From nobody Sat Nov 15 10:52:09 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1752497776; cv=none; d=zohomail.com; s=zohoarc; b=UOA6cZfOrF3/H9sjS+8tiF7B7Yy1Vd2jzTXwwGw/nHzMFCSnJAN02P+nYcUx36foE5bLwqUav89Fkg1aCdiyIurJdoSB724BwBqGt8NpJDwkAKL/yRAQ+c9EEkSH+03OkzwZy6KsDqeI6yMKxNYkTvpELY+KxcGesus838+2fos= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1752497776; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=8sj9iVmDpEf+chfg1RrFtaVPsqCvpCBDEdTqoin79mM=; b=ecj3M6M9eb31MjpUZB7krXkGZdXq7363Rk6WZrA7n56KydNID1LJb4IQnqRu/qqP/T7BrXbRNE2Zm6AmLCv5pqKrECfecykTwLKe3CgxLkGjGLzG4gpEDAL2dCZqgyC0jrqiBzo+lyR1eSvaJjtQTBdXcEm3MfJG3O0wKf/0pjU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1752497776528712.4567652455048; Mon, 14 Jul 2025 05:56:16 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ubIgK-0000rO-A5; Mon, 14 Jul 2025 08:53:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ubHtP-000772-QU for qemu-devel@nongnu.org; Mon, 14 Jul 2025 08:02:48 -0400 Received: from mail-ej1-x62d.google.com ([2a00:1450:4864:20::62d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ubHtL-0003rf-Hw for qemu-devel@nongnu.org; Mon, 14 Jul 2025 08:02:47 -0400 Received: by mail-ej1-x62d.google.com with SMTP id a640c23a62f3a-ae0dd7ac1f5so877734966b.2 for ; Mon, 14 Jul 2025 05:02:39 -0700 (PDT) Received: from draig.lan ([185.126.160.19]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ae6e829629dsm815882266b.138.2025.07.14.05.02.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Jul 2025 05:02:35 -0700 (PDT) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id C97CA5F89A; Mon, 14 Jul 2025 13:02:34 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1752494558; x=1753099358; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=8sj9iVmDpEf+chfg1RrFtaVPsqCvpCBDEdTqoin79mM=; b=xDp2P9MpUe6bevc0CQqbAs9mFOQFHNZxkmsiIfzN9PaWqRma7Qx0YPIR7TEqIV9VAS YrwZyM/EEfb/OxXkqRhWZ7dPkghieuBB532Q7sDBRYcJBLKuqOJrtqRoz+oQfBx71Upr v1dqACQtzsrolyHADkQOvsiOaJUJSXI5yfLr38X82/D4fnrrratU62NQAIZEIsx+7T6+ Z3tDxkvaaZAUbZjJkwptcm/z4tYR6G5PF09fXD/e6PPT9mCyT1WDjwa7BvRlYf0tgav2 7BIeHFtdWMC9ja/0Urn9AGCyxV6ABqfW07yU1KESZ0w2lW6OV2M5pGcut9WNdMU42wui 4vCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752494558; x=1753099358; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8sj9iVmDpEf+chfg1RrFtaVPsqCvpCBDEdTqoin79mM=; b=PaY2MNtVX7tTZGMQseCFED9HtP3mqRX9UnHYHvHiK2H2SsT89I/1Y0sXjHN7nZMTNQ +L3iUoz20+3an/XRypA6K1oLYxaJR7T3cSiMhLIBY3Z7NwyBItrsuaOJiYpSv8hCYfZQ JgUJcXH8vW+SgAZDsYkGfZJl0LTzVjHP42dQMsuz/AWohTM0tQJzqZr1r9qwDakkqd+N 0HGJtoBI3Q5AW8rGJ23nM4tAqqsmMOWpPbbal+gZngZr+3N7nM/qkBrhdRFpOvoNhfPs SOlygpkz9YoYrduetl0mLuzu4Vf2ij/WQFeguQE1Xhdt2JJnxo0iVzsHGt+lpiQQNs3x MlCA== X-Gm-Message-State: AOJu0YzNP7kKDiETFa0HLvA2z52veSZsOc0oLb81ZWkUkBmx5OCAHOs+ hp6B47CaV5isTI7SmxcbtjJZfcsg8JDPbS47o4vD+w+FfcsaHItRxdZ+fKphjFiDoi0= X-Gm-Gg: ASbGnctl7V6l3GtIpYlCbWXMFdiJdWeyWOTmt1KmuaW9TdNjQ9g5CWlyL2BxH+46l0v cxvcP5naMwj/dB+Q/INxSYDQYEXPSVkBzGMHQL7yMea6E2MFEI93DtJVvrVP4F+4ZpS9F+1KHua IcmNWk68GrfUWaehsqHRFZIHY9DUdvfPMa2Qjo9nZ7tr+vCeEYyYnr+7AOwff7cQduuAtvTrHXq zptFe4q5I1rGXvc+UwgE+4C45OVRdkLMeYtwLAnaiSr+bFqVMw5KVX2rdFcJfd+h/MG9uIWI73I Ky6NfT2n5CBjLVEDiUxELEdlVI7pWGutOAapk7dlOX4gI/uZh+wjo3HQymTjkXe/BYuFemtc1qA vAFlkNQ4LEaLU9n6GpQ7hqR0= X-Google-Smtp-Source: AGHT+IEVaGKdoJJic6qKtm9BhXBkLMSjcg4IVYuFlNOwRIJn+wLGGuc8I9PxmKQa1fJFCuwBau26WA== X-Received: by 2002:a17:907:bd94:b0:ae3:b2b7:7f2f with SMTP id a640c23a62f3a-ae6fc0f31demr1421381466b.40.1752494558362; Mon, 14 Jul 2025 05:02:38 -0700 (PDT) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Alex=20Benn=C3=A9e?= , Manos Pitsidianakis , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Thomas Huth Subject: [PULL 1/8] gitlab: use argparse in check-units script Date: Mon, 14 Jul 2025 13:02:27 +0100 Message-ID: <20250714120234.1524401-2-alex.bennee@linaro.org> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250714120234.1524401-1-alex.bennee@linaro.org> References: <20250714120234.1524401-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::62d; envelope-from=alex.bennee@linaro.org; helo=mail-ej1-x62d.google.com X-Spam_score_int: 12 X-Spam_score: 1.2 X-Spam_bar: + X-Spam_report: (1.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1752497778059116600 Modernise the argument parsing so we can easily add to the script. Reviewed-by: Manos Pitsidianakis Signed-off-by: Alex Benn=C3=A9e Message-ID: <20250710104531.3099313-2-alex.bennee@linaro.org> diff --git a/.gitlab-ci.d/check-units.py b/.gitlab-ci.d/check-units.py index 268a4118d5..cdc62ae5ee 100755 --- a/.gitlab-ci.d/check-units.py +++ b/.gitlab-ci.d/check-units.py @@ -8,8 +8,10 @@ # SPDX-License-Identifier: GPL-2.0-or-later =20 from os import access, R_OK, path -from sys import argv, exit +from sys import exit import json +import argparse +from pathlib import Path from collections import Counter =20 =20 @@ -51,16 +53,17 @@ def analyse_units(build_units): =20 =20 if __name__ =3D=3D "__main__": - if len(argv) !=3D 2: - script_name =3D path.basename(argv[0]) - print(f"Usage: {script_name} ") - exit(1) + parser =3D argparse.ArgumentParser( + description=3D"analyse number of build units in compile_commands.j= son") + parser.add_argument("cc_path", type=3DPath, default=3DNone, + help=3D"Path to compile_commands.json") + + args =3D parser.parse_args() =20 - cc_path =3D argv[1] - if path.isfile(cc_path) and access(cc_path, R_OK): - units =3D extract_build_units(cc_path) + if path.isfile(args.cc_path) and access(args.cc_path, R_OK): + units =3D extract_build_units(args.cc_path) analyse_units(units) exit(0) else: - print(f"{cc_path} doesn't exist or isn't readable") + print(f"{args.cc_path} doesn't exist or isn't readable") exit(1) --=20 2.47.2 From nobody Sat Nov 15 10:52:09 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1752498252; cv=none; d=zohomail.com; s=zohoarc; b=RuU/3tYQjpVr9+JrrhfOLPC5dN2w9IG11wIMK8SzPEBr38ZvtSm/f67Sddwx+oPOFE1d9xf1lvohtNoQAHr5ztDOA4DMp8/71lR2pV/56qLr3CWqzt6FPZ9oCMRSUQHym+Z8koOMF0qis1qRARkHEnyy/f2tMiU6XoFU2l9f4/w= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1752498252; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=QiZnRDIM6/kZEbxqRnf//fPQu15IWBfB/VoqA6cAXpE=; b=CwBYgnTAeDz+KvGk4VT5cfEWrPV+PgZm3UUX648gApzOlZIdRNaRHec3QdQi+xUIcjURcwOD3v/+BZEJm/SBVIME2jyhb6cT8N8nrM+Or3hIXW3v0GM5gTOsDP35kLprepd/HcKIFXHm/IzBZ3OwH3Mv/RqxeasUFosNiSzD9SY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1752498252140312.2917041046678; Mon, 14 Jul 2025 06:04:12 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ubIqN-0008HG-IJ; Mon, 14 Jul 2025 09:03:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ubHtN-00073X-P9 for qemu-devel@nongnu.org; Mon, 14 Jul 2025 08:02:46 -0400 Received: from mail-ed1-x52c.google.com ([2a00:1450:4864:20::52c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ubHtH-0003rU-Sq for qemu-devel@nongnu.org; Mon, 14 Jul 2025 08:02:45 -0400 Received: by mail-ed1-x52c.google.com with SMTP id 4fb4d7f45d1cf-60c9d8a169bso7463098a12.1 for ; Mon, 14 Jul 2025 05:02:38 -0700 (PDT) Received: from draig.lan ([185.126.160.19]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ae6e82645fdsm820902666b.97.2025.07.14.05.02.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Jul 2025 05:02:35 -0700 (PDT) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id DD19F5F89B; Mon, 14 Jul 2025 13:02:34 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1752494557; x=1753099357; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=QiZnRDIM6/kZEbxqRnf//fPQu15IWBfB/VoqA6cAXpE=; b=viZ8meUO60XoxjQeBoF1ccsZvF9KXuAusyfFdZrmariqjBUXvs2jyIZ43nC3RE0iHs uYRB0/RcUEtMZ/q3dO62YnfPs0AiRF3iehsJA+kxHDp12XhBNjKFEQx8e1ZriM+JFoDJ FPpOzw3LNEJlXi7wpwpCEt9fx3N13rsTaSZpBuSzQMrLImNyN2wcvW4siRIDzM4a4Xos t7lDYNJW15VcAvXIGS3LfoV834zsX6HoJoAH3+5CDQ1nE3+nz/me25ruQhhUTZTEGfF5 6ElHSRMDTpYcFvhUbkncZHnQx/aPzNcUpIYT6IyRSBWEfBFrYpVEyzJT/N7g9Jn7Rn5p YXBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752494557; x=1753099357; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=QiZnRDIM6/kZEbxqRnf//fPQu15IWBfB/VoqA6cAXpE=; b=l7vRFeV1b2WrKRogPxhgKsQcK1b4v3xAdLAgjRQVXGdWREtILYokW6r7aaB/OR0fju sO7Z1vdH4OkMplbUyKOT1+TKJKgWaWxw56sq9+iQToE0Fs/9OcQwTPNtx/MU/E9NS4oE 4MeQHQQLzpXK7IKrl37nEOWxrq5YMgqF9rEeardFZtnCwk2HnruFgNinOYuLS9O1czAl foD9YUv6o1jnpeAhJUSvcS/sbvk347k3HkMJSNJiJX/BZfjuqiaJA+p1Q01AZ64aY++1 rnZiVXqPUQPoV8aBjULOCl5AvFhOS5fZZ4hTqHuSScz2qz6AjSXwbb3HL/WSX3AZZBdI N0IQ== X-Gm-Message-State: AOJu0YwcklU+t2i8tOmAOyIC82j7iG6dJ9EjDh4/1rVwQD0mP9ji3CwI 1dV63J42hjFyxtYQHqVv4uihMHcm+2aVoZ4u83CqoBHQ0HT+qVIsXm6K+aGyByFuMRI= X-Gm-Gg: ASbGncvr1z7AbpVTm1y2mIjCgBu0mc4tZkKDFzVeK1TBB9OIKExWb4SiAIZBUgRGmrA WvBKIKEPu0l4OWCgMOR2AMA7Pp9/f9dQkgJwlqc36309D7cb/Z/OQaChTfnRVXR7mLZuFakYf+t Y+hl2F2OSmlqkKN2o5kVsXnU0c6le7JbAXQylN1wPCd4UVrp+Tn654a/X6SHlQL3C7OdDaC70az JI+vAdArL6py1CPAlhdSJT4wBKVvTLk+SKjykC6NS//xVfTrVTO+OP2jyrdn2X/p9cYjIJlfyX6 VjJOiV1UCE87U5EYu/vgVcxnpdDWz2HbOw8cqoqXila9074g+K6UImQxk8AgZppBxjRrdKyTSyb JZEW7Y/OLcJYeoMgsX/8gAGQ= X-Google-Smtp-Source: AGHT+IGe87kPbPhRwhjhjG8iP6popYMstJSM/pIvirnQQUVpwHchFlDLX8uNaln+LCbbd1pcAaRAKQ== X-Received: by 2002:a17:907:72cc:b0:ae3:ce75:afd8 with SMTP id a640c23a62f3a-ae6fca6d396mr1218906066b.30.1752494557091; Mon, 14 Jul 2025 05:02:37 -0700 (PDT) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Alex=20Benn=C3=A9e?= , Manos Pitsidianakis , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Thomas Huth Subject: [PULL 2/8] gitlab: add -n option to check-units script Date: Mon, 14 Jul 2025 13:02:28 +0100 Message-ID: <20250714120234.1524401-3-alex.bennee@linaro.org> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250714120234.1524401-1-alex.bennee@linaro.org> References: <20250714120234.1524401-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::52c; envelope-from=alex.bennee@linaro.org; helo=mail-ed1-x52c.google.com X-Spam_score_int: 12 X-Spam_score: 1.2 X-Spam_bar: + X-Spam_report: (1.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_SBL_CSS=3.335, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1752498253215116600 Mostly a developer aid for those who want to look at the full backlog of multiple build units. Reviewed-by: Manos Pitsidianakis Signed-off-by: Alex Benn=C3=A9e Message-ID: <20250710104531.3099313-3-alex.bennee@linaro.org> diff --git a/.gitlab-ci.d/check-units.py b/.gitlab-ci.d/check-units.py index cdc62ae5ee..cebef0e8be 100755 --- a/.gitlab-ci.d/check-units.py +++ b/.gitlab-ci.d/check-units.py @@ -30,7 +30,7 @@ def extract_build_units(cc_path): return build_units =20 =20 -def analyse_units(build_units): +def analyse_units(build_units, top_n): """ Analyse the build units and report stats and the top 10 rebuilds """ @@ -44,7 +44,7 @@ def analyse_units(build_units): reverse=3DTrue) =20 print("Most rebuilt units:") - for unit, count in sorted_build_units[:20]: + for unit, count in sorted_build_units[:top_n]: print(f" {unit} built {count} times") =20 print("Least rebuilt units:") @@ -57,12 +57,14 @@ def analyse_units(build_units): description=3D"analyse number of build units in compile_commands.j= son") parser.add_argument("cc_path", type=3DPath, default=3DNone, help=3D"Path to compile_commands.json") + parser.add_argument("-n", type=3Dint, default=3D20, + help=3D"Dump the top entries") =20 args =3D parser.parse_args() =20 if path.isfile(args.cc_path) and access(args.cc_path, R_OK): units =3D extract_build_units(args.cc_path) - analyse_units(units) + analyse_units(units, args.n) exit(0) else: print(f"{args.cc_path} doesn't exist or isn't readable") --=20 2.47.2 From nobody Sat Nov 15 10:52:09 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1752499171; cv=none; d=zohomail.com; s=zohoarc; b=KV9x1tMQgaajySKyZsanoOUjUw2BmoL1Z8MGLdEPTEP/pfnNHZ1PlLblYC8QhuS9OxdEUddg1KGZy2dwXHJtXUK3UC3byvRxf7LXPy/jKq+32Joabjotb0l8qXpSbpHwHkWzUYHGRe8aX+XBpftUdHEaRj9KakXLYaGtIVzyx9s= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1752499171; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=0FH07ylFIriqs3Ta+bo0GU0IZk1KRc8iHSIoU8TNWUw=; b=lA1NlCkNtZqBfKMN1ldcQO4UBGLcWvyx1rdtQtdM9jTcvwjXdp0atjP2qlz7ksuT9Hd0iyVDM3q5L93yLkZ0e40V0QBlA+SHLJKj7GPI9bWjzAGaTHRh2PJXK1YkbFBPeuhD6+CVBhsxcaQ2jgt7zkWqFs9hdUk1Km7ImytTMrg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1752499171913530.3852841095738; Mon, 14 Jul 2025 06:19:31 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ubJ4l-0000Td-Mj; Mon, 14 Jul 2025 09:18:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ubHtP-00076d-MR for qemu-devel@nongnu.org; Mon, 14 Jul 2025 08:02:48 -0400 Received: from mail-ej1-x630.google.com ([2a00:1450:4864:20::630]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ubHtK-0003rb-2z for qemu-devel@nongnu.org; Mon, 14 Jul 2025 08:02:46 -0400 Received: by mail-ej1-x630.google.com with SMTP id a640c23a62f3a-acb5ec407b1so754467766b.1 for ; Mon, 14 Jul 2025 05:02:39 -0700 (PDT) Received: from draig.lan ([185.126.160.19]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ae6e7e91bd0sm816420266b.33.2025.07.14.05.02.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Jul 2025 05:02:35 -0700 (PDT) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id F28435F8B4; Mon, 14 Jul 2025 13:02:34 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1752494558; x=1753099358; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=0FH07ylFIriqs3Ta+bo0GU0IZk1KRc8iHSIoU8TNWUw=; b=UIEFYOWrSjMRX1P4GaKFIA6BSLQXDIif7I4gJ/TFe5ngHZbXn+vRgQtOzYbwcwEjkx KXe0AJ7mA9d49NqDwORnKHZ8/UGAHJcpTZ/mhdXcT0TOYqJgZwo0/XknREq9zN8qpVJH HlKmtxwXOVRD2Gu1zI3s4TOoxiWfAvBIcKNNivoeXzffMB/pbiIOzjlE8G6N9aZM9ROb kIM02qlWblsGiJDPM0lzYVmWrGpMV8C/K8Ve1dN2hJSInkdkWqp3dRkn87F46q92xYkU eRliEIC5lKBhwNNLpSjP3bmfIriBcUkUDpzTdXeYYL4ldHSy9AiRiS/2oRMgDRTtzrEB pimg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752494558; x=1753099358; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0FH07ylFIriqs3Ta+bo0GU0IZk1KRc8iHSIoU8TNWUw=; b=VGVtq5Po5KbPQsLkaXhIwORZvbAY2IPFDi/ISYteYAev0SZIuZxAao+WbjJY5VnDZL oPif88vKpmu32PZz9urHv85/nZgSyWUAU9m7v7CCQFOpgeW98ln4gdqeH6f3fEzbD7Vk aQK9NNWyR9CbG5t3N/reVahrXDgGFrqnzXVCMZNhW386ISbYVCJlfiMs6MO9vuiCR8yj 1XwX0z0py/8BpTobIhHJYt6uuRkT19SwdLlTpuabnC0jx5omqc7faslSE6NrLESHIH6P tpFF9vPRwZ0jzz6WtnY/oCxw8wSlzirlGJSD3OSCS/AkGLMNDsuwfSGw4Y729U5lV3VI NTWQ== X-Gm-Message-State: AOJu0YxpJ8ydIqnPTFpEtLUbuh6mCjXp7QmpzrX3JQo66MmnqSH+o/U9 TOlmD044xAnknmbOPLzMwe1xtgAQ6nujY1NTtDz4kyUR/8kIk2WnVeNQcz15hcF/pcs= X-Gm-Gg: ASbGncuq93HLTzh+Eiq7iuut4Q0Qh2KjbXFDs/K2OcOfRRqy+yV5vRatMP5l5u/mRZ+ UdA2Zm9ZGo57MCWVToDvJFk8YYok75FSJlfpP1BRB6WOxcs0z/HNZwrMkzYmBg3yacXTH0RwUzW qAQ7UWiiqjsva2uD9/CCjtIbUGgpcHid6A6CqNwINkH67LX/QVtE2KCFalzkdic4Wg1s8qK/NJX bT7ls9p6XrXkUY6e59DZPHDZlS1SP9yiiXRQOC9jfOCMXi7zxXiSLvoIPb7JVHntMLxJF9/NWGb py82eUGxxhri+sOfN3a80PlIfqg54dzBEJQ3spOW/3eMlD++JqryJE90O7GIbmDHcmOAjVecXSM NKsK9WOimMilQzwsE/gHfnI8= X-Google-Smtp-Source: AGHT+IFqmxUVwrCdv3YHvpI8CCpf1lbAdOOgdg5eGegOEFuQM1qn7rYvfcbzrXweYGVNmQ7azC5cfg== X-Received: by 2002:a17:907:c885:b0:adf:f8f4:2001 with SMTP id a640c23a62f3a-ae6fc0da44cmr1315985766b.49.1752494557666; Mon, 14 Jul 2025 05:02:37 -0700 (PDT) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: Yodel Eldar , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Pierrick Bouvier , Alexandre Iooss , Mahmoud Mandour Subject: [PULL 3/8] contrib/plugins/execlog: Add tab to the separator search of insn_disas Date: Mon, 14 Jul 2025 13:02:29 +0100 Message-ID: <20250714120234.1524401-4-alex.bennee@linaro.org> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250714120234.1524401-1-alex.bennee@linaro.org> References: <20250714120234.1524401-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::630; envelope-from=alex.bennee@linaro.org; helo=mail-ej1-x630.google.com X-Spam_score_int: 12 X-Spam_score: 1.2 X-Spam_bar: + X-Spam_report: (1.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1752499174950116600 From: Yodel Eldar Currently, execlog searches for a space separator between the instruction mnemonic and operands, but some disassemblers, e.g. Alpha's, use a tab separator instead; this results in a null pointer being passed as the haystack in g_strstr during a subsequent register search, i.e. undefined behavior, because of a missing null check. This patch adds tab to the separator search and a null check on the result. Also, an affected pointer is changed to const. Lastly, a break statement was added to immediately terminate the register search when a user-requested register is found in the current instruction as a trivial optimization, because searching for the remaining requested registers is unnecessary once one is found. Suggested-by: Alex Benn=C3=A9e Signed-off-by: Yodel Eldar Message-ID: <20250630164124.26315-2-yodel.eldar@gmail.com> Reviewed-by: Pierrick Bouvier Signed-off-by: Alex Benn=C3=A9e Message-ID: <20250710104531.3099313-4-alex.bennee@linaro.org> diff --git a/contrib/plugins/execlog.c b/contrib/plugins/execlog.c index d67d010761..06ec76d6e9 100644 --- a/contrib/plugins/execlog.c +++ b/contrib/plugins/execlog.c @@ -232,12 +232,15 @@ static void vcpu_tb_trans(qemu_plugin_id_t id, struct= qemu_plugin_tb *tb) */ if (disas_assist && rmatches) { check_regs_next =3D false; - gchar *args =3D g_strstr_len(insn_disas, -1, " "); - for (int n =3D 0; n < all_reg_names->len; n++) { - gchar *reg =3D g_ptr_array_index(all_reg_names, n); - if (g_strrstr(args, reg)) { - check_regs_next =3D true; - skip =3D false; + g_auto(GStrv) args =3D g_strsplit_set(insn_disas, " \t", 2); + if (args && args[1]) { + for (int n =3D 0; n < all_reg_names->len; n++) { + const gchar *reg =3D g_ptr_array_index(all_reg_names, = n); + if (g_strrstr(args[1], reg)) { + check_regs_next =3D true; + skip =3D false; + break; + } } } } --=20 2.47.2 From nobody Sat Nov 15 10:52:09 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1752497670; cv=none; d=zohomail.com; s=zohoarc; b=DyJrVstZ5CZ/qLOe3P3F1cd8E6J0wEtBYXdgrppTx9AtT+kSg1uv3BvdpstjgJxrsCAfmtzHLW7UXy0HOn4bZJggGlxe+i6Yq26iu6JFw7WfLGqsxYNkkOcW9+oalk549gOt6mETFnDzeEvKQwBO3JOenWhs9C4b+FbHQUloDu4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1752497670; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=1ozVO0uoJM0OXPZbYH/ZJiA5dv6J079bm06qMcPaKi4=; b=CEG07z5QAuC0IuBhkgdbmDPgdat3GnxYCBvfN7IdP3galHamghcyUSUBMYPGiI5L1B8+iu43WpL+Fk+b8WPZNJUorwKI4YjjnrDMujHGWTDEthHY7AQp0zg1xDbVCkMtG9hkQNNQwTWJJGGGnCyI+pUoVb+V4lgAa57QGAwCF2g= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1752497670538861.2948014266882; Mon, 14 Jul 2025 05:54:30 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ubIgc-0000xy-Qu; Mon, 14 Jul 2025 08:53:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ubHtT-0007A3-5s for qemu-devel@nongnu.org; Mon, 14 Jul 2025 08:02:53 -0400 Received: from mail-lf1-x134.google.com ([2a00:1450:4864:20::134]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ubHtL-0003ru-VI for qemu-devel@nongnu.org; Mon, 14 Jul 2025 08:02:49 -0400 Received: by mail-lf1-x134.google.com with SMTP id 2adb3069b0e04-5562838ce68so3848443e87.2 for ; Mon, 14 Jul 2025 05:02:41 -0700 (PDT) Received: from draig.lan ([185.126.160.19]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-611fe587b72sm3976964a12.70.2025.07.14.05.02.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Jul 2025 05:02:36 -0700 (PDT) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id 1786C5F8B5; Mon, 14 Jul 2025 13:02:35 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1752494560; x=1753099360; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=1ozVO0uoJM0OXPZbYH/ZJiA5dv6J079bm06qMcPaKi4=; b=UJyjcL7x9Y9bTmiVikjTXW2idZGOyTv4fdCtzI+mWZzBldNf87fktFfKUSRgDYCtYJ Q52JHFTPDW12Xf90mJVpd+W7uwZhaHJFMXwTDHZcXa4IGmT2ZHAQ1Hxg1oPhPQKTP4rH r2BL3OzDKyTwoN3EOr7kwu+YLKfhb+iNHo4KE1ExZ+/zUhzNnPg1cdbAAlbdEujI/eiV Ybb5WJoQjR3L3zS6XAHL9tflmINi9LtUyBRthZssFqKFGg1F3a6R/tA3eq1nz8q0PLQO kaECnqJ7PF5WdZZxpejcgasejAO1EgnyA4sxgGWKTM2dPbPipDVsM0zjuEKTG5Z51P3H RIIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752494560; x=1753099360; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1ozVO0uoJM0OXPZbYH/ZJiA5dv6J079bm06qMcPaKi4=; b=K2kPxKJbrx2Eitg+2m4ld6ZYo78WMaJtDwLVmEN8xrICKw6dBrjYmMwu5xEQ5+akbp 6CBEspphfHJgctDVBCr5qZzHCwgzQaCh/t520Ehz45Sv8w7igi4EMEIXSNW9aDdJA9+L J+bqVTPEI5IYNE/cZpI/Yrrk4XdlEvAz+DF0/N4awjv44JOLxFhZkKTN9o7LqSzAwmch XNIjOA9Rd8/WehDH7NKIWoVX0S4g0n8RjPNA3elIW/VYmRJwuAUg6d2QJtS0BJawZp42 hqt6N7s2TXMaK4qIPVvJuxPJQB8Eplm9V99IxwPRQV2UsFcyf6n1bqmplzK4KlzpQ7SL /maA== X-Gm-Message-State: AOJu0YwIcW670PNu7xGWPTZSEKPlrs3XQbu0Sy0dB7Z5eO0Q+GIi5eHC YpUOShp3sXdn3mM1jNkGXnBCqG6RC+vnXN0CboD0NN2I2m7Vnvf/Wu4hpex+Nu1yuyI= X-Gm-Gg: ASbGnctggK+0xZbmx49KwyZi4I75+6sxF210fheqTN9DWkYMUH0O0HhUSJkU2xLe/oI K9bgN4GlFo4VDqnuDT29lanAASL04edQdekU+eEju1rsh+YBSB0xGBnSvdhzDq8Q4AXQ5MZ/mvM 8g2JYXWUGOVOccsSvGiLodwdd1kYczgyHsOgae7OwsTPRFJ88tGfkYs4tBNV1idSuUgGzfKnoVN gOtz6btb/C3+ughvdMOmVqoA57wL6On/JaT/jdN79tltFYH+wT3UfElkTaL943blGxy0Ffg/EXh Cx4BSDHd7/BBaxl3tCIZlWJWwU70H+1ntZipeLPtEOhEcnwyTkcOh9wq2FdjfdVuIUeHUIaw5p7 42h8tfzaiHb2ZM6hAKa7FjVU= X-Google-Smtp-Source: AGHT+IGoKAn2L1CroYUIibl3Ukx9AvYvLSNs1Hzv9peV3PCOSDwyutav7XR87lYZ1HQFvN7Rq2Wzfg== X-Received: by 2002:a05:6512:4017:b0:553:aa2d:1af5 with SMTP id 2adb3069b0e04-55a044c96d8mr3767014e87.8.1752494559314; Mon, 14 Jul 2025 05:02:39 -0700 (PDT) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: Yodel Eldar , Richard Henderson , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Laurent Vivier , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PULL 4/8] target/alpha: Add GDB XML feature file Date: Mon, 14 Jul 2025 13:02:30 +0100 Message-ID: <20250714120234.1524401-5-alex.bennee@linaro.org> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250714120234.1524401-1-alex.bennee@linaro.org> References: <20250714120234.1524401-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::134; envelope-from=alex.bennee@linaro.org; helo=mail-lf1-x134.google.com X-Spam_score_int: 12 X-Spam_score: 1.2 X-Spam_bar: + X-Spam_report: (1.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1752497673241116600 From: Yodel Eldar This patch adds the GDB XML feature file that describes Alpha's core registers. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2569 Reviewed-by: Richard Henderson Signed-off-by: Yodel Eldar Message-ID: <20250630164124.26315-3-yodel.eldar@gmail.com> Signed-off-by: Alex Benn=C3=A9e Message-ID: <20250710104531.3099313-5-alex.bennee@linaro.org> diff --git a/configs/targets/alpha-linux-user.mak b/configs/targets/alpha-l= inux-user.mak index ef8e365b09..aa25766236 100644 --- a/configs/targets/alpha-linux-user.mak +++ b/configs/targets/alpha-linux-user.mak @@ -2,3 +2,4 @@ TARGET_ARCH=3Dalpha TARGET_SYSTBL_ABI=3Dcommon TARGET_SYSTBL=3Dsyscall.tbl TARGET_LONG_BITS=3D64 +TARGET_XML_FILES=3D gdb-xml/alpha-core.xml diff --git a/configs/targets/alpha-softmmu.mak b/configs/targets/alpha-soft= mmu.mak index 5275076e50..e31f059a52 100644 --- a/configs/targets/alpha-softmmu.mak +++ b/configs/targets/alpha-softmmu.mak @@ -1,2 +1,3 @@ TARGET_ARCH=3Dalpha TARGET_LONG_BITS=3D64 +TARGET_XML_FILES=3D gdb-xml/alpha-core.xml diff --git a/target/alpha/cpu.c b/target/alpha/cpu.c index 2082db45ea..bf1787a69d 100644 --- a/target/alpha/cpu.c +++ b/target/alpha/cpu.c @@ -286,6 +286,7 @@ static void alpha_cpu_class_init(ObjectClass *oc, const= void *data) cc->get_pc =3D alpha_cpu_get_pc; cc->gdb_read_register =3D alpha_cpu_gdb_read_register; cc->gdb_write_register =3D alpha_cpu_gdb_write_register; + cc->gdb_core_xml_file =3D "alpha-core.xml"; #ifndef CONFIG_USER_ONLY dc->vmsd =3D &vmstate_alpha_cpu; cc->sysemu_ops =3D &alpha_sysemu_ops; diff --git a/gdb-xml/alpha-core.xml b/gdb-xml/alpha-core.xml new file mode 100644 index 0000000000..c9e12f4ffd --- /dev/null +++ b/gdb-xml/alpha-core.xml @@ -0,0 +1,136 @@ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + --=20 2.47.2 From nobody Sat Nov 15 10:52:09 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1752498252; cv=none; d=zohomail.com; s=zohoarc; b=Gq3IUfnH7JAa/x54wuhVhoiKG0+ya85sbHm0NcgmJAimRjaPN75SZKD7xAfZ+FhcqU4HMbzPJ8+NsULdFQpmSSnq3yP93zj4WLffP+65djWSGdgp8VutCF/EPCDqPdIX5nutSTMXqAbBdtbi3VvW5hsRTJg8QnxB4eRVh3IOqn4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1752498252; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=BiRpZlbPIOoFEj6iYHlDTcy2zJQpuVJMb5R6Mh4QsuA=; b=Shn1OgvOPHh4lUjJgWE9ZznZPP2RT9vcDdPbmyHv2R2n1ETJP+k4dtr8bCgioXpAvqH4MbrN/ea06EGIx7h97ak4CwW1HPmqMCuim3Qlp8QujljdyJVK66sSe4imAL5hYOOA19L6HD5b/KDgXXWysVMyLBCC0oxfjaQ7uz4ifig= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1752498252066865.7151849373109; Mon, 14 Jul 2025 06:04:12 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ubIqP-0008JU-6c; Mon, 14 Jul 2025 09:03:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ubHtT-0007AF-Oj for qemu-devel@nongnu.org; Mon, 14 Jul 2025 08:02:53 -0400 Received: from mail-ed1-x52b.google.com ([2a00:1450:4864:20::52b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ubHtM-0003rz-80 for qemu-devel@nongnu.org; Mon, 14 Jul 2025 08:02:51 -0400 Received: by mail-ed1-x52b.google.com with SMTP id 4fb4d7f45d1cf-6088d856c6eso7909881a12.0 for ; Mon, 14 Jul 2025 05:02:42 -0700 (PDT) Received: from draig.lan ([185.126.160.19]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ae6e7c09dfdsm808837366b.0.2025.07.14.05.02.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Jul 2025 05:02:39 -0700 (PDT) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id 329E75F8BD; Mon, 14 Jul 2025 13:02:35 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1752494560; x=1753099360; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=BiRpZlbPIOoFEj6iYHlDTcy2zJQpuVJMb5R6Mh4QsuA=; b=bI/DJ+3Q/T1Mkm25lHY35VWamh4iI+Ms3BAvO8yZpfdbIk13qcPZ9jZlWMB62wsoNq LU8aVtp+ZBoN/XWj0/uxxK204Sv2NfQBOLmn1pVDsvlYG9pktmE5FLIEcOCCeVBD81c7 wJBDTk4JaewhzGed1OK4KFMwOQO8AS+Gr6TmffrFd6L45EiZ0tFuwXUrkYmcZMrzNdPb +fgtFLuAfn80IFTnrYV///Uab4NmG1o9op8lxvS0LWqfNgjI18M97dorwl5vthoCMfJE BBwhybarT0vrQu8opSoO0R2Hpa4VXFsErE58i4tmeeCBqg/1BLQekJGxZfNRpXbiVWEY zUXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752494560; x=1753099360; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BiRpZlbPIOoFEj6iYHlDTcy2zJQpuVJMb5R6Mh4QsuA=; b=d+vZCUXnzu5AwRraqpuwbJ3l+rXb1JGD+K9EZtMQx6u6YKr6JPabtskxtnMaT1Fyqk KZZ34UUWpcLxa0yfZnAj9QcdtjZ9WfJaT1XIEqhho6jZ34snc/lyzelw3kYS96m13iNV N1MZJzRbqEC0DPWR327LDcOf3wR8PVJ/1GJtPfcgPpvG5pBd4rLgmwZhPPtfnlHiqBMV xbHxdq+hG8kLJCmuUuInNRk86uOeeiscHWDjqL3uUF2kO52ffTfcOSYLcjON5alBpSCK h7UU5e64Jc4pz4V6qN7bAe1jk7oN4qV67Kvr4uQHm2VVAPrvKlw20E6oLV0R60PgCtmR b+BA== X-Gm-Message-State: AOJu0YyC1UYy1EWZOnpfj5YnlYJtzbftuMGvwoOGJ5ZPaTwEuHOmt51C NDqK7niwUF6TI4LHL4MhZBQKp/2DhTXD3OBjSdTqwBntp/AEpIZP33Of2dGLPX28LmmkmueKo39 gLwnXlnE= X-Gm-Gg: ASbGncvVpu4j8bWR1HYpgLgYHF417G3gtWp2WKSIEJbhw6N6pvJ+9U0ko2O7/DWu1vv MWpaLxA4atEljbLonSyUFLaKe42Ln05QonoKNKnktijb3SIBLrqkXx1l8Xmultygj8HGT6348oq OGq8SKheZdnK0ckPXfUnz6n0+S7PwyR9gdhcmaU9Q8KQHaD5xVkE6YY3nH51V9XPbxJJb9WgQl5 Y6BhhoTbqZSPx5GXkA/LPXlA60jbefTkbIqsWlrpSEKBOyQ4A+Yk32P+kFKYJP2fd8RfDJwlMHb 30YLCg4ZLLa+l8CL4VNf0MitmXIkGceFAcmF89XNCwWu3Et46wErUrNQZ9MyIsRlAF8I0ltXsJ+ J1YER1ZB0pvDlAZogaojeUMk= X-Google-Smtp-Source: AGHT+IGK/sG2ZiphqscgNya2lAFzsfFtfraCLdcqgYqXGnm4qrQbv3ArBGB/KEENND9VqorKPcamnw== X-Received: by 2002:a17:907:9715:b0:ae3:b654:165b with SMTP id a640c23a62f3a-ae70117eb3cmr1149381166b.24.1752494560130; Mon, 14 Jul 2025 05:02:40 -0700 (PDT) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Alex=20Benn=C3=A9e?= , Pierrick Bouvier , Riku Voipio , Laurent Vivier Subject: [PULL 5/8] plugins: fix inclusion of user-mode APIs Date: Mon, 14 Jul 2025 13:02:31 +0100 Message-ID: <20250714120234.1524401-6-alex.bennee@linaro.org> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250714120234.1524401-1-alex.bennee@linaro.org> References: <20250714120234.1524401-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::52b; envelope-from=alex.bennee@linaro.org; helo=mail-ed1-x52b.google.com X-Spam_score_int: 12 X-Spam_score: 1.2 X-Spam_bar: + X-Spam_report: (1.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1752498253356116600 In 903e870f24 (plugins/api: split out binary path/start/end/entry code) we didn't actually enable the building of the new plugin helper. However this was missed because only contrib plugins like drcov actually used the helpers. With that fixed we discover we also need some more includes to be able to extract the relevant data from TaskState. Fixes: 903e870f24 (plugins/api: split out binary path/start/end/entry code) Resolves: https://gitlab.com/qemu-project/qemu/-/issues/3014 Reviewed-by: Pierrick Bouvier Signed-off-by: Alex Benn=C3=A9e Message-ID: <20250710104531.3099313-6-alex.bennee@linaro.org> diff --git a/linux-user/plugin-api.c b/linux-user/plugin-api.c index 66755df526..8d6fbb60e0 100644 --- a/linux-user/plugin-api.c +++ b/linux-user/plugin-api.c @@ -12,4 +12,5 @@ =20 #include "qemu/osdep.h" #include "qemu.h" +#include "loader.h" #include "common-user/plugin-api.c.inc" diff --git a/common-user/plugin-api.c.inc b/common-user/plugin-api.c.inc index 5b8a1396b6..63f3983271 100644 --- a/common-user/plugin-api.c.inc +++ b/common-user/plugin-api.c.inc @@ -13,6 +13,7 @@ #include "qemu/osdep.h" #include "qemu/main-loop.h" #include "qemu/plugin.h" +#include "accel/tcg/vcpu-state.h" #include "qemu.h" =20 /* diff --git a/linux-user/meson.build b/linux-user/meson.build index f47a213ca3..efca843369 100644 --- a/linux-user/meson.build +++ b/linux-user/meson.build @@ -27,7 +27,10 @@ linux_user_ss.add(libdw) linux_user_ss.add(when: 'TARGET_HAS_BFLT', if_true: files('flatload.c')) linux_user_ss.add(when: 'TARGET_I386', if_true: files('vm86.c')) linux_user_ss.add(when: 'CONFIG_ARM_COMPATIBLE_SEMIHOSTING', if_true: file= s('semihost.c')) -linux_user_ss.add(when: 'CONFIG_TCG_PLUGINS', if_true: files('plugin-api.c= ')) + +if get_option('plugins') + linux_user_ss.add(files('plugin-api.c')) +endif =20 syscall_nr_generators =3D {} =20 --=20 2.47.2 From nobody Sat Nov 15 10:52:09 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1752497672; cv=none; d=zohomail.com; s=zohoarc; b=hsI8EIbnUyISSSA352rPeYG+ThzpD/nF+/2tCN4OANHzIgNqRaUMBpoyLRigLrFvYf9qe95xBUQO9HSak0HS9OL86cTsNbAPCjwxyRr4Yf+1oywfSNj6ri/GlHH0dSZLJBjViiO6LH0cEXAHrHgFoQIg/hUYvGTjwkcBe0IpEcw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1752497672; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=6OYoWcuxiMWJ8Rae1ld8RgNow2XtJPy/ataGh1UigGU=; b=LVup1Ao06kgLPf7eNYA18SpC/kSe9E0C9Z57u8rc3pmU/ZnH9RQa6ul7lygMgCysV37Tqo6hMOLd0yMWqMKHwE0DMQ/ajKU1MS33qXENcc/NOg20s7koTTZbZNCdYslNzm0Migot19pHI68hpZfc/PQexggV5QnDqKIBuXF/hvQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1752497672818986.2990643977378; Mon, 14 Jul 2025 05:54:32 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ubIgf-0000zC-EX; Mon, 14 Jul 2025 08:53:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ubHtT-0007AC-4D for qemu-devel@nongnu.org; Mon, 14 Jul 2025 08:02:54 -0400 Received: from mail-ed1-x52c.google.com ([2a00:1450:4864:20::52c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ubHtL-0003s9-42 for qemu-devel@nongnu.org; Mon, 14 Jul 2025 08:02:50 -0400 Received: by mail-ed1-x52c.google.com with SMTP id 4fb4d7f45d1cf-60c60f7eeaaso6523372a12.0 for ; Mon, 14 Jul 2025 05:02:42 -0700 (PDT) Received: from draig.lan ([185.126.160.19]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ae6e82df641sm818261266b.170.2025.07.14.05.02.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Jul 2025 05:02:39 -0700 (PDT) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id 4E6B55F8C8; Mon, 14 Jul 2025 13:02:35 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1752494561; x=1753099361; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=6OYoWcuxiMWJ8Rae1ld8RgNow2XtJPy/ataGh1UigGU=; b=ZEuPsEXsLtcfH3qe0tVRcxTSUONppqNKPFGwVNxNmqgHFuWM+J4PbxTht8Q+v4lZL5 7HMUoQYy4Fy9Ka4jvZv8Wu/Jawhu2EeCzcwnok5lJaR7RTutK94QLZkruzf+AeORfE/0 qg5AKVN9R1zwG98IZCpLpqorLq9XiFx175uV6qxkJDiJ7tQkzPnE7IrccKyJDR9miWKw sk1DPw4RlXPnutNj0lJqDnoydowrScj8VMKCqLynikcc5wh4B6ucW/HTj6wlkj6cRvKU wtFGe+G2vOgz5eBK6/Inwk+ONMQ2gmXxVOEUth4mVY5sZ27C1zn/pP0oMLWVWRF8SI6k xxzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752494561; x=1753099361; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6OYoWcuxiMWJ8Rae1ld8RgNow2XtJPy/ataGh1UigGU=; b=KhWMib2UGV9r8pQ/TbxDWi22n7G+RIvwKDBo9hiE95h1nyxPf86vS2O41G7r2MA/zL dAYlDrtFTYrVoKGZ+cE8h3XHlDQNWnGMBJhKhrgpHu08DNdjyXHQEj7TLn+WbPPXhBK0 909pfuLbBq/7Jp/e6xculd1NpovRFTXfVAxrG4sLoaNBnBUJWuWzjgH0OvVZbtrymn8X gz/RWgAxe3TzntJNy8yoBhS3J3f52GO4bpojJLqtMqNpW7f5wbfoCBvbB1be39zjRcyh A47jaVTFUUx6YzP7e5QNDKc+g/wHGy8dlpsmO2gIiiLLLmJMkLd0yKdIb4T4uVOt9xR2 FO0g== X-Gm-Message-State: AOJu0Ywwuwdeg1xKF92h7WkTZOVEOtDoJF2UbzNHCY+ecX3eN5+JHlSo PHP5wcZg29MCiukfA00pDoqFfzuiyGhfgPQgKjemAOeaMQaO+fsztS27i16A8+WBk2U= X-Gm-Gg: ASbGncseZAKcBuPN/UY6jSLnSOh9paVqm2DlZ3eFX8bLNN3rfohvo4altg/ZsvjAdzC zz/5Peb/Fd2J2x2Q9Nf8YjSsPo6NZtz1HjuME1IDBiDtu+zHAnjxu4KsDO7YQA/HDWYCJR7gKlM u2II98kjhsBfs0cBd1+F51I9v6jGNjqo1cWEQSX4FGdTZydmP3o/Ox6gWl+VfItzCVwfcwCfkrG dlHpYtl6IgRFekZh3664/mGQjxomyfyJf8EJadI+Jnv8cBgQ68LErW3DE7hDi80HUsjcZUQD35f 8A/EhWXemUYTDexkrSOkkgNTWxxx1LwwZtuEcldFQ+51+tRgyqOCF9sgOo8pSIZnO59XiIMc363 yCftV+QE31hz4MQYpYZJCoNJMC23hkR+Qfg== X-Google-Smtp-Source: AGHT+IHTjnP1EwGeIENOfxAxmDLF0XL0xxOUUZIf8lTb9DHWxYwkM7kSbjdJ28WukOqZnwaSEqCZBA== X-Received: by 2002:a17:907:3da3:b0:ae0:b46b:decd with SMTP id a640c23a62f3a-ae6fbf7143cmr1357447866b.31.1752494560980; Mon, 14 Jul 2025 05:02:40 -0700 (PDT) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: Manos Pitsidianakis , =?UTF-8?q?Alex=20Benn=C3=A9e?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Thomas Huth Subject: [PULL 6/8] docs: use :kbd: role in sphinx docs Date: Mon, 14 Jul 2025 13:02:32 +0100 Message-ID: <20250714120234.1524401-7-alex.bennee@linaro.org> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250714120234.1524401-1-alex.bennee@linaro.org> References: <20250714120234.1524401-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::52c; envelope-from=alex.bennee@linaro.org; helo=mail-ed1-x52c.google.com X-Spam_score_int: 12 X-Spam_score: 1.2 X-Spam_bar: + X-Spam_report: (1.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_NONE=0.001, T_SPF_TEMPERROR=0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1752497675078116600 From: Manos Pitsidianakis Sphinx supports the :kbd: role for notating keyboard input. They get formatted as HTML elements in the readthedocs theme we currently use for Sphinx. Besides the better visual formatting, it also helps with accessibility as screen readers can announce the semantics of the element to the user. Signed-off-by: Manos Pitsidianakis Message-ID: <20250709-docs_rst_improvements-v2-1-cb5096ad0022@linaro.org> Signed-off-by: Alex Benn=C3=A9e Message-ID: <20250710104531.3099313-7-alex.bennee@linaro.org> diff --git a/docs/devel/testing/main.rst b/docs/devel/testing/main.rst index 6b18ed875c..2b5cb0c148 100644 --- a/docs/devel/testing/main.rst +++ b/docs/devel/testing/main.rst @@ -604,9 +604,9 @@ below steps to debug it: 2. Add "V=3D1" to the command line, try again, to see the verbose output. 3. Further add "DEBUG=3D1" to the command line. This will pause in a shell= prompt in the container right before testing starts. You could either manually - build QEMU and run tests from there, or press Ctrl-D to let the Docker + build QEMU and run tests from there, or press :kbd:`Ctrl+d` to let the = Docker testing continue. -4. If you press Ctrl-D, the same building and testing procedure will begin= , and +4. If you press :kbd:`Ctrl+d`, the same building and testing procedure wil= l begin, and will hopefully run into the error again. After that, you will be droppe= d to the prompt for debug. =20 diff --git a/docs/system/images.rst b/docs/system/images.rst index a5551173c9..43706969fd 100644 --- a/docs/system/images.rst +++ b/docs/system/images.rst @@ -30,7 +30,7 @@ Snapshot mode If you use the option ``-snapshot``, all disk images are considered as read only. When sectors in written, they are written in a temporary file created in ``/tmp``. You can however force the write back to the raw -disk images by using the ``commit`` monitor command (or C-a s in the +disk images by using the ``commit`` monitor command (or :kbd:`Ctrl+a s` in= the serial console). =20 .. _vm_005fsnapshots: diff --git a/docs/system/keys.rst.inc b/docs/system/keys.rst.inc index 59966a3fe7..c28ae1a227 100644 --- a/docs/system/keys.rst.inc +++ b/docs/system/keys.rst.inc @@ -1,36 +1,37 @@ During the graphical emulation, you can use special key combinations from -the following table to change modes. By default the modifier is Ctrl-Alt +the following table to change modes. By default the modifier is :kbd:`Ctrl= +Alt` (used in the table below) which can be changed with ``-display`` suboption ``mod=3D`` where appropriate. For example, ``-display sdl, -grab-mod=3Dlshift-lctrl-lalt`` changes the modifier key to Ctrl-Alt-Shift, -while ``-display sdl,grab-mod=3Drctrl`` changes it to the right Ctrl key. +grab-mod=3Dlshift-lctrl-lalt`` changes the modifier key to :kbd:`Ctrl+Alt+= Shift`, +while ``-display sdl,grab-mod=3Drctrl`` changes it to the right :kbd:`Ctrl= ` key. =20 -Ctrl-Alt-f - Toggle full screen +.. list-table:: Multiplexer Keys + :widths: 10 90 + :header-rows: 1 =20 -Ctrl-Alt-+ - Enlarge the screen + * - Key Sequence + - Action =20 -Ctrl-Alt\-- - Shrink the screen + * - :kbd:`Ctrl+Alt+f` + - Toggle full screen =20 -Ctrl-Alt-u - Restore the screen's un-scaled dimensions + * - :kbd:`Ctrl+Alt++` + - Enlarge the screen =20 -Ctrl-Alt-n - Switch to virtual console 'n'. Standard console mappings are: + * - :kbd:`Ctrl+Alt+-` + - Shrink the screen =20 - *1* - Target system display + * - :kbd:`Ctrl+Alt+u` + - Restore the screen's un-scaled dimensions =20 - *2* - Monitor + * - :kbd:`Ctrl+Alt+n` + - Switch to virtual console 'n'. Standard console mappings are: =20 - *3* - Serial port + - *1*: Target system display + - *2*: Monitor + - *3*: Serial port + * - :kbd:`Ctrl+Alt+g` + - Toggle mouse and keyboard grab. =20 -Ctrl-Alt-g - Toggle mouse and keyboard grab. - -In the virtual consoles, you can use Ctrl-Up, Ctrl-Down, Ctrl-PageUp and -Ctrl-PageDown to move in the back log. +In the virtual consoles, you can use :kbd:`Ctrl+Up`, :kbd:`Ctrl+Down`, :kb= d:`Ctrl+PageUp` and +:kbd:`Ctrl+PageDown` to move in the back log. diff --git a/docs/system/linuxboot.rst b/docs/system/linuxboot.rst index 2328b4a73d..f7573ab80a 100644 --- a/docs/system/linuxboot.rst +++ b/docs/system/linuxboot.rst @@ -26,5 +26,5 @@ virtual serial port and the QEMU monitor to the console w= ith the |qemu_system| -kernel bzImage -drive file=3Drootdisk.img,format=3Draw \ -append "root=3D/dev/sda console=3DttyS0" -nographic =20 -Use Ctrl-a c to switch between the serial console and the monitor (see +Use :kbd:`Ctrl+a c` to switch between the serial console and the monitor (= see :ref:`GUI_keys`). diff --git a/docs/system/mux-chardev.rst.inc b/docs/system/mux-chardev.rst.= inc index 84ea12cbf5..c87ba31362 100644 --- a/docs/system/mux-chardev.rst.inc +++ b/docs/system/mux-chardev.rst.inc @@ -1,27 +1,33 @@ During emulation, if you are using a character backend multiplexer (which is the default if you are using ``-nographic``) then several commands are available via an escape sequence. These key sequences all -start with an escape character, which is Ctrl-a by default, but can be +start with an escape character, which is :kbd:`Ctrl+a` by default, but can= be changed with ``-echr``. The list below assumes you're using the default. =20 -Ctrl-a h - Print this help +.. list-table:: Multiplexer Keys + :widths: 20 80 + :header-rows: 1 =20 -Ctrl-a x - Exit emulator + * - Key Sequence + - Action =20 -Ctrl-a s - Save disk data back to file (if -snapshot) + * - :kbd:`Ctrl+a h` + - Print this help =20 -Ctrl-a t - Toggle console timestamps + * - :kbd:`Ctrl+a x` + - Exit emulator =20 -Ctrl-a b - Send break (magic sysrq in Linux) + * - :kbd:`Ctrl+a s` + - Save disk data back to file (if -snapshot) =20 -Ctrl-a c - Rotate between the frontends connected to the multiplexer (usually - this switches between the monitor and the console) + * - :kbd:`Ctrl+a t` + - Toggle console timestamps =20 -Ctrl-a Ctrl-a - Send the escape character to the frontend + * - :kbd:`Ctrl+a b` + - Send break (magic sysrq in Linux) + + * - :kbd:`Ctrl+a c` + - Rotate between the frontends connected to the multiplexer (usually t= his switches between the monitor and the console) + + * - :kbd:`Ctrl+a Ctrl+a` + - Send the escape character to the frontend --=20 2.47.2 From nobody Sat Nov 15 10:52:09 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1752498291; cv=none; d=zohomail.com; s=zohoarc; b=UzZ41wmljwECGbclCMXzRoaqHmVymiDRQg5IeItDRoy+vAQtjd/eJd72UL96zKo6k1bEERhzV6SIKrlSkULZxxoV6pGg9B2NoYvoPb1ZKlyhqZrMoHGPYNHgtx8VsYJe1BttaiTuy2MNb3Qq4Qi+8X6YJRvOTnXMipuXAYiQRfU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1752498291; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=06ZP4ZDu9vIhxk8EIV8KfupaXCncTXZydCAzmathYzw=; b=FL9SuRkNk0Kh77HIAd3PqTrM74a4vZ84ui5vWs0qjNJrhI0QeLInVCO46DcTT25o0/Oc8Et7dIZpAoova4Q2cwTOuRZyNiOB0m6mBtjpDEu2a+PGOUF1KUXUaoJ3umt9So8NO4rS9Jy0tZbuzK3JuHdPjF95uwpNnog4xq35CeM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1752498277116100.61291693039914; Mon, 14 Jul 2025 06:04:37 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ubIqT-0008NS-Tz; Mon, 14 Jul 2025 09:03:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ubHtZ-0007OG-Et for qemu-devel@nongnu.org; Mon, 14 Jul 2025 08:02:57 -0400 Received: from mail-ed1-x52f.google.com ([2a00:1450:4864:20::52f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ubHtN-0003sJ-6y for qemu-devel@nongnu.org; Mon, 14 Jul 2025 08:02:55 -0400 Received: by mail-ed1-x52f.google.com with SMTP id 4fb4d7f45d1cf-60c6fea6742so8252251a12.1 for ; Mon, 14 Jul 2025 05:02:43 -0700 (PDT) Received: from draig.lan ([185.126.160.19]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ae6e7ee4547sm819767366b.61.2025.07.14.05.02.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Jul 2025 05:02:39 -0700 (PDT) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id 628765F8D5; Mon, 14 Jul 2025 13:02:35 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1752494562; x=1753099362; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=06ZP4ZDu9vIhxk8EIV8KfupaXCncTXZydCAzmathYzw=; b=PWMZGXdF+yO/fBZaZjoY9ZkqX000Xa6W3MDUlhJhUylldI1DrO8N+9Oec7wQmwUqzQ I8GnkS6hxBkzdNi/5omFbhtIqLcpS76Tm/7WqlVMsmNRM1zG1VmB3HcXSErgey5n6oOB D5ibs75yiggPhQVcA/Gipf+GBvCX5SrjcXMo8XVPwoFQgmS/h6KWNwwXqYdohglSQBx2 eYFgsZ04w/0qgql7vsKrGn9H5ZMuOQ4EU7vGecUOrqxZ/i5EBDnJDWoOH2r0PBF2nFYg zRYinDeLFBZLrsh6TllzESx8jdSfI8DUPiQFdc3UhI5ONijFnTEaNEbfwgA/BRiR2HNU vzAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752494562; x=1753099362; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=06ZP4ZDu9vIhxk8EIV8KfupaXCncTXZydCAzmathYzw=; b=bPrIn4LNUHZPVHIuEr+BlP5aOqsej0gqwr11souuXRuFt9EUFd70/ct0xQAdPqYEpn G2w2QCCwyb3ZIrNQgwhZfzzOhujTt9lnodZXrbUi332fArVLBsdnk0cjojRS64jqeN6P PIyRTqACOBzD3oo+ekdigVkDnw6LoipQfOo80mK8us2+uXJcC8CilAx4RX1VyEqCGL8q s1abf2776WAScGIfaeGkeDxpl6V6yAcUrvhj8vEiDQZ/qt64f8iucBX2RJA7cE6+bGD5 LbA3e40oerPWZdqzd1P57NtR21To/1wdJQNvMzjrV2Hd48N7qBNDco2xRSmkTALD1EOC XRrw== X-Gm-Message-State: AOJu0Ywz6PURq1HXqf81bEcYK8VyvnGfikJNLyLUjkgpzLIWfzl3Jy/s 14saV9PuHjw/9rwjG/lCV7s1SEhAirk8F7SsAF18csULUwG/swG5FV4SDjDR66OxARlyguOLnMv +VVyry8g= X-Gm-Gg: ASbGnctDKcF3G/Z/MMxGhiXK6r5HorDofdZjojiWBWlXFOmAuO6CzdclmkpkVJrecod +LhRXRBoTTt0DLAop9cfxwn+q86cSSsvnt0hxkk6fTSjq/l41JtbACBSb4KY2F50JEHn43605D/ 12QWfWxvZMCzK38/luScylZyBeKrmapo/VyaqjrbmVd4w0571IhHborGpO+GiXageV6iJjEwLvX mR5U19nM7xcp/uBlZpa4+T9dFkSPsbAZShORAxdE0bpyF56KYdmDCWQkOFbaRTzx5sowbrxru0p VqIhmti1bvspLM3NpmzgcEyDQ5yb+5Xpe0qCcEbePRWpTVjb7E/Lq61FhM8XOXHUjY108AUMjcN U2oIwVXWbpNQaTaApDxPO12o= X-Google-Smtp-Source: AGHT+IHsRsfe1hRpWYACwhaOKi9b6p/FD13o6YtytvZjhpET5hpEaJNMVnb4XMAYeFnpI9UEpEuDWg== X-Received: by 2002:a17:907:3c84:b0:ae3:5887:4219 with SMTP id a640c23a62f3a-ae6fc136150mr1291403566b.45.1752494561600; Mon, 14 Jul 2025 05:02:41 -0700 (PDT) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Alex=20Benn=C3=A9e?= , Manos Pitsidianakis , Jason Wang Subject: [PULL 7/8] docs/system: clean-up formatting of virtio-net-failover Date: Mon, 14 Jul 2025 13:02:33 +0100 Message-ID: <20250714120234.1524401-8-alex.bennee@linaro.org> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250714120234.1524401-1-alex.bennee@linaro.org> References: <20250714120234.1524401-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::52f; envelope-from=alex.bennee@linaro.org; helo=mail-ed1-x52f.google.com X-Spam_score_int: 12 X-Spam_score: 1.2 X-Spam_bar: + X-Spam_report: (1.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_NONE=0.001, T_SPF_TEMPERROR=0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1752498295410116600 We didn't clean-up the rst formatting when we moved this into the docs so lets do that now: - un-indent the usage/hotplug/migration paragraphs - properly wrap the command line fragments in code-block - highlight parameters in text with ``double quotes`` No changes to the actual text. Reviewed-by: Manos Pitsidianakis Signed-off-by: Alex Benn=C3=A9e Message-ID: <20250710104531.3099313-8-alex.bennee@linaro.org> diff --git a/docs/system/virtio-net-failover.rst b/docs/system/virtio-net-f= ailover.rst index 6002dc5d96..0cc465454c 100644 --- a/docs/system/virtio-net-failover.rst +++ b/docs/system/virtio-net-failover.rst @@ -26,43 +26,48 @@ and standby devices are not plugged into the same PCIe = slot. Usecase ------- =20 - Virtio-net standby allows easy migration while using a passed-through fa= st - networking device by falling back to a virtio-net device for the duratio= n of - the migration. It is like a simple version of a bond, the difference is = that it - requires no configuration in the guest. When a guest is live-migrated to - another host QEMU will unplug the primary device via the PCIe based hotp= lug - handler and traffic will go through the virtio-net device. On the target - system the primary device will be automatically plugged back and the - net_failover module registers it again as the primary device. +Virtio-net standby allows easy migration while using a passed-through +fast networking device by falling back to a virtio-net device for the +duration of the migration. It is like a simple version of a bond, the +difference is that it requires no configuration in the guest. When a +guest is live-migrated to another host QEMU will unplug the primary +device via the PCIe based hotplug handler and traffic will go through +the virtio-net device. On the target system the primary device will be +automatically plugged back and the net_failover module registers it +again as the primary device. =20 Usage ----- =20 - The primary device can be hotplugged or be part of the startup configura= tion +The primary device can be hotplugged or be part of the startup configurati= on =20 - -device virtio-net-pci,netdev=3Dhostnet1,id=3Dnet1,mac=3D52:54:00:6f:55:= cc, \ - bus=3Droot2,failover=3Don +.. code-block:: shell =20 - With the parameter failover=3Don the VIRTIO_NET_F_STANDBY feature will b= e enabled. + -device virtio-net-pci,netdev=3Dhostnet1,id=3Dnet1,mac=3D52:54:00:6f:55:= cc,bus=3Droot2,failover=3Don + +With the parameter ``failover=3Don`` the VIRTIO_NET_F_STANDBY feature will= be enabled. + +.. code-block:: shell =20 -device vfio-pci,host=3D5e:00.2,id=3Dhostdev0,bus=3Droot1,failover_pair_= id=3Dnet1 =20 - failover_pair_id references the id of the virtio-net standby device. This - is only for pairing the devices within QEMU. The guest kernel module - net_failover will match devices with identical MAC addresses. +``failover_pair_id`` references the id of the virtio-net standby device. +This is only for pairing the devices within QEMU. The guest kernel +module net_failover will match devices with identical MAC addresses. =20 Hotplug ------- =20 - Both primary and standby device can be hotplugged via the QEMU monitor. = Note - that if the virtio-net device is plugged first a warning will be issued = that it - couldn't find the primary device. +Both primary and standby device can be hotplugged via the QEMU +monitor. Note that if the virtio-net device is plugged first a warning +will be issued that it couldn't find the primary device. =20 Migration --------- =20 - A new migration state wait-unplug was added for this feature. If failove= r primary - devices are present in the configuration, migration will go into this st= ate. - It will wait until the device unplug is completed in the guest and then = move into - active state. On the target system the primary devices will be automatic= ally hotplugged - when the feature bit was negotiated for the virtio-net standby device. +A new migration state wait-unplug was added for this feature. If +failover primary devices are present in the configuration, migration +will go into this state. It will wait until the device unplug is +completed in the guest and then move into active state. On the target +system the primary devices will be automatically hotplugged when the +feature bit was negotiated for the virtio-net standby device. --=20 2.47.2 From nobody Sat Nov 15 10:52:09 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1752498251; cv=none; d=zohomail.com; s=zohoarc; b=QZ82aQjN5C1ICeoRajbNIj9oQVsN3YK6+HKK/h19LlOGBA42ZKwug0gLMiZouWdtU/g5HzfT3VAZiTYBucSTkT6CSqOIonRiBrrublU2h7s70a+kYXiqxioLr5tKn0ulmc+DUKV7NSO3nv0CbohlskHnpTz1pxGBdxx4IURd1zk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1752498251; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=T5v8OdxmzrjgwOi1V8ZOJSO/d9q/kYU1/NXLZZAou+A=; b=du9KuwVpsB5Ldjk9mplhf3Vur36rWvXgaUEDYuQwVaQQOEmhQ3Xg3CERgJSxU3b4uxxgVrlr7uFY3t4Z00PTzpPBpLoVMlUeuasqZWVDlEsjtbw/sN6INRsL/9ghyHPt7j//k91uQWVnY2UI3ZoJM/CJOKs0kvAbiop4lwegVdA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1752498251651465.41881403974014; Mon, 14 Jul 2025 06:04:11 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ubIqS-0008Mk-GP; Mon, 14 Jul 2025 09:03:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ubHtY-0007NA-Fu for qemu-devel@nongnu.org; Mon, 14 Jul 2025 08:02:57 -0400 Received: from mail-ej1-x629.google.com ([2a00:1450:4864:20::629]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ubHtN-0003sU-36 for qemu-devel@nongnu.org; Mon, 14 Jul 2025 08:02:56 -0400 Received: by mail-ej1-x629.google.com with SMTP id a640c23a62f3a-ae04d3d63e6so834903366b.2 for ; Mon, 14 Jul 2025 05:02:44 -0700 (PDT) Received: from draig.lan ([185.126.160.19]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ae6e7e90a07sm811640066b.6.2025.07.14.05.02.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Jul 2025 05:02:39 -0700 (PDT) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id 7D25B5F8E1; Mon, 14 Jul 2025 13:02:35 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1752494563; x=1753099363; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=T5v8OdxmzrjgwOi1V8ZOJSO/d9q/kYU1/NXLZZAou+A=; b=kZLFTi+3akDoEeINK2wSxeMPqMkv8SFQb3kjm+RBh8TxNQyCMc7whTUE1wM7PZkXSI cA4mniRue1gO/BPIclHENQ2auoEcXTOgRQOrNL9amEPiWRZjySg+GYEtFjqiGyLbSsHI GNvZWmvMASiltbTa7vhsnFZA/JE87AV0s1zLI92UxtP8ddh0MXOSeZWKIQmN9f6ggGVL niAMPLAC4Mk01pmfjYjm5T/1QpANmCXjPLWuNoiY1hv4XM3ZuwMdGoTvVTqLShYjLaCY 6bzLHUpgIo6MpF3/D655DpJyu9Cb/z49zLmmyQU2T4iAy019GGfUjZ3BygxnTI5Z5UKn C6kw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752494563; x=1753099363; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=T5v8OdxmzrjgwOi1V8ZOJSO/d9q/kYU1/NXLZZAou+A=; b=ZjEjTppsNcoRYU5rtSlzfUO36Yx6ftVt7i8CFlzjfFeNPg5h1ZxeVBjysfyeAwu85+ 8dPFk8LpZ5eNxCMTzB1p0qRmH2vXOU2JLcEVbVpHwPY0VH3pr8khzSaLtjBx2VY+c1XE ZUJx2Xub+bloCqexO6Jql6mIrLxpxHycUfwYLZC2v9hVIxYStn0JEwPqPABNYFpN8lHs WqmcbZ93K4fEK0KJ5ut6RAk2W/O1FZTK7cT3RXhuozNxI+AAMIE53lZ3CO0xbfTBnllw ic/IjzK/BDwb5nn87QLzU8S8S9NL7Of3gOD7g8y0otWUpf68nWRZLHAyT7iu8Ngngp7H 8o7A== X-Gm-Message-State: AOJu0YzhY1dJv9f0Qeerzzd11YDqkzzcPwzfU0ytZ97wSbzabWbB1Uy9 yARemL8b3+2Hto+QQ66IkVsW2bL8cv+/f1DuOjZA6noRONizhZmLnie8R+aRde4Kpmw= X-Gm-Gg: ASbGnctD6JqTfRaabniSvU4y7jVF18jYYlKw4A/HTZ8w1rnO2eMOZUePaQ2vv1n1PsM F+xv6EetJGTSMLa5EV3qPZXNyVu4IiB4iHf2oixZKy0/BVLXHE9rWzTa2n3ppjAg2AfwhxdaR3U TKaIGjD5E6VU9zR+MxckD6VdNDGsM9UB42vhrWbgb4hri6KWjLrh4MPux3YZffSwoT05Efy3UKM aOMaBeONRnl5uom4bdPbXjq3sZBxdvo6VQ10r98/Ho2e9/HFHh8ETD0ja8Yuo/54giHS/zmMomt goHJ2fdNRePCosNEj72eJqNWHhdb0gBNlQdF6Gws7OypYABUBpZlICvnpLNT7mYzqJfFY7PdubR Ylo7PHBAXNjDZx9yA4z2yAcUzIlReqNVzsQ== X-Google-Smtp-Source: AGHT+IF2pHp10QssnRsFCaTjz94XN9989zxU4tILODRi+Ref9jRPb5xYP3ekZ6fMMxqiNyDs1lQo5Q== X-Received: by 2002:a17:907:9627:b0:ae3:6028:e4d0 with SMTP id a640c23a62f3a-ae6fbc13b26mr1329290066b.7.1752494562484; Mon, 14 Jul 2025 05:02:42 -0700 (PDT) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: Rot127 , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Laurent Vivier , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Mark Cave-Ayland , Artyom Tarasenko Subject: [PULL 8/8] gdbstub: add the GDB register XML files for sparc64. Date: Mon, 14 Jul 2025 13:02:34 +0100 Message-ID: <20250714120234.1524401-9-alex.bennee@linaro.org> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250714120234.1524401-1-alex.bennee@linaro.org> References: <20250714120234.1524401-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::629; envelope-from=alex.bennee@linaro.org; helo=mail-ej1-x629.google.com X-Spam_score_int: 16 X-Spam_score: 1.6 X-Spam_bar: + X-Spam_report: (1.6 / 5.0 requ) BAYES_00=-1.9, DKIM_INVALID=0.1, DKIM_SIGNED=0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1752498253237116600 From: Rot127 Signed-off-by: Rot127 Message-ID: <20250711155141.62916-2-unisono@quyllur.org> [AJB: clean up commit msg] Signed-off-by: Alex Benn=C3=A9e diff --git a/configs/targets/sparc64-linux-user.mak b/configs/targets/sparc= 64-linux-user.mak index 64ea04e3e2..7c2ecb7be0 100644 --- a/configs/targets/sparc64-linux-user.mak +++ b/configs/targets/sparc64-linux-user.mak @@ -4,4 +4,5 @@ TARGET_ABI_DIR=3Dsparc TARGET_SYSTBL_ABI=3Dcommon,64 TARGET_SYSTBL=3Dsyscall.tbl TARGET_BIG_ENDIAN=3Dy +TARGET_XML_FILES=3Dgdb-xml/sparc64-core.xml TARGET_LONG_BITS=3D64 diff --git a/configs/targets/sparc64-softmmu.mak b/configs/targets/sparc64-= softmmu.mak index 2504e31ae3..d9d51d21e5 100644 --- a/configs/targets/sparc64-softmmu.mak +++ b/configs/targets/sparc64-softmmu.mak @@ -1,4 +1,5 @@ TARGET_ARCH=3Dsparc64 TARGET_BASE_ARCH=3Dsparc TARGET_BIG_ENDIAN=3Dy +TARGET_XML_FILES=3Dgdb-xml/sparc64-core.xml TARGET_LONG_BITS=3D64 diff --git a/target/sparc/cpu.c b/target/sparc/cpu.c index ed7701b02f..245caf2de0 100644 --- a/target/sparc/cpu.c +++ b/target/sparc/cpu.c @@ -1090,6 +1090,7 @@ static void sparc_cpu_class_init(ObjectClass *oc, con= st void *data) cc->disas_set_info =3D cpu_sparc_disas_set_info; =20 #if defined(TARGET_SPARC64) && !defined(TARGET_ABI32) + cc->gdb_core_xml_file =3D "sparc64-core.xml"; cc->gdb_num_core_regs =3D 86; #else cc->gdb_num_core_regs =3D 72; diff --git a/gdb-xml/sparc64-core.xml b/gdb-xml/sparc64-core.xml new file mode 100644 index 0000000000..375b9bb0cc --- /dev/null +++ b/gdb-xml/sparc64-core.xml @@ -0,0 +1,99 @@ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + --=20 2.47.2