From nobody Tue Dec 16 21:11:18 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass(p=none dis=none) header.from=nutanix.com ARC-Seal: i=2; a=rsa-sha256; t=1752227969; cv=pass; d=zohomail.com; s=zohoarc; b=ZQf3pXyZew9KDDIi+cLI5N7Htn6Aeheg6qZhhsi3UsgdePSd8Ctk3BmVtNo39YQW1zgVuaUv9m14WSU1+MiXvrr/veEpybQEaP8DiLtmYYUw83FfExc93RbMxXML4RDl/nhegyClTiahRRQB3ku2OXowkQT87WblNrTrvQlpGcs= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1752227969; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=G5AcBUdwpVBOtalw+srHb5dm3ZvommTQPZxQRnEHEjs=; b=VwRz/woAgZEZe3R682hiLL/RWaYg7nL7ytYzdeGfo9IP9xpoRIq5+0fVWM/k9vKWNjmPeFfSoYQ6IqgdNyv2CHWu5kRwnR15+pSE5giRpbwXKdIbfv2QB7VQ8PqExmB4aW6/j3A/g1kX5rDMwcn3bClyypFsLpc7FOAyttLyZGI= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1752227969572247.5945540920933; Fri, 11 Jul 2025 02:59:29 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uaAWT-00059j-EC; Fri, 11 Jul 2025 05:58:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uaAWP-00052X-FC for qemu-devel@nongnu.org; Fri, 11 Jul 2025 05:58:25 -0400 Received: from mx0b-002c1b01.pphosted.com ([148.163.155.12]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uaAWN-0004jo-C6 for qemu-devel@nongnu.org; Fri, 11 Jul 2025 05:58:25 -0400 Received: from pps.filterd (m0127841.ppops.net [127.0.0.1]) by mx0b-002c1b01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 56B70gmV032396; Fri, 11 Jul 2025 02:58:21 -0700 Received: from sn4pr2101cu001.outbound.protection.outlook.com (mail-southcentralusazon11022087.outbound.protection.outlook.com [40.93.195.87]) by mx0b-002c1b01.pphosted.com (PPS) with ESMTPS id 47q1karqjq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 11 Jul 2025 02:58:21 -0700 (PDT) Received: from PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) by CH4PR02MB10681.namprd02.prod.outlook.com (2603:10b6:610:246::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8901.23; Fri, 11 Jul 2025 09:58:19 +0000 Received: from PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88]) by PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88%5]) with mapi id 15.20.8901.028; Fri, 11 Jul 2025 09:58:19 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint20171006; bh=G5AcBUdwpVBOtalw+srHb5dm3ZvommTQPZxQRnEHE js=; b=UAlVvTaM8zz8f3tKmHpOhEyVfABgii5/vFfuAOwc0YSwyaYxqFnDUpH1e AD+dSYARmHxS5Ad4BO7X2IigQXsvkSTxS3sFyGNuS3J6fjXAbSxJNqPOaJ+HqcSZ OGIieCMtycR54dLMXO4Agk3OONTYZ4bLFEdDGToD9I6KgDYdNwnL9piC8+2ZzybG SgoM/lAR++M1q1RmHcAeen2Av8BK/iH80lBMHejI3WrALF9A/obg2a0iyiu2Rzn2 Y6ovylqwjQNUkqN8mpTxi25cGLQJHCTumF//1wNn9kPQbS/pu/MUWO09OOE7TCee J5PQy2wSZM3drcce5KTtIZX9T0rPw== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=DzV5l4TG9Yu+XTgKIuWhGoSfnmcMT91trJfqRLkvctTnj9A0uFv/fHlJtGAedklhkhmTNQzK9Co8SPBkHB6xk8UqbhJ1L8VQDASynsvWBZG47Lx1KeFfaU9G9ewwsusIOwdVw1+kvfded77RFUhinLI0TZmJsto4lBBMQOzR+92hBJ+GSvMmv9jFeJZBIA9HUk7lhZ/9WO2ilFKk3FFxaf72qFD6yW3vHWBC+43lEyO/SzZ4XHSiMbF/Y9wGb4Yebne0x/Ui3Gon3u0m6RMMcQMZWfYK0EtbNzYXQ66ubLyXA7Gzg3pFbn+zRk2iHY4NR6jIg0gpzlL+Y27EXpkTTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=G5AcBUdwpVBOtalw+srHb5dm3ZvommTQPZxQRnEHEjs=; b=LiLg+sI2FDGg+vqFd65xmeyKZSa0cgqr5Isz7pM42v3I/NJmSHOnGhJC1jM+gTHcvKi7Q4b9ujyLFnbF+/PkB+Z4Tjk0CVrKUvj7VdVNKaK65wRuh3n6yM/EWdJfdstblFr4VFDSEzp7+2FZSJS+8V89SHqCb89LbAxGqX+ya+EKScqlTGwz3rGrcgGyVIdM5uXDaRJAYkY9oVHNl8UIoPBm7j08wzjMcsDaf3ZZZqjkftTCiIR/R1hkQ92kW1EZ+ftIDzWaUASaoggFKrXykx+W9dzdpzKu5EFu+jEQWvbV1Uto5H2QtO3v5ad9TRClODycw4oWicVWBgh2pj7mVQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=G5AcBUdwpVBOtalw+srHb5dm3ZvommTQPZxQRnEHEjs=; b=PaM3J7etOR2zJAlSwq3EwXkb+O8q5ypNnV7NaS/7w/454e5n4v6GKmq3Br6Z8PG8By1qSxSMoskZzD5O6lU87Dc/jJgzRuO1vjMP9CWkpwgH71FXyxnVe3MuO6WIlljnmon5JcIBVZkM0ncKilOSgZnWuLycYgeFScg/07H8eS0b3kJau8sR8Bb9DcpdxIjqfCBsAy0WXerAwTJ93IdBK9ieeVb4iX53XflGGauWuGbSC83nE59prSHEujN9XUjMoJ18A+J9WW5/aUL7Rk7XRlhQOwDQlOnw1oiUn05pcGngDUUoXH3oo8tsR+/5vGgZNWBVZD1uz7Ys2Jqn7EOsRg== From: Mark Cave-Ayland To: pbonzini@redhat.com, mst@redhat.com, marcel.apfelbaum@gmail.com, eduardo@habkost.net, imammedo@redhat.com, qemu-devel@nongnu.org Subject: [PATCH v5 01/19] hw/i386/pc_piix.c: restrict isapc machine to 32-bit CPUs Date: Fri, 11 Jul 2025 10:57:03 +0100 Message-ID: <20250711095812.543857-2-mark.caveayland@nutanix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250711095812.543857-1-mark.caveayland@nutanix.com> References: <20250711095812.543857-1-mark.caveayland@nutanix.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: LO4P123CA0061.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:153::12) To PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR02MB7159:EE_|CH4PR02MB10681:EE_ X-MS-Office365-Filtering-Correlation-Id: 69d570f2-29e9-40e3-5dc0-08ddc06176d5 x-proofpoint-crosstenant: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|376014|10070799003|366016|1800799024; X-Microsoft-Antispam-Message-Info: =?utf-8?B?V3hDU05wQzEzRUZ0ZDdhdko0N1lOTnFaaXRMeURpR1JTRkxyNmQwaTVXWk9h?= =?utf-8?B?VzdlZUtLTGtkaWVQOW0ya0dkSW5uVjRpc0w5a3NsRlg1TjQyaVIyekFEcDhL?= =?utf-8?B?dTFEOFpyc0VodmRqTG0rL3lnUkk1dytlZTJ0Q3hLQ0pYS0hLanB1SjdCSkZM?= =?utf-8?B?UUsrR1RXckdmSmU1Z3phMGVwaGw1NWJVZzRRVitmQkhoc3paN3BOMDdFbWVS?= =?utf-8?B?eUQrR05aZGtrcGt4cnI0NzkxOC9odGZ6R21lc1pWQ2RxR1hJV2JYY1hSeVdR?= =?utf-8?B?VVRsM2NyaldzcDlpdlE3VkEwNG9PRmZZblE0T3BWWDlPK21Da25EdHhTUFRD?= =?utf-8?B?c0V3VWtKQ0d3YjlzUUVXdysyMEZpZzBXQklCSktsVldPUlFoQUdPNklNdmVH?= =?utf-8?B?dFB5ZVBZQ2FVaTR2VzNKajdTM1p4LzRLSXBiZmpwTkJRSUhrbnBiL0tzQkU0?= =?utf-8?B?aVpyNG40R3pqeUNFc05nSzFuYnhkekovYzlGM2FSMVowZWpJMElaRU1mK1dn?= =?utf-8?B?dVRqc0NkZ0FCY0lKb1VCQWhhYXZrVzJMU05lb1FXQ0d1dStOQjF1VU5iTkxQ?= =?utf-8?B?Q3pjS3o2ajNYL3pGMnBUQWJJK1RZTFF3MVZ2OU9SMlZzUnpCamlLNmdOd1Qr?= =?utf-8?B?Y200cFRhRGxrNGYxdnF1TkUxbUVoK2lKdGsrUnNuNElYM2FxSjE0MHZHSndR?= =?utf-8?B?WUYyVDhlN21lL2FwVnI2Y3B3YWt3TmdzbndRNk8veTJoT3o4NEd5dkxGRjJJ?= =?utf-8?B?Z2FSZzQzZWFzTW1xOVBGUDlseWFjNHdHeUgzVzgwdWhIdlh2NTAvVytQV0Jj?= =?utf-8?B?ZUtIeklPWk5KVDdKVjJLMVo4OTNrSFBUSjNQVDFGdnJtUExYZE8vTzB4dWsx?= =?utf-8?B?aWNCUUt1S2tSN2tObG9Tc2RyNVYrUjlhQ05xN0hwSmJPenFxQUhiTTRYRWZp?= =?utf-8?B?RjFSTWdER2NJenR5QVEvd1FqVzE0UXJsaThqTWdCRnNlMGh3QXIydkd5Yys0?= =?utf-8?B?M0FtVmNTamkzbkxRWTYwQnJra1hiV1l2dHI0M2RvVlVOVHI4bStOOExiTjNi?= =?utf-8?B?bzNtVnh1NzFQaXFYZzNPMEg1aWhyUk80ZXl5clVTeWhtZXBNblVCVWZoRVpK?= =?utf-8?B?ZmU5ZjdxYmNOeDFzcnQ2N2FBRDdhRzAxRDJES1UrZkpJV09IMG9TWU1MZ1Q1?= =?utf-8?B?QUVyK1RLaklvUDhtQTRuelQ3Wi9UQ2tvajBqdzNDYS85ZHZtYU9FTGZCdk1J?= =?utf-8?B?Y0p3bWViZTJuc2xQa2VkaGdjSUZtVzNhTlVNaDJVbThPTnpUUkxCcDdodEo4?= =?utf-8?B?a0liYlJTQStlcUhFWmx6dlZOaXR6MnovQ3M1bmVSN1NlQXc5SlFvZE9QVjdT?= =?utf-8?B?STVEQkZQK1BVZitpcUtVNTN2WXZoWXQweUpPWWEyU01kRk80aXZsZ3YzNWIw?= =?utf-8?B?Ylp2YVhISXQ1YjZLOGJlUklHU2NnYWpJaGl1eE5sVUpUNFZqSlJYcFNUMGdJ?= =?utf-8?B?eDJwUmVmdUJDeDF6WDNLNWxyQlJWZ3hlRkdvZ3gvS1hiMVpEbVJUWEcvUEx5?= =?utf-8?B?YzJTNGJRclFQTTBsWjNFaVpEcE83ZkpzbktSbjllK201SkIzd05VbVhjWG9U?= =?utf-8?B?TUN4cm15Ui9ZcVlQWWdDK1B2NVZzT1RqYU9WdHZhMngyYzkxSDZjbDJ0dDNn?= =?utf-8?B?bUZpRDZHeVErdlJOS25TYUJ6V0lRVDI2YXZkdFdOc0k3RW9UZDZ5SGdWZzIv?= =?utf-8?B?MnJteHpNYkdIb08xbkwzd29MYVY0WEt1VngyOW9HT1YybjVOdFJDaTdVa2NB?= =?utf-8?B?RFN4em1JZDMzWXRrNDBvMjFBb04rZ1ltVDMrMmxIeTJIc0lKUzh0aUxYbE51?= =?utf-8?B?WUhRRE5rM3h4T0p2bVZnUE9tQUxHUnJFZ2xNV3daeUdwM3lPSDdtZ004NlVr?= =?utf-8?Q?LHsp3MD+OEk=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR02MB7159.namprd02.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(10070799003)(366016)(1800799024); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?b1pNVTNXZ3l2a0RrTEMrOGJPdFZEbWptWUgvaHdmaUUxYTVhMVhkdnl3dlhK?= =?utf-8?B?SUxYTnpyTEE1Ri9hQnhteDhmZHlZdDM2YXZ4VGxCSmZYaW9Wck5OZlIwcEFv?= =?utf-8?B?MWpsYjh0Y3pMcm4rK2Fra0VldEFZeEIrRXRmeDlndVpPUmZWQzlXcGNuenFi?= =?utf-8?B?czZkb2xFRGs1TjFhYTlqMlF0dHMwbUtXbEZDYUJ3aWs2d0JCdENvdC9oNkUy?= =?utf-8?B?d282dERhRjZ1VnQzZ0pMeDl2aklTQjdJb0FzZVpDUU9FUXhkazY4dFc4ZzV0?= =?utf-8?B?NEQ3WGVpQ3d0K0pKcndySFlnbFpEV0lIQjhtTGVQRGg1eWh2K3ZRVlhhdmhu?= =?utf-8?B?OHl2WThsR0FMQVo3RVhIWlpYUGVvWlgxRFpLZ3gwNE42cmhLVnI3K1NzSE1B?= =?utf-8?B?WTZHTTUvKzQ4aEVKS0xtNUsxUnlOTFBjQ3htRnBHc3NMblZkV2JzcDZrUlZs?= =?utf-8?B?Y3ZrVDFyV1RNYUhybTVJMU5vV0dvNlo5NUFuMkdHZ003WkplSFpBeHBoNi8w?= =?utf-8?B?bkNOU09RdUdBN1B1OEhOckdlQlRGSWNGc2thcEduQ2JicDJTM21ySXVQVFZK?= =?utf-8?B?WDlLUzkzQ3hVTFd2azlZRGpXZWp2NWlnb3pYdFd5emlFTG9CdUNUaWhjQWd0?= =?utf-8?B?RVhmSkorbm9LVkRtR3c5ZXVRMHNLVGt5L3Jpb1lERSt5UzR6bis4ZmhYbzV5?= =?utf-8?B?SGN0VzF1enJNckhBU2hPcEY0dnFSZDNBZGU0TFAzd0dEbzFVM1VMVmlhaDlJ?= =?utf-8?B?V2NGdU9naW9lZVFob3hiMHA4dWkwMWFZZzZ3cENkbnh5QUwyYmUzRDFwSjND?= =?utf-8?B?MEJyZW14L0RDZzdWVHdRVXZLQ3ZtemQ2dGVZLzFoK0crd1RNbDJLT0xkcmN0?= =?utf-8?B?d2prUjFOb21mTDVYUmdDcldUbFk3NEtnK3lHTHZld1FxVTBzMHM2U2tLRkNw?= =?utf-8?B?Q2dRQkdpK3N5Q0VGdHhGa3RSbTBQREpibEFZT0xNZGdFNnFITXhTRUFWOEhs?= =?utf-8?B?bU1DQjVwRWxQdjUydXpNUS9KL0NIbXZSL0srSTNkZDdnMGtEbzRzSThHc2p6?= =?utf-8?B?dDhPOGtmSHM0QmZ3eStOTFl5MG03SEFva3h2SlZSUFhxZGZ6U1dDdHpuMmhh?= =?utf-8?B?aEZpN1pUaXNZNC93RzFNZndvYzVEdUxRdm5VRU5EZWljV01WVW02WHFoMktt?= =?utf-8?B?cmpNUmMzdkFOdm9JQ0p1TEh0TE5WZ3VET0ZhWmdWRjhxNnV6RGQ3clh4bFly?= =?utf-8?B?Sk03MjhxTGY0U2tFQVcvK1VmY0ViTFBOKzJlUThnZG1VM2pIVnNEc0JhMDdK?= =?utf-8?B?SVEyblVXUXNQdWx4SnZGOFkvZGNYbmJMRE9IcHVFeTJLbW5HTjZEY1JmQkFu?= =?utf-8?B?cDJSUFZnSnBnRVF3ZFZWRGpmNmxBdDFjdFBjMXE3RFdVNWppMTZaOTFyN3Mv?= =?utf-8?B?NEN6b2p1WFVTbVVlNHVVUFpubUU5SDEyT2lsSXJMMnFSSWdMaURNcEpSWmxo?= =?utf-8?B?RlgyMW03cFBoaTJsTkFuK1MyTzhJaDlFVE5FUXhmb05wQzFYQ3Z4dU1nbHR6?= =?utf-8?B?VzFaZDNzb3JmVjJTb0dXRHdlclRsWUVsdFNiWDI5c1ZyY3FIZUNkLy9jM3Vp?= =?utf-8?B?ekpBT2ZPYlpDZldocmJQM1NDKzByV21rUThqV0FpbklhbVZOVkM4Nm15WG52?= =?utf-8?B?NCswTDNIdHJHWWFSWUFETGxpcW5MZHEveVRBV0xjM2VKOFEyYUlONU1vZmJi?= =?utf-8?B?ZklDdmVLYng3b2xLT3ZvdTNkN3RBWWo0Y3BLTmdYSEtNY1NlcjRDVjdjaFJ5?= =?utf-8?B?aUNRT3M0ZG51dlZWWVBGcC9CRkEyMGMvWm9ya2FpVEZCWnQ3SG5FQStCTzVl?= =?utf-8?B?US9zZzJHK01jK29jTlRvcVdJazFMN1lqZmZpZkhqUkhnZGR5eWZBTjZ0THpX?= =?utf-8?B?L3pZNURwbEd2UFpXc1RLc1doTytkRWFkbW0wU3kzdG1UQ3lLNHlOOGNyRkwv?= =?utf-8?B?ME5XdzV0OUlveG45QXg3R3QwRWxCejkrUGR2WldnbUdvaHBwbkxhdHRSamdY?= =?utf-8?B?dDhScy9tQ2gxeEVNby96L0M0Mmg4Ulg2MW14dmg0MzlCaU1PY29CazJuM3Vh?= =?utf-8?B?WWtpdWFOb1E2YU9HNjRaWUtZUWNsbVAyaGxyelQ5VUZyb3MwM2hYdzhHZFd5?= =?utf-8?B?Y1pmdUMxL2FjcHk5UTBCQVpBQ0pNalNrS1Jlb0J1Y24wbzQ2VlNHS0FCTVRW?= =?utf-8?B?VWNyVGYxSWpVZ2JoeU03NGlCcEdnPT0=?= X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 69d570f2-29e9-40e3-5dc0-08ddc06176d5 X-MS-Exchange-CrossTenant-AuthSource: PH0PR02MB7159.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jul 2025 09:58:19.5236 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 99yRUgbK7Jg0NxyMalsTRpdrVi1XFqJsT5kPYgisoGaJGpjJ2rSHcVu6eNu/1j+XljeDjz9s0Jj1Ac6XLGt9e0xFqc3Uf/x2z0IrUDO34Ws= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH4PR02MB10681 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNzExMDA3MCBTYWx0ZWRfXyBP/Hi5TTqgH nSyDsuic1Le/5lxr3muMm3tQFaowUTCRlspC2xZZiLF1nHhpXdpv9megFTCIupYVe00Fqu6VVpo ilz+TihWgSUtWIZ1xy9obrZHXCZHevIOtYlBixY0MyEYkMNZ6h2mah9oM9o1bmlA3tcv1XPf2wc d338Us82KuYcip1voFx+bSEJFU44/t6kICYx2V+ihTFyMj0f9qpZqO5woc37ir9Czpb5GlKvgqJ hNPG2eoxPbLXfMcCmkPG5jt9LCBDJ4ixLUqzchlIWefy0sQ5gWxAbwRzYYpadlL8J/KW9bAZcN7 OHnz7ROPNpyvfyZ36IMqNl9oTBloOEJIhHIAroiRofnDiNfArTvADHBIUvTjrPpTK+hlUEYs+Hp HueoRreDskhaNarGwMsutmIdHxwPwUoNnZOIchycZnD6pKocrjs7Z7/cmWM+hnF/ScPZ04NZ X-Proofpoint-ORIG-GUID: AStmDS2Ae3L4ikkpYDQ19gYCQqXExKO- X-Authority-Analysis: v=2.4 cv=Do9W+H/+ c=1 sm=1 tr=0 ts=6870e03d cx=c_pps a=7r/ioy5s1gfMry3CYkvllQ==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Wb1JkmetP80A:10 a=0kUYKlekyDsA:10 a=64Cc0HZtAAAA:8 a=KKAkSRfTAAAA:8 a=nuetpX4ixqIVgyrW5aIA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-GUID: AStmDS2Ae3L4ikkpYDQ19gYCQqXExKO- X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.7,FMLib:17.12.80.40 definitions=2025-07-11_03,2025-07-09_01,2025-03-28_01 X-Proofpoint-Spam-Reason: safe Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=148.163.155.12; envelope-from=mark.caveayland@nutanix.com; helo=mx0b-002c1b01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @nutanix.com) X-ZM-MESSAGEID: 1752227971012116600 The isapc machine represents a legacy ISA PC with a 486 CPU. Whilst it is possible to specify any CPU via -cpu on the command line, it makes no sense to allow modern 64-bit CPUs to be used. Restrict the isapc machine to the available 32-bit CPUs, taking care to handle the case where if a user inadvertently uses -cpu max then the "best" 32-bit CPU is used (in this case the pentium3). Signed-off-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- hw/i386/pc_piix.c | 26 ++++++++++++++++++++++++++ 1 file changed, 26 insertions(+) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index ea7572e783..34beea993e 100644 --- a/hw/i386/pc_piix.c +++ b/hw/i386/pc_piix.c @@ -418,6 +418,19 @@ static void pc_set_south_bridge(Object *obj, int value= , Error **errp) #ifdef CONFIG_ISAPC static void pc_init_isa(MachineState *machine) { + /* + * There is a small chance that someone unintentionally passes "-cpu m= ax" + * for the isapc machine, which will provide a much more modern 32-bit + * CPU than would be expected for an ISA-era PC. If the "max" cpu type= has + * been specified, choose the "best" 32-bit cpu possible which we cons= ider + * be the pentium3 (deliberately choosing an Intel CPU given that the + * default 486 CPU for the isapc machine is also an Intel CPU). + */ + if (!strcmp(machine->cpu_type, X86_CPU_TYPE_NAME("max"))) { + machine->cpu_type =3D X86_CPU_TYPE_NAME("pentium3"); + warn_report("-cpu max is invalid for isapc machine, using pentium3= "); + } + pc_init1(machine, NULL); } #endif @@ -786,7 +799,19 @@ DEFINE_I440FX_MACHINE(2, 6); #ifdef CONFIG_ISAPC static void isapc_machine_options(MachineClass *m) { + static const char * const valid_cpu_types[] =3D { + X86_CPU_TYPE_NAME("486"), + X86_CPU_TYPE_NAME("athlon"), + X86_CPU_TYPE_NAME("kvm32"), + X86_CPU_TYPE_NAME("pentium"), + X86_CPU_TYPE_NAME("pentium2"), + X86_CPU_TYPE_NAME("pentium3"), + X86_CPU_TYPE_NAME("qemu32"), + X86_CPU_TYPE_NAME("max"), + NULL + }; PCMachineClass *pcmc =3D PC_MACHINE_CLASS(m); + m->desc =3D "ISA-only PC"; m->max_cpus =3D 1; m->option_rom_has_mr =3D true; @@ -799,6 +824,7 @@ static void isapc_machine_options(MachineClass *m) pcmc->has_reserved_memory =3D false; m->default_nic =3D "ne2k_isa"; m->default_cpu_type =3D X86_CPU_TYPE_NAME("486"); + m->valid_cpu_types =3D valid_cpu_types; m->no_floppy =3D !module_object_class_by_name(TYPE_ISA_FDC); m->no_parallel =3D !module_object_class_by_name(TYPE_ISA_PARALLEL); } --=20 2.43.0 From nobody Tue Dec 16 21:11:18 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass(p=none dis=none) header.from=nutanix.com ARC-Seal: i=2; a=rsa-sha256; t=1752228150; cv=pass; d=zohomail.com; s=zohoarc; b=VCKtFCUlhS2P3aZpu6spNdwLk6r7H+K4472gMG91c8eXCjTKxukcHEze4aklnH3rLS3sHftXQcWbklW5Ob0VEwTD2ipVgnqXbE7EfcrVTuk9DAKjBY/59P1LySnhC8UemQf8/kUl6pK9hmQy7CnvBCrs6dbnbAPr/QpucS6fJ5Q= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1752228150; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=SUXCVGbswc88cBpdVvWx0KBKeED+dWZMUqkHPl3ZGTg=; b=ATpjNVKqwaHbSQtr/khPp4qfwdmc8/1dm1/KXv0PME1UzRTeULYqu7k7Hq+mhR7QKuOunMkUWBjYFzKvRvG4ZLajczZ4zXppWkSX8N8vzgqcFMbgGVzfHSh4/o9yI68y07dwUr14RvTQZXXkERkfZXQlan4GaYc/YIAvaGPdLRs= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1752228149981931.295569271482; Fri, 11 Jul 2025 03:02:29 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uaAWY-0005MR-SF; Fri, 11 Jul 2025 05:58:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uaAWW-0005Gv-BA for qemu-devel@nongnu.org; Fri, 11 Jul 2025 05:58:32 -0400 Received: from mx0b-002c1b01.pphosted.com ([148.163.155.12]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uaAWQ-0004k6-33 for qemu-devel@nongnu.org; Fri, 11 Jul 2025 05:58:32 -0400 Received: from pps.filterd (m0127841.ppops.net [127.0.0.1]) by mx0b-002c1b01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 56B7IlLG032197; Fri, 11 Jul 2025 02:58:24 -0700 Received: from sn4pr2101cu001.outbound.protection.outlook.com (mail-southcentralusazon11022101.outbound.protection.outlook.com [40.93.195.101]) by mx0b-002c1b01.pphosted.com (PPS) with ESMTPS id 47q1karqk5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 11 Jul 2025 02:58:24 -0700 (PDT) Received: from PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) by CH4PR02MB10681.namprd02.prod.outlook.com (2603:10b6:610:246::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8901.23; Fri, 11 Jul 2025 09:58:23 +0000 Received: from PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88]) by PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88%5]) with mapi id 15.20.8901.028; Fri, 11 Jul 2025 09:58:23 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint20171006; bh=SUXCVGbswc88cBpdVvWx0KBKeED+dWZMUqkHPl3ZG Tg=; b=kAvxINgNGhXGpZfXS97+LzPic2W1ddN78qGDLUbhtcICB/K0pRyOJ64kR JMe0ge/nH72FWp1SXvgG+syQUMdAUIORn1kffhBl6oB400olCWQQY2qRUQ5A+oUx /e90f80y58PnmrSmC662TcVtE0y11Dg/tYyBy9PZduufbOaTeXXd1/6nIyES+iBD EuavkS6uHSyHgUckU3RHBu9H72WwxdnyXzBJlQfaI1QzEdPpjFulwhH8Jkrdbmm7 17Kpbmr3Gv8CWqR02n67XBW/WPI6IlLH1tZvrJJIQY7ACSV6GbxnLxeVsgl85uu1 El4NI/nrAh8dvt34oKtJBjOb5vJkg== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=wdli0EZyO528ldP60F3PbZApCUUXlbIGaG1j/EbeKhgsc+7h0cbGYS48R/8UgqebEmWVKa3V+WQ5mQIrUZ49445w0wGqtWn7G+ZrO7Dz3/hKwAuEC0szG8fDHRi3Ku8tAVK9HNWpzGOa+4Yx5y1W6FWRTptXgPKNVecl71Hbt10lL5x6qlOrnv6RTGLbWRQtQwQRL/+cJplB+TiCvxZckrG66O2RqRunCqq9tJtWCcr6MgSTLCIq0dO63aaoX9hUnu4x/+akmQlTHFDQnC5j7hOpTAXOlyRVXKer3w0VWxK3vth8wggAhDALd4GKFv6mb0By22//ICY6V5v8cvf2Bw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SUXCVGbswc88cBpdVvWx0KBKeED+dWZMUqkHPl3ZGTg=; b=Ng2XsA0vCPLQKTmJI1xUm9P+uXq/LTfN7Igw3jlP1i1Rt6IHeb2blgwSTILCftlT/8tyEonQiDDfhh1oFQfmN0ROF5ubvzlSst+D99WTDGswSacVqdYaLMA1FNflKC4+ajtxtroTXA61BPWSCo2Q1vxKxGZ3a7TioyoeW7Tgn+bR73aRYERxGjiKayl1aLHDh5xRxRlIRWa/uJyt3mq0Qh/K3wb6XwQFONWP+GQgroqkfpwwyVf/60l6MX4diuFmtrMG5O+bPZ81vL4YOCBumUPoAbthsA9X+3Y5sL7yOSCwPWLJEVkHp9kdJq2nRoj0HkrV9V/gHTPJFrmQ//eKjg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SUXCVGbswc88cBpdVvWx0KBKeED+dWZMUqkHPl3ZGTg=; b=wyIImAcvWxMjn6NgO2wIT9GOI7sZ6weZKDY85Etxvw2OYQ2Ew6arrRvLqgS9Q+v+RBr+A+kXGVZYy+7MVHRL3ed79EtrT3WMUoGJBl3AuhuqzIRzMaALxjCLJEb8J8Bfd49/dTmRei1GGeqpo6oejRApWNhv4pgXZ0rGQ7Gp/1J+b1eCj4Y8DfY5r7aWfxnR0OoYytcEAmo12wWb2fP62j1ca49ACjB9pFmPULVvpHMR1tSLmIixf3stzBi6GqXJYpeX2PM6C81HHELoz+6XGs2j3fncSE4xJMAUKV7xZ2mPc5i5HBAjYjhcMr7UB2S2fkxXlVLg5+4S9g3mxIS+Pg== From: Mark Cave-Ayland To: pbonzini@redhat.com, mst@redhat.com, marcel.apfelbaum@gmail.com, eduardo@habkost.net, imammedo@redhat.com, qemu-devel@nongnu.org Subject: [PATCH v5 02/19] hw/i386/pc_piix.c: remove include for loader.h Date: Fri, 11 Jul 2025 10:57:04 +0100 Message-ID: <20250711095812.543857-3-mark.caveayland@nutanix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250711095812.543857-1-mark.caveayland@nutanix.com> References: <20250711095812.543857-1-mark.caveayland@nutanix.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: LO4P123CA0643.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:296::10) To PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR02MB7159:EE_|CH4PR02MB10681:EE_ X-MS-Office365-Filtering-Correlation-Id: ef2da201-40b9-42ad-931c-08ddc06178d3 x-proofpoint-crosstenant: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|376014|10070799003|366016|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?kLrK5bZghsjzq/ofitch+yrLR8rPbFG0GJejiVTiOpeCPQnx72Iecbqcsfwp?= =?us-ascii?Q?JFkvRchsGlJ8tCIch26Gw4fVX6dUKTIoaS0JVkHtjJPGGmhS9tnWdGpz1zh6?= =?us-ascii?Q?6liwJ1RejxRgtSM8SXT9hqrtJf2SnThqGbdRRuj3w9KNYsRV9ZDZjze4hAao?= =?us-ascii?Q?Hj+BypH/x3aDWTEyHxFudzBJzlddK71P0vE6RTPZqNiSyjg+qmvGcsHwuEaM?= =?us-ascii?Q?asKcpndeOR1GdLaF7MWFU/L+wxCEk/L1Y/jQ98SUDDPPr8We+iFY1iBcm2DY?= =?us-ascii?Q?Z9wCkc1yxdIwl9tiW38ESnmVNOtprQ9mS0pQlnxrmBbd0e8rxPgrBfEWB2zT?= =?us-ascii?Q?uFAdbcTOpp1S8J9F1W6xqQPE+ieS4sm2p0TIrmUHt1bkHvjIYtIa8UqB4FpN?= =?us-ascii?Q?f7PxvhczyZdZSKLWoUkunQA9c0ENQMN6uIq4Qr82maDoGL3IS94tO5sudh07?= =?us-ascii?Q?ThGCpRlokQg5kwMov+oI3k1gQJII7wqJBAl562jcfgsmCsA0AoGMyu/Shd6f?= =?us-ascii?Q?Y1YzefzIKrZAO6+CBecFI0sJhybOG7N9uPsM42hywWDSnzy7zSmAAC0a4x/l?= =?us-ascii?Q?Umw1KogLtmo38gz3vh6K/kj9v6KQBhLz4WZmvtTsC/TjmTe50m8Xyr1uIUnG?= =?us-ascii?Q?y3hdcrmIx6dxDtjwHbe/uWx/eWkWodvPAB03aJv3pwDMEC7CNjwA1LxiuQl6?= =?us-ascii?Q?d8oQ72AHoxl0PhONYzmjFmsbnKMdf5aGBd7MfctRal9rcNGlg6ugqbbq5N7j?= =?us-ascii?Q?gCuPgh5Jg/5/cSdDfZyREzZakIVcILGy34mF0p9GSunyXB2Qhl8jAKbOfhr0?= =?us-ascii?Q?6vhCMT3u+jStbSgVlacmQasv35zzxZmelekkBOEoLGz+liIOJ1mU/m6Y1uBs?= =?us-ascii?Q?YZxB1CnrxV+OvelC4wrGRHBqRdAjoe2ghhMKcjOpD0KwBA0MpKzcCNJP39rl?= =?us-ascii?Q?cWYyfZqDs6LMUh+EZRDA4wL1G1ZmMmLrWDwXOkgTR6U9gDBc/NckePjk7vvt?= =?us-ascii?Q?R0Imt/6XVEUUEUf7BYFWxrObsCzLqJHLmaTfTuXyvPHcsIMDgULZFVf780Jr?= =?us-ascii?Q?hTuYbPVYowFwRX4uPLVGZXA8FiyuKyNKGynHjVvPiW/claVGZksFZrjQkdOn?= =?us-ascii?Q?w9nBfv1yqFzeyYSzRwm49JT8vGrwwNM5pwmBzb2ZxdtNAIsX/WTPC2g0izs7?= =?us-ascii?Q?DhksAkQV24yViRPeQ+VeT3vz5JV3LO5/0RLU/go2I50TzDcbtf1hbj1JlYz1?= =?us-ascii?Q?Heck80Vqlzh7ep5A+yRxfQUugbzuInSB68TjiruU+BzndL7/7Lo7BKjexgJR?= =?us-ascii?Q?qHCkGAg3MkDsav3wJbMtanDK53mvwQYq3j61vFqD7XHyzH+gebSadZHr2n/Z?= =?us-ascii?Q?IBCPL3ghdwUL+En7NxvyW5VhjVeyJMDSYCeYQ0dSq6oQ1LVUqU7T80WADdZf?= =?us-ascii?Q?tKNxnG8y3DM=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR02MB7159.namprd02.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(10070799003)(366016)(1800799024); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?/iEesPtK01lICnlUdnK42tLcfEhUHSbGEA1tDtdvXCxxK/U12SjLTfJWsxF0?= =?us-ascii?Q?ykw43o8SnlEUj473q1wRtwhyGy1Sou70JkP+8XB8oI4y///kQ+0uoLByblAM?= =?us-ascii?Q?4X+3CtspOq20jefVtbrvBAe5Tb7lxT/eqe0xob64CgXFby7AyYqaGgl3chKg?= =?us-ascii?Q?3NIA8yTGeoesxhXfPeDcuKhq6y1NbMfMpDajEeKMuBALioLt3eTbk7sSHo6c?= =?us-ascii?Q?mpdJ0hglywJlWQ5jeRjTG7Y/g29C3KubrYeFk5L6cAqdJJhvrtqO+iSOlKYS?= =?us-ascii?Q?kKNaGi7sAPWCtc6c+aFgbzqt1T1ZG0/ijwqZCEzo0I+acGjS8SMwX2ZYUDb+?= =?us-ascii?Q?JfIQlu5fMg/FzRLHmaJYHZ7X7GmLvmVYKKt4VPiqxnfRFnRecdx2/lRZCw4J?= =?us-ascii?Q?famyYzv4j+lWz4XGEcJdFZTXHAbqjzLDQpo20c+8EgLatUB+v1q4IdHoQqnH?= =?us-ascii?Q?ApH2BZCtqwPT9bqv6Ahuio5415JHJazKZ/Y+d9lRt5EXGGhb0yOE1SJgn99f?= =?us-ascii?Q?e28ftXuemWEhTPh2ZPoNB4A/9DsDhpAK70/wr6OALSF0Ja7c0r5HD0UktQ6u?= =?us-ascii?Q?kEMHm/24D2n5n7H7BNswdgbQ0b3sB214Z+p08A63Z+H300Ajf6/3g4x9/cCV?= =?us-ascii?Q?0int+nbcxDiv/mugsnN5wiElMPTxM7cF7tGByFh2Eu3TMWc/O3Hdwm8WcBOT?= =?us-ascii?Q?IwyDD9772TzFuNYGC5l8oBRus6vtkbBZjLT7BgbJC2bv7Cb5sO9QQI3NgXGt?= =?us-ascii?Q?zfBxV4rfQeEn6QZlXxFowTkjgKMRfrC4teFS0vZ0JMXA0+RUT4vvOSPKuoYA?= =?us-ascii?Q?Q7smUzCmhFB+5hqvxgliHnRgEGEyDfUcCKW23sZ8z2Sq5tdHo8C1Tisiz0bl?= =?us-ascii?Q?Tqf6qVvngn5sFwhMu/dFdDwzK1euGaqwbvfozb4MYbp/Szj0iMrI09XGj2vN?= =?us-ascii?Q?TMuJGRcQ/D3w5IF0MdcZA2NmYO7MZalbptqwUsMHOZ1jtfY7flQIMLXWOEQU?= =?us-ascii?Q?wngdOxXe4PzpRWN0fI2anQGKDrzPOcwr0cb5EriCK2SyzLsdvMBypoyrIcSQ?= =?us-ascii?Q?R7489CZTjbT+u0D4MVP0NxoDqVz9x8etN1pbjtglsgUBj03gYdyaU0UkICEA?= =?us-ascii?Q?6/ylCRxDZhVrurim7iDNlEbO6E50zhS87A76O/KS9s5XkuBHRsw5B8djkyAJ?= =?us-ascii?Q?pQLOPwk4hD/+PCT1OnTlPHaJpPda0yeYNPvoxor8Hh0aFjcAvIKZ/5QPeTzQ?= =?us-ascii?Q?cY2su4AOMWfPH+l0GuuSUGPfguAC07eZhKAT5ggnT9yqZ3QtKzj7z9odgIds?= =?us-ascii?Q?VaWdtfzoBMZgqwFOXLkiMLHMAAzV/O51rxHVoaG7rhlQGvM4Bh9cV017c+Tp?= =?us-ascii?Q?ci//ZOU9p6EB22vhg+DYVj4U78I5RgYMZlnkyPhw4pcJeOM+Mrdmi0l2jOtc?= =?us-ascii?Q?u1krbtuM0Bs92FEMro5fW55lv08r1g7oQjbieh65jSUZZPogm0msjiNs7qEY?= =?us-ascii?Q?cLr/CPNMCGztiouRKyZhTdMqF7hzmBucs47wWdNobSNZMxwB3mvG9YuLZAp4?= =?us-ascii?Q?DQj2/mxfXM2zJ940/aXZBHhbMvOIT+37npvVqrjm4qJBfHfFqksmPf8DPXUR?= =?us-ascii?Q?BAjh5qazFX+Cj4tVN/KX1l+1llidC+UWjzGkmk4LvRnt+ra+igj4txawaXF5?= =?us-ascii?Q?yu2X6Q=3D=3D?= X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: ef2da201-40b9-42ad-931c-08ddc06178d3 X-MS-Exchange-CrossTenant-AuthSource: PH0PR02MB7159.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jul 2025 09:58:22.9364 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: IofLG7j6QI/jwU5twdwktKpWJkc1NtiyITsSOPTOu4MQOgsgtDM5bSy4TRqux79bBEZdqfS+0+TKm97yTc2kE8rfNMrlr2gf++nPv8ooz3A= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH4PR02MB10681 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNzExMDA3MCBTYWx0ZWRfX1j7h1q7X6D7G lTdr0azZwOwPJYLYdZJezwzn+Ev6je2ikmitfx+2qdRtWBHvdjvDDT80uR1SOsFcYQ9enMLQ8Yx dGB6QkIHtPtuZnjYbw1OqDzCT45PghlINGoD/lHRXOqK3P5SgTJTDPLQYw4633txuZIV7SE/bep whAnviCIL9YrNVmfB3XR+chrT0PPDAbncwC9/Hv7W8YQ2ZTV2jYWaE+Z1Qz1q7vkxCRDpkdtJKk W2T4ll31fWGfS7h28KkszngTFPRW0DruNU1oXyZhyrRaKAdkFgtxOQPUZU9QL7zf1n7gklQxW3x MzRMV8ofjknCca9z9b3N60TDyfCrLAAXYHdO7FWrnZty4LcBxXK9m6xEEb447Se7DLxyFwe5CZ9 eAKmj3AB+iRA/gB7vMXtN9x8jYAnFZ+5MNQZ11VUDMKMkmIZQ5KMzGUrz4Ikey9zbTHeufT7 X-Proofpoint-ORIG-GUID: ndq7cmLf94A2g7DQ5qwSo_p6dAoIpkKW X-Authority-Analysis: v=2.4 cv=Do9W+H/+ c=1 sm=1 tr=0 ts=6870e040 cx=c_pps a=qdGNMY5putnn3dTEtBI8ag==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=xqWC_Br6kY4A:10 a=Wb1JkmetP80A:10 a=0kUYKlekyDsA:10 a=64Cc0HZtAAAA:8 a=2ibDuaHqQIY5G2AKcNYA:9 X-Proofpoint-GUID: ndq7cmLf94A2g7DQ5qwSo_p6dAoIpkKW X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.7,FMLib:17.12.80.40 definitions=2025-07-11_03,2025-07-09_01,2025-03-28_01 X-Proofpoint-Spam-Reason: safe Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=148.163.155.12; envelope-from=mark.caveayland@nutanix.com; helo=mx0b-002c1b01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @nutanix.com) X-ZM-MESSAGEID: 1752228151183116600 Content-Type: text/plain; charset="utf-8" This header is not required since the loader functionality is handled separ= ately by pc_memory_init() in pc.c. Signed-off-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- hw/i386/pc_piix.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index 34beea993e..4b0eeb4497 100644 --- a/hw/i386/pc_piix.c +++ b/hw/i386/pc_piix.c @@ -28,7 +28,6 @@ #include "qemu/units.h" #include "hw/char/parallel-isa.h" #include "hw/dma/i8257.h" -#include "hw/loader.h" #include "hw/i386/x86.h" #include "hw/i386/pc.h" #include "hw/i386/apic.h" --=20 2.43.0 From nobody Tue Dec 16 21:11:18 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass(p=none dis=none) header.from=nutanix.com ARC-Seal: i=2; a=rsa-sha256; t=1752228152; cv=pass; d=zohomail.com; s=zohoarc; b=m+F4sf5RLwSmPP2bpr1CYnQ7F+jv1uN42RoQE6bz+9CVx0BtnwnzW6s993vOv+A92A49Y4txzPETKAEIk4qzNUKxXACj0cUtN4gvPebfq8eHlMwGJ2PWSQP3uWQ13qP0qCknT6bb/m/eHvLoDuZf6L/wwbyWa79tywvYaUJczNo= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1752228152; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=8keZdesCieKMbzxNEOnjRTMZa8j163SPwSUtUHBnWQE=; b=W/XWS1c6R7EYrgC7LP9ycf1ALOXWxCgjhjglQQRAOQDP+wXHSNueCSZpxe8IITLKteZ2QWM8y+x9phiywahBSL0tEXsf7eexeTy9UuNZ5KT9Y2qE5dcKvv6y/57O2S3SwPdKKjx2eJOxJLjkE7qpIlHmE9KfrjfxABqrNlg8iJ0= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1752228152680728.450851343967; Fri, 11 Jul 2025 03:02:32 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uaAWa-0005S5-Qk; Fri, 11 Jul 2025 05:58:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uaAWZ-0005P8-Cc for qemu-devel@nongnu.org; Fri, 11 Jul 2025 05:58:35 -0400 Received: from mx0b-002c1b01.pphosted.com ([148.163.155.12]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uaAWU-0004kv-7M for qemu-devel@nongnu.org; Fri, 11 Jul 2025 05:58:35 -0400 Received: from pps.filterd (m0127843.ppops.net [127.0.0.1]) by mx0b-002c1b01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 56B7Msip016817; Fri, 11 Jul 2025 02:58:28 -0700 Received: from bn8pr05cu002.outbound.protection.outlook.com (mail-eastus2azon11021142.outbound.protection.outlook.com [52.101.57.142]) by mx0b-002c1b01.pphosted.com (PPS) with ESMTPS id 47ta49k6ce-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 11 Jul 2025 02:58:28 -0700 (PDT) Received: from PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) by CH4PR02MB10681.namprd02.prod.outlook.com (2603:10b6:610:246::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8901.23; Fri, 11 Jul 2025 09:58:26 +0000 Received: from PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88]) by PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88%5]) with mapi id 15.20.8901.028; Fri, 11 Jul 2025 09:58:26 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint20171006; bh=8keZdesCieKMbzxNEOnjRTMZa8j163SPwSUtUHBnW QE=; b=bYXU63rmNxlyKGkw9ZeqMozo8TWy4TAbna8E8kho68VyIQ5Y/6trxFe/j WgPacwARx1GjnOgY2Og89Sw4f7DURCvVaTXlSOlKoFvuxfaHtjsTeWgCAssGBIRU 89AvYXXlYsdZYwoBYR7Id9nqQnLUHIDTjaf9hKWRJZVUVxDkV6lFIo7iBq5I6X51 WruemTxSlEeeU3pOj38fHAyZQRiypYnIDtMkUN7AhnWvCTGFYOj1KKFWjPWxRPvj /CeR5sdBxw3hfT1qpxEEQe/4dCPAY1JLkfVDL0SdShZ3JglJOvRPw94vVwZgrqnk bDcPI9vamw3F38sus9AJSLjuOOw/A== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=wVgucecwI2Eg+mVSm4NFsHWY582l5h7e7+swWts2V7F0hKVZ+CjGu1C+dRhfCqtkqm8qLyRY5FS50ZxL0/04eQUzRe7dTy+QEiC0HV3TTAa24vzHisIPoi3Yub4iaAFsAxiIHP5CM4OR8JYguys0nQWLmqJ3RmxMhhJqJE0dUO2E/BcTNPYNIffSYcKo9e/Jkj6Dv0lTJ9b1Lshf21lK4X3itLW16AOF8XZSBqYtx+B7X5qZ0kNAToL6tgl7gdQhD5v9/K127vy6y7inxt5nwllKTHlCx251o1RWmpvlcVviQHvZzks9jxU3xaJBv9aD6pNcv8gcFEAVZGjw63S0UQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8keZdesCieKMbzxNEOnjRTMZa8j163SPwSUtUHBnWQE=; b=vEUn6hPnLUSV3rae/2MII4YZO6dhobTJiE5cTmoowIXLqIFnEsaYIbEcT7W8aDkOdYgbxno6uJ5LWj6dBw3H/z6O2vaUdTq6k2smuZXmYRVGMASi9wkF5CSjVVVdZtXMFzb3iAvSxKdGhNZ1NgCChHynOyJFV4Mt1cW9X6U9o1PjkquNSqoj8r3XAFZMSBhvcqP/1z18vMLiaqxeod/E3mi88L53Ea3FK/TZY7qf3OrNrZA5FoqOYmh2qe4JX0AG6AWK/SGCU+Eh76Ezgv976mvwM8Hn6RYMXrD43n5f90ArthWneZ2rpdDAQU812s8ENi3oWYy3t/ximsf8sXV1GQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8keZdesCieKMbzxNEOnjRTMZa8j163SPwSUtUHBnWQE=; b=ohug8+FAliwg9Sc5o5zyzel7JJIE5fTtsMcJj1zHVruRPEI/+f0MoBkhtkkqp2t41Mr3LXAVb58Fcjcpowc1+RqeACgMRHEUxCiceIpUGRipRbgTNjz1bajKKqFVq8o4e0hZZrDTLLwAahe/xxba7ycx2FBGtc8TStyN1JKMtr7Ul/Ox5qbv4dG+AmmE/jdcmFVaXHufEG0VNRrN8vg9DrzwQSqemb2Uh4eBfqfeHXC7ac39WK2upWXcSpQIQ3V/2lloGrVNz5XHbkVN21E8xljWmbPCMJzdfjASFWv+o84ud0e4StbsGviAGD+dPvXgL5Eb3+ZdpSX1QShnk6TpIQ== From: Mark Cave-Ayland To: pbonzini@redhat.com, mst@redhat.com, marcel.apfelbaum@gmail.com, eduardo@habkost.net, imammedo@redhat.com, qemu-devel@nongnu.org Subject: [PATCH v5 03/19] hw/i386/pc_piix.c: inline pc_xen_hvm_init_pci() into pc_xen_hvm_init() Date: Fri, 11 Jul 2025 10:57:05 +0100 Message-ID: <20250711095812.543857-4-mark.caveayland@nutanix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250711095812.543857-1-mark.caveayland@nutanix.com> References: <20250711095812.543857-1-mark.caveayland@nutanix.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: LO6P123CA0041.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:2fe::12) To PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR02MB7159:EE_|CH4PR02MB10681:EE_ X-MS-Office365-Filtering-Correlation-Id: 22cb2271-75da-446f-5b00-08ddc0617aec x-proofpoint-crosstenant: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|376014|10070799003|366016|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?bRlxH4pIUtzaa0+noJ065DR7UrZl0i6WnieRHYwABF7HzKiskspG0jVZtC0y?= =?us-ascii?Q?Bln0s77/Y/MZS4Ckhs23wFcw3q6r0ZccGbsGv9wwPtcmGXukGTaXi8n+FMfN?= =?us-ascii?Q?EjrJ7VoUD2wtjykYK9Awrvt4xUdQwsjMjedNmkzk2+QIy2D2SJwwajpHw5lp?= =?us-ascii?Q?cKPK6ComzseojZp0C8wOsZ+ro90HRpkeCC2w4WdTjOsC0qZGT7gUckb0XIUo?= =?us-ascii?Q?Kth/ThrmZVKq82INJj30yONUVkiM3Puw2s595CtY6Q/k7dkOrsNoOAyh6pCS?= =?us-ascii?Q?0Jt79YgT238CNmFAImOuFklAm5HcubhFjzkt9FtESJK04lmqu+W12lTH3E+X?= =?us-ascii?Q?gzMdiQfgriUOHSOET2nJQ3V5fFiBdd4BbUDpSR0hATdYt871Mmlc8uBZo7rr?= =?us-ascii?Q?q56ntDM5FiIbTGC2/n75HjFesQP8/8fnfL7pk7woenVQd6ozeSNw/FVcZC4Y?= =?us-ascii?Q?JoCOAWyd3379Ad/3TzXiJ6ETA2R3zkVxy1LEcdnFiodxmhAh6Xiri0d5ukDZ?= =?us-ascii?Q?aAhmbGSKpocVVnQvtWoVz61rVbp5vzEYFYpJ2L4xR51Kvx5ErtNqoR+7xX1s?= =?us-ascii?Q?T8fwrfHSSfg19WiatgdcKpSxFJPRKu3w5TKmxClscC5pGQRga9pGluNk9WQy?= =?us-ascii?Q?me9Ug3Nwz0xNmQOCUe4HRrRfWVqra26Z/tV5qbMbPNI7Rvna+3V+7NlViTtm?= =?us-ascii?Q?X9Bc/eD6x4VMvdOyKPNu/eYkUWTa5FPeCXflyrpfEOYUbpOOHyJd4xx+QyFa?= =?us-ascii?Q?bE6KhFmuHVGtenNJ11C15N7ffffUXXZDxcQjWnepQIBUFPjSBQjbysS71mNu?= =?us-ascii?Q?1+Mva2ENmB/dKZkU5WLkqBQhTfNEmZPw2CJXbOhBikWwUjPOqx49d/DPw3No?= =?us-ascii?Q?mTCtQwZ+NJZ70QmDz/fiYuiIGqwDbTy7Z6ne8tJaRSGFMN2X62HW4VwGJV5D?= =?us-ascii?Q?NyTSHEVEC8z/ikeypmLtgpLVgOvMMheoAqpzXexaMhLFbkomkk5voQRcfmEH?= =?us-ascii?Q?rHGv66S85pvQeVhkNU9JdEWPwjlaSkXDCrG9zdV1PHmCBwuczBoArve3WwVn?= =?us-ascii?Q?6j9iHIfZTd5QGYgXqnAWhXWDUgMV0UARX/O6S0cXdY37JQXNmgqObm9YLkoU?= =?us-ascii?Q?c5ZyIAsxhfJAttgYu9ItgTfTl/BIJCTIJgA1fp6DKEEbUp+TnK1p1OuHU5Q3?= =?us-ascii?Q?E+YoGSgKS3qZxmk7GcbdFLrQbcjFHBfC0KAyLVxChPP+VA2AFvR/Zb64lBsS?= =?us-ascii?Q?JYgd+DrstLU1+lfrUJFTlEzvDyvBnue7bALQmcr3baNrzeDwxl2ApoP1x4pY?= =?us-ascii?Q?p8bqSAqD+kfaebQATbnutouuaV5klSXTGVFU2mxIrJHGjVHr6D7XuHczRS4t?= =?us-ascii?Q?W65k9fXoTIUIyFNJJrQhyPzAXM5FQrLrQGhUrJND21Z+w+iQSwbvO4oNJIK7?= =?us-ascii?Q?5qUh+BdNvAg=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR02MB7159.namprd02.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(10070799003)(366016)(1800799024); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?PmPPj9C3sCj8SMvAh3GdH9HT6CxpHAX/SZ6vxKzWTfPm3TsSpfqTUu/zk7K1?= =?us-ascii?Q?CXnsU6FZbA2nZYZ4OieP4VIDI5e3QANEQX+M9E3nbr1hdTOENGU+b571p4XY?= =?us-ascii?Q?KhUcprcACgazDbFQDhP+ybdHv5gymncJpD5YsggayFf73oFrICz97lKDs9FB?= =?us-ascii?Q?FJSFOpQSG88K7F0Ut8Yd73LxGp5MVbjIwjGOhg+cd0S7xdgjO+0n+g+s/3Wj?= =?us-ascii?Q?AuoK+doJABQ4lR239mgZyfZ5yCpb0WdY2P5W8JTg+BrH6Q+3MoZ8v3Oa9EFX?= =?us-ascii?Q?t89Wj+RxYxAZpekHRxV2bAPn1mGcx5zY6uKq+q/N+PfR8uMC4ly5f7AIL8Vx?= =?us-ascii?Q?olnyyX7lfN0fgIDyZdMzlqZNOHkEhIQzJR7i6saXXVhKR4x4YzSMSn3eRFz7?= =?us-ascii?Q?WhmX07mQ/Fb7PuVMbtiMK4RKWR0+0hjEnj/zfW+++HKxgnQrYZk5jwFJeHPI?= =?us-ascii?Q?kN723pnPXQE6Z1+KPMIdxznvG0p9SX08wundVZ2oPVNQIDkInerh0setvJvS?= =?us-ascii?Q?z5RQz3GNVJJuAs56+gk0kJNdX2ce0I2u4NTcWPrqPvWZ/6hw1Nhv/rlXAEBp?= =?us-ascii?Q?x7He5pTcl7plO4w4x4/o+7N9ogUrCXtCU7uBrJeKWmBHd0FLtXV43VsgPDNw?= =?us-ascii?Q?Fg8BLBca9V88uPYIqrJ1xnO+6bdBJpFWUwy7ULDvvmWUNaVPQBQuz1iQyRvn?= =?us-ascii?Q?ug9+MC8t1MEMce9yJ+iATnaofs9JzIZ8rzgkFqPqcnv+G/00sh29057Asxeo?= =?us-ascii?Q?tZYKMAE+EjnJS8gSXLgXGmq/Z7ky+RmfF7+fRLZ5It7JVM2OGBh5h4JkLZi3?= =?us-ascii?Q?LdPV72PYcHTN5XgzQIixGKZfSn+/pZa8GRfLkxauT3f7WBl0yARGCydkVPIw?= =?us-ascii?Q?BrYgq7wmMmQC/+NpPXpmz1EiKFygFUCYqNrQvQKXLuNGqbIu4uJUrzEEOaQa?= =?us-ascii?Q?1HMoQ6Fgq4ebt3T6s7kfXp/fkcz7UrbDdvMlqJtKnSXyW/KON5C8kmt4Qprt?= =?us-ascii?Q?/bPVfre46lb2uiYiqlluL8iMa/8xf655x47XlIb0LpZsRSI6PR67+L7nbJ24?= =?us-ascii?Q?+9aSIqgJaFkj1M4IV4lpaDn5lfV8TgvUF/Gg3msnm5iSXMP41Bwu+gJ0t6gV?= =?us-ascii?Q?Zz7kygAxmx3FtG/Mr9OPEFYvAyYz0Iip3nCQY0ztI8v1QgWx/uaBGWfKOcHl?= =?us-ascii?Q?bpJ4wJ1WaultlmhDXeL3MUCX7jhKRoS6FprsDKMl9KdsQBRXfymZjwiRi+Bg?= =?us-ascii?Q?t3T1FnjDGsuAQ/p5kxNur9NryaXqQ7YgaRHndgfPjDS24WAkLgnacHFyanVN?= =?us-ascii?Q?I9WZlVEcp2W4KEJqeg02TueenL/BJIDGrcmZmgO37E4ZJCgHZ9JrXQ9tiCTu?= =?us-ascii?Q?Rss08HV6kGiq8edHMVj6TB5NjbNlQ//pt2JKp+yZ2tuZg0AGTATaSdmUwFhL?= =?us-ascii?Q?kQ4OHj98MOWeWZ5n62GillVNfYPkPk/8eBovw/BQiobtGIV/+NpR1wx71F8f?= =?us-ascii?Q?NVmcwKcAdFV0o+SGKXFukVnvmqZNwo9MW/q9ZqEgBdBc8VtYuJRH/7FAxVVw?= =?us-ascii?Q?S3l4QE+r27KN680zPZKZGCTB+5cLo/P2SRc/3RlRpo/jm/TatDYKN9lceO1/?= =?us-ascii?Q?0FNdcMvrfqofWDB4QLdhSMzgogajmlzDojAH/RBerBuNi63qwvSRCTQlWuwo?= =?us-ascii?Q?dMRNvA=3D=3D?= X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 22cb2271-75da-446f-5b00-08ddc0617aec X-MS-Exchange-CrossTenant-AuthSource: PH0PR02MB7159.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jul 2025 09:58:26.3824 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: UZd23qZl/SEZmfFz2b0UsvYTwEg5xeCJOBTNqWCv5UbHTvOSnjujWatOlKr4gD0x2P9oay9h/pu/PMTscAU3LbEA8LPNtl7noJ75tAjBYqo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH4PR02MB10681 X-Proofpoint-ORIG-GUID: prJckh8sGTFCs1WH_QcnKic1pD6jAzAj X-Proofpoint-GUID: prJckh8sGTFCs1WH_QcnKic1pD6jAzAj X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNzExMDA3MCBTYWx0ZWRfX3AZTgRUmoDWc LALh8PTVvmhRztQT+yBFUxbxSvmgLqJHtll4ytT+ICwo7tFHHM4zBSXktXB2Chfpp43Aq+YvsHu voG1EHlVKi47TvU58N+Cdr5O5PX9JtFUepKR3teLAUMCRsSiTq2xkfMkE3DXkwjmC0LV2iB9RnI lt2T86s65kyF9k7oH8KfbGrlw2K0CL8nzuX3UnwnjHNXx9rSftnfsFJZxMUmSYt71VMns1vD7xz TA5dlyQvcEdvZ0lJYjDHxtZAe6bPtnnIMrb6BFlRlpfiJ1tvG8GtKgo1KDtGZft1FKv8+9JMNm2 HC7qRYMN19LifE/xxqGjYY0TeRnWvBcWFBcQmwrJ+MCYk6hXyt7cJhf3FGkuZPDwgaBhVxCmdeu K4Pq9AO7iDFsjKW479fumwIwNo5EcSqr/oVJrzjTp/9s1cFJ9ExU0EUhek6e2KmoWMzT4M7m X-Authority-Analysis: v=2.4 cv=fNg53Yae c=1 sm=1 tr=0 ts=6870e044 cx=c_pps a=a1KkbayPxhvfYlTdgkZZag==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=xqWC_Br6kY4A:10 a=Wb1JkmetP80A:10 a=0kUYKlekyDsA:10 a=64Cc0HZtAAAA:8 a=MloeMuLfwZpfyPeI5kQA:9 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.7,FMLib:17.12.80.40 definitions=2025-07-11_03,2025-07-09_01,2025-03-28_01 X-Proofpoint-Spam-Reason: safe Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=148.163.155.12; envelope-from=mark.caveayland@nutanix.com; helo=mx0b-002c1b01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @nutanix.com) X-ZM-MESSAGEID: 1752228153117116600 Content-Type: text/plain; charset="utf-8" This helps to simplify the initialisation of the Xen hvm machine. Signed-off-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- hw/i386/pc_piix.c | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index 4b0eeb4497..b33480e203 100644 --- a/hw/i386/pc_piix.c +++ b/hw/i386/pc_piix.c @@ -435,14 +435,6 @@ static void pc_init_isa(MachineState *machine) #endif =20 #ifdef CONFIG_XEN -static void pc_xen_hvm_init_pci(MachineState *machine) -{ - const char *pci_type =3D xen_igd_gfx_pt_enabled() ? - TYPE_IGD_PASSTHROUGH_I440FX_PCI_DEVICE : TYPE_I440FX_PCI_D= EVICE; - - pc_init1(machine, pci_type); -} - static void pc_xen_hvm_init(MachineState *machine) { PCMachineState *pcms =3D PC_MACHINE(machine); @@ -452,7 +444,10 @@ static void pc_xen_hvm_init(MachineState *machine) exit(1); } =20 - pc_xen_hvm_init_pci(machine); + pc_init1(machine, xen_igd_gfx_pt_enabled() + ? TYPE_IGD_PASSTHROUGH_I440FX_PCI_DEVICE + : TYPE_I440FX_PCI_DEVICE); + xen_igd_reserve_slot(pcms->pcibus); pci_create_simple(pcms->pcibus, -1, "xen-platform"); } --=20 2.43.0 From nobody Tue Dec 16 21:11:18 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass(p=none dis=none) header.from=nutanix.com ARC-Seal: i=2; a=rsa-sha256; t=1752228087; cv=pass; d=zohomail.com; s=zohoarc; b=SRXKqh08vIf7497tYgB9sb0gMGJcnO71ORC14xCN1wASwgV3JYqWW18yv/rbEqp+ceMgLs31MTIA42q9SaHidcDvQLrv/iH1KLNNkhCK5Wk/8J/Z3vifsS5pCxiy7pVrkaOIibwtuFTl7qRoTfOiw/bm8K9bmSXJ5CAErUdqfO0= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1752228087; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=lAQVDGjhApLT3KTNAQprgusBIJzB0rhCV+T42QEq9qE=; b=NhDspKcBlwn3pyykE1hB1xtsr4gPHdtE+21kfOFS0lbWMJgbJN9o7fPikH59Rm5LOa4OqR2U7S6m940OcG2BtQU5eF4cd/uI0G0HlDs0OvWTxa2FhHz7tXfEUd9RjNbA/3lcmxP5QXBU+0w7OrhQ0mW61PP1rMYfeFcKjBV7/TA= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1752228087889353.68382696058904; Fri, 11 Jul 2025 03:01:27 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uaAWe-0005ZP-BR; Fri, 11 Jul 2025 05:58:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uaAWb-0005TF-Pq for qemu-devel@nongnu.org; Fri, 11 Jul 2025 05:58:38 -0400 Received: from mx0b-002c1b01.pphosted.com ([148.163.155.12]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uaAWZ-0004mN-FU for qemu-devel@nongnu.org; Fri, 11 Jul 2025 05:58:37 -0400 Received: from pps.filterd (m0127841.ppops.net [127.0.0.1]) by mx0b-002c1b01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 56B79cbe032134; Fri, 11 Jul 2025 02:58:33 -0700 Received: from bn8pr05cu002.outbound.protection.outlook.com (mail-eastus2azon11021116.outbound.protection.outlook.com [52.101.57.116]) by mx0b-002c1b01.pphosted.com (PPS) with ESMTPS id 47q1karqm1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 11 Jul 2025 02:58:33 -0700 (PDT) Received: from PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) by CH4PR02MB10681.namprd02.prod.outlook.com (2603:10b6:610:246::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8901.23; Fri, 11 Jul 2025 09:58:31 +0000 Received: from PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88]) by PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88%5]) with mapi id 15.20.8901.028; Fri, 11 Jul 2025 09:58:31 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint20171006; bh=lAQVDGjhApLT3KTNAQprgusBIJzB0rhCV+T42QEq9 qE=; b=BaG/D0Y0nIFzM+AqFMCOVa1hCiIRiFczyi9ibFHT21OPFSr0q1UoiDrge ipis32ygy0A7CXQf0ZziznlP69vF/b9uJwivl5lt7G+6vVGJjgfiSajNVNl+x8vr a6smVvHe0HZuFJ3I1gPYK9pPiVB+fD/tp/of4s6hCxdtkybdfpID3EJHLl8aQtnQ OksguaGYDvOFP2f9TDwEj30nXINt/pZDxk9uDkEuQcEiseKpT9cJ9V7UjUu1XO7I 1OFGr3upJ46di3oo4M8tP2b/+TT4Dl/KFQUdK9BOEkri6PBPaFsWMaHSZhX8Mk/K mRj3ConSAqod2KlQ8ote3ixiwRiEA== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=HkKNWJkAjqUJsQlJbAQIFOb89h7V5MdPhozrNrYqbS4MtmMySDv4p4G3xPME1CcuDPAB0REo5lo3Z5jjT6x/50m541HN0hi6792QQonyzVVhbPJ2W32jQw0YtjtRGpo1NS8ZF72laX/eAKxVvFOyquiuffv/VT29n46Wg0nTPOX8rnKYRFulILSXRuXlhFgMVdOMRA6Fc6Lvg2veGVxSFkan7v32f8d5slg05agAo1XRjLFO+gZN69z76ivX/HbP5s2L0fU/1WOGfNd7roQIJVrwtYsb/DdTPfncjBqBwXiY5UNreRK2tQ+W3s73TDGKz1iBtc2MeO1nWGtrP1qG3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lAQVDGjhApLT3KTNAQprgusBIJzB0rhCV+T42QEq9qE=; b=wQJOt2xkKjRexqdYT2i/Kx3vN7M8uuKNhrUKVRn92DinSyDBXQx7A2btH9LIvCX7o+nWThqB5ef5Vj1KqbIGP4TXTJ45yMXIleoWI3Bl2gMD+EHZcQ2NWQ6MZnaLXxs2Y4eiVWPLSdHlDzVRm3yRDDC9ZX8bGVy3JDGtWTbUHr2laZUBSn44B/BNY5OpX1ttWWPVa9dydH+uutlo7vGFnItST6VhnrwHiHTNxEbaUYcrpcvSSVS4cPw8fU7L7PoxtcyaUQ5WoT2vOzCKuxQuIBJdovaIEfuYSkcsN2xTHOTikZl/iyTftaX53revoM5UTXgVj+GvSRrKURaHxyXA9w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lAQVDGjhApLT3KTNAQprgusBIJzB0rhCV+T42QEq9qE=; b=QutVg4iKuk+bf6n/wDCkByQYc69lFebnEsbeA9+tDaWq/GNWo/OANjEcETtXBRP8+eiNFqvKmfet3g+wsXmOEZv6QFEK8RuvxlW5go5BOVW9EEn34jRjjawPAG6cSQu4COc+SS+KcvehpKTXudRhDgOcUh0818QliP6PwnOpHmR3Vdhop87TFU6adWUhC2PRGYxzARyQ8sQqa1a4RWHzMKhsDTC9J6WFgmBFlHdekK/4WlWOD6sNm+hkFGzc6jPX2taL1LcofqE7dKv+xfgIzOB82XPslNN62pZH7hMEThR6i6uGELCW9DYWOnvO8GHEDfogn/D4bEs14T32RzzU0A== From: Mark Cave-Ayland To: pbonzini@redhat.com, mst@redhat.com, marcel.apfelbaum@gmail.com, eduardo@habkost.net, imammedo@redhat.com, qemu-devel@nongnu.org Subject: [PATCH v5 04/19] hw/i386/pc_piix.c: duplicate pc_init1() into pc_isa_init() Date: Fri, 11 Jul 2025 10:57:06 +0100 Message-ID: <20250711095812.543857-5-mark.caveayland@nutanix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250711095812.543857-1-mark.caveayland@nutanix.com> References: <20250711095812.543857-1-mark.caveayland@nutanix.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: LO6P265CA0029.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2ff::15) To PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR02MB7159:EE_|CH4PR02MB10681:EE_ X-MS-Office365-Filtering-Correlation-Id: 98041530-421a-476f-ffe9-08ddc0617dbc x-proofpoint-crosstenant: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|376014|10070799003|366016|1800799024; X-Microsoft-Antispam-Message-Info: =?utf-8?B?cTJRNE9sQU9BOXBQY1BVMUFOaWdFVXhCVkpRZ0lnVFFhV2xQSG5KZi9NRG50?= =?utf-8?B?STNEcTFvWnREVTVwQTF2SHJPZG5Geko4RWc0cThXdStDbEJDZG82T2dWZ3d6?= =?utf-8?B?aXNvRzNyZUlXNXNhakt5ZUdXdWEzWmxaYUROYmgzZDlFQml6YVIwVzlqMzdV?= =?utf-8?B?NStuSlBWSGFIVFd5QVEyb2dTY3FMOFY1Nk0vM3dDc05Md1c1NTdNOTFiYXdv?= =?utf-8?B?Tit0ZUplT21aU1YwVWkyaTlRODNlT1ZObHFkZVVicUh5V05GcGNKSXlxcEtr?= =?utf-8?B?ZXNZemJQSE9aVmlkYWhyYlR1QnVubzVhS1JvbTNmeXZvbmxVT1pxTW93aDBM?= =?utf-8?B?djA3ekhieDlzY1lqWW9ST3YxeksrOCtFbUllOE5DVWtPR3pSRUUxZWY0Qjcy?= =?utf-8?B?ZnFPSmJhWTVCMS9IbHF1ZS80QUptcGRkczh2SmdQeGRrZm9jK3dOajNESUNB?= =?utf-8?B?akhZYlFvWkhoTkw2cVYwQlJiamI4UFhtSlhwMWVPMDNOMUpmNEhWYjhvb1dN?= =?utf-8?B?VzlNTE43TE90TFgxZS9GcEdTc0lyK293YlEreUJXL2R1SjJYbUlBUkxLRWh6?= =?utf-8?B?TXk5NjFxU1o2U3dQdmxacnRiSjluWUFqaWJvVUgwZnB3UURmRlY4c3NabHFD?= =?utf-8?B?R3VnMndXUnZsVnZKOGNJckx5ZExQQk9YeFE4RmRkVmtxMWgyRXFUL1Y3Y05y?= =?utf-8?B?NG1oc1ZiUUV0eEwrbGZVYUJVb09kNFFJVithcVErWGl2YU0xQUhZUXdBanhP?= =?utf-8?B?bktTeVVZcTdqWXNrajhtamRmTHVpVWg2S3NPYmY1SHRNa1hJS2U1TkVKeHJq?= =?utf-8?B?aFFScklTckQ3bWdUT3AvNHdsWWR1b2VaaXVtNkhFWHlxdEd1NitYamZnT0tU?= =?utf-8?B?bWMyL0NzVFBSaWRoSG9lam82REZaZnNablJITmJzbWhqV2d3c3g1Q2twM2JD?= =?utf-8?B?a3IwQmJlWkt2am5DRldCcVJMYzNrRHZuT0pmT21MZzFyZmxBTHdWbTZmWkFq?= =?utf-8?B?MzBPSXI1ZWdKcWtKSEE5ckJSWEFUNGFtcUZQMzBHZnFDZjJGVmFyNWhYVFdP?= =?utf-8?B?ZkFHekp4WWxZVmRwMHV6WWYwSGpMWE9Ic21mY0lLZDhHMnhXckNoZTJ4QStR?= =?utf-8?B?QnVHcXd3ZHlkZTJJVCs2UVRteVQ4VGtwekx1R3dIa2lPbUEzTm9NV21Bd0F1?= =?utf-8?B?bDZlbm10YWs4bldXdlF4L1poNzRyYXRKSDdMVnpzeFpSc1MwR1lzeFNtVmM0?= =?utf-8?B?OGV1NTZ0YnVVTVpKVThiTm1OcFpHcVpubW1SK1Z1Qnlpa0g4a1JuMU43ek9x?= =?utf-8?B?bWE2dEdubUoxWGxSNkNGNHZpK2FiNmdiaDIzTTlsYkUzVVl6dGN6em5Ld3FZ?= =?utf-8?B?SkRsLzk1RC9welZJbkVrTHAzNHFOOCtKRjJNSWlzVnlBOEcrb0sxdjFyYTNq?= =?utf-8?B?VEV6d1d4UGJnWDBveThiNnQxOEswV0ZVZ3BFQlVKN2Nad1l0bGFhUEUzY0xG?= =?utf-8?B?RzRpczJFS2h3d0YxalBrYTRDU0RyT0Z4OWxWWGh6N045a3Z1cnlFL3BhZG5a?= =?utf-8?B?VlN1YlJQKzNaYjZJVHZBbGJZMi9ZSFIwVWVod1kvSHRVdlBWRHRiZmVKUWJC?= =?utf-8?B?eGxNQUhGUWZnZ0VabCs1OXFQTVA1TVo1Y05NelE2L2FaMkVXNVo1MVBrNEJT?= =?utf-8?B?VVJwVlNVdy9MVWF3Nnkybk4zVWFtM3RYeXZ6OTgvdUZveDlobEpIWnhlaVpN?= =?utf-8?B?djREZ3NscFZkSFJQVkVxUTlDVm02VHViWHg1QnhQazRNYVVYYmNsNGt2dURP?= =?utf-8?B?ejdTYTgxT0lGMHAxOVl4ck8vT0MwMS9ObTltNmd4SUM5L0E1bThzR0ZJSDV0?= =?utf-8?B?K1J5WjJCNWltc1BMM1NXaEpucGZXKy9GZXdwQzNtbXIwYnRxTlJaV3lha2N2?= =?utf-8?Q?kf3M452ZgTA=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR02MB7159.namprd02.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(10070799003)(366016)(1800799024); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Y0ZDQTEvNUN3T1o0OHR3WGJYaFhhR2d4Y3VHK0tuOTZ3Z1N2bEJZS3NxNys5?= =?utf-8?B?Q3diMkwvbnhSdnArZEZ3N1ZBOXF1Vnk4UFVYTTZFQkx0VTNvWjdSQ0ltQlBx?= =?utf-8?B?TnJhbFdkd293UTJnZlJKYlg4M2l0bDlCeS9HZFovelJDb2t6cmtSTmhqcU9o?= =?utf-8?B?NkJvbDdmenVUb3NlWWkya1ZRMHpUYWt5VjJWVVZpUk14NTlYMkVobzJxaG45?= =?utf-8?B?TWZ3Rll6d0l3WlkvMklTTTNSR05mTHFNUXhuQ3hUNkE2L1dseUFGS1lnQ3B6?= =?utf-8?B?Z0YrQ0ZhUGtuTDIwWkVrTlkvZWo2ajltUVA2bmhwSjRwb2lnZjVQWk5GZUk5?= =?utf-8?B?bkdIdmNkay9YRm5NZDlWSFlOVGhNNklKbnBJV0dYZ1BCZWFiYnZQQmxIbXA4?= =?utf-8?B?ZFBzdnA5T1pLV0NzM20zSGVEekxERlR2bmxFUjh3eGcyK0RmS2k3aUdQWGVx?= =?utf-8?B?TVVyUnNxS2EzUDBlNlR2V3l6Qm9HNGcwU3FINS8xRUwrR01xbDBHaXVsS2Z6?= =?utf-8?B?RzFHdkZuRHZVYW94bzA1VWlSQ1pqcThEc3JadXlIekR1dzhPanBFKzVTZ01H?= =?utf-8?B?S2JwYTF2ZkN6SFNXbXphS1VGSDg5Uy9sZlU3MTdLbzlBYTIzZFRRS2R5eGNK?= =?utf-8?B?c3ZRSXFhRDQ4WkZyVnJ0T0JBdEVHK3diZUhWMHJvaVJqbk5DUXZ5QXRmYU1Z?= =?utf-8?B?Q1NQZFJxTk5XZElZYzZVT3pxU1g1eHJ6VW5vd2Q0VUxxbk9XcDhNVUtLd0U3?= =?utf-8?B?anZFRzZxTnN0UzgwU2h5VjdZL0JONHIwNUFNNEQ1a1BWMUpxVi83Q28yNi92?= =?utf-8?B?M0JsTjFxK2xIcE9aU2NNeG9Ubm5oRjNDNDJvVWl6TWRWNUVaK0JKY0NxU1Rj?= =?utf-8?B?YXZlVXpWd0ZIOUQzZ0F1WSt6YzJhUXhucHk5OW45elQ0Wkc0RXJNYzFrbDBB?= =?utf-8?B?SFFIVUFGeEF0d3BYdkNHbzdxRVcyeHJjTGZVVkxsR0lMR0FCUnp4OWhoRlVG?= =?utf-8?B?U2QrRnFpMGRJd3ZzZkljcWdydlFvY1FCaGNkaXRGQ05IamgvWmNUWGFzQWRv?= =?utf-8?B?eVlzK0VJL2U2WThqZlB1cDViSVNIZk9QSzZyNEYxOTNRaWJ2MGZWTHpBT3cr?= =?utf-8?B?eUtNUHpQaXA0VSsvREVqTjNNWVpSQ3BzMUcrN05FNHRwbzh4UVBoVkNXOHNL?= =?utf-8?B?c1N2ZEtjbUNES1djK1BuR20vMUtZZ3lPTTNzc3F4RFlienJRcVk1SDUxaGxr?= =?utf-8?B?K21tcDAvNEZhYklIOVZ1Z29lTkRUS3p3aU55UWNYV2NVNFA5b01MTFp4ZTFt?= =?utf-8?B?L1NCcGNkQjJJbGNQckNmejNGYVRsSXFlMG9PN0JLbUNVcXhGNUp1bHBwdGcw?= =?utf-8?B?OFAyUCtjcHBtVTRnSkRzbEV6cjlHcEZCQVMxUEFQM0hhWGY1d0RJcHlMM3ZF?= =?utf-8?B?dDNidVgyZDRZc2M0azhmdE1IVzFnVlVQRjM2MFlFei9MYW92dzhwNTBnbExY?= =?utf-8?B?QTQza2hMK1NZQ0hxRjVRNGV3QUsrR2E2SGlsWmRVRm9SMmhpdjdMUEVLYzZT?= =?utf-8?B?QVVjQ0lkcWE4KzNhc0cya3czYk1DT3VGbWhEMEIwK2VOSVRCUE9ZU0RBUUNC?= =?utf-8?B?UDBaY2l6RGhMcXRhVHhUem92T3RTRlExVkNNZlR2SzVSNHBBYzR3OXBXM1Br?= =?utf-8?B?ejJ4MkxGcW9ZNTk1YkVnSVZxLytOZ0QvTGVPelMyekN5cjFHMjZaK2FiS0V1?= =?utf-8?B?bk9KOXorcm9FbmozOHkxV1VFdkhGMHR2UUZRNGM1clFaZSs1c2U2UE9mclZk?= =?utf-8?B?S1lvZXZVc1hoekx6TDhNdnZnZFdHUkZ1YjBBOWcwT1NKVm40UVR5T0NCK1VV?= =?utf-8?B?QjNZRjFHTWFWNktMWnpEeVZ6WmZLbjZiYWhwMFU4SDF5T041WXRPMlJxTTN2?= =?utf-8?B?OWpVQmEzSGtwa2k3eXJ2TGY2WVQyNSs0aXh5UWF6TjhCb1FpVlcvZ3krNHJN?= =?utf-8?B?NFM0N1I0VjFlenJ5dHBHRGlLUTg0WUxXblA0YnI1eHdyVHJYUzdjT1JvY2ZE?= =?utf-8?B?eTZTbDJsR0hsQVlSN0NlamJoTmtXenpLZkpkbFY3ZEZpQmRCYm1OR1RyNi9Z?= =?utf-8?B?UEl2eno4aWh0RFo4ckxSVUV1eUt5b0JOb213NmRDU2tRK3FQam9YT0tzZjlq?= =?utf-8?B?VjVjelZpQWlOcXNWS3M5TVlWSCtPTzdTT09YVEZzN2VsMWJNM3V5Si8vLzBn?= =?utf-8?B?aXdmZWYyQ0JUd0srK21XN1BQRlZnPT0=?= X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 98041530-421a-476f-ffe9-08ddc0617dbc X-MS-Exchange-CrossTenant-AuthSource: PH0PR02MB7159.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jul 2025 09:58:31.2453 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: CAw8BJ65ZreCRpA2fxG//Cn7oWgYibLEtk7Uuc3X+9cCRdKApR9RZVSieLAAgnmp9+Ddj9iL6GZ6EhfEPG6rXo9KWV9ehYm4ycT69MS9o2g= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH4PR02MB10681 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNzExMDA3MCBTYWx0ZWRfXwCd4VXeC0Er9 D2I3v3cM2NBaZcM7hB2LUPtbQyoc+R4nAlzvL4/GpX4mrJGtwjsyl/xagDNFABZTPO6AysD4VdF dsobFg0LJJdZJ2nZgea2ynCITv6JTTmpIE1ujHnIZdxESySsV29JFd9RlnCip+FDIXAZwAvUAOr AkghE2T19WrzXf+LmDj/JuBbjOjDIpAKieKlYsi49nfNA4YY96o5IellLqMRqCEeiIPVlhH8om7 azuw1fzu6PXNnFgFoXXIx50XAP54W65JPKGdrWapm9YWft+N26qxorVcv7z8CCwSP+Djne/5C7D r9Jr2MH8vpye+Rw7CUcWmZ7DuJFeHwXxflBl+yTQUNOZ+mTkQhkFcs3x92YDi5DgtNI2ryhBtim KjS+mdVy2tX5D8jRNCk3xOso4h0Lw1vRILcfaMA5yTZTwg0a+67VsYNqsoWWWyxH34JSHaqV X-Proofpoint-ORIG-GUID: QxHaBjf-kOLXTBzQqYSU78ppme_W0_hA X-Authority-Analysis: v=2.4 cv=Do9W+H/+ c=1 sm=1 tr=0 ts=6870e049 cx=c_pps a=VPmHu6eXMPg+68oZcjUWEA==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Wb1JkmetP80A:10 a=0kUYKlekyDsA:10 a=64Cc0HZtAAAA:8 a=KKAkSRfTAAAA:8 a=EScErfUSVzH1iicdKiYA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-GUID: QxHaBjf-kOLXTBzQqYSU78ppme_W0_hA X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.7,FMLib:17.12.80.40 definitions=2025-07-11_03,2025-07-09_01,2025-03-28_01 X-Proofpoint-Spam-Reason: safe Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=148.163.155.12; envelope-from=mark.caveayland@nutanix.com; helo=mx0b-002c1b01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @nutanix.com) X-ZM-MESSAGEID: 1752228088597116600 This is to prepare for splitting the isapc machine into its own separate fi= le. Signed-off-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- hw/i386/pc_piix.c | 261 +++++++++++++++++++++++++++++++++++++++++++++- 1 file changed, 260 insertions(+), 1 deletion(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index b33480e203..f576e98727 100644 --- a/hw/i386/pc_piix.c +++ b/hw/i386/pc_piix.c @@ -417,6 +417,87 @@ static void pc_set_south_bridge(Object *obj, int value= , Error **errp) #ifdef CONFIG_ISAPC static void pc_init_isa(MachineState *machine) { + const char *pci_type =3D NULL; + PCMachineState *pcms =3D PC_MACHINE(machine); + PCMachineClass *pcmc =3D PC_MACHINE_GET_CLASS(pcms); + X86MachineState *x86ms =3D X86_MACHINE(machine); + MemoryRegion *system_memory =3D get_system_memory(); + MemoryRegion *system_io =3D get_system_io(); + Object *phb =3D NULL; + ISABus *isa_bus; + Object *piix4_pm =3D NULL; + qemu_irq smi_irq; + GSIState *gsi_state; + MemoryRegion *ram_memory; + MemoryRegion *pci_memory =3D NULL; + MemoryRegion *rom_memory =3D system_memory; + ram_addr_t lowmem; + uint64_t hole64_size =3D 0; + + /* + * Calculate ram split, for memory below and above 4G. It's a bit + * complicated for backward compatibility reasons ... + * + * - Traditional split is 3.5G (lowmem =3D 0xe0000000). This is the + * default value for max_ram_below_4g now. + * + * - Then, to gigabyte align the memory, we move the split to 3G + * (lowmem =3D 0xc0000000). But only in case we have to split in + * the first place, i.e. ram_size is larger than (traditional) + * lowmem. And for new machine types (gigabyte_align =3D true) + * only, for live migration compatibility reasons. + * + * - Next the max-ram-below-4g option was added, which allowed to + * reduce lowmem to a smaller value, to allow a larger PCI I/O + * window below 4G. qemu doesn't enforce gigabyte alignment here, + * but prints a warning. + * + * - Finally max-ram-below-4g got updated to also allow raising lowme= m, + * so legacy non-PAE guests can get as much memory as possible in + * the 32bit address space below 4G. + * + * - Note that Xen has its own ram setup code in xen_ram_init(), + * called via xen_hvm_init_pc(). + * + * Examples: + * qemu -M pc-1.7 -m 4G (old default) -> 3584M low, 512M high + * qemu -M pc -m 4G (new default) -> 3072M low, 1024M high + * qemu -M pc,max-ram-below-4g=3D2G -m 4G -> 2048M low, 2048M h= igh + * qemu -M pc,max-ram-below-4g=3D4G -m 3968M -> 3968M low (=3D4G-1= 28M) + */ + if (xen_enabled()) { + xen_hvm_init_pc(pcms, &ram_memory); + } else { + ram_memory =3D machine->ram; + if (!pcms->max_ram_below_4g) { + pcms->max_ram_below_4g =3D 0xe0000000; /* default: 3.5G */ + } + lowmem =3D pcms->max_ram_below_4g; + if (machine->ram_size >=3D pcms->max_ram_below_4g) { + if (pcmc->gigabyte_align) { + if (lowmem > 0xc0000000) { + lowmem =3D 0xc0000000; + } + if (lowmem & (1 * GiB - 1)) { + warn_report("Large machine and max_ram_below_4g " + "(%" PRIu64 ") not a multiple of 1G; " + "possible bad performance.", + pcms->max_ram_below_4g); + } + } + } + + if (machine->ram_size >=3D lowmem) { + x86ms->above_4g_mem_size =3D machine->ram_size - lowmem; + x86ms->below_4g_mem_size =3D lowmem; + } else { + x86ms->above_4g_mem_size =3D 0; + x86ms->below_4g_mem_size =3D machine->ram_size; + } + } + + pc_machine_init_sgx_epc(pcms); + /* * There is a small chance that someone unintentionally passes "-cpu m= ax" * for the isapc machine, which will provide a much more modern 32-bit @@ -430,7 +511,185 @@ static void pc_init_isa(MachineState *machine) warn_report("-cpu max is invalid for isapc machine, using pentium3= "); } =20 - pc_init1(machine, NULL); + x86_cpus_init(x86ms, pcmc->default_cpu_version); + + if (kvm_enabled()) { + kvmclock_create(pcmc->kvmclock_create_always); + } + + if (pcmc->pci_enabled) { + pci_memory =3D g_new(MemoryRegion, 1); + memory_region_init(pci_memory, NULL, "pci", UINT64_MAX); + rom_memory =3D pci_memory; + + phb =3D OBJECT(qdev_new(TYPE_I440FX_PCI_HOST_BRIDGE)); + object_property_add_child(OBJECT(machine), "i440fx", phb); + object_property_set_link(phb, PCI_HOST_PROP_RAM_MEM, + OBJECT(ram_memory), &error_fatal); + object_property_set_link(phb, PCI_HOST_PROP_PCI_MEM, + OBJECT(pci_memory), &error_fatal); + object_property_set_link(phb, PCI_HOST_PROP_SYSTEM_MEM, + OBJECT(system_memory), &error_fatal); + object_property_set_link(phb, PCI_HOST_PROP_IO_MEM, + OBJECT(system_io), &error_fatal); + object_property_set_uint(phb, PCI_HOST_BELOW_4G_MEM_SIZE, + x86ms->below_4g_mem_size, &error_fatal); + object_property_set_uint(phb, PCI_HOST_ABOVE_4G_MEM_SIZE, + x86ms->above_4g_mem_size, &error_fatal); + object_property_set_str(phb, I440FX_HOST_PROP_PCI_TYPE, pci_type, + &error_fatal); + sysbus_realize_and_unref(SYS_BUS_DEVICE(phb), &error_fatal); + + pcms->pcibus =3D PCI_BUS(qdev_get_child_bus(DEVICE(phb), "pci.0")); + pci_bus_map_irqs(pcms->pcibus, + xen_enabled() ? xen_pci_slot_get_pirq + : pc_pci_slot_get_pirq); + + hole64_size =3D object_property_get_uint(phb, + PCI_HOST_PROP_PCI_HOLE64_SI= ZE, + &error_abort); + } + + /* allocate ram and load rom/bios */ + if (!xen_enabled()) { + pc_memory_init(pcms, system_memory, rom_memory, hole64_size); + } else { + assert(machine->ram_size =3D=3D x86ms->below_4g_mem_size + + x86ms->above_4g_mem_size); + + pc_system_flash_cleanup_unused(pcms); + if (machine->kernel_filename !=3D NULL) { + /* For xen HVM direct kernel boot, load linux here */ + xen_load_linux(pcms); + } + } + + gsi_state =3D pc_gsi_create(&x86ms->gsi, pcmc->pci_enabled); + + if (pcmc->pci_enabled) { + PCIDevice *pci_dev; + DeviceState *dev; + size_t i; + + pci_dev =3D pci_new_multifunction(-1, pcms->south_bridge); + object_property_set_bool(OBJECT(pci_dev), "has-usb", + machine_usb(machine), &error_abort); + object_property_set_bool(OBJECT(pci_dev), "has-acpi", + x86_machine_is_acpi_enabled(x86ms), + &error_abort); + object_property_set_bool(OBJECT(pci_dev), "has-pic", false, + &error_abort); + object_property_set_bool(OBJECT(pci_dev), "has-pit", false, + &error_abort); + qdev_prop_set_uint32(DEVICE(pci_dev), "smb_io_base", 0xb100); + object_property_set_bool(OBJECT(pci_dev), "smm-enabled", + x86_machine_is_smm_enabled(x86ms), + &error_abort); + dev =3D DEVICE(pci_dev); + for (i =3D 0; i < ISA_NUM_IRQS; i++) { + qdev_connect_gpio_out_named(dev, "isa-irqs", i, x86ms->gsi[i]); + } + pci_realize_and_unref(pci_dev, pcms->pcibus, &error_fatal); + + if (xen_enabled()) { + pci_device_set_intx_routing_notifier( + pci_dev, piix_intx_routing_notifier_xen); + + /* + * Xen supports additional interrupt routes from the PCI devic= es to + * the IOAPIC: the four pins of each PCI device on the bus are= also + * connected to the IOAPIC directly. + * These additional routes can be discovered through ACPI. + */ + pci_bus_irqs(pcms->pcibus, xen_intx_set_irq, pci_dev, + XEN_IOAPIC_NUM_PIRQS); + } + + isa_bus =3D ISA_BUS(qdev_get_child_bus(DEVICE(pci_dev), "isa.0")); + x86ms->rtc =3D ISA_DEVICE(object_resolve_path_component(OBJECT(pci= _dev), + "rtc")); + piix4_pm =3D object_resolve_path_component(OBJECT(pci_dev), "pm"); + dev =3D DEVICE(object_resolve_path_component(OBJECT(pci_dev), "ide= ")); + pci_ide_create_devs(PCI_DEVICE(dev)); + pcms->idebus[0] =3D qdev_get_child_bus(dev, "ide.0"); + pcms->idebus[1] =3D qdev_get_child_bus(dev, "ide.1"); + } else { + isa_bus =3D isa_bus_new(NULL, system_memory, system_io, + &error_abort); + isa_bus_register_input_irqs(isa_bus, x86ms->gsi); + + x86ms->rtc =3D isa_new(TYPE_MC146818_RTC); + qdev_prop_set_int32(DEVICE(x86ms->rtc), "base_year", 2000); + isa_realize_and_unref(x86ms->rtc, isa_bus, &error_fatal); + + i8257_dma_init(OBJECT(machine), isa_bus, 0); + pcms->hpet_enabled =3D false; + } + + if (x86ms->pic =3D=3D ON_OFF_AUTO_ON || x86ms->pic =3D=3D ON_OFF_AUTO_= AUTO) { + pc_i8259_create(isa_bus, gsi_state->i8259_irq); + } + + if (phb) { + ioapic_init_gsi(gsi_state, phb); + } + + if (tcg_enabled()) { + x86_register_ferr_irq(x86ms->gsi[13]); + } + + pc_vga_init(isa_bus, pcmc->pci_enabled ? pcms->pcibus : NULL); + + /* init basic PC hardware */ + pc_basic_device_init(pcms, isa_bus, x86ms->gsi, x86ms->rtc, + !MACHINE_CLASS(pcmc)->no_floppy, 0x4); + + pc_nic_init(pcmc, isa_bus, pcms->pcibus); + +#ifdef CONFIG_IDE_ISA + if (!pcmc->pci_enabled) { + DriveInfo *hd[MAX_IDE_BUS * MAX_IDE_DEVS]; + int i; + + ide_drive_get(hd, ARRAY_SIZE(hd)); + for (i =3D 0; i < MAX_IDE_BUS; i++) { + ISADevice *dev; + char busname[] =3D "ide.0"; + dev =3D isa_ide_init(isa_bus, ide_iobase[i], ide_iobase2[i], + ide_irq[i], + hd[MAX_IDE_DEVS * i], hd[MAX_IDE_DEVS * i += 1]); + /* + * The ide bus name is ide.0 for the first bus and ide.1 for t= he + * second one. + */ + busname[4] =3D '0' + i; + pcms->idebus[i] =3D qdev_get_child_bus(DEVICE(dev), busname); + } + } +#endif + + if (piix4_pm) { + smi_irq =3D qemu_allocate_irq(pc_acpi_smi_interrupt, first_cpu, 0); + + qdev_connect_gpio_out_named(DEVICE(piix4_pm), "smi-irq", 0, smi_ir= q); + pcms->smbus =3D I2C_BUS(qdev_get_child_bus(DEVICE(piix4_pm), "i2c"= )); + /* TODO: Populate SPD eeprom data. */ + smbus_eeprom_init(pcms->smbus, 8, NULL, 0); + + object_property_add_link(OBJECT(machine), PC_MACHINE_ACPI_DEVICE_P= ROP, + TYPE_HOTPLUG_HANDLER, + (Object **)&x86ms->acpi_dev, + object_property_allow_set_link, + OBJ_PROP_LINK_STRONG); + object_property_set_link(OBJECT(machine), PC_MACHINE_ACPI_DEVICE_P= ROP, + piix4_pm, &error_abort); + } + + if (machine->nvdimms_state->is_enabled) { + nvdimm_init_acpi_state(machine->nvdimms_state, system_io, + x86_nvdimm_acpi_dsmio, + x86ms->fw_cfg, OBJECT(pcms)); + } } #endif =20 --=20 2.43.0 From nobody Tue Dec 16 21:11:18 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass(p=none dis=none) header.from=nutanix.com ARC-Seal: i=2; a=rsa-sha256; t=1752228388; cv=pass; d=zohomail.com; s=zohoarc; b=Uz7GYdmSqUkqOqPOSmElk4G8vnmV5jisPYUqQ15B4jT/wyrIpwnmjvpbxpZuJ1Q1fQyZQxKjVbsedZxSXAZh9G/i6L9me667+1yJIP3Nyyv0Oawtx/4WXLnwONTmf/6Bb8JypfQjRd4mRtX4CApa7QLJjZJ8IT12EkbOeBpf9ns= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1752228388; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=aHCHF4ZoZc+/RdpXMdrFR5mJCRLMp3UlYBKDQGHZcMA=; b=jJ/moRydPjf8VBNlqV7uAR4sWdS7addarMSLB8+tOR57ZwBM21mBfSq6YIf68H7l5eLw/W9RsSi2NrcSczyvtApDH4caTF/Bm0Npx65DPE9BBiQfHY8/ZhvPPrhGVSguwVj+mn6gRC0MdR6izPbaAEKMjVb0gCzHiwrUpahVOd0= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1752228388569709.4970242385764; Fri, 11 Jul 2025 03:06:28 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uaAWi-0005hq-G7; Fri, 11 Jul 2025 05:58:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uaAWg-0005dI-Kt for qemu-devel@nongnu.org; Fri, 11 Jul 2025 05:58:42 -0400 Received: from mx0a-002c1b01.pphosted.com ([148.163.151.68]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uaAWe-0004nY-6M for qemu-devel@nongnu.org; Fri, 11 Jul 2025 05:58:42 -0400 Received: from pps.filterd (m0127840.ppops.net [127.0.0.1]) by mx0a-002c1b01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 56B8UJkq026118; Fri, 11 Jul 2025 02:58:36 -0700 Received: from ch5pr02cu005.outbound.protection.outlook.com (mail-northcentralusazon11022126.outbound.protection.outlook.com [40.107.200.126]) by mx0a-002c1b01.pphosted.com (PPS) with ESMTPS id 47q0cvr2bk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 11 Jul 2025 02:58:36 -0700 (PDT) Received: from PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) by CH4PR02MB10681.namprd02.prod.outlook.com (2603:10b6:610:246::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8901.23; Fri, 11 Jul 2025 09:58:34 +0000 Received: from PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88]) by PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88%5]) with mapi id 15.20.8901.028; Fri, 11 Jul 2025 09:58:34 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint20171006; bh=aHCHF4ZoZc+/RdpXMdrFR5mJCRLMp3UlYBKDQGHZc MA=; b=iKAKx0/m0vplEIVDqaCRUdKg9hRv2mraSM94rVhLsNopFiZ+/DAOtIGm1 3H5UF5P7d8Fqga4fxvDDiKa0jNfs9DcLTZVOvpaKBtp+Rv026hM+e5xjok5FE2XQ Xuy34f1YIYnaRUnvkKoWCvjXkpvhWz5noRUPm1Iwla7HuKF3bx7XMLHligQYa2cn 0CFgLoY8fJR8uP6OK29NYWS0bPMbgHPABD71OwZ6n/yyaLEhqGUKiopielkVsd4b rD5GsR2nUWhcYPOiffK/BlxsVdwafD/bwffXHaMUKCeJYONFuDPHYsUQ/Aw2id1+ +d5eCkneeUG95k4/nA8Rt2DfX9S5g== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=bIwViield2Qu/qpCAqO2DfzYz6huqu+q12CLz6Bu0VpYR4zmTpesKxm9B8moocHkCz5feF3jQyaVvVr7cFBoNeAPPbx3Tx2IXtTqZq4eLCBaXJLYdzxKdbX3MOdU2HV8BP25eVLTZr1S7/BbNaIZmKzzFufziA/ssBkUk0DWxhXDHSPo74wgC2aLuwejHoUlKbfl8Vrx7cLM8nYWIS9vc6zu4OGnfC33n1/6DivfBkPd2L459/VaImbbpeJod2XK6reC6oQxuaGWXDmXLclA/wM9L1rIo0hlb7T8VoskSTI3mfWGUKEuvjrh77RASt95GkGMAU8Ig8t6RguxsG9Y7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=aHCHF4ZoZc+/RdpXMdrFR5mJCRLMp3UlYBKDQGHZcMA=; b=yoRHyevBA7fOTqZheuETNl3+xRSttqIug7zviCXimZ6a4e8W3obmnxWMJM4lBDrFbXVf79cxZMDoQokHtrb8J0j7yOmo3ZhWsESgr9UPEVF8rM02MY9hTLbJkwAzt1xkdpjcWAs3x23fFCBRbK3AYWDmm3F82LcFQ8J25OXhOeWi2g75uZbyJ2DUnEhQXsilNxDLgEmJADGFTRC3wddFiJNtbxt3zZ23LmXJuYOdSIZHHMMvKezXmXmLTO3XMruBwtI07zljDvToV5fAup5XMyWnetZXiwcLylSfm5q5jkgSrICNrVhbm37QGSH3m+uj2Gx69U05z8VR3kabIjDYqw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aHCHF4ZoZc+/RdpXMdrFR5mJCRLMp3UlYBKDQGHZcMA=; b=pfmRqxXJkwBiKmzcuqQG9LhMMbKNBkCz+0yGNPfjSJMK6toJ2wuGid7A/pg+blqkTgI7RbUyBpWyn4n9ZNUh3eJPzZyDqyrZ3c5VubfRGTML3nJ8bkuhWcJRc+5F9gopZH0OAARQILO/IZnH7CmLHxsdSjatt7JJKnsCy/7y6M3LCOyNOsOofTnn+D1qLG7iXZzPpfS3JlrigdBdKgtdx/Ve3SuobVBKEuUBthpKZ2cb1Qhl7UrBQ4Wqh6+rqCvw8okT/L6GR5L0qVbwWtG4qaDjfydAv9+TD7tSQVXybLgPu1zDlAjFT8XHFWKTCyOVZLHeyOe13zi78WN7MKBJWg== From: Mark Cave-Ayland To: pbonzini@redhat.com, mst@redhat.com, marcel.apfelbaum@gmail.com, eduardo@habkost.net, imammedo@redhat.com, qemu-devel@nongnu.org Subject: [PATCH v5 05/19] hw/i386/pc_piix.c: remove pcmc->pci_enabled dependent initialisation from pc_init_isa() Date: Fri, 11 Jul 2025 10:57:07 +0100 Message-ID: <20250711095812.543857-6-mark.caveayland@nutanix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250711095812.543857-1-mark.caveayland@nutanix.com> References: <20250711095812.543857-1-mark.caveayland@nutanix.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: LO2P265CA0064.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:60::28) To PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR02MB7159:EE_|CH4PR02MB10681:EE_ X-MS-Office365-Filtering-Correlation-Id: cda38968-73ba-4670-56a1-08ddc0617fbe x-proofpoint-crosstenant: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|376014|10070799003|366016|1800799024; X-Microsoft-Antispam-Message-Info: =?utf-8?B?a1pYUkVPODVJeGVzekpRY3BCSmVNQzBoaFVSakNxM3pCVEE4WmZoWjVJTTgz?= =?utf-8?B?VTlDa3E3WTYrSkRJeVZLOGlKaXUyRkprMTg0c1hiOWlkK2ZDMzI0WC96eXVa?= =?utf-8?B?NXBERnpXKzJRaUg2QVZLWW83QVgvVk05OE02K3FnTU5DNkpoYUsxWSs3UDho?= =?utf-8?B?ZUQ5WHcrT2Fvdm1KZmhIYkphSkt6dFpXN3RVdWNMT1hHTXd3Wk1SeGJUcWJN?= =?utf-8?B?WXFyVDE1SGphMzQwSXB4YkNrNkFEdnBZL2ZzbDVFTXZ0ZGw2TmFNMzJGOWdh?= =?utf-8?B?UlM4YzFZcG5UOWFMR3cyRnkvUW1jcFgyKzFuemYrZFJKRk10bm9hdWlXYU04?= =?utf-8?B?Wk0wdDg1UDAxV1I3Y3VxUG9lMmNJckhyU2luVDRFTkMrTlZQU0lQNDduckxY?= =?utf-8?B?dlMyNVRUODVPaDUyY0huMjR3a2wxYVVUeFprcWdPZmJVa3RPbS9MSlRjNXZV?= =?utf-8?B?c3YwQ29WTDlaK1Iyb3VuREphcmJCQVc4dVR3M1VCcWlpYzJzZU81K0pBVytC?= =?utf-8?B?L01iMmVuOHJQNk9aK09PUEpSeHMrNlBiQjJmT2JIa2dheXdReVpWS3pvOGpl?= =?utf-8?B?aDErQkN0WUFTRUY5Skk4QmlWWWxBVnhpYkFpK1pJSVh0L2xjdHo4QkRyd3dQ?= =?utf-8?B?QmhlWTgyYzUxcmxRYUxIelBxSERFeDNGVFNnR2ZKZWtQV1l1WGFzUE1WMGtq?= =?utf-8?B?UXUwTmIzRE81bXBWNGdYUmVvNFJqM2M2Z0Zpa0orbTRUUW5KQUlFU3p3bTdT?= =?utf-8?B?ZFczVmNaczFKcmtYdnlQMFcxR29pUmFYK09nbTVERVE0Z1hyQU9XNHNuOHht?= =?utf-8?B?b1ZzSXM3aXBRa2xNT1FEUUoyMnRreUtoaExzUit1UExOZ0RybndkYVNIc2tQ?= =?utf-8?B?TUdzZFAyZktyOVB0LytXTmJ4cUE0T2N1cW5qeU85RlNoeWtyK21DUUdPNUNN?= =?utf-8?B?b0lKQnllekdWOVdkZUoyQTlxU3JhcVFvTUQ5SXRBZXFkSUlES1lLeWVDZlNB?= =?utf-8?B?L3pPZmprbW56MVdnb2RQYjZHMkh2d2Vya05vSng5ZEQrWlFWOHRaNDlZcnRN?= =?utf-8?B?VWNRenZwSld4bUNuejM4WnFOSGRsSngrRUxnY3AyWFRwYlY3b2xicHVmVjll?= =?utf-8?B?QjJSdG9OUlQvMnYweXhRNUd3byt4UXIycWZmNDVCeERXcnM1d05jOG5lVEtx?= =?utf-8?B?NVBuYzlpUzJmVFExWWFud0NramFlWHZzTTgvdW5GNXZuK09SeXUzaXBnWFcv?= =?utf-8?B?Z0hjR1VhSFBkcExjQWJKbFh2SDZ2Mnp1SGlOdlFlRkRXLzArZkw3emYxb1Vt?= =?utf-8?B?S1VIY0FHYkltbWVoVVZPdUwrTFB2TkYrMGhnRlFJRzFaL1JHREtGNW1IWWhF?= =?utf-8?B?RmRpU2FrUncwdjdScXd6RlU1SElNME1sL0IvS2puNkRORlFwWWk3VGdtRzBZ?= =?utf-8?B?Z2RWZ2JQbjBZOUFiUHNrOTRhS2pDdkVkQUpYVk9mZlR4SmljUGZoWGJkcHZZ?= =?utf-8?B?OFlpeGU4ZVloN3c0Y2MwbDZIQTdzZDNJQjNRaWg2VFJYWGc5eU5HZEJmUFUw?= =?utf-8?B?a2FCU1dFUEhSSW9zM2EzTXJCbktNbmxvdVF1OXM1a0JDM3JtMTJuN1ErazJW?= =?utf-8?B?NFpFS254VGxXRGhVZ0dScjlpSnV0azJjNE1BbzdUZEpIRzZFaThkUDRFb2Fn?= =?utf-8?B?RDBnOE1DQ2FzMktmMkE5clgrNWEzM2lPNmV6YjVSUXJhQXdCZm8vemVQbFoy?= =?utf-8?B?YVc5amhIQnQzWnk4N1pJUldGcTZtNW9VdGhHZkZBZUJvcVhHdEFmZG1DSWZV?= =?utf-8?B?cTdVSU9OeXcrejczaThVU0t0aDhQaHQyMllONU40c1NFa2dRMVBjRDRCMS9v?= =?utf-8?B?d1NaRWdhOGpTNkRLQ0NPcVJyMzd4TjYzVWZRc3ZORHVTeURRQkltdlc1NC9q?= =?utf-8?Q?0eOXmxKnFg8=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR02MB7159.namprd02.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(10070799003)(366016)(1800799024); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NEpkdWhYRFJMdFVlYmhpQzhVdGxHZlNxcUFtWmRyMVJjNnh2QWUzazA1YVRK?= =?utf-8?B?WkV2RS8yWFhWa0IrbEcxWXZ0WXZpL3lLdWkreGFTdFlzTFRCYXNESE00bzBU?= =?utf-8?B?NmtkdmMrcXpMdFBNWk83UkxEbU1QUE9kYk9wRHFFRTd2bnYvQnpWT1JUZEJ5?= =?utf-8?B?WWNuNWE5OGdsVHF1Wmo3L0FBZFR1NXpvMFdnSWdhNXFTVC8xTm4yU09NK00z?= =?utf-8?B?RUZ4TTZLUnFmOEV5OFVvV3Z6YmczVDFCeCtMSjNjSDlEeWR1KzZ5QTBQc0hP?= =?utf-8?B?N3lDT2hDVnZ0VTg5N21ocUxCNVgwMk9DVUlQMFcrUVcwY0FybUszS0IyUWt1?= =?utf-8?B?ZjRxYUdsQi83VXJJOTZhQWVxWlhoSnF3eWFnb1o2SndJOFMrWHdydmJVM3hh?= =?utf-8?B?MDhRejhLYUphYUdsb3ZyaXVKOFo2OGZoUUEwNU91NWVrN0FBcmlIZTF6U3pZ?= =?utf-8?B?R3BjU0dKTlVjQTZPcEc5eUJRMGZjUXpUSWFTaDM4TTh2YTdSRGZvdWNTYTVD?= =?utf-8?B?Yk9ZanRqUFBQVVdmMzljcXR6REJ3aGxpbXZGQjFEcDNGTUlWZG9nQWkzLzN1?= =?utf-8?B?SjlBdkV6amdUcEtvZURTUUpMUE13aEdHWTNxNHo2RDdubndZQmNYWk9vUWtw?= =?utf-8?B?YlNRbFZzdHUyY0VKWHJlM2NJSStOaHZCSXlWWkhQYWpTL1lyQjhFL3FaOW92?= =?utf-8?B?MnFHQTNQWTNpcWhuS3lxby9YNjVHcnZhTS9oYUxmOXJUSW8xRmdHTGZxeWwz?= =?utf-8?B?cytLYnlMaHp1YXRsQjRHMEhiL0pkbWc5RExqQjBkaDhtQ0REZHRXRTh6SUdL?= =?utf-8?B?Sk50WVBlOElLUjFneDRlOCtld3RZUTlBbFhWeVBUZm9Ob1hEWFEzbTFYQ01N?= =?utf-8?B?YkM2SmltTEFZOUczOS8xMlN0dVp2M1h6UGN3akY1ZFpLenN3NS8yN0pON1Zs?= =?utf-8?B?MG9RVVhVTTJ2T1F3VmtGcUpsUklGTGJrVzd4emwvS2ZOUUZQNjk5endNdDFO?= =?utf-8?B?K0FnV2I4dTAyRG1qSlhkS2Q0S3ZlaVVzNEozTTlPanNkUlE1ZmhwUWxLU2N6?= =?utf-8?B?aFNwaThWN2ZCTjJ2WEZTTXIrYjY1cXN6ekxzNUZJeEl4VitwWDhXdHlSZkYw?= =?utf-8?B?SXMyc3NlRnNoY1FGcXFyRDVQQTB2NjFBcGdFYmZvRk0rSnRMNFhiT1ZYSEli?= =?utf-8?B?ZUhhNmtQVnVsYUZiTzY2eWR3bVhXSTdOcjVOZkgxR25na2paT0dQMWVuak9h?= =?utf-8?B?S1VBMTZjbmFvZ1Q4eVhFN014eE0yemNBR3JyZ3ZsSEtUWHhaQjFTWlNjTG45?= =?utf-8?B?UFJVdDMydUp4dnBXOW91ZEVZcXh1SmxScnQwakFNeGdjZFVZNnJGb2ZxNWI2?= =?utf-8?B?Si9XajBrZCs5M1FZMTArSE95Z3dWVWpDYXZreXJnd0phOTc3L01yTUJpR2xL?= =?utf-8?B?ODduNG40RDJTTmtxTnVSZ0pRcU5MeWJ5WDI5dFVrRFJ2WDhJcmo5bWhpK1NB?= =?utf-8?B?UkdIZVE0QXRiVjFhTTY4V052bUJVQml4a2xlRHJxSitWK0VkT1Fsc295WDg4?= =?utf-8?B?eE9QRGVjSFNzOWM2NVRlSHZVS3Q0aFdDTU8vaHYvUXFpS3U1T0wxN1VzL0ox?= =?utf-8?B?QjIxQTRPcW94TVdSOUMxczA4ckExS2ZiK2NXcmZlaE9ZMUF6dGJkWW10aGhF?= =?utf-8?B?TkJScWxiSmk4WmNXZ01rbkk1QnNQTGpEa0s2OWxNOTBzeERDWFk3UWR0Vm1j?= =?utf-8?B?WHRsaDBwVGJuTVluMnFGVWZNajR2OUtNUXJKaWtqeTd6dUhLVU1TYUNtZnEr?= =?utf-8?B?S0JVc1EwbDdZcXFjL3NYYndRNko5bDBuUU9FbWF4Vk03TnM5MzhWUStNZDVx?= =?utf-8?B?d3RFbm5xeWVpVnEyckFWM05ybFIrOG5EMEZrcXZ4NEZxNnVkSng5dGc4Q21Q?= =?utf-8?B?MXBERkFHd0h4ZTdySjN3ZG5qL21jZ0VMcVdPdlp5YmY4MUcrT1J3cW56RXRY?= =?utf-8?B?UmNzTTR6L2g1WFJRWVAyLzAzbGk2Z1E5eDZjd2pRM1NyVk5rZVN2NXQ4QXNF?= =?utf-8?B?QVhrQ3RIdzZYdVBwNVJoV1QvV0ZyMlpTQyswNzBBb1lGR3h2emFGWEVWMEtP?= =?utf-8?B?c0FsWmY4NU43RXJqdVRHYWNlM3BlRmF3NjFFdDZ3N3Y0aWRmNUgwTVluNTF1?= =?utf-8?B?TDluY1BWekROa3lhTWlKaDA4ektSK3F2Z3hONElyNGZYRzN0cmIrUUVzY3Vv?= =?utf-8?B?RjNxdnRSdkJlZUw4MVAwelNDT2lRPT0=?= X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: cda38968-73ba-4670-56a1-08ddc0617fbe X-MS-Exchange-CrossTenant-AuthSource: PH0PR02MB7159.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jul 2025 09:58:34.6014 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: sqYi06ls+sa3kSfjMMPnNdZpbigI/vDCt1b8srRtupwIEn0FGFra9aA+uL3uHlKb+9hMp6A6ZMcvzvawB1uWclnbB+2Lw533Fa0PGiJO85Q= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH4PR02MB10681 X-Proofpoint-ORIG-GUID: xQbxkz_HnySuuY1OwstXRxRcW0CHbaOR X-Authority-Analysis: v=2.4 cv=ccXSrmDM c=1 sm=1 tr=0 ts=6870e04c cx=c_pps a=LXS4Agk5KWHItNnKvyvmYQ==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Wb1JkmetP80A:10 a=0kUYKlekyDsA:10 a=64Cc0HZtAAAA:8 a=KKAkSRfTAAAA:8 a=pDVciPHeplB8fhom_mUA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-GUID: xQbxkz_HnySuuY1OwstXRxRcW0CHbaOR X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNzExMDA3MCBTYWx0ZWRfX5QB8sfc4sC6J EdijdkZny+0Y+ZX7xlRk4WulYOWXB4VDqrUR+YE4dP95TBAweTDNXid0xGsA/zBr6ZfJhYS7f7T HS0jStdvZCfvtt5CQvB5MtlZHN/xCrbr3yEOHE6DWjs/foyjpEKA2YqP2hmV9rq+vJWNxHGAScc HYLPjpsaGz5ieCt//zqSohUa/lgfY185xA4klUTFTPDzxGOW6MY2gG64zlZDkgRGW8sr3ms90Yt jlR8DLKpobqns3DNPMltTGpulvHkK0gymI9G9xGIMKfLeriEV3kN7NGfsgJqees/L4FurWUfi1G 9pKafHjZJVVsBhRzsuHdaxSr0pwMuMaJL1JOSwTd+Bm5ZjA1Vf3uMMYZgXo/5JX1mAOLKlsvsXz BJdRKZMbCCE83WGohLYcxp1J3W9BmyFMmZJisXO+YTvCrR9ERvdI89nOukAPvcIM7wGcoTdB X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.7,FMLib:17.12.80.40 definitions=2025-07-11_03,2025-07-09_01,2025-03-28_01 X-Proofpoint-Spam-Reason: safe Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=148.163.151.68; envelope-from=mark.caveayland@nutanix.com; helo=mx0a-002c1b01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @nutanix.com) X-ZM-MESSAGEID: 1752228390728116600 PCI code will never be used for an isapc machine. Signed-off-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- hw/i386/pc_piix.c | 105 ++++------------------------------------------ 1 file changed, 8 insertions(+), 97 deletions(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index f576e98727..1a4b14ba0b 100644 --- a/hw/i386/pc_piix.c +++ b/hw/i386/pc_piix.c @@ -417,19 +417,16 @@ static void pc_set_south_bridge(Object *obj, int valu= e, Error **errp) #ifdef CONFIG_ISAPC static void pc_init_isa(MachineState *machine) { - const char *pci_type =3D NULL; PCMachineState *pcms =3D PC_MACHINE(machine); PCMachineClass *pcmc =3D PC_MACHINE_GET_CLASS(pcms); X86MachineState *x86ms =3D X86_MACHINE(machine); MemoryRegion *system_memory =3D get_system_memory(); MemoryRegion *system_io =3D get_system_io(); - Object *phb =3D NULL; ISABus *isa_bus; Object *piix4_pm =3D NULL; qemu_irq smi_irq; GSIState *gsi_state; MemoryRegion *ram_memory; - MemoryRegion *pci_memory =3D NULL; MemoryRegion *rom_memory =3D system_memory; ram_addr_t lowmem; uint64_t hole64_size =3D 0; @@ -517,39 +514,6 @@ static void pc_init_isa(MachineState *machine) kvmclock_create(pcmc->kvmclock_create_always); } =20 - if (pcmc->pci_enabled) { - pci_memory =3D g_new(MemoryRegion, 1); - memory_region_init(pci_memory, NULL, "pci", UINT64_MAX); - rom_memory =3D pci_memory; - - phb =3D OBJECT(qdev_new(TYPE_I440FX_PCI_HOST_BRIDGE)); - object_property_add_child(OBJECT(machine), "i440fx", phb); - object_property_set_link(phb, PCI_HOST_PROP_RAM_MEM, - OBJECT(ram_memory), &error_fatal); - object_property_set_link(phb, PCI_HOST_PROP_PCI_MEM, - OBJECT(pci_memory), &error_fatal); - object_property_set_link(phb, PCI_HOST_PROP_SYSTEM_MEM, - OBJECT(system_memory), &error_fatal); - object_property_set_link(phb, PCI_HOST_PROP_IO_MEM, - OBJECT(system_io), &error_fatal); - object_property_set_uint(phb, PCI_HOST_BELOW_4G_MEM_SIZE, - x86ms->below_4g_mem_size, &error_fatal); - object_property_set_uint(phb, PCI_HOST_ABOVE_4G_MEM_SIZE, - x86ms->above_4g_mem_size, &error_fatal); - object_property_set_str(phb, I440FX_HOST_PROP_PCI_TYPE, pci_type, - &error_fatal); - sysbus_realize_and_unref(SYS_BUS_DEVICE(phb), &error_fatal); - - pcms->pcibus =3D PCI_BUS(qdev_get_child_bus(DEVICE(phb), "pci.0")); - pci_bus_map_irqs(pcms->pcibus, - xen_enabled() ? xen_pci_slot_get_pirq - : pc_pci_slot_get_pirq); - - hole64_size =3D object_property_get_uint(phb, - PCI_HOST_PROP_PCI_HOLE64_SI= ZE, - &error_abort); - } - /* allocate ram and load rom/bios */ if (!xen_enabled()) { pc_memory_init(pcms, system_memory, rom_memory, hole64_size); @@ -566,74 +530,21 @@ static void pc_init_isa(MachineState *machine) =20 gsi_state =3D pc_gsi_create(&x86ms->gsi, pcmc->pci_enabled); =20 - if (pcmc->pci_enabled) { - PCIDevice *pci_dev; - DeviceState *dev; - size_t i; - - pci_dev =3D pci_new_multifunction(-1, pcms->south_bridge); - object_property_set_bool(OBJECT(pci_dev), "has-usb", - machine_usb(machine), &error_abort); - object_property_set_bool(OBJECT(pci_dev), "has-acpi", - x86_machine_is_acpi_enabled(x86ms), - &error_abort); - object_property_set_bool(OBJECT(pci_dev), "has-pic", false, - &error_abort); - object_property_set_bool(OBJECT(pci_dev), "has-pit", false, - &error_abort); - qdev_prop_set_uint32(DEVICE(pci_dev), "smb_io_base", 0xb100); - object_property_set_bool(OBJECT(pci_dev), "smm-enabled", - x86_machine_is_smm_enabled(x86ms), - &error_abort); - dev =3D DEVICE(pci_dev); - for (i =3D 0; i < ISA_NUM_IRQS; i++) { - qdev_connect_gpio_out_named(dev, "isa-irqs", i, x86ms->gsi[i]); - } - pci_realize_and_unref(pci_dev, pcms->pcibus, &error_fatal); - - if (xen_enabled()) { - pci_device_set_intx_routing_notifier( - pci_dev, piix_intx_routing_notifier_xen); - - /* - * Xen supports additional interrupt routes from the PCI devic= es to - * the IOAPIC: the four pins of each PCI device on the bus are= also - * connected to the IOAPIC directly. - * These additional routes can be discovered through ACPI. - */ - pci_bus_irqs(pcms->pcibus, xen_intx_set_irq, pci_dev, - XEN_IOAPIC_NUM_PIRQS); - } - - isa_bus =3D ISA_BUS(qdev_get_child_bus(DEVICE(pci_dev), "isa.0")); - x86ms->rtc =3D ISA_DEVICE(object_resolve_path_component(OBJECT(pci= _dev), - "rtc")); - piix4_pm =3D object_resolve_path_component(OBJECT(pci_dev), "pm"); - dev =3D DEVICE(object_resolve_path_component(OBJECT(pci_dev), "ide= ")); - pci_ide_create_devs(PCI_DEVICE(dev)); - pcms->idebus[0] =3D qdev_get_child_bus(dev, "ide.0"); - pcms->idebus[1] =3D qdev_get_child_bus(dev, "ide.1"); - } else { - isa_bus =3D isa_bus_new(NULL, system_memory, system_io, - &error_abort); - isa_bus_register_input_irqs(isa_bus, x86ms->gsi); + isa_bus =3D isa_bus_new(NULL, system_memory, system_io, + &error_abort); + isa_bus_register_input_irqs(isa_bus, x86ms->gsi); =20 - x86ms->rtc =3D isa_new(TYPE_MC146818_RTC); - qdev_prop_set_int32(DEVICE(x86ms->rtc), "base_year", 2000); - isa_realize_and_unref(x86ms->rtc, isa_bus, &error_fatal); + x86ms->rtc =3D isa_new(TYPE_MC146818_RTC); + qdev_prop_set_int32(DEVICE(x86ms->rtc), "base_year", 2000); + isa_realize_and_unref(x86ms->rtc, isa_bus, &error_fatal); =20 - i8257_dma_init(OBJECT(machine), isa_bus, 0); - pcms->hpet_enabled =3D false; - } + i8257_dma_init(OBJECT(machine), isa_bus, 0); + pcms->hpet_enabled =3D false; =20 if (x86ms->pic =3D=3D ON_OFF_AUTO_ON || x86ms->pic =3D=3D ON_OFF_AUTO_= AUTO) { pc_i8259_create(isa_bus, gsi_state->i8259_irq); } =20 - if (phb) { - ioapic_init_gsi(gsi_state, phb); - } - if (tcg_enabled()) { x86_register_ferr_irq(x86ms->gsi[13]); } --=20 2.43.0 From nobody Tue Dec 16 21:11:18 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass(p=none dis=none) header.from=nutanix.com ARC-Seal: i=2; a=rsa-sha256; t=1752228037; cv=pass; d=zohomail.com; s=zohoarc; b=ODYYz/9aXLFli9Bbu/A+12O7kVAsY7XYXOvArhiSf/qx2F2MsTERQTk/AhezfX9l/+GIf+Ul+VaLzbu0cv/g+dr/oncWHhm56NsZ8cujiruV2uP06exTghoNN+Q75jzsI3h8GVZjgoe1l3vtH4RvUJcxp0BlAwcN8x7uBYBV6hs= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1752228037; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=m9SioZEJ23wHkdXdCcphUIyW1mjn7g1ujJHrWIC01rc=; b=FQtIaksHHVCuRukmsIW1lSi1R9eFLIaNIyJxYH1rhO+d7fDwQe4uJK03xr17dV7oDjwO7Cdz1GHuVaBGdLmM9TG3z70xSRgDZ2jFbDhJ8csPE8rntyyy+IPn0i3Q7apSxFsAQ5f1KUHskCNG3r33n82B2OWX3guIDaXyvTOx1Ig= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1752228037347319.69675154353047; Fri, 11 Jul 2025 03:00:37 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uaAWl-0005nB-A5; Fri, 11 Jul 2025 05:58:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uaAWh-0005gU-Fl for qemu-devel@nongnu.org; Fri, 11 Jul 2025 05:58:44 -0400 Received: from mx0b-002c1b01.pphosted.com ([148.163.155.12]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uaAWf-0004o8-KF for qemu-devel@nongnu.org; Fri, 11 Jul 2025 05:58:43 -0400 Received: from pps.filterd (m0127844.ppops.net [127.0.0.1]) by mx0b-002c1b01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 56B7OZam032420; Fri, 11 Jul 2025 02:58:40 -0700 Received: from ch5pr02cu005.outbound.protection.outlook.com (mail-northcentralusazon11022073.outbound.protection.outlook.com [40.107.200.73]) by mx0b-002c1b01.pphosted.com (PPS) with ESMTPS id 47q3k38m2g-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 11 Jul 2025 02:58:39 -0700 (PDT) Received: from PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) by CH4PR02MB10681.namprd02.prod.outlook.com (2603:10b6:610:246::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8901.23; Fri, 11 Jul 2025 09:58:38 +0000 Received: from PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88]) by PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88%5]) with mapi id 15.20.8901.028; Fri, 11 Jul 2025 09:58:38 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint20171006; bh=m9SioZEJ23wHkdXdCcphUIyW1mjn7g1ujJHrWIC01 rc=; b=MggjHN2/2GGqVTxOOJdfjyKfrnZfOsmT95tTwjJwjgatHItjO1f9C/2sq qxPi5DP6SLyV/RCTL1u7nfgx8sGWpocv6DUUNqsbUcD97NMO/rxvr4AHZ2Ufpkkv KfsgDvfyKmIopZObN/Qw3uccdRqBsHGz9xMLid5uhNABS1cT8r0eJ+rnNaNz9cNN x4MoqqOOHQDyVQz4c6kYjwXJMa0iPew44U/hKekcllLhfVwhukceAsdD15HvE0At 9lX6bepiEppbWzA9jpDGX/vhH3q2OhUdt095zW37RXXu/i7vKLl+aZlifDqleG4+ yMTFhtwgk6xqjdJk4h4NSUlvdmbRQ== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Z49baKJchPh4xCvm5zyePDpkc7op//+KrJaRK4cvpJCBqHEpodi2v/l1GD2xsnYJMsSKvFxReTvKgFb4Enpx6OprmjbZKqze1dxJvLnEPRwTtn0beNP3bqrrbYEIU2V4L5UsEvt/PPjYZs0g1DCjaqz0u6fJdTytqME+4fryxERjB9zWaB6YY/r3gXyB/mLY1ATmMBbTr4w8VaJ22XsGIX8Yme4o5gq0scyUjtwuwnETeJLPG4tQREcc71B9Cd4mhRLM2uFKAxjnWRXnWEVGo0VOB+10Fjl5pu/dwztGiQlah9023Bf5Eq/aSfT9CNXB26TZ3jsihnmj7sGAKOpNWw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=m9SioZEJ23wHkdXdCcphUIyW1mjn7g1ujJHrWIC01rc=; b=HoWu1Cy3ve2rq1uCeMQghU0hMtwC2rwF3oAVXinrVk86aWTTVdzrYE8VpFA9VB2PfhpTk149MkjuxIml7zgMar/b7N5frucaoBojkdaMatSbieLZrjO6RwN7Mdz7kV/BbrmnelAENMEX3MkojcjqElJYmcRGxH3s3C0tutTfYZQkVz/z5SCzh1TmZPnBkqhL/+V4s3/p13R/bgA1o6JmP7bVjWzvhwmfCLG1BN3J0A6Ba2aR75wIhCIgpZewhBJa7fzZmbgMimebMTZdHNPprN6grkjv8QfhgbqQE+WM8tAhF08K88RDMRU3wc2k1FwyiWA0IOrwVZdR1aCBlaG3GA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=m9SioZEJ23wHkdXdCcphUIyW1mjn7g1ujJHrWIC01rc=; b=j9GfyBu0g9PUZEVm3nEqSqIDzNPLLzYQIKkb0AVswE3v+uVU+VdmRPXuRxGj/eqYU2sb68xcHCTak6L1rnz7lZuQi4LeO/91o1sn1NR7VH9F4PAAFcLszm4H74R7bmjbw5Nnww8zzP5oqayqx8+Qdj2iIIEZ1eUI2M9K4petBn59AaXo/qXAhzPvmHoFGkE4jEiJvaPXCypZt23isZQHpqBv84ub8RShqstskLJtG4IrbEzTylTdFBPRE8B0pg98Lhb2jVsgfunxNB/XkNP5KQI9hKZreby+5bJ6Foh+yiQPeU9TxCSVjn+Glo8bG//Pg+4qrTpIG524+ymXUQHzFQ== From: Mark Cave-Ayland To: pbonzini@redhat.com, mst@redhat.com, marcel.apfelbaum@gmail.com, eduardo@habkost.net, imammedo@redhat.com, qemu-devel@nongnu.org Subject: [PATCH v5 06/19] hw/i386/pc_piix.c: remove SMI and piix4_pm initialisation from pc_init_isa() Date: Fri, 11 Jul 2025 10:57:08 +0100 Message-ID: <20250711095812.543857-7-mark.caveayland@nutanix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250711095812.543857-1-mark.caveayland@nutanix.com> References: <20250711095812.543857-1-mark.caveayland@nutanix.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: LO6P265CA0026.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2ff::16) To PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR02MB7159:EE_|CH4PR02MB10681:EE_ X-MS-Office365-Filtering-Correlation-Id: 524c71e2-216b-4d9c-3dbf-08ddc0618201 x-proofpoint-crosstenant: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|376014|10070799003|366016|1800799024; X-Microsoft-Antispam-Message-Info: =?utf-8?B?eTE0NE5oVWhKdWU3ZWxoSy9zYU1FaGVrajg1dEp4WGJjMzNkTEZWMTJyWDl3?= =?utf-8?B?TFJNNEdQZk1YcVM0Q202QlJtZkU5aW9xK2s0SmliZFlhajY0SnorNHZ5MkNy?= =?utf-8?B?ek5EdlBDZ2VwS2VPOVZoU3dmam9qUjBCYnUwOVAzZXFla3hKMnNLcEpMSEhF?= =?utf-8?B?STVsbXZ4djg2RGZsN2JJVGk3c2F0R1BvOXd5SmFUcGVISE9ZallQMXBxN0FB?= =?utf-8?B?SXRnWkxOeVQ4bWF6OUhhdXlTcmNlUks4WGRMVkRSU3N0azFpWkZreVYrdWxQ?= =?utf-8?B?ejhqSHZOVW9PVkxiZXNPR3dRQUVCa2w0TE1sK3liVHlmb1VIenI3WUhEVzNQ?= =?utf-8?B?Q0U3T1grcWgwT3M3Ni9Vam0zZDljTTlFSDE4a01lZzNCZU9zdlNReC9pbHhJ?= =?utf-8?B?MCtzUFdxY0QzSjlJSDJ1Njg1ejR5cDdCcjl4RmhMclRrM3luNEpQdVFQS3NF?= =?utf-8?B?dk1IbFlOdER6bmExc3RBTVRXOERWc0krYnJYVjBiSEd3ZTNBTEFaak5RMlhP?= =?utf-8?B?UitKRjJzbjNKSGhMbnE1ZUxJajlCMWM3MVVOdjZ4OFpkZ1QzeGF1L21RVTZw?= =?utf-8?B?dmg0UmptNHRGVzZaZUNHVzZBVmpUNTBRU1V0bWFQeEJ0Rk5LUHhVNW1ETHVL?= =?utf-8?B?TGJPclF4cVlBaHFHZlZjZzI5S2ZmTHBBN2x5aUNxdFY5RWhCZzF5QnJsWXVH?= =?utf-8?B?Q1VWOVJZbTZvK2l2VCtQNXVqdzRpeGxmRzU5OWNYMzVjcHJJM1R6ZmNZbmtZ?= =?utf-8?B?bnFRNktjRFdKeUtrdlczNkNFRFF5VDNzMjNqcHhGQllhM0VnNnQ3WVpPZ0di?= =?utf-8?B?OWpRaEJHZ01xdkV5d0xzSWUzQW5GSjRkUDlzeE1CUXdob29vMVJmUGpnaXFW?= =?utf-8?B?SWNjWW9yaHpvZXI4RFhhY2wwS1JqdFZtZG40VlZmK2pvNnJZWmpQdlNVRnRG?= =?utf-8?B?UGtjdjVsdFR6ODNBdE0rS3pLcVJnd1EvQlFNOUM5RG94dmJDeFNaSlN2NlVj?= =?utf-8?B?Tk13VGZuS09EZHlOSTVlNlZ6b3prNGlQbnBhekszL3RKZGpMYVhaSDllRmRy?= =?utf-8?B?dkpuTTJUK0NOS1o5bGN0OEcyWWlEc2pwbmdPbGVWdmZPTElWMU5RakJPdE1y?= =?utf-8?B?Si9TTlJMTVNwNGVpZXhCQ2hQSW8vaWkrODcrM0QzSndRK3lxcUxLY3BxNU9P?= =?utf-8?B?WlhpSnErQjJxYzVJVUtKcEVSeHNOaUVTTkhyZlZTWXZ2ZmpvckY1TE9aN1lk?= =?utf-8?B?OGZyaE5DKzhpT3U2OE53NlYvRnpMODY3TEo1VDY0UmdxYUJsUGlwY05TZ3Bo?= =?utf-8?B?MUc3cTQwZnNjakV1WEdRbWVpa0xCLyszNlNHdlRBMUc3MHRST2ppbmhlYVpH?= =?utf-8?B?QWlTN2hsQ3FTcGFubUNzWFJFUlkzWjhTQ0tscjdUUGtUMHByNEhzU1BPUk1i?= =?utf-8?B?RXdQek40MVkrSzk0eHVNTzlaajdWOWNBZ08xRGRmemo3VjFXK3E0ZEZRaEc4?= =?utf-8?B?eXNiQXJWS1BiYS9iMnlqTEIraW5jWDAxbTFjZmhsZ2RtZDZITkhFZDY2MEgz?= =?utf-8?B?ZFZnRVFYL2h3TCtWRWZKblBpYkkyTWhwU2VSa3BlMEJNWWRPaGNVbE9iNXdG?= =?utf-8?B?L1ZBazYxRk5qMmJVdlZtekdBRkhHeUtVVVQ4SWF3aGlZSXkzaUxFMjZOZjh4?= =?utf-8?B?NFFEb3BKRlJubDFtZmM5U0dHSVZmOHgxeHE5c29DYnArYmZwTk1yWVM1MTZ3?= =?utf-8?B?Y0dSb3h5NTAwS3lQeUtRdkRSak5zV2lSWVBKWm1pTm9KdnhBbDVUa05uR2JW?= =?utf-8?B?R2Z6MWZ5MXpHRHI2cVMwL3VVWWVwZllOM2RiSGx6RVEvbnh3My8rNUp0R2Q4?= =?utf-8?B?UnQzcndDWkRnQlltWXFHWVhxY2lkYWJBZjdDUGZCYTNIZjBFV2ZMeHZBL1d4?= =?utf-8?Q?karsCGvPggo=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR02MB7159.namprd02.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(10070799003)(366016)(1800799024); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?U213Tmw4TzF4VUlhcUU3R3RneDBsNXBmT1VWNUNpNDFtNWFxYUNLUDZWbTZY?= =?utf-8?B?RFJySmJ3NTdqY2x2eURMWDIwbVFvZm1KL0x6UkFlclVXL0MyaW5SdzV2eWY0?= =?utf-8?B?R1E4SmtXN0o2N3pHdXF1UnRMR2doOGFSSlFoNWhUbUJBTnRJTWI1UC90UFN1?= =?utf-8?B?cjM2d25QZnZBS0xidVJCdXF2bmZhN3VZRVVyOEFCeHJESDZrU2IxeXVJa3Q5?= =?utf-8?B?YkxMekdKaFlaMFVRL2V1bUN3SmpnZlRUWjA0VGRJZDY3NlJ6ZnBYOEZJRmZB?= =?utf-8?B?UnZqQ3cyQ0NLUHhuU2xXbGtWelR4c29ybDhFbEpycnN5OGNnQkRKWnE2OStI?= =?utf-8?B?cW9kRUpKZzlKZFZkVVAxU1dUYkxjYjB4bklRR0FaZnBBRDBVYzBCMGwwdGIv?= =?utf-8?B?TUxZaGFtdnZyVG4vS0xYRXdVYTNwVnc2aWpCaTFxRWdhdUFrUUJieDNNREk5?= =?utf-8?B?cEdIR3lpaG5CRG1kT1hUV1c2ODNEcy9zcWxrVmZTSnZGcDlKTnZoamJrV21Y?= =?utf-8?B?ay9KTzlsSUJSeFlHa3Fad3B3d3BQcWVSQUN0U014QmkzeW5rL3BEN0xCYUxO?= =?utf-8?B?Q2FxbHRydW5LZlBFOFNiaVlJcHJIRWRab3lqSUE5U3h3dHQxN1EyWTVJQlhs?= =?utf-8?B?RHZnNC9rRllpL2FOUzVrTmVCdVd2SGJoYWJvNzFpVVZ0NUs4Z0RLdyt0VmR4?= =?utf-8?B?MDB1NjV0U0tQaW4rREQxWllVVWpqQlI3c2xHWWNZbDdFdXF2YmszdW9mOHpQ?= =?utf-8?B?RlNHRkEzaXBWQzJIcHhPYnBROWpKYklZN0RYUUcrd2JCcWx2eHdhS2lSekZw?= =?utf-8?B?SG9Pd1FaKzdFdEN5Zm5zQWhvK0ZTajBKK0pwYWViUTllbUdvbUJxR3d0cnBX?= =?utf-8?B?QjN1TDNQNDhlMUVZQi9BODdhUzcvSGlHSkliV3o2bnJScHdzbG02eFptTnFt?= =?utf-8?B?NEJQRlRZbzNPYUtJc2NLNUdiQUZxbGJCc1ovcldCQ3ZWMWdQcjJSMzBNNndV?= =?utf-8?B?YnRqZlA2QnhFTUhsNlVRUDhXYmc4Z3JNcmd2c1ZtOWJ6Rm0rWlUyczA2eDZM?= =?utf-8?B?ZzRwcUJzWnhmSU9qZjE2cjdLRGJyaDNwaloycWVvOUVXRThUT0FWT1FiWjd2?= =?utf-8?B?VG1yYUZWZEt6OVB4amQ1eWlGSWFUOVlvbjFjRzRJRVVMa3cwbmpBMTZqVjdM?= =?utf-8?B?OHZ2VjdEb1hPcXJueTJaa240bGxEZ01yV1owVlFDVGNkQmtpYU0rcFpaaHZD?= =?utf-8?B?bE9Vc0p4ZVVUK2JtT3d6alU5SUJnSXMvbWR1OUZUbGRteEoyUUtmQnJ1Q1k4?= =?utf-8?B?NW9qbWkzeTliUnYrWmt5T3gyZmV3R05zeGlwV1grUFV0dnQ1WVFsSE5KeXRs?= =?utf-8?B?L0U4YXlFVzU3TDdVeER4R1BQbmg3ZGJxVXVTa21pY2ZaZzJrVWM4UHhJaVcz?= =?utf-8?B?RlJnOWkwVHA4OXlkcWRwK2xIajkyQVcydEpVdnpiMkpWRkFkaTdKNEtkVEts?= =?utf-8?B?UWo1N3FxSDJCNmsxUzNRTzhyRE5XWmhxMXUxTnhkbjJ0K05FT3Zoc3N0NW5t?= =?utf-8?B?TlFwZ2RUcERpSFJwOWF0NE9YY0JDQVhFY3NSb3hybzloOUFVbElzOE4zTk9S?= =?utf-8?B?MVlnU1RMREdMRWl5YURLNmNWQkd2NjAwMmhYKzVYT254UGg3enhuZW45OWty?= =?utf-8?B?alJLY3F4TmFKbnFRL2tWb3RGUVhyTG5Oa21TbTdwSzV4RzQ0RitNckNseUwz?= =?utf-8?B?SzFpL0hrYUlFSDRzS2pFcG1ndmNHWVYyNjV1eUlGcWV6aXZ4ZGlpVnVmUzI0?= =?utf-8?B?YStKaFBJL0pkZ1BXZ09ySWtveXN2WGN0d3A2T0k3aXpjYmtmVGVRdHJQWGFD?= =?utf-8?B?MndLWm5ZaHY0Uzh3L2xmK0pVYzE4KzZ1TGgzK3RpeXVKWGxlTlZIUUFETkUx?= =?utf-8?B?NnhPMzQ4b1lkOHh2WjExeWt6SjlhU3hxN1hUZmlaSkxGVWdHVVlFTjk0WHdi?= =?utf-8?B?UStVdEVUZHkwN0JpQVV6ajk4NzlZaXZSY2h0ZnRUcUxIKzR1dDdxWFlKYzNi?= =?utf-8?B?L1lNVi9TcGhRQTMyVlQ3U0ZaRU9IVDd5RWM5Y0tERDJxYlpEVTlNdWZYYnNR?= =?utf-8?B?NGFWVWNFRUZYSjk3ZFFFalFnemtBV1U5SUdyQUVHb2VOY2JKQ0FqTG1SMXRv?= =?utf-8?B?MG40TTdqdWZSMFlzSDVLdTI0dStjRm9BeTE3VlJDejM4bERpSFdnUU0wQ3pZ?= =?utf-8?B?cHBteFlWWlp0UUg4M2JLd3R1VTN3PT0=?= X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 524c71e2-216b-4d9c-3dbf-08ddc0618201 X-MS-Exchange-CrossTenant-AuthSource: PH0PR02MB7159.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jul 2025 09:58:38.2640 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: qtvLSZhWTy1gbNKKiVBVU/JupNiweHJokCc3aPRqNknwk7j2c8mj7izt5GsjEgpeh97CEn220t3doo9++ybL8bw/eZygnF0yX4M4/22VfM4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH4PR02MB10681 X-Authority-Analysis: v=2.4 cv=UNDdHDfy c=1 sm=1 tr=0 ts=6870e04f cx=c_pps a=mhBramkM2YKFwkQI7AGxcA==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Wb1JkmetP80A:10 a=0kUYKlekyDsA:10 a=64Cc0HZtAAAA:8 a=KKAkSRfTAAAA:8 a=F9lpminiuFHZMRiaUDYA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-ORIG-GUID: 2Lxp3t54aOgFWlvjTHVF-dQjaR-GDT20 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNzExMDA3MCBTYWx0ZWRfX8wA3id2cdPDS NCPqk8AtXLKfD899o+lOeeXvqILN9cdTquvSOIQemriEh8cvbenBiQpcanlbnSvG+EjdPto1ne9 RqwCK044aniIVWu+0AY/qLRrIEQrJS8lxZQDgzOKHOaXHiGTSTag7rt5kL4QHTAIYQARA3kqJHe ATYTat5lHnzZPTxv2SC+b5PKj1CVNTn/zHro1Eb/SLXF0pK579fyJtSHkL14MO92rdFP6m0oovS UgfYN9V5irQwYeGsjGkPVXc5AiiuarhWMOXmPwLAkWpPm4AH28tTR5GLZDIykJNbwJuzmtCH2lf NnBlnApUgDd1kTv14R1wPds9sy3h5nnfxuaxoS9o1G2uW26gUWVc8BWMGlTSKCbh6SE9MfQNKaG jmE9ALgx6Hb/Xu5XFrZLfabKn/EUaWiZf7UrqPXeQIko0zc4W54TnVMYyHi9hrB3cci04uyp X-Proofpoint-GUID: 2Lxp3t54aOgFWlvjTHVF-dQjaR-GDT20 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.7,FMLib:17.12.80.40 definitions=2025-07-11_03,2025-07-09_01,2025-03-28_01 X-Proofpoint-Spam-Reason: safe Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=148.163.155.12; envelope-from=mark.caveayland@nutanix.com; helo=mx0b-002c1b01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @nutanix.com) X-ZM-MESSAGEID: 1752228038041116600 These are based upon the PIIX4 PCI chipset and so can never be used on an i= sapc machine. Signed-off-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- hw/i386/pc_piix.c | 19 ------------------- 1 file changed, 19 deletions(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index 1a4b14ba0b..16d666f97e 100644 --- a/hw/i386/pc_piix.c +++ b/hw/i386/pc_piix.c @@ -423,8 +423,6 @@ static void pc_init_isa(MachineState *machine) MemoryRegion *system_memory =3D get_system_memory(); MemoryRegion *system_io =3D get_system_io(); ISABus *isa_bus; - Object *piix4_pm =3D NULL; - qemu_irq smi_irq; GSIState *gsi_state; MemoryRegion *ram_memory; MemoryRegion *rom_memory =3D system_memory; @@ -579,23 +577,6 @@ static void pc_init_isa(MachineState *machine) } #endif =20 - if (piix4_pm) { - smi_irq =3D qemu_allocate_irq(pc_acpi_smi_interrupt, first_cpu, 0); - - qdev_connect_gpio_out_named(DEVICE(piix4_pm), "smi-irq", 0, smi_ir= q); - pcms->smbus =3D I2C_BUS(qdev_get_child_bus(DEVICE(piix4_pm), "i2c"= )); - /* TODO: Populate SPD eeprom data. */ - smbus_eeprom_init(pcms->smbus, 8, NULL, 0); - - object_property_add_link(OBJECT(machine), PC_MACHINE_ACPI_DEVICE_P= ROP, - TYPE_HOTPLUG_HANDLER, - (Object **)&x86ms->acpi_dev, - object_property_allow_set_link, - OBJ_PROP_LINK_STRONG); - object_property_set_link(OBJECT(machine), PC_MACHINE_ACPI_DEVICE_P= ROP, - piix4_pm, &error_abort); - } - if (machine->nvdimms_state->is_enabled) { nvdimm_init_acpi_state(machine->nvdimms_state, system_io, x86_nvdimm_acpi_dsmio, --=20 2.43.0 From nobody Tue Dec 16 21:11:18 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass(p=none dis=none) header.from=nutanix.com ARC-Seal: i=2; a=rsa-sha256; t=1752227969; cv=pass; d=zohomail.com; s=zohoarc; b=UDpZVoTHLDbstGRUIuiHP6dgH3Fr+9QS8WuVykS4hcpHFO9TWz0cWSrusft7uRWFqgVB1l28AtzrsUI135GW5S8uFntwt8Tqlrbc1wudO4MyRnQByRVNqOlR+78EsS7is9XE65H2k0JGsEGK0DyUrozocxeFrVz3YWQgGxbVqMw= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1752227969; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=/HXPt6nEo0a/ya0GNERWxCMOQvb4mTJQ3WCdZfI4RnE=; b=CwYx29dFex/V53ENlsB0W8NfFzDqlwesyLpNZ/KdgBcNkOtXBicc1n9SpcYzIlQUkgC5Wd0T2TwxyuJAm2izRoJT9o8MH/fb8+QakujcmHPzBugIqJHos+6RMghNvR2ctGZ7F58bAlqqHdgxaE/NuyaxS5m+8uJnITqespNyspQ= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1752227969479879.5554770370679; Fri, 11 Jul 2025 02:59:29 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uaAWo-0005vJ-6H; Fri, 11 Jul 2025 05:58:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uaAWk-0005me-FA for qemu-devel@nongnu.org; Fri, 11 Jul 2025 05:58:46 -0400 Received: from mx0b-002c1b01.pphosted.com ([148.163.155.12]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uaAWi-0004ot-Rg for qemu-devel@nongnu.org; Fri, 11 Jul 2025 05:58:46 -0400 Received: from pps.filterd (m0127841.ppops.net [127.0.0.1]) by mx0b-002c1b01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 56B8HRNk032175; Fri, 11 Jul 2025 02:58:43 -0700 Received: from ch5pr02cu005.outbound.protection.outlook.com (mail-northcentralusazon11022137.outbound.protection.outlook.com [40.107.200.137]) by mx0b-002c1b01.pphosted.com (PPS) with ESMTPS id 47q1karqmk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 11 Jul 2025 02:58:43 -0700 (PDT) Received: from PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) by CH4PR02MB10681.namprd02.prod.outlook.com (2603:10b6:610:246::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8901.23; Fri, 11 Jul 2025 09:58:41 +0000 Received: from PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88]) by PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88%5]) with mapi id 15.20.8901.028; Fri, 11 Jul 2025 09:58:41 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint20171006; bh=/HXPt6nEo0a/ya0GNERWxCMOQvb4mTJQ3WCdZfI4R nE=; b=gAg50d0vB8zwu7eekBDdkJXpuTN5Cv71tp+/MVbFM2bDMHiIh8MYE6TDR nrtHbzskky8bi7RYmV5nzVt3VeTRZVdYZZfxj1EtB45LhZKf9OQeY3bMBeGvBSKp 2xxBGsj8cPNsSDXjK6kYdAPyL3cpO/8OZF3y8g+Ddw26dDUbmHQK3NMXZsFe7P+A az9BqchE0JjHqlWSkdgXpiIoO8J9hpp0J0X7VHUEIkgZfjGXBOgSaBIg+tHjxHy3 FmVsVqhkvUZLM85mYgCo4/59WQFVW6aOSCjlVpvnhKiQ1mSwsBH9rjD0+RGuRS9M o8jAqnaFAlDA5utyBoWDlKW4+FDrw== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=qXk2/w3ygxIElxMzm942qXe3U+vwy/6Xo3vpJA84m63vwPpFgjmb1gYMYRbh4acft6oYTi8vkka7y4RFZvntXL+6KwmxA5lOspO/y/EbmJ/MgSeYiZqyS2prCigoTK3UJe+zl5TMFm/pN6Oq4LJR+qIdZAW19Jrura9Zgwnh5ZaQYwrZu88rXc6r41e0NUBJwx4/VvV7XiswIfp8nrJwf9WvH34nqIVzldUVSaRJhB1drx/xcrIKXpVu+bjQoqAdZtnwIwJQ5VB0IcXhMeugVoYsXlAhdXRK8zJ3oOjwIv00SGVvSjmZsE0RCKwaqms9Yalxy92irYKYALP730PSpw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/HXPt6nEo0a/ya0GNERWxCMOQvb4mTJQ3WCdZfI4RnE=; b=lA1OLrS8JexvPrkHtm+hV0Uv1cWM3h3g29HbckuyWdV1h0gNRJq8A6/tvPcNj1lnqjgxgMA5mU4D8VpnsTnjgwnUMATxSBKgaB+ZZ1vW0Npp9i1v1MQdm8KTJgsjgDqaSs36Vhykj+dBJtgYQM6Mc1c0tSDHQpmPeYMzS4XWcOZF5M/g47ayeHPUslf4jlueiFtdeNKzNqHbbIDBJfvnmBjjrCAEZA/wzwoVLSGyRVCKKgdvZPeKW4f5Ke0r2An1eUBsnuA47MpdYeOdLhPEffDOzxzZjzD4I7q5rBwyQttbXxYHixcDpQke78dZwv22ZEgNumyjVHGtnBRQixDwjg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/HXPt6nEo0a/ya0GNERWxCMOQvb4mTJQ3WCdZfI4RnE=; b=ylO6fiFdSV+yEQWZlruI8FaBPA8iWpglZeN3uiJaIwwL0mCo7s+qsz+1s+9DZQabzG7A2B8UyRm0u2OnKOqOaVhC4d3bAsAFoTk/VfTZsrD8e2ZwY2NBv2JUfZbD2iEuem0Wo3DWP12MXiJOl8VST3bYmlIRn+WGO8uCJj05tBeNHK7Mwe+R3uQc9QG0c/B6UXaJrPx75/jQ13mYpPaDGirH6VC+5XUMXEowst+SZXSsutD+ol+q5JTwHvD+4GCtDNy3+UUg+CIHwvi1Iob7CGhvQLBKcsUB6hLSNojBbicZ8weCybHSDJbwEa4kVwWzZjX+Uk6txKa9eaP+7kXy5Q== From: Mark Cave-Ayland To: pbonzini@redhat.com, mst@redhat.com, marcel.apfelbaum@gmail.com, eduardo@habkost.net, imammedo@redhat.com, qemu-devel@nongnu.org Subject: [PATCH v5 07/19] hw/i386/pc_piix.c: remove SGX initialisation from pc_init_isa() Date: Fri, 11 Jul 2025 10:57:09 +0100 Message-ID: <20250711095812.543857-8-mark.caveayland@nutanix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250711095812.543857-1-mark.caveayland@nutanix.com> References: <20250711095812.543857-1-mark.caveayland@nutanix.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: LO2P265CA0174.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a::18) To PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR02MB7159:EE_|CH4PR02MB10681:EE_ X-MS-Office365-Filtering-Correlation-Id: c94db840-23f0-46fd-1cf0-08ddc061840f x-proofpoint-crosstenant: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|376014|10070799003|366016|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?JgVidmkgyWm/a198+Hy+J7bTowmLi7SGuMyyIbwjG4/RzEEX1+XPxqyaLkjy?= =?us-ascii?Q?urTae0/nyuMkog2bYcHKO/PT6nlRv3iIKvH5exkBJMNR6yhf7n4eA1OEAUeM?= =?us-ascii?Q?65xpCPLMVQwnN3q3n2R4tWIaOmhlsiI6JfK855BRL1BGvQOEHZbSiexrhC1W?= =?us-ascii?Q?8D2dqBNkne6fqiSxbsk5SkIWGxlyevYyVPamLXTLr0gzNqbctR2r57g3qwI0?= =?us-ascii?Q?l+52jQ3XVrDJ8mOC63gfDwswbTGf+1hc7IH+JUknXd2ijvJ6NYpRI4LgIPn9?= =?us-ascii?Q?YKeeXu86JcrK4sImpO+LCG+VMqHwc5nu5AB+UJyQT2mc/0F7X3TiroOSn4Ny?= =?us-ascii?Q?/8YPISUM5KSQviNfqZu0z0T7sH4VmPZ/SXakFfqijHyiTda1LMmCigkeTQlf?= =?us-ascii?Q?uxl+pg6qQC/CWzCF/MQe6zHkKX6OU0SmnWFu38azdFzRqSM2Kp2Ud9G3klFv?= =?us-ascii?Q?CJYJDFIlU9QA/tRpDGNIMdDJurP6l8btSep07DtUZEOFbRUaj+dywwJCzu3f?= =?us-ascii?Q?hSYefLfCxhZj1AFlg0mMFHBZTDYutP0xciodaDuOnwNrCtfhiyiaKoDxiC/D?= =?us-ascii?Q?cBstaOwod/X4h1JJnU/rb6KzlqgT8g31gyVWzWeMF4fESjYeVNoCniPF2S+t?= =?us-ascii?Q?UnNK6IdyXrf4cUFfdaruG6HM+kJb1KmrhBND7BnFK2tCrYhFGYod7VUl6Nw2?= =?us-ascii?Q?zBa0y0HKHovkAKCVFBflQGrybL80wugI2p0w5j9z7mJoqObsgoE3U3RUBMRz?= =?us-ascii?Q?Zcv9RTCCg8VIzsGHAqe51cyFS7B+xI3bpYZqQuD8yTO9rPx7G0HXiyD+vnsL?= =?us-ascii?Q?Qrhg74BV2I6t05Rhdv2OEyjh8Piip4XCRCnjuGDkkFxewc8l81YRYQhH3qaF?= =?us-ascii?Q?uhn16sDR49kyjjoce3P0Hm60+00jkf1gKpKay6W0yi65UTqPy1xvWtsbUR7e?= =?us-ascii?Q?ohsJze/jrAsKXzEaLHEel8aMUnnfLw/bo68gOEmvggRwP3rxtJV0Ec+81aG+?= =?us-ascii?Q?5AxLLtvZDsMmegJPH5Q2Dt73namaBYjhsO2vXPJhCYjVP7PTm8oQ2xF1GkfB?= =?us-ascii?Q?dorZ4V+o/hZzV3qcSbBRp9gPoD28gCKvEUfT2vsdVf/Z8zZaH0ZWATC0a8BU?= =?us-ascii?Q?ZN/IRmkScmsZ1MluqC1j8EfrEXVh8JG7JC1gHgzmwY0FGbzvUVDn5Y46GCDj?= =?us-ascii?Q?vQ4mE9aFlNUbHCaTIwSdrFSStHqD6ggnzcy77bJ+7BQXNSnQi8cgcyaDDdwH?= =?us-ascii?Q?fTBTxKzNL7NYuPPJdV73ECdEqF9ccoNdLYp9uelPLKqGoHrM7P9mE3LgNheh?= =?us-ascii?Q?IgwJ67iKZA0UIxJLgXnn1KVTjTYLo2Gj2mWxABtjvpIqLHPN/I1AYOnLlfLq?= =?us-ascii?Q?JnHZNRK7DVjsWf7Yw5FoNtxjUgm3K503vn4V6QVE+YVumAeMfmhWu7zyl55G?= =?us-ascii?Q?3LZ/6v3/awQ=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR02MB7159.namprd02.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(10070799003)(366016)(1800799024); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?7porHKURqe3k7iqIU2Xu17vzxIrtns7qQEum1QuqrjZcaa7EbCqBFCzCuK+a?= =?us-ascii?Q?S22NAEjsNqHSovHUIP8TQcX8Zm8Ev3k/HBKOz3wFfU2A0mr24GdYJiO2u8Zh?= =?us-ascii?Q?OWgQt2ZS43W3BjOZT2ZX4sMes9e/wbEmotUy8A21NKzud7OF6UOcBV5441ch?= =?us-ascii?Q?gpYZ7rCVuBy56CcGUgAi6v3Tl8N4hPhCTmeAoIcpNIC8BjyGLA/yMDYH7fqj?= =?us-ascii?Q?Q4gZDvzlaMTreRkoNS6wFMqZ+l6kXZ2uRpI3vyUUebTxGDn17da3Y5FOFLDR?= =?us-ascii?Q?/8D+zHVhnRDJOH96JEa6MAHxtSLskHUJz9xrFBN5HMNAXKAYlpsVft07SbRq?= =?us-ascii?Q?mLFo8PQ6JYQlZjY6qdnVNCvDSCRwjVZqktFbPuszB9N9FIe2KgJBpFBCT2mQ?= =?us-ascii?Q?qCTTUpR9IoTCrv23YIyKuGOZOIZJncU9RsAT7v1EupphU00WTQvbwoMvimD1?= =?us-ascii?Q?vN02f6LjwTMjgzgzxCD/nehHt4YrRW3UZpP4x0C5d0MRw2fHWIYgfZAe0VB0?= =?us-ascii?Q?VgmBQDjoEDmSyIkQRhstVvbAWLrnuTOOGDbSXP9RIBIBlBzO2zG6VkTBzy5H?= =?us-ascii?Q?i697BoUhRaXfTdr4Grhimj3a7Q4/gK1NTVawzXQfBYGxaE2Bc2ufj5LUC9OJ?= =?us-ascii?Q?Jgd/uts4PddkwAhYv+pSZiBKDbvNPvfvrsmiez5ZnQfw+P2LsDmFwLpADV2Q?= =?us-ascii?Q?0750U2I0gRQ7XoKWDU/FzZ/Xojgusk4CRtKnKt2e4x5xqkIduQK3hUlgE1JC?= =?us-ascii?Q?0ocAelBESFB6WqmaOf5Ze+U/7SaiNI+Hi0rRtPmWfXxyuBI1Tczbffoo8kA3?= =?us-ascii?Q?ATpHXiIt8ONUd815/Auk/Cw/fqthI5d2DMpiOEkJEKGi6NPvmUuV8/eCbhm9?= =?us-ascii?Q?cWM4Lq2EKGm10E4oLs4LUYhJbsb8F3wYBZ0Ime2xtmLKDeMG92lURKMpiqu8?= =?us-ascii?Q?ru46MtsLs/2aU6eILbvQuEaIHeZgPdicLGjAIkxoRK6t2wAAI1A5HMPsYlsW?= =?us-ascii?Q?n40EP245P8zWcr2Fk46onRdxsKy68gz3l5lH6U3hPkSWcYk5ZMOf0R/uaicm?= =?us-ascii?Q?lKMMZZzhyk7YvR17/RNj6VbOg5PpBKgFjb12ZZ3MG4RItDOXmhhFjwNKaMuZ?= =?us-ascii?Q?iVFtXKZoi8bXlZSQuCrKdMe+jOEfuv/abdVV+1dqKYlFlF80pYyCtn13+Xlg?= =?us-ascii?Q?Yk52zg/zZHLXcNO8n41mRq4WXWlU52WKkGGWKiNOEFVCl1O8C3JCFvalekW+?= =?us-ascii?Q?ekCWruHdyp33AubH4IGPtAdUfHofPrNHsQSQHZZEKTiCvkAYwXpghDi9ESlG?= =?us-ascii?Q?eUk1Pfjrmr/2DOuikNgPtLXRT4p+Uw+tdE24oL7f0a9Le8Sh4+FvrSeL4wIi?= =?us-ascii?Q?gSW9/S35Lu6h6hmhPtXWNaBHt4zhCSFVyShvYuSqQFgEsTCzbAa7wS/J4UCb?= =?us-ascii?Q?rbb5xFWrwESUAPsNaY7R/I1DRaDIploKABtpLNawupiPZp6p7Qt2yBqQFM3j?= =?us-ascii?Q?W8hT4J2/XsZql7GAz3NMggU5gi77rVA+aq9epBHNhcSrZpFpDCCLRfGWjbKA?= =?us-ascii?Q?B3HjXNFob1R/aZtWTTG0bz5pJnXntiFkvJWfNvK2H3DLTnViu9phcCpfNXQs?= =?us-ascii?Q?agP9pjQZR9mOfmtmnhRDifQpznOYGlIeB/wS9hfBTH1XbyQr2lxX7d9u19bL?= =?us-ascii?Q?SDsCBA=3D=3D?= X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: c94db840-23f0-46fd-1cf0-08ddc061840f X-MS-Exchange-CrossTenant-AuthSource: PH0PR02MB7159.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jul 2025 09:58:41.7369 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: tzTlvoaAIdv0qK4AIUxmMNF2WRQl3rwD4uY4h2F4y3eQx/hAE9wy0dAsI5LtwVTsnwKQkDvJy71ifYORcwe862o5VfWqa3otVTRJzr+iSnQ= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH4PR02MB10681 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNzExMDA3MCBTYWx0ZWRfXz6aJ5LrJhsAb /B6xJdFrPqewGHvJ3bhR6SVW/fZy0VeeqB7aQ3en341OKXBHriLdHEPq91ydVYpW1bzenNJgVQR 1ulClucQ77+SgOhS9jJWcOoZJEOiV6RWM25PfspQ0vLeETXH+c+7cJnL20OORHwHWwnwaUeAiHF HuAxj9hG57s3LLGxMXl3fYH6EPfCOXeHQTh2Z2v34bQ68aqGfumSCJIAgwjCXYtnkhaTQGDXHPe YuwdKR3ex/yKWxwi/zBvQk5QxlOBW2tfc0arBmfr09vLpYH20sxO4FG8MQ7hVaaQRPyGYVdSSgW zUHYcgJn1lCrZGsXWIfnNPAJ/X+2oE86g9Luah/LLU/hJVXCK4fksKigzjwiGnHnpf+bbSPjgYj 8mHPPAWpX/qj6VpttKFE490NbV5JVNDV6Yril8bDPh0YEmr1wGgG2kVeySpRTRa1oQMf7anr X-Proofpoint-ORIG-GUID: Mggllu1b7rMl2MXF011Dw6tCJKKR_CFg X-Authority-Analysis: v=2.4 cv=Do9W+H/+ c=1 sm=1 tr=0 ts=6870e053 cx=c_pps a=fuE/7uQEd4exF76fV1vK5g==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=xqWC_Br6kY4A:10 a=Wb1JkmetP80A:10 a=0kUYKlekyDsA:10 a=64Cc0HZtAAAA:8 a=yiTRickECGlooSfTVXsA:9 X-Proofpoint-GUID: Mggllu1b7rMl2MXF011Dw6tCJKKR_CFg X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.7,FMLib:17.12.80.40 definitions=2025-07-11_03,2025-07-09_01,2025-03-28_01 X-Proofpoint-Spam-Reason: safe Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=148.163.155.12; envelope-from=mark.caveayland@nutanix.com; helo=mx0b-002c1b01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @nutanix.com) X-ZM-MESSAGEID: 1752227970940116600 Content-Type: text/plain; charset="utf-8" The Intel SGX instructions only exist on recent CPUs and so would never be = available on a CPU from the pre-PCI era. Signed-off-by: Mark Cave-Ayland --- hw/i386/pc_piix.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index 16d666f97e..c49be1d799 100644 --- a/hw/i386/pc_piix.c +++ b/hw/i386/pc_piix.c @@ -491,8 +491,6 @@ static void pc_init_isa(MachineState *machine) } } =20 - pc_machine_init_sgx_epc(pcms); - /* * There is a small chance that someone unintentionally passes "-cpu m= ax" * for the isapc machine, which will provide a much more modern 32-bit --=20 2.43.0 From nobody Tue Dec 16 21:11:18 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass(p=none dis=none) header.from=nutanix.com ARC-Seal: i=2; a=rsa-sha256; t=1752227974; cv=pass; d=zohomail.com; s=zohoarc; b=agC5YlouSQ2c/OB++8tTAZ4ROetPlJJ43R5OeekDtfXQiBZ8p8OfkBL5iTSfB09Q3ekipWyGTxcZCVmTfbIAgkW6Gz6IpINny0V5m7V2tobPrM/oVVXmdJdIJu6jBEXc0FN5M6B8kw9+llpdnq83HhTnFXYRNnfAVjiS8S4nauo= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1752227974; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=ShKUPlA/XJzEqFPtg+j2rtiHW62XO9UgBfyYcIjb6Ig=; b=BVO0tQRCBVZYl7N8Ib8jyuJsbSuQP1Eg3JIj4ev+42yklBrrLFhwq8PfKf8TU9rsC/wEvp1L3TlywDhjZwpi7w/Knv/HkJboR5SdyG5PhuGemcx1Vy3kPjabTSdat3gJYYmjw0571AonEwgIMDQDucRrlc+J1jQrzf7nMQJWwdo= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1752227974219418.75525731434743; Fri, 11 Jul 2025 02:59:34 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uaAWs-00064c-Jv; Fri, 11 Jul 2025 05:58:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uaAWq-000619-Ja for qemu-devel@nongnu.org; Fri, 11 Jul 2025 05:58:52 -0400 Received: from mx0a-002c1b01.pphosted.com ([148.163.151.68]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uaAWo-0004q6-7w for qemu-devel@nongnu.org; Fri, 11 Jul 2025 05:58:52 -0400 Received: from pps.filterd (m0127837.ppops.net [127.0.0.1]) by mx0a-002c1b01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 56B2np2Y005261; Fri, 11 Jul 2025 02:58:47 -0700 Received: from ch5pr02cu005.outbound.protection.outlook.com (mail-northcentralusazon11022093.outbound.protection.outlook.com [40.107.200.93]) by mx0a-002c1b01.pphosted.com (PPS) with ESMTPS id 47rkc5v48f-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 11 Jul 2025 02:58:46 -0700 (PDT) Received: from PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) by CH4PR02MB10681.namprd02.prod.outlook.com (2603:10b6:610:246::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8901.23; Fri, 11 Jul 2025 09:58:45 +0000 Received: from PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88]) by PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88%5]) with mapi id 15.20.8901.028; Fri, 11 Jul 2025 09:58:45 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint20171006; bh=ShKUPlA/XJzEqFPtg+j2rtiHW62XO9UgBfyYcIjb6 Ig=; b=q8izpIJbyT4GyLKxQij0YN/VZYbWY/DRF4MUDvKZnh2XAO3TXpk9qmkPE zcyzpCMVmExhz2B1VSG34eW5V6tXSX3L8f1LVTHqaAf/z9EI/6WSfYgmsPfHn1lF GF7wHPzsKwTvQ8J1aEo2gXy1HXbZWHrAA1JtSVEDTZYHLixR0P0EqHyZlvFo33nj sk19Tn1fB6Ikj9tpK4+URLBC9XTeYzqzXB8rejk8VSLzEQ1ow7HwvsTH3JaZ0TeF UV70R8hU6g8knqLmm6FvmRImy5wWnEYJ/7UY8sLjh2j+QdG5Bu73GohxsGdzqKDt TtawDCpA0VYaaNeookNLoswIEBV9Q== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ua9XaP8bwT/lV/Cv75t4pTzost9x2wV2bctQZIiY92kPZEx1/x8vbSd7HDpltdY65TLta9PgqfnpdzdND8wJSH6Cju4gMRRQJ9oHi8LFw76XXWLtfv6zYKdLuy6x9aOkAWQK3KIWb+mdW5GE4hkFO+n1xOKVylcUy7q5bN36X7s+Q1tvs4jf+GDTFabeDo5xBqh47K2DwUZeYWJ7RiAYDZlyI7Rx2g0oAKhC4d1ARPnfs2fUNciwVZMtfMEzS4/G58kGyIIh89P7vCfd+UMBgceNJXXWcxc4PyfkrYtPH05UWiPrasPgSerp8uRZ5Du2DlDDW4FKESFQWkg3V5/ICQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ShKUPlA/XJzEqFPtg+j2rtiHW62XO9UgBfyYcIjb6Ig=; b=glz+QXXIwY5qE6nTcrSkxeoDhTa6kUrqo7aR1QXVXwV5ItWfYTs4R55RI/rJoSV9MaBbuJXSyssS5qWfPyD6NTQTF8lgvoIen04KMtH9yW7Wl9bAqQpJbvYYuo096FR6UTCafB1hUAEcAQ8SXkspZEorGHHDY1w/48TQvhdyk1QDoA1IPsEyyjMuHczsYTTjo42tNVCeBHZDp8e1Kx3S1/lKopYKU6p72P4uaA9oWMJk98NALzc2pZUxshcNZZgeSDgbz7Hff8ESB1L7GE03bjx4Z+iGiAHq/lo1Kvfp00A8k1i47Jbxbn1Od7RO5J1U7vO+wbGWf0QEP1GC3D9p2w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ShKUPlA/XJzEqFPtg+j2rtiHW62XO9UgBfyYcIjb6Ig=; b=NwEnrNEPxQGs008NmSTiv14vqzZWustqUC9pTEig/+6oXT4Jablk8IllfQUPgOatSqFoh0+byMO6xhSGgTW1Qk7HvFBSsGu85/EoLdZoOoMLAUs+tv2EGToDGyHlmZBanOzJJoCPfBks70o4VZ514+QKLxiSFVtLH/hONrRHjxzgNmx7cq5UVke4OELuWqm1Y/jvFZmiAEz90n2NLf3qLzbLYGNpn0D5KeoTmUc6M0yHC7Q5M49gPUJ+IiDcr49RsKcVSlLXlDg4lZvKOogBeoUBVr7m93vlkuuKd2145t1tlCAQ0NP/AnAX68gTaCjY2kK7vOs6kBF5rsG/sCUkSw== From: Mark Cave-Ayland To: pbonzini@redhat.com, mst@redhat.com, marcel.apfelbaum@gmail.com, eduardo@habkost.net, imammedo@redhat.com, qemu-devel@nongnu.org Subject: [PATCH v5 08/19] hw/i386/pc_piix.c: remove nvdimm initialisation from pc_init_isa() Date: Fri, 11 Jul 2025 10:57:10 +0100 Message-ID: <20250711095812.543857-9-mark.caveayland@nutanix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250711095812.543857-1-mark.caveayland@nutanix.com> References: <20250711095812.543857-1-mark.caveayland@nutanix.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: LO6P123CA0054.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:310::11) To PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR02MB7159:EE_|CH4PR02MB10681:EE_ X-MS-Office365-Filtering-Correlation-Id: 843f1bdb-600e-4ce1-b4da-08ddc0618641 x-proofpoint-crosstenant: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|376014|10070799003|366016|1800799024; X-Microsoft-Antispam-Message-Info: =?utf-8?B?bUtiMDZCN0FML0NSNEYvS29TQlFvalpESzBVWHhkTVpqUG5IZ1BhdTBuZDRQ?= =?utf-8?B?Z3JLYm1oRzltNDUwWDRtMFN4Q2poTGNoa29aRlBqS3RCSFR5NCtkRE1aSVoy?= =?utf-8?B?dE85MG1Ob2tMSmJLUE8ybzlsZVFyRXMrK0E3Nk5LTVAwQXM2RkZCYzM2c3Ay?= =?utf-8?B?RTFoS1FUNHA5OHI1V2NxNUkrYW90SlVsdG9uWVRHbUpBOGx0SG5ITWFvU3BK?= =?utf-8?B?RktZMFExVWp6NS9iSGRTNHhEYzI3RUhad1hoSGdPZFY5akdjL0pySGQ5TlJQ?= =?utf-8?B?bmxiai9iSGdGMjVDMXgyT0JaYjYrdXk2UmRoSTZNTjF1cmgvZTBlSXFNZzBN?= =?utf-8?B?OVQvSWJRYi9ySVFENSs5Y2dtNUJnVGV4L0hCSlh4WkZraGlQVEJBODFyT2Nm?= =?utf-8?B?WXRnbDRMRzltSkhsMGp1Y0dnVDFqSUQ1cmpsd0grL25aOEx0QUUvODYvTzAr?= =?utf-8?B?cElHQXRoRmJBMmFMMDRwWUF6N2c0ZVR6Y2MvRU85bHo3bVR4b3hzVllrWkRS?= =?utf-8?B?bEUxMURUbVJBR2RhWXhhZWtEb0ZyT3ZkZE00dzd2NjcweUp6V0VpdURXa3RC?= =?utf-8?B?NDBDNEdIWkZ5Z2F6WXNvY1liRW91WVJEMDlIZ2N4c3RwZWgwanIvWHFiUHBs?= =?utf-8?B?Q1VrK0x3Z2txbXRmWUtDN3pRWlV4cEJSQmN1b0lTVEdRR2xrWmphdDJweVVk?= =?utf-8?B?QjBNazIyOWM1U2FsdzNRWmVVdGg3cEIyaHJ0SDRpVkxiQXdHZWV1aERJQTB4?= =?utf-8?B?RWREM3lETE91cnc4QWs3cEVkZ3dBaDc5Zy8vT1hKNVRuR0gvZWJXMTdJSHl2?= =?utf-8?B?VkkvUnZkejFpZ3Ira0JkL2oxZUd0eEVHS1VXb2lvc01LR1NIcmc2R3pmblEr?= =?utf-8?B?TmdSRUNma3haSm5qQkQ3c3o2R1lsbEFKZURkQWlRR2ZsV0U3NG5qZjQyVkFt?= =?utf-8?B?WERiWnhRRVFBd002TUdKQ2tCVC9kNzRhZ3ZENitCZ1dkYXpHV044VHRuQ2lo?= =?utf-8?B?eURNZGlaQlk2TkVMWjVZclJCcjE1V2xlOXFBRkdJSmNFMlVzMTNvV28xWW85?= =?utf-8?B?QjgxbHJiZWh5UGNQOXdISkZhSFpDcU1EMEZFT09XcTB0eWVyeFZHemc2OFhB?= =?utf-8?B?MEpFV1J1SFdXYjU0UnBxZTVpWmpQU0gvUkpBRVJ6bUlwdWg3S3VsU3QwK0E1?= =?utf-8?B?dlpqUms5TGYvTW9iYnZ1d1UvZDh3dGo4QkU4T1FhRFB6UjRJOThOOE9CY2t1?= =?utf-8?B?L2RncDdVV2ZSdzQ4WnQzb3l4WlVnS1RtM21JQ3Nic2Ftb0l3MXZ6RzZzSTJ1?= =?utf-8?B?VHpCQ1RIT2RFOEtqSzhIR1NiZUxPWnVDeVZTWEhxQ1BOeWdvVDlBZk9GT3RW?= =?utf-8?B?eTNrV2dZeUxxcElrZENpNmhnQUljb1NoMzZPVzl6LzFDYWVlUVpjeUhyc3Nh?= =?utf-8?B?TVlXNHhPZXljMmwzUjRVempXRkRJOXY2YlVZbU5ZQ1lnSFA0eFJndGpVaHhs?= =?utf-8?B?WkdyeUJ3bXFXQzdWRUpxRUNYNGJ4WDFndkdlYXBwVWF1UU9taXpPaWpEeEc2?= =?utf-8?B?QmJqYU90Z3NtS1ZMZkVZaDk4a0N5WHhXUU1XRnUzSGlKb3AvOVp6bjJ1REJr?= =?utf-8?B?SmZ4cWF5bk1TZHRwTjY1UEVHN3lYVzI1Z2QwNDRPYWZjT0RrVlRERDd4UUh1?= =?utf-8?B?L0hLNGVmNzdsMFdtWGwxZklSUFJiU0JPdk1FNXJ2Rlo1RzhiaHViSWtHZS90?= =?utf-8?B?enNOMk9xVXdwK1lhS0dxWm1UbkI5TzlPSnlxaDc0NkFMY21Ha3JsaDdtWDlo?= =?utf-8?B?Uy9iR0FDMTI3aDdBOUtzVGhDVC9VWG5INjFDNjVFN2xnUmJJVUNwOXVpY3FY?= =?utf-8?B?MGZ0SlJNZVkzalJwL2VGSDNMYnR0dlFzNWxKZ2NBbnRKQ3VDc3BtWklHNjVr?= =?utf-8?Q?QUxn9GATUkI=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR02MB7159.namprd02.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(10070799003)(366016)(1800799024); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?THpjTXJNYkx1SE4rbWhFUVJYbi95WXV5T21PQ0dNd2RVUUxLSmlzVVQ3K3RS?= =?utf-8?B?VUd2V1BOaUlRZnB2bEorTHV6OWJieGVsc1JkdGgyNzFMZkd6dHd0czA0TGRX?= =?utf-8?B?NVE0MHRid1lWZ1o5VnFzcThzNkpjUWJjb3VVcTMzQS9NLzhSVWpHbEtINHVO?= =?utf-8?B?VlpCdVR3QlRzcEVDSmFBS0I2V2tlV1lBSCtObzFINDFOV0JaZDhTOW9hWlFa?= =?utf-8?B?TmF5bnkvMVBFODNYZUJoOVRMRlhwSnYwTUJJQ2lSRE5tZys1RkpNandDZVJX?= =?utf-8?B?SEMvK2p1NTlIdWxTNFR3cDVMRnhIRFJyOW8xTDJZSDE1MTZYZDZrQ1gxOGNG?= =?utf-8?B?bHZKeXFwaGh6MUtFd1BRSmQ2NllVK3c2YVh6citGdlA5TkFYNUEzWFRIcEEr?= =?utf-8?B?bmNhc1FvUDNNZUgzM1FrVWxDbTY2RVRoQUxZYVJGSVA4YUw0a1JFclRtNEZq?= =?utf-8?B?eGZmaklJazlCdnJHcklqa09DZ21xclRmT0V1Y3ZSeTNwR1JOdjZpNVhVM3FU?= =?utf-8?B?QjhtNUI5RDBlM2NTSUhsR2dLdThJMzdUNEFmby9ST05WbEwvUVZOTzFEVk9l?= =?utf-8?B?R2x4ZW1kYWZPK0p5MjhUTG94LzNEZ3pTVGk2K0tjMHVaMys5eTZ2QW5yOXI1?= =?utf-8?B?WjgvNEhQZ2xPcUFUT1JtYisvWU11cmJzOFNFc29neGRUZ1pPSjM3UEdYclFJ?= =?utf-8?B?d2NMR2tUQUZJaWNzUXpEZVJGWUFjanpYUGNNTUdNMnpWdE5MSmpIaVdTLzIr?= =?utf-8?B?OHZudjh1WmtSRXZJNkIrMG5qRCtsUlhKUytWSlAzUU5OTE1CZUlMcHR4S3hB?= =?utf-8?B?VnBWNWpweE1MTnlsenU1OW1nQVJrN290Zm53eWQ1L2FUZ0tPd0E1cmQrWVZt?= =?utf-8?B?dWhhRk9tMlV1cTZXUElGSGdsNmxxMmJQeWsrWlQzWC8ySVVNV1FBWmtzN0pP?= =?utf-8?B?UzBzazJBb095T1Fqa2Q0djBSQ2JXRmxmL2Qvd1h0bDlVZnI1K0tzS1VqcThV?= =?utf-8?B?dWJsQThoUEIrQm5rWHpDWEl0RGY4eDY3cGh0T29nTFVidDcxWWlKdzdzMCtz?= =?utf-8?B?RWFTZlc0QU1GSyt2U29jQUlXMkVxWTUraGZpekxCZzVlRWVycU5OckF4R3gz?= =?utf-8?B?MmVoQnl0eFpZMHZTZUx6RXZlbnl2cUV4bXphOUdLTnlvNFc0M1dhV1VGRlFx?= =?utf-8?B?a1k3WnBTcTJjWHU1MG0vYTRiSDNqdWQyWnhwOCtSZVdMMzQxTUliTWpBa3FT?= =?utf-8?B?a3pWbjVmQnZkaVNpb2xYRUxhK3RabTVKekhzNVV1TzdCVUpKbXF2S0tsK3dG?= =?utf-8?B?QkJGWmJkSXlSOVpvdDJoc01kamU1UkxwUHNMdjkzRkptMU4wdTM1SzRTOUxn?= =?utf-8?B?U1FOU1FaeStMSmorMHZIRXZaMENCTHVCVnlwbWxQZHkxWDdTWUN5RVd3NTZD?= =?utf-8?B?WUVZelFzUWlrSXd6NXJ6YUVUREl5YkRoazZDYjQ5MmpCcjcyQk5URDdxdGJC?= =?utf-8?B?ZTArdkJmcDFER3cxSS91Y0NkeXJRaUxEUWUwa3dPUFpqeExxcEZqQ3BpT3Vl?= =?utf-8?B?RlJMVHd0aFFxOFZlTXlDeTlRS0h4eUJYcTgzZHN1dHh3K3hxM244OEYzUEx1?= =?utf-8?B?SCswQW5Ic0YxNUlrY2dpQ1ZtYm1xUlY0aURmNzhlK2NESnRvRmxDNXlYVUhx?= =?utf-8?B?WjkzKzVNZzdjUW5WTWs0RC9MT2JiVWFadXl3WDVBYzBwdmxTL1p5MHNEWlRu?= =?utf-8?B?d3NjZFlscjZPZ1JIR21pY2t6cUZweHgxcWo0M1lPNzJJSmdwdVVWcDZkSTJa?= =?utf-8?B?c2VhVi8rYnJIcThQd1JvRHU1MGNZYUgraHNBeW5yaUVZMmRreFNBNk9kREdD?= =?utf-8?B?ZUc2UVdpWmhXUk5oQjJQSFJxTGpqaWl2UVkzZm9YSkdpTnJhdk1meEZIdDVD?= =?utf-8?B?ZDVsc2R3eko1SmlxRW9mcE11VjhyTGlIWU5tMWFZSktBdGVWTmh3a1NNTjA5?= =?utf-8?B?TnZWNllDcXhXQVQ1TmI0NmcrUk9kVXA0OFlraEoyOGF2OXdoanhSa1dMUUdT?= =?utf-8?B?SzJ4cXFrakxWOU9Ob01DSWZnTFNWTEFMd0liVlNZNURqTkZtMzQ5a25KaVlu?= =?utf-8?B?UWpSMGR5TDlMQ2tZNGdVUE1SbFR3Z2JRdTQ3K3NaOUdkOFZxMkRhRDh0eUdH?= =?utf-8?B?Tm1HUUt3dnVNWm1UU0NUQVBVOThGQ2JIaGxZOWRjYWpQaTdaK29qWmJXZXFC?= =?utf-8?B?SXFBVjhYWStJVGdhR2VRQ1lPUnp3PT0=?= X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 843f1bdb-600e-4ce1-b4da-08ddc0618641 X-MS-Exchange-CrossTenant-AuthSource: PH0PR02MB7159.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jul 2025 09:58:45.4311 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: tj8qESD+ytJD5gmgKKIZ221h41pB9t1AHee1g9YxL7Spbfzy2GhuTgnNMB/JO9yMYYzbz1qiOSRu8QBICTOpRavkoxim9z/LXxKcCwlySzk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH4PR02MB10681 X-Proofpoint-GUID: wWMGn-ciIR_yEZdSAuSpdG3ngJXhful1 X-Authority-Analysis: v=2.4 cv=EdbIQOmC c=1 sm=1 tr=0 ts=6870e057 cx=c_pps a=eRn1cRo1khMZ7TFbvRZV6Q==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Wb1JkmetP80A:10 a=0kUYKlekyDsA:10 a=64Cc0HZtAAAA:8 a=KKAkSRfTAAAA:8 a=XL6wrB0Zc_gxRR1ig4QA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNzExMDA3MCBTYWx0ZWRfX7Vq8vpNRA4HZ bZyAz+FPCxN0LWfF/8l+PfNRNBeSxxsngaJDQRunW3e8LtANMlqn8N8bM/cVrxvT0qr5QQ/ouP/ x+uQNs9b1hoo8ht5ncvpC9IkMp8zNXjq14ELrsrzvJwXXr1ne8I752bWZ6QSe4CHOErHI56P4fD lS/iQXuFrDuM1phvWv+j8tgy89e3eTEGBva41Yd8cZ4FzIffCWKEeftZTDBU6OcH3Pv05+/Jqnl ZJfAvWrr2PxIbM8swV17PZlchRJe6wxAVAFQezZRL1I4CsdV19zGZbJRggAJpQiuim2MepDHiq7 YjET1LWI5L92IZQn3FefqGvFb212/jOPfv2uDlA0M21bocwiTJpmz4okM515dqSJEaa9bpyBkEb T5vcdo2rXzm1jUjyHH+07lx9gUdY3/87iBEMMRBoE7JqQGQ8lANvYVJxQEBVRiBnx6gVi2ZP X-Proofpoint-ORIG-GUID: wWMGn-ciIR_yEZdSAuSpdG3ngJXhful1 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.7,FMLib:17.12.80.40 definitions=2025-07-11_03,2025-07-09_01,2025-03-28_01 X-Proofpoint-Spam-Reason: safe Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=148.163.151.68; envelope-from=mark.caveayland@nutanix.com; helo=mx0a-002c1b01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @nutanix.com) X-ZM-MESSAGEID: 1752227974767116600 NVDIMMs cannot be used by PCs from a pre-PCI era. Signed-off-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- hw/i386/pc_piix.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index c49be1d799..78f50a7893 100644 --- a/hw/i386/pc_piix.c +++ b/hw/i386/pc_piix.c @@ -574,12 +574,6 @@ static void pc_init_isa(MachineState *machine) } } #endif - - if (machine->nvdimms_state->is_enabled) { - nvdimm_init_acpi_state(machine->nvdimms_state, system_io, - x86_nvdimm_acpi_dsmio, - x86ms->fw_cfg, OBJECT(pcms)); - } } #endif =20 --=20 2.43.0 From nobody Tue Dec 16 21:11:18 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass(p=none dis=none) header.from=nutanix.com ARC-Seal: i=2; a=rsa-sha256; t=1752228037; cv=pass; d=zohomail.com; s=zohoarc; b=BYNHn1RHvJo7w07IOASIGBgBOJ2Can2rXQNj3gJXegAJGGwU35p0/zvgLLuJlEuR8CfSLcZw/RKhwIklO6gKufx3nrDOhB7VXHMLxaBCm6er2ZZyYYGNJ35OzBYQihxQyiczbPx+xqGB0+hhRVuP+lH0bEZKBBXQc5lgS5Xovr8= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1752228037; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=39a61ttw/5umG2hAm3Vs2Bra93sIZ0MTERbxhQtXTNY=; b=YTENse8vOL9q0K6HyDcEGzMLBPgUsUeGQ3BG9F4ebZgrveSgMJ9qvEbn7fo/yFurtBpLnlhf4XqWeeyYS++ZOWXz0aIpCREk/T/wBLCs8IfmkjW8ldPEkbWrBX3SwETabh1zc1Odh5rGdaXDyYOefAcOJSl6AK33r7zohIaHEX8= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1752228037104751.3891846538082; Fri, 11 Jul 2025 03:00:37 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uaAWu-00068b-R8; Fri, 11 Jul 2025 05:58:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uaAWs-00064V-6n for qemu-devel@nongnu.org; Fri, 11 Jul 2025 05:58:54 -0400 Received: from mx0b-002c1b01.pphosted.com ([148.163.155.12]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uaAWq-0004qb-Cb for qemu-devel@nongnu.org; Fri, 11 Jul 2025 05:58:53 -0400 Received: from pps.filterd (m0127842.ppops.net [127.0.0.1]) by mx0b-002c1b01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 56B76bqB025499; Fri, 11 Jul 2025 02:58:50 -0700 Received: from cy3pr05cu001.outbound.protection.outlook.com (mail-westcentralusazon11023106.outbound.protection.outlook.com [40.93.201.106]) by mx0b-002c1b01.pphosted.com (PPS) with ESMTPS id 47q3cf118p-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 11 Jul 2025 02:58:50 -0700 (PDT) Received: from PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) by CH4PR02MB10681.namprd02.prod.outlook.com (2603:10b6:610:246::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8901.23; Fri, 11 Jul 2025 09:58:48 +0000 Received: from PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88]) by PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88%5]) with mapi id 15.20.8901.028; Fri, 11 Jul 2025 09:58:48 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint20171006; bh=39a61ttw/5umG2hAm3Vs2Bra93sIZ0MTERbxhQtXT NY=; b=KpHVzAoMwQ/Bg+zslM1wNFAeJq/BaHsOwJ4RAyBP+8u45N2VGL80pGDFK VlSzYkTLxaA58huKgrXYiynoHrdrRpwUzK72J+3GSK7Ar3xNk0CJzz17fNhGzbT1 4KR84HXZdhGTvsecIpe3Zv/SvNZKT9q2wM03x1pyDH7439tygQextRC2Z3vlCvtB GIsvzR65WRn62RklevMBAF7/AE7RhZJG+Fx1pQ8PDA8s0gnGfqbONtgCaFh8/MK8 DWQOv15SCsPrKbiBNxWaJz5i5pkKTQVI0kOgfRHY8ShAa/LUvBtreBPKF7xZY6qf yYYOAODH4RJfjHSa00EeGD1w3Lg+g== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=pS2slKbXbRak52LqX3SdR+tpgSHRyzscf5YqvJrZVPIV4kGINIBiKUjLIrKMmrYUKX5SGjk0JUsGbluwjEUIZRAqQZZcV2pJtTgMdecexV/aGJpNrL5ovAOJkZKGSCvrtE/osNAf8eBGm+eJoe6WJpFugXnTE26XHSFSZSpMKELQDdZHD+RcZzfVJ5EVQjeBEMF+pXgD2O0EAXHobUrzykij0/qGrk3+6Rr8zZ3X7ocN1Y/0LrP0uVZRBgqH3Hp8k4OgbZWbqYJ7kAJLo71ZcrQ3qy4+lXfoLGv7SF+dVRNIt8/qzR3e3Tlw3Mx9b7AAVfTQY1OCkLEg+8B+gRGMAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=39a61ttw/5umG2hAm3Vs2Bra93sIZ0MTERbxhQtXTNY=; b=URkYlTXFM8VZOyWr5B4oC4Va3SZHyis/lEvj7sHlYabGkSWAK3gqvAPmjxmJvYHJZV6Fa88FiNiNtBnudRKR55n6Nlz4rNF/CeEgWjcFBYMg32SX+g0vXSBJnfikBmudkQSzi4urL7Mb+OLfYc/dR3kvuAYN3vSqdRtGu1sMW55IaSihggt+wt2g/41ixtb4XbdfAtKksBdkZ1pyLQKLFeKZU3rz70a3kVIvzaJUo+pBt1i2ihA61XkbsT+NnuIDY9YktJ2YWxA2yDWEm8dWoYKTKIHwxw77SHkX5PUFgrXXsUFOZleAAUeGLuOTpx0bZ0sM3VozuqZ+pgpY/Fjyvw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=39a61ttw/5umG2hAm3Vs2Bra93sIZ0MTERbxhQtXTNY=; b=WeC0r0iYSanGXBg1LmzIOTZkr21KvDptgvWEziPpto+bBGPyA+9ifNSLfjsIKElN+e6XoXwlcM+W1pyDslrrvKZhood5EpHLuDSmWTrKBSqC7rCuqOaovJbqWE/FlEgrrUgAqUfS5TUTAYNMAJVY9vfJUL96TuiJM4SQFW3VhAvMcosW3o+kQATBH8RlK8LvIDZy4DtI+v9/7rENo9EiKJIwzWNgU+JjQua98wUbazpTemoja2OUDYT0PoAEl0leJ037H6G+m2wV0AnsNWNoPh5W9AYqSti+mP1YY05WA+rWR5LHDf07K04QQyynCKx/+CxxqoZcLI8Jifq83RypnA== From: Mark Cave-Ayland To: pbonzini@redhat.com, mst@redhat.com, marcel.apfelbaum@gmail.com, eduardo@habkost.net, imammedo@redhat.com, qemu-devel@nongnu.org Subject: [PATCH v5 09/19] hw/i386/pc_piix.c: simplify RAM size logic in pc_init_isa() Date: Fri, 11 Jul 2025 10:57:11 +0100 Message-ID: <20250711095812.543857-10-mark.caveayland@nutanix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250711095812.543857-1-mark.caveayland@nutanix.com> References: <20250711095812.543857-1-mark.caveayland@nutanix.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: LO4P123CA0278.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:195::13) To PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR02MB7159:EE_|CH4PR02MB10681:EE_ X-MS-Office365-Filtering-Correlation-Id: d068cabc-fe29-45c5-d02c-08ddc061880a x-proofpoint-crosstenant: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|376014|10070799003|366016|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?WrtKnrtwmY8nd6+oMkE8wsNU77nezWuc4+n8svnHdxgz+mjE53ysQys8bW8G?= =?us-ascii?Q?iDRtU6KSg+P1bLDmrHB9jGjOgo/BY1M0ULWhRBFbi8rNSBlOpXIGRHFWIEEM?= =?us-ascii?Q?gyvmTYb/fDSEHIbZlo2exmyWXt9MPWf/Na31PfFysu990oLtrjIhHhw3sX89?= =?us-ascii?Q?jkrjVgUswg51jfJS1cK/Z/grDXUpF7hWVL4m7DGXi/Ef9RrSAfmzPjK/XP9h?= =?us-ascii?Q?cGaZ6jiQmvATb2KbzKuFsJCsuoWPVf2Hy3siX611y7Y1Pau6kjfkUE0qI4aM?= =?us-ascii?Q?+9GkSVEXknVUhusgqLj4iUXEGamf4QrzvL5/UkqBh6rXI0IbCqtD8JvIcCH3?= =?us-ascii?Q?Mm4LfLJordPNf6mWSehTpMbMd75FqBcunuDIvPTor5Y9GwB+eFYfjhq6ct5v?= =?us-ascii?Q?qhjPYmGOdUUQ+0qOEBD+K4EorAW8CFIjThe36Y0Tx6RP/sWcx5W5mBGFE4fy?= =?us-ascii?Q?C+7beW2XiFxuHMXmF5v2LE//YcG63LY+cDnFm31cXqBQuHBTcZYMNums8Sn0?= =?us-ascii?Q?DJmzWOYi7Gg7leuAJoqwzBjpE1lG+heNn1aylTCoz66q7QVr9AwkpzrAsUZR?= =?us-ascii?Q?O/MY6fSXHrSarIiuktVd5cF+iryQfjPw9l+9hhzBTFxVamxbesHZ9QB8LCAq?= =?us-ascii?Q?fJoJS3ChkebVpPgFAQ0KsUfSgAlmpUsv9Vut8gcFzQQsDxzUuAGF0UrHnv0I?= =?us-ascii?Q?RmAN5cEytdoIig6WuFdoP/O2J8Lq6R2F6nB3uteH8zR/d8NjgwMDai0/jawY?= =?us-ascii?Q?/jLi4v1Q/6Uvf6Y2ylFbvg8qP4fyzpM5PMu1QMOlx8Aw4VZ6Kq04/7o+Y7OW?= =?us-ascii?Q?clL3+n6I2ujxfdC/dNuxwpCcQ61yNVYW6/DPb7MHcnbnb/cOBsceMnfzJmdR?= =?us-ascii?Q?RzZDHzAX98g2rInCprtDvpIJSW28t8/OPera2j9AYN6JJIMCy8h1FvaiOUxZ?= =?us-ascii?Q?h6s+gMTZoaKtvayolbEjGHjqJycA7j7RNUD2LD3Ax1MsJrXtrSO7mdnWaHpI?= =?us-ascii?Q?OsIgxO8TYuzOulecHP4uR4zOOsXVm7WgVrd+CZPv/uPATBDH6BTp/eXn8mkp?= =?us-ascii?Q?wJB1UWxS8S8Q09VinWr4ltlhVs2D/IGCigT2OiYtv1T7voYuzQiUTvrtZVRg?= =?us-ascii?Q?rRZVo5c6hehFUuiFhs5Q9uTd/8h+v8K2iMpgc3dDUoszauuLVS1sCa+MKDTy?= =?us-ascii?Q?CthgDS3DZgaGJSnUi/gJcvUduBXO/3vxSVEV8j2K9Bmq6WRBFd7C4Tv46D0U?= =?us-ascii?Q?u5BX0ErUI1c70WZCCIayKwngyimET1SgRtMsQOa24TAowq+CX3PNkTUFkbqf?= =?us-ascii?Q?WCKQg52ocvifc30ldlqNgagksIA6/rKX69oYdsNNSqYg2JnqnPPAxYtTGnPe?= =?us-ascii?Q?RjsWSdiMrNB5sQgMxHMA88E6QKXCBgdRDv9/O9F9SPYupmrNKvCyrCniW58y?= =?us-ascii?Q?8BDlxQcKkHw=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR02MB7159.namprd02.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(10070799003)(366016)(1800799024); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?bmqOnRCN7HN9CHAUlsL257w6P7ljPby9hcQneu/+FWPzfEOtKWnFeK23uKTh?= =?us-ascii?Q?ZtXI8t+kLAcO2KMZunSYb0GNDFJVU2imse6alwNJxCaZaYG7yaE9GSDwRVI9?= =?us-ascii?Q?XkbLFp5hLaiJW4yE6qftKrcaSxafm9X9FJUkCSfU95pWpcmY+TO0BZhGicxd?= =?us-ascii?Q?Vln9cM2GFozliVABm2NF0ZLydWK96gVb43uW1w97AxUXQ4JpDNAfow5CUJhM?= =?us-ascii?Q?twH1LoUOba0V6cTfZN/uaSOP0hvPvGFCfatkGvSCCSgXkGd8JenymZeyuWSP?= =?us-ascii?Q?tuJWpzuYC/KXH1gf8PKU11PQNm1b/LiVm2Y5TIxonlD1gv0mZ+6NR7wxGqTu?= =?us-ascii?Q?BuwZgY0w/41EuIAgEh0985DUkDO3XpM9/RI8aDV8BYjcIdq1QxnZk6pz2yJv?= =?us-ascii?Q?7qj+81ts9qwo1Y0S3fdS08mWLI/ILbwlhAuor2cXRKMn8QuSk1P7iMs1wrES?= =?us-ascii?Q?+rG2y7d6YZHk5x6452GS//QFgCXMGjrgpwmkq7LW2DrAcFRjGXTkd7cz/oRt?= =?us-ascii?Q?AvGjj/zUD4nLPbrGUYcNIbQ4wEztfq0B6L5qVk7V8G0t7hhJSn3y+Wh+CjZg?= =?us-ascii?Q?06lJY5ejfd/GUEEZVfXpFFodjDtYdgGrvAwwAcWMKSd0AQ201RHZuksOtP33?= =?us-ascii?Q?6efwN/rjMc2xMnJn0Cs/1QLEFS2yogbk1hBnueC9Z5Mwkp8jT9M3aEkOl/TD?= =?us-ascii?Q?c9JO3tW4+7FDs8LpmWfaB3GBLXMfpz5pZlWYwPHAUgQmn4j8hUWtyYsPozfy?= =?us-ascii?Q?2ZpqsIKq4fx8Mb0c9G39onF+W9XaVbHKaQsUPKUwjehNWgXWrsi061wFzHSu?= =?us-ascii?Q?kCzQMhBU6UWdKA3Eoz7icNUihlKlTc+9NgDkwhMN+mCcqo1MHo9SgQBgd4ou?= =?us-ascii?Q?MFzrI0+aEDnwb3ibtjGMezgkuhHA1nZdycouecSNn9CCAjY2a+fzRQhTYcjy?= =?us-ascii?Q?5scfkSgKVpe/D8+PJF9TCEc8tgGaSKZcObCAWkyHWNg2vVBiqHFv8UMUumYJ?= =?us-ascii?Q?fC3XHZxmJSJ+T7HzqKOAIhLF5gff7e2e2Y/bvM1rmj/PeoR4joEiRBKP5TMp?= =?us-ascii?Q?NARAz8Co6KsiqzOSpgGYrVigeM0SMwE0Oq8CIPIs57utVczOFdph9nTEIyaE?= =?us-ascii?Q?K8ybrwQ51/QWNKZj8bV9ft9wCX0/rm2SH4bBBdNgpdaznWvvGmuj56BmI2Fk?= =?us-ascii?Q?co6T9U7bFA2SH2xYCt+yQcbs/R4llQviit8xQi8qdgepEmFz5mi0VLMUyQoG?= =?us-ascii?Q?wFRhlHKfqQwmelEJRxUeUd5lHWw7fcwG46fD4xf58XZwqRk/FLUEMVsBrQeH?= =?us-ascii?Q?Gen9ZFc7lNi8IDsPWPFr/fjQkCzzQY3C0SXCCPqxp/HbbZdP6D23lG9pMOKL?= =?us-ascii?Q?IpW8WDC2wwA3QGt17NpeDs6jRGr/4vjvyFtd+9dVisVTJxj3EloU5V5K3V3E?= =?us-ascii?Q?Orx0Tn0MkQ+20VnbAuZqaW2dZbeN1sZXDVbLfMTSOrCd8ggyckVOVbQtmy1y?= =?us-ascii?Q?dXE170nSc1s9zkYArc8u58sdUpSVQQasmUC0YKUWl1dtfPSi5/EI0yzK433C?= =?us-ascii?Q?HzZH2jcN6anA40BUrsrNUjyHynenTbmGxzU5OkkBl192W85yL5/Zb4h6iMK4?= =?us-ascii?Q?1bgBEr52NmWDEK2XzHvYILXWYr/R8zZgadk/nWKV35FykWjR17GWr8tY1bix?= =?us-ascii?Q?A2RoLg=3D=3D?= X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: d068cabc-fe29-45c5-d02c-08ddc061880a X-MS-Exchange-CrossTenant-AuthSource: PH0PR02MB7159.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jul 2025 09:58:48.5226 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: rfGf5feDEifsrgN9cwOnduA7azrH/MTfmi5c6+NrjjW9i00l6yLopHf7q3k8fwkN7Y7d4Q719BT0eSrC4yqA2WyvB5KEGS1ZoBQGJzX3guA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH4PR02MB10681 X-Authority-Analysis: v=2.4 cv=U9SSDfru c=1 sm=1 tr=0 ts=6870e05a cx=c_pps a=h/zdu8LGojurgwVeJVxNZw==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=xqWC_Br6kY4A:10 a=Wb1JkmetP80A:10 a=0kUYKlekyDsA:10 a=64Cc0HZtAAAA:8 a=puX-rZ3iWx3qy-NnaecA:9 X-Proofpoint-ORIG-GUID: nLm1mFOz5xNA07hMD9rSmDz_G73segRo X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNzExMDA3MCBTYWx0ZWRfX5fwQm0jfwOmb 0c/+bhXUbOm1KrwpfFsnEBB7drwT3nUyslDxci7v/tUelXFgSafIwlYJARr3Knp36McP2prkMP9 qiu6qYLG1g3w8L+6YjFRJbJ0MJZBsxNPko6K6YHYer2GNSh/0S3Nav36xrszkBXT0KaaI6v1dB6 jNTivWxZkvVBvmEeiiVHY8al3mju2dcyKz4wpUEYvm1SMgqk00suNNsLQ0EXdEbhrAT7Fj6etKx si7XlGrGkBeLmyJELswMxR2F7QYK8gW3ODKaH5uCcoD5SH6ZNmSK02psPrRPBHTv7vZ1dTDu0NK pwbdgBNlKYlT93uzwKqeDED4+ZjMWA7qBU9dx5cXcVEpfik1JpbTr+xoCMeSd4EmFisqtt9v2kt a4vFMX2BmVVXsthc6azwaFCqf3ysHYuU4nlOWgNo/bOY/CS5qbSdc2f7p83c+qodRB1cQ3na X-Proofpoint-GUID: nLm1mFOz5xNA07hMD9rSmDz_G73segRo X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.7,FMLib:17.12.80.40 definitions=2025-07-11_03,2025-07-09_01,2025-03-28_01 X-Proofpoint-Spam-Reason: safe Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=148.163.155.12; envelope-from=mark.caveayland@nutanix.com; helo=mx0b-002c1b01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @nutanix.com) X-ZM-MESSAGEID: 1752228038066116600 Content-Type: text/plain; charset="utf-8" All isapc machines must have 32-bit CPUs and so the RAM split logic can be = hardcoded accordingly. Signed-off-by: Mark Cave-Ayland --- hw/i386/pc_piix.c | 58 ++++------------------------------------------- 1 file changed, 4 insertions(+), 54 deletions(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index 78f50a7893..fbd9500061 100644 --- a/hw/i386/pc_piix.c +++ b/hw/i386/pc_piix.c @@ -426,69 +426,19 @@ static void pc_init_isa(MachineState *machine) GSIState *gsi_state; MemoryRegion *ram_memory; MemoryRegion *rom_memory =3D system_memory; - ram_addr_t lowmem; uint64_t hole64_size =3D 0; =20 /* - * Calculate ram split, for memory below and above 4G. It's a bit - * complicated for backward compatibility reasons ... - * - * - Traditional split is 3.5G (lowmem =3D 0xe0000000). This is the - * default value for max_ram_below_4g now. - * - * - Then, to gigabyte align the memory, we move the split to 3G - * (lowmem =3D 0xc0000000). But only in case we have to split in - * the first place, i.e. ram_size is larger than (traditional) - * lowmem. And for new machine types (gigabyte_align =3D true) - * only, for live migration compatibility reasons. - * - * - Next the max-ram-below-4g option was added, which allowed to - * reduce lowmem to a smaller value, to allow a larger PCI I/O - * window below 4G. qemu doesn't enforce gigabyte alignment here, - * but prints a warning. - * - * - Finally max-ram-below-4g got updated to also allow raising lowme= m, - * so legacy non-PAE guests can get as much memory as possible in - * the 32bit address space below 4G. - * - * - Note that Xen has its own ram setup code in xen_ram_init(), - * called via xen_hvm_init_pc(). - * - * Examples: - * qemu -M pc-1.7 -m 4G (old default) -> 3584M low, 512M high - * qemu -M pc -m 4G (new default) -> 3072M low, 1024M high - * qemu -M pc,max-ram-below-4g=3D2G -m 4G -> 2048M low, 2048M h= igh - * qemu -M pc,max-ram-below-4g=3D4G -m 3968M -> 3968M low (=3D4G-1= 28M) + * There is no RAM split for the isapc machine */ if (xen_enabled()) { xen_hvm_init_pc(pcms, &ram_memory); } else { ram_memory =3D machine->ram; - if (!pcms->max_ram_below_4g) { - pcms->max_ram_below_4g =3D 0xe0000000; /* default: 3.5G */ - } - lowmem =3D pcms->max_ram_below_4g; - if (machine->ram_size >=3D pcms->max_ram_below_4g) { - if (pcmc->gigabyte_align) { - if (lowmem > 0xc0000000) { - lowmem =3D 0xc0000000; - } - if (lowmem & (1 * GiB - 1)) { - warn_report("Large machine and max_ram_below_4g " - "(%" PRIu64 ") not a multiple of 1G; " - "possible bad performance.", - pcms->max_ram_below_4g); - } - } - } =20 - if (machine->ram_size >=3D lowmem) { - x86ms->above_4g_mem_size =3D machine->ram_size - lowmem; - x86ms->below_4g_mem_size =3D lowmem; - } else { - x86ms->above_4g_mem_size =3D 0; - x86ms->below_4g_mem_size =3D machine->ram_size; - } + pcms->max_ram_below_4g =3D 0xe0000000; /* default: 3.5G */ + x86ms->above_4g_mem_size =3D 0; + x86ms->below_4g_mem_size =3D machine->ram_size; } =20 /* --=20 2.43.0 From nobody Tue Dec 16 21:11:18 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass(p=none dis=none) header.from=nutanix.com ARC-Seal: i=2; a=rsa-sha256; t=1752228009; cv=pass; d=zohomail.com; s=zohoarc; b=J+behkLUhHl/TyRFqGwUHGb1Mbk2N4MwZriiPhDRzwxeS862Qu9SCTEsNZwI9YaFsnfxgRDL8jCyembXwvCdo35AJ+a3dLKo3zO2mCFt3l1usNk7e9faEW9jWiNeqA7xcKxL2qu/ig/MkmA/ANSrY2p87weurJHz4NIJ9ELyxI8= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1752228009; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=wXiY4HEGd2b4u+bVNb3QbdJVU9t/2vJpec61JjaFbDs=; b=U5tFS5pnWKYnesHbU/MBiRj2zzLrXjP+61fLj2vTT7wZb4PLegeFXgGuXCBRipjAE22tbgznPdTXLKwBrWW14zzhVZP4a57bq+K5WqviaGSZBXcpai2spL7n+aoY7f4dWYPqvMXJ2Xm0qIWv0ngJv6im1Z3KnMPeN7eewk/Q4+4= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1752228009549724.7487868620606; Fri, 11 Jul 2025 03:00:09 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uaAX0-0006FV-FB; Fri, 11 Jul 2025 05:59:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uaAWx-0006CH-7d for qemu-devel@nongnu.org; Fri, 11 Jul 2025 05:58:59 -0400 Received: from mx0b-002c1b01.pphosted.com ([148.163.155.12]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uaAWu-0004rQ-TO for qemu-devel@nongnu.org; Fri, 11 Jul 2025 05:58:58 -0400 Received: from pps.filterd (m0127844.ppops.net [127.0.0.1]) by mx0b-002c1b01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 56B88p8k000310; Fri, 11 Jul 2025 02:58:55 -0700 Received: from nam04-mw2-obe.outbound.protection.outlook.com (mail-mw2nam04on2106.outbound.protection.outlook.com [40.107.101.106]) by mx0b-002c1b01.pphosted.com (PPS) with ESMTPS id 47q3k38m32-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 11 Jul 2025 02:58:55 -0700 (PDT) Received: from PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) by BN0PR02MB7918.namprd02.prod.outlook.com (2603:10b6:408:161::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8922.25; Fri, 11 Jul 2025 09:58:52 +0000 Received: from PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88]) by PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88%5]) with mapi id 15.20.8901.028; Fri, 11 Jul 2025 09:58:52 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint20171006; bh=wXiY4HEGd2b4u+bVNb3QbdJVU9t/2vJpec61JjaFb Ds=; b=24KikO1ENc5Ch64fQjQSs4+n4/oOgSq+0GAkhNmKohCICbceea4t0y8tj BsbHTtLFFVWzO/ATAmCMC1lPtMwoIw5WRPezmVmeB3NWHHAbu9M8CAWAITedyy80 Y1ZQymWIXmn58QXFV8+Z3y+X4I6N1bh6zzzWUuiIOOM7GKrBfPORJ0HwdIGeBcWA /sVcX5GCiKEhDJDx221I9HOeDuDjpwAZ8pWVMNNb8MHw3B815iGf2xzH2JwPv2en CWbIfaYkkavK/sNSPRCR6dtrSrsQWV8nLI6z8wX6RFSHvFFpaxb+7ekPpJdqNAT6 cMXHMIY9Y2SaE/3wIqZfjrIv95ipQ== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=npluoK/Jffxq5V72UHGEpmzIAJT4N74H1GgeJVFk/ACYKZTMiqT8uyLOu+WPbJXDQtkVGJRSxfJ3ZDARla3RZXdKq33k/khaPwSdu35OEkPwpak+lXvMcVfLCiwmMbm9ubEqrgUdD7hJGfR98lir425WXhk94vSxyw3LDn6Vf8UWB1VZMrrVzeAuj5pnKe7avlPOEncHJFhzYl+FrP6YdFY4Z8Y/fISb72UOtDJObqiSipTlJZ65ZLj6Yr+dQInjv+ZuzeVKli7hfhA6OYVZszlaT5lTcsEgFS6+lHTT443Q2rL+MZDdBh9fmDYYEvMK5WibBcd0N8dZgdTsmlbdaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wXiY4HEGd2b4u+bVNb3QbdJVU9t/2vJpec61JjaFbDs=; b=b3Qk9HUpunvyz8XEUDsY5DTsZJ5eHzKfD6y64A2mUmHJWh0oGMyXOls1uNZFUKBN0vA4FvyoJ3ROK4XfpCZIuF0BHFaZsCrXqrSZpDj+5w8IjCWl6K3CrHCcTkOqB8hL9GI0FpUoz86d8ky3SkS/SQSOaIOLCEqdY8ujtafv/TFh2DCcJd6bRgK1vkf6ya4Gv9YbMl2P7sN1m66L6YvvXQWq0tGAIpowp37MvsRnv6RHGgWy8rdv/6YxnzO5ZetY/r9pMdlshUa9VeF/pgk9fvSqKjtyMx96D3Ax6xsHua1IFGN6pWW8vBXWixDTRXvZjOGzTAV05S5v23CWU33ECg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wXiY4HEGd2b4u+bVNb3QbdJVU9t/2vJpec61JjaFbDs=; b=WftRVFCqQzkt1omKyDSjaohsnWteF8t5A7XTM3DwZJMHnACzaSvGu5NTUocTTUpFfI648upALWRtJ75ZX66lzjkI8+ZKoXW5Q/FX4sjyii0bOknXQPihW5XyKYYcEH+j/bSaTpwjnc09UgOWHRkkfedvRLXw8j25pGDwB8TVK2WdqPANGgOwBlWHzZ3YsJrAjoovXFAYA1/qI8MhNIFEXUtP32yALpsdiqpsw5yPa+dWbNjKozVvgamUAfIpKaT5bOkVgbc5YqyC+R3QC64LEXnTpZjNhG3GOHq5fR8iQeS/0TURLFawIR/ca9T58fd79KpH9mPyzF+8q/ex7O7Tqg== From: Mark Cave-Ayland To: pbonzini@redhat.com, mst@redhat.com, marcel.apfelbaum@gmail.com, eduardo@habkost.net, imammedo@redhat.com, qemu-devel@nongnu.org Subject: [PATCH v5 10/19] hw/i386/pc_piix.c: hardcode hole64_size to 0 in pc_init_isa() Date: Fri, 11 Jul 2025 10:57:12 +0100 Message-ID: <20250711095812.543857-11-mark.caveayland@nutanix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250711095812.543857-1-mark.caveayland@nutanix.com> References: <20250711095812.543857-1-mark.caveayland@nutanix.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: LO4P123CA0265.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:194::18) To PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR02MB7159:EE_|BN0PR02MB7918:EE_ X-MS-Office365-Filtering-Correlation-Id: 730288af-acc8-4607-9b40-08ddc0618a30 x-proofpoint-crosstenant: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|376014|1800799024|366016|10070799003; X-Microsoft-Antispam-Message-Info: =?utf-8?B?b1ByQWNtckdFS2lPMXplZHB4NnR3L2ExQjJ4b0hvb1ZsWVQxekI3MjZ0My9J?= =?utf-8?B?Ylg3UzVMUnozTW5SbUp6TzEzMFdNWVdoOWpReks0VEtXb1RzS1hxYnVvNkkr?= =?utf-8?B?SHF4dE9XejNYUXo1OTcxMDVmRk16ZVlBUDJWNjBreXVNaGdaR1BJWlZPaStR?= =?utf-8?B?S2t5dmFSSElmY3pxUmZ0QnpybWY3azd1ckI0ZkxaQ3RRUVlqbWxLdnF3MXVV?= =?utf-8?B?NnE2cTl1SldCZlZvWFMxelV5N0lpaVVyNkk0c1kxK0pPN1Jmdm43QUJyMnNZ?= =?utf-8?B?ZnFYYVBxbVRnNm9IZHN4RitXRGcrdXI2b2JvWElKV2cwTUpzOTRiYkszbGVj?= =?utf-8?B?a2RYbHI4by91SjJvUUZFcHNXdzUrVjc5NU5rU1p0c1Brd0lQc1ZJSTcrVHdJ?= =?utf-8?B?UXNlRzJXYVlGeXJqclc0cmd5bSs3d09mSDM5SDZtTjlhUzkrd0RKc242RTUr?= =?utf-8?B?TUQyWkV4TWUxRGszQVcrcXh6TnJ1NHlOYlRCcE15MUpGMi9OOEZDbTcwZmgz?= =?utf-8?B?WnJaS0h5RkxVU3V5U09xMlZsa0xucm53V1JpdXdWZjkzaU5ncEdtWjJHVmZ1?= =?utf-8?B?Y2xXRHlXRlNhdHFOYVhvRmQyUDdhTGpTa2tXTUc4bDZHTTZPUEI4aWxjYTNZ?= =?utf-8?B?TnZVSVFqUDBSUGJvUEZqUVlQYzMvcHpObUpOeUxqbHBmcy9ucUJlVExWL1VO?= =?utf-8?B?STZPNXhQVVEzdHI5K0wwMWkxcFJ4b1p5Q2YwMFMrVU5md1BVaGU2YUxoZFVH?= =?utf-8?B?UktvbXkybFdWb3ZVY1lqZHJyWjhsaFZucGx1K1pKbjBVQnZoVGRJcXVyRHY4?= =?utf-8?B?Rzl4WlcvZityZ1lHQTd2Vzc2dm1BZ0JvSWFFVzkvQ0NmcDVmL0FGczQ4bDEv?= =?utf-8?B?Unl6UnBQbVQvT3hjdGxOOXFEOVYrTUtDY2E3VjUvTFJmRWloYjRNaHhITHBE?= =?utf-8?B?cWR6OWs1NkpJRGZodCtZWk9EMXg3a0s2eXllSDFnc24wNVh2c0dWWGRjOXFh?= =?utf-8?B?REZzOHR2cnRXSHJjQkhxendkVkVHZzN1ZkRDVnU1andYRnExeW1ib0VQZUNW?= =?utf-8?B?a2hKRy92V2RMZXFCTmluMXBwYjNEejZEQVVTOE95RmRHRm14TFJjbndocmt0?= =?utf-8?B?RFNDcm9KbEV3YjdqVEFHcWlNUjdsaEpoQjNiQi9KNzdCNytZRHNBK1VjcTlu?= =?utf-8?B?dGg1YVpzNHhUR1JiVWdaMjgyTEljRSt2WkdsNjJNeWFoNjhRam8xME91eUZi?= =?utf-8?B?dU1IeitDbWF3RURpS0g0WWhvUzlFNFpub01RdEZCT3c1TDhFUUpGZW9SWnNE?= =?utf-8?B?ZTE0SVJQU1lGN2FERkt2djZhWFNEdUhFYWtIY0hpUm10cHBRYldvSWlzVk5q?= =?utf-8?B?VC94aC9YY01OZzBEWXNIZ1owS2xWTHZhRC9ObTluYkYvSGpOK3lIbjAyVTJE?= =?utf-8?B?dnh0QW9obHJSQVB5cndCVEMxeHh6blFzOVRmUEpjbGhtTjdKbWdFckpBdXBv?= =?utf-8?B?ODZOQk5nRnhmczJKY0owY2ZiU05VekN6aVlPN1NvNHNvOTl5ZkdzMmFHV29C?= =?utf-8?B?V3FtYXZUTDhNVk5sbG1USlZPbytYQmVHT3FsT2dvN2FTajBVclk4bm1Qa29B?= =?utf-8?B?YWtGMzFrd1pad2wwS21Jcmw0YmNILy9NdFV0MEFXNFVVVFd3bUdnUHR5M1NW?= =?utf-8?B?Y041cXNxWVBKU2JjT24rcHpxRG5nSjEyam93M0duTTdMbGs5NUlBL3g0aU1z?= =?utf-8?B?aFlUU0k0NFhMS2szbzlNNW9PL3BiMXAyd3YvVlFVVTVzZy9wT0ExL2JRZXVO?= =?utf-8?B?T1lJMThiaGlGbUNIaUphVTh2ZG9GV0hibWRuMVVtSkhtZ3pmZWNVTFZIbXhM?= =?utf-8?B?b0ZrOTIybHg0V1hJcUFaNTlhWGZDRTRuWWhCZEpPTzNBTW5hREVBWE1jZ0Ux?= =?utf-8?Q?RJOcXZy/YiM=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR02MB7159.namprd02.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(1800799024)(366016)(10070799003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RU1LTkJrWWN6Tm5wZHhIMURpeDY3S0gwZnFoTzY0Yzk3a0xaLzlLcVFRcWU5?= =?utf-8?B?ek9nSWt0b1RPdXVvZU10MXVFYUxNcmk2OThZeW5uMHp1WnlPSjZ2VFNuU1pp?= =?utf-8?B?WTVFS2pKTU9KNi9odmFYVTl5QzZaVTNHOTk4YUdYMDF2Z3g4ZjhGdUliZ0xU?= =?utf-8?B?OGJIMHlya3JzbnpaZ0dvOFh4ZkduYUxSdjBQZitjMjVsNnlSWEVGNDJpbDlt?= =?utf-8?B?ajFrR2EwUFZlVzUxRlNzbndWdllIcm1IbDdGM0dHaGsyQzYzcXR4ZzBMWE8x?= =?utf-8?B?TU95UXZySW9SRFl0elBPUGNmb2dHSEtTY0lnc3Izek80WGVpb0ovWEJpMDFi?= =?utf-8?B?emZyWHMyTHNNZ25CckRVU1ZRbFg2ZUFNQzFWakxtN3FDRFUvejNOTzllVWJD?= =?utf-8?B?Z25TL2MwVGNJaW9IRkJ0MW9RSXk4SCtzTWtlSkYrTzRHVUxmcmlTQ0JhU21X?= =?utf-8?B?SENxZ1M0Ti9vdlB3QkZ4SWpaUFJnYmZ2THd3ZmN6UDI1dlpRcHdnSEIyV3oz?= =?utf-8?B?TWE3RmUwbFN5T05KbnNnclRLRWtnR00zRFdZUXJ1SmFYOXRsVVU2SzQ3bkE3?= =?utf-8?B?ZUlQQVJDZjF2VXVGbVBzMVZsTW9TRHBWa3c0WjhCcEhSdkFVNVVISVFEUEpl?= =?utf-8?B?d2R3UVYxaGRuZkNob2dLNU9RZWkyK2xIN2tUczY1bmsrOXc4d1YyTWFoay9T?= =?utf-8?B?aGIvV2FHdlJxTjhJN1prejN2RzRZNHZNVkNHeXdGUVowRXM4TlJ1VEdrdXgr?= =?utf-8?B?cXc1OThSVEo1SUJTT3k5OUZXRFM1OFI5Rk51Y1B3NUI2NDRUTkRrYjFNMW56?= =?utf-8?B?UElOVmI5MUZ1Y3VWN3Bqd0I0Q2VmZW1OVExQTHBLUUxjNDZSdTZOdEhGWGxj?= =?utf-8?B?YjRUR0I5L2lUZHBPMVliNlpTamZhdDlrMlpENUw2ZWo5RFZNdFo5TEgzWC90?= =?utf-8?B?cElGL1VvUjFpMVBCUnlpcURPK3A1WXhpWHpsSHN0QWhqQ0hJc3NwZm1uY2cz?= =?utf-8?B?Vy9DZ1I2WlFtZXV4SmVqVHF5TTFMRGw0NnJ3b2gzOC9oZDJuWXo5bVhzSFlG?= =?utf-8?B?NEJmU2RIeExYQ0lvelh0S0lqakpjVDBDT3JKby9QaGI1L2JuaFA0dU94L0M1?= =?utf-8?B?YlNMUkpjMXN2Q3ZLZlMyVzdXd1V3QlIva0F3bXNlaHp0M2JPeVlkN3dLSERr?= =?utf-8?B?QzZRWGR0NzZ3QVJkYUpzZFMrbUlmbEkzanBXVHVYMkpUS1JmdVlDeGtiek9i?= =?utf-8?B?R0lwa0RtdktoSnVaYkNiNVdnbVRENUpFWlM4ZUt6RzJjTmo4dWMreXkySXla?= =?utf-8?B?dldNREZtT0JWNmYvU200UDFEaEMwSFhOdENDT1FEei8zTGdzVXJNYWl0b3JP?= =?utf-8?B?MVN4MVRTdVRnazNsc2oyUXUybzFURFVJUnNZT05Kc1o3VDdXcUlWdjdSY0l5?= =?utf-8?B?bzlFMDJGUFMxYXgxa0Z1OWpUSUs2NGc3SEoxeEhsVDQ4NFdSWXJQY2Zvdjgw?= =?utf-8?B?WmdHSFc1OEVXdDhpNE4rb1lpVlBVYmg3cFprTktBT2lmK1FEOXl3N004Q1Vq?= =?utf-8?B?OEc1b0NDV2UvTmhyc0RHZXR5bFJzd2Q4eGNpS09nWFFhTUkvTng1ZVJRZ2Fr?= =?utf-8?B?NVZwZnloNDlhbklMaTMxMWFkR3hZOEMvOWZERlZBUi9XT3UrdHowcU91dmZZ?= =?utf-8?B?RDJmdUtKS1NDUDN0ZXlVdUdTN01MNnZ4eHBxaThJcjI5OUcwVmpJUTZ5eEtT?= =?utf-8?B?UFQxaEJLVjh6dlRnN1JiU2hmeElOTkU3TmkrQW1PamZtbHovdlVsUHY4eThU?= =?utf-8?B?ckRGbmNsU1B3VFk0aVljNXFzTmRPN3hGcTZ4WXNRdkp3UGI4U01xNGowQWQv?= =?utf-8?B?bjhnTitXOWNMbnRJTkNUQVNicUFrZ3piWDJ1dFVJeFV5UG0wZHhvV0s2U3lv?= =?utf-8?B?UXlVTkl1RjBSNnlCYit1dy8zaVhKSEduYzVFT2dpVFRScVJZS042NnY2Mnhz?= =?utf-8?B?ZktCTWs3bXRhMVlId3llTWUrZHQ3bmJLVDZpNUdOUFVNdXhaNUIvUktrS1NJ?= =?utf-8?B?c0UwRHovRlJKMTVveUQydS9lUlpwWnFJVDJWNTJDTHVtdkdMSkEyYkh2VW03?= =?utf-8?B?ZGRqeTRuYmFUWnpDclEvUnJWd3Y0eHFRVG1HSnJJTzZPcjFkZTlPak9aSHMz?= =?utf-8?B?MEdUNnFHd3NhekFUUVBhdmVTVHdCWXZpaEFCNXhHTlFORjJqYlJnNTUwalV2?= =?utf-8?B?QnI4Ujlidm1VYXlTSGFCRDhZQ1V3PT0=?= X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 730288af-acc8-4607-9b40-08ddc0618a30 X-MS-Exchange-CrossTenant-AuthSource: PH0PR02MB7159.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jul 2025 09:58:52.0063 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ku5nKWf4DHrAVUe0JVnYODHFmO6qpy9QTt6V6YiOVLlr52eb++tUQH9ImQxMC4TKmTkGICzlo7/mRMsmufLKR6Bfb4qhukyjOwTCG0Imy3o= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR02MB7918 X-Authority-Analysis: v=2.4 cv=UNDdHDfy c=1 sm=1 tr=0 ts=6870e05f cx=c_pps a=zW83crQ9oS5yqOJib3wKzA==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Wb1JkmetP80A:10 a=0kUYKlekyDsA:10 a=64Cc0HZtAAAA:8 a=KKAkSRfTAAAA:8 a=aqeCdxMHYQgX1PSeTiMA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-ORIG-GUID: 1bUVydqslX1T-DP_pus0h6bQ-sVNyXFd X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNzExMDA3MCBTYWx0ZWRfXwPMHoNaBQlGx Z9J0JNYPfBmy+UcYAVWD14bCV1dYGhMubdFRX74Yd8tuDHJVaFs9QbrWf411S0NfIN/vHJat+V3 UcePPKV/u4iodTSSOa/Dllfo+KNSJaie55FFv8D/z4pidC4lnrHFbvpQdsPnzwwMrj8T7LoMn/p sAY0rsKJQ32vwzi2i5vLi7oj0GuptdNKsYX2Xw4WKih02KUtRPIaFD9GLHMGQ/3LE3uqoMKzyiG YTHHXaRjrysxo1huFd+rMdDVwLyzoSJ0yjT55H+TwWxJbO0/KLab7lfSioh9mzQ3fdWeWllsx9H WxAtrbb/3SnW7NwgxFk/8KA+1r/8P0Sd4VealvSTFg1g6LDa/77l2F9vUJ/rA1Yvfd/MAwbHcOu bzKbzWyt9+RlzRH7PlKE2kgbmoLC6AyoRgXOMZBNxXYiQNbnU9Js1GZRkBwj6vQdb/L7TJ11 X-Proofpoint-GUID: 1bUVydqslX1T-DP_pus0h6bQ-sVNyXFd X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.7,FMLib:17.12.80.40 definitions=2025-07-11_03,2025-07-09_01,2025-03-28_01 X-Proofpoint-Spam-Reason: safe Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=148.163.155.12; envelope-from=mark.caveayland@nutanix.com; helo=mx0b-002c1b01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @nutanix.com) X-ZM-MESSAGEID: 1752228011412116600 All isapc machines must have 32-bit CPUs and have no PCI 64-bit hole so it = can be hardcoded to 0. Signed-off-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- hw/i386/pc_piix.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index fbd9500061..f64588f01c 100644 --- a/hw/i386/pc_piix.c +++ b/hw/i386/pc_piix.c @@ -426,7 +426,6 @@ static void pc_init_isa(MachineState *machine) GSIState *gsi_state; MemoryRegion *ram_memory; MemoryRegion *rom_memory =3D system_memory; - uint64_t hole64_size =3D 0; =20 /* * There is no RAM split for the isapc machine @@ -462,7 +461,7 @@ static void pc_init_isa(MachineState *machine) =20 /* allocate ram and load rom/bios */ if (!xen_enabled()) { - pc_memory_init(pcms, system_memory, rom_memory, hole64_size); + pc_memory_init(pcms, system_memory, rom_memory, 0); } else { assert(machine->ram_size =3D=3D x86ms->below_4g_mem_size + x86ms->above_4g_mem_size); --=20 2.43.0 From nobody Tue Dec 16 21:11:18 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass(p=none dis=none) header.from=nutanix.com ARC-Seal: i=2; a=rsa-sha256; t=1752228187; cv=pass; d=zohomail.com; s=zohoarc; b=PmMDj34Y6yAC1/pVa10LlQI6OdFnp4tUCwCN85Qki5d4XHFEarM38lBtpAWmhldH2sDRRtdD7mkJ4/YZMplpPHV64ynPu2v16o/spizy13LX7evzy+7k/mCiU18/XnY8jLh1d1ErfUOF2Wayw8MrSiFNnjyHHtOFzj9pPjsgufg= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1752228187; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=rALzJfhuFuyIke5siyIOHEim4J/yO7Z/nRt5alFVgkc=; b=GhgtZBbiH4iPXFVQrLQx+IlvXiqUeWn2eRH6tb0E3sf64OuJ/MZJSCv/op3dU9UKEfwm5Dq38ZrTgnDOIAL78w3+ApBLzfD49ry7sCRvJ5J8jB90JKgk20juLG/9nyZz3n0Tq8g9b62Veh1pkktK3IPc67nMp5iUq6zUrCS3Zhk= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1752228187085199.45791892851332; Fri, 11 Jul 2025 03:03:07 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uaAX8-0006KM-IB; Fri, 11 Jul 2025 05:59:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uaAWz-0006Ez-6M for qemu-devel@nongnu.org; Fri, 11 Jul 2025 05:59:01 -0400 Received: from mx0b-002c1b01.pphosted.com ([148.163.155.12]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uaAWx-0004rv-Cw for qemu-devel@nongnu.org; Fri, 11 Jul 2025 05:59:00 -0400 Received: from pps.filterd (m0127843.ppops.net [127.0.0.1]) by mx0b-002c1b01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 56B8McKm016805; Fri, 11 Jul 2025 02:58:57 -0700 Received: from nam04-mw2-obe.outbound.protection.outlook.com (mail-mw2nam04on2118.outbound.protection.outlook.com [40.107.101.118]) by mx0b-002c1b01.pphosted.com (PPS) with ESMTPS id 47ta49k6dp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 11 Jul 2025 02:58:56 -0700 (PDT) Received: from PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) by BN0PR02MB7918.namprd02.prod.outlook.com (2603:10b6:408:161::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8922.25; Fri, 11 Jul 2025 09:58:55 +0000 Received: from PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88]) by PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88%5]) with mapi id 15.20.8901.028; Fri, 11 Jul 2025 09:58:55 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint20171006; bh=rALzJfhuFuyIke5siyIOHEim4J/yO7Z/nRt5alFVg kc=; b=fgzkpZB/uN26CSfu/u58NhOQwlHiJL7nXBAOaET4H18wZX8cVVbCMpjkt 8CLHkXLzjhIUxVRC6MPXQM/qqFYENPk62kB57uejlfdiMWXyuYBdncF2n2o9k8Gs gEpsH01q97yc7ueVYSIANUyV6yChgJnnQjMCj1URE2e994urv5XhXvbrWhdk946w QCPbzzNmDZQKehpUv927SsW6BqdBmgkQGgJgeCv8WPOICLd2pB2/zdhHF+Nae+ka ngTiXow9olbKZjKnU0qTSGOK2OHssd+imgF3a3rEBVWS/2Cwact5AvqCODVWczMk TwuMxfBv75pN77wetiwRM2um5cG7Q== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=k4XGUxnk6b9jRTF0qsmtAdsiEFQUCTzecN7clcNdT2AJPJhjbXBQYQo8knl6Kyef60t8fS1hY3oUfMMocbKVOBL1D1yDPZLePrOWO943TmqvXHknUHUPytGAJeKnVibHz2wUMFRw4OxgLFeH2O15i/Y7u3kqsXmT54vAm+CiPQf0V6RDu9iecUK4cYRBGizut2NzB1hKfecxepsnvHcWUapkbSyiwWb1BZ+z/4/GDjjqQ6ri/OnL9GIsCSkkgg/KNfRK016bFCIV7kaC5O3hMrOLbntfUp8kXpr2B5emfFrdi5smN1+20YTKZCumy7CJUOWfwLSuw7k1NWmLZfZqcg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rALzJfhuFuyIke5siyIOHEim4J/yO7Z/nRt5alFVgkc=; b=c+Z1qMSzOEECOVdvygEeG0RcucANTMJj8C6cXm4PxCRaHucQzrwBwnStH2UOoD4EUCd52gLf+QE8C7UZ1pNaVmUGjevPtR52JSJYIDNrl7SGMvgRIijNtmsqzqsgzmR371KP9AdKebTvZ35/HgZ4ISHlNUKSeewDPC6+hoi8yqoCHDN4uc3RXaRqX4N0NQgEAs1ktm+joC2LkRad3mq72c0qV3ahZ/KxJuGjcklEL+LGsPkr5DEFjrWyCJiIT/Xl6U1aswydKw/z6zL2pup0UQoZHLVnQlsvSGSw8jcWrSdifQZ6x/hw0YpCcJ5TS9z8E4p0u+ocq3izA9yL0UTIzg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rALzJfhuFuyIke5siyIOHEim4J/yO7Z/nRt5alFVgkc=; b=GoKvB2HUZQuUatqRkf31qNDfzdLEeQooU1xYCsKcCncPqK7exNns6fgwINB48R5yEvriknVzewIJGWAasc6x3Vl5XBQ/4WYcOFFyczL+CLxIq/p3x9FDpc9W8vovj/Yx5HdeKOf1F41ByKCVAno93eZWQnVaPL2OrQSggFihFs95QR3rsm5di2hpRZJtg4tIlt2iSuUUnEzMTT45/QFJyzFP/JV9OTVvvIYcvtRUPIA43mR8Po/jheP7fW3q12kTRJ1Rv5vcVCpagLVUdn/VV6WftgwBQkVDPFoX045GVVUNeUqkZVZvjB69qFJrYeg0jXZbkt8aZsgU3KnsSVF6+Q== From: Mark Cave-Ayland To: pbonzini@redhat.com, mst@redhat.com, marcel.apfelbaum@gmail.com, eduardo@habkost.net, imammedo@redhat.com, qemu-devel@nongnu.org Subject: [PATCH v5 11/19] hw/i386/pc_piix.c: remove pc_system_flash_cleanup_unused() from pc_init_isa() Date: Fri, 11 Jul 2025 10:57:13 +0100 Message-ID: <20250711095812.543857-12-mark.caveayland@nutanix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250711095812.543857-1-mark.caveayland@nutanix.com> References: <20250711095812.543857-1-mark.caveayland@nutanix.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: LO4P265CA0249.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:350::14) To PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR02MB7159:EE_|BN0PR02MB7918:EE_ X-MS-Office365-Filtering-Correlation-Id: ad9e5cad-2fe2-4d78-fdce-08ddc0618bf8 x-proofpoint-crosstenant: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|376014|1800799024|366016|10070799003; X-Microsoft-Antispam-Message-Info: =?utf-8?B?cGZEVHFtNmNiUjRKcFN1K2RBeG55K295cHZTaG10ckwyaGcrZXcrMnUrbXFI?= =?utf-8?B?RVJqRHVLcDAxd1piVXhhS1NEYVo5OXpXclc5K042SUZRVUJzMFcxdWV0Y05F?= =?utf-8?B?bDQrRkxwTzZlZHpzMERMdDc1SzdzREVIdHAyVXMvSmFvb1lTSXUrUk9UYXNB?= =?utf-8?B?VjB6cEdNTFV2MU1HMU13ZktQMFBJdXR1YUovU3RLcjAzL2FOL0J3aXFXMzR6?= =?utf-8?B?dk0wRE5tNDh0K1ZRUml1RTdIL3ZjN001UFF2TDhDV0wyWmN1OUZzRThla3J3?= =?utf-8?B?aHZReW5nWUdCbmh0bWhodVlVdFI0Tzh1bzhWZWs5VlFLeDFRNjFPbzlheC91?= =?utf-8?B?UWhtVEFIQnNjdmFiaW5SQmxhZ3J0alNXV0tZTUpURDB1Z29iV3FReTZjVlJi?= =?utf-8?B?bXNic2VVbHdCR1FNQkd0R0NSa3ZXM2pqbVRxa0FKRDBWYnlkc1htTjFqek5J?= =?utf-8?B?N2Y1RlVnWmwxcWJOdFIvTFZJdEdHVjA1UVNJWk80Q1NHeTVVVTU4WFhiUEh0?= =?utf-8?B?dm9TQy9EYld0OWd0WTRFRFNjTWlXR1ExdmdESXVNY0QxaFh1MnpKaEhleHBU?= =?utf-8?B?VDA4NG82MkJKbGVoeHhkV0xKUDV4TWRvTVJZVzB4ejZ6bjh6RlVoYW56NjB5?= =?utf-8?B?a3lKdnVZTStTWXZvR21qaFFtRUNRbVpXNC8yZXhyYjUrOU9ieDZzbmliMVN3?= =?utf-8?B?Wk9OYkhuZXc0bXRhZFJydlNYQXN2bEEwaTM5U29CWUVDU1JBclVna2VnZ2Fa?= =?utf-8?B?bnI1TGFLeTlJTXZUeDNrZ3dXeTB5SGpyZnE2R0tKRUlnaVJsV24wMzNXRXcw?= =?utf-8?B?NEIrR29lRTRKRDV1TEh5NU5QK0RYanNSSk5pY0RoV3JwZXI5SEpUbm9tNU8x?= =?utf-8?B?b2d2RS9sVzZweGw3Wms0bGVrN3dCSzN1LzM4ZzB3OUFvdGNIRW4wbU9LWFlk?= =?utf-8?B?bjErVlpxR3M2eG1EMzJNTGt0ZmNtZ1FNUFBPZW15Zm9nZUZkMGZjKzJpTlhw?= =?utf-8?B?aVg3RHZuSEgwSHJMUE9BbVpCc2JSNkNKZTFSdXVUOGtnakZGejhPQXJTTmE4?= =?utf-8?B?V1JLL2JjMGh5K21Zd2YyR1hCUlNWN2hYYnVDY0R6ZUxNeWlpS3R2Wll2andu?= =?utf-8?B?MTh6eDZWcit0RzdTcVlydExrWjBtVGp5RFBUVS9nZWNLZmVZZ2pFWTFSRUdJ?= =?utf-8?B?Tk1xWngwZTN5cEQ1NlVxVEcxL1FNRzlkQjZEVGFhWGdlSFc1QkhXeTlSUTQ2?= =?utf-8?B?NkhTbittZ3YvcGlGdG4yYUtLMHo3OG1qMzFRb05za0lvb1ZXRHA1aEdzZGtY?= =?utf-8?B?NUJZc1p5UlVhVHl2NUdMdnRwK0h5eGpPZUZrM21hb2dUeVpyZFFZbTZxcFIz?= =?utf-8?B?WjFybFdwOWoralh0c29pT3RQNTBJZDRJa0p0WWpTajN5T2NzYUl3Z2J0OG9P?= =?utf-8?B?Nm0vMklXcWtDRWFuWE9nckVudlN1Snp6MVZoM0hMdEtYZGtZbzdEdnBQcHZw?= =?utf-8?B?TEFUWUFkQzFpbWtGcFRuU0Y3NmQ5ejVIQ3lxa1dQNzltMFY2VUpQMThoRlJy?= =?utf-8?B?dmxGbEtadnJKVm52Q2VqTWFTbGMzQmlGTllQV1dMOFhTbEZheDIvVUpKcDNi?= =?utf-8?B?MXRsUXYwMkNSTENodm9ocHNWTXNxamxXeVdsL3JvdnUvT3RTSUwxang0UGQ1?= =?utf-8?B?VHd4RVpNakV3L2pxbjlrUjNMalI5RWt3SUpjZ0RQM1Bpbmh2aGFYWjFxeFRL?= =?utf-8?B?ZkxmTXFMRGI0cGY0NmE0emxaOS9kRHRDTmRvWDkwR2YxbVZ1R3p3bVlPWStu?= =?utf-8?B?ci9VVy9Vd2dVb3JXTVM1YWJFT0lhbWFwblRLT3hOcThYdW5VT1BDaUR3UUsw?= =?utf-8?B?ZzNTMFdpbDMwYlV2dzhNa2VzTmxJMExxNXdIS0JYdEhmbDV6eE1VdUEyK2Vp?= =?utf-8?Q?3C1aTiJIjR8=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR02MB7159.namprd02.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(1800799024)(366016)(10070799003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NG8rbHpiN2M4STZMTVVSSXluTjBhVnR6d2lxMExtWndScmhBZ0NndWE0M0xZ?= =?utf-8?B?RW9pdGVUK2NuT2RxL1RhME95SENkdGNyTHRWWjBJalVueDEvVnJoQS9wMFM4?= =?utf-8?B?bnc5L0wvTWx2dXkyV2VRdFZYWUw1OUdiS1pMU2puTkZ5NnY3cVBNT1kvWnIw?= =?utf-8?B?bW5DRkRrTUlWZ1BpeW01ZGk2YjE5OWVSSVB3UUZhY2t5aytZS2VSUWlwVVpE?= =?utf-8?B?Q3NYWlBXWUMzU29JRm15SGQyckFhYnR1STRVWVl3OTlSN0Y2ek5BS1h3YkNq?= =?utf-8?B?d0wwb2p1UUNWdU14MDFYUDNGanBRc2hDZ21aUFhyWm9Ea01FYWtYY3E4Vkpl?= =?utf-8?B?c3BsUyswRWo5c0pXZEhESmk0bUY5c0RsRlpTckRBOEwxeFZvRzVSdmV6OGxj?= =?utf-8?B?ZmFXeEpUcWFpUGdKNHBYR2N4VEJRMlRMSEJjaW1OdUhlTXM4bEZieDk1M29J?= =?utf-8?B?d3ZVd3ptV1pwQ0c3VnJIZEttRWk5V2t5N2tiK3FPaC83RzhsUWJjN1VUaXpn?= =?utf-8?B?Z3lueDNiMWpCd0lsd0lrMnQ4amhIMDdDWkR5WklYYUhJcDlBNU5maW03M3FZ?= =?utf-8?B?b3dGcE5mS0lwODRNSU1Da1ZSTFZRa1FDWVRXb1dkZ2hWMGV4OHo4Um9rL2Jq?= =?utf-8?B?TTMxV0VzQUNhVE43bmJKYVdVdlJqdEdtSnRDUktsVllVUGxtZWRNd3hUakhR?= =?utf-8?B?enpMQnV1ZWdmWCs3aG9UaEFROWJnWE9xekRKRnBQY2Zid0U3cGdqRzFJS0I5?= =?utf-8?B?Ykw1RThwekY5YVQ2dGlZRFRsN0RValgxazRYVDg2ZFUzOXJSdU1Vemo5czJD?= =?utf-8?B?VEd2eHJIT0xqSHBQWXYvSjNaWkxqQ0NNSTIzR0dKOUY3dDZreHIxT0k0aDJp?= =?utf-8?B?cWFhVDgrZmViMURyRVRaN2dBQXQrY0MrUjdrYkJ6TEJEeWE1c0sxNUIvblMy?= =?utf-8?B?YTN3VGRHMDZTM1BTZVFVZlE5Q1g3UDdQNHFCSWZacXlnMXRIOUxrQ0QrdWI0?= =?utf-8?B?K0xGR1hhS2VmeUR6QldVdjhJVFdoYzNCS1NFNGlTeEdXZzRMcEJEbHFHeTNX?= =?utf-8?B?ekZuYmlKOTcxT3VONUJrUzFNWmxqbGVXNjgwdzNXbEplTEt6cFEvZjZQaWFr?= =?utf-8?B?QWpMVWVVQzBBV3pvSmxBZFc3elVYeWZCdHN3Wjl5QzhyTW9XbUFaN1lXZGF1?= =?utf-8?B?NFo5eXBBV2tRaVBPbC9LQTlhdjZVb1NHbzNDNEdTMzRlQjZ0SGhpUklnVlRy?= =?utf-8?B?V24rZ2RZNXFUQ0hTSVgwbm4wdWRLcDdhRVAvbENWTUQ3TjBCUlNjN0V4bjF2?= =?utf-8?B?NlRKWEdNdkdydXAwQndYSEhTOE44emdzTnZZNEpSa2NZTG5Obm5SWFpSelBR?= =?utf-8?B?ajRpeC9vRGx2T0w1c0xGUUJpbEE0dCtRc0krd3cwckdSYVFieW9QNXlzdm5m?= =?utf-8?B?M3RwZGpoQnFoRUxzdVhxK2F2dG4waXUxZW1yWW13ODJqaEVJc21xSkFmb3Fs?= =?utf-8?B?aHV0V1pjVGlsQ3NLTjdqK1gwWTFyVVd2RkJsV0lEU0lGTk40MFd6UjArTGJi?= =?utf-8?B?Wm1pZjk4S1YwMG1VTHk5Uzdpa2Z4bEU2V1V1VnNsSXB4VTEwSUZZUGNGOStn?= =?utf-8?B?azlSMHlSd0EzQ0JjUXlkSnY1bmozaXkyWEhucExramc0Z0MrTzlXMU9OcHBL?= =?utf-8?B?a3hOZkMxekxSWkRmUU9xTHhhTWlYa1NjTXlqajYwT1RBdHNJVjVXell0QjVK?= =?utf-8?B?WU9JMHpRc0t0bmtFQk50am4yVkw4RkpGQ2lkZUt6bzN6d3ZvaVBOa0FjMGVp?= =?utf-8?B?RENHcGthcUdYVi81cnNkSUF6d0xlcis4bXQ0NGllbWFHU2VmOHdWWi9ZQnB1?= =?utf-8?B?WXFzNVZRbjBGSlFOVkhZeVFiWkxuVFoxbTZ6Qm82L2UzRk1ORTZqZEtvT2Zn?= =?utf-8?B?OUtZWlBRd1BvcnNIM3orcXhFQm9ZL3J2TDdZb3RnNjluVFcrSTIwTVFRNXRW?= =?utf-8?B?bDBNVjVraXlFNG04NlNNRXN4R1ZrRzBEenNSeDhleWxreUhnaDVKZmRTTkZj?= =?utf-8?B?dUlkTFR3ajNkYUphRDUwSWVxYkZRK0thOGdKTHFjRk8zL0xaTGlkVy9aM3N0?= =?utf-8?B?c3Z1QWkwaldjb0ZUaHZDSDFZOXMycE5randlOGZtM1prWW1nRHBHS281YnNu?= =?utf-8?B?TldKWmI5NHRCWnJ5UFR2WUU5Rjd3N2pCei9WS3JVUndHRzBPNHV1RklGY3Bj?= =?utf-8?B?cDA2R2hYL3NMUHlNbk90VUVBbThnPT0=?= X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: ad9e5cad-2fe2-4d78-fdce-08ddc0618bf8 X-MS-Exchange-CrossTenant-AuthSource: PH0PR02MB7159.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jul 2025 09:58:55.0302 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ZyE7vUDSphqJBQBUfdm1SBBWrG4uDeHlz/QzdK/xAG+9RVp4bQPkVapOy4EfSxWPAkV67fGHRg/LmC0fleEG4nbF6AYU3nuw6Dn9Q1Brvwg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR02MB7918 X-Proofpoint-ORIG-GUID: iGW5O4ZQq88qTu96_qkaoZ5w6FPibly2 X-Proofpoint-GUID: iGW5O4ZQq88qTu96_qkaoZ5w6FPibly2 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNzExMDA3MCBTYWx0ZWRfXyqqV4BZfZM+5 2jInVa+HTVlLKX96brUlJ9Jxi4Rl0fjeRl2kQMjBHzJITLeEIXCDH5wXRVlTSXwFsPaWVpx8T/G w+rlkwcrLd0FxrJsOgalopVOs/zMa0/SVUiVBbvuqjqhUMuSmb/AwT1zcMVB510C25UeO3FOsnq 35hwipsJHKu4tFmlx5b2QgmXrD1LKcJYD0p5yyQBAJdXhLMXWISmdGLfQPBGZ1+iFmgBbPCqrW7 3/XO12iz/0UHdH88xP5ZbR0VaCesoRJ1M5aLo0F/N7rimaLFgHJ9xEuCuSrzbPiGziwduLlFNjb Jisp+Tv+Ef80mkyA75fca1e4x2KxhuU639F7bPl1fnZwmEO1Z6tIrSgGHGQnnuF0SflW/DKkXTk JOvRAGW28Pv74UH9/BJ/VNGFqLjbxCr8nY5doh9Oe1jPZy6MzrVIRNnkhKAxMPpLjPhlEdi6 X-Authority-Analysis: v=2.4 cv=fNg53Yae c=1 sm=1 tr=0 ts=6870e060 cx=c_pps a=VIP9IjDh2lSQMlgnK/Goww==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Wb1JkmetP80A:10 a=0kUYKlekyDsA:10 a=64Cc0HZtAAAA:8 a=KKAkSRfTAAAA:8 a=_jvWDQGc8cL8bECqUo4A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.7,FMLib:17.12.80.40 definitions=2025-07-11_03,2025-07-09_01,2025-03-28_01 X-Proofpoint-Spam-Reason: safe Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=148.163.155.12; envelope-from=mark.caveayland@nutanix.com; helo=mx0b-002c1b01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @nutanix.com) X-ZM-MESSAGEID: 1752228189719116600 This function contains 'assert(PC_MACHINE_GET_CLASS(pcms)->pci_enabled)' an= d so we can safely assume that it should never be used for the isapc machine. Signed-off-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- hw/i386/pc_piix.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index f64588f01c..27dfdd5403 100644 --- a/hw/i386/pc_piix.c +++ b/hw/i386/pc_piix.c @@ -466,7 +466,6 @@ static void pc_init_isa(MachineState *machine) assert(machine->ram_size =3D=3D x86ms->below_4g_mem_size + x86ms->above_4g_mem_size); =20 - pc_system_flash_cleanup_unused(pcms); if (machine->kernel_filename !=3D NULL) { /* For xen HVM direct kernel boot, load linux here */ xen_load_linux(pcms); --=20 2.43.0 From nobody Tue Dec 16 21:11:18 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass(p=none dis=none) header.from=nutanix.com ARC-Seal: i=2; a=rsa-sha256; t=1752228375; cv=pass; d=zohomail.com; s=zohoarc; b=lkJwpx3q/FEK3yk2vWR2llYZVa3Y5WvLYN0VNbcvzNo1eKarZLHK1NTLJVECKHqHbmSLVjZwYjlnX842hqQHsgfpX2PqQ/rdBsfHZZpI/xvJ1C9Rus0R9wRaBzJDv73ZC6mDt+uiCuZZsRvxoesWwdkfdV6ZeB6PUdqH43RJimA= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1752228375; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=CIhq3sEB2yI/CMMEkbdmSiHQ8G3kxB26U9Eq0zCx2+w=; b=fSDtzRx/bwDMo33z1m7sq5hYau+UPrRoujM5IzR0z5Z1DimMrKuW/lk9xhMAPK4nKwHeo/1lHPxmG+O4lWE9FUs1hvAbNU/Jz+rhmp04kR0vIcFwbb1doJ5fxgfXZkNHIMl4+lyoRKFbP/2VaD5/3NlgisnMv+eX83njJPSuA3k= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1752228375341773.4643475841622; Fri, 11 Jul 2025 03:06:15 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uaAXi-00073U-Ky; Fri, 11 Jul 2025 05:59:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uaAX2-0006KA-Vd for qemu-devel@nongnu.org; Fri, 11 Jul 2025 05:59:06 -0400 Received: from mx0b-002c1b01.pphosted.com ([148.163.155.12]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uaAX0-0004sg-C8 for qemu-devel@nongnu.org; Fri, 11 Jul 2025 05:59:04 -0400 Received: from pps.filterd (m0127844.ppops.net [127.0.0.1]) by mx0b-002c1b01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 56B8IvJe032537; Fri, 11 Jul 2025 02:59:00 -0700 Received: from nam11-co1-obe.outbound.protection.outlook.com (mail-co1nam11on2128.outbound.protection.outlook.com [40.107.220.128]) by mx0b-002c1b01.pphosted.com (PPS) with ESMTPS id 47q3k38m3d-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 11 Jul 2025 02:59:00 -0700 (PDT) Received: from PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) by BN0PR02MB7918.namprd02.prod.outlook.com (2603:10b6:408:161::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8922.25; Fri, 11 Jul 2025 09:58:58 +0000 Received: from PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88]) by PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88%5]) with mapi id 15.20.8901.028; Fri, 11 Jul 2025 09:58:58 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint20171006; bh=CIhq3sEB2yI/CMMEkbdmSiHQ8G3kxB26U9Eq0zCx2 +w=; b=2fguUYvl602CgtWK1hJORaiR/8gBo0aaRI3/15OzhGHEdqE7RfgHX8V2f gTdPe1x1N1n/3kk65NXqBzxbRcDhURwOB3IT0+XyKH4Frd9jZ/hpiYWMRx2AZAc5 tcVKYcEYtAJ7FWdBuH4Mf2JvvEnT+bseNKAvW5u2rfWj5L10X157kZRam66c4qja zk4ZJaFZBpDFQdVhIcFWvfaecYSJmTze1fXulGmDIbbNnpL86c/q+cMy0ymuJV/E t933gIUdiJmgNBTLdKQm/7PnDgd3567HyBGaI3bxszvsGjPQmaPWtNPVEIMtS2OO eUMJ6RMtRiZlyQm9HFZYyIYo+nadA== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=iJUYeH1T46fe+/8wJGPSXnLaBNHdmxOfgJEEPVdwMMgwAGPIvPUA76+m/a6mbdn74Qf/E5muYrB4mb+ITdLIgtNHpcD3v5u2BjeeL3nxNX5sdyjwvliNQgNji9quqv221g918r2XcJxrQRIhIJD7qcmfv3Iyaf0adS1fkGmhYp4WZ8wvUv/DY/Okip3QJJcirwWO7GSfg8iu00ndKXHMCsob0QxA/BwXkc1nZ4XtwiscPahrKkUWfLYiULDsmUeyfKS2KcZC5CvgQq+5uhvoL+109xyyqMXr9KiEy/p5DtwmYHfztB+n46cOm/gdEE81dN94nM3ejqDC6od2FCxutg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CIhq3sEB2yI/CMMEkbdmSiHQ8G3kxB26U9Eq0zCx2+w=; b=tRhcBE5U+YwO/JorqwzEKHG04uE8CgOt7kbe/URfzyV2XS9e9ENVH7Kh+k98XGgfLbHakK3y62+kC4nYW4PAd3GmjppjnxZ226MviJ7TRwhlY+ZaeMMcKJeO/qpqNkByhUBaJysvl3n++PZGYR6Y/wVyK1hcxtC1mbwbbul0BaxaSCzsXhnZnHCzyeyYZxPfgwCiNzpUWpwh4g8Th4phBqhJeF9x/9/X7iRdbJ7KyUxkQEDkLrR+D8DDSKZEtJiDLG0y8+cjU07iPvmqbxbKK6JF6r8nIcCw3MQNfSmcc2D2yMs246dkm0XKtN5kwjzHpRocg+IxT9NklP4+JHZj0w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CIhq3sEB2yI/CMMEkbdmSiHQ8G3kxB26U9Eq0zCx2+w=; b=nqoZd/vrGdZnbFj+szGwtADFMEKh7LurnpEemBw5bVf+vJvyghPFEh7bYFtzYQxUR34aOVcyddo2mnYTh1AHFN/5ad9X9Y3vM4ol6VKegZ52ASqKPeTCID1WxFDNiUjtMoZnPZcGj/WnS64E2mG1OzUVCiWFLmpxAdad/Q72mGYRvfXziJVOGdKXi6djaznj1hO8At+jB4GHG9Zw+TnNKJl7kEM+zkywRpn0H9zGAsdexiTXsY6SbBoFj6pFzGE+gp8i+pz3N+fWe82jZRDeuKw1JLEerJRTRXnkMpSRUeYRZXfKi9h2Vn/9Rtu+08bGO9/xCAyLkQJvSMkrctB4UQ== From: Mark Cave-Ayland To: pbonzini@redhat.com, mst@redhat.com, marcel.apfelbaum@gmail.com, eduardo@habkost.net, imammedo@redhat.com, qemu-devel@nongnu.org Subject: [PATCH v5 12/19] hw/i386/pc_piix.c: always initialise ISA IDE drives in pc_init_isa() Date: Fri, 11 Jul 2025 10:57:14 +0100 Message-ID: <20250711095812.543857-13-mark.caveayland@nutanix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250711095812.543857-1-mark.caveayland@nutanix.com> References: <20250711095812.543857-1-mark.caveayland@nutanix.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: LO4P123CA0038.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:152::7) To PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR02MB7159:EE_|BN0PR02MB7918:EE_ X-MS-Office365-Filtering-Correlation-Id: c810561a-09a2-4f16-3050-08ddc0618dd8 x-proofpoint-crosstenant: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|376014|1800799024|366016|10070799003; X-Microsoft-Antispam-Message-Info: =?utf-8?B?aU81eWhPQXQvSCtqYUpJR1JCSFdYUVJrOVV1cTNtc05jSHljdmFxRFlKYWdI?= =?utf-8?B?MGl2L0Q5cnNBZWRsODlpdy9jRHhoL0RLdGg4bjNINW1zUG5DcnhuVW5uM1Vl?= =?utf-8?B?RHJUdGhOeHIzeER1NVIvd2FodzdaUmt4eFU4bEFsUHNXUUtOa2F2YkF1UHIy?= =?utf-8?B?em5nZlYzcnV3MXdmYjBsMGFjZUs3bTFIVVppL1kxNDI3R3RYU01SaGdrblZM?= =?utf-8?B?U0k3cHpaN0RNVS9kUXZJREhEZ0VSQXZPWkVNVWovRHJHMEVTVEhRcEp4Y25n?= =?utf-8?B?Mmg0azVKTktKMnVETWRhcXlWK0hOcmtIc2dRSmMzRXBwc2xMeHovKzJMZFpD?= =?utf-8?B?WGJWb05EdzNpaFBOTlpBaEJlYjVDMmlPbTlkcUNRanFGZnBuVk9vWUoxNjFT?= =?utf-8?B?TlpKcVMrYmUxK3hCOTI4c284WVBrMVM1WUwrYWttV1NiTngrRzdQeDhNQy91?= =?utf-8?B?TWwwaGFFSmZCSm5KRmt4MzFLbU1DckpXdnRKN044ZktETUNZTGJWRXoyMVRl?= =?utf-8?B?TUNDdWJrNFFYREg5K3FFTUNPL0ZraFd4VUJzUkRaMW1PRlZXUWR4Y01Ialls?= =?utf-8?B?U2FCMDRnVkpxdU5JWnRsUDVLOWs2SXdCVFpjTGJLSm5SaC9vYzBpbVpRT0d6?= =?utf-8?B?RGN6MGJjdDYreHBqWHA5VTFjT0dLN1RGeGtVKytSdWNjRVZVdzZ3enJlb0ht?= =?utf-8?B?eEZjSElRUU9seVJ3aVpHN081TGdwblFINmlUb0VlbDRzVkszTUZOcEZSZ2sz?= =?utf-8?B?WWJmU2hGUlhvYk5vVldnMVY4NkN3b3NlbDVJRVJpZmtORDArUksyN21FNWFC?= =?utf-8?B?citlS0dTSTZwcEI4MHM0S0dpTGdXL2JRUkR4Z3V0RHptaGxabHJjWW96b2tw?= =?utf-8?B?R3AvQ0hNNmhyL2xhdjNsME53L3ZpN0tKQ09adWpnL3V4U21CQW0rYzFmYUJm?= =?utf-8?B?M0k5Zld1TjVGU3ZPSFc5b2htZHdXQVBTMWdvQ01uc0FkN3JsaHY0MHNrVEpO?= =?utf-8?B?QVpVcTFGQXhYUEJuN3JNV1hmOVF3blZkYmZZa0tsMzI1SHhWdTlkeXlkZ0pv?= =?utf-8?B?QnhrMDRUbnVHQWtoUVVSZExOelpWMjFHc0FKdy9ONUpLSCt3UlZaRGFhczBY?= =?utf-8?B?alhRQ2dYaDRhUWw1NnRjU1BOdzE4aFN4TE5wdTZsOVlncERXdWE5VlQ4UHJS?= =?utf-8?B?MmpDQ1RscWJOYUg2TU1STVAyVVp1VUlzOEQrRWdCU2ZUMUxqMDFVNWlhakpJ?= =?utf-8?B?M1hSR1JlLzNiYklhaFRqVTJzWGRHNEx5VG00TnpKaXFpMU5nSStZSGtwZUZi?= =?utf-8?B?UUQvUHJ6bmVhVHlSYllKc3ovNVh1K0VQelVKWGZZL3pDbmhoNFdNU1VpdlR3?= =?utf-8?B?dk52TGxnc256ZDd1MVZHVmdzUncwT3JGM2MwemtiOHZvdUQyYnlLS3Q5WHN6?= =?utf-8?B?NU1pTWRSbE0zNzJ0SC9xR2kxRG0ycHNFdG03a3FhYllna1lQZzJRYjJqeExo?= =?utf-8?B?UUI3VUU2WW02b00rZGY3WDdTSm94UkloSFhPYkp2YzhqSkczK0N5Z05CVTBI?= =?utf-8?B?NkUyT3UxVFlhSjJFUVRqVGMxTUpNR3FaUjNiamUyMEkxZDd6MTVHVWgyWGps?= =?utf-8?B?cnlMbi85bVUxVERYaXZISzBuaXNUNm1aTWpBeUhLMW5HbTkzWnlZVkxKOFV4?= =?utf-8?B?VWY2SFBDbFpGbldtWDh0QVRyY1JaYnhBSEhhQkxwRjdDUGZTa0JCMUxkeDNk?= =?utf-8?B?alpNNzlDMmVQa1BJNDloK0xvSnJQWFJETFhHT0ZieHQxSVFtTmp2ak9zaUJr?= =?utf-8?B?N2hqUE1RT0hESVpkWUpHUlBzZGk1ZG02aDJDZkEvdllkdTNUWkRkRVpSamVq?= =?utf-8?B?alN1NnhXTmlQZTdXOWUzcUF3RW9QMmhWd25MbjBPZWdaY2xYeGlncU9QdS9Q?= =?utf-8?Q?WYZBuF0t0sE=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR02MB7159.namprd02.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(1800799024)(366016)(10070799003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UC9qeG9RcWxMU1VONTVzdmdNSlZ3TTROTFhadFhTQVk5TEd0VUNmVE54R25i?= =?utf-8?B?NXl5NzdEWUY5OHRKQXoyb1MrM3JHYWV4UlIwa2gvbXFpZUZCdjZaVjYvSkVz?= =?utf-8?B?MlorYzhUYWtMYTYrbi92NXNiYzlSeFUrUFozcWdDTk11MzBvdzZ3Q0ZRd2xT?= =?utf-8?B?N3IrUUpPcVdwVnVRQ0hnREdRNkZZbnE2MW54T2dzTGsrSHVJMU9WeXkzSXdV?= =?utf-8?B?TnF1WmhXbUN6TlgzZW5kU3NjNmZkTGhHOHg2K2R6VlZyRWZKbmJBdzFHdjQ1?= =?utf-8?B?OWFSbnQrWFRTbmk5TDlKbHNzOHFVWXdRRWtKK3VuTDZvMjJJZi83SkN0QUo1?= =?utf-8?B?blhTbTZkRFQyaWVlN1JvdVVJOXN4TTZpRnBOYzVma0tTUitMZXVEbkJYQzl3?= =?utf-8?B?TUR0dkJsNXpwRjNuRlNmU3E0eERIeDFMeHlQR281QkREbTBsUFp0cVN0dTRh?= =?utf-8?B?cUlNV2xKMEtoS3JNaTZyUVpBU0NSS29CamlSVThDcHU4bnNZeFdObWRwb2R0?= =?utf-8?B?aWRYYURLWFlJVkFqMTNZZUpzQWQ3SFRxaEp6TmRzTmpPSGJ2Q1NNOCtaSnBt?= =?utf-8?B?YXN1TW9kRWxFcllvSFJ3dXQ5QVJiRmpjdnY0RkhjZ2s1MmxCL3lkOGdsR3Y2?= =?utf-8?B?Y1VUVmo1dVJzd1RBekRzbVRoU3o1Q29aZndrSlVsQURzN3NhSCtmdndTK1g1?= =?utf-8?B?Nk44SU83UExpLzhjcmhjSjJDNnZZcERuSWltMGVLVUtFRm0vUnZPOFZPODBp?= =?utf-8?B?QUVZV3lVVkhzS2RBSmdXREkwdy92c0FsOUlwNFVRak0zMHBWc0FFUk5mc2pT?= =?utf-8?B?eXA4SFAwdjdEN3NSLzdTNnN5ZmRVVzNtSzFqUlg4ODZUczVpVllGendVby8w?= =?utf-8?B?bURZQ1FxQUdnc21QSmhhek5kOEljZkJlc0dJb0JOZHVJU0JKMlJ3Um0yTXdw?= =?utf-8?B?R0RNNXB5WDJFZUoveXBhWFpSbVROTHR4cCtCUmlZY1RjMUtJWDllSFNZbmha?= =?utf-8?B?THM4OW1DaTZNdXFPUHpuamJoeWIyNitKUms1elhDR3JxMTNHMFBPaXk2M29T?= =?utf-8?B?ZmxKYUZkaDlZSmFjUmNvaTRteVlBVHpjN3p3Q2c2YUdBSFBZTGUvSXZ3M1Q0?= =?utf-8?B?d2FleU9VMXZ3bmQ4QmFHaklnWUVtVjR5Ky9OaVNWL0YvMDJoTXByK05idFJa?= =?utf-8?B?UXFjb01MQkV0aytuN3Z3K0Q0OVV3bnpybG9OcXU3WE1kUUUyU2xOSjVlbnBH?= =?utf-8?B?Y1BjZFJDRnpLWGlCcXFBQVM4UHB2RWpPTmxqS0JoYzdCK2loQSszaHl5VHNO?= =?utf-8?B?Y0RrN1NYREhySjFDdzN5KzRsK1BTTE1DTVVQNmdpaG5sbFFzL3dhb0l0ODd1?= =?utf-8?B?RTBxWUNrdXJyTzdvWU1PdTQyYU93c1ovdUV2Qlc4TDhwZkNMT1NVTmdBTjUz?= =?utf-8?B?S3JHTVlGdjNkT0hRajZ6Z3NJNDdrMS8yUkJzR0syUHU2Q0ZyVGVPVnJUOUlW?= =?utf-8?B?MmpoU3hmeE51UCtidzVuaTluOGlMd1ZHWTEwZnEra3hnMUF4Ynh3V0hXcktU?= =?utf-8?B?TWJ5cW0yNzkxK1d1RllrV1NqbkN1bTFTM1F0YTBqWmF4eTRURVNOVE1OaThk?= =?utf-8?B?MVZKQWozRmpSanNncEN3SURSbldYZjVDMjRITnZOWUtUVy8raW93KzQzdTBE?= =?utf-8?B?dFZZSUdBODROTWlQQjRzSHBoQzZUMHpCWWFSeGJRdGVjY2haTVpUc0VGNHZu?= =?utf-8?B?dU5DenhyK0lSdUZYeHQ4WmxnOHVNSTFjSzNJU1dDcktMdU50Z0JYS2Z4K3lR?= =?utf-8?B?VWROV0JrY0Q3b3BvRHNQNW02aSs3dnpkUTZVMDAyV21ac3hDajZtam9sbE41?= =?utf-8?B?aFZ4Y3N4TXJiOVJvWWE3UVBKMk5OMTNVSmk5eHBXdjhPZXI5WWJhd3k2bWNO?= =?utf-8?B?cUkvdkIxZ1RCekx2ZHFLbGpXTncwdXZvQVNTQTlaVEZNRGFtc0Exc1VtblVE?= =?utf-8?B?cGgydlI2T1hmeGZGQU0ybmhkSFA0blZlQ1pFYm5Tb2FpVjE3RDRVOUo5RWlz?= =?utf-8?B?VnUwT1BEQ0JZay9iazR4eWJ4QnJNcmwzK0gxUDNOR0grQUxWWVBSdnNTazVk?= =?utf-8?B?Yk9QaTFuU0hmTHRlYTRQVTVNWExWcm1FaFh1Y0Vvc3pqa1JKNzVlNHBUMVUz?= =?utf-8?B?Q0R0ZTlnNzlxNWFPanV4VXlmU21NVCtVMUJ4dVo0VE0rMlBSYk50SlkyRTE2?= =?utf-8?B?elN1WW8rUXVkQWJoOS9BVWVXNjhRPT0=?= X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: c810561a-09a2-4f16-3050-08ddc0618dd8 X-MS-Exchange-CrossTenant-AuthSource: PH0PR02MB7159.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jul 2025 09:58:58.1374 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: BnWfbZvqP4Pj86CKwu39bPhjygntGTe8PIBx5pM34pu9ShAedQeLU28IraM+758FDnVgwdHR+l10dW5nzJPBqR7l9g0lBFmvlM1V7fs1i7E= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR02MB7918 X-Authority-Analysis: v=2.4 cv=UNDdHDfy c=1 sm=1 tr=0 ts=6870e064 cx=c_pps a=JpZts7cEBrfcwmRlVwBwFQ==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Wb1JkmetP80A:10 a=0kUYKlekyDsA:10 a=64Cc0HZtAAAA:8 a=KKAkSRfTAAAA:8 a=qN5ve3sCTOSH2ZO3jx4A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-ORIG-GUID: q-RV746e0NpZCZ0mZCUWUCDNVTir65Mk X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNzExMDA3MCBTYWx0ZWRfXzph6hWJLfpEQ c3yn7048soyU2D3G40Bk3ExhO4B3BW6Amb+ZWNJ/IA5p7mjifPkxUqrjqkszuhswOjEEO/iUtsJ Qdg7DSCmZ8YoNhIXVIbrANlWUUqTaNtIUKrtDcIbAhr3yc6vL4PMbmHa5WCAl3bQmATQTNFYmU6 HEauCpt5ZQgKoGmjqQJ3j7IEy6jSh0hbRCcKlQFU5tCFu978yONNfwxibnHYF9nkLhneEbj3VpG JAjlXZDvGV0CB1ZtsQeKnT8nfXA1HpFRpEitTtt83iPd4zNQUTVRVFY0a8e2PF/VShM7wn9Ih/0 WkWxIOClYsHceAXUei9Ml1eT3jIkZpvIvH6IaytTS/kF0kE+4iNONRqf0J5VQ1tT1IC4/EWK93h hChzCVQlSLtMyC1C0EOzTqEmwKk0Nhriq/VNvOblRV7e7vokBR2ueJs+4s7Un/MaaII4sYwX X-Proofpoint-GUID: q-RV746e0NpZCZ0mZCUWUCDNVTir65Mk X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.7,FMLib:17.12.80.40 definitions=2025-07-11_03,2025-07-09_01,2025-03-28_01 X-Proofpoint-Spam-Reason: safe Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=148.163.155.12; envelope-from=mark.caveayland@nutanix.com; helo=mx0b-002c1b01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @nutanix.com) X-ZM-MESSAGEID: 1752228376277116600 By definition an isapc machine must always use ISA IDE drives so ensure tha= t they are always enabled. At the same time also remove the surrounding CONFIG_IDE= _ISA define since it will be enabled via the ISAPC Kconfig. Signed-off-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- hw/i386/pc_piix.c | 35 +++++++++++++++-------------------- 1 file changed, 15 insertions(+), 20 deletions(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index 27dfdd5403..59c2949379 100644 --- a/hw/i386/pc_piix.c +++ b/hw/i386/pc_piix.c @@ -426,6 +426,8 @@ static void pc_init_isa(MachineState *machine) GSIState *gsi_state; MemoryRegion *ram_memory; MemoryRegion *rom_memory =3D system_memory; + DriveInfo *hd[MAX_IDE_BUS * MAX_IDE_DEVS]; + int i; =20 /* * There is no RAM split for the isapc machine @@ -501,27 +503,20 @@ static void pc_init_isa(MachineState *machine) =20 pc_nic_init(pcmc, isa_bus, pcms->pcibus); =20 -#ifdef CONFIG_IDE_ISA - if (!pcmc->pci_enabled) { - DriveInfo *hd[MAX_IDE_BUS * MAX_IDE_DEVS]; - int i; - - ide_drive_get(hd, ARRAY_SIZE(hd)); - for (i =3D 0; i < MAX_IDE_BUS; i++) { - ISADevice *dev; - char busname[] =3D "ide.0"; - dev =3D isa_ide_init(isa_bus, ide_iobase[i], ide_iobase2[i], - ide_irq[i], - hd[MAX_IDE_DEVS * i], hd[MAX_IDE_DEVS * i += 1]); - /* - * The ide bus name is ide.0 for the first bus and ide.1 for t= he - * second one. - */ - busname[4] =3D '0' + i; - pcms->idebus[i] =3D qdev_get_child_bus(DEVICE(dev), busname); - } + ide_drive_get(hd, ARRAY_SIZE(hd)); + for (i =3D 0; i < MAX_IDE_BUS; i++) { + ISADevice *dev; + char busname[] =3D "ide.0"; + dev =3D isa_ide_init(isa_bus, ide_iobase[i], ide_iobase2[i], + ide_irq[i], + hd[MAX_IDE_DEVS * i], hd[MAX_IDE_DEVS * i + 1]= ); + /* + * The ide bus name is ide.0 for the first bus and ide.1 for the + * second one. + */ + busname[4] =3D '0' + i; + pcms->idebus[i] =3D qdev_get_child_bus(DEVICE(dev), busname); } -#endif } #endif =20 --=20 2.43.0 From nobody Tue Dec 16 21:11:18 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass(p=none dis=none) header.from=nutanix.com ARC-Seal: i=2; a=rsa-sha256; t=1752228037; cv=pass; d=zohomail.com; s=zohoarc; b=MQ5PvvSjuq1KmcmaukqbfyijodBTkJSOW6akHFK0Lvp9LVVH7Lszm2RK9Qf7SpltdjWYkv2fqVmfjdr0b6xBOFBV04d8P/ZJWh47zP35d5cB/wtAkxPJoqdczkWIhzadhwabHXpGWzQGob9ZwwEGtxeEaqu2Y4+2umJdeseqmaY= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1752228037; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=zQVQZqRPV+FkNfTw+Ml38xv/7xc1daU6rA+m7BAV/Hk=; b=OX2EDvYYEfyxHRdIGJhYZTdS82+lt3okAOKMJ2+PHSLfuXtiOT0HbcqOZBeWpgoGF3qi2zUNXbw3bFJq7cWqmX47EVHaSeW94W14r24zu1/w7iT5psjWM3o3SiPrSACmz/t5IGEd4wxPkDAXoTj2JmFQEQPhoBcArmEyWmRSVpA= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1752228037248660.1672816692009; Fri, 11 Jul 2025 03:00:37 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uaAXk-0007AV-9o; Fri, 11 Jul 2025 05:59:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uaAX6-0006Ku-97 for qemu-devel@nongnu.org; Fri, 11 Jul 2025 05:59:09 -0400 Received: from mx0b-002c1b01.pphosted.com ([148.163.155.12]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uaAX3-0004th-ED for qemu-devel@nongnu.org; Fri, 11 Jul 2025 05:59:07 -0400 Received: from pps.filterd (m0127843.ppops.net [127.0.0.1]) by mx0b-002c1b01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 56B7U4qm016883; Fri, 11 Jul 2025 02:59:03 -0700 Received: from nam11-co1-obe.outbound.protection.outlook.com (mail-co1nam11on2137.outbound.protection.outlook.com [40.107.220.137]) by mx0b-002c1b01.pphosted.com (PPS) with ESMTPS id 47ta49k6e0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 11 Jul 2025 02:59:03 -0700 (PDT) Received: from PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) by BN0PR02MB7918.namprd02.prod.outlook.com (2603:10b6:408:161::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8922.25; Fri, 11 Jul 2025 09:59:01 +0000 Received: from PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88]) by PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88%5]) with mapi id 15.20.8901.028; Fri, 11 Jul 2025 09:59:01 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint20171006; bh=zQVQZqRPV+FkNfTw+Ml38xv/7xc1daU6rA+m7BAV/ Hk=; b=KjjCnOOb4fvP2uEngl+IAuBZ01aEm80vW+yfhgqrAHTI1jbLpeTEhlgWZ TzgRZpISit+sxwjjNQXFtlm5Hie4bkMKmqbrDnOTOwP+LQuTxgYmx6FgaipQo1qb sF+0QmKkWP0l+2821hmf8o3XCNKoKGw78zBrzw2a2HlX6pW5/Jqqun9Y1rR+capS TXodGX6Mw6O+S/KWxjTC1PQzrjGWTnT/OGiKweftizu5d2pn69Ff/OEtXaJYNa8t SJDd1Y3/DIAUJ4VRrmWDcX4oov1vl1b68FXe0vsxgs9SY0sYuomkPqHjGjdraGkq jjeajFsVHoT60S/Yih5c7FJQo1TXg== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=dNqBalCQuCHDPZIrf6tPom+0t9Sit3KMRMefS7AsZFur7hhTsWK7rl/wrD9PqRH8smScQqmyDiM1mkv3rZ2phd0EjqfM5WzSwvhLtvCJCSLLKqsm5qdmkYVSrLQWXMvU/Qu7aHOdQ9uRpreQaH5cssRkk3yVRar7v560Kf+IfvNJ5dJ1O41hv0SLPEzY6A04XQL1dSCc6xLKrjLFp/KpidfIdH+JcPzK+6wNN2rYkhIlUOnkGTqX4hCBuPqb8TpZgoy35tgPLTF50sunstsWqJbh8WdypIEFP23DhCOpbygdrKapVBs5Cmfhx9R198y4FlxpoaGbXyeCpEFaZXQBwg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zQVQZqRPV+FkNfTw+Ml38xv/7xc1daU6rA+m7BAV/Hk=; b=a7V3Rz+CA6tCPh5RUUBAipG4hE9ZDdF40k/2H+EFx3plrGvWjhIqni4SmW+j+YYK6TSuhalvsif2k0+X2oKmfpN19M7pjWjZy2VrCKVNCB6XGA8PzNuRKBEbgGgM6zSmowaYhJXCSMXOGuEzON/a6hgwhLq8v+oPYIdspYehZeFj98MmRfoVTtrnei3KhpvjBMtCkuf0wd2jO/pAHrQWCt8miyqkL2AtajqTfl1t0V+j9yRmEZ9OfnUfyfHW4dL98RlLVapy/d9Y9EhZf4VxlqNT2xp44OiQOtJuDrUQxDjeEpdXts1urqfwP6U3dnMUUQLiYUtf3IyRBZDnLXkB1Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zQVQZqRPV+FkNfTw+Ml38xv/7xc1daU6rA+m7BAV/Hk=; b=My/59yQiXKLbz5n/jMZxQoDbKl5/IVr7kRCKydXqQHcPPjk8B5jYhGudau6hiJrstU1kY2GfyRUfkA/TbUkzPid/zgSqtPiJvoQ8Yvm7nHk2DEjyzWyDJdf2YaWpEHVvnnhGebU3YBBATGNAVGXotj+uCIcMI0i8ASh1NbD3A9qfPH4AAkJr4dZ7POwQA18iUAc3GrXlQGtDfn3AX56cMb9nvp9nfvqDsfSYZVJz+AEApirHZhDagaTl3Q7xSlgSaaQDTZ1jqWfzsW7scnFLnoJOQJZ7Y5mpg7FFD4aEMnk/7XPJ+PV+ARQ9XhBpjDcd3o3d/81SDRrqZhR6C7VYyA== From: Mark Cave-Ayland To: pbonzini@redhat.com, mst@redhat.com, marcel.apfelbaum@gmail.com, eduardo@habkost.net, imammedo@redhat.com, qemu-devel@nongnu.org Subject: [PATCH v5 13/19] hw/i386/pc_piix.c: assume pcmc->pci_enabled is always false in pc_init_isa() Date: Fri, 11 Jul 2025 10:57:15 +0100 Message-ID: <20250711095812.543857-14-mark.caveayland@nutanix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250711095812.543857-1-mark.caveayland@nutanix.com> References: <20250711095812.543857-1-mark.caveayland@nutanix.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: LO4P123CA0266.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:194::19) To PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR02MB7159:EE_|BN0PR02MB7918:EE_ X-MS-Office365-Filtering-Correlation-Id: cf4f9380-6299-4588-2424-08ddc0618ff5 x-proofpoint-crosstenant: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|376014|1800799024|366016|10070799003; X-Microsoft-Antispam-Message-Info: =?utf-8?B?ckR6NHROQTRsK3hmSFlIVUtleHdDaXdrVHNNb0xtL2xTRXFxSmxhV0dQR2lD?= =?utf-8?B?b0g1cDhDcE44YjZleEJnaTV3V2xlNnkvVmw1M2dMc1lRWXoyZTdCSUw5UXBz?= =?utf-8?B?RzV3bWlyTEFnMUxNS25CWUJXbWpKSkpLWEZaa3Qva2xwQ1JvUEVRUjF5c3pQ?= =?utf-8?B?eGNQQU9HcHFNMU5xRFhXTDVpdGNESGt6eDYzZ0JZUlBmSkpycWM1ZHI2YWZ1?= =?utf-8?B?Q2RBTHBVTXQxcTlVTGJ3aW95RFZFM01EblV5QUVGc1JOemsvMjZCWXBRUC9o?= =?utf-8?B?cjQySFJoWE1rN0NhWTZUY1gwVDIxbXVxdVlXRTVSWE8wK0FNMDRYcTF5YlJZ?= =?utf-8?B?RzRoZW9NSVJMcU5seDhJdXZ2ZlZkNS8yK0owenE5a2pqT0YxQWEvOEFJUG92?= =?utf-8?B?Q3ZjNDcxdHFTbWNTbWxQaFRMcEZISmJSV2lMTk1rNEI3Q2ZDTkh5a2Zxb09P?= =?utf-8?B?M3NIaFkvR2lJQllwb213WXoxRC9EUFpoQXRoazJONlU2ZEhrYmFyWlJwcnMr?= =?utf-8?B?R3ZnaVVHbGduaWRtZ2prQWVTZ0pxV2hvSUU1N0R1Qm9vOURVQVU4M0ZHWmp3?= =?utf-8?B?Qk5CQVVsQ05rNHJ0ZU1Eb0tKTVB2Q2NwM1FyV01nRmZvdVZUWFh4cjVPV3FJ?= =?utf-8?B?Vy9SVjVnRjVVemJnUHFQcWdPTjMrT0pXck1jd0VHa3JTTzM3SzJ4VTZIMldQ?= =?utf-8?B?TDFXZWtpK3ZWbGQxRXhLam8wWFBmOCtHSE9raW50c25LOVc5QnpjcXIyTm9H?= =?utf-8?B?SExYSVJVYUtnenI3a0ZLb1I3N3hNYWdBL0ZtZ2pUWkpwbHJkUTNjMUxKY3BI?= =?utf-8?B?aGVzcENvOFMvWWRISDlxL2V4a2xIR2pZbWtScVYwbXJldWY5T2I1eHFOVFdm?= =?utf-8?B?RkdzMEFySEZwVFd1TDhvYktzeGtSeURzUTJtZkRsRWpVMXBaTUZ3MUZrbjdX?= =?utf-8?B?eTg4akR3SUg0REIrODV3dTNRR0Exb3VpWHdxNlVSRHIyOS9TVDlmSkI1Ty9X?= =?utf-8?B?MlgwWlNKYStNV3dkNm5hdGZkcW5QWGJ1ZlUyOXRCWk0vaEtRNlRSN0JBQ3dm?= =?utf-8?B?T3phZURTMkpXeERtaWo3dUlVSUcxK2dWV3ZuYjA1ZEdQZHVqQTdFdXA3Q3JB?= =?utf-8?B?L3JsaFFEdis5L29PbGtudXFOWGp5WnVCYk1iWjljRVVQT21aczVYZjFOSTBV?= =?utf-8?B?aDMyNElNMEczZGNZeCtkV0pCYUlFdEpTdzdWUjEvTE45WStOTzlvRVhaTkY4?= =?utf-8?B?QUdVRmN4cEpzOEh1U1VyQ0dJUnBLZ1RzV3hxNlg3YWhNajcvaHFBWERPa1hv?= =?utf-8?B?dXZtYUxSTXY0Slo1VDBJcFA1ZkdoSXVaN1JPVCtWMnQwV3c0eFozOTRqQ1h6?= =?utf-8?B?UHZoS3ZtVDVxYW10QmxVbTEvWk1BbWowWU9NWlRCRTV2VzBGVUIwR1hiWHdZ?= =?utf-8?B?WWpMYWxodTlpRzYwejRjbHZOTU9NQlhYLzBVVWZGNnJJWFI2NitaM3JsNUFl?= =?utf-8?B?NURmOEV4KzB2RnpjT0FqUGtRdURMVktpZlJETzEybzBpZnhyVGFkYUtxQ3Fz?= =?utf-8?B?RTlUdVVsYzVQb0xrTGZhdVJFTzFqUnA2MUFFTEYrTFBjekNVVUdGZWpPaGVv?= =?utf-8?B?UGZ5cjcrRDgrZlJ2ZTc0dUpQYnhxUUxOVU9lb1ZuaG5MNHFwSFJyMlNTakZG?= =?utf-8?B?NytGcUtiVmIweExSc1duSHgybFdOcExlcWFKWlhWZGUxcjZ5SkdyRUJJSVli?= =?utf-8?B?dCtzQThmTitHdnpvblBNdnFDV3BTcnZBL21xM2tmYU5ITzczdmpjaE9FQ0NM?= =?utf-8?B?eTVUQjR5TElEV2l4REpBcFBDQkkrVDRuVEFhNjZ0VXRmdzdmUDF2bi9DNGsv?= =?utf-8?B?RFgrT1ZMRzJxc25SaFNLYkZVNUQ4bFpBOGpOelJLWEY2SDcyUWdHUXdWWjAz?= =?utf-8?Q?uy7CfBbr2XY=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR02MB7159.namprd02.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(1800799024)(366016)(10070799003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dkRDRk96ZHpmbkdUSWRaYmVIQklQNElFMjFhVk9Xd1hPL28wNGdrdXR0VWQ1?= =?utf-8?B?SGZ3Tk1DUFZNemFPM1ZQT3FMUzFUY212Q0FmQzV6ckNrSldOa0E2NVlpVlVR?= =?utf-8?B?VmF5bmhCTHNUMkxYMlpMV3VSNUNFOC92elp0eXNCWVE5VFNHVitYS2ZLOUJm?= =?utf-8?B?NUlLUWp5V0E4dDRrbXk1MG5WSDYvVTVTbU5NWjVhQUowNnkxNzVJVnlYaTBF?= =?utf-8?B?aURTQ2FZek52U28ySC9vRWJHOXJ6cXdiN2hpWXlMOTBqU2Q5bmp2b29rWCtY?= =?utf-8?B?ZHpHb3Qrb1c1WVpPSHhwemNTZkpGR2dDUGc3Z2lxVTNOdXJsV0pqaGpzazF6?= =?utf-8?B?ZjBtNVFKOU43c3NYeUZwRGFabVkyanMrSktPQkhZZmV2VzlYZ0RQY2hzVEtN?= =?utf-8?B?d05wSktoWFh3cUZYZUdJVVlzSWltUC9Zc1FJT3V6OHc3NGRubjlJT1hCdFlY?= =?utf-8?B?RmthK0ZxaXZJRElnaG05ZVdJMDZ5UjFiMkJXdXgyOFozenBFeWluK2ZVWVAy?= =?utf-8?B?K1dWTVRUTUlXejRMd21XMXhXZkIwemR6Vy84L3BmaWFZb2RObXM4cVFDS3JT?= =?utf-8?B?NGhLUXg3cjB2VXBRRU9xWG5WU3pDMWRkMmlaVnpURHZOVllidk9vRjE2Qzhw?= =?utf-8?B?R2tTajNmOENFcXJHVGd6TWlMOFhxVjhRdzlpTmtrcUF3d1RjTHQ3cUs4UXA4?= =?utf-8?B?RldNYXg5NGZEU3dwYUhuOWdFTjVWelFjU2Q1cDhIQWhQR1duVnJxSkxWZHhC?= =?utf-8?B?cStib1ZicElHWVdRNjZZY0ZscHh6cTN4ZW1yc0FFSUJJRElyZDllMi9VTDBU?= =?utf-8?B?eGRsVHVWWENTUXBEOHQweGNHczk5eURneHl1L2RKTnpkYmtGY29NYnljRllS?= =?utf-8?B?Vk81MnRMOHoyZlQ4RXUxK2tISFpKTU9qZWx2dXlwblRRaVlSbXN5Y2N5YkVC?= =?utf-8?B?eFFDTDg2VnRaTVl3U09ZMW5iZzN2V05lQ3p0cUpwcUZUTkQ4dGFDNEhEZlR5?= =?utf-8?B?SFhXR01NazZZL2VUdkU5S1E2eHZPUUxVcXk2N0UyRGlyZkJZbmY5NDhtc3Z5?= =?utf-8?B?dE5ERGQ4dkNvQXkwVFh4SlRRN2RFMHR6NjAxc0szaDg4OG16TUd1SkdPVit5?= =?utf-8?B?Uk8zSk9OSnpoaHhYSkZwemxXSHJCNWh2eVFqZDZRVzVCUlRSM1ZjWVJ2RjNv?= =?utf-8?B?eHZSYzN4bnhjbU5CaE5KTVJQMlR1cnh6WU85d1dGczNYcHhBWUcraE5QMmxG?= =?utf-8?B?UUtJWlUrSXM3RFJoNDJCL0pkNS9CaWxjMUhTMHJGY3p1U3FUcmd0VkppTEpm?= =?utf-8?B?Zk82OG8wNlN4N3F2K2JJNlNVd3pqbUdhYm4vZC9QWGhnV3IxeWdOcFRwQy91?= =?utf-8?B?RW5VR2V5Wit2WTRFK29VVGNFdGd4WHhUdHpralVEUGRWbUpUejROemw4alF1?= =?utf-8?B?TGJqdmpYN2d0aCtMZDdaM1VsR21BNWo3V0dXYm9YSWtIeHk1cnFwTENIckY2?= =?utf-8?B?WWpHNmVvbWVMSWdsTFBZdzJPeVB0OENHS1BxR245ckZWSnRuc1JhOFNIQWo3?= =?utf-8?B?dW5Ha3ZhVjRnUkpBS1VXZ2EvdnJlUlRjV2V1MDQzVkxldWJsaytyYUxjSDZa?= =?utf-8?B?MjNjSko2UFpaNVJSRzR0V1VOWHRHeExZeUkxRkhDQTRlOW9kT2d4Nm92ZDlj?= =?utf-8?B?YW1IWVJmNGhYTHRjdjFuVC9IN0VlamZHcnJxZHdyeXlnSjViTW1nWnNDbngr?= =?utf-8?B?ZkNnL0J0QzJ3MkorY3NUVnA5WDFPZW1LSks1SnJYWHN5WWNPaS9VZ0dCQVA4?= =?utf-8?B?dW1FSEJsU1FnS3Z2dGxCVmpLRmVicEpJdXgvaVdwanE1cUdsNzQ3dFhOaUpC?= =?utf-8?B?M3NZMEFQVEx6Q1FmTGhqVm9Fa2g2TFh1NHIvSjJkbkxiaVd3SWlrWlhIc2hz?= =?utf-8?B?MVMyaDA2QkJNZW54S3RQUHVjdXg5cDRzSkw2cjBwL3cwdTNvNzkxSllrNnlH?= =?utf-8?B?SUpPdTVMZnpnY1hadm5TdzNzcG8yU0Y2MlRWSWh1US8vcVIrM2ZGZDBrRVhN?= =?utf-8?B?ZHVmZW40TWhWcFFZZk9qYm9TNTVYSlZ4N29ES01tdWdYVVk5QmsxeU1qbW1G?= =?utf-8?B?ZFhrNVdRZmxBSjA4SUxybTF5WjhQVnVaejRteXc1SEJhVGpkVTEvUTBpNktt?= =?utf-8?B?TEhJdFIzZXJNQkxxMThkdTVoVktiZkZZekcwN3pCblM3TFRRNkdzbDJaSDhB?= =?utf-8?B?bzd2WnVkTGgvbHMwWklEWEF6ZzJBPT0=?= X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: cf4f9380-6299-4588-2424-08ddc0618ff5 X-MS-Exchange-CrossTenant-AuthSource: PH0PR02MB7159.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jul 2025 09:59:01.6714 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Er2sOMKihYQjcjOk7/m1qjFP56qE0uJrs6SwlB1VdAmmUVI+nvPenwbCvW/n8Z6qdO9EE9ebliOG8p1sNVhQqeLC9EjhWLNyGfq4fKmzygk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR02MB7918 X-Proofpoint-ORIG-GUID: DUV1IPUWAKKoOZeYmr4crVCfyFyhjRTB X-Proofpoint-GUID: DUV1IPUWAKKoOZeYmr4crVCfyFyhjRTB X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNzExMDA3MCBTYWx0ZWRfXxT1pNbOri/yL QTxKkf76nur9zkbLh4h7/3op9cHYraIX2zOfKN7Rq/mo2F5dX1iPRxNCk8TCucn56Nrag9hyQGq YfzRgG9A1GfLxmMPyQS91XeMzh5VgvGTPzJCqMc9Dn3amOFC+gUalM+6pyfvIo/hikH3y5GAuyy JolVCrPD9saQ1C/w/v8BNd0R9L9IwITnKDB/oqqtWOuhYDO0XJtoD+N7b2eqsCFNlUB9+D9uibb +WKboeu+/uLiWZcFLOK4zX2U2Da7vjnkzDP1nHMI3I6R8QrhFaJSCGBdWXJ1Gs+B1jAegFrqecV ChDtVCX72Oe9o4fYLSrDkJhdrHEY9sR543I5UMCPmMSkpyZKYW5vPN8Ah1taPI/KOsED7iquHoS qnPzcNSk8RYlAM1oK0T6XKH3q1uQQQRaZdKjzKQbiJQ6tLuv90uHq0xYV+H8X0yfGEMzq4hx X-Authority-Analysis: v=2.4 cv=fNg53Yae c=1 sm=1 tr=0 ts=6870e067 cx=c_pps a=uhh9Xr6CjD6FiqEknFfS7A==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Wb1JkmetP80A:10 a=0kUYKlekyDsA:10 a=64Cc0HZtAAAA:8 a=KKAkSRfTAAAA:8 a=XqeNvJXGgvzUN9CD1PIA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.7,FMLib:17.12.80.40 definitions=2025-07-11_03,2025-07-09_01,2025-03-28_01 X-Proofpoint-Spam-Reason: safe Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=148.163.155.12; envelope-from=mark.caveayland@nutanix.com; helo=mx0b-002c1b01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @nutanix.com) X-ZM-MESSAGEID: 1752228037961116600 By definition PCI can never be enabled on an isapc machine so hardcode the = relevant values set via pcmc->pci_enabled. Signed-off-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- hw/i386/pc_piix.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index 59c2949379..8277aaef1c 100644 --- a/hw/i386/pc_piix.c +++ b/hw/i386/pc_piix.c @@ -474,7 +474,7 @@ static void pc_init_isa(MachineState *machine) } } =20 - gsi_state =3D pc_gsi_create(&x86ms->gsi, pcmc->pci_enabled); + gsi_state =3D pc_gsi_create(&x86ms->gsi, false); =20 isa_bus =3D isa_bus_new(NULL, system_memory, system_io, &error_abort); @@ -495,7 +495,7 @@ static void pc_init_isa(MachineState *machine) x86_register_ferr_irq(x86ms->gsi[13]); } =20 - pc_vga_init(isa_bus, pcmc->pci_enabled ? pcms->pcibus : NULL); + pc_vga_init(isa_bus, NULL); =20 /* init basic PC hardware */ pc_basic_device_init(pcms, isa_bus, x86ms->gsi, x86ms->rtc, --=20 2.43.0 From nobody Tue Dec 16 21:11:18 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass(p=none dis=none) header.from=nutanix.com ARC-Seal: i=2; a=rsa-sha256; t=1752228009; cv=pass; d=zohomail.com; s=zohoarc; b=SJ25FLg1Uzch0cvBoVJYD8USB5vfGsk2TMyDZLwtBlrtvYFQN0ySpEgKeBPbgCFbshHQA2zmd+4Sj0GRq1Yai9qOo3KgmSu7C8n0Dc9V/ygvlSDmJOtLa7LB0iC2+/vbMKsvwgdJGYub6s5ctbWhAJyS1zdJKK6Ji1/SwD50Gpc= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1752228009; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=Gc9uDzoGYC3VSV7gw+vOn+Dzi5l/V/ZfVf35082tLLI=; b=gBRhQ0DM8Sn5tp8Wa2O0sYSl0SuR1OEbdRdI6X1usq5LYv+jGkRu4WC6NPXd04tCDISrMh5aefkF+aV0bnoDkMsVkiwvzBrdShhjco3QlNPrDhf+ONsbCqGdnWe6x4sTfM25rgthaoONlK6mP9SRBwUl6vtHGHsLRMg/OSt7Zwg= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1752228009580801.2110936561079; Fri, 11 Jul 2025 03:00:09 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uaAXS-0006gU-VO; Fri, 11 Jul 2025 05:59:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uaAXA-0006Lr-6w for qemu-devel@nongnu.org; Fri, 11 Jul 2025 05:59:12 -0400 Received: from mx0b-002c1b01.pphosted.com ([148.163.155.12]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uaAX8-0004uQ-5r for qemu-devel@nongnu.org; Fri, 11 Jul 2025 05:59:11 -0400 Received: from pps.filterd (m0127843.ppops.net [127.0.0.1]) by mx0b-002c1b01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 56B7U4qn016883; Fri, 11 Jul 2025 02:59:08 -0700 Received: from nam11-co1-obe.outbound.protection.outlook.com (mail-co1nam11on2135.outbound.protection.outlook.com [40.107.220.135]) by mx0b-002c1b01.pphosted.com (PPS) with ESMTPS id 47ta49k6ee-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 11 Jul 2025 02:59:08 -0700 (PDT) Received: from PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) by BN0PR02MB7918.namprd02.prod.outlook.com (2603:10b6:408:161::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8922.25; Fri, 11 Jul 2025 09:59:06 +0000 Received: from PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88]) by PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88%5]) with mapi id 15.20.8901.028; Fri, 11 Jul 2025 09:59:05 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint20171006; bh=Gc9uDzoGYC3VSV7gw+vOn+Dzi5l/V/ZfVf35082tL LI=; b=L+XZMz0DCtKSZuY8mMhTc88y72xwNHZiQVGA8WYra+ZYhTwq0mLd+HTEF oDm6qkAxRTr2yux4MjhcphNT0IFgrif6xB7J0bmuefhY6Me0lR8K7AB+lTUDKK7P HS7Sd0D1fs5NcaXv92CZfRDlwpcHFv2MkZ+yxFM3XGwFSctb0MGAm4wc3tIcqcvr dYBvmNDQl33HE0hLXBHNticNvMReT+q+5gu6TUPgQboP68YMFG8QUTrnZuphUZQr f0MvwjJh7SapZJu9DDbASeazvsTjkT7Vc90FDy7P25FwelLlZubS7GtWJuP+RiTP iDFH/ah31Ceh2nqzUwuayZCVHd5qQ== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=nBAZTfmoDPUekQ91TIeiUQbBqeGMZnnmp7/1cn2qqD+lOQqf8KvBZv+cICPsX2GXuFmPAqRB78+9IKZNmud6WtoiOoQmlcy56xKoQIHzNIQQ1DQY3Jvw6H3qT6AsWbiksXx9wtUtP+SxfGnoUKrp0blcijUIO9Sp3ANXLOq/1vDWUTwFOUHpn9Lhxt+/skeuhrSqq21UQk7w+Nr8vYsatWoNJERWJ8eQT08BQR6xQ/+jm9ZuDSZdNIgU1yIEMn52RJAsrGkWJHnUfm0ied6rN6FPkBTXGwQM6M96Rw+sdT5pR6Z+A5Mesrt0O+19SM9znV8eb8fzCZkUtLc+voCAKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Gc9uDzoGYC3VSV7gw+vOn+Dzi5l/V/ZfVf35082tLLI=; b=aIISmP3ZS1WJeGU7qJRtDdg6+E1i/CaCOePWLywTes9dC7IxDEZ47O0SVI2y99Gw79DGz9qmMGoxVzKm0QqQ8326071OojrXZ9kXWjZPWr8kyCTvSCcn71f3H6DnJ5Zo59AeYviPZusFaysZEAGgK7gnTX12rz60eHesCeICX9CciKHr/ika9puYi3/iCBI+cHVGICfjbGbvf3+5oH3vTuiuh9WWPFpZ138YO2f/AeG08Uq+LQVs5hxYLjK6u98ttu9B6NdtFADANNns/Ru7hEERttsHNzoFmRi8iGczX3hmwSQorfQ9E7SR0FOHay4/ZIoqZTtGIOFnNBoix2bcsg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Gc9uDzoGYC3VSV7gw+vOn+Dzi5l/V/ZfVf35082tLLI=; b=V6MyUvQZnvbMuGZithQUzSxAbekTEH/Lx2QEv4+/Cpp+CZ5YwMUiqUCoVx1MnkLi+nTnyQs21UNfwphY+iPlOcUzLoSgAPYpCAkZF1SYdZJPXZhDcBxG3etNUgsxC3OT1Cyx02S+xd9E3F8D91Jq0ZCNUIEjQhP9d0mTPkRqpWKrN91p7LvNK1W9lD8r7guAO7d3QOGnZTxN4AQScRexnMv9rKRFvw+UNZfHbSehE4Rxu2FiUHUn1LfULOwmwjYL/uSqsao0bqUnqTFySuuUX4m+MDsUZOMWEOy0YOS8qON97YGIgm3hf3jdAyN8ZaU82ayemWoV6p+lF3FEwKA09g== From: Mark Cave-Ayland To: pbonzini@redhat.com, mst@redhat.com, marcel.apfelbaum@gmail.com, eduardo@habkost.net, imammedo@redhat.com, qemu-devel@nongnu.org Subject: [PATCH v5 14/19] hw/i386/pc_piix.c: hardcode pcms->pci_bus to NULL in pc_init_isa() Date: Fri, 11 Jul 2025 10:57:16 +0100 Message-ID: <20250711095812.543857-15-mark.caveayland@nutanix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250711095812.543857-1-mark.caveayland@nutanix.com> References: <20250711095812.543857-1-mark.caveayland@nutanix.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: LO6P123CA0039.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:2fe::19) To PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR02MB7159:EE_|BN0PR02MB7918:EE_ X-MS-Office365-Filtering-Correlation-Id: 7755bcc0-486b-4d40-1009-08ddc06191fa x-proofpoint-crosstenant: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|376014|1800799024|366016|10070799003; X-Microsoft-Antispam-Message-Info: =?utf-8?B?V2hZZnNTd0s2amFuQ2hjcXg5cGlhUndSSm1ncjBWNy9sRXBaNmJXZ1RyN2Vm?= =?utf-8?B?U3hmdFAzZ2Zad0xHbDZzNnpTZ0JhOWFpWFYwWjFuZUgzOHgySnVqcVQwL1RV?= =?utf-8?B?eDJXcHE2cFNHYnBtZjRaM2FHRXQ1ZTFnRG5aUCtkSExBL0ZiSmZJckxyVkVX?= =?utf-8?B?TEsxYmVvQUJVeVJmZUxjK1p5NTVidDd4RW1GaHpwNk9ocGlGVy8vYmJxSUtw?= =?utf-8?B?WG5vY1phZE5MSWlWYnVpdFBNUUk5b3VwV3MrbFBIUGNkdG1aSVd4RHBoVlg3?= =?utf-8?B?My8xTFc3dUpvbmZDQ0puSEdRODY4TVZHTE5sdG81WmdIWkk0K09EcjM1WS9a?= =?utf-8?B?bGM3N2VLUnhPU2lRME5Hd2h3L1RCRHVLbjB5L0tKcm1tUVRlRTVMbGQ2aHRD?= =?utf-8?B?eksrSTYxSVZXczIvc2Y2b29ab3BqV1RMRndiRW0xbUY3OVBMVHZ2MjdwSFA3?= =?utf-8?B?VWtLS2RHYWZWejlPSCsvWUFjcnRncXRDS3dkMnl2c1dGRTRUNmJTOGlvNUFE?= =?utf-8?B?L3M1bDRSWGdYQXlDOVZUdXFJSGNsNFBrazkrMXRNcGtNUlpSQTZ5NEVrZ1dL?= =?utf-8?B?alZZMlF6cjlRSUNab3E3L3ZzUVNjeWdwSGFwcnlJWXNTWkR0MVpFT3RYS2t2?= =?utf-8?B?RkRDT3lvdXpZSXVyVmllSUdvM0JKWG5ZL0N0Y20wUUZFblFkM3ZUS2JtQy9v?= =?utf-8?B?bHhxR2QxWjIzcTNVdE5NaEVucGd3Z0tPMzQ5emk5QjRtVUJSMlpLb0x0ODBL?= =?utf-8?B?bWFlNW01WXpIOXMzZ3NlbDBPRDNDbk92azNVRGpZL2Y3UHR3KzB6WnRwZXdV?= =?utf-8?B?NkpJQWxZbmQ4UkpYNS9TWmxXQTM1eUR3bStmWWJ2Uk56UE5MN2hzaHZ6T1gw?= =?utf-8?B?V2ppL1B5bUkvYUlFUHZTV1M0R3c4ZDh4cXIvZE0wT0hyR016ZzMzY3JMckVp?= =?utf-8?B?RzZrZmpNcENtYjJjNXhUN3ZTTzBHQUp3QjJXTHgyWWZoZ3M4czdKRTlSYzFr?= =?utf-8?B?a3d1elJNcG5EdWU3ZUlNU2tBZzBEZHZuUmR1M1g0ZHZ0NW1XampVa3A3ei94?= =?utf-8?B?SXBQYkRYZ1dwMXQySzI2Z3M5aGpnS2hoVkxBNlIwdEJCenNvRUMrbmdyNjNU?= =?utf-8?B?UHJOZUVuMDQ4UkMyYnF4ZjljazhNSzAzZy9xV2R2Z3RKNDh3VDFHd0VCeUJE?= =?utf-8?B?bXMvMTB4cXJ0WHVRU3E2WGVXdkRKOG5WbllLenpyOThtbXVIYnBEd0RXNnRE?= =?utf-8?B?Y1NVY3hmTzMvczgzSFdaekJGTVdGQXVkdTB2SFBXRHdpN29OdTlkNXNEdnh3?= =?utf-8?B?RG1FTllHcm80Y2pHdmsxNUV3ZGZsbDBsd3I5LzROTUpJb0VHejllR0c1M0xm?= =?utf-8?B?cEhCNHNBTHNjUzcwcmdOMS9JY3U3aEswVzlXbGRmOHpvZnJ5WlB4QjVMZzVW?= =?utf-8?B?MDRmZ043TTloVWx1cVFjWmtkWnIzSmFjQ2YrazM3eDNZdisrM2VsQ1lrSTN1?= =?utf-8?B?NnhvSCtEbUZQZW1CYklGbXJCTC9VT0VSZytBeHNOZ1lJV1JRdXFMbUlHdlQ2?= =?utf-8?B?dGpEM0tOWWtvcVJINVNBL1dwaTlPME50NGRYUDVZenBpdVhpVExQdHNtVEJB?= =?utf-8?B?TTVodjNRNUR0Z2M5cE5aM1RJNHQ2d1N5bURLakNrZmlxZ0FzOEsreFdlc3V5?= =?utf-8?B?cVAwM1FUOHhJd0h6NW9JelB4K01TLzV0YlJZR3locm8ra2hFZC9KQ2JUWkZV?= =?utf-8?B?U0RWN2ppZjVERlRlQ09qY29LYlBjaE45RTViTTJTblpwaTY0WGtFTjZaL09K?= =?utf-8?B?b01GNHZ1RG5JNkYrRTUyKzN2Wjg2SmZCRjF3S3U2Rk9nZEh2M2lScWxqZlZx?= =?utf-8?B?ZHZhNkk3QTRtbklaSTJkQVNIaWVCQkNoZVVmQ0dKL3MrbHRhR1djdmt2SWNQ?= =?utf-8?Q?/QBIo85UCRc=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR02MB7159.namprd02.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(1800799024)(366016)(10070799003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RU1FMG5jY3Z6dHNTb04xVjR3ZGRjVm0rTHMyaVZCWXNGZjY0MERtaUNNVlVJ?= =?utf-8?B?NzhsVTNCZDRyMXV2S2g4VUVuS3BGSnJCcmN0WHp2RDBtVWJRQXVtSmxFNDJ3?= =?utf-8?B?NUlZOEN1L0hWbE1xd093WitlZDhqcW4rZXhKYVZtOFZwWFdodFoxQWhqbU10?= =?utf-8?B?cWYzeWozZy8yU2VGbjlNaHhRUVM1UmZkNDBSSzVoQ2hDZlVjdDd5R2FBY3dt?= =?utf-8?B?REUwd1pQL3h4U0ZKR3NXVGhzZDZhVGVNVHVaSll3ZXcySXNzdWR3RldNZ2M4?= =?utf-8?B?QTM3VGlKWDN3Wk1OT3B1TmZKOTZNYWVwNmdiSzUyRm1HYzhGd2ZQalhRaEl0?= =?utf-8?B?U3FaU1AzTk5rRlNxWDkrWDZhekJxSnZyUXhIYXhrSzZua0NkSnBUaDJCSC9Y?= =?utf-8?B?VUNGQ2EvUkY2SVdnZWFxRUVFc3lWL2MxV2IrMzVQVzBPV1JrYitiOWttaDlm?= =?utf-8?B?T2dBbFVJcURRUUpWSlUzV01raytyZFdPOU9VZ1ZmbjhKMHhOMm9kV2diR0ls?= =?utf-8?B?UjFaSDkxb0hLOXg2dFEyVE4yQzZJanpqSG10cU9MQVJzTFVBNGgzRUlvcW5F?= =?utf-8?B?SlVTcCszZ1p0RGx1ZUpVaVIzY2V2c3ZieXIyRjBxSXM2WXhCNHlNQitHQ21H?= =?utf-8?B?ZU9pQ0djcmh0bGF0bk5QU0ZCZW93VkFTNm5lMlA1aVlZVTh6WWp0cTJBTTlv?= =?utf-8?B?VldGb21YWE5BM2l3YjF5MEx5bVlaT3h2ODZsSkNFV0c5dlNoeGlKK3hOVjd4?= =?utf-8?B?QVlJdXdjOUpZODByeElGUXYyS2hxQ09PM3ByYU9WN0JESlVsanZ4T01ReGVK?= =?utf-8?B?YTNiWW5uODd1TWZBcWx0OGRDOGl4M0JKTWgrSUN3NTN1YW56ZE43SldKYkt1?= =?utf-8?B?SGEydFdySzIxdlE1Q0xBMk93dmZNT3ZBWmhzTXpuVE04MTcxSjFpK2NvS2xo?= =?utf-8?B?aEk2WENSZnhpclZjaVVHR1FRcDVBWEVCNW9kZWxJMVZTQng0NC9iSzErOG1S?= =?utf-8?B?TmhCZEJwSi9tcDQwa2praVdSYmxSZUJOYmFvMXVWK1hNczlENTdBQW9paFZY?= =?utf-8?B?aHhsbFVlUTVYYlVITUdnSWlWUEN5YStMR0VOWUVaay9QcjJtRW9TcGlpUmVp?= =?utf-8?B?aG82N2lJMDcyZ1drMFRyaHJRdUI5eCtYdFEvSUVxbkFuVFkwSVpzZ3F4Yjk5?= =?utf-8?B?SlM2K0UyaWZKeERwU1Q4WWV5ajBtdDE3eUpBSTRTMHFUSVdGd3RKWlB5aURz?= =?utf-8?B?c0N6bnJmV3FxVS9uRjdxK0Q0UlJhdkNxV0xuSmNxUFJHRjdDVU9JTmxDWjZG?= =?utf-8?B?WTVaY3p5SmFRSlJsaFc4RUxzRWhOZFh1bkhmSm9Yc29lNStkS0Zmd1hCT0hQ?= =?utf-8?B?ajJIYXpMRFpGRXhiK2xuQlBDaEk2U2pnK3BaQlRLMXUzV0FsUUUwaVdabWox?= =?utf-8?B?elZCcXUxdTA0ZEZlMU9XU1d6ZktuOHl6dHpVTUlhampJTncyR0ZkdVZrOVRD?= =?utf-8?B?QWJjWmFsSm1Ld2lJWjVueVdZRVZ1UzdEaTFsNWIyZUZ4aWpsakxMZ0RBM3hz?= =?utf-8?B?MndjWFFhT3FyNmVIZUh2eVlXb21hS2NRZ3YvckJIZUxjTGIxTG8yV0dEc3Rl?= =?utf-8?B?S3NrRFJQSGZoMjBLWHJzZ2pWdDJKcmNEQ0J4cWpzRTJEdFUwYVV6M28wQko0?= =?utf-8?B?MkszWTM0UTFOVjgrZCtWemxwbklEQlZVRWFRRU81MXlEN2xub2dxUlFxMENy?= =?utf-8?B?OFVQSzZvejZOTDNoWTFaMkpZNGFualNvVUQ1SmpFbmM3MEFaNGRHRTBoenRC?= =?utf-8?B?eFZ0VnJVa3NQV1FiaW56VTdERm5QZVVmajBIeHhLaVU5RXppNjErek1tYXBi?= =?utf-8?B?N2ZDWkdJWCthTjNFdTF3N2k1aXZSVU9BMEtES3hybFdxSHhyemxJUiswM0VU?= =?utf-8?B?ajU5MGFOdXJtYmhrb2tkUUFnRVNFcnBPSGNuL005Wm1INExYUmxiQmtjNE04?= =?utf-8?B?K3JObERpVnJhYy9lbEhKbGUwakdKK21OYlNuRFlmbkpoWGw2MDJaSHBRK2Jo?= =?utf-8?B?VFFKeVRISUNDcDU5Z2U5bjJrVlhKOGtZbU9nM2Z5NXJwU2NGQnhjMDRGSTJs?= =?utf-8?B?dUtuallHbDZYZVozZHE5MnY1dTRrTDdrbzlGendIM3QxaWxPZGs4MDgwclpt?= =?utf-8?B?MG9USWZ0SUw4WU5aVE5YQzJoMFNlZkQ4ZFNkMHZzU0FUamErcW5WaXdJTDRK?= =?utf-8?B?UzdueHZPUGxDQXFvNThLaGUxQ1ZBPT0=?= X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7755bcc0-486b-4d40-1009-08ddc06191fa X-MS-Exchange-CrossTenant-AuthSource: PH0PR02MB7159.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jul 2025 09:59:05.0750 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +JemeSdZAANG39rPxPE7OM5yMxuEzLEhfAhY6yeJdz5v87+5Wb0txvdXX4znTWE32oSmCXsRaJiLDNmJC25pEeOxPsDGvOQkDqy8RmnNXOI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR02MB7918 X-Proofpoint-ORIG-GUID: App1hqPG40xkWSTtfVfn3E9YpCfYK_8b X-Proofpoint-GUID: App1hqPG40xkWSTtfVfn3E9YpCfYK_8b X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNzExMDA3MCBTYWx0ZWRfX+Sn/KXEmstBB UQ4ydPBO5vp4gL3bLSn8E5B4s7+V1AC/PH01PtWPPGLTVF4SKxaaANYJT1FUC9ToUFwHl487uAJ bvS6y0nA2/S6dR56lmoXMf1K3GcZn+xXzkyyqbBS6vZDNi/3LYN6JrXeYmVLRlH0hZI5QTL4u5y R21yzsYmCTsS0R6efnO974NT7uexG2q0GQ22dcTHR88AWW8ykDELy1aZMdf+2lONs5jaKdFRist Mgv2Yh7ym+i4gmHeYdQ4WI8yO1avMKhzvmMy59IpHf4cbu6sPp+4yKYtptRgGHtQ06wsoWT9ZKv /bfbQfydebbhioLL13v9qPM+sNmceYUHOpXfRcx+apvLg+zT9tsa/pJeLMJyMUCo4TcYU/z2zNh pIh3IXbgrSKi9eOTEjwAt/dHpOg38ptfaVmAhERg67pPZPOx9hAez2vy5clQna3vMKVhlshV X-Authority-Analysis: v=2.4 cv=fNg53Yae c=1 sm=1 tr=0 ts=6870e06c cx=c_pps a=lnUO1cdkCGsLc4nFgqdZCg==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Wb1JkmetP80A:10 a=0kUYKlekyDsA:10 a=64Cc0HZtAAAA:8 a=KKAkSRfTAAAA:8 a=m4-MuDShih0a2sssyXkA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.7,FMLib:17.12.80.40 definitions=2025-07-11_03,2025-07-09_01,2025-03-28_01 X-Proofpoint-Spam-Reason: safe Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=148.163.155.12; envelope-from=mark.caveayland@nutanix.com; helo=mx0b-002c1b01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @nutanix.com) X-ZM-MESSAGEID: 1752228011394116600 By definition PCI can never be enabled on an isapc machine so hardcode the = PCIBus argument of pc_nic_init() to NULL. Signed-off-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- hw/i386/pc_piix.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index 8277aaef1c..f6cd1e728d 100644 --- a/hw/i386/pc_piix.c +++ b/hw/i386/pc_piix.c @@ -501,7 +501,7 @@ static void pc_init_isa(MachineState *machine) pc_basic_device_init(pcms, isa_bus, x86ms->gsi, x86ms->rtc, !MACHINE_CLASS(pcmc)->no_floppy, 0x4); =20 - pc_nic_init(pcmc, isa_bus, pcms->pcibus); + pc_nic_init(pcmc, isa_bus, NULL); =20 ide_drive_get(hd, ARRAY_SIZE(hd)); for (i =3D 0; i < MAX_IDE_BUS; i++) { --=20 2.43.0 From nobody Tue Dec 16 21:11:18 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass(p=none dis=none) header.from=nutanix.com ARC-Seal: i=2; a=rsa-sha256; t=1752228148; cv=pass; d=zohomail.com; s=zohoarc; b=TWS73iP8zNp+IPAdfmqR7+BPA+hcgJKthCZYGnoQdIVIPdXm+IPOcxJ99IkkjgOO8UXGlOvb5zFsOovFu91FCySY8rZCkp9thLMnUR3hCgzdsCqZowayzybygUUobhObNOQ6UFD2lw7vK8Be+A/6Kt/rxErXpBfw8+22wAjXiao= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1752228148; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=QiuB1IQfLQsR7Ew4F/luinvFpG6kD8CgLkb+jvrokAQ=; b=MlAOlXUDpBpHQH7d5syYAovAwu4j8p5jxcYOZ5HHLFDYbqWfGjHxkvZazbY3lgXA45OI6IyjVo/YE8RAA1LPjHmaJ/ueoVwiJ7WGXLlSlhdTUEDgrWhE9gMNxs+vgiFH3HnmrfRElws3btyGAfWg+/EctGlIgyfw8+8YdiheF4E= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1752228148878562.9189490101357; Fri, 11 Jul 2025 03:02:28 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uaAXb-0006mK-6G; Fri, 11 Jul 2025 05:59:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uaAXD-0006W1-SC for qemu-devel@nongnu.org; Fri, 11 Jul 2025 05:59:26 -0400 Received: from mx0b-002c1b01.pphosted.com ([148.163.155.12]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uaAXA-0004uy-2H for qemu-devel@nongnu.org; Fri, 11 Jul 2025 05:59:14 -0400 Received: from pps.filterd (m0127844.ppops.net [127.0.0.1]) by mx0b-002c1b01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 56B86Fmk032629; Fri, 11 Jul 2025 02:59:10 -0700 Received: from nam04-dm6-obe.outbound.protection.outlook.com (mail-dm6nam04on2123.outbound.protection.outlook.com [40.107.102.123]) by mx0b-002c1b01.pphosted.com (PPS) with ESMTPS id 47q3k38m43-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 11 Jul 2025 02:59:10 -0700 (PDT) Received: from PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) by BN0PR02MB7918.namprd02.prod.outlook.com (2603:10b6:408:161::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8922.25; Fri, 11 Jul 2025 09:59:08 +0000 Received: from PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88]) by PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88%5]) with mapi id 15.20.8901.028; Fri, 11 Jul 2025 09:59:08 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint20171006; bh=QiuB1IQfLQsR7Ew4F/luinvFpG6kD8CgLkb+jvrok AQ=; b=pzcU5xLywRbmUntbS3s1YXU6nJLnxcYJxcG/393H/TXaq8YFZU2D+SvvG ks0lq5XNY7aw4l1EIlCu/Kg+ottI/cBt4Q2XeTr8n4aozpjJ6mKF2F7Dj0beOGJ8 Rw0GehXNr3Xr0d/Te1YR/tF5Lk+34jjrePhRK2rOuLc6Cr8bA+R6eHLdcl76bxYQ rT/dWzwa16nUDthLiPxb0nfKFEgerhfyVYYKwNvWjliemx97cXhD79kI9ly0Zwcw Y+zTeNAHuYMSrsIicZciuUk+h7fVPktvW3mTkrQxrLmOi7PmwUTjjY1x5Za/obUB ffShS1V5WaLCj1JOnu2EENy3n4uZQ== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=N9yH3QE6sdhXjA+RODK1fDey9/5Nxzx/h+9tfxvyRWCSx+vE+mJxhCasGEiVdEjJ6J6neFZNWrO8NbA0BeLu46x+AHF1iaaldRjVueX0WmHj3IJbIYvo0hWTG0kk5hDke0wl2hNsrk8o+r3mRACGa8N6rw8Q5va5+Esmepv5G6gFrvWD1gATgngAfw8ZDk0Zo4YZzKcQnwu+yKGhjxfpWM/a6HW7xn0IYqHoAd3LU+RP5fBMErnZ2XIEW2Gc1eGrQ3OAgCeyg3tURZ/1oFIXkAqHGdJ4vUdDDggg8VQkIiIgjrj4ahFNX11nBJ1LN2eEcFrkRtBAto3vLI+AhTD15g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QiuB1IQfLQsR7Ew4F/luinvFpG6kD8CgLkb+jvrokAQ=; b=lbpVeiEQF+CUohr3bGD5aNT+E98OtL4fTr0PgNTxCGuLqT/M7uyi/gWVwvjb5DZFUepGBrs2LoJaRY+2kbv1YQnyGfSM+HBJawFR5NFjyjrHeyVW8oJP3gnWSYYJh4KfooHejlGwWxPaCNDtmHsOz76N+uUQQ/2FhY0+48SEcRrWdM2cB/kJ5Uo1sStA30NfWW//ob3UR/19MQhvYpWJbq5MsY61XUvqgz13qYY9uEO8lNFsJ8xAeBRq9fV/B908pi397LnJ48rbjt7UoSJ9Vsu3uGwS8bioWZ3drz5KJFfIOzf8IrFlQEMJgR66JbSBwVp/rLn9h7BEg4HeHLvuUw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QiuB1IQfLQsR7Ew4F/luinvFpG6kD8CgLkb+jvrokAQ=; b=nz0RnRP+QcWiWBTjdi6APbBCRnm6mfuqCYHX4HSgbagwYVQME7Ladeu8/OZP6a3TNOk4xjaCjMb64o+ElfS1hBdrxz0kQWks08HEqrFq7vH92n7oWRGLvw0WLZz0cs62B2//IqV7B5DZPLb39AaPe8qyLsbCSFDPKmL1A070df2Lzc12EYLC/gUjY5CGSp7JluhJjpcuv8fkOafblNIcy5bjrXjeSVpnf5o0tBs+Re4YLgZGsnse9mGP65I45O7BMNaFXPJT6Yp23g6QOQUXf0kPv+m9bJp3RSJTvNhI82S/Y5hRbAb8A/6zhGLkYbB/7TceLhJTGb8pX6+rWqcC6A== From: Mark Cave-Ayland To: pbonzini@redhat.com, mst@redhat.com, marcel.apfelbaum@gmail.com, eduardo@habkost.net, imammedo@redhat.com, qemu-devel@nongnu.org Subject: [PATCH v5 15/19] hw/i386/pc_piix.c: assume pcmc->pci_enabled is always true in pc_init1() Date: Fri, 11 Jul 2025 10:57:17 +0100 Message-ID: <20250711095812.543857-16-mark.caveayland@nutanix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250711095812.543857-1-mark.caveayland@nutanix.com> References: <20250711095812.543857-1-mark.caveayland@nutanix.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: LO2P265CA0414.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a0::18) To PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR02MB7159:EE_|BN0PR02MB7918:EE_ X-MS-Office365-Filtering-Correlation-Id: 04710141-c42a-40a0-9c95-08ddc06193f8 x-proofpoint-crosstenant: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|376014|1800799024|366016|10070799003; X-Microsoft-Antispam-Message-Info: =?utf-8?B?RFFnUmN5Z1BDeFMzUzhFNzNqYjFYczFXb1BBTXpkUk4xWW9NdTFaWGNTcEYv?= =?utf-8?B?OW5GNldxbXlmK3BaL2V0MTNzQTBVSzlxczRDOHZUeEZHVkNrWVlGdzVaTUhB?= =?utf-8?B?eU9BMktXdkQzdDBoWjVtMkNWdnY5eTlYQUVMd3FqcExEQllYcE1RVlYrT1Bp?= =?utf-8?B?d0dPR1ozYlRoTlNTclBEdFlzNUdjQkduQ1kvSjBPQmRUZ21HNHJUUFdnekw0?= =?utf-8?B?SDJJUUxlbWFOeUtnUUIxdFFlamVpemJ5WnZvWEpLTFFmbTIzSXpjdDF5cWU5?= =?utf-8?B?NWdkWGtJdHlxakg4Y240ZmdOQ0t6RThkeE9WeUl0OEhRVVo2Mk85UWhCeDkv?= =?utf-8?B?RU9ncnowSEl2RnZKb011L2xqc0xmSnJUUktuajcwZUtWOCthS0x4T0p2UVNV?= =?utf-8?B?WVMyRzY2K05QRWM4Wm5mUC9vZ3FDbng5eVF4di9xUVVaczNOeVJ3WTZJZEVS?= =?utf-8?B?eU5BUnROYm5MUE54b1d6YVAxQkRXcSt0UjkraWZUVmZSUWxWZnYrTmpYM1BC?= =?utf-8?B?ODRkcTBFM091clFIQ2ZycFR6eDhiaGxTamo0Y2JwY29YbCtHdE5GanJLZUVl?= =?utf-8?B?SnVBcXJsVnlSTCswZU1udFd6RlhWTDl3b0RkcmdsZ012VU1lSlR3UkZEK1ND?= =?utf-8?B?cElQQk00RWNxVkZZSEFhQWNQZmtwYUlrbEMzZTRTSTJLYjNZUUt5aXJYRVhv?= =?utf-8?B?MlB5WTVqUHFPV2Ztd01EUjRid09Uak9pVDZoZ2xrMEtrbU5wdU8xWDQxYUk4?= =?utf-8?B?YUk1YlVFSElwcnRsQVlSUGJxYVQ3Mm9hSmlHTTgrRTNkRGRCakFlS0JURksw?= =?utf-8?B?VVoyU3JzOEZiNkNQdEEwam1IaTFqRFhDV1RaNGVld05TcHlGdGsySmVBTHVy?= =?utf-8?B?QVJsQXU0WWs0RXl3NkprKzdyVWRZUnFyMFd2d1lHRGhxbktVeWdWWGZSRVdh?= =?utf-8?B?cHhQWVVpK28wVWo5MUM0VmQ4NWRQV3RkM3A1RjlOMFVBNEltL081TEU4QlVp?= =?utf-8?B?eStyczZtQkRpVlRSaUgwWUJtREFRK3dNTDdxYzVnTjBDN1RrMU1vZExnNnpY?= =?utf-8?B?ME56UEpjVU9jOERORHZ6SktzTmR5ckE0VU9vUXpCTFhYd0xHcGZtUEJOUnlB?= =?utf-8?B?dUhyUllZcll6MzdxT3Rzem1rb00zaWlQWmRPZFBYWFhtdXhWMFdiZXA5QTZj?= =?utf-8?B?MWJXTmFxcjE1QnpONFZmSHpBbVFGZ3prc1NVbi96L1BOa2Z0Tm1UbmNkNGlC?= =?utf-8?B?RHp4cytNek5CbkN1dXczYWwzdDh2VDBSNzZZZnJKM0F5WUtOVTgzaThrWm50?= =?utf-8?B?V3lQZlNmWUpXQWUrV2REWTFlOGdxNCsxQTFzL0Nrem1kMXdVOEJDR1ZsRWZs?= =?utf-8?B?K3kyVGViSHhPRVBEVnAycFA1bWswM1IxUjlNUjc5U3dNSkVnRGZXZGN3TVVo?= =?utf-8?B?OXZHWW40aHBhNldEK05RaEpZZ0E5Y3lhVm9jdzQvVTQyRVhDc3ozOG52ejU0?= =?utf-8?B?blgzYVFweGFiQjBCY0h6NmtDek0rVk5HQk1DQ1lkbEFGcmFRN1QxZSs0L1Fi?= =?utf-8?B?NjB3WjlwUmJjWHYxTGtKaGlIUm5HRTdvZWpyWDRnTlJyZFVKVVZEYVBwMnJi?= =?utf-8?B?QXhPYnpQbDZURmVQTk9IQjJYbzA2NkJVSVNxdk9NTXJHNEZhL2dCaEdmRnNv?= =?utf-8?B?OVc4TE9rMXVDZ2k1NXBDUU1zWnBYYWpJVkszOU4xNzU0L01JUE1YNGMzUjBV?= =?utf-8?B?bWt0cWFLNERuZmo1OXU3QzREQnZXdVZRYmdYNXFRazBUeCtDUkZhcVAwRStx?= =?utf-8?B?cmhiUnRhSkpUL1B5UG5tT3JseW13R2hmSFQxdU56Ny9qdU1ZYm5YRklQSzlP?= =?utf-8?B?enVTU3I2YUU5V2FSSm9hdU8zQzBnckoxMWYxMFVYa28rVmJsOVJ3NGFlOURp?= =?utf-8?Q?G7MVepJ/xQA=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR02MB7159.namprd02.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(1800799024)(366016)(10070799003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?T1VXak8wekNtaXRMeGRuQTVvODlkalBUeTJSUW9PMmxaeFQzM0ZQb0dlQ0sy?= =?utf-8?B?aEY0RVV2ZVpaTmc2akNvbWNHUjhWV09XdXhBQmlEUG00dG5pOVdKcWppQzFV?= =?utf-8?B?ZWpoRWZXK0pHeE9RV0pUbjlJdzd3ZG9lelhucUpTNVNocGZIWWtyYVJNUHhC?= =?utf-8?B?VWl5aGpNYlZvUWlXOGV5dXVvek5MbHo1akZwcWhGZ2huMlZ3enVDeS8yUzdC?= =?utf-8?B?ak5sYmFzbDZYS0pBSUh2TERYOXp0ZHloZHc1VmRTcmc1T29JWUY1aWRYeVJW?= =?utf-8?B?MXVldGRldWlNZHpGVHFqZEY0MUx0TkZJMnduMVQrakJkS1g1cEMwMkJwRU4x?= =?utf-8?B?TjhuaHVwdkRSdll5dlp6UUdveVpvcGNnaGY5bTBEeWQvWnl3N0Y0ck5zL0Nk?= =?utf-8?B?eGZLbGVtNzlvQldOczVpbVhrRmZZb2ZZN1pNNDBSbXRzSmV2dFhMSzBKc29h?= =?utf-8?B?bHhTZWFHTFRXM0tiV001UHlVUGlxZHY0blYxeTdBemYwT0ZYbWVIVkpKMDI1?= =?utf-8?B?VjJxMUhLNFNCVVJRWGg5VHkwNDRCUW1TU1l3Z0J3NVVoS1ZETFNiMmw1Wm9a?= =?utf-8?B?Mm8rSzAyaUJERkhFVG0rN0tDalY3dFN0ZGhObTByemVoSlZlcGc0MmlwRXRC?= =?utf-8?B?WEduNVdFSlZNWjRTYWZzcXdHeXloczNNRTREekJrdnBKTEhrU3dEOG0vWUgw?= =?utf-8?B?QUVLcjJuOHJ0UkZBa2d3eEwrT2JlVDNkczRLU2NSb2grdDdPb2JrVDBXZFdU?= =?utf-8?B?ZFJxS0xLcjMyM2VwV25wbWFrbktXWDBmYTEzOE02YVVCL2JwMFdCOXJJemg2?= =?utf-8?B?VnBRNHZxZkVqMXpWQjRJOXIyOTBGc1hjVHJWN1I4bVRrZzROTEhYeWhWZ2ZI?= =?utf-8?B?VkNWWnRPZWdqZElkZVcydFVJQzNZMWk0RUwzaVlSYS83c3Q0d0R0dnJUek5a?= =?utf-8?B?Vmk1Uit5QkZ0N1ErK1h6andIN0VvTGZ0QmhlcytjQmlDK2FuVWpEZGtQRXZY?= =?utf-8?B?Rk9OK05LaTJDT3hTMmlTT2xtRnFVT2cyYTdGdkFDQ1BJVW92S2llRWR0YUJB?= =?utf-8?B?Uk1RczFQUzlGRHdSYXBLb2tmcDc3V1M0THlGM2hzYXRTTWR2eEtwWk1ZOUUv?= =?utf-8?B?Tmc2QkVjWm53clNyMXRneTlaNjgrTUhMUm5kbG5mUU5hc3hEY0t4WVNwSkNL?= =?utf-8?B?eFJ0TktWY21RTEtqbHlBbFRWWlVkdnRtTndqWUwvYjJvQmV3M3padWNXY2t0?= =?utf-8?B?RHZBNENYbHRBODF2Z0lUTkZRanRwK2xZSHZxd0NvYVZ1V1h0c1dxSWR6NDdC?= =?utf-8?B?WHFMWmFMd2pPZ2s2ZFg5NThaSndhZzNoTjVHcExTQ2ZWV1lNdVVpd1loS3U5?= =?utf-8?B?ZVpWck05TVFraHhQdG0vRjQ3YzMzVnlHOElhNGhXMkVEMlUvam5WSitLWDht?= =?utf-8?B?VHN3ZkViK00xM2FWUDVIMldQcmc3dUdoOGFmUVNpbTRVVUZYYWhpaHkvcHoz?= =?utf-8?B?anhrWVoraUpRU1kxVkhCWHFiYW1HZmVuYWduSFdtUVJlVnBSaml2b0xNMW1B?= =?utf-8?B?ZlgxY3lIa3BlbWRCcm1nSzd0akI4ZS9wNjU3cWZmVStETEN5L1JqbFFwZ09a?= =?utf-8?B?TjE2T3dOeVM2NXFzOEp4VmpuVDlLVTJSdzc1Z0piMHZPTnQ3WERHSmM4STVU?= =?utf-8?B?TTlycmxsdURnVUpYV3FNcndWOGRrUzQwSGRvVWxldkNZMkl1bHVLV2IvdUo2?= =?utf-8?B?R252c2Uzd2RnYjBXVitmVHZTMEY5VzI1Rmw4bW1ZZVpTTWRlcHB0aVgralBw?= =?utf-8?B?VFlwZmg2REtvUzJ6aVk3SGZqam51SGxrZlpzbHptOUkzVlFFcUFLRmNkT29F?= =?utf-8?B?dGJzV3J0UHZLM1VadFNCSGdROHEvZkFQcnpZVlRmcEZ4RFFicDVWSEx4aEN4?= =?utf-8?B?amZJYWF1SHc0Z1ZxVnpVRDJIaWc3NjIyUm9ONlJETHkzN1VOdy9CSkxURi8w?= =?utf-8?B?SFNkOGVwVHk4WG5SeWdETkNFaEx3VVRBQnJPNCtYaXFKaUhQQ0twT0N5M2wz?= =?utf-8?B?NlZtVGpwQ3JzeUY2UnAzbkhaclNwZlFUeVp4NkxsQm9vbVJmNG5WdmNLNC90?= =?utf-8?B?MExOMVcvODZQRVpSSU9oeE5nMTY3UXJRMFFTazNnQTZxdWVwMWdaYzdNbWZS?= =?utf-8?B?OWtPYlBpRWxoc2U4UE9UM2dwZXlxeWJrTlVyMlovZUxrQmtDTTNvTzlCZ3pC?= =?utf-8?B?aWxXM3RiRjY0WEVteWZLejIwTHJ3PT0=?= X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 04710141-c42a-40a0-9c95-08ddc06193f8 X-MS-Exchange-CrossTenant-AuthSource: PH0PR02MB7159.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jul 2025 09:59:08.5445 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: tOtnuxKDyo7HzOIUfFvLacqZvqt0/GLcSYvleMolALJ+HczHglDJzHX0OOF/INlBTf37abA1rSgEFo21OEuwUU+GPSNsZftkso2wcmWMh/w= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR02MB7918 X-Authority-Analysis: v=2.4 cv=UNDdHDfy c=1 sm=1 tr=0 ts=6870e06e cx=c_pps a=YN2C2ub5wNuFRx14BhrpTQ==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Wb1JkmetP80A:10 a=0kUYKlekyDsA:10 a=64Cc0HZtAAAA:8 a=KKAkSRfTAAAA:8 a=ZtfbtUD1nkWWkvgxnEIA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-ORIG-GUID: F88_zdI2hQCQGzbF0ZKfQcZGL5p8BsgH X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNzExMDA3MCBTYWx0ZWRfX4DmNsH18C2Ic MRm/fghIxX4tgeA6KM8fOYbgFhqhbIhNBrzZ8NntEcET6P+jiOUs6taQhBQJg6ze37fMsiVOrPJ SffTzw9mNnbd5J9pdm7Cnfm3UBcQhAyFdsWlSamMBixuTgbEdq2yGQ/4OorVDR/6+05bd4W4EAF IX7yXG++80XiUPz6XwoydwQzuey/S4juPjev5M8OexlTbg6giNYAt65wYbfR7X0IbDVxctS4KWd Q9TSKeGUJPzquAwbEEcWjCsWQm664ouWSTDcOvduuPhVUmFyGIJ12c33uPFPBkA7zSaXCn/KhdZ XAknh9vV6J2MsTx+fLHP0tVVh/We5uqk3Vij9a2ehWg2sx735PqZNLhR859ptNwsBWCI4UNHmxM LP5UyUO5oG6vnCc0972TaGAykaxTDEGt6Cr10UOxR9BluJs1GidUJ0XZXT4/ZY1HFhM/Ic3u X-Proofpoint-GUID: F88_zdI2hQCQGzbF0ZKfQcZGL5p8BsgH X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.7,FMLib:17.12.80.40 definitions=2025-07-11_03,2025-07-09_01,2025-03-28_01 X-Proofpoint-Spam-Reason: safe Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=148.163.155.12; envelope-from=mark.caveayland@nutanix.com; helo=mx0b-002c1b01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @nutanix.com) X-ZM-MESSAGEID: 1752228151553116600 PCI is always enabled on the pc-i440fx machine so hardcode the relevant log= ic in pc_init1(). Signed-off-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- hw/i386/pc_piix.c | 194 ++++++++++++++++++---------------------------- 1 file changed, 76 insertions(+), 118 deletions(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index f6cd1e728d..fa63659113 100644 --- a/hw/i386/pc_piix.c +++ b/hw/i386/pc_piix.c @@ -70,7 +70,7 @@ =20 #define XEN_IOAPIC_NUM_PIRQS 128ULL =20 -#ifdef CONFIG_IDE_ISA +#ifdef CONFIG_ISAPC static const int ide_iobase[MAX_IDE_BUS] =3D { 0x1f0, 0x170 }; static const int ide_iobase2[MAX_IDE_BUS] =3D { 0x3f6, 0x376 }; static const int ide_irq[MAX_IDE_BUS] =3D { 14, 15 }; @@ -117,6 +117,9 @@ static void pc_init1(MachineState *machine, const char = *pci_type) MemoryRegion *rom_memory =3D system_memory; ram_addr_t lowmem; uint64_t hole64_size =3D 0; + PCIDevice *pci_dev; + DeviceState *dev; + size_t i; =20 /* * Calculate ram split, for memory below and above 4G. It's a bit @@ -187,38 +190,36 @@ static void pc_init1(MachineState *machine, const cha= r *pci_type) kvmclock_create(pcmc->kvmclock_create_always); } =20 - if (pcmc->pci_enabled) { - pci_memory =3D g_new(MemoryRegion, 1); - memory_region_init(pci_memory, NULL, "pci", UINT64_MAX); - rom_memory =3D pci_memory; - - phb =3D OBJECT(qdev_new(TYPE_I440FX_PCI_HOST_BRIDGE)); - object_property_add_child(OBJECT(machine), "i440fx", phb); - object_property_set_link(phb, PCI_HOST_PROP_RAM_MEM, - OBJECT(ram_memory), &error_fatal); - object_property_set_link(phb, PCI_HOST_PROP_PCI_MEM, - OBJECT(pci_memory), &error_fatal); - object_property_set_link(phb, PCI_HOST_PROP_SYSTEM_MEM, - OBJECT(system_memory), &error_fatal); - object_property_set_link(phb, PCI_HOST_PROP_IO_MEM, - OBJECT(system_io), &error_fatal); - object_property_set_uint(phb, PCI_HOST_BELOW_4G_MEM_SIZE, - x86ms->below_4g_mem_size, &error_fatal); - object_property_set_uint(phb, PCI_HOST_ABOVE_4G_MEM_SIZE, - x86ms->above_4g_mem_size, &error_fatal); - object_property_set_str(phb, I440FX_HOST_PROP_PCI_TYPE, pci_type, - &error_fatal); - sysbus_realize_and_unref(SYS_BUS_DEVICE(phb), &error_fatal); - - pcms->pcibus =3D PCI_BUS(qdev_get_child_bus(DEVICE(phb), "pci.0")); - pci_bus_map_irqs(pcms->pcibus, - xen_enabled() ? xen_pci_slot_get_pirq - : pc_pci_slot_get_pirq); - - hole64_size =3D object_property_get_uint(phb, - PCI_HOST_PROP_PCI_HOLE64_SI= ZE, - &error_abort); - } + pci_memory =3D g_new(MemoryRegion, 1); + memory_region_init(pci_memory, NULL, "pci", UINT64_MAX); + rom_memory =3D pci_memory; + + phb =3D OBJECT(qdev_new(TYPE_I440FX_PCI_HOST_BRIDGE)); + object_property_add_child(OBJECT(machine), "i440fx", phb); + object_property_set_link(phb, PCI_HOST_PROP_RAM_MEM, + OBJECT(ram_memory), &error_fatal); + object_property_set_link(phb, PCI_HOST_PROP_PCI_MEM, + OBJECT(pci_memory), &error_fatal); + object_property_set_link(phb, PCI_HOST_PROP_SYSTEM_MEM, + OBJECT(system_memory), &error_fatal); + object_property_set_link(phb, PCI_HOST_PROP_IO_MEM, + OBJECT(system_io), &error_fatal); + object_property_set_uint(phb, PCI_HOST_BELOW_4G_MEM_SIZE, + x86ms->below_4g_mem_size, &error_fatal); + object_property_set_uint(phb, PCI_HOST_ABOVE_4G_MEM_SIZE, + x86ms->above_4g_mem_size, &error_fatal); + object_property_set_str(phb, I440FX_HOST_PROP_PCI_TYPE, pci_type, + &error_fatal); + sysbus_realize_and_unref(SYS_BUS_DEVICE(phb), &error_fatal); + + pcms->pcibus =3D PCI_BUS(qdev_get_child_bus(DEVICE(phb), "pci.0")); + pci_bus_map_irqs(pcms->pcibus, + xen_enabled() ? xen_pci_slot_get_pirq + : pc_pci_slot_get_pirq); + + hole64_size =3D object_property_get_uint(phb, + PCI_HOST_PROP_PCI_HOLE64_SIZE, + &error_abort); =20 /* allocate ram and load rom/bios */ if (!xen_enabled()) { @@ -234,72 +235,51 @@ static void pc_init1(MachineState *machine, const cha= r *pci_type) } } =20 - gsi_state =3D pc_gsi_create(&x86ms->gsi, pcmc->pci_enabled); - - if (pcmc->pci_enabled) { - PCIDevice *pci_dev; - DeviceState *dev; - size_t i; - - pci_dev =3D pci_new_multifunction(-1, pcms->south_bridge); - object_property_set_bool(OBJECT(pci_dev), "has-usb", - machine_usb(machine), &error_abort); - object_property_set_bool(OBJECT(pci_dev), "has-acpi", - x86_machine_is_acpi_enabled(x86ms), - &error_abort); - object_property_set_bool(OBJECT(pci_dev), "has-pic", false, - &error_abort); - object_property_set_bool(OBJECT(pci_dev), "has-pit", false, - &error_abort); - qdev_prop_set_uint32(DEVICE(pci_dev), "smb_io_base", 0xb100); - object_property_set_bool(OBJECT(pci_dev), "smm-enabled", - x86_machine_is_smm_enabled(x86ms), - &error_abort); - dev =3D DEVICE(pci_dev); - for (i =3D 0; i < ISA_NUM_IRQS; i++) { - qdev_connect_gpio_out_named(dev, "isa-irqs", i, x86ms->gsi[i]); - } - pci_realize_and_unref(pci_dev, pcms->pcibus, &error_fatal); - - if (xen_enabled()) { - pci_device_set_intx_routing_notifier( - pci_dev, piix_intx_routing_notifier_xen); - - /* - * Xen supports additional interrupt routes from the PCI devic= es to - * the IOAPIC: the four pins of each PCI device on the bus are= also - * connected to the IOAPIC directly. - * These additional routes can be discovered through ACPI. - */ - pci_bus_irqs(pcms->pcibus, xen_intx_set_irq, pci_dev, - XEN_IOAPIC_NUM_PIRQS); - } + gsi_state =3D pc_gsi_create(&x86ms->gsi, true); + + pci_dev =3D pci_new_multifunction(-1, pcms->south_bridge); + object_property_set_bool(OBJECT(pci_dev), "has-usb", + machine_usb(machine), &error_abort); + object_property_set_bool(OBJECT(pci_dev), "has-acpi", + x86_machine_is_acpi_enabled(x86ms), + &error_abort); + object_property_set_bool(OBJECT(pci_dev), "has-pic", false, + &error_abort); + object_property_set_bool(OBJECT(pci_dev), "has-pit", false, + &error_abort); + qdev_prop_set_uint32(DEVICE(pci_dev), "smb_io_base", 0xb100); + object_property_set_bool(OBJECT(pci_dev), "smm-enabled", + x86_machine_is_smm_enabled(x86ms), + &error_abort); + dev =3D DEVICE(pci_dev); + for (i =3D 0; i < ISA_NUM_IRQS; i++) { + qdev_connect_gpio_out_named(dev, "isa-irqs", i, x86ms->gsi[i]); + } + pci_realize_and_unref(pci_dev, pcms->pcibus, &error_fatal); =20 - isa_bus =3D ISA_BUS(qdev_get_child_bus(DEVICE(pci_dev), "isa.0")); - x86ms->rtc =3D ISA_DEVICE(object_resolve_path_component(OBJECT(pci= _dev), - "rtc")); - piix4_pm =3D object_resolve_path_component(OBJECT(pci_dev), "pm"); - dev =3D DEVICE(object_resolve_path_component(OBJECT(pci_dev), "ide= ")); - pci_ide_create_devs(PCI_DEVICE(dev)); - pcms->idebus[0] =3D qdev_get_child_bus(dev, "ide.0"); - pcms->idebus[1] =3D qdev_get_child_bus(dev, "ide.1"); - } else { - uint32_t irq; + if (xen_enabled()) { + pci_device_set_intx_routing_notifier( + pci_dev, piix_intx_routing_notifier_xen); =20 - isa_bus =3D isa_bus_new(NULL, system_memory, system_io, - &error_abort); - isa_bus_register_input_irqs(isa_bus, x86ms->gsi); + /* + * Xen supports additional interrupt routes from the PCI devices to + * the IOAPIC: the four pins of each PCI device on the bus are also + * connected to the IOAPIC directly. + * These additional routes can be discovered through ACPI. + */ + pci_bus_irqs(pcms->pcibus, xen_intx_set_irq, pci_dev, + XEN_IOAPIC_NUM_PIRQS); + } =20 - x86ms->rtc =3D isa_new(TYPE_MC146818_RTC); - qdev_prop_set_int32(DEVICE(x86ms->rtc), "base_year", 2000); - isa_realize_and_unref(x86ms->rtc, isa_bus, &error_fatal); - irq =3D object_property_get_uint(OBJECT(x86ms->rtc), "irq", - &error_fatal); - isa_connect_gpio_out(ISA_DEVICE(x86ms->rtc), 0, irq); + isa_bus =3D ISA_BUS(qdev_get_child_bus(DEVICE(pci_dev), "isa.0")); + x86ms->rtc =3D ISA_DEVICE(object_resolve_path_component(OBJECT(pci_dev= ), + "rtc")); + piix4_pm =3D object_resolve_path_component(OBJECT(pci_dev), "pm"); + dev =3D DEVICE(object_resolve_path_component(OBJECT(pci_dev), "ide")); + pci_ide_create_devs(PCI_DEVICE(dev)); + pcms->idebus[0] =3D qdev_get_child_bus(dev, "ide.0"); + pcms->idebus[1] =3D qdev_get_child_bus(dev, "ide.1"); =20 - i8257_dma_init(OBJECT(machine), isa_bus, 0); - pcms->hpet_enabled =3D false; - } =20 if (x86ms->pic =3D=3D ON_OFF_AUTO_ON || x86ms->pic =3D=3D ON_OFF_AUTO_= AUTO) { pc_i8259_create(isa_bus, gsi_state->i8259_irq); @@ -313,7 +293,7 @@ static void pc_init1(MachineState *machine, const char = *pci_type) x86_register_ferr_irq(x86ms->gsi[13]); } =20 - pc_vga_init(isa_bus, pcmc->pci_enabled ? pcms->pcibus : NULL); + pc_vga_init(isa_bus, pcms->pcibus); =20 /* init basic PC hardware */ pc_basic_device_init(pcms, isa_bus, x86ms->gsi, x86ms->rtc, @@ -321,28 +301,6 @@ static void pc_init1(MachineState *machine, const char= *pci_type) =20 pc_nic_init(pcmc, isa_bus, pcms->pcibus); =20 -#ifdef CONFIG_IDE_ISA - if (!pcmc->pci_enabled) { - DriveInfo *hd[MAX_IDE_BUS * MAX_IDE_DEVS]; - int i; - - ide_drive_get(hd, ARRAY_SIZE(hd)); - for (i =3D 0; i < MAX_IDE_BUS; i++) { - ISADevice *dev; - char busname[] =3D "ide.0"; - dev =3D isa_ide_init(isa_bus, ide_iobase[i], ide_iobase2[i], - ide_irq[i], - hd[MAX_IDE_DEVS * i], hd[MAX_IDE_DEVS * i += 1]); - /* - * The ide bus name is ide.0 for the first bus and ide.1 for t= he - * second one. - */ - busname[4] =3D '0' + i; - pcms->idebus[i] =3D qdev_get_child_bus(DEVICE(dev), busname); - } - } -#endif - if (piix4_pm) { smi_irq =3D qemu_allocate_irq(pc_acpi_smi_interrupt, first_cpu, 0); =20 --=20 2.43.0 From nobody Tue Dec 16 21:11:18 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass(p=none dis=none) header.from=nutanix.com ARC-Seal: i=2; a=rsa-sha256; t=1752228063; cv=pass; d=zohomail.com; s=zohoarc; b=bd+MGT2/+YJrt901HbkTa6USkyLeMhqvJvRwafru6qYsJ1fLljIDB6SG1eYeRIojYij/P2lrx3yzbXoVro1+UItuHFYRFBc9cgXZnHesPasID81By7UGIt+OWpG6hbDwP7hHnPgBbMA8Ffzrkshn87lvfQKijl8gOXtk/2Gl/9E= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1752228063; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=UGdcSVjocv9bLTfxZzfvzXdzeE0RtD149z8Mk2TOVvk=; b=DQ+5FATm2DR98QBiT58TD38gWV8hf265HoXO4G6h3e4xMRvzBzncIAvwSOhluZ2vKJGvjkco8f1HHlew2/4LJNREGiU3I3STDKjdE8vdMJXpwc1ZpevGFn60VWRl8JjVrlH9MyTzc8MOXBv02BUyBuheOurVz7gt/iFqqFnEaL8= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1752228063164399.32849285986686; Fri, 11 Jul 2025 03:01:03 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uaAXq-0007Zh-Ld; Fri, 11 Jul 2025 05:59:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uaAXP-0006Zv-DZ for qemu-devel@nongnu.org; Fri, 11 Jul 2025 05:59:28 -0400 Received: from mx0b-002c1b01.pphosted.com ([148.163.155.12]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uaAXH-0004vr-7u for qemu-devel@nongnu.org; Fri, 11 Jul 2025 05:59:23 -0400 Received: from pps.filterd (m0127841.ppops.net [127.0.0.1]) by mx0b-002c1b01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 56B8HRNt032175; Fri, 11 Jul 2025 02:59:14 -0700 Received: from nam04-mw2-obe.outbound.protection.outlook.com (mail-mw2nam04on2098.outbound.protection.outlook.com [40.107.101.98]) by mx0b-002c1b01.pphosted.com (PPS) with ESMTPS id 47q1karqp8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 11 Jul 2025 02:59:13 -0700 (PDT) Received: from PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) by BN0PR02MB7918.namprd02.prod.outlook.com (2603:10b6:408:161::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8922.25; Fri, 11 Jul 2025 09:59:11 +0000 Received: from PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88]) by PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88%5]) with mapi id 15.20.8901.028; Fri, 11 Jul 2025 09:59:11 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint20171006; bh=UGdcSVjocv9bLTfxZzfvzXdzeE0RtD149z8Mk2TOV vk=; b=f95jVaF2ZjsJlJlOWwz1VjIGA+B9ftRFTpbNRf5usJhZ+DuqBqLf3DQyW omFlb8Gt4lp+ipuNJi1wFfUg1RLIYyHz6AHcH37B3remypBB0oVaQin+j+IU1uHC UIrz9TDrlz18bd7rJfhE7iYYAA3kqpG8LkXmaIokLdMDfqbsnVj7t8rkhIJx+ZAv Gr7gYSjwnesFEqGjNTTANrlQi9R5LpvGQ5jHzucDy/rmSFjiPio2YpHnNUoGJBz/ S01fY/QnRoWFX9IqUrDGA2DtOJS2/GjhDDfY4//cGCwiQQOniT/fXR49WwgghvO+ TChDyOe3xO+qFBjCAEPBH7eSzkJlQ== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=BFf0G6oXRF9+dFs6hLfoqsPHredzWVxd/SAl9I9X0dGc8xtIG9seIX/SIXTSsq7mZRu5Y/mx63BwNHrlzctBTnWfkRSchOrFrP57LLmf+qFUGhrNZPtoqlyUycrBNhrUz5FMsK3CdqCcJiJ08VfHDCtTIx+ryaacMGvDkKXgJa0YmYed24qAE4/z3T1qXjFLgsYfGcmSA2dXnYEQv9Mm3UstDv58Izs5TLP5ywg4yfgtJkHaw6v8ObORXe1iSCMvMxLCJJcS3qtYO8RU2Ze+uM0AX38eocUZOYVOPVyYD9VXqYvkjLL5mx3kRNdX/8TaXKp1/5OsnEcuXdTp1nhWdw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UGdcSVjocv9bLTfxZzfvzXdzeE0RtD149z8Mk2TOVvk=; b=VOCZR+MV86001jwPT3a9WC421lkdvfbTuxYseTDHERLr+UbNwjmbkboTyci5Cm53tzNp/bhPQQyIL01Ag1Fv+yq5x0xXOCOog7naXzTGg/o0kMXSggBMVyl3RThirkC3mqwqMJ1vl3PVk1Gcg/R15uhbcmn0VY7qVE8qF3cW3RMMglAYWYEGmMS1bPocBuDggkB+1IVQdeTXkS2aNPyNdNaPrFwJUyHxcIKxmpAEzWtcUkXvymc6CdUI6175xp+GjsbYpCQCc1Xu8fFRRoEIf4kFuilq9jM1OAgbUbdCD7k2F9qkHz5INWunhaOjuD4pn4ezX6s1vx1gAfJh7L3wAQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UGdcSVjocv9bLTfxZzfvzXdzeE0RtD149z8Mk2TOVvk=; b=lS4SuB6WYgHKRGfEG3+gQd2hfYimP7UWdxkYm1nmzd/RNsLdg7TKLGh2bpuANbXrZNtLSjYt7J/CJhapgLwtBOloaVSD820KwSnjY2KUDPlOqAIcF/5xkc9YOak1mPBs9tmii6KS+p27AIPVJw/omSiHEw9ys2aqVJtkjrFp5XNcTVKjn3uOhnn0tcgo1xt4naaCbeUVs7LsA9PKpbo6TK3FQc71rDZqVvy7+GDc+4LRyivgvkOCYDqhXZosrSU4kOJq6EIjziWehqly5N0dNqRRXLsY42DcbLHUyBv3oKk6u/FMxB7n+lHN72f3/C4ZtDZstK/0BdCqyAXCnoYyAg== From: Mark Cave-Ayland To: pbonzini@redhat.com, mst@redhat.com, marcel.apfelbaum@gmail.com, eduardo@habkost.net, imammedo@redhat.com, qemu-devel@nongnu.org Subject: [PATCH v5 16/19] hw/i386: move isapc machine to separate isapc.c file Date: Fri, 11 Jul 2025 10:57:18 +0100 Message-ID: <20250711095812.543857-17-mark.caveayland@nutanix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250711095812.543857-1-mark.caveayland@nutanix.com> References: <20250711095812.543857-1-mark.caveayland@nutanix.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: LO2P265CA0382.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:a3::34) To PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR02MB7159:EE_|BN0PR02MB7918:EE_ X-MS-Office365-Filtering-Correlation-Id: f2f44e05-90e9-4a34-76a7-08ddc06195f5 x-proofpoint-crosstenant: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|376014|1800799024|366016|10070799003; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?Z5Hqmhww1SKiXPRqqf2txmTG101fCe+UmGYHSNFD9jU1AB41tV+lOlZ6QVlw?= =?us-ascii?Q?Kv2mlqHAJXMEYIs8qr/OwJcjJGsuhGdRasOSzSVCh/zn1VNKNY09LnFbKpjb?= =?us-ascii?Q?+kxR05+ClHBuie5ZyIho5T9lB0ZuXBDPcjqoWTnX5dcSRQRoAZwYbCK/lF42?= =?us-ascii?Q?ZOugqHy6U7LYuhS/1ZZwFJYLboA4K7cX3hZT8RJUWcKCDgqnOHgkvl+xOitB?= =?us-ascii?Q?+HWFupazUZlJnbmLqbXMRP6XW/XuiOqlg018OCiqWk6m5DJ/Zmoi0jXQWQGt?= =?us-ascii?Q?1CP+FHnm7V9HBnUznFT3uQfohQzo0oEwH4wBzThZgaeqLviynqnkGY/gAubk?= =?us-ascii?Q?DhpIVk45b3EVzAV4bMCoEx0TMzFauC/2gZz4q7IhuAtvnIM/JnzZfEaucByH?= =?us-ascii?Q?v6Cwc7wyjWoPSLCqHd4Saxkp2s9LY0tHtPE/2XzHLU9gW365kFlql7M21YFq?= =?us-ascii?Q?lOkPEPWnZDdvVj+BexDb8Xzl3q0zEjwjN1kL3XzS6ZrWTnh2QsFWddCzygRV?= =?us-ascii?Q?MeXLAdj8fNoodOM2+pxzix4fR47M5YDh65IZq93mT78ToDmTXiHpkSVgpRSo?= =?us-ascii?Q?+JXObY6XE+sT+txe0KFEiebmqyY2yPw+kbgfCcEPB47L3xWAhuWqq7JnhkMC?= =?us-ascii?Q?GJdcxEC1iPgLUo3N5q4HJFMpU2MHMoxA1nOOBTEuVgvx1ID6ZtiK4sc6ks/a?= =?us-ascii?Q?m5P33yc2ArbT7fkMUHmTwx2MaG0Tdn2D/scXlcuUweirF9EvIe5jQaVzAI7c?= =?us-ascii?Q?xykw16BJZ8XET9KVSN8vI3AO2CGd37UIMml5IoRXDPvsPi0zI/mEPivl4clf?= =?us-ascii?Q?jozvRTkyC+LitNuRXyVQ0KonqEud9xlJXpx1zQri0XwziFhZLatJh2A5Qsy6?= =?us-ascii?Q?2X7FuXhAb5zNl4IJrXu44QGW0UQUAtR0VBK7I+SslEVM7fnC+lHDMeKoF+4X?= =?us-ascii?Q?QkDNv4d4TPB00ss5gNB30FK3oRc3sGTrYB5+2v7hc6obWnTyNEGlM7nKlArq?= =?us-ascii?Q?Wy5hbqhG3TgwRTstC/7unHRAFX1vX5wflDUj/WFlRKl7txPoySmaDz71XP4n?= =?us-ascii?Q?s/k9uaDJROpjLiDSxYDCj4vgjaz0MwzpOhbdRwffbYb7KwHrZcEfsdB2pUSR?= =?us-ascii?Q?w04pFyZKMjcxp7G5J/7IuFyE2gNCUZATIqZRIxiFTXhkht2VjKEI2VubC8x6?= =?us-ascii?Q?iiIAPXmOnUhDqyvThvuu8+CAfwMF0pa6gKlUSW4HI871CW2YUzWvkQ2eUfR+?= =?us-ascii?Q?pNz84girGupuBlSOy+mtDBR1pAiNFPflFDTxESz4wli1BJlVS2dU4J53KMwV?= =?us-ascii?Q?SUPHBNjDlQ4AFUVyz2YIVeU3jNoCafbN094yfumBzU1IXQsZuEW6kHa2wVjm?= =?us-ascii?Q?bEDwgalKFiL2sg8xFfk/goeI3Gp6kVMwN5CQrQdH9MrMea/7PDwhmptgHF4j?= =?us-ascii?Q?gzOw3m7SWHE=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR02MB7159.namprd02.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(1800799024)(366016)(10070799003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?3Bo7SUtSStORBJw9g9L1IM1+fe21fQQFsh988TX1vO/ttOi921dVMvvSnpcd?= =?us-ascii?Q?V2nFTbC6Z1iiQNzd4le31zNRTyomz6Qdg4ul8gemdHiSJzhQjHEmsx42TCfO?= =?us-ascii?Q?UBQ/IWY9mtP2iFKsh0qxYdjiO7I0jKpmMqpRM4hcvJZxmDmMNBm3TXyCExYu?= =?us-ascii?Q?6b969oY3S0rPo72l48gYbiuwUHY/z0EBS4542E1pKJgvkFItG5JyhiZ0RA2N?= =?us-ascii?Q?GcwaaP4pLrQAZH3EW2sYSXaq0HMEhuDkJSP9qOqE7LISFqMv8O3FL451vhbx?= =?us-ascii?Q?tuULyBmiw6ExisIdoKrEnDxa0DKLiKbWthA4FvYFpdW6YWZKz0VGHm3+K/5x?= =?us-ascii?Q?roXiirWU+HIAC8YJwmioXrHD9WQpIz175OVxdLglrEuBVRBpRvud9YAsKPYG?= =?us-ascii?Q?Y/k3W+WFewX9AHKqhIcprFm6488d1gV3EkqJosYl4Rur0mqM5HzJHNcSMj+g?= =?us-ascii?Q?eAH8KB0GIf45fpkkurRsGjE5Xv9sJYgBBDxZpzAYULlIwHkCazMglcbszh+B?= =?us-ascii?Q?2rpw1xEKRQFo+VKN93sC3kR80XL5J94qYqLAG2xFx+5VEM0OfPqkLobnEHAk?= =?us-ascii?Q?IPZ6bjORFRS5J7GoGHcCYcupf8AZknRMqznFhdAzm1T04P7inl42ub74TBGJ?= =?us-ascii?Q?swvijBTEyvr+oDu9yakgFWyCIe84sA7KQs8kTm4hsdtKhIgMXCPNuhIDZ/03?= =?us-ascii?Q?iGRmsEnsPjaRCWKTc3IxLBPKs+pdDhJA5/Fu4fFnckuXHf2nKq7AA50DEUGV?= =?us-ascii?Q?rklCLRUpR54Jgs7tpaJHBvZ2EvP65ys6P4jtDQX1vozVVgOJVz8FKIkzf58b?= =?us-ascii?Q?6xS4Uwy4WXKEW1YsD6SqfKRmyo8xxmnRtO46IHNg3vzD0GsgSKa1zY2WlEIG?= =?us-ascii?Q?EnrHYPdAZvsE3FxclNaLXmSGgUSOq+U7JAb9dEDnoEAmFEtQZer6GAffA4Tx?= =?us-ascii?Q?WEt0PvfITkiokmgZPoRzlcuNILmkbEn03ysr18FIvTn0IqMvUFUHhsidEBIH?= =?us-ascii?Q?0ntZ8U45PsCJEDE7uX/PKucOQ7ssCNOnyt5ThlX8smZY3gVZZ/xIM9A7qF0l?= =?us-ascii?Q?nQx4JJF+O/QGCbuDcAWa9hP0WaRnro/SoiiglX0MveBpgJA1MkkyGqNi4RLk?= =?us-ascii?Q?1txsIimmD7NHWIPP4P6Y85Hh9IOt7tK6JaXKLtxfy4eWQnPrxwSpbohJxrqU?= =?us-ascii?Q?gaRYPlTVGEz6O0hgDYxZVRTc7xwA6GiWiEzfnS2nr4bwIPEmAYdh/cqd8bvZ?= =?us-ascii?Q?II1R+b0TgrRI4hIOgh8Nuf7/oj1G/nh3xHzTMMtaNVKnaocWnZnikpdbzQTL?= =?us-ascii?Q?OF7woHlccd5iJhlO+2Srt7IOFk4oUlJ+ceV1wBIuiktiCPZ2clzhxHYGeXSg?= =?us-ascii?Q?fLZN3gbiwrXLWhnPwHkIusuk6UW1rj9x5rE+n6Qhdbsj3ZVA/5fwVsuGOB1N?= =?us-ascii?Q?14iJfEHRSm924MlCrcq8VVfQz1iTyUeeK6U9piwOr7l3z/rDd1g4zF7VTluq?= =?us-ascii?Q?zDgh4j9I+OGjLY1dO2UK6tdLxtNE0Ub0HRYNXSVBbHUPKkIvfXhPfEUm6VKq?= =?us-ascii?Q?pSLhI+A25yMAfykZVShQJLlVvbmvl7ZnKi03IJEgf2/qqoG5KlTO4QS5jaRu?= =?us-ascii?Q?ysabylt9hrso/KzJntphTEdzdLOqFqmmj4rDRurN1loL1mXNSFJnH50BXm+6?= =?us-ascii?Q?CTHoNw=3D=3D?= X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: f2f44e05-90e9-4a34-76a7-08ddc06195f5 X-MS-Exchange-CrossTenant-AuthSource: PH0PR02MB7159.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jul 2025 09:59:11.7583 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: NzE2z44i+XijLPBa5otv/b2NExP3ect5xlvNE5V+Ov6akwG3b0C4+YsSsyGLtj8WzwloE9ADHEIqyE9hcEIT9EqtEsVE8uP1QLTMAqdRQQg= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR02MB7918 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNzExMDA3MCBTYWx0ZWRfX5SyAkW0MBjRG DwHxR97AMqvJQ4wn7m1F28eL/xXm70Km3G5a+9a3BUPdiQLYL6+p2enyvRTs+xp8UMX6we9RzIh TcUn8RprpNUp+UnH9amJS2obl0N+KRuTOXmW9i/1pLtPhskHJTol+KoGf3iRVrfrZnn1OjaSDgl GVJ+idWFkbXJkja3kRDgAaqnfT57oVi2GXHVMX2tjF3KJH6JmrTkrji3ZhL1bweADEHRdR2/G6G V3HvlSm7l6SRGgFoHKOLUcN1oOlZkDDNRIlkgOl1Y65qMJTKhIdqbaRGupLGu302vOp/mdmHqGw Ft7S2ypFExy8xus5JUpwBe98Q5FshRdX/ar/nSMKl2En9Len2LACwT7aNqdvMNtAd0DTSsHzZV3 HHdkYJxi9I5bDHgNj5FHLTWRSwfw9JBxMB7CKq+dju8oJvYNia2vmAfIWzzLWXHhVLLe0KCB X-Proofpoint-ORIG-GUID: iUlrwloSOys1VFz-bkIfEKAw7RbYn4O_ X-Authority-Analysis: v=2.4 cv=Do9W+H/+ c=1 sm=1 tr=0 ts=6870e071 cx=c_pps a=bAxSNnLMfqpvnT1L+FcFCg==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=xqWC_Br6kY4A:10 a=Wb1JkmetP80A:10 a=0kUYKlekyDsA:10 a=64Cc0HZtAAAA:8 a=pGLkceISAAAA:8 a=Pbl5c31VFoorxvNN0s8A:9 X-Proofpoint-GUID: iUlrwloSOys1VFz-bkIfEKAw7RbYn4O_ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.7,FMLib:17.12.80.40 definitions=2025-07-11_03,2025-07-09_01,2025-03-28_01 X-Proofpoint-Spam-Reason: safe Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=148.163.155.12; envelope-from=mark.caveayland@nutanix.com; helo=mx0b-002c1b01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @nutanix.com) X-ZM-MESSAGEID: 1752228064432116600 Content-Type: text/plain; charset="utf-8" Now that pc_init_isa() is independent of any PCI initialisation, move it in= to a separate isapc.c file. This enables us to finally fix the dependency of ISA= PC on I440FX in hw/i386/Kconfig. Note that as part of the move to a separate file we can see that the licenc= e text is a verbatim copy of the MIT licence. The text originates from commit 1df9= 12cf9e ("VL license of the day is MIT/BSD") so we can be sure that this was the or= iginal intent. As a consequence we can update the file header to use a SPDX tag as= per the current project contribution guidelines. Signed-off-by: Mark Cave-Ayland Reviewed-by: Bernhard Beschow --- hw/i386/Kconfig | 3 - hw/i386/isapc.c | 170 ++++++++++++++++++++++++++++++++++++++++++++ hw/i386/meson.build | 1 + hw/i386/pc_piix.c | 149 -------------------------------------- 4 files changed, 171 insertions(+), 152 deletions(-) create mode 100644 hw/i386/isapc.c diff --git a/hw/i386/Kconfig b/hw/i386/Kconfig index 14d23e27b5..8ffcc9f7aa 100644 --- a/hw/i386/Kconfig +++ b/hw/i386/Kconfig @@ -96,9 +96,6 @@ config ISAPC select ISA_BUS select PC select IDE_ISA - # FIXME: it is in the same file as i440fx, and does not compile - # if separated - depends on I440FX =20 config Q35 bool diff --git a/hw/i386/isapc.c b/hw/i386/isapc.c new file mode 100644 index 0000000000..b24cbf41ea --- /dev/null +++ b/hw/i386/isapc.c @@ -0,0 +1,170 @@ +/* + * QEMU PC System Emulator + * + * Copyright (c) 2003-2004 Fabrice Bellard + * + * SPDX-License-Identifier: MIT + */ + +#include "qemu/osdep.h" + +#include "qemu/error-report.h" +#include "hw/char/parallel-isa.h" +#include "hw/dma/i8257.h" +#include "hw/i386/pc.h" +#include "hw/ide/isa.h" +#include "hw/ide/ide-bus.h" +#include "system/kvm.h" +#include "hw/i386/kvm/clock.h" +#include "hw/xen/xen-x86.h" +#include "system/xen.h" +#include "hw/rtc/mc146818rtc.h" +#include "target/i386/cpu.h" + +static const int ide_iobase[MAX_IDE_BUS] =3D { 0x1f0, 0x170 }; +static const int ide_iobase2[MAX_IDE_BUS] =3D { 0x3f6, 0x376 }; +static const int ide_irq[MAX_IDE_BUS] =3D { 14, 15 }; + + +static void pc_init_isa(MachineState *machine) +{ + PCMachineState *pcms =3D PC_MACHINE(machine); + PCMachineClass *pcmc =3D PC_MACHINE_GET_CLASS(pcms); + X86MachineState *x86ms =3D X86_MACHINE(machine); + MemoryRegion *system_memory =3D get_system_memory(); + MemoryRegion *system_io =3D get_system_io(); + ISABus *isa_bus; + GSIState *gsi_state; + MemoryRegion *ram_memory; + MemoryRegion *rom_memory =3D system_memory; + DriveInfo *hd[MAX_IDE_BUS * MAX_IDE_DEVS]; + uint32_t irq; + int i; + + /* + * There is no RAM split for the isapc machine + */ + if (xen_enabled()) { + xen_hvm_init_pc(pcms, &ram_memory); + } else { + ram_memory =3D machine->ram; + + pcms->max_ram_below_4g =3D 0xe0000000; /* default: 3.5G */ + x86ms->above_4g_mem_size =3D 0; + x86ms->below_4g_mem_size =3D machine->ram_size; + } + + /* + * There is a small chance that someone unintentionally passes "-cpu m= ax" + * for the isapc machine, which will provide a much more modern 32-bit + * CPU than would be expected for an ISA-era PC. If the "max" cpu type= has + * been specified, choose the "best" 32-bit cpu possible which we cons= ider + * be the pentium3 (deliberately choosing an Intel CPU given that the + * default 486 CPU for the isapc machine is also an Intel CPU). + */ + if (!strcmp(machine->cpu_type, X86_CPU_TYPE_NAME("max"))) { + machine->cpu_type =3D X86_CPU_TYPE_NAME("pentium3"); + warn_report("-cpu max is invalid for isapc machine, using pentium3= "); + } + + x86_cpus_init(x86ms, pcmc->default_cpu_version); + + if (kvm_enabled()) { + kvmclock_create(pcmc->kvmclock_create_always); + } + + /* allocate ram and load rom/bios */ + if (!xen_enabled()) { + pc_memory_init(pcms, system_memory, rom_memory, 0); + } else { + assert(machine->ram_size =3D=3D x86ms->below_4g_mem_size + + x86ms->above_4g_mem_size); + + if (machine->kernel_filename !=3D NULL) { + /* For xen HVM direct kernel boot, load linux here */ + xen_load_linux(pcms); + } + } + + gsi_state =3D pc_gsi_create(&x86ms->gsi, false); + + isa_bus =3D isa_bus_new(NULL, system_memory, system_io, + &error_abort); + isa_bus_register_input_irqs(isa_bus, x86ms->gsi); + + x86ms->rtc =3D isa_new(TYPE_MC146818_RTC); + qdev_prop_set_int32(DEVICE(x86ms->rtc), "base_year", 2000); + isa_realize_and_unref(x86ms->rtc, isa_bus, &error_fatal); + irq =3D object_property_get_uint(OBJECT(x86ms->rtc), "irq", + &error_fatal); + isa_connect_gpio_out(ISA_DEVICE(x86ms->rtc), 0, irq); + + i8257_dma_init(OBJECT(machine), isa_bus, 0); + pcms->hpet_enabled =3D false; + + if (x86ms->pic =3D=3D ON_OFF_AUTO_ON || x86ms->pic =3D=3D ON_OFF_AUTO_= AUTO) { + pc_i8259_create(isa_bus, gsi_state->i8259_irq); + } + + if (tcg_enabled()) { + x86_register_ferr_irq(x86ms->gsi[13]); + } + + pc_vga_init(isa_bus, NULL); + + /* init basic PC hardware */ + pc_basic_device_init(pcms, isa_bus, x86ms->gsi, x86ms->rtc, + !MACHINE_CLASS(pcmc)->no_floppy, 0x4); + + pc_nic_init(pcmc, isa_bus, NULL); + + ide_drive_get(hd, ARRAY_SIZE(hd)); + for (i =3D 0; i < MAX_IDE_BUS; i++) { + ISADevice *dev; + char busname[] =3D "ide.0"; + dev =3D isa_ide_init(isa_bus, ide_iobase[i], ide_iobase2[i], + ide_irq[i], + hd[MAX_IDE_DEVS * i], hd[MAX_IDE_DEVS * i + 1]); + /* + * The ide bus name is ide.0 for the first bus and ide.1 for the + * second one. + */ + busname[4] =3D '0' + i; + pcms->idebus[i] =3D qdev_get_child_bus(DEVICE(dev), busname); + } +} + +static void isapc_machine_options(MachineClass *m) +{ + static const char * const valid_cpu_types[] =3D { + X86_CPU_TYPE_NAME("486"), + X86_CPU_TYPE_NAME("athlon"), + X86_CPU_TYPE_NAME("kvm32"), + X86_CPU_TYPE_NAME("pentium"), + X86_CPU_TYPE_NAME("pentium2"), + X86_CPU_TYPE_NAME("pentium3"), + X86_CPU_TYPE_NAME("qemu32"), + X86_CPU_TYPE_NAME("max"), + NULL + }; + PCMachineClass *pcmc =3D PC_MACHINE_CLASS(m); + + m->desc =3D "ISA-only PC"; + m->max_cpus =3D 1; + m->option_rom_has_mr =3D true; + m->rom_file_has_mr =3D false; + pcmc->pci_enabled =3D false; + pcmc->has_acpi_build =3D false; + pcmc->smbios_defaults =3D false; + pcmc->gigabyte_align =3D false; + pcmc->smbios_legacy_mode =3D true; + pcmc->has_reserved_memory =3D false; + m->default_nic =3D "ne2k_isa"; + m->default_cpu_type =3D X86_CPU_TYPE_NAME("486"); + m->valid_cpu_types =3D valid_cpu_types; + m->no_floppy =3D !module_object_class_by_name(TYPE_ISA_FDC); + m->no_parallel =3D !module_object_class_by_name(TYPE_ISA_PARALLEL); +} + +DEFINE_PC_MACHINE(isapc, "isapc", pc_init_isa, + isapc_machine_options); diff --git a/hw/i386/meson.build b/hw/i386/meson.build index 7896f348cf..436b3ce52d 100644 --- a/hw/i386/meson.build +++ b/hw/i386/meson.build @@ -14,6 +14,7 @@ i386_ss.add(when: 'CONFIG_X86_IOMMU', if_true: files('x86= -iommu.c'), i386_ss.add(when: 'CONFIG_AMD_IOMMU', if_true: files('amd_iommu.c'), if_false: files('amd_iommu-stub.c')) i386_ss.add(when: 'CONFIG_I440FX', if_true: files('pc_piix.c')) +i386_ss.add(when: 'CONFIG_ISAPC', if_true: files('isapc.c')) i386_ss.add(when: 'CONFIG_MICROVM', if_true: files('x86-common.c', 'microv= m.c', 'acpi-microvm.c', 'microvm-dt.c')) i386_ss.add(when: 'CONFIG_NITRO_ENCLAVE', if_true: files('nitro_enclave.c'= )) i386_ss.add(when: 'CONFIG_Q35', if_true: files('pc_q35.c')) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index fa63659113..4c7da53943 100644 --- a/hw/i386/pc_piix.c +++ b/hw/i386/pc_piix.c @@ -70,12 +70,6 @@ =20 #define XEN_IOAPIC_NUM_PIRQS 128ULL =20 -#ifdef CONFIG_ISAPC -static const int ide_iobase[MAX_IDE_BUS] =3D { 0x1f0, 0x170 }; -static const int ide_iobase2[MAX_IDE_BUS] =3D { 0x3f6, 0x376 }; -static const int ide_irq[MAX_IDE_BUS] =3D { 14, 15 }; -#endif - /* * Return the global irq number corresponding to a given device irq * pin. We could also use the bus number to have a more precise mapping. @@ -372,112 +366,6 @@ static void pc_set_south_bridge(Object *obj, int valu= e, Error **errp) pcms->south_bridge =3D PCSouthBridgeOption_lookup.array[value]; } =20 -#ifdef CONFIG_ISAPC -static void pc_init_isa(MachineState *machine) -{ - PCMachineState *pcms =3D PC_MACHINE(machine); - PCMachineClass *pcmc =3D PC_MACHINE_GET_CLASS(pcms); - X86MachineState *x86ms =3D X86_MACHINE(machine); - MemoryRegion *system_memory =3D get_system_memory(); - MemoryRegion *system_io =3D get_system_io(); - ISABus *isa_bus; - GSIState *gsi_state; - MemoryRegion *ram_memory; - MemoryRegion *rom_memory =3D system_memory; - DriveInfo *hd[MAX_IDE_BUS * MAX_IDE_DEVS]; - int i; - - /* - * There is no RAM split for the isapc machine - */ - if (xen_enabled()) { - xen_hvm_init_pc(pcms, &ram_memory); - } else { - ram_memory =3D machine->ram; - - pcms->max_ram_below_4g =3D 0xe0000000; /* default: 3.5G */ - x86ms->above_4g_mem_size =3D 0; - x86ms->below_4g_mem_size =3D machine->ram_size; - } - - /* - * There is a small chance that someone unintentionally passes "-cpu m= ax" - * for the isapc machine, which will provide a much more modern 32-bit - * CPU than would be expected for an ISA-era PC. If the "max" cpu type= has - * been specified, choose the "best" 32-bit cpu possible which we cons= ider - * be the pentium3 (deliberately choosing an Intel CPU given that the - * default 486 CPU for the isapc machine is also an Intel CPU). - */ - if (!strcmp(machine->cpu_type, X86_CPU_TYPE_NAME("max"))) { - machine->cpu_type =3D X86_CPU_TYPE_NAME("pentium3"); - warn_report("-cpu max is invalid for isapc machine, using pentium3= "); - } - - x86_cpus_init(x86ms, pcmc->default_cpu_version); - - if (kvm_enabled()) { - kvmclock_create(pcmc->kvmclock_create_always); - } - - /* allocate ram and load rom/bios */ - if (!xen_enabled()) { - pc_memory_init(pcms, system_memory, rom_memory, 0); - } else { - assert(machine->ram_size =3D=3D x86ms->below_4g_mem_size + - x86ms->above_4g_mem_size); - - if (machine->kernel_filename !=3D NULL) { - /* For xen HVM direct kernel boot, load linux here */ - xen_load_linux(pcms); - } - } - - gsi_state =3D pc_gsi_create(&x86ms->gsi, false); - - isa_bus =3D isa_bus_new(NULL, system_memory, system_io, - &error_abort); - isa_bus_register_input_irqs(isa_bus, x86ms->gsi); - - x86ms->rtc =3D isa_new(TYPE_MC146818_RTC); - qdev_prop_set_int32(DEVICE(x86ms->rtc), "base_year", 2000); - isa_realize_and_unref(x86ms->rtc, isa_bus, &error_fatal); - - i8257_dma_init(OBJECT(machine), isa_bus, 0); - pcms->hpet_enabled =3D false; - - if (x86ms->pic =3D=3D ON_OFF_AUTO_ON || x86ms->pic =3D=3D ON_OFF_AUTO_= AUTO) { - pc_i8259_create(isa_bus, gsi_state->i8259_irq); - } - - if (tcg_enabled()) { - x86_register_ferr_irq(x86ms->gsi[13]); - } - - pc_vga_init(isa_bus, NULL); - - /* init basic PC hardware */ - pc_basic_device_init(pcms, isa_bus, x86ms->gsi, x86ms->rtc, - !MACHINE_CLASS(pcmc)->no_floppy, 0x4); - - pc_nic_init(pcmc, isa_bus, NULL); - - ide_drive_get(hd, ARRAY_SIZE(hd)); - for (i =3D 0; i < MAX_IDE_BUS; i++) { - ISADevice *dev; - char busname[] =3D "ide.0"; - dev =3D isa_ide_init(isa_bus, ide_iobase[i], ide_iobase2[i], - ide_irq[i], - hd[MAX_IDE_DEVS * i], hd[MAX_IDE_DEVS * i + 1]= ); - /* - * The ide bus name is ide.0 for the first bus and ide.1 for the - * second one. - */ - busname[4] =3D '0' + i; - pcms->idebus[i] =3D qdev_get_child_bus(DEVICE(dev), busname); - } -} -#endif - #ifdef CONFIG_XEN static void pc_xen_hvm_init(MachineState *machine) { @@ -834,43 +722,6 @@ static void pc_i440fx_machine_2_6_options(MachineClass= *m) =20 DEFINE_I440FX_MACHINE(2, 6); =20 -#ifdef CONFIG_ISAPC -static void isapc_machine_options(MachineClass *m) -{ - static const char * const valid_cpu_types[] =3D { - X86_CPU_TYPE_NAME("486"), - X86_CPU_TYPE_NAME("athlon"), - X86_CPU_TYPE_NAME("kvm32"), - X86_CPU_TYPE_NAME("pentium"), - X86_CPU_TYPE_NAME("pentium2"), - X86_CPU_TYPE_NAME("pentium3"), - X86_CPU_TYPE_NAME("qemu32"), - X86_CPU_TYPE_NAME("max"), - NULL - }; - PCMachineClass *pcmc =3D PC_MACHINE_CLASS(m); - - m->desc =3D "ISA-only PC"; - m->max_cpus =3D 1; - m->option_rom_has_mr =3D true; - m->rom_file_has_mr =3D false; - pcmc->pci_enabled =3D false; - pcmc->has_acpi_build =3D false; - pcmc->smbios_defaults =3D false; - pcmc->gigabyte_align =3D false; - pcmc->smbios_legacy_mode =3D true; - pcmc->has_reserved_memory =3D false; - m->default_nic =3D "ne2k_isa"; - m->default_cpu_type =3D X86_CPU_TYPE_NAME("486"); - m->valid_cpu_types =3D valid_cpu_types; - m->no_floppy =3D !module_object_class_by_name(TYPE_ISA_FDC); - m->no_parallel =3D !module_object_class_by_name(TYPE_ISA_PARALLEL); -} - -DEFINE_PC_MACHINE(isapc, "isapc", pc_init_isa, - isapc_machine_options); -#endif - #ifdef CONFIG_XEN static void xenfv_machine_4_2_options(MachineClass *m) { --=20 2.43.0 From nobody Tue Dec 16 21:11:18 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass(p=none dis=none) header.from=nutanix.com ARC-Seal: i=2; a=rsa-sha256; t=1752228391; cv=pass; d=zohomail.com; s=zohoarc; b=YdrQadr197Z1jK3clbcR4Qih3Xq+JBYPD44ahFjewXeagzm2p2sFTg+wjvc9g0K2gMG2a6CljjEsZrjC4FU/O4Zg+56KY2xy2A/dTGVjRKJzMxJcAMgbUTeJ4oS3uq1fxN/0+iA4ST+slsc4OQ0x9pBQNt5AhXKr2gjDT5QrVno= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1752228391; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=+C2StQJlnhWCYTDUl2nS3SX0b1JDV031vxwB5QhlZAM=; b=eiavzCa6x0yae0SY5AEYRmVxmDe6sipbPLWV6TleW+w6m1Pf/Ps2SZAuWl2i8YckxOkEbIk1mz/7FbCrZEaSzC5HjWwNnEXupxu4WjbV85fYSV3BB6gMy6VTulI1BYoekYua9u6gVRC0riy4pjFz1iNL3K+7w40+cOeWwUqOn34= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1752228390945467.9732403129548; Fri, 11 Jul 2025 03:06:30 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uaAXo-0007Ny-25; Fri, 11 Jul 2025 05:59:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uaAXP-0006a4-LC for qemu-devel@nongnu.org; Fri, 11 Jul 2025 05:59:28 -0400 Received: from mx0b-002c1b01.pphosted.com ([148.163.155.12]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uaAXK-0004w7-6H for qemu-devel@nongnu.org; Fri, 11 Jul 2025 05:59:26 -0400 Received: from pps.filterd (m0127842.ppops.net [127.0.0.1]) by mx0b-002c1b01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 56B7eBCR024640; Fri, 11 Jul 2025 02:59:17 -0700 Received: from nam11-co1-obe.outbound.protection.outlook.com (mail-co1nam11on2117.outbound.protection.outlook.com [40.107.220.117]) by mx0b-002c1b01.pphosted.com (PPS) with ESMTPS id 47q3cf11aj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 11 Jul 2025 02:59:16 -0700 (PDT) Received: from PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) by BN0PR02MB7918.namprd02.prod.outlook.com (2603:10b6:408:161::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8922.25; Fri, 11 Jul 2025 09:59:15 +0000 Received: from PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88]) by PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88%5]) with mapi id 15.20.8901.028; Fri, 11 Jul 2025 09:59:14 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint20171006; bh=+C2StQJlnhWCYTDUl2nS3SX0b1JDV031vxwB5QhlZ AM=; b=L0/KKUAX7emscj/wzV4ZXrTPou9SEfKvJJt4kh3az7qRkeW6gl5aKozZn EOv+0t2Qrd+zF6mTNoZXPrkiMcjeX6Aa4Xb+Mn89WAOFvVzwZVKOFc6fhylD2M/A uPw+DWrl7J+snHEjhyuY9rzLQRv3dYJ1qdyxGKtc8C68sGWvHDz9zB+3wZGeHvA6 DSr9d0oUveCsUVXetxJU6xJmv4UeLs8dnoqBFU6AsNB53Cl5aYqom7F5PwEBzJbV f3bLfV7ef6DFZb/5Ouzf7Mht1a4Usn27ZOHVphZBBBK3XsmaAu5+9SDksTc07Obu +viELKyCb4AEUfr0yRwI9rNzvkBMQ== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=nKaEKBVwf70fDzGYBBGh+bEM9NRiSzBd6lRGUsQZh+IvqRsrcpXOb3G+EuoCSjmXwBvsjgd3qZgEeI53U9vM74Gy0Le4QZDtiAUm3zWZlufXa3wuklt9DmsdNY5E4BfpLKaBauMQzj4bSJ/yCev3XLr1eGIW5mmfZ2wxjruTgzyqNqRj7+8ppGfwePXvFFlN4bMLbXDFSf8S0SvWk/lgmodJKw3JBkoqadLgyKd4BmHNZvlUtiTE8XksLc6CHEG+f6AF18Ouu1Up9KzmZtFKOvLvSeOaju5PHUD+hn/a3FmKB0JGKsvZCLv4+52pUSY2f0tjcwWWyeYJavfMnny+KA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+C2StQJlnhWCYTDUl2nS3SX0b1JDV031vxwB5QhlZAM=; b=AtGed0r5sOEmnUdjqlTD2CJN3p85or15BgIK0KKkWz/oLLLvX9aqn7zG3p2Gj3P5ond2CvWbuO6Vv7UsuG0qFhze3OJmfMy+njd4oune8n003C6eUvGnPzfQPvOnEiNupwX1vsRz+Y8mrW6d+u9wPvtQbhiL+uyBSDxaWj1u6Suh87ll9QlQ1RUAE+tlSlDJ8JYekbD+b15BuyD4gSB/MfuXZiCiOQr4AK9bGdU76Mpj+gE12pCJCDbnUzobpM/k1nP2HBInN/l45KctW9qaFnqWh+wyxNaow53DnK981Y+0Dfm0/5kWN4Q95HRajxVncPuF5eFbegPilN0gsnYngQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+C2StQJlnhWCYTDUl2nS3SX0b1JDV031vxwB5QhlZAM=; b=N+cXTVbiIw4S6pZGNox6pDIe4/yxzIUjr1eiKtdcU9PqQ8JHwpmbVUoC4qG9JSPzOLmXuRVRZw4T7uMUtEiJTizVzsf4YhbhlDK5mQzFArR4hTS1OBjPJiG/aLrDngPe3P5NI8s/HqK508RvtLE1lInE2B1IlXGwIX89yvZJuowYgIM+z8UbbS3i2d1TSaNjWa3car74fdEPDnRHb81G9ZH591XnNBjXVEiFjBErZUuKmFF9a2fA1zs16xADxu1zLnkx/ml27OOWs393KHYFIUiGvtP5dqDoRgNCnTiMOWMgJQHim2jR7TJPQOHPVWWKEjpA6RbKkxWRr/uhzCOaZg== From: Mark Cave-Ayland To: pbonzini@redhat.com, mst@redhat.com, marcel.apfelbaum@gmail.com, eduardo@habkost.net, imammedo@redhat.com, qemu-devel@nongnu.org Subject: [PATCH v5 17/19] hw/i386/pc_piix.c: remove unused headers after isapc machine split Date: Fri, 11 Jul 2025 10:57:19 +0100 Message-ID: <20250711095812.543857-18-mark.caveayland@nutanix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250711095812.543857-1-mark.caveayland@nutanix.com> References: <20250711095812.543857-1-mark.caveayland@nutanix.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: LO4P123CA0582.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:276::17) To PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR02MB7159:EE_|BN0PR02MB7918:EE_ X-MS-Office365-Filtering-Correlation-Id: 02336774-01d0-4743-956b-08ddc06197da x-proofpoint-crosstenant: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|376014|1800799024|366016|10070799003; X-Microsoft-Antispam-Message-Info: =?utf-8?B?TEttVC9IYXRVZkh6aDh2amUySEZ1eWJHVzMxbk94am9CR1p3ZWlZcTJod1Nl?= =?utf-8?B?N1FkYnIvbVZtcWUyVWZjYWhOQ2Qzc1NGOUhKM2hCSlZFQ2E4VURTSWUrVlBa?= =?utf-8?B?M2MwaUZ3Y1p2YU5IRTkxM2ptOERIOHQ5U1ZYeTQ5ZFpOY1pQWHhkN0VrYk1C?= =?utf-8?B?T0pOMXpQcmVsSnVBekkvMi8wQmVSNGt4WHgvY2NETmFkclRycGljaHBPampj?= =?utf-8?B?MWZsbjk1UW92dHI4US85QlZ6ZUcyR0hlSS9BeEl2N3RFamkzN1NuZUZUcnMx?= =?utf-8?B?L2VLdEJmbkZIWUYyQTdaQXZ5djY3UUt3bStIZXJ6MURUTzZIZFZKb3p3RVQ5?= =?utf-8?B?dWc5cWdFM0VHejBBLy8velN0YmtvUGZXdXhralFlNklqZUZORmRqTjRZZ25C?= =?utf-8?B?a1dnY3hLZG4rd2Z1UnFUeS95OEFobVh0b2IwdGw5STNGNUF1SjBZMUZSZk95?= =?utf-8?B?LzRYNjE4THJTQzJXWXlET1ZPQWorTzNZbHdBYVRFTUNqZG16ZjNpVjdhMmFv?= =?utf-8?B?alEyb25udjlqS01mOURGNVRUay9FYXZYMXBGamp4eVVLVFY4N0tGc0t5aDFw?= =?utf-8?B?anVDSTJQeVFSZGREdkFmNVhuTkFnL1Z5eFFUdGdWdDRLd29vc3U0UGpnMnFU?= =?utf-8?B?TFB1SHp2TzNtUFF3UWZMbGhNb3p4SzZRak0vL3NpZzg4UkJsb0ZSL2p2WUsr?= =?utf-8?B?RVpJcm53TTJvVTg4ODlBSjdMUUNNQzBUS3cvU1NpSUhuNlIxMldQR21ZZkVa?= =?utf-8?B?c1dpNUxnZnIyUnFEUDB6YXl1c0lEUEJTTW9ZRkZxNFpJM1hGeFNIUC95UDhI?= =?utf-8?B?TlJ3U1U0V2dMMWNHQThaNjVSV256ZXd6bHBmK3FQWUpQWFM2bEp3Y3EzeDEr?= =?utf-8?B?aE1tNm9WbmVwSk4wM1Vabkp6Q0xIbEI3MTBCVnlhMnIvcGRoanJhYmVlM1lk?= =?utf-8?B?eURoK2gxeFpxT3JEVUp1SHJIN3RYcU94V29PUjdGa0FUbW5uQkFwdkFWc2pw?= =?utf-8?B?Sk5XMmdER2tYd2Z5TmJFUzUwN3NiNmdKQWdIWXV1a2N4MjdxbEZIZVU5TTFO?= =?utf-8?B?eExpbWYzWVovYlZKL2RPeVowekRJYitTL2hIbitGMC9jMXk1TlN5QTExL0dl?= =?utf-8?B?MnArOXhyRmdwSWxYd2tMK3loVDZHcW5tS1dHNXByU0JScFhKNW1lZHk4dkgv?= =?utf-8?B?RGpKYzdhb2RFRGpDbE9VS0FvdUxaUVYwZktuTitKS0t0QUU0b1RTTnpXZ0dN?= =?utf-8?B?bWRvVkR5NDd2ZzRBV0ZCelFLd3QveGpzUmFBa2pDZ0hSZk53L2JPU3ZBeE94?= =?utf-8?B?VTNXejNzSzV5MmpkMkUzaXB3cmNxME0zYXJqczk3L3pla3I3OWFMaG1LZmQ4?= =?utf-8?B?T01mUWpLTDhFdE1jb1VDVXRqMFQ3RVpROW5nbDNkRFFUSGpVcGo2cmF5ZXJJ?= =?utf-8?B?d0VCR3d6aFUrTXFJWUo4dUxwL2c1czVoSWFmWGk4cktkWTVZSXNwY0RucW1C?= =?utf-8?B?K0UydWF3WTNyUWUvOWlhQStyckdQelI0T3dmbFNFcFFocm9Hamg1SVZtOTVl?= =?utf-8?B?V29pVlpuOTdEQm9NUlYyclZGQmozVjNDTUl1RjAxN2J4cWo0RzdxWHpad2h3?= =?utf-8?B?U1RXMjg2VTFtcEwzZG5WYitjVWRJTmYrY1pzVFMrc3ljdHZ1TmdscHhvajZJ?= =?utf-8?B?dytZblh5YlBQMkpmRUJyNFAxVVR2czVZQ3NDRmp2d1RkaFhENGNQYWRSWGZU?= =?utf-8?B?NlovdlA2WHUvQUE2Q3RIcjZJUDFiZUtwU0tWVVVHRDlBazY3bjQza1JiSFJE?= =?utf-8?B?cXhYeSt0OEhqd0k4aGhFLzhtc1lndlN6RTg3OGIxbzh3aDd5MmxoRS9BZjJ6?= =?utf-8?B?Z1FmSzBsbnY5TGJKTmJ5ZVVFZU9TRUFEajI4NTlVVU5aSUpFcFZuNmtJTTJ0?= =?utf-8?Q?QfBX5fULzEM=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR02MB7159.namprd02.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(1800799024)(366016)(10070799003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?b3VDQ041VXJKZ0QybGhvRFZITGp1ZFVISGtXTkttQmYwSnluMmJaakNCOXEz?= =?utf-8?B?ZW1LTnk0SkRtWmtvVzJRck9FNXhkalBsUTdlRmxXUWpPSDk3WVdvL1ZxTm1i?= =?utf-8?B?dElMemRrLzFIUjk2VUROWjJha1lJOVA3UVl6N2JpbG1LVFErcnpCMGlPV3dl?= =?utf-8?B?OUlkajZCOWJpNVVLR2U0WnluSTFRZFYrV2ptRlhaTFplQnRzeXhRMjIzU1BD?= =?utf-8?B?WmRaR0pSWDJXcDkwUkg5VTdrN0QranF1Tk54Q2JiWG05US9OalRPekJqelZM?= =?utf-8?B?Ui9yR1QzNzJLbnFGU1NEUEVYd2szUW41UHJ2bTFsWVNhYlVnejNvNVNpWjN4?= =?utf-8?B?cE1Va3lYR2ZyeXRQQzF0azFkeng4VzlLR2FBakZiNzM2MGRLS3ZkeWkzTjlu?= =?utf-8?B?STY0NVk0STVBZkdudTEzbDVPOUhOMjJYVGQvYko2ODhVNzNSMjJzYXluWE5I?= =?utf-8?B?RGxFa3dkb0pyWVp2YmIvSk9LcXlJc3VvV2NJYXM1RVdKaDN2eXlRMjUyYjlH?= =?utf-8?B?Q1lLT25yR1JGa0tRb2lUaCtGSnlCVVBBdkNmK3lTdXhscnlQT3ZEZStISHZN?= =?utf-8?B?d2t5Uyt3ZkQ1YUdkZXJKcXhLbENhamc5UTNnSXRNVVZURUhmaU14WTY2RitC?= =?utf-8?B?RG9JQTZ0Qmp1QTVQYlBlbUNPdVNMYnpmVmU0NDkxQUV0SlZHWEZMeGdSN0ZN?= =?utf-8?B?Z1YwSU9KakUyZFhCTlFIMUR0dnJDa1ZSZEExYUx4aEl1TUU0VVVGNURxRGFo?= =?utf-8?B?ZHZZaVN4d3ppVm9CUWtENSt2aHdvd1JtMit5cnZrYkg5S0xCdmFFbEUxWDRj?= =?utf-8?B?Y1RmYjdZZ20xZVRFend3cVpJR2hiRkpsb3hjWk5OVFBDWmtnRDdrdWdIZHBR?= =?utf-8?B?YmdDUDFSQUtkMXFlc0pSS016aUZBQ21EMDNPNzBnenB6SDBZeDk0R3c5SHg0?= =?utf-8?B?aDFCZEJXWWhVRDg3QTREcS9RWHZLVk5kT0FwZVZIME5XbUw1ODF5eWdLc1M3?= =?utf-8?B?YU5PMUtvUmtBa2NPUGNBMDJ4ZjBZMzdTWHlsRWh6bnMrUjBLN041azdGeHFY?= =?utf-8?B?YnNoQkIrU2hCdlhZQkp4clJVVlkrMjNoYUZQb05KbTNrQkJKM3ZMcHFLWmhr?= =?utf-8?B?WS95ZWI1MWJrOUxiQ0ZPbzVjazJqclhEVjV6czl1TmE4Mks0NThOVHJRdE9s?= =?utf-8?B?OWxEUzhkWXZBMzRvMEdEa2dRR1p5d1Zqd2MrbFFCNVJTMUFGclhwTVVMZStu?= =?utf-8?B?bURJemNLUEVaWG80QlRYUFgrbHJoVzNDTDFFUW5UeHVrZGZmWmxvWVFlMUxM?= =?utf-8?B?K2kwaDUvcDBmODF1MHgvWWhORGgzbUk4MDE4c2lIekRVeW1HbmQvVXR3MFpL?= =?utf-8?B?UGNnbnRPWkpvTWVoN0NJMnBYa2lmcUd0cDBnNEhpOTd1b2VKR3dCdVlrdGk3?= =?utf-8?B?THgxb1ZBUXhob2lhK2pJdXh2MlM1ZjUvYTM5MlFoQXpZdDRIVGR3T0diUDIz?= =?utf-8?B?akxpaklKVk9sd2tGTnRFbDZmRWc1VVVCcGN5RGFKVDBDN3lHSDJuSWJ1ai9H?= =?utf-8?B?QXRyMkZHSUYra2Vpa0gvbjlRam4zN3M4dWtTMXJIVFM1MFFMMlllV1FORjBL?= =?utf-8?B?NHAyUHR0dEpaV3M3OXozTkc4QmN1N0hRZUdBTFdRUDRUdkY0eC9SSitXWG9z?= =?utf-8?B?cmdRaEd6WVMxLzBpWVdnMytCU1FJMGxYSHlaUm10MFkway9jdUxybmlEQ1Vn?= =?utf-8?B?MFRCMDB6dkZxUkdIMUFQUkg3c0p3MmdIZGd4OVk2Zmc0R2o0aDFZci9TeHhw?= =?utf-8?B?cVR3Q0hMajRhaDVpbGNEVHNvSmkvaS9LY3V3M2ZpOENNU0UzbC9adXFMK2FO?= =?utf-8?B?UnovV2pwdENRS3VYUmdqZExCd0toZytubElYMUloRnVzWGdQL1JsOUhjTWJX?= =?utf-8?B?blFoMWEwNnpxSUVzeHBXTk5hbk8yKzlSbnlBcDNNR2Vlc1hDT2hnSjJ0ZU91?= =?utf-8?B?RGxwdWNaR2JwU3FaWHZIVUcwR0hsTmlhWnZveWZBZzJUT1dGdVlpenljeTd4?= =?utf-8?B?RFF5cEFRc3FoK1RtT1dHUTNpcVpVVDhyNmdkK0FZTVp4N0o5cENBZUxSOTVB?= =?utf-8?B?UzI5d3A4T1QvQkFzU3NZakJaeVhGdGQrbGF0TFB6K0UydlQyeUJxSk5LU05j?= =?utf-8?B?cUdWOU5LbitkYjJOS3lpR1YzYkMrdkgwR0cwL3ZNUFNwdXRqckR5WVhHbW54?= =?utf-8?B?dUdYeXFVYW1vaEZYdk1wVTNzTFdBPT0=?= X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 02336774-01d0-4743-956b-08ddc06197da X-MS-Exchange-CrossTenant-AuthSource: PH0PR02MB7159.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jul 2025 09:59:14.9296 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 0zx+Wu2wq/XmF8VbNF3YhFDwtAUsioSHe2BMP3gwVLES0OwuQu4gEzeBCYn00C/wMxRYf6epaISQqN7LViIFKJBRLiaC9+PCvSGHVxyFWak= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR02MB7918 X-Authority-Analysis: v=2.4 cv=U9SSDfru c=1 sm=1 tr=0 ts=6870e074 cx=c_pps a=Gqw+4yJV85EtGHpvYtJK2w==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Wb1JkmetP80A:10 a=0kUYKlekyDsA:10 a=64Cc0HZtAAAA:8 a=KKAkSRfTAAAA:8 a=W95sc-WnjIl6KLOMV5AA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-ORIG-GUID: Mkxuhsq2XemCVhll_PbGN52yzKkjqk2I X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNzExMDA3MCBTYWx0ZWRfX+yCvyfDbD/YF s80Y4beu6R9YoIa72PT21YtD/LM/DgPN9HEDTRk2uJKzLha8Dic5ue2RQYTLFkFEuHT7g/xXx8T J09f/EqHA02MOnEsqijPaXSLkDy7Oe1AgkPhxxIqQMt21igO4AGYE7HuoPxY8T+RwadPFVMm9+R DT4RR5A+6HEFWni0qsG7Hdm2l1zb81D1BsV3HMzzRvnjf7iFKZ3yY5VtkQg+nbkchjaS9Rj5uKn H0hJM6EIji29Mf4hFNrTUV2ZhNxGYJXUVfgTx+P5hep+yv/o/9+v2RZgeX/CZBz8x2HUZGT9yc2 CxCRgLlcD+A9k0B1vx+l3nxxnL73+5lQaXmlUUOktiQ3bTBL074o3EYkBycNlN8zOShPmBwK9J1 uwL6At6YZGAkhJW4KxNQnj+Js2fj4Q5i7BZLbdx1CHJpBG1n48hMWbgyUqgn3sSiy4FXK/or X-Proofpoint-GUID: Mkxuhsq2XemCVhll_PbGN52yzKkjqk2I X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.7,FMLib:17.12.80.40 definitions=2025-07-11_03,2025-07-09_01,2025-03-28_01 X-Proofpoint-Spam-Reason: safe Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=148.163.155.12; envelope-from=mark.caveayland@nutanix.com; helo=mx0b-002c1b01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @nutanix.com) X-ZM-MESSAGEID: 1752228392300116600 The headers for isapc-only devices can be removed from pc_piix.c since they= are no longer used by the i440fx-pc machine. Signed-off-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- hw/i386/pc_piix.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index 4c7da53943..17975ba0c4 100644 --- a/hw/i386/pc_piix.c +++ b/hw/i386/pc_piix.c @@ -27,19 +27,16 @@ =20 #include "qemu/units.h" #include "hw/char/parallel-isa.h" -#include "hw/dma/i8257.h" #include "hw/i386/x86.h" #include "hw/i386/pc.h" #include "hw/i386/apic.h" #include "hw/pci-host/i440fx.h" -#include "hw/rtc/mc146818rtc.h" #include "hw/southbridge/piix.h" #include "hw/display/ramfb.h" #include "hw/pci/pci.h" #include "hw/pci/pci_ids.h" #include "hw/usb.h" #include "net/net.h" -#include "hw/ide/isa.h" #include "hw/ide/pci.h" #include "hw/irq.h" #include "system/kvm.h" --=20 2.43.0 From nobody Tue Dec 16 21:11:18 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass(p=none dis=none) header.from=nutanix.com ARC-Seal: i=2; a=rsa-sha256; t=1752228017; cv=pass; d=zohomail.com; s=zohoarc; b=AM5OQZzDtvV0jglweqQhQQE9nr691vsyy82fpsqmewGCFDNZiZGZJp981iG+DSoIg4EyEfXg0vSdH154iomZ9RZ81/QkmuVVRz0iNuazfByVSVAygJBCVYDeSBIvicIH4JHLxZusj1cEPC0CDTF+UDaTUaFhjDAqolZ8uQ2a+Q8= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1752228017; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=la+0nnoAWZ183b5WEyboqRbwURPx8+4PFuLLE19wEzM=; b=gG7SGgP7K60rtcxaoDEMn4oaRZOsAgv5kMR58FRUhRunt1fL9vR8fVIz+55pMy1XsIxq0UgLPek59pI8kS36Ujso2brdBugoCESfB4hCMxdEOcTCGnzIPxLBGYfzveA9UxngDvdm6wjeO9xvgbopcuydx3C3Yv19lIv/FYXYpFQ= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1752228017498429.73577935860396; Fri, 11 Jul 2025 03:00:17 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uaAXn-0007J1-33; Fri, 11 Jul 2025 05:59:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uaAXa-0006qX-8G for qemu-devel@nongnu.org; Fri, 11 Jul 2025 05:59:39 -0400 Received: from mx0b-002c1b01.pphosted.com ([148.163.155.12]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uaAXX-0004wC-0C for qemu-devel@nongnu.org; Fri, 11 Jul 2025 05:59:37 -0400 Received: from pps.filterd (m0127843.ppops.net [127.0.0.1]) by mx0b-002c1b01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 56B8McKu016805; Fri, 11 Jul 2025 02:59:20 -0700 Received: from nam11-dm6-obe.outbound.protection.outlook.com (mail-dm6nam11on2127.outbound.protection.outlook.com [40.107.223.127]) by mx0b-002c1b01.pphosted.com (PPS) with ESMTPS id 47ta49k6fw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 11 Jul 2025 02:59:19 -0700 (PDT) Received: from PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) by BN0PR02MB7918.namprd02.prod.outlook.com (2603:10b6:408:161::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8922.25; Fri, 11 Jul 2025 09:59:18 +0000 Received: from PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88]) by PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88%5]) with mapi id 15.20.8901.028; Fri, 11 Jul 2025 09:59:18 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint20171006; bh=la+0nnoAWZ183b5WEyboqRbwURPx8+4PFuLLE19wE zM=; b=h+1nL9onTXebzLyRU0TDQJp4gEWNomkTBVVcJJ3YXAtHgD9FaUW+4wOTe Z1PGx3vBWNbJmfkPd8NdygEsbBF5cw//YAi4L9pyzCeaEWXlPYv6kNiiXnrEh/B5 lA8yT83HH2lnzhRLhf1pyq7kBqihD980XiLS+391zSPE4wYinr8DwW411Yn6oCVq H0MUKKz8RpNqykanmsEnv25V9GeRSc0NCphVoQKnnUJSpVF+tIL9N9LqhHfT+BE2 Fxl7XLYYklbrnd39YsqM9FXya5SNRFtrHEvP1m1FrXyUFl2GZXCNfccEio18FJSG Pt9EcK4q+lz73rd2MY2Tr03PmW5tQ== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=BKHNijtOHbcEjg28hyfwmyvVMwiEcRZzDSIu1UwgqXvii2DDsCTeYorchUfFkIM62QpTmbRsl3O1gULKwsg8ALxKQ8ISdjn1MFE34sKQU4dkRmAFQkRu9mRZ2mzPtjvH3FUJ2oeyRr/w12EnZZCgTPz8JpFIWmMYfp/yVKeH/tDdvKiGex4n2n2jaelQP5tBMrDs1MXRzVJct1KBGuC66C2ww9suHViaSmj0Bqw8nSj6sRaLodiLqAx6ljNpw4FUJf/YHChRwH26znHTU8xpXLAXHZgDItg3PqyUaVuF4UFfVgKShOZDeGoZLhEImUt+9ZWO2HU5eEtnWrYGYF5z+Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=la+0nnoAWZ183b5WEyboqRbwURPx8+4PFuLLE19wEzM=; b=CdFcvU7X/kFB3i00/vbVfvwHjU8HmxgAiDO3/3AGiy3I/7Wj6LYlcKbVWagFyEK6BxKl0pOq7vLlbwUZoft7gx1VAugzxjkRqTpSqrqsQKwlAfyD+BnASP+wm1p5ovSHFTkgURM4rJhTV9oDBwHuX8IFbWsuZzeUwlyVEOt7iIMYCPnbG713aoEvQT7fZI5vnxzpSifhmu5Ztpi08+cB2KPVNYGpVkel5arIG8r3Wo/CjwBHC6hNlQj/zHkSKluM91x69H5CNeKeTz+NnAJ2Qmv5DpSI7TJoAD93ciRzp3k7vmHxdpm+uwdGeNx9jB+aEIDZi1gscg1+1YzpByOXLQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=la+0nnoAWZ183b5WEyboqRbwURPx8+4PFuLLE19wEzM=; b=tNrridEyqcnNdY89EawW1HGl+McTsC+dQIA4eYol3lywyJmJcn5aSFsOLUSmKNbHQWbyQuRcFv5vJ+YAjNXoT+rs0WmjWoExhPAmFHFZrYpozwdakRUJYTQnqjCTPycpZPxAYppdAnGCz88vr7F6LoTFgvYHv7aUoORYY0A/K1dLR9VJvcl7Zkijros1OXZyZMN7CUW3jPKR7HtO5H4GBCxkootSvq9lVLqwYN1cuqMOBKv/f1xGDe3/lt1fMEB1ItE3pQZUFn4L+zP5xixIYV9XO5vSJrjnkxYT6AGgRTwWwu4usMTRy0n0NoBugWgKqlVNx34kNrVbELX5Jhs0xQ== From: Mark Cave-Ayland To: pbonzini@redhat.com, mst@redhat.com, marcel.apfelbaum@gmail.com, eduardo@habkost.net, imammedo@redhat.com, qemu-devel@nongnu.org Subject: [PATCH v5 18/19] hw/i386/pc_piix.c: replace rom_memory with pci_memory Date: Fri, 11 Jul 2025 10:57:20 +0100 Message-ID: <20250711095812.543857-19-mark.caveayland@nutanix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250711095812.543857-1-mark.caveayland@nutanix.com> References: <20250711095812.543857-1-mark.caveayland@nutanix.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: LO4P123CA0580.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:276::16) To PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR02MB7159:EE_|BN0PR02MB7918:EE_ X-MS-Office365-Filtering-Correlation-Id: 2b264ed5-4ab3-4127-7230-08ddc06199ad x-proofpoint-crosstenant: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|376014|1800799024|366016|10070799003; X-Microsoft-Antispam-Message-Info: =?utf-8?B?Q3hZY1lSaFc1bGRVOVh6cndnQk8xb01EVWhRb2R4QjBvOEVkU0d6SFF2b3FU?= =?utf-8?B?bHF4bzJjcjc1YndKejJucms3S0pOdGJVWmFrVjR6SzJRbktRZWFyeWNnOE0y?= =?utf-8?B?cFdLTUxRdFVQQ0JTUkRGWDR6Z3ZDTUlISEVSR3RYYk1BRHFxVWQ5cHpLSFFa?= =?utf-8?B?U1VPd1ZrbUdINm15OGVPNkJwSVZ5REdXQTU0VDcwZFl6TUdwQzdud3RRQ2hB?= =?utf-8?B?ZFZmUHhadW9MZ1V3UnZtTTdoOFNqcmVQbDhBcHplZ0NXSzNVcW1yb2lWcUpE?= =?utf-8?B?VS9UbnJHVVI3UHhJUVlZc09tR1ZSL1I3cWxNVzN0Q3MveG8yay9UTVZWWEtr?= =?utf-8?B?UUgvUHE3L3M5VlloR2FGRjN6NWxZNXVwbEx4MHduUC9oZ2I0aGpYNEh2VnZV?= =?utf-8?B?aWt3TWZKOHVDek05ejdKLzNwRTY3OWhWMmZsWHZHSDIxcE9hVUNENHVFcFV0?= =?utf-8?B?N0NHSlhyZFF2VW14Y2UwNTNEcTh3TmRIQjE1cjJwUndRS2I4NURMUzdid1lB?= =?utf-8?B?S1NYYUNGanN6NmdQMkFGQStvc1I5ZHJYcjZiVTJCTlM3aXVSU2Y4ZHlTaXZQ?= =?utf-8?B?Mlcwcy91QmpsQ0h5bnNXY1VtamJidUh4d1puOEE1NWxrOFVkeThjbVg2OEJu?= =?utf-8?B?bGlqWnJDejRkTWtwbkJWemlvaThxOVUyRzdsRDZadzNId3A4YlgrbmVDUEJM?= =?utf-8?B?Y2t1NFNEMy9Wa1J6MFo4YThpUWkrdFlEUjE4enMyZjFzRDM5VVR3Y0xDM1Nk?= =?utf-8?B?SDJ5K0RYdEQ0RnUwZ1BoUUVnNy9WcWRrUmhaNytyaFgwSmlwRTQwOFQwY2ZT?= =?utf-8?B?L0hON0tRNFc5Z0hPUDlFNHFCN2IzSmw5N0piTitxRlRDcG5EVVRIQnFnVW1I?= =?utf-8?B?WHlLa1k3bXVacS9HMXlaclBLOGZ3L0ZCQWFyM0pvZVI2K3E4ZEZHWURGVEZi?= =?utf-8?B?TzBqVHNycEFyMFpEUlBSRTRFcHp1QUNNUWtMRG9KTmc0akFuVG1FT09hWUh0?= =?utf-8?B?em9laVQ2ZXNvemdFR21hc2RKMUtLVVBqZENiVmZudHZlVVNzZHVnUitjVlk0?= =?utf-8?B?MUN4S2ZpbmhuQ3ZaMFUyR0Q1Sk9pWUZtRWVKajJ5UWtMRnhaNHBIQTNhbVBT?= =?utf-8?B?S2RVTUsrV3NvV1N1YVpNWlo5YURFUTFDRk1qcDJXSDJTNHE1UnY0RTk0Q2xy?= =?utf-8?B?ZVdOUzhFM1dGNWpnbktPMlZFK2E0NkhyNkQ2RkZTQjZKb05jb0R3YkllWEhW?= =?utf-8?B?Z3A5d0J0L1FIS2Ewb1NPcGkvaXhOdGhjbUU3dGoxWkVqaHIvMlhMRDdzcFFN?= =?utf-8?B?b2hnSXBHT1ZiZENaU0VRcjZmYVh4b2F3WEhiaE52Tnd2NmVoRmMwQlByeGZH?= =?utf-8?B?d0Z2L2xEVHZQTWgvUGdhdGtTSGZsajlYc2ZSY21YYitvaWQvVWxyaFd2TEFw?= =?utf-8?B?M2V3L0JQR3dqNW43M2czUnh1eXpweWZrelI5VFo3YjhZMDloK29OZlMrcldy?= =?utf-8?B?RElNU3IzNmhESE9LWVJyZkhmSXVxWUhtRGlUdmZYNHNMWmRGSHFmbWxLbnkv?= =?utf-8?B?S1p0UFN2aHhLWWJDQktCU1h6R1IyZUl4TXJsaXpPRTVVeWJ3ZHc2QzdxSFNi?= =?utf-8?B?SFg4bCsvZXV3WW1JY1d3bUJCSGtDQ0R0MXpIWGkxNWMreGV3cDVYYnZTNFJz?= =?utf-8?B?dGphaVora0w4cDNNZjNRLzJ3L2xzRUg1ZXZHdWJuY1ZMaGc2WmVzZXo3YVFP?= =?utf-8?B?S3h0ZS9id1BGQU5PNnovUlB2N0NUdlpVZ29aa1hyZ3B0Y0xUN0FuaTBYc2lh?= =?utf-8?B?NTFhblpMOFdhK1piME82MVNxanJhVmhWbHdCVEJTMlY1UU42aUxVMlRKc29N?= =?utf-8?B?RTduY1VFQjcvNjZHZWJWYWZucWkzRmxVK0Z5TzZSMFRTWHcvc1d2aUJ4K1Ix?= =?utf-8?Q?KlCn65hYH14=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR02MB7159.namprd02.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(1800799024)(366016)(10070799003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eWhYK3pDV3BHWWlvaHkzUUlON1huLzlTVmZ0aVdnN2NFQ1pzQVZNelo0MEpR?= =?utf-8?B?NTcwQ0htTVlUaUc0aWUwd2QwWmJsclZOMDk0TDJZdTVGZ0gxbnZwQldMNDVa?= =?utf-8?B?c2t1b3FabkFRRUw3ZnpaTGFEcUV6c2dLMkhsVnBtWk92eWpxc1dGUFNJNExC?= =?utf-8?B?Y2czT3NINnQvbC9wendCMWR5cml4Z3NVR21qbFJHbHM3UjdnRkdPcldLZytV?= =?utf-8?B?V3ovMVlKTmtXRFk5d3RQZXlTY1cweFNiYUxiQitZVENLcVd5bjFzTEtESDAx?= =?utf-8?B?WmM2TlJUSTZocWFhLzFwa2Z0dDJBTDRKRnpJREVCZjJrRWsvYjVNYTRLckJk?= =?utf-8?B?b1RVOURscjl1TlVkdDlWcC82NXJERGZ2c1dieTVPSDZHQzU0NFU5SXBNeURX?= =?utf-8?B?eTNidndzeGF4KzJuQ2Y0NHJqSm5OQTE0RVc1aERpY1FlSUZGd0lUSWh3MzZK?= =?utf-8?B?UjE0TW10MGIrTXYxM0t5dlZ2dTR0ZldCNzFhMk9OTk05cjVaa0xNakZ1eEs3?= =?utf-8?B?RkxscjliSFRZSVdpZWNJRkpuanFObEx2YjMyc3FQSEVZbktCSEdveU9DdHJq?= =?utf-8?B?ZnBVWDBvdllKdXBsbGlhUHJuZTZhMTEwWG5RVXFId0RVeVhleG5ac3BRajVv?= =?utf-8?B?NXlpZktYanViMWNRRDVDRE5qRGppNnN2QjgvQnRzNk92Znk1UndSeldETTM2?= =?utf-8?B?azRtbi9mUEpsY1NTQ3gxc2ZWYXo3cEI2eGw4cVFhdmRxUzZYZ0dzT3pjNEti?= =?utf-8?B?ZGZ1NmI3WHB4V2k5cVJianpNaFVuZTJETkduNFBibEFRVVFYUlNmNDNabE56?= =?utf-8?B?NjlqU1Q4T0g0dnhick96cnlITW1hVVYrY1R0T1hONUh6RUlKZTYzMElsQ1dV?= =?utf-8?B?d3pjM0VUK0lVVGJCZ25CcTkxNnRDR1pBdzk4Q3Q2K2pRZUhYZ0F1eDBxblYz?= =?utf-8?B?VHo1bHhLeXVwQVh5cEpHa0tOTVhRbStudlAvNlE3eWFpQVRHVm5FL2ZWeEIz?= =?utf-8?B?bXM5eTJ5Nk0vYm9KN2Y2R2FjZ0xSWjFyMXpuWFRwWGZobmpFNjlObjJ2ZDRu?= =?utf-8?B?U1pIOWwzTmtIcEt0K0VDVTFSL2dEalVMN2t1Qll6Ujh0THNpMDhiL0dCUlkz?= =?utf-8?B?NkVjaFA2M1d1Umc1Z2h2bTdsSUkvbWlQOWFvS09ydXBxbSs1bUsyV1hMRHpy?= =?utf-8?B?aDZvVFB6aFBiT1hTUTlMWWdEMFh1L2MwcEVQdW5HOEZvNnNWVEFPdUZMQVFt?= =?utf-8?B?Q1ppbjhmY1gzUC9lWUl4Q1BKTjJHdlprTzRLWDh1WXVlSzdCOFNwRGU1alIw?= =?utf-8?B?aGpuRldhdlN2RzZZMExRWUxBdXJFUWZPc0hiVjZKRXVyMUNlMnJWNkpQd3I5?= =?utf-8?B?K1Q1NjE4eEhLZTJqSXRJV1RSUSt5NEI2dG54cmlUUmNYaWJZT2NERTVxbzh0?= =?utf-8?B?WkNaQ3RFNXFTOHBubUMySlRDSDVjNm5yZCtjTE1jdjN5NEZqZGVNNCt2YzFZ?= =?utf-8?B?UVVqSFYvb0xyeDBINjduTVdPWWV1N083akxsSDVTaFMzdXp6QVowRHhBRUl5?= =?utf-8?B?UnZ2Q2ZGYkt2bjU0RGRsbUQzYllsb0swK3F4aWt5WlEwQzlMUWtxamx6dEdK?= =?utf-8?B?ZCsrRVo0T1ZMZ2RlM1o3K3VITHhCalYrYzlZVGxWYisxQ2ZYbnZFUEp2Q0Nv?= =?utf-8?B?aW5DbW1la3doOHd6Ny8wNjVvaEVuR1RPcmZRbitYT1Rra3hNUnc1ZFh6TlFW?= =?utf-8?B?b2J0dnIwMGNuOXVpdFptU2VSbUdLMnJUVGZTRW1JdVk0am12WlNnc3M5WEZQ?= =?utf-8?B?Y3hySm1Dak1JNjB4SW5ldzNEM04yRE5XRC9JWFJHSkpRWmZzcTVYdG9tajFR?= =?utf-8?B?WHphdnI1bkYwdnNCcFpyMEhoYlZmMEVxK1NibUJoRytkRE9IaldkTVFjZzdU?= =?utf-8?B?VzBWaTkwK2F6NFpHaXdrS1hieGwvMU1XZmF5MFNUQ1EwRWIxNGRSeFBqaW4z?= =?utf-8?B?cmUxc21VUjMzVytFbmdWZ1pIeFJiZUZrbXdLS0IrcXlQRHJOMGlnaS9ubFpn?= =?utf-8?B?MWxnU00xRTBSVm9ENWxCYTVMRCs1VU9nYkpyb3I2K3N3dWNVSkZ4SUJBV2dx?= =?utf-8?B?VUZ3NExVQkh5SUl2dWd3aU9rWjg5NmRkWnJkSlZyRHVsWituMEM2SU5LSUJC?= =?utf-8?B?M05STks4RnVyVlJ5QXJDZUl5ZldUc21rQjZVK3ZTRG12TEJqeUcwd0pCUXkz?= =?utf-8?B?b25KU3VqTitwTXVmQS9LOUYxaGlnPT0=?= X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2b264ed5-4ab3-4127-7230-08ddc06199ad X-MS-Exchange-CrossTenant-AuthSource: PH0PR02MB7159.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jul 2025 09:59:17.9884 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: DKdcag9exZrf5yx7myDrVlmPHEoGlliN3f8Oba4u77kK5k8M07fxGMmwVmolnXiTxlRrKxIkJLQo/MBlCTflDtk+6pTL8QsYbjFnMGktjc0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR02MB7918 X-Proofpoint-ORIG-GUID: CdngY8_MQf_HWTRNQlcEaYka5tCufvwv X-Proofpoint-GUID: CdngY8_MQf_HWTRNQlcEaYka5tCufvwv X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNzExMDA3MCBTYWx0ZWRfX9O1d/F8nhVsI 6x6ureaTv1m43Be5WEmzfoNF8ZQyriJBf4SBo4+sKlHH4iHT9i42v9MVjYhBtZNQ8cbVeH//zBE bWPNT7cfj57Rg1I4fEkIJI5+bJywNh2/vlR5rO0JKjDlVoXgkLtvQWO3aMFBTGWM5HDX4xb3k2n nOIQqGXlJ6dKH1lXura0DXmcaXZ485B4b77e1U6j/8uWAnIwj8PHJk2WoUMDqflj0I1Bgr//fPC gBKOje5XyaxH0zcsSUZpb3/A9F9sZKka0TjEanjjyh7q+4MZvTEijlJNXTF8JQiU++qJxvTde74 CJJ4WvFwYnPlWpx+k5pWWqy7rp7tNwOq1JxZjDGbRDwlGypVFeoo7gic352ESgrlHbDT5wj5NAf 6cdLPx5dUTSh0rmn+qq6qG3gVud/H7MNB/w3qSYtSQDC7BjAsN9cbJDcAV7S1OtGv8r6n7WH X-Authority-Analysis: v=2.4 cv=fNg53Yae c=1 sm=1 tr=0 ts=6870e077 cx=c_pps a=Az903AZYGncP8juWkLdPyg==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Wb1JkmetP80A:10 a=0kUYKlekyDsA:10 a=64Cc0HZtAAAA:8 a=KKAkSRfTAAAA:8 a=9K-6XCuZSqnjzfDIaq0A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.7,FMLib:17.12.80.40 definitions=2025-07-11_03,2025-07-09_01,2025-03-28_01 X-Proofpoint-Spam-Reason: safe Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=148.163.155.12; envelope-from=mark.caveayland@nutanix.com; helo=mx0b-002c1b01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @nutanix.com) X-ZM-MESSAGEID: 1752228019545116600 Now that we can guarantee the i440fx-pc machine will always have a PCI bus,= any instances of rom_memory can be replaced by pci_memory and rom_memory removed completely. Signed-off-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- hw/i386/pc_piix.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index 17975ba0c4..7d2f6abef3 100644 --- a/hw/i386/pc_piix.c +++ b/hw/i386/pc_piix.c @@ -105,7 +105,6 @@ static void pc_init1(MachineState *machine, const char = *pci_type) GSIState *gsi_state; MemoryRegion *ram_memory; MemoryRegion *pci_memory =3D NULL; - MemoryRegion *rom_memory =3D system_memory; ram_addr_t lowmem; uint64_t hole64_size =3D 0; PCIDevice *pci_dev; @@ -183,7 +182,6 @@ static void pc_init1(MachineState *machine, const char = *pci_type) =20 pci_memory =3D g_new(MemoryRegion, 1); memory_region_init(pci_memory, NULL, "pci", UINT64_MAX); - rom_memory =3D pci_memory; =20 phb =3D OBJECT(qdev_new(TYPE_I440FX_PCI_HOST_BRIDGE)); object_property_add_child(OBJECT(machine), "i440fx", phb); @@ -214,7 +212,7 @@ static void pc_init1(MachineState *machine, const char = *pci_type) =20 /* allocate ram and load rom/bios */ if (!xen_enabled()) { - pc_memory_init(pcms, system_memory, rom_memory, hole64_size); + pc_memory_init(pcms, system_memory, pci_memory, hole64_size); } else { assert(machine->ram_size =3D=3D x86ms->below_4g_mem_size + x86ms->above_4g_mem_size); --=20 2.43.0 From nobody Tue Dec 16 21:11:18 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass(p=none dis=none) header.from=nutanix.com ARC-Seal: i=2; a=rsa-sha256; t=1752228377; cv=pass; d=zohomail.com; s=zohoarc; b=MHLIPYN3rR5440tzNPqxcqv+IjFbk1Yry1E1Z443B9aA60GdeXsc4m8pLKDMcLJjwixzDBGY6MbPIO9gJzYRdusCpqQYtonB52OwJ9ql8O73kUvTd26pJQF0V+Hlfcw2Ab03CqPIqIspyUog2nXq7ETDNlADHv+Qzh8osyWlq6k= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1752228377; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=vdm/j/mLZzwlkW/qsiazO+2eDHobpNfTJnbg3e9bSMI=; b=jRWI/yIX+Vxnqv96WzIGIlKlbIKkeubX9EqikvWPXffVD9oat1BFoLDoO73c+IJeT6M+GSg+lU4OgjOBIzyv04Rr7HwqfZXKpjXbvZ130FaQGYz9LNflmqAzn9T2V8r8CSaG/NYRE3Whm7E6TFCjGz0O77dsAX1BgipOcAy21g8= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1752228377404529.7687195608388; Fri, 11 Jul 2025 03:06:17 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uaAXp-0007OK-2R; Fri, 11 Jul 2025 05:59:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uaAXa-0006qZ-B9 for qemu-devel@nongnu.org; Fri, 11 Jul 2025 05:59:39 -0400 Received: from mx0b-002c1b01.pphosted.com ([148.163.155.12]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uaAXX-0004wN-Ok for qemu-devel@nongnu.org; Fri, 11 Jul 2025 05:59:38 -0400 Received: from pps.filterd (m0127844.ppops.net [127.0.0.1]) by mx0b-002c1b01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 56B7b94H032450; Fri, 11 Jul 2025 02:59:23 -0700 Received: from nam11-dm6-obe.outbound.protection.outlook.com (mail-dm6nam11on2118.outbound.protection.outlook.com [40.107.223.118]) by mx0b-002c1b01.pphosted.com (PPS) with ESMTPS id 47q3k38m5v-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 11 Jul 2025 02:59:23 -0700 (PDT) Received: from PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) by BN0PR02MB7918.namprd02.prod.outlook.com (2603:10b6:408:161::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8922.25; Fri, 11 Jul 2025 09:59:21 +0000 Received: from PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88]) by PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88%5]) with mapi id 15.20.8901.028; Fri, 11 Jul 2025 09:59:21 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint20171006; bh=vdm/j/mLZzwlkW/qsiazO+2eDHobpNfTJnbg3e9bS MI=; b=yxIialGu2FCyUQTLAcNYYhbLeblWq200+1N6QKquK+UFmMjxImjUtclgO 9N3eW3U21FS9fFz9lecL9qJdnJjb7RrteVUqgodTUg5vinJ2SGXx8iaApTwcMD+p /8A5lF1dN7MN9elTBSWtWwI3AvJYFQNyWPOdqtfqOtvQwrGXo7wGer1u7q6mNTz4 pru/EVFpH+ndVRbvuFZHNxcbZ7sLRt6bnrrRK57azBDpymK6NafCN6uiW4b9E0Ej wrp+PWDypTKx2zEVqzMDq3ADJGPefxO5DmRAjD8h9WGx7OaWBMv67iVmydS0itv0 l7lEofI4eX1Uo3Z4Qx7CqqJSZXRuQ== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=D0oE67lYMPvWp3UORCpI3JQ8UCOehPpwHCuaRO5jWKrAl638TTPmGsU1v9Tu8p8tXQhweF4mPnoj3clbO1drVpgjghkeo3QT+OIlsx80LifTeiIuf2txmU2B88iHusxCHz8dWbnp4QPwG/v0nux1zOTE6OfSKnWpNwMyRPGt42KQs6+/cODB32TzvE5I/LCZYQzszJy8wOmV/8IB3HUlGfK4fcKPw0+J9ZOEcA7PCdaTa90kHmF9mlxRGvaWmrdLrn+J5phxOzvFegx2nO8wXB/eGHogiZcPwJ+x7lrPuGdYMHhDe/FDvI69uPGhHGhScZTJfMcxR+VUJ2BAmvgE9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vdm/j/mLZzwlkW/qsiazO+2eDHobpNfTJnbg3e9bSMI=; b=BduR1hLI5UwNuhUxBcuETAaTpB8wqna6kiXPKZvpdFRQ9PNyud/SikmFTnV0LuoE8bm4v4H/laKZIMLWAfAFbyM6WV9PJdvemF67uLE29GICym6pUleW2kmlDNku6WCSMggfgAE+npcX336ofPyR+VN0WnSCqM/Z0r+M7QW1sfmukg8EOJLY6AMlrosIHBkET8cuZ4KhDMfeLW7hGw9luviZEFFFmmBdhJF2OdMs4m96t4Bqz8d/JYbrgq36xs13DLtq74z65akhI3HeroipqbnygZItWjKsxR+YB+1BRRnkt6XRuK5apKJrCZLU51Ri968gtOydjjN8JrTf7vELVg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vdm/j/mLZzwlkW/qsiazO+2eDHobpNfTJnbg3e9bSMI=; b=caQVqzVfbj7Q+7t0pXAv4EuSO35ewcIt/HC4wBpgDeaSoupvyUBg5Uxx8YEAGKi8k9QBhcBxS0gcqG1+xWS6u8WRxUtaIBxnIl+xLqfKIYn+Z83sohjMZTOmPiknybWrwsncihY1M/q6EpgHFKiRZIpjZEyi/0wKN6RIhxx+dB2K5qGGDKljpdZrwv1YzPD0k41bcV8t989cusRdVZdO9meNBvh0sAYN0PiEOcYdXg+lX4KGvJbC5Et7vorGnQXhIuDYbewqBu56+VDPemDNue8h5gS8uqJCWMEG5/FqkypEhAxQxBswNYy+A7Rjq/y7LzrSwMqu/8AJKs1sfpYWeA== From: Mark Cave-Ayland To: pbonzini@redhat.com, mst@redhat.com, marcel.apfelbaum@gmail.com, eduardo@habkost.net, imammedo@redhat.com, qemu-devel@nongnu.org Subject: [PATCH v5 19/19] hw/i386/isapc.c: replace rom_memory with system_memory Date: Fri, 11 Jul 2025 10:57:21 +0100 Message-ID: <20250711095812.543857-20-mark.caveayland@nutanix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250711095812.543857-1-mark.caveayland@nutanix.com> References: <20250711095812.543857-1-mark.caveayland@nutanix.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: LO4P123CA0113.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:192::10) To PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR02MB7159:EE_|BN0PR02MB7918:EE_ X-MS-Office365-Filtering-Correlation-Id: 4436c679-d04b-49a3-978c-08ddc0619bc2 x-proofpoint-crosstenant: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|376014|1800799024|366016|10070799003; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?vGQ2ch9UTBMyXypbujqboW+u20dkAOC1WpgrEsQvUP+3GC7tiFjmKAkRtr6r?= =?us-ascii?Q?BzcSfd9QeNdkDTI1ynKBShncf/0uJhXbXORvOiyh/J6UIdUgVl5Kdgsntm/j?= =?us-ascii?Q?03S74Ap+iwBTF0kX84YInI9waWPCOTdeY2pHbt3Na38frd63BvVEbK+fdUws?= =?us-ascii?Q?3chzUZbuEOq9MpRON1RFDT6WPfgtdgEZYRf3Q5j8DZef/EYGOEBIqmv05ZsK?= =?us-ascii?Q?h6OJ86f3Sh6PXyvbwfZP9bYMwwAbxNHwo8+9T3nYf2bmJ0sLPvsAB6mj3I7B?= =?us-ascii?Q?VEs6i0EsjYY1PMC0h5qT64at4TH1JFwLyNsGkEwmdJ5twwjtp5NqaiXUjqrD?= =?us-ascii?Q?FmMpkyd/bmfVo1RY0huCmVENRolyLXy6CU6lFB2c+VxUgr0cJq0QlbMGGGLV?= =?us-ascii?Q?MS2xzMtHv2/i0lMtWbErFuOvxp8SQUjiI7F2GWc+ykL+6ZqRDzmXoE2QKMsX?= =?us-ascii?Q?/UL/clG4+tmQbLXLujftWgxcsOoTsHDKG1JJEWP2sfHt7yKsJtmsFumqEOpp?= =?us-ascii?Q?vjL5JmV/8J9YqcssPYLaBdOrshBUoMH98J56sh6iflm/8VNdSiryT6B9LWYI?= =?us-ascii?Q?syyKcKOP8P1anWPD/mlL1dEcx3jNCY/IxdDVeBHcJCEEisjckPfcwiSX0ds7?= =?us-ascii?Q?C29FawiIz3ev8ZgaNcL/77DCl67+feRyOq19LDkbCrTwmxU1MXn8Eh3NU5ik?= =?us-ascii?Q?ZppaVtIdd4jNZSXFjJDVR4PxoXx+9U7T+ktLi2Da8JFxeseY1c4kKe9WO/6+?= =?us-ascii?Q?Y7aAKzgjDjmZcKWbMaLiJZyynHjXfKbikmIeWIHIKlQg/UaS6mDXiHobUTEL?= =?us-ascii?Q?mLdk+1L61JfACbbh//mQVJBb+7C4YU7u/vjXE2kGfwR5/g7h2tiTdAglvzsQ?= =?us-ascii?Q?aezoN74bxfwTsWVyNDAXT9ngR6aE/QPIznRNhHm6ZmpaoZIYSSPvJ1XF/hWd?= =?us-ascii?Q?DKtpChE02t97TF8fc0kMcXZAmPMBQa3T/Jg034zHhsmlvu5KbU6pDhsldaKc?= =?us-ascii?Q?EHlvtTta3AzWeTp1GDsav6Ml520KlyHLNpMte8HwnNEq89mKsNU3zvfWf54w?= =?us-ascii?Q?80igZnkp3esbEvfMByfiTNIbrt/9g+wien8y+n1FyxlHlNy4TH1cAaFXZ+yj?= =?us-ascii?Q?CRDhS4GZkLpEZZnXrbYN5i9rqPRwKVNpDtW+vXRZHQimgJnmzjkMEYZw8ug/?= =?us-ascii?Q?6RoH2IhXomYXTbjE4DX9vEytvpLt93swsmkLJ66YrVm2qaaZSLSUslVg9eNJ?= =?us-ascii?Q?U+jqKXGScXFDHl373PLnHQiOmEDStAtM+x3qHIt1662F+IDPf3iEnhASkW1F?= =?us-ascii?Q?41RQZ9KNscKZOhNGIDeTkd/+3DLCPX+WnSZSsOb7jMPcla6wA4jke0ZqwVni?= =?us-ascii?Q?xREvjxMhK8GlAEAfAKf4xuLDFv++AWn5k3bloDODVbQz/klFCneARtFEn9Dp?= =?us-ascii?Q?0JxZ1fmUu7w=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR02MB7159.namprd02.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(1800799024)(366016)(10070799003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?+jWxJvt7cL6AvfOzfFBZb+liuD8wJawkq+yy7uQgEi+cbfeWh/djhBzRY1QS?= =?us-ascii?Q?ic/6+dvZ8i0lX4sX3zXD7tHz1AVn7BNCFZ6NqxCcvYs0yYpMcBz0D0yNt4Lg?= =?us-ascii?Q?Gp1FUX10Bv8Nlw9lMCUACbYbYztqC044qeLdX2QunWTEcmKPJ9kKBgYRlEM3?= =?us-ascii?Q?oIwFKuxPbQdI5HRKIwba9foEDrWOQaD4jD8FCCq3gLgaJ1rnlNTVnFhxynt5?= =?us-ascii?Q?3oOTkCsIA7M6rUu0BmEd8T1PvBpShYgEPCR8ok2eU+WBX11muvHxiL8n5ba2?= =?us-ascii?Q?cO1lpX48eisKN9Kun8Equ+zD1w7CTMAh0yiAoA5c1mZzlJU6Lgx14durbv4i?= =?us-ascii?Q?Aibd71fG78Zv4R+PNL6uEpF+AG5/77j0fjf39wIImuPYnahI+qMjFnr5Pf3+?= =?us-ascii?Q?l98NwuANJvR4MsCU8JSRBVXvjC7xL/5LbjFf8VctZWZLxNXEWsGJkL6/Xfx8?= =?us-ascii?Q?50zlxdsvho4LuWP7tZfD8fzJX2XYy0FqmW4l+Cy6ZbaqDO5MNvvyAg4v1YSX?= =?us-ascii?Q?mUY8+4uk24hG69CTsYrjjUpmOx4Ou5x0a/OcVXYdTJgKmoqIvOnTT05ojZjO?= =?us-ascii?Q?C4lyR69atrS0w+bdAMVUYdjfkQsyTZrF+jOHvLAJ0AXKduxxTDilqzEf/FTq?= =?us-ascii?Q?xxfYcwYvHxzgzFVivOb/Z3WGwn+3hf/r0dqV5p+0xAwyDW7E/S0Jr2nfhroW?= =?us-ascii?Q?a8rKozUht01ICAUcyA/loQhgo8rUQ4e5YfBLNcUEiF+MfDUT7l3QjWKdNJHm?= =?us-ascii?Q?9HP8ljJ+KRWnfGMVILUN/8f8xA4WZbHT82TIHkxNw5+Y1ijBvwSLGEACJ4KV?= =?us-ascii?Q?vnXt9sTZhLgKBVDM49GHFWegUAFrE/k8+OWNMqyg9pbeA85NJOT8gUALnjZV?= =?us-ascii?Q?vXCMVnqbdPa9s006t/W9+zqE+CCz804Zegc+h1Ipf2skj5BMUw6Bl3jG07G+?= =?us-ascii?Q?6O3DYQMrhYxPgVYChdGbqZo3tav1UOrkagpJsUgoekXB43A/xaWKSXVC01C1?= =?us-ascii?Q?LdMs+S77MsIPBCfUoekRxPGwUZiCr69SLX5qsmCo3r8WbOn6mmJVxLUR/8J2?= =?us-ascii?Q?KDkPsEAMliKLedqM9yQS25EktJeCRpQHQCZq8rdZwGDKYfDuYRrh/Sg4N39J?= =?us-ascii?Q?3f3JUc+lJobYrQkSXyR8St3SgFmyiMYkacrcbcQ5F/HlA4xdo/OP1MNkkmsd?= =?us-ascii?Q?VY5qo1I6GYwIgeC3EIswE/tYlKBg7pS1A/63nNuRMr3TwWR1SfvZxn0fJ5CL?= =?us-ascii?Q?+8IRcZKOBg+mlF7TsJ2E2PwNv/ltd9VXhN00DWmGTXbFsGghoCDI0CEdqCp+?= =?us-ascii?Q?x8sEsMZGf4qLlaAa89fpz4hiM3VH4+2GRYCi225vP6KU60VNN4ZRxBFeoPJn?= =?us-ascii?Q?PjAyYBqlEVALlhF7lQb0v9k7IAePIiACc0YjNBMH4SMb+GYpfn1UC+hOic1C?= =?us-ascii?Q?2joMVck+m03GF6oUN938NX5VsBdlYKvNAuVmhiLyjtAkQ2SHUbTdQw7GMU+C?= =?us-ascii?Q?lOhsYQ+LWt1d6N3WMjzv6tFPQe+GnwY50or2gcx+bghHIx9rjx0ge9CBTWeZ?= =?us-ascii?Q?b86qNi+Yxzu2mbmZYC1yubCAe4yQmVPDPIh5zGf+cHaYgAKbTvsjgiRYyvRd?= =?us-ascii?Q?1l42u4oLSq+AlKy7wBICHoZbXwmpLCm2EJAjtGi7LAQad5SHkmwqln5v+va5?= =?us-ascii?Q?+t+yVg=3D=3D?= X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4436c679-d04b-49a3-978c-08ddc0619bc2 X-MS-Exchange-CrossTenant-AuthSource: PH0PR02MB7159.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jul 2025 09:59:21.4718 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: MqIBKWcZ+Yw3Wcc+rkOFx9EEHO0ednT2oFL8B+sXZLKzmi5eWC6MGMkf59hQelhuK402bvS+GzK9VEPnR/TP8bOroiMaT6JWu3wGNP1Sick= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR02MB7918 X-Authority-Analysis: v=2.4 cv=UNDdHDfy c=1 sm=1 tr=0 ts=6870e07b cx=c_pps a=P372saq+MbI0baXGzHkldA==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=xqWC_Br6kY4A:10 a=Wb1JkmetP80A:10 a=0kUYKlekyDsA:10 a=64Cc0HZtAAAA:8 a=BKspdhvg69VpFdegezIA:9 X-Proofpoint-ORIG-GUID: H9R5g-iEfpctZyhg-tGsizZUv8Ck3ZbW X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNzExMDA3MCBTYWx0ZWRfX5ALKVMs3L8tw WC6CdIjXQbSVAPJJNXcC1nhmv96Ece+f28fcyEFogo255rGxJkVWqCxyAoxj3hOBSfhple/d4Q4 GHaZTN2cTLBRqevIB6c0oGBz3mJWPP1eQqgo2ep1B0iBjBo0rQ+dYZ+I4X/90bg9dXtEsbiFAOT 5lsl63uNA4fIdzTHoXKLOVvxiVOC8NRJ+8XT4qC52CZlGenyG/5sW6bPvBWj4WSM1jvaTLSuDXx Gp/ztyCFK9eLpEUNz+8NmaB+cC6J7ykDiqw4A+kUMnAfHuzB35viG0Fjsbnd3MnP5lTwp/FA6D9 LkXUv7avMr7UMfaF+s1ykQ2roMIV0Uu51PLA9k1UDhnZ4MfoZGiXW2WISym+aN9dJUSZUsryBow LLwEPQNcgnXAbW/yq9VZGSKQ/vOcZoPZWF9LTsYAFMliNxY9+keZ3nkMGqIAeLG7Zj3V+6BX X-Proofpoint-GUID: H9R5g-iEfpctZyhg-tGsizZUv8Ck3ZbW X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.7,FMLib:17.12.80.40 definitions=2025-07-11_03,2025-07-09_01,2025-03-28_01 X-Proofpoint-Spam-Reason: safe Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=148.163.155.12; envelope-from=mark.caveayland@nutanix.com; helo=mx0b-002c1b01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @nutanix.com) X-ZM-MESSAGEID: 1752228378150116600 Content-Type: text/plain; charset="utf-8" Now that we can guarantee the isapc machine will never have a PCI bus, any instances of rom_memory can be replaced by system_memory and rom_memory removed completely. Signed-off-by: Mark Cave-Ayland --- hw/i386/isapc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/hw/i386/isapc.c b/hw/i386/isapc.c index b24cbf41ea..abf648706e 100644 --- a/hw/i386/isapc.c +++ b/hw/i386/isapc.c @@ -36,7 +36,6 @@ static void pc_init_isa(MachineState *machine) ISABus *isa_bus; GSIState *gsi_state; MemoryRegion *ram_memory; - MemoryRegion *rom_memory =3D system_memory; DriveInfo *hd[MAX_IDE_BUS * MAX_IDE_DEVS]; uint32_t irq; int i; @@ -75,7 +74,7 @@ static void pc_init_isa(MachineState *machine) =20 /* allocate ram and load rom/bios */ if (!xen_enabled()) { - pc_memory_init(pcms, system_memory, rom_memory, 0); + pc_memory_init(pcms, system_memory, system_memory, 0); } else { assert(machine->ram_size =3D=3D x86ms->below_4g_mem_size + x86ms->above_4g_mem_size); --=20 2.43.0