From nobody Sat Nov 15 10:54:05 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass(p=none dis=none) header.from=nutanix.com ARC-Seal: i=2; a=rsa-sha256; t=1752137634; cv=pass; d=zohomail.com; s=zohoarc; b=N8G67AMJfRe4x+d2K/zOioKWblBpB4pEoyFpnqMy32izgs2IPWn+QBzl8EgEf4nmAoIWiKOtnf0K0woqsT70Jd6+VOrH9Q6ywtYkVHUqYhIDQkCjfM4h5yuKDOMRpenJdvlbCsusxJCA2RaDYrPSRe7lDZwfaVBd8dcl1UvG1zM= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1752137634; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=pPuDxY4QWTE7Efc+/14RO1CaZk+qNTAYIF/jv+iHMrI=; b=LoLqMqm73G3NDnoSgaf4wlsG+JY6wTw1i9JIL9Nh3giTIq8cDNxtQ29yDHWtwp9QyeG+T12Tz1NPlVipqyvq6H0icc+TSkKUOVUm6LbIMuhDENa0L0Gy3ZzqTw4jL/d5LteGo9MU6po137xyvedLW0j7EpJPcoO1pjmZMs7K8DA= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1752137634927291.2012934430169; Thu, 10 Jul 2025 01:53:54 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uZn28-0007gH-LR; Thu, 10 Jul 2025 04:53:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uZn1z-0007Vz-Tl for qemu-devel@nongnu.org; Thu, 10 Jul 2025 04:53:28 -0400 Received: from mx0b-002c1b01.pphosted.com ([148.163.155.12]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uZn1s-0003VM-WF for qemu-devel@nongnu.org; Thu, 10 Jul 2025 04:53:27 -0400 Received: from pps.filterd (m0127843.ppops.net [127.0.0.1]) by mx0b-002c1b01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 56A8XjUd005898; Thu, 10 Jul 2025 01:53:17 -0700 Received: from nam11-dm6-obe.outbound.protection.outlook.com (mail-dm6nam11on2094.outbound.protection.outlook.com [40.107.223.94]) by mx0b-002c1b01.pphosted.com (PPS) with ESMTPS id 47ta49g1fn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 10 Jul 2025 01:53:17 -0700 (PDT) Received: from PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) by CYXPR02MB10266.namprd02.prod.outlook.com (2603:10b6:930:e8::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8901.28; Thu, 10 Jul 2025 08:53:16 +0000 Received: from PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88]) by PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88%5]) with mapi id 15.20.8901.028; Thu, 10 Jul 2025 08:53:16 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint20171006; bh=pPuDxY4QWTE7Efc+/14RO1CaZk+qNTAYIF/jv+iHM rI=; b=k3h64MT/wfeFIYvJYWJmFyYB+cBK+67fYLXCLpwXDx2x+iZ1thc+VAu00 JPlaYkmSJUBzAEhFw24joRhulDbu4pxMebUOfF8LQQDHKhXYYvWh27t4briafyP9 kAVInzQULz1tGyNWA5p3rfzLZNGgjzv8j5poObzMQHdVXzp4+v5b8sdw8aklrDb9 Yb8PsmzTT2eJ2hLwe6Dw2ihQ9ryRT3PdlQ8nRtjKJ+826/mTKABqk04OrhhyW/7c xX9bcwbPazGC2mllx5P63jKm6yiA09sjTgGNWP1Dg8Mt2DcQp3drL54BmxI2XN1e iXjZu1vvyzOImHbb2jyfHE19qST1w== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=RKpYYv4K8LD6L1FyWvek6SVCiwpFwzcssPTnJyKq6jppih7b2Brj7Q1zXmQ2O2Tdd2VDClsYPvN518dOQtVlhnI2E0iDmVlt3crCeA6Q5fbnU5WWllfGyo079rn+ZcNng03bbXqcCMmVaBvhTtmgvephxJ4bAsrivDz+h0Wm3wVPMRXIT7BlH5avxNyIIomPjtqq6+npSF5UxmpnpLmw9wokgsmK28HD1pV6dN92jbXbAVc63L3Uw7S6DTC38/f4Gyrlz90T+Y+rnrs7ElDUMlWRrcqfJEtVzxrBwz/vKVUDbsL+Hi3YWenEHdOByxCFeBnaNvdVf+fsF803BfY/ow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pPuDxY4QWTE7Efc+/14RO1CaZk+qNTAYIF/jv+iHMrI=; b=SpNUWHTRVLj7vGBbrlJyd3GdALHhkonkpdJlFBKmP+zXHSb4PaeeG+YgPDWiK4ZQlZAkl8pXyS4Q0sVqd7GSut8mQyA8p1yE0QVXC0x8WHV1ETnA8e5F3zLopT+VXW0mG586g7NcqTmM3LAXvLrbvJ0cq32u3+sDiFHw/AB7wWAak6z6xyYITHUZJKlMhbtLdItGiSqBCYfjdEkV+qqNf/nyhVsdw8T0jZCIvQMI1AUbUV/NmJhTPZXwM1ntRX9bWliDagMw4EViiCjy63cCLnmEqcFM/voIWDYS3D0vE6un9DPcwDaVSOz/P1vYLSyES5ViHxTN3i5MEKcaaTKyAA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pPuDxY4QWTE7Efc+/14RO1CaZk+qNTAYIF/jv+iHMrI=; b=cTmecLjA4YNdBzoApoyDkiJCG9QWJ4v0WObOqFGFIkeSsbPI/R/IQn0wZDi9qUV/P1tWId4rVHMpGHKcdaYN5RKk1JoLHQGzfZbDSplM+zcIsS4NuazLiba/QDn8qN37J/Ad1N7/ONYwIiU4l1tR4LlEr+Bk/rDl6PI5BxRiQGMCCsF2Fkkij4Psz3O3BYH4qVoAodF1E1SW8WCJsJgPUnXFJ3nWwUd2QYSNhGAgN8pWDl89OeSJF/2ewvnw2Hh5p4VMHKDROQNEziXsnVoCoH+51O7oCR8r7KbYpEQbxZpcJqELUERxK8tC8eEmHmf5lE28nlDFKmwluY02/twkmw== From: Mark Cave-Ayland To: pbonzini@redhat.com, mst@redhat.com, marcel.apfelbaum@gmail.com, eduardo@habkost.net, imammedo@redhat.com, qemu-devel@nongnu.org Subject: [PATCH v4 01/18] hw/i386/pc_piix.c: restrict isapc machine to 32-bit CPUs Date: Thu, 10 Jul 2025 09:52:16 +0100 Message-ID: <20250710085308.420774-2-mark.caveayland@nutanix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250710085308.420774-1-mark.caveayland@nutanix.com> References: <20250710085308.420774-1-mark.caveayland@nutanix.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AM4PR07CA0004.eurprd07.prod.outlook.com (2603:10a6:205:1::17) To PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR02MB7159:EE_|CYXPR02MB10266:EE_ X-MS-Office365-Filtering-Correlation-Id: a18d7d61-6961-488b-3ca2-08ddbf8f35bc x-proofpoint-crosstenant: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|366016|376014|1800799024|10070799003; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?0AhwuzJSJFOO7I3CHW3yr7J6QmesNsb+S4Pi3Eh4wSOKHM3+NFqp7sQXP248?= =?us-ascii?Q?c4R7ywRTjZH3wtrT1/oH1cC01KL2N8IyXPM+PzvyKn5t4cp+jspxBkm/WfYT?= =?us-ascii?Q?bpdGvHjIIL9lfvsJjTeUNwDtMGkq0CCbw7pYJs9APc6hO6j9w13XibNR09Xo?= =?us-ascii?Q?rPXtJlhC7cQEtwWsDYJQbGNrN2uWZ2MNx7kNtfvmutChGns5DRUgvzuW1/71?= =?us-ascii?Q?pEAYmp1avxJ48qi/DTb8lFTrQ30buJ5rYmE1EXwT2Y3V6EhnG1G9Jj/1IMyn?= =?us-ascii?Q?T3vcTGmNhDg9Jh4zu4FglSndL8BOtVmIPuv78oyMrkgAbQhBkHw5IGGQGoZv?= =?us-ascii?Q?C53RRE+oNfAmxorFqrQBS0ZoI4hHe9lxiU0YKq942zki6GJ0BW8+GKxnhkyy?= =?us-ascii?Q?jKpGtswFyxvY8vF7LIwnAdkrejYfxTJBFrJVV68XSpQ9mmyVDwvd35BsNgRD?= =?us-ascii?Q?mr0rTIfXbZMJHZiWDU5FZR2ERWc18jSrhHbbzaCZAdTu3lSL0qLyqZJ+8nto?= =?us-ascii?Q?i/7lsfe3fHA5kruuUmYzal3KZ94VaM6nS6z7pVnXKVra+HILbUIMMvaqJ/kV?= =?us-ascii?Q?NaqPZt6tzXYifE1oiz6LANCrJUTQ8iZzw3YeX13rRg7YlTUEb/ULul9GrTFS?= =?us-ascii?Q?7WYdOp/ofVS0g9goDLjKXeYtuXl0ICpUB82SS/HwusJ1DyWenfSXaLXdDG0J?= =?us-ascii?Q?nltyE2ld1qDSoPijaR2Ps0jAa4pkvZDElO+OH5oO9LohGu/0TsitY4jzFGvx?= =?us-ascii?Q?wo/GnJdRa2H8tdVc5Q1/NnwHH8ipZo2MFfszS/QtRDdVjiBNhPyi7XkbpMuW?= =?us-ascii?Q?VdMaIB1t84N4tz+EYff1Rp2wb0PcEKrjOYRi+F3H3zRn0c3f+Q5Mvqk5Afey?= =?us-ascii?Q?J3kLWG816ivfaUP5299YCeLUXS2tqHsd08wkajrz1aHkZwbCpduO9+WSSdgf?= =?us-ascii?Q?3UfBosvwwBsLnDR3sq284jo8GJh2r8lzCne9lQ4bS2ynZ/y1Rggah715iFNj?= =?us-ascii?Q?ptwpuarVWY0i+s+nvSLhSmbRsgAicVZBlH69hHVVVIaQKEyrIWJSUKbmYWs5?= =?us-ascii?Q?+/r0fkqapuk8TwVBpuCdIOXmK0HbhGkAf1k0i0AV5S433QjLK5yrjlIVP88l?= =?us-ascii?Q?Dwr8K9UbXbi3Hjsov4boyXSd029yAT1oA5Z7dSeWqHQ4PFww/nOhW4bBGSex?= =?us-ascii?Q?fC/hG9gEH4FLHuEW/sfqGqwXDKCcIOJsuIfkxFBm6+LxzI6fbjlYML94cJxw?= =?us-ascii?Q?nTY8bKUqp9EcDGAhjNL+938ctqI5iajqWkEgAI7s6pm3KXHoGKddOYf5XzjZ?= =?us-ascii?Q?WmAd3fUo8qPvbQSxb9bXFyk16w9Q7II96V9RzptaMwJm2y42sBOFjE67OPri?= =?us-ascii?Q?gfBYtiN/EN7kIxjyZTG8J6sXWIMKxI1ir9V8PKG6SqcfrKR7OFbn4MCbzqIR?= =?us-ascii?Q?ClWUtiwmO2E=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR02MB7159.namprd02.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(376014)(1800799024)(10070799003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?ca2pIF3mOrlShnuBVTOtSv+ZjfmiszaTSHARybCU4l15xLfSX1p27YSiAKYh?= =?us-ascii?Q?0t9T/fkZfuQ4EBfznrgPIhpWlaXx0BGYa+e1IBZCjMxu0T5GEXlU4CIz/4lE?= =?us-ascii?Q?Pk3SXZ4h1K7zd3Szg1VaJAYdegH0AA62vgl48R7olsjoBWpyCZcA5jAj/xBb?= =?us-ascii?Q?bnQeMTBtDpHvLhq+G45os/RzovgNN6rcBLpaLz3XRbN6saNzGKIn9eCSIIYe?= =?us-ascii?Q?ng+EKkUbTNeJQeNVtjCzFHsWdAx5GWC59FOgtZyiLio3AV5OmyEambQtbRtp?= =?us-ascii?Q?zLL2HOAMmYgaDZ8NyP7XLg9nQPcvWscMK2Gb9vMdl24cDPMsPnJNWqIPUfdY?= =?us-ascii?Q?dkcsZRrSkb04ZLj3CA7xv2dh4CO4HIXGZg2gMWUsVeCn2rRz+GwWN/F93jJl?= =?us-ascii?Q?3jBD2apVrXO+nWwOPWnGdxgbvCAft9Dxe7c+eNe7jLFkwCmIMFPZaZPtQRHU?= =?us-ascii?Q?IdpUlORjuLfRqAcg9fgoeuARcpWBPXoZIkxTeT1zHxXZPmYNkt+q76msjqMZ?= =?us-ascii?Q?N8UwFRoS+ynlpqx5gHKmmutT5EY+gmeE2UrHtvBk4GcNg6/XBoTIukSyRUWs?= =?us-ascii?Q?NiYNtu9o+PeP/6d7omfgHUPokGXNFSxCAx9ZM/m0wudJYaV9wg7C8Sms0UO0?= =?us-ascii?Q?ffges6lrsl6DEoTHAazjGinHUXqJNKOgzxgE5/FY9u0eHJzWusmfZ3ddst2r?= =?us-ascii?Q?vTDUxKkyXUTWv5Fm9xJkrBVmuEDOv/f75SE57O+bKb7v7HXvdnXSa7+KQdoM?= =?us-ascii?Q?gpUBJ4jmrnyy1SPiRZAauxkUWf2VJBdnohZmqavHjIyrvHJb96i4NqN4su28?= =?us-ascii?Q?EZ2z2pu6Hx4cC8PkTrrQER69hfl+cjOMBpmqiY3gzQDDrdA6wrZJi4UCpJOQ?= =?us-ascii?Q?A8Usyifrw/rad8tQBmobv28xcMUAkFCxFYhQn0ALtce+4Z2ZF+JHjLSUEC6p?= =?us-ascii?Q?LvUU79wZPuCHV6r+/jrDN8KEwkbHaHgyarwXRRyrNhDBpPnTfm00WmIaP8g4?= =?us-ascii?Q?1HoouetiVkcPscs3rGN1rCcyl4dxmpBXROdJQl6HgymXn6sht0JUmgUzi5jp?= =?us-ascii?Q?Ja51+otBZRlM5cVwcAP9DVNTqV8scO4DMJwwMwx7K/Bf3TyaZIrRT5gV6uvn?= =?us-ascii?Q?05KKrJy0TaNt8piauN+4U/ZK/zJE3c7MtmhAZ7Q9WidTS8JuJhbTr43xCwv0?= =?us-ascii?Q?cvd7FMMbIdtkbm2GGMOLiK5G2g5MamJfu/GJAD/G0qnyCseJ1T5SlG4qU/FT?= =?us-ascii?Q?9zwPFoMQWVoYUJ5Lx+sMV89XXCOuvZgR6AyppqTyq1x+vTJ0Y+YL+ocRmtgT?= =?us-ascii?Q?uQKgCBvs2w1OvKP5nH/D5V6Y0KHXQd9RQMdRH45BvVSCKzD4LH+4nexzefXN?= =?us-ascii?Q?b3MVyxVfOPNsbGE4ar9VALF6Em5aUklPItwmgfNtHdW2bg0C4MhLE4JwJNvw?= =?us-ascii?Q?z6KpJX4lmUF9v7KtJ6b85RV5oF1ghb/xpVr/h3XNT4mIo7Aqu8iUYV6Ac7kA?= =?us-ascii?Q?3eBXfBkfuhm+2HHngJGKrGeiPXS+e3paL9oHFMFOfudw/X5psyFYky07oiq4?= =?us-ascii?Q?RmvFaEU/WzEPEBNRbBiCceBZiEC/+KzXrkSOng5iSELrEIjwdxi4iPLmm5++?= =?us-ascii?Q?a3/4CrqWM1Hr6rw6TB+o6HU9+50i6UzHLkBbm6qVsMidSe61AxTUrDm4aqNs?= =?us-ascii?Q?KS5sGQ=3D=3D?= X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: a18d7d61-6961-488b-3ca2-08ddbf8f35bc X-MS-Exchange-CrossTenant-AuthSource: PH0PR02MB7159.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jul 2025 08:53:16.0127 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: sOllk7B0y+c9/V3LK57gM0jt3pck0x9m18dal98vEamT7irZnKOf51cpautfih8NNxAhp6LSSiiegn4IEORqHlJaXDdZq21FgZxeLqTM1xs= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CYXPR02MB10266 X-Proofpoint-ORIG-GUID: R1npdgCz1LyRA8poogC6mVUcHzH4u0FT X-Proofpoint-GUID: R1npdgCz1LyRA8poogC6mVUcHzH4u0FT X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNzEwMDA3NSBTYWx0ZWRfXwuad7lWMI/5u S3X3IrVYQ+ZcvkmDuWJ471URjosq0Ty7aPTbwRwTluK/AIlLWaxgd23MWXQO39up8HB5KL4kll8 YFwitJU7rECZb+KTo76hTTHNehbWfVBJAprOb8rVzs/PDa6+Nk1YXA0LuGOE15htWtncTTQy/QK F2PK5Y5bs48lKy+yfWtFSyr5BTfPfrmgyVsP6zzdkT9d5u1RX8ncWyTWyftHVZdSSm9DoMMwSKt XkGzayMNP3qNhtHvg67eXzFQXdB2tJ4bOVtCmSicsPD8Bh5elTly9A+AQuUdofC962BSaGRx0Ua JZJhdalFCk/s9VQD4cXtGAtPyVmyWzza23h5ustwPs80skR9S1YEDPXB7kwqmpdqAM9GzG5UO8k W0ZzGmZeJEmUt4elWXfnm6VLAPmxF/jSFfBNJhyjH9P+kPCKTjf+E3gskIVZ4+5VMbJySozq X-Authority-Analysis: v=2.4 cv=fNg53Yae c=1 sm=1 tr=0 ts=686f7f7d cx=c_pps a=fxbcSSzt6U1YglO7xsTYVg==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=xqWC_Br6kY4A:10 a=Wb1JkmetP80A:10 a=0kUYKlekyDsA:10 a=64Cc0HZtAAAA:8 a=nuetpX4ixqIVgyrW5aIA:9 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.7,FMLib:17.12.80.40 definitions=2025-07-10_01,2025-07-09_01,2025-03-28_01 X-Proofpoint-Spam-Reason: safe Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=148.163.155.12; envelope-from=mark.caveayland@nutanix.com; helo=mx0b-002c1b01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @nutanix.com) X-ZM-MESSAGEID: 1752137635570116600 Content-Type: text/plain; charset="utf-8" The isapc machine represents a legacy ISA PC with a 486 CPU. Whilst it is possible to specify any CPU via -cpu on the command line, it makes no sense to allow modern 64-bit CPUs to be used. Restrict the isapc machine to the available 32-bit CPUs, taking care to handle the case where if a user inadvertently uses -cpu max then the "best" 32-bit CPU is used (in this case the pentium3). Signed-off-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- hw/i386/pc_piix.c | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index ea7572e783..67c52d79b2 100644 --- a/hw/i386/pc_piix.c +++ b/hw/i386/pc_piix.c @@ -418,6 +418,18 @@ static void pc_set_south_bridge(Object *obj, int value= , Error **errp) #ifdef CONFIG_ISAPC static void pc_init_isa(MachineState *machine) { + /* + * There is a small chance that someone unintentionally passes "-cpu m= ax" + * for the isapc machine, which will provide a much more modern 32-bit + * CPU than would be expected for an ISA-era PC. If the "max" cpu type= has + * been specified, choose the "best" 32-bit cpu possible which we cons= ider + * be the pentium3 (deliberately choosing an Intel CPU given that the + * default 486 CPU for the isapc machine is also an Intel CPU). + */ + if (!strcmp(machine->cpu_type, X86_CPU_TYPE_NAME("max"))) { + machine->cpu_type =3D X86_CPU_TYPE_NAME("pentium3"); + } + pc_init1(machine, NULL); } #endif @@ -786,7 +798,19 @@ DEFINE_I440FX_MACHINE(2, 6); #ifdef CONFIG_ISAPC static void isapc_machine_options(MachineClass *m) { + static const char * const valid_cpu_types[] =3D { + X86_CPU_TYPE_NAME("486"), + X86_CPU_TYPE_NAME("athlon"), + X86_CPU_TYPE_NAME("kvm32"), + X86_CPU_TYPE_NAME("pentium"), + X86_CPU_TYPE_NAME("pentium2"), + X86_CPU_TYPE_NAME("pentium3"), + X86_CPU_TYPE_NAME("qemu32"), + X86_CPU_TYPE_NAME("max"), + NULL + }; PCMachineClass *pcmc =3D PC_MACHINE_CLASS(m); + m->desc =3D "ISA-only PC"; m->max_cpus =3D 1; m->option_rom_has_mr =3D true; @@ -799,6 +823,7 @@ static void isapc_machine_options(MachineClass *m) pcmc->has_reserved_memory =3D false; m->default_nic =3D "ne2k_isa"; m->default_cpu_type =3D X86_CPU_TYPE_NAME("486"); + m->valid_cpu_types =3D valid_cpu_types; m->no_floppy =3D !module_object_class_by_name(TYPE_ISA_FDC); m->no_parallel =3D !module_object_class_by_name(TYPE_ISA_PARALLEL); } --=20 2.43.0 From nobody Sat Nov 15 10:54:05 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass(p=none dis=none) header.from=nutanix.com ARC-Seal: i=2; a=rsa-sha256; t=1752137870; cv=pass; d=zohomail.com; s=zohoarc; b=QvG/zQoAN82SBU5Pf8ovbgbflbDu1t6PIXxVUNxiMv5dRLHnXi+PXMrhoJT25Wfwmkuvgq1jyzSVrykXb3ZoMR4Hy11XHX1CLVQoGzzbwivDzxIzqFmAB4o1RHz1J8JnxjqjZyig0eFzB9SfkGptoFPNRB/L5FmM8gqBpdKe3LY= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1752137870; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=Itm3uTp6rIv3usi9+1o8mDIXzHDuzWVu8Kdyjrg7CBo=; b=T6KCJ5eNkEJHel/3Yt77buoXtg/z6kjONVGit5KtLqCidiiGmvGvrZ4YeI4Bp/VGWzT6qdg9ogfzdTuzBc4KOm7EoZrFVQg+vWdiVwwc9vp5P/bWxcEgIAtPj3t8YFMxhxRcDzpSN+KTu9nE1s89igzm2Uw4pfB0jelgKHHt2CQ= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 175213787020375.09128455622363; Thu, 10 Jul 2025 01:57:50 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uZn2M-0007nk-S5; Thu, 10 Jul 2025 04:53:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uZn21-0007Z9-DT for qemu-devel@nongnu.org; Thu, 10 Jul 2025 04:53:29 -0400 Received: from mx0a-002c1b01.pphosted.com ([148.163.151.68]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uZn1y-0003Vm-N7 for qemu-devel@nongnu.org; Thu, 10 Jul 2025 04:53:29 -0400 Received: from pps.filterd (m0127840.ppops.net [127.0.0.1]) by mx0a-002c1b01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 569LQdSj015992; Thu, 10 Jul 2025 01:53:22 -0700 Received: from nam11-dm6-obe.outbound.protection.outlook.com (mail-dm6nam11on2093.outbound.protection.outlook.com [40.107.223.93]) by mx0a-002c1b01.pphosted.com (PPS) with ESMTPS id 47q0cvn27s-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 10 Jul 2025 01:53:22 -0700 (PDT) Received: from PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) by CYXPR02MB10266.namprd02.prod.outlook.com (2603:10b6:930:e8::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8901.28; Thu, 10 Jul 2025 08:53:20 +0000 Received: from PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88]) by PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88%5]) with mapi id 15.20.8901.028; Thu, 10 Jul 2025 08:53:20 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint20171006; bh=Itm3uTp6rIv3usi9+1o8mDIXzHDuzWVu8Kdyjrg7C Bo=; b=z+lj3mHnkMgpomRZIeNQmHTr0Ba7bKRaJ9pyW3R7FG/VdNSyX25B+3PVz ZYTaksEy2yMUg1v3sH1im3q0WObaWHhY+Ybzw1HFHvR8Zv5FwAgMRseu/0KMgOWn aKf+/RehP4wgv/g7WTIeFNtZHI4c94vijgHDosSgFhG55Mb/381nO640i8N2rRm1 n91TnOr4Jot+vxNHM0mdLqRfCCOBq4BlLJT8GmfdCakQfZbn8nVJqEH+U066kGWh gryiv6jL1oXmFUaJjbEoBTS8TL9bFd0oP1pqM05YaDd2LarxyvTzGSUbiSmfP1tQ jD2hHwJaf7gkmHaM1Q9HF8OyFHYxQ== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=vIbjr2JYcwYrQE772x82UWNhOYJ0pni1sUQeti+P4wkVk5LROIDFdbXsn4cOgeIy66arsCx3oLtLw3ccqAY3KQuseIQ6V2i3vTWoM962Tb0wk1TnfEYsWCt4phiMaeujhHiw9s6/FZRy4V1Ifyray6JWIlwWr9ECk1MKT7Xb0lEy7AylvL7QynNuU07daTYr4vZ55JW9jUX9VOZOmAEdrpjJ47iNG3YpdokJX+cUyIhGz5Yk37Shz4JXluadW0dzZBb3/0O5df3PlKmxHbIofA4jMd9WDSgLt5qEwpLzJ7Z7eoTEnYZLe1DwejnGib7q5cNpDJ78sTCtgOe0cxsRjA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Itm3uTp6rIv3usi9+1o8mDIXzHDuzWVu8Kdyjrg7CBo=; b=A80WN8+WBpD064sGk0xzj7G0S7XYjyfjjYjBtWkYK0O1Ni9+tvxPPJi4pSW+ppAIg3nQ0aVSYJ7Bci4cYnwf0nCnLnpSUapA1dHxfFZviY9AZNkp0r4m7PTdSSy2A7E+uRWYEKVqOHJQ/74RzMDja91LRb2Sz2Zy3TGSoK5aN+uwuEQxhAbDjHJ2z8G7PsCU3i8tnTxOZujBM1BFdikBGDXrdXoB+xJbMbwPWwjZbpBlscqw0P+MvzrRoePePn9l/eLkYMJcb1139+6hqtfm3BN9UFl0a72q5CcXWQCAuUzIXmOevbN3OZea6ReycqNfL/INSH3mCWrHeWQCJDlJkA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Itm3uTp6rIv3usi9+1o8mDIXzHDuzWVu8Kdyjrg7CBo=; b=MYwj9n7KOqP+2+uq+HNVpPR4cbiyZwgwMl+njwRumKBejSkjD5fZwR36Cmu7zVn/0sJFFPW/vDABOWZ0sHGuk3UvUCihQTCoelw1WxHeu+SU4O13rEXtvpDIy+IMWV4Ni3uNj1g6hYt2Ymcl1jXu/4fsyaxjYpHeZ4ihjQ5vdwZXNJZTGaaHotcEHVmTagAQ1ODidHB6T+5WzOp/nawFSCLfFJGc92XBeTfLxexemRlU1Ad7nN7nTon1sj4+8ugWnsQRkKgq5v8ZAbUxVBMiwpRgfo+uVl0fKtV+xN1gkLu+JNrIG54nHEknOHtoOzCgZ1RCGZP170aGLGchT+VVAA== From: Mark Cave-Ayland To: pbonzini@redhat.com, mst@redhat.com, marcel.apfelbaum@gmail.com, eduardo@habkost.net, imammedo@redhat.com, qemu-devel@nongnu.org Subject: [PATCH v4 02/18] hw/i386/pc_piix.c: remove include for loader.h Date: Thu, 10 Jul 2025 09:52:17 +0100 Message-ID: <20250710085308.420774-3-mark.caveayland@nutanix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250710085308.420774-1-mark.caveayland@nutanix.com> References: <20250710085308.420774-1-mark.caveayland@nutanix.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AS4P189CA0037.EURP189.PROD.OUTLOOK.COM (2603:10a6:20b:5dd::8) To PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR02MB7159:EE_|CYXPR02MB10266:EE_ X-MS-Office365-Filtering-Correlation-Id: 3107918a-62a3-4640-1bf3-08ddbf8f386d x-proofpoint-crosstenant: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|366016|376014|1800799024|10070799003; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?kEUba1xXYc4NDXTNpsZ2vZuV0aYUUQBeHry3L7+7rk/NQAds3QLw1MOxqbPU?= =?us-ascii?Q?27ii6CL2gtCcB+VQues5gU8eDXkUiwXVNpgMAIuL9DN75QGaX+cafSgSniwM?= =?us-ascii?Q?rx70AWH/ddXhUsuGLmFNSeMWviI7hbzLKHfiHeApVAOkGSbB0vQ1ECQW+ryo?= =?us-ascii?Q?Whe7DPKaB3XiSyjDbnoajLdfnU4XzxtpcUoKZT86ldd1LJsppDhfOkFQn/4l?= =?us-ascii?Q?M/N/meGftpf5mjIRpaJV939EXh1ecPTxYPcTKBJ6YMKPPWMrXqtu6FRnvMXO?= =?us-ascii?Q?4g7FGi6AfYoqGeHiW2/VvaiLb9zYvdYxut3mdcW/0xqAw18V1XT0x3hDvx2f?= =?us-ascii?Q?JXMoezhdhzIRAsvyKB3TiUIFOTFL4tK5Ueo2TEZ88iP947IveLSdI/aG2AK5?= =?us-ascii?Q?TXKdTvx7xitDNexgt/Bilr9Pm54ldfBHix7QDIzyic1PkJgcchBP3J1vcM5O?= =?us-ascii?Q?uab1qHauazNCCtaX9IqXa2Vi/ACItuUDf6dq3/xV6iNlk4cZ/rgo2iv+K3aq?= =?us-ascii?Q?7tD7w0U4BikaR9sYG1HnfzccZo+szAtIGre6EdWTSoUC6J/hGlOFotakKeGz?= =?us-ascii?Q?J7pi+tH5XwPt7oHarce9cJyuzSIvfGmdhtKneoCQyVusFDWswjjscAjpGgTL?= =?us-ascii?Q?4JlrHoFy6ojnKFqnyThPCqd7Hd52zE4INp+8O5n64H2iFzjN3+EZMBSQOy1r?= =?us-ascii?Q?9akFS7tnJF6lIrhrd1WAVP1Flc8Yt+84XEUAJ0EYE0S09f1Ti/6NhjdVvA/1?= =?us-ascii?Q?/KaOV8baXLVR+rSCeruu+kaGVuVVQbzsvazsYvZdDXaJo65l+XMDHSsqZby8?= =?us-ascii?Q?bY0Nd9gYesVZTOLW+xmV7r2z4kB553XgMxtnTsISrpgALCURXLSaRBVUaCo+?= =?us-ascii?Q?QLQZPAPUe/rS5ucsIyx+4jAIB+6PnyUX0/his4S7RNa9yZhe5s+gm3V8jfom?= =?us-ascii?Q?MzlcA/Cln9IsrDr1qICdK96Le86/081+tDNGH8xh1A3x7fDG2PEomCauAyXe?= =?us-ascii?Q?2ouI2HJA5obrFAILNDInp0rCLZ+IY4YCOj//0R9tnzUPhFm8byDcHzbrPlJo?= =?us-ascii?Q?k3XA46U+JSdCetyD1zq6E7QO1Gno/GKhKaXBOies/UFTVKubh5T+Wmb0mcYd?= =?us-ascii?Q?ZTyXhTGvBY+0PbnuRUpIWNFK6WkYgOjJlu9IxpylqL29b61nHJmaCIM/r9dR?= =?us-ascii?Q?uSPN65QXIOgK7SizUcRsyi8GlfgW0HdBuai3etTO3h7QP7QC1L6NJ4YlqG+I?= =?us-ascii?Q?AxPSN8hUVEVw/gf8rbtuDh8ZXYIav9njz2RNCkIFXWmQkswh4/Mwd6DvrNNK?= =?us-ascii?Q?XsZcM9RXzh6VLZlbXHwXXbbKArHVutWk5kdibxB8Onq2AMe2O/iIVl0ukdJy?= =?us-ascii?Q?Uxc2ENb7MuCLv1N8oq91vgpMHPNyUw/BB388MlX7kjO2FyFRgQ=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR02MB7159.namprd02.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(376014)(1800799024)(10070799003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?rq1fRsQSOJqxMHenO0osRTKCNVjbdpTJAs+kubwNDwz0tapBLEusyRCqZfCJ?= =?us-ascii?Q?1UV1qkVYmCse5wxE7OBg9sa320ddCg35IBGM7gyTzqzFCLkPKtN51ES8Xh7v?= =?us-ascii?Q?JRU+o57tpOnIhGIga9x8i0KDd9vbzM1uj4yGXrsYl5CMrJ+7atEw6mSwL5hk?= =?us-ascii?Q?J7SS7GT6y4IjhRfxyVu3t3WHfAOEidU/xVodrznhVLbayh5qAl9LDSgCRA8w?= =?us-ascii?Q?zipqJ3ukG8aPIHygB7X1/8A4kdH+nw00zwS5J+FhUmq1wZxl3lAdaYdtN7fS?= =?us-ascii?Q?tcFFaefxRmaiuWqZTK3lUGjiymwGRbvn8kK8zVJlYKhP4cQMoAt1mM9thpLI?= =?us-ascii?Q?58pPMlZVxjRFDCi5GPa7IM6FFuODddY7C17rH9J+CMjjrm+VZTGcicSTe+qK?= =?us-ascii?Q?WSxjmrJ/5BL2xtVvOcwAXvQEHUX5EkkyUPo2zcTQ8eWXI5cmHzBtcjK1+snp?= =?us-ascii?Q?OKWWk8WZz0viDYfJTthmlvoAOrlcnMk/2q+2Z3BJQyd5/CnqtKYAZ0QxbMFu?= =?us-ascii?Q?qvzM8s8nEvWkzcEPrAqKh7SgQ6jCQhChJ69GGvLuXEqhd+h4pDtBBuOf/JBs?= =?us-ascii?Q?7HYGM/+vECllZ4PwzzFDsp+4sqGUX11mmozSx7FqNjbK77QpBNqivZ+Nq6yW?= =?us-ascii?Q?M3+Mz0/pDSBKHV5i+6fr5DA/Ql6r4Ya+1fR2poUGWGzD3ljL44zWZyCEeNW9?= =?us-ascii?Q?/dDztKzSxJe3zcIbRtHyC6Gm59GIhC1xjFZ8+iTB0lV08YkoOk34wDGzVtye?= =?us-ascii?Q?PX3NJeSxRku1VLgMsdJQPt7wpdxxfnmKFaXEelJOPKsdhr/B+uycPIiQ/etu?= =?us-ascii?Q?mMbaKUZSVaUPhof72y/zuWS9YmnShZWUIKVegnUlN3YnQFEXu8WVckV1uy1Z?= =?us-ascii?Q?RaYLLVjiEE8SQY1lXYMc1U3Fp/oTVgJtFru0DjFgfmiZY0MaJpOwPNFdBMbp?= =?us-ascii?Q?3FQWCxW/y2Kq4kufvICQT/13DenXk5CplDJzdlrAOhgDqeTLSxievyoanQ11?= =?us-ascii?Q?02uJ2x3nw+oVZtDw1cIbnFwvWwF4vclxCOC0U/rqynqc+R6KFIm9Jk6Ff5uU?= =?us-ascii?Q?9VG9eYgCw07ydM2BHwb+XAcU9wqUOlYuXHxQocLfYoMlCsgwx9W1I/s3ZTc0?= =?us-ascii?Q?taMF9EDZxEZtH+JPlFcH6XeTQTRiQa5UM+K7HpELvWxYeMnTRWvxmLUBbjsS?= =?us-ascii?Q?bJYnSgYIx50VcCXqi0/Lv3TNh7bjFQR1y/I6s68Xt3bRVK7EQ8g+JgTPFwX+?= =?us-ascii?Q?trIa6VHEoQwGoPlixdofWak03vPztxHfHGrVzuz1lzKqK/Mp6CqXiXDUtRDl?= =?us-ascii?Q?bpKWttKeW6dc5F/4WUWs8eXDbWFgq95Kpe9Rf2P/EoctM9chDPWnNGMN7Fw6?= =?us-ascii?Q?04QlvQjaiRirW3582X7KmTw0rGtc82van2DU+FmAzhTExGCe/CAMzcpxBXJs?= =?us-ascii?Q?Lk/pbpoBd+I67n3kuD61ttmIbUtmlzNpldg+BTJpgqAci4Pvmp7xe2gY8NMn?= =?us-ascii?Q?onJUSQegoGJdNSQoECStqMCoZ2m09+vGvcY/iNdJtzUidvacuvvPEhGzLXN+?= =?us-ascii?Q?MmLb/lWt+jeJWzLIoAGQ4E6+Af8GanV1bR+vh5iFb9vVHZphiBV9y+Cg3vRP?= =?us-ascii?Q?AU3XNqmEAF7wCVFWkk+GaQK0XrcnOp0istY6dqJ+odGBC0O1po0dsICBcmXC?= =?us-ascii?Q?VVSv8w=3D=3D?= X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3107918a-62a3-4640-1bf3-08ddbf8f386d X-MS-Exchange-CrossTenant-AuthSource: PH0PR02MB7159.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jul 2025 08:53:20.6075 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: bkfHIKbmilcSnhrwma28HMd8QTiBw8V0VdMAXRavd3y10/fW2CcnuNNxRC0c2ZDGPcKVCEwPnWm3XiXqF8sPaPFbxBk7koc1d4YA9L62Rw8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CYXPR02MB10266 X-Proofpoint-ORIG-GUID: VIunBVttXMwq-r0Jx9NtbVgavB-kjSO5 X-Authority-Analysis: v=2.4 cv=ccXSrmDM c=1 sm=1 tr=0 ts=686f7f82 cx=c_pps a=XL6KAwzBRdtyn7N5rzO1KA==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=xqWC_Br6kY4A:10 a=Wb1JkmetP80A:10 a=0kUYKlekyDsA:10 a=64Cc0HZtAAAA:8 a=2ibDuaHqQIY5G2AKcNYA:9 X-Proofpoint-GUID: VIunBVttXMwq-r0Jx9NtbVgavB-kjSO5 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNzEwMDA3NSBTYWx0ZWRfX4cLvhLUFSB2S y0xAibcrJKSKOLn1oNSubbbv+h3of+Yzgy2BgU+UOqfzJbZcfG6suevn2dQPMqbKujIExJ3RGSr kaijGBIh3ezbXDiyDYECDQS7sU3EQRQfNcTGk8VKf8gYsPKIX+Xa0in3ViBRpE6SR3Bc+x/SpJC X4N2qWNC1YAncNTPS9i2VY0j+W0Uohye5X+q6XEEh4nGjt1bX5Frfp8ivZgCiBFMhKr7YacISor 2NSGUZJHhQAynRokO0GasuyP6ilXA7a+Id9gXuAeWEzfgEFA8vh9KizqMzjWuSpGQYudEjhFrpn QwDv0KEaCp0+Vr5JSckW0zShld3KmwHV8IQNhRvL1pKaOlfjnjVXdF8ZwsEE6Bn7Fpbaw39y2v/ Mx2huaEEW93XxySNX/UzVLVT82oxJWO0E/IOPGeSYh3bGRTqyQ9I1okX7fY8oi2iZZZeX+mV X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.7,FMLib:17.12.80.40 definitions=2025-07-10_01,2025-07-09_01,2025-03-28_01 X-Proofpoint-Spam-Reason: safe Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=148.163.151.68; envelope-from=mark.caveayland@nutanix.com; helo=mx0a-002c1b01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @nutanix.com) X-ZM-MESSAGEID: 1752137872155116600 Content-Type: text/plain; charset="utf-8" This header is not required since the loader functionality is handled separ= ately by pc_memory_init() in pc.c. Signed-off-by: Mark Cave-Ayland --- hw/i386/pc_piix.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index 67c52d79b2..f66eaeb910 100644 --- a/hw/i386/pc_piix.c +++ b/hw/i386/pc_piix.c @@ -28,7 +28,6 @@ #include "qemu/units.h" #include "hw/char/parallel-isa.h" #include "hw/dma/i8257.h" -#include "hw/loader.h" #include "hw/i386/x86.h" #include "hw/i386/pc.h" #include "hw/i386/apic.h" --=20 2.43.0 From nobody Sat Nov 15 10:54:05 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass(p=none dis=none) header.from=nutanix.com ARC-Seal: i=2; a=rsa-sha256; t=1752137780; cv=pass; d=zohomail.com; s=zohoarc; b=VdvNHCp8Rh1o6kTZkWRygWV7kxOKihWohKsOOthWZPr6GFxCNMgSo2oedVW3QZ7o03HNQ4H+69q6TUsjteBnyX5jXmRdV07c7+uAVD5B+bYsNnWqLIEmJli3FctFTCGPLtUtnL0fMSmicEzqiNYB1Uv0p5rok9DMB2w9M1RsYlY= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1752137780; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=iYVyxYoqfiGHDpRqWkyZluW/ryAIrbcmTgm9J+vvFqI=; b=CEPzp8iWp62WlegKXWiaSG3u3Hp6pA7UJ+NE634P/cxmCHJUF7r85f9e8ulmpO71k9nsOarP1dsNopJtCwC5ENtXeaKt2Z2wMkyyBQ6439ifOyPbLxW+WH/3IBQqQ310PbPTV2EcmHun+xfoRJ/yJd/MqOEexlc64hZOKzRWPMs= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1752137780173883.3415368138445; Thu, 10 Jul 2025 01:56:20 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uZn2H-0007lD-Ad; Thu, 10 Jul 2025 04:53:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uZn25-0007eV-3y for qemu-devel@nongnu.org; Thu, 10 Jul 2025 04:53:34 -0400 Received: from mx0a-002c1b01.pphosted.com ([148.163.151.68]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uZn22-0003WS-LD for qemu-devel@nongnu.org; Thu, 10 Jul 2025 04:53:32 -0400 Received: from pps.filterd (m0127840.ppops.net [127.0.0.1]) by mx0a-002c1b01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 569LQdSl015992; Thu, 10 Jul 2025 01:53:26 -0700 Received: from nam11-dm6-obe.outbound.protection.outlook.com (mail-dm6nam11on2123.outbound.protection.outlook.com [40.107.223.123]) by mx0a-002c1b01.pphosted.com (PPS) with ESMTPS id 47q0cvn27y-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 10 Jul 2025 01:53:25 -0700 (PDT) Received: from PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) by CYXPR02MB10266.namprd02.prod.outlook.com (2603:10b6:930:e8::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8901.28; Thu, 10 Jul 2025 08:53:24 +0000 Received: from PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88]) by PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88%5]) with mapi id 15.20.8901.028; Thu, 10 Jul 2025 08:53:24 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint20171006; bh=iYVyxYoqfiGHDpRqWkyZluW/ryAIrbcmTgm9J+vvF qI=; b=RB9VOTm6SprJkLoLYYBmURC5TYx6a+5Ko2uXnWLE5ApD8k3boe6qneegK WrQr5rb9POyMJowtkRSwx8oyqwT6JXWov7s36lXdRriyR918BTR61z900+3Z/F3O Q1+kbF0wQ3Sf/xzB6N727l9bWZ64h6A1w+b2Dm71lSjpQyWJcfLO/qT8mEpveAwb 8R/3UghPVPrYAydfRJTQKD461ksHg1U7sm44wGegrCNQvgW9yYHFnFb6hU30R8f6 CraZHzG8DlVwhZSn9iukvvKZBitxoqC22VIT6zOBuvXmblwlvpX/rhIygULPpMFa rKM/wShoEZXQSEcaWYFX9L8lGRsWg== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=kT+j8E3tivoAum6aMahnjCPzxUa1mePpptVEwpwM8Br0houbCw7kOW3Ge8vdmBTni2HfINtRrdJcGsP1Pm1UonALvJusD+KCAlWOiwdJZr+VNiH4V2NHenYIeaj14Xq8/PO77dpIIhH8dWF3x9Nwn25caOBZcoLr0dFuyAX+hqByBokvytzK+QHPl9CdEeGt47Lq/wgZVunweJ0uld0BV5hhrsjPpuWrj5NehpM5lZAR6ECZKwewmGyqtUcYcruHMVTbZJ2vGtCdR9X4opKYR77qIgymTVFmElQLg1IGfmpIIErVEwOYpRZC/9bMzhsKWNrLZWMmwJ4VlhR/xl04ZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iYVyxYoqfiGHDpRqWkyZluW/ryAIrbcmTgm9J+vvFqI=; b=k2DyM93FjVgrA9MlUEYivY8He9fxeXM64ZVgIhW3Rrdz+J4jLxmvxz+vQHW7njF9Q9eWc/e/RdSEHxpHO3phT6nZzOu0SQhs6qd/0wpZy+2rfgCeVCcFhEGP1ufGUqiEmOHuyl146ODwQl9pHQaG4KGymGQE3+zVZxe4qBhd/wc0wwt5hYVhm3ODDhxy78DFwP9ybQgPEel4JCJbZ/gSuvmXfNoappL4MI7MoGrt5NnErVJvonPTqtO02S0NPtpXkQKcxgK/OGjinQUn9GeBSihu0nYMB7YIiz+wWxboUdbJ2gWCH6HSzWlsWvQ56zShyMnMCdQRXIOmdWpvH4V0GA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iYVyxYoqfiGHDpRqWkyZluW/ryAIrbcmTgm9J+vvFqI=; b=sESEwpNNSZUyNCGR31SzMSR/+i4auRbHfFKFB9UwFKQ31INrRHsIZVoSyeREFbua8pmoqFhBQTTQqMY2Sm9u0Y/sbAoIgNtvsNT74Jyq/1nBOgaYLBkArFPlwU71WOPs9a9KRgZX7HHuUczM7d1ryO4R0bO6RRC5jqi2UZEWE3u3SM9k7bXDerlQVrcO5k703QA6zxFfpPy5KYxWWshEamy2tNM0tc5jMN7aR9SxPFDpPz3HO42PMQ5vheUtnIPVHwN48sU61xtvtVKpyMEPR8mvkewtoey8jv8T8KpDZfmKNRVPQEj+XixibQTvC9zpGlNmhInbS5yFh5ie18baXg== From: Mark Cave-Ayland To: pbonzini@redhat.com, mst@redhat.com, marcel.apfelbaum@gmail.com, eduardo@habkost.net, imammedo@redhat.com, qemu-devel@nongnu.org Subject: [PATCH v4 03/18] hw/i386/pc_piix.c: duplicate pc_init1() into pc_isa_init() Date: Thu, 10 Jul 2025 09:52:18 +0100 Message-ID: <20250710085308.420774-4-mark.caveayland@nutanix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250710085308.420774-1-mark.caveayland@nutanix.com> References: <20250710085308.420774-1-mark.caveayland@nutanix.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AS4P191CA0012.EURP191.PROD.OUTLOOK.COM (2603:10a6:20b:5d5::11) To PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR02MB7159:EE_|CYXPR02MB10266:EE_ X-MS-Office365-Filtering-Correlation-Id: da831c93-d36f-4912-d852-08ddbf8f3a85 x-proofpoint-crosstenant: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|366016|376014|1800799024|10070799003; X-Microsoft-Antispam-Message-Info: =?utf-8?B?Y25wNHYyaXdRZExaeXR3azhYbmRVRnh3d2poaitPdkNVcmYxTzhWN29KRHpO?= =?utf-8?B?S3FtVUZ5MmVYTU5iQ3RPWHRJMkgxeEFIdnNqVTdvbFphb0dMZlVmQkVBNkRh?= =?utf-8?B?V0pGZjJSOHpZMTlBVHRxME5HM0oyeUtqNlRIcGJCV203YnN4VVBMTGhuVlFB?= =?utf-8?B?K3Q4WGczbk5SNyt5a1dMRUdJSERBKzdMNkl1OVlTMG5SUERUKzRvTG1Jc1ha?= =?utf-8?B?OHNCSmh2aHE5YW1GOUZ0ZU5LZ2FuLzNvbzN3WnBYYXk1MmRMaHdzblhDbWZm?= =?utf-8?B?L3l5QkIvSjBsOFpkZkZrdU0yMkdjdzVKTkpxYU1wZFEyUkNwUS90Nm1hbStX?= =?utf-8?B?L3duMWcrOGc5SURZUEN6U1A3SjVpVW44Q1pBZkM3NkJPK1hkNkk3YTVpMS9R?= =?utf-8?B?dlN0cW8vZStXL2ZlWGZ2MGdxYzBMdDhwcUNxMm9VdWFraHZYbHZzaFl5RFdm?= =?utf-8?B?anZoakIvUGsxOXdkMG5FYlM2UnA0QStrUnRtM1BmdTdFUTliRVk1RTdEa3cz?= =?utf-8?B?T2NrN240VTMyODQ1QmFIVHQxdUkzSjRkbHVaUHg1dXgzaGZsM3NManhiNUlQ?= =?utf-8?B?VTFtdXZGQnpDeWtmOExBU0x3cmZ4ZjJnemRqQnJiWE1VREV3MmdCdWFJZmN4?= =?utf-8?B?aXgzWXdQOXNkL3JmcDFSWjFBcjVWUytOVmdkWEZKV2VlRDJVbzRrZksxUStr?= =?utf-8?B?ZFRGd2pJQzVWczBSWGNNOThtRWc2anRPa29PaDMwbm5RbFdta1JTSnZLRDNl?= =?utf-8?B?NnQ4aVJUQjdVTzRBek1iYzZYL3RhbWw0azRpaGwvVjVtb0RNOTZoblNObUV5?= =?utf-8?B?cTZiWHpHczUwMEZHMU9PL3BvZzFic1FZQ2c1MXJwQW0zRDNwSTBkQ3ZHUkpq?= =?utf-8?B?TjZFbndIY2ovamo5alIwRHZJaTcwclloV0NPL0ZtcmdwMDJzTk9JVUJqdWl1?= =?utf-8?B?ampwUk9ESndBdHNYRzJGTUlpRGcybHJ0c2JSSERCTW95alA4MnZaQjlydFNI?= =?utf-8?B?OEtYOTZKdDZOTVNIRkF4cTR0NmNYVG5nNk9RYlAvQkNJdmd4YzFReUo4MjA3?= =?utf-8?B?SUxSZnFxbVhBYmxhdUp0Q0xDWWxDZW5LZzYxMDJZeWpKMzRNNlo0QjNtemNS?= =?utf-8?B?WEpjU1FZa1lzUUMxRlV3RFZuenpnZllDU0gwY2IzZllFbVlpc3p3YXk1UklG?= =?utf-8?B?WU50V2IvV3Bod0MwczNpWUZNN2VJLzJTZjI4cXpBa3hOZVF2Z2VhYVcrZklj?= =?utf-8?B?S1VNY1N1MVY3RCtxcWc2WXNFSW5mWTBzVkNnckh2ejduMW43MmpPTU9INUtQ?= =?utf-8?B?THN2eXo5RkNSUTBPVkR5M1RYeWxwQVJKUklnWjF3em9QMm9kNi85Ym16VURi?= =?utf-8?B?aXIrbWc1Z2xsOTJXMFVnK3l0R1VyNFAvSkYrU3hUdkdoUDd2eTBRQjFlWkRC?= =?utf-8?B?VGJrTnN5TlZ3SElEdVJpazgzR0ZHMGFuMXVUdWpRa3ZRdmY5NGFwdEp2ckox?= =?utf-8?B?QkNZRURNYUVpOU1Hb2tVeXFndzYvYmZ6VUpoR2NqRlhaRktOWDhsckNITWg4?= =?utf-8?B?K2VyZ0V5c1Z0MTgwNGgvWXB5RnlkSmdkSTJwQ0M0YWlYUE5CR0phQW5peXVJ?= =?utf-8?B?VnV5YThCK3lRMC9aUS91eVRPRkRYQ0M0YUM3VmdPSUdvQXNiWW54Vmk2VWVT?= =?utf-8?B?OGZBNk1wNGFRb3lVcmhRNkdMampxWmdJY1JQR3BEY3JzMDBPTnFvZkZ4SzJB?= =?utf-8?B?UUo4M3Y2UmJHc21nSnd6dWVKQW1NYVpMblR2YUJ3dG5uaWJXL1daWFppVUdn?= =?utf-8?B?VHdGNVFoV2VxYUJIM3JMWkg2VjB2MnUrenp4bjFFK0NkTm5VWkcyVDNrdHpu?= =?utf-8?B?SnZoNW9XZFBzbi9Fd3FqMy9KTTJ4ZHF6cC9yQ0o5SGwvM2MydHpXRVYxc2Nv?= =?utf-8?Q?okcRh4+mPVI=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR02MB7159.namprd02.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(376014)(1800799024)(10070799003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OG5IcThPeVQwQ1dGTmxoSWcvU29mdk0vWWVEbExZcFdJUytNdDVOWHNuNUtl?= =?utf-8?B?OURsWUV2RWRLcE1IVmVKVTAxOFVZWmRiSGtlNUw0ZVA4bjVGbGgycHIyNzRO?= =?utf-8?B?ZVRVU0F4dXkyTjdwdHJNVklWZitPNXMzZXlmdFBNN0hqa0FPQTN6Q3d6dTVp?= =?utf-8?B?K0JPczhra1EzaS9IY3BpRDNBcjVlSGt6MHcvS0pwY1BzaHFZUUlOZmlWcng3?= =?utf-8?B?L2lqMmNBWFZieVgwSEdpRDI5WlI1UlU0VlNpcEZjM2xtV1IrdVpZWjBXVE96?= =?utf-8?B?OEw1OGpmZHdJY0M1SktoOFMzc3dmeUF1UDU0TlpjOVI1M2hKREd0OGZOM012?= =?utf-8?B?eU1maUNJRENwcU9PUTU2ak9ITWJYd2I5R1RLaUNlYk9RQUdEczltdThtNHZU?= =?utf-8?B?UnFBM0tldmVBM2trTlZvT0dZcHpLeGRHZit0UUFjNVg5Qm1Wc0dRNTVPTVlP?= =?utf-8?B?OFlwSHd0S3ZETEQzcnE5dElES2RmdXhqMkpGRUwzZXcyMlF0MjlnM2RCcHRo?= =?utf-8?B?VlF0YnVYZ2xxc2xGTmRqQy90ZUpKeFRGT01KRjFkRXhkNnJ4S3FacVE5UHhz?= =?utf-8?B?OXVGajVodFh6cXVpUFRWZm5kaXJ2M25mdldzVFpTUXpQZUR3UGFuTmE0MDZx?= =?utf-8?B?R2lqcjFrdzFrNWFjbWZHNitTSE5lZTlOcXF5UjhjczJNZk5oQ203OE55R1cy?= =?utf-8?B?Z1AxMmkyWkVFazhoS0tIL1VQNzVaNWhkN1JtWDcwSXB6YU1lN2Y3S0tvUzNl?= =?utf-8?B?Z1dzbnNYaUNlLzVrN1k3MTd4OW91NXlReGIzU2syOVZyMlpCK2MyN1ppaXBj?= =?utf-8?B?bTdQMlF1TkhjN1BqTEJRa01TbXVMMjV4K1hybmxkL0hOTm0xTlhtRUc4Z1N5?= =?utf-8?B?MGdWcC9WblZ3VVEwbFhmVm9tSXpFRGpUQXZUWEMzT0NaaWFXdS8zS043TjR5?= =?utf-8?B?VjlCRkdYc0o4TFJiREtuUHVNcXlVZU9UZE94OXc2MG9wajBkWmFoUzhINXhz?= =?utf-8?B?TzdFMUNmRGs0cWhYUU1PS2JIN250NE0yQ2FyREduTU9HUUh4dG9paFNSNU8w?= =?utf-8?B?U3JqOG4rbThqN0Q4MVVWVGwxd2twaUlBZ056S0FnZUg2RGZ6WnFJa3NINENh?= =?utf-8?B?QnpjRS9obGRPakFsaDRYZ25hZmRpQ0hXZURTbC9SNnYwK2xlT3dMK0owYnIv?= =?utf-8?B?NTk4UW16ckNMQVlmN3dRZnQ2d0IrQUZvTitwQzhwclRCY0hqL0VOUFpnbmFs?= =?utf-8?B?VUp1VTY0WTBnZlFoVHBUbGlmVmdOYVU2U1FzVk44blQ4Nmt6ekxIUkI3Ykho?= =?utf-8?B?WnZ0RTZJaFZxVnFPSlR2cHRIVWFZc1gxNUxtNWFxUFB4ZlE5bnkvdzI1ZTZD?= =?utf-8?B?ZHQ1MVhRd2VSQ2cvMUx6a1lnQmFzUXAvemplM1ZvM1NFRzFGS0FhUVNuMnZD?= =?utf-8?B?UWRJSitXeWg0dnQwa1RVK2hlTEFCQkVvQ0FqM0VkaDd1TEo1YUd2Ky8wUFd6?= =?utf-8?B?U1Jqa2hoUC94bk53TXBmUnpYc0pNNmlOMjA0bENCSVlZT0JZcDk2RDNrTHpN?= =?utf-8?B?SnVCNVVkeHJOS1AwVlhJamJOQXoxbUp3TURLMjdJOWxsVk1TWVdyTDEzU1FR?= =?utf-8?B?U0RGTWlGdWpaMklaQ2ZjcHBqczdsekcxcE1YOEpwNENESlROK1lWcVB1Y0NN?= =?utf-8?B?UmlQUlQ3NWVITmppM2hQVG9vK0JiNVBQS05FaldYRDJKdGYyUTgzZVlUdnVD?= =?utf-8?B?ampVQmlOVldKZjhNNUdta3AydjVaTnVDVzAvUnZUVER5OUxRUzN5YzlmUGNu?= =?utf-8?B?Vkcwa3VSQlFYQktkODBjVXJWNXFTWnNGazdyeE1MWVRZYjZHNkRVcHEwVUhS?= =?utf-8?B?cS8zUEZJS3kveWNJVDJyOWMvQ1FldVJyYXU3ZjhJWmgwSnRNSzc5VTJ6a3hv?= =?utf-8?B?Q1BreFZmUWNQYlJuQk8vNTI4Z00vbjJHTEJIZlpveDFLM3hQRFdiczVIUE41?= =?utf-8?B?Wjk1cjluTmFWbzloUDBCckRKMVcvb0Z3a3VqMVl5ck9JTmlGZjdsd2tKMDBD?= =?utf-8?B?TjR2WWZmclc0azlkLy9XYjliaVRSTFFZZWZTKzZhdW1NRFNSZDFBbDU4VUFn?= =?utf-8?B?bHpqcDV1WnJTZ1ZjeVVZSlpKZTZWMG1lcVc3S1FXR295dWpMbkkvanFhQW82?= =?utf-8?B?VkJSNExVUngzY0Q2UHFtK05aR0ltWEQ5QzB1UGtzejhwZ2hydndTMld6QVpH?= =?utf-8?B?aVFsSVhPNWlnemJ6eVZneWZJdnVnPT0=?= X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: da831c93-d36f-4912-d852-08ddbf8f3a85 X-MS-Exchange-CrossTenant-AuthSource: PH0PR02MB7159.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jul 2025 08:53:24.1798 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 6bGoda4GXCughTDFs0jNOBcCrOoICo2wPuAlGJ5jBGZ5xod19x8wSbBR7ELaFHR833OdxRuP70+qHz2ZqM6ZGRg/QxyvRRiwx7Pf8oRH8yM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CYXPR02MB10266 X-Proofpoint-ORIG-GUID: M9ddES7DkybxJ7nOz656YpAjQzmiw8uw X-Authority-Analysis: v=2.4 cv=ccXSrmDM c=1 sm=1 tr=0 ts=686f7f85 cx=c_pps a=b6Rudwk60yQbI76W7G6FkA==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Wb1JkmetP80A:10 a=0kUYKlekyDsA:10 a=64Cc0HZtAAAA:8 a=KKAkSRfTAAAA:8 a=EScErfUSVzH1iicdKiYA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-GUID: M9ddES7DkybxJ7nOz656YpAjQzmiw8uw X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNzEwMDA3NSBTYWx0ZWRfX+AcQooWB/s4E azupsfAF9CTANiLLrO1XffLHf8C2+UryaFOSEhhieh7Z1PeRwE4iWkn+rXFkl5ITD741dIFjuTu vJJpHTxo1YiXTZvmCNNilCaOTVBJps/37YGRLQFtV7YFKm7sFNOokGcQMzJrj6d59zMy9GAbZjX QQL7BMfgZwbATBuOWQ6jAGZZt6OZo8SB7tJ3xsebO4qALwhKOFnAr2zZvZ7YHm6hXVxP7RtFTJW YtHCJeJRyBkG6Y7KZu3AgG/NwOrx78e07/mKLL4JiDsyZMfx84QSUuQNCavILyL4cDKU61kvx2R o1ATqxUwzLNsGoVOUsR+MzKw+y2N3GBgXnOxYtJrXFc1eNVO3x3THD6ADTLSPWT/a9s9zaiAyNE sp/hRaThgs65Uo+QBbW20x7DGH9CgJvRLKCIBTqlOD/tldhUDVyCkhjHvLfQIPrQ/e7BGjB2 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.7,FMLib:17.12.80.40 definitions=2025-07-10_01,2025-07-09_01,2025-03-28_01 X-Proofpoint-Spam-Reason: safe Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=148.163.151.68; envelope-from=mark.caveayland@nutanix.com; helo=mx0a-002c1b01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @nutanix.com) X-ZM-MESSAGEID: 1752137781200116600 This is to prepare for splitting the isapc machine into its own separate fi= le. Signed-off-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- hw/i386/pc_piix.c | 261 +++++++++++++++++++++++++++++++++++++++++++++- 1 file changed, 260 insertions(+), 1 deletion(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index f66eaeb910..0928b905d5 100644 --- a/hw/i386/pc_piix.c +++ b/hw/i386/pc_piix.c @@ -417,6 +417,87 @@ static void pc_set_south_bridge(Object *obj, int value= , Error **errp) #ifdef CONFIG_ISAPC static void pc_init_isa(MachineState *machine) { + const char *pci_type =3D NULL; + PCMachineState *pcms =3D PC_MACHINE(machine); + PCMachineClass *pcmc =3D PC_MACHINE_GET_CLASS(pcms); + X86MachineState *x86ms =3D X86_MACHINE(machine); + MemoryRegion *system_memory =3D get_system_memory(); + MemoryRegion *system_io =3D get_system_io(); + Object *phb =3D NULL; + ISABus *isa_bus; + Object *piix4_pm =3D NULL; + qemu_irq smi_irq; + GSIState *gsi_state; + MemoryRegion *ram_memory; + MemoryRegion *pci_memory =3D NULL; + MemoryRegion *rom_memory =3D system_memory; + ram_addr_t lowmem; + uint64_t hole64_size =3D 0; + + /* + * Calculate ram split, for memory below and above 4G. It's a bit + * complicated for backward compatibility reasons ... + * + * - Traditional split is 3.5G (lowmem =3D 0xe0000000). This is the + * default value for max_ram_below_4g now. + * + * - Then, to gigabyte align the memory, we move the split to 3G + * (lowmem =3D 0xc0000000). But only in case we have to split in + * the first place, i.e. ram_size is larger than (traditional) + * lowmem. And for new machine types (gigabyte_align =3D true) + * only, for live migration compatibility reasons. + * + * - Next the max-ram-below-4g option was added, which allowed to + * reduce lowmem to a smaller value, to allow a larger PCI I/O + * window below 4G. qemu doesn't enforce gigabyte alignment here, + * but prints a warning. + * + * - Finally max-ram-below-4g got updated to also allow raising lowme= m, + * so legacy non-PAE guests can get as much memory as possible in + * the 32bit address space below 4G. + * + * - Note that Xen has its own ram setup code in xen_ram_init(), + * called via xen_hvm_init_pc(). + * + * Examples: + * qemu -M pc-1.7 -m 4G (old default) -> 3584M low, 512M high + * qemu -M pc -m 4G (new default) -> 3072M low, 1024M high + * qemu -M pc,max-ram-below-4g=3D2G -m 4G -> 2048M low, 2048M h= igh + * qemu -M pc,max-ram-below-4g=3D4G -m 3968M -> 3968M low (=3D4G-1= 28M) + */ + if (xen_enabled()) { + xen_hvm_init_pc(pcms, &ram_memory); + } else { + ram_memory =3D machine->ram; + if (!pcms->max_ram_below_4g) { + pcms->max_ram_below_4g =3D 0xe0000000; /* default: 3.5G */ + } + lowmem =3D pcms->max_ram_below_4g; + if (machine->ram_size >=3D pcms->max_ram_below_4g) { + if (pcmc->gigabyte_align) { + if (lowmem > 0xc0000000) { + lowmem =3D 0xc0000000; + } + if (lowmem & (1 * GiB - 1)) { + warn_report("Large machine and max_ram_below_4g " + "(%" PRIu64 ") not a multiple of 1G; " + "possible bad performance.", + pcms->max_ram_below_4g); + } + } + } + + if (machine->ram_size >=3D lowmem) { + x86ms->above_4g_mem_size =3D machine->ram_size - lowmem; + x86ms->below_4g_mem_size =3D lowmem; + } else { + x86ms->above_4g_mem_size =3D 0; + x86ms->below_4g_mem_size =3D machine->ram_size; + } + } + + pc_machine_init_sgx_epc(pcms); + /* * There is a small chance that someone unintentionally passes "-cpu m= ax" * for the isapc machine, which will provide a much more modern 32-bit @@ -429,7 +510,185 @@ static void pc_init_isa(MachineState *machine) machine->cpu_type =3D X86_CPU_TYPE_NAME("pentium3"); } =20 - pc_init1(machine, NULL); + x86_cpus_init(x86ms, pcmc->default_cpu_version); + + if (kvm_enabled()) { + kvmclock_create(pcmc->kvmclock_create_always); + } + + if (pcmc->pci_enabled) { + pci_memory =3D g_new(MemoryRegion, 1); + memory_region_init(pci_memory, NULL, "pci", UINT64_MAX); + rom_memory =3D pci_memory; + + phb =3D OBJECT(qdev_new(TYPE_I440FX_PCI_HOST_BRIDGE)); + object_property_add_child(OBJECT(machine), "i440fx", phb); + object_property_set_link(phb, PCI_HOST_PROP_RAM_MEM, + OBJECT(ram_memory), &error_fatal); + object_property_set_link(phb, PCI_HOST_PROP_PCI_MEM, + OBJECT(pci_memory), &error_fatal); + object_property_set_link(phb, PCI_HOST_PROP_SYSTEM_MEM, + OBJECT(system_memory), &error_fatal); + object_property_set_link(phb, PCI_HOST_PROP_IO_MEM, + OBJECT(system_io), &error_fatal); + object_property_set_uint(phb, PCI_HOST_BELOW_4G_MEM_SIZE, + x86ms->below_4g_mem_size, &error_fatal); + object_property_set_uint(phb, PCI_HOST_ABOVE_4G_MEM_SIZE, + x86ms->above_4g_mem_size, &error_fatal); + object_property_set_str(phb, I440FX_HOST_PROP_PCI_TYPE, pci_type, + &error_fatal); + sysbus_realize_and_unref(SYS_BUS_DEVICE(phb), &error_fatal); + + pcms->pcibus =3D PCI_BUS(qdev_get_child_bus(DEVICE(phb), "pci.0")); + pci_bus_map_irqs(pcms->pcibus, + xen_enabled() ? xen_pci_slot_get_pirq + : pc_pci_slot_get_pirq); + + hole64_size =3D object_property_get_uint(phb, + PCI_HOST_PROP_PCI_HOLE64_SI= ZE, + &error_abort); + } + + /* allocate ram and load rom/bios */ + if (!xen_enabled()) { + pc_memory_init(pcms, system_memory, rom_memory, hole64_size); + } else { + assert(machine->ram_size =3D=3D x86ms->below_4g_mem_size + + x86ms->above_4g_mem_size); + + pc_system_flash_cleanup_unused(pcms); + if (machine->kernel_filename !=3D NULL) { + /* For xen HVM direct kernel boot, load linux here */ + xen_load_linux(pcms); + } + } + + gsi_state =3D pc_gsi_create(&x86ms->gsi, pcmc->pci_enabled); + + if (pcmc->pci_enabled) { + PCIDevice *pci_dev; + DeviceState *dev; + size_t i; + + pci_dev =3D pci_new_multifunction(-1, pcms->south_bridge); + object_property_set_bool(OBJECT(pci_dev), "has-usb", + machine_usb(machine), &error_abort); + object_property_set_bool(OBJECT(pci_dev), "has-acpi", + x86_machine_is_acpi_enabled(x86ms), + &error_abort); + object_property_set_bool(OBJECT(pci_dev), "has-pic", false, + &error_abort); + object_property_set_bool(OBJECT(pci_dev), "has-pit", false, + &error_abort); + qdev_prop_set_uint32(DEVICE(pci_dev), "smb_io_base", 0xb100); + object_property_set_bool(OBJECT(pci_dev), "smm-enabled", + x86_machine_is_smm_enabled(x86ms), + &error_abort); + dev =3D DEVICE(pci_dev); + for (i =3D 0; i < ISA_NUM_IRQS; i++) { + qdev_connect_gpio_out_named(dev, "isa-irqs", i, x86ms->gsi[i]); + } + pci_realize_and_unref(pci_dev, pcms->pcibus, &error_fatal); + + if (xen_enabled()) { + pci_device_set_intx_routing_notifier( + pci_dev, piix_intx_routing_notifier_xen); + + /* + * Xen supports additional interrupt routes from the PCI devic= es to + * the IOAPIC: the four pins of each PCI device on the bus are= also + * connected to the IOAPIC directly. + * These additional routes can be discovered through ACPI. + */ + pci_bus_irqs(pcms->pcibus, xen_intx_set_irq, pci_dev, + XEN_IOAPIC_NUM_PIRQS); + } + + isa_bus =3D ISA_BUS(qdev_get_child_bus(DEVICE(pci_dev), "isa.0")); + x86ms->rtc =3D ISA_DEVICE(object_resolve_path_component(OBJECT(pci= _dev), + "rtc")); + piix4_pm =3D object_resolve_path_component(OBJECT(pci_dev), "pm"); + dev =3D DEVICE(object_resolve_path_component(OBJECT(pci_dev), "ide= ")); + pci_ide_create_devs(PCI_DEVICE(dev)); + pcms->idebus[0] =3D qdev_get_child_bus(dev, "ide.0"); + pcms->idebus[1] =3D qdev_get_child_bus(dev, "ide.1"); + } else { + isa_bus =3D isa_bus_new(NULL, system_memory, system_io, + &error_abort); + isa_bus_register_input_irqs(isa_bus, x86ms->gsi); + + x86ms->rtc =3D isa_new(TYPE_MC146818_RTC); + qdev_prop_set_int32(DEVICE(x86ms->rtc), "base_year", 2000); + isa_realize_and_unref(x86ms->rtc, isa_bus, &error_fatal); + + i8257_dma_init(OBJECT(machine), isa_bus, 0); + pcms->hpet_enabled =3D false; + } + + if (x86ms->pic =3D=3D ON_OFF_AUTO_ON || x86ms->pic =3D=3D ON_OFF_AUTO_= AUTO) { + pc_i8259_create(isa_bus, gsi_state->i8259_irq); + } + + if (phb) { + ioapic_init_gsi(gsi_state, phb); + } + + if (tcg_enabled()) { + x86_register_ferr_irq(x86ms->gsi[13]); + } + + pc_vga_init(isa_bus, pcmc->pci_enabled ? pcms->pcibus : NULL); + + /* init basic PC hardware */ + pc_basic_device_init(pcms, isa_bus, x86ms->gsi, x86ms->rtc, + !MACHINE_CLASS(pcmc)->no_floppy, 0x4); + + pc_nic_init(pcmc, isa_bus, pcms->pcibus); + +#ifdef CONFIG_IDE_ISA + if (!pcmc->pci_enabled) { + DriveInfo *hd[MAX_IDE_BUS * MAX_IDE_DEVS]; + int i; + + ide_drive_get(hd, ARRAY_SIZE(hd)); + for (i =3D 0; i < MAX_IDE_BUS; i++) { + ISADevice *dev; + char busname[] =3D "ide.0"; + dev =3D isa_ide_init(isa_bus, ide_iobase[i], ide_iobase2[i], + ide_irq[i], + hd[MAX_IDE_DEVS * i], hd[MAX_IDE_DEVS * i += 1]); + /* + * The ide bus name is ide.0 for the first bus and ide.1 for t= he + * second one. + */ + busname[4] =3D '0' + i; + pcms->idebus[i] =3D qdev_get_child_bus(DEVICE(dev), busname); + } + } +#endif + + if (piix4_pm) { + smi_irq =3D qemu_allocate_irq(pc_acpi_smi_interrupt, first_cpu, 0); + + qdev_connect_gpio_out_named(DEVICE(piix4_pm), "smi-irq", 0, smi_ir= q); + pcms->smbus =3D I2C_BUS(qdev_get_child_bus(DEVICE(piix4_pm), "i2c"= )); + /* TODO: Populate SPD eeprom data. */ + smbus_eeprom_init(pcms->smbus, 8, NULL, 0); + + object_property_add_link(OBJECT(machine), PC_MACHINE_ACPI_DEVICE_P= ROP, + TYPE_HOTPLUG_HANDLER, + (Object **)&x86ms->acpi_dev, + object_property_allow_set_link, + OBJ_PROP_LINK_STRONG); + object_property_set_link(OBJECT(machine), PC_MACHINE_ACPI_DEVICE_P= ROP, + piix4_pm, &error_abort); + } + + if (machine->nvdimms_state->is_enabled) { + nvdimm_init_acpi_state(machine->nvdimms_state, system_io, + x86_nvdimm_acpi_dsmio, + x86ms->fw_cfg, OBJECT(pcms)); + } } #endif =20 --=20 2.43.0 From nobody Sat Nov 15 10:54:05 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass(p=none dis=none) header.from=nutanix.com ARC-Seal: i=2; a=rsa-sha256; t=1752137706; cv=pass; d=zohomail.com; s=zohoarc; b=Qi38feAjMT8MN70cwxpdechrmgullM07JAVbDHtAR5e89N2/Q5IN0fJAvu16F13PRQMY2UwaTVQ2zGYOEvfP7uXjNuZXLls6ZVKlto8CGcPIXGjkClY1qoTVxCf8v9kqoBUJtUe2UmG0nxH8s7uGXJ1bddRPCf5mS/JNDn2E8Xk= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1752137706; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=rf28l9VxXD8WH3voqalu+GHAJZPEicVxp3NdxI9vFxI=; b=Pn6cHBZFc0LIxK2qcRqAOYhn+OHdktUyhc8Tk0RDTJFgyV3iJM1V+CDyYxRCj5l6hg7pLImzEfJ8BOTjUkYDq3XNL9KI8qTbuL2YHAMkTlgTWsdgRs74kHsXIQCrxjP8alvYvVlf4KVHbO3IIh87ap1bxFCjLjtTzyQQDKhdlEc= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1752137706238659.2783604254062; Thu, 10 Jul 2025 01:55:06 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uZn2F-0007iy-Hq; Thu, 10 Jul 2025 04:53:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uZn25-0007eX-Re for qemu-devel@nongnu.org; Thu, 10 Jul 2025 04:53:34 -0400 Received: from mx0b-002c1b01.pphosted.com ([148.163.155.12]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uZn23-0003Wi-QU for qemu-devel@nongnu.org; Thu, 10 Jul 2025 04:53:33 -0400 Received: from pps.filterd (m0127841.ppops.net [127.0.0.1]) by mx0b-002c1b01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 569LnSQW032547; Thu, 10 Jul 2025 01:53:29 -0700 Received: from nam11-dm6-obe.outbound.protection.outlook.com (mail-dm6nam11on2102.outbound.protection.outlook.com [40.107.223.102]) by mx0b-002c1b01.pphosted.com (PPS) with ESMTPS id 47q1kank1y-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 10 Jul 2025 01:53:29 -0700 (PDT) Received: from PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) by CYXPR02MB10266.namprd02.prod.outlook.com (2603:10b6:930:e8::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8901.28; Thu, 10 Jul 2025 08:53:28 +0000 Received: from PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88]) by PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88%5]) with mapi id 15.20.8901.028; Thu, 10 Jul 2025 08:53:28 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint20171006; bh=rf28l9VxXD8WH3voqalu+GHAJZPEicVxp3NdxI9vF xI=; b=konfmpQJH8mESR+7LGRmnlMZvwgqXtzTINMQJsjo9BB24U0Yo9mwCfKyP gIJ7ZEM0tWLH9YunqFxi3LWrnnoeGQzlJfYY3E49JEuLsOg8NyKUtFzA2X8xYYXG cBKVPmS3S+fXF78vbkHCxHDKZ4VmUglR7jd6gaYibgVdFy2y+WkCiO2F30ByH0cA Bid8B4O9CeQA6+S6CmHmVo27aNRm1SOKLfrVe3edIQkU44B8wqPhXr7N5EklHBmR bNfSiqoyfTue8Q0vIvjvBapWgmJlG45D3k1RDWyJgVZvMuMLY4gObyTEMcyvW9Gv QnWjq4uELHNEE0GgxzqpgoIyxTvWw== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=C+dn2jZnMAy3LzjJ8wIRy53iLCm140XnpSNZZaEfvNMxsRNUh2oerhk4Dm8Jx/P815cSWJss0BCRiBNeyTn+IPt9zsSLC2Sl9+baEDBD0jSd91NfLAHFUwTqsSZgIL9ug1uUEhUUw30BO/u5Hdnu/jUlE4bOgFZd0SxYfYNV0PzfZJVcjMnLGq9SYo19AP0acjMH+4VzfG38zrwE24sCbJgf00wICO/9ebV/3xqfjJUTWyOw94ONR9WSKVAbN8WvXye5zkpdnWaenQ19bGERPnCgJtnZLKKfsavi0Ml/QNrh6jfDkm/1Odtxus+4RZLZG6i2VZvw0QDASKlQ3U/rPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rf28l9VxXD8WH3voqalu+GHAJZPEicVxp3NdxI9vFxI=; b=NeYjKZw87KszkppFqL7cUusS8g0NNMkQIrU4jjXKxdhamuuTaSedhjRSV3GP1Yvu/hQempWsXQs4kjYrK4W3h94tCl53Ogb5+gtR8iGXA4wkhs7y58cWiDGYZPnc5qptjjMd2XKGwUqj+xcEx1SAChfEFf0TLU8SOmHAyDuG5qfCmcg0qoK13uubRFo6J5bNeRtHq4UiaozdOBzZn6fRd8YFbO6JpgeGh7fqjHh97LpiJ0fGz9682rpsJgz8wr9nCj55ezDhCxdCQaQ/5ys5ptCryGux/QXkleobP7xcx1Lph37uJWjxbWOAaaV6y0xhyDJL7MJwgyG4Egr7ctOSkg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rf28l9VxXD8WH3voqalu+GHAJZPEicVxp3NdxI9vFxI=; b=Wzi8aKx3aBqk+ASzp8zGssYc+UMtQRVBkIK+RBg6RvVh7DvWUYEgYwsu2d5AfQpjnbEiOPHHuo5vrki0yIk5KTpv+a6A+TlvYxaYc/x6sfIWu4qa++rOWI3H4eUNuP8lFVMbW9qmPt2pbtYbNQTfdVE9sMHnBaYPHTcqMKEl3XIHHkX1+mXJ99M48Myo6wcfFPFokqwrGqsVD+xe5FOo+TYR+kzkld49ekw15aisK7GtgDzhRvmHn/7YDC8mF6/iRUxiZiu0a541IjflkjhwaRYYP7oH70jqyBzOUuhgNu+OhQhJcG/4SXR6dhPa1ZZyrxVXs8L/f1WYoFH6b3HxZQ== From: Mark Cave-Ayland To: pbonzini@redhat.com, mst@redhat.com, marcel.apfelbaum@gmail.com, eduardo@habkost.net, imammedo@redhat.com, qemu-devel@nongnu.org Subject: [PATCH v4 04/18] hw/i386/pc_piix.c: remove pcmc->pci_enabled dependent initialisation from pc_init_isa() Date: Thu, 10 Jul 2025 09:52:19 +0100 Message-ID: <20250710085308.420774-5-mark.caveayland@nutanix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250710085308.420774-1-mark.caveayland@nutanix.com> References: <20250710085308.420774-1-mark.caveayland@nutanix.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AM0P190CA0006.EURP190.PROD.OUTLOOK.COM (2603:10a6:208:190::16) To PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR02MB7159:EE_|CYXPR02MB10266:EE_ X-MS-Office365-Filtering-Correlation-Id: 1f5b7c55-9ef0-4c00-46d5-08ddbf8f3ce5 x-proofpoint-crosstenant: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|366016|376014|1800799024|10070799003; X-Microsoft-Antispam-Message-Info: =?utf-8?B?VEdUWFlvakZsSGdCdk1VTjVtSFlMTEVtbnczUmwvM0FHV1Z2TzFDZllFbEtV?= =?utf-8?B?NlZGV3lTZlZKeWR3N1dvbkdRblpmWnhOT1N5ZFQ0M3lORy9VQ1JNOFZ3U2c1?= =?utf-8?B?d29NUlFlWjQrOWhpQzZjclBRNGZIb3RobFJIWk0zZGhDcnlXUU9IcEpzYXJp?= =?utf-8?B?cWc5Rkd3bFR3NFZ3MlA4T2NtOVp0WnB6OTlWcFd0STFVdHhxNGF4TVpuTlJW?= =?utf-8?B?SXFVVG5td0Nqak1YdXVwcW9DRXhIRDZCUUdLSHpnM1hGcU5veTJXalFCbEVJ?= =?utf-8?B?WC9jWkZUcmRLcTh0ZjZ6a2l1WU56MVZNTzVGZTMzYzJmeHYxb1pMa0orTGpZ?= =?utf-8?B?cXB2bm5Oa0xBaHBmcEhibXFqQ0NMTW1GaTdZR3lzcXVoSm1LSSt2c2dsYy9j?= =?utf-8?B?SUpZci9hRTB4OFBnTmlIWTE0LzE0RWFJWUtNeFY5VG9qenNLZFdSeGY4N2hq?= =?utf-8?B?RWhKUDZ4OVFGcVNaVVkwRllzZ05pbmpjRGdmRDhPMTdhNURtQ1Bob01jbDJ1?= =?utf-8?B?eG5XVXZrK0JFRHZHUUtlMnlOcGZHYXFSc1RMVGxUT09xUDhiYmk4bnR3Y0ZY?= =?utf-8?B?NG9DRXR5Mk1OMjl6cy9sanN2Q203d0huanpsbExkSGxEemZmWFUwaEpTNTVh?= =?utf-8?B?cnlMbm1EOHppWHR4V1FDT0V4Rm0vQkVvd2pQNEdraXZEV3RsSURYbnhRU3JB?= =?utf-8?B?b2E3bFcwd2F5TGY1Qi83TUVjOVNweGtjL1I2RWtBdFZqeElhYTk5RGd2a09k?= =?utf-8?B?ZDZwbWp2QjNoQUdrdkpwMUV0YUNkWkFTZkRpZ0NaUGx3blhIZzVkd2o5RlVB?= =?utf-8?B?ZTlyZkZHVklpSDhESVNTc3RvWnUxdkhpaDhiQktmU0p0ODRZbmkvTzBKWFV0?= =?utf-8?B?RkdLVTFMa0N2SlVOQ0NCa3pMemQrdWNGeXZJTTlGK1VhRTJjdm5WWTZ5NFNh?= =?utf-8?B?MkxmN1Q2eHkrWitnQlNVN1hhclROQmpyV0FmUjRtWHdBS01BaE9qZDdkMzBB?= =?utf-8?B?SWhmRXVCeVpOR1VkYWlCdmNPZCtqKytQTmd0L3cwS0puQ3BiT0FRNGUxYXI5?= =?utf-8?B?bE9GUGZOZVRJRXlRUWZDRVVUQk1sSEs3S1hISlNoVldyalUwU2VQLzlmZkND?= =?utf-8?B?MkluRlZKMW9wVUw1MXNmeE9CQTZlUzAzenVtWE5MK0FaYnBhUU1rZWd0RU5U?= =?utf-8?B?ZjkxVHNPSENPdkNZM2FROVBSU3ZRNERiRm9HdXdrd29FS1c2TWVrbXpFaGxB?= =?utf-8?B?SDRpN2w5cnlRcGJkTVgxVHIvU2dhK2dwamc2VStEWk51ZTdWK0l6emhST2pj?= =?utf-8?B?SG1wUEZNRlpndFQvQWxDaWVHUjNNR0JXMCtTN1QvMWgzL2lUd3dNRURlOHJR?= =?utf-8?B?aGNBWklBOHRtWlBibWdGMkF4anZVYU5BNWRNUzhUaGdGVmNpZ1JYbXZUNm44?= =?utf-8?B?bWkycytvZkNLdmF6aTVHSU1RM1FHMk9POGViTDhOUmg0SnNVbWY1RVBCNis0?= =?utf-8?B?dm12K2I4UzRZS2FqSGc0c0pMcDJGM201dWdJTnpTa2Vxc3FTYWsrSTVJL0lM?= =?utf-8?B?RkNqNlYvU1NvcUh5dDAxZ0JvNGphbnZhNDQrT0twdHp4bnhnaklId3ZLRlRY?= =?utf-8?B?YitvWUxvVmVPalVNNWx2bVEycUN0KzVLTnNVOUZuUG44elhYSW9rc1JQYlhD?= =?utf-8?B?K3ovSHRKaWxYb1RRTlZvNVJtMjduSVR2dXdVaEoyM2hNOVRybUVZdUpmb2lY?= =?utf-8?B?Y00wQTBsNjQzN2d1S3hRMTk4bTR6MXNSRnBmQkNwSFFUNGl0R0dvdmdET0Jw?= =?utf-8?B?WDhrOEdVS2FRaVd4eVYzMlNpRjlsKzJyNVg2bE9QcW1Ld1RyWkloSnlQVjYy?= =?utf-8?B?L2Myai8xYkFvM0FMdlJKaFZmM1BjNGF5d0poOVhjZzVlNHJ2d0JFamhzWHdU?= =?utf-8?Q?dUCfDaAaG2k=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR02MB7159.namprd02.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(376014)(1800799024)(10070799003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WlhrWTZGU3VlaVBNcTRiNEtSakE2WDBTZ0NpVWxyUGtVam9kQUYzcXQ1NmRU?= =?utf-8?B?enZNSGdHVjNocVM2RDh0WUxNZG9lTi9XaU54dmhCWDlnd1NvSFBQaUJFRHRa?= =?utf-8?B?VlFabHJudnBLbmdGM0JmSnVXTkdONXdtWFNpdHZTQURFQ0d4U3BzbitiaEp2?= =?utf-8?B?Mnh4OFllbFNVWFlJRm5ZdmZVU0orMnJzamJhS2R3akNZNzEyMGNXZVhidEdv?= =?utf-8?B?SHVuV2UweTY4Zit0VzlDVCsweEMyYnZtZXg0WEhIVGo3TTR0YU9OaUZsclUr?= =?utf-8?B?cmhZRTQvOEdrUUJ1L1hORmJXWmo5YjlsZXd6L2tpZEdjNVJoN2hBK0hVUlEr?= =?utf-8?B?Wk1nNlI4VU5PSVhJMWRtM1B1Ym9BTE9oUDF5NEo3eGlFb0thc2c1MHQwaWRG?= =?utf-8?B?MG1yR0NDbmd0UjJuNTg5WnVib2xJSGFxWmFJWE11d1I3N2NOY1NIRmVUOFBJ?= =?utf-8?B?QVNqQi9XbWhReFpaTlpVbUNPYVZRdFpLS2c2TXZxMzdoTXhkRlBacTN0YWh6?= =?utf-8?B?d3QwQThxdDd3a0NyL0RjdDYxRlh2V1VSbnpDU2UyQVZqNlhwZ2Z0SWM1LytM?= =?utf-8?B?RFdVQWx1VnhaSE82bTNVWEp4SXNEbGM1cjVyb3hQVDdIdk9SUko5TUcrZjAr?= =?utf-8?B?cElvd3ZkS2VrWm5wUHVZKzVJOURxTy9FYTR0MWNxS1ZSRDVGbU95Qm5LN0RQ?= =?utf-8?B?eVV0SHdSb1cvaEJrM0p6ZGNMTHYweGdKR1JnRzZuY0RHMlN0M1BkT2c1d1E1?= =?utf-8?B?VW1ST0ZFN2hFeEpzV1FzcmdPTXMzYnFvTDBzVDl5OVQ4U2tyNjZRaWJESFpF?= =?utf-8?B?N3lqRUVaRDdsL2NoUkp5QVI4ek41V2xtM0hIZWUydVF5S21rRFpMWTF5cXFT?= =?utf-8?B?YW9EN2ZEaWZEY3dIQ2RUK1IrNEh3akZzRFVEYWE0QUVBWFlTVHM3YThKcjdI?= =?utf-8?B?THRCNzNjNjF4Y25rVVE5ekNwRGFpU1lrd3JPcEx6RHpEbDZJclVyWU8xY1g2?= =?utf-8?B?dDFyeFVMNkc2bnB0L0d2SStqcjVnNnNNK213SldKOVg0WTRwMmMvVmRVM0Fm?= =?utf-8?B?VnJiN0NlZXd5ZklUbEdoVW1vWFo2MzVGUjFHSEcxMlZvMldWeUhuUmhEa3ls?= =?utf-8?B?ODlWNk9BamptaEF3WVhsSUw3REhaVVY1UExkTEdndHB3a2x3REFJYWF2VmFR?= =?utf-8?B?a0lUV1NJbE4wbjBXampFdWxQOVBBMHM5OFc3NWF1VW5zaHpYcWNKQ3VlNjdy?= =?utf-8?B?Nml2OEZodE4rSHZCRlJzdE9pcDRnWmVIeURQRk93RlRkaHpxZnN0amZtZysx?= =?utf-8?B?MjJFYUZYMmJwYXpVanRiRThRMmZFU0ZlU0hKUGtQVitkUUlaZFAxNElhd0RM?= =?utf-8?B?K3hpc0FvSkNPSlJhdWp2bmpWYmxod09DMjd5ZnFxOFZncGJVRFBvOEprT3pv?= =?utf-8?B?VFBDQjBUUHFESG9EUXpxaXJGTHRCQ2RHZ1JlS1VqTFZRMTBLZTJaMllFMVRp?= =?utf-8?B?Kzd6K3Y2VDhTU3E0bGZkT3dOdFd1MDVFZWtjZHYrZEY4Z2dxMTAvaEtTRGUy?= =?utf-8?B?bGxiZzNvNUVPK2ptVE1ZbVRNRWN1N3FTSngra0RPUXJETEJ1OFNvb3p5RWVG?= =?utf-8?B?WHN1QkNFMEIxNmkxV1FIUzdOb2dsNlI3VU5BM3hmRkdweVJzR1o3U01BUjFB?= =?utf-8?B?NU81bWV1Tk9BdmJpYmR6eUZucS8va3c0WmJYTy9VWG41aHJ6VDlaMkxCVVZD?= =?utf-8?B?dkxzd3p1T3liVUwzRW8walo3aCtySnNWbHBLN1lZUm1SbGNyVzJpYkpGejEz?= =?utf-8?B?RzExWityVUw2OU1aTTcxU09oMXBIV083cDIxRXBjZ2JHVkZ3SVNxTHpBYmo5?= =?utf-8?B?WVRGTnVkNHFwN2Vmc0hCd3lvSHN1ajY2a0Y0LzNySkdSSlJuV1ZteG1vZjB6?= =?utf-8?B?eHJXUzRnZ1hSTXBOeStQblo0V2ZFNWZJUXNoQ2M0bytMSVBYdHRXK004Y2ZR?= =?utf-8?B?eUNrK3Z5N0o4RXVnTzhEeXBWaUNlN2hYaE9wd0NIbzNnNUo2QnI5bUtNdnlK?= =?utf-8?B?QkZsYXlLZ0ZweDNyWFB2MlZ2WlZvVHpvakVXS1FBT20vUWZFRmJXa0duK1J0?= =?utf-8?B?OGozOGdUdXJ4d0hXcXJEdmFmS3YyejN4U0NTT3NaMVk3UmhQaUxTU0hlZHBo?= =?utf-8?B?NzhnSzR3QnhpV2tMbnFEbmQ3QnpXenhWMUQvZmh3UTNyY1B3ajZFMFByRElR?= =?utf-8?B?dXpSb3Y5Z2krREFlalpRSXB0YjZRPT0=?= X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1f5b7c55-9ef0-4c00-46d5-08ddbf8f3ce5 X-MS-Exchange-CrossTenant-AuthSource: PH0PR02MB7159.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jul 2025 08:53:28.1458 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: j6XoptXCi8SIWq7Ti07H+UbXHJpFnah7P4W3CwlvyrqrAlS5zAQZqY5tqG19e2djrxJ6VjCBzTLXRjn1ZyatLVikLxwZ0XK40xIGWOxAVGU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CYXPR02MB10266 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNzEwMDA3NSBTYWx0ZWRfX/Z7AY8aEiYoD VXkFGCP6AX1yMz05Z9cnNz/CbnSfOAcixwDPtkcKaVNBHdDa4Xduu3tVksNkAsfDBPmzFC3DQf1 YhaCHW46u6KElENeJDvscKIsa2OACqM/Y6GFNk7N6+CdyzrgeXlvp5Rpw/tvAenQkHcMO4xlO0R T+DI0BkVK9+UsF3+wXAdOL5/xUnJtqJRx7b4OROzzlXg9S+pNpKYtBRMqy/Q9rEUzrC5QTkd+0O vYQJZfCj2VNr9nvIK7coOt+LAVVaB6FNeBHz2doU35vRZ+zlNnpSBKvGcXkf3orf1+Wbwb4rawL JwF6Kov4RznHYSQ9Io8fkp8wqf1Kio5boBLj1WxEp2PMP0MG8gzXufiPQrlwhUl1nzR/prLv6jq GiNa8OhvPsvm9bwOLTcaj6ztHT1QjUHhjQmnd/4WUXD+PLzbLVHJrWKp+rMkd7+o361wZIWy X-Proofpoint-ORIG-GUID: aAr8mV7X2qyrEXyvEDl8NQFIytz79YTo X-Authority-Analysis: v=2.4 cv=Do9W+H/+ c=1 sm=1 tr=0 ts=686f7f89 cx=c_pps a=mEzR6i2+MZAQiuWfcobVjw==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Wb1JkmetP80A:10 a=0kUYKlekyDsA:10 a=64Cc0HZtAAAA:8 a=KKAkSRfTAAAA:8 a=pDVciPHeplB8fhom_mUA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-GUID: aAr8mV7X2qyrEXyvEDl8NQFIytz79YTo X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.7,FMLib:17.12.80.40 definitions=2025-07-10_01,2025-07-09_01,2025-03-28_01 X-Proofpoint-Spam-Reason: safe Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=148.163.155.12; envelope-from=mark.caveayland@nutanix.com; helo=mx0b-002c1b01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @nutanix.com) X-ZM-MESSAGEID: 1752137708418116600 PCI code will never be used for an isapc machine. Signed-off-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- hw/i386/pc_piix.c | 105 ++++------------------------------------------ 1 file changed, 8 insertions(+), 97 deletions(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index 0928b905d5..548e81cf1b 100644 --- a/hw/i386/pc_piix.c +++ b/hw/i386/pc_piix.c @@ -417,19 +417,16 @@ static void pc_set_south_bridge(Object *obj, int valu= e, Error **errp) #ifdef CONFIG_ISAPC static void pc_init_isa(MachineState *machine) { - const char *pci_type =3D NULL; PCMachineState *pcms =3D PC_MACHINE(machine); PCMachineClass *pcmc =3D PC_MACHINE_GET_CLASS(pcms); X86MachineState *x86ms =3D X86_MACHINE(machine); MemoryRegion *system_memory =3D get_system_memory(); MemoryRegion *system_io =3D get_system_io(); - Object *phb =3D NULL; ISABus *isa_bus; Object *piix4_pm =3D NULL; qemu_irq smi_irq; GSIState *gsi_state; MemoryRegion *ram_memory; - MemoryRegion *pci_memory =3D NULL; MemoryRegion *rom_memory =3D system_memory; ram_addr_t lowmem; uint64_t hole64_size =3D 0; @@ -516,39 +513,6 @@ static void pc_init_isa(MachineState *machine) kvmclock_create(pcmc->kvmclock_create_always); } =20 - if (pcmc->pci_enabled) { - pci_memory =3D g_new(MemoryRegion, 1); - memory_region_init(pci_memory, NULL, "pci", UINT64_MAX); - rom_memory =3D pci_memory; - - phb =3D OBJECT(qdev_new(TYPE_I440FX_PCI_HOST_BRIDGE)); - object_property_add_child(OBJECT(machine), "i440fx", phb); - object_property_set_link(phb, PCI_HOST_PROP_RAM_MEM, - OBJECT(ram_memory), &error_fatal); - object_property_set_link(phb, PCI_HOST_PROP_PCI_MEM, - OBJECT(pci_memory), &error_fatal); - object_property_set_link(phb, PCI_HOST_PROP_SYSTEM_MEM, - OBJECT(system_memory), &error_fatal); - object_property_set_link(phb, PCI_HOST_PROP_IO_MEM, - OBJECT(system_io), &error_fatal); - object_property_set_uint(phb, PCI_HOST_BELOW_4G_MEM_SIZE, - x86ms->below_4g_mem_size, &error_fatal); - object_property_set_uint(phb, PCI_HOST_ABOVE_4G_MEM_SIZE, - x86ms->above_4g_mem_size, &error_fatal); - object_property_set_str(phb, I440FX_HOST_PROP_PCI_TYPE, pci_type, - &error_fatal); - sysbus_realize_and_unref(SYS_BUS_DEVICE(phb), &error_fatal); - - pcms->pcibus =3D PCI_BUS(qdev_get_child_bus(DEVICE(phb), "pci.0")); - pci_bus_map_irqs(pcms->pcibus, - xen_enabled() ? xen_pci_slot_get_pirq - : pc_pci_slot_get_pirq); - - hole64_size =3D object_property_get_uint(phb, - PCI_HOST_PROP_PCI_HOLE64_SI= ZE, - &error_abort); - } - /* allocate ram and load rom/bios */ if (!xen_enabled()) { pc_memory_init(pcms, system_memory, rom_memory, hole64_size); @@ -565,74 +529,21 @@ static void pc_init_isa(MachineState *machine) =20 gsi_state =3D pc_gsi_create(&x86ms->gsi, pcmc->pci_enabled); =20 - if (pcmc->pci_enabled) { - PCIDevice *pci_dev; - DeviceState *dev; - size_t i; - - pci_dev =3D pci_new_multifunction(-1, pcms->south_bridge); - object_property_set_bool(OBJECT(pci_dev), "has-usb", - machine_usb(machine), &error_abort); - object_property_set_bool(OBJECT(pci_dev), "has-acpi", - x86_machine_is_acpi_enabled(x86ms), - &error_abort); - object_property_set_bool(OBJECT(pci_dev), "has-pic", false, - &error_abort); - object_property_set_bool(OBJECT(pci_dev), "has-pit", false, - &error_abort); - qdev_prop_set_uint32(DEVICE(pci_dev), "smb_io_base", 0xb100); - object_property_set_bool(OBJECT(pci_dev), "smm-enabled", - x86_machine_is_smm_enabled(x86ms), - &error_abort); - dev =3D DEVICE(pci_dev); - for (i =3D 0; i < ISA_NUM_IRQS; i++) { - qdev_connect_gpio_out_named(dev, "isa-irqs", i, x86ms->gsi[i]); - } - pci_realize_and_unref(pci_dev, pcms->pcibus, &error_fatal); - - if (xen_enabled()) { - pci_device_set_intx_routing_notifier( - pci_dev, piix_intx_routing_notifier_xen); - - /* - * Xen supports additional interrupt routes from the PCI devic= es to - * the IOAPIC: the four pins of each PCI device on the bus are= also - * connected to the IOAPIC directly. - * These additional routes can be discovered through ACPI. - */ - pci_bus_irqs(pcms->pcibus, xen_intx_set_irq, pci_dev, - XEN_IOAPIC_NUM_PIRQS); - } - - isa_bus =3D ISA_BUS(qdev_get_child_bus(DEVICE(pci_dev), "isa.0")); - x86ms->rtc =3D ISA_DEVICE(object_resolve_path_component(OBJECT(pci= _dev), - "rtc")); - piix4_pm =3D object_resolve_path_component(OBJECT(pci_dev), "pm"); - dev =3D DEVICE(object_resolve_path_component(OBJECT(pci_dev), "ide= ")); - pci_ide_create_devs(PCI_DEVICE(dev)); - pcms->idebus[0] =3D qdev_get_child_bus(dev, "ide.0"); - pcms->idebus[1] =3D qdev_get_child_bus(dev, "ide.1"); - } else { - isa_bus =3D isa_bus_new(NULL, system_memory, system_io, - &error_abort); - isa_bus_register_input_irqs(isa_bus, x86ms->gsi); + isa_bus =3D isa_bus_new(NULL, system_memory, system_io, + &error_abort); + isa_bus_register_input_irqs(isa_bus, x86ms->gsi); =20 - x86ms->rtc =3D isa_new(TYPE_MC146818_RTC); - qdev_prop_set_int32(DEVICE(x86ms->rtc), "base_year", 2000); - isa_realize_and_unref(x86ms->rtc, isa_bus, &error_fatal); + x86ms->rtc =3D isa_new(TYPE_MC146818_RTC); + qdev_prop_set_int32(DEVICE(x86ms->rtc), "base_year", 2000); + isa_realize_and_unref(x86ms->rtc, isa_bus, &error_fatal); =20 - i8257_dma_init(OBJECT(machine), isa_bus, 0); - pcms->hpet_enabled =3D false; - } + i8257_dma_init(OBJECT(machine), isa_bus, 0); + pcms->hpet_enabled =3D false; =20 if (x86ms->pic =3D=3D ON_OFF_AUTO_ON || x86ms->pic =3D=3D ON_OFF_AUTO_= AUTO) { pc_i8259_create(isa_bus, gsi_state->i8259_irq); } =20 - if (phb) { - ioapic_init_gsi(gsi_state, phb); - } - if (tcg_enabled()) { x86_register_ferr_irq(x86ms->gsi[13]); } --=20 2.43.0 From nobody Sat Nov 15 10:54:05 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass(p=none dis=none) header.from=nutanix.com ARC-Seal: i=2; a=rsa-sha256; t=1752137814; cv=pass; d=zohomail.com; s=zohoarc; b=ZmTD3LBlpIkGQ79AJAZqrZSccc8mZCbsJlg65qC3SclS4b1KCRBMRt40l6GWI/DL1Lt0eAG1qJAjvI+uqVFCXdlt4NcYHhu0B0MU/baWN1KdOBkuyxkf6gs2NcBnYh4HqfYuGn+/TGxp317hd6GXKrLMOYfNEeZSENaIvQIKXLM= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1752137814; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=3b9iGl2PYyETgh+gSdyOOg1jkiqiB+FSsCf8TZ4CayQ=; b=Wv9R0MXcDTjV34xVnUZKUcmiLnC5oOw3EKd8QVubo2MmNhHf0yEbXAGXS0SVd+Fj+6bWWmB7V3R6mrDSgUFCkRTDnRjBGsJNJThHAA2MIO+Ty1j4pmBHqP+U+F7SV6/TtgNZjV+h0AmIE1o3ZQ6/ZiD9VmyqclzeabCTteAm9hE= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1752137814463849.7420105039306; Thu, 10 Jul 2025 01:56:54 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uZn2Q-0007tA-9f; Thu, 10 Jul 2025 04:53:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uZn2D-0007hX-Ho for qemu-devel@nongnu.org; Thu, 10 Jul 2025 04:53:43 -0400 Received: from mx0a-002c1b01.pphosted.com ([148.163.151.68]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uZn2B-0003X3-HG for qemu-devel@nongnu.org; Thu, 10 Jul 2025 04:53:41 -0400 Received: from pps.filterd (m0127839.ppops.net [127.0.0.1]) by mx0a-002c1b01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 569MbfPc010556; Thu, 10 Jul 2025 01:53:34 -0700 Received: from nam11-bn8-obe.outbound.protection.outlook.com (mail-bn8nam11on2091.outbound.protection.outlook.com [40.107.236.91]) by mx0a-002c1b01.pphosted.com (PPS) with ESMTPS id 47rkcn12hy-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 10 Jul 2025 01:53:33 -0700 (PDT) Received: from PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) by CYXPR02MB10266.namprd02.prod.outlook.com (2603:10b6:930:e8::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8901.28; Thu, 10 Jul 2025 08:53:31 +0000 Received: from PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88]) by PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88%5]) with mapi id 15.20.8901.028; Thu, 10 Jul 2025 08:53:31 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint20171006; bh=3b9iGl2PYyETgh+gSdyOOg1jkiqiB+FSsCf8TZ4Ca yQ=; b=FRjtt1P4ZQVdcFlK6O9yf+efVPIgqMFRffiGXHuSIVkouamuv7QK66loe pPbf6yZIRRPfOEirS+XRmavpXECq+7yyNTYtoi13GJBN97dsCf40KJpGcxxPqaAx FiaVzOItLqO9Y/eeSJieQg1K0T5/oEA6VeCxpaoiNt9AhSKCysIa+6mzB431lohY BBVWuhZwq64nQjYsP7oHY0xzBESqqDvNkA8icK7429OrGTmK4nRGDnAqRVV3zBXy QDY6uOgPoKafhhjPx32bsDGoat3YBb7qtjwrGGbZOBLR1EfLxjVkYlWT3e+q32OM h0w0+8PfhFWfChM41+RGXb2Y+DrlA== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=JhY59eeB+GsI0h3X3DcKcVjTy0C6mtPyBL/d1gdoBGAENAtaavaszZ7H4O6VRbvf0xWbWlL7nMeE7cGu7tx2+goO8dFqabhHebAB+WhqdpRQQdak1hhq8uHoGOX6jUqyHzptggMuVQIG2IPX1vpjbojaThYkdjjDoFnLZdrfI/NcsST5oIg4eUV6UR/LZqPmTeC0brZ9Piu7N9lCW7rREunt9hpy4L8Q6elq8rkftoxNf++tTtN6qCpaShASx62/Ej64bS1SZyr3fOo9DQtVPO+SPDGP9oRRSSTv+ygr6dJeWwunL/L2bLn/Phs8GXcFBDxN0oyK3mCQhzq4Hkt3vA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3b9iGl2PYyETgh+gSdyOOg1jkiqiB+FSsCf8TZ4CayQ=; b=erIGYuHzinH2kD96xgNMLLvD6pGI79kgLLmp1aGupNJNebS90bNhOEJBmLfAI7bgBJN9LxLJFioUTTqgalg1YVqpmVgTtXpPyGuAn+wKSYfkLQGoaI5egtYeihvYb+WuaQCjBCjqviYXzsphzS+nntIgJ79xegGzf3TnG5Fq2ZXzFoGZbaThKzJu0Lko373MipMe2kKIWmzNlf6jK3v2dJ93+HXcCL0v1bb7sq4IY/SkiRTf7zP99PSoIy98Xx/iXxVs0o/wTTnmU4Yq6zY4Vi17NdX9FjI0vA6ATxYAaLJRy/tvMONrwRez2iHKAw9vGwgHuhTy3Zz0uvutrRMVaA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3b9iGl2PYyETgh+gSdyOOg1jkiqiB+FSsCf8TZ4CayQ=; b=W60FGF53mWth8eFMmSbs+uJcQDutq4tg7x77VOiRk0+FhEfyWlQVh1awjbYs3Pj2N/fz+iTCH9C7vRfLykpH/ap42PmvUqsM8HhplQu8lujLzjUS2QeR0+PNrNAvCiPIUJQiGutsPtknvTzYjMnJ9MhR1AiNmecZU/UjeNuat8+Vav+EuO+5qf5PHq3/bSw8HHcIN7lTuZzw0PWD6kdc2r6hq6oFryZkfk46A+ldcT2topDMm3lmwOku1Ztr4wHIPiyvefgnTdUgsjkw4oBW9vLf0Oey3exFAn7++da+HaPzfwZO0U1vrR9GsZHAcrNIFQX/+AEnB92PAYX9eXt3jg== From: Mark Cave-Ayland To: pbonzini@redhat.com, mst@redhat.com, marcel.apfelbaum@gmail.com, eduardo@habkost.net, imammedo@redhat.com, qemu-devel@nongnu.org Subject: [PATCH v4 05/18] hw/i386/pc_piix.c: remove SMI and piix4_pm initialisation from pc_init_isa() Date: Thu, 10 Jul 2025 09:52:20 +0100 Message-ID: <20250710085308.420774-6-mark.caveayland@nutanix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250710085308.420774-1-mark.caveayland@nutanix.com> References: <20250710085308.420774-1-mark.caveayland@nutanix.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AM9P192CA0002.EURP192.PROD.OUTLOOK.COM (2603:10a6:20b:21d::7) To PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR02MB7159:EE_|CYXPR02MB10266:EE_ X-MS-Office365-Filtering-Correlation-Id: 03276762-e47c-4fb5-41b4-08ddbf8f3ed8 x-proofpoint-crosstenant: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|366016|376014|1800799024|10070799003; X-Microsoft-Antispam-Message-Info: =?utf-8?B?RDlQSkcyaWYwUGQrbGZnU0VNU3NQWVJaNFdidE13Z0FSdmV6cjdzZ2JEeTUz?= =?utf-8?B?cm1ud1Y2RDM1QnIxczRObDNSR0YxSU5oZ3Y0Rys3eW9tcXRhaEZMeHdmbE1G?= =?utf-8?B?L0g0NThIUnZhUjBCN2tOZkthRHFUQkdQY2VpcExYbHljMlVHRTZQV0NrRHd1?= =?utf-8?B?ODBaM2pvZjNpVHBYNkl6OThLSE13aXNwakhySy9WVk0wYTN5TXVNbTA3aVR0?= =?utf-8?B?ZVI1ZVNmRWxNa3c5RmY0d1NDUzhlTzNBdU0weWJ3U0NyT01nK3JDU1g5bFZu?= =?utf-8?B?M0NJb0twWUpGZ1ljMnltcExMLzhRT0t4K0RtbS94YlJoMnAxbjRlTkVuOWxF?= =?utf-8?B?b3dOZ0wrMVBGYmxxZEUwU0xldjVnSytZTUo2clJpbnN4OUFOdGRkV2x5Sm56?= =?utf-8?B?cTd4LzNIWGkxemp6cmE0eUdya2IrTXlyUTBEQmg3dDhyV3kyaHBlZ0dtajhh?= =?utf-8?B?blJGL1BkR1MvNlhralJlNzhGNktxSmFqTXZtNHZoZ3RBb2hlMldDWUdLYW92?= =?utf-8?B?ZWU0WUs2UlZVc3VjbUk3K1R5MWNoL0pwVjZSUG02M0VFdXNhYmZTcUp5THNO?= =?utf-8?B?bnJVV1lQam5FSUpoOWlpUjV2NUZDU2FQcnJJOW5RcEsvbjN6MGoybjlOVG93?= =?utf-8?B?Z1IvQWxBNGJwSzF1cTNBZTN3amh2Vk1DUkkybEF5b3R1VWVrWTZBaVluNHNt?= =?utf-8?B?UkNxNGlMWm5ybDVjZllhM3J2OTFkamhPWjdQRWFZTmpFV3JUTU5wSzVzQ0t4?= =?utf-8?B?MlJIOFlFdnZtWk0wMnV2V0RaVlh3cVdwcHFqNFdlVDFMTS8yQVgxM0lBU3h3?= =?utf-8?B?OFVLakh5eW9KSlpKWFlWd0s1NHB6dVBXUW5OZy9WY3l0eUFRMmU3M2JKNmFh?= =?utf-8?B?TG1GRkUvV3Iwa2lleDM0QjdDcVkxalY2a0o0QmhUR1RUUCtrUTUzWXZTekNP?= =?utf-8?B?WGcrUGJkbzJzcWt0REZqenJRdURGZDBNcHZwZ2lKZGxlRXpTMlNLNGQxSlVT?= =?utf-8?B?NXdWTUg5WmUwaUxvQVRzNHNOa3hRRTNhQXF4NVJpTEpObzZLVTAzWnNhWUZu?= =?utf-8?B?TUZTTGRiMDVlWFcwNWNkVmRTcS9WaHZVY24vSDQ1ZkFRUnVwWlpwZWZHUlFE?= =?utf-8?B?WHcvUGt5R0tOODlIYS9ENC9BWTdqdGp5Z0lubzRtcmRVMGkveittSWc1b2pn?= =?utf-8?B?SXJQQlY1ODJmckJRR1hJYWJEN1ptMUdRM2NzY2FsS1daMUhPNStmbDZtR0tI?= =?utf-8?B?bkhqVGJ2cWpUSk9zTU1IRmpadndFL0NYY05NUVVWb1h4bnVCL1E1Snp4L0Rt?= =?utf-8?B?V3BVMGtvd3NtNk1iU0tlNEMrQzJiYzFWektkUVZNbDZhTzBSZ1RybEpLd3l2?= =?utf-8?B?MmkzK3BoaklYMytLUE1xbmhJV0hJOEcrYVJCbFlDSTZKYXAzMXMxNnZkZFpv?= =?utf-8?B?eTkrZjk4ZEhLanJqcSsrdGNFdThMSisvMVduanhVYzVIb3lCVG5lMklkSWVs?= =?utf-8?B?RGdYRUdwMCtGQXZTRXVjWGNMVzhZSjJhMmJFd0FDUFlIcDBTcjYyd1NQRzZm?= =?utf-8?B?aVFqNXAvQmRIblFoUFgza09ZaFhHelJBMXlhVkxkYVhpRDB1V2RVS2tDQWZu?= =?utf-8?B?RVBMTkQ1YUdraGxyVSszbWI3VmpKOW5UNFNTK1hvNVZlRjBNNDU4dlcyWlVo?= =?utf-8?B?b043bXFDWFhlOEdiaVNCTVZVVzVIdkNPckxMSDZmQnhBMDhqb2ptTVJkZXhO?= =?utf-8?B?cVFrTGM2NTh6cVpwMTNQdmNFM21kYzZQY2JJQSt6bUJVT0JpOWFaVVQ3Y1BQ?= =?utf-8?B?eURFbi84a1ZSQmlEQVZkaWx0b0NTd0laZU5Va0xBQUk4ak01dWp4QUVjVXNF?= =?utf-8?B?N3hVODl5V0RKWlZCT1BOK1hhc21xSkE5dnZncDVVYkNLTDFaV1pVS3YxWnho?= =?utf-8?Q?UNFooMm28nY=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR02MB7159.namprd02.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(376014)(1800799024)(10070799003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?b3ZQYThxYWdWVXBvRXlGc2Y3bFhNZkpDdFJBV3NKUDVQZmo0bXFqaHM1dk1y?= =?utf-8?B?NEk4ZzZ1eG5rUWd5eG50cXhKSDlxTEs1WWJVWllFamRMUmtTVEZqdXlxdDRG?= =?utf-8?B?L3ZRTDFDZDFBang0SUF0UEt5UlVyZEYrM0M4WUQwZDVBVSthVmN1Sko1Y1Jm?= =?utf-8?B?Umo5V0U0Y3FBSkpheUEwVDFtZUFodFRwK2N1QlVCYVF1OGxmR2pYRjU2V0NU?= =?utf-8?B?Ni9IQkh1TGNFOHlGUUZZS1JpbWNvK2Z5c25ZR290M09zZ3Jmb0xGRXVqR010?= =?utf-8?B?Rm8vSU5FazJ4c0xsWEY3YWp1WEJOSFV1NnpnOFc1ZVZxc0kvaWEwb1R0TGtt?= =?utf-8?B?Rk1oN1MyUTNweGxHKzc4QzR5MHdqV2R2cVQ1eFJqOWtaNWM2bWdKZHlhcjQw?= =?utf-8?B?YlpFOEFkSGN1Z2pBVldFNXNnMEJvNGIwcmk1OE9STzNOcGx2RjF5Ynh3enZo?= =?utf-8?B?eEI3SDB6TmdkY1VFeldtQjFkSDRDU3JVbGJmdy9kL2wxZU9TYVAyUmtBV2dn?= =?utf-8?B?cExvN2Z2Nkc2azRwK1U1dEV3WG1FbmlDTjhacEZDZ25EUWxOUVo0UVZ0a3Mw?= =?utf-8?B?WGRaVFlpbENNaFVRTlFKVng0Z1p0SlBHQXBDOTVQZU1IQmtyd0NZNEtUYW1S?= =?utf-8?B?MTQ0d3VjZUtROFhCY2Y0MFYraS9ZYjlsRlUyRTFxdmlLcG9OZHdrZXdqUUU4?= =?utf-8?B?S2Q0UkVUM0FuR3dRMFVVVnd0bFY2VzZQNi9XL2VkNmpiYlhyVEc2a2t3WlFP?= =?utf-8?B?bjdFZEZUZ01yU2llaWdIMzYrUFdHZ01sUDJmN3RCbGpLSEdqeTI4aEorRlg2?= =?utf-8?B?UVMvSExtZEE0cEZQNGlHU0J1NG5RRVZZUDdwWlppM2NKQ2Q4a3Jxby9nMFp1?= =?utf-8?B?UFFLb0p2UzRVVVo3QXlxYW5KbDltdFhHZ0xEaGordFgrUEhzV3pnbHU3ajhZ?= =?utf-8?B?OG1IVmJ6c3RjQzNuRmt2a0p1TlNobHA2NFRtSlBBN3d1YWk5Y081NXVoWVFs?= =?utf-8?B?QWJNS1Q5dnc0dUE3bmRxSVY1VXJSenRDT28rY0FTK0JRNmhUYXVsMDBzRGNj?= =?utf-8?B?b3BFY0U1Qm5RVUQvQ2prM3hwWUZ2aFc4Rm1mejdSUWg2NVJVOWVWT3F6V01D?= =?utf-8?B?MGMrSTFkOERHMjBneXBGa3c2cDYwZ3Fja3FMTFhrRThCUWE2T0hoYTFpMHhK?= =?utf-8?B?N3B3enR2SVQwMDhLbGNEZnJQUkVMc0JyM2k3T3RQYzQ2UDNVaG5uWkVKTG5L?= =?utf-8?B?SUJLR2ZXTXFTWXRtVDJFK2Examg0aTZVbzAzZVpINTZyU1VRSmkwVWZXaHQr?= =?utf-8?B?eU94WlFsc1loeUdyaDlIY0pyMmZxOTN2MmdaQmhjdGVTVkdsRHNLekZPTTJ0?= =?utf-8?B?TmJuUUp0U0lFelltUW5yRDlSdFh6dHMrOEJObFV5Ny9vemY4QWQwU2ZoNW92?= =?utf-8?B?ZEJiRXhZdE5FMUsvc0RGWDZGbVdXVFlvVlJ5OWtZYzJvd1RJQ1A0YzhBbk93?= =?utf-8?B?KysrQ3FQa0dVTEMxSnptQ3RyM0YyN3NyMXVrallOaDB4QVlqVjhnaWthQmkv?= =?utf-8?B?ZHZ4SnBBSzRCT2VIeHd3RUxBbE1iTDRESXI4UzI4VmlTblRqOTYySnpISlU1?= =?utf-8?B?aXNFcG5LUjhydDA0azBCUnBnckVwN0VmY2FldkI5SHRZNjBkaklaQ21ZQ0hy?= =?utf-8?B?d0gyVTFldmVXelJpYTNobFNseFJaT01kMkRVUHU3RU9YTW9vcXFROUFLLzRG?= =?utf-8?B?NWxabTR4ckh0NUY2OGtQQ254Q2oyMDdIcXRWdmlac0xaQ2toNHNzVnU2eTgv?= =?utf-8?B?NTVERk5zWS9ib2s2clR1VGw1bTZBWW50cE01T3lMUEpZSGFWRXVXZVRLR1dh?= =?utf-8?B?eWFrN2tLcDZLVGJQY0FRNkRicGFnTHhPU3ZuMTQrSm1YSHBYdjh5Z3dwVnZN?= =?utf-8?B?dHBSN2RwVHdFbmpic1pXcTJiVC8xcERmU2RJa1hlOHhJcVhKLzEyTmJJUzdw?= =?utf-8?B?SURqTHgzaEMvNGhhSGNGT0xjNUFJUHRPbkFhM2RIaml0WXQwaWtacitJWnc3?= =?utf-8?B?eWZHYmJCK1VBa0dPSGx1Z0R3V254VHBIQWpHWGZqaFBKTXZkc2hCUkFIaGV0?= =?utf-8?B?dTluTy8wOGdmU3g1dTJESXlPSVVnOFBpa3pEdTFvOUxSRXFTT1NqaVlVZWhE?= =?utf-8?B?SmxwOFhyb0YwOSt2ME5IRzhKOEtxb1dkR0p4aDNjNHFZS2wyMHRueG1GdjZR?= =?utf-8?B?K1Qxc0J0WVBoMEMyRnpRcFBFbGR3PT0=?= X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 03276762-e47c-4fb5-41b4-08ddbf8f3ed8 X-MS-Exchange-CrossTenant-AuthSource: PH0PR02MB7159.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jul 2025 08:53:31.2786 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ZmdTb8SePRkpqZGmYDl6nShA0T9mlUb1Cg1iRFUi4g1kfcdinJUGLxYyvB2zWOvorBTx8kfwa+DnD7ZDcCGJtdpyf8xn456frlpf2yV1CO4= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CYXPR02MB10266 X-Proofpoint-ORIG-GUID: HsDdIiakmLmxeaDLSiYWLTLP5hY12NAh X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNzEwMDA3NSBTYWx0ZWRfX2XJowiC9gm19 zGCla8W1tRNirtCtmfP8+DgRVOFSFaLd0gmRv77jEh6trCJTYheaeVr2Iej5OdQ3y2d/sKteS5R P6sz+5FO1+I+QnQIti6z6zpTre3UnefJlt6vbNrAYUmHUsHBitYcupB6t8yVM1dIrFtmQ2z7Qxa T/FXf+f2CWu9+gEyanoKPd86JXi5ghpiI1UDL7PFRO6vmHfpUyzqNOOUsIK/9Pcq+2DPc4JmQvC tj3Hd6HH73E6L9JFHVj0jQOvkvZCw59V7rAmUURx6DafVjynwKmfRuOnMcE1rOdK3vATIBs5cvQ IARz40e0tzwz7Pn+x3uIUng+eYR2eV9qDXqWbrVFkLKKWhPNEXJE7t9YSf/w3H7IyPlyOWOvsRP awyK2H+nJQEGKwbFV38JXHOncXzg9BY26o6ZWFnQYpsM+oZHHkB99xBkdk7/PfmOs7gDNQPl X-Authority-Analysis: v=2.4 cv=KKZaDEFo c=1 sm=1 tr=0 ts=686f7f8d cx=c_pps a=vI7cwuzHBtkooc9oao+6fQ==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Wb1JkmetP80A:10 a=0kUYKlekyDsA:10 a=64Cc0HZtAAAA:8 a=KKAkSRfTAAAA:8 a=F9lpminiuFHZMRiaUDYA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-GUID: HsDdIiakmLmxeaDLSiYWLTLP5hY12NAh X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.7,FMLib:17.12.80.40 definitions=2025-07-10_01,2025-07-09_01,2025-03-28_01 X-Proofpoint-Spam-Reason: safe Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=148.163.151.68; envelope-from=mark.caveayland@nutanix.com; helo=mx0a-002c1b01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @nutanix.com) X-ZM-MESSAGEID: 1752137815389116600 These are based upon the PIIX4 PCI chipset and so can never be used on an i= sapc machine. Signed-off-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- hw/i386/pc_piix.c | 19 ------------------- 1 file changed, 19 deletions(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index 548e81cf1b..cf451d1cb5 100644 --- a/hw/i386/pc_piix.c +++ b/hw/i386/pc_piix.c @@ -423,8 +423,6 @@ static void pc_init_isa(MachineState *machine) MemoryRegion *system_memory =3D get_system_memory(); MemoryRegion *system_io =3D get_system_io(); ISABus *isa_bus; - Object *piix4_pm =3D NULL; - qemu_irq smi_irq; GSIState *gsi_state; MemoryRegion *ram_memory; MemoryRegion *rom_memory =3D system_memory; @@ -578,23 +576,6 @@ static void pc_init_isa(MachineState *machine) } #endif =20 - if (piix4_pm) { - smi_irq =3D qemu_allocate_irq(pc_acpi_smi_interrupt, first_cpu, 0); - - qdev_connect_gpio_out_named(DEVICE(piix4_pm), "smi-irq", 0, smi_ir= q); - pcms->smbus =3D I2C_BUS(qdev_get_child_bus(DEVICE(piix4_pm), "i2c"= )); - /* TODO: Populate SPD eeprom data. */ - smbus_eeprom_init(pcms->smbus, 8, NULL, 0); - - object_property_add_link(OBJECT(machine), PC_MACHINE_ACPI_DEVICE_P= ROP, - TYPE_HOTPLUG_HANDLER, - (Object **)&x86ms->acpi_dev, - object_property_allow_set_link, - OBJ_PROP_LINK_STRONG); - object_property_set_link(OBJECT(machine), PC_MACHINE_ACPI_DEVICE_P= ROP, - piix4_pm, &error_abort); - } - if (machine->nvdimms_state->is_enabled) { nvdimm_init_acpi_state(machine->nvdimms_state, system_io, x86_nvdimm_acpi_dsmio, --=20 2.43.0 From nobody Sat Nov 15 10:54:05 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass(p=none dis=none) header.from=nutanix.com ARC-Seal: i=2; a=rsa-sha256; t=1752137768; cv=pass; d=zohomail.com; s=zohoarc; b=mVjlgQZ3GcXVLluBvSFG7fWlDIcPMHnBI8Zby6tVVIn3bEio1TAt/3i9mUhcrpKca4L21aBVxiCh25v1lWLE8ce+hWkO2ktom27j/EP6OW+W8MBavhRRm0zG7fbIrVNpsMN5GwBYT3vCW4WVz0pPIDugEpSF+R9jaPGg7BHSna0= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1752137768; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=kcHZDj46NFWtrB++QFLSi7p9tdLrMqQM+6qLzGoixZw=; b=JnTaL6CfV4f5lgdDyW3zGy3wuaQOCOI6nha3VWfrQ5gWdebOmicGN32gX0S9nvuFlgnnrbCQcq/DsciIMpj9qFyVKJTVSjwyEv9Zeio8H+0PXCrwlsFrJ3OgYaE13Kb2y0YFxhYJlOQEsECohul931DMAawpWGEngzCm8Y96JSM= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1752137768113537.533020481551; Thu, 10 Jul 2025 01:56:08 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uZn2R-0007wo-7G; Thu, 10 Jul 2025 04:53:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uZn2I-0007n0-CS for qemu-devel@nongnu.org; Thu, 10 Jul 2025 04:53:46 -0400 Received: from mx0a-002c1b01.pphosted.com ([148.163.151.68]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uZn2C-0003XL-39 for qemu-devel@nongnu.org; Thu, 10 Jul 2025 04:53:45 -0400 Received: from pps.filterd (m0127840.ppops.net [127.0.0.1]) by mx0a-002c1b01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 569KL7Mk029252; Thu, 10 Jul 2025 01:53:37 -0700 Received: from nam11-bn8-obe.outbound.protection.outlook.com (mail-bn8nam11on2136.outbound.protection.outlook.com [40.107.236.136]) by mx0a-002c1b01.pphosted.com (PPS) with ESMTPS id 47q0cvn284-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 10 Jul 2025 01:53:36 -0700 (PDT) Received: from PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) by CYXPR02MB10266.namprd02.prod.outlook.com (2603:10b6:930:e8::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8901.28; Thu, 10 Jul 2025 08:53:35 +0000 Received: from PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88]) by PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88%5]) with mapi id 15.20.8901.028; Thu, 10 Jul 2025 08:53:35 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint20171006; bh=kcHZDj46NFWtrB++QFLSi7p9tdLrMqQM+6qLzGoix Zw=; b=CTGS7jySJ2VcRTrmSIAsCgE5LDHU5F+rNppz02lXJ7iDepLFaoC1VLLxs nq+m87d5AMkNCO+e+c2hMDCnJQpvA/GXAsMPalMISq+V8QKz0S9zEqRax4KENz9K iAxElHY5HT4H69bH5v/nZcnLadxo2y+uLB5KrYmTz7FlQe6usqgTfPaQbVUB39aC pXrOQQiPn1xMMmtmB8zfXdZ6KLvDkj9NijmP5K3ifAs4cE3l/sznWa03Mvneji5y PYMTksbVrNTLkSV3vBGWmoMhq8PQ3K5b4h3I0XZ5kN6pKyqfD0RERxl24LYxIAMT 2ypEQXEMqC41tQY8epivF65q032Ng== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=aJ7VyPlaHqynrHQOZPYSyvI3NpIYkc0nQB7WMYg/oF6UXuL78RqMXPtPlr2QHikUlJqDKvarNAT7J6+SkGDr3u6z5ic007JIEYtoGisP+bG86+pgKEX8EWohFDy+vTQVVH4VX+58boiworlR20AYZHtPu7imjT3j2bQu748SRYRvo/C21qxmBNxh5fty9N1b8g9a4V2s8bqKo+MPji127Dl9gMovgKteRibemDzsOF3ME/TjeRyc3mdTrl2CIc8OMe+YM4SflHrQ9jyHp5J7IleD8l4LlPUwlk1SOheZOkJjTe6R/5KVNx/mCLD+bJ8ElouPtw5BAax4gFGdLVE3Ww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kcHZDj46NFWtrB++QFLSi7p9tdLrMqQM+6qLzGoixZw=; b=bmG/0nuXD2+pjt6lD3mfHdu+nNGu+nelHFROFzQoYNFmcurlc1I6lYyeosKvZ2H5XGhBgaTpY9UuWLA85Ww+ZOQn/+54fXZD9TLov8HYbv257l5ucUpgDwx0dWykcZyS+JUmWekTK/VQLPQrhsmrDqkiDMRGTAV5ASRYK5OYXD1nMEr8fYBmWHFdhDdR8D7+RHbiDmeQYiITMFI7iJPipnMGMZbv0cW04cSkb0efjNbtYwnbThgAdZ+UaTQZ6wNA/bm5UDeNiIwYFd065hOGRt9SQGYLzUk1ivNhsgrsX3+jIoSHFREQzehMTkPGqmlOeb1W60tzvGhvcVnwCHC7Kw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kcHZDj46NFWtrB++QFLSi7p9tdLrMqQM+6qLzGoixZw=; b=dtriEtFwbrzSWtkUVPGgjEvn6Pm1RmOj7zNN5YkeKDpa4EZZ2AqDp7RPfMcU2cY55XSVaENVhV+EbGqyeGbmRHrUOJ5VlPTdCpgsP/43m1N202fC6ZsLGr7uPIfkSkkImbxfyyCLC+AjiOPvoWOC9iEnvYUO/rG4yQ0Ero2dn0flax5aVN3y68CaoLw4gr/8L8EgfSjTfhlTfecs/fhn/xPcD1Jp6bwjJoLyFm+ud8DvrpGUbxOPoe3FCfFZo7V6R7cKcLDYTl/K6wGEstLgXaOoBxv5F7aOBjPYwmkupITFwGJh86r9YUNChUPfYqsX7IjboY65hBDWM6lIWyLNbQ== From: Mark Cave-Ayland To: pbonzini@redhat.com, mst@redhat.com, marcel.apfelbaum@gmail.com, eduardo@habkost.net, imammedo@redhat.com, qemu-devel@nongnu.org Subject: [PATCH v4 06/18] hw/i386/pc_piix.c: remove SGX initialisation from pc_init_isa() Date: Thu, 10 Jul 2025 09:52:21 +0100 Message-ID: <20250710085308.420774-7-mark.caveayland@nutanix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250710085308.420774-1-mark.caveayland@nutanix.com> References: <20250710085308.420774-1-mark.caveayland@nutanix.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AM9P192CA0023.EURP192.PROD.OUTLOOK.COM (2603:10a6:20b:21d::28) To PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR02MB7159:EE_|CYXPR02MB10266:EE_ X-MS-Office365-Filtering-Correlation-Id: 65adc7ba-f2fe-45bb-afc2-08ddbf8f4127 x-proofpoint-crosstenant: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|366016|376014|1800799024|10070799003; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?HDjfStsYsCfucBW31qh12zvSBYA5OEz6FVuDHKowI8blxTDrAxu+I2nyD/GC?= =?us-ascii?Q?Onsz4NfcPVOWvcylNVIKm8W9K/1FdHuKUbBIQ464wWS57YzrXlvk9qd/eL7m?= =?us-ascii?Q?CiMFIqmXnuQugWHVbgwX3qmkU3Vq5fxiWmtFWsCCXKHx6pXo4nT8VqpUL5ox?= =?us-ascii?Q?eGMDt1glRPeuSPHqmS4m/PFu1r2chcNs78gry+Kbb+6ibrgR9TZyVTnXxq6f?= =?us-ascii?Q?zoGE3P5vSgcIn49JHEFScc/1gfa3X7O+qn6SCPFuaqW9uNtKyDGzZJ8JYrhV?= =?us-ascii?Q?JTw1LoPuo7ZzzKpIVF/W8jwpcepFwYae323j21aF/zxkz+1PW/REGbSz/2i1?= =?us-ascii?Q?+r2aSF305D9RzVqhjke9Nk1fTWCfBgBFrjBrSk822t3tFqfCw7on8n8S9BiO?= =?us-ascii?Q?tSSYlwbXLs9IdevkHyoliVqX6ex1/byAUELgNBvTeV6SoO0dagB9GmRYZtjW?= =?us-ascii?Q?lt5YPEQCaQ73Y0QVNdUH5GtcsbppdJlixTiFGSd4jKREy4yke7eNrI1r5pqt?= =?us-ascii?Q?Q3fVY6uvo1LwOw7HUpSxXgaIC9WHqNhxqXh6Z1TCUtx1CL/GGTROz//5hcbU?= =?us-ascii?Q?W/CLsdBCQZ33T5U6zJANFUgBfXRTFZ68iepNBgPg87Mbk++BxlhCC8Aph4f+?= =?us-ascii?Q?PBT12/5Eq10lmMnhEbKNtOleRIjB4R5z5lsdbqIEnJ8foSStClggPIXacNqP?= =?us-ascii?Q?T1KSFJRS/hwYvwpXQaNDGrG/Ed1YaesqMe9tpvTAJ6z/QwZdqt1D+CiV7uq9?= =?us-ascii?Q?ujxFRDEmdJMTl2yHtn5CO6MascxdPFpaB9lW+FA1R3cMoJEg7V8vbM8THerX?= =?us-ascii?Q?ZtQt0GpHR1WYsVu+sv7Hc9lCQmDqsZ45/pmWT0J+gJS3a4Bfhb4kuVfj9oUP?= =?us-ascii?Q?6dgBU7WnVXzekd9yChRW4ep1Egt/QlrGNnm0ai1AJkH0WHjhwGYpmJcaOAoY?= =?us-ascii?Q?mQDSt/tx2LEq5itWpjpn5oGbYqU2UbdQe5RFZYrU+o1cG6piZrp/Mn9fPOXO?= =?us-ascii?Q?3xhQrPmlayMZV6ZJefqPnHWKvyttIxdb09VvxGAUNGou8yT03cKQTEIT+bKf?= =?us-ascii?Q?woSDhcwxrIP6BRC4qozyykdzMDdaiDcGAyXtfYUlbfPEJ3BbfuZdb2foICNQ?= =?us-ascii?Q?cOhQ9RnEGMru5zURNBx1df9iJLJ8Abn48sNey0Q2sWn+RrJuShZO3mS2JPKl?= =?us-ascii?Q?Pz1SUj8dJrxwdPDFxUA8OEUwULKIVYjNuvW3xdFb5igbArLn7EofG3llCw0w?= =?us-ascii?Q?C3EqxZpBdmYMy4mqLQi3WFcySRvTJcPJ0ymYIOsOeTF4YliOPPMuwsNFfxFF?= =?us-ascii?Q?XeibqjITb0i2oIWhzp+502t4oV87lrumVrlQfxL9ESwHjR3wAJtA8tp6i8Ea?= =?us-ascii?Q?ZH09K2l6LknQRjZoE5crQTAMlpnSrEIn4mG3/HLjGOzpcISsLA=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR02MB7159.namprd02.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(376014)(1800799024)(10070799003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?BKCvcnD8qdoM4Nfx5FDaazJNDln8FJNIUTlDm9RZpbTFrwRJaLDIpkFj79lv?= =?us-ascii?Q?TpifcHceuZO1H3Ka7Ul9YZFdH4lj4DB6lItX3v79pifdKDD62nWFKuaeolNS?= =?us-ascii?Q?sMBPqynGRpDei+U4zp39uom0w9mNgQnoTUav0pNV/gvXxB5zkIJxvTZw+DwV?= =?us-ascii?Q?ch+IM/dx3oa4rgcnmTNNpejMCduJulDOtqPKvlK56NCAyAyNZZLF8Z9qaKl/?= =?us-ascii?Q?eaFwvD3+LLf8CBmOZZyiDOVBXZrDFzJu27m1Qplcr10tS1qCGJyRNqfWy+nT?= =?us-ascii?Q?gjInoZsH76QnlKlyKotQo37QFZ+O1HFjG5Oj1p4pv9eotdXrGDi6DH7/RrWl?= =?us-ascii?Q?8tR5MsnsZ++KMYWd/Dv3jM8j2hG1JGQdNMiNaSdIBJruIKmV+WHqkdSTf2li?= =?us-ascii?Q?6/bNkS56ic6+nGNUTCk3rrmqplUSaAqCrlGMq7uALD7T2BRYhiIpRSETplDl?= =?us-ascii?Q?b9rPwDIU93/JV3gnUO8IjxmYhsB+FGy7mk3kG+RiGAmFBkvEO/HAFkJD1QQG?= =?us-ascii?Q?9D9YYbhswePx160nsndKbMswctg1p+SssOxURiV/LsCimiQH6wj2Hb4yFX7p?= =?us-ascii?Q?xkYiMJggGCVQRgGmt1ZD+EqcNWPvZanQoH9So16RR07rdDbMnBgh4NUf5hr2?= =?us-ascii?Q?RyKOxMJn3QhfFZ8a0flKqL2bN0fwwpb0h0GYsQaNNEwN86XlMyfmJkklO6aM?= =?us-ascii?Q?NiZBDvuEnON5d+4inMQflpqQPMbBns8P6TPvOVQAb0JMB+lAifT4/ctFwSJn?= =?us-ascii?Q?+kdctCLBPh/rTDZMlS33vECpDo7eNB/yW4pjOGBJzbvKpJ4KOvk0humIK6fg?= =?us-ascii?Q?S7KQaQTQHOVMWPo8L25bcTwNfeEQNfGcgDgN+2CRY04VuXL2POqAqt3pcPa7?= =?us-ascii?Q?t5SJKA7HREYTML6zxMJ3fprG0wlXWLNU+4UBa7iesCjQVrPf0EQPeIqTm4q3?= =?us-ascii?Q?L5vDPEsQpAT4Gj4Ur8M1tZS3isiNej+IkbFmp2Lk5/Axyc3BOm0sD9JWqLlD?= =?us-ascii?Q?eo+6Fwcy+LbPXEQis+6UWM2H2f5QP+dStp4ug28Yv+g4H0F0uZWXw2CGWlot?= =?us-ascii?Q?pmFZU7DflrdskoTJfZ6F7s2aSkzMtJlC1HpFPboRDOsW9EdnKobbMyBrMRBn?= =?us-ascii?Q?2zzDr8RoonSaAfJDnbznMAfmUQyoN+CQN8AgtLCyLLiUEIy4bhsKI8/A8NrM?= =?us-ascii?Q?RPFOBsxRQ0jo4iyZUx0wo94M+KLWtCwroC3g/pJ5gW7MlbxrmWQ00N3QUvED?= =?us-ascii?Q?uqGhyng/1P5kOBsvSpztBiYC7t4gx+e80QRP4r/HNPEem/n2F7qepA3hnO10?= =?us-ascii?Q?3kj6zp0xDe0e6jARRjomCbfZLRi09wqMnrVhflUjbcuicVMUXs8bn0uzKtIz?= =?us-ascii?Q?+4SiR4gqxu5VzeoWipbbbTtZyK7Sh/dO9SKzxazmrb0BFXe0BKUIheHL/vG6?= =?us-ascii?Q?/Tg+iAKL/aeHR6p17I004Fkj4OGBa211DblCzpT5EA29ez506GAGQUZhG1Bh?= =?us-ascii?Q?zJI+EE5dhoGoey10/ocL550XP+i2qqc7wrJRxHQXVUp//c/THygMhdakN0RB?= =?us-ascii?Q?10NYbsrYtWZmIFJSJ4aWYd11RW9gerWvMUM56X8AcLoY1MKjK/EFUsETwBLJ?= =?us-ascii?Q?CoxgVo5jmI66uV5jMROzM9EaU9oltW1Jk4kLDDq/8d6EQsfOnxbuobgew5L1?= =?us-ascii?Q?ycMvKg=3D=3D?= X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 65adc7ba-f2fe-45bb-afc2-08ddbf8f4127 X-MS-Exchange-CrossTenant-AuthSource: PH0PR02MB7159.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jul 2025 08:53:35.1710 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 3SEkVJIfuoSh/Vt+MRpQgDgOj3SoZj0tBKZebEAGHmwzteieRyz/dPdywW2oPKiAG9kk6Pf8O7QHMXfXhEEYxuRy74Y3D8dyarRSbeogyTM= X-MS-Exchange-Transport-CrossTenantHeadersStamped: CYXPR02MB10266 X-Proofpoint-ORIG-GUID: T3iWIxdhfZs7nYUuPseIrmRCCr-wc7Uo X-Authority-Analysis: v=2.4 cv=ccXSrmDM c=1 sm=1 tr=0 ts=686f7f90 cx=c_pps a=DHuqkZ/VLdBH1VweqxBGCQ==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=xqWC_Br6kY4A:10 a=Wb1JkmetP80A:10 a=0kUYKlekyDsA:10 a=64Cc0HZtAAAA:8 a=yiTRickECGlooSfTVXsA:9 X-Proofpoint-GUID: T3iWIxdhfZs7nYUuPseIrmRCCr-wc7Uo X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNzEwMDA3NSBTYWx0ZWRfX1rKWtIQN8oyv F5+1EliCm5gXvch7dCCxPHSpIUTA/JIB2hoUUpOkqwKfaV5Wg/F/T+iJJofzQKlptCXxQK/e+9h aP4yfQjKmA/x+mNyMjnMyIvAUZSpSGNbO7UHdNO0ekdrDH6O0vzvXzQdVqhMrpeXoJtCCLwo37O I5WYw0djlWrrHW5lSVlIPGmFi22vd+qdo486vK9WqX6WyP6sGsZbu4KLUM7iataUBhhepgcJT1q eqI2zFkN8Aylf4j26CjIedYGRYUhCrHsrEBPHMIU1qYap2+HFhaQiLljrbjiZz8LRwRFmOe3Nun TpOkSx7t/XQjvOrkrexBJNb0P1ivsvQVxfChqsYQ1kwbZmvvzMsnHBzsJlItFrhQiAtXzP8WBfE d3LcH71jq6IYEYvQ2Hajw85ACkHQ32HeJV98s1DtfCWkP7meMESCwFBtegQqR2aJLCNxSMlk X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.7,FMLib:17.12.80.40 definitions=2025-07-10_01,2025-07-09_01,2025-03-28_01 X-Proofpoint-Spam-Reason: safe Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=148.163.151.68; envelope-from=mark.caveayland@nutanix.com; helo=mx0a-002c1b01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, T_SPF_TEMPERROR=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @nutanix.com) X-ZM-MESSAGEID: 1752137769010116600 Content-Type: text/plain; charset="utf-8" The Intel SGX instructions only exist on recent CPUs and so would never be = available on a CPU from the pre-PCI era. Signed-off-by: Mark Cave-Ayland --- hw/i386/pc_piix.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index cf451d1cb5..cbe4b33ba4 100644 --- a/hw/i386/pc_piix.c +++ b/hw/i386/pc_piix.c @@ -491,8 +491,6 @@ static void pc_init_isa(MachineState *machine) } } =20 - pc_machine_init_sgx_epc(pcms); - /* * There is a small chance that someone unintentionally passes "-cpu m= ax" * for the isapc machine, which will provide a much more modern 32-bit --=20 2.43.0 From nobody Sat Nov 15 10:54:05 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass(p=none dis=none) header.from=nutanix.com ARC-Seal: i=2; a=rsa-sha256; t=1752137733; cv=pass; d=zohomail.com; s=zohoarc; b=Mud3xv28V/Mt4DF6rx9kO/X0Bo0jA4rbGItOj8e8/zGXfV810oKqRAyPaNh34T3ZfhEclInhq0z85XI3mX+8p5r8RoeXMEkH4lvX0ANeBkvezYIE29VP2L4GUbVQ7E1w8HNUU3uwG1kJRrxi62IbbDpG6qdPkdOiiWWnHwQlEik= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1752137733; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=UuxmDkHlGK2qioIZUCl1D2cQpX9TzTmymVY0PE7L8bA=; b=MtsqW6k5xO4hZ4MPFqyxMaJlnOKzaY6Buf3y+9lfwjSSdfxcyM21K03jhDYnCXKCaKH/HNNGKRgk5P98EVs0lIZIMSRoW6EA2+BPhVHTtFrB1iqOTgLhsIL+0H1bA3tCTYfizuOm5DhMCuk0sWh3K0/yK1SvFK+6P57+n7ait+4= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 175213773348968.43276809112137; Thu, 10 Jul 2025 01:55:33 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uZn2Q-0007ue-0z; Thu, 10 Jul 2025 04:53:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uZn2J-0007na-BK for qemu-devel@nongnu.org; Thu, 10 Jul 2025 04:53:50 -0400 Received: from mx0a-002c1b01.pphosted.com ([148.163.151.68]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uZn2G-0003Xj-RZ for qemu-devel@nongnu.org; Thu, 10 Jul 2025 04:53:46 -0400 Received: from pps.filterd (m0127838.ppops.net [127.0.0.1]) by mx0a-002c1b01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 56A2vb2X006138; Thu, 10 Jul 2025 01:53:41 -0700 Received: from cy4pr05cu001.outbound.protection.outlook.com (mail-westcentralusazon11020093.outbound.protection.outlook.com [40.93.198.93]) by mx0a-002c1b01.pphosted.com (PPS) with ESMTPS id 47q3m150kn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 10 Jul 2025 01:53:41 -0700 (PDT) Received: from PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) by BN0PR02MB8048.namprd02.prod.outlook.com (2603:10b6:408:16a::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8901.29; Thu, 10 Jul 2025 08:53:38 +0000 Received: from PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88]) by PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88%5]) with mapi id 15.20.8901.028; Thu, 10 Jul 2025 08:53:38 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint20171006; bh=UuxmDkHlGK2qioIZUCl1D2cQpX9TzTmymVY0PE7L8 bA=; b=I9obIExIwSgMvxZSAkSxZQTN0Z7dwzsEAQfVOHlaJBCaf93WeC/DyH5VA vDLg3iaz5X7Jc8CyEq1Xhz4JEzPQHyu8c3n5meh1vnLjgpccKJQ6F1S7H0/irtOQ ExbN8mcTamJI5ZOf9/GHYAjjRSkpGiPEdkT3KYwrOO+d4ghOsSisiTmE7/csHZQe E8L/gra4MEa2xVH8O/nLikDkkUPWTP8SXtWZGrWlfshfhbzrfPU235ERTeMk3Cpj 3Mkp+gsND/bMwGHTPjAsfLk5SPGT4u3/bdcpv2uAu6qj3FD/fjxxSkhw2bT0R5wH YJtgh9CEJtiLTq5n0Rt/pRVv+Kv/w== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=AHZMkFS+0Z6hw08rFrSrJpNUT6SbQDBC8q6obEnjw9GpKsNOcmSYz8aWYHTzoHitAuh237Ob96llS7hl7PhAd/+4MBYG7WX3XalH45KSBl1sOIgEzz2zrql04A5F6WaSvEX8qZsMUHXWDywB2TrabtjpvrVEFqH+iopSWSGdcFHLAoCw1+2P9hM6kJ/V3C3BhRCMRACFuRYNMSb8eOjn9w68D2I4hNtIIfVqCK+bAnfDUSXL0RY/t2iITKy71iLBAsoGo91bo2FlHWMAR6MhbkHHKR7qLYA6PeA8NTzTL+j6xR9SUW565K/tmcF2ULUpX4DPPB56epr84YWLDjoT5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=UuxmDkHlGK2qioIZUCl1D2cQpX9TzTmymVY0PE7L8bA=; b=QOik+dQ+55UYGAb/VsLqgxlHqPQ6jH3q4sXh8o0q7UkuvCJXkEJWlvPZX09J6JADYc8gGSwOPY/EnST5mC+ltXoPpqxwi8M9MqwfkTwwB0GGSeH/jOMwBofspVtAo8xostuPLi0LZrZiL47PKk4pOWgMTMO915uE5AWn7VDekzZpGqM1uRyqcj9hENKYYNuRoBgYJ+P6o5R2RxkP82HUoL5qPMByF5NPKqog/acx31228qkl7YwiDAZYfJw9VWAjOG+Cqx2pgQ3cvwA0oEBsU2GtH3qKs9vZKWpnsn6qd3Qf5nptVK/gv5Ls7CHOEFQhIxj7+zy8UP6msR5cEx8uhw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UuxmDkHlGK2qioIZUCl1D2cQpX9TzTmymVY0PE7L8bA=; b=vLNfQM+KziT14TKwKK0FUNPl9pmD2XFyf7QsZnxxwQSLMRCtWsmSXZQqn+CePJRV6LEqvUc0OFA1Fji2Q6hzSfhyfuSG5EyPBSwu8wSblQtHQcaaJEfS1pIIYMR1GxPhmc1km/9Jy8OKTv1d0I0EgBxFc3MIZ1sC9R/xV08LBNNSNhWxRWPYjp5SQkMTU09yaZbsok+3HeulhFci9Cl2U02We3IYK/ZEcYoeityMy5CwNT8wCG482BVhgprFuu46bjupai0gpvOeBnD8sFO53LqXGMbPx/XXRKy1vQoWDwnuUlrtcaBnSh4RADsy5rEtZf7/HVw0YiJ7JlKx9ceVaQ== From: Mark Cave-Ayland To: pbonzini@redhat.com, mst@redhat.com, marcel.apfelbaum@gmail.com, eduardo@habkost.net, imammedo@redhat.com, qemu-devel@nongnu.org Subject: [PATCH v4 07/18] hw/i386/pc_piix.c: remove nvdimm initialisation from pc_init_isa() Date: Thu, 10 Jul 2025 09:52:22 +0100 Message-ID: <20250710085308.420774-8-mark.caveayland@nutanix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250710085308.420774-1-mark.caveayland@nutanix.com> References: <20250710085308.420774-1-mark.caveayland@nutanix.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AM0PR10CA0128.EURPRD10.PROD.OUTLOOK.COM (2603:10a6:208:e6::45) To PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR02MB7159:EE_|BN0PR02MB8048:EE_ X-MS-Office365-Filtering-Correlation-Id: eebd1b3a-8bf9-4a31-eef9-08ddbf8f431b x-proofpoint-crosstenant: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|376014|366016|10070799003; X-Microsoft-Antispam-Message-Info: =?utf-8?B?dEhFNlBaUHdzek52M1FCYno0eVVaWVprZEFpVjc1UnduSWtYcVJWWkVBV0Vt?= =?utf-8?B?QlhHbXBRMlN1QTNTSUNGcmxBVTkyUlg1R3hyRlNjZ3RLSkFpb0NWMTlJRTZ5?= =?utf-8?B?QTJ5UlZ5di9vN3dOY3JVTTVLRmgxZ1JTWnBReVJoU2VmajlYMkUyNCtycEZB?= =?utf-8?B?V3p0aXFmUzY2eS8rZVZLR2d6WWVnYUk5QVRnMVMxMnNSNnk3NmV5MnlDVjNJ?= =?utf-8?B?Tlk4UTFuNlJpZmJ5cVF4by9NZUVvVTlIcTFjaWFmeVZXbHBLMkNmZ3ZpbWVw?= =?utf-8?B?R3luVHRzRmYvaTl1Y1hrTkdTcmZuVUloMXhZWnpKdUZUam5vVzRRN2pFR2ZN?= =?utf-8?B?YnVwUjB0bTkydS9hMkJqMDgvM3paTTRackVpRGtmOUpwKzhObG1QaW94NXRR?= =?utf-8?B?VWxEc0dCNmY5VjlNZk90UEtza1Y1eFdTazZvS0I0Zm9OdllaSjFGejEvejhl?= =?utf-8?B?VUhZemI4Ri9SSXpsS3ZkVDE2ZnpMd0tQajNXTVhOQXdiZHJwSG1tVlVRWm1x?= =?utf-8?B?U1Q0dklyWjA3TGd5bjlrVHlQNnk5bG9VUSszc2dBbmVDYXhtc1V5S0R1QUNH?= =?utf-8?B?M3A1Q2tuNGlyL0N1NGJTMGtJT203MFJVMlBIUEJlNlZrckNpVTM5cjdqeFlq?= =?utf-8?B?RjFRQXRvcFp6NHV3dXUwY1RNWEFSOXljdHYwSWdkR2NFUVM2WG0xbC8vQ3NM?= =?utf-8?B?Nks4K3VqNnFSeENWbk4vanVFcTNad2dXSmdQQ0dsMXkvRE1oUzdRYW1ScHRB?= =?utf-8?B?d2hlUnYrWURUR002Z0d0Z3VqS2VJaU5CVTRJV1h5RjBlZHRRVDd3Z1BQd1E2?= =?utf-8?B?ck9ra241Y0t2a0dML01qSDNtSDRKN0VIcEpXMWg0WE1DZ0NkVHJDRTJaVVJr?= =?utf-8?B?amhoSlpaNExYV3JPZlRuTUgrcXBCb0tBa0IzQmVPU1BHbzlpQngzMmhUSko4?= =?utf-8?B?Yzl2VWQvZmVackJvRGFxZmxRMlJlbGo5RlpQdmpwVTVwK3ltOFprRUJtMHRG?= =?utf-8?B?TmI4VVNDV0ZTSkVmWEN5VXg4UlBPckxjYmF6cHNpU3pmbjdXenU3SCs1bENV?= =?utf-8?B?cE5tRVI1N0wvZURFTUFVZHRWbHNUTW8xTmdxdnY2Nmp3YU02NkJpOWRMYmJo?= =?utf-8?B?K3FCMThuT3Nlb1ZvK0xwL2pMZlZwQUw1cDc5QmZ0elBkZlBhR20zMTlsUFQy?= =?utf-8?B?ZXB5TkVvYkljNVlyOTAySjFwODdabGNFeHd1aDduQzA3ZmpNYkdETWxBeXJo?= =?utf-8?B?WkdwaHFGTDcwbmVLY08rdmNOTWhabWp1Tk1BNXJvWmNJbFpnUFVPam9ZSXIw?= =?utf-8?B?akdVZXU2ZUM3ZjVGTzBDMlc3TUxDa0pMQWgyOWNhS1AvSHdXbnEyKy9VQk9q?= =?utf-8?B?K1gvdllhOFM4SElPRXJ6dEQzTFE3L1g1WmZ0L3N2dlA2cG5KNjI1Q1BkSk9V?= =?utf-8?B?M2FhRHg2blVFK1lCL2VneHFxaC9DU0VxakwwRFRFR2VBT0dvYVJGQjRkbElm?= =?utf-8?B?MGJsR2pMUEovSW5maFJMUUNrWmdVRHdxL2tVZVhpZ01IR0NEUmdYc0I5cFpH?= =?utf-8?B?TjlidEh5WWYrRUpjb256QkQvZmhtNjlOUWhRNEptWHpTVGovYzFPUWNGeFYv?= =?utf-8?B?c1pvQzdVZDNwZit6Nys1akJybWx2UVpDOFlPVFdXRjRQblJvaERtdjh1eklM?= =?utf-8?B?UUVhSWdVY1h5RUI2SzA4b2RvODMzdkJ1Z3JmdUFteEh3ZEtUOTFJNGhCQkw0?= =?utf-8?B?NjU4ZUM2OEVSTWordEJqczM1YTF3VFQ0WVdTSStXdU1sTk5TTytSTVJpOXV2?= =?utf-8?B?V01hbitKVVJjSFhJejRGakFGZjk3VlJUMExaM1NDWkZxTWhPQ09kZGVRYWx1?= =?utf-8?B?WFVZa0lDMHdkTUVSS3hkczVFVGFKTDdTeWVDOG1IU2prU0ZIak5LVzg2ZDJT?= =?utf-8?Q?89dC2Pr7CMk=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR02MB7159.namprd02.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(376014)(366016)(10070799003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YmlhdDcrMkhRUkNVV3NrVmJ4QWQyQXFBcWUrNnN2a3ExUFlFb09kNzJ1Yy93?= =?utf-8?B?T1hDTXNsamNLSDRRUlJRYVNSc0pOU003TkFRVFZoSlFRTzE2K1JteWdGemcv?= =?utf-8?B?czlvakExNWJpb0NHVjQ5OXM1bGpEUTczUkFKS3A5c3FaM29oTkh4VjhKMWZV?= =?utf-8?B?UGJoc2h6c3lRdDZRSmovSS9vVlp6WC8yeEVqSWRWaGluRlhOR0FTOWFxa3pM?= =?utf-8?B?dklFS1BUVXplYzNKei90SzdqL1JqKzNvMTVhSmZ4bVRVdmVZcURFOURlOVJL?= =?utf-8?B?N0tWTDZFOFg3eDRzUUp6RDBTTFVVZyt2WHJLUWs2RWJIMExTYkF6MStEbk9O?= =?utf-8?B?VndKL1RUSTlwLzBsQjFkNG1QaUFzeHhxaDNUSDg5ay9KckRGekVuWXBHZnJU?= =?utf-8?B?Smtqblo3cVlPVEhkbEEzSHRRSXdaYm5sUUhPczJXNDRUM3ZiUlZMNEdpQUt5?= =?utf-8?B?WWhVNmUxZFlzWUNZV2F4MSttS2hPSksxZVZnR1BnWW9aSVFnMmk2RHllSW14?= =?utf-8?B?OE9FcE5mVlJONXd1cmpIUjZjSGRvbmp3Ukw5KzZNRnAvZDU5YXZ0MFFUZ1JM?= =?utf-8?B?SkpVOE1EMWN1akRPWlhXcUJLOE1CRXNORklhTmFEeHJHY2d3d0lUTzhsdHg4?= =?utf-8?B?OU54TDM1S09TY0dISXM2UkxMNk04WkxaTXNCdkk3UUhISjNiL1pEOU9ZQjVT?= =?utf-8?B?M2lwTEJhbE55SWt0SFZKbHUvQjZYVDByQi93Vk52RFdWcEVZUURKYnVCdW9Q?= =?utf-8?B?YTB0QkgxWXRMT3JGSWZSWXR0M3RLOWFtQ1FieHlVeHFhQlhZbEI2bXVBRmtD?= =?utf-8?B?NzdmbU1TTnYzYXJWaitzYUNuK3lURHJ3UXZ3UmNscXBMZ0U5V0dUdmtVTm1J?= =?utf-8?B?c1VWWWhPSE1VTmxEcjFVbTIrYkJjR0NWMFBBZ3I2VjJTYzVkckQ3OE5xM2pp?= =?utf-8?B?ek0zM0pZL0hnNGFHUTd0a3NPVTBTU1pnZElZT3RPTU1UZXJkUkJIdVVTU1RU?= =?utf-8?B?cUFjWStud0wwa1g5OVJuOStpWWVEMmRNT1B2NjRFS1pkclZtTFhEMHdxUjBR?= =?utf-8?B?ajBXKzRwTlErakhDM2QvSm40WGdlZVE5Mms5VzFIOGk1MzY2RE1CajIvUWhF?= =?utf-8?B?a2FkakRoTUEwbXFmZVJ0bm5iOURpblNTYzVDOFczNTFrcHZzVDQrWGNMUDNl?= =?utf-8?B?U21BbmN5b2J1ak4xRzBvVjJBeTFzL01FdFFaVnd3dzdDZGNPbHN1Z3VBRGxi?= =?utf-8?B?eTVMa2FUbnpTUTJXNjEvMmErZkt4ZUx0eUh6ZWl3Rm9kY0ovVHJnODJNYkgv?= =?utf-8?B?L3FvR1FsQlp6Q2tOV2M1Y3FTRmx5TzZWdkJueFZvd0ExU0ZYbnV2Q0J2bGpq?= =?utf-8?B?WUNQMXorOFpIelo2QVNpTHhIMlB5MStLN1p3b29EM2FZUS9KS1diVjIrVDEy?= =?utf-8?B?Y1ptdFhMMytUMzUwaGxORUFpWW5WcW1QNjllL2pMWnVieU9adEF0MmZNQ0pB?= =?utf-8?B?SkNIWWNIdjBRWlgxdC95T1RKWmVGT3IvQU4rSTN4a3g0YUV6alJwTjFJYUN2?= =?utf-8?B?SEZzcnRveEJmVCt2ZGVzSWxKQW94azBPZEJjbkRpUW1zMEdnN1ZHOWFqeTFI?= =?utf-8?B?T09PTzVqYUlPTDNUQ0pONU82dWE1UFhoWmlYTHlMeXZxdVAwV29kb1EwK0RH?= =?utf-8?B?dzRvUkpJNDAzdU00TEpudzBKVXNyVXRWbTlNc0JneDF4VFJoanB5Ykx4TEVS?= =?utf-8?B?SWsxQy85c0lzd1JzOUt2ZXk5dEZ1OWdYVk5Jd3REelRQSE9ja1Z0OXlNbjc5?= =?utf-8?B?Nmdrand2dkNmVVNXV0M0Z3N1cEdqODRzMVU2ZFZzTmI4MDZNMEhSWERGNVA0?= =?utf-8?B?SEtYcUJvRlArQnBKYTFPUi96cldhZUczNGJUa0V0SG9rS1hlbSsvc1EvRVQr?= =?utf-8?B?c2k0NFRwOHFFbkgvT1ZhaW9GT291bHpYbkRWOUcrNWpIR1dWZXhXY3dzYWNz?= =?utf-8?B?b3duWUJLNnE0aW1pQkRiZ1FwSUYyZTVrdk1SV3VrcEpZZU8zQkJYUkZHZWg5?= =?utf-8?B?UWwvcFlqOXhXUm9NNGxBWEpTVDdxRXFQMjAxb28vcWs3aHhtcWRSSmcvSWFi?= =?utf-8?B?RDNWRmk1VUxpMjhDUk5pRERQVzhwZ2IvMDQxTEdPb2xWL3BhcSt4M1h0d3Yz?= =?utf-8?B?UWNwcndsN09ic1RGblU2bUU5SE4wSHY5SU9UcDVXVnJRbldpY0ZqTXZiMis3?= =?utf-8?B?SEMzVWJFRXRpK0YyYU9IamVMY013PT0=?= X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: eebd1b3a-8bf9-4a31-eef9-08ddbf8f431b X-MS-Exchange-CrossTenant-AuthSource: PH0PR02MB7159.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jul 2025 08:53:38.4315 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: u3EyrtOjdQ8qkyybgZi9XHLjXZ+BU5z+RfZXoDPSOZtHXf7sXhDatphtw1EyTuTB5SLwXsqsWoMFwxi7nsH/ccW2VG4o4BWq4QHdtQ1KgAA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR02MB8048 X-Authority-Analysis: v=2.4 cv=Nffm13D4 c=1 sm=1 tr=0 ts=686f7f95 cx=c_pps a=bGwgGCu/CPolCU/HHR4Rmg==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Wb1JkmetP80A:10 a=0kUYKlekyDsA:10 a=64Cc0HZtAAAA:8 a=KKAkSRfTAAAA:8 a=XL6wrB0Zc_gxRR1ig4QA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-GUID: Ujh50bDcNmnl632s5ONMujABtQxvDw0g X-Proofpoint-ORIG-GUID: Ujh50bDcNmnl632s5ONMujABtQxvDw0g X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNzEwMDA3NSBTYWx0ZWRfX2xFBbCmZHsT7 zyTkA+j17lQPgTFg6yGwMViq4HZZ7PP211eppR0Hy/CPttjFlEvicaLdGKo9eWxCBk4CKGsmWHe LTLWC9zNTljvR34pLrXoav8bmVG5Knjlzaz7CVEHtEg3QWbOiQ/h9/CK7bv97DwLT1rhl7y4V3Q WYgtlK04W09oC+tzcxNEmBHxRd4SJ9vuYSbzRvVo16PO3nlJwdZPYLxs1yJOJ+3M7yr2563e92e VQxuwBlypH5Jp5/TCb9g8EjUcE6O8Wl5F3AiqQajIVTiYPQc08CTTvCRI8njJqrpbqTXLCG3MCP qd4BBpg12uWstfFTW3n+LR0QUPpr4DJKSA5Qjq+pjgofT61R1HaBZRNunFYmdln3kyfgxr25lts 5PYlbi4cBflVZUcl20PeRC1fVRixhUVctfZnR1YPoITh2n07SOlzba8AOLIFxGVhcddmH45U X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.7,FMLib:17.12.80.40 definitions=2025-07-10_01,2025-07-09_01,2025-03-28_01 X-Proofpoint-Spam-Reason: safe Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=148.163.151.68; envelope-from=mark.caveayland@nutanix.com; helo=mx0a-002c1b01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @nutanix.com) X-ZM-MESSAGEID: 1752137734474116600 NVDIMMs cannot be used by PCs from a pre-PCI era. Signed-off-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- hw/i386/pc_piix.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index cbe4b33ba4..2c508f9db6 100644 --- a/hw/i386/pc_piix.c +++ b/hw/i386/pc_piix.c @@ -573,12 +573,6 @@ static void pc_init_isa(MachineState *machine) } } #endif - - if (machine->nvdimms_state->is_enabled) { - nvdimm_init_acpi_state(machine->nvdimms_state, system_io, - x86_nvdimm_acpi_dsmio, - x86ms->fw_cfg, OBJECT(pcms)); - } } #endif =20 --=20 2.43.0 From nobody Sat Nov 15 10:54:05 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass(p=none dis=none) header.from=nutanix.com ARC-Seal: i=2; a=rsa-sha256; t=1752137663; cv=pass; d=zohomail.com; s=zohoarc; b=LeyDlhZjovtKP32cW8IBOxM1r/s/fZ8m5AZxxVPmOLUSIJMa98KaPL/tiylNw0KqQT80/NO6uJBX5I52Md7TRk3XruQNSxVmx25veHLtwlS0rqrxHh4GMjtSqLQ00dIkdhK1ZTF/wLvxeZO+8LJAY1I2aunOIH/72zGmEJbLK7o= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1752137663; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=Dyd/rqTp1IzCDlik89rDGfjueIDhCQW2dHUL1PqkPpc=; b=UjaLN8H+Qqxq4fqKNTbyc7w9G/z6zZrLrIHQzAWImQNuYHL6BoYsXjalAF93t+9OZ/gUCyY3ORX5SBDq3TPuE9sSbBoO53XJnaMC/zeeR4pyLrTlSJvMi3x5Gn4k7pI8wu39+VkFKqN28mhvdA8q3ryWu4u2KOFA8Lu/6euLkeI= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 175213766296347.85498719054135; Thu, 10 Jul 2025 01:54:22 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uZn2T-00081j-0U; Thu, 10 Jul 2025 04:53:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uZn2L-0007nw-65 for qemu-devel@nongnu.org; Thu, 10 Jul 2025 04:53:50 -0400 Received: from mx0a-002c1b01.pphosted.com ([148.163.151.68]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uZn2J-0003Xy-4i for qemu-devel@nongnu.org; Thu, 10 Jul 2025 04:53:48 -0400 Received: from pps.filterd (m0127840.ppops.net [127.0.0.1]) by mx0a-002c1b01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 569MVr7d029396; Thu, 10 Jul 2025 01:53:44 -0700 Received: from cy4pr05cu001.outbound.protection.outlook.com (mail-westcentralusazon11020112.outbound.protection.outlook.com [40.93.198.112]) by mx0a-002c1b01.pphosted.com (PPS) with ESMTPS id 47q0cvn28f-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 10 Jul 2025 01:53:43 -0700 (PDT) Received: from PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) by BN0PR02MB8048.namprd02.prod.outlook.com (2603:10b6:408:16a::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8901.29; Thu, 10 Jul 2025 08:53:42 +0000 Received: from PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88]) by PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88%5]) with mapi id 15.20.8901.028; Thu, 10 Jul 2025 08:53:41 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint20171006; bh=Dyd/rqTp1IzCDlik89rDGfjueIDhCQW2dHUL1PqkP pc=; b=lG9nIR5pYvmMwET77IxX42DxKplMVGA3bu7MIMKgHeK4AquokOr5j9CQj SI5ZMS8H0q1uXaOKiX33a3VIfyA3asj/FwiTNnrXR074PqJ/2zx5YfyiRRPsJVz4 44neiMpvJ9wApMQv4K2hGd79KwZz2c+x1M+lrU2hP25mxIkKOfl1FWBwkYJjG7zx DvgxaKGog/P9jA0/3Ad+dMu7cH9a0DStE9kcKFRDET7bhASODFteljy4SdAEuBL8 RmmOtlniDx1nzdV69JcanAMTBaZp/x8GF16NpwY9UKrVjkdZHZH3PHvaNMiI7qEl qYlsic1KNlkRiDU1x7gOHUfbWOI9A== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ZR2cGbS/B70Ft8Yn1gnvyfTriXdEPkn4GelaaRF/vnvDRDVdCdLAbDtY70M+9WWuE+z2kVMNqlvOYiONj3t/YyWQ3LNfOtC0nUp6tY1yy6j/brEHEg/xwYwZbKkwxs9alWec6Z9JCXY/tO8VAeLEB26X0gzF2unyWDwnrpivh7R1wKP0pIHv7TBwwr26wtl9eUBu4gtHD2JOJTrpmL7A4IWC9h3vfGKHtrQpKohdpRg/iA6bFbi1pWqZ+ZHE5ZNImXSiNQZYW4qgkeg7Wn2oWV6oRfv9Btz5nXQgRdO9xEi62A5XMsXN2wWNo4UefUMWsWUQtICTi+HFc9Tbt1gWAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Dyd/rqTp1IzCDlik89rDGfjueIDhCQW2dHUL1PqkPpc=; b=wereE7px3YNU29lSsA7u6KtS/4Qt6IBrEnQWsEY3JMhmJYuXaW9LmYRCDiD3CqbEdcWAqk2YCsg+IfT6yXvDAe/pZfubwEKbBc76km1b/MoIyHFdsvSH7NRz9LXFYVEs1Bl+k6OeES91F84td2IzizBZrk32bbKcc/9Eo4u2qvX9npPolljZbFbuKBUyEDks/kZz1vTlj6cJuKYwhsm4SX1z1gA+bTCL7mtNFXmQiRtMZF21HwlfLL/vkV1FMhlX29/FZhbguioCWVpdEhqeoUNyXUEgRoE0EVoUHWR2xxTTQkRPCPmeK1+ZleJYEcPEQoG+naYk9ZJxp/Uhb0+VBg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Dyd/rqTp1IzCDlik89rDGfjueIDhCQW2dHUL1PqkPpc=; b=aQnWMq1iSBeOPR7ALhXLdaQ8gIgS/poFItUYFTxRn98AuOt555lU6wpUyoTXZHcOA7VG8bIG+B6UTZuoVTOfXTIwIA6vNOu7nez0aEc2FeUphfXnJE0M0JukVc9IH0DG2tlnPb8IytIlGLr5z5NJExv9iPmL7qUH3INAYfGwD7U+DLlqc4lZnZ0R8rwSSyWrDHJq/Q0qdwiAJApVLQgl2SzGGklk4Jn+LdITCloUiL2KKgM4B8PEenXUvXQBOyvGL7ZwRi26vx0cvff80Vypts7XwHuidxabKsdpfj3Mxn06WtM8GkKvll4ZSiZgHrRubn6d0kKNkYtpu2RJ55Ya9A== From: Mark Cave-Ayland To: pbonzini@redhat.com, mst@redhat.com, marcel.apfelbaum@gmail.com, eduardo@habkost.net, imammedo@redhat.com, qemu-devel@nongnu.org Subject: [PATCH v4 08/18] hw/i386/pc_piix.c: simplify RAM size logic in pc_init_isa() Date: Thu, 10 Jul 2025 09:52:23 +0100 Message-ID: <20250710085308.420774-9-mark.caveayland@nutanix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250710085308.420774-1-mark.caveayland@nutanix.com> References: <20250710085308.420774-1-mark.caveayland@nutanix.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AM0PR05CA0082.eurprd05.prod.outlook.com (2603:10a6:208:136::22) To PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR02MB7159:EE_|BN0PR02MB8048:EE_ X-MS-Office365-Filtering-Correlation-Id: 41f659bc-6289-4e78-7ae6-08ddbf8f44ed x-proofpoint-crosstenant: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|376014|366016|10070799003; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?QplKjiHf5dL1bsTjIAL1r5yCdFVBwKlGXpZ5/VXjCpKmCYByyaXg/11DFwd3?= =?us-ascii?Q?MXrrGnrjVfdaqicxJT56OFd2itQkdak9dSLp6y1+ncoCkxeS3ZW4W08ZCMGJ?= =?us-ascii?Q?EzCB4PXLKfL3yKYye/AWQeqbJCqi4pylhopYVADZix/Wv3wXqgiKHef17zs7?= =?us-ascii?Q?5eNQVr7EUi8yU74mYFHyj7/CtO/ZAMfPzNa/mSFr4ENnONefrBBCIxMpOBLU?= =?us-ascii?Q?kzps4unMW5sX7gGuVB8GJsNkYqlt7Gsx2V2iBJAnGzXYJYiah3vz4n0nrFty?= =?us-ascii?Q?GaRJgAVzbQpgYhPrz3Vpz+N+8CCTfSUZVp6S5MDQZfPRkDfT0Co7j5OlQN6u?= =?us-ascii?Q?u34i8JHafCof+hfzrWq1m/xNluyjTubns3oRE5+5KhECH76nxO4OaQ5cHS9A?= =?us-ascii?Q?VKCZnXXssGgZiZO1h2GjR8SFUzo0zvbUePc50BVhe1teca8dpiXOjdI+gv1s?= =?us-ascii?Q?RPNw2chLJ2tluMLzEn9fl/o/92t6niT/J1IBe2Qt42MJiuFFExy8ElzupxUV?= =?us-ascii?Q?EE0iXMftveFSUC8BweP2G3q0wOB9MjSevABqFS1kG8TUqwFPafnq/tijvSii?= =?us-ascii?Q?QI3ba39TYKatDokzFnodxYn8KHxIxT0vRgW7eaSt7/o+gXLQhii0FZr01PsZ?= =?us-ascii?Q?eQzhOMCLxMkDY0OvofkpWsik+12GAFZiXlW5WXRWifm9tqfx2oUoSqZXEkHx?= =?us-ascii?Q?e+uC5cAl7AupqoDxV1zPrTWJTtfnAU0Z6a2tncg2MWLUsz6/ZZCQcJn5bzq4?= =?us-ascii?Q?I7GlGiOAIthcSPOKDpganbkcOcRH17FYOF0lrr6fc83qzV16WJp+N0f8jpXj?= =?us-ascii?Q?D7HCZxi/jVy2TKQf1ZYfjyIgkZLmtDUJPJmrN7QVQdlZI+i/BZgmSXYU+gL3?= =?us-ascii?Q?jjNeTYcEtJ3W/DuBnItbk/ycSt+TN/3LP/JdcpW41pyfsakTJxsstg+a6Y5S?= =?us-ascii?Q?FZ/5sZGucXkTJ6YbtuXgRXGeSaXzLXMUqdwNbr/G/MTRk62CnxSlyBplNHvI?= =?us-ascii?Q?4H4DPDIgwhX01NeTK9ICk51xU8MWIs+dj2MDzLPLUtsUJobSsb6amoE7c829?= =?us-ascii?Q?stIRPVrHaVgNPf5LKZoPpmGeT7kxkHHrolP5YWdOjLMz1mk8vzumJoupltOi?= =?us-ascii?Q?//zFINMQ+ycjnwPPfOy4C/Wcu8/+5or70A0sZg8TYEMRObXl7umU9bzyY5qs?= =?us-ascii?Q?SvGbnZld5bD00h5jOKQWNOSQm94g3QLAVlAj0nxNPvRnYkaRHUUsVK34nkpC?= =?us-ascii?Q?UK4JJSYKkUJJyJp5QNozmSEVJaAgP8lj3ug73I4V99Ssdl+8rqetW8U/MhtC?= =?us-ascii?Q?l7nZNbmyRPnF9+o6BuS5hcwIOHg30o3dyZmH9XYS94aoMwwQPOGCoPXOKn2A?= =?us-ascii?Q?Uhv5B53GmdxVb+B+GQc2FVxjfo5N/F0uW4M7wvCCljLYvXSTr1wmHPQ6l/6w?= =?us-ascii?Q?KBogyaOrx6A=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR02MB7159.namprd02.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(376014)(366016)(10070799003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?B9XxhnSfNqbT2Ka/ozP1KoFWBumgNGE8y/5jXnNZeNrWZrdSDJf6PO2NeCKV?= =?us-ascii?Q?YL6rEiLRDQ9LbonVvZTdoeMAvR3gdbKdnbgNWb+VNV7tJKel7MDWhY1G1uxj?= =?us-ascii?Q?k2QQi9dOgmjrmePPMeE0WuEB/jYGOdAqyp6JPlBrk+eChkQeoMD6e9UGGF7M?= =?us-ascii?Q?bYZbDtwPioTe9vXX5cVpGsFnjK2HonzV6w95YNt1HnzyV9CPbZJ+xH5QUkiH?= =?us-ascii?Q?CUYu7k5eLJR69RmoFUg3wKYRrfYVCZL6nk3PaN4YkNldhIBXwHN8xxa1Af83?= =?us-ascii?Q?1XwourVoiS+/cUJ9S0jN6X4iE3YZQEjDVmEq3GrP49X3u73CWphhHOPqj0Su?= =?us-ascii?Q?fL1btoDs+XSj2PlSPEkJ/Eqq0c6iZ9PvEIg0xrtMhVkky8a1u/aThem2QkoG?= =?us-ascii?Q?cWkaMO+FtSGE2OUBbcFUkM8swQuAi1c+jX0BU0hynA4VDg5DFbRg/GrDvlWV?= =?us-ascii?Q?JegoWIo9fRYDAO1j7yCAo6tmWpg3z3KomxmR/XRdweAkzfv1AJr2ma7xh52Z?= =?us-ascii?Q?JfZ5SWdaELaLZT4aBmXEXb4zqgf9xCXDzN3xm78RLafg7tYLTxHI7YWeRRKe?= =?us-ascii?Q?2SmbRhm3trf/w6gsBgn8vWywsHD15tZcn1CHhH02H47kFN2ZuKpAurtagaXR?= =?us-ascii?Q?Qal9x6gG/TRVdb+jI9vNBCreP/pHTBuk/oQUsRmnN0G268nU0ATQ5nS8AUSW?= =?us-ascii?Q?l8A6uVLiXalfI+ef0VxEL13xezOrx7Or4sCR/mQpB61zSPlH1Om70fhxl3E6?= =?us-ascii?Q?yb0/TvWPVNARCFLFhTDLydkf9WrphALzB5E6IbfgQOxHqw/ulVU5BJlKZ9VC?= =?us-ascii?Q?NHLKesCDLP8P5yM9MWaVupu9EElQluj+zq5KX9fbU7KxHTNIKafII5XAyr2e?= =?us-ascii?Q?6p3iBn7TR/h+PJacdO2HN8aX9x9CC/Meakk07bFdHTXxoAf3ixWFVXX29wL0?= =?us-ascii?Q?8ceLvkMi5xUBuTN01ln9emlb8GanwW1OZXRL4gq+ySm2qNBSg5yMRuMJLWgo?= =?us-ascii?Q?W6nU3HgO7y9W4+R3Aij0rb+D+R9sqCEPr27tIoZkiAJqq6w97G0FcJ1S3nag?= =?us-ascii?Q?rWMOKeUP8P3+yNCXkAJYLD4+dgbsmbGotd+gEDn6LCjCw3H3V4svIgDnz8Ow?= =?us-ascii?Q?gTJ5exjCP2aEigo1Jqd/zz9HsRCmB22DdguCueuiM2CMweXrJv3DLuAwX5RV?= =?us-ascii?Q?oSkH4M+b5GIuAD0J+TnyasBfoX80GrlGWBKLyZzn3B2B6OMdh9UmaHEvjPQ8?= =?us-ascii?Q?LdQr4enYH9hzuIB2KquWIJHII5IXeYeItvJ/eKkUr5TsC7WbCYlK6nXEI64o?= =?us-ascii?Q?DDEwrd+fCfCK8oEabwLkBk4Dzb8RHKidoH+Q+5jCQbtxTHoblSnoS0Y0UAlh?= =?us-ascii?Q?2r1YbcCSy5CGdIWXBUla5MgsrtDKJqR94CjiywoJ4Np55jLM39EkFYy1aRdY?= =?us-ascii?Q?JqVVK8M5ev/6kY5P0davMkD2R8M46YfqB3L2R7oqj7PXtmWemOjO22hgZvde?= =?us-ascii?Q?U/tH88brkeTP9TRPtKCL0EeKIjN85UTyp/CJ/xp27MGufT5IgMIjqimwZD7p?= =?us-ascii?Q?Wx1BjU21dvx8bRVMHM+QK68eS9CbxCarqU50Du5mfj7+d7o00TUNZrtY+uld?= =?us-ascii?Q?je64fQgP13Qx2zuP975nIOg7Gn4hgZ94kCMSzUbZoVvCrVzp/iJVYx10/4je?= =?us-ascii?Q?8axwyQ=3D=3D?= X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 41f659bc-6289-4e78-7ae6-08ddbf8f44ed X-MS-Exchange-CrossTenant-AuthSource: PH0PR02MB7159.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jul 2025 08:53:41.6468 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Gwg+rRnPBYeu7ThsT1mQoLjk6OojZ3aR43pYxRDF0cyCictn7RlkPQWLtcSSlzDWvmDosviPeuu3M2ZOT/ojBQ8JeJtdvbO5tJi+vVJxx2c= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR02MB8048 X-Proofpoint-ORIG-GUID: ZtSOeCIqZ4KJcoAED6fZO15ELIEu3rl6 X-Authority-Analysis: v=2.4 cv=ccXSrmDM c=1 sm=1 tr=0 ts=686f7f97 cx=c_pps a=waeEY1lgPsvMgfEg+IY2ww==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=xqWC_Br6kY4A:10 a=Wb1JkmetP80A:10 a=0kUYKlekyDsA:10 a=64Cc0HZtAAAA:8 a=puX-rZ3iWx3qy-NnaecA:9 X-Proofpoint-GUID: ZtSOeCIqZ4KJcoAED6fZO15ELIEu3rl6 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNzEwMDA3NSBTYWx0ZWRfXxrRcsz9ToOSV K0AesmGB8BU7lZZcSeQkj3rcrofQ3lvFOsJmA8QQWEFuG/+TCY2IPo5wd37n+BlcETSQCcGnPDi wwXPVafprE7WNSHlRj5+l4qgLNYrNX0nBdeVGwkvSRGOsX2J6u+k2Yec2qD5rDotUdSo48S0a/7 Q3QhzavLQ0tUUJLTucJl7esTkeoKkKWdCEi9Psx3wec3WkmBGTAY/7QA1r22o+SIXdWRY0+M0XV EOTOdTxdipVIRlLlIhtMgKI813+Uzcl6XkF3Hd8/lBsutvr+Tl8a7PncW7ZwUkjFHEazdl8hUMS sFf3h1PIi6i0MhWA7dZUmKs54yfBGtRDI2cBvvsMshzXVXhhp7m++90OjUHN1Oe6/YZu5OyytDU YeoXxtFbOZxzhnERCTWKbWM6+0oWX/n1SRv3xubNbemcMw2rvcHx8Yj3a4ldV27CuyOl3NPT X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.7,FMLib:17.12.80.40 definitions=2025-07-10_01,2025-07-09_01,2025-03-28_01 X-Proofpoint-Spam-Reason: safe Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=148.163.151.68; envelope-from=mark.caveayland@nutanix.com; helo=mx0a-002c1b01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @nutanix.com) X-ZM-MESSAGEID: 1752137664078116600 Content-Type: text/plain; charset="utf-8" All isapc machines must have 32-bit CPUs and so the RAM split logic can be = hardcoded accordingly. Signed-off-by: Mark Cave-Ayland --- hw/i386/pc_piix.c | 58 ++++------------------------------------------- 1 file changed, 4 insertions(+), 54 deletions(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index 2c508f9db6..80e4ed8c87 100644 --- a/hw/i386/pc_piix.c +++ b/hw/i386/pc_piix.c @@ -426,69 +426,19 @@ static void pc_init_isa(MachineState *machine) GSIState *gsi_state; MemoryRegion *ram_memory; MemoryRegion *rom_memory =3D system_memory; - ram_addr_t lowmem; uint64_t hole64_size =3D 0; =20 /* - * Calculate ram split, for memory below and above 4G. It's a bit - * complicated for backward compatibility reasons ... - * - * - Traditional split is 3.5G (lowmem =3D 0xe0000000). This is the - * default value for max_ram_below_4g now. - * - * - Then, to gigabyte align the memory, we move the split to 3G - * (lowmem =3D 0xc0000000). But only in case we have to split in - * the first place, i.e. ram_size is larger than (traditional) - * lowmem. And for new machine types (gigabyte_align =3D true) - * only, for live migration compatibility reasons. - * - * - Next the max-ram-below-4g option was added, which allowed to - * reduce lowmem to a smaller value, to allow a larger PCI I/O - * window below 4G. qemu doesn't enforce gigabyte alignment here, - * but prints a warning. - * - * - Finally max-ram-below-4g got updated to also allow raising lowme= m, - * so legacy non-PAE guests can get as much memory as possible in - * the 32bit address space below 4G. - * - * - Note that Xen has its own ram setup code in xen_ram_init(), - * called via xen_hvm_init_pc(). - * - * Examples: - * qemu -M pc-1.7 -m 4G (old default) -> 3584M low, 512M high - * qemu -M pc -m 4G (new default) -> 3072M low, 1024M high - * qemu -M pc,max-ram-below-4g=3D2G -m 4G -> 2048M low, 2048M h= igh - * qemu -M pc,max-ram-below-4g=3D4G -m 3968M -> 3968M low (=3D4G-1= 28M) + * There is no RAM split for the isapc machine */ if (xen_enabled()) { xen_hvm_init_pc(pcms, &ram_memory); } else { ram_memory =3D machine->ram; - if (!pcms->max_ram_below_4g) { - pcms->max_ram_below_4g =3D 0xe0000000; /* default: 3.5G */ - } - lowmem =3D pcms->max_ram_below_4g; - if (machine->ram_size >=3D pcms->max_ram_below_4g) { - if (pcmc->gigabyte_align) { - if (lowmem > 0xc0000000) { - lowmem =3D 0xc0000000; - } - if (lowmem & (1 * GiB - 1)) { - warn_report("Large machine and max_ram_below_4g " - "(%" PRIu64 ") not a multiple of 1G; " - "possible bad performance.", - pcms->max_ram_below_4g); - } - } - } =20 - if (machine->ram_size >=3D lowmem) { - x86ms->above_4g_mem_size =3D machine->ram_size - lowmem; - x86ms->below_4g_mem_size =3D lowmem; - } else { - x86ms->above_4g_mem_size =3D 0; - x86ms->below_4g_mem_size =3D machine->ram_size; - } + pcms->max_ram_below_4g =3D 0xe0000000; /* default: 3.5G */ + x86ms->above_4g_mem_size =3D 0; + x86ms->below_4g_mem_size =3D machine->ram_size; } =20 /* --=20 2.43.0 From nobody Sat Nov 15 10:54:05 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass(p=none dis=none) header.from=nutanix.com ARC-Seal: i=2; a=rsa-sha256; t=1752137747; cv=pass; d=zohomail.com; s=zohoarc; b=YhUEyOy10iaSL8lB95d6+cG42dXUl8qrQ2+MsckqezoHRGzOA0Z4Sh3uR6LTbanWlwoBvdDVUL5W7Og8e6XTTW2hgoIWS4dOImJxX3oDuzGFslzjbQexRN01cvLzZsA+B3ENQ2F9NSshFki8uUxSoS4rXrthWWoz2otIitIn6fs= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1752137747; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=pm2SRgwQCZ9jiWGwZWNaL21zne5VUj0SrW3LuVusrG4=; b=A+Cx9Kmzt2oIiC0ywpZAvu7H1wwLS0BtRVwhgmzp7Q2qJXuoS3rDSU6u0XvMnJVB5kYU+MXfuiwn9K3sq7IRgJCVNoI8K4hNy1cRA/bekLDABofgF7adriK29ALYUnryjrobwQnpJAL7wH/XJJYJ2TZjfYHJyqUCt10GsmPJXrQ= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1752137747738585.9106749855789; Thu, 10 Jul 2025 01:55:47 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uZn2T-00084t-TG; Thu, 10 Jul 2025 04:53:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uZn2P-0007sf-3t for qemu-devel@nongnu.org; Thu, 10 Jul 2025 04:53:53 -0400 Received: from mx0a-002c1b01.pphosted.com ([148.163.151.68]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uZn2M-0003YR-1m for qemu-devel@nongnu.org; Thu, 10 Jul 2025 04:53:51 -0400 Received: from pps.filterd (m0127838.ppops.net [127.0.0.1]) by mx0a-002c1b01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 569Mgvbw018518; Thu, 10 Jul 2025 01:53:47 -0700 Received: from cy7pr03cu001.outbound.protection.outlook.com (mail-westcentralusazon11022103.outbound.protection.outlook.com [40.93.200.103]) by mx0a-002c1b01.pphosted.com (PPS) with ESMTPS id 47q3m150kw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 10 Jul 2025 01:53:47 -0700 (PDT) Received: from PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) by BN0PR02MB8048.namprd02.prod.outlook.com (2603:10b6:408:16a::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8901.29; Thu, 10 Jul 2025 08:53:45 +0000 Received: from PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88]) by PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88%5]) with mapi id 15.20.8901.028; Thu, 10 Jul 2025 08:53:45 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint20171006; bh=pm2SRgwQCZ9jiWGwZWNaL21zne5VUj0SrW3LuVusr G4=; b=G2sX2cSmyDj3zphsybQ2s1+4DnLk2eVXfJOd0iN8tMQnzCLfWhwEjKt7m 6A8362vR2OY19Eml6Esja/m5MDfPuLlgkKrIzdzc8aTmfrAW/AyPogeng9waiJ2v L17SezzTPmTfDTgGJD6bINt96ykbAGDxeGpBTqlzlrcmZNPQ6D2T5cIwHNq/EJQP t79KMrAAXWblciLF72GPKYRKIDvgA1p3QwYfyh5PgmnToTIECEbJEnVMJljWTjus +nGamQBiivLFRWJ7lZ1fHFDTUBodpghrxkNgR3A6yHND9Er7dtoc6j057Nzn2IPw +1dK7p2Hqevi8/ZI6MnNxb/r2XvPA== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=wek8i7YNiJ0JBw/1sCfzE2y9X6/B58xFuqDF612R0TZs5HRUnM4qopRTb9yek4zlQPUYW9p4/fU9V74hUA8iSTsZBd9gz8VMRhdTMI6pSRTar882/7nyOnXi8gIqyoekJHIdG8gQEAwjC9WG90Eamy6pbO3t/u6P1yzdocX47nEVXv3gl21AIEBIOeLoHndu212gAMavDn3LJtSTv92pFAflBd0Bng/qeDe9SL47OI2pkessMO72bSx7uZ8ssTz82XxJ22ezIlqDOmTAwygjQnaGDRAe0gJ9td3GCE1pCjSU5q/GUIsmLx05qLxFdoeDxFjKrTM7y02hMwjCU3smnA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pm2SRgwQCZ9jiWGwZWNaL21zne5VUj0SrW3LuVusrG4=; b=jc8jDps1QTKaPyjWTHL+fdsnk5NjIJaLKJ0dcsv/2cq4y7mAr6bm27gpyENHyqVr5oMR8TjEf68m8DIBQOxxnlsx2yI2bOO6JHoSxWen9l3FwaYSxyRmlfo7fxbwv/9m1D6FbVaCy1lLVR4FTSm0Np7AEsRC/Sqgq1lU+CEV//VTQXBmVkHWitO68oIod4zPCtyPqxsJ7/dWKuGsN0TF7iTFtaPFGKELhe2Dou8VTdrdcmWNX7Dz2PdM0Qe84NAuWcQx1Bz+8EvcCB+6Mk0RQtkCrclHbDNf4OGTI//hMfeveJkR6ey9vFBwzhUzatD4Jbv28JOdGojQ7hcR6Lbgpw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=pm2SRgwQCZ9jiWGwZWNaL21zne5VUj0SrW3LuVusrG4=; b=CUkjcL/a8bJzBK1YVWoxYl+9RbiF07e6M4szDkdGhw11xASgC++O6pDn1MVG0x1pfX+d3zIW+Yt4Ydd82eoN7I+bUmF7uDATIKSWzdgoxOzs4+2xdxHSjEtUPA/JNU2t8s144fdkQgcTrj0cL7f6q6FR6c1r9OE08B+4e+7WUQkEDjIIHpbYPlMm7kIlrYwglQsecXeNSrr/av2rkQrInhOwFFfGOyBEO0SFfwmUs9NuXRWgnE01nT2wPrWnyYQpQFh8H0PuLSohlOqb9E++nyRVHEd4xq4+gdWf0VLsmqjpNw/grRlLfg5RtGLj68bHpD+jRKXkwUPps6Q7ZK8Dow== From: Mark Cave-Ayland To: pbonzini@redhat.com, mst@redhat.com, marcel.apfelbaum@gmail.com, eduardo@habkost.net, imammedo@redhat.com, qemu-devel@nongnu.org Subject: [PATCH v4 09/18] hw/i386/pc_piix.c: hardcode hole64_size to 0 in pc_init_isa() Date: Thu, 10 Jul 2025 09:52:24 +0100 Message-ID: <20250710085308.420774-10-mark.caveayland@nutanix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250710085308.420774-1-mark.caveayland@nutanix.com> References: <20250710085308.420774-1-mark.caveayland@nutanix.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AS4P195CA0042.EURP195.PROD.OUTLOOK.COM (2603:10a6:20b:65a::16) To PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR02MB7159:EE_|BN0PR02MB8048:EE_ X-MS-Office365-Filtering-Correlation-Id: f3171dab-7461-458d-ca22-08ddbf8f4748 x-proofpoint-crosstenant: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|376014|366016|10070799003; X-Microsoft-Antispam-Message-Info: =?utf-8?B?Vi80NVplRklydUx6MEhrSlRsRldJUjdyK3cwWTVpSk04RDhJQnJqcHh3Zm1S?= =?utf-8?B?T3ZkQTh1RFFLcWlITlBjTWg0aUhGQjNMLzdwL1J3UWZ4VHVFREdOZjB4Q1R0?= =?utf-8?B?TGtTRVcycS9vYWVJZzB5ZnJQTEhyVmRNL2R6c3BXdjVDeDJiRkZPd0lUbU83?= =?utf-8?B?MkVlZlUxalNXaXlnU1JxT3ZLSWJFWlIvZjFuYzVSVHdWQ3pBRHp6Qm5vSU5H?= =?utf-8?B?S1h3S0FwNHY0dURnMFRLRG5SM1RQelFVaHlrdlV1RjBteXg5RTRLTmhHd05x?= =?utf-8?B?UmJMR3pFZ2ljRlBQcGxwSFBIaEhzVjIvMFZ6K2dTdnVUQnFacy93a3RpdUhL?= =?utf-8?B?TEFsRzdKd2hoejd2a3NaYUw4QzVsSExKd3lQZDVMSzdZUGpCTzBrSmZCSldk?= =?utf-8?B?NUQ5OC84bzd2eXRSWHZaZ2tqZ1RLODdlRWJQNERSNWRacm9vODdSN0o1Z1Qx?= =?utf-8?B?c0puQVJWckFteXd1d3ZYS2xJbldDL2JWY1h1MzloOFdYRWQ4NjZBYWdqTmtM?= =?utf-8?B?VjJzMkU2NFNHMGd2UW1zcnBmdW5XY1FmT21mUXZ5alVuUHAweERKOTdFbGFp?= =?utf-8?B?VXJvOVh1dkd4SGphOGY0RGRDWVF2SjlPcElscWp6aVpHbGFOQWhVVGRWUTI3?= =?utf-8?B?RTcyTTRKSVlQMk5ndnJnbDdnWDB1MVNtTTQ2KzBVdHcvSUJpUjdPYnB2Mk9h?= =?utf-8?B?djNnaWNxQUhDREorVXR3VEUvT0lKM1ZOamJxeHBqY282Y3ZoL2ZTZXhkdE13?= =?utf-8?B?K2ZOR2FaUGJnSlhjelYrODRZVU1tRzdPUnFVbnByamVTVnhHc1dRTStJMnRq?= =?utf-8?B?Q2dVMWlhaDJNcGZFN2oxNDI0UkFacGxKdUJIbzRqT1NqUEE3cS9ub1hsWFRi?= =?utf-8?B?ODlGZ1g4c3ZWb3ErNE5hMnR6K2k2Z1o0VU1KOXhFWXVZK3R3aFc1NEJnbnVE?= =?utf-8?B?WnIvVC9WWEN3cEYwZCtERDNDek1RYmlwZWVudzQ0OGFmVXpqdnhrdmtSRjQ4?= =?utf-8?B?NXA5bk52eis1U2I4M2hCQytYRENNNEZCT3pEdjNyK3FQWCtHV05aNzFxZkVi?= =?utf-8?B?S2g0Q2pJUzQyLzZMRW9YVDhMc0VMMWUxSmsxb3lwQ0Nvc0tpTzNzNGR2b3Fx?= =?utf-8?B?dFVjUDcxZHRHUzRXSlNkeEd5RTRoNlVrNnBJYWJCTFoyM0xmRnZjM0Q4TSsy?= =?utf-8?B?aE9jVzlMZ3RsMjBETVYvQTgyOVFMbVZ3ZmVyKzFQWXI2K0JmTWNOTFI2RStH?= =?utf-8?B?cWwwZERaVFluelBVSDBjN2FPTCs4VzJiVVBiek1sYkhyNThGNEo3VjYzTkdi?= =?utf-8?B?VTRYUXg0NTZlY3FRZW1Gek50R2l6VjBPbTg3T241YnMyblU1cFVBNlBHZnc5?= =?utf-8?B?cTFVbVA4TWRRQ2tsak8yRnpDbmQwZE9tbXhUbno0NXNCaWRkSVF5N1NJdUla?= =?utf-8?B?NVNJcVMxNXlSOHQ0NDljK0lYTHE1NnpWZ0tHYkN5cGdWNTFpNnFYcG8yc3Bl?= =?utf-8?B?SlVGWE83OUwrdWZ4cWtVOSsvK1RZYzgwUVp3Mk9qVDlFVDNSVzdGNUZXOUN1?= =?utf-8?B?WWg2WDAvQ0tJQjZKcDMvS2xPRGhTM1hja2JYdERrTUZIZWtrMjMyTVVPVitx?= =?utf-8?B?ajlWSC8xbG9QTVZJZTAwVGJnaTdsMTRmM3F3Szl5U0YvNDJNTEJiTEdJRkpC?= =?utf-8?B?RnVKRkY0NnRvLzFicUhEanlwbk8rWmpOL0Z0TnJoZ2FPai9WcVNGSXVMSnNW?= =?utf-8?B?TGtKZFZITWFrK1ZRaDllQzh4UXlDaEltOXpCZjhQMVZVdGxNdlN2d204R3E0?= =?utf-8?B?TGdSdnhWdWR2elo2b1drWE5udkJqOU5sci94bzdITm11THZNSm85YmpDbjI3?= =?utf-8?B?UkNlS0V1dXd6RndzdGhibXMwRkVDdndDRGRUeUd4RnJlUUZMUjdEc2RTWGVq?= =?utf-8?Q?cIZbpMBB6y0=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR02MB7159.namprd02.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(376014)(366016)(10070799003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MHVGMnlHeGFocElmSXQySEJVQVRjeEV6TzRHOUlHR2loanZmL0ZLRDh6aC9p?= =?utf-8?B?cms3U3NvODltT2xvZmRvK2xkVGhhQlN1dS8xTGxQVWxRMXZhbEc0dnRSeDdW?= =?utf-8?B?NXhBODBtbWlGR3dZSmZPMkRUSVhWWkhEUWtJR0ZFVlZodU9jNmpIN0lHL2o5?= =?utf-8?B?aEdMY0hsakFzbjhrdnVmaUVNSWVPeHA5YW02WVN4VThHeWx2NXIweHZSRXJj?= =?utf-8?B?eGNHdGtqUmdQMEVFRFNVTGJJa0liaEVJMnk1ZDBWUm1SS3BkZDJtaDZhUmhT?= =?utf-8?B?Nm1WcjhXWUpWU0t0MTdWNzNHMVNGT1VBWXB2L05jQTY5Y3FYRUx0Sm1Yb1Yz?= =?utf-8?B?RTVGQXpsUGp3VGl2TXF5dy9oTGNsRitKVTdsczZsakFSZnBHZXBoL090V2g3?= =?utf-8?B?MVZBc2NLV1M1b1d4UmE1UE1UcWFkdHVNNFdTVWxhWmZEYlZPcTFNdUFuY0wy?= =?utf-8?B?ZWZhMG1jYWV0MkJWL0VCRnhFR09maEVCd3VtYmZEcFEvMHZvems4MS94cTFX?= =?utf-8?B?ZUI2NzNRMXVYVjY2ek9NWWNTUHVKNWlqQWNYYmpwMlo3OWRtQXlGekZLQndo?= =?utf-8?B?M0ViNmpLTnhmNE9kTGhvajMzcmwyMGpLcEhpbUpSV0pPdk5hOUZiM1F2L0pF?= =?utf-8?B?c3MwU1FydHhBTUtiYXRTRjJzcmRWZ2dQeFZ3dVB4Y010ZXZnNXcvQ1FZZDVj?= =?utf-8?B?VFk1ei9ETlNDQ1UzVG82enZIMWRzcitWVjBGdHNFSEJjeGhjeXR5NGEwMDlp?= =?utf-8?B?TjIycGRjbkp3UWhZTDdrYlJ2ZUJ5MzZobjZ2T2ttaGk5MU9nNWc4OE9qMjla?= =?utf-8?B?a29OWi9oaU9Yd04wclFveU94U2syT3Izdkl3c0hCV21Pd1p2UFdyMUY3YXE3?= =?utf-8?B?VHBSQ1lsUCtrNDVzWk9ZczJsS1BMdUdRRWVrd0pUQ1FVd0lYbSsxV2RYT05U?= =?utf-8?B?V3J3MUs3ZjBvM2x1elZZUUdSelRicWVrWU9wcEZDc0xZeFVOakpOVmVhNlNr?= =?utf-8?B?dTNhWENFOVd1RnpDY095QjNsSXZ0QXFiakZGRTRVclI3eVBINXpXNFFqQ3Fl?= =?utf-8?B?aFlFdGhhZThyNWR2YW9uNjlaQ3VvOTBxaXY5T0U4dTM1NGw2eVR5dTd1MkV6?= =?utf-8?B?cEkzbVN1a0l1N3lYSDBBSjB5eW9ObE5OOHZqUXJWV0YyM3RvdkYzTGVJMTFX?= =?utf-8?B?ZU82Sk5Fb0ZwSEhXWkU2Tk9NTit0Ti8vNUxVNXBZazZMWm5uYm90SURLaW9n?= =?utf-8?B?ZmVDdXVFSmtFTklZZWNBazkrd2FYcVFPYTFtZ0J3SVljOUthYzdRNGlaak91?= =?utf-8?B?RGVXOERRckZkb2J4bEs2UU9VRzF0clQrT05WTmV1b3ZRN3N1bDE0TnFBUXJy?= =?utf-8?B?SkJsMWk5QWlGemNCUjg4d25TMEwrek90a3pRMW1qTzFER0s4cHFwNGJBbVNw?= =?utf-8?B?cENuRDl4STRpMi9XdmhaNjRrakpzQm42eGthQ1VtcHF4SFdJcS9pRjczNFA2?= =?utf-8?B?SFJzTWVOblNxQ05ybkdPOTJtSGpCY1Bsc3NaYlNuTXV0Y2kwdjBJN3Z2a3o2?= =?utf-8?B?M1RsK3d6eExFN3ZPaXU0bDNYTkNQRFNTbm9tWEUvdkVEQ3ExbTBWMjlDN09X?= =?utf-8?B?L3hoemFUTUJwc0RsblZyQWNUUFRFT3hyajNFcHQrT2RjZzFCMmcxMTJDZ1pK?= =?utf-8?B?b0NFMEpXc3lhR0ljdXI3TDd3Uk12Szhwd0ZBSVlDM29hLzFpeTNyMGQrQ0lS?= =?utf-8?B?aUZSeW8zVTBicWU4NjNSV2kvMmkzVFE1MGhkdmZ3RWo2TUF2VVdaMXl2SzRk?= =?utf-8?B?bTMwWHJVNGwxTkltMENHQUdoNG16TExqT01kSVFjZjFqcTl0NzVJN1Z5bmlw?= =?utf-8?B?cW0wYnRGV3Q1YVFObzJKbkJmWGV3OVI5TSswZWkzU2YvWkxYQll3aDJUaWxt?= =?utf-8?B?YmNFc3VqelhKYkgvbzV4MXVtN0xXK09RdW44MGtKU3lNWEdxR2R5WXdGazcr?= =?utf-8?B?SndSK0hwVml4S2grUVdMTyszTWh1OFUrNVorM1M0aGRueWllS05RZWVQYlho?= =?utf-8?B?Z1Z3RnJtU2lkL3JzcUwvaWZkSXd3ZXc0QWpvLytBRUlLSXJTcS9GcDBVeDZI?= =?utf-8?B?cFhCc3duQVZwVlUzNjZaUkhBNjd4cFpZeFJNUGE3RTF6WlNiM0U0M09uSmlB?= =?utf-8?B?WDFDN09uN29oUjRkeHE0M1lJN1BzcE1HT2xOSlltVTRUL0R5UzRLNFc3eHZZ?= =?utf-8?B?WE1VYVNwOStGUVB3Z1dmbWtFVG5BPT0=?= X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: f3171dab-7461-458d-ca22-08ddbf8f4748 X-MS-Exchange-CrossTenant-AuthSource: PH0PR02MB7159.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jul 2025 08:53:45.4691 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: gF8ghrqLUEem5vWLl3iejGy5z0rM1UH51oQLRuQrnL1Zf9QIMx7URX+akGzxn9quzFcMkiiDfWcFOxV31f/EFj9fQmSqP0NkBkp6wsclXXY= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR02MB8048 X-Authority-Analysis: v=2.4 cv=Nffm13D4 c=1 sm=1 tr=0 ts=686f7f9b cx=c_pps a=NRt2x9XRVm29nzkZGme07w==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Wb1JkmetP80A:10 a=0kUYKlekyDsA:10 a=64Cc0HZtAAAA:8 a=KKAkSRfTAAAA:8 a=aqeCdxMHYQgX1PSeTiMA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-GUID: Y2I9djKr7bSLUkXm4C3lpAcAlFWaZZTP X-Proofpoint-ORIG-GUID: Y2I9djKr7bSLUkXm4C3lpAcAlFWaZZTP X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNzEwMDA3NSBTYWx0ZWRfX7Wo6TEcg91yN WxP+fNmfL4R5zD2yWgoPGXh3qYrw/OQRhxWUhg0JF/RlOc0895pUJuwzgS7yiXRSRiVQgdzzyrF DGyaSQnVhdyb1gZxKT8uPIGn0DMJMvrMmTZuIhwnRVye/3tkGHiVS1kBJoqGXM7DBW0POc6/5Y1 PXcS5ALBPn/wMo058MpT/VQPFKsVbAYiDYp/2GD+/94QSBxeuznVegM2MEX1gUpb0kFsWlhqWW5 /ygrtYj/B+HXeDYR/oIhlrMv/wmVFj7cjlgQpMGYkhZ2iF000ARdJcY2r5uMffYma28NibrDZyS 6BH0/LHQtDGDljTkiAlRrBjpci7/YlE+lEUio0Ctd37JYDWXm5XXbyB5P5FH6ogbLtSAjHAkdg9 jyO/sWvnLi0pTU0DF/I7/LWMmLc53hpS7v+tEimXJDvgTt1WRZGaEprVL6aYnq9ez5kiGt6Y X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.7,FMLib:17.12.80.40 definitions=2025-07-10_01,2025-07-09_01,2025-03-28_01 X-Proofpoint-Spam-Reason: safe Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=148.163.151.68; envelope-from=mark.caveayland@nutanix.com; helo=mx0a-002c1b01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @nutanix.com) X-ZM-MESSAGEID: 1752137748614116600 All isapc machines must have 32-bit CPUs and have no PCI 64-bit hole so it = can be hardcoded to 0. Signed-off-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- hw/i386/pc_piix.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index 80e4ed8c87..48d0b2f5b5 100644 --- a/hw/i386/pc_piix.c +++ b/hw/i386/pc_piix.c @@ -426,7 +426,6 @@ static void pc_init_isa(MachineState *machine) GSIState *gsi_state; MemoryRegion *ram_memory; MemoryRegion *rom_memory =3D system_memory; - uint64_t hole64_size =3D 0; =20 /* * There is no RAM split for the isapc machine @@ -461,7 +460,7 @@ static void pc_init_isa(MachineState *machine) =20 /* allocate ram and load rom/bios */ if (!xen_enabled()) { - pc_memory_init(pcms, system_memory, rom_memory, hole64_size); + pc_memory_init(pcms, system_memory, rom_memory, 0); } else { assert(machine->ram_size =3D=3D x86ms->below_4g_mem_size + x86ms->above_4g_mem_size); --=20 2.43.0 From nobody Sat Nov 15 10:54:05 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass(p=none dis=none) header.from=nutanix.com ARC-Seal: i=2; a=rsa-sha256; t=1752137872; cv=pass; d=zohomail.com; s=zohoarc; b=KxuZBpLxQHCExT/I/NspjHHviOsoiitS29uV2KQTwo2HlrVucHmwYL0ub+GzAvwRIBGaMjtnzGo+YSAcx6cw4ndyAOpIn+CM4JyyD1Dy8jJtmm0FxQ1+AFM8vXjklULaqLBsO9XwemLKQGNdjn8AP91PKQNdO7iJm7Db5p0d7xg= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1752137872; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=q3jsS/WCSFC7H70BMqgDzBvpReJeR5JRJpOazWCmVRM=; b=bcDP2jkb2mm8MT3V/pKOuJgmBOd/oBb7CdDpPSmZnfNwKc6/o4zWYsky/k9a48fHCuWo0yJk+8DJPng82gOErO9iqc4+AYWGmaj9QY+g+d8VLBUZOa4wC+Fdcb1fmnRQQbSIhkPkeDZ/c6yOKkq3ywg3oEfS91CkA8YXhY3n+wc= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1752137872106528.8223464360428; Thu, 10 Jul 2025 01:57:52 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uZn2V-00089t-QP; Thu, 10 Jul 2025 04:53:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uZn2S-000805-Fa for qemu-devel@nongnu.org; Thu, 10 Jul 2025 04:53:56 -0400 Received: from mx0a-002c1b01.pphosted.com ([148.163.151.68]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uZn2Q-0003Ys-De for qemu-devel@nongnu.org; Thu, 10 Jul 2025 04:53:56 -0400 Received: from pps.filterd (m0127839.ppops.net [127.0.0.1]) by mx0a-002c1b01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 569ME8IM010890; Thu, 10 Jul 2025 01:53:50 -0700 Received: from cy4pr05cu001.outbound.protection.outlook.com (mail-westcentralusazon11020102.outbound.protection.outlook.com [40.93.198.102]) by mx0a-002c1b01.pphosted.com (PPS) with ESMTPS id 47rkcn12jy-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 10 Jul 2025 01:53:50 -0700 (PDT) Received: from PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) by BN0PR02MB8048.namprd02.prod.outlook.com (2603:10b6:408:16a::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8901.29; Thu, 10 Jul 2025 08:53:48 +0000 Received: from PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88]) by PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88%5]) with mapi id 15.20.8901.028; Thu, 10 Jul 2025 08:53:48 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint20171006; bh=q3jsS/WCSFC7H70BMqgDzBvpReJeR5JRJpOazWCmV RM=; b=wx/vWVlw162xEIH3/oIYvv54J5pgC76ZcLOKN5v9LR0TE+KYfa+MmjJeM XDvQSJ1EYyiOmfm1YOz0Fw/oQcY0zb0zhQUxtkWfZfq0+vOX9+JDbTiRA7OpHoon by0sjqjE4beT4hg+BQG/Dp0AmmWNhu4CPAHp2a8F/MEek67dBfQeuaPUB3/2SSrK JfTZI1NiRbYHze51mJSCj87F2BDfGeTGoqhPER4IrSxJjqZkyFzt0kytqWfjpm5D EgB6xUytnrZfW15P9+AFUooZWK+4wG5QKixJbVnp2dyPu0F76xBbgD35R4ngcyVV 9dpvIp1q8oHd3KLm5iOo6j7HRHEJQ== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=g636X+ATQOTPg5KuNvYZ9Pu+h3sLjecJK5xjvFgKBTicFXRS4cnEBS1W2gK0bK0dXNSFDfYL+qgvYQJnq8E4XXln+T2k4MLZGQfti+NGCBvXTzXwT3y3IDNSHIp5XRSB8eqvCQ1PpON9Shph+asMZRXaKXLOftrpzLXzhhgC6aWP97UoHVnU+RREh77YNStMlANo4uVI5LIaduu9YERZ/1i8wBbXrEdATrO5mgvGu55OqjOD/1OpVGzGvFNwc7qm01bPnqjVR40swjY1+U9hhl7csYqR8nE7lO6mPlh2XvaOS+Q3NyRiQYVigAVh/bLwdCF1PKFK6lpU2tvIjxC1UA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=q3jsS/WCSFC7H70BMqgDzBvpReJeR5JRJpOazWCmVRM=; b=Ozt6WxL+1DtT8aZK6AsPGvxbsa00NIXEjFMBAISz7mG3xQ9M6TtsRQIusghTWiOfFvH+D3CbHG7yIQHelKkzFLPICqbQ4vApP9FlC+mwZRkibhciLKhR+MhUOQD5IXmB6JdKvBzdS0ZqOO9bDkBq9203acmtHQ1m0V96KthRpT11l0x2CMHjRns2zt+J3CrgHdKpSA1kzGS+Fn8+2eiVlS2T9kFqTtfB9FP83JwZqO1TRyyBxctHiOTicCeIHfLzRlK1llNtIh670khgw+DNysGp7G8pvXELpTNEVO9EJVXjUGR58vNbwJ+YBge7qJqc146A95fnUW5pdpr08YZMxA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=q3jsS/WCSFC7H70BMqgDzBvpReJeR5JRJpOazWCmVRM=; b=OJUyuxO0iAnLaDFJFxyrGsoImwf2pkT0MwWP1kgW1bQ5H64HNCHKfYJt8/P6NWeJ3uoWiz0jx/SPLFIXddEz5OSx3EwL6+0B59lUWbRZcEjAcfxvqluDYgYDFXwJwGA7OPIXkReXXbbUzxq2QFXn/FysFbAhShLrycumdSfdJy6BHsX+/cMC89hkHOp/mTQcQQZAYZcTDO2tY1jpXoSMt++8EYPIhHKWyW0LHTlswi0HZOQ7wWdlG78QqdPI2SYvpc5NuJ7aaHavXhjwHYfI4NSvJv19UpKWK6x/eaqmonXn5AavIBgBfRfQJk3Z23+tlVNGmRANNEPLgbRbczEMIQ== From: Mark Cave-Ayland To: pbonzini@redhat.com, mst@redhat.com, marcel.apfelbaum@gmail.com, eduardo@habkost.net, imammedo@redhat.com, qemu-devel@nongnu.org Subject: [PATCH v4 10/18] hw/i386/pc_piix.c: remove pc_system_flash_cleanup_unused() from pc_init_isa() Date: Thu, 10 Jul 2025 09:52:25 +0100 Message-ID: <20250710085308.420774-11-mark.caveayland@nutanix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250710085308.420774-1-mark.caveayland@nutanix.com> References: <20250710085308.420774-1-mark.caveayland@nutanix.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AM4PR07CA0029.eurprd07.prod.outlook.com (2603:10a6:205:1::42) To PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR02MB7159:EE_|BN0PR02MB8048:EE_ X-MS-Office365-Filtering-Correlation-Id: c340f9e6-2532-4118-60bd-08ddbf8f494c x-proofpoint-crosstenant: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|376014|366016|10070799003; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?Dp2ShkTdZ9qZjXbd6u0H4ACBydN+PMheWvUXPIHFyj7o/gafKt2pCO+bzAG/?= =?us-ascii?Q?EnDX8v0TX2l1qsaTWQmEY7tsRNVCSaekfBfu6z0MGp7bcTAuN1F/p7HqcXgu?= =?us-ascii?Q?lSnMI4OcsCDMWriubUfiViVjF5a5xrHX5vEsxZvIwwM+FGx1/KRGCQ6Xg14H?= =?us-ascii?Q?jcJLOIdC7kpFCDguuLtX7/SlvFku5kpz1X8Zh3I6Z5uD2b2h7v2dRbA5EcsV?= =?us-ascii?Q?zL6egYOEM/aLXItCn8YcKC8A7GE1raVEpWcA+SkXbtyephMxWNKiUyp1rRSl?= =?us-ascii?Q?2PEeyqoQkoDaIHWFDadmqBTM90kXLBxrdzz0APzT1bJCJAMIF8w9mclkvSlt?= =?us-ascii?Q?yk5YJYOgW93q9FsR9Dotyz4Y77ron6D1sB7GYg/O/Xx27LXuS8UR9JEerQb+?= =?us-ascii?Q?EJ7nQKIGZuET260aTZQub3/7pqtNuoD90cX8oY/FxzGv0T/ytOg6RTt+8z4M?= =?us-ascii?Q?5ORNTfShcPNl5097I9lffjubxI6L7uJD62pR5IKIcx9aA8GDIfhDnjnAEDrL?= =?us-ascii?Q?SkMk/S7GK5fKIeDkrA5ZEAVOHHU+HVY2XrCDyhQL6VA832HYZQntM8jaNIKP?= =?us-ascii?Q?cjfYlmny1UHJkGN0EF+QOvvuHgMRFUl/9KBAceK63afxkmtbIhtKLMxezSL/?= =?us-ascii?Q?QIOTHlAx7tb2wxcyYv5germI06iYwybh1lfRgN3/V9takhhgz6W5Y8sHSFV5?= =?us-ascii?Q?0h0JLNWZ0UfnSxx/EqzDDjV5AOFhtXpUCXJNUkYgA/SYhaNCDjJUlif8LUvH?= =?us-ascii?Q?FyvKZRdlTSdtnNfTPyU422ilJK6MQnhADSMZ0GFj8KsVSjYpQtRB5AOu1jNa?= =?us-ascii?Q?tnepiOzD8tiF4do+6ZdbhO5D1l7Do9jn5t1mO5XBCXd23LRzsJYZpNbDddYG?= =?us-ascii?Q?rEKzKyceXDUxaBOUhrzL8vYJLWRrl8t7+a6+CXmWNStfANU3NKd8IjlXrB06?= =?us-ascii?Q?eA4VLcntV5LkPYFL5esmrxEGcLZ3b9kwYFBzlcBdX0kuAKedpa9ZUW7Wq+ze?= =?us-ascii?Q?cOdKKNhSSjtFd6FZKe9zyeHdM+NHMkH6Y/SYxaLLjQOVEHVo3SbgvsTQZqRW?= =?us-ascii?Q?JGy4C3M1tBfoMHvMAikfqF2wT1xQ0ezBnXg30aZPXqcPSZJLOkzzn7rOPeYU?= =?us-ascii?Q?5RyZuanjXFlw6aFSYvqO3a0q0rqxEDeY2DXJS8/jmOcj07RiIxGPQJ22PX3W?= =?us-ascii?Q?sFDvwGgpjyERloeeJkq0hmhfihtoboavVP9t4sCsyzH0WVUkGoZOnt+w02U/?= =?us-ascii?Q?jotAOMcj2JAOA8YTNjkZqC9A23ifJbFAXnm83Tl6OlWREhRiuZWlKkVNaZCB?= =?us-ascii?Q?U3YsVpWYasJlOKBmwalBxZqgzzRPTQoyPMfVYMwB6w8TPkwFHJrqWf+zLwqo?= =?us-ascii?Q?1uxyErsIG0dxWuCwjeymPc/k+3rvJLUnAT905VH01PooaSPlSDyT7WIBRC3O?= =?us-ascii?Q?q32W0auaijE=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR02MB7159.namprd02.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(376014)(366016)(10070799003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?3t+gx0vw8E2YRto8MP1wyskimkHO3Xh1ZHgUWLCU9zMoZtQfdDxKH2/jC1W0?= =?us-ascii?Q?crJqgZnfve8bKlTH6Sg0q+op2IoTUv2agZQuTnjaOIBAoKWNW9Y6OyLzJfnV?= =?us-ascii?Q?o/OjGgKCmZ8mWLezyqeQA7eugVN+LEVXjm1+iV4mtajjsqmtJG4w393igP5+?= =?us-ascii?Q?G8nX2wc5NDZtRwOis9ixlB39sFjTzP68olzmLhSP0CfZlwE0GTgxaPs4jvxd?= =?us-ascii?Q?sQmwICkYj+NiemH9ODMe8c1YzRfvlGbpsc2ogCu3z1eVT+Rdnzcz4SAvjlxv?= =?us-ascii?Q?qYKh5nhjDU3kcjoSmoySIF5We7TROiGFC8GR7hHeB2pwhSO5EXgsIOqyRVoR?= =?us-ascii?Q?leGP1tvRN3ROuiLKN24V5ZUO/dEs8cMsgTiHwBmHyHb1qLKciNGZrSVYc2OF?= =?us-ascii?Q?pPB/rnysv8aUbXPPdjaI6URLNztXSEXQKpLF6B1NUySgOeWto8iTmzyThcHK?= =?us-ascii?Q?ACDdcxLr2fY7L/4pzY6WMBHQvPifZ46p3JfW+TJQ/d0QNMh0EO3MCrtC+P6m?= =?us-ascii?Q?nY3PUrVR1GSwusYClu8w6ex0q6oSSnsXvDpDYEsFI4vSkmvUEaWVO/Whr/jF?= =?us-ascii?Q?hAs9f6EmMVHGgM/sotq6xys1TdU9pj9w67n08QKRpW5wg3lEFHmqOZwKRWFg?= =?us-ascii?Q?gOTzkT9TdmctIWup1K0/dVzlcOTwG6jQqYi8wl6TxXfohQhofS8KjY99Hwh5?= =?us-ascii?Q?ae/2ZHSl5YiD1MHSKlQRRCmuMZSg31ZIPjjZ5WkFsYCM5O9yfUWTOba+KEyk?= =?us-ascii?Q?uOUQpSTsONG+m1wfP97AaegYY1RPsvk3rSF2/r/P4gyAOve4KqhKgs33DmN9?= =?us-ascii?Q?8UnPjJ8QzxyRFfMonSDnpkT/1fYz3+eGyB7DkV1CLvSj2FbPkgZH+9TEH3Mn?= =?us-ascii?Q?xPVFh64AcBQkDJm2rM4PPlxw9KatD/fnXvSRhkEBAnmQFfVP6SUNv0o3dINK?= =?us-ascii?Q?fxbMyRELjnoqhlkJ1mDnI/fuVGygXt1vJsZK5IydDUHCVMm+PArbkrZCjIw2?= =?us-ascii?Q?7IY19Uy/V4Z4NgZlSFaQTNgAUsVF3nP/45MWfixmbHLAQpSyWM9nLu2ONJt2?= =?us-ascii?Q?YuKlvRzxT+X9Ktc/gk04rK/YOoFFLcJQWBVoz8KRC/UujrI5xhjFpCvsTdVY?= =?us-ascii?Q?+N/6LNlzROmDAZ3zQj9pZbqNCYw1S27G7W/o57AxnnsmaxAoU/OdrMcR/hOu?= =?us-ascii?Q?lx0Z3IGMA8/UGnWnIzrCWObjOeDkoYJKliUnocQAhrJobJweueS1S60bcily?= =?us-ascii?Q?FX8Na72pp/NpwL+av+NyBFeTMPqArK825vl4tLR7KxzBqda5ki13bClaUGpl?= =?us-ascii?Q?S0zPe2npoYDKT9D4HobIpGOVeGlqjg+pvNL2NlfvNd/eI7GSNkKlGj9hXce5?= =?us-ascii?Q?waryZdHfVfW/UUKtGzTEoEGkr7L12WWeOgIPXqjoo9kvuKgug90c74d4ZOcR?= =?us-ascii?Q?zFIEMM6vUgFAxJy2lIjSwhbXjmt1LhofumtRN7Ii1QxHHfsKsbVIvDGb3WQT?= =?us-ascii?Q?NCcjMP6eonccegNAoYRP6ZGi/2GeGryosgmeYabpOeAAl8kDxCXyyNZuIJr7?= =?us-ascii?Q?otZ3eOpup54yeix5IRKuLESrlLgran4e12bwdKIW/Y7oLcHx1f8WYxMWTxFO?= =?us-ascii?Q?3SlMVGoNiEWACNkW7iGRhp21nfVSU4zVCEIfJlKTkGBGILnxepwCWSaZkH7c?= =?us-ascii?Q?V6yWQQ=3D=3D?= X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: c340f9e6-2532-4118-60bd-08ddbf8f494c X-MS-Exchange-CrossTenant-AuthSource: PH0PR02MB7159.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jul 2025 08:53:48.8332 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: UrUqcASEQRui/zsYn3zAlTARFpa2TCer+yXv0zguth5+PtHhXSeq9t94iuR2KFlNHSB63tQXGLXAHnb6fuArKD/no8nX2WT2ABM0xYNYPKA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR02MB8048 X-Proofpoint-ORIG-GUID: Tq3WBmIERHVDGvO-qPIae-xajlp-8sxT X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNzEwMDA3NSBTYWx0ZWRfX7TpbQTtYAx1G 6VTWBXX2/NDBi5NJFmJWCM9xxVdX8+GtCRrAVu0TvL2Q3q3CA1Y1xhDY784VeAJSB3MYTAezCHc /RKLMxTje6avv6FJ2iGdDmUyWHsL9ETksRqmEujl652xwxdALVJFnowF6q89aG2L/jFQw0r37k6 jGDmMt/VaClmpLrz7JnKxUjhT/5OTD1nKZGUgIf69uy9JeSL62X9bMx10uT+Bu2UGdCjFEd2Xe8 AfrEUD0mqkCgA58u4ryivu8JKO/4da6Tqoi6fnReHRyudDDfz/lrodZtn6yDW21+nUj5wbzwHu0 zMRzQO+WfvhXMj7fu8/7lkNu3+CG4BMWGK5rz6f3P1ST0NPJLoM0OFN9SKPQk5sFmUHCpnXJ9V2 qIDqE7Ewch5Vxf4YfE8BRJjlulmLGyPcISPJzbyu9aGhYONM8su1F6MbcG8SdGENT3X4cjPW X-Authority-Analysis: v=2.4 cv=KKZaDEFo c=1 sm=1 tr=0 ts=686f7f9e cx=c_pps a=cPJgcE//urRiG05FhKkhAw==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=xqWC_Br6kY4A:10 a=Wb1JkmetP80A:10 a=0kUYKlekyDsA:10 a=64Cc0HZtAAAA:8 a=mnHwG4yJ6Weg6gPWIr4A:9 X-Proofpoint-GUID: Tq3WBmIERHVDGvO-qPIae-xajlp-8sxT X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.7,FMLib:17.12.80.40 definitions=2025-07-10_01,2025-07-09_01,2025-03-28_01 X-Proofpoint-Spam-Reason: safe Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=148.163.151.68; envelope-from=mark.caveayland@nutanix.com; helo=mx0a-002c1b01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @nutanix.com) X-ZM-MESSAGEID: 1752137873910116600 Content-Type: text/plain; charset="utf-8" This function contains 'assert(PC_MACHINE_GET_CLASS(pcms)->pci_enabled)' an= d so we can safely assume that it should never be used for the isapc machine. Signed-off-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- hw/i386/pc_piix.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index 48d0b2f5b5..f09ec48c0c 100644 --- a/hw/i386/pc_piix.c +++ b/hw/i386/pc_piix.c @@ -465,7 +465,6 @@ static void pc_init_isa(MachineState *machine) assert(machine->ram_size =3D=3D x86ms->below_4g_mem_size + x86ms->above_4g_mem_size); =20 - pc_system_flash_cleanup_unused(pcms); if (machine->kernel_filename !=3D NULL) { /* For xen HVM direct kernel boot, load linux here */ xen_load_linux(pcms); --=20 2.43.0 From nobody Sat Nov 15 10:54:05 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass(p=none dis=none) header.from=nutanix.com ARC-Seal: i=2; a=rsa-sha256; t=1752137780; cv=pass; d=zohomail.com; s=zohoarc; b=S/TM+eZ6vHvTJBMTNPXaHjfIx2o1FV5fyR4Fv0RsNQjZbUIyNbC3oBxcMnKd7v4AEIIgDQajYwVO+UAFDtf8YADnKSu7hXNKTz3HmcDk/Q4DaNuRe2J6lzCIqaO5Nk739gKYq7lpi+fJyBTaOKT6haenH3xFM4K9xujGLIBTdvw= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1752137780; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=9/FOzg2CRIyaEtPC9hpMYUEYWDyQ7Jwfx8nvvv/xM8s=; b=Z4K7hWhulsR655L7SAAFKXjwpNtAVx1XOoEB5ySbw6FLUIV4iq7hYyH+0cdSgAbesGTIvQrh4nsyoXvEvnf3+Dk691qSv6mJXtYrQOc53oBL64jjjLoP9uYo56GaDJuNchZqPnAgYOtaf0q/MRcuD1aJXL6vdKBLMrrsQY6D0+s= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1752137780202599.5751943312911; Thu, 10 Jul 2025 01:56:20 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uZn2W-0008Dk-Kb; Thu, 10 Jul 2025 04:54:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uZn2V-00088r-3B for qemu-devel@nongnu.org; Thu, 10 Jul 2025 04:53:59 -0400 Received: from mx0a-002c1b01.pphosted.com ([148.163.151.68]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uZn2T-0003ZS-4b for qemu-devel@nongnu.org; Thu, 10 Jul 2025 04:53:58 -0400 Received: from pps.filterd (m0127837.ppops.net [127.0.0.1]) by mx0a-002c1b01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 56A7dB2e009292; Thu, 10 Jul 2025 01:53:54 -0700 Received: from cy4pr05cu001.outbound.protection.outlook.com (mail-westcentralusazon11020089.outbound.protection.outlook.com [40.93.198.89]) by mx0a-002c1b01.pphosted.com (PPS) with ESMTPS id 47rkc5s3g6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 10 Jul 2025 01:53:53 -0700 (PDT) Received: from PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) by BN0PR02MB8048.namprd02.prod.outlook.com (2603:10b6:408:16a::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8901.29; Thu, 10 Jul 2025 08:53:52 +0000 Received: from PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88]) by PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88%5]) with mapi id 15.20.8901.028; Thu, 10 Jul 2025 08:53:52 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint20171006; bh=9/FOzg2CRIyaEtPC9hpMYUEYWDyQ7Jwfx8nvvv/xM 8s=; b=OzfmBwOUqWsqj1uk2JMKCz3/euS6Yxw7UEEoy4WBCNbfp666+EOu3N4EW fhG6jvdrlyAZ4z6XuYvE1awhdCOX3JEWyVl3iajH6NftPfFSN3J9DQIsjCI0EzGi QwH2IQFEIv4+ro1KqMZ/p1ki6sIcI8AO4NOHOYrkiC2JMAdDm1In90UG1fOO2HRW wm7Tad7Ss7Pa0N3A7cZsLlSc1NWrL0ChCabwHWJUs4fLYOtByec9UtRSxFEoc5uK dzalUTmLXJQz+wfwuEv1T4+LBCBYZhRZifNf2WjOsCHP2BZqK2RIa+XZgah5EX7p Ozxv2huhpxF52hHu+OLQXh/wo+C4Q== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Kz2XnnvBBmc3N4226xBjxMy1iBzsvx64NeE2+sBW/7OSTTn2IMqxU6qVZcM8ZZmsy9Rxa0Mx7uwvgM+PnoNPpr11E4ha7QI1ZIz3+TEY5YTgPMS2EnLz4R4U6MnwfCIsar0kxsIvnOjrg0Zq+egjXR8rD7j30U6hyOVIxHZ1YLYdp1SE623djsTORaaHXTmAmEfVgZfM0VqvRsAP7Oz8ykjrp+gGBrY+OXJjoXKBaQf59WIHr/wSvOCmoNFp0INoc0Z6tOksj/7LMC0c7mmi2LPCAy3bxVWz+f9jO4av13eTIFetpThVPSbxE9IQpezI0KyNiqUlvjLo+Mxr/lESMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9/FOzg2CRIyaEtPC9hpMYUEYWDyQ7Jwfx8nvvv/xM8s=; b=rOwm0cv1t14tPjoywPvtlU7ea/xcRcHhtQeFo14Bed6WsH6A++qmL9uVgr+WxegOEDQfnO0WP4LjQhLJSbrQBa15+yBRzTb6KziAyqcpofYdUbu1nS26eF34YX7Zz7VippZyFGOMljsDLJ/05Ne8SNpGLkouBxc2kzCUxjx0McwSOk474ga6KTRcuwX/Z08cwzLyfp9B0iIBRXmJAW1SqkptPb5L7l0UF/MGjBb6XZMMYFEeWoF6IPxAogi6oqILmJxeS6FebwgXVchIWpLURbmrw9nBkM9GCVAeT9TlCZrPBv8yW3IJ5EJDB78bFR4qywSoQXlfS+z8YSrKT475xQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9/FOzg2CRIyaEtPC9hpMYUEYWDyQ7Jwfx8nvvv/xM8s=; b=MuThLO8TN/7t+vlCEQ2epvIzkLp2P1zoNq5P1VcopbbIsgEeQXibdot4wYUdNF1Nm9ZTZZ40S21o5HYUU7U0uamzfhwPf8MHPsYs6XtTM8YZHgQiB/Taq23Mxg1GiV5Uy5U+EEUtwlwBnmyIxNoDrvvbW+WJOHbmbhiqn7qzvDtfIPs42hLUQriu1d2aOp83/Ip4bFsIQryzBy9TMqv6ELmfwpCRScvHR81P4dOfn85clvFBMJbZXX+izfDK9YcjScDNrUmp+FZbOsUbKHC+M9SYqMPQlLmpT+1kT88JLGuDyspPTa+302kyyE0Zmg+/5oN0W/YeTG0ZfpitIaJCvQ== From: Mark Cave-Ayland To: pbonzini@redhat.com, mst@redhat.com, marcel.apfelbaum@gmail.com, eduardo@habkost.net, imammedo@redhat.com, qemu-devel@nongnu.org Subject: [PATCH v4 11/18] hw/i386/pc_piix.c: always initialise ISA IDE drives in pc_init_isa() Date: Thu, 10 Jul 2025 09:52:26 +0100 Message-ID: <20250710085308.420774-12-mark.caveayland@nutanix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250710085308.420774-1-mark.caveayland@nutanix.com> References: <20250710085308.420774-1-mark.caveayland@nutanix.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AM0PR02CA0178.eurprd02.prod.outlook.com (2603:10a6:20b:28e::15) To PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR02MB7159:EE_|BN0PR02MB8048:EE_ X-MS-Office365-Filtering-Correlation-Id: b47359f0-808c-4205-3a1b-08ddbf8f4b53 x-proofpoint-crosstenant: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|376014|366016|10070799003; X-Microsoft-Antispam-Message-Info: =?utf-8?B?c21SSzd3NEhFNmNoTUxGbEVMSFhkUXFvMjdSa3FSQlh6N1k0bGpMbXJwZXNO?= =?utf-8?B?QjRnNWhSTnoxMHNsMGhHRDQyV1pxTVYwUkNhaWxobkRyQWhIejZnMjdOaldv?= =?utf-8?B?a0Jra1Bxd05PM1hDL0h2M1RKM2xWbGYxc3JxbWdpQW9JK3ViTWNyUEgxczZl?= =?utf-8?B?YU5jNXRSdWF4SmtsVWUvbFJCUkRCK3ZWTmMzV2p1NDV3WlV1di9janhDWmk4?= =?utf-8?B?YUNzZEFldjl3eUJTV21yTnQ3eE55eTMybFJ0ZFpocW9mUk1QeGRkYmF1NUU5?= =?utf-8?B?V21YOXJQSGpCdEdkaGMxQ2lMdWs3aFdLc21LTGlGVUlYc1pMVnZKOEFxS3JR?= =?utf-8?B?aUJLRXNBNnUvM3NYUGk2STYwOHdnSW1ZUkRKVVlSNXVxRGZxeEVKeC91bzll?= =?utf-8?B?YXRhYjRwTy83VVBXUjhTY2o2alJsd21heVBSZFZ5V2NGMWM3QUdHaGdIZVBq?= =?utf-8?B?clNJUXhQV1IvZHlJVHhzYlRsQ2VGREV0SzJ6em80NDM4MnROeTZoemRpemFq?= =?utf-8?B?SEtkdm83RE80UHloeDMxVnY3K21WUGVuVzh2QU51QTJuQVNSelUySy82b2Z2?= =?utf-8?B?TXV3QU5vWDJnSkpvSmIvaVRCQkJXWDNzaGprQnJyMHE5YjFJN2pTRXNsQzdK?= =?utf-8?B?dEM4VGorY3VYdFAvVHFYY0tUYTFmTm1Gd0FhVVhBcEt0NzZxd2N2LzMwc1V0?= =?utf-8?B?b1pUTDhjWFpLTHBaWXd6SzRHUWdKM0x2THo1TU1mV2NXSVhNZjhvYWU0cTJr?= =?utf-8?B?QjZKSDZiYzdXSm5jcis3eWVqY0dEV2ZuZThhSzhhOUFnZGVLNVlPNC84azM3?= =?utf-8?B?R0RoZTZMOTZlYnVRMjhiUnFDcUw2UkY2c1dJZmMvaXVDTHR0WG04bkNHK2F0?= =?utf-8?B?clJ3cVFrZ01IQ2dOL1JkaXdaRE1icldPMjA2SXBZaC9lSmdzU2I3eFdaTzBY?= =?utf-8?B?ZmE1QXVqRytUS2piNEZjVHlyeUJQYTBncUQxQUNESzluM0txUEtybzJPRDBu?= =?utf-8?B?TmNabFhKemZnL04vTFdEd3Q3a2tCbG1tR01BZmNjZ2g3TnAzMkpOUTk0VVNL?= =?utf-8?B?NFVoSndWNEFaeE9LVkhUTDR0QlQ1SDlISTdMS3ZYcENRZEo3K012eWlLb0t2?= =?utf-8?B?bVhVY0FVWDdKYWlLdjFzMUQyV1pCUnNabHlpb1lNTXJpT1hEV2ZJSlU0VEM1?= =?utf-8?B?THdoSlIwRG9CcGNSL0NEZVUvWHBOUkNNNkZVd3RuUVNIdVF5MUF3M0JTQklo?= =?utf-8?B?SXZ5ajZ2cVFiejJvRE5rSzlCNUJraEpETlIzenNXYXZGNXNLa0owejhmV2xh?= =?utf-8?B?OGhQUkxiSGZnY0txWnZPODZsQjBYanppU1pGUWk0bEdEbzJQbEdnRFBxWnh1?= =?utf-8?B?YnZNZ3M3clRxbkRpWm5Vc1d3WUpndWN3akF4UG84Q3ZMMm1JK255ZkZyMHBD?= =?utf-8?B?TFhCWWVFbFA5Mnd6QUhIcDdLTUcvQmdYdS9yTUhhTE9VUE4wR0pZcXZyRGxk?= =?utf-8?B?Qm9XZlpNbm5aQ2ZvWW83R0tSSWZEaEZSWlVpL1FTQmxlWkI1V0twd3RobjVD?= =?utf-8?B?RjVUSVhxZHZVSDRvaWo0ZEptOURsUFBmWUMxSU9HM0pnRVZWdWRwTWtTVlVQ?= =?utf-8?B?cFBFSmEzMDJBQkJDMEI4cDFVdmpNRjhrdnQ2a3pjY1FYZkxteHBmOWdFWDJj?= =?utf-8?B?Zi96bEpOUGcvdHhhUGM4ZkFnWmlMK3dtWWpXdXFRbWYwNkRXakJya01XWnRD?= =?utf-8?B?QkNpbU9RcENJNG9PT0l4ak1kYXNaYWs4eGordFNxeHBUQ0ZwTjhWU2h5REpX?= =?utf-8?B?OENJMDQrRXdSbTJFRHVoT0x1YXdkVVArOVp2d21tcXJoUnZGQks1Q1ZUczY4?= =?utf-8?B?ZTVpNTMrdXVqOXlyWUw3MHNUOWlTVWdQeHFmTkRqVG5leUlOTndJSVpqc0xp?= =?utf-8?Q?PcRbqVv+2jU=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR02MB7159.namprd02.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(376014)(366016)(10070799003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZmxPRHNVNFBlOTVOOC9neWh2TVRmMW9LWEJPVS9oVVFlWjJBTmw3UktyOFZy?= =?utf-8?B?REg1N3lOaG1SN09jQS9DS2d2bnhPQ3djdnA4L2NQZ21GR2E1UytRV2FmYUlv?= =?utf-8?B?dVlraHpJQU5tQWNKREdtdWRWc1ZacThvenVVVVRyWWdYRElZSkNwNDRXWkFk?= =?utf-8?B?MVo3cnB3MEdLYU1UdHFRNmlDNSswTG5Ga0dIZG1TSVFhQTVETDFEbGs5VGFB?= =?utf-8?B?amZOZWw3aUdhUXVnbGtKL1E5bnhGZ0czWW5tU2JpVFdlQzd3VCtKcUxIK3Uv?= =?utf-8?B?U3BxMzA3ODNsekJRb0lyLzRjQWdKRHFFemxPaTVzTitLQ01BK3hQNm91TVRO?= =?utf-8?B?T1k3SU5tNzJ4OW1mU3hLQlE3WmI3N2xsd0FpQ3FDU01YdWZTWXZ1eG8xQjFh?= =?utf-8?B?TDBiS3hBbzFwb0dFSXpZcExMSnI1WFVkY0J6djR6VXgvTzZqUWZDTTRxcURk?= =?utf-8?B?NWQ3SUozUkYxYzJwd3Vka29TTmoya205OUgvUjFQbm40dzRNM2w3dnhZMVlU?= =?utf-8?B?dHBVOGkxMDhQSnJvOXZwZmRKZCtmdnNRZkdGd0tKNXl2L010VFJLUGQwcmxU?= =?utf-8?B?djU2ODAxbW9GYjZaY0xWeHhiV3dqSzZNcEFOeUNFZmxQcWdXUmliWng2RWpl?= =?utf-8?B?WlpQSDRxby9MSUpjcUhsazk1MDB6OG9XOGlpamtrYzFRT1FwMXpqampENU90?= =?utf-8?B?SWtSeUxWY3Y1WjZQZnIrbWkwNjlYZ1hXNnkvcVZCMER1QXNWdGJWNlZWVGdM?= =?utf-8?B?UGVmOTl3M2M2bStENXFJTmVzeExiT3QxK05WZGJPejZRblFxeGRxRk1nbVI3?= =?utf-8?B?UjlRaEQrTit2WUxYd21qcWZZYnY4Wmt6ZURiQU9rbzBoUlBIU2RWUTBWeU9y?= =?utf-8?B?YTJKNE9xOHRwc3JMS0JjcUZScWtMaGtYdXNObDE5eEJrUElINEdBaEtHbk9Q?= =?utf-8?B?aXN2NDRIUWRjSlQrSUZXbGxEejNFS1RHa2RRUVR3WStkdExhNWdRZGFMRE5Q?= =?utf-8?B?YmxaK21YNDB5TkhqNUpTaURuaWZzYzR1aG9nMXI3QTBXR0hGUVdvMjdSNWZy?= =?utf-8?B?QW1iaGg5RHdKRXdBb1lLNlA5UkRkWVF6cFI4dWZoUnFSS21iaFU4aUROdnIy?= =?utf-8?B?bkM4eFVmc1c1cGVCMitwMmdwQlVMb2RlRi85WDJGUTZaTG5hNUhlWGRGK3FU?= =?utf-8?B?eTlpNVZCWnAwYjBJYURoZUYxSFZDTThnSE84ZFB4UTZTQVZvbDlrSGtXOEM1?= =?utf-8?B?aE5kKzV2bnQ4QmlDWmplQng5bVFMZ3BoL1o2dkI2K2lLb3ovdENJcEUrSFZN?= =?utf-8?B?MEcyYVFvaTJRTVRBWUxqQm96ZTlmZlhNZFRtS3dEZFh1K3NubXJ4ZFlXNmor?= =?utf-8?B?b3ZhRFBHQnE4aHRiVkRObTA2b0NkTkh5aDllWE1BZktSazU1blh0YnJXWnQ4?= =?utf-8?B?YWZsd1EvK2hoalBZeCtwcWN1dFBXTzJDNEZVTzgvdG8yVy9qQ2E4cVY0aGxX?= =?utf-8?B?bXVTTHhrWGc1ZURlcnNRVTJSdW1HMUxHZ3VHaWhvejRDTndpbHNtaGdiZU9M?= =?utf-8?B?NitGaks3d1NJUUkvZkRzY25iTHlmM0dNZGtGQlA1STdpMnB6ejBjQnBYeE9U?= =?utf-8?B?VUVjMUlsaG1BcVJQdjBUSnpmT1JibWdEb2dSMERma0Z0WWtWL1l4WlpzRUts?= =?utf-8?B?L0Z1cXQ5YVAyTXBPeVdpTnA5MTNTZERXN3V6dVFSRTBYem5MOHVWM0pBNlF4?= =?utf-8?B?emtwYm52eWRJWTVDWE52NUJPcnRnYVM2R2szTWludHh2VHZYS21GYTY0TG1i?= =?utf-8?B?SGZPYjJVYnlIeEZ6ZjNHUDRVakNPSUVsL1JrUkxWR01VQXl1aHN1bm03d3JV?= =?utf-8?B?VUljUDI1dVRnY2MyS0VtR3FQeVpZWUtqZlNPRjMwK3Mwdi9tZ0Z6azNLc1FF?= =?utf-8?B?VEhyM1NGQWxVWGViMUtmak9TRUFkSGxtb2ZxNzNvcHhVck1laUFnWXJxd2xS?= =?utf-8?B?MlB4emxuOTMrK1hSekJsK2FlcG1sYkVjUXpBYW1xM2g2bGxuQ0ZhT1ZTTFd4?= =?utf-8?B?cDN5aitjVU5BQk1BRkRCdUlGNXJoTTJGeW5KOXRNZEU2d3orNmhHcVNZVnpa?= =?utf-8?B?OFA3ajJnbU1vWkM5aDJ6OGVkMjNmME5nMnpuaTdKR0ZwUW5vdnBxRUdqa3JS?= =?utf-8?B?cS9GZDJBMUR4cnBZb0JHZk5FdWFpVk84Z2hnZWh0TjBidEVEWGttclNQTzIw?= =?utf-8?B?STJ2N2ZRd3VHWTc4Vi9iOXM0UU53PT0=?= X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: b47359f0-808c-4205-3a1b-08ddbf8f4b53 X-MS-Exchange-CrossTenant-AuthSource: PH0PR02MB7159.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jul 2025 08:53:52.2514 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /ClHDQALiO95jYb3qIw3CpQ7HaHNkSOBzLL+F+ggzsZ+ZynBp71kL+Is4Ljwnor1Ms5zVwl7opTNkvCDrqb03YN1pHoxoZf10yV/pI+R7gU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR02MB8048 X-Proofpoint-GUID: Eg5xFZJcIxoHxokzovdeGJp_tzrC-vra X-Authority-Analysis: v=2.4 cv=EdbIQOmC c=1 sm=1 tr=0 ts=686f7fa1 cx=c_pps a=Im6zT5tXWloa+1LbjvLQdw==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Wb1JkmetP80A:10 a=0kUYKlekyDsA:10 a=64Cc0HZtAAAA:8 a=KKAkSRfTAAAA:8 a=qN5ve3sCTOSH2ZO3jx4A:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNzEwMDA3NSBTYWx0ZWRfXxQyOuyRQ1kAg OOfIiMzw4Bg0HmxSKDa04KVQN8A8RjrlOvbjt8HRCjiP7DWCBPGLWET4uDqnXI6ueAYUj5bkLEv h25lsOtSBYFthE4RmG2oQYIAq16/3jBCBnJmxFs+lmT+b95XlMCQIV1gPRFEeShnQoI4l2mbnWY aMgKKJMisgngzYI/b3pNfaMp7uNNEuylojT9ZPfOGnrf+4137aUVX4zgy5jVjQui9gKzWGQ7/4A 2A3iFkXVcFs9hy7gNVlAaGe1IqjA/rHU76H8aet/8EYWTI8XenqigK9vWVzs76zGvHNGramvFkS 3IQL9aaaPI1SUhFh5JLdjM379qwY4CTp4exbEOEzEV8n1oMfiJQ2Qog2igy/rp0uhL29dTMXaMH 79FZk/bcC+R20A/nAvTABe4VeShBoFI/hXQjqRo8HmTaVaz9wHfye/CCjdRiAi2Yp166BisF X-Proofpoint-ORIG-GUID: Eg5xFZJcIxoHxokzovdeGJp_tzrC-vra X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.7,FMLib:17.12.80.40 definitions=2025-07-10_01,2025-07-09_01,2025-03-28_01 X-Proofpoint-Spam-Reason: safe Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=148.163.151.68; envelope-from=mark.caveayland@nutanix.com; helo=mx0a-002c1b01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @nutanix.com) X-ZM-MESSAGEID: 1752137780977116600 By definition an isapc machine must always use ISA IDE drives so ensure tha= t they are always enabled. At the same time also remove the surrounding CONFIG_IDE= _ISA define since it will be enabled via the ISAPC Kconfig. Signed-off-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- hw/i386/pc_piix.c | 35 +++++++++++++++-------------------- 1 file changed, 15 insertions(+), 20 deletions(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index f09ec48c0c..9832b5d6c4 100644 --- a/hw/i386/pc_piix.c +++ b/hw/i386/pc_piix.c @@ -426,6 +426,8 @@ static void pc_init_isa(MachineState *machine) GSIState *gsi_state; MemoryRegion *ram_memory; MemoryRegion *rom_memory =3D system_memory; + DriveInfo *hd[MAX_IDE_BUS * MAX_IDE_DEVS]; + int i; =20 /* * There is no RAM split for the isapc machine @@ -500,27 +502,20 @@ static void pc_init_isa(MachineState *machine) =20 pc_nic_init(pcmc, isa_bus, pcms->pcibus); =20 -#ifdef CONFIG_IDE_ISA - if (!pcmc->pci_enabled) { - DriveInfo *hd[MAX_IDE_BUS * MAX_IDE_DEVS]; - int i; - - ide_drive_get(hd, ARRAY_SIZE(hd)); - for (i =3D 0; i < MAX_IDE_BUS; i++) { - ISADevice *dev; - char busname[] =3D "ide.0"; - dev =3D isa_ide_init(isa_bus, ide_iobase[i], ide_iobase2[i], - ide_irq[i], - hd[MAX_IDE_DEVS * i], hd[MAX_IDE_DEVS * i += 1]); - /* - * The ide bus name is ide.0 for the first bus and ide.1 for t= he - * second one. - */ - busname[4] =3D '0' + i; - pcms->idebus[i] =3D qdev_get_child_bus(DEVICE(dev), busname); - } + ide_drive_get(hd, ARRAY_SIZE(hd)); + for (i =3D 0; i < MAX_IDE_BUS; i++) { + ISADevice *dev; + char busname[] =3D "ide.0"; + dev =3D isa_ide_init(isa_bus, ide_iobase[i], ide_iobase2[i], + ide_irq[i], + hd[MAX_IDE_DEVS * i], hd[MAX_IDE_DEVS * i + 1]= ); + /* + * The ide bus name is ide.0 for the first bus and ide.1 for the + * second one. + */ + busname[4] =3D '0' + i; + pcms->idebus[i] =3D qdev_get_child_bus(DEVICE(dev), busname); } -#endif } #endif =20 --=20 2.43.0 From nobody Sat Nov 15 10:54:05 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass(p=none dis=none) header.from=nutanix.com ARC-Seal: i=2; a=rsa-sha256; t=1752137707; cv=pass; d=zohomail.com; s=zohoarc; b=C48l//J11+i7KX3r8pO2gCfcoJDqK4aV0utsLDHPGGe1z97QZPEJDFQ8Mu2kVg4DHvttUHv+kk3qZ92qHQAHoMRg/x/CVAoi0qdJn00aK2sRYjlfs0n9oAx1LgIOBMYX4KQin/rHalayKAzRHovtEuTi0FWbylG3SBR9Ftor+BY= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1752137707; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=d0BRxMv2AVTmI/RqCqQLXETwsopcw147SXhNq9f8cXI=; b=aT8u+Wt4hejAcZLDOej8eebiBBMExpkzXvtzyU6FVh1+0/H79RMKWMJWfcrKv4xV2mmg1PNDUlCV9TRabZhngrrqniYCKfqXgNnXPlJTy3iT0h2sxV8UbOtECCB+GZLf33SIe3c2jk4hHI4faDeRjTYhVYua1A3pE80aeAx6zCo= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1752137707823273.4917369070147; Thu, 10 Jul 2025 01:55:07 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uZn2e-0000D0-Qk; Thu, 10 Jul 2025 04:54:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uZn2c-0008WO-U2 for qemu-devel@nongnu.org; Thu, 10 Jul 2025 04:54:07 -0400 Received: from mx0a-002c1b01.pphosted.com ([148.163.151.68]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uZn2X-0003Zu-AD for qemu-devel@nongnu.org; Thu, 10 Jul 2025 04:54:06 -0400 Received: from pps.filterd (m0127840.ppops.net [127.0.0.1]) by mx0a-002c1b01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 569MA3c4020442; Thu, 10 Jul 2025 01:53:58 -0700 Received: from dm5pr21cu001.outbound.protection.outlook.com (mail-centralusazon11021130.outbound.protection.outlook.com [52.101.62.130]) by mx0a-002c1b01.pphosted.com (PPS) with ESMTPS id 47q0cvn294-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 10 Jul 2025 01:53:58 -0700 (PDT) Received: from PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) by BN0PR02MB8048.namprd02.prod.outlook.com (2603:10b6:408:16a::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8901.29; Thu, 10 Jul 2025 08:53:56 +0000 Received: from PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88]) by PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88%5]) with mapi id 15.20.8901.028; Thu, 10 Jul 2025 08:53:56 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint20171006; bh=d0BRxMv2AVTmI/RqCqQLXETwsopcw147SXhNq9f8c XI=; b=r81Ok60hxJ/us5dLW3UvDjSnrvwSMCLnRm0Oa8rp7Frpq886b63HohG25 vSThe6rlbnP/ECkqzK7rnmnz+NTBAt5Wt3zN2xnm4je9IJyifSFA5yC2Fw4JCp33 ZeKCU/rJJVWyCzzdIHaI/RN9stgC2OUNt/wuzeu/6UmFQQKgqxgrMXxpSKH7gbgt QN/Yxd6GUootaToE1qMiFZhVo/JibLLZfAqJjSEwpX4gXnzHVi0iT003ituaAlDn xNpbR8+OZpMr0A6dF6HUd9uTRBWMu2aIyr6ovsXpiVLwtdaL8MCOfie8UREALnBc 5qeBjVnc6RmM8k4AcbPbThO3wflWg== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=l83bI5syfseVYphP8iMbX8iOg82BMg4fCWZBmT8erAG4wR89VQA370PqrPQoa/4DW2ItRBY4qg5OWm04+N6q9GfaM1/p6ShugZ6Kf8ar6W+e9ecz7yRAFx8iKF1+Jd/0XjYNg1PBgKmkhdCdWyOlrGyqz6XYuyK2+lnDX+E0xcsoyOCUPsdltQd2OUXG9WPCLXno7hUlgV31aem6GkuHWSrakEjqS0/CTKD+d/SwQaP35ylRtn07H92YYU74ubFoA9w5FjSVGLUQgMgbTNWs5d6XSZvP704Rr4eeOvxQLTbM4yLN0DJ+3v93tvHLHnor0wBC0HwUh/XybGQbTVzBxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=d0BRxMv2AVTmI/RqCqQLXETwsopcw147SXhNq9f8cXI=; b=X8awz6q8xaRp/kOQfafTM0E3RwbKt8KNefZ7PL6QURXm7bFkOPvXDD0bILrXp6/STP/181N0jypU4oHBOLfZL6M7SfJ37hvO5r/d2KinFGMsCJdjGbVB4tZuf7wHOSbywinG5Zuj4HAxmy/ltHyf0bnlHGoyuHwJb27QWl+wwpDxnsrf8PsAjKjUTJm1L+PxDrNzmC5LIb3/uEtwvbho9atcL7Vwzr5i1SI6K74OzEHSTdRITryrhtINVbbfKy2LqZf90CNJsVRa/uIUw2AQkEp/5eWpJzFq9RIXXrSS20pBis3QqJPJCqReXNp2tsLDMv/oKHSShGoYT/aaqrqYvA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=d0BRxMv2AVTmI/RqCqQLXETwsopcw147SXhNq9f8cXI=; b=ctmKR/+jueQ3b+1r+nS3vtil+gSrfbQRIHh0zht8cvsXnZ7yl8HY2MBbUxxl5e8EySWG04uY8YxJCsPT0qZINzZOJFDs9A9U43N0NQ8DExTRWU9V6FO4UO3t2F1ygSsfji7fdhNmYFhIuwBYszNUTjsJEs1h3v3C2Nw6gpunXhpxJ29jQeVDejhz3d8w/fkxy6PvKtrCcCrCKXTzVR1aT2/0sfQrCCmCEQs6yWeP0Bmd89UiwcQboJhREb9TS+RXm3DIkauZXGrcl9RUiflB0ioHeJOIxXRrXNzUQ8n2vxoMZol4m70NMNuIWfR0iHiW8WZGxe7yIKZkVwgl2l9K1g== From: Mark Cave-Ayland To: pbonzini@redhat.com, mst@redhat.com, marcel.apfelbaum@gmail.com, eduardo@habkost.net, imammedo@redhat.com, qemu-devel@nongnu.org Subject: [PATCH v4 12/18] hw/i386/pc_piix.c: assume pcmc->pci_enabled is always false in pc_init_isa() Date: Thu, 10 Jul 2025 09:52:27 +0100 Message-ID: <20250710085308.420774-13-mark.caveayland@nutanix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250710085308.420774-1-mark.caveayland@nutanix.com> References: <20250710085308.420774-1-mark.caveayland@nutanix.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AS4PR09CA0002.eurprd09.prod.outlook.com (2603:10a6:20b:5e0::9) To PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR02MB7159:EE_|BN0PR02MB8048:EE_ X-MS-Office365-Filtering-Correlation-Id: ef30950d-6c0a-4ffd-ef61-08ddbf8f4dc0 x-proofpoint-crosstenant: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|376014|366016|10070799003; X-Microsoft-Antispam-Message-Info: =?utf-8?B?ay9mR2NQOG1DaE9iUEVXeGJXODVmem5EejVOMEpjMUlxVVVCRnBCcVpXNVd0?= =?utf-8?B?OUdMcUxvTUlrS0dWSUdXTFFSWUNmeEQ3QjZDQkxyT3pHc09ER3d2OElSaEdu?= =?utf-8?B?T0VidUpua3hWMU4xQTIvUER5OVVWN2RmSVFndUYxZTBMREp2d0J2RHJIRUNr?= =?utf-8?B?QVh2dENUcHpQRDZ6M3IvOXNXZ0hJcnc0bHF3d09pMmFxWWkxa0ZraE81c0I3?= =?utf-8?B?U0NQMTVOemQyV0NyanBFenBIMkxIL3EwWlkrSnh0dFpqMGh6d0ZXL1dreDVS?= =?utf-8?B?RUo1OEJWeThveVdwMHdKK1pPZjBHcGZGYmxITTlnRi96SCtTV3ZLeUx1TVRY?= =?utf-8?B?VXhzMEpSWmN6cVFZbmdyMGpuVXN3QXE5bVV6K2dpRDAzSDJwRThkQUc0enZX?= =?utf-8?B?ZTZFaTVQUTNPVzVIbzB4MDFFVWlrcEN1U2tSOExiaFg2dmdFZEt1Rzg2WVh6?= =?utf-8?B?MS9xWUluT3lPK3lUS1J6QUpORU8zanExdHEwQnAzd1RQWjNUcDk4bGE5cU9a?= =?utf-8?B?U0xWSjRnekl2T1dZNE9zbFVDdEZWTWU2SG11eElaRTJPZjZYRkxYWjdXY3dE?= =?utf-8?B?S29YdUtpemhhWGxuNW5Wa29RUEJkMUpET1ppQW9DWW9TUXhxZ2Z2QmVUcGhi?= =?utf-8?B?cUIyRXY5UVd1YlJGVUFoQjVLa2F5YjNiM1B4V0hwTGloeEQxRU9OM2ZyRHll?= =?utf-8?B?RVlyT0hvOU5LSFRlSVdVTVV3QW42Y1FCZVIrV0RSWE0rcmticVo1cHpQZkh1?= =?utf-8?B?UWhza3puU1ZaeXFxV3JxaVMzcjZDWmEwTmRiTWY3OUtsejBXWWZ1eU16N0pk?= =?utf-8?B?Yi9mcnFkN0FTTEwwWFNKOTNiSGNSenpUV1QzcCt5U2lKT0tPQVhINzRza0tF?= =?utf-8?B?RjYraEs2NUMxNGU5cCt5L2g4QTdxY0l2OEoxV1dnd2lqRjEwMVpWR0pSZjNT?= =?utf-8?B?SEh4WDVjWUFQR0dPT2cwV2dQSzhnbjVWbE5ndDRFaGVJS2IzV2N3dE9UVTBa?= =?utf-8?B?NFRxNURwYjAyTDkvOTl2OGR6cmJVWUNTdjNqdEFhSXFLQlFrQ2o1Sk16ZlVK?= =?utf-8?B?SkIzaG9TQnBjOU1RbHhMSVhpVk1iUzdZWnNsd3F5YlJVeTlSM2JBZ2FJbVc0?= =?utf-8?B?Q050OVR0cXRvUXVZdzRzZWJ2NndTd3lXUkROeG1mSDMxb0FpSHpPbCtBVDF0?= =?utf-8?B?UktOc2Q4QUt1OTliSzlnbWFNTTdRSGRjTGloNHV6enpmY3JDR3hRaDdId0Zk?= =?utf-8?B?bDQ0TnhsazBFc3hDb3F6YzdpVmMzTFNITUFzMnN2UUJBbzdpcE13TVhGZ3Jq?= =?utf-8?B?REJONDl1anJWNWVhczJJV1psZHVnNFF2ZmtRcEZiVU9QY3UyaGtaTzdqVXdj?= =?utf-8?B?cGRONWdMQjJ5bllSVmJlSWJncFVBdnZuK1YrTW5RbHd3WlU4T0VkTkVpTEN4?= =?utf-8?B?K0w5WFdBK1ZYam81NGRESDI5SXY3OHRaY2RhZ0ZkVmxiN3lZWXZTNGdGcmZ4?= =?utf-8?B?d3pDRzF3aldHK2twMk5taDVWZ3YzRjJYbmxCK1g4bndqdG5KZUdBL3FZVDJq?= =?utf-8?B?WjQ3bzZBQVpqQVU5cmQ3KzZaOU1EY2hwN0lTWFpKRitoQXJmWGlnTkIxUlVt?= =?utf-8?B?b1Z6VnZQVzA4bTFmS1ZmczB0TWlDbDlsdG8rWW01cCtVTERaRkZNNUgwdEFx?= =?utf-8?B?L0NheC82VkJUQVlNUUZBTlBEWmEydFJZR2tlYWhFd3IySGJNNUI2R0VsUDRq?= =?utf-8?B?RHJpc1NGSzNiaTM3TEk4UEtlTy90N0RjeWRpWHdRYVl0QnJxTmRLYWUzbGxy?= =?utf-8?B?UzREMGRrT3hpaDVwSDNUVU5Zdy92cDI0Q0lWVWNpdEpmSHFWK245K3pYeXBZ?= =?utf-8?B?Z29yZGpHOUg2RFNiOXBqZmdHa0N5bjdTVzRKU1AxYWw4eGVYbnQwNzg5b1kv?= =?utf-8?Q?CkHFkjk8EdI=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR02MB7159.namprd02.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(376014)(366016)(10070799003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WlhHZ3dES3d5eXA0cWhicktMRWJrZTkwVnRCZlQzaXJOb05IREIwNXV6Q0lE?= =?utf-8?B?aW9ZMFlXK0plR0cxZmNIVjlwSUlhVXZpVi8zeGh3MHBVK3c2WFJmdWNJZExB?= =?utf-8?B?ekNBWVlGaVQ2blVBMmd1NmxGbTFFT0JLMHdOQUhGSjRsTzd6VmtjRHN3ckln?= =?utf-8?B?M2U4aGVyc2R4c2hDSitjbEkyTG8wUnZ2dWhzYTd0UlRISkdBTDNzTnQrcEoz?= =?utf-8?B?N0VMVFE1UWZNMk1sSXVzUXYva21oMDU2ZHRWSG5CZjlZT0xLaDFTSXcwRGlS?= =?utf-8?B?UWFta0FZUmdDdlpLNm12QTBzb0x3bjBZbGZtUmZ6Qk5OZDJ1L2FIeDNyY3l5?= =?utf-8?B?djd0TjF5c3NTUFgyamFvN2YzZlV5ZEJlcmw3aEV4VU40Uk9pTURkelBxaUx3?= =?utf-8?B?RlVEaS9tSnRLdFJ1a0dvdWlzM2xwWWtOTmdwL3gvVmlPMW9xeFVoSHZjeVYw?= =?utf-8?B?OHZZOTNjenc3MUpldURNWERmRlgxTXJrMDNJUHRJU3pkSFp6SCtvV0QwZHpu?= =?utf-8?B?UGJOL2pwV0dUdlRzMjAzUmNiZkcxV2I5SGN2SXpJZm9USjZSaGhBaklqOHZx?= =?utf-8?B?Snlmbi9pTDg5ZHdiZG9mVTdReUFLcjJvYlNYdkYwSWFhNkEyUHQ2TFlVVnM2?= =?utf-8?B?dVRtOFM0aWdnUjNMeHEzRzduVWI1KzVUcHlpMGErNWhTOXJhWlpJK2l4REJ6?= =?utf-8?B?Z1d5Y3MvY3hldlJlZVdabFViSmQxWnlNUmlwcmpmeGJSSmw3WFdiL1RiYW5R?= =?utf-8?B?R25WbnA2VEJlSThrbGJGdzdMSmxWRGFMYzFqcnM5cDV1ajVUVklsN3NWWXRa?= =?utf-8?B?L21IbVVJWExGaWJxc1lZMm9xRnluRStyK0FIeng5V0dxaVZ1T1FQbGhwQW9R?= =?utf-8?B?TjNFV21TNkV1Tzd2c212OXdyYm5XK2hiQ011M0xwWjBxMG8wSVphcnNHcnAz?= =?utf-8?B?RFFKMXhSQWpCMy9idzdlQjduZERjSysxUlozR2ZwSFR2WXJDQTdTU2ZWUFN1?= =?utf-8?B?U1pPTXFhbHUvd2IxZnVhdXU2YjZjNktpNXZLMDZnb1JPVk9rcm5yR09JWWNK?= =?utf-8?B?Y1VtNGZyZzBSRWVRRFlPVnhJWVZ2elVSZ2hXZks5MmhHdVg1am1YM0JrbjUz?= =?utf-8?B?RGtxQ083cnpHL2RUeXpWeWprWi9vVUFXcmtrczFxMTgvNU56ekZiM2VoYytx?= =?utf-8?B?cGhnZjZvNnZGVjhhWXNDMlVTc21PL1ZSbndXU0FVcHg4MUExZlFoRWhOd2di?= =?utf-8?B?WGxLbWRMQmNSc2JZNG9zTU9kLy80UVpiYzBsODYyTWdzUVZ2MzhTWkJLTGhw?= =?utf-8?B?WFhSa091S1pNTDFCek05bTh2NDBDdXVTNVpIMFlBZ0NiazVlL0hyUCtkYlBx?= =?utf-8?B?WGlxRzIvRkhpbXVLMzRIT3doNk40Mm55b1N4aTlZVnh3MEVtU0ZFUmhvaXU5?= =?utf-8?B?cy9jTmRrRHFkdUlmc2FGQW1aZmREcUZ3Vmw3K0g2T1c3UFlKdFlXUkl4eUls?= =?utf-8?B?R2NTUjNpa1BaeHpSVnNaaHZ5bmhXZWJBSmEvT1pXeGRPVG16dm9tYWxLSURO?= =?utf-8?B?RTBRQjkvQU1xZjZMaTFZTlQwV3l4Mjd5Qk1naHRXWXNCa2xYRXdSRUd6OXJ4?= =?utf-8?B?RUlha1UwUXZOT0RCNjN1OEJRNGVFajdnY1ZhYnFJMU1YYVB1UFdLZ3pscWF3?= =?utf-8?B?OFVTbWxXcmdxNlQrZHd3clNyNUpDdndLUGpIYlNndlREVUdqQURqeWd2Snhr?= =?utf-8?B?by9YNlpRc1orOE9WVUo5akN1RDUyZmo3Mkk3Rkc1dUhvbG9YNm9EdGtXWk0x?= =?utf-8?B?dXhaQWxuNFdCMGtLK0NWSHgwZC9SRnBoTFpWNFZIL0x6L1NiMVM4Z2NBb0hv?= =?utf-8?B?SXM0c3dMYWlzNjFHK1BJeVhON1lBNkJMZHdMQmRONXBzQzJFNEZTVlhUTFlV?= =?utf-8?B?bEJ3WER3aEVYeDJucS9QYXpGNHNoa1JLbXRlQ0l5eEVpUEpQakFXNStkMWJl?= =?utf-8?B?YXFkUE5wTFVBaytCZy80YmdDQjJCbkZScUdRc1RvR0NiYTR6TCswQ1htWCtq?= =?utf-8?B?aS8yTm5JWkpJZXZKODRXVXc5eXk3TDgySlZycGlEY0JhQjlxbFExYUlDTjBz?= =?utf-8?B?cElPU2xzekp0NThRSFFHbS9MZUpmNVVCSnhpKzI1NlBVTFI2blJIZFpWTzZn?= =?utf-8?B?T1hMSXpxZVpKbkcxZHpnYXpKMWEwV2VyQ3VhTmhPYmZpSTE1dm5SK0xOYkFN?= =?utf-8?B?WU5SbEY0Y3g0aE04cVBjdmcxMDlRPT0=?= X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: ef30950d-6c0a-4ffd-ef61-08ddbf8f4dc0 X-MS-Exchange-CrossTenant-AuthSource: PH0PR02MB7159.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jul 2025 08:53:56.3015 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: unsuxvpOO6VmRVUdpnCRYK8rIghdY2g4U93dljzGfsCnK0ZUvqG0ygRK+dT9FKkplfASgyec1AFI72xsBJzfqfa109wMivV5NKkjkYv5rKw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR02MB8048 X-Proofpoint-ORIG-GUID: u7EwRlvkmZdaoWKX0bB3Z6a9yWqyVVh2 X-Authority-Analysis: v=2.4 cv=ccXSrmDM c=1 sm=1 tr=0 ts=686f7fa6 cx=c_pps a=7kgNGXaSmB15KJ6u7rEBag==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Wb1JkmetP80A:10 a=0kUYKlekyDsA:10 a=64Cc0HZtAAAA:8 a=KKAkSRfTAAAA:8 a=XqeNvJXGgvzUN9CD1PIA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-GUID: u7EwRlvkmZdaoWKX0bB3Z6a9yWqyVVh2 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNzEwMDA3NSBTYWx0ZWRfXxDf4r0kTZlKI DTZ6fRBfZV7RT/YRQLgeCuaMxgiLyf4/maNFbH5CQ5/8c6Z3WoL+XXnP2Bh4OqMB7UMOpRoFYxI Lu/QiItFwr/+A7xHQYHx2IVYJ9f5WAzaRIjPzCyIiXszkvMzqozjtR1faBey97n33TriEXl2mCH 9ZbIPH+QzA5DGNJr1dcWvkSnVXkA2KH99mIBvWfTl05wWPMhTI3E+t16MsPw9KfsWuf3pxmmS5a pFRInRxMyQLmKNGR4c/mLDI+KcLe/AVJ3+5RqXOnmHQopsVtbJEOXhnLfa5O6D+F2JZF3Pxwpg6 6/9otsaOF+NlqLzTi9dCWCmN2WIzD++Tf2NL3FOL7gQT6oaQ7TMX29DtAVQAwnpxLjmTdLEk04b WK/BF3hpfQgKhvpyhoKnvPCatNi+jflQiEi00W5L8HLH/4qTaSxGrFsBdm4wqqL53hWDQoao X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.7,FMLib:17.12.80.40 definitions=2025-07-10_01,2025-07-09_01,2025-03-28_01 X-Proofpoint-Spam-Reason: safe Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=148.163.151.68; envelope-from=mark.caveayland@nutanix.com; helo=mx0a-002c1b01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @nutanix.com) X-ZM-MESSAGEID: 1752137710179116600 By definition PCI can never be enabled on an isapc machine so hardcode the = relevant values set via pcmc->pci_enabled. Signed-off-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- hw/i386/pc_piix.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index 9832b5d6c4..7b38e37d7b 100644 --- a/hw/i386/pc_piix.c +++ b/hw/i386/pc_piix.c @@ -473,7 +473,7 @@ static void pc_init_isa(MachineState *machine) } } =20 - gsi_state =3D pc_gsi_create(&x86ms->gsi, pcmc->pci_enabled); + gsi_state =3D pc_gsi_create(&x86ms->gsi, false); =20 isa_bus =3D isa_bus_new(NULL, system_memory, system_io, &error_abort); @@ -494,7 +494,7 @@ static void pc_init_isa(MachineState *machine) x86_register_ferr_irq(x86ms->gsi[13]); } =20 - pc_vga_init(isa_bus, pcmc->pci_enabled ? pcms->pcibus : NULL); + pc_vga_init(isa_bus, NULL); =20 /* init basic PC hardware */ pc_basic_device_init(pcms, isa_bus, x86ms->gsi, x86ms->rtc, --=20 2.43.0 From nobody Sat Nov 15 10:54:05 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass(p=none dis=none) header.from=nutanix.com ARC-Seal: i=2; a=rsa-sha256; t=1752137743; cv=pass; d=zohomail.com; s=zohoarc; b=VnIlXXrAlPRu3yD6syum6xDEgiJypyOwtPcmTrHiGEqHP0Al5/HwwExgpA3ThxrnxMt3GZlvx/t2pAXMSYU9VdfZsp2VDA7Vnk7qYiyHN+EdcbjcdHynkL6FgLpQur2tkY37WTlLgg08AMKVBdvCbpdrz1q7bNI33oABgPhrjRw= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1752137743; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=MVy9IpMFLSy/6XGWecXsvRF9RMpmklOgXe5V2tWFbt0=; b=Fk9pMYcfgy4CF/9g/bxO0aR3GXkmnNnsVTCdC6hb5xoJ+53297Wzf8gKbS0urgT8V8hPaOF1///MEG2S/S8jpETIQcrJU8cHnsMRzYHp7QEasnRGU93h/L9egwN84Zu0GMXyAvKBg2bo0vPb+Gbjc/sk2zYaPxvhJSZYW8Z0CyM= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1752137743131625.5895118972375; Thu, 10 Jul 2025 01:55:43 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uZn2h-0000Ll-Sx; Thu, 10 Jul 2025 04:54:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uZn2e-00009Y-6D for qemu-devel@nongnu.org; Thu, 10 Jul 2025 04:54:08 -0400 Received: from mx0a-002c1b01.pphosted.com ([148.163.151.68]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uZn2c-0003a2-8u for qemu-devel@nongnu.org; Thu, 10 Jul 2025 04:54:07 -0400 Received: from pps.filterd (m0127840.ppops.net [127.0.0.1]) by mx0a-002c1b01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 569MA3c5020442; Thu, 10 Jul 2025 01:54:01 -0700 Received: from cy7pr03cu001.outbound.protection.outlook.com (mail-westcentralusazon11022097.outbound.protection.outlook.com [40.93.200.97]) by mx0a-002c1b01.pphosted.com (PPS) with ESMTPS id 47q0cvn298-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 10 Jul 2025 01:54:01 -0700 (PDT) Received: from PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) by BN0PR02MB8048.namprd02.prod.outlook.com (2603:10b6:408:16a::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8901.29; Thu, 10 Jul 2025 08:53:59 +0000 Received: from PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88]) by PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88%5]) with mapi id 15.20.8901.028; Thu, 10 Jul 2025 08:53:59 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint20171006; bh=MVy9IpMFLSy/6XGWecXsvRF9RMpmklOgXe5V2tWFb t0=; b=C5FtN5pFesgk1bYfahl6tCiB7SwR68ceEyduVofo14sd8aTAZPO443KIj k+6PxViyQ76vo27b/6BCl44M78TKBq1LAKbXIjhn6ML4iDRyF5NWmrjgnTZ3qVwK 0LJypqjc+lW6awycBUC83d5yzSiTg0Vx72fVJLg6/KfI6YIw9HLdGGqsIkhJ3qKU 8S1JFgRVDMe+b7D76PPkhV1tRTfzZ/HYC0TwX/Ywvkr6TbdJ2ClJ/HtGfA+okdGS 6VvPHnYCtAiVuhC9vgJOWfOm4T3lE+KFh42IuRs/zbxqj4c2zhzj1bYjh2KgTzyQ KSp91wfiOikEF8V+nCgFXE9q7+9Xw== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=vwsKn7GCCkhUryhX9ZBj1AewEReokGlWPpn2q5tgOb2edIKSj+Q1c27CM0Nspwb5y+tDAYFaiqCcWdh3XDb+PnDhSQdsCfRrhrKu5Io6QTd9UZQ31+JaUfuhoIrDOKbgQNtSBYnybK+00HMsdONdKOIUGl+GX59uCH0cV0tVV4RYOWMPRFvEWJyKFJ9PIBgbbRwD1fZZMUhNy8cfKNMkGWkb6cMkCkZ6BmwDm57q7O8J1Oo7Hy7WaotFk1OvIO0fAizDDlUCo3oUkOipqPn0SSoWXBEnb5PCyHi4O55caF9IKvnlV1W3JQszA6N+8WjaIzio7u2N5ONDUc1Jqqki/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=MVy9IpMFLSy/6XGWecXsvRF9RMpmklOgXe5V2tWFbt0=; b=Jq2hH1IUUvM+tK5zNXE80jg7hiJISHk81VMXJ2lhCv8UyYdHHTAl1vWoS/Kj66zge+TAFvdVDudKiCQ+VWmNF3fo2O1yYr9a3vMCmOmffhXSdbknUZzYlajmrUiiOft4/UysDeALDoDCGbc9VrxRi5CHvL67iWXu4dxOOAEROOWUK1jhJE5IuLJsduhXke+EfNaD/ktbRw5p6wQkBuMP34+8bRf68tiKni4hdEAiUEMyPGBt8qx1IFPTEFpmRl6CYeWGYTAyqgdn+sLR3rYTV+Yvuf8CQecyr830E4EeTJHmAZU0Gm80j85nozJbKAWIeKp/sy6bKWbWso82LvjQHA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=MVy9IpMFLSy/6XGWecXsvRF9RMpmklOgXe5V2tWFbt0=; b=tXCg1oxsaZFuvcGG5C/QAvNlPEQu2HTIZzKJYgNrSf5x1ARdyODGc4FY2v1pHcYiKgO3T1O5dKKNMIQkXweMoT/CEHoYAQckVvwHLbRUa4M5hPVOwc/htPxgpbT4EPE++4V3Uf09vk4rh6Sv2xC3Q6rCjDYMA2cWb18nyEEZjn8QIzznmvqH5y0MMXDa9af4Ah6a7gzUvXu5ieHzJfJPaJcEdSXuHeuIwRlsmNt3C+z/Fu+5mY7M9EHMyKT4IUU3g7pRBtzAwRpPU1/L2VpbyXcV4CKH5yP78EUw8y5fA+liZjp7sBY0SOM3v3N//ml8ZY7uY4jz99m6e7I17idj6w== From: Mark Cave-Ayland To: pbonzini@redhat.com, mst@redhat.com, marcel.apfelbaum@gmail.com, eduardo@habkost.net, imammedo@redhat.com, qemu-devel@nongnu.org Subject: [PATCH v4 13/18] hw/i386/pc_piix.c: hardcode pcms->pci_bus to NULL in pc_init_isa() Date: Thu, 10 Jul 2025 09:52:28 +0100 Message-ID: <20250710085308.420774-14-mark.caveayland@nutanix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250710085308.420774-1-mark.caveayland@nutanix.com> References: <20250710085308.420774-1-mark.caveayland@nutanix.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AM0PR06CA0134.eurprd06.prod.outlook.com (2603:10a6:208:ab::39) To PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR02MB7159:EE_|BN0PR02MB8048:EE_ X-MS-Office365-Filtering-Correlation-Id: 8198f342-2bc5-4114-9a35-08ddbf8f4fc0 x-proofpoint-crosstenant: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|376014|366016|10070799003; X-Microsoft-Antispam-Message-Info: =?utf-8?B?aUVwa2prcElSNFVQSlVKdmdRTmRLQ3JOa1NXRFlPb0Z5a1JHeXowbHZqZ2J0?= =?utf-8?B?UzBqZTdhMVl4MzBOSHpPZ1ZHUFhrNlJRTnEreFRob3VEa21icUU3Y2N3RjNz?= =?utf-8?B?OXFJVXFNUHRuRUNuVmhBSS95TWVMQklCNzR3aDcyQ1RMLzVWL0F1S3g1N1dQ?= =?utf-8?B?UnFYdm5tYTJIWFA3ZGVOSU5WS3M0eFdmMW5UamJrNEhiOE1RN1VTVnRyajZs?= =?utf-8?B?bHNhMk5kUkdQWGFuT29Zd3RJdnp0c3Z5Qng3T2pIT3psUmhKc0p4eko2c0JT?= =?utf-8?B?dFNwY2VReVE5L0FDUGJYTEVHZFFpdE1TWXlHZmEySmR6OHBVbFpVOHlrcHdB?= =?utf-8?B?NzZIMXYxcGE0RE5DMjlwK2RuR1VpMUROL0xsSWFFWTNCTWlSVzlVRkFrVVNP?= =?utf-8?B?ZDNicUF1ZjZWSUlJSWFCa09CV015VHVWYXFIaTU1YXF3akpQalcxSEtJSnd0?= =?utf-8?B?QzFRM1ppd2N2Zng5cUYzSXZNNk5jYWVSS3NhdjBldXFwblFoajVRUVY3OThM?= =?utf-8?B?bDVFZUhja1pKd3Y3YzBMNEhhUTZmc0lyWEEvTmRiQ2REMkEwVUp4TnhybEFE?= =?utf-8?B?aDUxVGZHTFlQRlFybTAxL2c4ajRra3pPeFUxTkIvOXVJT09NNFo1MDFZOHpi?= =?utf-8?B?dzUyY3lJV3BTL2d5aE5PZERwUHZPNnBLTkhPSFZVVjE2c0x0VDlRRjIyb09Q?= =?utf-8?B?bjRLb3J1STh3UGhQNHJnTlVLWkthS3l5UldOdjhJcTY3MGJHcWU5Z1FMQlZ1?= =?utf-8?B?RkljQmZTY2ZhQnJZVjlKWWVZTUxFTkMvYWk4NWgreVliR2NNQ0xiNXE2STRZ?= =?utf-8?B?VzdrWlFYMG5kNUc1enRiV2xLUnpRaGJ1NTNnTlV4WGJ2Skg1Wk1aQ3crOWkw?= =?utf-8?B?T1dZd3g2T1F6QklVMFkrY3BLeEJxKzJxUFg0NUNTNlFiUzVYSE1PdnY3aVVJ?= =?utf-8?B?R3lML1UyNTd5S3BlOTVFWVU1T2VBTTFHZkdNOXY4MWdoU3gzVkZQaElQY1Mx?= =?utf-8?B?WjNLWXNLUGg2SXNWSnhZWVR3WGcxaHpGMERNeURsWTdOdjl5UHNWR1NEbTJw?= =?utf-8?B?THkyTFEwMHlGbExIS3doSkcwMEo5MTdidXBLN25jajdYSUIrVXVuelhPb090?= =?utf-8?B?TlNCZXM5R25raGdpbmNyUjVncEFIa29VSE5ORW5jNS93S0hIMjVvci9PejlN?= =?utf-8?B?a21SR2dnVzJVUGtOU3haNUJMSnRxS1RlUUlaS0pJOWlXN0xoSW9oVWV6d012?= =?utf-8?B?ZmV5NWlSNzdJUXEwRW9kem9PNW9HaUhUMVV3ejlKRVJQZ0pUazAzaTFVOEsw?= =?utf-8?B?REhJZUNTQlExNkRlYUY5MnI5d1UrSE40SzEraGg5ZHNNZHNpMXl0WG0rM3Zx?= =?utf-8?B?b0JkeSsrVnJWUUM3NzJ0b0pSaWR5a29MNmd6dDFmZHUxRnRJQjNEU0RwYUk0?= =?utf-8?B?WllPdEJiTVU3WWl4NlIrYTV0ck1DcVVaVmdBZlZIRnJTN1MrUldWTkR4MEwx?= =?utf-8?B?NitySjlOc0UxdHE4Zy9RTHhjRmNhVEFUdTFiMGJYU2J3aXhaZ3hRaTZMUXdN?= =?utf-8?B?RkZZK3Y1NEgvMnQ4TzJ4UGlHN2lWWkpRa3VKaG5VUlNhM3I5elBCdS9IMmQx?= =?utf-8?B?TEpQNXZRY1NZQ0JYckJGV0x6d0pydnBxZUorM2pTcGFvQTRZcHMvaWZQcEs3?= =?utf-8?B?aVFLcXJzVDRoVjNTL0RCQ2tIaFBYWFNhL2RaSk42QWJZS09OZC8ybW9ndWRJ?= =?utf-8?B?ZnVpajZoTS9BQUlUTXBVay93Q2hxQmRKckpnMWdxeVZHNFpuVXBUczVqS3RD?= =?utf-8?B?b0NBMjF4UHc2d29pb1VzSEVNMlJJeHJsWHhOVU1icG5Ed1pEWHhoS2JNRnda?= =?utf-8?B?UHoxYjNRcExPWXVhcW5UdU1EeER0dWMvdEtkSDJMMDhjbk03SG5aWWU2YnBP?= =?utf-8?Q?5XgrDQVyEsY=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR02MB7159.namprd02.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(376014)(366016)(10070799003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dFpjSUJVVGpzYldkeGNXc3NadCtOdEZHbEF5d1RjQmtKT1VSQ1ZQZVB6YUtU?= =?utf-8?B?ZUU2KzR3akZlbGpydlFvSUVxSE1ha3hwYnYwTE1UY1haMFM4SmtMb2tOdG1G?= =?utf-8?B?US9yVUNZcnVQMlRUbXdzaTBzcXdET3R0eHhhb2ZKckRqRkQ3ZTZqbzAvbGpm?= =?utf-8?B?VjBRZzlMYk5QVURJNGdab3lLZGJlcHVuRGRLQXBxYVR5cER1ejNIcjJFeW8y?= =?utf-8?B?NHNodzNnYmtEUUFEODF6VVBOSG5SRXVycEtXeFFlSmpnZHRHaC8zMlZlUHFu?= =?utf-8?B?YzUrWnhxODhwZFBQVnp1Q0UwSnNXR3hMbm1tNzhxUVNvV3RuVXM4cnNmV0pv?= =?utf-8?B?Wk92TVhkODJqSS9DenNwSHZuSk9iTEs5Wm9xQnp2OVJPbU83cHEvNjZWSU9Z?= =?utf-8?B?clROWkhac3VacVNwRnMrOTR0UHFVTTArOEVJRHd6NmJ0VlBTV1VvWXYwbURr?= =?utf-8?B?MXhFYzVENU02Vk1aa0lvcS96ZS9BbWlzdXRlUW82dlJWczErQy9uWHptZE5P?= =?utf-8?B?M3VuTFpHUkUzalFtQXVTOGVHYXV2RWV2aUh6ZVV2SGFMMmxQZVpiTG4xZjZP?= =?utf-8?B?S3R5ZVkvRXQyc2RCRjM0ZWZmZ2JwdjI2NTJ3MXc2QXIxeHRHMnNPUDZWb0pV?= =?utf-8?B?SHZzbnEveXJ2eHVFdzNGZjhqWDNOciszd0hjTlNOcU4zZ2JVeGR0Q3FQQWtL?= =?utf-8?B?M2c1UjlUMnVndFJGRjZWeXFvREZBQ2FaZW5tck9JRzgxMXZGdUlHbWhDTVVr?= =?utf-8?B?a09ESE9KN2RhMTJEYTdLMmE0NTNUQTBtTkkwL1gwcVQ1OC96dVY4VnVEM25V?= =?utf-8?B?SGRRbm9UemZQMHM5aTdQMFpLc012dkNsUDY5aFVKQlBTOFA3Q3V0OGtkTCtt?= =?utf-8?B?blllM1djT1FjakFSZVFrbWM5eG9malNhRFY3bEdiZmRCc2I3MC95ZFdmdmpQ?= =?utf-8?B?T1U1Y2JtdWY4WWJpSjNOUE11VFg4S0FtK0tzRXFXTk9NNWpIQmx4eWQ2M010?= =?utf-8?B?N1pRclJMR1A3MzEzUkYxaG1VK0hDbHYyUlhiOXpVUzVESzN3c0ZZOXNMc1VE?= =?utf-8?B?cUd0NGJub3lMWUp0enRmeDAxbFVWZ2cwSlJoSEg3NWtndVlOMTBuZGt6OHBi?= =?utf-8?B?VFNBSGc0OHJSVVpPbysrWjhSbGFxSFlJUUFDNytmZ1FGMXNaSThXS1JwRE1L?= =?utf-8?B?WnlWLzZGTXBINkRiaEhsOFVlRHYxNWlTMGJneUQwVFhHelI2Nm4xaHlFeVBM?= =?utf-8?B?NWRUMTZQOG5idW9BS3lIaXFPTHhtbWx1UktIMzh0VGgxL1dPdzV6OWNkREJ0?= =?utf-8?B?U0VrY1gvcEJVdzRQbFkvK1FRUTNyazNXQ3Uwek04MXUyb0gweEZ2VFZLam5w?= =?utf-8?B?VTBaYVI2dWxYbHZpN2VlWll4WjhkMjEvbmZwL0lKNlJxUHNVV1g2QVBjMWd1?= =?utf-8?B?Zks2bnlidkR1OHJBOUlWSk1Zak9SWnhRa3ZzdXdtY2lQbU1hY2xnTHZQV0hE?= =?utf-8?B?NVFRNHd5b2J2MjRvL01rRmtURTJMdXZRaVpmT2xockVjZCtqcG8zd0JkTE9r?= =?utf-8?B?dzhNankvNlNsYzk3SjljVkVqWUpYTi90VXpZRSt4MVZxb0dKb3BHS0diZUJY?= =?utf-8?B?MnVPeFBuRWJpQnJJbGRLbmhpbHloYjhUajVGbTZmVjZ4UXRwRXBKNGVJYjlw?= =?utf-8?B?VnBDOEN3L2hXVXRUSnp2dDJ3YkxmSk5TdGJvN0hvYnBXTDFUTThXRnVQVE9v?= =?utf-8?B?enN4cVMrY0xuWkpmKzNJL09UU21JQUs2c2hYWjJCMnVxeFJQWjJnVEM5T09r?= =?utf-8?B?c1Z0NlNYVjB0U1JsMDBLLzM2L3FmTWxpNllrM3k2V2ZNdTE2RUw1VXZ4YzZT?= =?utf-8?B?V0RlYVBIYlNSVVh5RVFkNHNRUG5zSHNXVnBMUmVxb2xKUjJjQkh4TUYwV3BP?= =?utf-8?B?V2hDT3FhZ0pwQWJDVkFVbC9IRXdNeGxrdjhONmdkVWJHZXBReDhHWENvV2E5?= =?utf-8?B?Q0ZzU0VLNGZFWnZKdE9qbm9xd1FjZlpqNGsxbWVraTJNSE5XVDR1RHNJeEJ3?= =?utf-8?B?S0YySzJMOEo2N2h3WUlDcWg0cmNJQjIrNEJGNmFhZExwdWU1TXJKY2g3SlA4?= =?utf-8?B?YVJ4U3dpZnl1bnhRN0lUUEJqd0hJL1lDTkVuaXBuYjMyMGttYmlFV0ZocEsw?= =?utf-8?B?M2FIYW9zNk5kbjZSTmNqcFNvTUp1Tll2R1RJMllyVm1adm01MkwwU1ZYRzVV?= =?utf-8?B?SkhKQU1wVmVDN3VnWjMwNnpBSU1nPT0=?= X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8198f342-2bc5-4114-9a35-08ddbf8f4fc0 X-MS-Exchange-CrossTenant-AuthSource: PH0PR02MB7159.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jul 2025 08:53:59.6539 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: I4GpX7fu24THLgUHe6PQ1Orn5tBQFTjPcnj+ukOM+0bM/21P7/Rec9hTQVy1K0EOUsR6A5HfGIlnYLgvQxt3Ha/VhYaL/23+puf4uJLgJVc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR02MB8048 X-Proofpoint-ORIG-GUID: 6ek0-VumRybRkUyrem4dqog8tIlovS87 X-Authority-Analysis: v=2.4 cv=ccXSrmDM c=1 sm=1 tr=0 ts=686f7fa9 cx=c_pps a=gsriAIW9IgONcNjeu7BG8g==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Wb1JkmetP80A:10 a=0kUYKlekyDsA:10 a=64Cc0HZtAAAA:8 a=KKAkSRfTAAAA:8 a=m4-MuDShih0a2sssyXkA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-GUID: 6ek0-VumRybRkUyrem4dqog8tIlovS87 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNzEwMDA3NSBTYWx0ZWRfXyg97jzyLMyUY sShml2hzLMjcbpGhVwwL2aTDxrl+ed8ilcVSbrTOhTy8cIbEHSUUTawS6fRtV/51f0M1MTJnAFy O4+eniLJJJeRJLoTbgr27chVA5QsuGOsjp2GINLjoP/ltJm5qYebqCaPKU3I6xNijb1i4D0WpHZ 4TBrjnjJj3JSv16x5DBwCYu5sXgYheZlxYYe73SDM132A/q2cctA5zfeRri1ELKFJULFqKqOujD fMFNEYMufr3SQ/Ykgh4lwrEKfqHkZHBE12UztMKm/soQkFWTCoZz1ZDdc6noaj4sxCf9osXKo+m c80IwRwjjRWvIqE2cCeIWGXe6dHTtu6gNtqO7/s9fU5FnlgaGVmiOlhT+tV/JCrYq96v8mMAKed YtFD1IEpQnOM8YSdnyyD/q8Ic9rEbT5Z0CS8XeyrLMRTljmPu2SLUejKADqSkZLkJVJyjEUM X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.7,FMLib:17.12.80.40 definitions=2025-07-10_01,2025-07-09_01,2025-03-28_01 X-Proofpoint-Spam-Reason: safe Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=148.163.151.68; envelope-from=mark.caveayland@nutanix.com; helo=mx0a-002c1b01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @nutanix.com) X-ZM-MESSAGEID: 1752137744538116600 By definition PCI can never be enabled on an isapc machine so hardcode the = PCIBus argument of pc_nic_init() to NULL. Signed-off-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- hw/i386/pc_piix.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index 7b38e37d7b..70eaf5ed48 100644 --- a/hw/i386/pc_piix.c +++ b/hw/i386/pc_piix.c @@ -500,7 +500,7 @@ static void pc_init_isa(MachineState *machine) pc_basic_device_init(pcms, isa_bus, x86ms->gsi, x86ms->rtc, !MACHINE_CLASS(pcmc)->no_floppy, 0x4); =20 - pc_nic_init(pcmc, isa_bus, pcms->pcibus); + pc_nic_init(pcmc, isa_bus, NULL); =20 ide_drive_get(hd, ARRAY_SIZE(hd)); for (i =3D 0; i < MAX_IDE_BUS; i++) { --=20 2.43.0 From nobody Sat Nov 15 10:54:05 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass(p=none dis=none) header.from=nutanix.com ARC-Seal: i=2; a=rsa-sha256; t=1752137750; cv=pass; d=zohomail.com; s=zohoarc; b=bXpSQcppBpjq/r5ELG02QCIi/yFGSCzU7JTbtg7QBRqP5euT3B0nIs83KY6SfCrEnrWjvYEDAbXEbi4h3hGXwzxLYmou6YwwzfeHfg4tFc/ix/PDfjSHe6LP4vwim7LB8YTFBjZ72LnCB58kMuHqRrzjVb2yPnvOSsalcUBVzvo= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1752137750; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=srwo/MTicQQFXhI1NLoXSJCzuRP7LozOadrVDq6TlCE=; b=Adu5cl1CLKqh3OoKnxuXQ7bQ8HiJZ894OoPumvu8RAnJebjGn6SqULyW5vwNB/TTfapcEtOGKEkCn+c/SP1EYmO+JXRs2+LssTPs9pFNz6zdAT1VXXuvqtv86ACM4y5I2aPusuTSeO4SvPou5aMVAiPuRxfY51VzaZVO8ycouu4= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1752137750691502.6797331281556; Thu, 10 Jul 2025 01:55:50 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uZn2i-0000QM-PA; Thu, 10 Jul 2025 04:54:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uZn2f-0000EQ-2a for qemu-devel@nongnu.org; Thu, 10 Jul 2025 04:54:09 -0400 Received: from mx0b-002c1b01.pphosted.com ([148.163.155.12]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uZn2c-0003a7-Fp for qemu-devel@nongnu.org; Thu, 10 Jul 2025 04:54:08 -0400 Received: from pps.filterd (m0127843.ppops.net [127.0.0.1]) by mx0b-002c1b01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 56A8Xk9F005901; Thu, 10 Jul 2025 01:54:04 -0700 Received: from dm1pr04cu001.outbound.protection.outlook.com (mail-centralusazon11020140.outbound.protection.outlook.com [52.101.61.140]) by mx0b-002c1b01.pphosted.com (PPS) with ESMTPS id 47ta49g1h6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 10 Jul 2025 01:54:04 -0700 (PDT) Received: from PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) by BN0PR02MB8048.namprd02.prod.outlook.com (2603:10b6:408:16a::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8901.29; Thu, 10 Jul 2025 08:54:02 +0000 Received: from PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88]) by PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88%5]) with mapi id 15.20.8901.028; Thu, 10 Jul 2025 08:54:02 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint20171006; bh=srwo/MTicQQFXhI1NLoXSJCzuRP7LozOadrVDq6Tl CE=; b=I0XwOqRZLQat4fAkqvxj0/5GVa/DdTsPP/f7VLk2lo5eP21kqKYcgUxEn kUCe5lrX6gy0yGgWDhtVdyxbE2GX985lJXo7L+jlpU4oLyIwLiAtDPp75si3IOJv XIainsfwilEys6sPhPeyeexjzV15P/rCgCDIHSdtR+MPCPpHwpdjit4MsK4fGB0d gjfJ2lTiImivfNWpp2eM/cKXp4IsThrbgTl5SEmzNk6shs0cVD+CpopeVIywSGOs EzP27PHpVmTbBJYvPpQV67XPj8CuUT4K0ns6fZ4g7PMei0KDgmh5b4AxE2I1YAe4 VxdiefkHxySWPeENtcDOHN+ba36AA== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=R7QbpxO97HMRGIuPCSOeTYWcPJy23AyOTn3VqPavNKBhIB+UZBfh3T5wntDvrEaj0GdX6nq79qY/SUnoBZJRQpsnEEpG7xKWYlEcatzj+8TnfpBZxMHMB+nbWNWGxYohaPbddymB1y2+BX27/+cDV/yX83rB/uaUzPo7W4sUA/vVqTzlZJJOXo5EHFSzGTAUIDVMBeHjy+dNeSrF1MQcpPhMjYy6mtBbSKkNqE6tfPOMMVPOsHYgEPrNdU1C5KqLOvvHt2X+DQD4jupQ02dVhTO+aLmTmQ9DtfIFsKnrQUe85h+TFBVLD2Mlnysd3A429NjzCmmldTkYl7fRZKCS2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=srwo/MTicQQFXhI1NLoXSJCzuRP7LozOadrVDq6TlCE=; b=opLEwHEQz8z5mnAMre/3pnpv3bmNiP2sJW93hkQ0mL+QyrLwELNu++0RqfOKzoQrJnvpByvih1ja1rhvXoEQ7Aq6qpB4r9a5kr4UsIvPalyRFpxsezJyOdQ6Hvavv02wnqgvShRzBKGu+mpslP0VJErjBRVyL320NayMnIgIN7hyKOU9idh+8AoEiaXLelwwrUhpLB9jMsxy1BARgNWjl1fDMbpuLZxmJjFiR4SJ/kW8DQ6olIz1GdDr63txRzHInBGyrqUbX17Eq7y3n8W5tooDL9Oue/9IQdd+Roj0RF0HJ/U5ThRk+G85ZqOyAC/DEWMnxpdicKjKBctMYacLcA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=srwo/MTicQQFXhI1NLoXSJCzuRP7LozOadrVDq6TlCE=; b=eZuuT+h2Ko17JQwMbbFLd9g4BoJ0lGIOeBbQ+eEViu2B4PydHtOyi0BXQ46/sisg1tXZsE5w3wHikEAzr8sS2Gq8dgRqcDw/I5oAxaLWMslmrsc6BTz+9MD8BDS8FFL60kNZa8OKpXS22f6isKiaeWpmyPlx/IahzpKgIpyZWCbDrR1+8PA/jJHLcmzqHEmePo8Ht9iuabNVN9UZup/y9tto8nXxyr3rlfe++yPWch6x9SIRHIV6/eGY9fUdspFcCpA/Hq5r1wkfiM4SZmSmDJVZT0X8JuHvR51b5fbGvGBrX5FPNg3S6j98XO2s5E6lOui7y3cnnadnyJSEYNweaw== From: Mark Cave-Ayland To: pbonzini@redhat.com, mst@redhat.com, marcel.apfelbaum@gmail.com, eduardo@habkost.net, imammedo@redhat.com, qemu-devel@nongnu.org Subject: [PATCH v4 14/18] hw/i386/pc_piix.c: assume pcmc->pci_enabled is always true in pc_init1() Date: Thu, 10 Jul 2025 09:52:29 +0100 Message-ID: <20250710085308.420774-15-mark.caveayland@nutanix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250710085308.420774-1-mark.caveayland@nutanix.com> References: <20250710085308.420774-1-mark.caveayland@nutanix.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AM8P191CA0023.EURP191.PROD.OUTLOOK.COM (2603:10a6:20b:21a::28) To PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR02MB7159:EE_|BN0PR02MB8048:EE_ X-MS-Office365-Filtering-Correlation-Id: ff85ec56-bd4a-4389-8135-08ddbf8f5186 x-proofpoint-crosstenant: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|376014|366016|10070799003; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?YOanoCffa6+d+9AByA0ttN0WiD2qjavdcjJCYQBT3UZJVboBSAblU/opXahe?= =?us-ascii?Q?PXiwq0+pU6txSznyeH5uTwOluMNeOjFj3pUSGn+kyW1gMAaotCbrN8Yh978D?= =?us-ascii?Q?rWqq5IyPLkR7ZCx6fbAbYYNK+3sL1hMMvhWNjJBEkQE5tJlTVEnWe/LUJCqM?= =?us-ascii?Q?8NWEIFdwXHreqqX2a18kjdlDdTlR1K9G3H9ycS978VzAN/zGN3jJOopQHl3R?= =?us-ascii?Q?7w17avsyCGLy3aLqkQHEEecUtYWUBkpPIhsoO/l8NaPPFZ5cMC9076whP1vf?= =?us-ascii?Q?6EIVSx16UHuUKX6i1npHOB7KLKteNLXzfmxxaOPvxqZ3jCRv/rtdFk/Eq4v7?= =?us-ascii?Q?wYZhu6lxUq34LZ5/bV008vAc37q1XexQzzwY5n/FK3nulxZUJ/+Ayr7ksYco?= =?us-ascii?Q?xZFotJ980FO7astOYfGOrHKGk9UaVBc/lKf8WTka4TUFZkmb3TVOfCab+tqR?= =?us-ascii?Q?7xNLoQaUUrxZkUq7fXs26SJ9tue4lTSm22PoXu7AUMwxrOU0rYZKAutAHeCj?= =?us-ascii?Q?VtwHUOYp1IJrn476uR0C4zWQtLyWDpZ/00HuVr6wwghiBNBA5CvoAKpp2oyr?= =?us-ascii?Q?Hg4Arj0MSFDFIprRmC/5skGHNQQLwC/WYd4cl5WiiRV7qBlKcPkYxKYpxwGe?= =?us-ascii?Q?HDU0YnNTfpQsbCwx7NUK+tuXh8KGWOD8CcposNq//hQDHZFkp3LIkPFmCJwE?= =?us-ascii?Q?Z6qTqsex2Lu+XZ9urhncKlSJEiI7vYPUWNVeBK2k/BhfgDH/RYlAOJ0rwATt?= =?us-ascii?Q?vaakJ978nKUJwiook5hQa4lelCQGBbIlP8sLnC3HNXBLZs/RtLiyWtpreedj?= =?us-ascii?Q?T/uNn3OvfmwD4+2N5a2AZrEIUFHEOGVxA6v+7tdWG5rdlx8xWOhOPzubESI3?= =?us-ascii?Q?GOOoiavUEAAsdEyieUJlGPwhiuXREI9l1ogJRRiV1lpmQiJlS8ve2MksW3L4?= =?us-ascii?Q?yi/G/VovHzHu6GFWuf9xnmVPBuFFRx0/W+fw9n3huflxpsfxBEp9hVvMPNud?= =?us-ascii?Q?hYIAdnebxOwAOlbez2Ew3V0kGOCguai+lkA5innyydx/h7LhHRi9Hs0jx/2q?= =?us-ascii?Q?jRBUvzNbDT5UAJadszUwlTr9c7iqFKpfagonJxVLUYaOG9uCvTV1Aa4R4D+j?= =?us-ascii?Q?CEqdr8BP3kS+x3jZVxE4/PS35/+NyrXrUVinQN2V80+z1RTW22sEyuGa/foN?= =?us-ascii?Q?eOtSNIwgpDhnwPZsxm0pqHDBN39VDdrC2OlgHWpl/iI2ZeY8nrKVjNSIehvu?= =?us-ascii?Q?HbHm3NG3StrTgEA6HqlI1ecUiKzSyvZ10E+ipLki6P+xMFft9Dh7uDD8aADB?= =?us-ascii?Q?O6fW9ASlK7ubm2AQd1oADLodtN2VJCLzLpH32DCidCGlv0YGBWY4groKAGmh?= =?us-ascii?Q?x/C6Kbrmz9m9QRznA/+oUiFxSrlOgog289FHJSH8tn0+Yqy5rND3Nc1V/C5p?= =?us-ascii?Q?fHa2gUTzhuM=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR02MB7159.namprd02.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(376014)(366016)(10070799003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?FOgVqFk4Fm/HFPsA3ooQoOjjcZYGG2IJOPKYcb/zhoy9Qb+86wVv70i4DNS6?= =?us-ascii?Q?1aAX11Zl62YclRr7ATUpeUvml2g86GVkC+s5vuLeItoACTermahv9C5hjfAN?= =?us-ascii?Q?ysPtXaQkqdsSy8GhToCBLqr2o4s9f7EN9x+pbTiO0tJMYjYSxHqUC6muaCEO?= =?us-ascii?Q?mYv8XCzdv0q1RIrAVvLshkeeOfBBrNzhnCs7VXjvjjUs1OnSHlF9w/bSOvwb?= =?us-ascii?Q?mq26sEPu6Quxs6PbA8aM4zHyMTTjoLNE+SaZ7fg7smM+Wl+bh+W4BDztICbi?= =?us-ascii?Q?pfZZ1PjlWqVgTQVPFI9PGrw+FfMAD26rUby5gGBUpsHOZfmFzNpzAXOrmTrQ?= =?us-ascii?Q?r59V6NwTNN1KBZ9SFmHcFK6PiZYFLhy7MvZXGirmdLh3NI/WY88acRkmjTh1?= =?us-ascii?Q?UsvP5xd+mMQr1e3Of0kJvza00Styp4XQFfEQj6bCultm3gnzQnSyeIySY39A?= =?us-ascii?Q?EK31zdHcQ8ri1OZsiV8sNmpQ12vZsYIOi6/zwE/DGzfyTl0daLrzimP9u1SY?= =?us-ascii?Q?g6s2Ovhbjk97CT2o3UXs9eBqWTSupe3T27l6gy6kXCIe4RwU2yUlzSRH3qDO?= =?us-ascii?Q?eBhWlNMjW/iUT0XX01lzXgMwdngh7wB6DnC4PncV0VJmLHrbFjtwV5M5Lnni?= =?us-ascii?Q?LNcccaNQviB1c0gdX9TRcgVwgI/+Ws+qxogbcfz8oKJnE0M9hJMwWmIzvnr5?= =?us-ascii?Q?8vKv0DOUtHk+E9c01cdqfecBYeh3tepvuYRqU7+pat4CFOVY+E2303TUVaBT?= =?us-ascii?Q?cbYI7dA3ULrlsplIKJ4bwtS5Dp8aMSjcDYyv+FfkqE41KvLvksBt3EdOTxdY?= =?us-ascii?Q?s4ublmJa9FURMyWzpatv0be6KeqRtl0t9tfO54qErYyGYGZEuldF+gn7dx6/?= =?us-ascii?Q?GeXiI+GS4YWKFIFBMQO+ihIUNymopidVDSO8X2oZJJhtzsYqNwl8dawgRD4a?= =?us-ascii?Q?CV87DDs6mcrdbAXVijHlD0D+WsTX9GwyDkP86RyVnINC4s6UO54Pu753oao5?= =?us-ascii?Q?xfavRGT4wNrKBDiN6wdoyoJVSS4mLyNGzPpAq4Zmi9Fh7sQu8Owwa9V4ksiD?= =?us-ascii?Q?bBGgCNGzZHuUiZ/L800N+jtc92AA2Filjtd42T0obZbPA4V16C+ZXBuW9QPZ?= =?us-ascii?Q?koTt4ldmlG8cu/I5bfrS2Fuc6x0eZGY4k1l1aSgcAarVZX/d1YKeSpdU9aa1?= =?us-ascii?Q?dHOrFv2pmcEJBRyDPJMzJt6JdMsKsexKzfRSFanyW6+k+fsRm36m9uY3y4Dj?= =?us-ascii?Q?lLEewiHQXe8Wtscoi4GmLW6N/nUUTRWtQf7WesonwnIx7KTaJ8nWlMlrhlJP?= =?us-ascii?Q?HTt/2o/DWpsgpjT4zmLJzkbo9KSsgNRDJsDHr3QkAzks6F5a6zl+dd3PuGb8?= =?us-ascii?Q?vA2EdK3z6iQxmmpJgqQckNvY5SzlJF7QtKDGatbytK9BtM9Ii14Bwd4hvlT6?= =?us-ascii?Q?KHAvSuHbfD/egvHB6/eTueUsmo3Nk2pq4SOABUakI67twIWaEasF4H/kt4FL?= =?us-ascii?Q?WLyE9qlfICT3EsxdfSMHNptoHTu04r2exNSepcoDqBVcZiewdi78+si2axuc?= =?us-ascii?Q?rmYgEed2LGH3NoopZSVHWewYIPbBWwynmELuhbbhwIeSUhzJUC5B2c54VyiK?= =?us-ascii?Q?qWdMZj5W4q+usggjh4GdX6ENrd20nZJkDQ6jswbLzhabelnO4GOBJC55n9eI?= =?us-ascii?Q?CNrtsg=3D=3D?= X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: ff85ec56-bd4a-4389-8135-08ddbf8f5186 X-MS-Exchange-CrossTenant-AuthSource: PH0PR02MB7159.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jul 2025 08:54:02.6428 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: nKhuq5GXh8A5OioZjQebwCKlrdDLMR4Hb6snfMWdkdecSEZz471044uzJEedeXKMsWxQ9hcBFKXzr+Zzymn/KAnxxcsReWx2rgrXc03UuF0= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR02MB8048 X-Proofpoint-ORIG-GUID: 2NmgLb-S3G4aQs6NIFV3dA2yS0v8Xm8M X-Proofpoint-GUID: 2NmgLb-S3G4aQs6NIFV3dA2yS0v8Xm8M X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNzEwMDA3NSBTYWx0ZWRfX5uSAIqXuzQZm sSVv3DA2MW0zyWgZvgsKWHuUvDO0yBhBCXTRZ+cKGe3WH/3sMHsC1HdLJ1ylROJWYMXsYL1dnbU /N/9Wk8Lva1RtmRl9rWpDmfH/hY4bt4yB35CYEcnQMeBHBH7Sv/X1dA6yGUWNWdgf22ua6cYVj/ 4xM78VU07E8jQjTWkDSAXMDWamA25Dv6BNKqC1xvGMmMupak2o43oSZ3ZaEA5oiKDP0PM65fNGi yrPdOdyk8iRpmsxww1er90bKqeF4o/ymj/jgODAyzFTP1fy+XHy1nmRT7Bcg/THlpduVQxElI+y OospVw19hx1i5DD2PFkWZNvtlaSY1d3DPgNbLwOddzrGD6qG55RAvqpoNSiInLuYhAzvDQ42ecT TpZOG8E0mOD4y+k24AzH7r+otYHlSJX1T9v8zRxoMyc4/bHG1qIJfhvjYKWIfKSH49bOcvtC X-Authority-Analysis: v=2.4 cv=fNg53Yae c=1 sm=1 tr=0 ts=686f7fac cx=c_pps a=I4ZpZOlEiWfCXB4Cv/CMvA==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=xqWC_Br6kY4A:10 a=Wb1JkmetP80A:10 a=0kUYKlekyDsA:10 a=64Cc0HZtAAAA:8 a=lP01sPVOnlGqiXarDuQA:9 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.7,FMLib:17.12.80.40 definitions=2025-07-10_01,2025-07-09_01,2025-03-28_01 X-Proofpoint-Spam-Reason: safe Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=148.163.155.12; envelope-from=mark.caveayland@nutanix.com; helo=mx0b-002c1b01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @nutanix.com) X-ZM-MESSAGEID: 1752137753016116600 Content-Type: text/plain; charset="utf-8" PCI is always enabled on the pc-i440fx machine so hardcode the relevant log= ic in pc_init1(). Signed-off-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- hw/i386/pc_piix.c | 194 ++++++++++++++++++---------------------------- 1 file changed, 76 insertions(+), 118 deletions(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index 70eaf5ed48..cac016df22 100644 --- a/hw/i386/pc_piix.c +++ b/hw/i386/pc_piix.c @@ -70,7 +70,7 @@ =20 #define XEN_IOAPIC_NUM_PIRQS 128ULL =20 -#ifdef CONFIG_IDE_ISA +#ifdef CONFIG_ISAPC static const int ide_iobase[MAX_IDE_BUS] =3D { 0x1f0, 0x170 }; static const int ide_iobase2[MAX_IDE_BUS] =3D { 0x3f6, 0x376 }; static const int ide_irq[MAX_IDE_BUS] =3D { 14, 15 }; @@ -117,6 +117,9 @@ static void pc_init1(MachineState *machine, const char = *pci_type) MemoryRegion *rom_memory =3D system_memory; ram_addr_t lowmem; uint64_t hole64_size =3D 0; + PCIDevice *pci_dev; + DeviceState *dev; + size_t i; =20 /* * Calculate ram split, for memory below and above 4G. It's a bit @@ -187,38 +190,36 @@ static void pc_init1(MachineState *machine, const cha= r *pci_type) kvmclock_create(pcmc->kvmclock_create_always); } =20 - if (pcmc->pci_enabled) { - pci_memory =3D g_new(MemoryRegion, 1); - memory_region_init(pci_memory, NULL, "pci", UINT64_MAX); - rom_memory =3D pci_memory; - - phb =3D OBJECT(qdev_new(TYPE_I440FX_PCI_HOST_BRIDGE)); - object_property_add_child(OBJECT(machine), "i440fx", phb); - object_property_set_link(phb, PCI_HOST_PROP_RAM_MEM, - OBJECT(ram_memory), &error_fatal); - object_property_set_link(phb, PCI_HOST_PROP_PCI_MEM, - OBJECT(pci_memory), &error_fatal); - object_property_set_link(phb, PCI_HOST_PROP_SYSTEM_MEM, - OBJECT(system_memory), &error_fatal); - object_property_set_link(phb, PCI_HOST_PROP_IO_MEM, - OBJECT(system_io), &error_fatal); - object_property_set_uint(phb, PCI_HOST_BELOW_4G_MEM_SIZE, - x86ms->below_4g_mem_size, &error_fatal); - object_property_set_uint(phb, PCI_HOST_ABOVE_4G_MEM_SIZE, - x86ms->above_4g_mem_size, &error_fatal); - object_property_set_str(phb, I440FX_HOST_PROP_PCI_TYPE, pci_type, - &error_fatal); - sysbus_realize_and_unref(SYS_BUS_DEVICE(phb), &error_fatal); - - pcms->pcibus =3D PCI_BUS(qdev_get_child_bus(DEVICE(phb), "pci.0")); - pci_bus_map_irqs(pcms->pcibus, - xen_enabled() ? xen_pci_slot_get_pirq - : pc_pci_slot_get_pirq); - - hole64_size =3D object_property_get_uint(phb, - PCI_HOST_PROP_PCI_HOLE64_SI= ZE, - &error_abort); - } + pci_memory =3D g_new(MemoryRegion, 1); + memory_region_init(pci_memory, NULL, "pci", UINT64_MAX); + rom_memory =3D pci_memory; + + phb =3D OBJECT(qdev_new(TYPE_I440FX_PCI_HOST_BRIDGE)); + object_property_add_child(OBJECT(machine), "i440fx", phb); + object_property_set_link(phb, PCI_HOST_PROP_RAM_MEM, + OBJECT(ram_memory), &error_fatal); + object_property_set_link(phb, PCI_HOST_PROP_PCI_MEM, + OBJECT(pci_memory), &error_fatal); + object_property_set_link(phb, PCI_HOST_PROP_SYSTEM_MEM, + OBJECT(system_memory), &error_fatal); + object_property_set_link(phb, PCI_HOST_PROP_IO_MEM, + OBJECT(system_io), &error_fatal); + object_property_set_uint(phb, PCI_HOST_BELOW_4G_MEM_SIZE, + x86ms->below_4g_mem_size, &error_fatal); + object_property_set_uint(phb, PCI_HOST_ABOVE_4G_MEM_SIZE, + x86ms->above_4g_mem_size, &error_fatal); + object_property_set_str(phb, I440FX_HOST_PROP_PCI_TYPE, pci_type, + &error_fatal); + sysbus_realize_and_unref(SYS_BUS_DEVICE(phb), &error_fatal); + + pcms->pcibus =3D PCI_BUS(qdev_get_child_bus(DEVICE(phb), "pci.0")); + pci_bus_map_irqs(pcms->pcibus, + xen_enabled() ? xen_pci_slot_get_pirq + : pc_pci_slot_get_pirq); + + hole64_size =3D object_property_get_uint(phb, + PCI_HOST_PROP_PCI_HOLE64_SIZE, + &error_abort); =20 /* allocate ram and load rom/bios */ if (!xen_enabled()) { @@ -234,72 +235,51 @@ static void pc_init1(MachineState *machine, const cha= r *pci_type) } } =20 - gsi_state =3D pc_gsi_create(&x86ms->gsi, pcmc->pci_enabled); - - if (pcmc->pci_enabled) { - PCIDevice *pci_dev; - DeviceState *dev; - size_t i; - - pci_dev =3D pci_new_multifunction(-1, pcms->south_bridge); - object_property_set_bool(OBJECT(pci_dev), "has-usb", - machine_usb(machine), &error_abort); - object_property_set_bool(OBJECT(pci_dev), "has-acpi", - x86_machine_is_acpi_enabled(x86ms), - &error_abort); - object_property_set_bool(OBJECT(pci_dev), "has-pic", false, - &error_abort); - object_property_set_bool(OBJECT(pci_dev), "has-pit", false, - &error_abort); - qdev_prop_set_uint32(DEVICE(pci_dev), "smb_io_base", 0xb100); - object_property_set_bool(OBJECT(pci_dev), "smm-enabled", - x86_machine_is_smm_enabled(x86ms), - &error_abort); - dev =3D DEVICE(pci_dev); - for (i =3D 0; i < ISA_NUM_IRQS; i++) { - qdev_connect_gpio_out_named(dev, "isa-irqs", i, x86ms->gsi[i]); - } - pci_realize_and_unref(pci_dev, pcms->pcibus, &error_fatal); - - if (xen_enabled()) { - pci_device_set_intx_routing_notifier( - pci_dev, piix_intx_routing_notifier_xen); - - /* - * Xen supports additional interrupt routes from the PCI devic= es to - * the IOAPIC: the four pins of each PCI device on the bus are= also - * connected to the IOAPIC directly. - * These additional routes can be discovered through ACPI. - */ - pci_bus_irqs(pcms->pcibus, xen_intx_set_irq, pci_dev, - XEN_IOAPIC_NUM_PIRQS); - } + gsi_state =3D pc_gsi_create(&x86ms->gsi, true); + + pci_dev =3D pci_new_multifunction(-1, pcms->south_bridge); + object_property_set_bool(OBJECT(pci_dev), "has-usb", + machine_usb(machine), &error_abort); + object_property_set_bool(OBJECT(pci_dev), "has-acpi", + x86_machine_is_acpi_enabled(x86ms), + &error_abort); + object_property_set_bool(OBJECT(pci_dev), "has-pic", false, + &error_abort); + object_property_set_bool(OBJECT(pci_dev), "has-pit", false, + &error_abort); + qdev_prop_set_uint32(DEVICE(pci_dev), "smb_io_base", 0xb100); + object_property_set_bool(OBJECT(pci_dev), "smm-enabled", + x86_machine_is_smm_enabled(x86ms), + &error_abort); + dev =3D DEVICE(pci_dev); + for (i =3D 0; i < ISA_NUM_IRQS; i++) { + qdev_connect_gpio_out_named(dev, "isa-irqs", i, x86ms->gsi[i]); + } + pci_realize_and_unref(pci_dev, pcms->pcibus, &error_fatal); =20 - isa_bus =3D ISA_BUS(qdev_get_child_bus(DEVICE(pci_dev), "isa.0")); - x86ms->rtc =3D ISA_DEVICE(object_resolve_path_component(OBJECT(pci= _dev), - "rtc")); - piix4_pm =3D object_resolve_path_component(OBJECT(pci_dev), "pm"); - dev =3D DEVICE(object_resolve_path_component(OBJECT(pci_dev), "ide= ")); - pci_ide_create_devs(PCI_DEVICE(dev)); - pcms->idebus[0] =3D qdev_get_child_bus(dev, "ide.0"); - pcms->idebus[1] =3D qdev_get_child_bus(dev, "ide.1"); - } else { - uint32_t irq; + if (xen_enabled()) { + pci_device_set_intx_routing_notifier( + pci_dev, piix_intx_routing_notifier_xen); =20 - isa_bus =3D isa_bus_new(NULL, system_memory, system_io, - &error_abort); - isa_bus_register_input_irqs(isa_bus, x86ms->gsi); + /* + * Xen supports additional interrupt routes from the PCI devices to + * the IOAPIC: the four pins of each PCI device on the bus are also + * connected to the IOAPIC directly. + * These additional routes can be discovered through ACPI. + */ + pci_bus_irqs(pcms->pcibus, xen_intx_set_irq, pci_dev, + XEN_IOAPIC_NUM_PIRQS); + } =20 - x86ms->rtc =3D isa_new(TYPE_MC146818_RTC); - qdev_prop_set_int32(DEVICE(x86ms->rtc), "base_year", 2000); - isa_realize_and_unref(x86ms->rtc, isa_bus, &error_fatal); - irq =3D object_property_get_uint(OBJECT(x86ms->rtc), "irq", - &error_fatal); - isa_connect_gpio_out(ISA_DEVICE(x86ms->rtc), 0, irq); + isa_bus =3D ISA_BUS(qdev_get_child_bus(DEVICE(pci_dev), "isa.0")); + x86ms->rtc =3D ISA_DEVICE(object_resolve_path_component(OBJECT(pci_dev= ), + "rtc")); + piix4_pm =3D object_resolve_path_component(OBJECT(pci_dev), "pm"); + dev =3D DEVICE(object_resolve_path_component(OBJECT(pci_dev), "ide")); + pci_ide_create_devs(PCI_DEVICE(dev)); + pcms->idebus[0] =3D qdev_get_child_bus(dev, "ide.0"); + pcms->idebus[1] =3D qdev_get_child_bus(dev, "ide.1"); =20 - i8257_dma_init(OBJECT(machine), isa_bus, 0); - pcms->hpet_enabled =3D false; - } =20 if (x86ms->pic =3D=3D ON_OFF_AUTO_ON || x86ms->pic =3D=3D ON_OFF_AUTO_= AUTO) { pc_i8259_create(isa_bus, gsi_state->i8259_irq); @@ -313,7 +293,7 @@ static void pc_init1(MachineState *machine, const char = *pci_type) x86_register_ferr_irq(x86ms->gsi[13]); } =20 - pc_vga_init(isa_bus, pcmc->pci_enabled ? pcms->pcibus : NULL); + pc_vga_init(isa_bus, pcms->pcibus); =20 /* init basic PC hardware */ pc_basic_device_init(pcms, isa_bus, x86ms->gsi, x86ms->rtc, @@ -321,28 +301,6 @@ static void pc_init1(MachineState *machine, const char= *pci_type) =20 pc_nic_init(pcmc, isa_bus, pcms->pcibus); =20 -#ifdef CONFIG_IDE_ISA - if (!pcmc->pci_enabled) { - DriveInfo *hd[MAX_IDE_BUS * MAX_IDE_DEVS]; - int i; - - ide_drive_get(hd, ARRAY_SIZE(hd)); - for (i =3D 0; i < MAX_IDE_BUS; i++) { - ISADevice *dev; - char busname[] =3D "ide.0"; - dev =3D isa_ide_init(isa_bus, ide_iobase[i], ide_iobase2[i], - ide_irq[i], - hd[MAX_IDE_DEVS * i], hd[MAX_IDE_DEVS * i += 1]); - /* - * The ide bus name is ide.0 for the first bus and ide.1 for t= he - * second one. - */ - busname[4] =3D '0' + i; - pcms->idebus[i] =3D qdev_get_child_bus(DEVICE(dev), busname); - } - } -#endif - if (piix4_pm) { smi_irq =3D qemu_allocate_irq(pc_acpi_smi_interrupt, first_cpu, 0); =20 --=20 2.43.0 From nobody Sat Nov 15 10:54:05 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass(p=none dis=none) header.from=nutanix.com ARC-Seal: i=2; a=rsa-sha256; t=1752137671; cv=pass; d=zohomail.com; s=zohoarc; b=njVWzel1T6maq9mAa8GMnmHT5LfV0sO/ClMcZLVu6L/yVJxy4bam/If226K1Ryst4YFW0NudR/ypURtYEUY4KUBOPKTbfcx3c2Emw1q+ungA2VV3HqV+awQfu4vZddGbM6WkTyidUd/O8Qn8CdLZ5V8Phgxm5+pIyr+Sep/G234= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1752137671; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=bhW2GJXHa+LjH1mbvQvH006rmYB2gZrdpKyHb0ly7TY=; b=B8TSMg9sR3wXtFBjdePR8XoS3+ImFWJgMrj/jrXWPGd5hfzD1Y9IgOuzWWwW/FKF2cBidaX7MYTvgYjZzDFqAQHWK57E0cdyAcYGObxkOaG/j6UI4TUJnFzTQr7QZ0v35XkuWiDr6oKPyI0IaZtERY59Pd2BKEF32IfbwXmniK4= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1752137671684231.97277048987507; Thu, 10 Jul 2025 01:54:31 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uZn2n-0000av-AN; Thu, 10 Jul 2025 04:54:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uZn2k-0000Vw-O8 for qemu-devel@nongnu.org; Thu, 10 Jul 2025 04:54:14 -0400 Received: from mx0a-002c1b01.pphosted.com ([148.163.151.68]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uZn2h-0003ap-NV for qemu-devel@nongnu.org; Thu, 10 Jul 2025 04:54:14 -0400 Received: from pps.filterd (m0127838.ppops.net [127.0.0.1]) by mx0a-002c1b01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 56A6bTJG025383; Thu, 10 Jul 2025 01:54:08 -0700 Received: from cy4pr05cu001.outbound.protection.outlook.com (mail-westcentralusazon11020111.outbound.protection.outlook.com [40.93.198.111]) by mx0a-002c1b01.pphosted.com (PPS) with ESMTPS id 47q3m150mm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 10 Jul 2025 01:54:07 -0700 (PDT) Received: from PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) by BN0PR02MB8048.namprd02.prod.outlook.com (2603:10b6:408:16a::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8901.29; Thu, 10 Jul 2025 08:54:06 +0000 Received: from PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88]) by PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88%5]) with mapi id 15.20.8901.028; Thu, 10 Jul 2025 08:54:06 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint20171006; bh=bhW2GJXHa+LjH1mbvQvH006rmYB2gZrdpKyHb0ly7 TY=; b=y+RhqCvetq8hvVEd3ZEiQNRqQoRZycuVM0aguOCdu8d3NgvjrnlwQB9Wu ru5a6htQE/RX8zjQ1yVFM+mzEay6M9tfkjreQdOQxJF25/RAz6/NkAq2+NJX+eKn EA3aw5igcBK64aOIFOEmlpfh31kH7DdQ/AJkvpdEUZtGATk4quqU3bfDQHxbkW1v crpkhd/iMSL2k1kMDO8qx+EEYkowRczs9hSwSvPwJNuL8N41ouZssO9QYrxADKXu iDVk41SG/PfXoF0B7ZBUckDNea8oCz4P/Cu9XGOo5UIhagNrOAU5zbpBu+RqvU8M 6i+UsI+LVG+EgSOhH+sPgpAN12fSw== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=OO3gWIJv1jMXAjBFi/7E0P8xnKZELFRyyk3wFdIu4cAxnauRojKasuASKteytTL8KSApTyHnbNXTxHDUlA2uxLjleaz8ws2WpsHQ54vcumt8NcXoJxF0khM5StwUWEMh3660iWpa4sisqWvrLoo/z+oT7gBXDvQsnerRgBFMfn5Tg6texHyZRh47M2HgeKqx7BkdZPwOKFOqXPatRqrAN3zoNaNbQdiubk1RNKRvKgU6HEQAPJDdfJJAi2Beu0Tg5HUJGswFtyf5+Li/e5i2wWSFwFsP84GCncsUwOCpMJ5A4KE2tSA9GYoChnBRmhlmQWJ3t/iZYYjX95O9i5R4uA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bhW2GJXHa+LjH1mbvQvH006rmYB2gZrdpKyHb0ly7TY=; b=cxCIRXkFJqtZn1C2aKUJe9DS+ihfH5YvEARwIjY4bjaRLw78JoR4KKXFLcCJW+bJ/CpzPYS3DJT8DeABKAVHOdnW/1e/J1bEtrHIPwBBKOFmMxqVnWmmnTjX7se9ZgevYMlX9ispDR23bn5rNgaat4J2zjMsBeHgLPtdPz7SoYotzQF2v1dsLT/QS4nUsnUuxZQZF8fpkPQEcEIuM9Y9kMBcHTf86sBH9OcQyoeDl4OB9DY43daCJ0K8Y9TZ1SDnv8msjN2JJuY5SdpTuPaC4CKxEf+6AuOj4dGxMXUdCy1NouGbR9ycfk9CK7ft6J4YI9fLv2+dcAoY9xtwnc1tAw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bhW2GJXHa+LjH1mbvQvH006rmYB2gZrdpKyHb0ly7TY=; b=yN/6jdP0V/AmYmyq5kB86vXDZwag2IJAuQEEZ4eYSGhnuLi3dXY8KMgiF4WJomRWQfEe1jV8Xi6IzHNUgrb7kZeDwVXa9k/RY+UiejIomKHCd2V4JFVuQ4tAEkeztbbEUSBfQnaVDSNyFImAwr8r2CKx3QTs6NEewrOaN0fYkj7juTdl/JdeEbXk8qpdLdw3Sv85eVb0QnItFN8ZD8ccXE1vnUl62Is55Vx+X3O/adWpTnzRSdlNCajbUjFmI1yaXjXK1gspOWPgxv0wvuZJspECteDX4y4/vyK0Rqhl8JyWYLF3wx2+CZipjf/WXS9id9r/TMNE8tUb6lQshue75g== From: Mark Cave-Ayland To: pbonzini@redhat.com, mst@redhat.com, marcel.apfelbaum@gmail.com, eduardo@habkost.net, imammedo@redhat.com, qemu-devel@nongnu.org Subject: [PATCH v4 15/18] hw/i386: move isapc machine to separate isapc.c file Date: Thu, 10 Jul 2025 09:52:30 +0100 Message-ID: <20250710085308.420774-16-mark.caveayland@nutanix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250710085308.420774-1-mark.caveayland@nutanix.com> References: <20250710085308.420774-1-mark.caveayland@nutanix.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AM8P191CA0017.EURP191.PROD.OUTLOOK.COM (2603:10a6:20b:21a::22) To PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR02MB7159:EE_|BN0PR02MB8048:EE_ X-MS-Office365-Filtering-Correlation-Id: 52976221-19de-4cbb-9187-08ddbf8f53c8 x-proofpoint-crosstenant: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|376014|366016|10070799003; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?Q5NBJOW/9KYdLjLpqvgu1lt6lT3HzVYP/GMXKArvFFb2gsqA2CCHS/Qcl/kq?= =?us-ascii?Q?hHTWjtHOLn1z7YgBMFK3Zpc/1efL2mn93lKrnmkIsBmP5HA/m/yglbnvRG2T?= =?us-ascii?Q?Xnp9TfnDe4Slf04VB+QZoSv2OVt18vivqy7J74z6PEoGPyDq0gvtMHZudb6d?= =?us-ascii?Q?q6aOIGhEHlXJFxqTP5r4ZLSVLxpbqoFDaLDQBBp7+S3YRZO+v/5v6t7IrcK9?= =?us-ascii?Q?nbZe6gK74yJtfGg2Kf95Zf2u8d8nMnOTiTWzWc/Bk+G2x1s2H5kHxvkFaAgY?= =?us-ascii?Q?U7hoDj32f7YWWOXJOSz/+ftz5o4ji9OOHWglm2QfIQJ/Zfl2IBCGO7iN69q7?= =?us-ascii?Q?aGXbSm86PC+5K3z3iWZ/KjixALiKHm7DOAC4SPT38tgr9WeTBNiTMCLrs7Dz?= =?us-ascii?Q?cIQXQN0zAR1W5NVZmpM4CXKKI/U3pMn9c8F48+BSe/yHXfIlPmE/VwvAFuCB?= =?us-ascii?Q?hxvEWT4LbXJCwrEJIL3eu2dYKzgZjDzljDqlU4UhXUmtOru5EBxP64pKcOut?= =?us-ascii?Q?0LGkEMgIWSBKNG2KzPBw+nUkCfCp8/53gX6HjKzKTtDSvKLJVjulc7sQ5ahb?= =?us-ascii?Q?pYWbUQ6rSX9rzLbizmjbLUn6vrfhFQgVgT2UNCEom4k7i4ycS5PWLlJCFwXO?= =?us-ascii?Q?MsFN5UuUgxKfciwlukoKK/0lRafT0ox6sUZ4SIUZ00yz8nFGGwfnIxCVzwee?= =?us-ascii?Q?Txno/+HSgQpJRXWzKXdies+52z3t6pMdSHGfT6FnLy/QltNaBVu/gy1lIs/m?= =?us-ascii?Q?MMIImsGHnU4odQbB1jgHF/rvRiB08pkjZXqXJ2Wqq535swWD2it9ylm0p05B?= =?us-ascii?Q?cGYbDXemXTCxJhwLcDe+84aB6MmPxohatQwsjJvoZ0zteLkp5OY4yXcjXNA3?= =?us-ascii?Q?p5ZNi92VmB/z2mJTV82R9mVInMB70cIEjT0D9nWna2B8IDeCdr4YUF20hdKQ?= =?us-ascii?Q?4gN4bD+5Hgr/vR/X80GcumGXibNALQjiwR97XI89dWuVOZUH6ZSlJY2VBO3M?= =?us-ascii?Q?vFEGchKHXgnZkyrhfPH3WWwVjNbsJEnGwylR7ANJ300MIJHVm+8LBcEdflRe?= =?us-ascii?Q?E7purk787jRkIHMl3R39h30HeSLkajn7YRkFahCOBaHr6ePG9RtQypr3gp9D?= =?us-ascii?Q?13T7H8HyzSQmYOxoV2URMTPSlowPy1pckjKgVk20xhmZQ3JmWbZvYcPpdWdq?= =?us-ascii?Q?RrWs9hy+WwI9JU6j/OkrVEAMFZ+0dpXqEq+cZ4O+OmYmPL8IX2p2avrYRu0p?= =?us-ascii?Q?SG2GWogJvmemQLNgWqM/K/FNHd1dCBNS3ZYnGBtOzaQa2cgSJ+vKIutDwOim?= =?us-ascii?Q?HYWAlMUYaDSLhpc5/KowFuw+YZ/JiXYYFhCpDWHPZ8+W0Y2WfcDn2K+gBrD3?= =?us-ascii?Q?DnsvxxQDUyMJu2HOqaWVMCOcu7v1qYetOXNxr/MY5ouwwLOFeIcNC2rJX7fj?= =?us-ascii?Q?huEdKkPMR+k=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR02MB7159.namprd02.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(376014)(366016)(10070799003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?kzBnGr4VuSYyWMYjAY6i4uqRN3VH6sIhbYvWNqp50PqzfZ2VW/gLrhyPEdud?= =?us-ascii?Q?YWj5mkBNRiqpsQVr0JHcdVgkgaAPIeoQfxwE2S4XJ6t/n4ukJ9nx2JNn8D0V?= =?us-ascii?Q?zi1/kQWYrO9feNhgDV47pAefcrxACFJcS+HBmx4Qk6q+CaKlaE1yUsHUe511?= =?us-ascii?Q?g4F9H1mjKkk0qSytTUEPi4REX92PziVy+XeQTJkn9mgwA8cXqFzPJNAem2sg?= =?us-ascii?Q?NaRrVNO19cSCkdr+lPK8QJA7AH2ia7bwW4puHVFVezsyrWKd1SzSFa/vA1KM?= =?us-ascii?Q?u/a/rvjPraiC4BlpVTTcIsns51Q6PO3yWTLEW++ZUz1ZRo7x9SkNWb3fTA02?= =?us-ascii?Q?FJ7zxrZeTXjSyujMatsYavnIrfrZmuII4t2T2IHUA4qWk1wnRg/scIs67EIL?= =?us-ascii?Q?iPMwGLSYQt7Yj+G8KmE+acDmOMDyUbV5dJNw9ktKksWPEQWnYs2dmEI6glN2?= =?us-ascii?Q?pOUCr+STX2lKwwpySwu4vSnbgMrVFxRCMsc5m44P+zU4iQN8/tey2D7n4kuk?= =?us-ascii?Q?Cc5QsQ/lrAvVExkkxgm6D1Yc7cISrc0WADjKNyhAIFB1pCmVM++FwyD42Uuq?= =?us-ascii?Q?+oqDQgncGQy/u+S8TtUtQN0gY0qxqJuJe4+4jp4yhDWRHWJqMTw9pkz5+LSa?= =?us-ascii?Q?jiGgvPNaB06NjfdkwRj9JJdsUswpTNpuLb/5We0cCHAg96a89RK7MHScBtGX?= =?us-ascii?Q?scic53etzhU4g1YEkKUxTKnXtt4zjLTMe/2qbcO7UkKCfEhrd6csZXiz0i5p?= =?us-ascii?Q?hnVH3HQeZ5cejb4/umlqFAEg+sWE12zTpQFFoW42ZtXcJCpIkcRCkxg37EuP?= =?us-ascii?Q?VcKjP3+87FaADNd8WXdhfeloUj72edSL+vI6vS68vSiF9/pez+Y0DpGV12qm?= =?us-ascii?Q?gzQSJcfjq+EgNnHtLwAMTG44ho6g3NgRSqpwblO+VcywfF4T+ESvdrzx12nR?= =?us-ascii?Q?YXYSmd9yHdD7I49E2n/APGkImqFTTp6D9tDk2pimMvBepVPzfM7MyTWlSTZ4?= =?us-ascii?Q?9iL0Gns5pA9d6xRyFm08RrDjgybjnZ9eEhzG8BwclifkvIpXdtk+ioriHpSd?= =?us-ascii?Q?vKVwWrsmvpPlRpzyWritdu1yduWQYeY4Ah+WigUWBc93yVqk9tEEJn0z0INF?= =?us-ascii?Q?6+o+slh1JxZjiBxovvVjcxeLc1soX6kyoUfKnpkWP33YiGjPygySXlNfJCxz?= =?us-ascii?Q?KAkJX02GACXcSY1QmbQamgIi0cEND1wPekzYZm8yHwkg7UoGrsyuamEr6Lax?= =?us-ascii?Q?/9RGIwRjEjmkbfeRJaHL7pz/sp0M1dwKijIXPs7BQ2ZLOOFE1fZBKMccJkhH?= =?us-ascii?Q?BCAOw3EAWR0Blx+iS7ib95WnoaDSZ1wBW7WY91MVQRw7X6PJQjVok6m0BA4i?= =?us-ascii?Q?XZR83YyusJ3RtU80j4Obg8aQmRUhB9z4saLOi/OSkU4s0BIWv5Noktzu/KC3?= =?us-ascii?Q?y5IiXtZKIpExMY4KawMpV9GBqAKvB/S4xV70plC0NqVAbT1B1hnJSRh6l+U/?= =?us-ascii?Q?REmYp6GYsH1rZW4WZv2yCLaRiFlsazukdVlJQNPQ+sjGVVIjduFi4fYivS/B?= =?us-ascii?Q?DNprn8R/Qw1N6rv86deKqYx+72ADmXknkQtwe1rbTVYx9imJ17o3WW4TXR1h?= =?us-ascii?Q?8YXzqJF93+Im6HTbz9dVptgBVLg3xNm3aQ3+JJPxmizXc5UiiYUog5pIIcl+?= =?us-ascii?Q?7uWdfQ=3D=3D?= X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 52976221-19de-4cbb-9187-08ddbf8f53c8 X-MS-Exchange-CrossTenant-AuthSource: PH0PR02MB7159.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jul 2025 08:54:06.4414 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: fYRJxdR9bOmtKrbGWGKdKuOA34eeWOaIdMg76rX25KeO4nzlLRm8KUzuUIT5UpVbLX6PhUQ5J4MXAE+Pfche9pWOQFmMZ1s4gohNZPaTcLw= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR02MB8048 X-Authority-Analysis: v=2.4 cv=Nffm13D4 c=1 sm=1 tr=0 ts=686f7fb0 cx=c_pps a=Lghs/6261MT82QrUgbBUQA==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=xqWC_Br6kY4A:10 a=Wb1JkmetP80A:10 a=0kUYKlekyDsA:10 a=64Cc0HZtAAAA:8 a=pGLkceISAAAA:8 a=Pbl5c31VFoorxvNN0s8A:9 X-Proofpoint-GUID: XXmvY853oCywicY9HEQ3SfZcKDKjFqox X-Proofpoint-ORIG-GUID: XXmvY853oCywicY9HEQ3SfZcKDKjFqox X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNzEwMDA3NSBTYWx0ZWRfX5X2QExFnNXBu /Lyufr0KrWrz84kNpNIgSt0j+7seRINLWEfvFGBgm3E0ZFG92GhftXj4HLXhfHtaFWG5XsVyHHX eWslq3rf442tHgdmlX5aR/zaWKjR3BXhVMU2dmOYpSzgmls2dyNqsymZXgMs2mnr7picnBL5Svg jxcy7MUQOCcZ1ZEgfk/ih78iBQfIcg1nI0KpYLV4hQk0j/nqUVTBHHrcCuAYwYfVvDnNvBfRYbx P+vS0EJK+sPa3TLbvGCfvODq0AmD2/OYkSTKRFUV6XIP1aCVtMmqdXIZIKDyWzwZje6StNPIcyO YqU/OJfxgbfpYItwKlBosVzm9oy3oWMljjh3rGVfdZsGp8aqX4PHvzMPQ/RdkBlWVoKCEFHZKpU CJOwQ0y2GvhSWmlBJ+fWS4fnvKh2FJXoGBgxgGsfD6e/DmjPzWp8h8O3GZoaj14kuNM2B9xc X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.7,FMLib:17.12.80.40 definitions=2025-07-10_01,2025-07-09_01,2025-03-28_01 X-Proofpoint-Spam-Reason: safe Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=148.163.151.68; envelope-from=mark.caveayland@nutanix.com; helo=mx0a-002c1b01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @nutanix.com) X-ZM-MESSAGEID: 1752137674156116600 Content-Type: text/plain; charset="utf-8" Now that pc_init_isa() is independent of any PCI initialisation, move it in= to a separate isapc.c file. This enables us to finally fix the dependency of ISA= PC on I440FX in hw/i386/Kconfig. Note that as part of the move to a separate file we can see that the licenc= e text is a verbatim copy of the MIT licence. The text originates from commit 1df9= 12cf9e ("VL license of the day is MIT/BSD") so we can be sure that this was the or= iginal intent. As a consequence we can update the file header to use a SPDX tag as= per the current project contribution guidelines. Signed-off-by: Mark Cave-Ayland Reviewed-by: Bernhard Beschow --- hw/i386/Kconfig | 3 - hw/i386/isapc.c | 168 ++++++++++++++++++++++++++++++++++++++++++++ hw/i386/meson.build | 1 + hw/i386/pc_piix.c | 148 -------------------------------------- 4 files changed, 169 insertions(+), 151 deletions(-) create mode 100644 hw/i386/isapc.c diff --git a/hw/i386/Kconfig b/hw/i386/Kconfig index 14d23e27b5..8ffcc9f7aa 100644 --- a/hw/i386/Kconfig +++ b/hw/i386/Kconfig @@ -96,9 +96,6 @@ config ISAPC select ISA_BUS select PC select IDE_ISA - # FIXME: it is in the same file as i440fx, and does not compile - # if separated - depends on I440FX =20 config Q35 bool diff --git a/hw/i386/isapc.c b/hw/i386/isapc.c new file mode 100644 index 0000000000..bb22083821 --- /dev/null +++ b/hw/i386/isapc.c @@ -0,0 +1,168 @@ +/* + * QEMU PC System Emulator + * + * Copyright (c) 2003-2004 Fabrice Bellard + * + * SPDX-License-Identifier: MIT + */ + +#include "qemu/osdep.h" + +#include "hw/char/parallel-isa.h" +#include "hw/dma/i8257.h" +#include "hw/i386/pc.h" +#include "hw/ide/isa.h" +#include "hw/ide/ide-bus.h" +#include "system/kvm.h" +#include "hw/i386/kvm/clock.h" +#include "hw/xen/xen-x86.h" +#include "system/xen.h" +#include "hw/rtc/mc146818rtc.h" +#include "target/i386/cpu.h" + +static const int ide_iobase[MAX_IDE_BUS] =3D { 0x1f0, 0x170 }; +static const int ide_iobase2[MAX_IDE_BUS] =3D { 0x3f6, 0x376 }; +static const int ide_irq[MAX_IDE_BUS] =3D { 14, 15 }; + + +static void pc_init_isa(MachineState *machine) +{ + PCMachineState *pcms =3D PC_MACHINE(machine); + PCMachineClass *pcmc =3D PC_MACHINE_GET_CLASS(pcms); + X86MachineState *x86ms =3D X86_MACHINE(machine); + MemoryRegion *system_memory =3D get_system_memory(); + MemoryRegion *system_io =3D get_system_io(); + ISABus *isa_bus; + GSIState *gsi_state; + MemoryRegion *ram_memory; + MemoryRegion *rom_memory =3D system_memory; + DriveInfo *hd[MAX_IDE_BUS * MAX_IDE_DEVS]; + uint32_t irq; + int i; + + /* + * There is no RAM split for the isapc machine + */ + if (xen_enabled()) { + xen_hvm_init_pc(pcms, &ram_memory); + } else { + ram_memory =3D machine->ram; + + pcms->max_ram_below_4g =3D 0xe0000000; /* default: 3.5G */ + x86ms->above_4g_mem_size =3D 0; + x86ms->below_4g_mem_size =3D machine->ram_size; + } + + /* + * There is a small chance that someone unintentionally passes "-cpu m= ax" + * for the isapc machine, which will provide a much more modern 32-bit + * CPU than would be expected for an ISA-era PC. If the "max" cpu type= has + * been specified, choose the "best" 32-bit cpu possible which we cons= ider + * be the pentium3 (deliberately choosing an Intel CPU given that the + * default 486 CPU for the isapc machine is also an Intel CPU). + */ + if (!strcmp(machine->cpu_type, X86_CPU_TYPE_NAME("max"))) { + machine->cpu_type =3D X86_CPU_TYPE_NAME("pentium3"); + } + + x86_cpus_init(x86ms, pcmc->default_cpu_version); + + if (kvm_enabled()) { + kvmclock_create(pcmc->kvmclock_create_always); + } + + /* allocate ram and load rom/bios */ + if (!xen_enabled()) { + pc_memory_init(pcms, system_memory, rom_memory, 0); + } else { + assert(machine->ram_size =3D=3D x86ms->below_4g_mem_size + + x86ms->above_4g_mem_size); + + if (machine->kernel_filename !=3D NULL) { + /* For xen HVM direct kernel boot, load linux here */ + xen_load_linux(pcms); + } + } + + gsi_state =3D pc_gsi_create(&x86ms->gsi, false); + + isa_bus =3D isa_bus_new(NULL, system_memory, system_io, + &error_abort); + isa_bus_register_input_irqs(isa_bus, x86ms->gsi); + + x86ms->rtc =3D isa_new(TYPE_MC146818_RTC); + qdev_prop_set_int32(DEVICE(x86ms->rtc), "base_year", 2000); + isa_realize_and_unref(x86ms->rtc, isa_bus, &error_fatal); + irq =3D object_property_get_uint(OBJECT(x86ms->rtc), "irq", + &error_fatal); + isa_connect_gpio_out(ISA_DEVICE(x86ms->rtc), 0, irq); + + i8257_dma_init(OBJECT(machine), isa_bus, 0); + pcms->hpet_enabled =3D false; + + if (x86ms->pic =3D=3D ON_OFF_AUTO_ON || x86ms->pic =3D=3D ON_OFF_AUTO_= AUTO) { + pc_i8259_create(isa_bus, gsi_state->i8259_irq); + } + + if (tcg_enabled()) { + x86_register_ferr_irq(x86ms->gsi[13]); + } + + pc_vga_init(isa_bus, NULL); + + /* init basic PC hardware */ + pc_basic_device_init(pcms, isa_bus, x86ms->gsi, x86ms->rtc, + !MACHINE_CLASS(pcmc)->no_floppy, 0x4); + + pc_nic_init(pcmc, isa_bus, NULL); + + ide_drive_get(hd, ARRAY_SIZE(hd)); + for (i =3D 0; i < MAX_IDE_BUS; i++) { + ISADevice *dev; + char busname[] =3D "ide.0"; + dev =3D isa_ide_init(isa_bus, ide_iobase[i], ide_iobase2[i], + ide_irq[i], + hd[MAX_IDE_DEVS * i], hd[MAX_IDE_DEVS * i + 1]); + /* + * The ide bus name is ide.0 for the first bus and ide.1 for the + * second one. + */ + busname[4] =3D '0' + i; + pcms->idebus[i] =3D qdev_get_child_bus(DEVICE(dev), busname); + } +} + +static void isapc_machine_options(MachineClass *m) +{ + static const char * const valid_cpu_types[] =3D { + X86_CPU_TYPE_NAME("486"), + X86_CPU_TYPE_NAME("athlon"), + X86_CPU_TYPE_NAME("kvm32"), + X86_CPU_TYPE_NAME("pentium"), + X86_CPU_TYPE_NAME("pentium2"), + X86_CPU_TYPE_NAME("pentium3"), + X86_CPU_TYPE_NAME("qemu32"), + X86_CPU_TYPE_NAME("max"), + NULL + }; + PCMachineClass *pcmc =3D PC_MACHINE_CLASS(m); + + m->desc =3D "ISA-only PC"; + m->max_cpus =3D 1; + m->option_rom_has_mr =3D true; + m->rom_file_has_mr =3D false; + pcmc->pci_enabled =3D false; + pcmc->has_acpi_build =3D false; + pcmc->smbios_defaults =3D false; + pcmc->gigabyte_align =3D false; + pcmc->smbios_legacy_mode =3D true; + pcmc->has_reserved_memory =3D false; + m->default_nic =3D "ne2k_isa"; + m->default_cpu_type =3D X86_CPU_TYPE_NAME("486"); + m->valid_cpu_types =3D valid_cpu_types; + m->no_floppy =3D !module_object_class_by_name(TYPE_ISA_FDC); + m->no_parallel =3D !module_object_class_by_name(TYPE_ISA_PARALLEL); +} + +DEFINE_PC_MACHINE(isapc, "isapc", pc_init_isa, + isapc_machine_options); diff --git a/hw/i386/meson.build b/hw/i386/meson.build index 7896f348cf..436b3ce52d 100644 --- a/hw/i386/meson.build +++ b/hw/i386/meson.build @@ -14,6 +14,7 @@ i386_ss.add(when: 'CONFIG_X86_IOMMU', if_true: files('x86= -iommu.c'), i386_ss.add(when: 'CONFIG_AMD_IOMMU', if_true: files('amd_iommu.c'), if_false: files('amd_iommu-stub.c')) i386_ss.add(when: 'CONFIG_I440FX', if_true: files('pc_piix.c')) +i386_ss.add(when: 'CONFIG_ISAPC', if_true: files('isapc.c')) i386_ss.add(when: 'CONFIG_MICROVM', if_true: files('x86-common.c', 'microv= m.c', 'acpi-microvm.c', 'microvm-dt.c')) i386_ss.add(when: 'CONFIG_NITRO_ENCLAVE', if_true: files('nitro_enclave.c'= )) i386_ss.add(when: 'CONFIG_Q35', if_true: files('pc_q35.c')) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index cac016df22..b04c683e4e 100644 --- a/hw/i386/pc_piix.c +++ b/hw/i386/pc_piix.c @@ -70,12 +70,6 @@ =20 #define XEN_IOAPIC_NUM_PIRQS 128ULL =20 -#ifdef CONFIG_ISAPC -static const int ide_iobase[MAX_IDE_BUS] =3D { 0x1f0, 0x170 }; -static const int ide_iobase2[MAX_IDE_BUS] =3D { 0x3f6, 0x376 }; -static const int ide_irq[MAX_IDE_BUS] =3D { 14, 15 }; -#endif - /* * Return the global irq number corresponding to a given device irq * pin. We could also use the bus number to have a more precise mapping. @@ -372,111 +366,6 @@ static void pc_set_south_bridge(Object *obj, int valu= e, Error **errp) pcms->south_bridge =3D PCSouthBridgeOption_lookup.array[value]; } =20 -#ifdef CONFIG_ISAPC -static void pc_init_isa(MachineState *machine) -{ - PCMachineState *pcms =3D PC_MACHINE(machine); - PCMachineClass *pcmc =3D PC_MACHINE_GET_CLASS(pcms); - X86MachineState *x86ms =3D X86_MACHINE(machine); - MemoryRegion *system_memory =3D get_system_memory(); - MemoryRegion *system_io =3D get_system_io(); - ISABus *isa_bus; - GSIState *gsi_state; - MemoryRegion *ram_memory; - MemoryRegion *rom_memory =3D system_memory; - DriveInfo *hd[MAX_IDE_BUS * MAX_IDE_DEVS]; - int i; - - /* - * There is no RAM split for the isapc machine - */ - if (xen_enabled()) { - xen_hvm_init_pc(pcms, &ram_memory); - } else { - ram_memory =3D machine->ram; - - pcms->max_ram_below_4g =3D 0xe0000000; /* default: 3.5G */ - x86ms->above_4g_mem_size =3D 0; - x86ms->below_4g_mem_size =3D machine->ram_size; - } - - /* - * There is a small chance that someone unintentionally passes "-cpu m= ax" - * for the isapc machine, which will provide a much more modern 32-bit - * CPU than would be expected for an ISA-era PC. If the "max" cpu type= has - * been specified, choose the "best" 32-bit cpu possible which we cons= ider - * be the pentium3 (deliberately choosing an Intel CPU given that the - * default 486 CPU for the isapc machine is also an Intel CPU). - */ - if (!strcmp(machine->cpu_type, X86_CPU_TYPE_NAME("max"))) { - machine->cpu_type =3D X86_CPU_TYPE_NAME("pentium3"); - } - - x86_cpus_init(x86ms, pcmc->default_cpu_version); - - if (kvm_enabled()) { - kvmclock_create(pcmc->kvmclock_create_always); - } - - /* allocate ram and load rom/bios */ - if (!xen_enabled()) { - pc_memory_init(pcms, system_memory, rom_memory, 0); - } else { - assert(machine->ram_size =3D=3D x86ms->below_4g_mem_size + - x86ms->above_4g_mem_size); - - if (machine->kernel_filename !=3D NULL) { - /* For xen HVM direct kernel boot, load linux here */ - xen_load_linux(pcms); - } - } - - gsi_state =3D pc_gsi_create(&x86ms->gsi, false); - - isa_bus =3D isa_bus_new(NULL, system_memory, system_io, - &error_abort); - isa_bus_register_input_irqs(isa_bus, x86ms->gsi); - - x86ms->rtc =3D isa_new(TYPE_MC146818_RTC); - qdev_prop_set_int32(DEVICE(x86ms->rtc), "base_year", 2000); - isa_realize_and_unref(x86ms->rtc, isa_bus, &error_fatal); - - i8257_dma_init(OBJECT(machine), isa_bus, 0); - pcms->hpet_enabled =3D false; - - if (x86ms->pic =3D=3D ON_OFF_AUTO_ON || x86ms->pic =3D=3D ON_OFF_AUTO_= AUTO) { - pc_i8259_create(isa_bus, gsi_state->i8259_irq); - } - - if (tcg_enabled()) { - x86_register_ferr_irq(x86ms->gsi[13]); - } - - pc_vga_init(isa_bus, NULL); - - /* init basic PC hardware */ - pc_basic_device_init(pcms, isa_bus, x86ms->gsi, x86ms->rtc, - !MACHINE_CLASS(pcmc)->no_floppy, 0x4); - - pc_nic_init(pcmc, isa_bus, NULL); - - ide_drive_get(hd, ARRAY_SIZE(hd)); - for (i =3D 0; i < MAX_IDE_BUS; i++) { - ISADevice *dev; - char busname[] =3D "ide.0"; - dev =3D isa_ide_init(isa_bus, ide_iobase[i], ide_iobase2[i], - ide_irq[i], - hd[MAX_IDE_DEVS * i], hd[MAX_IDE_DEVS * i + 1]= ); - /* - * The ide bus name is ide.0 for the first bus and ide.1 for the - * second one. - */ - busname[4] =3D '0' + i; - pcms->idebus[i] =3D qdev_get_child_bus(DEVICE(dev), busname); - } -} -#endif - #ifdef CONFIG_XEN static void pc_xen_hvm_init_pci(MachineState *machine) { @@ -838,43 +727,6 @@ static void pc_i440fx_machine_2_6_options(MachineClass= *m) =20 DEFINE_I440FX_MACHINE(2, 6); =20 -#ifdef CONFIG_ISAPC -static void isapc_machine_options(MachineClass *m) -{ - static const char * const valid_cpu_types[] =3D { - X86_CPU_TYPE_NAME("486"), - X86_CPU_TYPE_NAME("athlon"), - X86_CPU_TYPE_NAME("kvm32"), - X86_CPU_TYPE_NAME("pentium"), - X86_CPU_TYPE_NAME("pentium2"), - X86_CPU_TYPE_NAME("pentium3"), - X86_CPU_TYPE_NAME("qemu32"), - X86_CPU_TYPE_NAME("max"), - NULL - }; - PCMachineClass *pcmc =3D PC_MACHINE_CLASS(m); - - m->desc =3D "ISA-only PC"; - m->max_cpus =3D 1; - m->option_rom_has_mr =3D true; - m->rom_file_has_mr =3D false; - pcmc->pci_enabled =3D false; - pcmc->has_acpi_build =3D false; - pcmc->smbios_defaults =3D false; - pcmc->gigabyte_align =3D false; - pcmc->smbios_legacy_mode =3D true; - pcmc->has_reserved_memory =3D false; - m->default_nic =3D "ne2k_isa"; - m->default_cpu_type =3D X86_CPU_TYPE_NAME("486"); - m->valid_cpu_types =3D valid_cpu_types; - m->no_floppy =3D !module_object_class_by_name(TYPE_ISA_FDC); - m->no_parallel =3D !module_object_class_by_name(TYPE_ISA_PARALLEL); -} - -DEFINE_PC_MACHINE(isapc, "isapc", pc_init_isa, - isapc_machine_options); -#endif - #ifdef CONFIG_XEN static void xenfv_machine_4_2_options(MachineClass *m) { --=20 2.43.0 From nobody Sat Nov 15 10:54:05 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass(p=none dis=none) header.from=nutanix.com ARC-Seal: i=2; a=rsa-sha256; t=1752137758; cv=pass; d=zohomail.com; s=zohoarc; b=icC6IFvup79l+UdLwZhAA2T4LciRGkNeaSgik/rr3f7DhwLmKQvYJx/6mH1fUjNktiVmgbzeTura34T7YAKlEVPsuYTIC02ZeTa4Un8cg5fL0LX0fXtHtQ4HdQBNP+Qrpb2MhY0DWPSwEVf+sgEhyNFsZijn/pte8d9xBP0MFl4= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1752137758; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=7c32xvFohDD8H97QIyuNbxoDK62h7Z2h/Vl2pKCPQbs=; b=QmPTItyUq/oPLYpW+2CVWm6Of+jSIg/PKys0ENF1TKDxwhGeILjcH1vVBkxNzFQaMMwCxEjeLRSO/KgmVm5axWy0PCSF6J9kxhHJnwD4AvymvpaZnEhRg/jOz8wz2dCCqz6vzaN7V6NuVv+PjRw7mYAIHDrjmLku0GabAPX4UB8= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1752137758587817.92628217597; Thu, 10 Jul 2025 01:55:58 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uZn2s-0000qA-23; Thu, 10 Jul 2025 04:54:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uZn2m-0000aB-5q for qemu-devel@nongnu.org; Thu, 10 Jul 2025 04:54:16 -0400 Received: from mx0a-002c1b01.pphosted.com ([148.163.151.68]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uZn2j-0003bg-Tk for qemu-devel@nongnu.org; Thu, 10 Jul 2025 04:54:15 -0400 Received: from pps.filterd (m0127840.ppops.net [127.0.0.1]) by mx0a-002c1b01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 56A63DGL022335; Thu, 10 Jul 2025 01:54:11 -0700 Received: from cy4pr05cu001.outbound.protection.outlook.com (mail-westcentralusazon11020131.outbound.protection.outlook.com [40.93.198.131]) by mx0a-002c1b01.pphosted.com (PPS) with ESMTPS id 47q0cvn29n-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 10 Jul 2025 01:54:10 -0700 (PDT) Received: from PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) by BN0PR02MB8048.namprd02.prod.outlook.com (2603:10b6:408:16a::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8901.29; Thu, 10 Jul 2025 08:54:09 +0000 Received: from PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88]) by PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88%5]) with mapi id 15.20.8901.028; Thu, 10 Jul 2025 08:54:09 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint20171006; bh=7c32xvFohDD8H97QIyuNbxoDK62h7Z2h/Vl2pKCPQ bs=; b=vuLpn3nAGDAO8ePn/IKTYJJ+jvgN20qoFh3DpSQYXRwhrJHNzOzbEkk7K NkWrvFpa+6qqQQMYC+q6U26VIZ9Ce7iExNi5WrBRfJ6hFFGCB7LbO6IWd3xozH5U 2/PDxCERbqBL37vBi58Peq0Onm3fqIAz9qyGSsW3sgtVvenR6e7Ly/ASJHF2dsD/ 7Xd0tM6fz1Rlakb/6budyOLIeQpOJeKHUkmbE8tSp5DBWDr2aDip7Vzli1JOmp9b w8IGgu2K3z5q+8orDGtNu8vRgyIrT37u+GKABmP2WyscbvkpREHQOKarDKDRHEpf c7hFp97n0DZH6Ca2xMhjnRaFTB1WA== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=C2chvCb7dhyk7c0cdlyEvSBnbY6MR3Rr6d87EqtvwU/T4WSc6LqfMBUgRU0EHORjvPrPQSjPWPd/HZ88bz/8OTHwPKTrqnsD5c7VBwpk1J85C3hT9Nyz4KoqtmhCFO2kZND1NQU0bdxlvvG+rAzsXZM5NP77JLwzZLDygSWb9reIdZvgN7ipQaqtMvEPEngvIhXB86FfQkipn1evIOPEXowjxMFqU1lqyb8WVHUuslRUwlZedC1VAoFo6gs5mnhXjUs0MnzsIcErBvRPvu9JEyHjMMsatXUBER3HBrbDP+OCg1rVhyJM3sN2gwNJ7efqgb4/xpqxoGzytDmWlquw5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7c32xvFohDD8H97QIyuNbxoDK62h7Z2h/Vl2pKCPQbs=; b=e0cjx8V0dnpnp8a0m/K1oHzG68seEyKGBhtzZLL9RQxvDp/aX9j07JpFHP36i0dP5SpXYJDU+3B8o3J0xcT3LU0nuU6hBYfUXFbX8w3Dy2JdekZU3xU7Qx6F7kY2okTpyUezaEJDmUplX8A7nDmJTFljg9Z75bX9BYc7StIL7T5qZt96j92ikvahvIdxBG+6vK2iRHpC/st7YlujX2Ixyv91V7uklgWdXucwXaecGXYQnwILt4YzyszO2JbwAOuMgRTCNB+immzVegN4z3YLrjLRLjNO1wUoFLbSQ1aEF6vIwlcA+StMJRb3NwKGZ3QW2ZtKETPI3ifAhds3hcY09A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7c32xvFohDD8H97QIyuNbxoDK62h7Z2h/Vl2pKCPQbs=; b=ufAgXxxAK1v7Lnx7OXu8QmsDiMjqMo3YocwPQ6rXV/34tsoHo4BcZLe//EXUnW8xCNy6UjdNCPyd3J9dlbgMllNqB9Ws387Bix3GtARII6u1IiRASoCL/94Tkl8CVzDL8HQQLyrjHGimRAwEe+8TUNrh8rVA68sp2kodTK8aE5RccYLQY4ctTbLJH+wZYh37GgCAPjKbbII5nXj2w8LSBgILvAIDOEAybMrtKA8gYLDrBqse0FX5ZkC7TsvAltZ1Yu0s4Ri/oSwR0m9O8PqQgvzQlS5IkDXviVtyTxq+kttp4AJitZsJiJIbZ9epDvArEQLfMeQ/CsNoa40TDSoSHQ== From: Mark Cave-Ayland To: pbonzini@redhat.com, mst@redhat.com, marcel.apfelbaum@gmail.com, eduardo@habkost.net, imammedo@redhat.com, qemu-devel@nongnu.org Subject: [PATCH v4 16/18] hw/i386/pc_piix.c: remove unused headers after isapc machine split Date: Thu, 10 Jul 2025 09:52:31 +0100 Message-ID: <20250710085308.420774-17-mark.caveayland@nutanix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250710085308.420774-1-mark.caveayland@nutanix.com> References: <20250710085308.420774-1-mark.caveayland@nutanix.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AM0PR07CA0030.eurprd07.prod.outlook.com (2603:10a6:208:ac::43) To PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR02MB7159:EE_|BN0PR02MB8048:EE_ X-MS-Office365-Filtering-Correlation-Id: 7747f0e0-179b-4302-5ce0-08ddbf8f5590 x-proofpoint-crosstenant: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|376014|366016|10070799003; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?Nw8RZ5bE+Z32lWYYD6hcfdPOhqWSENNby9zD/uq7uG8iiRkbmv/hEgT4cVyu?= =?us-ascii?Q?td/Ib7egcRcYdyMcBQD5K7gCVegSEN3GaEAB1b4UpbxbdM4Y7gvjsD4jpYAE?= =?us-ascii?Q?QAdVkbAZDIpReCHPOAehb7QI58B17ZKbSiC/ekF5KsJ1HQVSRrk1JM+JUK/G?= =?us-ascii?Q?kaat8NjAe18dHitXUb1kCFGNXLUTnriKwcvtpM1+wZ02Tso/y3s3XajVcyiA?= =?us-ascii?Q?QU+Ae5JORIuy3s9xNXmRL4rfK3CiqMZki93Fzl5n4kbDWt4gsVmGzehvkbju?= =?us-ascii?Q?2lBlpbquwSiKUK5EMVsU/HcllURfgcHfSoFtxuyvl4YsWxN/dKNuO2MFsWiX?= =?us-ascii?Q?AlyVlkBO8phxTekhPN1vFg/b2gg1wAH98rpHeCW1JarECkwwPOKm2u5DfFEw?= =?us-ascii?Q?e3lRpOXT5GBCyU9IsyVxYJ0fglT3u/0lK3hNoQMNmZpsQD9TC0DPQUiWzghr?= =?us-ascii?Q?sSrpHkSEJCfJ3S8VKg7Pjj6Xhs+JPK23yiV7CIa1qprlq52aInOhK06dFuP8?= =?us-ascii?Q?iCLhXTxsJAu3rPq2kTXYu5JMm1J58rodMdap1OkfVH2B7Sc2KcBUzMo/OBQP?= =?us-ascii?Q?M5Dq8cvDXM5FXHEvDRBtnBAfPUHg6iPC+T4xvQAacaSkurhIIH5r1/L3xgQ7?= =?us-ascii?Q?amWpk4T/EDf3M8g0XeGkt/HJvjDjTx5xgU+RFViPQj9lw469QclvcxaB28yt?= =?us-ascii?Q?Tk/LcL5tNnLlJrjkyG3nsTSQkxh1P75HCERqBUFX11LKm3fIvH+rDSTeAd4b?= =?us-ascii?Q?S+smd/yxw5mVt6HqfbSQaUNSZyHcM/F9u7tQgucYAyejD8nJLGbnPGekWst9?= =?us-ascii?Q?lJT7ppre3P2QS7IzZABowBfDT2xy1IcZZDCrhZ5fxBHQSJ07U1zUKoUq3tnP?= =?us-ascii?Q?WcjxPJWPSDyLqDZE51Dd0k0LcdEC8hQhZBTZemMvDIXoVoIrDePbxO7liaHG?= =?us-ascii?Q?LqE2hqHT9V0eS5hKFYr3yZ3xOphGkZ8DaG8ms4SpvyO0o4N9gGFZORGxLUlD?= =?us-ascii?Q?M7P4w5iLyL53D9qv8TtYoM5FnyE5C+WoXomFHVCe9YZ5uO7QJi4XDiyZtb/q?= =?us-ascii?Q?enFOg+XFRV6/oKT+IrQJc/defLOQui/W3z4uVUwa2vHzAG6ltiJ7eFOy/BFK?= =?us-ascii?Q?AaA5qtXliVzNv6JtHOku8Jaxm2L1YhY7HONAEfBb5qiLobRyEMq9qsgsaood?= =?us-ascii?Q?EYS67dyYSJ+XYIM9+zSjbPH8FgjuCxkjeCWlvzJGlZE+fQcdsgj0TIL2JhXG?= =?us-ascii?Q?TVf1Ykb6u0JByVTiAZjZhLPO6AX8xYiURte2f+bQvYxyhP8Jwxw/gih50GI6?= =?us-ascii?Q?4iCMwYeKsMWrdgH520tEVaoAZMPFEGKlkwealKOPcFcp3J4wzWDOkrDXIpAT?= =?us-ascii?Q?qAU5RpQX86coqqG39c0Sxl9JDbKhe20t1V7ial8kEuIrX9ZtRA=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR02MB7159.namprd02.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(376014)(366016)(10070799003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?BOGXzUe/vRjyNU0cEL+MQbwChkhpgz2afV8dEPxoc3cbF9swth5A3iRoFJUA?= =?us-ascii?Q?SFCjZAL6Ibjps7L/UXxLpaUJk0xMj8iIG7sBNVUScV018I1uUzoCiuLP9ME+?= =?us-ascii?Q?c6+oyKC0JrEO1c9COxNXpPgBi3y9UhaR9DUUTTWL9DBhVjX1+zapf4qoIXmK?= =?us-ascii?Q?m/KuAG0pE/pzVAtsk6ShZAW8X0ZK/iGCRuPE5r1/jNxLmQKG905udtncVGXs?= =?us-ascii?Q?Tli3bDbrx8v4p4Fn34LELOwMsvZhfeftyZnt/jaBSlL6aauxaR3XOpHGijMd?= =?us-ascii?Q?ikjNZhmhPA1LSz6Pby88wTChY4imPVDieVKlSpD0wXJom3EU0CJLJpx1IsMk?= =?us-ascii?Q?BzN9eJFT4Kx3maVbQGYZlkp/cf36Sv1Ax5m1Orfc4sWEaoMDz37kE7qy1gkY?= =?us-ascii?Q?N5G7wGtWoQgJacnlfuPH7qiSomcEhFeKobw2r1ITE8jus89nYuoKj95qjRxd?= =?us-ascii?Q?Gj+sUqiCHwAiNM0TSwfzsEB56sU1mRtgLwPyECFr48SBQuu2EDkk6UqO8BWA?= =?us-ascii?Q?gyf7VwjgW8zHZlt4TJVezFrfHNwwoJ5DbbDxkykHTzmzd3EGLBv5jwHL0gGL?= =?us-ascii?Q?kKGXfrg+Ar44BG+dV3S2QC/UvpcCYSx009Ym4qwvoq1zzW5nWAsfr617J25v?= =?us-ascii?Q?qGe9g36P02GU2qMBo8EKjxsXMtD5a5sHtswmVMVrQhq/7d6ccR5sqdwMk4Af?= =?us-ascii?Q?kVM7D2aiy5KVw9ZRyvTjKf+I7TvIA2Je39vDmL8kaV8AYFzuBVSmHp3SuM9q?= =?us-ascii?Q?Y4JBn4yOR3bOsXrMSxCuXfHuy+boT3OWRC2l9J9lLodC62av2EMAypAKeW15?= =?us-ascii?Q?MAebKqCbYwP9N+DT27k+83RrRvEOlin38TUjT0U/9khoxNm+4znIxLYh5amv?= =?us-ascii?Q?dSqrofhF3LAG4f3J1FNZSBOQLpiUDDntX/l8n3KrCePlZUFOT4JwVDoIx0KH?= =?us-ascii?Q?S144qoCEdPPBElGKoWQh9TI6qiktsVUrhQiN0j7sOQkzkwuERTXNvSXoW1sw?= =?us-ascii?Q?glC+NOZzTVYg2I1au6hHJBCPqzc8+kOR0PNm4z0lEmoQxYBDqij1GwkKJ6bC?= =?us-ascii?Q?BLDH044QBPzN3NQnJ2XulmNMXczvzhL0ygwfYhb+buZZ1nLRQEaGlaOv8hqc?= =?us-ascii?Q?JQS8HqZFE/VMGDJ0Zbr+rh2CkfsAO6AOMpOGQN4rIgapWEnm0D5BNraOCGU7?= =?us-ascii?Q?mUbyaQYQLB0MAbCXt2vrclYd8ST4NkxtNrgQb+4V2UgBnuvu8EZ661SwCRGb?= =?us-ascii?Q?CMl9UXyBF1fyUnvAmVUdoagFBq4m+Ekbf6OZOPh6O2xjZKCLMW+GOByz4xN/?= =?us-ascii?Q?3zEi17HYbOMxRKWaBNSFvZx1invW+xD+gUXu6HBVJc7hxWt2Nroov1m2yUub?= =?us-ascii?Q?n0TxeRb2iAAFQRaj53f3GIPRjW9kdxGfZI+ayirESXHhrpQoDXmmVe7lrzLF?= =?us-ascii?Q?gG9Ifp4YEmWutoHB9OBFLsbZaDSaFIclvTb9Yk3UhSSwY6T5L/etO6IRdGF/?= =?us-ascii?Q?Z9Rh6lHUmIwvM83Eqa1et8XOlSD+S6j1ZZmUGMTmj/LCoaO9kytBmRFuXSv/?= =?us-ascii?Q?OMyI/ovFkW97u6aWw0MYC1FKHPzk1x/87zazDbo1WMyi3nGp6/hcrRUWIole?= =?us-ascii?Q?7p/07zX4fGMUdLqSLSysEfGb8s/Q7yW7+WlECEdqNxMF/TBYC21rrfNWSR/E?= =?us-ascii?Q?pFVPJA=3D=3D?= X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7747f0e0-179b-4302-5ce0-08ddbf8f5590 X-MS-Exchange-CrossTenant-AuthSource: PH0PR02MB7159.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jul 2025 08:54:09.3994 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: t34uq+KNTXq/x7SMlW8eSjsa+Byp92R5VJvMWJv83ruGTCJWzwF6jvuWRT0Kb9RlJI7UYW7Ej8308A4AkYuM7huPAO0kuoBg6Btn2LXFe4E= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR02MB8048 X-Proofpoint-ORIG-GUID: zQOs1tYHc1njKR1rxmytoaAPxj_Sm369 X-Authority-Analysis: v=2.4 cv=ccXSrmDM c=1 sm=1 tr=0 ts=686f7fb2 cx=c_pps a=wLjL7U/RDB/pQmeqDiFFmw==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=xqWC_Br6kY4A:10 a=Wb1JkmetP80A:10 a=0kUYKlekyDsA:10 a=64Cc0HZtAAAA:8 a=mByk-SMsxhCBlLGf_oAA:9 X-Proofpoint-GUID: zQOs1tYHc1njKR1rxmytoaAPxj_Sm369 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNzEwMDA3NSBTYWx0ZWRfX4oEVxXeggm3K NSXMoQ0dNA6IbVCqzGnuGFg1NEqDMZtYRXmdba6LrP3SNz+WAL5wAXasx7CGLTbXRpBijK2efeG +XEZI/85Bve64EDH0LfAxcg1JeOkx+vznEuc230+6UgPxVI9vwEXZOsGXMIeOF80ImijpzJYCIs zCQkkoPQ2xYrMXtBg+MD27P7LjgzIajkO2SALs711G4wG2QZBLPHNNzplUgvQN5ObM4/R+65ima HAR49BbHIMevorBEAYLg7HkfkSjSW4AHgSYziu0WdelD3mCkZmKt2QGzlyClD+Fssd4FkkOEcFa IZFH4aAwbm1pIK2LTj9w91SYymgvRQlnDuEPomdZ8Hk3qLZgz/SIOkhHT2Ah4RnHs+UcvC5Cf1O Wi6wkwdpBBitQ+94K2HVwAaT1HsTQ0+WbKAPeVEkqCXe5U5wbWGgS7hfcp3iQv6B6m4TLs59 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.7,FMLib:17.12.80.40 definitions=2025-07-10_01,2025-07-09_01,2025-03-28_01 X-Proofpoint-Spam-Reason: safe Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=148.163.151.68; envelope-from=mark.caveayland@nutanix.com; helo=mx0a-002c1b01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @nutanix.com) X-ZM-MESSAGEID: 1752137760774116600 Content-Type: text/plain; charset="utf-8" The headers for isapc-only devices can be removed from pc_piix.c since they= are no longer used by the i440fx-pc machine. Signed-off-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- hw/i386/pc_piix.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index b04c683e4e..ed5a313500 100644 --- a/hw/i386/pc_piix.c +++ b/hw/i386/pc_piix.c @@ -27,19 +27,16 @@ =20 #include "qemu/units.h" #include "hw/char/parallel-isa.h" -#include "hw/dma/i8257.h" #include "hw/i386/x86.h" #include "hw/i386/pc.h" #include "hw/i386/apic.h" #include "hw/pci-host/i440fx.h" -#include "hw/rtc/mc146818rtc.h" #include "hw/southbridge/piix.h" #include "hw/display/ramfb.h" #include "hw/pci/pci.h" #include "hw/pci/pci_ids.h" #include "hw/usb.h" #include "net/net.h" -#include "hw/ide/isa.h" #include "hw/ide/pci.h" #include "hw/irq.h" #include "system/kvm.h" --=20 2.43.0 From nobody Sat Nov 15 10:54:05 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass(p=none dis=none) header.from=nutanix.com ARC-Seal: i=2; a=rsa-sha256; t=1752137743; cv=pass; d=zohomail.com; s=zohoarc; b=M9Xn+eeWRTd5WrS25w6q5kjzsM/w4s22UvsZtFTKpYtqSrHNu6PA6mecs5B+Cf4Pmh4TynZLxru4dcrOafwgCY9dGnLGulLvEz5VL4wkNNGuLwgga+zmMiTSW4PKRga5WbTmfSwCzRMI7u1B7xSAI0tYtGbYgKqCsznOeAgNVLs= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1752137743; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=AJ/B4wHG2OAUgiSFCGwBj5GgqSqT7WnagOhH7rcyyrU=; b=N6QhftTT6iTjF2YJRVoZBcdmKOsT0sl46uIbVx5JOR4Eymb5GzE6PG7nqWeU53rDAZ/oBkYJkd3H/gIfoKM7Wi0bwGxEDuc7n/8YEVsJ7YXUJ2m3fnMlBmwBpCyBlUoGjdLUV+j5rwxv4z3jEckNi+jPh81vR3DjZULCLXGe/0A= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1752137743512223.83687859752604; Thu, 10 Jul 2025 01:55:43 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uZn35-0001cH-9S; Thu, 10 Jul 2025 04:54:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uZn32-0001GB-6H for qemu-devel@nongnu.org; Thu, 10 Jul 2025 04:54:33 -0400 Received: from mx0a-002c1b01.pphosted.com ([148.163.151.68]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uZn2o-0003d8-GK for qemu-devel@nongnu.org; Thu, 10 Jul 2025 04:54:28 -0400 Received: from pps.filterd (m0127838.ppops.net [127.0.0.1]) by mx0a-002c1b01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 569Mgvc2018518; Thu, 10 Jul 2025 01:54:14 -0700 Received: from cy7pr03cu001.outbound.protection.outlook.com (mail-westcentralusazon11022079.outbound.protection.outlook.com [40.93.200.79]) by mx0a-002c1b01.pphosted.com (PPS) with ESMTPS id 47q3m150mt-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 10 Jul 2025 01:54:14 -0700 (PDT) Received: from PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) by BN0PR02MB8048.namprd02.prod.outlook.com (2603:10b6:408:16a::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8901.29; Thu, 10 Jul 2025 08:54:12 +0000 Received: from PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88]) by PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88%5]) with mapi id 15.20.8901.028; Thu, 10 Jul 2025 08:54:12 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint20171006; bh=AJ/B4wHG2OAUgiSFCGwBj5GgqSqT7WnagOhH7rcyy rU=; b=XjQk6jp4Y1TJisiIvMB54+8QibqKOnvwvXRCoJUpi4Q7M+EeCSZATfnZ7 ohT0EHiQzZuSff7pm1/gOfTboyQ+svJi4vgi2QPInT4qFuAn5dEviq+FO87kAsUJ iYoFJvyd4dlbki/4CYSzNk5rCM2MOCZv8rcFK5rIy1TWIr2YWHyvMjzCk6MvgPml Gq5tC4KoK1thnzlaKN9ufBRX6kHDpdmXBzC9d9e6qaswR/7WSEmAJEF9RY4z+jBJ 7gh+CIJgER6aveHhkTt1aW851Z4kPbNgOASG30lBIFNfuhjMpgH4b6E1DjBGA23i KQ9nMIIyT0JfM94o6cb/QxjUv2Jiw== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=QoVmImFmux5bg1H2ebuQuV0pCLHgB7dosk0Z7c+nm27GayRyJKc/rORxuq88AhQ/kUCpilmdFWKqMsdebsnLtN3UQyg/4l758ryTuhJ42Ftd9e5YNVGomHFVWUvIjfiVLZvHUK0NnzL8YBkW+H9QPKW26siYU1fSJOx4Xi6FOeU8tJ/mXK62h3AGR91lNIiwPiVNKNpKecvgDl3WI8cvT7sbVcKvU/2ESxKgizvwGr/EwzhDxxlh5ONtp1dhaPassnOd7aH3jPVL+IVkDveIaaB8dHadTjlS11Dy0HOpPOrMz7pWJils/VxwpIsB/2srTgvsx7ifcvuzEcC15aymIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AJ/B4wHG2OAUgiSFCGwBj5GgqSqT7WnagOhH7rcyyrU=; b=VCaFfViD8dFoqooEi9mtxs7dJfJ1JN0ujLH6rkpX5j1+i1DbfrQPx1vlfhBBovtsh9df1V4HjwPzNnx3iwFfz3EjhbZPXRvlzAGc3+OnpJZcLNJJviHvSahw/uTaN5ro9diocRAXms3/gmUXRHscQOAlpgCbwbHydKXD9JmjF2BhA9Eq/lf/m3Mys4C7864V1Rwt5pgrbY2R9rQ5M+jJuSW2uvecaDLbRi5SCAgrZ2bOXiC84H5WBE4shNaQzfd3Qg2zbPoYs9tZHxNZgyZM3Bln5TSDZ5i3jfRe4JDqHvfvY0ELycFlqbXbsK8d0bevcXNdQFnMgNJqsCinxHutCw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AJ/B4wHG2OAUgiSFCGwBj5GgqSqT7WnagOhH7rcyyrU=; b=uzjolfQ5JM5Zy7rU++BU5eWxDAfUq+/a+IrtSmsvO3r3QQUkKtcJ+dEGEcWgiSZHg1RQMgI2yiyeaMDeKNturpdG1kHg4Y9BN6lRMD/RIOU9g38hAh/mKsU4uvndOmdUOwugfX1VB/Yynl0zVB+RFPwqt0hDroaD5sMG26IR6MpjOWEY6/EEzzkpVPV+dftEBTIaTMfOQU8DRoPwdcbGuH/Sv9ZWqi/qyPi982FD/dX7pBsYtwAHY6zwlq542CUGkXcAIM27K52chHfR88uwD3BuwtbwUsnKJKUYiEHWTDMm0TyYcW++ktmnoL2cEOZ7V1E+vpU71YdRax2aJ+StDA== From: Mark Cave-Ayland To: pbonzini@redhat.com, mst@redhat.com, marcel.apfelbaum@gmail.com, eduardo@habkost.net, imammedo@redhat.com, qemu-devel@nongnu.org Subject: [PATCH v4 17/18] hw/i386/pc_piix.c: replace rom_memory with pci_memory Date: Thu, 10 Jul 2025 09:52:32 +0100 Message-ID: <20250710085308.420774-18-mark.caveayland@nutanix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250710085308.420774-1-mark.caveayland@nutanix.com> References: <20250710085308.420774-1-mark.caveayland@nutanix.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AS4P190CA0024.EURP190.PROD.OUTLOOK.COM (2603:10a6:20b:5d0::15) To PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR02MB7159:EE_|BN0PR02MB8048:EE_ X-MS-Office365-Filtering-Correlation-Id: f824f8fb-40af-4c56-dfaa-08ddbf8f576e x-proofpoint-crosstenant: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|376014|366016|10070799003; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?aQjHf9jvJda1ZUXxmsuZb9PJ4sZi8Fo+DBAxxcZ0NhH76c5EFNyx9PA7DoNQ?= =?us-ascii?Q?qRXN3s580P7H0BdKPi2dFL6EEBB1cQBh42XrYfIcZliVBl4WvsWK/sEhgnfc?= =?us-ascii?Q?le+OZ+HTTk63Eg1QFrTwKqpL3sy7fvS0OC3U2CGQQAovNNZPue7ESO7a4Zw1?= =?us-ascii?Q?pvlAI3aPIYwNAE5qrRSy3Q0/dwFBUn3rcH9JhKV2o3R3VEL3EqWIaZKBbZkJ?= =?us-ascii?Q?b5LzGWT/k0e7c8RJ7sSWyf2uyp8o/5uns+0qnkLcwpx5YDiChOBk+chb7kGE?= =?us-ascii?Q?/pnXEgg/A/zwHQIG3ZqCavqSfasg6fKNArVHkpIa2Xp49XIP4cOlQOj1nte1?= =?us-ascii?Q?tHmRhBWGqsMt1tr7zOJzOzF0efcl9Yk5I7lS/Z9wS077UXbl4u6u9Oz7ze1C?= =?us-ascii?Q?Wh7nEIls9MJDX0EqGj+p8lm6GNpLi5oSPcYOailRoiR+2Ha0XxHFXS2hFTiu?= =?us-ascii?Q?PZcs0NzHbrP16twWwKMWFzelXUo1KjGmeEpxhprFODm41X8fJXsTwHjEbiMO?= =?us-ascii?Q?unwoigu+RYMVO13JWl9SV1KSqooyUgcDLtnbk8jlrobFpQPQ4hiCeTQjNBwz?= =?us-ascii?Q?+WdqeSVHqSCBpZsn5Javjm4aE66FBG84X48vZA/NTPfFXUQmz1u/iA9B2Vrg?= =?us-ascii?Q?RVBQLiFPqBPZ7heprwIl/VErc1Z8buMXJ1YtIJZiyt6s6VUSHFKohu/C6NN+?= =?us-ascii?Q?Bz1sXnz47jJUlFBi0SaiIzA0Qsp2w0f13/qivgMYs23kl46qnwighZvYpooL?= =?us-ascii?Q?GXELysBnImroHjziZ7gbSwOER3mib3flEnM33wLzLFDBYi/o5ld1an6oSi3g?= =?us-ascii?Q?kHS6HYmqvj2VXr5oeOPvJRoAEkbcIT4xUWDMf5gU3hmrWCqEMaK9ri4v3Mkd?= =?us-ascii?Q?CfISNIoUKm5AjWDrfkbO5aHxVgnGSt2j89wMSBSP+GFWRq2/5DK4U7uZ8FRl?= =?us-ascii?Q?aSlgwnLaOSEKy+j5OuLjODQrMhC+tFC61r1N/0hmooiryB0EJQpi3g+0na1J?= =?us-ascii?Q?9qGjf4AS4B5D0PlqPSx9yMkBWNHl2L+IWN/GYgScrwblJ2mzHM5BZneeG2za?= =?us-ascii?Q?qmUUZfgkNNxQPDocV5AtewGusQ5oUOmkrNiMh+FwgxbHQifl5+FRdcQub0vs?= =?us-ascii?Q?EvOzVqxCi4Ntg4JgCOiGnhN4DBARbtm4so/qrB27R0CO2hx5scIVUwv4ap83?= =?us-ascii?Q?qfBlwjY4fUeO0LIdUsk26oS1ZCfj4CoTRT5qsXpQyqcvHZQXQsBRDE5ceVmd?= =?us-ascii?Q?EYDWMCFAdEsqTgD9Avhb5+kXvJLf6y0dvnjGFS4ScAOc3mAbz4h0qxLBlo69?= =?us-ascii?Q?gN3dDUMvD8hRmvoAuRj4z2KqwicPJndBWV/X/43KbuI7DHj+HFBCOJqP17Tj?= =?us-ascii?Q?ShvISoYtAlKdaO1IvMh0N6m8W/IxtgDecTaLtxbdkqM6KIW/N7w3RioNvncU?= =?us-ascii?Q?D4/J60FAyks=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR02MB7159.namprd02.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(376014)(366016)(10070799003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?CKioLQb1xvPgnqMzrV1CSzhjnWrADjlSy/RuPS6Bqt1e94VW22Kfkkj84+zM?= =?us-ascii?Q?rVMKnj2nwIVkLewDTpjyuKLNzuvLzmqbbo0cFecphV60arrVuS1VURtaGVk4?= =?us-ascii?Q?C2ntaX6LIc9Pn+Oty1yYtKlHdqB12WoHNp9FsqzmVmEeZbjGr/WkTPF7zvMj?= =?us-ascii?Q?e0XyI1Nn4doPmTE+Ad5e1qqxTFee9aXDdGfuF0g8gWBP5M3Z3k3oZBR4oBzk?= =?us-ascii?Q?6yzM50vjHxLC0rHPXmRDUw3JeR7ORNO179DrVL/oM/I9nFBnGfstVfutbKpd?= =?us-ascii?Q?E541ZZj/Y9WIpskKJDJ0trVSNR8SadL9t86jCH/HAGJYRwmVc+auWPzQT+SG?= =?us-ascii?Q?YOYOeMgit2tMG+XsLfrkpQm5avkr4YVz+A6QPQP35tKpgEmb+ag/AAQdOtyd?= =?us-ascii?Q?Of/z6L3u+FG+YoSPBS6iXKUyuyHUjyMjMoG84exnk7xgFl9m1ai+A6yQVXaS?= =?us-ascii?Q?KoUzoqzEPcTE7kInib+yeVAbWlKMTBCvkc4HtLgDH8X36PrU15nJSovZsFUr?= =?us-ascii?Q?TSST5rpzR7jtFLmyfUeVPYaRK5cQ4dBk4PdqoeMLEs8blOqGy50gCXER8kkr?= =?us-ascii?Q?slPoJUWcHeDUES2NaDgyp5zzoqKWQNQYJ+TtJvRE4TQgcEZOx7Jea0IJ8TKt?= =?us-ascii?Q?Vv1vIN1WBbF4YCdrBGLtzFdksGpir3di3ZtaciuPKHplyJvpGXz+GL97v7YS?= =?us-ascii?Q?y9KHPcLwJ0RRd56cF1ImVQon/vo2CtVrmjwyQUyySvTQrPyzXUuVMd28fMd/?= =?us-ascii?Q?xw0wpoHbmRIsVualV+0ZdFLw1lWXlr18RfvI14mHv325UhKVi/BJYzIFG7Xk?= =?us-ascii?Q?e4NYPSpUVwwipbHIyRfNFQT3lZfQcsO8oMeWh0MnAMpTXlxjxMAtIu2PojIC?= =?us-ascii?Q?BOImx0lT1o9qbQYI2NRUeRt+Hqo75CwUGvBOb80WK1jM/rob6An3M7M7mVXE?= =?us-ascii?Q?32ovpcOcErruLMKorxTfcMnTGbAa74JIfbpE5tMk7i2vqVN2x1BRX9QFrPk7?= =?us-ascii?Q?UrPcXAqyg9k9jbUhyYx5u5n9hjGcHxYaJPVTxRD/pkmMMawd7itp8ZUaVgX8?= =?us-ascii?Q?TWVxHqKqVGSiB9QGeuWB/lRnNvGj0y1M3E5/CquwAfeA4xPPohD+9Zj8TqWE?= =?us-ascii?Q?UZEj5tEzijSXjvxotVco1yfn78WpSzTxLiSOnaa+MUlSQAdJkbAoPmWs2r/U?= =?us-ascii?Q?I5ca2vNCLiBxLJ86MessoDYRgLzr2tmxI3NKDECjoSu0MobCiFKF0FYz/sew?= =?us-ascii?Q?ScYnifqiQ4z786AXUtSv4YMVcb3R5FZBHm1lOD2y+zLBg8XErl+VNvxPlHxv?= =?us-ascii?Q?nditLMKvfbpqviV42dLC/VRVvWZD2ykGNJGxz8V7lP/xHgmU+cjCLuyNHOaT?= =?us-ascii?Q?K0pHFmtAog0c8/WOblzTS/7hvzKRwdYtDlaANixRW9rdjajUGL/iBKaQ6wzJ?= =?us-ascii?Q?kJ22v893q5183QJ5KEsWK7UwRMd1TKYd9WXwt26TGCv1hNrEM+GIX0RKalRU?= =?us-ascii?Q?1UWUejpe3+86d3Tx+efS6bgN/HWQdg2p8+ul9MA9u0zeK+RpFn8p+hxKcs2v?= =?us-ascii?Q?Av1SzDCTEq8pUfV24DNbYY1oiMRbOH20W+IM/5Ja697GBODyv1/TAInEOcnj?= =?us-ascii?Q?F9mXBaSlhBh7zzJJTA/brH9s8+5dGLYSp9zSsqDMlq4ospAE19fDQ6NjtOxb?= =?us-ascii?Q?ONxGtA=3D=3D?= X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: f824f8fb-40af-4c56-dfaa-08ddbf8f576e X-MS-Exchange-CrossTenant-AuthSource: PH0PR02MB7159.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jul 2025 08:54:12.5206 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: S2wdGv2AT2CGwETySwt5qIc0o203ivlXKKr3CHsD9JVBLiuAh4nfZ1uhrZYuPS/iDFrp6FuqKpAiCWm4kB/cZghFm5eslOQXTodmB7kQRm8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR02MB8048 X-Authority-Analysis: v=2.4 cv=Nffm13D4 c=1 sm=1 tr=0 ts=686f7fb6 cx=c_pps a=gS6jynj8eUnyaxK4LccMmw==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=xqWC_Br6kY4A:10 a=Wb1JkmetP80A:10 a=0kUYKlekyDsA:10 a=64Cc0HZtAAAA:8 a=HsFdn5qcwZwCtpCsMvAA:9 X-Proofpoint-GUID: uTrzvBCjZtDeiwDOVwNCv0e9-qyN1i_3 X-Proofpoint-ORIG-GUID: uTrzvBCjZtDeiwDOVwNCv0e9-qyN1i_3 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNzEwMDA3NSBTYWx0ZWRfX2mXDYRLwuJZY ByVRRqeaAnbejUPL8nVzbluisLPVLfdKSlk9fJ2Y0TBkeG8ENFB+D1Q0dwSazEoFtpDUB7bTHVF fBXzUFSp6gmOFsq0B0YpaHyTMaqN3iaXQW6kXWpU47L2HrtfCnq0BR+WXKAAA7AkddhNL/9ctzO TvslDqzNMFOveA9qOqJ9VA6fRGMY4w5efXCzAmvpM7M86TrJQG7O9QX4LjNTj9V7AXiS/mb7CpF 222k9hnqORbkJD5WswTzP4HY0w7qoXWNFFl3nJTzGNKyezs44Lvch4uSKOR2/+VYDJLKiLkbuFX MBbRIgY3+ztVKVVenI1R6aLVDnLbK0Phh5Iwg9I/M+YrEXlz8JsXJdrDoQxgcDRYu+kEM0EM5qM uaR6LrcVu88+Id5elhPgb1Yz5PMTInwzsd1aY7wL7MgSsYJu92fWh4k+J338nhjwRMgVvBtv X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.7,FMLib:17.12.80.40 definitions=2025-07-10_01,2025-07-09_01,2025-03-28_01 X-Proofpoint-Spam-Reason: safe Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=148.163.151.68; envelope-from=mark.caveayland@nutanix.com; helo=mx0a-002c1b01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, T_SPF_HELO_TEMPERROR=0.01, T_SPF_TEMPERROR=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @nutanix.com) X-ZM-MESSAGEID: 1752137744584116600 Content-Type: text/plain; charset="utf-8" Now that we can guarantee the i440fx-pc machine will always have a PCI bus,= any instances of rom_memory can be replaced by pci_memory and rom_memory removed completely. Signed-off-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- hw/i386/pc_piix.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index ed5a313500..ede7b68946 100644 --- a/hw/i386/pc_piix.c +++ b/hw/i386/pc_piix.c @@ -105,7 +105,6 @@ static void pc_init1(MachineState *machine, const char = *pci_type) GSIState *gsi_state; MemoryRegion *ram_memory; MemoryRegion *pci_memory =3D NULL; - MemoryRegion *rom_memory =3D system_memory; ram_addr_t lowmem; uint64_t hole64_size =3D 0; PCIDevice *pci_dev; @@ -183,7 +182,6 @@ static void pc_init1(MachineState *machine, const char = *pci_type) =20 pci_memory =3D g_new(MemoryRegion, 1); memory_region_init(pci_memory, NULL, "pci", UINT64_MAX); - rom_memory =3D pci_memory; =20 phb =3D OBJECT(qdev_new(TYPE_I440FX_PCI_HOST_BRIDGE)); object_property_add_child(OBJECT(machine), "i440fx", phb); @@ -214,7 +212,7 @@ static void pc_init1(MachineState *machine, const char = *pci_type) =20 /* allocate ram and load rom/bios */ if (!xen_enabled()) { - pc_memory_init(pcms, system_memory, rom_memory, hole64_size); + pc_memory_init(pcms, system_memory, pci_memory, hole64_size); } else { assert(machine->ram_size =3D=3D x86ms->below_4g_mem_size + x86ms->above_4g_mem_size); --=20 2.43.0 From nobody Sat Nov 15 10:54:05 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass(p=none dis=none) header.from=nutanix.com ARC-Seal: i=2; a=rsa-sha256; t=1752137679; cv=pass; d=zohomail.com; s=zohoarc; b=VP4ypXBqqzKWPsqI4Ecnfq49WvMz3LMtPH0D9txuWyHDV+6O4JhvKdxaKlJ0q+hewJvYgIeK7rv5RhoqFdibIUZy/cnpcYzvq2JR4r9uoH2vpB33P6T7sunYHVG4bjdySPI4xRNem2GYDV4yKaEP22CtNyjaeAcJi8seS+S8f3E= ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1752137679; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=ng9n9bUgxAGCYCeQjGtwS5tMu0TJ3H20zPfyrn3zffk=; b=jOKUskepIqZgM3HHzamv+OA9On2e6lu8QA27TjzzYvZ8zgfs20vuOzO9Z5M/MAqHEnPH9XHQn+PFitpKaRZpkJGgjGK4GqKNDdB6rHS7i0NEafNUqwKaEmBAc5dn3UReuPvO3aYYKUv2lqEk3csAeONClbyHnmpOo//X7Nhc8Oo= ARC-Authentication-Results: i=2; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; arc=pass (i=1 dmarc=pass fromdomain=nutanix.com); dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1752137679844296.8617466422421; Thu, 10 Jul 2025 01:54:39 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uZn37-0001gz-3I; Thu, 10 Jul 2025 04:54:37 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uZn35-0001cz-At for qemu-devel@nongnu.org; Thu, 10 Jul 2025 04:54:35 -0400 Received: from mx0a-002c1b01.pphosted.com ([148.163.151.68]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uZn32-0003e3-SE for qemu-devel@nongnu.org; Thu, 10 Jul 2025 04:54:34 -0400 Received: from pps.filterd (m0127838.ppops.net [127.0.0.1]) by mx0a-002c1b01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 569MJAsn028318; Thu, 10 Jul 2025 01:54:17 -0700 Received: from cy4pr05cu001.outbound.protection.outlook.com (mail-westcentralusazon11020082.outbound.protection.outlook.com [40.93.198.82]) by mx0a-002c1b01.pphosted.com (PPS) with ESMTPS id 47q3m150my-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 10 Jul 2025 01:54:17 -0700 (PDT) Received: from PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) by BN0PR02MB8048.namprd02.prod.outlook.com (2603:10b6:408:16a::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8901.29; Thu, 10 Jul 2025 08:54:16 +0000 Received: from PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88]) by PH0PR02MB7159.namprd02.prod.outlook.com ([fe80::6cf9:b35c:b143:bb88%5]) with mapi id 15.20.8901.028; Thu, 10 Jul 2025 08:54:15 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= proofpoint20171006; bh=ng9n9bUgxAGCYCeQjGtwS5tMu0TJ3H20zPfyrn3zf fk=; b=GtAwx2tHRQMmQA7d1Zy4Boy8UbggrVEJMoSviMUKoL4U4v7XdWplRzHYQ KILRk95NY2CJQXa2IuFsXA+rACmS9J9WtDn4EU0qfP1gDPlnIAy/iWk1UblIAgXc 3Twh7WJoRtrPNbla6Kcc6qrQynNxmAAgtjdrFfhlm/2C5ulwm/F+tia6iX01iJ4t sEHoD6te+aQncgeOXNFtJzDAUk2U8AEMDAbZKJbMQXCV88ayNYt7uwKromVR/V8G aIPOHibVf72FGRonzWGbtdU03vZRaqKejkWU9whOkt67ZLVZqLCPDCEwTS9zeHRF mkGBinhIeIwPS5UTAWBaLntr3ZWxQ== ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=qT+JdYXkVbyciYPUTqSQxSdaG5J/gSrKuk2b49cYDuKBpUVPYmkEp0uI1mVgz5tQXAM7RYUMSEy0Ub8SwVisLASXi0PaQkMXfun8R1NG45VSrXUb24bL0iDJsM3cFPm6m8G/T9INB57jUYOTXI2phYUop7bYB+8mkrPp3MVz7FZw/ho1ytxCS5SzG6SpUlonZXG5FXfbn8sCGs20U0Et5eih3Kmh65kImNF+YRwZjO20Yxb9Xvqzy5SasjZfEleLSpgg1lyZIBG9gevsFzHjuHodJaiEvsVlnNd3+QAJzYnwswaHeiWVwf3w9TM+gCQQ64gMWDK33Etq6uzqZbABjw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ng9n9bUgxAGCYCeQjGtwS5tMu0TJ3H20zPfyrn3zffk=; b=d3Dtiev4xJtfw0+VNDuzxRlmsr11YRy9FBt4T5j3Aaj4ugEauAXLXbZCeHHygGipE/zrMSVdgYa1LMrhQgoL6NHPkexx4dMfTIph3kKm815ey+Lm3U+3/p3xRCLkIOuF1+3Ia69fRivqsjt6BdvJdBiGUvfw33OcsBgMXY1nlItwxYxDho0tL4HC/7E9Q2UVjCy4Oz+KV3f8AYPWIJ3Fss5hqeD/+luPSU4VD2ITr+SvNvjFOd1Rlu4xnix89SxgrCC8K3vlNVA/xR4m/DnNALfUr4iyzp0gTCRYJG0MYP3cERT3nUFklZ8rPc63NB16biLpOkNWUWx0rgD3hePdkg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nutanix.com; dmarc=pass action=none header.from=nutanix.com; dkim=pass header.d=nutanix.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nutanix.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ng9n9bUgxAGCYCeQjGtwS5tMu0TJ3H20zPfyrn3zffk=; b=GMpHKjkOkl8yQcyz7TuMpPYPf2ZzLDavgIRpNwHuLFb1QiByHtF4UjziYmLYwLWzFBbRXceFGoiQe/EE9qdxVmChR+zXgre3JZGUiK7KK3c3KRLfh3mAe0sW2sbH08M+moM4V1CgJXVvRLaA+g+c3LcadswWAX6IgA7ITFbpIjvti99OGzY52YGlgBN9k+aq/+MRr1P22lXNVdtANVje/q8NyLT4kxEZOVGcsxw2sm7hDOvnBbe7dZDAoDEQIhVRwMiBlDOMvJiwzCn1z1chZsWZa8sRRskjW+F4WG4ev1c0of2qt9fBvcmV+52W4etJD5W5Sv4/w8YFFEXaXvOC3Q== From: Mark Cave-Ayland To: pbonzini@redhat.com, mst@redhat.com, marcel.apfelbaum@gmail.com, eduardo@habkost.net, imammedo@redhat.com, qemu-devel@nongnu.org Subject: [PATCH v4 18/18] hw/i386/isapc.c: replace rom_memory with system_memory Date: Thu, 10 Jul 2025 09:52:33 +0100 Message-ID: <20250710085308.420774-19-mark.caveayland@nutanix.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250710085308.420774-1-mark.caveayland@nutanix.com> References: <20250710085308.420774-1-mark.caveayland@nutanix.com> Content-Transfer-Encoding: quoted-printable X-ClientProxiedBy: AS4P192CA0023.EURP192.PROD.OUTLOOK.COM (2603:10a6:20b:5e1::9) To PH0PR02MB7159.namprd02.prod.outlook.com (2603:10b6:510:16::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR02MB7159:EE_|BN0PR02MB8048:EE_ X-MS-Office365-Filtering-Correlation-Id: 5e96ef16-a08c-4f2d-452e-08ddbf8f595a x-proofpoint-crosstenant: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|376014|366016|10070799003; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?z7BAHggeU/uL2rvfI2EW/SYrPgDltz4W5mmC2MMYdmOmzuxeBxdulTHS1plf?= =?us-ascii?Q?zkLKKMUN/gjNYfuxGuEt0YssEQt89CkAxl35Jzg9Hijsq2aIwOiosPse9y8m?= =?us-ascii?Q?S9yTy/lfo/ma9OuZjFxqepqRjTWxkwYz+WyUBXVYkon6TOrzsM/UhTi7Wt32?= =?us-ascii?Q?lSJDQs2mo90YsQaOvy8fAbzZpmy9f910DoQViuQ4ppeBQblkuiJMKh1Cd5tI?= =?us-ascii?Q?gp0Yyb8q9tgxLCDCyCHbMnZMcGkX/uMNf5eeiHRsomsKhalPy+L6I8u1hz+R?= =?us-ascii?Q?N0nS4PxlYKMMIsN+phEOWqKyRGRiUOtOWceDKr9lKxkDjoIbJj9aAlFKrQhn?= =?us-ascii?Q?WeQ1ukazh0+JAd8h+lq1yiAO+WghWO4lZwXbb8F3Ex6Xan4VHm/Ngx1bwU83?= =?us-ascii?Q?8V7usWoFhpXfXEww6lqLoSiMMvfaS9mrObkthMX2956xjRqOSZZgtx2H6AJv?= =?us-ascii?Q?nosqaXZnqS/Qmn+/MauTEDQxhcr6FeqAaSBnTe/jGytgTZ6tmSygUnqxBnem?= =?us-ascii?Q?WNn7rTdLcyve7lXe2UQshtPLG0pT1/Gjc9eNndcoN6WqdNi8DKsiLj38D5Il?= =?us-ascii?Q?DOGWWS7NKfuY6XTlbOCLyTStA3oGx7cu+7rUqtuLbXfeXUjP4E8wVgSFnpWG?= =?us-ascii?Q?7rFEuDyaTQrawQpTj6K3bWdvSxM94Fg0/D0ew37+HAjmGIp6Qbxfjdkqsyn7?= =?us-ascii?Q?h2UVH7sjRptwAYkW44Rbk61UxNjvqlXzmpy/ZZB81P2a6iK3a0aZjyMVrLzy?= =?us-ascii?Q?K2XIRt+bkhWW/rndKpawzL2TemSeyA//pD5XNCxLIWd+OIuk8Jd4qtAL//m9?= =?us-ascii?Q?egGPdt3ZWzh4ThdNpR7NqIgD2PLuwbAP+Bfd0HoZvlM7UgBF8vNtDdp+FfDl?= =?us-ascii?Q?jxDed9uVB6ASk1pIy45eA/N7dbnTlacy23JYVMPLHbM6wMogk6M+bYjendrd?= =?us-ascii?Q?23hdWTSMT5N+7OzIzg1YePmaVdcOR9GW0nNaRDIAHJ0B6VJjb5c4lWAYf3w5?= =?us-ascii?Q?L3AbKxRjqNc1R8HGXdHqYbo88e/1qQ4lbbBT/UmXmdb2j7nodQfrh+voHhYG?= =?us-ascii?Q?OpjF+yPsMoD5ze2SIBuHHPv6nYkYBDkRDuoodV7VeuOd5KXNs+0Aps/ya9v9?= =?us-ascii?Q?rQ8tRDWUygNn5OoH9DhXw4d2wrDr6UKTxYn58FjaK/vk0Gtvlz5TCBibisE0?= =?us-ascii?Q?QJQgKGoKoTE3i5tnTE+EfqPP3EwRUKLNNmf/qWBLBQYOeIS3Pq68A8GyLkKA?= =?us-ascii?Q?qJ11/vMbHIjyb+gTJhxqkU4zy8v7FNTQ5t9YddaxsM5zJfUV6fB54QNkzgiy?= =?us-ascii?Q?1kqmMVmBjPv9Nr/pDMiuIWhiZtCDB4MQFMd2pSxKQww+TF/Kl9Omt6EPGlGn?= =?us-ascii?Q?xBYnEXdwf5f1M46vP4x01DwszmUaw7z1KubppG0Z7iGtnEYK++P48tIu9K9y?= =?us-ascii?Q?3/BiW8XmrJU=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR02MB7159.namprd02.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(376014)(366016)(10070799003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?X3G69uPOm2PUwwdDOxyo/AOdVecitNPseP8qJVbPntBeZChVITZAUcRhVTUn?= =?us-ascii?Q?SCGr3/d/PlDaO8KEpj8USQ3aL4meMvevDKu8mN4IuJTe5gIXxTeocgkGLz7J?= =?us-ascii?Q?hqNtgILObMOoFtuRMNgfkLSL/yYwnSI8Jc1ErCV9jFiWpFTI88U9uK391ULY?= =?us-ascii?Q?5Dil3Gp7x24XBE+nbO+s0USnQm70EKVuoZiG6l8F+CFa0vCtRXalvFB0ZCq7?= =?us-ascii?Q?vPPL66vZEZwl3LZgXCgs7M+Dho6lz+GEjMeK571ltTfowE59GgGEDFiy8JJp?= =?us-ascii?Q?QGgcZ9fWqpI0DYokXJNvk5A+8DofMSKOgg/jxANBa6HQuSXCqydit+1ads/k?= =?us-ascii?Q?AQRwChfqA+wDGn/57yfY5ckatvGEDaIQQU3PdtZBaCnY0a3WIdb9PBL+vvFx?= =?us-ascii?Q?pM55R85sVk0/EZUjoRXunmwbBGkAE0Ay7OlwKNmOzuAok/F2X2vqfesSr2Zt?= =?us-ascii?Q?//n6wtb/aDK8yfF0jW/dWRz25h3ny71VZcKvwSYJSo/bpwWROL+KB8Fd3lnX?= =?us-ascii?Q?7ajs/vBdZaG/5OocoaLptZA24vFmVFls0xDwYj9906d9CuiaX2pfh5Ir+Yqk?= =?us-ascii?Q?sQaaEsK7ojeJQ61jXgyKKYTCP4VKPtW03Phm8YQxLfaNWptaLUFRERESG2Bq?= =?us-ascii?Q?pBvcfwWNgA+iMC9YEivuETRq+bzXinHuPk5abEsYeXF1Cp7FtZg6rg6kQMDU?= =?us-ascii?Q?g0x+DCzHd1kYmV5GPZESZ/AqHIEHDG/4aJMY2DaePWP7tVq4IFV+LSFRB1ua?= =?us-ascii?Q?YlOgdUjjklYzkwRfK47tSuJIao8YWpD39X9Dm9/55hLca6lIEdf7+O9v3u6H?= =?us-ascii?Q?+OoGuYZKKoLheVTM+en2O4A6XA3X7Klzj9O7otEAnNdYX3t5rgC3EW/AIQtn?= =?us-ascii?Q?IkTAiHi6V/RbRTmO55wIgXnONuKgWA5QMOwFCMrXa0PJvQJ9xJyKyz9o+SGW?= =?us-ascii?Q?0VPnXop7KuVleqPbpt5fh+wewdGMf8i9JoSv5XykdcJbK3elrFTGtHUyjVTy?= =?us-ascii?Q?ZlWhpv7PE2dzrXhlUaDyShMp167pQcKt0gOX5rqNzPzoYczBxKx8eXH7U8zI?= =?us-ascii?Q?NZYURmyn63Z3UGIfjkO8/YxG6LYlKgIElSer9am3qTUe7k01xN8KnmDtr8AI?= =?us-ascii?Q?YA9rtZlB+13uWXkMdYCYeORKHeKJGV54619FmgcNJVm+gY9uVGXouGDr9XgI?= =?us-ascii?Q?DjEYTT899B8JjwOd4YBACMVOpB4HZvZppyHKtsrwB2GI19fm9/QZ1ZsE/ER0?= =?us-ascii?Q?sFBNb9AdwXt1s+Yh3Ncge3bz9dJPDWSM5xt835rdgg1EtFgNxVb70DhMJPTR?= =?us-ascii?Q?0QxmFgRTyRdVHw+iSmn4jBff45N0+/wBGP5N5S1W3X4ciYqVAOiGw4irCzj+?= =?us-ascii?Q?gYGy6mHCHYcYwVsJyS57Qwvf2DTo+ahOBs2fjPUaDcgWfww2QdpGRbzpcPAn?= =?us-ascii?Q?RIC++wtPjgWjb5UVdoXKd6HrSHAGQZfQML/PSNP5o5oDEjlKuY3eZ75ca49g?= =?us-ascii?Q?YabrwYRdub9oDAsHf4Kkrynf6FRtrBke7jI585AVEC/+PTqAXuSOA1+rIlub?= =?us-ascii?Q?ASkqMx7qA4CFTeP5omFNmpjBMl68vNEdMqb3/TpuPZnl2RdBzj0xTDKNM9ab?= =?us-ascii?Q?0qzuakjWmbTww1AHSlXwFddSZA44Dg5RDAGNrSPzPAtixmNgg8vccy0YQWFB?= =?us-ascii?Q?BbuBQw=3D=3D?= X-OriginatorOrg: nutanix.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5e96ef16-a08c-4f2d-452e-08ddbf8f595a X-MS-Exchange-CrossTenant-AuthSource: PH0PR02MB7159.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jul 2025 08:54:15.7652 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: bb047546-786f-4de1-bd75-24e5b6f79043 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: qeN6nLY3he4B23yfHr7dNJy6hiDVvOXcWAWjLNJ6MFL7Kjcwxapy9yk1zGktuOuUSTVyp7shTCF0rPa0JSNdPQzKydp/lQRj8a3J/zXtQAE= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR02MB8048 X-Authority-Analysis: v=2.4 cv=Nffm13D4 c=1 sm=1 tr=0 ts=686f7fb9 cx=c_pps a=lntwMuBcOMWYP1oWCx7eiA==:117 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=wKuvFiaSGQ0qltdbU6+NXLB8nM8=:19 a=Ol13hO9ccFRV9qXi2t6ftBPywas=:19 a=xqWC_Br6kY4A:10 a=Wb1JkmetP80A:10 a=0kUYKlekyDsA:10 a=64Cc0HZtAAAA:8 a=BKspdhvg69VpFdegezIA:9 X-Proofpoint-GUID: FokeU87Sn81zMQZ1hI7p9yYk5ldgB9Kx X-Proofpoint-ORIG-GUID: FokeU87Sn81zMQZ1hI7p9yYk5ldgB9Kx X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNzEwMDA3NSBTYWx0ZWRfX101060RRKk/+ 998AaMEapOFoPzMRIzs0HipW7daWEmiGWe8t2uLVOxeYg0G1dUbcJSlqx6tlp/Sryr3ZZNl+zaZ w2iZfidsSRRYVsfVnvH7A0yagCCBxAifcIfjRckUbGv/SAPtEP5WZfTwAqmJlxo5+ldkL5fE7zC tZ2h3HVS93LEh+0OhFE0ZxQaaFvfe9vddSw5iVmCn4qCenmLFwSxMyBIFQ0eVITd886mhwZdR14 qcK1EbZJe0YAEav7L8g6jCV5cmx0y5q8Cq3Qd40sC4W5DeX+M3eFnEOIOPoWY5Qq/vU6cymWuuE 7QqfGDfM6iYNSqr9rmJoEfzojPZFko55qvhbW1LZdZu9I920Bu0ULT1CYDZEAZYHnTlpOrUVMYi 51qKxbiQQaoMFMdIGQjXj9oX8MSJSpTSJO0d7ClBteMzLpvFhd5PrwBqnbDw5+cCf2gohI3C X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.7,FMLib:17.12.80.40 definitions=2025-07-10_01,2025-07-09_01,2025-03-28_01 X-Proofpoint-Spam-Reason: safe Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=148.163.151.68; envelope-from=mark.caveayland@nutanix.com; helo=mx0a-002c1b01.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @nutanix.com) X-ZM-MESSAGEID: 1752137682035116600 Content-Type: text/plain; charset="utf-8" Now that we can guarantee the isapc machine will never have a PCI bus, any instances of rom_memory can be replaced by system_memory and rom_memory removed completely. Signed-off-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- hw/i386/isapc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/hw/i386/isapc.c b/hw/i386/isapc.c index bb22083821..27c075b5f3 100644 --- a/hw/i386/isapc.c +++ b/hw/i386/isapc.c @@ -35,7 +35,6 @@ static void pc_init_isa(MachineState *machine) ISABus *isa_bus; GSIState *gsi_state; MemoryRegion *ram_memory; - MemoryRegion *rom_memory =3D system_memory; DriveInfo *hd[MAX_IDE_BUS * MAX_IDE_DEVS]; uint32_t irq; int i; @@ -73,7 +72,7 @@ static void pc_init_isa(MachineState *machine) =20 /* allocate ram and load rom/bios */ if (!xen_enabled()) { - pc_memory_init(pcms, system_memory, rom_memory, 0); + pc_memory_init(pcms, system_memory, system_memory, 0); } else { assert(machine->ram_size =3D=3D x86ms->below_4g_mem_size + x86ms->above_4g_mem_size); --=20 2.43.0