From nobody Sat Nov 15 14:51:53 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1752011035; cv=none; d=zohomail.com; s=zohoarc; b=KP1xlhdvM4K8fmdbM5owNV4+QFF5He1k+tcS0EWxbQmjhvxAAhaLPrFRd0DbxXvyHoQGdBohm7zUiuXXEBlHfV3XiUsVoPhSAt+hFKxLZvuOMOkRvT8wKPL2+qWDYhDPwsjUe/LT6Hgjf6+r326cmZfis3ZXJCVC0cQqgodR+KI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1752011035; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=VK+7t2j2kymFsc3IeGpMe2sULS+2lCNmhWxaVyDzmrY=; b=bBVX24bLB2R2JeH4p/3xQ+vJ5AxLHBinpAt3xtBqmbOmJnNSgHDSR3zvTyyqgtWzOH9sOekeKqd/4XrE6+uc65Ji5NRh0zsFT8YW61QD1AAu4psiY6oTcdjik76tofZjjdQN3QnfTUTJIOTMpinM3wFIf4xJlj5gen/QD4zHll0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1752011035902234.80422547067474; Tue, 8 Jul 2025 14:43:55 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uZG4g-0000WY-Dm; Tue, 08 Jul 2025 17:42:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uZEtC-0003Lr-DO for qemu-devel@nongnu.org; Tue, 08 Jul 2025 16:26:06 -0400 Received: from mail-ed1-x530.google.com ([2a00:1450:4864:20::530]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uZEtA-0007oY-JU for qemu-devel@nongnu.org; Tue, 08 Jul 2025 16:26:06 -0400 Received: by mail-ed1-x530.google.com with SMTP id 4fb4d7f45d1cf-6097d144923so598064a12.1 for ; Tue, 08 Jul 2025 13:26:04 -0700 (PDT) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [2001:8b0:1d0::2]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-454cd4a68ebsm19731255e9.39.2025.07.08.04.52.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Jul 2025 04:52:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1752006363; x=1752611163; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=VK+7t2j2kymFsc3IeGpMe2sULS+2lCNmhWxaVyDzmrY=; b=kuelZM96BGQ4UgIT2GY77PxZOSZR6UHPs8QaOaTLzA2fk8gTStMPyYx9uLVHCrWJwt +trvQtSA11n5PES8BV0HaedThyXYx/X1ybE12VjiA17mb2b+9vJdwxTCFZKYbK9BLaqh a4w7l2qr4/RoJzhSLzfREOBYz6OSI59VaySlYbF+kjhMAujAuWCCO1rgWjtUQmGKptcc YFpsHA1go5SSyV2NnYEMHtB6zWaIyhI+lnslNHD5FFN7xgx4CVmrQCXHFML+7izxVk+f b0F8RXsU4uUVKqRxfEDiPSsaQqSeTJ+e2ygeR52O3wojvdftkGkmR7o/43SAStGpQbmF 3zhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752006363; x=1752611163; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VK+7t2j2kymFsc3IeGpMe2sULS+2lCNmhWxaVyDzmrY=; b=SGQKEOVP9R3NnHhxGRJR5ofeMxmQO0BohaqeI13WMiuhKOlmd3p5sX7d2JeQ1euyDz vGMmSh25FDHRSV+6wUkI89xmmpJnrYljWJHV+bt1xjOt36onWUuCs4+TOoc+hPycONwN axFmwdO0H7q/USUcmm28XWqyu4yG0DjlrjRraYFDAu+f06c7x+0zZ6hZSXvVtKj5srUm oa+Dc/vdzoCw25OwkWbnGftZHwDkBbH8zMaBRS2j+lrpBZifyXSClwNd2LtA7VTf7Bfa a5YCMORBi+J3etdRYCAEdiLYckuXDoX1NIDlTbWKS4/Y99r/7bpFLtxlFk1Mvdlo4KyH tIug== X-Forwarded-Encrypted: i=1; AJvYcCVN+G/FsvaWAvqoVRrKc3VjNCz4kxOdmSfaTJS7mZJ8ObwY7R8pL+VXhEBZYDAtFllcLZribQoQx5ke@nongnu.org X-Gm-Message-State: AOJu0YxHI6fSmXvHcBQpNzzrzcKpIh43rl5IibYLUxM92Gc51C/xe7+r iYyMFKm8dhQ+LJtFgUPSYg4G9xUNLTf9Zl3jd10QRONLYtHIoSz0N0FmOO5nWM2wSqP+ZBhamXX NLCWq X-Gm-Gg: ASbGncugc1Y8YGQyhBsf0gOodB2q80zQewK9dil7egHetwKKZw8ip84nHBvtcl8QKP8 yVqoBWHTmCc7yeYbaSoyO1PYGk54PHRf1COVbgOnTtRmj8fWxXHRkFHzJ+nBj/lOco5mk3n5sKz hppG500qB4xuzbKJWzGkYGd61jvM2W+Zs2Y/+gSL925LcDFVmU+w1DOAeW7hK2N33kfUe+RCfuf C02jSHsNTBMoE2cpUhHRljMbIE39DOiYa639aeOv9tv/5azw0hy8/YUT6ARq1G9Nx4K6XjzLdEW g7yuN2SzYLHglixILpKHeplzPz8mgyE7kt8S32VLMQK1L4VpUuNAhBIjj6AW+XKDCxDi X-Google-Smtp-Source: AGHT+IGALo4sVNBgG4JPDbkGK0xlAvZZ58lvqIhuwe9o8VqKKyz/RfIsQzbeyBd1YX8sRyHbJdn8Wg== X-Received: by 2002:a05:6000:250d:b0:3a5:5136:bd25 with SMTP id ffacd0b85a97d-3b5ddfb8b30mr2465893f8f.1.1751975565039; Tue, 08 Jul 2025 04:52:45 -0700 (PDT) From: Peter Maydell To: qemu-arm@nongnu.org, qemu-devel@nongnu.org Cc: Eric Auger Subject: [PATCH v2 3/3] hw/intc/arm_gicv3_kvm: Drop DPRINTF macro Date: Tue, 8 Jul 2025 12:52:38 +0100 Message-ID: <20250708115238.667050-4-peter.maydell@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250708115238.667050-1-peter.maydell@linaro.org> References: <20250708115238.667050-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::530; envelope-from=peter.maydell@linaro.org; helo=mail-ed1-x530.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1752011037130116600 Content-Type: text/plain; charset="utf-8" We don't generally like DPRINTF debug macros, preferring tracepoints. In this case the macro is used in only three places (reset, realize, and in the unlikely event the host kernel doesn't have GICv3 register access support). These don't seem worth converting to tracepoints, so simply delete the macro and its uses. Signed-off-by: Peter Maydell Reviewed-by: Eric Auger Reviewed-by: Richard Henderson --- If anybody needs to debug this code they can add useful tracepoints at that point. I don't think these DPRINTFs will help at all. --- hw/intc/arm_gicv3_kvm.c | 13 ------------- 1 file changed, 13 deletions(-) diff --git a/hw/intc/arm_gicv3_kvm.c b/hw/intc/arm_gicv3_kvm.c index 8e34d08b415..e118c1b1f04 100644 --- a/hw/intc/arm_gicv3_kvm.c +++ b/hw/intc/arm_gicv3_kvm.c @@ -34,14 +34,6 @@ #include "target/arm/cpregs.h" =20 =20 -#ifdef DEBUG_GICV3_KVM -#define DPRINTF(fmt, ...) \ - do { fprintf(stderr, "kvm_gicv3: " fmt, ## __VA_ARGS__); } while (0) -#else -#define DPRINTF(fmt, ...) \ - do { } while (0) -#endif - #define TYPE_KVM_ARM_GICV3 "kvm-arm-gicv3" typedef struct KVMARMGICv3Class KVMARMGICv3Class; /* This is reusing the GICv3State typedef from ARM_GICV3_ITS_COMMON */ @@ -721,14 +713,11 @@ static void kvm_arm_gicv3_reset_hold(Object *obj, Res= etType type) KVMARMGICv3Class *kgc =3D KVM_ARM_GICV3_GET_CLASS(s); uint32_t reg; =20 - DPRINTF("Reset\n"); - if (kgc->parent_phases.hold) { kgc->parent_phases.hold(obj, type); } =20 if (s->migration_blocker) { - DPRINTF("Cannot put kernel gic state, no kernel interface\n"); return; } =20 @@ -807,8 +796,6 @@ static void kvm_arm_gicv3_realize(DeviceState *dev, Err= or **errp) Error *local_err =3D NULL; int i; =20 - DPRINTF("kvm_arm_gicv3_realize\n"); - kgc->parent_realize(dev, &local_err); if (local_err) { error_propagate(errp, local_err); --=20 2.43.0