From nobody Mon Sep 21 20:55:15 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1752005421; cv=none; d=zohomail.com; s=zohoarc; b=RJRsRYu5wysnAY9CYI3LPctgyQnivhKMvKuaPG14T+R06RfAiWuA+fnN/anbn2Xmab/qxHXCSl2oP1ekeH0dsNS4a1ZMBMN8kghs04swhdAYWlHSNEOAvkCLJ6LrudLZsINwcNcpXMJV/U20/NrhaCxLISkpMuQKdwwjmZ4Uz3I= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1752005421; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Sender:Subject:Subject:To:To:Message-Id; bh=Ppd5dv4Tp7YRamv0O63EAhTYLmJq5HGWwv6YhqWwEPs=; b=bPo2zTTqIi/ILfNlMrdNQsJXb9CDEKgoqjIBL0Rfhi4Z5k3rsmT0y/K2nACJ91FBhMDxG0uJKJKcUoNwUZ8HT5+woN9Zhm0iozekCkLlrhtF4OZ71VxtG8ThEzK0EPFfw9febTtRWynfDJg3pP5pZEUibftYrlTpMCGYTin6Em0= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1752005421819292.1705775605616; Tue, 8 Jul 2025 13:10:21 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uZEci-0002NY-75; Tue, 08 Jul 2025 16:09:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uZDTq-0001oT-6p; Tue, 08 Jul 2025 14:56:13 -0400 Received: from mail.aspeedtech.com ([211.20.114.72] helo=TWMBX01.aspeed.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uZDTb-0000ci-3g; Tue, 08 Jul 2025 14:55:44 -0400 Received: from TWMBX01.aspeed.com (192.168.0.62) by TWMBX01.aspeed.com (192.168.0.62) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1748.10; Tue, 8 Jul 2025 13:58:11 +0800 Received: from mail.aspeedtech.com (192.168.10.10) by TWMBX01.aspeed.com (192.168.0.62) with Microsoft SMTP Server id 15.2.1748.10 via Frontend Transport; Tue, 8 Jul 2025 13:58:11 +0800 To: =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Peter Maydell , Steven Lee , Troy Lee , Jamin Lin , Andrew Jeffery , Joel Stanley , "open list:ASPEED BMCs" , "open list:All patches CC here" CC: , Kane-Chen-AS Subject: [PATCH v4 5/5] hw/misc/aspeed_sbc: Add machine parameter to alias OTP drive property Date: Tue, 8 Jul 2025 13:57:57 +0800 Message-ID: <20250708055810.2868680-6-kane_chen@aspeedtech.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250708055810.2868680-1-kane_chen@aspeedtech.com> References: <20250708055810.2868680-1-kane_chen@aspeedtech.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=211.20.114.72; envelope-from=kane_chen@aspeedtech.com; helo=TWMBX01.aspeed.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_FAIL=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Kane Chen From: Kane Chen via Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZM-MESSAGEID: 1752005423671116600 Content-Type: text/plain; charset="utf-8" From: Kane-Chen-AS This patch adds a new machine parameter `otpmem` which creates a QOM property alias on the aspeed_sbc device for the OTP drive. Example usage: ./qemu-system-arm \ -machine ast2600-evb,otpmem=3Dotp-drive \ -blockdev driver=3Dfile,filename=3Dotpmem.img,node-name=3Dotp \ -global aspeed-otp.drive=3Dotp \ ... With this change, the specified alias name (e.g. "otp-drive") becomes available on the QOM path `/machine/soc/sbc/otp-drive`. Signed-off-by: Kane-Chen-AS --- hw/arm/aspeed.c | 20 ++++++++++++++++++++ hw/misc/aspeed_sbc.c | 8 ++++++++ 2 files changed, 28 insertions(+) diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c index c31bbe7701..8ec32369a6 100644 --- a/hw/arm/aspeed.c +++ b/hw/arm/aspeed.c @@ -48,6 +48,7 @@ struct AspeedMachineState { uint32_t uart_chosen; char *fmc_model; char *spi_model; + char *otpmem; uint32_t hw_strap1; }; =20 @@ -1424,6 +1425,21 @@ static void aspeed_set_bmc_console(Object *obj, cons= t char *value, Error **errp) bmc->uart_chosen =3D val + ASPEED_DEV_UART0; } =20 +static char *aspeed_get_otpmem(Object *obj, Error **errp) +{ + AspeedMachineState *bmc =3D ASPEED_MACHINE(obj); + + return g_strdup(bmc->otpmem); +} + +static void aspeed_set_otpmem(Object *obj, const char *value, Error **errp) +{ + AspeedMachineState *bmc =3D ASPEED_MACHINE(obj); + + g_free(bmc->otpmem); + bmc->otpmem =3D g_strdup(value); +} + static void aspeed_machine_class_props_init(ObjectClass *oc) { object_class_property_add_bool(oc, "execute-in-place", @@ -1445,6 +1461,10 @@ static void aspeed_machine_class_props_init(ObjectCl= ass *oc) aspeed_set_spi_model); object_class_property_set_description(oc, "spi-model", "Change the SPI Flash model"); + object_class_property_add_str(oc, "otpmem", aspeed_get_otpmem, + aspeed_set_otpmem); + object_class_property_set_description(oc, "otpmem", + "Set OTP Memory type"); } =20 static void aspeed_machine_class_init_cpus_defaults(MachineClass *mc) diff --git a/hw/misc/aspeed_sbc.c b/hw/misc/aspeed_sbc.c index b56a8b7678..b82c5e37cc 100644 --- a/hw/misc/aspeed_sbc.c +++ b/hw/misc/aspeed_sbc.c @@ -209,10 +209,18 @@ static void aspeed_sbc_instance_init(Object *obj) { AspeedSBCClass *sc =3D ASPEED_SBC_GET_CLASS(obj); AspeedSBCState *s =3D ASPEED_SBC(obj); + char *otpname; =20 if (sc->has_otp) { object_initialize_child(OBJECT(s), "otp", &s->otp, TYPE_ASPEED_OTP); + otpname =3D object_property_get_str(qdev_get_machine(), + "otpmem", + &error_abort); + if (strlen(otpname)) { + object_property_add_alias(obj, otpname, + OBJECT(&s->otp), "drive"); + } } } =20 --=20 2.43.0