From nobody Fri Dec 19 18:53:52 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1751909059; cv=none; d=zohomail.com; s=zohoarc; b=DeD6X5INmLFZprQyZx4Uwt2X+mlRcjJyPKfvdC9NWYldH92QotJIein3x+UE7kFGs7u9fI+eSopTqFkuCuc5jn+CC5TX9EMUVC4fyRPc6EOmkErxlXi2fgs3hRt0ldPigjd9hqkmahT32ieMZTXlXCGrQJXMKV/xcNmR2nKY8ao= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1751909059; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=RFonhSB51r1m9DRDPq3gxW3IKaSRsXZYDkC267ansE0=; b=P2RJecQ/U5YtBoja14CV30iEn2JlOOJ49yO/j5XHg1xeu9rC/ew2yn5iDcWRgVu4eu92JbHdijZG01b0ZJNAPJCJ7PwkzkXr61lnmEmv0mGT1CeCxY1Vw4AhAZRjUtVg8BcdcuMAaJJ1i/pp0sGVqiJG+6l3nqrCwu5lQunO8y4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1751909058777989.6178405333901; Mon, 7 Jul 2025 10:24:18 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uYpYT-00054N-Sx; Mon, 07 Jul 2025 13:23:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uYpWT-0000kS-7K for qemu-devel@nongnu.org; Mon, 07 Jul 2025 13:20:58 -0400 Received: from mail-wm1-x329.google.com ([2a00:1450:4864:20::329]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uYpWO-00058S-5F for qemu-devel@nongnu.org; Mon, 07 Jul 2025 13:20:55 -0400 Received: by mail-wm1-x329.google.com with SMTP id 5b1f17b1804b1-450cfb790f7so26806745e9.0 for ; Mon, 07 Jul 2025 10:20:48 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-454a9bcf35csm147172605e9.20.2025.07.07.10.20.45 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 07 Jul 2025 10:20:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1751908847; x=1752513647; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=RFonhSB51r1m9DRDPq3gxW3IKaSRsXZYDkC267ansE0=; b=tX5jj3y6GzOlWOO/ey+MQQQDZWQeuOK7XpbtwCtlOQoxxs76dz884cYpP/0bltCmZB oqVX5nJhP6SfaqfNCMLZ27pYjgSJ6W85nibSfS2/rAO4bEA//DrykmlcQ6aaXsgW849R dkJpuVl22zxEuLSfxPiHNYq71e0von0zZagxgl7V7cl9gUPuqlheENGZ+AWmzV72Er9o 0hNLElbsFX3kkvVi1UaMg/+0aONG+dT/Nqi6O4W6nP4OE5OCe6Kr+hWU9EJDRp/O1ktO so1weJGw8GgWUpi7ViNX2ePS1kskk0kmRIhDzQKxlZ6rTLhnNQ89sw7U+/GY4aEMwcSx 6PEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751908847; x=1752513647; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=RFonhSB51r1m9DRDPq3gxW3IKaSRsXZYDkC267ansE0=; b=ThGIRJxMnmctgLb25d14LmV85LTHivsDlahyd2h37l12+hqPNBaKuAs7fxGQUQMLUQ kYrs8KVXJcvDs3lpGnbbC7qbYa8uL390NTVShBkKvT8+Y2sIg4anBh3h95GjEB2tNKdd RSMV7o+d9TpLGh9TZWyRZq9J1/TuraIRi1hvz4v2ZP2Kj45paL9J6DIFgENxUqytdngr R5psceagsfFq0WT+q8prir3BE6SRjPaqxZWTiPZzRNA89NZ//ViN2414/btUecQkytFD 7EyPEJKXTJrFqrVNbbP4kXX/r2mDD2y7uwbLqleWwwE3QVVdEZe69xdKrJQH+ZO2Ho2m 2VFQ== X-Gm-Message-State: AOJu0YwUWALYJ2ooNhNzavTj4D9BrZIUe7sK1BgA2xRGt9GZd/r/bI9/ aWbAw/06Xk+2GNAePSvDbdIBHQWSH+jweFirmha7vPLArnY7sjFHv2hd8YVQ+SwiVmdVgHWzUSh XXYkQd7o= X-Gm-Gg: ASbGncvp8ZsVjPLyTRT/Gc8gdRfkVQIUUcBGlg4VzJe/GI0nsEi0HwdUTNyKcp16dpC IjKDA+ZsottACcMrn1n0QjYiGejGqs14Lqt956+Qh2chFVIW2SLsDbBb/eafMamWNQ7oIKz+mw7 qyMSL1VOdYHQLok4wAfsBI2OzI09rPfjEKKVO/D8hoB2i3gDbj+tNejep46hvTWSeb68Kw+52b0 /MnfgsYizR7rhJKo1nGNuoBd2G0ETqCBmhjUO9ZTmUx5TaEWTMfw+KcAYnL23i62N34uOcwInM3 b7GJX1nF36tahsFMfvJvlBTTMSIuM9JeQoF4G0nBUpAyGAT1sfmaAVGATpBMp+934J4qEYvsfwI lTze/DNp0nGytpNZnbRVsERtKSp7axQWV80OL X-Google-Smtp-Source: AGHT+IGhI82KjTmq2GBYUFjCnNZWFDyft3wJhBMSIY8cUy9DDxHlM8oqhAuXnW0mZvX6TO7CAfhsVw== X-Received: by 2002:a05:600c:818c:b0:43c:efed:733e with SMTP id 5b1f17b1804b1-454ccc799d0mr4855545e9.14.1751908846639; Mon, 07 Jul 2025 10:20:46 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: "Michael S. Tsirkin" , qemu-s390x@nongnu.org, qemu-arm@nongnu.org, =?UTF-8?q?Alex=20Benn=C3=A9e?= , Pierrick Bouvier , qemu-block@nongnu.org, Richard Henderson , qemu-ppc@nongnu.org, Paolo Bonzini , qemu-riscv@nongnu.org, =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Subject: [PATCH-for-10.1 v6 07/14] gdbstub/helpers: Replace TARGET_BIG_ENDIAN -> target_big_endian() Date: Mon, 7 Jul 2025 19:20:01 +0200 Message-ID: <20250707172009.3884-8-philmd@linaro.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250707172009.3884-1-philmd@linaro.org> References: <20250707172009.3884-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::329; envelope-from=philmd@linaro.org; helo=mail-wm1-x329.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1751909059935116600 Check endianness at runtime to remove the target-specific TARGET_BIG_ENDIAN definition. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- include/gdbstub/helpers.h | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/include/gdbstub/helpers.h b/include/gdbstub/helpers.h index 6f7cc48adcb..1411b136d5c 100644 --- a/include/gdbstub/helpers.h +++ b/include/gdbstub/helpers.h @@ -16,6 +16,7 @@ #error "gdbstub helpers should only be included by target specific code" #endif =20 +#include "qemu/target-info.h" #include "exec/tswap.h" #include "cpu-param.h" =20 @@ -55,18 +56,14 @@ static inline int gdb_get_reg64(GByteArray *buf, uint64= _t val) static inline int gdb_get_reg128(GByteArray *buf, uint64_t val_hi, uint64_t val_lo) { + bool be =3D target_big_endian(); uint64_t to_quad; -#if TARGET_BIG_ENDIAN - to_quad =3D tswap64(val_hi); + + to_quad =3D tswap64(be ? val_hi : val_lo); g_byte_array_append(buf, (uint8_t *) &to_quad, 8); - to_quad =3D tswap64(val_lo); + to_quad =3D tswap64(be ? val_lo : val_hi); g_byte_array_append(buf, (uint8_t *) &to_quad, 8); -#else - to_quad =3D tswap64(val_lo); - g_byte_array_append(buf, (uint8_t *) &to_quad, 8); - to_quad =3D tswap64(val_hi); - g_byte_array_append(buf, (uint8_t *) &to_quad, 8); -#endif + return 16; } =20 --=20 2.49.0