From nobody Thu Dec 18 12:29:47 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1751904744; cv=none; d=zohomail.com; s=zohoarc; b=H4KR9RYJJbwaP+gwi5iHGW64hrs+Q0cavMTvNKWVaAol2894IruoR5VGrNORWk2BkJTzK9/KIaBcaorev9XGZz802nRu05zTLlijq5KHHAf8u+4yXVvUPqKMYFXPNzWUt9ehAmlRWWJUpXtMuIZsg3tcnJEOreUm7/Ttyu4lEOQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1751904744; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=Z7zVf5YnOCPvcqn6yKrlfucDJ6AlSHJertRqzvoA/ik=; b=KAZOwAcWSkP1VyBLMNUcd5Y1XHzi/37uyuSLfaCcST057ErAi85w+6pTZ711eVwATP/qLEkNW7BooEqGUsQjcddtMneRfAHNaSo822y3lxMJIQ20zmtBF5PGVxhwoWfYOSUlbgVrwNd1GTv0NMFCazgFBDBRoNPPRJPEAQysLng= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1751904744506288.28304363946415; Mon, 7 Jul 2025 09:12:24 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uYoRe-0002xD-9k; Mon, 07 Jul 2025 12:11:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uYoQD-00015z-Jr for qemu-devel@nongnu.org; Mon, 07 Jul 2025 12:10:28 -0400 Received: from mail-wr1-x430.google.com ([2a00:1450:4864:20::430]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uYoQB-00012K-GR for qemu-devel@nongnu.org; Mon, 07 Jul 2025 12:10:25 -0400 Received: by mail-wr1-x430.google.com with SMTP id ffacd0b85a97d-3a51481a598so1827338f8f.3 for ; Mon, 07 Jul 2025 09:10:22 -0700 (PDT) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [2001:8b0:1d0::2]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b4708d0aebsm10842820f8f.37.2025.07.07.09.10.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Jul 2025 09:10:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1751904621; x=1752509421; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Z7zVf5YnOCPvcqn6yKrlfucDJ6AlSHJertRqzvoA/ik=; b=pZjyGFpoEiFrMHtggamgtglNLMOWJjyqvbrmA2SuiAckdCdBcprsmveHecPRzbgcLC 9q8ufMLT97K5Icrplan7YEwSeNMJgxXQgNsspmX65kOZ1lVfpBT2+Mvr+7khfsrCtWG/ rPQUnofCYGQx7uuYXUOoUGJnI53pNrwHoQic3xBe61/4o3iI4bIFcVCNalthLtpgSG8n anqezBA7R1hzKoPyGcDz/Clf9Vxu15WmXc4sujQBwLOIsjQ1qEsOARDT/opRL5G9W/0q dyaNyGnFzu/Yb/LffuYNy+X8LQ5RBxNkz0xLe+54adIKYoggmjLsNyjAi5JK6qzkLq9M OIUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751904621; x=1752509421; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Z7zVf5YnOCPvcqn6yKrlfucDJ6AlSHJertRqzvoA/ik=; b=dOQBX1dLWJneHaRI2UsLkcLw3dN4Fkq80PYBmpDujbYg+a51Vj1BenATql5MRHa3sF u3qCkCqdy+m9/nTqFxLgmhYa11gW6LoEXTHnQObu9WcemgZGVQrqTqrq9mDl336uJRMm 9ur4ANnNevZfJQ5bXKtEUc2oY+PF64cqAB9LmnKvBtIGzAxcnDlyCjkMp2uhTFov+7zC UBAS7Xq8wVTuYCcqIbrZNEofZ0UFNNX6RqEsfQP+hcSPfnqKHKJSf7MGxIeoB2tGkQ7j h/AnVkhjJ7CEYHCITLRByhZtJrA0C+yfkYEtqSPwKD+ViQ8QYsG4iow8yEVv47pQOcHv P0Kw== X-Forwarded-Encrypted: i=1; AJvYcCX7K4gikEpvn2n4pizNlLL6Xgkpjf5sympW4CACVaV9A2f3WoyfWadL7hut0xMgQGJ02r6MPq8ejEnP@nongnu.org X-Gm-Message-State: AOJu0YzgPxCZr4uARJbj0qxh/3Dz7P9Yk5P9Q3EoLd0/5DYc3dKj183A SPebhDmc5uhnaxFQmBIiT1OIMkXXP6TPWT2Xk+z38Y+Nc8Pjdc+ImKi2ZcAHd5t35c4= X-Gm-Gg: ASbGncteAGIjdnpRfmZ9ELbnrYFGqn9hiUhLkYYJNCuDiaAf9dWaWejHOojAqaXtvTn 4R6wBCQAusVC42NUvLfp/utTg8KpanFAXuquLZ9lP7dgF74xDsjS2xCPVMYbuJa1ksV8cK3kYE1 OPXSs48qQc/Y9ypdGISg6d3ZLEZTTQRYn98eIvqUzSYGfVawE3j/zeufcmxfcqGF2eGaZPtHDhZ 7ukdItbJtGMf6YW+FwtJqduPDAS8CtWVUp7l26u8MSH/IQyyCnLrAHt9NvCmkYw5sG+yOclmujS dJ3qOnYF8+Ov4yAZZC9u1Bp2xJJjsvyTkUUOqSAAAKAIUFMf1oWMU5eVWEFUoq0QpZ0c X-Google-Smtp-Source: AGHT+IF1y2QHWZ7mWm0fAvG5oshsyyQuVbEtfuZYCs96qBi0u8b31frpw4Z0yXCXMFmMt3CZos4PeQ== X-Received: by 2002:a05:6000:25c3:b0:3a4:f975:30f7 with SMTP id ffacd0b85a97d-3b497045024mr10321482f8f.56.1751904621330; Mon, 07 Jul 2025 09:10:21 -0700 (PDT) From: Peter Maydell To: qemu-arm@nongnu.org, qemu-devel@nongnu.org Cc: Eric Auger , Marc Zyngier Subject: [PATCH 1/2] hw/intc/arm_gicv3_dist: Implement GICD_TYPER2 as 0 Date: Mon, 7 Jul 2025 17:10:16 +0100 Message-ID: <20250707161018.585469-2-peter.maydell@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250707161018.585469-1-peter.maydell@linaro.org> References: <20250707161018.585469-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::430; envelope-from=peter.maydell@linaro.org; helo=mail-wr1-x430.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1751904745381116600 Content-Type: text/plain; charset="utf-8" The GIC distributor registers GICD_TYPER2 is present when the GICv4.1 is implemented, and RES0 otherwise. QEMU's TCG implementation is only GICv4.0, so this register is RES0. However, since it's reasonable for GICv4.1-aware software to read the register, expecting the zero for GICv3 and GICv4.0, implement the case to avoid it being logged as an invalid guest read. Signed-off-by: Peter Maydell Reviewed-by: Eric Auger --- hw/intc/gicv3_internal.h | 1 + hw/intc/arm_gicv3_dist.c | 9 +++++++++ 2 files changed, 10 insertions(+) diff --git a/hw/intc/gicv3_internal.h b/hw/intc/gicv3_internal.h index bc9f518fe86..fc586524f56 100644 --- a/hw/intc/gicv3_internal.h +++ b/hw/intc/gicv3_internal.h @@ -31,6 +31,7 @@ #define GICD_CTLR 0x0000 #define GICD_TYPER 0x0004 #define GICD_IIDR 0x0008 +#define GICD_TYPER2 0x000C #define GICD_STATUSR 0x0010 #define GICD_SETSPI_NSR 0x0040 #define GICD_CLRSPI_NSR 0x0048 diff --git a/hw/intc/arm_gicv3_dist.c b/hw/intc/arm_gicv3_dist.c index d8207acb22c..a7d10ed9493 100644 --- a/hw/intc/arm_gicv3_dist.c +++ b/hw/intc/arm_gicv3_dist.c @@ -431,6 +431,15 @@ static bool gicd_readl(GICv3State *s, hwaddr offset, (0xf << 19) | itlinesnumber; return true; } + case GICD_TYPER2: + /* + * This register only exists for GICv4.1, which QEMU doesn't + * currently emulate. On GICv3 and GICv4 it's defined to be RES0. + * We implement as read-zero here to avoid tracing a bad-register-= read + * if GICv4.1-aware software reads this ID register. + */ + *data =3D 0; + return true; case GICD_IIDR: /* We claim to be an ARM r0p0 with a zero ProductID. * This is the same as an r0p0 GIC-500. --=20 2.43.0