From nobody Sat May 2 09:07:20 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1751647440; cv=none; d=zohomail.com; s=zohoarc; b=MfS6QJ57rRixYBaG1Qm76N4dlY1Ktm2fyqn51R6Kir4ZVfj64gWsJl3061jORPRhZbsDiMX/ELMBNyi6Jsj975m1CwNnlwLob4gqy4JbhG55Q+3x+9J3adTcDR2dLmjYQZUO7I3uHGi1WAK000LQWkvbde+upJzHNtJP2Duv62o= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1751647440; h=Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=J4AjWlLcQzRJMk4zTnwVIKd1mI/AdtOF3eG8HhuX0Cc=; b=MvsztDnUmUp6Mj0JQolAiWNmBR4vBhWXqHUElSBJAx19UCwO4VYm4StpYqXO9hSo7i7acLFSrX9elJNWe1zvVkoTu2kz4cs2wQev98zYzq5UCFcLftAp1AlTUFwT4o1q01ZsMVXeJ0McPpd8MmxjNIv/bN8gDtycnuPAdEi7ai0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1751647440884808.702901604208; Fri, 4 Jul 2025 09:44:00 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uXjFQ-0004Pm-9y; Fri, 04 Jul 2025 12:26:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uXjF8-0002dt-Jp for qemu-devel@nongnu.org; Fri, 04 Jul 2025 12:26:31 -0400 Received: from mail-wm1-x32d.google.com ([2a00:1450:4864:20::32d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uXjF6-0006r7-L5 for qemu-devel@nongnu.org; Fri, 04 Jul 2025 12:26:30 -0400 Received: by mail-wm1-x32d.google.com with SMTP id 5b1f17b1804b1-453647147c6so9827465e9.2 for ; Fri, 04 Jul 2025 09:26:27 -0700 (PDT) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [2001:8b0:1d0::2]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b471b96534sm2816857f8f.48.2025.07.04.09.26.26 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Jul 2025 09:26:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1751646387; x=1752251187; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=J4AjWlLcQzRJMk4zTnwVIKd1mI/AdtOF3eG8HhuX0Cc=; b=Ro+e38QykMzERNdY5/9EF5+MHFJn0wX1m6q8aYUVCnWvkb4qsjsn4ZVhyBV6MQV3UP ulp62I5FZpe5yZNphPgiW0qsAIsBc52d7vGk9dW9/cNXdheyy0NLgaNMZBpMHU4uPwCD OnK6CnJB+UASs7gSStL+v0Di9m7EXVGjrA+zO85tYg3O3uQkVjVm/pUle1r2r/bKsf+F rvFUso3OjA2xI0inNziJ7ztjW+bb1/f4Vz0AVFqnGTd6EYQWyZhHz14fFALrTfp6XVya jXBobxNg1Lh6iCwzXTUP2vPrWbBHm6Q+Ej+RodO0g5aJRpc4oO5gHZQb2JmwdB4uY8JW x/yA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751646387; x=1752251187; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=J4AjWlLcQzRJMk4zTnwVIKd1mI/AdtOF3eG8HhuX0Cc=; b=ZLjJ9NQHnjXNYSTVWZLwponvOPrk8igOjQwH5a07pF+JUsQ0kb5JZYTjkSZfP2cbE8 Nzswt/VApCxdSWq2fx9Zh4i/fJbwj8j+hRjRCZfaf0IlLeEGfJWG79e8IbAKvXpwjydF UVsfpADlJv7rnYOpfSIF+uMIjlNCROBM7rUzOsGjgvfAzanIrn+tTBo77jiKy+bBXvuZ hr4M3TndO+wc+f695RdGT2/T5igOsEzYlfbyhId6SYyzV8g6/baq2+j9XhR20eLfnCan Mu1OjS7fgVpUihpteGVMDrUJDWpF54zWdx7hhkVbwIKPTVy5BoFcPXZmwd4hbte12LyH HuEg== X-Gm-Message-State: AOJu0Yz7AZ+y+2E0RcbXMfti1YCCv6DtPxq3F7XcvdALU2F3NaQcSZ/1 +pkbceRS6YTfrDjpNiBr442BWgPuZTGx+UGllVkCkdCrQ5enDR2KFyibY/y10bkzvcYjSIir2HB K5fN0 X-Gm-Gg: ASbGncvrKF2JTNv5YJpETziwzwts1yUiLceZgZJK59bsO7xHaa+4hHEyKS+uc7ctK8H /b4q4dhgcIkP9rORMXSEk3ysaSDLB+I8nMmAZ4/bMp/LdwhQ7lKkkW9AEqekokbSxCOQNZ28Ozg 1k8UeTa5qKg28DQynvh4e1LcCyxVwEZVIicNDgQ72gYuAASYuc700yhxlmTaD8MTvfBvftOStMn OTC34jwlGGOpE9MSfSRRPzWnJ93vxh3qJtg9WGz7pZ+81odGeKMgEuDxzuCbxBSbLEbi/dqiYNc f41AgAVi+PYckEuVwDIw5BqAMaurow5PLy+LfelJKDJXn4n6KN8wXSesBDj+u+DOWV3Q X-Google-Smtp-Source: AGHT+IFgAlYwRlN8wRoG4SQvEe+AU4Uo36serLNkhO0c6tzzoXazCutSgHt11e3RhJ2MV3+lKrs6CA== X-Received: by 2002:a5d:5f8e:0:b0:3a6:ec1b:5742 with SMTP id ffacd0b85a97d-3b4964f9403mr2847514f8f.22.1751646386829; Fri, 04 Jul 2025 09:26:26 -0700 (PDT) From: Peter Maydell To: qemu-devel@nongnu.org Subject: [PULL 088/119] target/arm: Split trans_WHILE to lt and gt Date: Fri, 4 Jul 2025 17:24:28 +0100 Message-ID: <20250704162501.249138-89-peter.maydell@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250704162501.249138-1-peter.maydell@linaro.org> References: <20250704162501.249138-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32d; envelope-from=peter.maydell@linaro.org; helo=mail-wm1-x32d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1751647441257116600 Content-Type: text/plain; charset="utf-8" From: Richard Henderson Use TRANS_FEAT to select the correct predicate. Pass the helper and a boolean to do_WHILE. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-id: 20250704142112.1018902-77-richard.henderson@linaro.org Signed-off-by: Peter Maydell --- target/arm/tcg/sve.decode | 4 +++- target/arm/tcg/translate-sve.c | 23 +++++++++-------------- 2 files changed, 12 insertions(+), 15 deletions(-) diff --git a/target/arm/tcg/sve.decode b/target/arm/tcg/sve.decode index dcfc40ef44b..c90d975ebf7 100644 --- a/target/arm/tcg/sve.decode +++ b/target/arm/tcg/sve.decode @@ -789,7 +789,9 @@ SINCDECP_z 00100101 .. 1010 d:1 u:1 10000 00 .... = ..... @incdec2_pred CTERM 00100101 1 sf:1 1 rm:5 001000 rn:5 ne:1 0000 =20 # SVE integer compare scalar count and limit -WHILE 00100101 esz:2 1 rm:5 000 sf:1 u:1 lt:1 rn:5 eq:1 rd:4 +&while esz rd rn rm sf u eq +WHILE_lt 00100101 esz:2 1 rm:5 000 sf:1 u:1 1 rn:5 eq:1 rd:4 &while +WHILE_gt 00100101 esz:2 1 rm:5 000 sf:1 u:1 0 rn:5 eq:1 rd:4 &while =20 # SVE2 pointer conflict compare WHILE_ptr 00100101 esz:2 1 rm:5 001 100 rn:5 rw:1 rd:4 diff --git a/target/arm/tcg/translate-sve.c b/target/arm/tcg/translate-sve.c index f74f2bb1b38..62d3e2efd69 100644 --- a/target/arm/tcg/translate-sve.c +++ b/target/arm/tcg/translate-sve.c @@ -3108,7 +3108,8 @@ static bool trans_CTERM(DisasContext *s, arg_CTERM *a) return true; } =20 -static bool trans_WHILE(DisasContext *s, arg_WHILE *a) +typedef void gen_while_fn(TCGv_i32, TCGv_ptr, TCGv_i32, TCGv_i32); +static bool do_WHILE(DisasContext *s, arg_while *a, bool lt, gen_while_fn = *fn) { TCGv_i64 op0, op1, t0, t1, tmax; TCGv_i32 t2; @@ -3118,14 +3119,8 @@ static bool trans_WHILE(DisasContext *s, arg_WHILE *= a) TCGCond cond; uint64_t maxval; /* Note that GE/HS has a->eq =3D=3D 0 and GT/HI has a->eq =3D=3D 1. */ - bool eq =3D a->eq =3D=3D a->lt; + bool eq =3D a->eq =3D=3D lt; =20 - /* The greater-than conditions are all SVE2. */ - if (a->lt - ? !dc_isar_feature(aa64_sve, s) - : !dc_isar_feature(aa64_sve2, s)) { - return false; - } if (!sve_access_check(s)) { return true; } @@ -3149,7 +3144,7 @@ static bool trans_WHILE(DisasContext *s, arg_WHILE *a) t0 =3D tcg_temp_new_i64(); t1 =3D tcg_temp_new_i64(); =20 - if (a->lt) { + if (lt) { tcg_gen_sub_i64(t0, op1, op0); if (a->u) { maxval =3D a->sf ? UINT64_MAX : UINT32_MAX; @@ -3204,15 +3199,15 @@ static bool trans_WHILE(DisasContext *s, arg_WHILE = *a) ptr =3D tcg_temp_new_ptr(); tcg_gen_addi_ptr(ptr, tcg_env, pred_full_reg_offset(s, a->rd)); =20 - if (a->lt) { - gen_helper_sve_whilel(t2, ptr, t2, tcg_constant_i32(desc)); - } else { - gen_helper_sve_whileg(t2, ptr, t2, tcg_constant_i32(desc)); - } + fn(t2, ptr, t2, tcg_constant_i32(desc)); + do_pred_flags(t2); return true; } =20 +TRANS_FEAT(WHILE_lt, aa64_sve, do_WHILE, a, true, gen_helper_sve_whilel) +TRANS_FEAT(WHILE_gt, aa64_sve2, do_WHILE, a, false, gen_helper_sve_whileg) + static bool trans_WHILE_ptr(DisasContext *s, arg_WHILE_ptr *a) { TCGv_i64 op0, op1, diff, t1, tmax; --=20 2.43.0