From nobody Tue Dec 23 10:51:26 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1751646812; cv=none; d=zohomail.com; s=zohoarc; b=VVWB7tozJ/s6pg49jsrr9zhaqfEXISvMzASNW4KN6JSxsxJswT2ziGN/HRblYNcIUHSLA2TSjbLygqeGY9AzEpxfDdEe7JFMZdatbeRyAlWn6+3iiXMQSWXJNcCpumLCiXnWibO2X+gJ9HPOIEQcLWa+rp/NBVWQYf3O2vpE+KM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1751646812; h=Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=OSlrzFqQKqu03zPkvyInBmMYbd2uN9rgCw0yQ9re9cM=; b=dUgqILUBAKkGXKd0X3tMms6zF5gE6lw0Qa3KE2eZXbi6W/F7ZJ4rbbGXwAaKVgrx96X7833ibdknBDguOkmleMKsaaazg7ickYEqO4tzka5/t2oJqG5oW4P5BwpaHewTkSg23nC3n5LzTAkamJDkOdyBzXXIAzg4D2WCiJp/5uw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1751646812415143.18603573100688; Fri, 4 Jul 2025 09:33:32 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uXjEY-0000jD-Ld; Fri, 04 Jul 2025 12:25:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uXjES-0000bh-59 for qemu-devel@nongnu.org; Fri, 04 Jul 2025 12:25:48 -0400 Received: from mail-wr1-x430.google.com ([2a00:1450:4864:20::430]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uXjEQ-0006HO-Hr for qemu-devel@nongnu.org; Fri, 04 Jul 2025 12:25:47 -0400 Received: by mail-wr1-x430.google.com with SMTP id ffacd0b85a97d-3a582e09144so633156f8f.1 for ; Fri, 04 Jul 2025 09:25:46 -0700 (PDT) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [2001:8b0:1d0::2]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b471b96534sm2816857f8f.48.2025.07.04.09.25.44 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Jul 2025 09:25:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1751646345; x=1752251145; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=OSlrzFqQKqu03zPkvyInBmMYbd2uN9rgCw0yQ9re9cM=; b=SZYAkBO87OOc3WhLRoxq5aD2aI8UpnszINGuXGm6AhZwlqRbppTBWTmN48zQxmoQu5 dNyTavyLoD3OXA7hbSus20kWbO1s/5jZqtWAYCTytjfsvu2ZlyawcCvjkGQZz5zCjed+ 2tD9B548u9eUnmdhHELlVpKYHyaC5GyZjLUwOYi6awzWYGQlrw0gJp0WYDcNUJRtuqlm n501Afq8yS3y3A/0G1h3mrzZ/o44avi7FJA/RplhjrL4kY95Oc0e5cgxYUiKJWPI1bZY Y0ve9hgrkZ2psNUXK4qYrMd3SR5Twe8WOTLB4QxzoAGFuGoZQeDSb4r9izgMe2GIYAAK HUag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751646345; x=1752251145; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OSlrzFqQKqu03zPkvyInBmMYbd2uN9rgCw0yQ9re9cM=; b=lmtn/ghEev98KRxJE3BCwtOdn7XV0w1jkD4eRnyyXVL3EwHkWNqOwRIMfhEdsxT2t0 5yMaAZXPVOCslYQVLdOb2ZcRmulMboDmhUGw0CHZ+5+L7wGjYoG6fjWtm4LR9RC38JHH noHE6O8q9PENdzoyZ0HjcGv+4Cd3xfCik+St5EToyyOWVIBRwnXdEZvEDIuYDIAX1DfY We7ZwDfPS0W7pa++RZf2hSWgitYiLlgaANMdEqKPUchT9MLiZp6CJzZGgoYlmSeZ0j7e U7U7LrM9aCyWXa8GcJgtrh8/apPOZtEn2Le4a/fpejJRyDYG5PsN6LHssOfNQ99bdZN8 Rhkw== X-Gm-Message-State: AOJu0Yyegye8WykkXnFywpH3A9QD7zNfEd0kwWexjc5ZemZPU7pOkLbC m06zV+OUuVsuduSQ2RnywG9zRYdgXXFpLfTGu5BtGDskqhE9oeZO+LxlQ8ojAcEVNqdEtRSQdva IUOPg X-Gm-Gg: ASbGnctbrabQNdDhNFQzZyv0CL8r8tb3aYurVO40+4tNxzZCJXTwUkamtd3KlqqGSPn YxKgvdOiUAvzKcUHeKn5+697iUkRylMNpy/4UzSle+5gmrT/ck25v+gFT1khBm6Zu7Yykz6W9Cz tU4uzEGTcaiqK6B773Ee/lxlbxz1OihNNmzYY9YfteDFdGlP46RtyD7lC0R5U1YHzrTd8gI3lJf N0RkZrb8r6SZnfMaLsxZRI9iOG41cjQArbjlXGy+KrKFUrg2OCPM8bVTMjjwQDdxRZtXbvBoh2M e491YU/EaXREFR28ADXIKvM7krZcKlMJjmY2Tve98RJJAiHYJcZI7rOiuglOvurC+jNP X-Google-Smtp-Source: AGHT+IHslByqunm9gn64p2WEIYFOVEoOrpwK+vsXpJlgCVZnxMGbBHe0zL4CFVGptoxL7B31oj2Umw== X-Received: by 2002:a05:6000:382:b0:3a4:fefb:c8d3 with SMTP id ffacd0b85a97d-3b49703db12mr2410980f8f.40.1751646345127; Fri, 04 Jul 2025 09:25:45 -0700 (PDT) From: Peter Maydell To: qemu-devel@nongnu.org Subject: [PULL 046/119] target/arm: Pass ZA to helper_sve2_fmlal_zz[zx]w_s Date: Fri, 4 Jul 2025 17:23:46 +0100 Message-ID: <20250704162501.249138-47-peter.maydell@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250704162501.249138-1-peter.maydell@linaro.org> References: <20250704162501.249138-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::430; envelope-from=peter.maydell@linaro.org; helo=mail-wr1-x430.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1751646813811116600 Content-Type: text/plain; charset="utf-8" From: Richard Henderson Indicate whether to use FPST_FPCR or FPST_ZA via bit 2 of simd_data(desc). For SVE, this bit remains zero. For do_FMLAL_zzzw, this requires no change. For do_FMLAL_zzxw, move the index up one bit. Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-id: 20250704142112.1018902-35-richard.henderson@linaro.org Signed-off-by: Peter Maydell --- target/arm/tcg/translate-sve.c | 2 +- target/arm/tcg/vec_helper.c | 8 +++++--- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/target/arm/tcg/translate-sve.c b/target/arm/tcg/translate-sve.c index 7e304245c64..b85bd885f9d 100644 --- a/target/arm/tcg/translate-sve.c +++ b/target/arm/tcg/translate-sve.c @@ -7214,7 +7214,7 @@ static bool do_FMLAL_zzxw(DisasContext *s, arg_rrxr_e= sz *a, bool sub, bool sel) { return gen_gvec_ptr_zzzz(s, gen_helper_sve2_fmlal_zzxw_s, a->rd, a->rn, a->rm, a->ra, - (a->index << 2) | (sel << 1) | sub, tcg_env); + (a->index << 3) | (sel << 1) | sub, tcg_env); } =20 TRANS_FEAT(FMLALB_zzxw, aa64_sve2, do_FMLAL_zzxw, a, false, false) diff --git a/target/arm/tcg/vec_helper.c b/target/arm/tcg/vec_helper.c index 8b49577e2fd..e8467823f21 100644 --- a/target/arm/tcg/vec_helper.c +++ b/target/arm/tcg/vec_helper.c @@ -2191,7 +2191,8 @@ void HELPER(sve2_fmlal_zzzw_s)(void *vd, void *vn, vo= id *vm, void *va, intptr_t i, oprsz =3D simd_oprsz(desc); bool is_s =3D extract32(desc, SIMD_DATA_SHIFT, 1); intptr_t sel =3D extract32(desc, SIMD_DATA_SHIFT + 1, 1) * sizeof(floa= t16); - float_status *status =3D &env->vfp.fp_status[FPST_A64]; + bool za =3D extract32(desc, SIMD_DATA_SHIFT + 2, 1); + float_status *status =3D &env->vfp.fp_status[za ? FPST_ZA : FPST_A64]; bool fz16 =3D env->vfp.fpcr & FPCR_FZ16; int negx =3D 0, negf =3D 0; =20 @@ -2274,8 +2275,9 @@ void HELPER(sve2_fmlal_zzxw_s)(void *vd, void *vn, vo= id *vm, void *va, intptr_t i, j, oprsz =3D simd_oprsz(desc); bool is_s =3D extract32(desc, SIMD_DATA_SHIFT, 1); intptr_t sel =3D extract32(desc, SIMD_DATA_SHIFT + 1, 1) * sizeof(floa= t16); - intptr_t idx =3D extract32(desc, SIMD_DATA_SHIFT + 2, 3) * sizeof(floa= t16); - float_status *status =3D &env->vfp.fp_status[FPST_A64]; + bool za =3D extract32(desc, SIMD_DATA_SHIFT + 2, 1); + intptr_t idx =3D extract32(desc, SIMD_DATA_SHIFT + 3, 3) * sizeof(floa= t16); + float_status *status =3D &env->vfp.fp_status[za ? FPST_ZA : FPST_A64]; bool fz16 =3D env->vfp.fpcr & FPCR_FZ16; int negx =3D 0, negf =3D 0; =20 --=20 2.43.0