From nobody Thu Apr 30 08:42:12 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1751647412; cv=none; d=zohomail.com; s=zohoarc; b=i/h1NvxahCOP3W9EEKMNSFYFw5PctB4D0azRQw/gzDwyD9ti3DCtxsm6YOSsLAAakKpBwUA6X5rgpAkCV8VlQeTX5cRnRvb43IK48x7b2t3Jnw7snZV6WpxKWVq2AwQ6PneCBj++GlcLGExx3+3ebHwrYAYBGapvmeXUMxavgMg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1751647412; h=Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=Sej+V2Rr9AtmU3YQ9vXb4to4NlQ7GYAchQCQX2HueIA=; b=SGySqoF51WiCf/pA+5Koocbqd3Q/fgYFNO4hvbf48A5yeuKp+byehVDwdI3XgDkTwEn71bBMHGFDxdfqyLuyr7vkyp7HK4xBRgKyyUNEDKN7MYOIijGYAPg9Fdv4QbuJrLVxDNa0iYGshvEqPlYldAymXZUQRfk3tUnQ+Sk5Z78= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1751647412405396.6200402971217; Fri, 4 Jul 2025 09:43:32 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uXjEA-0008RO-WC; Fri, 04 Jul 2025 12:25:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uXjE9-0008PV-4J for qemu-devel@nongnu.org; Fri, 04 Jul 2025 12:25:29 -0400 Received: from mail-wr1-x42d.google.com ([2a00:1450:4864:20::42d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uXjE6-00069e-Kk for qemu-devel@nongnu.org; Fri, 04 Jul 2025 12:25:28 -0400 Received: by mail-wr1-x42d.google.com with SMTP id ffacd0b85a97d-3a6cdc27438so930539f8f.2 for ; Fri, 04 Jul 2025 09:25:26 -0700 (PDT) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [2001:8b0:1d0::2]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b471b96534sm2816857f8f.48.2025.07.04.09.25.24 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Jul 2025 09:25:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1751646325; x=1752251125; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=Sej+V2Rr9AtmU3YQ9vXb4to4NlQ7GYAchQCQX2HueIA=; b=Vg0ucKm5+V64l4WtKvH6QTGGUoqANtG22rWiT90b+DnoLyxtgd/GU4BaxD3iRWvPs4 tFzcycOJ1Zg56X5lzB9r3z4Wc0PGohZCj09O+Fw0sp2YThSd8nj1IDLS2PPDYidu3mO7 a4D+k1/sZA/TxlEMR6ZgE4ZWtHiudDd6cugZRX9DdODFkygODZZsJBhvJ+ph/AQQJ7VL ga0HTMkpDTBZoFjh93yoK0OI8Sv1DDy/VsHdsthLl3EKzgS3RNrCBtHWgEDKxbH/zq+n NVfyIyeSBMjVgDJip+17YjUfGZADzy9ILRbuZrz5wTZebiH7lDUdYs6LpFUYqzIexTMW qEJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751646325; x=1752251125; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Sej+V2Rr9AtmU3YQ9vXb4to4NlQ7GYAchQCQX2HueIA=; b=vB9wOet4mV2OQdaOPSB+PkBVfh3J0KVNBn6u5aCpDbzVRjI/l7cQydyXDkF+bEGoJV KafXBPfpSSIPr/OihMOoTms62unU8v1myZ3MJmv7rpvf+rwDYizAFAFmcibPWvGGVzrQ gDsI0JQIKRLTK+FIuruKNLXa1P9z9N0xAVlYXa3fbRu4PmroQUvXKp7CCbowsUQtrdH4 qOQ1QF6caPazP6kPaPL47+PsdCu8LhZJFIBAUPH4yZ9WtSXY0DnmJUJCwI75pDa7Stjh mptROHYAhKUDiT+P6ESI99Mo7F72aRkHkzdGaPLlm7Pu7fYsVdoWHJbU3hCEr/ayWVXV uT3A== X-Gm-Message-State: AOJu0Yz8C3ATxA7kd5f6ke7VX8VW5v/OETd0wvLUc/mFwy8YPoejxfdv 1QxqDgrMIHFFwWhKQlxYY4gQNZ3ABw22g2QvHIkN2YhzOTRBEu03sbTpvOMU+2dAEexB19XeD2x HlJ8u X-Gm-Gg: ASbGncvKfcTdWPzhblzOW7c5c+b2TYPtds7n4LxDJX9ejgaKrjfZ2bryVPmZnoHQnP2 afvFdJBJLrEpDhlRRJt40oHIZEhg3NsWV1tb7/+pgr0uXoBPppelc+9eWvFm3pvFTsy+bDzxOk5 OXIRhunha4ISVHOZqR8KPZpCeNG6ZjOK2LVPYbqT5GhkTZc/GGcqroCwPNHkUrZ18/NEPBrz5e9 kmyV6hdcDvbtJaSoP5j2TgX36JvcFDmwYdWGzT/W6K/JS/L1r0s0rYfbEqwmat2tEhuZO00Hzy2 F8rfovWke15lbX1tkDmuS/nJPRS9GqZwq+7bwKfR3TRG9d+X+t96STZ2x9HyrWQH3Sh9 X-Google-Smtp-Source: AGHT+IGUmhW6eNTRwsbb5HsIv9LS8J62fSTewm9pdP4g8U92KOSDwbq+mrw4C6KB8jKXZNuFeuKydg== X-Received: by 2002:a05:6000:2384:b0:3a4:ee3f:e9a6 with SMTP id ffacd0b85a97d-3b49703d9acmr2327350f8f.54.1751646325173; Fri, 04 Jul 2025 09:25:25 -0700 (PDT) From: Peter Maydell To: qemu-devel@nongnu.org Subject: [PULL 024/119] target/arm: Use FPST_ZA for sme_fmopa_[hsd] Date: Fri, 4 Jul 2025 17:23:24 +0100 Message-ID: <20250704162501.249138-25-peter.maydell@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250704162501.249138-1-peter.maydell@linaro.org> References: <20250704162501.249138-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::42d; envelope-from=peter.maydell@linaro.org; helo=mail-wr1-x42d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1751647412833116600 Content-Type: text/plain; charset="utf-8" From: Richard Henderson Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-id: 20250704142112.1018902-13-richard.henderson@linaro.org Signed-off-by: Peter Maydell --- target/arm/tcg/sme_helper.c | 37 ++++++++-------------------------- target/arm/tcg/translate-sme.c | 4 ++-- 2 files changed, 10 insertions(+), 31 deletions(-) diff --git a/target/arm/tcg/sme_helper.c b/target/arm/tcg/sme_helper.c index 8f33387e4bd..9942d717aaa 100644 --- a/target/arm/tcg/sme_helper.c +++ b/target/arm/tcg/sme_helper.c @@ -904,20 +904,11 @@ void HELPER(sme_addva_d)(void *vzda, void *vzn, void = *vpn, } =20 void HELPER(sme_fmopa_s)(void *vza, void *vzn, void *vzm, void *vpn, - void *vpm, float_status *fpst_in, uint32_t desc) + void *vpm, float_status *fpst, uint32_t desc) { intptr_t row, col, oprsz =3D simd_maxsz(desc); uint32_t neg =3D simd_data(desc) << 31; uint16_t *pn =3D vpn, *pm =3D vpm; - float_status fpst; - - /* - * Make a copy of float_status because this operation does not - * update the cumulative fp exception status. It also produces - * default nans. - */ - fpst =3D *fpst_in; - set_default_nan_mode(true, &fpst); =20 for (row =3D 0; row < oprsz; ) { uint16_t pa =3D pn[H2(row >> 4)]; @@ -932,7 +923,7 @@ void HELPER(sme_fmopa_s)(void *vza, void *vzn, void *vz= m, void *vpn, if (pb & 1) { uint32_t *a =3D vza_row + H1_4(col); uint32_t *m =3D vzm + H1_4(col); - *a =3D float32_muladd(n, *m, *a, 0, &fpst); + *a =3D float32_muladd(n, *m, *a, 0, fpst); } col +=3D 4; pb >>=3D 4; @@ -946,15 +937,12 @@ void HELPER(sme_fmopa_s)(void *vza, void *vzn, void *= vzm, void *vpn, } =20 void HELPER(sme_fmopa_d)(void *vza, void *vzn, void *vzm, void *vpn, - void *vpm, float_status *fpst_in, uint32_t desc) + void *vpm, float_status *fpst, uint32_t desc) { intptr_t row, col, oprsz =3D simd_oprsz(desc) / 8; uint64_t neg =3D (uint64_t)simd_data(desc) << 63; uint64_t *za =3D vza, *zn =3D vzn, *zm =3D vzm; uint8_t *pn =3D vpn, *pm =3D vpm; - float_status fpst =3D *fpst_in; - - set_default_nan_mode(true, &fpst); =20 for (row =3D 0; row < oprsz; ++row) { if (pn[H1(row)] & 1) { @@ -964,7 +952,7 @@ void HELPER(sme_fmopa_d)(void *vza, void *vzn, void *vz= m, void *vpn, for (col =3D 0; col < oprsz; ++col) { if (pm[H1(col)] & 1) { uint64_t *a =3D &za_row[col]; - *a =3D float64_muladd(n, zm[col], *a, 0, &fpst); + *a =3D float64_muladd(n, zm[col], *a, 0, fpst); } } } @@ -1065,19 +1053,8 @@ void HELPER(sme_fmopa_h)(void *vza, void *vzn, void = *vzm, void *vpn, intptr_t row, col, oprsz =3D simd_maxsz(desc); uint32_t neg =3D simd_data(desc) * 0x80008000u; uint16_t *pn =3D vpn, *pm =3D vpm; - float_status fpst_odd, fpst_std, fpst_f16; + float_status fpst_odd =3D env->vfp.fp_status[FPST_ZA]; =20 - /* - * Make copies of the fp status fields we use, because this operation - * does not update the cumulative fp exception status. It also - * produces default NaNs. We also need a second copy of fp_status with - * round-to-odd -- see above. - */ - fpst_f16 =3D env->vfp.fp_status[FPST_A64_F16]; - fpst_std =3D env->vfp.fp_status[FPST_A64]; - set_default_nan_mode(true, &fpst_std); - set_default_nan_mode(true, &fpst_f16); - fpst_odd =3D fpst_std; set_float_rounding_mode(float_round_to_odd, &fpst_odd); =20 for (row =3D 0; row < oprsz; ) { @@ -1097,7 +1074,9 @@ void HELPER(sme_fmopa_h)(void *vza, void *vzn, void *= vzm, void *vpn, =20 m =3D f16mop_adj_pair(m, pcol, 0); *a =3D f16_dotadd(*a, n, m, - &fpst_f16, &fpst_std, &fpst_odd); + &env->vfp.fp_status[FPST_ZA_F16], + &env->vfp.fp_status[FPST_ZA], + &fpst_odd); } col +=3D 4; pcol >>=3D 4; diff --git a/target/arm/tcg/translate-sme.c b/target/arm/tcg/translate-sme.c index fcbb3500161..51175c923ef 100644 --- a/target/arm/tcg/translate-sme.c +++ b/target/arm/tcg/translate-sme.c @@ -358,9 +358,9 @@ static bool do_outprod_env(DisasContext *s, arg_op *a, = MemOp esz, TRANS_FEAT(FMOPA_h, aa64_sme, do_outprod_env, a, MO_32, gen_helper_sme_fmopa_h) TRANS_FEAT(FMOPA_s, aa64_sme, do_outprod_fpst, a, - MO_32, FPST_A64, gen_helper_sme_fmopa_s) + MO_32, FPST_ZA, gen_helper_sme_fmopa_s) TRANS_FEAT(FMOPA_d, aa64_sme_f64f64, do_outprod_fpst, a, - MO_64, FPST_A64, gen_helper_sme_fmopa_d) + MO_64, FPST_ZA, gen_helper_sme_fmopa_d) =20 TRANS_FEAT(BFMOPA, aa64_sme, do_outprod_env, a, MO_32, gen_helper_sme_bfmo= pa) =20 --=20 2.43.0