From nobody Fri May 1 04:29:13 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1751647403; cv=none; d=zohomail.com; s=zohoarc; b=FwSkbNCut65Pkub8CB63gJXOhwh3ODApQ6UH1bWCsVhddogqtC+U5Yirz+1NnDJpMTC7rdTbr9LLzVr8f09M0GNvq/z3n8FtUZiAykJAljWg6yVIcAMS2ycqypkAkYGQ8pS65dxmBgaKWR2ARMQvgUxPXqxFmIe6aa59L4zD3HE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1751647403; h=Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=oGULRAKLg+XiqlPDP7+fCzEGTdLLvfGjVV5/QGjmu+4=; b=izRBn01mhoSGjLT2GpHoM3R7tUr99byFngfrntCSgj1xGh/72QCl1b0mfvP7rGr+LMRrtZFMzRGjcj/FRfPkM/Wxw3JSdO1iIKdt8pJKt0Gpd6hQuVAwfBzp8vg+YecndVgnULw3Dgw9eivtPdoEQJ6NDYWmFVq45NmgcQ/rqSw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1751647403141857.8547955458091; Fri, 4 Jul 2025 09:43:23 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uXjH3-0001uR-Vy; Fri, 04 Jul 2025 12:28:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uXjFS-0004k7-Te for qemu-devel@nongnu.org; Fri, 04 Jul 2025 12:26:51 -0400 Received: from mail-wr1-x42f.google.com ([2a00:1450:4864:20::42f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uXjFQ-0006wu-J7 for qemu-devel@nongnu.org; Fri, 04 Jul 2025 12:26:50 -0400 Received: by mail-wr1-x42f.google.com with SMTP id ffacd0b85a97d-3a588da60dfso714306f8f.1 for ; Fri, 04 Jul 2025 09:26:48 -0700 (PDT) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [2001:8b0:1d0::2]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b471b96534sm2816857f8f.48.2025.07.04.09.26.45 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Jul 2025 09:26:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1751646407; x=1752251207; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=oGULRAKLg+XiqlPDP7+fCzEGTdLLvfGjVV5/QGjmu+4=; b=Z7vPRoPlrWEihOpX7kDg6O9aA+/UimQ58+0yXJaH4XYrY5TVxkgg9hpY236mQ5QAJ8 W6z8D+NKo60PKDchLq8jcycCMA8hgGsuCIB4x/H5NnxFQBjRw49GVDG1MUY5EyJ2H6jg jMKmqkT1Yh9dpcT2CK7mNxgkaScfdcoSvZKDV702rx8uwGGSdo3M4s6FSrgA76RklVol 1AaTk3IJT8HzETdWW/3Z61d9qViAIeMZVpl7AS0QNSuR9RLVvLqExgZQTWqQtpjc/Zm+ xRl13tQ6de/MoWCW1adSnJqS1wdVGX0oxvptMgCtyybPYjGob5oNnky9PBGV1/V33q2f y71w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751646407; x=1752251207; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=oGULRAKLg+XiqlPDP7+fCzEGTdLLvfGjVV5/QGjmu+4=; b=PPAwiSEZgiHPxul3MHyoIKM86x184Yddvgx1rdqqhHQ1aIjkTMsSNh1kq3AmEslVlx ndggeSI1HU+KST0Mkkg3ZyiXtJLW2j4sXQqdWCePKv2liofwqaWisJUVJHxXfjRrERsa zIEtDVQ2DJxvjHv1gwuIFZnYsqvmIL++6lMzw7Z49CuOomt0Wmxrd8ySGfIUB19+SRkv Ugox6rv14FAzImqLDcOYSoe0771TwNvI9kOACHVy4TfxYhKfiUu7lr28FzbinMjX2TNN NSq+WxMR7df7kXd7h15s24AIuVENVb6r5ckaSYszt+PuC9QiR3gKFcGLwOXqONxB5cSt uSOw== X-Gm-Message-State: AOJu0YxJt00kw11Dyy7PUup8yRqJPjMD+ZoGBhPaenZ1P0ZUOrXxd1IB Y2NQNzz4G4byMiHlcTtK8Y1/TMyjcU7FDtEugxKltYpyPVqF5SMRMDGS2HR1kHa0jFXRcrQX4YU odKHm X-Gm-Gg: ASbGncupQbh2kc7vj2WUmpZhVnkjvsDpeSwYmjf5ngFmm7se9t0z6Bq/hhmHgzRsOTm mz6G0L4CNDfUlCSqY+YCECBTE51mztF3p0cOdOho5MfF7zMd8i2G6u/fPLsHvontzw1gzne8YdI 2np53G3UmIRTKpau69ub8STq25ASK9OpmnCEmtXBmrQxDWBBPxkUnt7OhqZcJEqIHFcco7diW/N 2Bu0akqxi8+RYzZr9BH8mvBOAdmlXVMoMR/gorCEm4Ujn6PYgcKPhQatBUWerebDyzGwZyvfOXf 8WLqRaf0jFb0S58y2WY8klK4hame9sIAcWZa0FrZVVh56ZwyYzaeDW+O2BXpwXzT6kMo X-Google-Smtp-Source: AGHT+IG0fUn/wDHOO4/jUXjXmoaec1iRkx4o5ocTPifINAGhJu5DK3JOJitfp39At4lZ1orreyV8PQ== X-Received: by 2002:a05:6000:4719:b0:3a4:f00b:69b6 with SMTP id ffacd0b85a97d-3b4964ed694mr2666861f8f.54.1751646406656; Fri, 04 Jul 2025 09:26:46 -0700 (PDT) From: Peter Maydell To: qemu-devel@nongnu.org Subject: [PULL 110/119] target/arm: Implement LD1Q, ST1Q for SVE2p1 Date: Fri, 4 Jul 2025 17:24:50 +0100 Message-ID: <20250704162501.249138-111-peter.maydell@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250704162501.249138-1-peter.maydell@linaro.org> References: <20250704162501.249138-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::42f; envelope-from=peter.maydell@linaro.org; helo=mail-wr1-x42f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1751647404937116600 Content-Type: text/plain; charset="utf-8" From: Richard Henderson Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson Message-id: 20250704142112.1018902-99-richard.henderson@linaro.org Signed-off-by: Peter Maydell --- target/arm/tcg/helper-sve.h | 16 ++++++++++++++++ target/arm/tcg/sve.decode | 8 ++++++++ target/arm/tcg/sve_helper.c | 6 ++++++ target/arm/tcg/translate-sve.c | 34 ++++++++++++++++++++++++++++++++-- 4 files changed, 62 insertions(+), 2 deletions(-) diff --git a/target/arm/tcg/helper-sve.h b/target/arm/tcg/helper-sve.h index ade76ff664d..c36090d13d1 100644 --- a/target/arm/tcg/helper-sve.h +++ b/target/arm/tcg/helper-sve.h @@ -2155,6 +2155,10 @@ DEF_HELPER_FLAGS_6(sve_ldsds_le_zd, TCG_CALL_NO_WG, void, env, ptr, ptr, ptr, tl, i32) DEF_HELPER_FLAGS_6(sve_ldsds_be_zd, TCG_CALL_NO_WG, void, env, ptr, ptr, ptr, tl, i32) +DEF_HELPER_FLAGS_6(sve_ldqq_le_zd, TCG_CALL_NO_WG, + void, env, ptr, ptr, ptr, tl, i32) +DEF_HELPER_FLAGS_6(sve_ldqq_be_zd, TCG_CALL_NO_WG, + void, env, ptr, ptr, ptr, tl, i32) =20 DEF_HELPER_FLAGS_6(sve_ldbsu_zsu_mte, TCG_CALL_NO_WG, void, env, ptr, ptr, ptr, tl, i32) @@ -2264,6 +2268,10 @@ DEF_HELPER_FLAGS_6(sve_ldsds_le_zd_mte, TCG_CALL_NO_= WG, void, env, ptr, ptr, ptr, tl, i32) DEF_HELPER_FLAGS_6(sve_ldsds_be_zd_mte, TCG_CALL_NO_WG, void, env, ptr, ptr, ptr, tl, i32) +DEF_HELPER_FLAGS_6(sve_ldqq_le_zd_mte, TCG_CALL_NO_WG, + void, env, ptr, ptr, ptr, tl, i32) +DEF_HELPER_FLAGS_6(sve_ldqq_be_zd_mte, TCG_CALL_NO_WG, + void, env, ptr, ptr, ptr, tl, i32) =20 DEF_HELPER_FLAGS_6(sve_ldffbsu_zsu, TCG_CALL_NO_WG, void, env, ptr, ptr, ptr, tl, i32) @@ -2549,6 +2557,10 @@ DEF_HELPER_FLAGS_6(sve_stdd_le_zd, TCG_CALL_NO_WG, void, env, ptr, ptr, ptr, tl, i32) DEF_HELPER_FLAGS_6(sve_stdd_be_zd, TCG_CALL_NO_WG, void, env, ptr, ptr, ptr, tl, i32) +DEF_HELPER_FLAGS_6(sve_stqq_le_zd, TCG_CALL_NO_WG, + void, env, ptr, ptr, ptr, tl, i32) +DEF_HELPER_FLAGS_6(sve_stqq_be_zd, TCG_CALL_NO_WG, + void, env, ptr, ptr, ptr, tl, i32) =20 DEF_HELPER_FLAGS_6(sve_stbs_zsu_mte, TCG_CALL_NO_WG, void, env, ptr, ptr, ptr, tl, i32) @@ -2616,6 +2628,10 @@ DEF_HELPER_FLAGS_6(sve_stdd_le_zd_mte, TCG_CALL_NO_W= G, void, env, ptr, ptr, ptr, tl, i32) DEF_HELPER_FLAGS_6(sve_stdd_be_zd_mte, TCG_CALL_NO_WG, void, env, ptr, ptr, ptr, tl, i32) +DEF_HELPER_FLAGS_6(sve_stqq_le_zd_mte, TCG_CALL_NO_WG, + void, env, ptr, ptr, ptr, tl, i32) +DEF_HELPER_FLAGS_6(sve_stqq_be_zd_mte, TCG_CALL_NO_WG, + void, env, ptr, ptr, ptr, tl, i32) =20 DEF_HELPER_FLAGS_4(sve2_sqdmull_zzz_h, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, i32) diff --git a/target/arm/tcg/sve.decode b/target/arm/tcg/sve.decode index 3eda029146d..2efd5f57e45 100644 --- a/target/arm/tcg/sve.decode +++ b/target/arm/tcg/sve.decode @@ -1340,6 +1340,10 @@ LD1_zprz 1100010 10 1. ..... 1.. ... ..... ..= ... \ LD1_zprz 1100010 11 1. ..... 11. ... ..... ..... \ @rprr_g_load_sc esz=3D3 msz=3D3 u=3D1 =20 +# LD1Q +LD1_zprz 1100 0100 000 rm:5 101 pg:3 rn:5 rd:5 \ + &rprr_gather_load u=3D0 ff=3D0 xs=3D2 esz=3D4 msz=3D4 scal= e=3D0 + # SVE 64-bit gather load (vector plus immediate) LD1_zpiz 1100010 .. 01 ..... 1.. ... ..... ..... \ @rpri_g_load esz=3D3 @@ -1443,6 +1447,10 @@ ST1_zprz 1110010 .. 01 ..... 101 ... ..... ..= ... \ ST1_zprz 1110010 .. 00 ..... 101 ... ..... ..... \ @rprr_scatter_store xs=3D2 esz=3D3 scale=3D0 =20 +# ST1Q +ST1_zprz 1110 0100 001 rm:5 001 pg:3 rn:5 rd:5 \ + &rprr_scatter_store xs=3D2 msz=3D4 esz=3D4 scale=3D0 + # SVE 64-bit scatter store (vector plus immediate) ST1_zpiz 1110010 .. 10 ..... 101 ... ..... ..... \ @rpri_scatter_store esz=3D3 diff --git a/target/arm/tcg/sve_helper.c b/target/arm/tcg/sve_helper.c index 360114ece2c..43b872c7fd6 100644 --- a/target/arm/tcg/sve_helper.c +++ b/target/arm/tcg/sve_helper.c @@ -7211,6 +7211,9 @@ DO_LD1_ZPZ_D(dd_be, zsu, MO_64) DO_LD1_ZPZ_D(dd_be, zss, MO_64) DO_LD1_ZPZ_D(dd_be, zd, MO_64) =20 +DO_LD1_ZPZ_D(qq_le, zd, MO_128) +DO_LD1_ZPZ_D(qq_be, zd, MO_128) + #undef DO_LD1_ZPZ_S #undef DO_LD1_ZPZ_D =20 @@ -7597,6 +7600,9 @@ DO_ST1_ZPZ_D(sd_be, zd, MO_32) DO_ST1_ZPZ_D(dd_le, zd, MO_64) DO_ST1_ZPZ_D(dd_be, zd, MO_64) =20 +DO_ST1_ZPZ_D(qq_le, zd, MO_128) +DO_ST1_ZPZ_D(qq_be, zd, MO_128) + #undef DO_ST1_ZPZ_S #undef DO_ST1_ZPZ_D =20 diff --git a/target/arm/tcg/translate-sve.c b/target/arm/tcg/translate-sve.c index 7dff0285690..7b575734fde 100644 --- a/target/arm/tcg/translate-sve.c +++ b/target/arm/tcg/translate-sve.c @@ -6121,13 +6121,23 @@ gather_load_fn64[2][2][2][3][2][4] =3D { gen_helper_sve_ldffdd_be_zd_mte, } } } } }, }; =20 +static gen_helper_gvec_mem_scatter * const +gather_load_fn128[2][2] =3D { + { gen_helper_sve_ldqq_le_zd, + gen_helper_sve_ldqq_be_zd }, + { gen_helper_sve_ldqq_le_zd_mte, + gen_helper_sve_ldqq_be_zd_mte } +}; + static bool trans_LD1_zprz(DisasContext *s, arg_LD1_zprz *a) { gen_helper_gvec_mem_scatter *fn =3D NULL; bool be =3D s->be_data =3D=3D MO_BE; bool mte =3D s->mte_active[0]; =20 - if (!dc_isar_feature(aa64_sve, s)) { + if (a->esz < MO_128 + ? !dc_isar_feature(aa64_sve, s) + : !dc_isar_feature(aa64_sve2p1, s)) { return false; } s->is_nonstreaming =3D true; @@ -6142,6 +6152,12 @@ static bool trans_LD1_zprz(DisasContext *s, arg_LD1_= zprz *a) case MO_64: fn =3D gather_load_fn64[mte][be][a->ff][a->xs][a->u][a->msz]; break; + case MO_128: + assert(!a->ff && a->u && a->xs =3D=3D 2 && a->msz =3D=3D MO_128); + fn =3D gather_load_fn128[mte][be]; + break; + default: + g_assert_not_reached(); } assert(fn !=3D NULL); =20 @@ -6309,6 +6325,14 @@ static gen_helper_gvec_mem_scatter * const scatter_s= tore_fn64[2][2][3][4] =3D { gen_helper_sve_stdd_be_zd_mte, } } }, }; =20 +static gen_helper_gvec_mem_scatter * const +scatter_store_fn128[2][2] =3D { + { gen_helper_sve_stqq_le_zd, + gen_helper_sve_stqq_be_zd }, + { gen_helper_sve_stqq_le_zd_mte, + gen_helper_sve_stqq_be_zd_mte } +}; + static bool trans_ST1_zprz(DisasContext *s, arg_ST1_zprz *a) { gen_helper_gvec_mem_scatter *fn; @@ -6318,7 +6342,9 @@ static bool trans_ST1_zprz(DisasContext *s, arg_ST1_z= prz *a) if (a->esz < a->msz || (a->msz =3D=3D 0 && a->scale)) { return false; } - if (!dc_isar_feature(aa64_sve, s)) { + if (a->esz < MO_128 + ? !dc_isar_feature(aa64_sve, s) + : !dc_isar_feature(aa64_sve2p1, s)) { return false; } s->is_nonstreaming =3D true; @@ -6332,6 +6358,10 @@ static bool trans_ST1_zprz(DisasContext *s, arg_ST1_= zprz *a) case MO_64: fn =3D scatter_store_fn64[mte][be][a->xs][a->msz]; break; + case MO_128: + assert(a->xs =3D=3D 2 && a->msz =3D=3D MO_128); + fn =3D scatter_store_fn128[mte][be]; + break; default: g_assert_not_reached(); } --=20 2.43.0