From nobody Fri Dec 19 02:49:56 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1751640057; cv=none; d=zohomail.com; s=zohoarc; b=Y+Ryy9PA2w9ZJKe6kQAllwQ6HDcTB2ajWLAUtiKbOjmON055p+3LSv4NydTdVJCT09Sm415V3GxHo/Eq1Bz/Lxh7NBwfg/V5RrHOeCdiVHS0RL5fOD/xORTChqSUrcOdP09IegEdRUXass/0aKHfqFUPS55GmoForo2nO122vh0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1751640057; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=+o9WtWIZF7CJjfjA2GAPrFXLh1beSrq23YpovmlbJIg=; b=j1L2Q0wpMXU+eXPDGekfiJqji2aLDGB8RbjMB0LbM2s21H0WYZhi0WTOKBsUY2yER7DTe+EDZZzdqyFP8wgjM9M/QDUyoHqaQZ7CCeNRpknyfi9LYVQQqkxUHTRLKrvnp6t9id5oHEOwTGbXCyW/kMiGzn4oMnG1UGhsT/bLzqw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 175164005741517.400303573743145; Fri, 4 Jul 2025 07:40:57 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uXhNg-0007hl-0X; Fri, 04 Jul 2025 10:27:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uXhIa-00060O-9P for qemu-devel@nongnu.org; Fri, 04 Jul 2025 10:21:56 -0400 Received: from mail-oa1-x2b.google.com ([2001:4860:4864:20::2b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uXhIX-0006Be-Kz for qemu-devel@nongnu.org; Fri, 04 Jul 2025 10:21:56 -0400 Received: by mail-oa1-x2b.google.com with SMTP id 586e51a60fabf-2cc89c59cc0so1315553fac.0 for ; Fri, 04 Jul 2025 07:21:53 -0700 (PDT) Received: from localhost.localdomain (fixed-187-189-51-143.totalplay.net. [187.189.51.143]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-2f78ff0471esm528016fac.3.2025.07.04.07.21.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Jul 2025 07:21:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1751638912; x=1752243712; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=+o9WtWIZF7CJjfjA2GAPrFXLh1beSrq23YpovmlbJIg=; b=a5/TsSFPlAxA8hXszobUQ4Zu9yh6nugjk6e8L5T3glkZ5dmQ8e20rMETp72JwxSvLy gR+RovQzGAQ0uboM04FmSeB7EGU6X59HfAol9mcyPeUJfdMWRJQ6PXusLsTiowNsSnR7 GNH3uMTdO1328/XZxWRQOLUA4O5CSFIWz0ieRhh1bL8Yuj8bSZoOHk/u+svYEIxAPSZC sC53BGPLGUALbUiaOGd0J46ZIFdk0hcwJV5ovENEyyBgF4NzFfWvsbOIfta3MBNDEKmL ocG/0VdmkMTADaFXi1r26iamKZmg1G04wl65LJj/O0tFM+yfS1Q7FENZ7jRn6C+9gu5l RymQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751638912; x=1752243712; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+o9WtWIZF7CJjfjA2GAPrFXLh1beSrq23YpovmlbJIg=; b=aY/+DV7daJclA3+6j72UtYgSVnCsmDY/2jZ6CH7u55+CTGrhbOmjjaWBtzJIp33LPw 5LDVbUj+HFrTX7jJ1TfDIJ7JpCM6qYOJGKrDlphrdabozmIPv5QUqzYY7UU6F5yi/Kis WEjaciE3jwLZ9NH60kX4dC/ELPk6CjgbvT4fyjG6uxLlYevu51VWQCotddxxqJ9QeaiD 2ygIDFii+axs3uFk9bCDvQw7Z3XWrT941is1FNQpughSDqBJH5m+aOhHNSlhIzq+2n6L nWTJ87AjMhiceJYSx/dI+dOjG9lwVtiD7PobYbC1NjMKWeCfE6izNNvsQqtO+1JKHOxv NQOg== X-Gm-Message-State: AOJu0YzMMnMGwaHZxjlE4GFGEoxlaEb8Nm35kJHlQkowaILLukWqbd+g qGWNrlQjEg+1E2CFNQZpRQSGWNo6ATavliolytecqJ3kI+Bx3RSIqGj7Jmxlvx7aebyoXW72peL y3wJac2Y= X-Gm-Gg: ASbGncuVE1ubLoUFW26zD4eGGOKQOrhKEV4rFvIXunmHVPHyFza+RL32UgiJ4JrGEWQ ojqHtjZik5ZMg5MI3U4ihrUSZ1UNoYHQELsqnTpefHJ5YWEq6+NN3IPWqBuTHk+Zv1MckDgUp6/ SQu9nKM5QPHEOZ/8jnCfK5Ex1u9bhijVF3PdfmbfOUrE9FABVt8Ah68kwiPxYG9Qh5iBwYiDvsY mO7+o+BSQDgTTXEoWLeaOQSAPev9nkZH2ABXus1rMaNKJg38AWagcc0pAm0Kiz3MyzmXlAyqHq4 +P4hnC0PNLNr1eeEgu7ylvCxPH9oKvpj/9ox11si/H3gGoKQUhNyph8TZTFz8mnlvx9vDL+7mGl hdLIIqxOYWRC3X1sq2B9GHOZyNRtpL6WB64ji1zNwMEPHfDFU X-Google-Smtp-Source: AGHT+IGi7L9UEX4O+oeQtJBgXBWvhWVNuVV0OlQK7LiCuPfYQpdp8XwRSP2CMobC3fO5ye5tmttW/Q== X-Received: by 2002:a05:6870:b1ca:b0:2f7:64f7:8d40 with SMTP id 586e51a60fabf-2f791f2ba2dmr2453482fac.9.1751638912105; Fri, 04 Jul 2025 07:21:52 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Cc: qemu-arm@nongnu.org, peter.maydell@linaro.org Subject: [PATCH v4 037/108] target/arm: Implement SME2 FDOT Date: Fri, 4 Jul 2025 08:20:00 -0600 Message-ID: <20250704142112.1018902-38-richard.henderson@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250704142112.1018902-1-richard.henderson@linaro.org> References: <20250704142112.1018902-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2001:4860:4864:20::2b; envelope-from=richard.henderson@linaro.org; helo=mail-oa1-x2b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1751640059046116600 Content-Type: text/plain; charset="utf-8" Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- target/arm/tcg/helper-sme.h | 5 ++++ target/arm/tcg/sme_helper.c | 44 ++++++++++++++++++++++++++++++++++ target/arm/tcg/translate-sme.c | 18 ++++++++++++++ target/arm/tcg/translate-sve.c | 5 ++++ target/arm/tcg/sme.decode | 14 +++++++++++ target/arm/tcg/sve.decode | 7 ++++-- 6 files changed, 91 insertions(+), 2 deletions(-) diff --git a/target/arm/tcg/helper-sme.h b/target/arm/tcg/helper-sme.h index cdd7058aed..ec93ff57ff 100644 --- a/target/arm/tcg/helper-sme.h +++ b/target/arm/tcg/helper-sme.h @@ -173,3 +173,8 @@ DEF_HELPER_FLAGS_5(gvec_fmaxnum_b16, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, fpst, i32) DEF_HELPER_FLAGS_5(gvec_fminnum_b16, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, fpst, i32) + +DEF_HELPER_FLAGS_6(sme2_fdot_h, TCG_CALL_NO_RWG, + void, ptr, ptr, ptr, ptr, env, i32) +DEF_HELPER_FLAGS_6(sme2_fdot_idx_h, TCG_CALL_NO_RWG, + void, ptr, ptr, ptr, ptr, env, i32) diff --git a/target/arm/tcg/sme_helper.c b/target/arm/tcg/sme_helper.c index 8ce50653b4..60322be3d0 100644 --- a/target/arm/tcg/sme_helper.c +++ b/target/arm/tcg/sme_helper.c @@ -1152,6 +1152,50 @@ void HELPER(sme_fmopa_h)(void *vza, void *vzn, void = *vzm, void *vpn, } } =20 +void HELPER(sme2_fdot_h)(void *vd, void *vn, void *vm, void *va, + CPUARMState *env, uint32_t desc) +{ + intptr_t i, oprsz =3D simd_maxsz(desc); + bool za =3D extract32(desc, SIMD_DATA_SHIFT, 1); + float_status *fpst_std =3D &env->vfp.fp_status[za ? FPST_ZA : FPST_A64= ]; + float_status *fpst_f16 =3D &env->vfp.fp_status[za ? FPST_ZA_F16 : FPST= _A64_F16]; + float_status fpst_odd =3D *fpst_std; + float32 *d =3D vd, *a =3D va; + uint32_t *n =3D vn, *m =3D vm; + + set_float_rounding_mode(float_round_to_odd, &fpst_odd); + + for (i =3D 0; i < oprsz / sizeof(float32); ++i) { + d[H4(i)] =3D f16_dotadd(a[H4(i)], n[H4(i)], m[H4(i)], + fpst_f16, fpst_std, &fpst_odd); + } +} + +void HELPER(sme2_fdot_idx_h)(void *vd, void *vn, void *vm, void *va, + CPUARMState *env, uint32_t desc) +{ + intptr_t i, j, oprsz =3D simd_maxsz(desc); + intptr_t elements =3D oprsz / sizeof(float32); + intptr_t eltspersegment =3D MIN(4, elements); + int idx =3D extract32(desc, SIMD_DATA_SHIFT, 2); + bool za =3D extract32(desc, SIMD_DATA_SHIFT + 2, 1); + float_status *fpst_std =3D &env->vfp.fp_status[za ? FPST_ZA : FPST_A64= ]; + float_status *fpst_f16 =3D &env->vfp.fp_status[za ? FPST_ZA_F16 : FPST= _A64_F16]; + float_status fpst_odd =3D *fpst_std; + float32 *d =3D vd, *a =3D va; + uint32_t *n =3D vn, *m =3D (uint32_t *)vm + H4(idx); + + set_float_rounding_mode(float_round_to_odd, &fpst_odd); + + for (i =3D 0; i < elements; i +=3D eltspersegment) { + uint32_t mm =3D m[i]; + for (j =3D 0; j < eltspersegment; ++j) { + d[H4(i + j)] =3D f16_dotadd(a[H4(i + j)], n[H4(i + j)], mm, + fpst_f16, fpst_std, &fpst_odd); + } + } +} + void HELPER(sme_bfmopa)(void *vza, void *vzn, void *vzm, void *vpn, void *vpm, CPUARMState *env, uint32_t d= esc) { diff --git a/target/arm/tcg/translate-sme.c b/target/arm/tcg/translate-sme.c index 9ec02d960d..761584c90b 100644 --- a/target/arm/tcg/translate-sme.c +++ b/target/arm/tcg/translate-sme.c @@ -903,3 +903,21 @@ static bool do_bfmlal_nx(DisasContext *s, arg_azx_n *a= , bool sub) =20 TRANS_FEAT(BFMLAL_nx, aa64_sme2, do_bfmlal_nx, a, false) TRANS_FEAT(BFMLSL_nx, aa64_sme2, do_bfmlal_nx, a, true) + +static bool do_fdot(DisasContext *s, arg_azz_n *a, bool multi) +{ + return do_azz_acc_fp(s, a->n, 1, a->rv, a->off, a->zn, a->zm, 1, 0, + multi, FPST_ENV, gen_helper_sme2_fdot_h); +} + +TRANS_FEAT(FDOT_n1, aa64_sme2, do_fdot, a, false) +TRANS_FEAT(FDOT_nn, aa64_sme2, do_fdot, a, true) + +static bool do_fdot_nx(DisasContext *s, arg_azx_n *a) +{ + return do_azz_acc_fp(s, a->n, 1, a->rv, a->off, a->zn, a->zm, + a->idx | (1 << 2), 0, false, FPST_ENV, + gen_helper_sme2_fdot_idx_h); +} + +TRANS_FEAT(FDOT_nx, aa64_sme2, do_fdot_nx, a) diff --git a/target/arm/tcg/translate-sve.c b/target/arm/tcg/translate-sve.c index b85bd885f9..4acd22f55e 100644 --- a/target/arm/tcg/translate-sve.c +++ b/target/arm/tcg/translate-sve.c @@ -7229,6 +7229,11 @@ TRANS_FEAT_NONSTREAMING(USMMLA, aa64_sve_i8mm, gen_g= vec_ool_arg_zzzz, TRANS_FEAT_NONSTREAMING(UMMLA, aa64_sve_i8mm, gen_gvec_ool_arg_zzzz, gen_helper_gvec_ummla_b, a, 0) =20 +TRANS_FEAT(FDOT_zzzz, aa64_sme2_or_sve2p1, gen_gvec_env_arg_zzzz, + gen_helper_sme2_fdot_h, a, 0) +TRANS_FEAT(FDOT_zzxz, aa64_sme2_or_sve2p1, gen_gvec_env_arg_zzxz, + gen_helper_sme2_fdot_idx_h, a) + TRANS_FEAT(BFDOT_zzzz, aa64_sve_bf16, gen_gvec_env_arg_zzzz, gen_helper_gvec_bfdot, a, 0) TRANS_FEAT(BFDOT_zzxz, aa64_sve_bf16, gen_gvec_env_arg_zzxz, diff --git a/target/arm/tcg/sme.decode b/target/arm/tcg/sme.decode index 9850c19d90..a2b93519c4 100644 --- a/target/arm/tcg/sme.decode +++ b/target/arm/tcg/sme.decode @@ -285,6 +285,9 @@ BFMLSL_n1 11000001 001 0 .... 0 .. 011 ..... 11 .= .. @azz_nx1_o3x2 n=3D1 BFMLSL_n1 11000001 001 0 .... 0 .. 010 ..... 110 .. @azz_nx1_o2x2 = n=3D2 BFMLSL_n1 11000001 001 1 .... 0 .. 010 ..... 110 .. @azz_nx1_o2x2 = n=3D4 =20 +FDOT_n1 11000001 001 0 .... 0 .. 100 ..... 00 ... @azz_nx1_o3 n= =3D2 +FDOT_n1 11000001 001 1 .... 0 .. 100 ..... 00 ... @azz_nx1_o3 n= =3D4 + ### SME2 Multi-vector Multiple Array Vectors =20 %zn_ax2 6:4 !function=3Dtimes_2 @@ -322,6 +325,9 @@ BFMLAL_nn 11000001 101 ...01 0 .. 010 ...00 100 .= . @azz_4x4_o2x2 BFMLSL_nn 11000001 101 ....0 0 .. 010 ....0 110 .. @azz_2x2_o2x2 BFMLSL_nn 11000001 101 ...01 0 .. 010 ...00 110 .. @azz_4x4_o2x2 =20 +FDOT_nn 11000001 101 ....0 0 .. 100 ....0 00 ... @azz_2x2_o3 +FDOT_nn 11000001 101 ...01 0 .. 100 ...00 00 ... @azz_4x4_o3 + ### SME2 Multi-vector Indexed =20 &azx_n n off rv zn zm idx @@ -351,3 +357,11 @@ BFMLAL_nx 11000001 1001 .... 1 .. 1 .. ...00 10 = ... @azx_4x1_o2x2 BFMLSL_nx 11000001 1000 .... . .. 1 .. ..... 11 ... @azx_1x1_o3x2 BFMLSL_nx 11000001 1001 .... 0 .. 1 .. ....0 11 ... @azx_2x1_o2x2 BFMLSL_nx 11000001 1001 .... 1 .. 1 .. ...00 11 ... @azx_4x1_o2x2 + +@azx_2x1_i2_o3 ........ .... zm:4 . .. . idx:2 .... ... off:3 \ + &azx_n n=3D2 rv=3D%mova_rv zn=3D%zn_ax2 +@azx_4x1_i2_o3 ........ .... zm:4 . .. . idx:2 .... ... off:3 \ + &azx_n n=3D2 rv=3D%mova_rv zn=3D%zn_ax4 + +FDOT_nx 11000001 0101 .... 0 .. 1 .. ....0 01 ... @azx_2x1_i2_o3 +FDOT_nx 11000001 0101 .... 1 .. 1 .. ...00 01 ... @azx_4x1_i2_o3 diff --git a/target/arm/tcg/sve.decode b/target/arm/tcg/sve.decode index 3a99eb7299..5970ed9ac4 100644 --- a/target/arm/tcg/sve.decode +++ b/target/arm/tcg/sve.decode @@ -1662,7 +1662,8 @@ FMLSLT_zzzw 01100100 10 1 ..... 10 1 00 1 ..... .= .... @rda_rn_rm_ex esz=3D2 BFMLALB_zzzw 01100100 11 1 ..... 10 0 00 0 ..... ..... @rda_rn_rm_ex e= sz=3D2 BFMLALT_zzzw 01100100 11 1 ..... 10 0 00 1 ..... ..... @rda_rn_rm_ex e= sz=3D2 =20 -### SVE2 floating-point bfloat16 dot-product +### SVE2 floating-point dot-product +FDOT_zzzz 01100100 00 1 ..... 10 0 00 0 ..... ..... @rda_rn_rm_ex e= sz=3D2 BFDOT_zzzz 01100100 01 1 ..... 10 0 00 0 ..... ..... @rda_rn_rm_ex e= sz=3D2 =20 ### SVE2 floating-point multiply-add long (indexed) @@ -1673,7 +1674,9 @@ FMLSLT_zzxw 01100100 10 1 ..... 0110.1 ..... ....= . @rrxr_3a esz=3D2 BFMLALB_zzxw 01100100 11 1 ..... 0100.0 ..... ..... @rrxr_3a esz=3D2 BFMLALT_zzxw 01100100 11 1 ..... 0100.1 ..... ..... @rrxr_3a esz=3D2 =20 -### SVE2 floating-point bfloat16 dot-product (indexed) +### SVE2 floating-point dot-product (indexed) + +FDOT_zzxz 01100100 00 1 ..... 010000 ..... ..... @rrxr_2 esz=3D2 BFDOT_zzxz 01100100 01 1 ..... 010000 ..... ..... @rrxr_2 esz=3D2 =20 ### SVE broadcast predicate element --=20 2.43.0