From nobody Sat Dec 13 22:54:06 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1751624191; cv=none; d=zohomail.com; s=zohoarc; b=kFy3P5c0TG/SNuINMl6KaC/UnQ1N5nH+r4TE32yI65RAqvzEgjmnx6gOlogydoFc6Ut12AmNGksOvIRBKQ9njD3Ebzg7onDFpIHFJPkh+1sPQPUCgG2HQHtmOsAQBlZRfeTKgOJpqjmRLlmBC2YOd2Qu+HuXXJTstTd07BAXwBk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1751624191; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=5yU4jFODLQ5Yk9FO8VyUpgwPHGFKBwT9h/DN9+uzfxQ=; b=NXAcERNPK4A1qJmwpiNVumhT0BFhfAMKvChiiacO0xnjZbpdLwJgYhA/M0ermXIzA/nzou2YCDbNsie+ogAZnDUVSzojmyRuWmGWpawqIuO91aJEiChGKz/B1ew4yarh/ohCCGnYOohV/n1xtGPhxH5MFh79mGdZD33n64afGPU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1751624191375388.2625411686853; Fri, 4 Jul 2025 03:16:31 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uXdRf-0005yD-OW; Fri, 04 Jul 2025 06:15:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uXdRO-0005uv-M5 for qemu-devel@nongnu.org; Fri, 04 Jul 2025 06:14:51 -0400 Received: from mail-wm1-x329.google.com ([2a00:1450:4864:20::329]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uXdRL-00068Y-C4 for qemu-devel@nongnu.org; Fri, 04 Jul 2025 06:14:45 -0400 Received: by mail-wm1-x329.google.com with SMTP id 5b1f17b1804b1-450ce671a08so4169465e9.3 for ; Fri, 04 Jul 2025 03:14:42 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b47030bc79sm2100514f8f.9.2025.07.04.03.14.40 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 04 Jul 2025 03:14:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1751624081; x=1752228881; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=5yU4jFODLQ5Yk9FO8VyUpgwPHGFKBwT9h/DN9+uzfxQ=; b=SlCjpdPPkfJq61JejPhZ2Wj/AVyto4Rshs7bw0nA6JtWLpDbnVIh3vnHuUyxoqFbd9 /pREJ82KkPYd02K+fN3yeLDyWQr/nly7dyQqlxShbF+v1Z2BwqsAcdLrwnjjywELgQvV Vu8prjPmuQ2s9pz9ma/DICwokTOKhDgOyn1ZJtJiV4nNQazyHk7cz/UiyIIg/WBriYmE 5lLgeQG7fstVx0wQBeRFZgbaPp41gkuMRxTAyfWlkrwnsPbLUvtRH3v9r75x9TbDrrS7 KIIkULI4um6Yx/1rOdTYv3YVfaZa7T4V9Y+Yu6lEuOOUJ1g5KcmysMZZaRUw4/Qsy7Di w6SQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751624081; x=1752228881; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5yU4jFODLQ5Yk9FO8VyUpgwPHGFKBwT9h/DN9+uzfxQ=; b=rlJULHRc6oIYwYWWaXhs9EyQtSASDNPjdou4ZmaBUeHqoOItPacXw6NTY3bsj13RAF xrZKOJwwr4yNVH9DMKGhlFwL2SVDgigS9IyyXOPUWBCWRPJGyFkJR5m49GRhtM2gHUfh mv4L+CoNKlH+53BbHYP16CMURQOOqq5F7Nudx0fdRdYPLJxwEwLHhn0AQFLI4RqxJOnW barGXYGb2Wqu1ji12w7TYC14DFKjty7mI5lN7agqh+Yv0Sn+snNi2iwgVpsI8jYPObPF UQ80Ju4fchmqJ3Xeq/DKzsfGj5Ev1pXbPU9KKILSD3VJPocOAw75vIbq6Dtmid9o4tsz rTWg== X-Gm-Message-State: AOJu0Yxybco9z2H9fNDT4BnjHfnegXmxnqbpX/0qMHUxQ+0Ua5LdaCRL J1dSJLVAwvJqw326QU5pQN5p5LgGdY1u+408lGsk7UVarPgO3VUOwpOyXV44I2+efFV8LPgtJD0 ezlcDiJ4= X-Gm-Gg: ASbGncv7RSJGoKO4Ok/6uJK8pMt/ARa8EXsoOJs/l+I7jq+2BVbqBvW250BSP7gWGgT MotoNiUQ6nA+vC24QwswlioQUK9DKwioDEtNO1Yg3zkQ5XsGq0CqLbAiFdGa+ylW8Lbw47Znjta TmlsuJYt99RN48VFWXHBPkThYLClEUilr9shTOaWrDytL43hQly/t8d55w6/3lkihtxUxJNCrjR g+W3eD/4Kdzj8W5ZTSp+hUOv8b4A6ztuy4EpWNE3sCQTUbCpIychSNJLgo5Vn9m+brGpR3T4Ph+ OVatSjaXvahf1ZbPQK8WvgGNJIt6XmnYVrkgTxHT65y7SqgXl5yOjVfwMsSbh+eFSzpxLYSGdQM +eOKsdf6z+FcALrdhwjO/9exiFR14rOWq3T3m X-Google-Smtp-Source: AGHT+IHsGoZ40OAnCXH3jYayS4gvuTz0xGTGwM8GhGEypnAAhuhYqUglyP8eggPVM4UrMH3RqdCyeA== X-Received: by 2002:a05:600c:540f:b0:445:1984:247d with SMTP id 5b1f17b1804b1-454b4e67f8bmr13368495e9.7.1751624081235; Fri, 04 Jul 2025 03:14:41 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 01/31] system/cpus: Assert interrupt handling is done with BQL locked Date: Fri, 4 Jul 2025 12:14:02 +0200 Message-ID: <20250704101433.8813-2-philmd@linaro.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250704101433.8813-1-philmd@linaro.org> References: <20250704101433.8813-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::329; envelope-from=philmd@linaro.org; helo=mail-wm1-x329.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1751624193213116600 Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson Reviewed-by: Xiaoyao Li Reviewed-by: Zhao Liu Message-Id: <20250703173248.44995-5-philmd@linaro.org> --- accel/tcg/tcg-accel-ops.c | 2 -- system/cpus.c | 2 ++ 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/accel/tcg/tcg-accel-ops.c b/accel/tcg/tcg-accel-ops.c index b24d6a75625..6116644d1c0 100644 --- a/accel/tcg/tcg-accel-ops.c +++ b/accel/tcg/tcg-accel-ops.c @@ -93,8 +93,6 @@ static void tcg_cpu_reset_hold(CPUState *cpu) /* mask must never be zero, except for A20 change call */ void tcg_handle_interrupt(CPUState *cpu, int mask) { - g_assert(bql_locked()); - cpu->interrupt_request |=3D mask; =20 /* diff --git a/system/cpus.c b/system/cpus.c index d16b0dff989..a43e0e4e796 100644 --- a/system/cpus.c +++ b/system/cpus.c @@ -265,6 +265,8 @@ static void generic_handle_interrupt(CPUState *cpu, int= mask) =20 void cpu_interrupt(CPUState *cpu, int mask) { + g_assert(bql_locked()); + if (cpus_accel->handle_interrupt) { cpus_accel->handle_interrupt(cpu, mask); } else { --=20 2.49.0 From nobody Sat Dec 13 22:54:06 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1751624458; cv=none; d=zohomail.com; s=zohoarc; b=f/iEk3ilGpfEDqpL580NnHAHgJcT3Rz1KV/yhWo5oU6UUWW9BmVguvRud9/LtkZShwFzsZh3IV5WW8MrV+vnWvEIiYFzsDt6MWSjzV6XKjVssrqpedjPY+1mmwsfBtbp/0PwPg3DOISq/HGXXeJy81u7JocRtbzUF0hVeADNtfM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1751624458; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=+KDRndTqan82yvtPjat1lQGvdAKO/1zJZTpa0R1qcXc=; b=bG8ZGey3AI0GkHZV3/ykGKPbQmJ3T21D6pVCPDJE/1WoVPueOaK5RyG1pADgBOsImDx/Nh7AcJreh7E0YsyqHqITwvvSiNnK18c56mLG1nNUDQte3pp8b8+TAz5ia62hUbYanJfkh7VnJOzicsCvSky/CPRXW9glvpCtVmZeaAE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1751624458779509.9329813013436; Fri, 4 Jul 2025 03:20:58 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uXdRh-0005yj-Bl; Fri, 04 Jul 2025 06:15:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uXdRU-0005vq-N8 for qemu-devel@nongnu.org; Fri, 04 Jul 2025 06:14:55 -0400 Received: from mail-wr1-x431.google.com ([2a00:1450:4864:20::431]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uXdRR-00069P-P0 for qemu-devel@nongnu.org; Fri, 04 Jul 2025 06:14:52 -0400 Received: by mail-wr1-x431.google.com with SMTP id ffacd0b85a97d-3a50956e5d3so555016f8f.1 for ; Fri, 04 Jul 2025 03:14:47 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b4708d085asm2081801f8f.25.2025.07.04.03.14.45 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 04 Jul 2025 03:14:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1751624086; x=1752228886; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=+KDRndTqan82yvtPjat1lQGvdAKO/1zJZTpa0R1qcXc=; b=HhutvXcDjxKCBmr8M9N5mpf1/LgcFNst2A27YLoASs/oXmkl6qwFj3mf+VClVfg0xg GfMw7zNOaXHaWz8w6oSpsd1NQ73mqWgyTOgcEknP0+A9Q/3Cf3M2UjziVUYF6ovLCtVR 85ZzENo+Zl/bG9t0cOklybp2hehC+g1CCrdajFJaCm+GlyIPru6Lo67/TOtXH82YEeGa v13bwhvk96C1u5kFIGN6iDJQB3txgF+GNXPQ78pGXjAtHLvbdnwDTrKIPFwYwcd65l6F PyRBmJqu9DVAuQJ26GEnktHUkkdCsnWD12EzdrhRUOk2eS7uhvjxgOSrz3vBa8OeyROb YnsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751624086; x=1752228886; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+KDRndTqan82yvtPjat1lQGvdAKO/1zJZTpa0R1qcXc=; b=IEfwnKBqcYCiY3tXrMWq0yKOhx4ZFHTkTnzl9PnwRJzVG2SFGHMkK+r5/5eWXKy4lN QC3Prlx+C8yjwQY81KQHAw67t9IlAKYfg1R388UPpxCCrSOdU067JwhrTA8XApWzRhlt XOlfILiSxnLAo8LlrWLe8fcxLiuTL21EPMkB8qkbm9KPX8zz3x4yt+gbv0zTrQEkqy5t 5ZJW7+IVR1amrJuN0AA83pHY2KdvMUErfeturK+wtvxgGWi8233H0tCBaxNFS9Op+GLQ piN21yfI+AC16o+YOQToCgHqbRS7xCzmzPnVI6U/nVM13DI61vZ7CBDjQqzAuSUxKmJg cXKw== X-Gm-Message-State: AOJu0YxZwQsOb6odmAr+VjDDZ+uHYjc+u4SmUaFET2c02QYh9Awc+fZY wSk0rLn2eZCptJNz4ocawqHXsvQbEbqdCgwhOAoOpbh6mpWggsNCrCVrnv/Y6BhldJOUyMRMg9u sLo6naEM= X-Gm-Gg: ASbGncvnRR8QQi2gzXdZSrxHgQXr76wH+KCva3Fp9q2MyfHXl+Y7xtAvI7WYo5dfWQy m8uqblMIxj2zJ38p3e6vNrTXfYJV0hHSSxYvByDzhX/93LWGPG/H5mmDpQ0P79eXpAq5IUacN54 23UxKk2JgqX9T5RxD/WWuUsdxghkV1dir0mst6wbiJGqFA/kwLbW4DhMb507TZb64hk56ZhKrDU 9T667Wo58+PYl0ytcK1F/qWWL/+zzsRU+iIGhnzsTaNySCxqoCsjmFd31yAx8Pf4zZb/mzYr9wM 76B4/ue78RiVBXvKEXe+J47p4N+oyjJNr3hxLSLgdgu0jNOkhAgMhbXs9Ax5fjseXzhbkWzLDNC 8aUoLLfa3t8EHEDT6rIpzcGitWiHDJeN2mwy0 X-Google-Smtp-Source: AGHT+IGY0QB3lOftMHf25y7wGNZKvFN3HVVd5iYxOl5WiyNgQl4f2RJnaBTiJc8/FsJxQTz3vkxkbQ== X-Received: by 2002:a05:6000:208a:b0:3a5:527b:64c6 with SMTP id ffacd0b85a97d-3b4964f3890mr1860473f8f.1.1751624085675; Fri, 04 Jul 2025 03:14:45 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 02/31] accel/kvm: Remove kvm_init_cpu_signals() stub Date: Fri, 4 Jul 2025 12:14:03 +0200 Message-ID: <20250704101433.8813-3-philmd@linaro.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250704101433.8813-1-philmd@linaro.org> References: <20250704101433.8813-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::431; envelope-from=philmd@linaro.org; helo=mail-wr1-x431.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1751624460549116600 Since commit 57038a92bb0 ("cpus: extract out kvm-specific code to accel/kvm") the kvm_init_cpu_signals() stub is not necessary. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson Reviewed-by: Xiaoyao Li Message-Id: <20250703173248.44995-6-philmd@linaro.org> --- accel/stubs/kvm-stub.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/accel/stubs/kvm-stub.c b/accel/stubs/kvm-stub.c index ecfd7636f5f..b9b4427c919 100644 --- a/accel/stubs/kvm-stub.c +++ b/accel/stubs/kvm-stub.c @@ -105,11 +105,6 @@ unsigned int kvm_get_free_memslots(void) return 0; } =20 -void kvm_init_cpu_signals(CPUState *cpu) -{ - abort(); -} - bool kvm_arm_supports_user_irq(void) { return false; --=20 2.49.0 From nobody Sat Dec 13 22:54:06 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1751624137; cv=none; d=zohomail.com; s=zohoarc; b=EeVDNJpd+nSTb6lBiynrS+T4EU9X+4LD90hN88dkBDgmRvYSOZLEx3birSsyenga84ao+RXZMDu06y1KwcBLGqIfCHzCzlGstdlnj29ccNZMMF5Z6s1BLV8QnIukYCk35fGGRXX/XTE53jcZ7RNv8cq3HBqn9shJaHjFKcqtjtM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1751624137; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=g1qUi+6m397zoKQpfNej+VqjNFsZRTFYtagMj07jt4U=; b=SKnUD8FfpLc6Atlgow3+Y8JcJsUrpIeH4IWvnQKOA/UKmziiq04wKjR5y1CZlmnlmSM07xay0XdH1YQ9Jd+LhoPOzSVAr9UbR3xiSqnjc9hB5ouXlLKEBdoPN3Lr0cskvgaSDISIZmC8W/uwF4FPzSSpGfNfdZbJOwmfcsiKjVQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1751624137131306.06006079937174; Fri, 4 Jul 2025 03:15:37 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uXdRg-0005yi-16; Fri, 04 Jul 2025 06:15:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uXdRX-0005vu-2j for qemu-devel@nongnu.org; Fri, 04 Jul 2025 06:14:55 -0400 Received: from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uXdRU-0006Au-K7 for qemu-devel@nongnu.org; Fri, 04 Jul 2025 06:14:54 -0400 Received: by mail-wm1-x32e.google.com with SMTP id 5b1f17b1804b1-450cf0120cdso5757155e9.2 for ; Fri, 04 Jul 2025 03:14:52 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b47285d3bbsm2110255f8f.96.2025.07.04.03.14.49 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 04 Jul 2025 03:14:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1751624090; x=1752228890; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=g1qUi+6m397zoKQpfNej+VqjNFsZRTFYtagMj07jt4U=; b=zcQwY8zxSd4HGsirKLKZFDViTvkIQhS2LGAiNwOQfLB1nNIWsolxUVtsmC+LfF4fLS Cp73joyYhm+/i+6rs9SXrsd5IrXXS2lhFDhnWkI6J1B2XS31OkBNE3816ectAWepHpN3 XEF8iWt7i76jqs7EvxtGgjvc2CUAg18LWBIa36ANaqHOaOUA3aeegLS4NOHz/jZz6f6j 27VcbQMTtajlRDK9pLy2VNFn4JYvLwmPezYHB+Frj1NtBqHEd4JDtmjSsrDmFiTs7S6o dyqdlPNMhfDHb1y7V0MEqJmUY7vFJKMEIDyzb5DmHRwkvS5/ccXNTNuUSoDDdtCyeYj1 POsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751624090; x=1752228890; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=g1qUi+6m397zoKQpfNej+VqjNFsZRTFYtagMj07jt4U=; b=dwEI3puQSqTItMlbL/1kzmYl6k/66rQILQDbxqxOoKQz5fjYkho+TMYyjaAiIF/Akp CKWD1lnlc/tyyRXZzAUynLHgAPtBGdjS/N62A+D31L/XDXGyexSObTQ/OidW+dpd59yc 4f3pitbTrE9bYUXguiHw+z3xgjXb++mI9bypxxdzPanfnsEhU6BspxeERkVhcJb25QhM BN5wrUfz6Q3oVRm1meREDOqs6YZZSPABV8wGmv9K/jCT2EjkRW4PVvAaGUgXOngyLLSy jNDJk6e75mfzLRJam/PUFns5hiK4kAwua3jdRKwh5BWuopIPNB7U04sH2m9G2W2OW0T4 ijDA== X-Gm-Message-State: AOJu0YzOBi++amEEJM+IDtEyhbqDFNAZRf0mDemzjeopHlMVJh68GBi/ F1EG1COzayZSsFcbaI0IvMsUZCfcmR4ppsrk9xw3JipnVPvkt/LmWEIOcOY2zfUwTH506OGqCf6 NpFiHeMg= X-Gm-Gg: ASbGnctrH118L3lNgI3mi9J54xpLZHb3ppdlgR31HulSIOXSrPMyg0ll2wyNAPKnixD msuf0vqFVGPJO8hfOJ8uPxx4iCXDdZCIL8f26XxknR5Cy9iujlqtPZ+3nxExWKg5Q7fw87IJnWh k/4HRzqK+XeKjg/0/f9W/LjCGBu2dsVhoH8bc818M/vkXVxDftrVbp0h1BEhC5xtgvIB7U9wkf/ /MgqP8PRlh/mLDVZ5sRgMFPson2/bpkU5NPCTMk5rrdqAoQAJqp06b2Wc34H8nBcFSnt5M/dROE wsaIKcAu4eLplnLafBmP5+zhfbcp5WOb0XVcnIM1ddHTTDsYjyQPyrQ9uAqcfswohT77WkyzM6D 8/k/6u5ovMO1Dvy8or9PyhGwC+2n4Uzk7fjCq X-Google-Smtp-Source: AGHT+IGbV2KHuWPiLNbT3/342ZnMYwodrHJWWLDozZd3WAa1wCGRj3YhdF+8YnZENcmhm+76zwUc/A== X-Received: by 2002:a05:600c:19d1:b0:450:d61f:dd45 with SMTP id 5b1f17b1804b1-454b4e6b9fdmr15451665e9.4.1751624090262; Fri, 04 Jul 2025 03:14:50 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 03/31] accel/kvm: Reduce kvm_create_vcpu() declaration scope Date: Fri, 4 Jul 2025 12:14:04 +0200 Message-ID: <20250704101433.8813-4-philmd@linaro.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250704101433.8813-1-philmd@linaro.org> References: <20250704101433.8813-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32e; envelope-from=philmd@linaro.org; helo=mail-wm1-x32e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1751624138940116600 kvm_create_vcpu() is only used within the same file unit. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson Reviewed-by: Xiaoyao Li Reviewed-by: Zhao Liu Message-Id: <20250703173248.44995-7-philmd@linaro.org> --- include/system/kvm.h | 8 -------- accel/kvm/kvm-all.c | 8 +++++++- 2 files changed, 7 insertions(+), 9 deletions(-) diff --git a/include/system/kvm.h b/include/system/kvm.h index 7cc60d26f24..e943df2c09d 100644 --- a/include/system/kvm.h +++ b/include/system/kvm.h @@ -316,14 +316,6 @@ int kvm_create_device(KVMState *s, uint64_t type, bool= test); */ bool kvm_device_supported(int vmfd, uint64_t type); =20 -/** - * kvm_create_vcpu - Gets a parked KVM vCPU or creates a KVM vCPU - * @cpu: QOM CPUState object for which KVM vCPU has to be fetched/created. - * - * @returns: 0 when success, errno (<0) when failed. - */ -int kvm_create_vcpu(CPUState *cpu); - /** * kvm_park_vcpu - Park QEMU KVM vCPU context * @cpu: QOM CPUState object for which QEMU KVM vCPU context has to be par= ked. diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c index d095d1b98f8..17235f26464 100644 --- a/accel/kvm/kvm-all.c +++ b/accel/kvm/kvm-all.c @@ -453,7 +453,13 @@ static void kvm_reset_parked_vcpus(KVMState *s) } } =20 -int kvm_create_vcpu(CPUState *cpu) +/** + * kvm_create_vcpu - Gets a parked KVM vCPU or creates a KVM vCPU + * @cpu: QOM CPUState object for which KVM vCPU has to be fetched/created. + * + * @returns: 0 when success, errno (<0) when failed. + */ +static int kvm_create_vcpu(CPUState *cpu) { unsigned long vcpu_id =3D kvm_arch_vcpu_id(cpu); KVMState *s =3D kvm_state; --=20 2.49.0 From nobody Sat Dec 13 22:54:06 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1751624203; cv=none; d=zohomail.com; s=zohoarc; b=VtkyYCmtmCA5QXAxJjjS5DppJe6VvE5rC30RGVZz6LWUsKsqjPgjTTSCGIAXwOESK73TyMVks3d8RaLTHsschxZ/MxwVK0xMwFvmqUlNeky35PGNV3oU45a7qCFN2HCYP9aGe43PQxTnZjxb2dHZJOoUbFLq9gFETPcBLT5zWyE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1751624203; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=Qi/F+aAGU5AG22ZfFCwxT77wB5E9yShca/tWxG6C5Mo=; b=CxMd72aN1o85PHuUZduc9w9t64qpxkj5Ipn9iL9W+3wsHWLHyFJmOPNVnNq7wNfVpMaTS9JHieUnUnd9vzg4MkjN7CpN4PGuKNv6AB7dYHyVBiL37O9DxNglFAi8OgpVBJ3GgJLvcalD9t6z4aXkJIzE454xFKI0CK668kNle8U= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1751624203907501.95821586293573; Fri, 4 Jul 2025 03:16:43 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uXdRi-00060I-SQ; Fri, 04 Jul 2025 06:15:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uXdRd-0005xk-2f for qemu-devel@nongnu.org; Fri, 04 Jul 2025 06:15:01 -0400 Received: from mail-wm1-x332.google.com ([2a00:1450:4864:20::332]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uXdRa-0006CN-5S for qemu-devel@nongnu.org; Fri, 04 Jul 2025 06:15:00 -0400 Received: by mail-wm1-x332.google.com with SMTP id 5b1f17b1804b1-453608ed113so8246975e9.0 for ; Fri, 04 Jul 2025 03:14:56 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-454a9bced0esm51337475e9.22.2025.07.04.03.14.54 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 04 Jul 2025 03:14:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1751624095; x=1752228895; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=Qi/F+aAGU5AG22ZfFCwxT77wB5E9yShca/tWxG6C5Mo=; b=NnIxT5ou1DHoujuU5kkKVrVU+WvlhfCUOGmhdKyONG08Uu+mmIIyQJB+QemYgiGJGg tzBhPh89sA+RQqjOimd/swa34Cf3kUgrrXUc+8nxswSnS3CIZjDZNhHFH5XLGTHrnuW4 tJYnyNc3gSKMHLT3loHrwvc4widSlmmW6NCSCYpzt/ATQE6RjvNoy2Vwfu/WmCUvUPbw b7UyvMOlGjROHdY2OyTs7EDB0F2s16Hh+uhMW6JgqjKJdAvwAPvo3sO5DVAgStI4RELW 34eCxZZmiJW2oMwM3l2ez7+xbIpMTuy9EYHDrJjVEzT1UXXGdNojrNd3onW3Y3qtxFYz HxHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751624095; x=1752228895; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Qi/F+aAGU5AG22ZfFCwxT77wB5E9yShca/tWxG6C5Mo=; b=paSh1xLyTCj46C1PLHh0wnh8YA83X5x/T7bPkiENjCbtpbQbxNVVy1IW6d6Q2HdOf0 UUsJ0mCJsXl7wjL/yJv08f3zr/XsHrmcdeKm/cKH/87Wy89t/HQXy+EA0kpqg72hL2Hb ty8kohCqV3Hr1y8BCyQFHTbyJ645s9zvkXEjYgWe7Kvk8W40PnHUgTmHr3SiR5zsUG1P uKBtrMfoSlI5wRO95bXHgzKeGMxp9IRal8HG/xoTFVcn1LeZ6OryYhKHuam0TQPbIE5I x1N5yu2810z15VcXEt2TYhkXcheEwir+LShx0RZxT9Z+7UXBgU1coGUzv8egQC0jbJzC U97g== X-Gm-Message-State: AOJu0YyzR2IgTyOmGlEB+DQaLE1tXdj4bZ0hffqLGGSuuqAu6H58yD05 iD9Dy0cdOlA5QzrJffym/EcVQX12umidT3LsqGJMQG3i6OZVC0nzQg74PaezwW37jbVNXxircV8 T1VU+tKw= X-Gm-Gg: ASbGncukm8urMPvoUfwKQMzP8XdpDx23/ncPnCpBGpykuCxE1/JZuUh4EAXRT5Vozom xSgm8BlGsEhFsLCK1y5SQbXAPRALqE4EkmWLR6IkDyaBvnf0eM9UPuL2BFv4/ePIgrUD4/idPay MWM+l9Kg8mkW8XnYCNxx/puMJeoAm9f2zOLbT0Mql4FhJyHG+3j+Dd39GsDwAUedolBYzqHUuy/ vRS4lWqhKz/Daphh5wsyje5objjkhNPllc/ot+oCCFN/TvA4Ge0tW8K7LtUGhSD5yfj3mODfwp2 Q5+EaI8wYSS/Kmro9l1m8+2s4lYvyKExgaq0PBU2Mpjy4yZwnU5GmQwl6Jgu58n0Ti0Hq+jZjA4 GmyI13/HyQ5c4wyUmjyU+WAexKlSmNq2/dO0x X-Google-Smtp-Source: AGHT+IGeJvXwa1E87X3fBLWH1XWeO+jo/c5pKJzo//sW5SkaGqSgGfcoQxiLacD5YtRK/cNrI0+Zbw== X-Received: by 2002:a05:600c:3493:b0:442:cd03:3e2 with SMTP id 5b1f17b1804b1-454b306a122mr20465715e9.2.1751624094842; Fri, 04 Jul 2025 03:14:54 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 04/31] accel/tcg: Remove 'info opcount' and @x-query-opcount Date: Fri, 4 Jul 2025 12:14:05 +0200 Message-ID: <20250704101433.8813-5-philmd@linaro.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250704101433.8813-1-philmd@linaro.org> References: <20250704101433.8813-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::332; envelope-from=philmd@linaro.org; helo=mail-wm1-x332.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1751624205427116600 Since commit 1b65b4f54c7 ("accel/tcg: remove CONFIG_PROFILER", released with QEMU v8.1.0) we get pointless output: (qemu) info opcount [TCG profiler not compiled] Remove that unstable and unuseful command. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Acked-by: Dr. David Alan Gilbert Reviewed-by: Richard Henderson Reviewed-by: Xiaoyao Li Reviewed-by: Markus Armbruster Reviewed-by: Zhao Liu Message-Id: <20250703173248.44995-8-philmd@linaro.org> --- qapi/machine.json | 18 ------------------ accel/tcg/monitor.c | 21 --------------------- tests/qtest/qmp-cmd-test.c | 1 - hmp-commands-info.hx | 14 -------------- 4 files changed, 54 deletions(-) diff --git a/qapi/machine.json b/qapi/machine.json index 0650b8de71a..f712e7da6d6 100644 --- a/qapi/machine.json +++ b/qapi/machine.json @@ -1761,24 +1761,6 @@ 'returns': 'HumanReadableText', 'features': [ 'unstable' ] } =20 -## -# @x-query-opcount: -# -# Query TCG opcode counters -# -# Features: -# -# @unstable: This command is meant for debugging. -# -# Returns: TCG opcode counters -# -# Since: 6.2 -## -{ 'command': 'x-query-opcount', - 'returns': 'HumanReadableText', - 'if': 'CONFIG_TCG', - 'features': [ 'unstable' ] } - ## # @x-query-ramblock: # diff --git a/accel/tcg/monitor.c b/accel/tcg/monitor.c index 1c182b6bfb5..7c686226b21 100644 --- a/accel/tcg/monitor.c +++ b/accel/tcg/monitor.c @@ -215,30 +215,9 @@ HumanReadableText *qmp_x_query_jit(Error **errp) return human_readable_text_from_str(buf); } =20 -static void tcg_dump_op_count(GString *buf) -{ - g_string_append_printf(buf, "[TCG profiler not compiled]\n"); -} - -HumanReadableText *qmp_x_query_opcount(Error **errp) -{ - g_autoptr(GString) buf =3D g_string_new(""); - - if (!tcg_enabled()) { - error_setg(errp, - "Opcode count information is only available with accel= =3Dtcg"); - return NULL; - } - - tcg_dump_op_count(buf); - - return human_readable_text_from_str(buf); -} - static void hmp_tcg_register(void) { monitor_register_hmp_info_hrt("jit", qmp_x_query_jit); - monitor_register_hmp_info_hrt("opcount", qmp_x_query_opcount); } =20 type_init(hmp_tcg_register); diff --git a/tests/qtest/qmp-cmd-test.c b/tests/qtest/qmp-cmd-test.c index 040d042810b..cf718761861 100644 --- a/tests/qtest/qmp-cmd-test.c +++ b/tests/qtest/qmp-cmd-test.c @@ -51,7 +51,6 @@ static int query_error_class(const char *cmd) { "x-query-usb", ERROR_CLASS_GENERIC_ERROR }, /* Only valid with accel=3Dtcg */ { "x-query-jit", ERROR_CLASS_GENERIC_ERROR }, - { "x-query-opcount", ERROR_CLASS_GENERIC_ERROR }, { "xen-event-list", ERROR_CLASS_GENERIC_ERROR }, { NULL, -1 } }; diff --git a/hmp-commands-info.hx b/hmp-commands-info.hx index 639a450ee51..d7979222752 100644 --- a/hmp-commands-info.hx +++ b/hmp-commands-info.hx @@ -256,20 +256,6 @@ SRST Show dynamic compiler info. ERST =20 -#if defined(CONFIG_TCG) - { - .name =3D "opcount", - .args_type =3D "", - .params =3D "", - .help =3D "show dynamic compiler opcode counters", - }, -#endif - -SRST - ``info opcount`` - Show dynamic compiler opcode counters -ERST - { .name =3D "sync-profile", .args_type =3D "mean:-m,no_coalesce:-n,max:i?", --=20 2.49.0 From nobody Sat Dec 13 22:54:06 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1751624192; cv=none; d=zohomail.com; s=zohoarc; b=kGDQXi9BnGdgzj7amukYCxH6e4r2USFL4KhNDJ8dR/MdS/uHeur/zlkX2mSqccdTtOGYmLENxmnInHyBuf6mG7W1bbjAqNIzOlgtOAWk2ImSh1+/RaRJ2ADNbHf8gbmGhlVCQ4ft+MKcKvT0wcWAjy4YSNo7QnXcesBFwQvaD98= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1751624192; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=4O4V3IVlY7U/ZO9G8RGp5YV8GTOAnuzXOdvv3mDiNZI=; b=ce84iRmAE7eQ9gP/ykKnyGQh4y/SciltMQ3SUlDCn5ITOvNpmG3AD39Da/1PYsCQeTv9v21tHLott32WnHTJMFtZQ0qKzZBIHkd1VorwS1CT10ZziCOv/b2Y0KuhJSlE4U6b3d4bozQgl6G3xRcrWLtUCxqItGhBdfann+LnTRw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1751624192193630.1507610778311; Fri, 4 Jul 2025 03:16:32 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uXdRj-00060Z-Rn; Fri, 04 Jul 2025 06:15:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uXdRh-0005zT-Oa for qemu-devel@nongnu.org; Fri, 04 Jul 2025 06:15:05 -0400 Received: from mail-wr1-x42d.google.com ([2a00:1450:4864:20::42d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uXdRe-0006Fj-D9 for qemu-devel@nongnu.org; Fri, 04 Jul 2025 06:15:05 -0400 Received: by mail-wr1-x42d.google.com with SMTP id ffacd0b85a97d-3a54700a46eso407440f8f.1 for ; Fri, 04 Jul 2025 03:15:01 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b4708d094csm2079828f8f.28.2025.07.04.03.14.58 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 04 Jul 2025 03:14:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1751624100; x=1752228900; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=4O4V3IVlY7U/ZO9G8RGp5YV8GTOAnuzXOdvv3mDiNZI=; b=UHUPQxO89zRlO1qU9GOijvaEMN1p3XGwLuBmE/S70EpU8Wgd8RZNMsnoXQZwSvG/bs 34ycb2rA5a4qHl3vd3qWKMuT6HuC4b7+piqFqfItAOzLQb/bYC7f4Ec24n7/z0+2vGVS ACFZK6RyKBEf4gsRn9hfReRPNJwC3/Ot6SLKvhCvDWX097Kxjaun+Vhoq6Usv0ljCSWa Ci6J/2rVDF4aDBXkWxTmsQwmo1N5UZRJDc8/+Jom4UY+pcq1GeHCJBDJURGyDFs3heey oDK0jfbJwPedwpLlnnsdcCO/GO0Po2Sv52WxV/xDj6CxZNMaHylTMmAt7ZRezw9oagnY 1aEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751624100; x=1752228900; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4O4V3IVlY7U/ZO9G8RGp5YV8GTOAnuzXOdvv3mDiNZI=; b=TGWKFczO3AGMnas4c5tTNvKY0/zh4VqsV1SnZOU0ycfdFsFTUSN7TJSXCQu9qaePaj 7RrmFxelcZVZ5io9sGZSlb22QwyHoL9R+w+nco/peYSvpoAeI9/N3a61ht6C71JF7HL6 TRXpUYOs7kVZQN0sUfcbVgpaBtndEbcMXc4spdPD7bxXIEIUNdREXLPQSpflyzj6BsZV 6Sg78ItVOPpALODVFWKzLQUuw85IOhHCCnZ2hYpJWaz4UwD9i7L0VUvUIMxFL94Omzy3 zk+0YhxJQ2EDEd/tBlLYsqRnC/O2j+yY4/u9pf3p1ruuRFAtA0l0xYf4VH45NNYBj3Ff 1duA== X-Gm-Message-State: AOJu0Yw8BxY2U4VIgLtvTg/XBSBSZZ1om9ECxFbEfd8IVbKJJVQeIg4L KmUlBLJO0Gr/V6+R5ClbusoXlTmM8dqqwQiVb7h8BhIuIlq8WjgOsPLhDYDm9bVwXsldWXnsPkJ 5ABmf84I= X-Gm-Gg: ASbGncsDIsnx1W5GzkkSHdzz3JOyjNipBH2z/hiQ9qiTN/hzLJPWTo3e30QR/SQQmLV xk4OwUE7x4DNwnw4wS8FQZ+Q+LXNXYy5uq/exh45bkIASTQppeRVNIcqa1IRrjJn3RJaW+lJ9Vr HH5TF62NnbBBGunnlcJCrKeU00UgLjZioJ/brq+yGAvPvhBoXVHwRCLhcBiQa/6OgLxj3ZGDGki yNVJ857q/c5LTk5+H3S3CD2NssiKOlngjRsfaXCsEtkOhjc1JvH6KZVFwuih1THZwmRHNnqYErW kyaTX3uv+4dghul6cS+8V2TRmCPGOn/SquCk6HsltDPcbHyAGjmmtk4YTLs2wdNkNuTeykESk+R wtC25wTcysyfTuHLH72dZiaBDqyVwsWKisJejtBnwXey8720= X-Google-Smtp-Source: AGHT+IHsHRBtRsJC9qzdmZvBDxQ1+PcCNmqPS8AP4VkTUH0d/m/bx+DCBrhyUNfNC7Mu1J1csYWq1Q== X-Received: by 2002:a05:6000:3111:b0:3a4:fc37:70e4 with SMTP id ffacd0b85a97d-3b4964fc7e9mr1721220f8f.58.1751624099571; Fri, 04 Jul 2025 03:14:59 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 05/31] accel/tcg: Remove profiler leftover Date: Fri, 4 Jul 2025 12:14:06 +0200 Message-ID: <20250704101433.8813-6-philmd@linaro.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250704101433.8813-1-philmd@linaro.org> References: <20250704101433.8813-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::42d; envelope-from=philmd@linaro.org; helo=mail-wr1-x42d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1751624193232116600 TCG profiler was removed in commit 1b65b4f54c7. Fixes: 1b65b4f54c7 ("accel/tcg: remove CONFIG_PROFILER") Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson Reviewed-by: Xiaoyao Li Reviewed-by: Zhao Liu Message-Id: <20250703173248.44995-9-philmd@linaro.org> --- accel/tcg/monitor.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/accel/tcg/monitor.c b/accel/tcg/monitor.c index 7c686226b21..344ec500473 100644 --- a/accel/tcg/monitor.c +++ b/accel/tcg/monitor.c @@ -141,11 +141,6 @@ static void tlb_flush_counts(size_t *pfull, size_t *pp= art, size_t *pelide) *pelide =3D elide; } =20 -static void tcg_dump_info(GString *buf) -{ - g_string_append_printf(buf, "[TCG profiler not compiled]\n"); -} - static void dump_exec_info(GString *buf) { struct tb_tree_stats tst =3D {}; @@ -196,7 +191,6 @@ static void dump_exec_info(GString *buf) g_string_append_printf(buf, "TLB full flushes %zu\n", flush_full); g_string_append_printf(buf, "TLB partial flushes %zu\n", flush_part); g_string_append_printf(buf, "TLB elided flushes %zu\n", flush_elide); - tcg_dump_info(buf); } =20 HumanReadableText *qmp_x_query_jit(Error **errp) --=20 2.49.0 From nobody Sat Dec 13 22:54:06 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1751624360; cv=none; d=zohomail.com; s=zohoarc; b=WmGxqd7D4JIfnwaxJK7tvEH6XmMb4TWIl/Rfj5iqRmgc8jey3J9V5lyimwEuvb4exDHPx7LzxLn72Je/PFmha+yCbxo9H0PEOL/qeC0GGnhDPIlb8QzVUXmj9LKb0XU0d6UQ04pGL4hbxacPl+G634249Kp0TaN5/gmLrzKzA1E= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1751624360; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=/bqUcP0GVFbZdYz0pOg29PIjT2vqEhewVl+kCu78NhM=; b=PPHKX/NJ+YnOKWvcJbu1rymYneNRA4aBcc2oa8BNJsAYIDSzWRjOsn6Oz1brsOoD5v24CKZDDbZrUMARftnu1ZIftEz0DfYROrAqXT9O54yx9QwK/JaBp7P1R+zBsTkOZ98MbR7PT+hjMglzEgCNryxnQ/lC3gRFRVEhAg3w+5I= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1751624360114577.7236868634981; Fri, 4 Jul 2025 03:19:20 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uXdRm-00062E-AG; Fri, 04 Jul 2025 06:15:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uXdRk-00060u-4z for qemu-devel@nongnu.org; Fri, 04 Jul 2025 06:15:08 -0400 Received: from mail-wr1-x42d.google.com ([2a00:1450:4864:20::42d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uXdRi-0006bS-9e for qemu-devel@nongnu.org; Fri, 04 Jul 2025 06:15:07 -0400 Received: by mail-wr1-x42d.google.com with SMTP id ffacd0b85a97d-3a57c8e247cso556502f8f.1 for ; Fri, 04 Jul 2025 03:15:05 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b471b968ebsm2077004f8f.47.2025.07.04.03.15.03 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 04 Jul 2025 03:15:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1751624104; x=1752228904; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=/bqUcP0GVFbZdYz0pOg29PIjT2vqEhewVl+kCu78NhM=; b=SR/BTxBKqo8OREH087+Q6Xo2damESwPeyvoMbHTNijfnsCbvJu2vmXEy2e8KtUNc21 5J80RggrzF62lCZjS+3t0RaDTXlGfgYF0nIaIW97jjZA4A49dasixh7x6+xxvtfOCMQN 80I1WSCMe1OjLtI5UCnDJb0wPaQKOaKdCGn/cmUcM838D4Q0b+FiYcdzN9DzgOKZRl9I bbZIkfcqOalZHXAqINT8dLu+z2ft4tCTK5rMfzGmo37kEeCuDpS2+olL/LUfjOScYcCW 2dnOqWoh9yXAERPrJK/5aCuyt70KXwdKshijPgTtLP4tO/syLlVgwyQ9fTceJ7R1nx4K Bfsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751624104; x=1752228904; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/bqUcP0GVFbZdYz0pOg29PIjT2vqEhewVl+kCu78NhM=; b=ct/2ha80ZmeZUJKjwgLoYZNPMosZEJgokCb/J3y2eo5WNV6pwpIN9ZA56obX8TZYQo Q0xX+VgXVS7C+aUbUoELIGUxqcHuMY5ecPumCqzwAAMX2uGDTFuKqEE48HMIc/RNJsN5 W7X1j1Zxy8lSzv61fd/D+32VRPhLOqr1Zs+jqZSyUQw4Hn0zwoNHIp0NSMR1mQ0B4mwr 7PTgF84xwG+XQE8WOIw2oWCcHKhN1P3GhMi+eKP7LoqYPxnK1W9frDFpnHor6VjufaeJ RgcI6v97ubq31doraMu++fhmFq+DcHMabv//LI4jPR1c7Q6rUvJJj6aqOrA0U7tuF/er 1GsQ== X-Gm-Message-State: AOJu0YxKOM5JB8x5sS6FZr1okhe3nPpXXHa+4Pd05AuZdnFCfp2g41nt rQDzyE/zizvS4m+wQZbyH7ZVGrhyScZSZNHtCOXCKiJfzBvSc7exf6y11z5Bbk6DT5rO2RuOWF8 V/npIGO4= X-Gm-Gg: ASbGncup8i2nP5rokSjHBicsueY/axpLGY+ACwKLRinRJH4L8l/kPVYX/bve8nl9hEB 6zLvqnxPeG2qbmGN0yVa8fR32xhVv8eTLV+4wUZjdiNmQ44zM5D7Obsw9hCS9KktQbU4JViGxzp sU7HHE7JZW9l07YjE2JCDOi4VZAL9+dIXWgFgVZG7Elh49kjsJxD7fSAKIVXCp7d2wuShQjYLBz mTmhsEMlKhKFIZsfH1ep/0KdY2Ht+9Cr2CbV/uQHN2R5JVCfMuMWNj4SsrVj7rLqd7v5Z1T3L25 sc5fguXdqKIF97B2gVQcqv24iF6WYJSY7vfdGPq0X0ula96kQFQWIDt8bfTG6ZzzZhrSuXhMfTI ZPDC4XiyMzgYPBHubTA0p7kV8RkKgfpPhixKMMoMGRY8mOB4= X-Google-Smtp-Source: AGHT+IHiafN3IWpLkHqEVFEliylHLlMrRUUSCAHl9rg1a4gpxh3Bm/bffoNyceSVT/WrlBT4J2UIwA== X-Received: by 2002:a05:6000:2011:b0:3a4:e480:b5df with SMTP id ffacd0b85a97d-3b497038f48mr1291588f8f.44.1751624104114; Fri, 04 Jul 2025 03:15:04 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 06/31] accel/tcg: Factor tcg_dump_flush_info() out Date: Fri, 4 Jul 2025 12:14:07 +0200 Message-ID: <20250704101433.8813-7-philmd@linaro.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250704101433.8813-1-philmd@linaro.org> References: <20250704101433.8813-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::42d; envelope-from=philmd@linaro.org; helo=mail-wr1-x42d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1751624361433116600 Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson Reviewed-by: Xiaoyao Li Reviewed-by: Zhao Liu Message-Id: <20250703173248.44995-10-philmd@linaro.org> --- accel/tcg/monitor.c | 27 +++++++++++++++++---------- 1 file changed, 17 insertions(+), 10 deletions(-) diff --git a/accel/tcg/monitor.c b/accel/tcg/monitor.c index 344ec500473..6d9cc11d94c 100644 --- a/accel/tcg/monitor.c +++ b/accel/tcg/monitor.c @@ -141,11 +141,26 @@ static void tlb_flush_counts(size_t *pfull, size_t *p= part, size_t *pelide) *pelide =3D elide; } =20 +static void tcg_dump_flush_info(GString *buf) +{ + size_t flush_full, flush_part, flush_elide; + + g_string_append_printf(buf, "TB flush count %u\n", + qatomic_read(&tb_ctx.tb_flush_count)); + g_string_append_printf(buf, "TB invalidate count %u\n", + qatomic_read(&tb_ctx.tb_phys_invalidate_count)); + + tlb_flush_counts(&flush_full, &flush_part, &flush_elide); + g_string_append_printf(buf, "TLB full flushes %zu\n", flush_full); + g_string_append_printf(buf, "TLB partial flushes %zu\n", flush_part); + g_string_append_printf(buf, "TLB elided flushes %zu\n", flush_elide); +} + static void dump_exec_info(GString *buf) { struct tb_tree_stats tst =3D {}; struct qht_stats hst; - size_t nb_tbs, flush_full, flush_part, flush_elide; + size_t nb_tbs; =20 tcg_tb_foreach(tb_tree_stats_iter, &tst); nb_tbs =3D tst.nb_tbs; @@ -182,15 +197,7 @@ static void dump_exec_info(GString *buf) qht_statistics_destroy(&hst); =20 g_string_append_printf(buf, "\nStatistics:\n"); - g_string_append_printf(buf, "TB flush count %u\n", - qatomic_read(&tb_ctx.tb_flush_count)); - g_string_append_printf(buf, "TB invalidate count %u\n", - qatomic_read(&tb_ctx.tb_phys_invalidate_count)); - - tlb_flush_counts(&flush_full, &flush_part, &flush_elide); - g_string_append_printf(buf, "TLB full flushes %zu\n", flush_full); - g_string_append_printf(buf, "TLB partial flushes %zu\n", flush_part); - g_string_append_printf(buf, "TLB elided flushes %zu\n", flush_elide); + tcg_dump_flush_info(buf); } =20 HumanReadableText *qmp_x_query_jit(Error **errp) --=20 2.49.0 From nobody Sat Dec 13 22:54:06 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1751624383; cv=none; d=zohomail.com; s=zohoarc; b=h1ii9ZJUkD6yOEGiD/FVzI/0PHB5xNX2UcJsRhrjd7h3y+f8KrwoJIeKXGHXB17Qjpt/5KxNfrWnUwPTX64T7GzSwCBePwLmfcMJImoJ3G46NlNu6cPMQvxctr/L010W2ZRfnckCRL/SeeJfWdj0Jvp/LAXSFZh7oBCNLKSG1rY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1751624383; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=o6bhqsFMFs7mcPHK86doFfOhErUfzngUDVxx9M5BYVo=; b=gqQ6cOtCb0C/Y1gbqCHVaHAqRJioJd7mFyPxHg/NwpuWljQd1Kz5oaByGJyZz+eNG/UUXW4IQ79j9mzk2gkrHwqRRMiiUoiEoqPLy6dhaHLfzauGZXY+TNDUvJB4JeKiKKCEimwDvqwaH4zB1flnagb1e+lVYyMImKCQQTi3U0E= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1751624383182868.1076211763002; Fri, 4 Jul 2025 03:19:43 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uXdRv-00066Y-KZ; Fri, 04 Jul 2025 06:15:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uXdRo-00064W-Oa for qemu-devel@nongnu.org; Fri, 04 Jul 2025 06:15:12 -0400 Received: from mail-wm1-x336.google.com ([2a00:1450:4864:20::336]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uXdRm-0006cZ-Os for qemu-devel@nongnu.org; Fri, 04 Jul 2025 06:15:12 -0400 Received: by mail-wm1-x336.google.com with SMTP id 5b1f17b1804b1-453066fad06so5177255e9.2 for ; Fri, 04 Jul 2025 03:15:10 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-454adc71aadsm39418505e9.25.2025.07.04.03.15.07 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 04 Jul 2025 03:15:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1751624109; x=1752228909; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=o6bhqsFMFs7mcPHK86doFfOhErUfzngUDVxx9M5BYVo=; b=KJTukJXFPns2BhaHHaD6SLOj32PiZ8x+ZiZ2yXGUdDYm/UUz3LYhpwzcdaUQajV8+A ZETRcvIY2ZlGUws84/vCqx0DHcVjgWa6WLXfHG4iyBx7jydmtCezz5o2k++iZlnBei76 +pZx6nEpbH000ABSiU9pwdFV3PGtiOiaE6oaGRnz07Tb5KBuQenT0ctG5HiBD/rDp5Kq Zj1lxSeIfLrOlRzCZnp3Ve+TfZut3WammpsVLjNazeUJeEFnuvk4Hpa72tGhnKLYAo9T qA7pTvUrqrkBZNyQD4BAXIwky84ViK4oE52UGZ5xraI/IOR0pzjtDCYZoPZdaCrmQ3Cp ZvqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751624109; x=1752228909; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=o6bhqsFMFs7mcPHK86doFfOhErUfzngUDVxx9M5BYVo=; b=VL7KyIlzVuWNR6i8Q73VQjuk3CkwRsIjVr6PBs/sBk4tNJN15s0eX95twDAQRuoO+A E7/fmir+1WmBNprjAjdhBYuSuZ3snoCbE3eTFQHk77xF9v4SkyLM2g3+YfZYDyDk10zB C2hj8/mGMyi+Z+q2Fy9yt321HNu4thlIDF2zsmKn3CA5VZF/Kc6LHxzhxhlJoZDBw/GZ iA0uDwNk3XQu3sqTR7yP26pylfa1nc+vHJxcz95F4Qagz1QlY3aKdygEr5UeoQe9KGc5 A68pGuLG+hqnwwxaTlL0vtHSDvrtwtGtdXFj8dvHSaEQA83aSnX+spBenJ5HWL1NQNt0 5Q5Q== X-Gm-Message-State: AOJu0Yzj74vjSf7Fjh/4iwMrhcbqltLsZbQJ/cE+EYQk3933T7uRnyyG SFlbQpF04fu7AX/4KgWtLTtoERY3kOzHy68C6w/47YsLAABZsuHrd2U25unt5ilYL+9m8LuwYJ3 TNYGGruI= X-Gm-Gg: ASbGncsgHWifdY2tAXwr6NrSm8Q+NHFj2BlJaN1UYlB/Pb9kvQlrIbyVDkfgsmpvrqP r7VUuSF2avbbRvmTp6zWsp6YowI+jB29YlRK/p+k5fTtkf+HNnt4S/UfSUDLXcb4k5NSDj1/2d8 2FHFNmeVQTq2/96UkFaGJXjgWw7SjNq0nh4DYsvdOHJVFWCcsA1g0qd4y2O3JmLh1bmqoShWQ9n W8WHplX3W2AhPyWc8FFsukzWaHbg+Tq1MPwWEKos8QzIGNZ8f/A+ZDsfGDoFz4qIuCv6wc+UL7Z jTwGYUw7zwu/TGSK7iESdtcdwHhZSiUJdli101b0nFZx0w2A5Liao8uFwt13A3pUmLl2xRkEQHL mXWTUELqkBB6Wc8xC/Ue7uJBr+r4A9167RBY6 X-Google-Smtp-Source: AGHT+IEENzCbIdg7CplaJct7Up06tSjJHrmqapkzmUFTTiK2sRR+WHLgxWxJCZgTGJiLmUP2yOnCdg== X-Received: by 2002:a05:600d:1a:b0:450:d00d:cc with SMTP id 5b1f17b1804b1-454b306c4c4mr16348295e9.2.1751624108585; Fri, 04 Jul 2025 03:15:08 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 07/31] accel/tcg: Factor tcg_dump_stats() out for re-use Date: Fri, 4 Jul 2025 12:14:08 +0200 Message-ID: <20250704101433.8813-8-philmd@linaro.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250704101433.8813-1-philmd@linaro.org> References: <20250704101433.8813-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::336; envelope-from=philmd@linaro.org; helo=mail-wm1-x336.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1751624385686116600 Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson Reviewed-by: Zhao Liu Message-Id: <20250703173248.44995-11-philmd@linaro.org> --- accel/tcg/internal-common.h | 2 ++ accel/tcg/monitor.c | 11 ++++++++--- 2 files changed, 10 insertions(+), 3 deletions(-) diff --git a/accel/tcg/internal-common.h b/accel/tcg/internal-common.h index 1dbc45dd955..77a3a0684a5 100644 --- a/accel/tcg/internal-common.h +++ b/accel/tcg/internal-common.h @@ -139,4 +139,6 @@ G_NORETURN void cpu_io_recompile(CPUState *cpu, uintptr= _t retaddr); void tb_phys_invalidate(TranslationBlock *tb, tb_page_addr_t page_addr); void tb_set_jmp_target(TranslationBlock *tb, int n, uintptr_t addr); =20 +void tcg_dump_stats(GString *buf); + #endif diff --git a/accel/tcg/monitor.c b/accel/tcg/monitor.c index 6d9cc11d94c..e7ed7281a4b 100644 --- a/accel/tcg/monitor.c +++ b/accel/tcg/monitor.c @@ -200,6 +200,13 @@ static void dump_exec_info(GString *buf) tcg_dump_flush_info(buf); } =20 +void tcg_dump_stats(GString *buf) +{ + dump_accel_info(buf); + dump_exec_info(buf); + dump_drift_info(buf); +} + HumanReadableText *qmp_x_query_jit(Error **errp) { g_autoptr(GString) buf =3D g_string_new(""); @@ -209,9 +216,7 @@ HumanReadableText *qmp_x_query_jit(Error **errp) return NULL; } =20 - dump_accel_info(buf); - dump_exec_info(buf); - dump_drift_info(buf); + tcg_dump_stats(buf); =20 return human_readable_text_from_str(buf); } --=20 2.49.0 From nobody Sat Dec 13 22:54:06 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1751624394; cv=none; d=zohomail.com; s=zohoarc; b=W75n9I4Em/lrpqP67fjsiB1fDvag6YZhloDFSFFvDW7ircl/NzYlaKDV7sVdY0lQRhPtQB9oqFGFrghJ4wTn3TDo1lZZh/R/zz1tXTIre5Yn0jjfYl8MWtl7GP0zVLUfJ4eJCFOgXrt4lKVFLOqsD4U8Uo1wNQ+6MknJq8oKqJU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1751624394; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=VLdxvBumjozr6AaX1LMKeVrCwgZ9kkvv1MIJjkhu7gw=; b=nuafxojVEaflAOk+EUwebekMPdS0J9q/GLZ2piuiPlKf3UaYL4GhtkRQPJnpvGya7lvIfinY3roTD0ZXbboia2zkp26x96+7O084VMBBhV3/PGoUcxIl/Bt54sTtjURM62PvyPTs8CrlMi9pVEmUpKffbJX2S6jJoQ3fWcJM7Tg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1751624394148521.8961960305699; Fri, 4 Jul 2025 03:19:54 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uXdRy-0006By-9F; Fri, 04 Jul 2025 06:15:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uXdRw-000683-0t for qemu-devel@nongnu.org; Fri, 04 Jul 2025 06:15:20 -0400 Received: from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uXdRr-0006db-QR for qemu-devel@nongnu.org; Fri, 04 Jul 2025 06:15:17 -0400 Received: by mail-wm1-x32e.google.com with SMTP id 5b1f17b1804b1-451d54214adso4993035e9.3 for ; Fri, 04 Jul 2025 03:15:14 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-454b1695577sm22359315e9.27.2025.07.04.03.15.12 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 04 Jul 2025 03:15:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1751624113; x=1752228913; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=VLdxvBumjozr6AaX1LMKeVrCwgZ9kkvv1MIJjkhu7gw=; b=UliwEVu2iH6fMFNPE+dGUvZd8o8jlPdK7KqC69OA7ufYk4z4LOAt53HKy/ZNFcqLw2 Db4Rxak0ZW57mWj9CJDPZ/myY/b1h2tIUxQI0bYAAJoK0NvNDaTwaBnmuZ8QuQXCUM3X Y77elkIPsmMYAjGHfJUT5FRIp7d1Q+P7vTfTT5qcutj03S5Ph/bPS5yBZSQaoJ6yixzM N34MzkMm95gmvqHxkqxyBDszR91J0qaF5mQsj+vHQe/LxJLTQa65Vnpo2NXXLX2nwGBu +3ct++djo/BJuyhQQ3pQOHOQ7YwLH8sZulWngC23UKeKHJctIUCnDLV50qPgG7OwTD9d ab3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751624113; x=1752228913; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VLdxvBumjozr6AaX1LMKeVrCwgZ9kkvv1MIJjkhu7gw=; b=LfN5Aatv3sEgD/YylHw7b+KCl3m/7DmiyraX3J5Y2+kPcwvaPsv5teLny1qwi8CnRd NdnRvdH8JJ3UzNsIgHj7MjRJrHUgLEREgcfXWwA3InNIhNnS4Qo8N31cVVxqTiDYO+lE PSpDoZaTFlocDKg8+Bo3CGtyrYWXQwfkRE6d2OIbnWiZ2uBXY7VQrk+CIytpweACZutk eZvouD71YcCzi8mnb+5WEka6bnPQN1l8BmyY5NhWJOtfOFOIYocqtzYdkxez/lga+KjW OPFCdHy2PUyvJDTknOiRX/7gZ26A01h4lzp0Vup5rRE4schgkEZQ+zScA10AqqwjkfPb MTvw== X-Gm-Message-State: AOJu0Yygo+pcHG1adZ9sqF9AMq+kJTv8BUbSoWtKc5gVViEismiyKvsZ Fgz3VAjNSvNDdM/mAWH1+n41gHLYCSprxookw3Bh+ibjN6QFQkq1Afskj7IS+Wph+dK8BJj3jLL 2+EYmOeM= X-Gm-Gg: ASbGncsOy4boHrrUBGZ8GaxKJEdLFRh6nRSsx8f7rx6fB8T1vJfMPRatctb+jm3urkZ LXViuh/c8Iycq/67KEBMbcmW7b9U9lNK4t9yZYj+YFEZuVJeNyJ73CCpCK2xXn6hUSFtPcxYWLB uD5w6IyohywsBgRlpDwwM5nB5l8C30KKu4oVMJpjiNgi7Jhl9TSiWDrcJfFBRmmJKH+KxQvkxbl guLdI4pi7S4wd98d9+kYYrMqBXlh7d00eZjoeePymPiHj3r6hDSKy7Wz8PFzN4/y5GIog++OHzk JZJnsUdng+ufFRi2gXEVBb8vIT6LS4UV2kz+sZdIk/olj/IwP/LjA3qN/qb4FHLJxSwdHF6wtig R2qb6o5alBSQ9skNsf40PAcS47a0ZuPLdXQPlIHTvLnAYomg= X-Google-Smtp-Source: AGHT+IFY/oMcoCkngkbc2pXXcV1O5nES63mgCHkFSqX3Obiii3KFGcQH/3cYI1Uq/xN+ri4HFI3Stw== X-Received: by 2002:a05:600d:16:b0:450:d00d:d0 with SMTP id 5b1f17b1804b1-454b3ab5cefmr12197045e9.19.1751624113201; Fri, 04 Jul 2025 03:15:13 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 08/31] accel/hvf: Restrict internal declarations Date: Fri, 4 Jul 2025 12:14:09 +0200 Message-ID: <20250704101433.8813-9-philmd@linaro.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250704101433.8813-1-philmd@linaro.org> References: <20250704101433.8813-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32e; envelope-from=philmd@linaro.org; helo=mail-wm1-x32e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1751624395884116600 Common code only needs to know whether HVF is enabled and the QOM type. Move the rest to "hvf_int.h", removing the need for COMPILING_PER_TARGET #ifdef'ry. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson Reviewed-by: Xiaoyao Li Reviewed-by: Zhao Liu Message-Id: <20250703173248.44995-15-philmd@linaro.org> --- include/system/hvf.h | 38 -------------------------------------- include/system/hvf_int.h | 34 ++++++++++++++++++++++++++++++++++ 2 files changed, 34 insertions(+), 38 deletions(-) diff --git a/include/system/hvf.h b/include/system/hvf.h index a9a502f0c8f..d3dcf088b3f 100644 --- a/include/system/hvf.h +++ b/include/system/hvf.h @@ -14,10 +14,6 @@ #define HVF_H =20 #include "qemu/accel.h" -#include "qemu/queue.h" -#include "exec/vaddr.h" -#include "qom/object.h" -#include "exec/vaddr.h" =20 #ifdef COMPILING_PER_TARGET # ifdef CONFIG_HVF @@ -40,38 +36,4 @@ typedef struct HVFState HVFState; DECLARE_INSTANCE_CHECKER(HVFState, HVF_STATE, TYPE_HVF_ACCEL) =20 -#ifdef COMPILING_PER_TARGET -struct hvf_sw_breakpoint { - vaddr pc; - vaddr saved_insn; - int use_count; - QTAILQ_ENTRY(hvf_sw_breakpoint) entry; -}; - -struct hvf_sw_breakpoint *hvf_find_sw_breakpoint(CPUState *cpu, - vaddr pc); -int hvf_sw_breakpoints_active(CPUState *cpu); - -int hvf_arch_insert_sw_breakpoint(CPUState *cpu, struct hvf_sw_breakpoint = *bp); -int hvf_arch_remove_sw_breakpoint(CPUState *cpu, struct hvf_sw_breakpoint = *bp); -int hvf_arch_insert_hw_breakpoint(vaddr addr, vaddr len, int type); -int hvf_arch_remove_hw_breakpoint(vaddr addr, vaddr len, int type); -void hvf_arch_remove_all_hw_breakpoints(void); - -/* - * hvf_update_guest_debug: - * @cs: CPUState for the CPU to update - * - * Update guest to enable or disable debugging. Per-arch specifics will be - * handled by calling down to hvf_arch_update_guest_debug. - */ -int hvf_update_guest_debug(CPUState *cpu); -void hvf_arch_update_guest_debug(CPUState *cpu); - -/* - * Return whether the guest supports debugging. - */ -bool hvf_arch_supports_guest_debug(void); -#endif /* COMPILING_PER_TARGET */ - #endif diff --git a/include/system/hvf_int.h b/include/system/hvf_int.h index d774e58df91..4f6db40c34e 100644 --- a/include/system/hvf_int.h +++ b/include/system/hvf_int.h @@ -12,6 +12,8 @@ #define HVF_INT_H =20 #include "qemu/queue.h" +#include "exec/vaddr.h" +#include "qom/object.h" =20 #ifdef __aarch64__ #include @@ -77,4 +79,36 @@ int hvf_put_registers(CPUState *); int hvf_get_registers(CPUState *); void hvf_kick_vcpu_thread(CPUState *cpu); =20 +struct hvf_sw_breakpoint { + vaddr pc; + vaddr saved_insn; + int use_count; + QTAILQ_ENTRY(hvf_sw_breakpoint) entry; +}; + +struct hvf_sw_breakpoint *hvf_find_sw_breakpoint(CPUState *cpu, + vaddr pc); +int hvf_sw_breakpoints_active(CPUState *cpu); + +int hvf_arch_insert_sw_breakpoint(CPUState *cpu, struct hvf_sw_breakpoint = *bp); +int hvf_arch_remove_sw_breakpoint(CPUState *cpu, struct hvf_sw_breakpoint = *bp); +int hvf_arch_insert_hw_breakpoint(vaddr addr, vaddr len, int type); +int hvf_arch_remove_hw_breakpoint(vaddr addr, vaddr len, int type); +void hvf_arch_remove_all_hw_breakpoints(void); + +/* + * hvf_update_guest_debug: + * @cs: CPUState for the CPU to update + * + * Update guest to enable or disable debugging. Per-arch specifics will be + * handled by calling down to hvf_arch_update_guest_debug. + */ +int hvf_update_guest_debug(CPUState *cpu); +void hvf_arch_update_guest_debug(CPUState *cpu); + +/* + * Return whether the guest supports debugging. + */ +bool hvf_arch_supports_guest_debug(void); + #endif --=20 2.49.0 From nobody Sat Dec 13 22:54:06 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1751624243; cv=none; d=zohomail.com; s=zohoarc; b=YAzhWwJOSmITe5tUSDRvKVj1wLxRrvz0rz0rd4hNNmq7joxcN0aNwiaGaSbO11ty1sob4TALRr6emtcy05I8TWEs1VP3QfO1/3D6hRgzzjemQGoU3iB97C1YjuvsF+xrc7ql4eS5SJi1AOlomg12zgBysgFZwnyiMWPneeCMyOw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1751624243; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=lpXNsihVON/k8tGrpfoVi+AOpyOW8UHr4r65X+dnp3c=; b=PTK9bQ0PbS7pGO/PAwMHP3+aBq+h8iskozaafiyL8XA+E5My4Ft+6YQ2VkLz82fyxKcjMzVb/QqHZXyD5DT1Hkg2+XbtL/Psooc/LBqZ23JOjJ+fe8ReaEKO939EJ0IuTMCpvIYl2YQxOsVw9qPNEqbMQoH3ORxWXo3wx2p56Ss= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1751624243787234.71247037457442; Fri, 4 Jul 2025 03:17:23 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uXdS0-0006CW-9y; Fri, 04 Jul 2025 06:15:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uXdRy-0006C4-Fn for qemu-devel@nongnu.org; Fri, 04 Jul 2025 06:15:22 -0400 Received: from mail-wr1-x42e.google.com ([2a00:1450:4864:20::42e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uXdRw-0006eX-9x for qemu-devel@nongnu.org; Fri, 04 Jul 2025 06:15:22 -0400 Received: by mail-wr1-x42e.google.com with SMTP id ffacd0b85a97d-3a50fc7ac4dso317624f8f.0 for ; Fri, 04 Jul 2025 03:15:19 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b471b9651dsm2137625f8f.65.2025.07.04.03.15.17 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 04 Jul 2025 03:15:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1751624118; x=1752228918; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=lpXNsihVON/k8tGrpfoVi+AOpyOW8UHr4r65X+dnp3c=; b=NBUd/qFR3FsDIMFp+yZUJehJigiwCXB3ifCnhPpMlD+zuMDJYOI5Gj+0FCn7jFQCmN oNGfrHA6d5kQBtr6/IUi1ns8i+P+vfgtOkRcX9v94T70uVDKH1NU3cFnHEl/ugBnXhP/ s/U1XrXr1tpDvsUN4Hv+q3aWuKSBu07SLW1hvdwG5ZoDlMaL72GLLRtl9izERVkxUczY AV0RbQoKpLPEVKkL9HJGvTvElBgmmnk7Cmw3+lNV4jDsQCmUWfiwr2R5Z2Espjg5dWIJ IXFLkry2iJcBI8Zuo/ajZFk3G5TakoE/oO087q4bU7tt1WgWjqbqAa0OxHN4aZVJ2wBa cmHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751624118; x=1752228918; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lpXNsihVON/k8tGrpfoVi+AOpyOW8UHr4r65X+dnp3c=; b=DjU9LitTDF//drKD3cT2/+z1o+uEOPSNPFDJTfxw8/gulyCEoTXGs/GwAS4SChlMfy U8q0qF6S6mXbOR79iT2pO7L7TK8ZXr96gDuAuXaa8rDjABzR45DH45+tPzdAAXJx+Wvq ygbN4Csj/5v+fe4/iAaWfn/uZW8g0vvKInLn0ah57J5Jh8v2u0GAdUQWWUmHqLYm8gal XAd65O5gBQO19u8z2QPi4OW384hAkoBuy/UxcSRlNRVfuVRByiq9UNv5sB8Iv0cxbft7 LHDjP9phYH8Ej9GNPY+AESRY1Bd75nbGGMYPLC2mDg2gERx6g039+5pTaXq5gvZqxtzN MQqw== X-Gm-Message-State: AOJu0YylOj5G7lEmmvwfIBIzTmzwnKLYIBOGpy1D5fqIuWrl70O3evNC zmn/HJSqz/ooJ+TcyDqHGsoeX8VfuNQWtANtVdWCtRrwk+IefGtF1txcJy6KDxaijeMFXHCg42I JSkvAxXc= X-Gm-Gg: ASbGncu+G/0j6gpPaL6Io52ZNY08ZeudTuAGpWsUpdi6yvETv8hOQmvPI3OIQp/Yeor f/Du2FvkEBKzfXzJKIum3JZIL8qgXa8/Rur81BvFiDLeG7H3k2lr80zmdzej8SOm41CFiZhaTmc dfVWRQ7jA0E5y9HfGMi7cIaPP9F6AxTHTKbUoRxC9tlLOBsXatDf90DgQ3zUL/krwvRnwhasYnF 4LMzzy5wLEVLOtFxOp9EKBxgKAYf2q8kpwYOcB02gL+imKZwU+boLyVWAykqpfyp19Lu2dl9dNi USjUb+fQQFArRRJ5r8vy7UcemS3PEG0NyQWl3Uxqd+hbl919u0CGq1/r8vx4ID4zg9AdEwxnubs nQ0YLwNU4Km3JWS3UG3qpIUnwWx7qBvw4SKIzzkmJ5HeYy9s= X-Google-Smtp-Source: AGHT+IFW8PcE+ytQMFksvWx3usGvuQlPGWsEou9ztQMS6C7KJn806k0d7GXx6o2QXVdCCw8ag2wJng== X-Received: by 2002:a05:6000:240c:b0:3b3:9cc4:6830 with SMTP id ffacd0b85a97d-3b4964f7c5fmr1806562f8f.48.1751624117876; Fri, 04 Jul 2025 03:15:17 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 09/31] accel/hvf: Move per-cpu method declarations to hvf-accel-ops.c Date: Fri, 4 Jul 2025 12:14:10 +0200 Message-ID: <20250704101433.8813-10-philmd@linaro.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250704101433.8813-1-philmd@linaro.org> References: <20250704101433.8813-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::42e; envelope-from=philmd@linaro.org; helo=mail-wr1-x42e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1751624245915116600 hvf-all.c aims to contain the generic accel methods (TYPE_ACCEL), while hvf-accel-ops.c the per-vcpu methods (TYPE_ACCEL_OPS). Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson Reviewed-by: Zhao Liu Message-Id: <20250703173248.44995-16-philmd@linaro.org> --- accel/hvf/hvf-accel-ops.c | 30 ++++++++++++++++++++++++++++++ accel/hvf/hvf-all.c | 28 ---------------------------- 2 files changed, 30 insertions(+), 28 deletions(-) diff --git a/accel/hvf/hvf-accel-ops.c b/accel/hvf/hvf-accel-ops.c index b38977207d2..3752334688b 100644 --- a/accel/hvf/hvf-accel-ops.c +++ b/accel/hvf/hvf-accel-ops.c @@ -50,9 +50,11 @@ #include "qemu/osdep.h" #include "qemu/error-report.h" #include "qemu/main-loop.h" +#include "qemu/queue.h" #include "system/address-spaces.h" #include "gdbstub/enums.h" #include "hw/boards.h" +#include "hw/core/cpu.h" #include "system/accel-ops.h" #include "system/cpus.h" #include "system/hvf.h" @@ -482,6 +484,34 @@ static void hvf_start_vcpu_thread(CPUState *cpu) cpu, QEMU_THREAD_JOINABLE); } =20 +struct hvf_sw_breakpoint *hvf_find_sw_breakpoint(CPUState *cpu, vaddr pc) +{ + struct hvf_sw_breakpoint *bp; + + QTAILQ_FOREACH(bp, &hvf_state->hvf_sw_breakpoints, entry) { + if (bp->pc =3D=3D pc) { + return bp; + } + } + return NULL; +} + +int hvf_sw_breakpoints_active(CPUState *cpu) +{ + return !QTAILQ_EMPTY(&hvf_state->hvf_sw_breakpoints); +} + +static void do_hvf_update_guest_debug(CPUState *cpu, run_on_cpu_data arg) +{ + hvf_arch_update_guest_debug(cpu); +} + +int hvf_update_guest_debug(CPUState *cpu) +{ + run_on_cpu(cpu, do_hvf_update_guest_debug, RUN_ON_CPU_NULL); + return 0; +} + static int hvf_insert_breakpoint(CPUState *cpu, int type, vaddr addr, vadd= r len) { struct hvf_sw_breakpoint *bp; diff --git a/accel/hvf/hvf-all.c b/accel/hvf/hvf-all.c index 8c387fda24d..1c72c43ddb4 100644 --- a/accel/hvf/hvf-all.c +++ b/accel/hvf/hvf-all.c @@ -41,31 +41,3 @@ void assert_hvf_ok_impl(hv_return_t ret, const char *fil= e, unsigned int line, =20 abort(); } - -struct hvf_sw_breakpoint *hvf_find_sw_breakpoint(CPUState *cpu, vaddr pc) -{ - struct hvf_sw_breakpoint *bp; - - QTAILQ_FOREACH(bp, &hvf_state->hvf_sw_breakpoints, entry) { - if (bp->pc =3D=3D pc) { - return bp; - } - } - return NULL; -} - -int hvf_sw_breakpoints_active(CPUState *cpu) -{ - return !QTAILQ_EMPTY(&hvf_state->hvf_sw_breakpoints); -} - -static void do_hvf_update_guest_debug(CPUState *cpu, run_on_cpu_data arg) -{ - hvf_arch_update_guest_debug(cpu); -} - -int hvf_update_guest_debug(CPUState *cpu) -{ - run_on_cpu(cpu, do_hvf_update_guest_debug, RUN_ON_CPU_NULL); - return 0; -} --=20 2.49.0 From nobody Sat Dec 13 22:54:06 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1751624357; cv=none; d=zohomail.com; s=zohoarc; b=a2Fx6HDMp76g7IzbrTQn0K0n3VxU8OnQUrkI7pqEsCu5F/2FvsOY3U1FQB8/w+L/a0eMLA1PZHqhOaTbmsVHrMl2//29UtuBfHNKcHX7vzfQ5WKn5EUWtqdSJSWkK3hIJSMa7rLxp/sPCSjCxH1tVj9e5qjUz7a4KRGyXDJuP/4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1751624357; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=IXkfdD9TUd+4AfH72kU5It9cVyo8SKVvdnuAYEy/qHo=; b=hKJZLNXoGUAa9USiKSPBuPclanbPCtplx5b2Fo0oPly0XEvWT67/jzRmfv39DhJzOW76RlWGzD1NYRP9LLURbn0giYKuO9RkLzlCNoSaKozwF5JuGE6CdskIjuSxF9H8524m8PmgH4LH5Q7jgjiP56McyhHNoyyCZFZ4bq96JVY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1751624357457581.8836027609058; Fri, 4 Jul 2025 03:19:17 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uXdSA-0006DV-FY; Fri, 04 Jul 2025 06:15:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uXdS4-0006D4-Bs for qemu-devel@nongnu.org; Fri, 04 Jul 2025 06:15:29 -0400 Received: from mail-wr1-x434.google.com ([2a00:1450:4864:20::434]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uXdS1-0006fR-H6 for qemu-devel@nongnu.org; Fri, 04 Jul 2025 06:15:27 -0400 Received: by mail-wr1-x434.google.com with SMTP id ffacd0b85a97d-3a51481a598so389700f8f.3 for ; Fri, 04 Jul 2025 03:15:25 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b471b97f10sm2130940f8f.57.2025.07.04.03.15.21 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 04 Jul 2025 03:15:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1751624123; x=1752228923; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=IXkfdD9TUd+4AfH72kU5It9cVyo8SKVvdnuAYEy/qHo=; b=hEy5eyq+mPnpskkefVvxhV95ao7LOgGrD3xCkZ4CqT/yo1cXgc1vLHyU/MK0OywG2F 2zNpdUNjSOgD86g6qOlThvcJ5YSExp5qrcujPzwAtow3hEGXWVB1Z7pEUhP4Tz3x7YXP 2gGLcFGmISw4hcLDIAJOZ0UjkKe2b/q7SHG7YgT6gj6IN2CkXKv3YAI+bnpqSzzkDBRP 6R9cPdCxHfiR0CUbEwV357wir70zQ1MnHC2X17raA8694TpiubepBLNXynA+/ROMAqfZ 9lkmi0LzQSzYpUTBbZrg18qIgXP4uC3nbEKx9UjzHYp0y6UKBCngxyPI8vho1sTkVIqu QP2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751624123; x=1752228923; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=IXkfdD9TUd+4AfH72kU5It9cVyo8SKVvdnuAYEy/qHo=; b=JOpTdA9m1C+d7LxP9K+VaqoCo8xHIKw7SgVd0ahirun4EDgEI297zSrF3Kbt8hobUz FeNE4MvHeI2Ao0pPDbn/z5DZGbsbpHFkE2gnqw7Cbq3YezndAVJmOqWt7fhdMvnwv/oW q6rPH32JCwMBwbhxpuGdHArEEBw5//PffCr9SJAsNGTiTDju7QXC2XNT+5+yD7h4XeUn c4dqxD/MExbn/zQmPLG+3citUOgp6BeE2Cf61Qzhzd8sZ24mkB1NRxb3vnLGqXX7FTbD EqebFpJEMbhSmtH4HWhiaNYaQG28cjs7J3O0rPSXGYC2dvPQbsNxYywE2g+htH75wEi2 LEpg== X-Gm-Message-State: AOJu0Yzpkdwv8dcYaZ2BrAGTU/+dqNfNOvDKcX84Wk1wLqbIQrmc0RKI AtnwzZ/Mkp4juUsADo/qUmVx7R+vhEZUftcuH3dBdeYFy70CrAMKDRwwb7u5PmWt8PqCdnyOkyQ F1/z65n0= X-Gm-Gg: ASbGncv8e6PiwPZZt2GPaFB/L8LRqwTc3YlxlYah7sYmCPZmw/T9IXplUJN/rFaFGOC yfLAUJx0PU+bwMtt/w7ifK7fe0gjl5wT2TaKzmOpJkVNG8LkJIh5XvuQAuaoGOJrw3XmS7mXNUn 1m7hDltdClX5ZoH4/Kx5yCH+gyrE9dUCZ8pX2mo3T6fU7Crna6jUojcuqfUcT9Hq0gMoJiLKR2G d/9lTaKHRsW+cEws7I1LhSZhuqP+/WZLfR1neXrUfx+Smw9KB0Zkvf5khGTUeeQaFZ2hm6YDrSs Ad/x6woGqH/nubfykvkQoANZi0/9jSXXOlxe773gQVTYyzcsIbXQam9gsh/FJfqaiysbK9egbH3 YL2Mez3SEzej4lMAuiDg/xyUyMfO+GIuDwwdB X-Google-Smtp-Source: AGHT+IEvga4MUMWI//f63QiPtCRwIkkXmLRDaO+uZ4qA7V/17FyKDbAFLJWWaIVOehh6tEAawgvnSg== X-Received: by 2002:a05:6000:1789:b0:3a4:d0fe:42b2 with SMTP id ffacd0b85a97d-3b49701f78dmr1065371f8f.19.1751624122550; Fri, 04 Jul 2025 03:15:22 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 10/31] accel/hvf: Move generic method declarations to hvf-all.c Date: Fri, 4 Jul 2025 12:14:11 +0200 Message-ID: <20250704101433.8813-11-philmd@linaro.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250704101433.8813-1-philmd@linaro.org> References: <20250704101433.8813-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::434; envelope-from=philmd@linaro.org; helo=mail-wr1-x434.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1751624359841116600 hvf-all.c aims to contain the generic accel methods (TYPE_ACCEL), while hvf-accel-ops.c the per-vcpu methods (TYPE_ACCEL_OPS). Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson Reviewed-by: Zhao Liu Message-Id: <20250703173248.44995-17-philmd@linaro.org> --- accel/hvf/hvf-accel-ops.c | 273 +------------------------------------- accel/hvf/hvf-all.c | 267 +++++++++++++++++++++++++++++++++++++ 2 files changed, 271 insertions(+), 269 deletions(-) diff --git a/accel/hvf/hvf-accel-ops.c b/accel/hvf/hvf-accel-ops.c index 3752334688b..2c0715a17f7 100644 --- a/accel/hvf/hvf-accel-ops.c +++ b/accel/hvf/hvf-accel-ops.c @@ -48,20 +48,16 @@ */ =20 #include "qemu/osdep.h" -#include "qemu/error-report.h" +#include "qemu/guest-random.h" #include "qemu/main-loop.h" #include "qemu/queue.h" -#include "system/address-spaces.h" #include "gdbstub/enums.h" -#include "hw/boards.h" +#include "exec/cpu-common.h" #include "hw/core/cpu.h" #include "system/accel-ops.h" #include "system/cpus.h" #include "system/hvf.h" #include "system/hvf_int.h" -#include "system/runstate.h" -#include "qemu/guest-random.h" -#include "trace.h" =20 HVFState *hvf_state; =20 @@ -81,132 +77,6 @@ hvf_slot *hvf_find_overlap_slot(uint64_t start, uint64_= t size) return NULL; } =20 -struct mac_slot { - int present; - uint64_t size; - uint64_t gpa_start; - uint64_t gva; -}; - -struct mac_slot mac_slots[32]; - -static int do_hvf_set_memory(hvf_slot *slot, hv_memory_flags_t flags) -{ - struct mac_slot *macslot; - hv_return_t ret; - - macslot =3D &mac_slots[slot->slot_id]; - - if (macslot->present) { - if (macslot->size !=3D slot->size) { - macslot->present =3D 0; - trace_hvf_vm_unmap(macslot->gpa_start, macslot->size); - ret =3D hv_vm_unmap(macslot->gpa_start, macslot->size); - assert_hvf_ok(ret); - } - } - - if (!slot->size) { - return 0; - } - - macslot->present =3D 1; - macslot->gpa_start =3D slot->start; - macslot->size =3D slot->size; - trace_hvf_vm_map(slot->start, slot->size, slot->mem, flags, - flags & HV_MEMORY_READ ? 'R' : '-', - flags & HV_MEMORY_WRITE ? 'W' : '-', - flags & HV_MEMORY_EXEC ? 'E' : '-'); - ret =3D hv_vm_map(slot->mem, slot->start, slot->size, flags); - assert_hvf_ok(ret); - return 0; -} - -static void hvf_set_phys_mem(MemoryRegionSection *section, bool add) -{ - hvf_slot *mem; - MemoryRegion *area =3D section->mr; - bool writable =3D !area->readonly && !area->rom_device; - hv_memory_flags_t flags; - uint64_t page_size =3D qemu_real_host_page_size(); - - if (!memory_region_is_ram(area)) { - if (writable) { - return; - } else if (!memory_region_is_romd(area)) { - /* - * If the memory device is not in romd_mode, then we actually = want - * to remove the hvf memory slot so all accesses will trap. - */ - add =3D false; - } - } - - if (!QEMU_IS_ALIGNED(int128_get64(section->size), page_size) || - !QEMU_IS_ALIGNED(section->offset_within_address_space, page_size))= { - /* Not page aligned, so we can not map as RAM */ - add =3D false; - } - - mem =3D hvf_find_overlap_slot( - section->offset_within_address_space, - int128_get64(section->size)); - - if (mem && add) { - if (mem->size =3D=3D int128_get64(section->size) && - mem->start =3D=3D section->offset_within_address_space && - mem->mem =3D=3D (memory_region_get_ram_ptr(area) + - section->offset_within_region)) { - return; /* Same region was attempted to register, go away. */ - } - } - - /* Region needs to be reset. set the size to 0 and remap it. */ - if (mem) { - mem->size =3D 0; - if (do_hvf_set_memory(mem, 0)) { - error_report("Failed to reset overlapping slot"); - abort(); - } - } - - if (!add) { - return; - } - - if (area->readonly || - (!memory_region_is_ram(area) && memory_region_is_romd(area))) { - flags =3D HV_MEMORY_READ | HV_MEMORY_EXEC; - } else { - flags =3D HV_MEMORY_READ | HV_MEMORY_WRITE | HV_MEMORY_EXEC; - } - - /* Now make a new slot. */ - int x; - - for (x =3D 0; x < hvf_state->num_slots; ++x) { - mem =3D &hvf_state->slots[x]; - if (!mem->size) { - break; - } - } - - if (x =3D=3D hvf_state->num_slots) { - error_report("No free slots"); - abort(); - } - - mem->size =3D int128_get64(section->size); - mem->mem =3D memory_region_get_ram_ptr(area) + section->offset_within_= region; - mem->start =3D section->offset_within_address_space; - mem->region =3D area; - - if (do_hvf_set_memory(mem, flags)) { - error_report("Error registering new memory slot"); - abort(); - } -} - static void do_hvf_cpu_synchronize_state(CPUState *cpu, run_on_cpu_data ar= g) { if (!cpu->accel->dirty) { @@ -244,147 +114,10 @@ static void hvf_cpu_synchronize_pre_loadvm(CPUState = *cpu) run_on_cpu(cpu, do_hvf_cpu_synchronize_set_dirty, RUN_ON_CPU_NULL); } =20 -static void hvf_set_dirty_tracking(MemoryRegionSection *section, bool on) -{ - hvf_slot *slot; - - slot =3D hvf_find_overlap_slot( - section->offset_within_address_space, - int128_get64(section->size)); - - /* protect region against writes; begin tracking it */ - if (on) { - slot->flags |=3D HVF_SLOT_LOG; - hv_vm_protect((uintptr_t)slot->start, (size_t)slot->size, - HV_MEMORY_READ | HV_MEMORY_EXEC); - /* stop tracking region*/ - } else { - slot->flags &=3D ~HVF_SLOT_LOG; - hv_vm_protect((uintptr_t)slot->start, (size_t)slot->size, - HV_MEMORY_READ | HV_MEMORY_WRITE | HV_MEMORY_EXEC); - } -} - -static void hvf_log_start(MemoryListener *listener, - MemoryRegionSection *section, int old, int new) -{ - if (old !=3D 0) { - return; - } - - hvf_set_dirty_tracking(section, 1); -} - -static void hvf_log_stop(MemoryListener *listener, - MemoryRegionSection *section, int old, int new) -{ - if (new !=3D 0) { - return; - } - - hvf_set_dirty_tracking(section, 0); -} - -static void hvf_log_sync(MemoryListener *listener, - MemoryRegionSection *section) -{ - /* - * sync of dirty pages is handled elsewhere; just make sure we keep - * tracking the region. - */ - hvf_set_dirty_tracking(section, 1); -} - -static void hvf_region_add(MemoryListener *listener, - MemoryRegionSection *section) -{ - hvf_set_phys_mem(section, true); -} - -static void hvf_region_del(MemoryListener *listener, - MemoryRegionSection *section) -{ - hvf_set_phys_mem(section, false); -} - -static MemoryListener hvf_memory_listener =3D { - .name =3D "hvf", - .priority =3D MEMORY_LISTENER_PRIORITY_ACCEL, - .region_add =3D hvf_region_add, - .region_del =3D hvf_region_del, - .log_start =3D hvf_log_start, - .log_stop =3D hvf_log_stop, - .log_sync =3D hvf_log_sync, -}; - static void dummy_signal(int sig) { } =20 -bool hvf_allowed; - -static int hvf_accel_init(MachineState *ms) -{ - int x; - hv_return_t ret; - HVFState *s; - int pa_range =3D 36; - MachineClass *mc =3D MACHINE_GET_CLASS(ms); - - if (mc->hvf_get_physical_address_range) { - pa_range =3D mc->hvf_get_physical_address_range(ms); - if (pa_range < 0) { - return -EINVAL; - } - } - - ret =3D hvf_arch_vm_create(ms, (uint32_t)pa_range); - assert_hvf_ok(ret); - - s =3D g_new0(HVFState, 1); - - s->num_slots =3D ARRAY_SIZE(s->slots); - for (x =3D 0; x < s->num_slots; ++x) { - s->slots[x].size =3D 0; - s->slots[x].slot_id =3D x; - } - - QTAILQ_INIT(&s->hvf_sw_breakpoints); - - hvf_state =3D s; - memory_listener_register(&hvf_memory_listener, &address_space_memory); - - return hvf_arch_init(); -} - -static inline int hvf_gdbstub_sstep_flags(void) -{ - return SSTEP_ENABLE | SSTEP_NOIRQ; -} - -static void hvf_accel_class_init(ObjectClass *oc, const void *data) -{ - AccelClass *ac =3D ACCEL_CLASS(oc); - ac->name =3D "HVF"; - ac->init_machine =3D hvf_accel_init; - ac->allowed =3D &hvf_allowed; - ac->gdbstub_supported_sstep_flags =3D hvf_gdbstub_sstep_flags; -} - -static const TypeInfo hvf_accel_type =3D { - .name =3D TYPE_HVF_ACCEL, - .parent =3D TYPE_ACCEL, - .instance_size =3D sizeof(HVFState), - .class_init =3D hvf_accel_class_init, -}; - -static void hvf_type_init(void) -{ - type_register_static(&hvf_accel_type); -} - -type_init(hvf_type_init); - static void hvf_vcpu_destroy(CPUState *cpu) { hv_return_t ret =3D hv_vcpu_destroy(cpu->accel->fd); @@ -639,8 +372,10 @@ static const TypeInfo hvf_accel_ops_type =3D { .class_init =3D hvf_accel_ops_class_init, .abstract =3D true, }; + static void hvf_accel_ops_register_types(void) { type_register_static(&hvf_accel_ops_type); } + type_init(hvf_accel_ops_register_types); diff --git a/accel/hvf/hvf-all.c b/accel/hvf/hvf-all.c index 1c72c43ddb4..ddc77e629f5 100644 --- a/accel/hvf/hvf-all.c +++ b/accel/hvf/hvf-all.c @@ -10,9 +10,24 @@ =20 #include "qemu/osdep.h" #include "qemu/error-report.h" +#include "system/address-spaces.h" +#include "system/memory.h" #include "system/hvf.h" #include "system/hvf_int.h" #include "hw/core/cpu.h" +#include "hw/boards.h" +#include "trace.h" + +bool hvf_allowed; + +struct mac_slot { + int present; + uint64_t size; + uint64_t gpa_start; + uint64_t gva; +}; + +struct mac_slot mac_slots[32]; =20 const char *hvf_return_string(hv_return_t ret) { @@ -41,3 +56,255 @@ void assert_hvf_ok_impl(hv_return_t ret, const char *fi= le, unsigned int line, =20 abort(); } + +static int do_hvf_set_memory(hvf_slot *slot, hv_memory_flags_t flags) +{ + struct mac_slot *macslot; + hv_return_t ret; + + macslot =3D &mac_slots[slot->slot_id]; + + if (macslot->present) { + if (macslot->size !=3D slot->size) { + macslot->present =3D 0; + trace_hvf_vm_unmap(macslot->gpa_start, macslot->size); + ret =3D hv_vm_unmap(macslot->gpa_start, macslot->size); + assert_hvf_ok(ret); + } + } + + if (!slot->size) { + return 0; + } + + macslot->present =3D 1; + macslot->gpa_start =3D slot->start; + macslot->size =3D slot->size; + trace_hvf_vm_map(slot->start, slot->size, slot->mem, flags, + flags & HV_MEMORY_READ ? 'R' : '-', + flags & HV_MEMORY_WRITE ? 'W' : '-', + flags & HV_MEMORY_EXEC ? 'E' : '-'); + ret =3D hv_vm_map(slot->mem, slot->start, slot->size, flags); + assert_hvf_ok(ret); + return 0; +} + +static void hvf_set_phys_mem(MemoryRegionSection *section, bool add) +{ + hvf_slot *mem; + MemoryRegion *area =3D section->mr; + bool writable =3D !area->readonly && !area->rom_device; + hv_memory_flags_t flags; + uint64_t page_size =3D qemu_real_host_page_size(); + + if (!memory_region_is_ram(area)) { + if (writable) { + return; + } else if (!memory_region_is_romd(area)) { + /* + * If the memory device is not in romd_mode, then we actually = want + * to remove the hvf memory slot so all accesses will trap. + */ + add =3D false; + } + } + + if (!QEMU_IS_ALIGNED(int128_get64(section->size), page_size) || + !QEMU_IS_ALIGNED(section->offset_within_address_space, page_size))= { + /* Not page aligned, so we can not map as RAM */ + add =3D false; + } + + mem =3D hvf_find_overlap_slot( + section->offset_within_address_space, + int128_get64(section->size)); + + if (mem && add) { + if (mem->size =3D=3D int128_get64(section->size) && + mem->start =3D=3D section->offset_within_address_space && + mem->mem =3D=3D (memory_region_get_ram_ptr(area) + + section->offset_within_region)) { + return; /* Same region was attempted to register, go away. */ + } + } + + /* Region needs to be reset. set the size to 0 and remap it. */ + if (mem) { + mem->size =3D 0; + if (do_hvf_set_memory(mem, 0)) { + error_report("Failed to reset overlapping slot"); + abort(); + } + } + + if (!add) { + return; + } + + if (area->readonly || + (!memory_region_is_ram(area) && memory_region_is_romd(area))) { + flags =3D HV_MEMORY_READ | HV_MEMORY_EXEC; + } else { + flags =3D HV_MEMORY_READ | HV_MEMORY_WRITE | HV_MEMORY_EXEC; + } + + /* Now make a new slot. */ + int x; + + for (x =3D 0; x < hvf_state->num_slots; ++x) { + mem =3D &hvf_state->slots[x]; + if (!mem->size) { + break; + } + } + + if (x =3D=3D hvf_state->num_slots) { + error_report("No free slots"); + abort(); + } + + mem->size =3D int128_get64(section->size); + mem->mem =3D memory_region_get_ram_ptr(area) + section->offset_within_= region; + mem->start =3D section->offset_within_address_space; + mem->region =3D area; + + if (do_hvf_set_memory(mem, flags)) { + error_report("Error registering new memory slot"); + abort(); + } +} + +static void hvf_set_dirty_tracking(MemoryRegionSection *section, bool on) +{ + hvf_slot *slot; + + slot =3D hvf_find_overlap_slot( + section->offset_within_address_space, + int128_get64(section->size)); + + /* protect region against writes; begin tracking it */ + if (on) { + slot->flags |=3D HVF_SLOT_LOG; + hv_vm_protect((uintptr_t)slot->start, (size_t)slot->size, + HV_MEMORY_READ | HV_MEMORY_EXEC); + /* stop tracking region*/ + } else { + slot->flags &=3D ~HVF_SLOT_LOG; + hv_vm_protect((uintptr_t)slot->start, (size_t)slot->size, + HV_MEMORY_READ | HV_MEMORY_WRITE | HV_MEMORY_EXEC); + } +} + +static void hvf_log_start(MemoryListener *listener, + MemoryRegionSection *section, int old, int new) +{ + if (old !=3D 0) { + return; + } + + hvf_set_dirty_tracking(section, 1); +} + +static void hvf_log_stop(MemoryListener *listener, + MemoryRegionSection *section, int old, int new) +{ + if (new !=3D 0) { + return; + } + + hvf_set_dirty_tracking(section, 0); +} + +static void hvf_log_sync(MemoryListener *listener, + MemoryRegionSection *section) +{ + /* + * sync of dirty pages is handled elsewhere; just make sure we keep + * tracking the region. + */ + hvf_set_dirty_tracking(section, 1); +} + +static void hvf_region_add(MemoryListener *listener, + MemoryRegionSection *section) +{ + hvf_set_phys_mem(section, true); +} + +static void hvf_region_del(MemoryListener *listener, + MemoryRegionSection *section) +{ + hvf_set_phys_mem(section, false); +} + +static MemoryListener hvf_memory_listener =3D { + .name =3D "hvf", + .priority =3D MEMORY_LISTENER_PRIORITY_ACCEL, + .region_add =3D hvf_region_add, + .region_del =3D hvf_region_del, + .log_start =3D hvf_log_start, + .log_stop =3D hvf_log_stop, + .log_sync =3D hvf_log_sync, +}; + +static int hvf_accel_init(MachineState *ms) +{ + int x; + hv_return_t ret; + HVFState *s; + int pa_range =3D 36; + MachineClass *mc =3D MACHINE_GET_CLASS(ms); + + if (mc->hvf_get_physical_address_range) { + pa_range =3D mc->hvf_get_physical_address_range(ms); + if (pa_range < 0) { + return -EINVAL; + } + } + + ret =3D hvf_arch_vm_create(ms, (uint32_t)pa_range); + assert_hvf_ok(ret); + + s =3D g_new0(HVFState, 1); + + s->num_slots =3D ARRAY_SIZE(s->slots); + for (x =3D 0; x < s->num_slots; ++x) { + s->slots[x].size =3D 0; + s->slots[x].slot_id =3D x; + } + + QTAILQ_INIT(&s->hvf_sw_breakpoints); + + hvf_state =3D s; + memory_listener_register(&hvf_memory_listener, &address_space_memory); + + return hvf_arch_init(); +} + +static int hvf_gdbstub_sstep_flags(void) +{ + return SSTEP_ENABLE | SSTEP_NOIRQ; +} + +static void hvf_accel_class_init(ObjectClass *oc, const void *data) +{ + AccelClass *ac =3D ACCEL_CLASS(oc); + ac->name =3D "HVF"; + ac->init_machine =3D hvf_accel_init; + ac->allowed =3D &hvf_allowed; + ac->gdbstub_supported_sstep_flags =3D hvf_gdbstub_sstep_flags; +} + +static const TypeInfo hvf_accel_type =3D { + .name =3D TYPE_HVF_ACCEL, + .parent =3D TYPE_ACCEL, + .instance_size =3D sizeof(HVFState), + .class_init =3D hvf_accel_class_init, +}; + +static void hvf_type_init(void) +{ + type_register_static(&hvf_accel_type); +} + +type_init(hvf_type_init); --=20 2.49.0 From nobody Sat Dec 13 22:54:06 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1751624176; cv=none; d=zohomail.com; s=zohoarc; b=lVnS42zUZgagZ+jn/rmLGeBf1RqFOfJoW8H5NUUqSJZZXDN3Yfg7fHM6yemdlWbqbL8NKvwfgFwQMJGaibv2s4uXU6yG7F1RfeLbR5qK89zGrG65QO6+Int7xHiU0bHbJYjUFjnJ5BlWUbzCjG2zfKKlkylXVgPYpREaW5xhDxo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1751624176; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=wxoW7z/LI9NHhMEdNzGYL7+8ON+AV57aS1ofLSGL0sY=; b=XwVDsuNfXYbEnPm7nanZySzF7bKlCh9CmuqYYn1yBUBq7A28gDdIsmVuuod+Rbx9UkU6Al8TBG3APkGgeLNqNHQlKp0Q1WCSKmobgfiqCcNvdYoiXShwnxUsJ0GvEwkEKwisCr4Z/X9HyeR1ZsMYoZhVHqzoyL+7ssaq4x7aAiM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1751624176719749.9330409154418; Fri, 4 Jul 2025 03:16:16 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uXdSH-0006In-7u; Fri, 04 Jul 2025 06:15:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uXdS7-0006DU-Tz for qemu-devel@nongnu.org; Fri, 04 Jul 2025 06:15:34 -0400 Received: from mail-wr1-x42b.google.com ([2a00:1450:4864:20::42b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uXdS6-0006g5-1M for qemu-devel@nongnu.org; Fri, 04 Jul 2025 06:15:31 -0400 Received: by mail-wr1-x42b.google.com with SMTP id ffacd0b85a97d-3a4e742dc97so1235835f8f.0 for ; Fri, 04 Jul 2025 03:15:29 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-454b16a3799sm22115115e9.35.2025.07.04.03.15.26 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 04 Jul 2025 03:15:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1751624127; x=1752228927; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=wxoW7z/LI9NHhMEdNzGYL7+8ON+AV57aS1ofLSGL0sY=; b=QNMXwR3wtJYD/0nfEUeIu2u7Pc62J/agQzSt6Ri5Kd/vVPDCA5PJbk1FKTn97hAhFa VJr+nVx+NvD9L8V+iE+KBNyi3w8TacELMBje9m93ZI//dM0PvlCDSVHUw+mHV4/JexEt ts09D487VjzJ88VHU1rLuhMpBpeWIQkHDPyRtxUXDMzhMrTS4ORTp+K+5DgzOsElRgs0 46tLmrk0Pt1xhSb3RQj9RAvkfJJeuO4agQx4u9RMsbAqPg59E2NFUBMlWqH1PLNuGyFm koOml4YyysqaA0S+vBLkNblT5grtIXqB4LLXRn5XC0PkpM0U3TwEzeaJf81BVJydI43V y9LA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751624127; x=1752228927; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wxoW7z/LI9NHhMEdNzGYL7+8ON+AV57aS1ofLSGL0sY=; b=irn9ycEH90g9sL2CLqseJlwQ4o6Bi+gNnOt4O1ZZV8LA9P4Nz00Qh137J21wqbIW8P F9X1JT+kjbDHQ8zQfyMVJXaYmJwqbyYkE0BimzaKH0eDVG0oemePBbQbTLASi2W8U7W/ 4L6oRIvBX32j4eN05jUMzJ9x/GntDVOgeJVPIAGgN+18OBv8eeBbrOPXmGnoimpbBk/z oaJ7TGC65nD77fGCmLgWb/l0BJtOrxE1uaGzdLzuvBozL6mKOtQKtXDWLItU8aZIGxJN aE8WQ7OriR6AHrQE3BKF1+cNz71BVHkvQMeydagB+4oYgnCbnwQKJ/+ICVAWw1PALXCc TCfg== X-Gm-Message-State: AOJu0Yx41z9/5LUlYRSNyq/vJRzZVSdQiYrCGSO4ybqTBs5pMRiFc38d lV2fnVokwOhOxVSvpgtuucmvoIWfRUQudz++g+QBv/On/JiHUYZ3K84hFSi9OwbmYNCbluq35Ow XZVe0oCc= X-Gm-Gg: ASbGnctiyRdixPD+Zd/JWmCvjAbF/URF1zG+sLMjBlEex77ORVt7BUsGVKdXSp0u2Qp eZaSA0GjU+Jqh59tMzaTbVfw+amT2jsEiS3ZNZ96C3YYlgF6sOQeTeOzzXTJDXq1o0Hfv1RFPRV 1+G8ubCUaYgjlUFMYWma3v15jTHu8zaDPrqUqR2at/X1qa5Pa3rBNIkYAYBLhJATZ3fG3GZkjEF ZZrOA55UNY0VLpnR38fI1Fy8MAbDYdW+FYlK6L812Yw3b1SAGOuWKSN3ZmJxksqNTvq47Iuk5Ji Ie5R09CNh23Wo5CWjOcfr0UOwNlXPSL1ohkBs8k8Xov6CY8CHtSTi6GHrK2pfEp+cPxJVFa0B+L Qcxt78CKWQvoL0DNq3nfs3/gWhENohgN7Fqac X-Google-Smtp-Source: AGHT+IH+7BXrrIeoNn3xisSH1SpK91sMAOQ1eO5QzWBRZGwg8+4ZLVoZfzpikSJ+gJzzPns+MH1Yyw== X-Received: by 2002:a05:6000:2801:b0:3aa:ac7b:705a with SMTP id ffacd0b85a97d-3b493204a97mr1510686f8f.11.1751624127151; Fri, 04 Jul 2025 03:15:27 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 11/31] cpus: Document CPUState::vcpu_dirty field Date: Fri, 4 Jul 2025 12:14:12 +0200 Message-ID: <20250704101433.8813-12-philmd@linaro.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250704101433.8813-1-philmd@linaro.org> References: <20250704101433.8813-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::42b; envelope-from=philmd@linaro.org; helo=mail-wr1-x42b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1751624177117116600 Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson Reviewed-by: Zhao Liu Reviewed-by: Xiaoyao Li Message-Id: <20250703173248.44995-18-philmd@linaro.org> --- include/hw/core/cpu.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/include/hw/core/cpu.h b/include/hw/core/cpu.h index 162a56a5daa..5eaf41a566f 100644 --- a/include/hw/core/cpu.h +++ b/include/hw/core/cpu.h @@ -442,6 +442,7 @@ struct qemu_work_item; * @opaque: User data. * @mem_io_pc: Host Program Counter at which the memory was accessed. * @accel: Pointer to accelerator specific state. + * @vcpu_dirty: Hardware accelerator is not synchronized with QEMU state * @kvm_fd: vCPU file descriptor for KVM. * @work_mutex: Lock to prevent multiple access to @work_list. * @work_list: List of pending asynchronous work. @@ -538,7 +539,6 @@ struct CPUState { uint32_t kvm_fetch_index; uint64_t dirty_pages; int kvm_vcpu_stats_fd; - bool vcpu_dirty; =20 /* Use by accel-block: CPU is executing an ioctl() */ QemuLockCnt in_ioctl_lock; @@ -554,6 +554,7 @@ struct CPUState { uint32_t halted; int32_t exception_index; =20 + bool vcpu_dirty; AccelCPUState *accel; =20 /* Used to keep track of an outstanding cpu throttle thread for migrat= ion --=20 2.49.0 From nobody Sat Dec 13 22:54:06 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1751624425; cv=none; d=zohomail.com; s=zohoarc; b=eTAqvxRpBntBBaVDIBu1DjrNOn2gsRbK5uF1pU3D4KFnY4N0l6M8Ryc4MnF4rPJ05QdMgsIxZiR16waNNGH2o/ADqYcxk25Kjg+Jo8W7IoG9XKiV1Rw+6MUYWKvAXKzO/XoxrciLu7ekro3fnqHRrloOXwsIM8Q+KaqdOyipWiM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1751624425; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=eEidoVZ/Dc4n7iZhpqZa1LMyUM4NhBQ2iC14GxUB49g=; b=Hq/RZirqJuK1ef2iTHgWsWK7SzDPGZx8voAf1wc8TQhE0OeH2WCLJeTunOyJd0a46j4ktaJOGID1IxZrbWnWDzQvyLKNcwm3h+F/98QbO5PFgA33Fm0fF1hb4aH4xc/43CyBPg2HKEXnvFlrZYey3FltfdwIkMoqvaq5UAJcrx4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1751624425181504.7923144135609; Fri, 4 Jul 2025 03:20:25 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uXdSQ-0006KH-MQ; Fri, 04 Jul 2025 06:15:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uXdSC-0006HO-CW for qemu-devel@nongnu.org; Fri, 04 Jul 2025 06:15:37 -0400 Received: from mail-wr1-x430.google.com ([2a00:1450:4864:20::430]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uXdSA-0006gj-3M for qemu-devel@nongnu.org; Fri, 04 Jul 2025 06:15:35 -0400 Received: by mail-wr1-x430.google.com with SMTP id ffacd0b85a97d-3a52874d593so625291f8f.0 for ; Fri, 04 Jul 2025 03:15:33 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-454b1628ebcsm22590175e9.14.2025.07.04.03.15.30 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 04 Jul 2025 03:15:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1751624132; x=1752228932; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=eEidoVZ/Dc4n7iZhpqZa1LMyUM4NhBQ2iC14GxUB49g=; b=UTdwjtIsjya1X1BPjAeR1RcEvTGsEAPF7N+fsiiir+uON5d6eMtIh6zd77CelKgA2p 4ZV7C+/S+RsC8pfluMIattz/3H+Dao/+TORjexZZUwu60dVptLL7hFBnoMIEW3IBqoMl 51F99fVuKcWcqJvQphQ74pp4F3Gcu8JRtC2PrSHqHeq6jxw83D0gmZIHX9J6JU8b0fGR neYgegtE88FK4X1d46EO6iLfGDiBZSm2mQxtuW/MN6ypSe0qCfdmWV+2Nnrk9gvCFa6M PVNcimVA0LzDS3SKXgcTbT9pTeuiJY2ZPjWst0OuCKfBM81UgQeaRYJQxP2dTU9lPpcw GBvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751624132; x=1752228932; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=eEidoVZ/Dc4n7iZhpqZa1LMyUM4NhBQ2iC14GxUB49g=; b=shR0sghkehssQRAthaARPrnXmonq3gmRowi+twi/Cz/TGeaaruUsDnVVihp35WC4eS 3XiPf537tJmQPg1BAEZT05I1f5OROzcw2Rn2MNpB1/tBihVNJQV8vLaMsywbPNRJWUQe 20EzF9qgHQKf7bJpMfi4FsdNV3FkljzmAsH7+GbjZfj61ARfkXtUnNOiz2cfdZd2kqGn gEMRdptZCgMdWV+95vHHvw4yjGCHWqKhy76xid/vvOYdfrSofyYPirhrHyagaAHq/k1u uKLjEN/zUd7TvFp7FNtgdRSgEEOF1kvYMcFFDzFJx03oSj5kDTWkZQQfjWY8iswRNZpW RBaQ== X-Gm-Message-State: AOJu0YxfebOMkFFgcgUt1Enq8fr0RWzUs1EEW8HxBRTzUliqS8sVd2mh RLz4Y1fWNETfVRxbHvfZJVuqEKxlonNyGp7jTmos1MEghnJfNv89VujEmchEapvjC1kXwj+Av1C kKm45BIg= X-Gm-Gg: ASbGnctuGIBkTYrdTVBtNP/NsiRztL/sljZw5DZ9zM8vsOLlQn3bT/YnW+SjiHK+pzi NKzNJKKcckYwYplAkAkByZ7H8W8+boBAYS8ME6QUkOQ4Un2FMT0cnZF2I2u8v8C78M577FRRGh5 /VTOahUjodAucKtFgETQRt2Dg0wcd+gEBbV5S4J3m4M8ygbWnX5AxShCn9lF4+Yl3RQk+ohKKVX jQJjzszP7GcMYF2dKOeyrpn9E2CKZmaCGdI6h2pFQM+w4HMZW1tP5C7pxusSyrXBecJpRdEWUoR xnFIo1BIzV2yKp2JACjMLCmUZ9Yv2Pm2uhKTkC/n5O534nf6gXpLJ5QEKbXCqSpTP1DKi6dMBCT qBcbziax41DKNL/O82UTushPY2FqOM/3nQAus X-Google-Smtp-Source: AGHT+IHHxRXWTZ2lR1sFbL2iReoXvIxP5CnW+EOO/roWHDEbc1yTObIVtQUdYyLKl2UzUlCXcW83Ng== X-Received: by 2002:a05:6000:4287:b0:3a5:2cf3:d6ab with SMTP id ffacd0b85a97d-3b49661d6a6mr1737608f8f.39.1751624131663; Fri, 04 Jul 2025 03:15:31 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 12/31] accel/hvf: Replace @dirty field by generic CPUState::vcpu_dirty field Date: Fri, 4 Jul 2025 12:14:13 +0200 Message-ID: <20250704101433.8813-13-philmd@linaro.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250704101433.8813-1-philmd@linaro.org> References: <20250704101433.8813-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::430; envelope-from=philmd@linaro.org; helo=mail-wr1-x430.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1751624426117116600 No need for accel-specific @dirty field when we have a generic one in CPUState. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson Reviewed-by: Xiaoyao Li Reviewed-by: Zhao Liu Message-Id: <20250703173248.44995-19-philmd@linaro.org> --- include/system/hvf_int.h | 1 - accel/hvf/hvf-accel-ops.c | 10 +++++----- target/arm/hvf/hvf.c | 4 ++-- target/i386/hvf/hvf.c | 4 ++-- target/i386/hvf/x86hvf.c | 2 +- 5 files changed, 10 insertions(+), 11 deletions(-) diff --git a/include/system/hvf_int.h b/include/system/hvf_int.h index 4f6db40c34e..5150c7dd9c9 100644 --- a/include/system/hvf_int.h +++ b/include/system/hvf_int.h @@ -62,7 +62,6 @@ struct AccelCPUState { bool vtimer_masked; sigset_t unblock_ipi_mask; bool guest_debug_enabled; - bool dirty; }; =20 void assert_hvf_ok_impl(hv_return_t ret, const char *file, unsigned int li= ne, diff --git a/accel/hvf/hvf-accel-ops.c b/accel/hvf/hvf-accel-ops.c index 2c0715a17f7..395b5a8e1c0 100644 --- a/accel/hvf/hvf-accel-ops.c +++ b/accel/hvf/hvf-accel-ops.c @@ -79,15 +79,15 @@ hvf_slot *hvf_find_overlap_slot(uint64_t start, uint64_= t size) =20 static void do_hvf_cpu_synchronize_state(CPUState *cpu, run_on_cpu_data ar= g) { - if (!cpu->accel->dirty) { + if (!cpu->vcpu_dirty) { hvf_get_registers(cpu); - cpu->accel->dirty =3D true; + cpu->vcpu_dirty =3D true; } } =20 static void hvf_cpu_synchronize_state(CPUState *cpu) { - if (!cpu->accel->dirty) { + if (!cpu->vcpu_dirty) { run_on_cpu(cpu, do_hvf_cpu_synchronize_state, RUN_ON_CPU_NULL); } } @@ -96,7 +96,7 @@ static void do_hvf_cpu_synchronize_set_dirty(CPUState *cp= u, run_on_cpu_data arg) { /* QEMU state is the reference, push it to HVF now and on next entry */ - cpu->accel->dirty =3D true; + cpu->vcpu_dirty =3D true; } =20 static void hvf_cpu_synchronize_post_reset(CPUState *cpu) @@ -150,8 +150,8 @@ static int hvf_init_vcpu(CPUState *cpu) #else r =3D hv_vcpu_create(&cpu->accel->fd, HV_VCPU_DEFAULT); #endif - cpu->accel->dirty =3D true; assert_hvf_ok(r); + cpu->vcpu_dirty =3D true; =20 cpu->accel->guest_debug_enabled =3D false; =20 diff --git a/target/arm/hvf/hvf.c b/target/arm/hvf/hvf.c index 7b6d291e79c..c9cfcdc08bb 100644 --- a/target/arm/hvf/hvf.c +++ b/target/arm/hvf/hvf.c @@ -813,9 +813,9 @@ int hvf_put_registers(CPUState *cpu) =20 static void flush_cpu_state(CPUState *cpu) { - if (cpu->accel->dirty) { + if (cpu->vcpu_dirty) { hvf_put_registers(cpu); - cpu->accel->dirty =3D false; + cpu->vcpu_dirty =3D false; } } =20 diff --git a/target/i386/hvf/hvf.c b/target/i386/hvf/hvf.c index 99e37a33e50..818b50419f4 100644 --- a/target/i386/hvf/hvf.c +++ b/target/i386/hvf/hvf.c @@ -733,9 +733,9 @@ int hvf_vcpu_exec(CPUState *cpu) } =20 do { - if (cpu->accel->dirty) { + if (cpu->vcpu_dirty) { hvf_put_registers(cpu); - cpu->accel->dirty =3D false; + cpu->vcpu_dirty =3D false; } =20 if (hvf_inject_interrupts(cpu)) { diff --git a/target/i386/hvf/x86hvf.c b/target/i386/hvf/x86hvf.c index 2057314892a..17fce1d3cdd 100644 --- a/target/i386/hvf/x86hvf.c +++ b/target/i386/hvf/x86hvf.c @@ -427,7 +427,7 @@ int hvf_process_events(CPUState *cs) X86CPU *cpu =3D X86_CPU(cs); CPUX86State *env =3D &cpu->env; =20 - if (!cs->accel->dirty) { + if (!cs->vcpu_dirty) { /* light weight sync for CPU_INTERRUPT_HARD and IF_MASK */ env->eflags =3D rreg(cs->accel->fd, HV_X86_RFLAGS); } --=20 2.49.0 From nobody Sat Dec 13 22:54:06 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1751624459; cv=none; d=zohomail.com; s=zohoarc; b=DpSBDxpJmmLWlpvFKc7cMtwilWCUCxFGkiC/AQvPY0EU+gBrkUMDubLMm+mo1vvzwINf85+Q8zBXVm2wLngJzlasDBwnPSbKUd0C6JaG3s5fv1Lz2u5fGdSIZLgNTZrxaGa86kchFmQcN0w2a0I3X8xCHP/h5ekdllyns35trpk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1751624459; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=LBoiRmSfdCqtJIqk1JKUtvtWiXDQLjURI5vrbPYAfFE=; b=ZgBeDvLbb6ofPCwFP4ELKM4nuWsRWTu2QWQkZIMtZanf77m24mpCEqETHW355Rw46VR31BF//3Zy0AxmQuYxgEuaaAKhPqd5w/cg87470EDB1GwGrwE1dyCm4UeXRFBOBLc/aaNvNvxQcFmkHS2IQQPATtwQ++Wl/CIsBdMFCXk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1751624459877609.1940842751783; Fri, 4 Jul 2025 03:20:59 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uXdST-0006Ze-H2; Fri, 04 Jul 2025 06:15:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uXdSH-0006J2-62 for qemu-devel@nongnu.org; Fri, 04 Jul 2025 06:15:44 -0400 Received: from mail-wm1-x329.google.com ([2a00:1450:4864:20::329]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uXdSE-0006hT-Hn for qemu-devel@nongnu.org; Fri, 04 Jul 2025 06:15:40 -0400 Received: by mail-wm1-x329.google.com with SMTP id 5b1f17b1804b1-45348bff79fso8370755e9.2 for ; Fri, 04 Jul 2025 03:15:38 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-454a9bcef22sm51811925e9.19.2025.07.04.03.15.35 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 04 Jul 2025 03:15:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1751624136; x=1752228936; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=LBoiRmSfdCqtJIqk1JKUtvtWiXDQLjURI5vrbPYAfFE=; b=G72pCg39CSUgiTp4Ks8RWEZUVJ8y8JxSLr4IxSJmOcr6YjoUlGN14djKU9cp5BXqc9 p9sXKizFptdsEE8czWy5dmuZWgxc2KISsOdSoUdePApqtp9HfPka/FlLesoryNJmdtK7 prc/iLQq3tCbYC4nFWYLkLals1NxpMO10QB7EXtsSVX1LykkFr9aU7Rbqzt3klDGX5F3 PTnCDKmZKNfcZg1XKYx4fwD+2popTck5SskuVGCRq/aB6roIbezxOoyB/iIKjqL9+7qH sK8Ti7sqVWBvGsbTAmLB6zs1ahf3q4LXE0B3pT9pxU5PAz7O833lwB7rYcxak4kPIzH3 VorA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751624136; x=1752228936; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LBoiRmSfdCqtJIqk1JKUtvtWiXDQLjURI5vrbPYAfFE=; b=lelAD9EuXzgVkjAyuliSI6cGDCO8gAQXYP7HF8zTqsKVIRh4Xb8a3QyAwyoDIEq7XX kNRZScBkGUu7lD/ZIp67YfPLWomxthtLPkIGNxym3yxo9rafFOwDuD+5hQf2UzSiVPjp 2t3q7sbuJH8qWT3vWTep/muIhLQTRlkmDBOduJy0qdSUfcfjD17DUZHb+yN8oegJxdB6 FjxiA42gMPZyoFjRis7KFgueGofpYa5FifYydBCvkq6D+ugsf+jwqxZCmKG64GlV5MfF HKhPmSRg/3vNPGsmN8KXepxEOb2iY0V6NOsbS0H5DLuLwdYIRLnwb11v5uwuRrvU007s 9i7A== X-Gm-Message-State: AOJu0Yw7hLqy/CVLRt1gHWwqbQkScoX2cq5eW8tLrbyNJtJq+86KmuIc +eZrpN6U5NRuDO+3t7QX+i3lU0fHI3kkJJ7DBUolAojMVq1Pf6HUYhukZE6w+Fdr7R+tGAGz1A0 owG3urX0= X-Gm-Gg: ASbGncv8vfbEQDMhEl46JdJrw+FomqEwbqErWgbzF4fmRbD7yy62/yLdVeZ2S9+fiBl OBOcPmqwCJeZt2Uz+WUgu90s5DnG7c71c5xGOTgWZJIs7Rb3W2OOpL+DznuR1P9dPPxtXeXgdZx WzItbm6ym3hw/eU/9mIIrThFFp/4A/KuRzjeukGsTssQut1Qpm6TiK5MAmyHqNd9JTQPg3EVIEl N2lJe8xIlrJPKOzlmIcy9pco0Jrk/D9IR9l0DM3V4PsfFLZrBzriOxSTp7fs2ktSpHk47qTV07g roLojHTE1Mh+RQbimtNTWWyAFlUUD5uJa609rET8/5h30QBxprEtLOsxKJDLR/zLzEvo2INNuYZ 2EePaDjutel7zlXS7aoiV4gQ5r6ov8l3nPUa7 X-Google-Smtp-Source: AGHT+IF96hGUeYY4GTMBkgEadWYpoiiQRpfuJLjoi8QKuucYEiqlUEAF6rIZUp9QtbHwu/Hsl+IwpA== X-Received: by 2002:a05:6000:1788:b0:3a4:f379:65bc with SMTP id ffacd0b85a97d-3b497038e7emr1362278f8f.40.1751624136332; Fri, 04 Jul 2025 03:15:36 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 13/31] accel/nvmm: Replace @dirty field by generic CPUState::vcpu_dirty field Date: Fri, 4 Jul 2025 12:14:14 +0200 Message-ID: <20250704101433.8813-14-philmd@linaro.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250704101433.8813-1-philmd@linaro.org> References: <20250704101433.8813-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::329; envelope-from=philmd@linaro.org; helo=mail-wm1-x329.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1751624460597116600 No need for accel-specific @dirty field when we have a generic one in CPUState. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson Reviewed-by: Xiaoyao Li Reviewed-by: Zhao Liu Message-Id: <20250703173248.44995-20-philmd@linaro.org> --- target/i386/nvmm/nvmm-all.c | 21 ++++++++++----------- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a/target/i386/nvmm/nvmm-all.c b/target/i386/nvmm/nvmm-all.c index f1c6120ccf1..aea61a6fd2a 100644 --- a/target/i386/nvmm/nvmm-all.c +++ b/target/i386/nvmm/nvmm-all.c @@ -30,7 +30,6 @@ struct AccelCPUState { struct nvmm_vcpu vcpu; uint8_t tpr; bool stop; - bool dirty; =20 /* Window-exiting for INTs/NMIs. */ bool int_window_exit; @@ -508,7 +507,7 @@ nvmm_io_callback(struct nvmm_io *io) } =20 /* Needed, otherwise infinite loop. */ - current_cpu->accel->dirty =3D false; + current_cpu->vcpu_dirty =3D false; } =20 static void @@ -517,7 +516,7 @@ nvmm_mem_callback(struct nvmm_mem *mem) cpu_physical_memory_rw(mem->gpa, mem->data, mem->size, mem->write); =20 /* Needed, otherwise infinite loop. */ - current_cpu->accel->dirty =3D false; + current_cpu->vcpu_dirty =3D false; } =20 static struct nvmm_assist_callbacks nvmm_callbacks =3D { @@ -727,9 +726,9 @@ nvmm_vcpu_loop(CPUState *cpu) * Inner VCPU loop. */ do { - if (cpu->accel->dirty) { + if (cpu->vcpu_dirty) { nvmm_set_registers(cpu); - cpu->accel->dirty =3D false; + cpu->vcpu_dirty =3D false; } =20 if (qcpu->stop) { @@ -827,32 +826,32 @@ static void do_nvmm_cpu_synchronize_state(CPUState *cpu, run_on_cpu_data arg) { nvmm_get_registers(cpu); - cpu->accel->dirty =3D true; + cpu->vcpu_dirty =3D true; } =20 static void do_nvmm_cpu_synchronize_post_reset(CPUState *cpu, run_on_cpu_data arg) { nvmm_set_registers(cpu); - cpu->accel->dirty =3D false; + cpu->vcpu_dirty =3D false; } =20 static void do_nvmm_cpu_synchronize_post_init(CPUState *cpu, run_on_cpu_data arg) { nvmm_set_registers(cpu); - cpu->accel->dirty =3D false; + cpu->vcpu_dirty =3D false; } =20 static void do_nvmm_cpu_synchronize_pre_loadvm(CPUState *cpu, run_on_cpu_data arg) { - cpu->accel->dirty =3D true; + cpu->vcpu_dirty =3D true; } =20 void nvmm_cpu_synchronize_state(CPUState *cpu) { - if (!cpu->accel->dirty) { + if (!cpu->vcpu_dirty) { run_on_cpu(cpu, do_nvmm_cpu_synchronize_state, RUN_ON_CPU_NULL); } } @@ -982,7 +981,7 @@ nvmm_init_vcpu(CPUState *cpu) } } =20 - qcpu->dirty =3D true; + qcpu->vcpu_dirty =3D true; cpu->accel =3D qcpu; =20 return 0; --=20 2.49.0 From nobody Sat Dec 13 22:54:06 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1751624467; cv=none; d=zohomail.com; s=zohoarc; b=Dsk37D04zPnjwN7PSCyoKrQsK52giM4BzyyM8BPc5X0oTcN6CzIatdExlZ/Ahrj2kUBRY6FI2HWU++uzJ2ZqVTE6EdsddPZOdUmTuDLQC+7Hp95k1nz9E0GrBqAKZ7/RqaQFCaxLrwCQzxhTOI9WLzKCrRazHm/3hjEGVo4i5dI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1751624467; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=1AkDLUIDoYeXz0B32G8TfwPxxxgPR7nn1gNxi5L7EiE=; b=SdYv0R5Y1qYV5vA6jAL9TYvm1zohm4bh1rDJpNHuEbeGg5bVA4O9TDnROzgnXgTrq59HcLt8/IE/3WjIDh5V3qXwlwBnWcs9mDDTqkE+j0UldaZX6oR/VOddA1IruRij9Sx8OhYVpmh5XrEy1mV6NkbA5f3y/z4Od9xAy5WOfpc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1751624467295829.0665688111246; Fri, 4 Jul 2025 03:21:07 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uXdST-0006an-KO; Fri, 04 Jul 2025 06:15:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uXdSL-0006Jx-3e for qemu-devel@nongnu.org; Fri, 04 Jul 2025 06:15:45 -0400 Received: from mail-wr1-x429.google.com ([2a00:1450:4864:20::429]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uXdSJ-0006iL-2z for qemu-devel@nongnu.org; Fri, 04 Jul 2025 06:15:44 -0400 Received: by mail-wr1-x429.google.com with SMTP id ffacd0b85a97d-3a50fc7ac4dso317889f8f.0 for ; Fri, 04 Jul 2025 03:15:42 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-454b1698f54sm22234415e9.33.2025.07.04.03.15.40 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 04 Jul 2025 03:15:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1751624141; x=1752228941; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=1AkDLUIDoYeXz0B32G8TfwPxxxgPR7nn1gNxi5L7EiE=; b=luB5qGZdVDPgIsl+7jUuczhATbx3bWzkJgskPN5yjr6DHxo15sQSdTGrmEBBLrrTQe ABZCKcjZD3NcA89tLvk7VfzVn4wZkfSGjn/DRdml6I3N6RBc/UwZFDlxk/zFX6C5tuuv 1qx1LWRv+GFbPYFAhH+e7Ntj2gKwM3JZARmS5PYZlsXLxtzKP3DpPWJ02/bZQgBeucnc 5WqnwRZY5igM/hSeToNCH/wsbb9ag9MRKu4ut017j2azLaeQ9RQMpARKZsBXhth5AHaD wji1TARgruFQxBENwn8Z2BaLfnfqv7qGTupQn3J6rbr99rUYo8jqaGI9QU9j+bvHb2JK gufw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751624141; x=1752228941; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1AkDLUIDoYeXz0B32G8TfwPxxxgPR7nn1gNxi5L7EiE=; b=hn6E6uB828An5Off6zYkFCcCmVY82FOYImgf04cKSR88zhEDTJ0Ow+/JmQ+JcXsovw WoL52iypgff8IdKe9LjJVTGHf+c7Bgsaixhe+Yz4c0BY7g6Yt8OxAbi+gxgKGTIgwynt VYiF0qyZg/m8/+AJPMqldGQREljyvPd6qgU1OiY3unAIjJq3J2EpmZHKoCpJ30i6SB0R npjXZ1O7lXuBO1fwBMX7MrFeeaYq/5Ximti7yOYurO7tBlrv6UDMsqTKi3m2OM3myMWI C814nMNpS+8EvJydY4jrgh/wjznV2tQePkYleIqmR55gCSv0MG6OL9k8xQ5TQd2ob9Ef dXXA== X-Gm-Message-State: AOJu0YySYg1sc0tllbkSWJRaFFpoct07rwn29q2t8GxBJA4aAbKgQk2d Vxk7McXvV3642PBN+1p8/MQBwuWPWoo3YOZE9o9AfaSq8kvOuKwZ1AgRUtoTGyT8/vPoLVkIdQD Wmy1FNe0= X-Gm-Gg: ASbGncs8gIfzHtZPPsasfH1oVSWW+PJ0YgUejlIutpQXAMAOdPuggjJQksrf1Qu6OlC Pzd2sV60vuKalnd6wMG27JMVCbfKF93sOWw8fTnpeoWw4YakpO3eonLKfc58Gpt5m8Rt1vFsaAw mpIXe+9Xj7AXqEBrTVp++en6ytySGqOyWbCxDfaEHf7DBUz0ct8ekBgang0vhh7p1mpaGoiO6QC Vel2RXwljxWJOZh88oRct6PDPQyxqmBjX8ccoNbUbb3yq22HSSBHv7ODMxmvjBTLCXE5oQ2Xjni Pz26JuSbNIBKXvv3vxBBGm/clT07uDUafqqjPsnEgAuIs6JPjJRQ7w4nTaXH/kt/IuWsIJ+qQJt Uj/yeInnBu3giiyisvplwyYrBnMaUuWZmOGbC X-Google-Smtp-Source: AGHT+IG/HgEBUTT88wK7/BwJk08r3jrp/DIfryKaaz82R3YFViYDpBq5guH0biNJQtynZlyqTdT4lQ== X-Received: by 2002:a05:6000:250d:b0:3a4:dd8e:e16b with SMTP id ffacd0b85a97d-3b4964d4079mr1364888f8f.20.1751624140864; Fri, 04 Jul 2025 03:15:40 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 14/31] accel/whpx: Replace @dirty field by generic CPUState::vcpu_dirty field Date: Fri, 4 Jul 2025 12:14:15 +0200 Message-ID: <20250704101433.8813-15-philmd@linaro.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250704101433.8813-1-philmd@linaro.org> References: <20250704101433.8813-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::429; envelope-from=philmd@linaro.org; helo=mail-wr1-x429.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1751624468992116600 No need for accel-specific @dirty field when we have a generic one in CPUState. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson Reviewed-by: Xiaoyao Li Reviewed-by: Zhao Liu Message-Id: <20250703173248.44995-21-philmd@linaro.org> --- target/i386/whpx/whpx-all.c | 23 +++++++++++------------ 1 file changed, 11 insertions(+), 12 deletions(-) diff --git a/target/i386/whpx/whpx-all.c b/target/i386/whpx/whpx-all.c index cf6d3e4cdd4..5001afad3a7 100644 --- a/target/i386/whpx/whpx-all.c +++ b/target/i386/whpx/whpx-all.c @@ -237,7 +237,6 @@ struct AccelCPUState { uint64_t tpr; uint64_t apic_base; bool interruption_pending; - bool dirty; =20 /* Must be the last field as it may have a tail */ WHV_RUN_VP_EXIT_CONTEXT exit_ctx; @@ -836,7 +835,7 @@ static HRESULT CALLBACK whpx_emu_setreg_callback( * The emulator just successfully wrote the register state. We clear t= he * dirty state so we avoid the double write on resume of the VP. */ - cpu->accel->dirty =3D false; + cpu->vcpu_dirty =3D false; =20 return hr; } @@ -1391,7 +1390,7 @@ static int whpx_last_vcpu_stopping(CPUState *cpu) /* Returns the address of the next instruction that is about to be execute= d. */ static vaddr whpx_vcpu_get_pc(CPUState *cpu, bool exit_context_valid) { - if (cpu->accel->dirty) { + if (cpu->vcpu_dirty) { /* The CPU registers have been modified by other parts of QEMU. */ return cpu_env(cpu)->eip; } else if (exit_context_valid) { @@ -1704,9 +1703,9 @@ static int whpx_vcpu_run(CPUState *cpu) } =20 do { - if (cpu->accel->dirty) { + if (cpu->vcpu_dirty) { whpx_set_registers(cpu, WHPX_SET_RUNTIME_STATE); - cpu->accel->dirty =3D false; + cpu->vcpu_dirty =3D false; } =20 if (exclusive_step_mode =3D=3D WHPX_STEP_NONE) { @@ -2054,9 +2053,9 @@ static int whpx_vcpu_run(CPUState *cpu) =20 static void do_whpx_cpu_synchronize_state(CPUState *cpu, run_on_cpu_data a= rg) { - if (!cpu->accel->dirty) { + if (!cpu->vcpu_dirty) { whpx_get_registers(cpu); - cpu->accel->dirty =3D true; + cpu->vcpu_dirty =3D true; } } =20 @@ -2064,20 +2063,20 @@ static void do_whpx_cpu_synchronize_post_reset(CPUS= tate *cpu, run_on_cpu_data arg) { whpx_set_registers(cpu, WHPX_SET_RESET_STATE); - cpu->accel->dirty =3D false; + cpu->vcpu_dirty =3D false; } =20 static void do_whpx_cpu_synchronize_post_init(CPUState *cpu, run_on_cpu_data arg) { whpx_set_registers(cpu, WHPX_SET_FULL_STATE); - cpu->accel->dirty =3D false; + cpu->vcpu_dirty =3D false; } =20 static void do_whpx_cpu_synchronize_pre_loadvm(CPUState *cpu, run_on_cpu_data arg) { - cpu->accel->dirty =3D true; + cpu->vcpu_dirty =3D true; } =20 /* @@ -2086,7 +2085,7 @@ static void do_whpx_cpu_synchronize_pre_loadvm(CPUSta= te *cpu, =20 void whpx_cpu_synchronize_state(CPUState *cpu) { - if (!cpu->accel->dirty) { + if (!cpu->vcpu_dirty) { run_on_cpu(cpu, do_whpx_cpu_synchronize_state, RUN_ON_CPU_NULL); } } @@ -2226,7 +2225,7 @@ int whpx_init_vcpu(CPUState *cpu) } =20 vcpu->interruptable =3D true; - vcpu->dirty =3D true; + cpu->vcpu_dirty =3D true; cpu->accel =3D vcpu; max_vcpu_index =3D max(max_vcpu_index, cpu->cpu_index); qemu_add_vm_change_state_handler(whpx_cpu_update_state, env); --=20 2.49.0 From nobody Sat Dec 13 22:54:06 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1751624422; cv=none; d=zohomail.com; s=zohoarc; b=Dx1HBlYJBh+EUmUVtGTuPLJSQ4o6m9nxFWX7NAKerxGBEvE5k5usoDPxbZGVFvzE3VRSU8UprU3q1rx7Dn93T5yBLBO2qbRuDSLIsqeSfwBcJCoBubROxx8yhHeBDj/T2dCJe4Tla/TbvpsUEleLQ6vOvLX1Q0sFspc4lHzTUfQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1751624422; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=+xZJfQ5oPTw81l9vGVJcZV3TZMpxgXbDigfZBZsjgfo=; b=SoHLQdwqGoBR+HWzceY97FHUhzz8TNa9w1QUyI2mC7M7j312a9thbTBiz+nNVS9SyNH0JNi2hylwuAl9/SeHg72Mlyb5258jIyM3/fB+VUDgG/hZH3DJa/FuWMGs7wtu/SjYuqM9sTYDHjCz1w0VFBNeJsGzYtaq2to3gQ6Exy4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1751624422105168.08531641854574; Fri, 4 Jul 2025 03:20:22 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uXdSV-0006e0-34; Fri, 04 Jul 2025 06:15:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uXdSP-0006L6-DU for qemu-devel@nongnu.org; Fri, 04 Jul 2025 06:15:52 -0400 Received: from mail-wm1-x329.google.com ([2a00:1450:4864:20::329]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uXdSN-0006lw-GE for qemu-devel@nongnu.org; Fri, 04 Jul 2025 06:15:48 -0400 Received: by mail-wm1-x329.google.com with SMTP id 5b1f17b1804b1-450cb2ddd46so3756675e9.2 for ; Fri, 04 Jul 2025 03:15:46 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b4708d0ae0sm2143688f8f.33.2025.07.04.03.15.44 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 04 Jul 2025 03:15:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1751624145; x=1752228945; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=+xZJfQ5oPTw81l9vGVJcZV3TZMpxgXbDigfZBZsjgfo=; b=F3vE14dwaRKqxdZMFgDn12E1zPjMf9wkal4Uh0WDsSlHpJ6UT5D4Ocx3HDVc8u8vGZ MidMDXBYinYNHIhPSae+kkBWJCywyYQNO2ktMNjeWhNLgFOMusg1u+OFYkrzM6LljcrA w4Ink3kON6YwXbntKFM5/7JXbkEOkjP1yq+ZpHkSsLlMhH/gnJVEf0kqJfCR5Jrq1Ujt 4AbT5zjsoJMcFB40ePMOp2QvAdcxl4c0ATKfcm65LHfAWKiKyOw/d8I7leBfcmaaGRDm ACfb3LCIfky6XSFvF5zpsXLr2Fk5U2w91sm0jV2asDqdnlDoG9cGCnyWSX6oThVLqr0W WnHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751624145; x=1752228945; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+xZJfQ5oPTw81l9vGVJcZV3TZMpxgXbDigfZBZsjgfo=; b=fSqeO4g2VDitMuS7UONKcfpOdbIyLQUntCduu7HPoa7UtM1AF3iEaQ+6zbiq53SYAv yetl6kXLYWRUtB+794568e0Oazwc+6bQ0zFbBU0rFTHRdsGYU30OVkYjejZ/fZvHP++1 bqFUJYr7XH6+rODLe5puykDb940Dxd115bkLHCr6PFmTLEHZFgU4Pv3I6Du+zRXFy9ST +v8qXxN52QHNvcEFtmg9hiBWF+z3fUTba7pXtW4fQ1hSHhspuibLKNOZOvuvSI4UQgPB qnhhnGC0oX8g03/lBdXoVzNV1bgPH7xSZn1D5OO0NcfVjLYYmQy8g7+Gb/XJhQF5JHbL OHXA== X-Gm-Message-State: AOJu0YxPnt1RtKEHxozo0GxL/V7xylhaGS17ei+0U6wFDSGNndrJPMV9 z4itA+q2nl425Zcm0V83c/+Ky4KWb7lCntV0afYGXAkZlEuCJYE32AjjSbKqfTTQcpEfUMdBu1k zyLM7Tss= X-Gm-Gg: ASbGncs8gRhABLeMb2Yi05Shi0pRuVGK7Ih3wpsbVZIiZ4ISXZB0wrlvsuAk1CeDPhA zMewsBEcWFZaztY/uYEu+HrO8vE0PdDdF4T8qcmgkE6zy3zvYsV8n8DBrKLaCUiCaZj9Qrf8Edu z7nfzOm5aceZbYszFVfYhWjU5Q2ZRR5kUYxmZqlW4PYqvko94K6wu9SHVqkCTwgxBzQNHU+EX5+ QNHnvM4QYAA7Y7MKv2GibpK6Q7JCGe5psP6J8pcdAL1Su03hths2duezI31AptoWvYCUChNQ5Rc JWh6UXd7GZ2wye7UL2TLD0IT12ZbwR0iYw92MtjAAneI3R5JXBhQsD5upMLrHJIddRdPs1iJF0w kdqxIWH8xZxt3+MWjxCaRyC1xickSzHNVZP0z X-Google-Smtp-Source: AGHT+IGm8JHB0uskDnoY6TIEdksArRwhsyBIJOEYEhT4KXnuScfKWQWS57TfBx8+ske6NP+Dm2Tatw== X-Received: by 2002:a05:600c:3e1a:b0:441:d4e8:76c6 with SMTP id 5b1f17b1804b1-454b3187c08mr24112365e9.30.1751624145409; Fri, 04 Jul 2025 03:15:45 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 15/31] accel/kvm: Remove kvm_cpu_synchronize_state() stub Date: Fri, 4 Jul 2025 12:14:16 +0200 Message-ID: <20250704101433.8813-16-philmd@linaro.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250704101433.8813-1-philmd@linaro.org> References: <20250704101433.8813-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::329; envelope-from=philmd@linaro.org; helo=mail-wm1-x329.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1751624424060116600 Since commit 57038a92bb0 ("cpus: extract out kvm-specific code to accel/kvm") the kvm_cpu_synchronize_state() stub is not necessary. Fixes: e0715f6abce ("kvm: remove kvm specific functions from global include= s") Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson Reviewed-by: Xiaoyao Li Reviewed-by: Zhao Liu Message-Id: <20250703173248.44995-22-philmd@linaro.org> --- accel/stubs/kvm-stub.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/accel/stubs/kvm-stub.c b/accel/stubs/kvm-stub.c index b9b4427c919..68cd33ba973 100644 --- a/accel/stubs/kvm-stub.c +++ b/accel/stubs/kvm-stub.c @@ -29,10 +29,6 @@ void kvm_flush_coalesced_mmio_buffer(void) { } =20 -void kvm_cpu_synchronize_state(CPUState *cpu) -{ -} - bool kvm_has_sync_mmu(void) { return false; --=20 2.49.0 From nobody Sat Dec 13 22:54:06 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1751624398; cv=none; d=zohomail.com; s=zohoarc; b=AqCHSw5Tf44yQhWlyDu/4UuS5uvm2BBk2O6IoxU+ydFjYiKI1Fki3aUYGMMja3zYX6+HUpNHSKkTsxKxFUsuvhGK19huoa+LBKyWd7TXbnNTs+dB8+CllejVDu47+UMFn8dJJfSMYdiiii3E/wHQ4Vp4gQOrdqt//HZXAEIRu2g= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1751624398; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=mGJ2ndj0RHyzDpqgO8Q1/q0oLyFwkpR41xzkhPCtx98=; b=Ak0hqeZy+mhS6UQeVJDBY/Yt5N3DCKc3TlXZiAzZWn9CiU2BB9fD+WuN+bEJGRPif0B0dXjbNgvqxedp6V7httd7tukCJfTROrFJAyaaK5chySeOAhiaMTYe2fFWPiY5lcj7VAsoV5yDEe26Hs2bkZWF+Yp8tWkZfJgITZ2DeRE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1751624398783277.6430857395088; Fri, 4 Jul 2025 03:19:58 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uXdSW-0006j4-L3; Fri, 04 Jul 2025 06:15:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uXdSU-0006d1-Gl for qemu-devel@nongnu.org; Fri, 04 Jul 2025 06:15:54 -0400 Received: from mail-wm1-x330.google.com ([2a00:1450:4864:20::330]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uXdSS-0006nE-CI for qemu-devel@nongnu.org; Fri, 04 Jul 2025 06:15:53 -0400 Received: by mail-wm1-x330.google.com with SMTP id 5b1f17b1804b1-45363645a8eso5092905e9.1 for ; Fri, 04 Jul 2025 03:15:51 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b471b96731sm2113555f8f.55.2025.07.04.03.15.49 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 04 Jul 2025 03:15:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1751624150; x=1752228950; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=mGJ2ndj0RHyzDpqgO8Q1/q0oLyFwkpR41xzkhPCtx98=; b=m/AEnrdkeh6my6vbbp7SKtH/5KTPcU7ZVrLLlrM4YolHJEAmGH6nYr891S0ojdgjFw 2/LLyAUh8JB+9ENsm62iEIIHGZbmR4Ej8cQv2lcLT47WUZ1mQf9V/OKYTzGsf2Umrefh YJrtkUVMISK3FHomT+QICo5b0+km9tTbLHk2N7sw9CxiMc48IqVzBLnKZe07BKWY1HhY rlvx/xHwmKWmUzm3GOxcjppyJWCUFGqZGdLL7EZFPxpjffwoq5ENEWmUdDjQOFVQ1y+Q Ji/HyyoXmQU3/EV2rOMwY64l4b4pXrB6qWC+Q3rrR6XfZMIVoi0ibqP5TlFNc3h5eNfg /KsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751624150; x=1752228950; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mGJ2ndj0RHyzDpqgO8Q1/q0oLyFwkpR41xzkhPCtx98=; b=M9f+PGK0Kju1lhaJldJknQV14YCdK2bG1SrRO6b5CkpUFgXEFAh50XOcDGi424ArM2 48ZQjMqiIkdHHv4uiRQrE/CyNgEWEuy4QzZzqUjbBH4mRw0wkWoR1Gw6OoRIq/RgNmO/ u+y6/q8HDcDJ7K2d7FecFGGN0M5gmyY1NguvvpRNEwEdyAPIQ+Tj4M1bls3J/qfaRdI/ TSHa2NHATMQ7iDNOLu/drtfsZJWBCPW/0zaj7xrW4w+Cb3KAn8XMxqhYDICqpNQnHm0q nchosfKfl6n4cHFh1izuFncY1u5WMeoIqH3IIhtOXyPZ/0jVDqXAb3t8VMSa87LG2tjA 8r1Q== X-Gm-Message-State: AOJu0Ywqle0I+GfETc5xDv0LyTovuThAF7DC57nN7vX3EzR9B82Bx9E4 8hmt1+qobeeAKnpdodgUbMyLUes+yWM4FqOMtgC8VhjJNsHOyQXv5mjT3ROHwrnZrK71sPzEORs ZI7g2Rvg= X-Gm-Gg: ASbGncuMiK5TRDolAsdUddqOi7T5epjGgjUZHi7rs5dMHeIxJkZlHWoCZxHyAs/agSs fdoMJJm1WG9NMaSanxuQDTFq0eFP0ZQaFaa5gSvy11cfZvfwfcM1nL8pHzzmnoFqE9FLrLCIINX uhaYmzYsZfX/6O6OfDti1vA+bgX6pv/mBee6QtniULgJ/zn3325UfNPv6wIx/f2pnEKyW1zozKx L3nyts2Nl8W1dyvQXfyHzYQGDR7RhDTcjFtYAh5DS3MTYpXdQI8AKD7cEGpg2J66LZbHJHdAS/B l2txY3ci1o+3I9SMHOZTbMXxzJEmxPh9l9NYYKagHsHN2CftDQX9W8JFZiz+93xZWawndRTt2ea Car6B3nA9iHGKRzOYlBLeUvZpm/D/kT8P23y6 X-Google-Smtp-Source: AGHT+IGLmM8cD1LeWEaayfFc0aeQhjLhK+u09bE8yd14lSdZM8yo2HonEhKuqKwPZA23KZvUpSbwRQ== X-Received: by 2002:a05:600c:1d81:b0:43d:fa5d:9315 with SMTP id 5b1f17b1804b1-454b319566emr15894515e9.33.1751624149966; Fri, 04 Jul 2025 03:15:49 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 16/31] accel/system: Document cpu_synchronize_state() Date: Fri, 4 Jul 2025 12:14:17 +0200 Message-ID: <20250704101433.8813-17-philmd@linaro.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250704101433.8813-1-philmd@linaro.org> References: <20250704101433.8813-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::330; envelope-from=philmd@linaro.org; helo=mail-wm1-x330.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1751624399869116600 Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson Reviewed-by: Zhao Liu Message-Id: <20250703173248.44995-23-philmd@linaro.org> --- include/system/accel-ops.h | 8 ++++++++ include/system/hw_accel.h | 13 +++++++++++-- 2 files changed, 19 insertions(+), 2 deletions(-) diff --git a/include/system/accel-ops.h b/include/system/accel-ops.h index 4c99d25aeff..55f91cea25d 100644 --- a/include/system/accel-ops.h +++ b/include/system/accel-ops.h @@ -42,6 +42,14 @@ struct AccelOpsClass { =20 void (*synchronize_post_reset)(CPUState *cpu); void (*synchronize_post_init)(CPUState *cpu); + /** + * synchronize_state: + * synchronize_pre_loadvm: + * @cpu: The vCPU to synchronize. + * + * Request to synchronize QEMU vCPU registers from the hardware accele= rator + * (the hardware accelerator is the reference). + */ void (*synchronize_state)(CPUState *cpu); void (*synchronize_pre_loadvm)(CPUState *cpu); void (*synchronize_pre_resume)(bool step_pending); diff --git a/include/system/hw_accel.h b/include/system/hw_accel.h index 380e9e640b6..574c9738408 100644 --- a/include/system/hw_accel.h +++ b/include/system/hw_accel.h @@ -17,9 +17,18 @@ #include "system/whpx.h" #include "system/nvmm.h" =20 +/** + * cpu_synchronize_state: + * cpu_synchronize_pre_loadvm: + * @cpu: The vCPU to synchronize. + * + * Request to synchronize QEMU vCPU registers from the hardware accelerator + * (the hardware accelerator is the reference). + */ void cpu_synchronize_state(CPUState *cpu); -void cpu_synchronize_post_reset(CPUState *cpu); -void cpu_synchronize_post_init(CPUState *cpu); void cpu_synchronize_pre_loadvm(CPUState *cpu); =20 +void cpu_synchronize_post_reset(CPUState *cpu); +void cpu_synchronize_post_init(CPUState *cpu); + #endif /* QEMU_HW_ACCEL_H */ --=20 2.49.0 From nobody Sat Dec 13 22:54:06 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1751624391; cv=none; d=zohomail.com; s=zohoarc; b=Rt4CQvMZZecHwsX1drO2Z2cl3iiqnferH+egNLG0HkHPAA5IajRWJnHfZjV0IGqXKPahSwkhKheAp3D4kCCdLuJFOJtN+zvGRrhMxd61jogb698XLFl2j9ACN+uhKub4A4ThPY0JECdmjRxIhVnr3Had4ARGWwHKlFeE+dP5+ow= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1751624391; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=DHgtj6RnlNfzvgIpTQEpgIYEYW1t3P49hcW2EZzF7SM=; b=UELiGY795eLsbpTYu4IYcDHLiSUPg3LZAWfzpd9aFrt8VnmBfcLU0UYFt+6H2unNUPQinwj2gSx/twZrvJyszg5vDNJe+b5YS5hSQa5ot0nJ+NSz16nTVdtmBar2QFNYnuVO9PgIdYCahnfHjYv0SixLJtBmYca11MvtMkl3kZQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1751624391843971.013722941183; Fri, 4 Jul 2025 03:19:51 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uXdSh-0007Pf-Ua; Fri, 04 Jul 2025 06:16:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uXdSe-0007Am-6t for qemu-devel@nongnu.org; Fri, 04 Jul 2025 06:16:04 -0400 Received: from mail-wr1-x436.google.com ([2a00:1450:4864:20::436]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uXdSY-0006rn-05 for qemu-devel@nongnu.org; Fri, 04 Jul 2025 06:16:03 -0400 Received: by mail-wr1-x436.google.com with SMTP id ffacd0b85a97d-3a5123c1533so325651f8f.2 for ; Fri, 04 Jul 2025 03:15:56 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b4708d0941sm2089446f8f.26.2025.07.04.03.15.53 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 04 Jul 2025 03:15:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1751624155; x=1752228955; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=DHgtj6RnlNfzvgIpTQEpgIYEYW1t3P49hcW2EZzF7SM=; b=azg+bDI3ht9DWYNGe2XFlE1gfttU0S5Sr977BejvAq1THbXSIgyd4b/QvQnrMt2qDt l7WV66WUoDdPEHvayZHlP9dTNyXh5mwLiCREdkUnZD4wR5ku8mwRyO9nvgjPCK91XrkD H26OZAcfQhYeYOoqTWoXOfyrQd+O2vGEU9OgktDg4E/vbYNBfh021SvLzxqXFuassst8 V4aTf84Xv+yf+1aM6HmeQKzxHCAX7PqsCagdYKKkRP46/PmOtpMNlwzK0UuqYvcbdshQ E/2w0R4hrKJymLjq4Sc72Vlpz6m12Mul2J55tNvn6d/Bjh7zZhOfQLX8Ij/7ZXOkfMvw a1oA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751624155; x=1752228955; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DHgtj6RnlNfzvgIpTQEpgIYEYW1t3P49hcW2EZzF7SM=; b=ih2L/WYo+APfkhgqIdLRhv742TK2AOfEUXMJn5VaNqlhUPcNd48KMmKlG5VNsiWf/9 X0XbFCa5PhTRPqoQEWpHORWP09HXEey0HjZhwXbOIBne8Y/TBmCTyM65pe9bcgQmu1OR FL4oNt/U8NxnQ49xAZkTEd+8Gb1dYtn8ZGrsl9T2AzO3tX6KuFONsCdrUwSVjf2WY4HH /0WrGPbDmSdrhyrdLau7qx/JYQh8nS9nEYHCD/ZKcbWCai2mfgn+SsDEkk1nuwAueflU hPsrR66Gd7Yz8fMN4/Yxs9BA4wg3cKCTAyYnbQ4x3fmp9w4lONaaaxsVglHElgO1N3rN vg7g== X-Gm-Message-State: AOJu0Yy61G4LQ1ajFnKcEciQICZ8NhtCahcOQFRzD7xjpCP6nuGjEwjP JtR6LnXw+M+708lJnNsOFm7C4N7zKlzG2eys/xplmTOwp7iDzEfcqO4yMMF+tF6dThf5/A3+tOK 1945PARA= X-Gm-Gg: ASbGnctf6aHFX/TOmZnNi64Qbq6Gb/FtuiJ7wWFTd4OOI8jnR8SWYgsDcgNaCZ6HULs G60OJXn4KxXYC6PsV1DA7lgs7/VH89d1Ct0MDLFfTnYNU07+RikqX93qsvMNED+jdBO/vREpznH dXK5ySBmlk21s2U5DlBe/e2UhCCnhsZm5+TLlGVIDST2Io10DjqAHkX2Naje2/8h9q3pYbLoPjT 1dKD2JZUBnQxjXgFf5PoqExH4U6vSHGXra6ak15esasAVSAnUjIHaZZWbOIm2W1G3SWnqlbdJQd xaTMpvh5EZi9sNy5QUzhV7emXKxYPjrtKQNQSRx90JyDK5AVvXQBHCX7IkzcS1DpHn1xh0GDLwS LNsMs9JA6Na+x6bBSDxJIvjw3OvtT/64zwpHSqluT0qCNcCg= X-Google-Smtp-Source: AGHT+IEaNnX+oIdu/VkZGU35Zogc/geR0mUa6T6yx5sAQqFiI6/BgfPPo+rrsD6g3OkXg/7z6+rm2w== X-Received: by 2002:a5d:64e7:0:b0:3a4:ddde:13e4 with SMTP id ffacd0b85a97d-3b4964ee263mr1564110f8f.58.1751624154613; Fri, 04 Jul 2025 03:15:54 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 17/31] accel/system: Document cpu_synchronize_state_post_init/reset() Date: Fri, 4 Jul 2025 12:14:18 +0200 Message-ID: <20250704101433.8813-18-philmd@linaro.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250704101433.8813-1-philmd@linaro.org> References: <20250704101433.8813-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::436; envelope-from=philmd@linaro.org; helo=mail-wr1-x436.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1751624393758116600 Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson Reviewed-by: Zhao Liu Message-Id: <20250703173248.44995-24-philmd@linaro.org> --- include/system/accel-ops.h | 8 ++++++++ include/system/hw_accel.h | 8 ++++++++ 2 files changed, 16 insertions(+) diff --git a/include/system/accel-ops.h b/include/system/accel-ops.h index 55f91cea25d..a4e706b49c9 100644 --- a/include/system/accel-ops.h +++ b/include/system/accel-ops.h @@ -40,6 +40,14 @@ struct AccelOpsClass { void (*kick_vcpu_thread)(CPUState *cpu); bool (*cpu_thread_is_idle)(CPUState *cpu); =20 + /** + * synchronize_post_reset: + * synchronize_post_init: + * @cpu: The vCPU to synchronize. + * + * Request to synchronize QEMU vCPU registers to the hardware accelera= tor + * (QEMU is the reference). + */ void (*synchronize_post_reset)(CPUState *cpu); void (*synchronize_post_init)(CPUState *cpu); /** diff --git a/include/system/hw_accel.h b/include/system/hw_accel.h index 574c9738408..fa9228d5d2d 100644 --- a/include/system/hw_accel.h +++ b/include/system/hw_accel.h @@ -28,6 +28,14 @@ void cpu_synchronize_state(CPUState *cpu); void cpu_synchronize_pre_loadvm(CPUState *cpu); =20 +/** + * cpu_synchronize_post_reset: + * cpu_synchronize_post_init: + * @cpu: The vCPU to synchronize. + * + * Request to synchronize QEMU vCPU registers to the hardware accelerator + * (QEMU is the reference). + */ void cpu_synchronize_post_reset(CPUState *cpu); void cpu_synchronize_post_init(CPUState *cpu); =20 --=20 2.49.0 From nobody Sat Dec 13 22:54:06 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1751624228; cv=none; d=zohomail.com; s=zohoarc; b=NF+z+rOEKngErToGS8aSK9y5JdwWK0orB31fE6LXdX8uu0YXO87ybxUnqvLvoltCqQXAJZqMYriBk7D+Bt3FcI0hfAjFrl+3YUiheuNDsxg/8tpWpTkW7rfHQ+fJhS7y9p2yhezTGP/Y2pbPb9klm83Q13ZcvdC1okX2eRcAKq4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1751624228; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=iCBsSrpa7kKZRsqPbYchBfWXs8TNxgSCBY8aXqIgO9o=; b=PYvscxzZ9G0ABw32Up0fWxyMKEfw6xSxageoZ/OJ6jWqyLTq6zR4+mwwQQHoRnecXrjDVMacJ8487KgbwJ9c+fyjO++39xD5G9scYfXZFu1sL50BAH54krBZIOWqBemAvBjBX+gsY4oEi5LrhzdZay5KiNklNkHZe76p18PzTP4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1751624228724766.5006765152474; Fri, 4 Jul 2025 03:17:08 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uXdSf-0007DO-Vh; Fri, 04 Jul 2025 06:16:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uXdSc-00070o-VP for qemu-devel@nongnu.org; Fri, 04 Jul 2025 06:16:03 -0400 Received: from mail-wr1-x431.google.com ([2a00:1450:4864:20::431]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uXdSb-0006sS-52 for qemu-devel@nongnu.org; Fri, 04 Jul 2025 06:16:02 -0400 Received: by mail-wr1-x431.google.com with SMTP id ffacd0b85a97d-3a6e8b1fa37so541458f8f.2 for ; Fri, 04 Jul 2025 03:16:00 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b47030bd58sm2163100f8f.18.2025.07.04.03.15.58 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 04 Jul 2025 03:15:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1751624159; x=1752228959; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=iCBsSrpa7kKZRsqPbYchBfWXs8TNxgSCBY8aXqIgO9o=; b=JzF3nY5PYBSrTRNtKGmwVRrfTAVH9EqioxgrIUegSv29aFlY3vM6lYwsm/wMZQzjHy Ai7++/5a9hsG9rVhwIJto3+CymiXxGg2O0sH6TzVib+tY0523P7ZlCKM9TH/N9otbclY MLwXS1/a0rJfuicLWeJTOZg8hdasweaqpMufeVZ65WXZ5dGo5RK7NCmeqqvE5pTvJI6X /FUp48vq9f8WZPIbolCE3ZmkfCObwWTRSBhcFvehJ3CE2xlK1I4/qH2RgcCj6/pLJCvP 3j7mq2c0pIqECPdunMQZdxeBIP2tZVGzgK99sVi3cicBdZGEI8DfhEbLX4TbRYejp7rm QSTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751624159; x=1752228959; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=iCBsSrpa7kKZRsqPbYchBfWXs8TNxgSCBY8aXqIgO9o=; b=IQ+4gdIHepbrJdv467qBwqEKZ3bDlssAyXGwqVkYTlYy1NP4fmcv+xsV9quPc6IAKL WDfkajgNkkIyjanN1JVMfr6BmMkhHt63Zzsb0WckLDg3dG2dgxBjnM5nwNQq5QhTEXEz Kvw+RwJxYDRzhe0zmzGla5vwkd8xyAtsPWT9WCJ8yiSYhdyc0U9aByRusHmn7mITh50P /Hzr/3a+yLXTxNuqLfKMcK382Xu1PGR3DngGUGL92nHjVmgnB2XmI8kkuxuvDpwgt3+K ICeUWARkhOsM5LJoHjHgfZ25QJHhHMJanG6SdqF91wrJcb5RhDCFgGNzes7XlKp33TmO xNKg== X-Gm-Message-State: AOJu0YzlOz4qUGsIDtw3Y/aZwwFe8U6O6ctOEnyNRBR3Q6nactp9+Gdl GUYeuk39HAQcwtfyJTweWL3qO9MxByIUjIipvgNaqN0sPfb0KjU9XZrqZGknOKvtd2Lhayg91a3 ovqUrFBE= X-Gm-Gg: ASbGncuQe06u05+oM+w1UdVcIGFHYy42kvZAkUZ21Lei8kC/2vmeGPrz0LlRcG4u2NQ bkPY6jZg//NjSLyOo1tNhlbaHOH9bC9L4AfBjxR5yk8yKuHkRDMP1itDir1k/hovyoHIhZT2bN/ aU8wBbMeQdfLmudzHrGGM3Uo210deYOpZR3kkk6o+lccAwMSd5y5ccVg5RTuFmcH1P3kegtXe1i w2NffNAP8YQlqOuH2z+0Z0A89aFx0jcBQauuaD0dyvUINxNoSAnci2NTGpwQmwblzZQRoqQ/e/Q NKaLWcNq31SjMHYOBKbpH8jBycGb4eKwDTaqS4GKiKpZh3lGOUCQfyni11wiukWfEcf3zwWb0hh CPuc2ET01QME4W0bkgpFbnHThONntAb54Fl8eAT+JwQgiRZQ= X-Google-Smtp-Source: AGHT+IGNo6+7pqfNonk66Q+1btjZHpV+9qRaR9LGIeoqL/H8EA3GMzakhXFVXr7r9uvccoxuyRA/pg== X-Received: by 2002:a05:6000:208a:b0:3a4:e7d3:bd9c with SMTP id ffacd0b85a97d-3b4964fa66bmr1668359f8f.17.1751624159153; Fri, 04 Jul 2025 03:15:59 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 18/31] accel/nvmm: Expose nvmm_enabled() to common code Date: Fri, 4 Jul 2025 12:14:19 +0200 Message-ID: <20250704101433.8813-19-philmd@linaro.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250704101433.8813-1-philmd@linaro.org> References: <20250704101433.8813-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::431; envelope-from=philmd@linaro.org; helo=mail-wr1-x431.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1751624229776116600 Currently nvmm_enabled() is restricted to target-specific code. By defining CONFIG_NVMM_IS_POSSIBLE we allow its use anywhere. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson Reviewed-by: Zhao Liu Message-Id: <20250703173248.44995-25-philmd@linaro.org> --- MAINTAINERS | 1 + include/system/nvmm.h | 23 ++++++++++++----------- accel/stubs/nvmm-stub.c | 12 ++++++++++++ target/i386/nvmm/nvmm-all.c | 8 +------- accel/stubs/meson.build | 1 + 5 files changed, 27 insertions(+), 18 deletions(-) create mode 100644 accel/stubs/nvmm-stub.c diff --git a/MAINTAINERS b/MAINTAINERS index b1cbfe115bc..c73468b2422 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -586,6 +586,7 @@ NetBSD Virtual Machine Monitor (NVMM) CPU support M: Reinoud Zandijk S: Maintained F: include/system/nvmm.h +F: accel/stubs/nvmm-stub.c F: target/i386/nvmm/ =20 Hosts diff --git a/include/system/nvmm.h b/include/system/nvmm.h index 6971ddb3a5a..7390def9adb 100644 --- a/include/system/nvmm.h +++ b/include/system/nvmm.h @@ -13,17 +13,18 @@ #define QEMU_NVMM_H =20 #ifdef COMPILING_PER_TARGET - -#ifdef CONFIG_NVMM - -int nvmm_enabled(void); - -#else /* CONFIG_NVMM */ - -#define nvmm_enabled() (0) - -#endif /* CONFIG_NVMM */ - +# ifdef CONFIG_NVMM +# define CONFIG_NVMM_IS_POSSIBLE +# endif /* !CONFIG_NVMM */ +#else +# define CONFIG_NVMM_IS_POSSIBLE #endif /* COMPILING_PER_TARGET */ =20 +#ifdef CONFIG_NVMM_IS_POSSIBLE +extern bool nvmm_allowed; +#define nvmm_enabled() (nvmm_allowed) +#else /* !CONFIG_NVMM_IS_POSSIBLE */ +#define nvmm_enabled() 0 +#endif /* !CONFIG_NVMM_IS_POSSIBLE */ + #endif /* QEMU_NVMM_H */ diff --git a/accel/stubs/nvmm-stub.c b/accel/stubs/nvmm-stub.c new file mode 100644 index 00000000000..ec14837501a --- /dev/null +++ b/accel/stubs/nvmm-stub.c @@ -0,0 +1,12 @@ +/* + * NVMM stubs for QEMU + * + * Copyright (c) Linaro + * + * SPDX-License-Identifier: GPL-2.0-or-later + */ + +#include "qemu/osdep.h" +#include "system/nvmm.h" + +bool nvmm_allowed; diff --git a/target/i386/nvmm/nvmm-all.c b/target/i386/nvmm/nvmm-all.c index aea61a6fd2a..2df49d7eeb4 100644 --- a/target/i386/nvmm/nvmm-all.c +++ b/target/i386/nvmm/nvmm-all.c @@ -46,7 +46,7 @@ struct qemu_machine { =20 /* -----------------------------------------------------------------------= --- */ =20 -static bool nvmm_allowed; +bool nvmm_allowed; static struct qemu_machine qemu_mach; =20 static struct nvmm_machine * @@ -1192,12 +1192,6 @@ nvmm_accel_init(MachineState *ms) return 0; } =20 -int -nvmm_enabled(void) -{ - return nvmm_allowed; -} - static void nvmm_accel_class_init(ObjectClass *oc, const void *data) { diff --git a/accel/stubs/meson.build b/accel/stubs/meson.build index 8ca1a4529e2..4c34287215f 100644 --- a/accel/stubs/meson.build +++ b/accel/stubs/meson.build @@ -3,5 +3,6 @@ system_stubs_ss.add(when: 'CONFIG_XEN', if_false: files('xe= n-stub.c')) system_stubs_ss.add(when: 'CONFIG_KVM', if_false: files('kvm-stub.c')) system_stubs_ss.add(when: 'CONFIG_TCG', if_false: files('tcg-stub.c')) system_stubs_ss.add(when: 'CONFIG_HVF', if_false: files('hvf-stub.c')) +system_stubs_ss.add(when: 'CONFIG_NVMM', if_false: files('nvmm-stub.c')) =20 specific_ss.add_all(when: ['CONFIG_SYSTEM_ONLY'], if_true: system_stubs_ss) --=20 2.49.0 From nobody Sat Dec 13 22:54:06 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1751624394; cv=none; d=zohomail.com; s=zohoarc; b=WfM5sAwrmLF5H1vTk4sYnu/Xp1wmQ+j4trBNEcq7We46M1SRLsEbTXjOXxPV8kbaE8yz9JTUap0nDELc2SFUI32OkndRHUzhur2bSrxx/WSZv4qHbxgYQjfP+Z+AOJ5cp/sLjRJn9UU7qM5d93Lnu06e3X71P3VnM92U2vzEuYQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1751624394; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=2hGQxE/nkF7+o6yQ+EIWRMLcUDg7UbkORknvxDV9Va8=; b=LT2Aor02WdN53PzvmZaAVgpn19Sf1mp6oP9bCJi32o+P2VECMhrKtZG2W6lRbmQmLpJ+z2qNpZTv+c9O6VLVNADZZIHnLiHH5hkPjiSsqDqhmFaoP8zdDKzmy/w3AFGx8rSuQ3HZ3vLbajU0WbsrOvhwB0kgJm+q5qRDsG7zlhE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1751624394790968.823270508128; Fri, 4 Jul 2025 03:19:54 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uXdSn-0007bo-V2; Fri, 04 Jul 2025 06:16:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uXdSl-0007WN-69 for qemu-devel@nongnu.org; Fri, 04 Jul 2025 06:16:11 -0400 Received: from mail-wm1-x32a.google.com ([2a00:1450:4864:20::32a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uXdSh-0006t6-Qz for qemu-devel@nongnu.org; Fri, 04 Jul 2025 06:16:10 -0400 Received: by mail-wm1-x32a.google.com with SMTP id 5b1f17b1804b1-45348bff79fso8375125e9.2 for ; Fri, 04 Jul 2025 03:16:06 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b471b966cbsm2071216f8f.49.2025.07.04.03.16.02 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 04 Jul 2025 03:16:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1751624164; x=1752228964; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=2hGQxE/nkF7+o6yQ+EIWRMLcUDg7UbkORknvxDV9Va8=; b=F/mZ66zqhc0EEWHsp2EMrMVqdcx0KVkOkiTIiHGrQeFpP3s2KbDuqPg7rqswjRrO9l dUh92ltHAmBG1qn/wh9veTk6c+2XCbnhwnaUk1+KDjHfkjWgekErj7+GBVxU4NFbY3jh kqrhLaCOPKHmbxA9/fZZvMOxxdeMp5x8tPc0igOrpFnpKMBzhC8pGpzF6d7cMjCFeGOs nHXS9+6qz1c+I3hwtwQbSj/mP5qCmrqMeUC8BuexXUef3TUEj0w1cwuAnM9J1FVkgaqm cYFydAm0WqQpWc4L0cjUOcPNVcwLZsU7gH/OfYItTw5SUMvST48QkAw5jcCEziGH7Y0n h4sQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751624164; x=1752228964; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2hGQxE/nkF7+o6yQ+EIWRMLcUDg7UbkORknvxDV9Va8=; b=dXSjTt0TFj89JcyjGtnet0El9exSxl1c7eusxZmFUuAzBq0ijFViABdT4dw931qldj z32CRBtbucx8pHKv/SBz9gWAftdSJlVBUUrgO6ij7nd8t4IwU41lM2Fe2yEK7UvckSVc el08YjSMj1QeHC03Es+up1VO/I7SDc3v9bIexj14WVYmB8vevNTl0+dYumDgp3XoZuZD 27vP/odpmRpc5x15cOv2C6aTsU6hqAR1wHTDpYF9H3nZxrhelG2/vJzCyp29lXIgWFh8 +ixPEdUoSdXUnVGsIY0xTAZpb8JMv4qQnMmVEuOAl58FIKKTUWy0nuEVPWunjLdrUTsL Cg4A== X-Gm-Message-State: AOJu0YxHvOqkgOl1YIirRynYkPoZhCvjQyxxNihRA1cwA444OqRjsKkC D1IyiP4cNQ3QGjfn1NGuocgzvvOF0fFFBj4SmpLQrXv8cHRhubtwrbnVOvkL43c3CZL72Fq4kRw X8EqI/jA= X-Gm-Gg: ASbGncuJtnotmEJbN+hO9ISVUGMJJBNhBy/3ju049LBTJwZGD1fVFpWrV+VcHpvXA+b c3SIUEmSKjKWbnnBB3wMwZgbUUDQgq2gHX8OzPhu2e8lLU17oOAPF3/RQCmXyGfbo8TYy6WiXtI 7d5WzVAiU06BOW8GL5mxSRZb8nDJO0QA7Tg/88F+zzheksmwCnhh/5si+5VD4BRN2XSbwoo+cad PFVMag5meuv37XSkO8RXUwEVbSORPaMS4Ev2KrtKAmAWBP8Pv5OrHYbyLmn3nMKM26oYKJu/2yP WqkvwG1X0fFPpzRtCTUah7bxZQstTlLKPHouwNAdQLJX0xFRs302QF2jjw1asqrh+TUFgaVbPWS epcGJNkNnuxFbxuIbwkR+O02oav7a+IJzrK3F X-Google-Smtp-Source: AGHT+IFgO5yTQmiiu8p9KK4SH12rMRpiUyADuCIMwW+DkrTt+rZ4yzNhETPxk0kkcjyXhg4EoNZYxQ== X-Received: by 2002:a05:600c:4689:b0:439:643a:c8d5 with SMTP id 5b1f17b1804b1-454b819befdmr1541635e9.0.1751624163869; Fri, 04 Jul 2025 03:16:03 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 19/31] accel/whpx: Expose whpx_enabled() to common code Date: Fri, 4 Jul 2025 12:14:20 +0200 Message-ID: <20250704101433.8813-20-philmd@linaro.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250704101433.8813-1-philmd@linaro.org> References: <20250704101433.8813-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32a; envelope-from=philmd@linaro.org; helo=mail-wm1-x32a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1751624395834116600 Currently whpx_enabled() is restricted to target-specific code. By defining CONFIG_WHPX_IS_POSSIBLE we allow its use anywhere. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson Message-Id: <20250703173248.44995-26-philmd@linaro.org> --- MAINTAINERS | 1 + include/system/whpx.h | 27 ++++++++++++++------------- accel/stubs/whpx-stub.c | 12 ++++++++++++ target/i386/whpx/whpx-all.c | 7 +------ accel/stubs/meson.build | 1 + 5 files changed, 29 insertions(+), 19 deletions(-) create mode 100644 accel/stubs/whpx-stub.c diff --git a/MAINTAINERS b/MAINTAINERS index c73468b2422..0fd8b2a4e61 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -540,6 +540,7 @@ WHPX CPUs M: Sunil Muthuswamy S: Supported F: target/i386/whpx/ +F: accel/stubs/whpx-stub.c F: include/system/whpx.h =20 X86 Instruction Emulator diff --git a/include/system/whpx.h b/include/system/whpx.h index 00ff409b682..00f6a3e5236 100644 --- a/include/system/whpx.h +++ b/include/system/whpx.h @@ -16,19 +16,20 @@ #define QEMU_WHPX_H =20 #ifdef COMPILING_PER_TARGET - -#ifdef CONFIG_WHPX - -int whpx_enabled(void); -bool whpx_apic_in_platform(void); - -#else /* CONFIG_WHPX */ - -#define whpx_enabled() (0) -#define whpx_apic_in_platform() (0) - -#endif /* CONFIG_WHPX */ - +# ifdef CONFIG_WHPX +# define CONFIG_WHPX_IS_POSSIBLE +# endif /* !CONFIG_WHPX */ +#else +# define CONFIG_WHPX_IS_POSSIBLE #endif /* COMPILING_PER_TARGET */ =20 +#ifdef CONFIG_WHPX_IS_POSSIBLE +extern bool whpx_allowed; +#define whpx_enabled() (whpx_allowed) +bool whpx_apic_in_platform(void); +#else /* !CONFIG_WHPX_IS_POSSIBLE */ +#define whpx_enabled() 0 +#define whpx_apic_in_platform() (0) +#endif /* !CONFIG_WHPX_IS_POSSIBLE */ + #endif /* QEMU_WHPX_H */ diff --git a/accel/stubs/whpx-stub.c b/accel/stubs/whpx-stub.c new file mode 100644 index 00000000000..c564c89fd0b --- /dev/null +++ b/accel/stubs/whpx-stub.c @@ -0,0 +1,12 @@ +/* + * WHPX stubs for QEMU + * + * Copyright (c) Linaro + * + * SPDX-License-Identifier: GPL-2.0-or-later + */ + +#include "qemu/osdep.h" +#include "system/whpx.h" + +bool whpx_allowed; diff --git a/target/i386/whpx/whpx-all.c b/target/i386/whpx/whpx-all.c index 5001afad3a7..94fd5fc7849 100644 --- a/target/i386/whpx/whpx-all.c +++ b/target/i386/whpx/whpx-all.c @@ -242,7 +242,7 @@ struct AccelCPUState { WHV_RUN_VP_EXIT_CONTEXT exit_ctx; }; =20 -static bool whpx_allowed; +bool whpx_allowed; static bool whp_dispatch_initialized; static HMODULE hWinHvPlatform, hWinHvEmulation; static uint32_t max_vcpu_index; @@ -2688,11 +2688,6 @@ error: return ret; } =20 -int whpx_enabled(void) -{ - return whpx_allowed; -} - bool whpx_apic_in_platform(void) { return whpx_global.apic_in_platform; } diff --git a/accel/stubs/meson.build b/accel/stubs/meson.build index 4c34287215f..9dfc4f9ddaf 100644 --- a/accel/stubs/meson.build +++ b/accel/stubs/meson.build @@ -4,5 +4,6 @@ system_stubs_ss.add(when: 'CONFIG_KVM', if_false: files('kv= m-stub.c')) system_stubs_ss.add(when: 'CONFIG_TCG', if_false: files('tcg-stub.c')) system_stubs_ss.add(when: 'CONFIG_HVF', if_false: files('hvf-stub.c')) system_stubs_ss.add(when: 'CONFIG_NVMM', if_false: files('nvmm-stub.c')) +system_stubs_ss.add(when: 'CONFIG_WHPX', if_false: files('whpx-stub.c')) =20 specific_ss.add_all(when: ['CONFIG_SYSTEM_ONLY'], if_true: system_stubs_ss) --=20 2.49.0 From nobody Sat Dec 13 22:54:06 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1751624461; cv=none; d=zohomail.com; s=zohoarc; b=lbqfx30/UegZrqwO3Z7vl/NbkxGHAONQzQWRtTsnB7RIdAah39Bddl2X/L0F+l/J9SeAvVkZzUzyJcehWfhXXra3pIYT5l9Z3TRZQm8dJsSmGlr0txnzfa2rxul+27h8NPYi/DWAUspUl7/8Z+3qPJ0/SffWDZtRaxMGDrA2dyI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1751624461; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=eLugPiCaiIPoDJ+xihdsj48/eAMyy0a5nMvy9lICya8=; b=MGHweZuBIp8pY5NWHuWHnJp6hNzvlUA+s8LqkKs49z8w2zhWb5PFavoPBIfxAn56McXHF/Mfm/84VeCa6/1O+jJzrv3aFHD2r7PW76Otlw+6RUVdhGT2Ba90/PRCV0nNpWSys0s/SzCkVNcPWrA6D2Ogi+eMW0oGRKZB7dxdvJg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1751624461053667.1080037892289; Fri, 4 Jul 2025 03:21:01 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uXdSu-0007ro-FO; Fri, 04 Jul 2025 06:16:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uXdSn-0007bp-FL for qemu-devel@nongnu.org; Fri, 04 Jul 2025 06:16:13 -0400 Received: from mail-wm1-x334.google.com ([2a00:1450:4864:20::334]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uXdSl-0006uX-Ah for qemu-devel@nongnu.org; Fri, 04 Jul 2025 06:16:13 -0400 Received: by mail-wm1-x334.google.com with SMTP id 5b1f17b1804b1-450cf0120cdso5767535e9.2 for ; Fri, 04 Jul 2025 03:16:10 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-454a9be5bbfsm50663475e9.34.2025.07.04.03.16.07 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 04 Jul 2025 03:16:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1751624169; x=1752228969; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=eLugPiCaiIPoDJ+xihdsj48/eAMyy0a5nMvy9lICya8=; b=yOBOCCDsD+2jcSoQzEOj2uOMP4eQGmWjlV8bXX9xZMJPTWdeYlH1Y/3zQNFcqDKZB+ kDDn/dx0E9ymmHUYSPax7Y5MDLoFDhX7BJ4czxUyUw9dnpNn39IIbQvAT60mcfkGVMXl Z5q7AX3prAlWhkWJ0CQTZFezeWyOcefJBFz0/b9sxVs7R9ZNCc0F9/BWNOe/THi2e7Ec cZz/yzIHSR85wtyf9Nv4vD+YfDgNqlDAooKbz1DFaYKw09SxYepanSAFJH2PXC9iOyAj wo10Shuq6ZaCGmyisjo3ERtfnYY3VAzL8pUw/W+Qn+h75kXSUBbLy5xmmIiJ87kHW2sy 3l0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751624169; x=1752228969; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=eLugPiCaiIPoDJ+xihdsj48/eAMyy0a5nMvy9lICya8=; b=hKi0CnDrH0tOjwEg4Cv/ScvIesYi6EaY2xOCv2QUp2MJymASqPlYLwQoLAvr55Da/S liI+mMEU2BZ2BfDtlBqhjjWtg88xOPkt4EYr4U414oYGLNKmrykK8HJzV3rApkYDXuJS AdVM1n6nankgGUMd7f2Dt9sdnVX2IfPeidvERm3LrU2DQ1mZQAaKp5kT2De/Vxdcc71t Oheq9BpcqGKdkdxmMnvWYj1HggETeMG8qfEeNDVL10R9NPgdbzXdJPmDL1qkEeAOFHcJ doZAinzj3Jt4kCc9Phbh1AkYJ2uzXlcDTAbmZ3P8Sdrmfwdsu27QIXngyzGzWBFqBhsz xTMg== X-Gm-Message-State: AOJu0YzTw1KiMaQynZSzsNAANEbm6z1pOpky/oxqUvIXu9XundLCA0Hk jFm8fk6gbEjFi81CduZFk5wwnjWyM0iSwHjMyAfXTLVurbhcH7OyytNC8RsPNFZrMu+W8UtxAmh +6Il/2J8= X-Gm-Gg: ASbGnctB+9aTM7ybF22FniYOTETp/+e+PScVF/bC/eRUU2VO2Ro9f2c9SKtjemUgQ9H RRe8Po6mOEc2p9zbtSTWPQKQ9xc8PvcxWpIEQLz4oBb/YKxHHWU/82U/F18KPENhNRHxHnpOX7o b85A0A1kt+3tQBCrZ1S4j4tV24Jq8wA3VATVPBM7w/OJLYRCS/Gl8XdUdtorQMwPAFN2hnkLKqV 97pLomNz4XHOdxDoRd5pT1MMdjPIzxzwJtYQHyKlZDZXEO9jOdCa6FXx1EHM4aUzk3OVh+rYrHq 3ER0MrW4cNKX01V9tCJfr/iyoFc9lZQAOSAUxW7Gu4tptriOE/sB4IUWQ03Q3vMOuLM5iCrYTtO UKTs4vTwkFnANgfqT/MOrOov/iazBcgP/Jy/X X-Google-Smtp-Source: AGHT+IEJBADweT8GYL07R9mTSwjfLWLAHQeZ0BPabF17A6gc7gIOa03HH81Zaz21CYVuztClcwQNtQ== X-Received: by 2002:a05:600c:3b11:b0:43d:ac5:11e8 with SMTP id 5b1f17b1804b1-454b4ead65emr12792475e9.21.1751624168521; Fri, 04 Jul 2025 03:16:08 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 20/31] accel/dummy: Extract 'dummy-cpus.h' header from 'system/cpus.h' Date: Fri, 4 Jul 2025 12:14:21 +0200 Message-ID: <20250704101433.8813-21-philmd@linaro.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250704101433.8813-1-philmd@linaro.org> References: <20250704101433.8813-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::334; envelope-from=philmd@linaro.org; helo=mail-wm1-x334.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1751624462562116600 'dummy' helpers are specific to accelerator implementations, no need to expose them via "system/cpus.h". Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson Reviewed-by: Xiaoyao Li Message-Id: <20250703173248.44995-27-philmd@linaro.org> --- MAINTAINERS | 1 + accel/dummy-cpus.h | 14 ++++++++++++++ include/system/cpus.h | 5 ----- accel/dummy-cpus.c | 1 + accel/qtest/qtest.c | 1 + accel/xen/xen-all.c | 1 + 6 files changed, 18 insertions(+), 5 deletions(-) create mode 100644 accel/dummy-cpus.h diff --git a/MAINTAINERS b/MAINTAINERS index 0fd8b2a4e61..fca98e12195 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -503,6 +503,7 @@ F: include/system/accel-*.h F: include/system/cpus.h F: include/accel/accel-cpu*.h F: accel/accel-*.? +F: accel/dummy-cpus.? F: accel/Makefile.objs F: accel/stubs/Makefile.objs F: cpu-common.c diff --git a/accel/dummy-cpus.h b/accel/dummy-cpus.h new file mode 100644 index 00000000000..d18dd0fdc51 --- /dev/null +++ b/accel/dummy-cpus.h @@ -0,0 +1,14 @@ +/* + * Dummy cpu thread code + * + * Copyright IBM, Corp. 2011 + * + * SPDX-License-Identifier: GPL-2.0-or-later + */ + +#ifndef ACCEL_DUMMY_CPUS_H +#define ACCEL_DUMMY_CPUS_H + +void dummy_start_vcpu_thread(CPUState *cpu); + +#endif diff --git a/include/system/cpus.h b/include/system/cpus.h index 3226c765d01..69be6a77a75 100644 --- a/include/system/cpus.h +++ b/include/system/cpus.h @@ -7,11 +7,6 @@ void cpus_register_accel(const AccelOpsClass *i); /* return registers ops */ const AccelOpsClass *cpus_get_accel(void); =20 -/* accel/dummy-cpus.c */ - -/* Create a dummy vcpu for AccelOpsClass->create_vcpu_thread */ -void dummy_start_vcpu_thread(CPUState *); - /* interface available for cpus accelerator threads */ =20 /* For temporary buffers for forming a name */ diff --git a/accel/dummy-cpus.c b/accel/dummy-cpus.c index 867276144fa..03cfc0fa01e 100644 --- a/accel/dummy-cpus.c +++ b/accel/dummy-cpus.c @@ -17,6 +17,7 @@ #include "qemu/guest-random.h" #include "qemu/main-loop.h" #include "hw/core/cpu.h" +#include "accel/dummy-cpus.h" =20 static void *dummy_cpu_thread_fn(void *arg) { diff --git a/accel/qtest/qtest.c b/accel/qtest/qtest.c index 92bed9264ce..612cede160b 100644 --- a/accel/qtest/qtest.c +++ b/accel/qtest/qtest.c @@ -24,6 +24,7 @@ #include "qemu/guest-random.h" #include "qemu/main-loop.h" #include "hw/core/cpu.h" +#include "accel/dummy-cpus.h" =20 static int64_t qtest_clock_counter; =20 diff --git a/accel/xen/xen-all.c b/accel/xen/xen-all.c index de52a8f882a..c150dd43cab 100644 --- a/accel/xen/xen-all.c +++ b/accel/xen/xen-all.c @@ -18,6 +18,7 @@ #include "hw/xen/xen_igd.h" #include "chardev/char.h" #include "qemu/accel.h" +#include "accel/dummy-cpus.h" #include "system/accel-ops.h" #include "system/cpus.h" #include "system/xen.h" --=20 2.49.0 From nobody Sat Dec 13 22:54:06 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1751624426; cv=none; d=zohomail.com; s=zohoarc; b=UbMGwbWi/6o3VQP+wtfVyxGE5/r5Almuy2hLD1pldgvUU2QUehmq81XkDq/z36kcqgtxIi/PGjY11263ydTxcdVoPv3Ps8vddioftXQx4JOwSApcXFHkxDVmV6s3cu3SoMXYn243qrALq8ayEJa2Wy6syriz3dBL1UHZuiD00tw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1751624426; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=p7fZaNjQsotgFZjH3a21SFT+U7+4VJCz66hjOxfj1Ts=; b=QTPHJpKOPVeTj7PIM1ucmD03DkF/VuqVm6yNDc3Aa4Yyla49eHZpVT94REsupeYQTzUgbKAlhe/zK3zr/j26u4uI+3hXVn5CEDTxNAoF3YshNThP4kZjgoOV7C1UZFQ0gS2k/SbCW8r9uCO8OENwTWliIc9IM2PRdEoq7SCCix0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1751624425991488.2672234046322; Fri, 4 Jul 2025 03:20:25 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uXdSx-0007xZ-DE; Fri, 04 Jul 2025 06:16:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uXdSs-0007nW-1w for qemu-devel@nongnu.org; Fri, 04 Jul 2025 06:16:18 -0400 Received: from mail-wr1-x42d.google.com ([2a00:1450:4864:20::42d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uXdSp-0006vO-QU for qemu-devel@nongnu.org; Fri, 04 Jul 2025 06:16:17 -0400 Received: by mail-wr1-x42d.google.com with SMTP id ffacd0b85a97d-3a6d1369d4eso389469f8f.2 for ; Fri, 04 Jul 2025 03:16:14 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b470caa1a2sm2074747f8f.42.2025.07.04.03.16.12 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 04 Jul 2025 03:16:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1751624173; x=1752228973; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=p7fZaNjQsotgFZjH3a21SFT+U7+4VJCz66hjOxfj1Ts=; b=kmKAemJszfRUeI8QTICIPb4jmDbTTcbxIBPaFWoGwgrfjO0mDxz7RjWtTJYm43y/ne 6xHfoj2vlN4H4yVL2E9S3IHaOPA7V4X1/quVdktSODsO/SaE0DiWWRQjjUFDFgXNnipG Nvd4L78CtoVi6C6weGYykdY4I2CfSyKj8CZc6jUDU2hPro9ldoYtji8HJI0QmS7RcQMN jltH1ahKyP+3Kyrivx+lZIRBoNH6w1jHOj2y33cIVQXhy0fVD8xJtZkLLf4lPZRmHJxy wbghYOJgHoRhsR3qvd+TGqHH/do8Wz60CZOXI9lmcZjbVYgrs/gP5FZIg0aEV1deXjHL 5CRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751624173; x=1752228973; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=p7fZaNjQsotgFZjH3a21SFT+U7+4VJCz66hjOxfj1Ts=; b=ic6pWt4wtywAtfaZKq/up0urO47hCGR0tt7moqJinaq9RnBneNsB89pKFp4wA2FG9m /cwcKFZOMPWp0sjKXilm+hxOnd/HDcbG9c/oskQvt4JmW/f20VNtmKgVtPCMkc/TJn2n gbGAdZLQ0CwDxxLSpaEsoMnH5om6eel61ps89XiNYxYbJ/xyq49mGkqNfBWoOaPjXKoO J8DCrZidGIlfDPsFBp1gtDyDxtw+iUIaGORuPdK00BAToV2mYv+IeaNqwcP6E4NgdrVc Fx8YiPE5isZGN+1nifPTUBjcnbOQM0qCj9siL96i/bq9qI662N4wbzbqQlPVDoSXtPrF Gbtg== X-Gm-Message-State: AOJu0YyM3SmH53fF5hxSERm1xbjfOwQCrm7i2ZtUw28urLbjyp4HVA9y O76VKGKZOVU0PahXWXBaKsy4xi+Mv+bcnFxX0zcXPvOWAzEMJYmzykQMdQTZDzQ6Deuer2tI4tW pZTQnTUY= X-Gm-Gg: ASbGncsA2Q/kHRbBnn9ukaAzn8aPG8gGyGvscXZ2Ao6qwBWIWAJjQMERJiA4/fbXfJu CjWs24VFkANl32Ec/U0r8CqtTZ9n9C/ukYiTXnGsZad50IXHvzKlHCPFJT2AoR5pCXZ1zuILy9y IHRyC7dxGbepDEU37zuDHz7cNFvf//tpP5Zx9jqoH82csJJH7B6Zw9MFLI1DbK8Smvt/QCavKGO G26fhznZuZhd/qVNtXc+KYldyEur81Nduy/oU6gxlTSMAEVjRf7aWXSfn6aiNap6CR1YtUSO8Rb 6AGmegyCNLw4P/9cN0+6ry9GV8s4F6gvnpzi9VP70q6HA18+GWFFmbVxzB3E+IbVMcIEqc77GCc DYtLtX57ktancRLx6TJlD/KENfskB1Y/BeOpL X-Google-Smtp-Source: AGHT+IGYRpo+eZ4WcLWHHZmcPhuk2LH5kNcw/4pLT/n+iGmv40DdPIWKA+KRNunx8y3+4m4dr1FSew== X-Received: by 2002:a05:6000:2289:b0:3a5:8a68:b815 with SMTP id ffacd0b85a97d-3b4965ff60cmr1500033f8f.46.1751624173099; Fri, 04 Jul 2025 03:16:13 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 21/31] accel: Expose and register generic_handle_interrupt() Date: Fri, 4 Jul 2025 12:14:22 +0200 Message-ID: <20250704101433.8813-22-philmd@linaro.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250704101433.8813-1-philmd@linaro.org> References: <20250704101433.8813-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::42d; envelope-from=philmd@linaro.org; helo=mail-wr1-x42d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1751624428251116600 In order to dispatch over AccelOpsClass::handle_interrupt(), we need it always defined, not calling a hidden handler under the hood. Make AccelOpsClass::handle_interrupt() mandatory. Expose generic_handle_interrupt() prototype and register it for each accelerator. Suggested-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Pierrick Bouvier Reviewed-by: Zhao Liu Reviewed-by: Richard Henderson Reviewed-by: Xiaoyao Li Message-Id: <20250703173248.44995-29-philmd@linaro.org> --- include/system/accel-ops.h | 3 +++ accel/hvf/hvf-accel-ops.c | 1 + accel/kvm/kvm-accel-ops.c | 1 + accel/qtest/qtest.c | 1 + accel/xen/xen-all.c | 1 + system/cpus.c | 10 ++++------ target/i386/nvmm/nvmm-accel-ops.c | 1 + target/i386/whpx/whpx-accel-ops.c | 1 + 8 files changed, 13 insertions(+), 6 deletions(-) diff --git a/include/system/accel-ops.h b/include/system/accel-ops.h index a4e706b49c9..e775ecc348c 100644 --- a/include/system/accel-ops.h +++ b/include/system/accel-ops.h @@ -62,6 +62,7 @@ struct AccelOpsClass { void (*synchronize_pre_loadvm)(CPUState *cpu); void (*synchronize_pre_resume)(bool step_pending); =20 + /* handle_interrupt is mandatory. */ void (*handle_interrupt)(CPUState *cpu, int mask); =20 /** @@ -86,4 +87,6 @@ struct AccelOpsClass { void (*remove_all_breakpoints)(CPUState *cpu); }; =20 +void generic_handle_interrupt(CPUState *cpu, int mask); + #endif /* ACCEL_OPS_H */ diff --git a/accel/hvf/hvf-accel-ops.c b/accel/hvf/hvf-accel-ops.c index 395b5a8e1c0..be8724ac896 100644 --- a/accel/hvf/hvf-accel-ops.c +++ b/accel/hvf/hvf-accel-ops.c @@ -353,6 +353,7 @@ static void hvf_accel_ops_class_init(ObjectClass *oc, c= onst void *data) =20 ops->create_vcpu_thread =3D hvf_start_vcpu_thread; ops->kick_vcpu_thread =3D hvf_kick_vcpu_thread; + ops->handle_interrupt =3D generic_handle_interrupt; =20 ops->synchronize_post_reset =3D hvf_cpu_synchronize_post_reset; ops->synchronize_post_init =3D hvf_cpu_synchronize_post_init; diff --git a/accel/kvm/kvm-accel-ops.c b/accel/kvm/kvm-accel-ops.c index e5c15449aa6..0eafc902c3f 100644 --- a/accel/kvm/kvm-accel-ops.c +++ b/accel/kvm/kvm-accel-ops.c @@ -101,6 +101,7 @@ static void kvm_accel_ops_class_init(ObjectClass *oc, c= onst void *data) ops->synchronize_post_init =3D kvm_cpu_synchronize_post_init; ops->synchronize_state =3D kvm_cpu_synchronize_state; ops->synchronize_pre_loadvm =3D kvm_cpu_synchronize_pre_loadvm; + ops->handle_interrupt =3D generic_handle_interrupt; =20 #ifdef TARGET_KVM_HAVE_GUEST_DEBUG ops->update_guest_debug =3D kvm_update_guest_debug_ops; diff --git a/accel/qtest/qtest.c b/accel/qtest/qtest.c index 612cede160b..5474ce73135 100644 --- a/accel/qtest/qtest.c +++ b/accel/qtest/qtest.c @@ -67,6 +67,7 @@ static void qtest_accel_ops_class_init(ObjectClass *oc, c= onst void *data) ops->create_vcpu_thread =3D dummy_start_vcpu_thread; ops->get_virtual_clock =3D qtest_get_virtual_clock; ops->set_virtual_clock =3D qtest_set_virtual_clock; + ops->handle_interrupt =3D generic_handle_interrupt; }; =20 static const TypeInfo qtest_accel_ops_type =3D { diff --git a/accel/xen/xen-all.c b/accel/xen/xen-all.c index c150dd43cab..c12c22de785 100644 --- a/accel/xen/xen-all.c +++ b/accel/xen/xen-all.c @@ -153,6 +153,7 @@ static void xen_accel_ops_class_init(ObjectClass *oc, c= onst void *data) AccelOpsClass *ops =3D ACCEL_OPS_CLASS(oc); =20 ops->create_vcpu_thread =3D dummy_start_vcpu_thread; + ops->handle_interrupt =3D generic_handle_interrupt; } =20 static const TypeInfo xen_accel_ops_type =3D { diff --git a/system/cpus.c b/system/cpus.c index a43e0e4e796..0d0eec82a2f 100644 --- a/system/cpus.c +++ b/system/cpus.c @@ -254,7 +254,7 @@ int64_t cpus_get_elapsed_ticks(void) return cpu_get_ticks(); } =20 -static void generic_handle_interrupt(CPUState *cpu, int mask) +void generic_handle_interrupt(CPUState *cpu, int mask) { cpu->interrupt_request |=3D mask; =20 @@ -267,11 +267,7 @@ void cpu_interrupt(CPUState *cpu, int mask) { g_assert(bql_locked()); =20 - if (cpus_accel->handle_interrupt) { - cpus_accel->handle_interrupt(cpu, mask); - } else { - generic_handle_interrupt(cpu, mask); - } + cpus_accel->handle_interrupt(cpu, mask); } =20 /* @@ -680,6 +676,8 @@ void cpus_register_accel(const AccelOpsClass *ops) { assert(ops !=3D NULL); assert(ops->create_vcpu_thread !=3D NULL); /* mandatory */ + assert(ops->handle_interrupt); + cpus_accel =3D ops; } =20 diff --git a/target/i386/nvmm/nvmm-accel-ops.c b/target/i386/nvmm/nvmm-acce= l-ops.c index 21443078b72..a5517b0abf3 100644 --- a/target/i386/nvmm/nvmm-accel-ops.c +++ b/target/i386/nvmm/nvmm-accel-ops.c @@ -87,6 +87,7 @@ static void nvmm_accel_ops_class_init(ObjectClass *oc, co= nst void *data) =20 ops->create_vcpu_thread =3D nvmm_start_vcpu_thread; ops->kick_vcpu_thread =3D nvmm_kick_vcpu_thread; + ops->handle_interrupt =3D generic_handle_interrupt; =20 ops->synchronize_post_reset =3D nvmm_cpu_synchronize_post_reset; ops->synchronize_post_init =3D nvmm_cpu_synchronize_post_init; diff --git a/target/i386/whpx/whpx-accel-ops.c b/target/i386/whpx/whpx-acce= l-ops.c index b8bebe403c9..31cf15f0045 100644 --- a/target/i386/whpx/whpx-accel-ops.c +++ b/target/i386/whpx/whpx-accel-ops.c @@ -90,6 +90,7 @@ static void whpx_accel_ops_class_init(ObjectClass *oc, co= nst void *data) ops->create_vcpu_thread =3D whpx_start_vcpu_thread; ops->kick_vcpu_thread =3D whpx_kick_vcpu_thread; ops->cpu_thread_is_idle =3D whpx_vcpu_thread_is_idle; + ops->handle_interrupt =3D generic_handle_interrupt; =20 ops->synchronize_post_reset =3D whpx_cpu_synchronize_post_reset; ops->synchronize_post_init =3D whpx_cpu_synchronize_post_init; --=20 2.49.0 From nobody Sat Dec 13 22:54:06 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1751624376; cv=none; d=zohomail.com; s=zohoarc; b=KwtrLtyrPDOAW54F41iHq840MltakGtm4YgRbIz+j/sC0VNMCyNascDylfGyFyi2ZpdXWNiCd86HZUNn4/WwwMGGMsjFv8n38RpSCuxVf/rcc4f2owpaV8Joz00oQEQUrYH+vkLj8Ujf73Qqu+dUu3RNEpsqsX/Vd8dNth9TwmA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1751624376; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=a/ehok3HXLFMICTHZ9JCOL4fKFue6Luf24Tj+XvmPiI=; b=kS4G2tijHXemMiXGSM/Ln4mBNSaGK3GHlE9U/Se5O+/SpRvHuQ/hJPI6gsT/JYZxo/MTE4r1vzWikXr39fllNEMZKlJYdtpEpbNzsFv65OnVIBR+bEKlV7RkINgOk6MWA632sd3EpHpD6MH85v6IBb1t9/3M2qWwKBqUTbwsKqc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1751624376398764.8623589215038; Fri, 4 Jul 2025 03:19:36 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uXdT1-00088t-LB; Fri, 04 Jul 2025 06:16:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uXdSw-0007y4-9Y for qemu-devel@nongnu.org; Fri, 04 Jul 2025 06:16:23 -0400 Received: from mail-wr1-x434.google.com ([2a00:1450:4864:20::434]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uXdSt-0006wI-Uq for qemu-devel@nongnu.org; Fri, 04 Jul 2025 06:16:21 -0400 Received: by mail-wr1-x434.google.com with SMTP id ffacd0b85a97d-3a57c8e247cso557644f8f.1 for ; Fri, 04 Jul 2025 03:16:19 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b47285c90esm2129300f8f.91.2025.07.04.03.16.16 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 04 Jul 2025 03:16:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1751624178; x=1752228978; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=a/ehok3HXLFMICTHZ9JCOL4fKFue6Luf24Tj+XvmPiI=; b=r+iN5v4K4L0TWY5hIx+Es73u0e1GcqJE+KoQe4jnoNhVL1yYcbxxHwFpmU2Me0p3oA Q9Se7cku8f761rLZzO1GnbnTImV6KlRwo9YsCp07UPn8ROfOyLMv2Fdx3aDLxzpUwCY1 IPjjEdb01LFB4/eIX2vgC7SeKUo7JDg4vjFFkrJtJ/CPwt6muXdkYEWGMXL+CodNi6ty KiqFfuhdM9yhKoHI3kA5gcN5vCSwG1fskLxVkchyRtSvhNO+13yRxdfyFQ5+vJxMvUFb IZKkxMxj+ih9JvfnyNYhIoxE07TJKJWvuDflYPSTzWUJzEw7A/BSQe49/UP70tGhwsqp HwuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751624178; x=1752228978; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=a/ehok3HXLFMICTHZ9JCOL4fKFue6Luf24Tj+XvmPiI=; b=XClgHq0jR6Fcgl0Lmitssv81IDGp/n8ww4POT/5wFrrMD9ccWeQYstWqnB6FEfdhtb sz1SRhf3i3pgGgCx7KtgFUSR5snJYJ6GUG8HjCwMr8BzywgWhTzsSaR94n1NpFbMFvBY 9BmZlGfsKevS9GetrXZl+lwfsVSrejFl+u7qofrEcGZIBXUy08XjPy3E6A8B8quLZdpG pXf7olNGDL7cj728fHYZXteYXIlFytH83Recvooemb+isxuXwa+U0S1NpfTev5QqGUmK 1X8GAPGfMTbT3g2R8VMMX5zwHXzwg3tjwwG98EV8PtvNo55JSooz0CIlIgPfeE8I5S+0 OT8A== X-Gm-Message-State: AOJu0YxUVJ+hS3PdERM+QBGUFZoDVukea/1v9D5AaUfb5FwfsfhrG3MN wx7V6ZIZWibmEHuQiU4JH/tQU4uZSo2xoK0QFZnOjo9Izh50LdsEURsJFrFKOTv7VagE1zdLpv+ 16h4bIaE= X-Gm-Gg: ASbGncuPDwMLunPf9rYLqhx90QWK2gJGhv8nBQjmgIL5vRFmCghRbpK5a7eJU4GrdXU lRo98R49FkdDImHSTHBwoB5G5kZTTfTktC3SMGjYMFTEwj5IMP2iuMUux3mVuB37eElIavGePC1 cvnW4ZcVKmVw1dPWq1UVkEJW+Zw8L+dwx2lP5BY5AO/u3gBnCNKYiP1ailqI6iI+sw5lPRbMPGr FYsSWAAZMN7L0FmBQjJnoi427E6x95NPLSCFcxCk6bUz5oZNp+FOoKYAr5H85x1HN6+BniqLMAd 3zvLQ8sbpPjJSatpjzrLnqJLDs8HZaagXocD2sXFMh8Wxs3vieIcz3CczzjM31qP02rZ5+mmO8m omtTLd2azVX2hNmXrSDV4+UMxd0eZ5RQyHFpZ X-Google-Smtp-Source: AGHT+IG9TjGkwo7efzyMwPuD+7B+75MU6aBwksawEK+7PQ6xES1fn1DI/9ZY4SPZQDp9z+P75HLPag== X-Received: by 2002:a5d:6f15:0:b0:3a5:8977:e102 with SMTP id ffacd0b85a97d-3b497038cdamr1160706f8f.39.1751624177511; Fri, 04 Jul 2025 03:16:17 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 22/31] accel: Keep reference to AccelOpsClass in AccelClass Date: Fri, 4 Jul 2025 12:14:23 +0200 Message-ID: <20250704101433.8813-23-philmd@linaro.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250704101433.8813-1-philmd@linaro.org> References: <20250704101433.8813-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::434; envelope-from=philmd@linaro.org; helo=mail-wr1-x434.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1751624377556116600 Allow dereferencing AccelOpsClass outside of accel/accel-system.c. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson Reviewed-by: Alex Benn=C3=A9e Message-Id: <20250703173248.44995-30-philmd@linaro.org> --- include/qemu/accel.h | 3 +++ include/system/accel-ops.h | 3 ++- accel/accel-system.c | 3 ++- accel/tcg/tcg-accel-ops.c | 4 +++- 4 files changed, 10 insertions(+), 3 deletions(-) diff --git a/include/qemu/accel.h b/include/qemu/accel.h index fbd3d897fef..9dea3145429 100644 --- a/include/qemu/accel.h +++ b/include/qemu/accel.h @@ -37,6 +37,9 @@ typedef struct AccelClass { /*< public >*/ =20 const char *name; + /* Cached by accel_init_ops_interfaces() when created */ + AccelOpsClass *ops; + int (*init_machine)(MachineState *ms); bool (*cpu_common_realize)(CPUState *cpu, Error **errp); void (*cpu_common_unrealize)(CPUState *cpu); diff --git a/include/system/accel-ops.h b/include/system/accel-ops.h index e775ecc348c..a786c7d478a 100644 --- a/include/system/accel-ops.h +++ b/include/system/accel-ops.h @@ -10,6 +10,7 @@ #ifndef ACCEL_OPS_H #define ACCEL_OPS_H =20 +#include "qemu/accel.h" #include "exec/vaddr.h" #include "qom/object.h" =20 @@ -31,7 +32,7 @@ struct AccelOpsClass { /*< public >*/ =20 /* initialization function called when accel is chosen */ - void (*ops_init)(AccelOpsClass *ops); + void (*ops_init)(AccelClass *ac); =20 bool (*cpus_are_resettable)(void); void (*cpu_reset_hold)(CPUState *cpu); diff --git a/accel/accel-system.c b/accel/accel-system.c index a0f562ae9ff..64bc991b1ce 100644 --- a/accel/accel-system.c +++ b/accel/accel-system.c @@ -85,8 +85,9 @@ void accel_init_ops_interfaces(AccelClass *ac) * non-NULL create_vcpu_thread operation. */ ops =3D ACCEL_OPS_CLASS(oc); + ac->ops =3D ops; if (ops->ops_init) { - ops->ops_init(ops); + ops->ops_init(ac); } cpus_register_accel(ops); } diff --git a/accel/tcg/tcg-accel-ops.c b/accel/tcg/tcg-accel-ops.c index 6116644d1c0..37b4b21f882 100644 --- a/accel/tcg/tcg-accel-ops.c +++ b/accel/tcg/tcg-accel-ops.c @@ -196,8 +196,10 @@ static inline void tcg_remove_all_breakpoints(CPUState= *cpu) cpu_watchpoint_remove_all(cpu, BP_GDB); } =20 -static void tcg_accel_ops_init(AccelOpsClass *ops) +static void tcg_accel_ops_init(AccelClass *ac) { + AccelOpsClass *ops =3D ac->ops; + if (qemu_tcg_mttcg_enabled()) { ops->create_vcpu_thread =3D mttcg_start_vcpu_thread; ops->kick_vcpu_thread =3D mttcg_kick_vcpu_thread; --=20 2.49.0 From nobody Sat Dec 13 22:54:06 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1751624422; cv=none; d=zohomail.com; s=zohoarc; b=kjw3fzXJEAv6bIFVVPhYzDc+Y84c6xUVqtTh/3YnrOTgXlAh7tYcMXYSOh6GojLCnkYwHDnRHB741RmJNuh6yZRqOGQQ6wQkbEFTtpg1AEzhr1Lng0oIdj4rbuVo7ARo1SCi85053GrJHGp0jORV3FEmc5YlulGB3vw+jU2D3NM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1751624422; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=MDgreBIe8GH6HfFhheEGkGfr9GGDVllh8tKN5isBeSo=; b=TUtJXkOxISML3BKj9I7CAvsprhKi2+k7m1RgNuwscxh+QJT6GmKYmTswZUqiyWSOto6bSzEFW3SooCLiLDCTh3Ojg1lEZ7ek/A+Hp8CASoCbPYEZmxb7QLvoU/Ofm5hsyixpxqkmTKspEzoe76cwkH4kckHQxCvEZaFmGN0dO7c= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1751624422522761.4294053828385; Fri, 4 Jul 2025 03:20:22 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uXdT5-0008Lk-QJ; Fri, 04 Jul 2025 06:16:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uXdT2-0008BM-SI for qemu-devel@nongnu.org; Fri, 04 Jul 2025 06:16:29 -0400 Received: from mail-wm1-x32c.google.com ([2a00:1450:4864:20::32c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uXdSz-0006x3-JT for qemu-devel@nongnu.org; Fri, 04 Jul 2025 06:16:27 -0400 Received: by mail-wm1-x32c.google.com with SMTP id 5b1f17b1804b1-450cf214200so5858195e9.1 for ; Fri, 04 Jul 2025 03:16:23 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b47225b23csm2080587f8f.84.2025.07.04.03.16.21 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 04 Jul 2025 03:16:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1751624182; x=1752228982; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=MDgreBIe8GH6HfFhheEGkGfr9GGDVllh8tKN5isBeSo=; b=Zb2uk7kxywkxi4pQlOIK/9ttnKa7Kg/ilWjXmLK/F7O1/xd0tyxJ3AHBh33MJb34nK HvCLB4neBzqygqK8wMxSVN0/sWQ5l0ec3IHuKfqIf26t4ceH6mTFw6eEutgaoHFVodxQ rlquBYqIuy/BXfNSW08QReTuBN8yQZKEu91NATm8rnzZ0t7O99xiCzPUX63VC9NrpbNP jc+bZFDkDVrKttLA+s1cpOsKpgS3XA3aiwhdSvBqYDw11P0BD5NLeJOtGDlaECI/ID9d aYhOxhoQxqPEEULhcG8kZgaQgy/BfY2HannDEjty6Wbpmi52CIRq2za1GyKPZei5t7Dw oirg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751624182; x=1752228982; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MDgreBIe8GH6HfFhheEGkGfr9GGDVllh8tKN5isBeSo=; b=CXAyEH8CgjJPVNV3IHA4UVtPidzpUwSJl0Q5y5OXGBMtKCLbvc6c3ywNMp7qWBkYM+ MYb0VEZE2Bo0UPPgLxaVovq4x1Gf7F2KdeCD6hjtmQXal1emUJCbUGQSHl5Kjq0LI8b7 u6mBjVF3DxkmCV7qfnfnivsBqHr+8ElTglJokl6lz5y1wepua3YBLhcawR7cc4XFbOFf bISXRxBy7hFYw2RrbVifONnKPUzayuZQUYa64Qqrk0sn1dPgumE3d0u+4OwjhyvmA+Y8 DnDiKDmxMeaxjkaN63bP6viGhYO0y3/fLIz5zTF9d/SD2bQ14zzmjdNbG9gthU/mH9MP fXlQ== X-Gm-Message-State: AOJu0YwSrgCix2K6DELDjcfuT6O3YV/UrdxUTg/Sqi2bNMBYoded2XMe qtfih/7sBrbiBPC9Ytc6VRux/lPJAl/sw4k55Fo4qvR2BHFP5zSlGuDLtr50AaGJQtTkUp08Eo3 N6FjiLjE= X-Gm-Gg: ASbGncvv/S+DpHkBLaxj/dZiluPPxI+TaEJZYfTQ/r8ldr1VAfQZNbSQEkWK1glCcKc tXU4QsxeXWgtsAnd+jFxJIjVboYWIDTcytKaUwAsXSYGUSWOeEJshExVlpPDovUW9cyxmoco1XB M73+ApcW2xxEoTYXx+tmct7PdMkY76Q54qzxfOl7fzE60oWc+2EHN1VxyPwXnjEjOSxD8GdadFM eNMizn/ji2TgLofKy0TOk4kfY5JLgabOhCvS+2vf8Xl0fpJjyhqEJGW4pcTdqjsqtd4N/x6nOuI OT70DRawnr2EPnb1RXX05F2WMduAyVmYsKmGuqQnMUD7fmsX6aOVNFGuqQ+V2Gh+JdNvF39OjJm xyK9oCzgYao5yQlV1f82O4eawt3hNFptBFDIvxu1wTX+jLTM= X-Google-Smtp-Source: AGHT+IFmKyqYDyPhl6ZNheUuSW+jOyspB6fCGILKZIkiH14wyBKi9FUsbOaT5NcIe83yBUjG1nkW1Q== X-Received: by 2002:a05:600c:a087:b0:454:ab1a:8c39 with SMTP id 5b1f17b1804b1-454b310d890mr17562065e9.26.1751624182044; Fri, 04 Jul 2025 03:16:22 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 23/31] accel: Propagate AccelState to AccelClass::init_machine() Date: Fri, 4 Jul 2025 12:14:24 +0200 Message-ID: <20250704101433.8813-24-philmd@linaro.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250704101433.8813-1-philmd@linaro.org> References: <20250704101433.8813-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32c; envelope-from=philmd@linaro.org; helo=mail-wm1-x32c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1751624424214116600 In order to avoid init_machine() to call current_accel(), pass AccelState along. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson Reviewed-by: Alex Benn=C3=A9e Message-Id: <20250703173248.44995-31-philmd@linaro.org> --- include/qemu/accel.h | 2 +- accel/accel-system.c | 2 +- accel/hvf/hvf-all.c | 2 +- accel/kvm/kvm-all.c | 2 +- accel/qtest/qtest.c | 2 +- accel/tcg/tcg-all.c | 2 +- accel/xen/xen-all.c | 2 +- bsd-user/main.c | 2 +- linux-user/main.c | 2 +- target/i386/nvmm/nvmm-all.c | 2 +- target/i386/whpx/whpx-all.c | 2 +- 11 files changed, 11 insertions(+), 11 deletions(-) diff --git a/include/qemu/accel.h b/include/qemu/accel.h index 9dea3145429..b9a9b3593d8 100644 --- a/include/qemu/accel.h +++ b/include/qemu/accel.h @@ -40,7 +40,7 @@ typedef struct AccelClass { /* Cached by accel_init_ops_interfaces() when created */ AccelOpsClass *ops; =20 - int (*init_machine)(MachineState *ms); + int (*init_machine)(AccelState *as, MachineState *ms); bool (*cpu_common_realize)(CPUState *cpu, Error **errp); void (*cpu_common_unrealize)(CPUState *cpu); =20 diff --git a/accel/accel-system.c b/accel/accel-system.c index 64bc991b1ce..913b7155d77 100644 --- a/accel/accel-system.c +++ b/accel/accel-system.c @@ -37,7 +37,7 @@ int accel_init_machine(AccelState *accel, MachineState *m= s) int ret; ms->accelerator =3D accel; *(acc->allowed) =3D true; - ret =3D acc->init_machine(ms); + ret =3D acc->init_machine(accel, ms); if (ret < 0) { ms->accelerator =3D NULL; *(acc->allowed) =3D false; diff --git a/accel/hvf/hvf-all.c b/accel/hvf/hvf-all.c index ddc77e629f5..68f1425fae2 100644 --- a/accel/hvf/hvf-all.c +++ b/accel/hvf/hvf-all.c @@ -247,7 +247,7 @@ static MemoryListener hvf_memory_listener =3D { .log_sync =3D hvf_log_sync, }; =20 -static int hvf_accel_init(MachineState *ms) +static int hvf_accel_init(AccelState *as, MachineState *ms) { int x; hv_return_t ret; diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c index 17235f26464..264f288dc64 100644 --- a/accel/kvm/kvm-all.c +++ b/accel/kvm/kvm-all.c @@ -2573,7 +2573,7 @@ static int kvm_setup_dirty_ring(KVMState *s) return 0; } =20 -static int kvm_init(MachineState *ms) +static int kvm_init(AccelState *as, MachineState *ms) { MachineClass *mc =3D MACHINE_GET_CLASS(ms); static const char upgrade_note[] =3D diff --git a/accel/qtest/qtest.c b/accel/qtest/qtest.c index 5474ce73135..2b831260201 100644 --- a/accel/qtest/qtest.c +++ b/accel/qtest/qtest.c @@ -38,7 +38,7 @@ static void qtest_set_virtual_clock(int64_t count) qatomic_set_i64(&qtest_clock_counter, count); } =20 -static int qtest_init_accel(MachineState *ms) +static int qtest_init_accel(AccelState *as, MachineState *ms) { return 0; } diff --git a/accel/tcg/tcg-all.c b/accel/tcg/tcg-all.c index 6e5dc333d59..d68fbb23773 100644 --- a/accel/tcg/tcg-all.c +++ b/accel/tcg/tcg-all.c @@ -80,7 +80,7 @@ static void tcg_accel_instance_init(Object *obj) =20 bool one_insn_per_tb; =20 -static int tcg_init_machine(MachineState *ms) +static int tcg_init_machine(AccelState *as, MachineState *ms) { TCGState *s =3D TCG_STATE(current_accel()); unsigned max_threads =3D 1; diff --git a/accel/xen/xen-all.c b/accel/xen/xen-all.c index c12c22de785..8279746f115 100644 --- a/accel/xen/xen-all.c +++ b/accel/xen/xen-all.c @@ -77,7 +77,7 @@ static void xen_setup_post(MachineState *ms, AccelState *= accel) } } =20 -static int xen_init(MachineState *ms) +static int xen_init(AccelState *as, MachineState *ms) { MachineClass *mc =3D MACHINE_GET_CLASS(ms); =20 diff --git a/bsd-user/main.c b/bsd-user/main.c index 7c0a059c3ba..d0cc8e0088f 100644 --- a/bsd-user/main.c +++ b/bsd-user/main.c @@ -474,7 +474,7 @@ int main(int argc, char **argv) opt_one_insn_per_tb, &error_abort); object_property_set_int(OBJECT(accel), "tb-size", opt_tb_size, &error_abort); - ac->init_machine(NULL); + ac->init_machine(accel, NULL); } =20 /* diff --git a/linux-user/main.c b/linux-user/main.c index 5ac5b55dc65..a9142ee7268 100644 --- a/linux-user/main.c +++ b/linux-user/main.c @@ -820,7 +820,7 @@ int main(int argc, char **argv, char **envp) opt_one_insn_per_tb, &error_abort); object_property_set_int(OBJECT(accel), "tb-size", opt_tb_size, &error_abort); - ac->init_machine(NULL); + ac->init_machine(accel, NULL); } =20 /* diff --git a/target/i386/nvmm/nvmm-all.c b/target/i386/nvmm/nvmm-all.c index 2df49d7eeb4..b4a4d50e860 100644 --- a/target/i386/nvmm/nvmm-all.c +++ b/target/i386/nvmm/nvmm-all.c @@ -1152,7 +1152,7 @@ static struct RAMBlockNotifier nvmm_ram_notifier =3D { /* -----------------------------------------------------------------------= --- */ =20 static int -nvmm_accel_init(MachineState *ms) +nvmm_accel_init(AccelState *as, MachineState *ms) { int ret, err; =20 diff --git a/target/i386/whpx/whpx-all.c b/target/i386/whpx/whpx-all.c index 94fd5fc7849..721c4782b9c 100644 --- a/target/i386/whpx/whpx-all.c +++ b/target/i386/whpx/whpx-all.c @@ -2504,7 +2504,7 @@ static void whpx_set_kernel_irqchip(Object *obj, Visi= tor *v, * Partition support */ =20 -static int whpx_accel_init(MachineState *ms) +static int whpx_accel_init(AccelState *as, MachineState *ms) { struct whpx_state *whpx; int ret; --=20 2.49.0 From nobody Sat Dec 13 22:54:06 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1751624266; cv=none; d=zohomail.com; s=zohoarc; b=JL6wohunMuFT0ASkC/zsHSbeUR7JjI0g3BxoQRgx5YFWT68RPVZvDiNdK/AoBET7Ki2UXqCXIgGBA41ftESsw8mpgiW1N5h5VnoUpgpEvF9+tW+cw8yUsG4CwiUK16iDLeYnx+P5COwSlSUaUgLf4yLdpoUltwaAWQKVF9fWKQI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1751624266; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=YzdNSDrMEvcfRaufIPZ8ratyEQ1tLFQSVd+1LrIS2js=; b=ao8zV1194jTOGrC9hZbM57OYwi57FLEGllGbmHp7H4JjtCcsRLfwlld4c+af9YENyrSiwmFUnKV4H2t9XpRz/YocTxRsc3Sn2Qah/hdSfdXSOZNBsjZS8awITwr39KPOJKVN44aKDFilmmNEY8AkZzvlvp5xp3qOfcOZDNQdzwI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1751624265838629.9789226108511; Fri, 4 Jul 2025 03:17:45 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uXdTC-0000FL-Qz; Fri, 04 Jul 2025 06:16:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uXdT5-0008Ms-Ay for qemu-devel@nongnu.org; Fri, 04 Jul 2025 06:16:31 -0400 Received: from mail-wr1-x435.google.com ([2a00:1450:4864:20::435]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uXdT3-0006xp-7y for qemu-devel@nongnu.org; Fri, 04 Jul 2025 06:16:30 -0400 Received: by mail-wr1-x435.google.com with SMTP id ffacd0b85a97d-3a503d9ef59so514896f8f.3 for ; Fri, 04 Jul 2025 03:16:28 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-453a85b3e2bsm54808655e9.0.2025.07.04.03.16.25 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 04 Jul 2025 03:16:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1751624187; x=1752228987; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=YzdNSDrMEvcfRaufIPZ8ratyEQ1tLFQSVd+1LrIS2js=; b=ra2jNiR2iAyCZyKOTBX4TQny1Esg81NQw/Bv9NJATCCT90kOOquJqhBE404wiJ0eFp XxxD0fGdimeiwdQoITM5oUsZ4iFf9XUFgiDlup/zN/KupWbIpSdb4zJMW9wOIxbm3/56 U7Mfuwl0Uj7nvimDsnxF72CrpC5sjFtv39vCaEWc8ZSqpaEM6OVU8pR+pYPZRpYhPKim vJOuTJd/ZYX2ERbaBnunJhb7mztuxgemeJ8eI+7wl+ERSXkKQjxj1kFm4djcvOC+N1rV 84veeFEz7uyInLm1pR/VCVdYsMQimDz8G+ye9XQswLMCIyUszOUeV+MQLc4tr5QKjy18 3Pbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751624187; x=1752228987; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YzdNSDrMEvcfRaufIPZ8ratyEQ1tLFQSVd+1LrIS2js=; b=Q3B5CgEXem/rE89/EuIkq/DvAH39HEsq/bVxGH+lLYWLB16ZheFUI4bKcH33NWr9S4 oI4i1UbyicWk43I/dFFudb0fFTlFc25eihO9nl0+XboZ99bNy6WIV7C0EHEBRe71t0DG rkudlYSnlxFMYc3JUykUV6cY5dhDWPA2wggHDJ55QKZ/Ft7tTHeuO48qqlKs08yYqA0O WulJC+0CSQMmi29/foTR0MwUDji2DevGvhFdMHOUU5uI3/hhQAS9TJC86Br1T+YbnkoW A8SYBogUeHYxPFMMGwOTTSrJF00s3oQ0Pf3rr5DmiioN+d8LfIi6Zu+TSdiP7uHfSiov fkyA== X-Gm-Message-State: AOJu0YzI3dEtjIJ0KJKDz8DsPhZ/fwN2g++S/3xXq8/WXEOyeRVgu+zU 7shd6NbRpxm+wQK2ek4IN5iwcC29RVnukw9YKuqtsxg3cAJoCzSlgX4qhHoI091ZpibJGMTe3zi 5Ku8B8b4= X-Gm-Gg: ASbGnctWkowebP37IC1xcQV9Ram3L/Tp5pQ2KuldTTd7DQkr8q13v6UyPlonYNxF/L9 d0WGQaOuEgPRmjqXr5B6QR8XeeAAn+DdyEHpHc9NMPo+wE40+AKUxGTdm8UfJ3ySJOHhKrJqGFa cUZFu/Ml9FarbqF9/IrlDvBiO6d9XrC3PxfwZILn0DQm5yWD5Iz98oG3pcUzRuleuSR96qUtUVX 4OmeYrHzq2up18TAYDc0u0Q2iKAqETLaR85806l5QryMs+u3akVXui3oeJIcOZIPj1CmTff/mIV IRRdR25VUimTCqKucvGreKBxcSl3L8OiBxCFgnXNs85eKSUlwPImDLT3Dl/dBt31pPWU1+WP2/N HIjLgpKO12HV1QtY4V4+mrOUfa7m5mQpMykfv X-Google-Smtp-Source: AGHT+IEmLTsplqT9VX60Zu1ll3lGdoWUSYzi4d4BIIHkLGa1AH07utcJx+91At86ORj8YgLRILYTQg== X-Received: by 2002:a05:6000:24c9:b0:3a4:e667:922e with SMTP id ffacd0b85a97d-3b49700c540mr989888f8f.4.1751624186677; Fri, 04 Jul 2025 03:16:26 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 24/31] accel/tcg: Prefer local AccelState over global current_accel() Date: Fri, 4 Jul 2025 12:14:25 +0200 Message-ID: <20250704101433.8813-25-philmd@linaro.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250704101433.8813-1-philmd@linaro.org> References: <20250704101433.8813-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::435; envelope-from=philmd@linaro.org; helo=mail-wr1-x435.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1751624268213116600 Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson Message-Id: <20250703173248.44995-33-philmd@linaro.org> --- accel/tcg/tcg-all.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/accel/tcg/tcg-all.c b/accel/tcg/tcg-all.c index d68fbb23773..c674d5bcf78 100644 --- a/accel/tcg/tcg-all.c +++ b/accel/tcg/tcg-all.c @@ -82,7 +82,7 @@ bool one_insn_per_tb; =20 static int tcg_init_machine(AccelState *as, MachineState *ms) { - TCGState *s =3D TCG_STATE(current_accel()); + TCGState *s =3D TCG_STATE(as); unsigned max_threads =3D 1; =20 #ifndef CONFIG_USER_ONLY --=20 2.49.0 From nobody Sat Dec 13 22:54:06 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1751624209; cv=none; d=zohomail.com; s=zohoarc; b=BljoZf/quup9TPGxruGTrr+fvrfzNVi0eJ1FwHVDqm4a5h+XC5IXJC32G2BHRIuvPdOtn6MfN5FJv6SN15u8wc1I6MyQjl5kq88nM9iDHed3UYkd8bW8ZFkyVf6yuS8hqbUdX5p6ohF1cPFAe2Q94KYg8C+1Sk6/iQzFGcPrUVA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1751624209; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=dFobWdh11IzhN53VTmVorncMVB6vG7uRGziOzupdhm0=; b=GMTd93llteZFpw4lRxKBY2MlWuy8scGIJgyS99FG8SYItzzBYO35l8QdMaX8BMRStyGq7H3C40e1Qd8dKo/HC4G8hcm3EpehptEld5LiC45Q4PqjIFlGQ3q1CLKB+UWvC5MX5RA2ox19CNkL2MAQcSsvYUuJjZ7qOqFPF7Rdyko= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1751624208983473.11562324628494; Fri, 4 Jul 2025 03:16:48 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uXdTG-0000ie-NE; Fri, 04 Jul 2025 06:16:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uXdTA-0000Ce-FQ for qemu-devel@nongnu.org; Fri, 04 Jul 2025 06:16:36 -0400 Received: from mail-wm1-x332.google.com ([2a00:1450:4864:20::332]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uXdT7-0006yM-Mx for qemu-devel@nongnu.org; Fri, 04 Jul 2025 06:16:35 -0400 Received: by mail-wm1-x332.google.com with SMTP id 5b1f17b1804b1-450ce3a2dd5so5914315e9.3 for ; Fri, 04 Jul 2025 03:16:32 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-454b161e8f1sm22689075e9.8.2025.07.04.03.16.30 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 04 Jul 2025 03:16:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1751624191; x=1752228991; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=dFobWdh11IzhN53VTmVorncMVB6vG7uRGziOzupdhm0=; b=iX/UQnTxpvKPYBIJzy2p9i25OBQiumciz75EHkAhQOkae2v02k4b3zFGKtNWLiPvss jlrK14EYOmyZdbouZ4RdXK5y/MPqx/bgnRvllsWER+SV41ixXBTqI3Cf4v9I7gWKKY+i c89nZx/18FMsZmLg+Hll+KLnUKfudoiNA70U/Et/21J0rEBvvF79aMUVzsXk7IzPM+TO PkI5d8YfA2O0DzbZ8Lg3MMEO+tC4BeP3aMzahiOfzYssQTutYcPgpiZj9YehEAw3v+0Z RMNzr9E3jnc5JXj6F8q+VwqvKjL+MGphRfgkN50cFoeTRQaYsrBXsuSqDvLfjJNsNq3l 0znw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751624191; x=1752228991; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dFobWdh11IzhN53VTmVorncMVB6vG7uRGziOzupdhm0=; b=EgVSekqCbloQ7YnYfpOkjxRj5W4slTMH7lSQobXjESpM01uJAcynPGlq/5XEevKKEJ BQFIeqFW4TCLh52G2VOJsojFd6/n3ivvRxtNUvMe4sNf4jNkmVTQqtEv7Id82k+hiTZB y4n4BgzuG3IEsk1DO0phyQT85hOSbdVC+NIRM+tcybd6qakl7twOUdzRMOK0cD/S6Dvt jBqOTlDrnKTO23Ct8+XPSUkAkO4L3knwMqlJjBZ1Teyk504UT/gKH42z+TRecBdpMoie nQEjwPDRyIm3rwznAiZzI4tRWZrYc9IzbhqyyhhuiggKcQ1HYCX3Z7IQj1ArIbEnRn3I 6Knw== X-Gm-Message-State: AOJu0YxA9e7kkTST4utITjFX6/6zGYQ8zdE1WvYmAI5M4FNglaOSExzt gcN4xzc+dxMPRisnpz+gWRslIiCduuqLIbuBUSfLn6A7hBRWDC6bR3kH9G89avQ/XR5UHlPr5xM 8WTi4kdU= X-Gm-Gg: ASbGncvWekrd6Ua6cYftFonOHAepUh8EzF6bbHW8PQ+Mmw9SFQxb54e9m7EfozzZ5Zy CpmwvKPdnRrHZQW5YG/1Ouz+wDnZ2Jw9Xd+zjT9FivLGFe4crwVf8W4jy36LVAb0NeImNBv8cou jCo8+twoI2B9eTMN5FX9SmR//6FuabWX7v+zLwsKwZBYzgQKpoXhP+7mtTEW4LBJG+kOCiD6WR+ mjBXfFR0h16H5mFe5XCnb0ptwMdSATSC3Epji8Tvw1DT30Kx0vjmsXaYCimjNnMPdyPDVPW+x1P h4QPEzDR/K3IDwCf7fHOLs9vBaeQHagK8jj5XT3Sl+zX6116q4StyWV/7avF1oKxc63iBuVfRz/ sgOzR3vFxMJ6iv/qXDpGnJPfNTWqPtXjBVmRv X-Google-Smtp-Source: AGHT+IFGvDP96FT9707JTcu52eun1VIz5YX3LGlM1fAQyz3LMzrWUmUsm7p6BomSpnNJOCRbpm7YyQ== X-Received: by 2002:a05:600c:8599:b0:453:483b:626c with SMTP id 5b1f17b1804b1-454b50b0173mr9720945e9.23.1751624191300; Fri, 04 Jul 2025 03:16:31 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 25/31] accel/kvm: Prefer local AccelState over global MachineState::accel Date: Fri, 4 Jul 2025 12:14:26 +0200 Message-ID: <20250704101433.8813-26-philmd@linaro.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250704101433.8813-1-philmd@linaro.org> References: <20250704101433.8813-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::332; envelope-from=philmd@linaro.org; helo=mail-wm1-x332.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1751624211411116600 Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson Message-Id: <20250703173248.44995-32-philmd@linaro.org> --- accel/kvm/kvm-all.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c index 264f288dc64..72fba12d9fa 100644 --- a/accel/kvm/kvm-all.c +++ b/accel/kvm/kvm-all.c @@ -2588,15 +2588,13 @@ static int kvm_init(AccelState *as, MachineState *m= s) { /* end of list */ } }, *nc =3D num_cpus; int soft_vcpus_limit, hard_vcpus_limit; - KVMState *s; + KVMState *s =3D KVM_STATE(as); const KVMCapabilityInfo *missing_cap; int ret; int type; =20 qemu_mutex_init(&kml_slots_lock); =20 - s =3D KVM_STATE(ms->accelerator); - /* * On systems where the kernel can support different base page * sizes, host page size may be different from TARGET_PAGE_SIZE, --=20 2.49.0 From nobody Sat Dec 13 22:54:06 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1751624244; cv=none; d=zohomail.com; s=zohoarc; b=TUcUnB6RyJdCGc8SNNU8Rk1eeAdHmfNQSnSWUHaIebI/U1ZNMdHhlRfHFz01JImEhWqIt8+TbP/it0k8ZyBGWmspm01zT0WuzF8Z4WL6mWxIXRYNefMdRXOk8UOWduRLP7jV+GvCnANx4mY7OakNQYBw8DWXJ7sH5TUtwN0HiDU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1751624244; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=mZ0RE64UQypZytSx4Qr4+gDSoIvyEELE2vq85gWcMKU=; b=N8p7A3mJrlBaOGEfNa+DKbod/vU5IxXXmskcNRQPjuROpW/rTZpkzmeBEq6jVjBdEpYS+LgIuCaDxL//NKMYV2XH4jhqVJNnPNEDlLxqTn9yrGCS+d7NL+Mm0RfOZ/ZtGmBg1dDuzM4FWCQDGyz7d90Gn/v0ZrBHiUFZx1yOCiI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1751624244106666.9858416230413; Fri, 4 Jul 2025 03:17:24 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uXdTI-0000pB-3J; Fri, 04 Jul 2025 06:16:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uXdTE-0000WX-JX for qemu-devel@nongnu.org; Fri, 04 Jul 2025 06:16:41 -0400 Received: from mail-wm1-x335.google.com ([2a00:1450:4864:20::335]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uXdTC-0006z9-E8 for qemu-devel@nongnu.org; Fri, 04 Jul 2025 06:16:40 -0400 Received: by mail-wm1-x335.google.com with SMTP id 5b1f17b1804b1-453749aef9eso2563455e9.3 for ; Fri, 04 Jul 2025 03:16:37 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b4708d022asm2085121f8f.22.2025.07.04.03.16.35 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 04 Jul 2025 03:16:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1751624196; x=1752228996; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=mZ0RE64UQypZytSx4Qr4+gDSoIvyEELE2vq85gWcMKU=; b=CzaKAaYpaAuKyWwUgIgQfjh6zN2VTOVt2bBLXJT9NGbCCH5yhQ91sGzFIl1wnyeB3Z zcfv/CqCyezVsRnZFA3mKFHHfc314+5rZ1qOUuXL/I7XKDunEo2NCnMzg2dHz4TtclsS HlxkqT0YkrkAi0JwCM0iS4ocNT+X4oGaRjase5auIU1pvZvkb+ghzJJhyCpE6IxhRDfk iN9X/2MJTiBu7cGla09614ejnkHxZXTZTYzyl3u5IWj5vYyo+mbevZC4Qxl29co3+j4Y IU+kKjhzusBS+2F9QqlWAzENsYTGCn+kPVvOYUC7zu6JfUhJ6FNWSgoEddQc8ZTHKw3G E8Mw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751624196; x=1752228996; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mZ0RE64UQypZytSx4Qr4+gDSoIvyEELE2vq85gWcMKU=; b=INRqU3qDPuDPdJ4qt90avKSADrppIzPygvu1Xt8vQWm5j9oGzgSdep14QgFytiIYYf OVckQdmgprTviwKEdIOcQ4FpSDCSuqBpm3jzpnrhpx+yOO9psKTwHaDcFwEdB5s2jEGC RlTOJqgEeq6aFvMkq9+Rw9uW8Y04nqh/IV6NPZnibJ1k2EUVVChumZadvmb1qRBYbEJ0 9jLUfyurK67SalM03qvFLRy3gegYAxkqOGvhRc/iXAWQjvRiwoLatgS6sDd8mwYZwJic c471/75sSOFTEUUvfZHhvMshgPXhaevZvGwOCbIdlnpTU8qBf8vGIpQBeVQ0ysjD86fs DPbA== X-Gm-Message-State: AOJu0YyE+gkVFqNVtwYMvl8apnoL3/MxXQiGX1US5OX0c6psr+I4DoIO ykqsMtY90EPMWKTBfqccN5lXgHdCzmF7YgqpalA/rlVERAFIqu/yL3ZNrzl2p86V6G9NzJ8py1F wT6GM3oU= X-Gm-Gg: ASbGncv5qYHUiEvAseOb4tVF7FXc8s3CABh97D2gU2oyrq2sJ1E8wXArZ2dw9+lucjM heHiIofmXTORVfFgMnHRa6CUAnIK3Ez+z4MQlSj3k+5Vvu+FFVAIiWw8MOpue/id05cFalnxA8x /SN6RkXC6eK4n28UtRYdjmDEsybn5lTWXmen1Gq2PTVCNkJAY26/T1PutZyyAxxXegBQMI+I4vd ycQNVUcoyxpRqukep/1QFOLDjABY2+7EZ8h4Dp8nIJLX0d6DHO2SQSJsrimThArNE++kWj+0CKr DBQT6Sae0IlPLlZUyC0YzVcTrUV/TNv6AEvca39QNTj7q7lwBxLpOsTbKO/XVOrcW/hrDN12yVm +7CgNleoEcJ00apvIl782jqiaq1VpfzLgptVHx9M7axi4QpE= X-Google-Smtp-Source: AGHT+IGmBL0pugXVIqb5M1kYB6ZZ7i9D/80cByKyUdUcVChXuhsltbKTOe2zoCg8wJ1RgKAgutm03g== X-Received: by 2002:a05:600c:8b6c:b0:43d:b3:fb1 with SMTP id 5b1f17b1804b1-454b3183873mr17616325e9.27.1751624195821; Fri, 04 Jul 2025 03:16:35 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 26/31] accel/kvm: Directly pass KVMState argument to do_kvm_create_vm() Date: Fri, 4 Jul 2025 12:14:27 +0200 Message-ID: <20250704101433.8813-27-philmd@linaro.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250704101433.8813-1-philmd@linaro.org> References: <20250704101433.8813-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::335; envelope-from=philmd@linaro.org; helo=mail-wm1-x335.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1751624245862116600 Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson Message-Id: <20250703173248.44995-35-philmd@linaro.org> --- accel/kvm/kvm-all.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c index 72fba12d9fa..007f82a50de 100644 --- a/accel/kvm/kvm-all.c +++ b/accel/kvm/kvm-all.c @@ -2470,13 +2470,10 @@ uint32_t kvm_dirty_ring_size(void) return kvm_state->kvm_dirty_ring_size; } =20 -static int do_kvm_create_vm(MachineState *ms, int type) +static int do_kvm_create_vm(KVMState *s, int type) { - KVMState *s; int ret; =20 - s =3D KVM_STATE(ms->accelerator); - do { ret =3D kvm_ioctl(s, KVM_CREATE_VM, type); } while (ret =3D=3D -EINTR); @@ -2646,7 +2643,7 @@ static int kvm_init(AccelState *as, MachineState *ms) goto err; } =20 - ret =3D do_kvm_create_vm(ms, type); + ret =3D do_kvm_create_vm(s, type); if (ret < 0) { goto err; } --=20 2.49.0 From nobody Sat Dec 13 22:54:06 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1751624360; cv=none; d=zohomail.com; s=zohoarc; b=n+AbT7nWLeKvZInSRkQIunDHYA7Cx82eWIoP0VHdH+pWEKVa2QNui78dRLMHkNa+BGRf5F1r3dOfh4C1o1RiDTv1tlfVLYXJFUwBQUkuTa2qSYBLTEC4elPDKmg+cGt6a9nThYQLTovzAiLhCXxaUi41AqvYTQIfJXzu+vajVvw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1751624360; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=hfrsLuv7BgUOaclFfgVSuiyNtp0y1WW2rDAJ5uN4uD0=; b=LKK7qM0aTIoyKzlmA3LuT0tPNlaONkKPUiKdjtizO/2HH0s0EwQ8sRaRp0MqkLpaBVDfAvhLuI/jD2AE6OvzRxSviL49tNRrmf83zOromKZOayoF6gqf1kGGyzrWD8bxr5tlpgFJFyd3hsGo5j/eGNL7Rbj9w/kd1bmmfArOTvs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1751624360905500.15889737480836; Fri, 4 Jul 2025 03:19:20 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uXdTM-0001Dj-E9; Fri, 04 Jul 2025 06:16:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uXdTJ-0000x6-6G for qemu-devel@nongnu.org; Fri, 04 Jul 2025 06:16:45 -0400 Received: from mail-wr1-x42b.google.com ([2a00:1450:4864:20::42b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uXdTG-00070D-Ka for qemu-devel@nongnu.org; Fri, 04 Jul 2025 06:16:44 -0400 Received: by mail-wr1-x42b.google.com with SMTP id ffacd0b85a97d-3b45edf2303so663433f8f.2 for ; Fri, 04 Jul 2025 03:16:41 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b471b96731sm2115383f8f.55.2025.07.04.03.16.39 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 04 Jul 2025 03:16:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1751624200; x=1752229000; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=hfrsLuv7BgUOaclFfgVSuiyNtp0y1WW2rDAJ5uN4uD0=; b=bIcKFzRYRXQZOEENW7SyytLh45EtYPAxcIQOBENsVHZNyCP4UTgs+mthb4NZIrmGRo HoyQhw8BkC3jWztwDH+LxNPMPkqGV/mUlEd7c5Z36XBHbT4j5YLPyVLvIKi3Yq7oZvgf 1pi4AwsNrYkX3MaX9sfjEtbLRoSounQPy4NKhSw8uHvo3FGPj06S0XiTv/KgSHZeQKtT Gy11tjUmRLxza8P9KVrFIghf05jgttZzEi8On7r7jOdCc6BmrkpnzjO65U17aimSj88g OAnFqhgug23KMUx4zkaRF2+vmaC7x6kv6dr16YTnlooXinqvuq0UBGM0NvxC1WfONSE7 3f+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751624200; x=1752229000; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hfrsLuv7BgUOaclFfgVSuiyNtp0y1WW2rDAJ5uN4uD0=; b=tBSI7S1YP7+RUYzTyj1AxKHb5YDqtrCQBk9m3XKf6FcCNq5zJPqTmZ84fq4x0vkAJt 1SebPxtByxnsVyZQyiOJxichBw8YQKPOOXa8B17xAK/NTTNs1jU7LN4P8YZDi4r+6bHz fEzgUrHLTouPRdBV7vj1crnX0e1xg0Lz3pDGhPsIoQm09CjZjVEBKUIsX5IrsjZR+YV0 h6YaYO3FH6HgbVEbaAdRhL8Phr5hSBQlVgooTYVd3pa3AF3SFVhLZFbnb+bgkKP/1p2T PweC9KDOrvDcegeR0MH9lt3Ekwjm9SP7nrfHx+sZXnCgp9TxE7KHB6ZCwkJMloka0HL9 Ghpw== X-Gm-Message-State: AOJu0YwDCiq/Yac/LLryZ5cUJgr95sY0aAKg3jTomvNmzSGfK/U72OJ8 LjSS+j6iF8GyxBgikRxgVrj+TBMLuUhwI9u+kDLzITF8H2XMkwIs7vX90EMTU+w1iyzI3x4Ctb5 KTEPqE5o= X-Gm-Gg: ASbGncvda+RQu8E0pX3OY9YjE/b4VjpqkExVHzWUu4+StXS1IfDbNlY2SVBiqjF+R4f UeqLRifiHR+H1USFV1q1h5H7niguqHzcjWfD43juDvDu0PMmHbW1/AWI97CMJbusuARsAxJEmlv j68qsylA42IZXbWuFBGpUUd99/jDGRHD/ctdz7SwusYEJKgLicrC4kdmCQ0wPVrl0F2X7k/YFTc qoRnfhFQXubP5jON4J6VyxUxflPj9hUICZwI01KRuZPZ2qyWsGozsoLKIl+3FCMV259mkJOWJq2 6520yl0SrhNBGnbktcv+9NuwrA2ddctoMv5cbaLQcd4Ty/q/XHJRZqgUd9EM/Krs/mxhR6vji3X TSugRngMzVrvkLo7egZ5LQje18AhMybjoGybv X-Google-Smtp-Source: AGHT+IFhjjD1fJ3Mmkf5v4Aic82arylXmH7pkAVhhA0rhGdmccvT4OG6wHYBqU/Ki6VMQzgqm9XJQg== X-Received: by 2002:adf:fc8f:0:b0:3b3:a0f6:e8d0 with SMTP id ffacd0b85a97d-3b49661a129mr1453315f8f.54.1751624200412; Fri, 04 Jul 2025 03:16:40 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 27/31] accel: Directly pass AccelState argument to AccelClass::has_memory() Date: Fri, 4 Jul 2025 12:14:28 +0200 Message-ID: <20250704101433.8813-28-philmd@linaro.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250704101433.8813-1-philmd@linaro.org> References: <20250704101433.8813-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::42b; envelope-from=philmd@linaro.org; helo=mail-wr1-x42b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1751624361422116600 Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daud=C3=A9 Message-Id: <20250703173248.44995-34-philmd@linaro.org> --- include/qemu/accel.h | 2 +- accel/kvm/kvm-all.c | 4 ++-- system/memory.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/include/qemu/accel.h b/include/qemu/accel.h index b9a9b3593d8..f327a71282c 100644 --- a/include/qemu/accel.h +++ b/include/qemu/accel.h @@ -46,7 +46,7 @@ typedef struct AccelClass { =20 /* system related hooks */ void (*setup_post)(MachineState *ms, AccelState *accel); - bool (*has_memory)(MachineState *ms, AddressSpace *as, + bool (*has_memory)(AccelState *accel, AddressSpace *as, hwaddr start_addr, hwaddr size); =20 /* gdbstub related hooks */ diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c index 007f82a50de..6f6f9ef69ba 100644 --- a/accel/kvm/kvm-all.c +++ b/accel/kvm/kvm-all.c @@ -3786,10 +3786,10 @@ int kvm_get_one_reg(CPUState *cs, uint64_t id, void= *target) return r; } =20 -static bool kvm_accel_has_memory(MachineState *ms, AddressSpace *as, +static bool kvm_accel_has_memory(AccelState *accel, AddressSpace *as, hwaddr start_addr, hwaddr size) { - KVMState *kvm =3D KVM_STATE(ms->accelerator); + KVMState *kvm =3D KVM_STATE(accel); int i; =20 for (i =3D 0; i < kvm->nr_as; ++i) { diff --git a/system/memory.c b/system/memory.c index 76b44b8220f..e8d9b15b28f 100644 --- a/system/memory.c +++ b/system/memory.c @@ -3501,7 +3501,7 @@ static void mtree_print_flatview(gpointer key, gpoint= er value, if (fvi->ac) { for (i =3D 0; i < fv_address_spaces->len; ++i) { as =3D g_array_index(fv_address_spaces, AddressSpace*, i); - if (fvi->ac->has_memory(current_machine, as, + if (fvi->ac->has_memory(current_machine->accelerator, as, int128_get64(range->addr.start), MR_SIZE(range->addr.size) + 1)) { qemu_printf(" %s", fvi->ac->name); --=20 2.49.0 From nobody Sat Dec 13 22:54:06 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1751624292; cv=none; d=zohomail.com; s=zohoarc; b=m4F8I5zfJtfTSxuXgOt3T8BPI6WZXIeXld5RWaCC4EB8NW/KFn+c0AQRRUB1n98v8V7sPegvUrVea+JRl8BzcQrxIKEkofHgelaI2vrlg39Ys82NXj9wmyHYkXu9pHxCQ+HZo1Fh0UpkXej8ddIvnkbOH7yfr8y7+4t6U4SNuAk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1751624292; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=UTBNOqbP3E+GBsl184QB6sPguCL61jIY7KiQPlXXwQU=; b=jefwbCeFazSvjUiHQ4XZ6Oz9SqV0nZpOjoGSNSbof5criN/0O/O7qMexDAPrRYhfDgApEcVt6VATyCzFhuDubKuFMdOxVHgXYkx83QyIQLCJv7rkuaFb6vgA53q/5uJ/F1fWhHowXRaY2l0n1tYIxVFcsTxCGnGwLL68Lg4A+Ac= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1751624292356899.2625795396134; Fri, 4 Jul 2025 03:18:12 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uXdTR-0001bR-Ui; Fri, 04 Jul 2025 06:16:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uXdTO-0001Pz-3p for qemu-devel@nongnu.org; Fri, 04 Jul 2025 06:16:50 -0400 Received: from mail-wm1-x32b.google.com ([2a00:1450:4864:20::32b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uXdTM-00071J-70 for qemu-devel@nongnu.org; Fri, 04 Jul 2025 06:16:49 -0400 Received: by mail-wm1-x32b.google.com with SMTP id 5b1f17b1804b1-4537fdec33bso4595575e9.1 for ; Fri, 04 Jul 2025 03:16:47 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-454a9bcececsm51406325e9.23.2025.07.04.03.16.44 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 04 Jul 2025 03:16:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1751624205; x=1752229005; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=UTBNOqbP3E+GBsl184QB6sPguCL61jIY7KiQPlXXwQU=; b=ldoYscVgpXSauEdjU5oFFFjInVsCQmmDC39LaF9qFoBd0OOJ1vty07R8sdqC0t+lRW uEO85O0dcySBYtHaSaeUV1cxlIutNOnVXimlZRmltzR6oC6oU9zXJg3IT9gBuo/m1BvS 8tGjkYNWaJqwDLvVOuu3qaarl6E5RIOPsDQPMH3X6GVQhdbH0i464UbffBHz5xJuddag +FjxyDPzSZUmRLCi5/rYjsc59px2QkLzmbOJZcQPIqFg1pc3+SkvSAguJFFzRnYm8GsL aFkRH/IT4EG/YpLqb3nx6Rfw55443VyukCzE3HDT9l3lcd90jpwkYj5G1ZYXnTwNxJqb jcCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751624205; x=1752229005; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UTBNOqbP3E+GBsl184QB6sPguCL61jIY7KiQPlXXwQU=; b=uSx1aCmzUBd02CECUzFXdXk2tuYF/KMq3X3Dj4O41X9h9pZBZymiCSZBv4v66x1Xn7 ntVPyhV3xcrFY6NM6ZyrEeb/iledT3xYEmxQaXIR3uNe3mct704aKhWirIhvdSHUHiNa Pud58BUBmP/hB8v642ETqouadxX7PTU8UV2kupwlrioa1VyfirWQ19HfZnqavqYDr33Y LpMyUpbM3Diq5GOPYrtZ14aZHExV6/t7FJzXM4l3YWI3InPxSoklnufwgKNrS4qEIQjf MjuvkDkXTAFXR0wXafLPkoUSbG8IWzZTOn21h47oHuEsHU3kVxW1EDzTOSQeIQi/GIzm +u1Q== X-Gm-Message-State: AOJu0YzwkXBANUl954eCsO643rO+OyTsycke+IdHBzg4zYHWUH4MtsCX BRbVj7cWP6EIrU4x91al1HWaS2ro7V6flGwmrULtmvigNn5Qv9U4fGn7N6UiSyWP8I7Xp+P1ME9 MfNldub4= X-Gm-Gg: ASbGncsxiSUQcmsceFlv8W0BMrRPOymB0sfMb8RM1BvZ0BcHMwYwSsX6ltHunPfUGIN mfZxcPK4pI3Ww+z/mhZ3vFQdjf9jG+DmkOQrPD+Fm13+oUT1ONReTR6TUB20wq5JKZ4cdQufQ13 dVKe1HDoXDWXmS9rC5a6sRSwH9nzRVYrWNgYEYC83YaSwA/Zikcu05BOi7efJHOpYNB7RHine2j PqOcLlJUXBQBwYnAv7LeWZgMykHqugwGLPjcpeqZz3TvhXWA777cy+eKjORbBRkkMUxCRrq2f96 FJGFqz9WImF1nyQlO2t4YDKjv/vd0mtkiw8FbjmcUVOkqUBKk1hg6+jWTGyfK3HEyyoRK4Sg1L1 vXsj98mvE4gSG7TPpsi0EbiulStsYICyaWI5U X-Google-Smtp-Source: AGHT+IEQ65Sixc21MzYmjV+Odyy/AXfdMZr1Acj3Yjp7ap5NE7L44HXopBvTc5d2AgVVUkfcAmT27Q== X-Received: by 2002:a05:600c:8582:b0:453:745:8534 with SMTP id 5b1f17b1804b1-454b5110ec7mr10872305e9.12.1751624204930; Fri, 04 Jul 2025 03:16:44 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 28/31] accel: Remove unused MachineState argument of AccelClass::setup_post() Date: Fri, 4 Jul 2025 12:14:29 +0200 Message-ID: <20250704101433.8813-29-philmd@linaro.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250704101433.8813-1-philmd@linaro.org> References: <20250704101433.8813-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32b; envelope-from=philmd@linaro.org; helo=mail-wm1-x32b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1751624294490116600 This method only accesses xen_domid/xen_domid_restrict, which are both related to the 'accelerator', not the machine. Besides, xen_domid aims to be in Xen AccelState and xen_domid_restrict a xen_domid_restrict QOM property. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson Message-Id: <20250703173248.44995-36-philmd@linaro.org> --- include/qemu/accel.h | 2 +- accel/accel-system.c | 2 +- accel/xen/xen-all.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/include/qemu/accel.h b/include/qemu/accel.h index f327a71282c..a6a95ff0bcd 100644 --- a/include/qemu/accel.h +++ b/include/qemu/accel.h @@ -45,7 +45,7 @@ typedef struct AccelClass { void (*cpu_common_unrealize)(CPUState *cpu); =20 /* system related hooks */ - void (*setup_post)(MachineState *ms, AccelState *accel); + void (*setup_post)(AccelState *as); bool (*has_memory)(AccelState *accel, AddressSpace *as, hwaddr start_addr, hwaddr size); =20 diff --git a/accel/accel-system.c b/accel/accel-system.c index 913b7155d77..af713cc9024 100644 --- a/accel/accel-system.c +++ b/accel/accel-system.c @@ -58,7 +58,7 @@ void accel_setup_post(MachineState *ms) AccelState *accel =3D ms->accelerator; AccelClass *acc =3D ACCEL_GET_CLASS(accel); if (acc->setup_post) { - acc->setup_post(ms, accel); + acc->setup_post(accel); } } =20 diff --git a/accel/xen/xen-all.c b/accel/xen/xen-all.c index 8279746f115..bd0ff64befc 100644 --- a/accel/xen/xen-all.c +++ b/accel/xen/xen-all.c @@ -64,7 +64,7 @@ static void xen_set_igd_gfx_passthru(Object *obj, bool va= lue, Error **errp) xen_igd_gfx_pt_set(value, errp); } =20 -static void xen_setup_post(MachineState *ms, AccelState *accel) +static void xen_setup_post(AccelState *as) { int rc; =20 --=20 2.49.0 From nobody Sat Dec 13 22:54:06 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1751624361; cv=none; d=zohomail.com; s=zohoarc; b=aHuUyUkmh0o9Mnn/qJZmfhSOT5k4k+GuhnEs1J3RPXI/5EcfWSGnlAJDcOLxAYcNjIq4TK5GrKrxJnmgXhRX2xGGV4ZKd0Wx5zqSKP5bafryEAZnPQU8G9B5Nt2vlo4v9LJGI9obs5zGrlLEnOfLD4CTN6xZSjLMX7e7isZyFB8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1751624361; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=Mmz1EiIT7E9enw2QEgqBm9stdbrwDBoce02YpMIkdwI=; b=TlRXK5hzGuoV5WjAaNnFojIhbeXDsQ/CY3tPN9RGe7PFa9lE0N4BigMfIe6Uwj4l9xKnrFrmWCy8ENUiuqwQDPK/3MuOGsnQSFXrlYlK4kY6HPfbV8EXzJQJ+tO0hXCTSCBFb2QVA9bbYji1t3ooM+TArdXurM1kWQBsjztrqUk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1751624361186694.0207042336327; Fri, 4 Jul 2025 03:19:21 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uXdTa-0001tz-17; Fri, 04 Jul 2025 06:17:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uXdTS-0001g7-3s for qemu-devel@nongnu.org; Fri, 04 Jul 2025 06:16:54 -0400 Received: from mail-wr1-x42b.google.com ([2a00:1450:4864:20::42b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uXdTP-00072I-Vl for qemu-devel@nongnu.org; Fri, 04 Jul 2025 06:16:53 -0400 Received: by mail-wr1-x42b.google.com with SMTP id ffacd0b85a97d-3a6e2d85705so322490f8f.0 for ; Fri, 04 Jul 2025 03:16:51 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b471b97f10sm2133998f8f.57.2025.07.04.03.16.48 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 04 Jul 2025 03:16:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1751624210; x=1752229010; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=Mmz1EiIT7E9enw2QEgqBm9stdbrwDBoce02YpMIkdwI=; b=abwrBL5iIUUcsZFbfyG2Zw5thXLGZ7/p0sDy0vSiT3Q+7sviA5r+BcFbUsnqPmgSm/ UZUoKuUz3p6oIqOmuslmmW7gSH6rUkkfrf9pNCf8h9dr7+v0K/qEKlop0YTy7Ss7Jqcr rlciPd2A6EbFF/r6Ev1pDc4Svy0rtLZwnE3AkrCSUvpv9LUdP83c9mCIQLTTu+yZyvm+ XSzFpZnlCwTy+6wN5MePe9uXgmIgyYNZ3GbEleuOsIEwuJmXD6cB61MoZkEu3QxUEpjD V3jIKS06byocbnnIQyor5UfiBGnF3elih0R/9/pQqKMJrisZiuStbhL0BKA3rw7Wk9Jw ke5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751624210; x=1752229010; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Mmz1EiIT7E9enw2QEgqBm9stdbrwDBoce02YpMIkdwI=; b=KqUi7so7I1bQdTglWzZpi6QCANaPtCZDgPP/39ikVWbVzqpCyefghu8AZLSNH94mih ZMttayXO3SijKElALYLvSKkKt29u3oVVelHkOHVPVWsJjZkd4DmQsT/qQjYTy4xeRBDU hCtzQ2HMMTzN17u72ArXJy7rrln3r4K/5SkYmZyDf72yKuU16st4jZQXrU77b5yCVuS/ vjjmcKHx8RbDUXj0K+Bj4luqOEluLMoUDiyjarP5+DyeFBzbtgg0f/kbiXWZXrUuLdOe f09Qui76fXaQOSZiSAoc+eLnTR+C3PtML/Wnnuu1niMwqRs2cdffUOmz06HkHlTMfLT8 /gTg== X-Gm-Message-State: AOJu0Yz3ayp563Q6wU1opkLkC2cF9fw8XXBrinXJ+Y4XGrZazRioQUDK F5x4vK/2YOMGSSutTJrsNinAOEjSMG/UnDBIwXGh6TOL+5mGCxit1Ksole4jy/7dBQ1CiQxaK5f vvmvhvC4= X-Gm-Gg: ASbGncuHCCPJaMnwiYajhtT6gvsGA+eR1mjr4DxBZZMYH9946joZJOxYIAkmxG5my6p c8gaekeYeooqjl6vp0EIpwggsfw2VZm9Nkh3s+qp2fCc/J7zvics0Nrv3q6PpP2JS891mNEiDwz Tbb9f1iymhkxOt3wZCerWKe2v1EpsejhTGgL4DMS8hboJmrk0WwuQ9XhKF7ow/7cb3t6aAs0nWV gIN4ACpgimjou0qfdmADWJZtyY9RIbgXB6N9P+SXH00tYeUJf5Ekt5PKgOeswGhG5idqe7r4ZU5 aJteOPLwBqHqkzhKoqbN7RTaCj/4vr85Ul3euznqHbSoSLK1FKtIDN2wl7XS7kZd4El+trVUXsB Vo50nf/jRRqYj0JUqCzrKrBWKIrybom01tnG4 X-Google-Smtp-Source: AGHT+IG1OvokeaCsO01pGcHKnjJJqIB4bcX3kZcdBiUO954sHRGsritFkO912tizcckONwxa/tPaRg== X-Received: by 2002:a5d:5f8d:0:b0:3a4:f70e:abda with SMTP id ffacd0b85a97d-3b4964eafb0mr1699730f8f.10.1751624209502; Fri, 04 Jul 2025 03:16:49 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 29/31] accel: Pass AccelState argument to gdbstub_supported_sstep_flags() Date: Fri, 4 Jul 2025 12:14:30 +0200 Message-ID: <20250704101433.8813-30-philmd@linaro.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250704101433.8813-1-philmd@linaro.org> References: <20250704101433.8813-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::42b; envelope-from=philmd@linaro.org; helo=mail-wr1-x42b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1751624363312116600 In order to have AccelClass methods instrospect their state, we need to pass AccelState by argument. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson Message-Id: <20250703173248.44995-37-philmd@linaro.org> --- include/qemu/accel.h | 2 +- accel/accel-common.c | 2 +- accel/hvf/hvf-all.c | 2 +- accel/kvm/kvm-all.c | 2 +- accel/tcg/tcg-all.c | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/include/qemu/accel.h b/include/qemu/accel.h index a6a95ff0bcd..1c097ac4dfb 100644 --- a/include/qemu/accel.h +++ b/include/qemu/accel.h @@ -50,7 +50,7 @@ typedef struct AccelClass { hwaddr start_addr, hwaddr size); =20 /* gdbstub related hooks */ - int (*gdbstub_supported_sstep_flags)(void); + int (*gdbstub_supported_sstep_flags)(AccelState *as); =20 bool *allowed; /* diff --git a/accel/accel-common.c b/accel/accel-common.c index 4894b98d64a..591ff4cbb65 100644 --- a/accel/accel-common.c +++ b/accel/accel-common.c @@ -124,7 +124,7 @@ int accel_supported_gdbstub_sstep_flags(void) AccelState *accel =3D current_accel(); AccelClass *acc =3D ACCEL_GET_CLASS(accel); if (acc->gdbstub_supported_sstep_flags) { - return acc->gdbstub_supported_sstep_flags(); + return acc->gdbstub_supported_sstep_flags(accel); } return 0; } diff --git a/accel/hvf/hvf-all.c b/accel/hvf/hvf-all.c index 68f1425fae2..b6075c036e2 100644 --- a/accel/hvf/hvf-all.c +++ b/accel/hvf/hvf-all.c @@ -281,7 +281,7 @@ static int hvf_accel_init(AccelState *as, MachineState = *ms) return hvf_arch_init(); } =20 -static int hvf_gdbstub_sstep_flags(void) +static int hvf_gdbstub_sstep_flags(AccelState *as) { return SSTEP_ENABLE | SSTEP_NOIRQ; } diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c index 6f6f9ef69ba..45579f80fa5 100644 --- a/accel/kvm/kvm-all.c +++ b/accel/kvm/kvm-all.c @@ -3980,7 +3980,7 @@ static void kvm_accel_instance_init(Object *obj) * Returns: SSTEP_* flags that KVM supports for guest debug. The * support is probed during kvm_init() */ -static int kvm_gdbstub_sstep_flags(void) +static int kvm_gdbstub_sstep_flags(AccelState *as) { return kvm_sstep_flags; } diff --git a/accel/tcg/tcg-all.c b/accel/tcg/tcg-all.c index c674d5bcf78..5904582a68d 100644 --- a/accel/tcg/tcg-all.c +++ b/accel/tcg/tcg-all.c @@ -219,7 +219,7 @@ static void tcg_set_one_insn_per_tb(Object *obj, bool v= alue, Error **errp) qatomic_set(&one_insn_per_tb, value); } =20 -static int tcg_gdbstub_supported_sstep_flags(void) +static int tcg_gdbstub_supported_sstep_flags(AccelState *as) { /* * In replay mode all events will come from the log and can't be --=20 2.49.0 From nobody Sat Dec 13 22:54:06 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1751624422; cv=none; d=zohomail.com; s=zohoarc; b=YlKqzPjtzKropQfow6IvWCZMuhd9GrKtzeNIGiIekvYA/VOBFu+W1lyEOeQldHzi+kjm7jph7gRTmnLJB/D5jzndJyh3zqOODXHMIbqLlNPI9xrzfwprjLUT6Mdl5NOwDDNpAbVmaACYrC081DPASrwvUTT5xpTBdn2JUpw65oo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1751624422; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=Y+PveYXLiA/YiEmWDBVO+M6ycQoq9kMKoK80Idtoeg4=; b=h2GQ+tZOH+bnXxjEr25y8mhliRrvtp5blKeX3eJNSkvxgGaX+7IGNWVGDuqTB6y3bTSmT9kt141PPO64tyvYbldpTUnKW7JusLa0AtI8pgCkMU3oLnGo/ZB4D048S9rsI8OGdYJkUgE36WFchrDN3xU4nxFJGTflaJoTDtnx+lI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 175162442234350.19918547511975; Fri, 4 Jul 2025 03:20:22 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uXdTb-000251-Rs; Fri, 04 Jul 2025 06:17:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uXdTW-0001mJ-7S for qemu-devel@nongnu.org; Fri, 04 Jul 2025 06:16:59 -0400 Received: from mail-wm1-x32c.google.com ([2a00:1450:4864:20::32c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uXdTU-00073a-1N for qemu-devel@nongnu.org; Fri, 04 Jul 2025 06:16:57 -0400 Received: by mail-wm1-x32c.google.com with SMTP id 5b1f17b1804b1-450cfb790f7so5739345e9.0 for ; Fri, 04 Jul 2025 03:16:55 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-454b10b8c89sm25814525e9.38.2025.07.04.03.16.53 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 04 Jul 2025 03:16:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1751624214; x=1752229014; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=Y+PveYXLiA/YiEmWDBVO+M6ycQoq9kMKoK80Idtoeg4=; b=PwGTotdw4qSzJIA8sok25yS/ri1tlAKaT5+/L3zfmf+deFByg/WEGhyE68ZdbIsT4E +wzyimaN97Px7+7pyceJF+/YJDlW6zOYw7/0sRbBAb7f43KM8eqx18AscxQ1i/9WhzwP bV7SgFIC0NCc0Mab41AxU2pbBSuFBcI7Bs9ZkJS1yTquXZe0Fk1c8LYYgXY94hKqrN+H 5Fs9siTMBvusSSgz3TS0SVL+BgjxtksGO+x/c8jI4UATgEkey8oDDUGFHinPT7Ywwg2X z+pXKyijUA7RzXeRf9kur0sPgsG37tPNf4At83zDtz1tLzXcvrSrVRLdq8NXJqU9d5D9 LoDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751624214; x=1752229014; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Y+PveYXLiA/YiEmWDBVO+M6ycQoq9kMKoK80Idtoeg4=; b=Nl/Ob+HMIT7rVVQUqZK2J8ad4PNFbcj6iSEwtf/0O+H9TbI8Rc8bAdv49nMkSe+j+P 8E45y+BoQEv5qxcTRCJSywG2WJ7Gti7Gyk2vIax3mdJX4/xEfXkiTCG/fznOMVAPsD96 Hh6KeG7eYbqHqVp6qe2eSFNBXiJZZi5PBSgdt90CImiQaIsKk7xFRf/zUcJhgSrT8ViA nz/GfoMYihDEjBKdCpCBbEAranyElfKDZ9aPK9jK5wSLf63QtPEb+01xiy6659mEhctj C443hpCp+egJuMaseEew8i6ZW3esV/jyJd6D/n3sBlbBODWahNXDeahlyDLsCT27nq+0 yR3w== X-Gm-Message-State: AOJu0Yx9I3dWFLHB8IN9v/9SsB+L7k6DMMD+ni1yUYq3eEloS139JwxW ejqACpt7yi+7dz9KReENnHoBOYmUeWl+o/Z8N6PR2oLHiGp6r71KSeFZR594yKykgKrExr3kC7U 8lV09ETA= X-Gm-Gg: ASbGncuso7ER/WEp041hWlq9Fl8nNsPm26jp4AMAwnX7x/nJtcM94neknVr2gmg1oXQ pqVolwipl0aucyT96MQvQ6+H6UDZdQc+9EiqMHo+9o/UJbYopiChPH+cOnF+2qivoLjJ1ijXIsh 8KjElajReB2B0mWmOkYS8375Eq4U05aH6nVDw++Kmdo1N5U+PYTRwriUo2iM1/HfRpLX0+R7lCL kabz0f024TdGmVxjOEx0L1vYMJcu9Mh9OLvUo6IDIHx6zuRJuwODr5GcQNxgdJmtOnHk20nvdRb LEt490iJwuDRGowN3gDdNrIuXmqn5IwV59PaQYemuhNLYupyESATzDDN9CKbzgXa00LxiURVq6W of26cx9gLnXuD4L3Vgg//7gJ0tyyvO5+iNYv9 X-Google-Smtp-Source: AGHT+IGFTx1K2rmHQ96EsEDBmY9hRME8t38BxzRUf8cI34gybe5loQexvtIu6h/ihL33Ig4MdoljRw== X-Received: by 2002:a05:600c:528e:b0:451:df07:f437 with SMTP id 5b1f17b1804b1-454b3115054mr25775265e9.30.1751624214110; Fri, 04 Jul 2025 03:16:54 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 30/31] MAINTAINERS: Add me as reviewer of overall accelerators section Date: Fri, 4 Jul 2025 12:14:31 +0200 Message-ID: <20250704101433.8813-31-philmd@linaro.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250704101433.8813-1-philmd@linaro.org> References: <20250704101433.8813-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32c; envelope-from=philmd@linaro.org; helo=mail-wm1-x32c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1751624424062116600 I'd like to be informed of overall changes of accelerators. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson Message-Id: <20250703173248.44995-40-philmd@linaro.org> --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index fca98e12195..bfd59f64122 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -495,6 +495,7 @@ Guest CPU Cores (other accelerators) Overall M: Richard Henderson R: Paolo Bonzini +R: Philippe Mathieu-Daud=C3=A9 S: Maintained F: include/exec/cpu*.h F: include/exec/target_long.h --=20 2.49.0 From nobody Sat Dec 13 22:54:06 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1751624384; cv=none; d=zohomail.com; s=zohoarc; b=DptTBjX/uadlZfiUiylDsZKJUJnC3NSrhm3OIe9CbyWJxOcwA/jX4E0JCyUpjm79lVHz6ni2ylRc/Kuy3GJXKbYWYZQ4PYpx1SSULaSLtb1XXBbNJTUoeb+oVWNn1e6w262UDskaMk1KexiUTONtyl36hjH0KO0B4HCTvwcuV5o= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1751624384; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=aW8jT2Wve8m9HiyaZWg6TzaiyGwHlA9RHVgvMmEmKaQ=; b=K6pYji/vkXdzeLlPBNyovmJAU8RdBZ9PZZqQGvZtP3tcKAJYvfVaJjdEvQjAt4cicpcjVrvNs3+TX6Sp8rYgv3Kv8L0bLn2nE9dflJjmSfsCUlWyr4PnvYVbzyczPavGt8SoAaKDwz9jgGBXw3/ZHCZYw6IqTARc26bSjrKAg6c= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1751624384977717.9199479199663; Fri, 4 Jul 2025 03:19:44 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uXdTd-0002Ic-Uf; Fri, 04 Jul 2025 06:17:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uXdTb-000250-6t for qemu-devel@nongnu.org; Fri, 04 Jul 2025 06:17:03 -0400 Received: from mail-wr1-x42c.google.com ([2a00:1450:4864:20::42c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uXdTZ-00074Y-4s for qemu-devel@nongnu.org; Fri, 04 Jul 2025 06:17:02 -0400 Received: by mail-wr1-x42c.google.com with SMTP id ffacd0b85a97d-3b45edf2303so663756f8f.2 for ; Fri, 04 Jul 2025 03:17:00 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b4708d0a5csm2083276f8f.29.2025.07.04.03.16.57 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 04 Jul 2025 03:16:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1751624219; x=1752229019; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=aW8jT2Wve8m9HiyaZWg6TzaiyGwHlA9RHVgvMmEmKaQ=; b=YRLJIf7N2kXU5OvLDFhRDTQAD/QKMO+yDbkaCJLMBym0Z4lqISw3lgUZ2JDzQzL/3E jTFJJtfw9aoMlMow/A6n7zYufpM7LscdngrST3GG92NzCcjRRuoDILH7y81/u8Rtaeug V+bS0BUKMuWCRplbn8FlZiAgOdUc32C43q9aH49R3bVvA+w0ZJI2WoBTXXNVt3wT6XDp u1+cXXMPMEuJACTZUwdlwSv6hJgTvQsh6WzUCTmtMC91nahuVhKTD1FZpCfAaFnO/Q/E PHNlTt4NqdmXaKQL0Hs+nlLdVhcXuubiJFwTOU5xhulE38kD+xuyRKrDvWryqLUff728 qyNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751624219; x=1752229019; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=aW8jT2Wve8m9HiyaZWg6TzaiyGwHlA9RHVgvMmEmKaQ=; b=C6Ds7p+n1zrF4s64S3iHk3+mxaH1K68y2Rj5MEovfu9W1YJR5kR+WCVHtB3V4yRFdj mL9hYVtgPthzGeHXYuJdKJ7gy1+gPcyvzYg9WO493YkEQJeTUri1otWK8kCg4BCiHsvo HIFTZ2fP8MpFxmlY11+DTR32amU4xbmfFI/5f876BS8sJaA/32TZsizEvSNTVGx48cyY iyAmYyNMSIPiIXo0Esm/eI0JyKsoO5xIdYNnoK9RyDbM2xn+XB3kWz/dkcGkfv/w5Bu+ MGX5sUEPRL7tqxdj+8Mv7JVxln4RwPzIuHDX7+Pp3DSqTOS1JK2lTvwm1JK9X9R44Fgk KV+A== X-Gm-Message-State: AOJu0Ywu8TIlmHUOqQQE1P+NXOA9ZghBtEtkv48zx57/M0WP0TC7tbZ6 63xXG07UUAWkGHN5hYg8sX5Qsf3AoIWLdkoGZ/qLCxVc6wTdPShYSE3+uKuSFD+q7o5SWetqNvW vaUjG29U= X-Gm-Gg: ASbGncu9NqxKIDuLhqScwVDN8brrZtEtqaePG6RItFpwwXByl0tP5CbUf03bcUFoUFZ STrdGG0PQI4kdj7gKdGBxUm6pctJih/pM5Jxy8uFHBqCIbmTlIsyJt2cHJMARLOa+dLpKtpJygs OKSfbcZEd5Dq9OQt14ju8ZZ8rIrdiNS+HtJnTlq9/B/qGtQv/KieiyDPyZ/1WhhqyhDGpO21Auf rnsHge93+H7iN6gImK5UjVgSTOEZ8LucvCVn4lA0kbI/xyj1lcaCmeXj9ZHHUw2iOh2SOsjOzo+ hx6cxu3aBSHyQmlBb0x3CPcUdyFPd6DzlKmGkgTprP0nvm7YYWd69x68idN3DDSXM1pW7tTgLzD NiqEG5h+NdsziK3DlQEixreXSxPmU9uP9KbFK X-Google-Smtp-Source: AGHT+IF3wWl/dXPWddWZhkJIPm+jB9bAgRPyGBzoOVuDFY+YwD8VcH4+2FgwzuJgcwhUzFlEm1B8sQ== X-Received: by 2002:a5d:64e4:0:b0:3b1:8db7:d1fc with SMTP id ffacd0b85a97d-3b4964f92b7mr1619616f8f.21.1751624218666; Fri, 04 Jul 2025 03:16:58 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PULL 31/31] hmp-cmds-target.c: add CPU_DUMP_VPU in hmp_info_registers() Date: Fri, 4 Jul 2025 12:14:32 +0200 Message-ID: <20250704101433.8813-32-philmd@linaro.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250704101433.8813-1-philmd@linaro.org> References: <20250704101433.8813-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::42c; envelope-from=philmd@linaro.org; helo=mail-wr1-x42c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1751624385769116600 From: Daniel Henrique Barboza Commit b84694defb added the CPU_DUMP_VPU to allow vector registers to be logged by log_cpu_exec() in TCG. This flag was then used in commit b227f6a8a7 to print RISC-V vector registers using this flag. Note that this change was done in riscv_cpu_dump_state(), the cpu_dump_state() callback for RISC-V, the same callback used in hmp_info_registers(). Back then we forgot to change hmp_info_registers(), and 'info registers' isn't showing RISC-V vector registers as a result. No other target is impacted since only RISC-V is using CPU_DUMP_VPU. There's no reason to not show VPU regs in info_registers(), so add CPU_DUMP_VPU to hmp_info_registers(). This will print vector registers for all RISC-V machines and, as said above, has no impact in other archs. Cc: Dr. David Alan Gilbert Signed-off-by: Daniel Henrique Barboza Reviewed-by: Alistair Francis Reviewed-by: Philippe Mathieu-Daud=C3=A9 Message-ID: <20250623145306.991562-1-dbarboza@ventanamicro.com> Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- monitor/hmp-cmds-target.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/monitor/hmp-cmds-target.c b/monitor/hmp-cmds-target.c index 8eaf70d9c9a..e9820611466 100644 --- a/monitor/hmp-cmds-target.c +++ b/monitor/hmp-cmds-target.c @@ -102,7 +102,7 @@ void hmp_info_registers(Monitor *mon, const QDict *qdic= t) if (all_cpus) { CPU_FOREACH(cs) { monitor_printf(mon, "\nCPU#%d\n", cs->cpu_index); - cpu_dump_state(cs, NULL, CPU_DUMP_FPU); + cpu_dump_state(cs, NULL, CPU_DUMP_FPU | CPU_DUMP_VPU); } } else { cs =3D vcpu >=3D 0 ? qemu_get_cpu(vcpu) : mon_get_cpu(mon); @@ -117,7 +117,7 @@ void hmp_info_registers(Monitor *mon, const QDict *qdic= t) } =20 monitor_printf(mon, "\nCPU#%d\n", cs->cpu_index); - cpu_dump_state(cs, NULL, CPU_DUMP_FPU); + cpu_dump_state(cs, NULL, CPU_DUMP_FPU | CPU_DUMP_VPU); } } =20 --=20 2.49.0