From nobody Tue Dec 16 03:21:25 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1751564115; cv=none; d=zohomail.com; s=zohoarc; b=L8Fzrd3GQV8tREByS34BDHnTrFw4AXOfJW/vmvDQNgxt0hWMOSOtm3+r8fOSJMxmqIG9DWsZybYKl8s6Q+oLYwnJKOqL6J+w6WO71MtkUQGBOR39OZ0eQeA13yOAOo4pSJPNiApEGlbEt517S6oLFaA1MdP2x801ecNSETEjjfU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1751564115; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=zSMALvjOcbwDFxdBZhQQT9TGvgwhtr1LjNKTHw1swdk=; b=H0tr7TQav8gx23LDCMpy816wP9Xtio1OLxCRe27ZPPCjVU8unReQUTGsjQf4XUAjP38yCNCzzrNA6wmMqVRNitWNlr4+ooRsJ0iLLHflF3NW0QO06AAixpDWIaxHKmEW8Mp0LSUFrUR8bDfvkPmOiWb8dJZbg6MyzCuhQF9PA5o= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 17515641155741012.322440381302; Thu, 3 Jul 2025 10:35:15 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uXNo6-0005TF-Ap; Thu, 03 Jul 2025 13:33:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uXNo1-0005Sg-Ci for qemu-devel@nongnu.org; Thu, 03 Jul 2025 13:33:05 -0400 Received: from mail-wr1-x42b.google.com ([2a00:1450:4864:20::42b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uXNnz-0007nM-KW for qemu-devel@nongnu.org; Thu, 03 Jul 2025 13:33:05 -0400 Received: by mail-wr1-x42b.google.com with SMTP id ffacd0b85a97d-3a575a988f9so45526f8f.0 for ; Thu, 03 Jul 2025 10:33:02 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-454a9bea4a9sm31666605e9.37.2025.07.03.10.32.59 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Thu, 03 Jul 2025 10:33:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1751563981; x=1752168781; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=zSMALvjOcbwDFxdBZhQQT9TGvgwhtr1LjNKTHw1swdk=; b=gpYej75Xj1bS1X8weRzAo481Z48mh+BE3AxKqHy2MG7YckZTgYrdAZKIiVUAUf/F+p 9CeV2WqxH23qdJ1WyVvNLdtnSK7jf3ple7lUQvbaPnIXEMBDzEXjR29AzkLkHQ/jzwY4 NbYMwywtc8TmHr6kK6nANSiv9RXuE9ixIDfnM25N2Fxjsj+IoA02fXxVBIsLvUJHAcag JepanPSgk7PP8HyP8JjEL0gLqaLNwAUPoLeqFxgjYmH9a0MaPkBKXTxqR2XGEcZkh5AM lz3c+vSJtq3MaVopCa/j2CDa1/Mrr/Y/bbz4cPlr3oiADT3I/Z6YnQLqnQJTpCY+qVXG PmtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751563981; x=1752168781; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zSMALvjOcbwDFxdBZhQQT9TGvgwhtr1LjNKTHw1swdk=; b=Dmn4mV+GHO2J+5J7kqqZrw8H90mlW2akDuL8NFA0NjAi3zGKZsLZExrSlJPSy0RbT6 6yJenvOdD8zbYe3el9Kn5A5leB+dOZm/8FvNGC6A+cP994RG9x0vF5jk9IVn17hVIjl9 y5avsLax4pENLpwbpTzxl+R/+YP5wrRWqWtW5rn4Ug2pHXk3zFDlJUnedYwkbPQxma2N z9bsqkwkNMQd1HgUVPfAhQSxXpRFrD4tKLmVSIqmfAO6iNh1Wcee9rbYmRFwAucmKdKU d5Z2MiGP0LgJh+jxTE7Arj2WmSpCF1xyp3SYpRlEy4As7sel4UHW8mugn9r8xDNkCY3E O4VA== X-Gm-Message-State: AOJu0Yzau92vF4o+B19JkQX8Egqohwy6wjgn3UefRQIjmcBZ2npiiZq5 nkFPmLjwopvPjWRzjyrv3cRoOm8F84YhYMOHmwlgA8UvlZRw3VvMNtI9sZkaJjv2VhBw2zhOC1P PgVgbPro= X-Gm-Gg: ASbGnctQcLcamGPCgf+ef9hNNbr0heiRMbPbnYwx2qbLJuFhIxSRMneP+oFRKAeZUjC PxsGQ3/OH80ZROY+O6N/Mp51PK0Sn9PUG6psWK12fT8otmxyTolRtw/Hh8e1bYFWcMDdooypBGj 31pH2pPP5TqB3qSJbLPLjapA3/0joG5Ld+o2lReL05N5+Kl9kPFer/xpdPP2gHO2qeneTBisXtn ocr/4JQA9ihApUIXWwIigDtyB67aZ5CzIKOXufYt8ljTBuivmA+QOTADeCUF81rd7rERuIG9L87 UNf40I1ADdouTZBZkF6YQwsQ3XsMJRx/uQ2KPb6GMV4TLtzIvsjBsWoLtSNrZEzue2DD/PxZqeI pV5mf70kC8H13MOdA07gnN/NGQMTPQtRmrjyX X-Google-Smtp-Source: AGHT+IGFu80crPNQoEIjjt6dkLl56V2F1tSkb0BEa/Vn6eF8EhrmaihENxnjtBeptWNpVQGwn+pzQA== X-Received: by 2002:a05:6000:2711:b0:3a5:39be:c926 with SMTP id ffacd0b85a97d-3b32ebd78efmr2469546f8f.32.1751563980898; Thu, 03 Jul 2025 10:33:00 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Zhao Liu , Paolo Bonzini , Richard Henderson , Pierrick Bouvier , =?UTF-8?q?Alex=20Benn=C3=A9e?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Peter Xu , David Hildenbrand Subject: [PATCH v6 02/39] system/memory: Restrict eventfd dispatch_write() to emulators Date: Thu, 3 Jul 2025 19:32:08 +0200 Message-ID: <20250703173248.44995-3-philmd@linaro.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250703173248.44995-1-philmd@linaro.org> References: <20250703173248.44995-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::42b; envelope-from=philmd@linaro.org; helo=mail-wr1-x42b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1751564116736116600 Commit 8c56c1a592b ("memory: emulate ioeventfd") added a !KVM check because the only accelerator available back then were TCG, QTest and KVM. Then commit 126e7f78036 ("kvm: require KVM_CAP_IOEVENTFD and KVM_CAP_IOEVENTFD_ANY_LENGTH") suggested '!KVM' check should be '(TCG || QTest)'. Later more accelerator were added. Implement the suggestion as a safety measure, not dispatching to eventfd when hardware accelerator is used. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- system/memory.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/system/memory.c b/system/memory.c index 76b44b8220f..4f713889a8e 100644 --- a/system/memory.c +++ b/system/memory.c @@ -25,7 +25,7 @@ #include "qom/object.h" #include "trace.h" #include "system/ram_addr.h" -#include "system/kvm.h" +#include "system/qtest.h" #include "system/runstate.h" #include "system/tcg.h" #include "qemu/accel.h" @@ -1530,12 +1530,7 @@ MemTxResult memory_region_dispatch_write(MemoryRegio= n *mr, =20 adjust_endianness(mr, &data, op); =20 - /* - * FIXME: it's not clear why under KVM the write would be processed - * directly, instead of going through eventfd. This probably should - * test "tcg_enabled() || qtest_enabled()", or should just go away. - */ - if (!kvm_enabled() && + if ((tcg_enabled() || qtest_enabled()) && memory_region_dispatch_write_eventfds(mr, addr, data, size, attrs)= ) { return MEMTX_OK; } --=20 2.49.0