From nobody Sat Nov 15 14:29:01 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1751533056; cv=none; d=zohomail.com; s=zohoarc; b=Q7zfGbQQdrXs+BjCcp9+sf9LsaYxgES17Yi5yuDExTqOdFU0gdLemQ6Y9Bfq1cuJkkx9EsDCf4JORDrN+0ZnT0Pd/E22F28beV3MOWxWaBJ2DAbxlE809fkDI9OVspGim3QSAHw0b+0j32mco0U1qppi9/C8thGC/3YsmkPWj0E= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1751533056; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=aKRfOMZpAFbQW59XcJc9qTc3jh/YMdne3jcVAlhxqzs=; b=KvtqPhm+8BdiV6x1Eu5WJHb/JOfbOBzzSwJTOs+cIyuh84fmDAMryDLA38za1pCe0unmcTD3EZbSJsp85llHkkI4kCGB0h+tALr6/bZ0xIBNZo5jsR2WO0wGf8C26xMFj9e8fnqzAJukZw2CoVr/b9CvZAXvYtrDjiGtk/hz1xY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1751533056842998.4590329520684; Thu, 3 Jul 2025 01:57:36 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uXFkK-0002dI-1p; Thu, 03 Jul 2025 04:56:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uXFkG-0002be-Ay; Thu, 03 Jul 2025 04:56:40 -0400 Received: from mail-pf1-x429.google.com ([2607:f8b0:4864:20::429]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uXFkE-000824-GK; Thu, 03 Jul 2025 04:56:40 -0400 Received: by mail-pf1-x429.google.com with SMTP id d2e1a72fcca58-7424ccbef4eso4819831b3a.2; Thu, 03 Jul 2025 01:56:37 -0700 (PDT) Received: from localhost (pa49-178-74-199.pa.nsw.optusnet.com.au. [49.178.74.199]) by smtp.gmail.com with UTF8SMTPSA id d2e1a72fcca58-74af57ef4dbsm16631704b3a.160.2025.07.03.01.56.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Jul 2025 01:56:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1751532996; x=1752137796; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=aKRfOMZpAFbQW59XcJc9qTc3jh/YMdne3jcVAlhxqzs=; b=hhB2hXRBMcj083kErq/iYSX+lcEiF6uWUBN9eLE9Pdao/V2PrOHD65Bjro62c9CDPn voK1kWvh2EbLlP4rcn+Qx4Ma2MiiFMMiO04/N4nj0apAT++5SAI3GSV9ezwTBRRqUWlO vGejemD29VwWucBvW1CJ9MIhQy2ujN3fYIBYEKuOUeZVWiLGzba68OKb3wbcb4Yahvmr nGvfvjN4MPxOjsP0gF8z3Hpmupoxe56Hr6l6gju5hLldokK9K+/U80baHfyptIruumE7 s66Lk3oFdlYEckw1+7Xa10kq9vujDxW4CVCeUg6Wcv7g8GwcxSrGFb0YUWTcheebzPdS BaVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751532996; x=1752137796; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=aKRfOMZpAFbQW59XcJc9qTc3jh/YMdne3jcVAlhxqzs=; b=ZCeZ4p0mb6561MPesacKUk8a9EtAtXWcaNx5iEn6SLblm4+JNWlWBMgAhP40TkiMs4 AxuZf2KRLFIqiaRHxJebCwJIy0gmV8ZPmzomMAkOinG1Sl4X2UhzETxwD54a4QfUjpYD JN/QG++XduhOz0DDJnCQiGcAbg/o97/hPql2rTgbYYU04Qy4TSrr/bnJD6YBMPvfRTRN LSmrQLVP3b/mmzX+04T2KXr4ER8UxST5ZRXCu+Mt9UID1z0QCI/HLcjiMZOqNcIzTZBw FuZxOp+n0NAXDj315jnmJmUZ/DCoG2baRFl8YHN2Wvkm/3RAJJ0gEg3m1TMdxYqjDvGA LaGw== X-Forwarded-Encrypted: i=1; AJvYcCWlpkji5OB2OojtxjOjHrRrlwVe2yMY+qpKOj9AmyFe5r7ubM05ivf4Spp0GjOFoaizqaGITUDTqA==@nongnu.org X-Gm-Message-State: AOJu0YxSwTDu73uhQhiW3R9TPrgHblYuJgpRXSkQ3dF84C7EFHjYsqNz crxO0CZAJAQj2fSrK7OMSozHXi9xEu5VNaGslMICDXTABhv9n3tTW/obHUTaBEWMWvU= X-Gm-Gg: ASbGncuZTfJeZbp7WSiH3tnI8THFmFCgPeahK/AMA7lS6T9apYmj4XMq/yI+loAXepJ TyFIYXtMpSDfGWs8wLKJdpGQXYE2QLLA97d1foxUkJr2EH3H4ENfSQZOoDpiQEi4M7h8cpoNnCa 0tYBxrppH9e/1S6OmfMcj/QZ1LkCxj14Ku6lLuU0UU3TIRXi6qQuxStTDMGeSNC+InAJsN5lT8A u7mwMnNuP0h0L1H/dDxK81vuR6BOuPyfF05/Hw1gz1uV2HHWUYCZOfjr9yZaX7iJC9fccxaBgPh JE3beCIABXsL24uKQ6InBAIefmHtWI20PuUvI+YV0Fp+cgh7I4aEoTrL8AjxtAnBqHkdVF9kyBk LvBGw6b2zr4JiBBodaV0yCl5Xt/uzBsYmtnzwW3QFrWI= X-Google-Smtp-Source: AGHT+IGzwAlqDoi6kEjLNV9yt8UNZjj86pVaRPcoqGg/HZwvAIlKSmyjfylRqhK9d0Dzq8ITLBwF/A== X-Received: by 2002:a05:6a21:6da0:b0:220:99ba:6b5d with SMTP id adf61e73a8af0-222d7f33162mr9017321637.39.1751532996074; Thu, 03 Jul 2025 01:56:36 -0700 (PDT) From: William Kosasih To: qemu-devel@nongnu.org Cc: Peter Maydell , qemu-arm@nongnu.org, Richard Henderson , William Kosasih Subject: [PATCH v4 05/11] target/arm: Fix VSTR helper store alignment checks Date: Thu, 3 Jul 2025 18:25:58 +0930 Message-ID: <20250703085604.154449-6-kosasihwilliam4@gmail.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250703085604.154449-1-kosasihwilliam4@gmail.com> References: <20250703085604.154449-1-kosasihwilliam4@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::429; envelope-from=kosasihwilliam4@gmail.com; helo=mail-pf1-x429.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1751533058265116600 Content-Type: text/plain; charset="utf-8" This patch adds alignment checks in the store operations in the VSTR instruction. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1154 Signed-off-by: William Kosasih Reviewed-by: Richard Henderson --- target/arm/tcg/mve_helper.c | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/target/arm/tcg/mve_helper.c b/target/arm/tcg/mve_helper.c index 8834523c23..9587f2da7d 100644 --- a/target/arm/tcg/mve_helper.c +++ b/target/arm/tcg/mve_helper.c @@ -172,15 +172,17 @@ static void mve_advance_vpt(CPUARMState *env) mve_advance_vpt(env); \ } =20 -#define DO_VSTR(OP, MSIZE, STTYPE, ESIZE, TYPE) \ +#define DO_VSTR(OP, MFLAG, MSIZE, STTYPE, ESIZE, TYPE) \ void HELPER(mve_##OP)(CPUARMState *env, void *vd, uint32_t addr) \ { \ TYPE *d =3D vd; \ uint16_t mask =3D mve_element_mask(env); \ unsigned b, e; \ + int mmu_idx =3D arm_to_core_mmu_idx(arm_mmu_idx(env)); \ + MemOpIdx oi =3D make_memop_idx(MFLAG | MO_ALIGN, mmu_idx); \ for (b =3D 0, e =3D 0; b < 16; b +=3D ESIZE, e++) { = \ if (mask & (1 << b)) { \ - cpu_##STTYPE##_data_ra(env, addr, d[H##ESIZE(e)], GETPC())= ; \ + cpu_##STTYPE##_mmu(env, addr, d[H##ESIZE(e)], oi, GETPC())= ; \ } \ addr +=3D MSIZE; \ } \ @@ -191,9 +193,9 @@ DO_VLDR(vldrb, MO_UB, 1, uint8_t, ldb, 1, uint8_t) DO_VLDR(vldrh, MO_TEUW, 2, uint16_t, ldw, 2, uint16_t) DO_VLDR(vldrw, MO_TEUL, 4, uint32_t, ldl, 4, uint32_t) =20 -DO_VSTR(vstrb, 1, stb, 1, uint8_t) -DO_VSTR(vstrh, 2, stw, 2, uint16_t) -DO_VSTR(vstrw, 4, stl, 4, uint32_t) +DO_VSTR(vstrb, MO_UB, 1, stb, 1, uint8_t) +DO_VSTR(vstrh, MO_TEUW, 2, stw, 2, uint16_t) +DO_VSTR(vstrw, MO_TEUL, 4, stl, 4, uint32_t) =20 DO_VLDR(vldrb_sh, MO_SB, 1, int8_t, ldb, 2, int16_t) DO_VLDR(vldrb_sw, MO_SB, 1, int8_t, ldb, 4, int32_t) @@ -202,9 +204,9 @@ DO_VLDR(vldrb_uw, MO_UB, 1, uint8_t, ldb, 4, uint32_t) DO_VLDR(vldrh_sw, MO_TESW, 2, int16_t, ldw, 4, int32_t) DO_VLDR(vldrh_uw, MO_TEUW, 2, uint16_t, ldw, 4, uint32_t) =20 -DO_VSTR(vstrb_h, 1, stb, 2, int16_t) -DO_VSTR(vstrb_w, 1, stb, 4, int32_t) -DO_VSTR(vstrh_w, 2, stw, 4, int32_t) +DO_VSTR(vstrb_h, MO_UB, 1, stb, 2, int16_t) +DO_VSTR(vstrb_w, MO_UB, 1, stb, 4, int32_t) +DO_VSTR(vstrh_w, MO_TEUW, 2, stw, 4, int32_t) =20 #undef DO_VLDR #undef DO_VSTR --=20 2.48.1