From nobody Sat Nov 15 14:26:51 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1751533032; cv=none; d=zohomail.com; s=zohoarc; b=XNWJ8o8QAZ1Vf/xvRyYC3EG7egiwCb84LTVdbBIzwcKU/jk8YHzALWwGSxAU4wd/HI7y8kOMuEFhhHWyrYbf5FCRBanZ5rgU7TwV1gIv5DlddkSglee7CcnC49DfIATlmWIcwGy2ZYLmaOm0Cu8JjTHid5e7fLYHsOuxsVy43UM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1751533032; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=Dsn0anIP4CK0jEvYeRaGC/cLz2Rpi7NuxiCgDFOKI2w=; b=GvopYeoCrtmFpFeVHHMrMoeYrmnY+ctriAqtZ0EOZLbFC20Ak9iu4PrynOPb0+V2HC9xY4JMwuTgSDXGo2c5ySfXP8thgHNbd8OpDa6jv6vL5239h4+YjqI/t+w3TTHAhHd7dObsvRFM04kvZ/rzddqAMB8kXPNaGZZg5KH9wV0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1751533032629769.5960794995136; Thu, 3 Jul 2025 01:57:12 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uXFk9-0002T7-8u; Thu, 03 Jul 2025 04:56:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uXFk7-0002Sc-Nl; Thu, 03 Jul 2025 04:56:31 -0400 Received: from mail-pl1-x632.google.com ([2607:f8b0:4864:20::632]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uXFk2-0007xP-Vc; Thu, 03 Jul 2025 04:56:31 -0400 Received: by mail-pl1-x632.google.com with SMTP id d9443c01a7336-23633a6ac50so97744395ad.2; Thu, 03 Jul 2025 01:56:26 -0700 (PDT) Received: from localhost (pa49-178-74-199.pa.nsw.optusnet.com.au. [49.178.74.199]) by smtp.gmail.com with UTF8SMTPSA id d9443c01a7336-23acb2e32d3sm144358075ad.8.2025.07.03.01.56.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Jul 2025 01:56:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1751532982; x=1752137782; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Dsn0anIP4CK0jEvYeRaGC/cLz2Rpi7NuxiCgDFOKI2w=; b=JOpPt0v9phndBGr6AFabHDcZ3qXPhL7OuoK+wTRIxnxCn2+Acyk3kjfFM0S5jUwOgx 9Wftg+dFH7kGQ7sgIabpYCNetYRHLtkqI3Yi+s+azb2KNcv8Dl0RFlKxL0UGtZm4Ae+l LmxVpCXzun32wchgcLQRZFyYHmIRcyNX7RYIZISwq1Q2xo49iwCJHSBLZKTJJ74AO9EZ 4peBJIaDmhcr2nymomaFQqlCggLFAUbXcSeHbzpUUB6h0SUor3cBsHX974fpABinHVT1 0z2oSIo2ZB6oMP126THYFuOJDRlRDuKU2Cj5v3OmTSl/6+XDd+5Rrfiuy7oTXhX+BlA1 6jug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751532982; x=1752137782; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Dsn0anIP4CK0jEvYeRaGC/cLz2Rpi7NuxiCgDFOKI2w=; b=lsQ1jNV22S1tl9BngzSbulKu19TqZIk8bb0iuQSwggpvoIZJWOBSDDD+qzX0uK7S76 yTn3gvJ1sgFX8mvBYlYwok7V4QFl9oiGVxaXiUDUlVmIzvjt7wADOugN+f8V1vjP1F4k oTSx2bL7AEbrUFtWHkHgTw9qGGF6kLruI3PqKuv4yALexZiZC+Yf07I7JNaHzJaorZjl c4O0IkUvmZL9gz6WBcG1x+VE6sBnsnVJ3iBG2GdlmgIo5RadD+QEletkrdh561toStc2 m7Sbjtzs5QrUiNUD4CTlNrUNNW95bi8jyUORSllxGAduyMt/LTVGTmow7FDZPyySBcWK /erA== X-Forwarded-Encrypted: i=1; AJvYcCWAfodxCQjBj1NKU9Q3zDcCCg8QFUDgLl5BMy2vjPEZDl9Fd4fJCFjA2icgebedZiwGW8dUG8E+zw==@nongnu.org X-Gm-Message-State: AOJu0YwVm1DcSXEs/squVfMeB+T10Qo+NaVWL2TB/Il3k3RrFFuirJn7 1TFasJGeYXrOu4ssrGV7IaWUW61zAZlIklEdqrBOZFPFnjECk4p6lAUNTJ/5NaRKttY= X-Gm-Gg: ASbGncuNO3OAzRi23fBr5BISVuSyBCoybk2ZkFL22Pepe6GZw3dGLceaFMDN+Y6EmEK oVQkq+sJVrOzP8QFOpCazx1xMrk0zG/Pm5d3eyWizQcuONDxc4KcLiVnLi89fnOdLXtdkzWUsq5 aZAujCHFD1AxiD0kbHZCZ6yQDz7S/lKAObsP2Br9Y5KqRX5Gbl5VLlVYzDApjKevE39S5dyKG3k IAxmr4i1Q9bNX8wNNU2+Jjgegl1n+g9U7iOWNVMqG9baYxpgqo1oZUb2trM00FV+HrdRDzbW4mn 2A6hM0vE277CVthZikPJGr/Jb+iL0jmuePsesg8sJlo/ONboOvW1KZRdK4j1hB4DA6fZi/MC4kD e3mJQ9MxjuzD4RfwWhvMzLrYH6nuS5pZcsjlWjrTVfgzRBhl8Zz8WYA== X-Google-Smtp-Source: AGHT+IH0ocaFDjD2VJqtx9WFYDIgFO7SLthBpBcrT2wiaoVpzVnodklXlVNJV+7sKOXP/B5tXan4oQ== X-Received: by 2002:a17:903:11c4:b0:234:c5c1:9b84 with SMTP id d9443c01a7336-23c6e5b73ffmr82226135ad.37.1751532982011; Thu, 03 Jul 2025 01:56:22 -0700 (PDT) From: William Kosasih To: qemu-devel@nongnu.org Cc: Peter Maydell , qemu-arm@nongnu.org, Richard Henderson , William Kosasih Subject: [PATCH v4 02/11] target/arm: Fix BLXNS helper store alignment checks Date: Thu, 3 Jul 2025 18:25:55 +0930 Message-ID: <20250703085604.154449-3-kosasihwilliam4@gmail.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250703085604.154449-1-kosasihwilliam4@gmail.com> References: <20250703085604.154449-1-kosasihwilliam4@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::632; envelope-from=kosasihwilliam4@gmail.com; helo=mail-pl1-x632.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, T_SPF_HELO_TEMPERROR=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1751533034016116600 Content-Type: text/plain; charset="utf-8" This patch adds alignment checks in the store operations (when stacking the return pc and psr) in the BLXNS instruction. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1154 Signed-off-by: William Kosasih Reviewed-by: Richard Henderson --- target/arm/tcg/m_helper.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/target/arm/tcg/m_helper.c b/target/arm/tcg/m_helper.c index 251e12edf9..f342d93489 100644 --- a/target/arm/tcg/m_helper.c +++ b/target/arm/tcg/m_helper.c @@ -632,8 +632,11 @@ void HELPER(v7m_blxns)(CPUARMState *env, uint32_t dest) } =20 /* Note that these stores can throw exceptions on MPU faults */ - cpu_stl_data_ra(env, sp, nextinst, GETPC()); - cpu_stl_data_ra(env, sp + 4, saved_psr, GETPC()); + ARMMMUIdx mmu_idx =3D arm_mmu_idx(env); + MemOpIdx oi =3D make_memop_idx(MO_TEUL | MO_ALIGN, + arm_to_core_mmu_idx(mmu_idx)); + cpu_stl_mmu(env, sp, nextinst, oi, GETPC()); + cpu_stl_mmu(env, sp + 4, saved_psr, oi, GETPC()); =20 env->regs[13] =3D sp; env->regs[14] =3D 0xfeffffff; --=20 2.48.1