From nobody Sat Nov 15 12:39:23 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1751533097; cv=none; d=zohomail.com; s=zohoarc; b=F7cFsqLPSqys14B/L4zIZHnG3FNz7ZKZFhFkhlROVBMXf+IjzKZFBEC7v7OlDuIIXEf/1yRbAM4I74WJe6Lnsd9EwORVe+7VmhDi+vl90vS/QNiYFgGbTa5TOSVcOwq+mRVzw1hPiEn5pb3tRJAIbfgnDm9lwPTh31uzadIdU0s= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1751533097; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=ue+TRUQ4zOoNWn0fMMKkbL+MC+6NF+Rulh2d0yliDEM=; b=UYGgEJxxVD9xkNPwam/8VhC01UQ8lKa0107N8Nriz7gsEnwsWtEiSLqLh21/2K0oEXJnrUGeAmxKks/H2dZPIsWYyZRuBfWMZxw14ZOJd6fG6d4dFf5smmP9ZsYvrvQe1hyH28Pl00xwOSUkWjtyQNAdlkFhR/JMmzFkEtrJCJU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1751533097858982.8736117653748; Thu, 3 Jul 2025 01:58:17 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uXFk4-0002Qg-1p; Thu, 03 Jul 2025 04:56:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uXFk2-0002Pr-OE; Thu, 03 Jul 2025 04:56:26 -0400 Received: from mail-pf1-x436.google.com ([2607:f8b0:4864:20::436]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uXFjz-0007vZ-MM; Thu, 03 Jul 2025 04:56:25 -0400 Received: by mail-pf1-x436.google.com with SMTP id d2e1a72fcca58-739b3fe7ce8so8294382b3a.0; Thu, 03 Jul 2025 01:56:21 -0700 (PDT) Received: from localhost (pa49-178-74-199.pa.nsw.optusnet.com.au. [49.178.74.199]) by smtp.gmail.com with UTF8SMTPSA id d2e1a72fcca58-74af557b3bcsm16409931b3a.101.2025.07.03.01.56.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Jul 2025 01:56:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1751532977; x=1752137777; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ue+TRUQ4zOoNWn0fMMKkbL+MC+6NF+Rulh2d0yliDEM=; b=jpMp1D/Wig4EyvWL6yRCrUJtN3wlInjAEHR8LlR04TV835qDlKFtA+0xiFhFZBvjjl WIstFs+KjpGlE3Ri8CkZ46towjw3ZTKp+B9AfHTlVr1P9jFQOfKBMwADHCtJmhsGKUL6 T5RpSlte5SKwWgkfFnQRpS5Nlq0i1SUCHnwrVuGr6/nVg9EEvPpP4zllCSeISKWOvqz/ jHLyeqvqAQ3DSzCvO92A4OcD2dCaVpzhd7KBleZiY17hnxBJIdv/g+noxeSibsffYg7/ gi5WRH9e0evnyYoBY2KIK1X43C1GbZSY4SkN+v2IsmFAvNb3kpblUXAedhE8qEIFWx5c zX/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751532977; x=1752137777; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ue+TRUQ4zOoNWn0fMMKkbL+MC+6NF+Rulh2d0yliDEM=; b=NrxlHOmnO+RViRlr69lG3hhNduO/q4/8bayhefQL8eVLpBAESoL8WMrOgl3ezFyj0Y T7Zqfbx6ECz82Wwrjw4FErrHqvZJFUcuC5Vgvs9/AFm7Bl9yn5HbbhFtw8fzj3pOqow8 OPo8aoBJTODKcrgD5/sSBda38rcUgE+pY4SFMsGg6cpCl48SYsg/UiX4VxgLLqTjnYZ1 vZrGdCp7T9GOdgXRHRqcLOztfsF+986T4cyNN2pHeFcl92ya7mVkbT/fR2QfxUgLEJRk rjx10nOEEDi15Wb+d8rta34BYQbGoEz6KPWED68GxSdSYZcPg7SsOB+lCPh818YOvXb9 WFXg== X-Forwarded-Encrypted: i=1; AJvYcCXqjMquyVXm+sSVKxht5vw3AOaVyf4AFhH1/oXBF7MJEu4EuGIc905RkL11uggPlMKqBzbfugVZsA==@nongnu.org X-Gm-Message-State: AOJu0YwRQuZm/F2OhvzZKa26T1U/NokKn3LK0HGnZRlE+HtWWDv+KaXA csu487kbVMW43meENrfyTqHhCrZFKrS360RCc+Uw7dckSVxK6fJ8jNCnhdeTOPh0E7I= X-Gm-Gg: ASbGncvW1YyRWGEfy5dxmptUaWuaNcCcFpB4n/b40pdJFp8rK7rW7TcNBih8ChleRx9 nYW70AccRojawAoAJm2Oio2MuesN8kmd0+W6aupOAaUT//J8/cKUMgqBU02U2ZWHGD9BV43A3P/ Kl33UXlPYRI6ueeL5JF5OJGL0tKWnZg8CiLonuePt368RTNwglH2QeIxMLSTRoQ7O1XzfqS+egC j+nDpMGcvVdLFrZ4kMtlLzTzpX0z4bEigkfmMCVDUVFIB7lS/xzHuMGWsCh5H/lGuIntswEiMzM v60ApLrsuCZe+jVdzkJVrzBjOb2wlCtL5z1taTTD5K2r3UuLrJxCaRhjBK7XweoKcGvaF4f/A9y SSYmPioBWqFwdjtgINcEw4Mv/7byrCCcPAzLW0AuM5OI= X-Google-Smtp-Source: AGHT+IGxmGehSByD6+KCQPrmX1GUgbnZQPJXWMID+loawjcZBI7PJhntn5KOq7bdgxnNXIEDfE6/IA== X-Received: by 2002:aa7:8881:0:b0:748:2fa4:14c0 with SMTP id d2e1a72fcca58-74b50c84cb2mr8726323b3a.0.1751532977206; Thu, 03 Jul 2025 01:56:17 -0700 (PDT) From: William Kosasih To: qemu-devel@nongnu.org Cc: Peter Maydell , qemu-arm@nongnu.org, Richard Henderson , William Kosasih Subject: [PATCH v4 01/11] target/arm: Bring VLSTM/VLLDM helper store/load closer to the ARM pseudocode Date: Thu, 3 Jul 2025 18:25:54 +0930 Message-ID: <20250703085604.154449-2-kosasihwilliam4@gmail.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250703085604.154449-1-kosasihwilliam4@gmail.com> References: <20250703085604.154449-1-kosasihwilliam4@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::436; envelope-from=kosasihwilliam4@gmail.com; helo=mail-pf1-x436.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1751533098855116600 Content-Type: text/plain; charset="utf-8" This patch brings the VLSTM and VLLDM helper functions closer to the ARM pseudocode by adding MO_ALIGN to the MemOpIdx of the associated store (`cpu_stl_mmu`) operations and load (`cpu_ldl_mmu`) operations. Note that this is not a bug fix: an 8-byte alignment check already exists and remains in place, enforcing stricter alignment than the 4 bytes requirement in the individual loads and stores. This change merely makes the helper implementations closer to the ARM pseudocode. That said, as a side effect, the MMU index is now resolved once instead of on every `cpu_*_data_ra` call, reducing redundant lookups Signed-off-by: William Kosasih Reviewed-by: Richard Henderson --- target/arm/tcg/m_helper.c | 24 +++++++++++++++--------- 1 file changed, 15 insertions(+), 9 deletions(-) diff --git a/target/arm/tcg/m_helper.c b/target/arm/tcg/m_helper.c index 6614719832..251e12edf9 100644 --- a/target/arm/tcg/m_helper.c +++ b/target/arm/tcg/m_helper.c @@ -1048,6 +1048,9 @@ void HELPER(v7m_vlstm)(CPUARMState *env, uint32_t fpt= r) bool s =3D env->v7m.fpccr[M_REG_S] & R_V7M_FPCCR_S_MASK; bool lspact =3D env->v7m.fpccr[s] & R_V7M_FPCCR_LSPACT_MASK; uintptr_t ra =3D GETPC(); + ARMMMUIdx mmu_idx =3D arm_mmu_idx(env); + MemOpIdx oi =3D make_memop_idx(MO_TEUL | MO_ALIGN, + arm_to_core_mmu_idx(mmu_idx)); =20 assert(env->v7m.secure); =20 @@ -1073,7 +1076,7 @@ void HELPER(v7m_vlstm)(CPUARMState *env, uint32_t fpt= r) * Note that we do not use v7m_stack_write() here, because the * accesses should not set the FSR bits for stacking errors if they * fail. (In pseudocode terms, they are AccType_NORMAL, not AccType_ST= ACK - * or AccType_LAZYFP). Faults in cpu_stl_data_ra() will throw exceptio= ns + * or AccType_LAZYFP). Faults in cpu_stl_mmu() will throw exceptions * and longjmp out. */ if (!(env->v7m.fpccr[M_REG_S] & R_V7M_FPCCR_LSPEN_MASK)) { @@ -1089,12 +1092,12 @@ void HELPER(v7m_vlstm)(CPUARMState *env, uint32_t f= ptr) if (i >=3D 16) { faddr +=3D 8; /* skip the slot for the FPSCR */ } - cpu_stl_data_ra(env, faddr, slo, ra); - cpu_stl_data_ra(env, faddr + 4, shi, ra); + cpu_stl_mmu(env, faddr, slo, oi, ra); + cpu_stl_mmu(env, faddr + 4, shi, oi, ra); } - cpu_stl_data_ra(env, fptr + 0x40, vfp_get_fpscr(env), ra); + cpu_stl_mmu(env, fptr + 0x40, vfp_get_fpscr(env), oi, ra); if (cpu_isar_feature(aa32_mve, cpu)) { - cpu_stl_data_ra(env, fptr + 0x44, env->v7m.vpr, ra); + cpu_stl_mmu(env, fptr + 0x44, env->v7m.vpr, oi, ra); } =20 /* @@ -1121,6 +1124,9 @@ void HELPER(v7m_vlldm)(CPUARMState *env, uint32_t fpt= r) { ARMCPU *cpu =3D env_archcpu(env); uintptr_t ra =3D GETPC(); + ARMMMUIdx mmu_idx =3D arm_mmu_idx(env); + MemOpIdx oi =3D make_memop_idx(MO_TEUL | MO_ALIGN, + arm_to_core_mmu_idx(mmu_idx)); =20 /* fptr is the value of Rn, the frame pointer we load the FP regs from= */ assert(env->v7m.secure); @@ -1155,16 +1161,16 @@ void HELPER(v7m_vlldm)(CPUARMState *env, uint32_t f= ptr) faddr +=3D 8; /* skip the slot for the FPSCR and VPR */ } =20 - slo =3D cpu_ldl_data_ra(env, faddr, ra); - shi =3D cpu_ldl_data_ra(env, faddr + 4, ra); + slo =3D cpu_ldl_mmu(env, faddr, oi, ra); + shi =3D cpu_ldl_mmu(env, faddr + 4, oi, ra); =20 dn =3D (uint64_t) shi << 32 | slo; *aa32_vfp_dreg(env, i / 2) =3D dn; } - fpscr =3D cpu_ldl_data_ra(env, fptr + 0x40, ra); + fpscr =3D cpu_ldl_mmu(env, fptr + 0x40, oi, ra); vfp_set_fpscr(env, fpscr); if (cpu_isar_feature(aa32_mve, cpu)) { - env->v7m.vpr =3D cpu_ldl_data_ra(env, fptr + 0x44, ra); + env->v7m.vpr =3D cpu_ldl_mmu(env, fptr + 0x44, oi, ra); } } =20 --=20 2.48.1 From nobody Sat Nov 15 12:39:23 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1751533032; cv=none; d=zohomail.com; s=zohoarc; b=XNWJ8o8QAZ1Vf/xvRyYC3EG7egiwCb84LTVdbBIzwcKU/jk8YHzALWwGSxAU4wd/HI7y8kOMuEFhhHWyrYbf5FCRBanZ5rgU7TwV1gIv5DlddkSglee7CcnC49DfIATlmWIcwGy2ZYLmaOm0Cu8JjTHid5e7fLYHsOuxsVy43UM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1751533032; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=Dsn0anIP4CK0jEvYeRaGC/cLz2Rpi7NuxiCgDFOKI2w=; b=GvopYeoCrtmFpFeVHHMrMoeYrmnY+ctriAqtZ0EOZLbFC20Ak9iu4PrynOPb0+V2HC9xY4JMwuTgSDXGo2c5ySfXP8thgHNbd8OpDa6jv6vL5239h4+YjqI/t+w3TTHAhHd7dObsvRFM04kvZ/rzddqAMB8kXPNaGZZg5KH9wV0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1751533032629769.5960794995136; Thu, 3 Jul 2025 01:57:12 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uXFk9-0002T7-8u; Thu, 03 Jul 2025 04:56:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uXFk7-0002Sc-Nl; Thu, 03 Jul 2025 04:56:31 -0400 Received: from mail-pl1-x632.google.com ([2607:f8b0:4864:20::632]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uXFk2-0007xP-Vc; Thu, 03 Jul 2025 04:56:31 -0400 Received: by mail-pl1-x632.google.com with SMTP id d9443c01a7336-23633a6ac50so97744395ad.2; Thu, 03 Jul 2025 01:56:26 -0700 (PDT) Received: from localhost (pa49-178-74-199.pa.nsw.optusnet.com.au. [49.178.74.199]) by smtp.gmail.com with UTF8SMTPSA id d9443c01a7336-23acb2e32d3sm144358075ad.8.2025.07.03.01.56.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Jul 2025 01:56:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1751532982; x=1752137782; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Dsn0anIP4CK0jEvYeRaGC/cLz2Rpi7NuxiCgDFOKI2w=; b=JOpPt0v9phndBGr6AFabHDcZ3qXPhL7OuoK+wTRIxnxCn2+Acyk3kjfFM0S5jUwOgx 9Wftg+dFH7kGQ7sgIabpYCNetYRHLtkqI3Yi+s+azb2KNcv8Dl0RFlKxL0UGtZm4Ae+l LmxVpCXzun32wchgcLQRZFyYHmIRcyNX7RYIZISwq1Q2xo49iwCJHSBLZKTJJ74AO9EZ 4peBJIaDmhcr2nymomaFQqlCggLFAUbXcSeHbzpUUB6h0SUor3cBsHX974fpABinHVT1 0z2oSIo2ZB6oMP126THYFuOJDRlRDuKU2Cj5v3OmTSl/6+XDd+5Rrfiuy7oTXhX+BlA1 6jug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751532982; x=1752137782; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Dsn0anIP4CK0jEvYeRaGC/cLz2Rpi7NuxiCgDFOKI2w=; b=lsQ1jNV22S1tl9BngzSbulKu19TqZIk8bb0iuQSwggpvoIZJWOBSDDD+qzX0uK7S76 yTn3gvJ1sgFX8mvBYlYwok7V4QFl9oiGVxaXiUDUlVmIzvjt7wADOugN+f8V1vjP1F4k oTSx2bL7AEbrUFtWHkHgTw9qGGF6kLruI3PqKuv4yALexZiZC+Yf07I7JNaHzJaorZjl c4O0IkUvmZL9gz6WBcG1x+VE6sBnsnVJ3iBG2GdlmgIo5RadD+QEletkrdh561toStc2 m7Sbjtzs5QrUiNUD4CTlNrUNNW95bi8jyUORSllxGAduyMt/LTVGTmow7FDZPyySBcWK /erA== X-Forwarded-Encrypted: i=1; AJvYcCWAfodxCQjBj1NKU9Q3zDcCCg8QFUDgLl5BMy2vjPEZDl9Fd4fJCFjA2icgebedZiwGW8dUG8E+zw==@nongnu.org X-Gm-Message-State: AOJu0YwVm1DcSXEs/squVfMeB+T10Qo+NaVWL2TB/Il3k3RrFFuirJn7 1TFasJGeYXrOu4ssrGV7IaWUW61zAZlIklEdqrBOZFPFnjECk4p6lAUNTJ/5NaRKttY= X-Gm-Gg: ASbGncuNO3OAzRi23fBr5BISVuSyBCoybk2ZkFL22Pepe6GZw3dGLceaFMDN+Y6EmEK oVQkq+sJVrOzP8QFOpCazx1xMrk0zG/Pm5d3eyWizQcuONDxc4KcLiVnLi89fnOdLXtdkzWUsq5 aZAujCHFD1AxiD0kbHZCZ6yQDz7S/lKAObsP2Br9Y5KqRX5Gbl5VLlVYzDApjKevE39S5dyKG3k IAxmr4i1Q9bNX8wNNU2+Jjgegl1n+g9U7iOWNVMqG9baYxpgqo1oZUb2trM00FV+HrdRDzbW4mn 2A6hM0vE277CVthZikPJGr/Jb+iL0jmuePsesg8sJlo/ONboOvW1KZRdK4j1hB4DA6fZi/MC4kD e3mJQ9MxjuzD4RfwWhvMzLrYH6nuS5pZcsjlWjrTVfgzRBhl8Zz8WYA== X-Google-Smtp-Source: AGHT+IH0ocaFDjD2VJqtx9WFYDIgFO7SLthBpBcrT2wiaoVpzVnodklXlVNJV+7sKOXP/B5tXan4oQ== X-Received: by 2002:a17:903:11c4:b0:234:c5c1:9b84 with SMTP id d9443c01a7336-23c6e5b73ffmr82226135ad.37.1751532982011; Thu, 03 Jul 2025 01:56:22 -0700 (PDT) From: William Kosasih To: qemu-devel@nongnu.org Cc: Peter Maydell , qemu-arm@nongnu.org, Richard Henderson , William Kosasih Subject: [PATCH v4 02/11] target/arm: Fix BLXNS helper store alignment checks Date: Thu, 3 Jul 2025 18:25:55 +0930 Message-ID: <20250703085604.154449-3-kosasihwilliam4@gmail.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250703085604.154449-1-kosasihwilliam4@gmail.com> References: <20250703085604.154449-1-kosasihwilliam4@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::632; envelope-from=kosasihwilliam4@gmail.com; helo=mail-pl1-x632.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_PASS=-0.001, T_SPF_HELO_TEMPERROR=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1751533034016116600 Content-Type: text/plain; charset="utf-8" This patch adds alignment checks in the store operations (when stacking the return pc and psr) in the BLXNS instruction. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1154 Signed-off-by: William Kosasih Reviewed-by: Richard Henderson --- target/arm/tcg/m_helper.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/target/arm/tcg/m_helper.c b/target/arm/tcg/m_helper.c index 251e12edf9..f342d93489 100644 --- a/target/arm/tcg/m_helper.c +++ b/target/arm/tcg/m_helper.c @@ -632,8 +632,11 @@ void HELPER(v7m_blxns)(CPUARMState *env, uint32_t dest) } =20 /* Note that these stores can throw exceptions on MPU faults */ - cpu_stl_data_ra(env, sp, nextinst, GETPC()); - cpu_stl_data_ra(env, sp + 4, saved_psr, GETPC()); + ARMMMUIdx mmu_idx =3D arm_mmu_idx(env); + MemOpIdx oi =3D make_memop_idx(MO_TEUL | MO_ALIGN, + arm_to_core_mmu_idx(mmu_idx)); + cpu_stl_mmu(env, sp, nextinst, oi, GETPC()); + cpu_stl_mmu(env, sp + 4, saved_psr, oi, GETPC()); =20 env->regs[13] =3D sp; env->regs[14] =3D 0xfeffffff; --=20 2.48.1 From nobody Sat Nov 15 12:39:23 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1751533033; cv=none; d=zohomail.com; s=zohoarc; b=L7oJ5ZF/fobRPa0mDnjLCvQyMlzclHn4lft0N6hy5nxFUV5FML8fimzfz0/36QR+6RIsy1iY2B4KB3hAKdvRZuZpBl74AubNE2pibimSe2kXFBgxP/3R4GTgZSl9U+w+xghslSP7IWf118mege80Fx7W0zCZ1N7mqP1J2fTJ/1s= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1751533033; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=kDVYKioaP//F/+wWF23qKuUDqxQg0Bmhy05BTrTCAN4=; b=N6UXOX+mTT5+6w+S9mX40xXY5uP6jJ7rIsp+PHrLE+7I+q5Edh64oAesRyTtw6Tgift0AxQpKnxcqhg26B5EzJZmShrvnIBL7Jpa5F1nz6dsbwd7GTxbFCiQim4egLyPFeChjdUrLDohsS2QHJLJCKEcjHfWCysUDhtz8S0mV0k= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 17515330332860.8434270770383137; Thu, 3 Jul 2025 01:57:13 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uXFk9-0002TZ-Uc; Thu, 03 Jul 2025 04:56:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uXFk7-0002Sg-Re; Thu, 03 Jul 2025 04:56:31 -0400 Received: from mail-pf1-x42b.google.com ([2607:f8b0:4864:20::42b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uXFk5-0007z0-5N; Thu, 03 Jul 2025 04:56:31 -0400 Received: by mail-pf1-x42b.google.com with SMTP id d2e1a72fcca58-748e378ba4fso10191797b3a.1; Thu, 03 Jul 2025 01:56:28 -0700 (PDT) Received: from localhost (pa49-178-74-199.pa.nsw.optusnet.com.au. [49.178.74.199]) by smtp.gmail.com with UTF8SMTPSA id d2e1a72fcca58-74af56d0cb1sm15870233b3a.134.2025.07.03.01.56.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Jul 2025 01:56:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1751532987; x=1752137787; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=kDVYKioaP//F/+wWF23qKuUDqxQg0Bmhy05BTrTCAN4=; b=ZO3MerR0UPcfV87CBDTDsAa50lCGF9Gvqo9soqO2JPQR0OBFGbvgvdcidPHchNYfdJ oosdR7iu2lIX2D3RuHl7CxpHN4KkxjQzxUhYtWo0lqnuZUawoMiT1W92jgmAHTqD7fh8 L3Sxxsex7LqbVZ/CrVLRCj3dXY9GLNTXnTQuXeRJrk21DNU2F5j0ilOsMHTPJEBFaNGr ZecowvI98jm5uuqN7OK/7uLovviVGYO5eFRVzVNBlGd9ABRcH2Pt09EKbDDETmI6qAdV JgMan14zn7C0wB+MBgjBatFigvX5XhHFKk1b0J2FHvp9nmQCCx5A/gfnJfpl58a4uA+C RVtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751532987; x=1752137787; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kDVYKioaP//F/+wWF23qKuUDqxQg0Bmhy05BTrTCAN4=; b=wKRBQUS+JM5+4wb7rz4yWol+o9ZiyOuRYh94ZVB1cHb72iNVWj0NCGPoNc2xmRC1Hl 1TATZ3g95u7+nYO/OvGnFC9alE4xsiwYJwOh+yd0f7J7y6OZxBDpDsqCSSuXQLg1IZM6 cM3JJETZfBHEnRjFuJy1egzV8qtaJgLcy5u13KtLGTgX+D3d7TZ+dTEcj4tIDku6fqak QY3jynppez+N8faJ4weNPkfvr+tAb9UiiHFO3HGGRmgKIxirG50as1/zUq4R+l9oiDt3 QgP++gQQ7hCllYPIZMy1fm/aZhpMCy890iFeKiGGsRCzeeF+0WQdRSz752QPlAHiYolz yMjw== X-Forwarded-Encrypted: i=1; AJvYcCWIMMVbrWmSg+mUQYf8hhP0NDWyszICF/Rdn3HYFkDA82bNK5MnnlC9xQlRp23F41z/bzhOdnvugg==@nongnu.org X-Gm-Message-State: AOJu0YzeY4GXuN/1VZcVuk2q/U4JY5baM3FmVD5/yQyBoC8+eNuoBd5C xejsx2rW9yPLafvL4qFVZIk4SqVJwCZvWVi1mfaHNAfrCqCKmY2/F3TDbY0iKLNkka4= X-Gm-Gg: ASbGncugSyqxzOV4PnAEW2ylbqBaF6scY7XPffRiAYNHFNlUuJYjyLG7TlkHc53JgK2 i9TBU6lJ9y1Y+vd1Q5ADKZtG/8woDI+iQS3R4KJDlFbsbNhWczYy8Ysfi/Zt50a7bx49S++CAxn 8wMT0zY99bsAQ0ezpA0bvPYesf0EOXBD5GQY/381n/eDcypXvePEm1cbf5Kupi3hGkkEg6CzzrP +BQJ73gEFcvT6vzyNIFgFqk3fdHrkK71Ja3rD2w2BKNxYAmNWkW8ssE/jpS4UFZiJ6MWfYDL1p0 +56I//L7c4ry4Pxz2hLPG+vOPbqgA9/Ytm5kvQQdm2aA9mhx3W+Rbu7s6Xgte2fVIIZhkk/a54G PKoFrEOt0xr5cam/b9tDfelPfgqeGI//BR6/+fMhgeQE= X-Google-Smtp-Source: AGHT+IFW5ANqC7dlMVkcOL1jv/LQfv1hy0MbG3/AhtzQ8LLvEAy/bmyqjfrWB9L6FS2Idl+yUBHD1g== X-Received: by 2002:a05:6a00:22cf:b0:748:e585:3c42 with SMTP id d2e1a72fcca58-74b5104c95emr6297478b3a.15.1751532986888; Thu, 03 Jul 2025 01:56:26 -0700 (PDT) From: William Kosasih To: qemu-devel@nongnu.org Cc: Peter Maydell , qemu-arm@nongnu.org, Richard Henderson , William Kosasih Subject: [PATCH v4 03/11] target/arm: Fix function_return helper load alignment checks Date: Thu, 3 Jul 2025 18:25:56 +0930 Message-ID: <20250703085604.154449-4-kosasihwilliam4@gmail.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250703085604.154449-1-kosasihwilliam4@gmail.com> References: <20250703085604.154449-1-kosasihwilliam4@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::42b; envelope-from=kosasihwilliam4@gmail.com; helo=mail-pf1-x42b.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1751533034004116600 Content-Type: text/plain; charset="utf-8" This patch adds alignment checks in the load operations (when unstacking the return pc and psr) in the FunctionReturn pseudocode. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1154 Signed-off-by: William Kosasih Reviewed-by: Richard Henderson --- target/arm/tcg/m_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/arm/tcg/m_helper.c b/target/arm/tcg/m_helper.c index f342d93489..28307b5615 100644 --- a/target/arm/tcg/m_helper.c +++ b/target/arm/tcg/m_helper.c @@ -1946,7 +1946,7 @@ static bool do_v7m_function_return(ARMCPU *cpu) * do them as secure, so work out what MMU index that is. */ mmu_idx =3D arm_v7m_mmu_idx_for_secstate(env, true); - oi =3D make_memop_idx(MO_LEUL, arm_to_core_mmu_idx(mmu_idx)); + oi =3D make_memop_idx(MO_LEUL | MO_ALIGN, arm_to_core_mmu_idx(mmu_= idx)); newpc =3D cpu_ldl_mmu(env, frameptr, oi, 0); newpsr =3D cpu_ldl_mmu(env, frameptr + 4, oi, 0); =20 --=20 2.48.1 From nobody Sat Nov 15 12:39:23 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1751533047; cv=none; d=zohomail.com; s=zohoarc; b=gu6YWHQIJCTEnjmlqsjPXASLZ8ZFL5DfRZ1SWy16x0M/4GyQhNxQMH1Yv7I3DlJLOAjYdR0JqkAFJwGqDBG8VdwGjEyTe3AaCSMbwCfWavPyvHlH7N0J81tAtJwCqYe63uHqXDEEwlcXB8fo/Zu2d7UEMqEiiW2mx3/ZAj6S6l4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1751533047; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=FEzEahgnaMEVhNEBoKt7NK9A09hysKMBO9xMURSLdOA=; b=BY2ZXZ5p0iY9mUhyzmemRssjjQlkOzq5N1yQLvM8KQRR2ldUxbpBIxWwaK/wEN6DNfWXOCoJ+zTRrQl4z47oG2z+9F6oILTWaCVp8WCwPy0yq0H3OHRZV3O1uiBtOEg7totywYwyCs1NSnufg4W2bw4KSvnfBG4twcVTo9VRZFQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1751533047754878.4295498583393; Thu, 3 Jul 2025 01:57:27 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uXFkF-0002Yf-SM; Thu, 03 Jul 2025 04:56:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uXFkC-0002WE-17; Thu, 03 Jul 2025 04:56:36 -0400 Received: from mail-pf1-x433.google.com ([2607:f8b0:4864:20::433]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uXFk9-00080b-Sq; Thu, 03 Jul 2025 04:56:35 -0400 Received: by mail-pf1-x433.google.com with SMTP id d2e1a72fcca58-739b3fe7ce8so8294540b3a.0; Thu, 03 Jul 2025 01:56:32 -0700 (PDT) Received: from localhost (pa49-178-74-199.pa.nsw.optusnet.com.au. [49.178.74.199]) by smtp.gmail.com with UTF8SMTPSA id 41be03b00d2f7-b34e302378bsm13967901a12.23.2025.07.03.01.56.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Jul 2025 01:56:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1751532991; x=1752137791; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=FEzEahgnaMEVhNEBoKt7NK9A09hysKMBO9xMURSLdOA=; b=Fg7p36NAGOU/j83HHZnrmoZo+nKFEZxN2HPv4QVMsYh0pF4OLisWd1CNEAp8KBU5As muyevLL5EbwXAdgWFT6Ws0ex9GPllTsfsEWJShVfINHR/TMBVcUJXMf6oq5/eUSF0+e8 Le/QHy8hVP700jQesJL/K6u1VbE1pbEvOxtZwxYYXdRF2PO4C9AIle7ILF/EkFYzysFP a3jczhRjc7xcX/WqjiFgTxuO6IPj0JEBraxdHDHk+8/G79x08rWMooIeyfQdtrTAL0Fd tb1r2xKuYYuomxtMdk4SpQqpGHacHgePoYxio1Qvotjoj/fM7W3cl2r3cvIlqwVD/Tbc VuLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751532991; x=1752137791; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FEzEahgnaMEVhNEBoKt7NK9A09hysKMBO9xMURSLdOA=; b=mF27SwEr+17MIh+Zjt82AT44XTZGA76wlKu1iJPmo8zG3yXUlvOj41y2xlhpW7pR3s RfKtZSiqNbN5laEcQyjmwHR1mOdiklZYLKRuhFA41csySUEcxF43UU8ofRsyFajB7L0z BvNF3rKEwyXjYhQ19c1gL4W/bGxNxacvC/g2QpA7pBazwrQ2sqEnm8thJyG78howXu6p 13rzNIpXvsbtvJUjHsGCNYXacAl45HCMX8MopXhJ1uqKA0WpKimOoT8/ZAe8yrAxkHd5 jd6RUwoZXV32Odm+Rc+tiGdwtsb4x7DCh00PZezfwXsxKG2+/J8xle///UG8Z9Or8cmd X05Q== X-Forwarded-Encrypted: i=1; AJvYcCXqN8QfL57Hev3VyDunSzDDcxhIZaTu3LKh0Osc1MaL7ONnkChjA0YzzkvYPjxGaki6pcr16BoEIA==@nongnu.org X-Gm-Message-State: AOJu0YxBXkPJVmJbfDDN7oEA5YuFUGaf2mbelUMbqF0VqZu7JZ7/HMQo 9TiQgPEcdWMpmYj1GgeStfusjPLsSVuY2f2IVJl/VpfhrcdSNqP+AX0KT4LB2G/4EOU= X-Gm-Gg: ASbGncstlgTJwbwPkrwOZzSizNTGEmOgBm8Gs+vf1ZjTnDzHbJxbibKFEmxA1mflgeY MXEVOIpgk/nnU7spKFJrO7Zx0cO+zWXe22SUEeJywGRE6h5adHJHJFl+jYEjhfAzw0+SgCj3fjv h6YOWXvKiNfGzWnmyf8s/UNTqo9jfdI4K9BqbMjoXnlsA82DS8R5/Fb4H4MtFAuAmj9BdnHUfZu eeBSFO5fsM9oiC6kUk9lNiKftzEXPf2b8pANN2yZKcp/4zC4BOkPegBKaxTdubqiNHZ5bImMcfI mJD9b1EBaQnpFYYayrcTwjeflHvs6RcBhbcpWkrnqG/PW29or0h/YYEI9rJtVfQMS+mavhv4jAn 92eSZ5Emg9pwzslTLWpjHx7AiqXoCbkjs6/28/NOwrQ0= X-Google-Smtp-Source: AGHT+IEvMHHgFaaytalz6UQbvUPncZajrApGFHUekdfKCZRo5eVGwOep335jVCVn4k2EGcykuKBUBw== X-Received: by 2002:a05:6a20:3ca1:b0:1f5:8c05:e8f8 with SMTP id adf61e73a8af0-222d7e9bfc7mr9085863637.25.1751532991529; Thu, 03 Jul 2025 01:56:31 -0700 (PDT) From: William Kosasih To: qemu-devel@nongnu.org Cc: Peter Maydell , qemu-arm@nongnu.org, Richard Henderson , William Kosasih Subject: [PATCH v4 04/11] target/arm: Fix VLDR helper load alignment checks Date: Thu, 3 Jul 2025 18:25:57 +0930 Message-ID: <20250703085604.154449-5-kosasihwilliam4@gmail.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250703085604.154449-1-kosasihwilliam4@gmail.com> References: <20250703085604.154449-1-kosasihwilliam4@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::433; envelope-from=kosasihwilliam4@gmail.com; helo=mail-pf1-x433.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1751533048227116600 Content-Type: text/plain; charset="utf-8" This patch adds alignment checks in the load operations in the VLDR instruction. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1154 Signed-off-by: William Kosasih Reviewed-by: Richard Henderson --- target/arm/tcg/mve_helper.c | 24 +++++++++++++----------- 1 file changed, 13 insertions(+), 11 deletions(-) diff --git a/target/arm/tcg/mve_helper.c b/target/arm/tcg/mve_helper.c index 506d1c3475..8834523c23 100644 --- a/target/arm/tcg/mve_helper.c +++ b/target/arm/tcg/mve_helper.c @@ -148,13 +148,15 @@ static void mve_advance_vpt(CPUARMState *env) } =20 /* For loads, predicated lanes are zeroed instead of keeping their old val= ues */ -#define DO_VLDR(OP, MSIZE, LDTYPE, ESIZE, TYPE) \ +#define DO_VLDR(OP, MFLAG, MSIZE, MTYPE, LDTYPE, ESIZE, TYPE) \ void HELPER(mve_##OP)(CPUARMState *env, void *vd, uint32_t addr) \ { \ TYPE *d =3D vd; \ uint16_t mask =3D mve_element_mask(env); \ uint16_t eci_mask =3D mve_eci_mask(env); \ unsigned b, e; \ + int mmu_idx =3D arm_to_core_mmu_idx(arm_mmu_idx(env)); \ + MemOpIdx oi =3D make_memop_idx(MFLAG | MO_ALIGN, mmu_idx); \ /* \ * R_SXTM allows the dest reg to become UNKNOWN for abandoned \ * beats so we don't care if we update part of the dest and \ @@ -163,7 +165,7 @@ static void mve_advance_vpt(CPUARMState *env) for (b =3D 0, e =3D 0; b < 16; b +=3D ESIZE, e++) { = \ if (eci_mask & (1 << b)) { \ d[H##ESIZE(e)] =3D (mask & (1 << b)) ? \ - cpu_##LDTYPE##_data_ra(env, addr, GETPC()) : 0; \ + (MTYPE)cpu_##LDTYPE##_mmu(env, addr, oi, GETPC()) : 0;\ } \ addr +=3D MSIZE; \ } \ @@ -185,20 +187,20 @@ static void mve_advance_vpt(CPUARMState *env) mve_advance_vpt(env); \ } =20 -DO_VLDR(vldrb, 1, ldub, 1, uint8_t) -DO_VLDR(vldrh, 2, lduw, 2, uint16_t) -DO_VLDR(vldrw, 4, ldl, 4, uint32_t) +DO_VLDR(vldrb, MO_UB, 1, uint8_t, ldb, 1, uint8_t) +DO_VLDR(vldrh, MO_TEUW, 2, uint16_t, ldw, 2, uint16_t) +DO_VLDR(vldrw, MO_TEUL, 4, uint32_t, ldl, 4, uint32_t) =20 DO_VSTR(vstrb, 1, stb, 1, uint8_t) DO_VSTR(vstrh, 2, stw, 2, uint16_t) DO_VSTR(vstrw, 4, stl, 4, uint32_t) =20 -DO_VLDR(vldrb_sh, 1, ldsb, 2, int16_t) -DO_VLDR(vldrb_sw, 1, ldsb, 4, int32_t) -DO_VLDR(vldrb_uh, 1, ldub, 2, uint16_t) -DO_VLDR(vldrb_uw, 1, ldub, 4, uint32_t) -DO_VLDR(vldrh_sw, 2, ldsw, 4, int32_t) -DO_VLDR(vldrh_uw, 2, lduw, 4, uint32_t) +DO_VLDR(vldrb_sh, MO_SB, 1, int8_t, ldb, 2, int16_t) +DO_VLDR(vldrb_sw, MO_SB, 1, int8_t, ldb, 4, int32_t) +DO_VLDR(vldrb_uh, MO_UB, 1, uint8_t, ldb, 2, uint16_t) +DO_VLDR(vldrb_uw, MO_UB, 1, uint8_t, ldb, 4, uint32_t) +DO_VLDR(vldrh_sw, MO_TESW, 2, int16_t, ldw, 4, int32_t) +DO_VLDR(vldrh_uw, MO_TEUW, 2, uint16_t, ldw, 4, uint32_t) =20 DO_VSTR(vstrb_h, 1, stb, 2, int16_t) DO_VSTR(vstrb_w, 1, stb, 4, int32_t) --=20 2.48.1 From nobody Sat Nov 15 12:39:23 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1751533056; cv=none; d=zohomail.com; s=zohoarc; b=Q7zfGbQQdrXs+BjCcp9+sf9LsaYxgES17Yi5yuDExTqOdFU0gdLemQ6Y9Bfq1cuJkkx9EsDCf4JORDrN+0ZnT0Pd/E22F28beV3MOWxWaBJ2DAbxlE809fkDI9OVspGim3QSAHw0b+0j32mco0U1qppi9/C8thGC/3YsmkPWj0E= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1751533056; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=aKRfOMZpAFbQW59XcJc9qTc3jh/YMdne3jcVAlhxqzs=; b=KvtqPhm+8BdiV6x1Eu5WJHb/JOfbOBzzSwJTOs+cIyuh84fmDAMryDLA38za1pCe0unmcTD3EZbSJsp85llHkkI4kCGB0h+tALr6/bZ0xIBNZo5jsR2WO0wGf8C26xMFj9e8fnqzAJukZw2CoVr/b9CvZAXvYtrDjiGtk/hz1xY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1751533056842998.4590329520684; Thu, 3 Jul 2025 01:57:36 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uXFkK-0002dI-1p; Thu, 03 Jul 2025 04:56:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uXFkG-0002be-Ay; Thu, 03 Jul 2025 04:56:40 -0400 Received: from mail-pf1-x429.google.com ([2607:f8b0:4864:20::429]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uXFkE-000824-GK; Thu, 03 Jul 2025 04:56:40 -0400 Received: by mail-pf1-x429.google.com with SMTP id d2e1a72fcca58-7424ccbef4eso4819831b3a.2; Thu, 03 Jul 2025 01:56:37 -0700 (PDT) Received: from localhost (pa49-178-74-199.pa.nsw.optusnet.com.au. [49.178.74.199]) by smtp.gmail.com with UTF8SMTPSA id d2e1a72fcca58-74af57ef4dbsm16631704b3a.160.2025.07.03.01.56.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Jul 2025 01:56:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1751532996; x=1752137796; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=aKRfOMZpAFbQW59XcJc9qTc3jh/YMdne3jcVAlhxqzs=; b=hhB2hXRBMcj083kErq/iYSX+lcEiF6uWUBN9eLE9Pdao/V2PrOHD65Bjro62c9CDPn voK1kWvh2EbLlP4rcn+Qx4Ma2MiiFMMiO04/N4nj0apAT++5SAI3GSV9ezwTBRRqUWlO vGejemD29VwWucBvW1CJ9MIhQy2ujN3fYIBYEKuOUeZVWiLGzba68OKb3wbcb4Yahvmr nGvfvjN4MPxOjsP0gF8z3Hpmupoxe56Hr6l6gju5hLldokK9K+/U80baHfyptIruumE7 s66Lk3oFdlYEckw1+7Xa10kq9vujDxW4CVCeUg6Wcv7g8GwcxSrGFb0YUWTcheebzPdS BaVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751532996; x=1752137796; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=aKRfOMZpAFbQW59XcJc9qTc3jh/YMdne3jcVAlhxqzs=; b=ZCeZ4p0mb6561MPesacKUk8a9EtAtXWcaNx5iEn6SLblm4+JNWlWBMgAhP40TkiMs4 AxuZf2KRLFIqiaRHxJebCwJIy0gmV8ZPmzomMAkOinG1Sl4X2UhzETxwD54a4QfUjpYD JN/QG++XduhOz0DDJnCQiGcAbg/o97/hPql2rTgbYYU04Qy4TSrr/bnJD6YBMPvfRTRN LSmrQLVP3b/mmzX+04T2KXr4ER8UxST5ZRXCu+Mt9UID1z0QCI/HLcjiMZOqNcIzTZBw FuZxOp+n0NAXDj315jnmJmUZ/DCoG2baRFl8YHN2Wvkm/3RAJJ0gEg3m1TMdxYqjDvGA LaGw== X-Forwarded-Encrypted: i=1; AJvYcCWlpkji5OB2OojtxjOjHrRrlwVe2yMY+qpKOj9AmyFe5r7ubM05ivf4Spp0GjOFoaizqaGITUDTqA==@nongnu.org X-Gm-Message-State: AOJu0YxSwTDu73uhQhiW3R9TPrgHblYuJgpRXSkQ3dF84C7EFHjYsqNz crxO0CZAJAQj2fSrK7OMSozHXi9xEu5VNaGslMICDXTABhv9n3tTW/obHUTaBEWMWvU= X-Gm-Gg: ASbGncuZTfJeZbp7WSiH3tnI8THFmFCgPeahK/AMA7lS6T9apYmj4XMq/yI+loAXepJ TyFIYXtMpSDfGWs8wLKJdpGQXYE2QLLA97d1foxUkJr2EH3H4ENfSQZOoDpiQEi4M7h8cpoNnCa 0tYBxrppH9e/1S6OmfMcj/QZ1LkCxj14Ku6lLuU0UU3TIRXi6qQuxStTDMGeSNC+InAJsN5lT8A u7mwMnNuP0h0L1H/dDxK81vuR6BOuPyfF05/Hw1gz1uV2HHWUYCZOfjr9yZaX7iJC9fccxaBgPh JE3beCIABXsL24uKQ6InBAIefmHtWI20PuUvI+YV0Fp+cgh7I4aEoTrL8AjxtAnBqHkdVF9kyBk LvBGw6b2zr4JiBBodaV0yCl5Xt/uzBsYmtnzwW3QFrWI= X-Google-Smtp-Source: AGHT+IGzwAlqDoi6kEjLNV9yt8UNZjj86pVaRPcoqGg/HZwvAIlKSmyjfylRqhK9d0Dzq8ITLBwF/A== X-Received: by 2002:a05:6a21:6da0:b0:220:99ba:6b5d with SMTP id adf61e73a8af0-222d7f33162mr9017321637.39.1751532996074; Thu, 03 Jul 2025 01:56:36 -0700 (PDT) From: William Kosasih To: qemu-devel@nongnu.org Cc: Peter Maydell , qemu-arm@nongnu.org, Richard Henderson , William Kosasih Subject: [PATCH v4 05/11] target/arm: Fix VSTR helper store alignment checks Date: Thu, 3 Jul 2025 18:25:58 +0930 Message-ID: <20250703085604.154449-6-kosasihwilliam4@gmail.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250703085604.154449-1-kosasihwilliam4@gmail.com> References: <20250703085604.154449-1-kosasihwilliam4@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::429; envelope-from=kosasihwilliam4@gmail.com; helo=mail-pf1-x429.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1751533058265116600 Content-Type: text/plain; charset="utf-8" This patch adds alignment checks in the store operations in the VSTR instruction. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1154 Signed-off-by: William Kosasih Reviewed-by: Richard Henderson --- target/arm/tcg/mve_helper.c | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/target/arm/tcg/mve_helper.c b/target/arm/tcg/mve_helper.c index 8834523c23..9587f2da7d 100644 --- a/target/arm/tcg/mve_helper.c +++ b/target/arm/tcg/mve_helper.c @@ -172,15 +172,17 @@ static void mve_advance_vpt(CPUARMState *env) mve_advance_vpt(env); \ } =20 -#define DO_VSTR(OP, MSIZE, STTYPE, ESIZE, TYPE) \ +#define DO_VSTR(OP, MFLAG, MSIZE, STTYPE, ESIZE, TYPE) \ void HELPER(mve_##OP)(CPUARMState *env, void *vd, uint32_t addr) \ { \ TYPE *d =3D vd; \ uint16_t mask =3D mve_element_mask(env); \ unsigned b, e; \ + int mmu_idx =3D arm_to_core_mmu_idx(arm_mmu_idx(env)); \ + MemOpIdx oi =3D make_memop_idx(MFLAG | MO_ALIGN, mmu_idx); \ for (b =3D 0, e =3D 0; b < 16; b +=3D ESIZE, e++) { = \ if (mask & (1 << b)) { \ - cpu_##STTYPE##_data_ra(env, addr, d[H##ESIZE(e)], GETPC())= ; \ + cpu_##STTYPE##_mmu(env, addr, d[H##ESIZE(e)], oi, GETPC())= ; \ } \ addr +=3D MSIZE; \ } \ @@ -191,9 +193,9 @@ DO_VLDR(vldrb, MO_UB, 1, uint8_t, ldb, 1, uint8_t) DO_VLDR(vldrh, MO_TEUW, 2, uint16_t, ldw, 2, uint16_t) DO_VLDR(vldrw, MO_TEUL, 4, uint32_t, ldl, 4, uint32_t) =20 -DO_VSTR(vstrb, 1, stb, 1, uint8_t) -DO_VSTR(vstrh, 2, stw, 2, uint16_t) -DO_VSTR(vstrw, 4, stl, 4, uint32_t) +DO_VSTR(vstrb, MO_UB, 1, stb, 1, uint8_t) +DO_VSTR(vstrh, MO_TEUW, 2, stw, 2, uint16_t) +DO_VSTR(vstrw, MO_TEUL, 4, stl, 4, uint32_t) =20 DO_VLDR(vldrb_sh, MO_SB, 1, int8_t, ldb, 2, int16_t) DO_VLDR(vldrb_sw, MO_SB, 1, int8_t, ldb, 4, int32_t) @@ -202,9 +204,9 @@ DO_VLDR(vldrb_uw, MO_UB, 1, uint8_t, ldb, 4, uint32_t) DO_VLDR(vldrh_sw, MO_TESW, 2, int16_t, ldw, 4, int32_t) DO_VLDR(vldrh_uw, MO_TEUW, 2, uint16_t, ldw, 4, uint32_t) =20 -DO_VSTR(vstrb_h, 1, stb, 2, int16_t) -DO_VSTR(vstrb_w, 1, stb, 4, int32_t) -DO_VSTR(vstrh_w, 2, stw, 4, int32_t) +DO_VSTR(vstrb_h, MO_UB, 1, stb, 2, int16_t) +DO_VSTR(vstrb_w, MO_UB, 1, stb, 4, int32_t) +DO_VSTR(vstrh_w, MO_TEUW, 2, stw, 4, int32_t) =20 #undef DO_VLDR #undef DO_VSTR --=20 2.48.1 From nobody Sat Nov 15 12:39:23 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1751533054; cv=none; d=zohomail.com; s=zohoarc; b=NI1zusJYbKgacO7GTunMudqxkBo4I0OQX5qMBy/TJ1SlS6U5Vuz4nvhyNZ/XVwlaIgJSM+x+g6uv9nbqPnAWrtNMhQfQn29TH4pYyW3WTrXxLGNnvsyvGWkOxPQ409FoWsT+Frwg7fD6rmwkTbTlIrXWAof8DYqdViFJ/zmvkb0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1751533054; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=95N5DHUFYR/urUJHPiqmxEqBz3CfWOqz9EM3HMn4/jk=; b=engQXAzQETXYBwxK9+BpsnHdRlW90atU6HLD/JC8lO9FeBdqNDAcl5p3AG6PWyz22A9wyz4zqVafEIRYh6Jqi/DJ39CeScKhQY8ULSKMnIhl3U7KUPa9t9UVCEp31EoPDa4u2+S0wXhkASpS6ZTIaVxO8LZ2kDXhiSf8trfUkPY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1751533054729447.4528421552568; Thu, 3 Jul 2025 01:57:34 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uXFkY-0002wM-Vv; Thu, 03 Jul 2025 04:57:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uXFkM-0002gy-Id; Thu, 03 Jul 2025 04:56:48 -0400 Received: from mail-pl1-x62d.google.com ([2607:f8b0:4864:20::62d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uXFkK-00083n-F0; Thu, 03 Jul 2025 04:56:46 -0400 Received: by mail-pl1-x62d.google.com with SMTP id d9443c01a7336-235ea292956so50617185ad.1; Thu, 03 Jul 2025 01:56:42 -0700 (PDT) Received: from localhost (pa49-178-74-199.pa.nsw.optusnet.com.au. [49.178.74.199]) by smtp.gmail.com with UTF8SMTPSA id d9443c01a7336-23acb3b7bafsm149171255ad.167.2025.07.03.01.56.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Jul 2025 01:56:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1751533001; x=1752137801; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=95N5DHUFYR/urUJHPiqmxEqBz3CfWOqz9EM3HMn4/jk=; b=FiL4O+pDxf3OsHCww9NO9C4/e083TW0V0OiuoJpjVQ7i2FWVenkMO+dMjTbq8bj/tT RMp2WY7ZEWcG1jC6JIwTTT1DxRaZBAjMuIMShWQPFz16e3kP3u1f8oMom1eRpyPfGrJY FxKMKz3v5Gm4x8xt1L9y7VrO7cG/lY+PIF0GLAkKThJ17g+2quNXmSTaGj83yQtUQTno JYZyQfvEWOP83UxV1Fl3V8xlrbHNmXauSLLFqHQWTlVsrD0EHE5DktwplpYSXLFAIK/f 663FWvr6FGt0SJCbn7O0nzBx8+4nb8e6m0GxdeC/us/WcMy6fx6B50umXhBgeNV9rKxC vsJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751533001; x=1752137801; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=95N5DHUFYR/urUJHPiqmxEqBz3CfWOqz9EM3HMn4/jk=; b=ud+jMh55szu5yYZsFD4gf56bAMClI15l41Y1QyQhFvkgA2acB3MIt/UiImJuQcKVZy qbshMIFEC/8+FHn6/5NrU0N/zNSaa28fZH5G+LPJIdVaoD2kqeT5OH2uN8bZ78A+ccvq jhihSue5IsXi6CttaqJt7jqmXSLUEWeSDlejc3gCXlomXiSUWmGB4W/iOBOeUEFghV80 ba36mjOtW3phD9D2hgw8Ecg1cIMO0WLHl7l56+vMVtIrxUH0yZfP0cPlSNXf/rIShJwA 89RXhfUHdivd6/3iEYbtjsk75lKW+7qxVW/Z/cPcAcyyd9GY33n9am4/cDCAMjA2MpWM NVcg== X-Forwarded-Encrypted: i=1; AJvYcCUU+bzpT0BJbDDIOTtsBdGtr3lR8eaEukh6w+EaYAEP+ZRHaiofeoNdxPvzaCLYQYfetiM2FCBCVw==@nongnu.org X-Gm-Message-State: AOJu0YyfY4/yw1Kk6/rOdovof/0Sz0Z6oVgGwKIA8L3Ob47od0RGpmpg x10ITUxdAJzygc6twD4GYpn8JX7ymz3kRTv4r8wK9CBb0PX7e/ZZwGUcb76GEBeglWk= X-Gm-Gg: ASbGncse6ppCipieZq8NPaX8wTTgXzpQJJwv3TguMl1BIxyHem6pPX7su04Q6hXOxxk NQKzL5p8ox12I9EDevryU/cx3mYbCsZrZ55yN/BqctYwdbm2TT5V+xlzG4zs81WOj3fYnwN4qbM gS6sti8te0IcqVMJDAhmFdCxJNdpTYfkk1cotHilA9iiIiQ/oaJ9tBQ7NbPVq/Je+IL0/blHvFG C4ZQhQQtyU9eNL4GQ+pMWSOBeKWJrapjnUfHner7djwz1rRTM6H/p/u8bZ6PtmXKoJ9WYaEvJcJ ZjLTqC06G3tRvLLgGcHI4OhmkBOXLMNiC21DP1cDwS9yc28mewMW/7MhGb1PBbqNarEBpTwX2X9 0Le5OyapNoWWt3XBXMR07ItUeXEkFTGUNPf3KkB2slWY= X-Google-Smtp-Source: AGHT+IEbFgIYugWhe19qxSjOlXu4R2lYhdw4Y6xunbEVMmcLWzvF0M1Lf9EFiEB4NFVk9agjKYBOKA== X-Received: by 2002:a17:902:c94f:b0:234:a139:11e7 with SMTP id d9443c01a7336-23c6e56c268mr93591235ad.35.1751533001105; Thu, 03 Jul 2025 01:56:41 -0700 (PDT) From: William Kosasih To: qemu-devel@nongnu.org Cc: Peter Maydell , qemu-arm@nongnu.org, Richard Henderson , William Kosasih Subject: [PATCH v4 06/11] target/arm: Fix VLDR_SG helper load alignment checks Date: Thu, 3 Jul 2025 18:25:59 +0930 Message-ID: <20250703085604.154449-7-kosasihwilliam4@gmail.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250703085604.154449-1-kosasihwilliam4@gmail.com> References: <20250703085604.154449-1-kosasihwilliam4@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::62d; envelope-from=kosasihwilliam4@gmail.com; helo=mail-pl1-x62d.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1751533056244116600 Content-Type: text/plain; charset="utf-8" This patch adds alignment checks in the load operations in the VLDR_SG instructions. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1154 Signed-off-by: William Kosasih Reviewed-by: Richard Henderson --- target/arm/tcg/mve_helper.c | 42 ++++++++++++++++++++++--------------- 1 file changed, 25 insertions(+), 17 deletions(-) diff --git a/target/arm/tcg/mve_helper.c b/target/arm/tcg/mve_helper.c index 9587f2da7d..633f511a7e 100644 --- a/target/arm/tcg/mve_helper.c +++ b/target/arm/tcg/mve_helper.c @@ -218,7 +218,7 @@ DO_VSTR(vstrh_w, MO_TEUW, 2, stw, 4, int32_t) * For loads, predicated lanes are zeroed instead of retaining * their previous values. */ -#define DO_VLDR_SG(OP, LDTYPE, ESIZE, TYPE, OFFTYPE, ADDRFN, WB) \ +#define DO_VLDR_SG(OP, MFLAG, MTYPE, LDTYPE, ESIZE, TYPE, OFFTYPE, ADDRFN,= WB)\ void HELPER(mve_##OP)(CPUARMState *env, void *vd, void *vm, \ uint32_t base) \ { \ @@ -228,13 +228,15 @@ DO_VSTR(vstrh_w, MO_TEUW, 2, stw, 4, int32_t) uint16_t eci_mask =3D mve_eci_mask(env); \ unsigned e; \ uint32_t addr; \ + int mmu_idx =3D arm_to_core_mmu_idx(arm_mmu_idx(env)); \ + MemOpIdx oi =3D make_memop_idx(MFLAG | MO_ALIGN, mmu_idx); \ for (e =3D 0; e < 16 / ESIZE; e++, mask >>=3D ESIZE, eci_mask >>= =3D ESIZE) { \ if (!(eci_mask & 1)) { \ continue; \ } \ addr =3D ADDRFN(base, m[H##ESIZE(e)]); \ d[H##ESIZE(e)] =3D (mask & 1) ? \ - cpu_##LDTYPE##_data_ra(env, addr, GETPC()) : 0; \ + (MTYPE)cpu_##LDTYPE##_mmu(env, addr, oi, GETPC()) : 0; \ if (WB) { \ m[H##ESIZE(e)] =3D addr; \ } \ @@ -286,13 +288,15 @@ DO_VSTR(vstrh_w, MO_TEUW, 2, stw, 4, int32_t) uint16_t eci_mask =3D mve_eci_mask(env); \ unsigned e; \ uint32_t addr; \ + int mmu_idx =3D arm_to_core_mmu_idx(arm_mmu_idx(env)); \ + MemOpIdx oi =3D make_memop_idx(MO_TEUL | MO_ALIGN, mmu_idx); \ for (e =3D 0; e < 16 / 4; e++, mask >>=3D 4, eci_mask >>=3D 4) { = \ if (!(eci_mask & 1)) { \ continue; \ } \ addr =3D ADDRFN(base, m[H4(e & ~1)]); \ addr +=3D 4 * (e & 1); \ - d[H4(e)] =3D (mask & 1) ? cpu_ldl_data_ra(env, addr, GETPC()) = : 0; \ + d[H4(e)] =3D (mask & 1) ? cpu_ldl_mmu(env, addr, oi, GETPC()) = : 0; \ if (WB && (e & 1)) { \ m[H4(e & ~1)] =3D addr - 4; \ } \ @@ -331,22 +335,26 @@ DO_VSTR(vstrh_w, MO_TEUW, 2, stw, 4, int32_t) #define ADDR_ADD_OSW(BASE, OFFSET) ((BASE) + ((OFFSET) << 2)) #define ADDR_ADD_OSD(BASE, OFFSET) ((BASE) + ((OFFSET) << 3)) =20 -DO_VLDR_SG(vldrb_sg_sh, ldsb, 2, int16_t, uint16_t, ADDR_ADD, false) -DO_VLDR_SG(vldrb_sg_sw, ldsb, 4, int32_t, uint32_t, ADDR_ADD, false) -DO_VLDR_SG(vldrh_sg_sw, ldsw, 4, int32_t, uint32_t, ADDR_ADD, false) +DO_VLDR_SG(vldrb_sg_sh, MO_SB, int8_t, ldb, 2, int16_t, uint16_t, ADDR_ADD= , false) +DO_VLDR_SG(vldrb_sg_sw, MO_SB, int8_t, ldb, 4, int32_t, uint32_t, ADDR_ADD= , false) +DO_VLDR_SG(vldrh_sg_sw, MO_TESW, int16_t, ldw, 4, int32_t, uint32_t, ADDR_= ADD, false) =20 -DO_VLDR_SG(vldrb_sg_ub, ldub, 1, uint8_t, uint8_t, ADDR_ADD, false) -DO_VLDR_SG(vldrb_sg_uh, ldub, 2, uint16_t, uint16_t, ADDR_ADD, false) -DO_VLDR_SG(vldrb_sg_uw, ldub, 4, uint32_t, uint32_t, ADDR_ADD, false) -DO_VLDR_SG(vldrh_sg_uh, lduw, 2, uint16_t, uint16_t, ADDR_ADD, false) -DO_VLDR_SG(vldrh_sg_uw, lduw, 4, uint32_t, uint32_t, ADDR_ADD, false) -DO_VLDR_SG(vldrw_sg_uw, ldl, 4, uint32_t, uint32_t, ADDR_ADD, false) +DO_VLDR_SG(vldrb_sg_ub, MO_UB, uint8_t, ldb, 1, uint8_t, uint8_t, ADDR_ADD= , false) +DO_VLDR_SG(vldrb_sg_uh, MO_UB, uint8_t, ldb, 2, uint16_t, uint16_t, ADDR_A= DD, false) +DO_VLDR_SG(vldrb_sg_uw, MO_UB, uint8_t, ldb, 4, uint32_t, uint32_t, ADDR_A= DD, false) +DO_VLDR_SG(vldrh_sg_uh, MO_TEUW, uint16_t, ldw, 2, uint16_t, uint16_t, ADD= R_ADD, false) +DO_VLDR_SG(vldrh_sg_uw, MO_TEUW, uint16_t, ldw, 4, uint32_t, uint32_t, ADD= R_ADD, false) +DO_VLDR_SG(vldrw_sg_uw, MO_TEUL, uint32_t, ldl, 4, uint32_t, uint32_t, ADD= R_ADD, false) DO_VLDR64_SG(vldrd_sg_ud, ADDR_ADD, false) =20 -DO_VLDR_SG(vldrh_sg_os_sw, ldsw, 4, int32_t, uint32_t, ADDR_ADD_OSH, false) -DO_VLDR_SG(vldrh_sg_os_uh, lduw, 2, uint16_t, uint16_t, ADDR_ADD_OSH, fals= e) -DO_VLDR_SG(vldrh_sg_os_uw, lduw, 4, uint32_t, uint32_t, ADDR_ADD_OSH, fals= e) -DO_VLDR_SG(vldrw_sg_os_uw, ldl, 4, uint32_t, uint32_t, ADDR_ADD_OSW, false) +DO_VLDR_SG(vldrh_sg_os_sw, MO_TESW, int16_t, ldw, 4, + int32_t, uint32_t, ADDR_ADD_OSH, false) +DO_VLDR_SG(vldrh_sg_os_uh, MO_TEUW, uint16_t, ldw, 2, + uint16_t, uint16_t, ADDR_ADD_OSH, false) +DO_VLDR_SG(vldrh_sg_os_uw, MO_TEUW, uint16_t, ldw, 4, + uint32_t, uint32_t, ADDR_ADD_OSH, false) +DO_VLDR_SG(vldrw_sg_os_uw, MO_TEUL, uint32_t, ldl, 4, + uint32_t, uint32_t, ADDR_ADD_OSW, false) DO_VLDR64_SG(vldrd_sg_os_ud, ADDR_ADD_OSD, false) =20 DO_VSTR_SG(vstrb_sg_ub, stb, 1, uint8_t, ADDR_ADD, false) @@ -362,7 +370,7 @@ DO_VSTR_SG(vstrh_sg_os_uw, stw, 4, uint32_t, ADDR_ADD_O= SH, false) DO_VSTR_SG(vstrw_sg_os_uw, stl, 4, uint32_t, ADDR_ADD_OSW, false) DO_VSTR64_SG(vstrd_sg_os_ud, ADDR_ADD_OSD, false) =20 -DO_VLDR_SG(vldrw_sg_wb_uw, ldl, 4, uint32_t, uint32_t, ADDR_ADD, true) +DO_VLDR_SG(vldrw_sg_wb_uw, MO_TEUL, uint32_t, ldl, 4, uint32_t, uint32_t, = ADDR_ADD, true) DO_VLDR64_SG(vldrd_sg_wb_ud, ADDR_ADD, true) DO_VSTR_SG(vstrw_sg_wb_uw, stl, 4, uint32_t, ADDR_ADD, true) DO_VSTR64_SG(vstrd_sg_wb_ud, ADDR_ADD, true) --=20 2.48.1 From nobody Sat Nov 15 12:39:23 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1751533116; cv=none; d=zohomail.com; s=zohoarc; b=ejczufcEoiJJW5S2Dzm1+atS1VrXRgRo4igdH/J9BLM3bRfuS35eNS4PzZ0G6XabJX0c+BibW4JK0WQKuZ3K7x05kW5XyffAmkO4B4E5Iz3aXK1Rr7sabbV1bJgyqeDza8qCt9lh6THhV4bEBN7+379xUAW/vWmq5sOcZTwHxeo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1751533116; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=phAr9vGsIdCZhTB64UYGMtairPbr9vOxRvodihkDwSA=; b=g/hEGINFzMy8z59g3NjCRg3rReHdUaT+P3cBSuGNAy5HOJQHKgaSH+0kvNCrETOMJEX6azlqg5cKRIFRndoPrem4wXX7mU+XyU4bhEQW1Wk8QgLaxfiP2eSeAu8PyKbLPvueFLQgVW8Dyemm2vYtYqZaecK73nH3kB1+6xiNweY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1751533116104530.276015297047; Thu, 3 Jul 2025 01:58:36 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uXFkc-0002ze-Nu; Thu, 03 Jul 2025 04:57:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uXFkR-0002oE-Lr; Thu, 03 Jul 2025 04:56:52 -0400 Received: from mail-pf1-x42c.google.com ([2607:f8b0:4864:20::42c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uXFkP-0008AB-FD; Thu, 03 Jul 2025 04:56:51 -0400 Received: by mail-pf1-x42c.google.com with SMTP id d2e1a72fcca58-74931666cbcso7524212b3a.0; Thu, 03 Jul 2025 01:56:48 -0700 (PDT) Received: from localhost (pa49-178-74-199.pa.nsw.optusnet.com.au. [49.178.74.199]) by smtp.gmail.com with UTF8SMTPSA id d2e1a72fcca58-74af541d233sm17150026b3a.61.2025.07.03.01.56.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Jul 2025 01:56:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1751533006; x=1752137806; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=phAr9vGsIdCZhTB64UYGMtairPbr9vOxRvodihkDwSA=; b=nETRPWbArckspZO47tvswNUzse2fyp/oi0Ofq4Rs0ooOP/lMQlFB9c+24UFsFFA+mF 09n8MmToK6UQSF32rgmNkYnJIZiM1xtkPyBiecXtMF08FuHXWlo1OS7xGbbFsBOpStko msqeFxzYAaGKKut6cZb4dxMB2MCCzU5DOciV9ObSxT6sC6Svv4U/9WlZXEI5rOzivIRh LLN2xJnHQBgOnAfqyHp6Ad9NWC3WUgQFUDIIlXjXGJLrp/Xl7GqLp7obnI2ufHMGd7Vb laHRG2sUSa/jQR71h/bHpfWqChKoC/uAzMAWNi5FsZ4GQQmSgrJH+zi0t4aMk2M9tMrJ qy7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751533006; x=1752137806; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=phAr9vGsIdCZhTB64UYGMtairPbr9vOxRvodihkDwSA=; b=KCIQM+j+him01uglXpemv27SKLOeWcl3A/YoShDv3ZJJwjqVevHXaXrFer94h0EZ3j xhPaWMo9onmFs2K/htAugJ8vC/KHh9OlHYuIXCBHg42pGE13cgMLbAuyPFi7EHnNYECq PymXbeHx3NBySw4aYWYJpkZLUrC7HDD/7TKJPWfm5ONAfAk4M1wCKr2/Ip59KTDXNNaq xqI4dmacN5/aBQJMxdPW3a2bHcHDB6byYAKWPoEfDVvhb3CMn87jiTmKF65mSjaGMX+T mZf2IYP5Jcy38gTacHNt2PWkw5Zr9eGLo4TvAZ9MQC/CWt9eE8+vi0zDIK5uedyVpH0a AhEg== X-Forwarded-Encrypted: i=1; AJvYcCXTWlO5jKJrpyWI/GpsKKT46kmq257Q/sb7BedYQedswW75UHjcXyuJqgturvp4RUkWst87kbR/5g==@nongnu.org X-Gm-Message-State: AOJu0YxQ64FigODtMTt/SMcZ6gTze7BQ6iXc5IbrLQgXdf3ZGsR56TfD qNDvpjOAZWl/ZbBxwAUKOdXX7wPgo5PFx4WtAQNEE+UuacXbdwAoe/IQU0nnZNkbn3o= X-Gm-Gg: ASbGncszKfUNtC03xsmxunI6qYWGMg8PDEWU5PlZ82IiCtKySl8wZG392GRRFL3Z2II KoLrzpMY4nHanrMFl0n3jBZwyU19nvcoDO4zP6HwEvcQzpWDCSbn6IqC5O9/Z0edsBBs4gj0coZ Hsgm+ABHHCxCZ8xMqyGcj67AoWLl1+GV8HCCQ/fTNSWvBqNPawzEhCfEPEp7sdtDBU437eGTIfJ Ds53IqW50oMeIrTAGPwZqANLcM2Ik5aZESSjL247tD8wJsV55R8CZTBd9R6+ZtuDDsmjzppc0Wd HuaW3rKwmN3NnGnmLIRSKAA4kQDb0a+Rw+oWB0LH8ZYf4HFrj47JBudgUt+y18ZUxJotekHctxM Nopj7Y00+B/bbTMegolQcV1NVD3BOzV0pXDk6djC6bVg= X-Google-Smtp-Source: AGHT+IGjPgOh3f/gngELKnDsb05uyXf8B/kk9F66M1qVXp/8JVWfjAobkNJzLfxyxt58dsoyQiyRQg== X-Received: by 2002:a05:6a00:2341:b0:748:34a4:ab13 with SMTP id d2e1a72fcca58-74b50e8db4fmr7835945b3a.6.1751533006192; Thu, 03 Jul 2025 01:56:46 -0700 (PDT) From: William Kosasih To: qemu-devel@nongnu.org Cc: Peter Maydell , qemu-arm@nongnu.org, Richard Henderson , William Kosasih Subject: [PATCH v4 07/11] target/arm: Fix VSTR_SG helper store alignment checks Date: Thu, 3 Jul 2025 18:26:00 +0930 Message-ID: <20250703085604.154449-8-kosasihwilliam4@gmail.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250703085604.154449-1-kosasihwilliam4@gmail.com> References: <20250703085604.154449-1-kosasihwilliam4@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::42c; envelope-from=kosasihwilliam4@gmail.com; helo=mail-pf1-x42c.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1751533116986116600 Content-Type: text/plain; charset="utf-8" This patch adds alignment checks in the store operations in the VSTR_SG instructions. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1154 Signed-off-by: William Kosasih Reviewed-by: Richard Henderson --- target/arm/tcg/mve_helper.c | 30 +++++++++++++++++------------- 1 file changed, 17 insertions(+), 13 deletions(-) diff --git a/target/arm/tcg/mve_helper.c b/target/arm/tcg/mve_helper.c index 633f511a7e..2d21625f24 100644 --- a/target/arm/tcg/mve_helper.c +++ b/target/arm/tcg/mve_helper.c @@ -245,7 +245,7 @@ DO_VSTR(vstrh_w, MO_TEUW, 2, stw, 4, int32_t) } =20 /* We know here TYPE is unsigned so always the same as the offset type */ -#define DO_VSTR_SG(OP, STTYPE, ESIZE, TYPE, ADDRFN, WB) \ +#define DO_VSTR_SG(OP, MFLAG, STTYPE, ESIZE, TYPE, ADDRFN, WB) \ void HELPER(mve_##OP)(CPUARMState *env, void *vd, void *vm, \ uint32_t base) \ { \ @@ -255,13 +255,15 @@ DO_VSTR(vstrh_w, MO_TEUW, 2, stw, 4, int32_t) uint16_t eci_mask =3D mve_eci_mask(env); \ unsigned e; \ uint32_t addr; \ + int mmu_idx =3D arm_to_core_mmu_idx(arm_mmu_idx(env)); \ + MemOpIdx oi =3D make_memop_idx(MFLAG | MO_ALIGN, mmu_idx); \ for (e =3D 0; e < 16 / ESIZE; e++, mask >>=3D ESIZE, eci_mask >>= =3D ESIZE) { \ if (!(eci_mask & 1)) { \ continue; \ } \ addr =3D ADDRFN(base, m[H##ESIZE(e)]); \ if (mask & 1) { \ - cpu_##STTYPE##_data_ra(env, addr, d[H##ESIZE(e)], GETPC())= ; \ + cpu_##STTYPE##_mmu(env, addr, d[H##ESIZE(e)], oi, GETPC())= ; \ } \ if (WB) { \ m[H##ESIZE(e)] =3D addr; \ @@ -314,6 +316,8 @@ DO_VSTR(vstrh_w, MO_TEUW, 2, stw, 4, int32_t) uint16_t eci_mask =3D mve_eci_mask(env); \ unsigned e; \ uint32_t addr; \ + int mmu_idx =3D arm_to_core_mmu_idx(arm_mmu_idx(env)); \ + MemOpIdx oi =3D make_memop_idx(MO_TEUL | MO_ALIGN, mmu_idx); \ for (e =3D 0; e < 16 / 4; e++, mask >>=3D 4, eci_mask >>=3D 4) { = \ if (!(eci_mask & 1)) { \ continue; \ @@ -321,7 +325,7 @@ DO_VSTR(vstrh_w, MO_TEUW, 2, stw, 4, int32_t) addr =3D ADDRFN(base, m[H4(e & ~1)]); \ addr +=3D 4 * (e & 1); \ if (mask & 1) { \ - cpu_stl_data_ra(env, addr, d[H4(e)], GETPC()); \ + cpu_stl_mmu(env, addr, d[H4(e)], oi, GETPC()); \ } \ if (WB && (e & 1)) { \ m[H4(e & ~1)] =3D addr - 4; \ @@ -357,22 +361,22 @@ DO_VLDR_SG(vldrw_sg_os_uw, MO_TEUL, uint32_t, ldl, 4, uint32_t, uint32_t, ADDR_ADD_OSW, false) DO_VLDR64_SG(vldrd_sg_os_ud, ADDR_ADD_OSD, false) =20 -DO_VSTR_SG(vstrb_sg_ub, stb, 1, uint8_t, ADDR_ADD, false) -DO_VSTR_SG(vstrb_sg_uh, stb, 2, uint16_t, ADDR_ADD, false) -DO_VSTR_SG(vstrb_sg_uw, stb, 4, uint32_t, ADDR_ADD, false) -DO_VSTR_SG(vstrh_sg_uh, stw, 2, uint16_t, ADDR_ADD, false) -DO_VSTR_SG(vstrh_sg_uw, stw, 4, uint32_t, ADDR_ADD, false) -DO_VSTR_SG(vstrw_sg_uw, stl, 4, uint32_t, ADDR_ADD, false) +DO_VSTR_SG(vstrb_sg_ub, MO_UB, stb, 1, uint8_t, ADDR_ADD, false) +DO_VSTR_SG(vstrb_sg_uh, MO_UB, stb, 2, uint16_t, ADDR_ADD, false) +DO_VSTR_SG(vstrb_sg_uw, MO_UB, stb, 4, uint32_t, ADDR_ADD, false) +DO_VSTR_SG(vstrh_sg_uh, MO_TEUW, stw, 2, uint16_t, ADDR_ADD, false) +DO_VSTR_SG(vstrh_sg_uw, MO_TEUW, stw, 4, uint32_t, ADDR_ADD, false) +DO_VSTR_SG(vstrw_sg_uw, MO_TEUL, stl, 4, uint32_t, ADDR_ADD, false) DO_VSTR64_SG(vstrd_sg_ud, ADDR_ADD, false) =20 -DO_VSTR_SG(vstrh_sg_os_uh, stw, 2, uint16_t, ADDR_ADD_OSH, false) -DO_VSTR_SG(vstrh_sg_os_uw, stw, 4, uint32_t, ADDR_ADD_OSH, false) -DO_VSTR_SG(vstrw_sg_os_uw, stl, 4, uint32_t, ADDR_ADD_OSW, false) +DO_VSTR_SG(vstrh_sg_os_uh, MO_TEUW, stw, 2, uint16_t, ADDR_ADD_OSH, false) +DO_VSTR_SG(vstrh_sg_os_uw, MO_TEUW, stw, 4, uint32_t, ADDR_ADD_OSH, false) +DO_VSTR_SG(vstrw_sg_os_uw, MO_TEUL, stl, 4, uint32_t, ADDR_ADD_OSW, false) DO_VSTR64_SG(vstrd_sg_os_ud, ADDR_ADD_OSD, false) =20 DO_VLDR_SG(vldrw_sg_wb_uw, MO_TEUL, uint32_t, ldl, 4, uint32_t, uint32_t, = ADDR_ADD, true) DO_VLDR64_SG(vldrd_sg_wb_ud, ADDR_ADD, true) -DO_VSTR_SG(vstrw_sg_wb_uw, stl, 4, uint32_t, ADDR_ADD, true) +DO_VSTR_SG(vstrw_sg_wb_uw, MO_TEUL, stl, 4, uint32_t, ADDR_ADD, true) DO_VSTR64_SG(vstrd_sg_wb_ud, ADDR_ADD, true) =20 /* --=20 2.48.1 From nobody Sat Nov 15 12:39:23 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1751533054; cv=none; d=zohomail.com; s=zohoarc; b=ULW3+eOBYPyBzMoaArTftHhqqSkr78mPS8QHlI8gHRyIRIZchW9PdH2BpX5VpiIh7l8M4tqXyJkf/bNkpQsLIIUq5GUtSIKE30zlCRqTOa6qOFsjy+AukU6OEz6TYIq40bBacq7/zykfD2mCeGXXGc/RBe4TiLhcfSkNLikvScw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1751533054; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=vlweHpW5fp62HujQOYN5IEIifrxslp9W9q5Rd++5zyE=; b=bsd2v+ecG6dmEPzpg6bD8CV9JsPXSfXikMCKCBjbcZjd55Do9hwA9kwJK5m75DLEL3ZX0wPNjDewWrqnjVQohvZku2WaTquUxW6hMB37AfisTBgUtuOl9IOpXgorUlzw04gevF/S55SAfR1Td+DGdxX43/4Hzr8HkjmC7Ugtxu8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1751533054556427.84291777131614; Thu, 3 Jul 2025 01:57:34 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uXFkk-0003El-EJ; Thu, 03 Jul 2025 04:57:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uXFkW-0002wL-0M; Thu, 03 Jul 2025 04:56:57 -0400 Received: from mail-pl1-x635.google.com ([2607:f8b0:4864:20::635]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uXFkU-0008DQ-2B; Thu, 03 Jul 2025 04:56:55 -0400 Received: by mail-pl1-x635.google.com with SMTP id d9443c01a7336-235f9ea8d08so72315825ad.1; Thu, 03 Jul 2025 01:56:53 -0700 (PDT) Received: from localhost (pa49-178-74-199.pa.nsw.optusnet.com.au. [49.178.74.199]) by smtp.gmail.com with UTF8SMTPSA id d9443c01a7336-23acb2f2569sm157045585ad.64.2025.07.03.01.56.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Jul 2025 01:56:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1751533012; x=1752137812; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=vlweHpW5fp62HujQOYN5IEIifrxslp9W9q5Rd++5zyE=; b=U3pmi3rk7rKJ2BvE+wwT3XSPROk8bjGHUmtKYObdZCxmp5ao1yt9zy+k5iFukD6jws FnohXfM+u0GDcrLzWAfUMuVv2Xbeq/TweEJQ8u4el5wbmBa1iK1daRLks8L7poJTjdTy meU/3lsaS0U4vDJKElafioeAZKTSQzkl+34jIeZDpRw5LLGTWVb2a4PIIOSifdbN8p4s Kw2hkKTqfqCjcUI8X2CeuoFLt3MCMoWzt2ZVasyz0BOIjLljzxw7+0lzAhxVLSFCWOwb DyNJKTky5LpbCbtEhQSkwm2Cnw2FSLfuMnQJW/hOCbNSdU/OlHqlWJzA9stDoSuMStU7 4YwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751533012; x=1752137812; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vlweHpW5fp62HujQOYN5IEIifrxslp9W9q5Rd++5zyE=; b=Lx1ZobtFJmYbBtykMTUVP4gktPk79UlLNYF+0LKeH9SJovF6KiS4V9H/v96CoHIxrX 4Mg8UTSHk0zpa++46N4KruPJ02n90Goliket2jkRxHAeqC9zmCBkpfE4iLbLQY5pnYPM ALEBf+ICH2SKav4wWLEPaIIO9IbAIDQ65PJIb8IbZV+fFF/mK/YgPPASvOLw1E4motzR +rVWzkyXUEcJt4jCWjqKgs/NeeAeDn6R1D2FHg/4+4CoEoRxxsI/Rx7Garn19ZSyLdjD CUG7S1Gq8obUCZKpRzy1s80/JEZhyuowbfuUMtW1ZRLu6kk/x2LbXpoXSYn6vW3pv58h d8IA== X-Forwarded-Encrypted: i=1; AJvYcCWegqcEJa1pb3Pgdv5lUkJpY3WaAoCX8kVJEVR2eTCWsaXHPXVgtUGpXi4y1G2B9MHnnuaQTtcHzw==@nongnu.org X-Gm-Message-State: AOJu0YwFAL9ErLEFGPbP7VEOud1yVPE3TMAQkPaiIwwIm9U1BELYS80K Ylp67UaMhZMw5P2SJRZpp4bca/JTfGS/eh9JD0sxPrCrnbiDPPA0hEOQth0CCoRpjFo= X-Gm-Gg: ASbGncvN3wBIfeFyhvX7wYoUIphHgMq5bzjOm5DkZcHL81GXYBhVgD0sb8yLohUY4p6 +pA/ckBFCp1qPJiWQYZWaKLTPgb3gfvgai1IAM99SAOfB0t6/GD7ZGu/2FpmvCvuQo7WCKqcnlV bQzkSc6/pCVY7BAhRkmF0fPgCVyJCL84jhSZM3hofQMYsUzcogrJAVJ/074P8C5Fb7z1Txo53Q9 f03Encj6d8Wt4/4A9EGeWPaeoKlpYBG7p2APHM7hBeQVygxoq4Er3jD7e6bj9D7W6mIgjWjZtNh ZJ5/oNSxMtbnnDQ+aIJaViz16KmcOj2bb5OoopAk3x2YmIDsHG5ntMFRTdLRvgwh9K7AjhMTPEk UexpgyC8HktWC8nEdj04Q0Y3GZSEbIk844d5RkWkoMNI= X-Google-Smtp-Source: AGHT+IFQzip9lbsYdcynhldNUXjJdq7jRyo6hd0xt79MhSICX8f7gTN5nz2beMJIHLqqTzwHpQ4Aiw== X-Received: by 2002:a17:903:985:b0:22e:6cc6:cf77 with SMTP id d9443c01a7336-23c6e5e2804mr107805445ad.53.1751533011822; Thu, 03 Jul 2025 01:56:51 -0700 (PDT) From: William Kosasih To: qemu-devel@nongnu.org Cc: Peter Maydell , qemu-arm@nongnu.org, Richard Henderson , William Kosasih Subject: [PATCH v4 08/11] target/arm: Fix VLD4 helper load alignment checks Date: Thu, 3 Jul 2025 18:26:01 +0930 Message-ID: <20250703085604.154449-9-kosasihwilliam4@gmail.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250703085604.154449-1-kosasihwilliam4@gmail.com> References: <20250703085604.154449-1-kosasihwilliam4@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::635; envelope-from=kosasihwilliam4@gmail.com; helo=mail-pl1-x635.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1751533056235116600 Content-Type: text/plain; charset="utf-8" This patch adds alignment checks in the load operations in the VLD4 instruction. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1154 Signed-off-by: William Kosasih Reviewed-by: Richard Henderson --- target/arm/tcg/mve_helper.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/target/arm/tcg/mve_helper.c b/target/arm/tcg/mve_helper.c index 2d21625f24..7069910db4 100644 --- a/target/arm/tcg/mve_helper.c +++ b/target/arm/tcg/mve_helper.c @@ -403,13 +403,15 @@ DO_VSTR64_SG(vstrd_sg_wb_ud, ADDR_ADD, true) uint16_t mask =3D mve_eci_mask(env); \ static const uint8_t off[4] =3D { O1, O2, O3, O4 }; \ uint32_t addr, data; \ + int mmu_idx =3D arm_to_core_mmu_idx(arm_mmu_idx(env)); \ + MemOpIdx oi =3D make_memop_idx(MO_TEUL | MO_ALIGN, mmu_idx); \ for (beat =3D 0; beat < 4; beat++, mask >>=3D 4) { = \ if ((mask & 1) =3D=3D 0) { = \ /* ECI says skip this beat */ \ continue; \ } \ addr =3D base + off[beat] * 4; \ - data =3D cpu_ldl_le_data_ra(env, addr, GETPC()); \ + data =3D cpu_ldl_mmu(env, addr, oi, GETPC()); \ for (e =3D 0; e < 4; e++, data >>=3D 8) { = \ uint8_t *qd =3D (uint8_t *)aa32_vfp_qreg(env, qnidx + e); \ qd[H1(off[beat])] =3D data; \ @@ -427,13 +429,15 @@ DO_VSTR64_SG(vstrd_sg_wb_ud, ADDR_ADD, true) uint32_t addr, data; \ int y; /* y counts 0 2 0 2 */ \ uint16_t *qd; \ + int mmu_idx =3D arm_to_core_mmu_idx(arm_mmu_idx(env)); \ + MemOpIdx oi =3D make_memop_idx(MO_TEUL | MO_ALIGN, mmu_idx); \ for (beat =3D 0, y =3D 0; beat < 4; beat++, mask >>=3D 4, y ^=3D 2= ) { \ if ((mask & 1) =3D=3D 0) { = \ /* ECI says skip this beat */ \ continue; \ } \ addr =3D base + off[beat] * 8 + (beat & 1) * 4; \ - data =3D cpu_ldl_le_data_ra(env, addr, GETPC()); \ + data =3D cpu_ldl_mmu(env, addr, oi, GETPC()); \ qd =3D (uint16_t *)aa32_vfp_qreg(env, qnidx + y); \ qd[H2(off[beat])] =3D data; \ data >>=3D 16; \ @@ -452,13 +456,15 @@ DO_VSTR64_SG(vstrd_sg_wb_ud, ADDR_ADD, true) uint32_t addr, data; \ uint32_t *qd; \ int y; \ + int mmu_idx =3D arm_to_core_mmu_idx(arm_mmu_idx(env)); \ + MemOpIdx oi =3D make_memop_idx(MO_TEUL | MO_ALIGN, mmu_idx); \ for (beat =3D 0; beat < 4; beat++, mask >>=3D 4) { = \ if ((mask & 1) =3D=3D 0) { = \ /* ECI says skip this beat */ \ continue; \ } \ addr =3D base + off[beat] * 4; \ - data =3D cpu_ldl_le_data_ra(env, addr, GETPC()); \ + data =3D cpu_ldl_mmu(env, addr, oi, GETPC()); \ y =3D (beat + (O1 & 2)) & 3; \ qd =3D (uint32_t *)aa32_vfp_qreg(env, qnidx + y); \ qd[H4(off[beat] >> 2)] =3D data; \ --=20 2.48.1 From nobody Sat Nov 15 12:39:23 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1751533077; cv=none; d=zohomail.com; s=zohoarc; b=RPL9N31XapRU8Z0/h49VndFM9yrGuxhhIMETzWNNYRYAaAMCGZtauRm7glMbs8bsPr+cOIk1QYmeCl4tbRZv2HAM/mwph0oy8opi9No4QYVEW6rWnhe/id/vu5sne6WF4FDGKq65PuZ5B+ur4vP31e01X9AbHQo9daxboPZHgw8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1751533077; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=b7zaRZf5bnnSsSyEzbbs1xqvJInRW9QsQLxNL2OOGn4=; b=fu8BJDXrktVF5pr6mO4ryktYjOSlx+8PEL7MJr1/7UTXkk16qihOt6O6Q77t/6nCaj6Cizq1KKZg/FsalGYsDJhNVteWMmlTlZSWcMXt7vLQRbcwx7xbA/A6p7iYgRsRUDZyG3CEaHQw+GDa0+xN3N9xa4EbHlmb5NrLpoMTXVQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1751533077018471.77931463282164; Thu, 3 Jul 2025 01:57:57 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uXFkk-0003Fd-O5; Thu, 03 Jul 2025 04:57:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uXFkc-00033n-JB; Thu, 03 Jul 2025 04:57:05 -0400 Received: from mail-pl1-x62e.google.com ([2607:f8b0:4864:20::62e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uXFkZ-0008F2-Nb; Thu, 03 Jul 2025 04:57:01 -0400 Received: by mail-pl1-x62e.google.com with SMTP id d9443c01a7336-22c33677183so67889105ad.2; Thu, 03 Jul 2025 01:56:58 -0700 (PDT) Received: from localhost (pa49-178-74-199.pa.nsw.optusnet.com.au. [49.178.74.199]) by smtp.gmail.com with UTF8SMTPSA id d9443c01a7336-23acb39ba8esm156083505ad.129.2025.07.03.01.56.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Jul 2025 01:56:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1751533017; x=1752137817; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=b7zaRZf5bnnSsSyEzbbs1xqvJInRW9QsQLxNL2OOGn4=; b=EW6Jb6tof40kKUhrXHXqgaT2441iwE39I7LT+1Q5s/ac/FxjhLMTTZCXZ6wmx/8eh2 oPk5LZxeP7LOY1mMt/lRkM6xZgbPxeedDX2S7qwNaP+3uCcZomdXbeO1Vvhm0trq3XI4 Tiltw+qG+XuN5T8cZPBJrQbtFgnmMlRBkvd5/Htyd5kU6quicisuyEUbmeVaEl42BcP4 usSDdD5X12XJ7uh03FkI5shYiNH1P2FNQbDOqUsaIuKoGOzfDEy0LvP5MXD0Sl+92JGD D1ueB/P3WxW3XpyLVa2muAoHrhZWf4Tn7bSuHEHdv2tv9EIAqV2CTIoYdffw7xH8lPiv 12wA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751533017; x=1752137817; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=b7zaRZf5bnnSsSyEzbbs1xqvJInRW9QsQLxNL2OOGn4=; b=CeIeoV04B+JL5Oe/h+sKSdAWUazYPnqAe/ud0EJMT9KiKSkjHXLeOXyUnRoxVk3Whn NJLAbd5P6x/r6Y+12yK7fnk6a8+wT6LIsZQKrKOe1HH0lZTHaseGvuJ/dvlpnnjSeusZ 7FxWln4i5n61wa26V9Id5qKllDjUBaCmsiPk/vEupPYC/9aQ2iCzmETpTf5hE+f8Accj 4+ESNRIAHql1wrHsQIbQxh+8bqErGhnObriBj0ZFitCvwNlgL8Cq0dJhKWItXK8/svt+ dboCDkcfF8lvsJAfztuGzyZWfv2m7/7siHMRGtDTqGyh/VafqFLZ883MKp+pAEmu3bfE bFOQ== X-Forwarded-Encrypted: i=1; AJvYcCUGvGlSbXLFoUWkLvhw+B65ku3ELFAP9BzrQe4wS6AJvqVIe9O1AOqN2v0bG5olOqF17u0lwXAMYw==@nongnu.org X-Gm-Message-State: AOJu0YwhncmELB/MzjEZKPcEWTJlV5XPxbfIM/LluNSYHL8AxXnmqoi9 AB9hXi2SCExYcnI1UYYlFKT5nylOTOOwnTr5/5Yikc/g6iELNm5S/2oCSQEtxug9cXM= X-Gm-Gg: ASbGnctVas/5CTQdbeeqc7filaO1IDX5nZrvrUHgeIfH+nMM5wPm9oPObpyIt0FtLJ7 1AyeA74ZxYTAC+LZ+5YUbemPwJ2oEif3zbeFK9WERUejt8OCPxlEJxFM2rDcB8n5N6ZFb5EEBnz 4W3Dcpl5IlYmIqXyrfz2lzHQcBPQ4TN1cV0H1NP3aM82ghIRWr0rP7FNqtFklnlyEeBqvw4zRsy pBXK61tO8nUCLAbJHO51GlNBN45mkVaPemvgsRkdWglc7dg0Sn2OvraT8ucvK0Zni/0dVN5aZsH CxwBQ+upCtedwHPBgw+OuIcewyPZEGuN66J0ve/y12PwKEvfvrvyYLYxTXVPwgE+Tr/PKW6/4Y2 agQ0JCMX8oU0oFbkOLXex3MTQWt0I4PUa94yj3YjXfZI= X-Google-Smtp-Source: AGHT+IF1YYK+ZcCQPqld796dIS7GQZoWSC91zw+gnf3FZSLwG6YZMNUN0hwV7bxjfZ65SjwsXNzFWg== X-Received: by 2002:a17:903:2f4b:b0:234:c22:c612 with SMTP id d9443c01a7336-23c79819a3emr40017035ad.43.1751533017483; Thu, 03 Jul 2025 01:56:57 -0700 (PDT) From: William Kosasih To: qemu-devel@nongnu.org Cc: Peter Maydell , qemu-arm@nongnu.org, Richard Henderson , William Kosasih Subject: [PATCH v4 09/11] target/arm: Fix VLD2 helper load alignment checks Date: Thu, 3 Jul 2025 18:26:02 +0930 Message-ID: <20250703085604.154449-10-kosasihwilliam4@gmail.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250703085604.154449-1-kosasihwilliam4@gmail.com> References: <20250703085604.154449-1-kosasihwilliam4@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::62e; envelope-from=kosasihwilliam4@gmail.com; helo=mail-pl1-x62e.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1751533078531116600 Content-Type: text/plain; charset="utf-8" This patch adds alignment checks in the load operations in the VLD2 instruction. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1154 Signed-off-by: William Kosasih Reviewed-by: Richard Henderson --- target/arm/tcg/mve_helper.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/target/arm/tcg/mve_helper.c b/target/arm/tcg/mve_helper.c index 7069910db4..7473dfad2d 100644 --- a/target/arm/tcg/mve_helper.c +++ b/target/arm/tcg/mve_helper.c @@ -495,13 +495,15 @@ DO_VLD4W(vld43w, 6, 7, 8, 9) static const uint8_t off[4] =3D { O1, O2, O3, O4 }; \ uint32_t addr, data; \ uint8_t *qd; \ + int mmu_idx =3D arm_to_core_mmu_idx(arm_mmu_idx(env)); \ + MemOpIdx oi =3D make_memop_idx(MO_TEUL | MO_ALIGN, mmu_idx); \ for (beat =3D 0; beat < 4; beat++, mask >>=3D 4) { = \ if ((mask & 1) =3D=3D 0) { = \ /* ECI says skip this beat */ \ continue; \ } \ addr =3D base + off[beat] * 2; \ - data =3D cpu_ldl_le_data_ra(env, addr, GETPC()); \ + data =3D cpu_ldl_mmu(env, addr, oi, GETPC()); \ for (e =3D 0; e < 4; e++, data >>=3D 8) { = \ qd =3D (uint8_t *)aa32_vfp_qreg(env, qnidx + (e & 1)); \ qd[H1(off[beat] + (e >> 1))] =3D data; \ @@ -519,13 +521,15 @@ DO_VLD4W(vld43w, 6, 7, 8, 9) uint32_t addr, data; \ int e; \ uint16_t *qd; \ + int mmu_idx =3D arm_to_core_mmu_idx(arm_mmu_idx(env)); \ + MemOpIdx oi =3D make_memop_idx(MO_TEUL | MO_ALIGN, mmu_idx); \ for (beat =3D 0; beat < 4; beat++, mask >>=3D 4) { = \ if ((mask & 1) =3D=3D 0) { = \ /* ECI says skip this beat */ \ continue; \ } \ addr =3D base + off[beat] * 4; \ - data =3D cpu_ldl_le_data_ra(env, addr, GETPC()); \ + data =3D cpu_ldl_mmu(env, addr, oi, GETPC()); \ for (e =3D 0; e < 2; e++, data >>=3D 16) { = \ qd =3D (uint16_t *)aa32_vfp_qreg(env, qnidx + e); \ qd[H2(off[beat])] =3D data; \ @@ -542,13 +546,15 @@ DO_VLD4W(vld43w, 6, 7, 8, 9) static const uint8_t off[4] =3D { O1, O2, O3, O4 }; \ uint32_t addr, data; \ uint32_t *qd; \ + int mmu_idx =3D arm_to_core_mmu_idx(arm_mmu_idx(env)); \ + MemOpIdx oi =3D make_memop_idx(MO_TEUL | MO_ALIGN, mmu_idx); \ for (beat =3D 0; beat < 4; beat++, mask >>=3D 4) { = \ if ((mask & 1) =3D=3D 0) { = \ /* ECI says skip this beat */ \ continue; \ } \ addr =3D base + off[beat]; \ - data =3D cpu_ldl_le_data_ra(env, addr, GETPC()); \ + data =3D cpu_ldl_mmu(env, addr, oi, GETPC()); \ qd =3D (uint32_t *)aa32_vfp_qreg(env, qnidx + (beat & 1)); \ qd[H4(off[beat] >> 3)] =3D data; \ } \ --=20 2.48.1 From nobody Sat Nov 15 12:39:23 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1751533113; cv=none; d=zohomail.com; s=zohoarc; b=YBRpy6BVYbyWPwdossUiTu6oZNW9p8p87uFtTruR9dHngEfEhRJTfX9KuhJN00wUC6BVykDPc6xp8Tb2/fBfI0aV6tK2rwMvFGfULCyeYKWhtbget1vdCL8fLGMajY4/nJaFwAK8yFNi1Y3Ze7WVgGVKJ1Z2LRfnryZ426NleXM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1751533113; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=iyFUAaglgtudCcm/+GaLUiopNJBnEFOWo2eTOT6yB94=; b=CMcM42RXeMdaI+j8P277r8grmtVzVo7OKlUOJZHFVzG0Zxzpv4y4zOWvtwO/iPKqycszX2L6DuNgs+3/KX2Z3sVXhDPlLc3S2BplqodLvtO/X4h4KXd6fSgek6cmrWC1Um7Da2nhTQaacigD+wuvTtQPX5C+4z2y7j6SqUFArHo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1751533113865476.9102199467344; Thu, 3 Jul 2025 01:58:33 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uXFkl-0003Ix-Kl; Thu, 03 Jul 2025 04:57:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uXFkg-00038M-U9; Thu, 03 Jul 2025 04:57:08 -0400 Received: from mail-pf1-x42d.google.com ([2607:f8b0:4864:20::42d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uXFkf-0008GH-1Z; Thu, 03 Jul 2025 04:57:06 -0400 Received: by mail-pf1-x42d.google.com with SMTP id d2e1a72fcca58-74af4af04fdso580193b3a.1; Thu, 03 Jul 2025 01:57:03 -0700 (PDT) Received: from localhost (pa49-178-74-199.pa.nsw.optusnet.com.au. [49.178.74.199]) by smtp.gmail.com with UTF8SMTPSA id d2e1a72fcca58-74af55c6c67sm16731730b3a.110.2025.07.03.01.57.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Jul 2025 01:57:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1751533022; x=1752137822; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=iyFUAaglgtudCcm/+GaLUiopNJBnEFOWo2eTOT6yB94=; b=e8VDtZbuK3J8i1UDixoDdWwNAS1UKJjzZqLhTOwCFesXRtK9ueDgthkUTh+sg+GhUg brcvh+2tu6073O3wBbT1RoICNwWY/hTuiuWVX/lYAoxbEfR7wcZW1/VP6adWTmZcEbVh AGgi4aGTb0goYYgHF0kp8eC0UwzxzHjRiQrcFeJdUAYybv8dmTHoyZA+giYb1sEJRRL1 MCxSm+IGp09RHiiT77226ybf68FHLpb9zieNouehoHTJGM175/UU53FXhmwLK2HFnEGr rSV5qkZkcCTHqT6Y0NlBxoKxn+1tnJNRK+HswoDvkwTNdTM13Yzb143Ytu4S54+Ig9UH 9xAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751533022; x=1752137822; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=iyFUAaglgtudCcm/+GaLUiopNJBnEFOWo2eTOT6yB94=; b=Ke8K0DUdPSou9HheaqQJkXFbqBzRK0YylV/EkZUSTxuzJL7Wy50UlGkoLmspoTmr41 6mavKnU7dTATzQYlCrZnV77htOJCsD95j8MSErWkXZTt9znaJMx4Ii511F9sntnJKP47 fJwki1M/d48OqKb4af0K9/bGBcSzLjD9EI+iTmK60iN9j6rRKT8HJNgbxCRqViGUphZr pO/T/BsxDXpbf/pupB0QnMue9mrj3OcSIvhGe1jJKYo+QH5BSAe1Vvm5MZuBsrGyHkdj BPT8fEjvg5VKeCF1chO1aqj7EIz1V1Pb+JOHso6qcaVHr4XN8yTA0jWwnLKsVt6wtqos HQ0Q== X-Forwarded-Encrypted: i=1; AJvYcCVH7uZQkuOEkolY4k5nmHbjnjHR5K6ZfmvqMq3pcKjI+TnlJu6ORNayupMIvAJ1l33LB35Ljn3ifQ==@nongnu.org X-Gm-Message-State: AOJu0YxKdr03ic29qKkfNxj7uHO8BNqoGTGk9d6TBs/96v3CBv3D53l6 a/A6NK20FaTN3vQqRyfQ2n+fZpYDuu0/njqZCQtwqQYnMxL67aXWY+5ZK89jaJNK6GU= X-Gm-Gg: ASbGncstC5Oifm57euXZgmSHywtsSQHOaf0XE7vBHVaqnI48gmjiuhrrvoe7dcqVuVS OB5RviOl0eGaQSwOob3EWQAFLPIKUbyO6YHjZehY4vgE2Sd6GkGmgNaZUP9XbXlTHf4CrwNbsWz FDj7tELk6IuVhhIKya1PaIWj58w+ljmtTSLBbopIC3x1ByeK4msCAYUaEnf+uHDIzCbxwTAkudT 3orwhJ15DEpLWzR+XuegQBP+5awllG/JrZYwrChObsY/z4Puj+VSWJMxEHrECHz3wuLZMfYt5UG 4tTHdlHhiVDN0t05LU3vAYftOxilShOKEFKoG9P2EmjJIBjlBgGVtLfN28nIR2EK2NUDUxow7/I 8ZxzLze3Y7SG6fx5OoZd1PC9uU0twen2ZRrFfkbv+ftY= X-Google-Smtp-Source: AGHT+IGVqC6rlaJoZsXBTHg2cNBDmewf6YP15GdCmVNKi4cnHH8ZLlI2921i/sWg9w8IpyMUWaeiwA== X-Received: by 2002:a05:6a21:999e:b0:1f3:3547:f21b with SMTP id adf61e73a8af0-22487aa74b0mr2219578637.5.1751533022148; Thu, 03 Jul 2025 01:57:02 -0700 (PDT) From: William Kosasih To: qemu-devel@nongnu.org Cc: Peter Maydell , qemu-arm@nongnu.org, Richard Henderson , William Kosasih Subject: [PATCH v4 10/11] target/arm: Fix VST4 helper store alignment checks Date: Thu, 3 Jul 2025 18:26:03 +0930 Message-ID: <20250703085604.154449-11-kosasihwilliam4@gmail.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250703085604.154449-1-kosasihwilliam4@gmail.com> References: <20250703085604.154449-1-kosasihwilliam4@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::42d; envelope-from=kosasihwilliam4@gmail.com; helo=mail-pf1-x42d.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1751533114927116600 Content-Type: text/plain; charset="utf-8" This patch adds alignment checks in the store operations in the VST4 instruction. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1154 Signed-off-by: William Kosasih Reviewed-by: Richard Henderson --- target/arm/tcg/mve_helper.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/target/arm/tcg/mve_helper.c b/target/arm/tcg/mve_helper.c index 7473dfad2d..5273411389 100644 --- a/target/arm/tcg/mve_helper.c +++ b/target/arm/tcg/mve_helper.c @@ -577,6 +577,8 @@ DO_VLD2W(vld21w, 8, 12, 16, 20) uint16_t mask =3D mve_eci_mask(env); \ static const uint8_t off[4] =3D { O1, O2, O3, O4 }; \ uint32_t addr, data; \ + int mmu_idx =3D arm_to_core_mmu_idx(arm_mmu_idx(env)); \ + MemOpIdx oi =3D make_memop_idx(MO_TEUL | MO_ALIGN, mmu_idx); \ for (beat =3D 0; beat < 4; beat++, mask >>=3D 4) { = \ if ((mask & 1) =3D=3D 0) { = \ /* ECI says skip this beat */ \ @@ -588,7 +590,7 @@ DO_VLD2W(vld21w, 8, 12, 16, 20) uint8_t *qd =3D (uint8_t *)aa32_vfp_qreg(env, qnidx + e); \ data =3D (data << 8) | qd[H1(off[beat])]; \ } \ - cpu_stl_le_data_ra(env, addr, data, GETPC()); \ + cpu_stl_mmu(env, addr, data, oi, GETPC()); \ } \ } =20 @@ -602,6 +604,8 @@ DO_VLD2W(vld21w, 8, 12, 16, 20) uint32_t addr, data; \ int y; /* y counts 0 2 0 2 */ \ uint16_t *qd; \ + int mmu_idx =3D arm_to_core_mmu_idx(arm_mmu_idx(env)); \ + MemOpIdx oi =3D make_memop_idx(MO_TEUL | MO_ALIGN, mmu_idx); \ for (beat =3D 0, y =3D 0; beat < 4; beat++, mask >>=3D 4, y ^=3D 2= ) { \ if ((mask & 1) =3D=3D 0) { = \ /* ECI says skip this beat */ \ @@ -612,7 +616,7 @@ DO_VLD2W(vld21w, 8, 12, 16, 20) data =3D qd[H2(off[beat])]; \ qd =3D (uint16_t *)aa32_vfp_qreg(env, qnidx + y + 1); \ data |=3D qd[H2(off[beat])] << 16; \ - cpu_stl_le_data_ra(env, addr, data, GETPC()); \ + cpu_stl_mmu(env, addr, data, oi, GETPC()); \ } \ } =20 @@ -626,6 +630,8 @@ DO_VLD2W(vld21w, 8, 12, 16, 20) uint32_t addr, data; \ uint32_t *qd; \ int y; \ + int mmu_idx =3D arm_to_core_mmu_idx(arm_mmu_idx(env)); \ + MemOpIdx oi =3D make_memop_idx(MO_TEUL | MO_ALIGN, mmu_idx); \ for (beat =3D 0; beat < 4; beat++, mask >>=3D 4) { = \ if ((mask & 1) =3D=3D 0) { = \ /* ECI says skip this beat */ \ @@ -635,7 +641,7 @@ DO_VLD2W(vld21w, 8, 12, 16, 20) y =3D (beat + (O1 & 2)) & 3; \ qd =3D (uint32_t *)aa32_vfp_qreg(env, qnidx + y); \ data =3D qd[H4(off[beat] >> 2)]; \ - cpu_stl_le_data_ra(env, addr, data, GETPC()); \ + cpu_stl_mmu(env, addr, data, oi, GETPC()); \ } \ } =20 --=20 2.48.1 From nobody Sat Nov 15 12:39:23 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1751533106; cv=none; d=zohomail.com; s=zohoarc; b=SSu5SObBlmYIDpO9kFgC2FUOzmR6NldjKJ0yqf4QljQIk89DsFdz2PIe5HqLNxcZvXHffhRrVepX0fBVBdWgM4iPECAqODMyOVB9u3jzyBpmvvipEAQF9v0Kyr5uLn+676Pm3AZMH/kP+RLkrdolpDirCna3eQyi9qJJbhCJ+jY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1751533106; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=TdpPRtQvmGX5FMXgJZ9zxoWkisAb+D1p74rPq+2zohI=; b=L67y63Wth9LqCLFoDboJgp47gOpYMg/UkBWKRB5NiHsZFH7xK2Wxkqg0ufIRLWmbOGLz+YqYCpuovTx52FLr/R5FzDUf2+zgFXqAd98SAbbvS+6Zz8QIGgS6Th6P0/UKEMK5dcTFMqc1l8sGZZkJMzRJKx6ZjZOO6f8b0XsMPHI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1751533106470936.8945155350535; Thu, 3 Jul 2025 01:58:26 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uXFkt-0003gT-SQ; Thu, 03 Jul 2025 04:57:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uXFkn-0003TU-4T; Thu, 03 Jul 2025 04:57:13 -0400 Received: from mail-pf1-x42d.google.com ([2607:f8b0:4864:20::42d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uXFkk-0008HL-Dg; Thu, 03 Jul 2025 04:57:12 -0400 Received: by mail-pf1-x42d.google.com with SMTP id d2e1a72fcca58-742c7a52e97so7473886b3a.3; Thu, 03 Jul 2025 01:57:08 -0700 (PDT) Received: from localhost (pa49-178-74-199.pa.nsw.optusnet.com.au. [49.178.74.199]) by smtp.gmail.com with UTF8SMTPSA id d2e1a72fcca58-74af557790dsm16476366b3a.100.2025.07.03.01.57.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Jul 2025 01:57:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1751533027; x=1752137827; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=TdpPRtQvmGX5FMXgJZ9zxoWkisAb+D1p74rPq+2zohI=; b=XekqtNL6GOgCFT5wR45UNgAccRX7OceNTYfxrW1p9ql5x0DJ/me2R++0GWZmXHN5wa IxvjOEE1Sbhhp3gxVHe1ARafjhjs03D/lWfrA7NX69/jEcKiO/RhgZNZv84GrVbjgngI YxArWbNcpK7gKElOPj9QR7MhT+KmGDmwNgXwAKMmtw7ZZCpz385xcerr7CYv//yt0Xj0 AJmtWoDpb0hV0G8mZldURI8KXlzoPd3R3ZaX6AE0uWRiCD/rlUNeA/sl7gw9dhsx3A2O 7avRDTEbhpzBrtKtL1zn/h0qKJO+RO1hCBVxrnR5tz/yibP7yUU2IL42C2VupADQJi8D jJug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751533027; x=1752137827; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TdpPRtQvmGX5FMXgJZ9zxoWkisAb+D1p74rPq+2zohI=; b=R6+kmSu6xlFmY/hq2onzwXVK3DzJk8D5EZWAWKNGxPa/QKfLQM8ssz4gVzOFf24mWv sp+KPYA04zpumjihdY0eWIx1KicPtuUK2/ZoI90/5z3fVrymky/DzggLHFbVgm+naixh piYCkSmnm8hC1j5XtH/SZNUgzyIVdXY20NA1sOL1IPjmWQUIRSragjRbaN35oF+eBAjq XWNSWD0C7NCL6hV5nWNgr/rOuSIzeNizAWUmuaH8AMEdBZpw5smIxtGwIz7e451th9UA 2NdX4JrG497hq+9IEV143lIDLsG5+4bIm+GLI+SY6OPvqBWsjo+1vlViZlS44coecC6U X7vw== X-Forwarded-Encrypted: i=1; AJvYcCV8GLzZGm8I+tbMsPrm8FjRRQmdz/kCc6AsR8xPY+YQ1TsoljJsHl2JVsMm+2TlQNGTUs5ZglLnJw==@nongnu.org X-Gm-Message-State: AOJu0YxZZI/kq0SN+L7QpvQbXf1C2WjCkMTyrImkwsX7YMATddgo6mkX PQgy42nrK+yNZAEWnCnn9Me3Su53gecFZyXlAEq8V/Pi1OTR7EHz5kJ41YJ7qErPulk= X-Gm-Gg: ASbGnctdg2ecKqKV7Zatbx15l10f6XfrtsjHqvkiSF6V+mHyqE4obsRS1235sR9xoXk 1CYy2g1TpxEkFAtRC8ZkHdsyjIjxjhku9jHJ417AuWYLlKHuLDtIYDmZSoTLZg0xx5biHkcjhYA B355LHIpX/bZPxpQHBWQt6UtN5/iqpW49Ngjoh+o0Gu9YsQBfXwkWCtJfw1Mwu3hS76/ye5SuUV mPKHMmJvj/cjeFmILmHJuy6bgsy60sgN0OkFDktdO+5tzScRJ0mlJ+7edkCmQlJujRum15xpDf9 7V0wDt8lIsUEmSxsLcsauX/Qoc/vdnZeZIMuzsNsQ/Gg74O1i9HsVTZ1QyYIOxB991DoWokSxMr Epdxb28r1p/Yx5SRbZbU2EojB+MbZyeNI3EGg2nCRatE= X-Google-Smtp-Source: AGHT+IFbX7YcSUfog4QzLnbphQVSoqksthcJcJ548UG/PpRApEA+r8WSBFSqaCQ1O8QPkEnpFKQ58Q== X-Received: by 2002:a05:6a00:228f:b0:749:bc7:1577 with SMTP id d2e1a72fcca58-74c99830bb7mr2772559b3a.9.1751533027005; Thu, 03 Jul 2025 01:57:07 -0700 (PDT) From: William Kosasih To: qemu-devel@nongnu.org Cc: Peter Maydell , qemu-arm@nongnu.org, Richard Henderson , William Kosasih Subject: [PATCH v4 11/11] target/arm: Fix VST2 helper store alignment checks Date: Thu, 3 Jul 2025 18:26:04 +0930 Message-ID: <20250703085604.154449-12-kosasihwilliam4@gmail.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250703085604.154449-1-kosasihwilliam4@gmail.com> References: <20250703085604.154449-1-kosasihwilliam4@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::42d; envelope-from=kosasihwilliam4@gmail.com; helo=mail-pf1-x42d.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1751533106844116600 Content-Type: text/plain; charset="utf-8" This patch adds alignment checks in the store operations in the VST2 instruction. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1154 Signed-off-by: William Kosasih Reviewed-by: Richard Henderson --- target/arm/tcg/mve_helper.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/target/arm/tcg/mve_helper.c b/target/arm/tcg/mve_helper.c index 5273411389..42bb3b979b 100644 --- a/target/arm/tcg/mve_helper.c +++ b/target/arm/tcg/mve_helper.c @@ -669,6 +669,8 @@ DO_VST4W(vst43w, 6, 7, 8, 9) static const uint8_t off[4] =3D { O1, O2, O3, O4 }; \ uint32_t addr, data; \ uint8_t *qd; \ + int mmu_idx =3D arm_to_core_mmu_idx(arm_mmu_idx(env)); \ + MemOpIdx oi =3D make_memop_idx(MO_TEUL | MO_ALIGN, mmu_idx); \ for (beat =3D 0; beat < 4; beat++, mask >>=3D 4) { = \ if ((mask & 1) =3D=3D 0) { = \ /* ECI says skip this beat */ \ @@ -680,7 +682,7 @@ DO_VST4W(vst43w, 6, 7, 8, 9) qd =3D (uint8_t *)aa32_vfp_qreg(env, qnidx + (e & 1)); \ data =3D (data << 8) | qd[H1(off[beat] + (e >> 1))]; \ } \ - cpu_stl_le_data_ra(env, addr, data, GETPC()); \ + cpu_stl_mmu(env, addr, data, oi, GETPC()); \ } \ } =20 @@ -694,6 +696,8 @@ DO_VST4W(vst43w, 6, 7, 8, 9) uint32_t addr, data; \ int e; \ uint16_t *qd; \ + int mmu_idx =3D arm_to_core_mmu_idx(arm_mmu_idx(env)); \ + MemOpIdx oi =3D make_memop_idx(MO_TEUL | MO_ALIGN, mmu_idx); \ for (beat =3D 0; beat < 4; beat++, mask >>=3D 4) { = \ if ((mask & 1) =3D=3D 0) { = \ /* ECI says skip this beat */ \ @@ -705,7 +709,7 @@ DO_VST4W(vst43w, 6, 7, 8, 9) qd =3D (uint16_t *)aa32_vfp_qreg(env, qnidx + e); \ data =3D (data << 16) | qd[H2(off[beat])]; \ } \ - cpu_stl_le_data_ra(env, addr, data, GETPC()); \ + cpu_stl_mmu(env, addr, data, oi, GETPC()); \ } \ } =20 @@ -718,6 +722,8 @@ DO_VST4W(vst43w, 6, 7, 8, 9) static const uint8_t off[4] =3D { O1, O2, O3, O4 }; \ uint32_t addr, data; \ uint32_t *qd; \ + int mmu_idx =3D arm_to_core_mmu_idx(arm_mmu_idx(env)); \ + MemOpIdx oi =3D make_memop_idx(MO_TEUL | MO_ALIGN, mmu_idx); \ for (beat =3D 0; beat < 4; beat++, mask >>=3D 4) { = \ if ((mask & 1) =3D=3D 0) { = \ /* ECI says skip this beat */ \ @@ -726,7 +732,7 @@ DO_VST4W(vst43w, 6, 7, 8, 9) addr =3D base + off[beat]; \ qd =3D (uint32_t *)aa32_vfp_qreg(env, qnidx + (beat & 1)); \ data =3D qd[H4(off[beat] >> 3)]; \ - cpu_stl_le_data_ra(env, addr, data, GETPC()); \ + cpu_stl_mmu(env, addr, data, oi, GETPC()); \ } \ } =20 --=20 2.48.1