From nobody Sat Nov 15 13:20:54 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass header.i=@intel.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1751510937; cv=none; d=zohomail.com; s=zohoarc; b=MEVWRfZkWyDhcAzSB9VzTzZD+fQ/OMhzmu5dbEQoVwfPGW0Dn5t3xIaP7HhdeEZQ8crWLCT8pGUtUl7jezLCyMRDIhKnSvckJY2H/8jIdLcLadwjN7SwnWnS7mX4+GsZfIpoRdx4FYWfMriExgPGjbTX5ppPZD6TaBkPHcV8u4o= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1751510937; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=NH/448gyRvjA38EyasK7VLuGkQyqHZ2NGxL1QFN5xoM=; b=fxON/lixZe1b6IG6gdAi1dATTyvVi2POAXKEv1nVe5fx4dFDv+PnaxCHriQ1l7QVHOW4bLr1N8NiS2ymdv/Tat2LYJ8vJ0lA2XTwj8zfJAPx3Ts7OWa6rVkk1yUXo3W7RLcrL1gqhLQIpJYii40VADVZ5rqGRIF/5+d00gJr1Vs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=@intel.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 175151093741677.28291495379312; Wed, 2 Jul 2025 19:48:57 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uX9zV-0002T1-NA; Wed, 02 Jul 2025 22:48:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uX9zS-0002P0-RM for qemu-devel@nongnu.org; Wed, 02 Jul 2025 22:47:58 -0400 Received: from mgamail.intel.com ([198.175.65.15]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uX9zR-0007uj-3S for qemu-devel@nongnu.org; Wed, 02 Jul 2025 22:47:58 -0400 Received: from fmviesa007.fm.intel.com ([10.60.135.147]) by orvoesa107.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jul 2025 19:47:54 -0700 Received: from lxy-clx-4s.sh.intel.com ([10.239.48.52]) by fmviesa007.fm.intel.com with ESMTP; 02 Jul 2025 19:47:53 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1751510876; x=1783046876; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=aggi/VVoEsa3JDXqyqBaYdGUcSP9MkQM0hUW7deY3Vo=; b=Q+CSYR9wXb1yw7V2SdjMKaejXj0GGK444v1Do9DI4+MPSL8TDDXAswXW 9zb1EBtJTgtoJ9SqHrdFVeyzkxA/05Vrbp5PmmhQ6ffhhFQy8bO8vU3J7 Z6JY+MtQtwgUyNriLCthNZ6WNybrW2W/+UV0c4KoOuIuMyZs+wt2QioeO AsPBEebtv79/CKAurJQan73qmIgsu7ZzpOtba3lVEnf41asQmviE/pBmt Wz86ohM6Mlw/ANe06iIFX+2yR5eYdUnsYojrBmUg20QIwyQbSRv43k57I zVdxzwcHbxy7I4dEoANc9spdmm43fjZ9pOSC1BiEH4SNAXgLuzH4K6lq3 g==; X-CSE-ConnectionGUID: PipyiUgpQDCsjHkFSpNEqw== X-CSE-MsgGUID: n3An80AWS3ydR4gZtxOHjw== X-IronPort-AV: E=McAfee;i="6800,10657,11482"; a="57499450" X-IronPort-AV: E=Sophos;i="6.16,283,1744095600"; d="scan'208";a="57499450" X-CSE-ConnectionGUID: TVVSVLO8T1C99mG6z91B4A== X-CSE-MsgGUID: wFNQ01H+RPa0RYwA0bEPUA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,283,1744095600"; d="scan'208";a="153880358" From: Xiaoyao Li To: Paolo Bonzini Cc: Marcelo Tosatti , qemu-devel@nongnu.org, xiaoyao.li@intel.com Subject: [PATCH 1/4] i386/tdx: Remove enumeration of GetQuote in tdx_handle_get_tdvmcall_info() Date: Thu, 3 Jul 2025 10:40:17 +0800 Message-ID: <20250703024021.3559286-2-xiaoyao.li@intel.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250703024021.3559286-1-xiaoyao.li@intel.com> References: <20250703024021.3559286-1-xiaoyao.li@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=198.175.65.15; envelope-from=xiaoyao.li@intel.com; helo=mgamail.intel.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HK_RANDOM_ENVFROM=0.001, HK_RANDOM_FROM=0.999, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.237, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @intel.com) X-ZM-MESSAGEID: 1751510938633116600 Content-Type: text/plain; charset="utf-8" GHCI is finalized with the being one of the base VMCALLs, and not enuemrated via . Adjust tdx_handle_get_tdvmcall_info() to match with GHCI. Opportunistically fix the wrong indentation and explicitly set the ret to TDG_VP_VMCALL_SUCCESS (in case KVM leaves unexpected value). Signed-off-by: Xiaoyao Li --- target/i386/kvm/tdx.c | 6 ++++-- target/i386/kvm/tdx.h | 2 -- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/target/i386/kvm/tdx.c b/target/i386/kvm/tdx.c index e809e4b2dfa2..8c661c3ecfdb 100644 --- a/target/i386/kvm/tdx.c +++ b/target/i386/kvm/tdx.c @@ -1259,13 +1259,15 @@ out_free: void tdx_handle_get_tdvmcall_info(X86CPU *cpu, struct kvm_run *run) { if (run->tdx.get_tdvmcall_info.leaf !=3D 1) { - return; + return; } =20 - run->tdx.get_tdvmcall_info.r11 =3D TDG_VP_VMCALL_SUBFUNC_GET_QUOTE; + run->tdx.get_tdvmcall_info.r11 =3D 0; run->tdx.get_tdvmcall_info.r12 =3D 0; run->tdx.get_tdvmcall_info.r13 =3D 0; run->tdx.get_tdvmcall_info.r14 =3D 0; + + run->tdx.get_tdvmcall_info.ret =3D TDG_VP_VMCALL_SUCCESS; } =20 static void tdx_panicked_on_fatal_error(X86CPU *cpu, uint64_t error_code, diff --git a/target/i386/kvm/tdx.h b/target/i386/kvm/tdx.h index 35a09c19c521..d439078a8761 100644 --- a/target/i386/kvm/tdx.h +++ b/target/i386/kvm/tdx.h @@ -32,8 +32,6 @@ typedef struct TdxGuestClass { #define TDG_VP_VMCALL_GPA_INUSE 0x8000000000000001ULL #define TDG_VP_VMCALL_ALIGN_ERROR 0x8000000000000002ULL =20 -#define TDG_VP_VMCALL_SUBFUNC_GET_QUOTE 0x0000000000000001ULL - enum TdxRamType { TDX_RAM_UNACCEPTED, TDX_RAM_ADDED, --=20 2.43.0