From nobody Fri Sep 12 22:59:38 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1751463692; cv=none; d=zohomail.com; s=zohoarc; b=jEps7Njsg2BDaB0NYqSUb0oWoJkp8kpcKsERdkjqJLFpxunLXqBky10vv8RUZ7xHvJ05uylWUvwDG7ahO7xwLb1hCJBKTSBCTC8K4LzlHmw0Q43CHuVqsETEzsGdLsEaV5JcdYMMWGdWQY8l29ImQs/aEwU2rfr9zkoDQUJEnfA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1751463692; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=d3iqV402n2zRibf20P4N2YxyvHzHBd9L0SbttgPpbJQ=; b=jonHxha3vlCBCXn44p16Mg1BJRQl+haiQi8/Rvfj9xnXUGn+1DDxNPpdfJxVN1nVUctBdVNHiWPjzMMWknTBfZscwXoa6k0necF7ZryQK96cljb0zqLbu898cE9tviZY9SCihACRKCEI8bkKlLzp6O5sVrkFO8I4hU6BYDscQrU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1751463692675435.87694800402323; Wed, 2 Jul 2025 06:41:32 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uWwp5-0003Ct-3J; Wed, 02 Jul 2025 08:44:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uWwjh-0004WX-G2 for qemu-devel@nongnu.org; Wed, 02 Jul 2025 08:38:50 -0400 Received: from mail-oa1-x2a.google.com ([2001:4860:4864:20::2a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uWwjZ-0002Cd-9z for qemu-devel@nongnu.org; Wed, 02 Jul 2025 08:38:49 -0400 Received: by mail-oa1-x2a.google.com with SMTP id 586e51a60fabf-2e9a38d2a3aso4363943fac.3 for ; Wed, 02 Jul 2025 05:38:39 -0700 (PDT) Received: from stoup.. ([187.210.107.185]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-2efd4ea5d9fsm3843451fac.10.2025.07.02.05.38.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Jul 2025 05:38:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1751459919; x=1752064719; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=d3iqV402n2zRibf20P4N2YxyvHzHBd9L0SbttgPpbJQ=; b=vZYBAtd1jUFxMsb3VI5urNcsh/zVmn9NzL6pC6kcA5HZQQiISlpqAZy+4Ns8fUQpP+ QCWT8YYDCnGrbFpW6N2Hwl5ppmj8i4C9wT9JWvFN8BYfmfABzYeg8KAsnTCm2QxKHdIy aQoPTSfRSosPJYTgYovh/6jYkjjcsE0EovTIiTEKeLiYDmCBU/fnfhpReqo7gVnLj9av fr9tR+rvoP9yok5C9IU5idDk78B6LVlFl+jiQBHdfs+zDyjV1x0umG9kef2FkIAm+OkZ /xD5Vx1jGSwI4zgwd4tF8B8AgAR26E9lF3SEWJj946odqFSZg2ZFv21Hrx0kyDqp77KB 3T+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751459919; x=1752064719; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=d3iqV402n2zRibf20P4N2YxyvHzHBd9L0SbttgPpbJQ=; b=KmarlKhyVx2P6m6Mt1DO3tdriPNg0ifkbr4f6pFljPh46O1Ml3LjAv3PzyfkRk4cH5 kvoMHI6PeKn4sxtxGs41oTybJSEzNCu0xX+SQHeQ9AQtwbJckgyJhd8cCGvzJ3fdLfcA ENObkzKbL7hybSofIEOB9iTYgyEOnnHDZdoZHi3Ty3Wxec3L7ESFjrywLcGpd9llwlCS DXNgSiLtpTak8N+m0bqaNS60c0/gfk7x/RrM99Knmf7O2ubvogiqpjmqH5C2DiJeskW4 SmxIhc1pgycKr+vz4eIgZ+2vzaP65GAFwF9V3nB5Xt1mSDBcZIZxFQoHvHi6N8gJelOK 0J5g== X-Gm-Message-State: AOJu0YxYKviGENLt0W/C3GB6R+jwMOra/K53GAHFjScddixQyOCGyIws n7i11OU09R6dbv8rWM+Js+NLFrImbGUnc+/vhcs/BIxEiz+xlYaKXLs7HqCk6KMnkP83lhwOfxq frEUgW44= X-Gm-Gg: ASbGncvONZmaXOurnLaVs6JnlsyVf+h7Iygl6hcSqqjtKIIPbs39sE0DC0Q9DIKpPFh EomLcH/Gu3nrcPzO29RKa+eGfpiqia/vGxeE+3m5h690qrabGlIXzuDetqEnVlq44v82VLvfmI8 chFApFoJQJOH4YAR/wiELim1CnWRDrQkp6BD3feSXmV2GwjMd2cgz39or/dCSnQxzlBgV825Lfj 1574V44l69lX5rn8IpsDIwcVAT/+CgIGMpXJfreE6lTFMwIRDt07+Vdmm+zlknG9rghd5JdReTh cd+5cH1Ldw2xJeOesD0aX3b49ywTQcwjjycREz1wSqRMlGneydOAlRUxSrm62unAtJMvqg== X-Google-Smtp-Source: AGHT+IGmNeTsu6QxxtXuWOpm1HSgHYRfwfMyssLwMBIvI6eFZwJ+liiekEioDDlmVzjc+swPoAm+zQ== X-Received: by 2002:a05:6871:7897:b0:2e9:e9b9:fd7c with SMTP id 586e51a60fabf-2f5a8c3aba3mr1881211fac.26.1751459918888; Wed, 02 Jul 2025 05:38:38 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Cc: qemu-arm@nongnu.org, peter.maydell@linaro.org Subject: [PATCH v3 67/97] target/arm: Implement SVE2p1 WHILE (predicate pair) Date: Wed, 2 Jul 2025 06:33:40 -0600 Message-ID: <20250702123410.761208-68-richard.henderson@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250702123410.761208-1-richard.henderson@linaro.org> References: <20250702123410.761208-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2001:4860:4864:20::2a; envelope-from=richard.henderson@linaro.org; helo=mail-oa1-x2a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1751463695251116600 Content-Type: text/plain; charset="utf-8" Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell --- target/arm/tcg/helper-sve.h | 3 +++ target/arm/tcg/sve_helper.c | 44 ++++++++++++++++++++++++++++++++++ target/arm/tcg/translate-sve.c | 14 +++++++---- target/arm/tcg/sve.decode | 8 +++++++ 4 files changed, 65 insertions(+), 4 deletions(-) diff --git a/target/arm/tcg/helper-sve.h b/target/arm/tcg/helper-sve.h index 0b1b588783..eac23e75b9 100644 --- a/target/arm/tcg/helper-sve.h +++ b/target/arm/tcg/helper-sve.h @@ -941,6 +941,9 @@ DEF_HELPER_FLAGS_3(sve_cntp, TCG_CALL_NO_RWG, i64, ptr,= ptr, i32) DEF_HELPER_FLAGS_3(sve_whilel, TCG_CALL_NO_RWG, i32, ptr, i32, i32) DEF_HELPER_FLAGS_3(sve_whileg, TCG_CALL_NO_RWG, i32, ptr, i32, i32) =20 +DEF_HELPER_FLAGS_3(sve_while2l, TCG_CALL_NO_RWG, i32, ptr, i32, i32) +DEF_HELPER_FLAGS_3(sve_while2g, TCG_CALL_NO_RWG, i32, ptr, i32, i32) + DEF_HELPER_FLAGS_4(sve_subri_b, TCG_CALL_NO_RWG, void, ptr, ptr, i64, i32) DEF_HELPER_FLAGS_4(sve_subri_h, TCG_CALL_NO_RWG, void, ptr, ptr, i64, i32) DEF_HELPER_FLAGS_4(sve_subri_s, TCG_CALL_NO_RWG, void, ptr, ptr, i64, i32) diff --git a/target/arm/tcg/sve_helper.c b/target/arm/tcg/sve_helper.c index dbade6ece0..2aec963f74 100644 --- a/target/arm/tcg/sve_helper.c +++ b/target/arm/tcg/sve_helper.c @@ -4142,6 +4142,28 @@ uint32_t HELPER(sve_whilel)(void *vd, uint32_t count= , uint32_t pred_desc) return pred_count_test(oprbits, count, false); } =20 +uint32_t HELPER(sve_while2l)(void *vd, uint32_t count, uint32_t pred_desc) +{ + uint32_t oprsz =3D FIELD_EX32(pred_desc, PREDDESC, OPRSZ); + uint32_t esz =3D FIELD_EX32(pred_desc, PREDDESC, ESZ); + uint32_t oprbits =3D oprsz * 8; + uint64_t esz_mask =3D pred_esz_masks[esz]; + ARMPredicateReg *d =3D vd; + + do_zero(&d[0], oprsz); + do_zero(&d[1], oprsz); + + count <<=3D esz; + if (count <=3D oprbits) { + do_whilel(d[0].p, esz_mask, count, oprbits); + } else { + do_whilel(d[0].p, esz_mask, oprbits, oprbits); + do_whilel(d[1].p, esz_mask, count - oprbits, oprbits); + } + + return pred_count_test(2 * oprbits, count, false); +} + static void do_whileg(uint64_t *d, uint64_t esz_mask, uint32_t count, uint32_t oprbits) { @@ -4174,6 +4196,28 @@ uint32_t HELPER(sve_whileg)(void *vd, uint32_t count= , uint32_t pred_desc) return pred_count_test(oprbits, count, true); } =20 +uint32_t HELPER(sve_while2g)(void *vd, uint32_t count, uint32_t pred_desc) +{ + uint32_t oprsz =3D FIELD_EX32(pred_desc, PREDDESC, OPRSZ); + uint32_t esz =3D FIELD_EX32(pred_desc, PREDDESC, ESZ); + uint32_t oprbits =3D oprsz * 8; + uint64_t esz_mask =3D pred_esz_masks[esz]; + ARMPredicateReg *d =3D vd; + + do_zero(&d[0], oprsz); + do_zero(&d[1], oprsz); + + count <<=3D esz; + if (count <=3D oprbits) { + do_whileg(d[1].p, esz_mask, count, oprbits); + } else { + do_whileg(d[1].p, esz_mask, oprbits, oprbits); + do_whileg(d[0].p, esz_mask, count - oprbits, oprbits); + } + + return pred_count_test(2 * oprbits, count, true); +} + /* Recursive reduction on a function; * C.f. the ARM ARM function ReducePredicated. * diff --git a/target/arm/tcg/translate-sve.c b/target/arm/tcg/translate-sve.c index cb60b533e9..de6ffe7511 100644 --- a/target/arm/tcg/translate-sve.c +++ b/target/arm/tcg/translate-sve.c @@ -3109,7 +3109,8 @@ static bool trans_CTERM(DisasContext *s, arg_CTERM *a) } =20 typedef void gen_while_fn(TCGv_i32, TCGv_ptr, TCGv_i32, TCGv_i32); -static bool do_WHILE(DisasContext *s, arg_while *a, bool lt, gen_while_fn = *fn) +static bool do_WHILE(DisasContext *s, arg_while *a, + bool lt, int scale, gen_while_fn *fn) { TCGv_i64 op0, op1, t0, t1, tmax; TCGv_i32 t2; @@ -3164,7 +3165,7 @@ static bool do_WHILE(DisasContext *s, arg_while *a, b= ool lt, gen_while_fn *fn) } } =20 - tmax =3D tcg_constant_i64(vsz >> a->esz); + tmax =3D tcg_constant_i64((vsz << scale) >> a->esz); if (eq) { /* Equality means one more iteration. */ tcg_gen_addi_i64(t0, t0, 1); @@ -3205,8 +3206,13 @@ static bool do_WHILE(DisasContext *s, arg_while *a, = bool lt, gen_while_fn *fn) return true; } =20 -TRANS_FEAT(WHILE_lt, aa64_sve, do_WHILE, a, true, gen_helper_sve_whilel) -TRANS_FEAT(WHILE_gt, aa64_sve2, do_WHILE, a, false, gen_helper_sve_whileg) +TRANS_FEAT(WHILE_lt, aa64_sve, do_WHILE, a, true, 0, gen_helper_sve_whilel) +TRANS_FEAT(WHILE_gt, aa64_sve2, do_WHILE, a, false, 0, gen_helper_sve_whil= eg) + +TRANS_FEAT(WHILE_lt_pair, aa64_sme2_or_sve2p1, do_WHILE, + a, true, 1, gen_helper_sve_while2l) +TRANS_FEAT(WHILE_gt_pair, aa64_sme2_or_sve2p1, do_WHILE, + a, false, 1, gen_helper_sve_while2g) =20 static bool trans_WHILE_ptr(DisasContext *s, arg_WHILE_ptr *a) { diff --git a/target/arm/tcg/sve.decode b/target/arm/tcg/sve.decode index c90d975ebf..968b2a57e9 100644 --- a/target/arm/tcg/sve.decode +++ b/target/arm/tcg/sve.decode @@ -796,6 +796,14 @@ WHILE_gt 00100101 esz:2 1 rm:5 000 sf:1 u:1 0 r= n:5 eq:1 rd:4 &while # SVE2 pointer conflict compare WHILE_ptr 00100101 esz:2 1 rm:5 001 100 rn:5 rw:1 rd:4 =20 +# SVE2.1 predicate pair +%pd_pair 1:3 !function=3Dtimes_2 +@while_pair ........ esz:2 . rm:5 .... u:1 . rn:5 . ... eq:1 \ + &while rd=3D%pd_pair sf=3D1 + +WHILE_lt_pair 00100101 .. 1 ..... 0101 . 1 ..... 1 ... . @while_pair +WHILE_gt_pair 00100101 .. 1 ..... 0101 . 0 ..... 1 ... . @while_pair + ### SVE Integer Wide Immediate - Unpredicated Group =20 # SVE broadcast floating-point immediate (unpredicated) --=20 2.43.0