From nobody Fri Sep 12 22:55:47 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1751463816; cv=none; d=zohomail.com; s=zohoarc; b=JZzYlfBY2mj/gnkxL6ssqCKflxHW3M2AsSBhr//wIpeS6rkKz1hdipMdbxeSgHWihRSdMzqLC5Gei0+FgCUSpEwHRRpEuM4DfEt2Omfo5F5bKLtDoSyUzW9D8muSASEnanwHu5ZMX9raIJY+AMU53j/ihDIxhve+iDMZR8AdJ94= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1751463816; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=cLOzuV0IZQAzv7VumD5A4WEK+Bowcevem0zcvJPACgI=; b=VHlCsVgy9ElhoBtF/n/VAGS8c/1XiPwP80vY7oa7/mpqEYnPbH0EP2NHVzquFEYhBHqVNyktwiCDjki/u64Pix2AvPkToCgJesXNBLVU7iuaxNB+BoV28KfFPAA1UV/Ec6qK2KyQ9wOAz5G0k5EQZSsKlC2ipJTLFaqZ1rlIbcs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1751463816512457.06148267152776; Wed, 2 Jul 2025 06:43:36 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uWwlv-0006U0-RT; Wed, 02 Jul 2025 08:41:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uWwjV-0004Lb-LN for qemu-devel@nongnu.org; Wed, 02 Jul 2025 08:38:41 -0400 Received: from mail-oa1-x34.google.com ([2001:4860:4864:20::34]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uWwjL-00027N-Rr for qemu-devel@nongnu.org; Wed, 02 Jul 2025 08:38:36 -0400 Received: by mail-oa1-x34.google.com with SMTP id 586e51a60fabf-2ea35edc691so1681586fac.2 for ; Wed, 02 Jul 2025 05:38:24 -0700 (PDT) Received: from stoup.. ([187.210.107.185]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-2efd4ea5d9fsm3843451fac.10.2025.07.02.05.38.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Jul 2025 05:38:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1751459903; x=1752064703; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=cLOzuV0IZQAzv7VumD5A4WEK+Bowcevem0zcvJPACgI=; b=QEw5j/agJa8Qy+rEb0bRcRBqqDequFvOT4QS4mFRnumaSPSksAR0ILYZRptGxNZwvG PxfnbfIw/Hpa67Xzr8iK88H8+pi2oSz7E05auouoj8j7V/P+2lZSQI0qnhEH1qWftmsS LPKKIs9VTsejSa7B3adOiYNMEi6khy5E3eMfuFgx25JAezHnoqAhLRv/rps5R5c4dMVW vDF4FxxjuoEkVhLHR/CAy/Ly5urG66DZpWqJPPAi4O1jumx6Wqf0vxlpoynKwP6lrWS6 TGrH8pcO9THHmySRO9O9T1T8LcCW2/0AsFNaGbce1i20F/PgBWjh2wJgH0ad4W5PJCKh 0VPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751459903; x=1752064703; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cLOzuV0IZQAzv7VumD5A4WEK+Bowcevem0zcvJPACgI=; b=mGqtMvGjw1+RQ/pqXmyRbkCkbxUKUgN9CSTNCoekbaLKTyGA+EA4OegzWu7S+UL2lx +RLNSoT3GLrtVYv+6eaS90fEyEt5NTGg0GioZNPo2IctGDUbzXQqvl9VfKOr+2nAnIQz laaY7vpNeNp7hRLwviyrn2pkfqnElgAzBEJ2BEp1ewuxMfYNr8xLaH/NzNhw3h74QN5K 634BssgRhNnykgZPiiBuZKFQU7vWOP3yHFggf3nSi3YIF9DSToaADrc6q9NTR+8CihPi R7+2Jo/CiE8t70Q8hkH7tQt00VpUwbPn9vHhxmo4k9AmGN94BErF4jHKGm5YDmafsv48 wyAQ== X-Gm-Message-State: AOJu0YzqVshkDxFDwcaf2LLjaniHweExJMlcx1uM+RcNUtdgwZob9KYB S8yszCSqG7ZxWoxJramYCG4NUuZdardyMBoTG/xqB9+6yrl0azBBdjVDBk8ByFTenF9I4d6dxZM NgnnHvlU= X-Gm-Gg: ASbGncupQBbYudZTwEr2OGeXddS+FkSE/51BJIs3EEMLI+hPgQMs1lNvhbZlwcN9Myz Iz0WN9B5mRC1gTw019ANYHdlvnz76fUHJK7OZuRU6RccIMcXccK1xAnrtrgFL6gCiYsd3d48Nsz lJQl6LvHBHANKyGd9WuQ68n6n43YIh2TLDtEwW2Zc+IDCixaq26p1ZoukWa/wkQHIkiqY99NqpT MeMexwxGS/qM99B6s7JT8tPk1Xqz2HbUdKXwbeinEVLMoPKiE2ZSAZv+G1fmUK1otbw3R0EohrA 5FiAWbovJWmOvy+b5FdtzQixmtW6JpVaks7R+qFol3XzgTfRGr3h0N6SRYT5tcRO65+L8w== X-Google-Smtp-Source: AGHT+IGrEd9mRp6ANSJaZZd2sqMEOqLsmmfPtSA+/DDwHuUz7HVwUMNbfQkjmppHQrjYQUcgSfmLhA== X-Received: by 2002:a05:6870:f71e:b0:2c6:72d3:fc93 with SMTP id 586e51a60fabf-2f5a8a490d0mr2079026fac.12.1751459903204; Wed, 02 Jul 2025 05:38:23 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Cc: qemu-arm@nongnu.org, peter.maydell@linaro.org Subject: [PATCH v3 56/97] target/arm: Implement SME2 FCLAMP, SCLAMP, UCLAMP Date: Wed, 2 Jul 2025 06:33:29 -0600 Message-ID: <20250702123410.761208-57-richard.henderson@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250702123410.761208-1-richard.henderson@linaro.org> References: <20250702123410.761208-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2001:4860:4864:20::34; envelope-from=richard.henderson@linaro.org; helo=mail-oa1-x34.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1751463822872116600 Content-Type: text/plain; charset="utf-8" Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell --- target/arm/tcg/helper-sme.h | 15 +++++++ target/arm/tcg/sme_helper.c | 52 +++++++++++++++++++++++ target/arm/tcg/translate-sme.c | 75 ++++++++++++++++++++++++++++++++++ target/arm/tcg/sme.decode | 17 ++++++++ 4 files changed, 159 insertions(+) diff --git a/target/arm/tcg/helper-sme.h b/target/arm/tcg/helper-sme.h index 06b95da3c3..78ba3d1f20 100644 --- a/target/arm/tcg/helper-sme.h +++ b/target/arm/tcg/helper-sme.h @@ -298,3 +298,18 @@ DEF_HELPER_FLAGS_3(sme2_sqrshrun_sb, TCG_CALL_NO_RWG, = void, ptr, ptr, i32) DEF_HELPER_FLAGS_3(sme2_sqrshrn_dh, TCG_CALL_NO_RWG, void, ptr, ptr, i32) DEF_HELPER_FLAGS_3(sme2_uqrshrn_dh, TCG_CALL_NO_RWG, void, ptr, ptr, i32) DEF_HELPER_FLAGS_3(sme2_sqrshrun_dh, TCG_CALL_NO_RWG, void, ptr, ptr, i32) + +DEF_HELPER_FLAGS_4(sme2_sclamp_b, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, i3= 2) +DEF_HELPER_FLAGS_4(sme2_sclamp_h, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, i3= 2) +DEF_HELPER_FLAGS_4(sme2_sclamp_s, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, i3= 2) +DEF_HELPER_FLAGS_4(sme2_sclamp_d, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, i3= 2) + +DEF_HELPER_FLAGS_4(sme2_uclamp_b, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, i3= 2) +DEF_HELPER_FLAGS_4(sme2_uclamp_h, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, i3= 2) +DEF_HELPER_FLAGS_4(sme2_uclamp_s, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, i3= 2) +DEF_HELPER_FLAGS_4(sme2_uclamp_d, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, i3= 2) + +DEF_HELPER_FLAGS_5(sme2_fclamp_h, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, fp= st, i32) +DEF_HELPER_FLAGS_5(sme2_fclamp_s, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, fp= st, i32) +DEF_HELPER_FLAGS_5(sme2_fclamp_d, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, fp= st, i32) +DEF_HELPER_FLAGS_5(sme2_bfclamp, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, fps= t, i32) diff --git a/target/arm/tcg/sme_helper.c b/target/arm/tcg/sme_helper.c index 7a869f6b9c..bfcedef3d9 100644 --- a/target/arm/tcg/sme_helper.c +++ b/target/arm/tcg/sme_helper.c @@ -2055,3 +2055,55 @@ UZP4(sme2_uzp4_d, uint64_t, ) UZP4(sme2_uzp4_q, Int128, ) =20 #undef UZP4 + +#define ICLAMP(NAME, TYPE, H) \ +void HELPER(NAME)(void *vd, void *vn, void *vm, uint32_t desc) \ +{ \ + size_t stride =3D sizeof(ARMVectorReg) / sizeof(TYPE); \ + size_t elements =3D simd_oprsz(desc) / sizeof(TYPE); \ + size_t nreg =3D simd_data(desc); \ + TYPE *d =3D vd, *n =3D vn, *m =3D vm; \ + for (size_t e =3D 0; e < elements; e++) { \ + TYPE nn =3D n[H(e)], mm =3D m[H(e)]; \ + for (size_t r =3D 0; r < nreg; r++) { \ + TYPE *dd =3D &d[r * stride + H(e)]; \ + *dd =3D MIN(MAX(*dd, nn), mm); \ + } \ + } \ +} + +ICLAMP(sme2_sclamp_b, int8_t, H1) +ICLAMP(sme2_sclamp_h, int16_t, H2) +ICLAMP(sme2_sclamp_s, int32_t, H4) +ICLAMP(sme2_sclamp_d, int64_t, H8) + +ICLAMP(sme2_uclamp_b, uint8_t, H1) +ICLAMP(sme2_uclamp_h, uint16_t, H2) +ICLAMP(sme2_uclamp_s, uint32_t, H4) +ICLAMP(sme2_uclamp_d, uint64_t, H8) + +#undef ICLAMP + +#define FCLAMP(NAME, TYPE, H) \ +void HELPER(NAME)(void *vd, void *vn, void *vm, \ + float_status *fpst, uint32_t desc) \ +{ \ + size_t stride =3D sizeof(ARMVectorReg) / sizeof(TYPE); \ + size_t elements =3D simd_oprsz(desc) / sizeof(TYPE); \ + size_t nreg =3D simd_data(desc); \ + TYPE *d =3D vd, *n =3D vn, *m =3D vm; \ + for (size_t e =3D 0; e < elements; e++) { \ + TYPE nn =3D n[H(e)], mm =3D m[H(e)]; \ + for (size_t r =3D 0; r < nreg; r++) { \ + TYPE *dd =3D &d[r * stride + H(e)]; \ + *dd =3D TYPE##_minnum(TYPE##_maxnum(nn, *dd, fpst), mm, fpst);= \ + } \ + } \ +} + +FCLAMP(sme2_fclamp_h, float16, H2) +FCLAMP(sme2_fclamp_s, float32, H4) +FCLAMP(sme2_fclamp_d, float64, H8) +FCLAMP(sme2_bfclamp, bfloat16, H2) + +#undef FCLAMP diff --git a/target/arm/tcg/translate-sme.c b/target/arm/tcg/translate-sme.c index d52ccf2ac5..99e4056316 100644 --- a/target/arm/tcg/translate-sme.c +++ b/target/arm/tcg/translate-sme.c @@ -1547,3 +1547,78 @@ static gen_helper_gvec_3 * const uzp2_fns[] =3D { gen_helper_sme2_uzp2_q, }; TRANS_FEAT(UZP_2, aa64_sme2, do_zipuzp_2, a, uzp2_fns) + +static bool trans_FCLAMP(DisasContext *s, arg_zzz_en *a) +{ + static gen_helper_gvec_3_ptr * const fn[] =3D { + gen_helper_sme2_bfclamp, + gen_helper_sme2_fclamp_h, + gen_helper_sme2_fclamp_s, + gen_helper_sme2_fclamp_d, + }; + TCGv_ptr fpst; + int vl; + + if (!dc_isar_feature(aa64_sme2, s)) { + return false; + } + /* This insn uses MO_8 to encode BFloat16. */ + if (a->esz =3D=3D MO_8 && !dc_isar_feature(aa64_sme_b16b16, s)) { + return false; + } + if (!sme_sm_enabled_check(s)) { + return true; + } + + fpst =3D fpstatus_ptr(a->esz =3D=3D MO_16 ? FPST_A64_F16 : FPST_A64); + vl =3D vec_full_reg_size(s); + + tcg_gen_gvec_3_ptr(vec_full_reg_offset(s, a->zd), + vec_full_reg_offset(s, a->zn), + vec_full_reg_offset(s, a->zm), + fpst, vl, vl, a->n, fn[a->esz]); + return true; +} + +static bool do_clamp(DisasContext *s, arg_zzz_en *a, + gen_helper_gvec_3 * const fn[4]) +{ + int vl; + + if (!dc_isar_feature(aa64_sme2, s)) { + return false; + } + if (!sme_sm_enabled_check(s)) { + return true; + } + + /* + * Clamp is just a min+max, easily supported by most host + * vector operations -- we already have such an expansion in + * translate-sve.c for a single output. + * TODO: Add support in gvec for multiple simultaneous output, + * and/or copy to temporary upon overlap. + */ + vl =3D vec_full_reg_size(s); + tcg_gen_gvec_3_ool(vec_full_reg_offset(s, a->zd), + vec_full_reg_offset(s, a->zn), + vec_full_reg_offset(s, a->zm), + vl, vl, a->n, fn[a->esz]); + return true; +} + +static gen_helper_gvec_3 * const sclamp_fns[] =3D { + gen_helper_sme2_sclamp_b, + gen_helper_sme2_sclamp_h, + gen_helper_sme2_sclamp_s, + gen_helper_sme2_sclamp_d, +}; +TRANS(SCLAMP, do_clamp, a, sclamp_fns) + +static gen_helper_gvec_3 * const uclamp_fns[] =3D { + gen_helper_sme2_uclamp_b, + gen_helper_sme2_uclamp_h, + gen_helper_sme2_uclamp_s, + gen_helper_sme2_uclamp_d, +}; +TRANS(UCLAMP, do_clamp, a, uclamp_fns) diff --git a/target/arm/tcg/sme.decode b/target/arm/tcg/sme.decode index c1f73d9f63..47adcb5a15 100644 --- a/target/arm/tcg/sme.decode +++ b/target/arm/tcg/sme.decode @@ -860,3 +860,20 @@ UZP_2 11000001 esz:2 1 zm:5 110100 zn:5 ....= 1 \ &zzz_e zd=3D%zd_ax2 UZP_2 11000001 00 1 zm:5 110101 zn:5 .... 1 \ &zzz_e zd=3D%zd_ax2 esz=3D4 + +&zzz_en zd zn zm esz n + +FCLAMP 11000001 esz:2 1 zm:5 110000 zn:5 .... 0 \ + &zzz_en zd=3D%zd_ax2 n=3D2 +FCLAMP 11000001 esz:2 1 zm:5 110010 zn:5 ...0 0 \ + &zzz_en zd=3D%zd_ax4 n=3D4 + +SCLAMP 11000001 esz:2 1 zm:5 110001 zn:5 .... 0 \ + &zzz_en zd=3D%zd_ax2 n=3D2 +SCLAMP 11000001 esz:2 1 zm:5 110011 zn:5 ...0 0 \ + &zzz_en zd=3D%zd_ax4 n=3D4 + +UCLAMP 11000001 esz:2 1 zm:5 110001 zn:5 .... 1 \ + &zzz_en zd=3D%zd_ax2 n=3D2 +UCLAMP 11000001 esz:2 1 zm:5 110011 zn:5 ...0 1 \ + &zzz_en zd=3D%zd_ax4 n=3D4 --=20 2.43.0