From nobody Fri Sep 12 22:55:45 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1751460094; cv=none; d=zohomail.com; s=zohoarc; b=TKNEiu2dR4P1UJxXpIYEsAyqGMISBtc4dbXbWNNi7P/ekGzwi5BwmkZ+PYnIpeNkxKT9deVuCVz9NcYoFmYsuyf3RTlOZuvoTrdCbdm0lmPW3WNgXZy9BesQ22xzpYZhIOTMIuVLq95JxJR0YODaAgDQf3Go9kldbMMcaVjtqX8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1751460094; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=7DJLNfwuW/Zo+RPNp5mq/l1peWmKK7HstZBP41coj7M=; b=nZlrUIByJmy886o4RomDOrwxwTEvVgKuaqGAVvXUhXSlTVh8sGpogM95OF2ZbpqRrnehX7S2m6skx2xy8QFwR0EWem8+9WSlNJ/uqw0RwkDbyB94ik3560ewiJmDpb/MtdPiJIx09RzGTrg/gfJRefnYUqYbeT/pcWazc1IR3Fo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1751460094311336.65481548551236; Wed, 2 Jul 2025 05:41:34 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uWwhW-0001YX-1h; Wed, 02 Jul 2025 08:36:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uWwg5-0007vU-Of for qemu-devel@nongnu.org; Wed, 02 Jul 2025 08:35:05 -0400 Received: from mail-ot1-x32f.google.com ([2607:f8b0:4864:20::32f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uWwfm-00014M-FX for qemu-devel@nongnu.org; Wed, 02 Jul 2025 08:35:03 -0400 Received: by mail-ot1-x32f.google.com with SMTP id 46e09a7af769-73af5dc0066so1561537a34.1 for ; Wed, 02 Jul 2025 05:34:44 -0700 (PDT) Received: from stoup.. ([187.210.107.185]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-2efd50b1b2fsm3864281fac.32.2025.07.02.05.34.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Jul 2025 05:34:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1751459684; x=1752064484; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=7DJLNfwuW/Zo+RPNp5mq/l1peWmKK7HstZBP41coj7M=; b=WJzLQhXGvPliLbNUTxx3433/k/Iq3nXKg9/xCsDDYG0acUgkX9Ez4skqgd33Ic5fps lEERt7CtfK9ulrHKAwwyl6ZpfHs+8VpgmpGYtJJg2WQ4XFjAJ99e/XMA/VK9UKEhmdVD XocOE5wkkvgh9jtM6W5nMDlnOnRO/U+Zvxg2TPEPXmE+NctMkcb+6r1PESsiZWK0ETDg DFfScE43N4PQfnRsPG3+cWOEQ+oqNuVwV01wS4C443ybhND0DvHrEsUc0+OBROk2DFRq KpRMg9LxATOAbddUoe34hoOBZDkuCLp2MAD0H5V9ULsRChfsgZ58CBRvcfionsfailSF /BIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751459684; x=1752064484; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7DJLNfwuW/Zo+RPNp5mq/l1peWmKK7HstZBP41coj7M=; b=fTKHKyPI/gHHD9iY0f+VRPukWWQb1UQ5gHg/ubdT/I4px8+bKaadGWw0vQ37LyrYJz xA+zNF8TNSnxVgyBu5DY7yMrLBB36fyrEt4WOzMZmOrh5Rh4BzyxTlkt4tTkZy2JO2CV qOca7VyvlfowOQivM+owdIh4RYoxMM01yqQfAhdTabY96Cz26O+W5rg6g+OOW1Z2gCrc kGJucij9dc5EoC6ubUUsu3fmu0HhPIz23diJQedHI77Y83AawsjES8Qqi1TUATksgWjY F0iWO24wj0NWzY2VTEk7GfLFLesNXEYGAir7DER1FerQJN3mm1OtY/XbuU1x+etdueaC qeug== X-Gm-Message-State: AOJu0YzL7zJDs9HLqUoDRVkp438uAM9kp3zQWoMdvsSS+/Q9JSPSgisz rUlCfeim4SDwxpJGIlGx7cRk4WD6qD7L227KPFo0xuPwsispQRgWODpoUDvPt6z61GUl8b0PPCl UBkurY6o= X-Gm-Gg: ASbGncsrD4VXZrqrL7/F0C7l2usJlEqxywJUU8DYQ86YFm2s4dC/ZlDDLOta7UtTz/X b1qVF1063eLRSaDTxJ9FeHFD107SLxz470bYEJfzv5yhbF7AHmUV1eemPJHGeeNWTPI/Gi8lGLZ ELMP3dexpNB7zBgdVsLLYv/ec79rLvQ/linh8BrY9KqsQ4YWHosXv95mpIkKX9yFO/IWFnQ8MU+ bs+IuCb4Jv+3cSYZ+Wp3I0/TlVdup92viQtrcVfLa3HIvH8hbNp5uZ5GQIrwcL7V4H1WfPdGDUc joHwpYWvuioUfwz94O0eBTXhzAQLxE0BbAmjhxyYMVUgn+J1RGaNY2CZ3ynJb/Hq8fAzNA== X-Google-Smtp-Source: AGHT+IHMt691dZbZeCRIy+QUzSXYOJiO1mzSzbTJX/l+x10pPNJEr5/ROBvmMSL0Cav1aAnpWrckDA== X-Received: by 2002:a05:6830:648c:b0:73a:6904:1b46 with SMTP id 46e09a7af769-73b4ca7b5f7mr2741164a34.8.1751459683926; Wed, 02 Jul 2025 05:34:43 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Cc: qemu-arm@nongnu.org, peter.maydell@linaro.org Subject: [PATCH v3 25/97] target/arm: Add helper_gvec{_ah}_bfmlsl{_nx} Date: Wed, 2 Jul 2025 06:32:58 -0600 Message-ID: <20250702123410.761208-26-richard.henderson@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250702123410.761208-1-richard.henderson@linaro.org> References: <20250702123410.761208-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::32f; envelope-from=richard.henderson@linaro.org; helo=mail-ot1-x32f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1751460094721116600 Content-Type: text/plain; charset="utf-8" Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell --- target/arm/tcg/helper.h | 8 +++++ target/arm/tcg/vec_helper.c | 58 ++++++++++++++++++++++++++++--------- 2 files changed, 53 insertions(+), 13 deletions(-) diff --git a/target/arm/tcg/helper.h b/target/arm/tcg/helper.h index 8c4705fc53..a05b63380c 100644 --- a/target/arm/tcg/helper.h +++ b/target/arm/tcg/helper.h @@ -1095,8 +1095,16 @@ DEF_HELPER_FLAGS_6(gvec_bfmmla, TCG_CALL_NO_RWG, =20 DEF_HELPER_FLAGS_6(gvec_bfmlal, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, ptr, fpst, i32) +DEF_HELPER_FLAGS_6(gvec_bfmlsl, TCG_CALL_NO_RWG, + void, ptr, ptr, ptr, ptr, fpst, i32) +DEF_HELPER_FLAGS_6(gvec_ah_bfmlsl, TCG_CALL_NO_RWG, + void, ptr, ptr, ptr, ptr, fpst, i32) DEF_HELPER_FLAGS_6(gvec_bfmlal_idx, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, ptr, fpst, i32) +DEF_HELPER_FLAGS_6(gvec_bfmlsl_idx, TCG_CALL_NO_RWG, + void, ptr, ptr, ptr, ptr, fpst, i32) +DEF_HELPER_FLAGS_6(gvec_ah_bfmlsl_idx, TCG_CALL_NO_RWG, + void, ptr, ptr, ptr, ptr, fpst, i32) =20 DEF_HELPER_FLAGS_5(gvec_sclamp_b, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, ptr, i32) diff --git a/target/arm/tcg/vec_helper.c b/target/arm/tcg/vec_helper.c index f3de26ca54..3ebee97e68 100644 --- a/target/arm/tcg/vec_helper.c +++ b/target/arm/tcg/vec_helper.c @@ -3186,44 +3186,76 @@ void HELPER(gvec_bfmmla)(void *vd, void *vn, void *= vm, void *va, clear_tail(d, opr_sz, simd_maxsz(desc)); } =20 -void HELPER(gvec_bfmlal)(void *vd, void *vn, void *vm, void *va, - float_status *stat, uint32_t desc) +static void do_bfmlal(float32 *d, bfloat16 *n, bfloat16 *m, float32 *a, + float_status *stat, uint32_t desc, int negx, int neg= f) { intptr_t i, opr_sz =3D simd_oprsz(desc); - intptr_t sel =3D simd_data(desc); - float32 *d =3D vd, *a =3D va; - bfloat16 *n =3D vn, *m =3D vm; + intptr_t sel =3D extract32(desc, SIMD_DATA_SHIFT, 1); =20 for (i =3D 0; i < opr_sz / 4; ++i) { - float32 nn =3D n[H2(i * 2 + sel)] << 16; + float32 nn =3D (negx ^ n[H2(i * 2 + sel)]) << 16; float32 mm =3D m[H2(i * 2 + sel)] << 16; - d[H4(i)] =3D float32_muladd(nn, mm, a[H4(i)], 0, stat); + d[H4(i)] =3D float32_muladd(nn, mm, a[H4(i)], negf, stat); } clear_tail(d, opr_sz, simd_maxsz(desc)); } =20 -void HELPER(gvec_bfmlal_idx)(void *vd, void *vn, void *vm, - void *va, float_status *stat, uint32_t desc) +void HELPER(gvec_bfmlal)(void *vd, void *vn, void *vm, void *va, + float_status *stat, uint32_t desc) +{ + do_bfmlal(vd, vn, vm, va, stat, desc, 0, 0); +} + +void HELPER(gvec_bfmlsl)(void *vd, void *vn, void *vm, void *va, + float_status *stat, uint32_t desc) +{ + do_bfmlal(vd, vn, vm, va, stat, desc, 0x8000, 0); +} + +void HELPER(gvec_ah_bfmlsl)(void *vd, void *vn, void *vm, void *va, + float_status *stat, uint32_t desc) +{ + do_bfmlal(vd, vn, vm, va, stat, desc, 0, float_muladd_negate_product); +} + +static void do_bfmlal_idx(float32 *d, bfloat16 *n, bfloat16 *m, float32 *a, + float_status *stat, uint32_t desc, int negx, int= negf) { intptr_t i, j, opr_sz =3D simd_oprsz(desc); intptr_t sel =3D extract32(desc, SIMD_DATA_SHIFT, 1); intptr_t index =3D extract32(desc, SIMD_DATA_SHIFT + 1, 3); intptr_t elements =3D opr_sz / 4; intptr_t eltspersegment =3D MIN(16 / 4, elements); - float32 *d =3D vd, *a =3D va; - bfloat16 *n =3D vn, *m =3D vm; =20 for (i =3D 0; i < elements; i +=3D eltspersegment) { float32 m_idx =3D m[H2(2 * i + index)] << 16; =20 for (j =3D i; j < i + eltspersegment; j++) { - float32 n_j =3D n[H2(2 * j + sel)] << 16; - d[H4(j)] =3D float32_muladd(n_j, m_idx, a[H4(j)], 0, stat); + float32 n_j =3D (negx ^ n[H2(2 * j + sel)]) << 16; + d[H4(j)] =3D float32_muladd(n_j, m_idx, a[H4(j)], negf, stat); } } clear_tail(d, opr_sz, simd_maxsz(desc)); } =20 +void HELPER(gvec_bfmlal_idx)(void *vd, void *vn, void *vm, void *va, + float_status *stat, uint32_t desc) +{ + do_bfmlal_idx(vd, vn, vm, va, stat, desc, 0, 0); +} + +void HELPER(gvec_bfmlsl_idx)(void *vd, void *vn, void *vm, void *va, + float_status *stat, uint32_t desc) +{ + do_bfmlal_idx(vd, vn, vm, va, stat, desc, 0x8000, 0); +} + +void HELPER(gvec_ah_bfmlsl_idx)(void *vd, void *vn, void *vm, void *va, + float_status *stat, uint32_t desc) +{ + do_bfmlal_idx(vd, vn, vm, va, stat, desc, 0, float_muladd_negate_produ= ct); +} + #define DO_CLAMP(NAME, TYPE) \ void HELPER(NAME)(void *d, void *n, void *m, void *a, uint32_t desc) \ { \ --=20 2.43.0