From nobody Sat Nov 15 14:09:44 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1751455337; cv=none; d=zohomail.com; s=zohoarc; b=AYd6YQvpkygwMMZqrSQ6VgqlS3HfYUEKRbLzS2q7Lp3RHejxZsxcghiuAdWOkY7nvoJSdl0VeCW+/imPRGhCzOe8gsr1TLW/PdwvQA45RAyfIn/Vd3YzQBq9JoPtz/4dsJIygpBPK1jmRzt4JIMMavvAQZ57tr/JlH7IOPFaNQI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1751455337; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=3J4Bv1vpjzwpdZe6XYejX5dLNpz+G5brIjasw5lYx80=; b=R4/8rfTz0tjwitwsYoQnCpOG5FqmDKVxEqqrlIWt22jjLhDy1JsaUtmDv1arH6hLpUAjfD3CZnyB0wjUFH5og40VqBzt3944drOmqcUPBZ4vQLgO4yfYuNbGq+l9kk1IoYKZNlH55wvHtFqURWh4gWC1Bbc2Ecg27M+LsGdqeXA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1751455337689212.62270733054527; Wed, 2 Jul 2025 04:22:17 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uWvVo-0007ah-2B; Wed, 02 Jul 2025 07:20:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uWvVl-0007Yz-Vv; Wed, 02 Jul 2025 07:20:22 -0400 Received: from mail-pg1-x52f.google.com ([2607:f8b0:4864:20::52f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uWvVj-0002Lc-KH; Wed, 02 Jul 2025 07:20:21 -0400 Received: by mail-pg1-x52f.google.com with SMTP id 41be03b00d2f7-b0b2d0b2843so5681153a12.2; Wed, 02 Jul 2025 04:20:17 -0700 (PDT) Received: from localhost (pa49-178-74-199.pa.nsw.optusnet.com.au. [49.178.74.199]) by smtp.gmail.com with UTF8SMTPSA id 41be03b00d2f7-b34e320fc3bsm11469354a12.75.2025.07.02.04.20.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Jul 2025 04:20:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1751455216; x=1752060016; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=3J4Bv1vpjzwpdZe6XYejX5dLNpz+G5brIjasw5lYx80=; b=iffLnyARVCGKfoPtEZ4AZ+UQEmXaK7jCLfHnP5zBkllvhBoPHcC7OoCg2tHQuoHhST jXWUgh8mrbuSrWjDwYv79pWEZ1i61/hCyusXZk8+g9ekbU/nm2oJqY8DBKI4LrWkCn/S 2bw8qADvmHWWA9DFbcq4p28YhtRk7lhYtvOrOtaT+a61TNWQRs2zGsth2RGFeJ1mkEw/ i1qLLmrRuaGWFl+xP/h4TuaZ58tAkDqs6KkLAHMmYTzoMHv5oEneam7B53tdNJGc+w7w bv2nsmh+aCk9w01LEbREMqQyW3ppknLJUaF4xoHeX9sVzsoYNkUap2+W0T6aeNw7qxzV 8UJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751455216; x=1752060016; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3J4Bv1vpjzwpdZe6XYejX5dLNpz+G5brIjasw5lYx80=; b=vAXdlsj86hv2ItuOF+MNE0OloGJ466NPjVcjn5kjFl/eM/ZWu1a07NE8dVDhzo1xs2 IiAINgg8zfgDVwCuE5+Tg+lVqgCr4isWgNp0QXXtVQCiX40y6AWFu9pQh8ML4gEWlFCj yytT3zdiYulaWw5NLtAfu9xF00CxfQR7modjNWyCGl+EGdxCxDW13qUyEoidqvr1MuI+ 43fxfNxzGeIKzfWmKRMTdTWRmKukST5aYdfB46IPYDHL6ogWXbJMbHQ69tFFN/W8ezHd BrS0pdrOWYwpX40d5lo8NPm7Osip4Ohm/LET5IyJ/Cns8iaPiomANpDEhUA/60MlYD9L 2QcQ== X-Forwarded-Encrypted: i=1; AJvYcCXPtQgCPYtuIydNC/KS4mIZopG7UCSC5bI7H2zSvxFChypFmFp9ZIE4PxOjyIIwqrDYkSQyLAKKyQ==@nongnu.org X-Gm-Message-State: AOJu0YyMak1293ZRxUU4CEzqVJvxbGdldvq6gXmcFKT18IY5mippuyJt NIZiHM3zb7fwowRifq6qVZ1dWzZyy9CbUjxhFrTrY6w6Zj2y1bECGuvddhDW8l6pKdE= X-Gm-Gg: ASbGnct2bNM/bhkAL23SHpR9fjsYd+j9jSjjpPepZgur6YzQ7fO0W2yx5llwLxW/Bne EuElZGX0N+DjHf014m75HNApKo+A5fGmjN9ZEvJ/Jca5MMBVAXpU8MI3ZCPf88vcwpTSsL16w7i EeCt2yqVuu+jIh1R2HqKJpOL66C9Nm+ScvMhft1FK9LvgSVlEabs6Lw5aSMG14CVwop5xXE+ZRf mn+cRZmc3majQliZto6uIPC7mLeSQfEAWBUiRVdoIq9FzFsWZMAFYKrw65CoipKBjRCSTe7Q85S QdIvq+oFHwr/iza2WgG0NcDFWYMe2VkiuIZATpi9GBzc2OCkPXrw63WfcwwmtRHa3rU+hSTv34T jI2tkIFBaEwpfyX1zy9/6SgXD3OreUvNRvGsxEBgpjPg= X-Google-Smtp-Source: AGHT+IF68756L99A9VzBRT2/V6cS0pnieY6wP4CjbVZVbV7SVoo+jCcCARvky1tubENTSz30QbmUbg== X-Received: by 2002:a17:90b:33c4:b0:316:d69d:49fb with SMTP id 98e67ed59e1d1-31a90b3d073mr4734170a91.14.1751455215922; Wed, 02 Jul 2025 04:20:15 -0700 (PDT) From: William Kosasih To: qemu-devel@nongnu.org Cc: Peter Maydell , qemu-arm@nongnu.org, William Kosasih Subject: [PATCH v3 04/12] target/arm: Fix VLDR helper load alignment checks Date: Wed, 2 Jul 2025 20:49:46 +0930 Message-ID: <20250702111954.128563-5-kosasihwilliam4@gmail.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250702111954.128563-1-kosasihwilliam4@gmail.com> References: <20250702111954.128563-1-kosasihwilliam4@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::52f; envelope-from=kosasihwilliam4@gmail.com; helo=mail-pg1-x52f.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1751455339721116600 Content-Type: text/plain; charset="utf-8" This patch adds alignment checks in the load operations in the VLDR instruction. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1154 Signed-off-by: William Kosasih Reviewed-by: Richard Henderson --- target/arm/tcg/mve_helper.c | 24 +++++++++++++----------- 1 file changed, 13 insertions(+), 11 deletions(-) diff --git a/target/arm/tcg/mve_helper.c b/target/arm/tcg/mve_helper.c index 506d1c3475..1db626bb26 100644 --- a/target/arm/tcg/mve_helper.c +++ b/target/arm/tcg/mve_helper.c @@ -148,13 +148,15 @@ static void mve_advance_vpt(CPUARMState *env) } =20 /* For loads, predicated lanes are zeroed instead of keeping their old val= ues */ -#define DO_VLDR(OP, MSIZE, LDTYPE, ESIZE, TYPE) \ +#define DO_VLDR(OP, MFLAG, MSIZE, MTYPE, LDTYPE, ESIZE, TYPE) \ void HELPER(mve_##OP)(CPUARMState *env, void *vd, uint32_t addr) \ { \ TYPE *d =3D vd; \ uint16_t mask =3D mve_element_mask(env); \ uint16_t eci_mask =3D mve_eci_mask(env); \ unsigned b, e; \ + int mmu_idx =3D arm_to_core_mmu_idx(arm_mmu_idx(env)); \ + MemOpIdx oi =3D make_memop_idx(MFLAG | MO_ALIGN, mmu_idx); \ /* \ * R_SXTM allows the dest reg to become UNKNOWN for abandoned \ * beats so we don't care if we update part of the dest and \ @@ -163,7 +165,7 @@ static void mve_advance_vpt(CPUARMState *env) for (b =3D 0, e =3D 0; b < 16; b +=3D ESIZE, e++) { = \ if (eci_mask & (1 << b)) { \ d[H##ESIZE(e)] =3D (mask & (1 << b)) ? \ - cpu_##LDTYPE##_data_ra(env, addr, GETPC()) : 0; \ + (MTYPE)cpu_##LDTYPE##_mmu(env, addr, oi, GETPC()) : 0;\ } \ addr +=3D MSIZE; \ } \ @@ -185,20 +187,20 @@ static void mve_advance_vpt(CPUARMState *env) mve_advance_vpt(env); \ } =20 -DO_VLDR(vldrb, 1, ldub, 1, uint8_t) -DO_VLDR(vldrh, 2, lduw, 2, uint16_t) -DO_VLDR(vldrw, 4, ldl, 4, uint32_t) +DO_VLDR(vldrb, MO_UB, 1, uint8_t, ldb, 1, uint8_t) +DO_VLDR(vldrh, MO_TEUW, 2, uint16_t, ldw, 2, uint16_t) +DO_VLDR(vldrw, MO_TEUL, 4, uint32_t, ldl, 4, uint32_t) =20 DO_VSTR(vstrb, 1, stb, 1, uint8_t) DO_VSTR(vstrh, 2, stw, 2, uint16_t) DO_VSTR(vstrw, 4, stl, 4, uint32_t) =20 -DO_VLDR(vldrb_sh, 1, ldsb, 2, int16_t) -DO_VLDR(vldrb_sw, 1, ldsb, 4, int32_t) -DO_VLDR(vldrb_uh, 1, ldub, 2, uint16_t) -DO_VLDR(vldrb_uw, 1, ldub, 4, uint32_t) -DO_VLDR(vldrh_sw, 2, ldsw, 4, int32_t) -DO_VLDR(vldrh_uw, 2, lduw, 4, uint32_t) +DO_VLDR(vldrb_sh, MO_UB, 1, int8_t, ldb, 2, int16_t) +DO_VLDR(vldrb_sw, MO_UB, 1, int8_t, ldb, 4, int32_t) +DO_VLDR(vldrb_uh, MO_UB, 1, uint8_t, ldb, 2, uint16_t) +DO_VLDR(vldrb_uw, MO_UB, 1, uint8_t, ldb, 4, uint32_t) +DO_VLDR(vldrh_sw, MO_TEUW, 2, int16_t, ldw, 4, int32_t) +DO_VLDR(vldrh_uw, MO_TEUW, 2, uint16_t, ldw, 4, uint32_t) =20 DO_VSTR(vstrb_h, 1, stb, 2, int16_t) DO_VSTR(vstrb_w, 1, stb, 4, int32_t) --=20 2.48.1