From nobody Sat Nov 15 14:09:41 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1751455345; cv=none; d=zohomail.com; s=zohoarc; b=dk8ea1gzMWzer9F+6XDkWbQ0oCMGXNOcSrsCzgZNPAO+3LJLdTsvLI2dUFZ14Rgq/pDFl91NdpiR88WTGnJk6R+iC210T00FAVsqbWoW7nH56VkoGx/LMf6EDdFVYUVHbP4jwLuwWtZl6sA83FIeu08l4JpVHmUO7XhMeRq8cbs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1751455345; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=CG0R9mTp11tTEY5zMYyUSL9wFDskVR0oTUKY6NSgROg=; b=gtUiVxNpAL8Z9a51Z0WfM24sD4BrXYFfVcQpFyFIQsTM2SDEw4ra2V/e9xTyNj+MLTCvJYMI29BnA1JlBssRi21N3mTxBbboseS1ujrXvAhhS0pzALKD+AoSZvZOo+GSY5p8XpF33cpCnbVw6+pr9MAoQUQ6GMCzPGEbikjjgCg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1751455345836568.5920286317809; Wed, 2 Jul 2025 04:22:25 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uWvWV-00082F-SA; Wed, 02 Jul 2025 07:21:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uWvWG-0007jY-CJ; Wed, 02 Jul 2025 07:20:53 -0400 Received: from mail-pf1-x42b.google.com ([2607:f8b0:4864:20::42b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uWvWE-0002TK-B2; Wed, 02 Jul 2025 07:20:52 -0400 Received: by mail-pf1-x42b.google.com with SMTP id d2e1a72fcca58-7426c44e014so6771828b3a.3; Wed, 02 Jul 2025 04:20:45 -0700 (PDT) Received: from localhost (pa49-178-74-199.pa.nsw.optusnet.com.au. [49.178.74.199]) by smtp.gmail.com with UTF8SMTPSA id d2e1a72fcca58-74af540b25dsm13618409b3a.25.2025.07.02.04.20.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Jul 2025 04:20:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1751455244; x=1752060044; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=CG0R9mTp11tTEY5zMYyUSL9wFDskVR0oTUKY6NSgROg=; b=kFxQTTbQflh+xqpEnbQOFBWzb3dOyAWPQ6fn6dhYMzwhhfC74f14O9U7lwYT1gkQKK kJFAB9osKWco3Ze+FDaD7+zjuslYCpAPJGle/JcVrldIY78vnIGKwdoYc+aaBdJ0F5Yo eeInJ3KXrLJfgZvJTXkxhXMUf8bFHW8g2xq9LE/53oWzjyR6cKYGmRiF/vyNCEJnMf6z 2JB+j4BpVDRbJT+8cP+qOTttS8jmO8PoJNcR9VlWal/vvW6fFEyj3l8YLpnJhN6L+FLs UXBaaD3pxl2smvNHHCqh/SQMwbenmeRKJx1go4tOdq2iXSyRQLQuLncOvUn3GAUrgZVz uG+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751455244; x=1752060044; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=CG0R9mTp11tTEY5zMYyUSL9wFDskVR0oTUKY6NSgROg=; b=bLjJTbA4KBstzI/eCuu4RjOMfbdr3C4wP6gzmKxRbkhdvE8FqauYC8tTMQN7AP2foH KzdFF5axzPrrEhXDfVruS43unuXFDxdP61DR2KLdwQVGmLOBX/sQ67ocuVBQ/3I/tMm+ MxKkD3LCjnfXf40pOFyfKMoS+4j9mklgZFcFEX11un9jPbpnNCLbZUUnQghwq3EQ8zXE C+wffXBJnh3fYhcedd05y+/pv6yuJ6LRVWOFF1MJNAuXXjme29A7fEkAjCUpAkuLmv3A qlhNDzG8dhdnAE5y0dpIIXJ/obrRrDT3VGhvksAnRLq0FXVkzqaJEeVyykjIU5TMEC38 cL7w== X-Forwarded-Encrypted: i=1; AJvYcCXFJivlMgg8RRYvjkIqrCE3I8SXY+eeng2rL90Wmrqy5X7Bp11KQs0gWIK5UodkANqXx4xvQ24c0Q==@nongnu.org X-Gm-Message-State: AOJu0YysMyNUxydxgVWevoM4IG1SpVrtt4Fzc/4gKkiGSGIl9g4ZrEUH oFblDGDuZMGzC1Oz9juq7CkZAS6Y05XVL9MbUjmDINmUk9zOUFbaxrnHQ3GS7YRIy2U= X-Gm-Gg: ASbGnctcSPejjSaVF1pO99t+5DsFLUdV4o6vYI6owJ8WZ1m+TpkUlgLSC16nt1O7zMr z9iBbaFJxAu4xoL2ZtLD/MWYGiRHWOpFR4cxhlzVAjYliBtpzKI1a2oB1PiRu1i4VGlCS1otHoP Izw+t01XYLeLxDAKCKkOoN5BrrEnU7vQ0UtYJ27McH6AQmHhJD6gBHk0i4AlEiiQ1Y4koV1Rt8J jABkKDj95nu7h6uAVdi+7u/yH44Gtj4vXE9HLDeFtybJeWXtYhsKzrnP0E0IOtAixO72tF3VEAE djGgypodLebQafqDpxTA7yUjHUEczV+xC/EqMmaD/doXZmaaMn2Sitm9oOWtsAiR6lCbeaHCvE/ Jja4bBwceDE5yQDkWsAX/fpM8IOgp/RNN6nNcpJJ2ye0= X-Google-Smtp-Source: AGHT+IElJEuVhFGDph6uYrqCcNgauUJTZ9XZAiOexT5cP08OgEuzPmwxoSOTASNG/Fm7AojufZpSqQ== X-Received: by 2002:a05:6a21:e8a:b0:220:eef:e8f0 with SMTP id adf61e73a8af0-222d7e90b1dmr4775419637.23.1751455244156; Wed, 02 Jul 2025 04:20:44 -0700 (PDT) From: William Kosasih To: qemu-devel@nongnu.org Cc: Peter Maydell , qemu-arm@nongnu.org, William Kosasih Subject: [PATCH v3 11/12] target/arm: Fix VST2 helper store alignment checks Date: Wed, 2 Jul 2025 20:49:53 +0930 Message-ID: <20250702111954.128563-12-kosasihwilliam4@gmail.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250702111954.128563-1-kosasihwilliam4@gmail.com> References: <20250702111954.128563-1-kosasihwilliam4@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::42b; envelope-from=kosasihwilliam4@gmail.com; helo=mail-pf1-x42b.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1751455348036116600 Content-Type: text/plain; charset="utf-8" This patch adds alignment checks in the store operations in the VST2 instruction. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1154 Signed-off-by: William Kosasih Reviewed-by: Richard Henderson --- target/arm/tcg/mve_helper.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/target/arm/tcg/mve_helper.c b/target/arm/tcg/mve_helper.c index 185f6efeab..5dd2585684 100644 --- a/target/arm/tcg/mve_helper.c +++ b/target/arm/tcg/mve_helper.c @@ -669,6 +669,8 @@ DO_VST4W(vst43w, 6, 7, 8, 9) static const uint8_t off[4] =3D { O1, O2, O3, O4 }; \ uint32_t addr, data; \ uint8_t *qd; \ + int mmu_idx =3D arm_to_core_mmu_idx(arm_mmu_idx(env)); \ + MemOpIdx oi =3D make_memop_idx(MO_TEUL | MO_ALIGN, mmu_idx); \ for (beat =3D 0; beat < 4; beat++, mask >>=3D 4) { = \ if ((mask & 1) =3D=3D 0) { = \ /* ECI says skip this beat */ \ @@ -680,7 +682,7 @@ DO_VST4W(vst43w, 6, 7, 8, 9) qd =3D (uint8_t *)aa32_vfp_qreg(env, qnidx + (e & 1)); \ data =3D (data << 8) | qd[H1(off[beat] + (e >> 1))]; \ } \ - cpu_stl_le_data_ra(env, addr, data, GETPC()); \ + cpu_stl_mmu(env, addr, data, oi, GETPC()); \ } \ } =20 @@ -694,6 +696,8 @@ DO_VST4W(vst43w, 6, 7, 8, 9) uint32_t addr, data; \ int e; \ uint16_t *qd; \ + int mmu_idx =3D arm_to_core_mmu_idx(arm_mmu_idx(env)); \ + MemOpIdx oi =3D make_memop_idx(MO_TEUL | MO_ALIGN, mmu_idx); \ for (beat =3D 0; beat < 4; beat++, mask >>=3D 4) { = \ if ((mask & 1) =3D=3D 0) { = \ /* ECI says skip this beat */ \ @@ -705,7 +709,7 @@ DO_VST4W(vst43w, 6, 7, 8, 9) qd =3D (uint16_t *)aa32_vfp_qreg(env, qnidx + e); \ data =3D (data << 16) | qd[H2(off[beat])]; \ } \ - cpu_stl_le_data_ra(env, addr, data, GETPC()); \ + cpu_stl_mmu(env, addr, data, oi, GETPC()); \ } \ } =20 @@ -718,6 +722,8 @@ DO_VST4W(vst43w, 6, 7, 8, 9) static const uint8_t off[4] =3D { O1, O2, O3, O4 }; \ uint32_t addr, data; \ uint32_t *qd; \ + int mmu_idx =3D arm_to_core_mmu_idx(arm_mmu_idx(env)); \ + MemOpIdx oi =3D make_memop_idx(MO_TEUL | MO_ALIGN, mmu_idx); \ for (beat =3D 0; beat < 4; beat++, mask >>=3D 4) { = \ if ((mask & 1) =3D=3D 0) { = \ /* ECI says skip this beat */ \ @@ -726,7 +732,7 @@ DO_VST4W(vst43w, 6, 7, 8, 9) addr =3D base + off[beat]; \ qd =3D (uint32_t *)aa32_vfp_qreg(env, qnidx + (beat & 1)); \ data =3D qd[H4(off[beat] >> 3)]; \ - cpu_stl_le_data_ra(env, addr, data, GETPC()); \ + cpu_stl_mmu(env, addr, data, oi, GETPC()); \ } \ } =20 --=20 2.48.1