From nobody Sat Nov 15 14:09:43 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1751455329; cv=none; d=zohomail.com; s=zohoarc; b=mlKmDLJLGubV6EBGhjUwQqxAJWJGSNtmBK2h1BYQuYFvFgMTS/ddWqfE57vVrXC9CZx151UDm4DbFRL1LwTnhrVgM02ENWeg9afIskw5ncPb6IEMaDyud0Y4O7leqBz/TdWOIiuvmYkCOvrdSHm+YQj9eKsjZn4wssJm+Acx3Gw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1751455329; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=TmGCorEGQlW7KnyvSorg2owRSTnel+NvEASPcPe6Kxg=; b=FAhz4390OwXm9XUKLeJ9Ugh5TXAE2rkN50USGgeWjF1gx8kAbpKGS49g3GAQokNKeViXyHuO7jYs6Z/C9LU7HAYNMgL2c0OeI494Gc2vfjE4B4JaE+C7+NJwam5vf+oOg0WzjafqxLBleWJt4ySJizQIo50m5mqoB/msuIhLI04= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1751455329388802.5317950109462; Wed, 2 Jul 2025 04:22:09 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uWvWQ-0007lN-5c; Wed, 02 Jul 2025 07:21:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uWvWB-0007hU-Fy; Wed, 02 Jul 2025 07:20:48 -0400 Received: from mail-pf1-x436.google.com ([2607:f8b0:4864:20::436]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uWvW5-0002Rp-3f; Wed, 02 Jul 2025 07:20:47 -0400 Received: by mail-pf1-x436.google.com with SMTP id d2e1a72fcca58-747c2cc3419so6290216b3a.2; Wed, 02 Jul 2025 04:20:37 -0700 (PDT) Received: from localhost (pa49-178-74-199.pa.nsw.optusnet.com.au. [49.178.74.199]) by smtp.gmail.com with UTF8SMTPSA id d2e1a72fcca58-74af541a3e4sm13688454b3a.37.2025.07.02.04.20.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Jul 2025 04:20:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1751455236; x=1752060036; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=TmGCorEGQlW7KnyvSorg2owRSTnel+NvEASPcPe6Kxg=; b=d2lUAlP81WBhp8W8Wc1V6ByYcDfla6Dl9zcxRfa3EexWsCerNwJOcnStFU4h3+Sr9t 5Gx9Y43zNN/sGE5qLcuygTyWZrAnteM7rusfAruO2aapvhqqQGavnvf0eqQwY1dqZlrH arevpDLZQoJuFRh5D4CT706JBBRGf+pfZVAz2ONaRUPv9LE20Mjw4LgghWYXiKLtf8lJ 0+urCn0Q6nL59/t9RdI7gPPppQD/hZRptEVc2O/1jxu3c1BH14y3FVBcd/foso/1P9Iz aYJWDAXtYsUUWiWZiHz8dMbiMkoibXtxsEXtzmvJFziPtwCRmDYd9iL2bZxsFnN0vjjh n/Qw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751455236; x=1752060036; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TmGCorEGQlW7KnyvSorg2owRSTnel+NvEASPcPe6Kxg=; b=P6WqysNOBofEocU9nQQQExehdJnfMsR4KRqQP3KO+C78t+nYmsPBkfr4qODZ987Iep t5lG2WRUpk8emt+nB6sVq1f6+b21xLbydx/KpfxW8fjbN+fViy5hJ6fNl5u60gbv0H8c Kt6/mIrmmJCTMiAcPMQ/RAjRN5RdH8CE84q31V+0dshlHvKEPVUB9s49X0EBMmcz+B2j qz9pOsxCWZlzbjzcpnpcoAhyqjmfiDw6n6U6Qy6ANFSx2TQUtqBb6VGZwDKulS2BLjGr Hd2ii3MVBniCgmB74sMn313/FEL2xJx/XupS/x0lCc2Owf2uJ57O76NTp5MIdhDnVAoD SKoA== X-Forwarded-Encrypted: i=1; AJvYcCWVdQJR7sb28Ih4bndry2agczO1HO3XjZQ9A0tx1DRzMXBnEjwL3fitYjPzO9dEwoRLIOpNnmqsbw==@nongnu.org X-Gm-Message-State: AOJu0Yw+eDEdP9QxmvOvqSQHUKyU0KbLC8+AatZSje6Rt010GGSNCndu xTZvlb2gSfN38R47aeJXuqmPNmwIzE7gj+gHvVsoTMGWwGQm7ltt/jtLQUt80bThC8Q= X-Gm-Gg: ASbGncuittJfBHWjuzC01IpXmUd7a7abCFa3Wh0CGEjW2yyK4Wwvqu/yp4dzCXCzW4W v+r2PoJd9VkyVAYVVADtpynFQTXSXjqh0Ws3PiIkU+KQTi/nUaSLSZoTn6Dz3HFhY1GPQkXsinY cJu31M5MisHXq+OUUZ5Isr2NfDcPuYSP8Fws7GH49nx3//J5ToW6yB4ZlOgcsZ3LDx6Nbr4kE+t 04Xtn+w3QHH7ytCMuf4I2HsEgpICWqTJE5Fic5jwk9jAtQcHSuvgDVexEPubDYBvSIwI/5vtk8k M4ORu4xtMxjPMILzHju+qPXawWhwpgdqARe7hJXbFbS6YIGaeq084Ag1r9E025yme7F9HSo+6dE 7UXV3uowhYSxjMatSidPGLvR1veO2zO3RbOnZNJT//Xg= X-Google-Smtp-Source: AGHT+IHmtW7yRIksNRadponOnePQ6rm+E08HySMZIYnNNVgebA2ajNRbYwSp0diz22YJtkG0xyM7dg== X-Received: by 2002:a05:6a00:1995:b0:749:1c27:bcc5 with SMTP id d2e1a72fcca58-74b5126948bmr3175468b3a.22.1751455236063; Wed, 02 Jul 2025 04:20:36 -0700 (PDT) From: William Kosasih To: qemu-devel@nongnu.org Cc: Peter Maydell , qemu-arm@nongnu.org, William Kosasih Subject: [PATCH v3 09/12] target/arm: Fix VLD2 helper load alignment checks Date: Wed, 2 Jul 2025 20:49:51 +0930 Message-ID: <20250702111954.128563-10-kosasihwilliam4@gmail.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250702111954.128563-1-kosasihwilliam4@gmail.com> References: <20250702111954.128563-1-kosasihwilliam4@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::436; envelope-from=kosasihwilliam4@gmail.com; helo=mail-pf1-x436.google.com X-Spam_score_int: -13 X-Spam_score: -1.4 X-Spam_bar: - X-Spam_report: (-1.4 / 5.0 requ) BAYES_00=-1.9, DKIM_INVALID=0.1, DKIM_SIGNED=0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1751455329729116600 Content-Type: text/plain; charset="utf-8" This patch adds alignment checks in the load operations in the VLD2 instruction. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1154 Signed-off-by: William Kosasih Reviewed-by: Richard Henderson --- target/arm/tcg/mve_helper.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/target/arm/tcg/mve_helper.c b/target/arm/tcg/mve_helper.c index 86eef54426..d6e2f1ac5a 100644 --- a/target/arm/tcg/mve_helper.c +++ b/target/arm/tcg/mve_helper.c @@ -495,13 +495,15 @@ DO_VLD4W(vld43w, 6, 7, 8, 9) static const uint8_t off[4] =3D { O1, O2, O3, O4 }; \ uint32_t addr, data; \ uint8_t *qd; \ + int mmu_idx =3D arm_to_core_mmu_idx(arm_mmu_idx(env)); \ + MemOpIdx oi =3D make_memop_idx(MO_TEUL | MO_ALIGN, mmu_idx); \ for (beat =3D 0; beat < 4; beat++, mask >>=3D 4) { = \ if ((mask & 1) =3D=3D 0) { = \ /* ECI says skip this beat */ \ continue; \ } \ addr =3D base + off[beat] * 2; \ - data =3D cpu_ldl_le_data_ra(env, addr, GETPC()); \ + data =3D cpu_ldl_mmu(env, addr, oi, GETPC()); \ for (e =3D 0; e < 4; e++, data >>=3D 8) { = \ qd =3D (uint8_t *)aa32_vfp_qreg(env, qnidx + (e & 1)); \ qd[H1(off[beat] + (e >> 1))] =3D data; \ @@ -519,13 +521,15 @@ DO_VLD4W(vld43w, 6, 7, 8, 9) uint32_t addr, data; \ int e; \ uint16_t *qd; \ + int mmu_idx =3D arm_to_core_mmu_idx(arm_mmu_idx(env)); \ + MemOpIdx oi =3D make_memop_idx(MO_TEUL | MO_ALIGN, mmu_idx); \ for (beat =3D 0; beat < 4; beat++, mask >>=3D 4) { = \ if ((mask & 1) =3D=3D 0) { = \ /* ECI says skip this beat */ \ continue; \ } \ addr =3D base + off[beat] * 4; \ - data =3D cpu_ldl_le_data_ra(env, addr, GETPC()); \ + data =3D cpu_ldl_mmu(env, addr, oi, GETPC()); \ for (e =3D 0; e < 2; e++, data >>=3D 16) { = \ qd =3D (uint16_t *)aa32_vfp_qreg(env, qnidx + e); \ qd[H2(off[beat])] =3D data; \ @@ -542,13 +546,15 @@ DO_VLD4W(vld43w, 6, 7, 8, 9) static const uint8_t off[4] =3D { O1, O2, O3, O4 }; \ uint32_t addr, data; \ uint32_t *qd; \ + int mmu_idx =3D arm_to_core_mmu_idx(arm_mmu_idx(env)); \ + MemOpIdx oi =3D make_memop_idx(MO_TEUL | MO_ALIGN, mmu_idx); \ for (beat =3D 0; beat < 4; beat++, mask >>=3D 4) { = \ if ((mask & 1) =3D=3D 0) { = \ /* ECI says skip this beat */ \ continue; \ } \ addr =3D base + off[beat]; \ - data =3D cpu_ldl_le_data_ra(env, addr, GETPC()); \ + data =3D cpu_ldl_mmu(env, addr, oi, GETPC()); \ qd =3D (uint32_t *)aa32_vfp_qreg(env, qnidx + (beat & 1)); \ qd[H4(off[beat] >> 3)] =3D data; \ } \ --=20 2.48.1