From nobody Tue Feb 10 12:59:21 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1751453171; cv=none; d=zohomail.com; s=zohoarc; b=Aenyw8WxYz80crj1Z10qvUXY6CN4OW5CaUuES6ZkbEEaE+5TbUyNfs53ncF63umKnCUvCzqpTJ4hsfL376cEtg/HYsTvPZ+N7OZBGGw6yXNA+zWhBV2eCfH78mCe0bGRF9hkTOpNLGPzmpceNVdupnGq6UQbhSyFE5e9W98Dr08= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1751453171; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=kaLVJH5otwR+otl8BtaHu4M3HmdksGlIfafwyt6VO9Q=; b=Wrsq0JQO6D246OSzjc1uqbATIRODF8zzdSXZDDkVTUI5miPtWk9vL2IdYK4bWMo0kr6koOH+9ZHlVqLk0GZdUo+JaDLi+FZnpBUawH8i7+0cZyLgfubAUMcoDLJE7uKCl3PnjipksnFcuJg2/PinZdWgTSp2MqCPYVhGuE2bhbg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1751453171537462.7294486414652; Wed, 2 Jul 2025 03:46:11 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uWuwl-0006kv-Q1; Wed, 02 Jul 2025 06:44:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uWuwU-0006eQ-HJ for qemu-devel@nongnu.org; Wed, 02 Jul 2025 06:43:55 -0400 Received: from mail-ej1-x633.google.com ([2a00:1450:4864:20::633]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uWuwL-0001JM-Pf for qemu-devel@nongnu.org; Wed, 02 Jul 2025 06:43:52 -0400 Received: by mail-ej1-x633.google.com with SMTP id a640c23a62f3a-ade76b8356cso812972766b.2 for ; Wed, 02 Jul 2025 03:43:45 -0700 (PDT) Received: from draig.lan ([185.126.160.19]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ae353c6beb8sm1060962966b.132.2025.07.02.03.43.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Jul 2025 03:43:41 -0700 (PDT) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id 58BBB5F8DC; Wed, 02 Jul 2025 11:43:37 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1751453024; x=1752057824; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=kaLVJH5otwR+otl8BtaHu4M3HmdksGlIfafwyt6VO9Q=; b=U0I/Pjw4yQ+qGpnQ00Um23qEiFY2d76dZWe4YSdq7lR4fZOg8+YhCAfEIXqUPvOHIy M6HqpMGLnftFNBbf7SKAtcgF7mcKMi7FK6H7lUsJ2VfWc/SBO4vQWqLjirc4rZK0OOSc oMSQ8R7FADGrzePvfE1vKBn3H5h8JEOeLIVNX3u9HPniGYSPyy+LjIDuca3bWaGZ/G3X k+a/WXGt9QEig9qLktnplwnPDXyiRBf2Hz5hOnqi6ixz6DwetiKKC0mvupuutjwsSjLk zqIoih9/Ee5WglvFVzu0+XmWDCX0hibBM1THSZt6H29cRrmXBM1yrsTbCKG7rOs/yw/q 4C+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751453024; x=1752057824; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kaLVJH5otwR+otl8BtaHu4M3HmdksGlIfafwyt6VO9Q=; b=CuggZoOQ42CLAIPipI6KS1WxoxgYw3wV9pGEFpHON5lktxkJEnGpWk6XF607AsPQBJ KRBhOim3m1RWd/2yJDJoJEGdriGp6u8cxdW6FlY65ek6nDaV69p0H5ZZqkMmqtWj+2HN kRkmfh29U7hmA/L8iJxkOAhndxy5HEMzh0pB9+TWg8gATzhxuAr1N5TVocbOre2d3fXv LlDkWF081ly9XsIpI9ZKxVeL11EEW1Laux/lEYvjWoiSxZjjuwWY/zczOaJ5RnV/DZos GBuZS4mwTNaY+MyNag7iHDojPOcAis8EVMpH+E8UmOwI7Xbdba3d/T0RdciJDhTZ638X TlXw== X-Gm-Message-State: AOJu0YwPVEGUhFsR/mSRFF5IKUy+wbzegDtfm0W48GcjHfnTsd9SZIQh ANGUlgan8MZZnPGCEtUxAbv2cFGcQza3oKKw/C4jhMRwy/aCgk+8/2GUzmUnRKU+m/I= X-Gm-Gg: ASbGncueipyyiHRH1sm25YkYh3r35LPoMZWM85sg9A3uPgnX6spKWdp/dgAYj69rARr HZxDwdBCcz/trYThxNvcXGe8W+H8C/EQZcHbuqSZ10xGXB6yO701YACLU++9m2p3ehzyDXo4OLY WP226aBgCHtxBzefIKjbr51bgO76hi1mCuxbctWW/LSO+AfdRLqVvjkaELcISNyeJSWUqnLNsAJ Xy2c+Akss6+1LI3P0KWZsy6S/SQXJMG0qj2hH1vk6yOkeqN1+Qyy75Wr41vmXvmv2Nve3t5IJO9 Rjdt6SRGHCdGjeTX2Mu93gBxSxVGgOI0utQ6nmAIigFc5TPogXeUIAS86qpDeSg= X-Google-Smtp-Source: AGHT+IGfG0hqmHObkpn85ZZexJNP5SCrV/mcs4v1eRzc/oedO5BMRQv7ZewlZzWk+d4N2IIgF9fuRQ== X-Received: by 2002:a17:906:dc93:b0:ae3:b22c:2ee3 with SMTP id a640c23a62f3a-ae3c2dc4229mr235042366b.31.1751453023745; Wed, 02 Jul 2025 03:43:43 -0700 (PDT) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: Rowan Hart , Pierrick Bouvier , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Alexandre Iooss , Mahmoud Mandour Subject: [PULL 06/15] plugins: Add register write API Date: Wed, 2 Jul 2025 11:43:27 +0100 Message-ID: <20250702104336.3775206-7-alex.bennee@linaro.org> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250702104336.3775206-1-alex.bennee@linaro.org> References: <20250702104336.3775206-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::633; envelope-from=alex.bennee@linaro.org; helo=mail-ej1-x633.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1751453173222116600 From: Rowan Hart This patch adds a function to the plugins API to allow plugins to write register contents. It also moves the qemu_plugin_read_register function so all the register-related functions are grouped together in the file. Reviewed-by: Pierrick Bouvier Signed-off-by: Rowan Hart Message-ID: <20250624175351.440780-3-rowanbhart@gmail.com> Signed-off-by: Alex Benn=C3=A9e Message-ID: <20250627112512.1880708-7-alex.bennee@linaro.org> diff --git a/include/qemu/qemu-plugin.h b/include/qemu/qemu-plugin.h index 3a850aa216..cfe1692ecb 100644 --- a/include/qemu/qemu-plugin.h +++ b/include/qemu/qemu-plugin.h @@ -871,7 +871,8 @@ struct qemu_plugin_register; /** * typedef qemu_plugin_reg_descriptor - register descriptions * - * @handle: opaque handle for retrieving value with qemu_plugin_read_regis= ter + * @handle: opaque handle for retrieving value with qemu_plugin_read_regis= ter or + * writing value with qemu_plugin_write_register * @name: register name * @feature: optional feature descriptor, can be NULL */ @@ -893,6 +894,41 @@ typedef struct { QEMU_PLUGIN_API GArray *qemu_plugin_get_registers(void); =20 +/** + * qemu_plugin_read_register() - read register for current vCPU + * + * @handle: a @qemu_plugin_reg_handle handle + * @buf: A GByteArray for the data owned by the plugin + * + * This function is only available in a context that register read access = is + * explicitly requested via the QEMU_PLUGIN_CB_R_REGS flag. + * + * Returns the size of the read register. The content of @buf is in target= byte + * order. On failure returns -1. + */ +QEMU_PLUGIN_API +int qemu_plugin_read_register(struct qemu_plugin_register *handle, + GByteArray *buf); + +/** + * qemu_plugin_write_register() - write register for current vCPU + * + * @handle: a @qemu_plugin_reg_handle handle + * @buf: A GByteArray for the data owned by the plugin + * + * This function is only available in a context that register write access= is + * explicitly requested via the QEMU_PLUGIN_CB_RW_REGS flag. + * + * The size of @buf must be at least the size of the requested register. + * Attempting to write a register with @buf smaller than the register size + * will result in a crash or other undesired behavior. + * + * Returns the number of bytes written. On failure returns 0. + */ +QEMU_PLUGIN_API +int qemu_plugin_write_register(struct qemu_plugin_register *handle, + GByteArray *buf); + /** * qemu_plugin_read_memory_vaddr() - read from memory using a virtual addr= ess * @@ -915,22 +951,6 @@ QEMU_PLUGIN_API bool qemu_plugin_read_memory_vaddr(uint64_t addr, GByteArray *data, size_t len); =20 -/** - * qemu_plugin_read_register() - read register for current vCPU - * - * @handle: a @qemu_plugin_reg_handle handle - * @buf: A GByteArray for the data owned by the plugin - * - * This function is only available in a context that register read access = is - * explicitly requested via the QEMU_PLUGIN_CB_R_REGS flag. - * - * Returns the size of the read register. The content of @buf is in target= byte - * order. On failure returns -1. - */ -QEMU_PLUGIN_API -int qemu_plugin_read_register(struct qemu_plugin_register *handle, - GByteArray *buf); - /** * qemu_plugin_scoreboard_new() - alloc a new scoreboard * diff --git a/plugins/api.c b/plugins/api.c index 3c9d4832e9..6514f2c76a 100644 --- a/plugins/api.c +++ b/plugins/api.c @@ -433,6 +433,25 @@ GArray *qemu_plugin_get_registers(void) return create_register_handles(regs); } =20 +int qemu_plugin_read_register(struct qemu_plugin_register *reg, GByteArray= *buf) +{ + g_assert(current_cpu); + + return gdb_read_register(current_cpu, buf, GPOINTER_TO_INT(reg) - 1); +} + +int qemu_plugin_write_register(struct qemu_plugin_register *reg, + GByteArray *buf) +{ + g_assert(current_cpu); + + if (buf->len =3D=3D 0 || qemu_plugin_get_cb_flags() !=3D QEMU_PLUGIN_C= B_RW_REGS) { + return -1; + } + + return gdb_write_register(current_cpu, buf->data, GPOINTER_TO_INT(reg)= - 1); +} + bool qemu_plugin_read_memory_vaddr(uint64_t addr, GByteArray *data, size_t= len) { g_assert(current_cpu); @@ -453,13 +472,6 @@ bool qemu_plugin_read_memory_vaddr(uint64_t addr, GByt= eArray *data, size_t len) return true; } =20 -int qemu_plugin_read_register(struct qemu_plugin_register *reg, GByteArray= *buf) -{ - g_assert(current_cpu); - - return gdb_read_register(current_cpu, buf, GPOINTER_TO_INT(reg) - 1); -} - struct qemu_plugin_scoreboard *qemu_plugin_scoreboard_new(size_t element_s= ize) { return plugin_scoreboard_new(element_size); --=20 2.47.2