From nobody Sat Nov 15 14:52:50 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1751390379; cv=none; d=zohomail.com; s=zohoarc; b=dYA5V0fyfijaWlIoqTABZDQ5tjW1JD3zSSNWR2sSWJNb3cDRPEdvt/KvxfsjAWIBlm2ZJYTOqhMeIKdJjieWKod4+Xmhy3zpQTG45e0AcgQcz4VD7C9n+dTVyOTuG8Xx3K9SXrP88s91XqzvR7N3mS+sqawaHWc3fxjMGzasP2c= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1751390379; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=z3FS3pa/hJFQ3XazBFwVcLs+0F58UEBEFoq6YVldz6U=; b=XP5cawuKWktt/nZUFSp6f3V9T2JWwDiA1pY+JOqsxzMoeCaBFAKhB89P6ZmGOe+dYzbIVFsQUqpuA6t5bbMzrdWMr+0E/i3sc5OG1rDNc5N4Y2RmrEMCmS2hJz5Yjk+1EqmTDDLE3/qL9sWGN36r8FLNGIB8FvaMLdrW5kEbiJc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1751390379038299.86208542710597; Tue, 1 Jul 2025 10:19:39 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uWeSV-0005aV-7Y; Tue, 01 Jul 2025 13:07:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uWeSU-0005Zv-1I for qemu-devel@nongnu.org; Tue, 01 Jul 2025 13:07:50 -0400 Received: from mail-wm1-x32a.google.com ([2a00:1450:4864:20::32a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uWeSM-0003TT-4l for qemu-devel@nongnu.org; Tue, 01 Jul 2025 13:07:49 -0400 Received: by mail-wm1-x32a.google.com with SMTP id 5b1f17b1804b1-453643020bdso51657425e9.1 for ; Tue, 01 Jul 2025 10:07:40 -0700 (PDT) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [2001:8b0:1d0::2]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a88c80bb28sm13475658f8f.43.2025.07.01.10.07.38 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Jul 2025 10:07:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1751389659; x=1751994459; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=z3FS3pa/hJFQ3XazBFwVcLs+0F58UEBEFoq6YVldz6U=; b=TzohPTUJMTJvoiIqux5j4dC3P6SONAniudz7JGUTaOwtqerxgiTCcaMA86PiLUhX1l PS5q+kA4SPce89GeQKUZfMRvrwGyhVVu6KrVZ038ApDRefRHzpe+fE5yFt/B3PMj0SHq Dv5J/yF0Ys8s1urF+OKWIY2IoDur6j+odBjb7HpF3xBt79shEhcdFNPkek2RUgYDlRRO 8b+gIGdjkLzszS3/WohZIRGAdhaVBO/jP3vsi8/248cE/nJo2sQwmxwOyoLnmJQ5tw5G QNhgYsafHAhAPaT88kiSmw4pYdMZB+bCi1NVMGoZOVH48L6ni3vNWiOkGGzOstBZx9NF UxNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751389659; x=1751994459; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=z3FS3pa/hJFQ3XazBFwVcLs+0F58UEBEFoq6YVldz6U=; b=N6LSs0mf0sNRIwtUgfbaCf2LqTp7DWSReHJuVGqwFfmwcMGhfZmE3IRuuSa+fwatr7 jaETVlPnhSIWj4Bpyh5bJufI+Brgi9QesvfKbB39jURA6Nb1/n8QKd2B+GRJA0iyxo3y kYjKDRzNshlBtSCMwmofojof0hMfJWmuoIYw7OUYBRG6dM4sCIzSv1NBnNhiL4zD4lj2 rbSpMylCuY4uYh13DfIz94le+GhoyLKk2k+VnYKPfOBVtsKPT+NKp6enaCCdZ666sxz0 olTJTWeocI3hZZ8yUxpbPeVU6DsDjOWDGCysJlGGMxJO3gxSz7NRMUN8UvNAD9kInbJ/ wNFQ== X-Gm-Message-State: AOJu0YwJ121OFqSlWbG/7rH0a+FaEhjOvm9x06gULV7p4vIQiYiplc3I cSvJHl2yfGr+yqHSt1BeUf1YVGyBvscQGhIZS+1OICBiGtaZ+bPrHTqICjONwuL2u3Tmbuexldp f4+IB X-Gm-Gg: ASbGncslhJ8/+7vSN76Tb/ZeWMYrGxLgWMM03MmBiArjdLbaicgB7yYHOpwk9u0mV/E PLM8eLKlj9xWU3wL6/WSNixuxZaPypk28nSrJJMS9boqbC/0Hw9gXzYmeV/v6YRXiqAKm8QLTb0 9KOV6Mz++7B03RhUJcH2cADklXK9Ygk/dy8oX48JLj3BHQVkqzRTI8GXHMwaaNiM7kRVvEJJmox PKyLYQe/Dfim9oy5U3dV9U7CGHHXLioz9bd3cj6ao3Xwge7ucqgVf+y7eYZjQtNK7FzZdPYaBeg 2IeW3mN+1fSDDinjjmpINYP23AwPbt7nY7QvxpXgVmBLfzhCpXvBjhCsT9XfDYLrllRj X-Google-Smtp-Source: AGHT+IGhBDCQYHsFrr/puJelHd/xRVxXX7WYwqJiMBBfDNblxcIQnGFURb9On6widWE1YW9ojTGwZQ== X-Received: by 2002:a05:6000:4407:b0:3a5:52cc:346e with SMTP id ffacd0b85a97d-3a8fdb2accemr9792969f8f.6.1751389658928; Tue, 01 Jul 2025 10:07:38 -0700 (PDT) From: Peter Maydell To: qemu-devel@nongnu.org Subject: [PULL 16/43] hw/arm/virt: Simplify logic for setting instance's 'tcg_its' variable Date: Tue, 1 Jul 2025 18:06:52 +0100 Message-ID: <20250701170720.4072660-17-peter.maydell@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250701170720.4072660-1-peter.maydell@linaro.org> References: <20250701170720.4072660-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32a; envelope-from=peter.maydell@linaro.org; helo=mail-wm1-x32a.google.com X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, DKIM_INVALID=0.1, DKIM_SIGNED=0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1751390380865116600 From: Gustavo Romero Because 'tcg_its' in the machine instance is set based on the machine class=E2=80=99s negated variable 'no_tcg_its', 'tcg_its' is the opposite of 'no_tcg_its' and hence the code in question can be simplified as: tcg_its =3D !no_tcg_its. Signed-off-by: Gustavo Romero Reviewed-by: Eric Auger Message-id: 20250628195722.977078-3-gustavo.romero@linaro.org Signed-off-by: Peter Maydell --- hw/arm/virt.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/hw/arm/virt.c b/hw/arm/virt.c index 99fde5836c9..6d9256a5255 100644 --- a/hw/arm/virt.c +++ b/hw/arm/virt.c @@ -3342,12 +3342,8 @@ static void virt_instance_init(Object *obj) =20 /* Default allows ITS instantiation */ vms->its =3D true; - - if (vmc->no_tcg_its) { - vms->tcg_its =3D false; - } else { - vms->tcg_its =3D true; - } + /* Allow ITS emulation if the machine version supports it */ + vms->tcg_its =3D !vmc->no_tcg_its; =20 /* Default disallows iommu instantiation */ vms->iommu =3D VIRT_IOMMU_NONE; --=20 2.43.0