From nobody Sat Nov 15 14:53:47 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=suse.de ARC-Seal: i=1; a=rsa-sha256; t=1751313905; cv=none; d=zohomail.com; s=zohoarc; b=OfBXeM49cl2dht3hT1AZ5RWZNwBMUjmwgGxM/cfDnjLqNgkBV5fjdvDN4conckjsvQKX4zQGNeh1Z+1z14V1kada5+UFed1GSmGaSKiDF+4PudeLHFRx5vzdq2ETw1a/9FN4BtBYZIq9zxcOa0T+imX7SMoyZti7hPB+5Fn3xKE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1751313905; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=OMnsDqpS7mN5ekbzq6rLUj1Jtd21FawuezqRU1AIOxE=; b=B/Mp1rBewvtiOUtZjNTE0OkbUKH/wCZub8gbXyU85B4yHnTozqd4WF8cWpxx+YIjgw8gEOc4k/81uNBnjq3wLb2FKwTT23VoNeobfC6Mh4rPFzpkR4BgGTD7rWFuflIgfLsrbMaDIYeiFJkpykTY67v1Trg00dhwbmPtrkIAwBU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1751313905117480.5155980629979; Mon, 30 Jun 2025 13:05:05 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uWKgX-0005mX-9C; Mon, 30 Jun 2025 16:01:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uWKgF-00059p-Br for qemu-devel@nongnu.org; Mon, 30 Jun 2025 16:00:43 -0400 Received: from smtp-out1.suse.de ([195.135.223.130]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uWKgD-0007mk-IM for qemu-devel@nongnu.org; Mon, 30 Jun 2025 16:00:43 -0400 Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 810D021161; Mon, 30 Jun 2025 20:00:04 +0000 (UTC) Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 71F791399F; Mon, 30 Jun 2025 20:00:02 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id KG35DMLsYmhQUAAAD6G6ig (envelope-from ); Mon, 30 Jun 2025 20:00:02 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1751313604; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OMnsDqpS7mN5ekbzq6rLUj1Jtd21FawuezqRU1AIOxE=; b=SOyg5eilBG96Xgweic7QpojL5RNpbLiDFTv2YpjnoxsXcYhXWbsXCx7hy9Bc3UbcnWyFgQ 9H0lBS6SxaQMlKXuZAbRJzKjUCYEIzIuZFwIr3ii2ENN+sv1fu2KKz/7xmN1CQ/R5pTcej nHfItiG8i8OCuYztIR4T5J64RZlORVI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1751313604; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OMnsDqpS7mN5ekbzq6rLUj1Jtd21FawuezqRU1AIOxE=; b=u4T9Up066SayiMCh1tGi/xzVTuJpAhXlkANSFlRrZkkJIEGUtMas/56r7hC0wJUYrSG04+ Rv2XZ2Wy7KlkJJCA== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1751313604; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OMnsDqpS7mN5ekbzq6rLUj1Jtd21FawuezqRU1AIOxE=; b=SOyg5eilBG96Xgweic7QpojL5RNpbLiDFTv2YpjnoxsXcYhXWbsXCx7hy9Bc3UbcnWyFgQ 9H0lBS6SxaQMlKXuZAbRJzKjUCYEIzIuZFwIr3ii2ENN+sv1fu2KKz/7xmN1CQ/R5pTcej nHfItiG8i8OCuYztIR4T5J64RZlORVI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1751313604; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=OMnsDqpS7mN5ekbzq6rLUj1Jtd21FawuezqRU1AIOxE=; b=u4T9Up066SayiMCh1tGi/xzVTuJpAhXlkANSFlRrZkkJIEGUtMas/56r7hC0wJUYrSG04+ Rv2XZ2Wy7KlkJJCA== From: Fabiano Rosas To: qemu-devel@nongnu.org Cc: berrange@redhat.com, armbru@redhat.com, Peter Xu , Laurent Vivier , Paolo Bonzini Subject: [PATCH v2 21/24] tests/qtest/migration: Take reference when passing %p to qtest_qmp Date: Mon, 30 Jun 2025 16:59:10 -0300 Message-Id: <20250630195913.28033-22-farosas@suse.de> X-Mailer: git-send-email 2.35.3 In-Reply-To: <20250630195913.28033-1-farosas@suse.de> References: <20250630195913.28033-1-farosas@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.80 X-Spamd-Result: default: False [-2.80 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; MID_CONTAINS_FROM(1.00)[]; R_MISSING_CHARSET(0.50)[]; NEURAL_HAM_SHORT(-0.20)[-0.999]; MIME_GOOD(-0.10)[text/plain]; RCVD_VIA_SMTP_AUTH(0.00)[]; MIME_TRACE(0.00)[0:+]; R_RATELIMIT(0.00)[to_ip_from(RLjrdmmf3juheryardexw6jb95)]; ARC_NA(0.00)[]; TO_DN_SOME(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_FIVE(0.00)[6]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:mid,suse.de:email,imap1.dmz-prg2.suse.org:helo]; RCVD_TLS_ALL(0.00)[] Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=195.135.223.130; envelope-from=farosas@suse.de; helo=smtp-out1.suse.de X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.237, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @suse.de) X-ZM-MESSAGEID: 1751313905670116600 Content-Type: text/plain; charset="utf-8" The documentation of qobject_from_jsonv() states that it takes ownership of any %p arguments passed in. Next patches will add config-passing to the tests, so take an extra reference in the migrate_qmp* functions to ensure the config is not freed from under us. Signed-off-by: Fabiano Rosas --- tests/qtest/migration/migration-qmp.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/tests/qtest/migration/migration-qmp.c b/tests/qtest/migration/= migration-qmp.c index fb59741b2c..d82ac8c750 100644 --- a/tests/qtest/migration/migration-qmp.c +++ b/tests/qtest/migration/migration-qmp.c @@ -97,7 +97,8 @@ void migrate_qmp_fail(QTestState *who, const char *uri, } =20 err =3D qtest_qmp_assert_failure_ref( - who, "{ 'execute': 'migrate', 'arguments': %p}", args); + who, "{ 'execute': 'migrate', 'arguments': %p}", + qdict_clone_shallow(args)); =20 g_assert(qdict_haskey(err, "desc")); =20 @@ -136,7 +137,8 @@ void migrate_qmp(QTestState *who, QTestState *to, const= char *uri, } =20 qtest_qmp_assert_success(who, - "{ 'execute': 'migrate', 'arguments': %p}", a= rgs); + "{ 'execute': 'migrate', 'arguments': %p}", + qdict_clone_shallow(args)); } =20 void migrate_set_capability(QTestState *who, const char *capability, @@ -174,7 +176,7 @@ void migrate_incoming_qmp(QTestState *to, const char *u= ri, QObject *channels, migrate_set_capability(to, "events", true); =20 rsp =3D qtest_qmp(to, "{ 'execute': 'migrate-incoming', 'arguments': %= p}", - args); + qdict_clone_shallow(args)); =20 if (!qdict_haskey(rsp, "return")) { g_autoptr(GString) s =3D qobject_to_json_pretty(QOBJECT(rsp), true= ); --=20 2.35.3