From nobody Sat Nov 15 14:26:51 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1751297945; cv=none; d=zohomail.com; s=zohoarc; b=CeTUgut+5z9vUnJNpOdWfcQTN9AGO1KVa6ox4VWiijDytMgrcI6qjeyWlh2U9jg83Zx+SC76cwPIcIO95OUImfr66YtWDkULWfhVFmcCp8zhvXsPQAkoFLC/tEf/VwBtpi+yvsfxdgkwK8xsOuf+DjccJXcVEW2Gi2qcRPUW9iQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1751297945; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=jMI3zk1yx7l0ZvxOUeqOoFW7RCKjr7ZEIlQI75AA6SE=; b=HkfXg2Q4VAAtq9kahrGqjsiMBSnErtHYZfQ74uhOgWSb41j5R3PiMhCzXcCu5JubM7ARbMPLETcg71WwN1sgIY4egzlPs8MF/naTtTsbn1x2QWxKzCKMnSizuv5X/xO3hLjKCUfqiiWo0O+G1D0PjNI81rLL13TXHpOYGdONct4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1751297945953112.55699042232015; Mon, 30 Jun 2025 08:39:05 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uWGRW-0000MA-4l; Mon, 30 Jun 2025 11:29:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uWGRN-0000L7-FN for qemu-devel@nongnu.org; Mon, 30 Jun 2025 11:29:08 -0400 Received: from mail-ot1-x32b.google.com ([2607:f8b0:4864:20::32b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uWGRL-0008CE-EG for qemu-devel@nongnu.org; Mon, 30 Jun 2025 11:29:05 -0400 Received: by mail-ot1-x32b.google.com with SMTP id 46e09a7af769-73a43d327d6so1152074a34.2 for ; Mon, 30 Jun 2025 08:29:01 -0700 (PDT) Received: from stoup.. ([187.210.107.185]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-73afb00c48asm1712478a34.27.2025.06.30.08.29.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Jun 2025 08:29:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1751297341; x=1751902141; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=jMI3zk1yx7l0ZvxOUeqOoFW7RCKjr7ZEIlQI75AA6SE=; b=KCgK177sx0JKReZZkHgLFD/2rLfzvBwXRahhM3WVd804UTxZlCZyOWWDMiQxF/Ypn1 Mh/tOKVP8ZtKNwQR/c7l5nOfUrauMYmeICFZFw7AxYjyyro4ZUkSkXpE1EhVMYuQOyxV DSmmOKJawz0YAIAh5b7iSxiFC2wQfsdM2KCsgF1oCbqbWCBe9J9LFaym/CYK53BAHxB/ pz9MGuT+gABsavWbfxtsDGikgWw+e7QqIBl6yVP7ZC9M4bDpxN1ewmvnCyYIETk19/4H Bfp7Lm0gNpCjKIXVU/1R2+IDZHKrj3xegqPuP8bVL9yCClFxPPNg1PB8fUgEtZSrVHo4 F/6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751297341; x=1751902141; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jMI3zk1yx7l0ZvxOUeqOoFW7RCKjr7ZEIlQI75AA6SE=; b=L7+LY+/LmMAIz7l2bOXZCGCQY9niyhMa+nNdxDAltbI9YJNR1bAA4/qjYHdUrqUQru BsOe1cLsht5Ro8NckZL4JmTfXp2LMaHcIRMU3wmE8GI0Ty3dnc2I3T7d5p6dNAi2GrkI ZMnP+3miWTJaN+mLUab2ySp/tCTcXAd0/G6EpA0ugDAd6rwrxCpohmlc/XMiiUj37f5A 5aZjMJTM7JniphYwDibHBuNdsr//3dILk+Hz7KodTYsJSfuO4NNiNji5SAzD+JlxlIo7 /hArwIn/dnLjHsyh5kRydFDGMahzQNv7B/BevQHc+J/+QWgf3suCM38v01r+ksqvUZVt MVNg== X-Gm-Message-State: AOJu0YzU6SbfENhGFSJjK9c/Bz6rW4w5+Ig/2rpBKKJYVcwEOrm/VzJf +EesHIHDp2a2zh8OqBktW5Ljy0//kLMuDC9p7aJ6haJ2sAkJtdOVDGPrYOyPtQC5JfLjJcHCwkX y9/AK X-Gm-Gg: ASbGncv4L3q6TcINAMeL0gMPYQRemDEjzh7LaLUlv5vhWEkX3++37xIZ7okTA5BJSwE HngnjE6eV2PajYm9YJQ71XHDLhswVXUtrz6y0RUV2/MM787+7r91gD+hGhefMnW021x8MW2GZ9J hx/HolhmSLfMkZgk+UnAbN+KdcnjoknDh9ZujwiZ/Wa/0u0zRBXXazZX8wuOuJjAgvnaGhA0nm6 bqzT+Le5CiNU2SkP30eLuszrgWyrrDZC0SNKlRjLfyyLxbM2ycgDsoSYdkiQSQ1v4oQ/DHdbfnt 1k9g8xwEvKOLnfQTi1Dj4MXuW41HaXC2brFKoo/UhmYJdG1Pyx5G2p1PcjIg1jDzqEi4mg== X-Google-Smtp-Source: AGHT+IFOimJtMECRJ37QymRBkd5IBS+R0nigGFd23VswaTuTca44zBjBci2ECOJpRrf5OpBeMhr0sw== X-Received: by 2002:a9d:6014:0:b0:73b:1efa:5f6d with SMTP id 46e09a7af769-73b1efa6d00mr3355738a34.16.1751297340892; Mon, 30 Jun 2025 08:29:00 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Cc: Pierrick Bouvier Subject: [PULL 04/29] tcg/optimize: Build and use o_bits in fold_and Date: Mon, 30 Jun 2025 09:28:30 -0600 Message-ID: <20250630152855.148018-5-richard.henderson@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250630152855.148018-1-richard.henderson@linaro.org> References: <20250630152855.148018-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::32b; envelope-from=richard.henderson@linaro.org; helo=mail-ot1-x32b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1751297946625116600 Content-Type: text/plain; charset="utf-8" Reviewed-by: Pierrick Bouvier Signed-off-by: Richard Henderson --- tcg/optimize.c | 20 +++++++------------- 1 file changed, 7 insertions(+), 13 deletions(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index 49ef039932..d9ccbb36e2 100644 --- a/tcg/optimize.c +++ b/tcg/optimize.c @@ -1422,7 +1422,7 @@ static bool fold_addco(OptContext *ctx, TCGOp *op) =20 static bool fold_and(OptContext *ctx, TCGOp *op) { - uint64_t z1, z2, z_mask, s_mask; + uint64_t z_mask, o_mask, s_mask, a_mask; TempOptInfo *t1, *t2; =20 if (fold_const2_commutative(ctx, op) || @@ -1434,18 +1434,9 @@ static bool fold_and(OptContext *ctx, TCGOp *op) =20 t1 =3D arg_info(op->args[1]); t2 =3D arg_info(op->args[2]); - z1 =3D t1->z_mask; - z2 =3D t2->z_mask; =20 - /* - * Known-zeros does not imply known-ones. Therefore unless - * arg2 is constant, we can't infer affected bits from it. - */ - if (ti_is_const(t2) && fold_affected_mask(ctx, op, z1 & ~z2)) { - return true; - } - - z_mask =3D z1 & z2; + z_mask =3D t1->z_mask & t2->z_mask; + o_mask =3D t1->o_mask & t2->o_mask; =20 /* * Sign repetitions are perforce all identical, whether they are 1 or = 0. @@ -1453,7 +1444,10 @@ static bool fold_and(OptContext *ctx, TCGOp *op) */ s_mask =3D t1->s_mask & t2->s_mask; =20 - return fold_masks_zs(ctx, op, z_mask, s_mask); + /* Affected bits are those not known zero, masked by those known one. = */ + a_mask =3D t1->z_mask & ~t2->o_mask; + + return fold_masks_zosa(ctx, op, z_mask, o_mask, s_mask, a_mask); } =20 static bool fold_andc(OptContext *ctx, TCGOp *op) --=20 2.43.0