From nobody Sat Nov 15 14:31:12 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1751297594; cv=none; d=zohomail.com; s=zohoarc; b=V1I76SvYYnPg4EcwBxTDGZ5z2khSyu8+7OwZbSNjtCLfuGi+vdIIprLNiLHvydKO7o0nN5YwbKjNGw5QDbdSyR2flpwgjmJ/HpuksTRW2FI4kuKHb4jAeK+MGngrlxZC4wWP0FjWQ4fqnenql5jqMiHI2qrAa8F9IS4B3KrCSYQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1751297594; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=R4bDMTeja2drb8U76A8rTMhXOU4TxSudcFPnnrBZGgM=; b=KibzyvXeRnDJEPSs46Wv1N6RKoC93AhgMRmnQEoWzF1xCVfKwXAHuhz0LLhft7toJ2bPOkQrxxLC1K/buPPApdGpWPBH3Ocshbn79p+fPTxc4ksTHo17Smf2OnKCegYTPbZGjcpDpRV3+oUKSJuKeSxpEaZ4Xn09MOM6LC7zTto= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1751297594121263.5164133189513; Mon, 30 Jun 2025 08:33:14 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uWGSA-0000ci-CR; Mon, 30 Jun 2025 11:29:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uWGRn-0000TI-O6 for qemu-devel@nongnu.org; Mon, 30 Jun 2025 11:29:38 -0400 Received: from mail-ot1-x32c.google.com ([2607:f8b0:4864:20::32c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uWGRh-0008Fy-06 for qemu-devel@nongnu.org; Mon, 30 Jun 2025 11:29:30 -0400 Received: by mail-ot1-x32c.google.com with SMTP id 46e09a7af769-735ae68cc78so2784107a34.1 for ; Mon, 30 Jun 2025 08:29:21 -0700 (PDT) Received: from stoup.. ([187.210.107.185]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-73afb00c48asm1712478a34.27.2025.06.30.08.29.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Jun 2025 08:29:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1751297359; x=1751902159; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=R4bDMTeja2drb8U76A8rTMhXOU4TxSudcFPnnrBZGgM=; b=kbvRePd29fKB+6dXU7TLG2CTChssK1uimUi5J47qeAhS+0nrsQO16ja77QsYVlGX9B MV+X5SAtC7QU16UozDa72HJEpaye+ZPZnzut/42PX7dmbCt3gfPu/TS2yXz/BHTOFrnw FDa3hgG1rA9s5mIf43ye2nQ40SFTweewr+m7Rx+sgvlUH3LkXsYTtLFzMJcDahBkww3S I+wXQFn4xgbvOzI3vKqNOkLzi2bOX2z5EMfCQlTKLGZZaSd87rOdjnpX6hdCHMDIhhnl UUBgcR7mjb+y2zeNou+5IL6Bsm1FVO1B2XtIEbSVr4q6pyGuv1H9KHZnB86x2CyIpRvV rKEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751297359; x=1751902159; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=R4bDMTeja2drb8U76A8rTMhXOU4TxSudcFPnnrBZGgM=; b=wq1wxYx+t3VwtL4TCM52Cdd2cKN//mmIakkLNDoa3jXibsiexyMnxnpYXR+TgA6Bvn fk7hT5502EezOWJb54rSqeMjt866jVynz0So5UGC+TusfH+CqkWO10hrVmCA49JRh4gP GtbO8qo1LgjnwLYaN9EUNFdiEHh0IBf/MyNO4AM8divD0RuYn7oNbTfkvpx8iQIKe4nT xV54afUU2OmZOUdU2vNsvQRsGtpxzL4/yN4SOeX08WKxJ4nROzsbAeVTO1QPzRoWkb8/ klRX1+v4k0/eZt7WQLKiYlhywB/b9kSOA8dNAaIvM41EAAMgR5t6Wdzh/N3BLaQPcfpB tAUQ== X-Gm-Message-State: AOJu0YwmszznUmAWa0l1yD6MKz3ecNL2Y8u+Sza+PVE+oqzr1UORspej r04qw84Pd5s54ZNcEeSkfhnzRw9fJQXQ1rxMESOqd2TsDAnqIX0EqBC83hL/et3OZJV8JBeRL3y bUX3I X-Gm-Gg: ASbGncvxwCqVL4s+GHVvWfeUnH6Gc8piIMMGYI4Do2mRuyAtE2kfdrRoW+JfPXH+XDr mgTebS2NbFZZTJwsrQ8+oWPiATPAT/YI0mRnU0SIn7mg8hLiFDaIypNmD9tPRzfqnf1m5U3vdQ1 GNTfFgsThMjnc7fh/GnuXY16Rpqsi2M6x38jOah/kjqUIhP+F4YqH5NXeNyRg9GAqk7/3z6Kjfu t2Pn+O9BRHJn9ZBW3eJreQhYggxT6PrISdKIc4oT8gfYytTLpyvpGGBOz0QhwZSMyVP/ybVIekT pqj7smiasgw8sdSTPzVesEicAbVpzjUQF8Z8swPTHwyvajNusZQafdyqfvDCKHhj9zM+Pw== X-Google-Smtp-Source: AGHT+IHTrL/ytEuoHfo1QLP2hJuBhPS0BZ/mBMXukqmfEEd2H2PnRgNeFjbVYdgt/kUTGqh2yUgsSw== X-Received: by 2002:a05:6830:720b:b0:72b:92aa:b69f with SMTP id 46e09a7af769-73b1b7f88e8mr3501534a34.16.1751297359449; Mon, 30 Jun 2025 08:29:19 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Cc: Pierrick Bouvier Subject: [PULL 23/29] tcg/optimize: Fold and to extract during optimize Date: Mon, 30 Jun 2025 09:28:49 -0600 Message-ID: <20250630152855.148018-24-richard.henderson@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250630152855.148018-1-richard.henderson@linaro.org> References: <20250630152855.148018-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::32c; envelope-from=richard.henderson@linaro.org; helo=mail-ot1-x32c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1751297595597116600 Content-Type: text/plain; charset="utf-8" Reviewed-by: Pierrick Bouvier Signed-off-by: Richard Henderson --- tcg/optimize.c | 33 ++++++++++++++++++++++++++++++--- 1 file changed, 30 insertions(+), 3 deletions(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index aa64f15779..06ccf39d64 100644 --- a/tcg/optimize.c +++ b/tcg/optimize.c @@ -1044,8 +1044,9 @@ static bool fold_const2_commutative(OptContext *ctx, = TCGOp *op) * If z_mask allows, fold the output to constant zero. * The passed s_mask may be augmented by z_mask. */ -static bool fold_masks_zosa(OptContext *ctx, TCGOp *op, uint64_t z_mask, - uint64_t o_mask, int64_t s_mask, uint64_t a_ma= sk) +static bool fold_masks_zosa_int(OptContext *ctx, TCGOp *op, + uint64_t z_mask, uint64_t o_mask, + int64_t s_mask, uint64_t a_mask) { const TCGOpDef *def =3D &tcg_op_defs[op->opc]; TCGTemp *ts; @@ -1095,6 +1096,13 @@ static bool fold_masks_zosa(OptContext *ctx, TCGOp *= op, uint64_t z_mask, rep =3D MAX(rep - 1, 0); ti->s_mask =3D INT64_MIN >> rep; =20 + return false; +} + +static bool fold_masks_zosa(OptContext *ctx, TCGOp *op, uint64_t z_mask, + uint64_t o_mask, int64_t s_mask, uint64_t a_ma= sk) +{ + fold_masks_zosa_int(ctx, op, z_mask, o_mask, s_mask, -1); return true; } =20 @@ -1448,7 +1456,26 @@ static bool fold_and(OptContext *ctx, TCGOp *op) /* Affected bits are those not known zero, masked by those known one. = */ a_mask =3D t1->z_mask & ~t2->o_mask; =20 - return fold_masks_zosa(ctx, op, z_mask, o_mask, s_mask, a_mask); + if (!fold_masks_zosa_int(ctx, op, z_mask, o_mask, s_mask, a_mask)) { + if (ti_is_const(t2)) { + /* + * Canonicalize on extract, if valid. This aids x86 with its + * 2 operand MOVZBL and 2 operand AND, selecting the TCGOpcode + * which does not require matching operands. Other backends c= an + * trivially expand the extract to AND during code generation. + */ + uint64_t val =3D ti_const_val(t2); + if (!(val & (val + 1))) { + unsigned len =3D ctz64(~val); + if (TCG_TARGET_extract_valid(ctx->type, 0, len)) { + op->opc =3D INDEX_op_extract; + op->args[2] =3D 0; + op->args[3] =3D len; + } + } + } + } + return true; } =20 static bool fold_andc(OptContext *ctx, TCGOp *op) --=20 2.43.0