From nobody Sat Nov 15 14:49:49 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1750840198; cv=none; d=zohomail.com; s=zohoarc; b=JLv8ERg5WDW7hdHSICjAF6r1J8hDrPQLreQV7vQmRo9xtK4uURhpmVmvKRyaEIqx6UxROaYWgvuWyYNszoBBsVaUvjLbtqVujhdyUZPqIppGMONYbY4Fe7QZQpGBf4p0OZBPR0Mf5YBcUIloXT0vELEUcNt2mZacc5ST9+k2fS4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1750840198; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=5AUAYcGfRWYprJv275nmuF6gbXK19rGN9VLixUtbHGc=; b=n0ih6NCsvfaeMrdHsQ2etbG1/XorB+bux/5N6ch5IVjzW/0dfDHI6q4W4RutwCHiZN4AQTEL6iJVkMiydBmrw3gw2fkrdFcJlG7a0Qgo4Fxz+wdz6wmXFJrCdCmu94SQ1Na7ocmT3qvlwFYFPokU/AqwfrLrVILMaFte+wvFVqk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1750840198082185.8346205199109; Wed, 25 Jun 2025 01:29:58 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uULUl-00054y-I6; Wed, 25 Jun 2025 04:28:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uULUT-00053u-Kf for qemu-devel@nongnu.org; Wed, 25 Jun 2025 04:28:21 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uULUQ-00060n-C3 for qemu-devel@nongnu.org; Wed, 25 Jun 2025 04:28:20 -0400 Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-31-dYGy9erBOK6W4Gz6e69bxQ-1; Wed, 25 Jun 2025 04:28:11 -0400 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 7F8EC180121D; Wed, 25 Jun 2025 08:28:09 +0000 (UTC) Received: from merkur.redhat.com (unknown [10.45.225.230]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id F3F95180045B; Wed, 25 Jun 2025 08:28:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1750840096; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=5AUAYcGfRWYprJv275nmuF6gbXK19rGN9VLixUtbHGc=; b=YCLXDmN/5NR/gMz67GwlOoF4PF/Dazy9r/+vxcYgooAHkLZk0I6hJEUKmEOYWd5ajyjIP+ zLtCKlbAZZrM04zwoYj8XxYUZWk3d+0MlWmMNx5lToM34tL/3vqt1XgOh8r+Y4OvPv2gM9 hfD0BAU3T2awhjfoU0ID7Aw56QOAmcQ= X-MC-Unique: dYGy9erBOK6W4Gz6e69bxQ-1 X-Mimecast-MFC-AGG-ID: dYGy9erBOK6W4Gz6e69bxQ_1750840089 From: Kevin Wolf To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, pasic@linux.ibm.com, borntraeger@linux.ibm.com, farman@linux.ibm.com, thuth@redhat.com, qemu-s390x@nongnu.org, qemu-trivial@nongnu.org Subject: [PATCH] hw/s390x/ccw-device: Fix memory leak in loadparm setter Date: Wed, 25 Jun 2025 10:27:51 +0200 Message-ID: <20250625082751.24896-1-kwolf@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=kwolf@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1750840201368116600 Content-Type: text/plain; charset="utf-8" Commit bdf12f2a fixed the setter for the "loadparm" machine property, which gets a string from a visitor, passes it to s390_ipl_fmt_loadparm() and then forgot to free it. It left another instance of the same problem unfixed in the "loadparm" device property. Fix it. Signed-off-by: Kevin Wolf Reviewed-by: Eric Farman Reviewed-by: Halil Pasic Tested-by: Thomas Huth --- hw/s390x/ccw-device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/s390x/ccw-device.c b/hw/s390x/ccw-device.c index 19c2238f76..8be1813b9e 100644 --- a/hw/s390x/ccw-device.c +++ b/hw/s390x/ccw-device.c @@ -57,7 +57,7 @@ static void ccw_device_set_loadparm(Object *obj, Visitor = *v, Error **errp) { CcwDevice *dev =3D CCW_DEVICE(obj); - char *val; + g_autofree char *val =3D NULL; int index; =20 index =3D object_property_get_int(obj, "bootindex", NULL); --=20 2.49.0