From nobody Sat Nov 15 16:38:22 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1750697687; cv=none; d=zohomail.com; s=zohoarc; b=GCA/Crf/PUrto847eBWl1h4duKCPztcdLI4GTAawWZau25GAjVwgPaJ0SEZJ1A1JaP0AoyjiX/niMTuXQcruL/aqUGqjwOOspMrZo0xO0OY6CUSkcagzajUjtgWmxlsOXkwz61MXizgAIvdAZ8/mAbjsy6l445556U2LaHi5lS0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1750697687; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=tNCesYs3FFj+/RQZWBoxRB23WBzDxbnoA2srKEuQzv4=; b=UGSO+1zSyN9TpSVR0uxqXTfd3U+X0Pej7iNhm26DJ0TUsNQfOWIsO5JmeFqsVjndnoGRGLDXUsO/RC1lNekO7pkPUHYOjJL0gDmQSEdhT09JUHFXHxEODxks37Khon154hNBTApBz8P33E5EAcLh4euJaFYPnC4YlYauoq1dulY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1750697687794355.47936349643317; Mon, 23 Jun 2025 09:54:47 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uTkQx-0000st-3h; Mon, 23 Jun 2025 12:54:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uTkQu-0000rk-OB for qemu-devel@nongnu.org; Mon, 23 Jun 2025 12:54:12 -0400 Received: from mail-wm1-x330.google.com ([2a00:1450:4864:20::330]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uTkQt-0008C8-66 for qemu-devel@nongnu.org; Mon, 23 Jun 2025 12:54:12 -0400 Received: by mail-wm1-x330.google.com with SMTP id 5b1f17b1804b1-4536c6b2506so362915e9.0 for ; Mon, 23 Jun 2025 09:54:10 -0700 (PDT) Received: from localhost ([2a02:8308:a00c:e200:8947:973b:de:93b7]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-453647082a2sm116607745e9.37.2025.06.23.09.54.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Jun 2025 09:54:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1750697649; x=1751302449; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=tNCesYs3FFj+/RQZWBoxRB23WBzDxbnoA2srKEuQzv4=; b=baPpPDgo0+BhElh1eMaz/CcSmMJ9fJQYASZ+wN4x6hQe51YtonU21fB1pDf0Ibyirz yM85eofOd15UepiNmAq+9UZfY5YOx4ZZVa3k7bD2LxkoqyN8c3F+AledfLik49pKWMye cXnVfRMJ9XNt9YTMaLxM3ufszGwh3uuLL8mt5hEP3Kca/0fObfzjrRJ17N7KvB0lRw5u 6ajW/tvNXue/QLOIyB0iZk0GLoZVNw+EcqrWp0ublRMUXTBKAa3XzMkFbQEjitx9d/4n Hr03VaPGkSAi9ig2oOwDbmMf42am2C3rxrxg+FUfOVLjPt8qPrHz3ZRBXWv4R4BDb0NW a9Vw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750697649; x=1751302449; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tNCesYs3FFj+/RQZWBoxRB23WBzDxbnoA2srKEuQzv4=; b=VgozgQAgBfwSxHgILre9dMKInuA28dbSHQsn6FwYiRe8prusj16xiFNEmQXUqozyky iqZYbNehf4XNcecNy2ugO9M0d16wWAtHtU2S3Zr6lE/Ds5UyDrHScOA5rJoK2+u8ebWe 3hb27s7wE+ZRm8IGNWoa0VVnmKKy9cVjEoIIpq2zKmsb188N0CHcmjTYHaIUUkbUMw9P 6Q/I6mMKRlrLMFbWYXAOijgdW4tbHHQEAD+2NV64yLyLrCLXT3iJt2rUS36dfIAylCoK 6BxLZ9xjDgJlGGx999TLq5Kqej2nd1E+Ic8k0R7UwtgxnJvSVtqLzcJ0+PiBoVWeITrO Sjmg== X-Gm-Message-State: AOJu0YwJ0P7VJwY+TNg829w+LxdwXtMrWV5VANWwErffdNySjz0wuwYw SVY5D7RJVXKkG3Z/i1Y5R3RumE4BcQYMD+ehG3e6Mxvq3cvo9896SsjvoKivcScZ7DM= X-Gm-Gg: ASbGncvK5UCvAxEtHCItWwhUiOEoF6O83Vupw0VgoCdW+5Rd32EgE4b6HuvzALTs6Av dXNvFlE2Ppe40BL54khMCWEWTu0L+6Nk+HCzAhnkKD+yAK+j3LSK1qCkUFyqYnvVw4nLGMCPUYj nEUF2o4rM+oX/1+6taVYdJCpsSaeAjrBIyicqPiMXGleVMSe1684gK4N4Ef2DmGmzwsnxM3MDo+ RvohcNYUrax+LE4+Uf651oclGdDBy1o0xKWGE4MimEeGlCnxpllvcoRWHNdSdFTH21ni+fJ4cD4 LypzotU5kGOg+LuNzg0XwSlXNB8sdfPDU63GShvFqO1vZdIWwr9A1G1rZRJeG/g8W08= X-Google-Smtp-Source: AGHT+IEto515WugI+tQ8tzq/Ckbh2Pz50Ab9kcI7e97q/wl6trF+5OZZh4CYul12bGQb/+lxjnlVDg== X-Received: by 2002:a05:600c:1c28:b0:453:4376:8f48 with SMTP id 5b1f17b1804b1-453659d879bmr49082635e9.6.1750697649327; Mon, 23 Jun 2025 09:54:09 -0700 (PDT) From: =?UTF-8?q?Radim=20Kr=C4=8Dm=C3=A1=C5=99?= To: qemu-riscv@nongnu.org Cc: qemu-devel@nongnu.org, Alistair Francis , Weiwei Li , Daniel Henrique Barboza , Liu Zhiwei , Atish Patra Subject: [PATCH 2/2] target/riscv: disarm timer when writing past value Date: Mon, 23 Jun 2025 18:53:29 +0200 Message-ID: <20250623165329.2759651-3-rkrcmar@ventanamicro.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250623165329.2759651-1-rkrcmar@ventanamicro.com> References: <20250623165329.2759651-1-rkrcmar@ventanamicro.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::330; envelope-from=rkrcmar@ventanamicro.com; helo=mail-wm1-x330.google.com X-Spam_score_int: -10 X-Spam_score: -1.1 X-Spam_bar: - X-Spam_report: (-1.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HK_RANDOM_ENVFROM=0.001, HK_RANDOM_FROM=0.999, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @ventanamicro.com) X-ZM-MESSAGEID: 1750697689664116600 There is no need to keep the timer running when writing a past value to the *stimecmp. The behavior was correct before, but I think it makes a bit more sense like this. Signed-off-by: Radim Kr=C4=8Dm=C3=A1=C5=99 --- target/riscv/time_helper.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/target/riscv/time_helper.c b/target/riscv/time_helper.c index 8198a2d8d92d..81a6a6394502 100644 --- a/target/riscv/time_helper.c +++ b/target/riscv/time_helper.c @@ -64,6 +64,8 @@ void riscv_timer_write_timecmp(CPURISCVState *env, QEMUTi= mer *timer, * If we're setting an stimecmp value in the "past", * immediately raise the timer interrupt */ + timer_del(timer); + if (timer_irq =3D=3D MIP_VSTIP) { env->vstime_irq =3D 1; riscv_cpu_update_mip(env, 0, BOOL_TO_MASK(1)); --=20 2.49.0