From nobody Sat Nov 15 14:53:46 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=zamaudio.com ARC-Seal: i=1; a=rsa-sha256; t=1750597223; cv=none; d=zohomail.com; s=zohoarc; b=QNOH+52vviPyYSVdhaqodECNZD9AsXULTJk1kGJB7pfnkCNduAv6fwpcOrEf1eUCcHj0oOnel3wBw3pjn47pB0t/XhKNACZ///IQJUeejs9i94wnb82SLBSeSnvrIrLkW/VHroPxmm90nNFpQ1KZdRVh+9YNpO0BGjuH0oW49hc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1750597223; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=v80er9m3aqYundIhzd3eulAhE74whECdgdz/q2Kqci0=; b=i8Lr7WmdICcjRQ84JwmEDIIWmP3a5N1/jFXBq4zVnKScg+LHOGfMVqX5ri6a5eYMViazeDIfPCK19II3LzFEXYcQ6UwLzL4aJkKM6WhtBzZFkQYc23AwR/Ox46NV1CsjeqnhIAkm8v//9fx8jUkZhFNqAs4fpbL+PRH/4Ujiae0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1750597222885615.9296517941524; Sun, 22 Jun 2025 06:00:22 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uTKIs-0005a5-W8; Sun, 22 Jun 2025 09:00:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uTJum-0002WE-6G for qemu-devel@nongnu.org; Sun, 22 Jun 2025 08:35:17 -0400 Received: from mail-0201.mail-europe.com ([51.77.79.158]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uTJuh-0007nq-W5 for qemu-devel@nongnu.org; Sun, 22 Jun 2025 08:35:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zamaudio.com; s=protonmail; t=1750595705; x=1750854905; bh=v80er9m3aqYundIhzd3eulAhE74whECdgdz/q2Kqci0=; h=Date:To:From:Subject:Message-ID:Feedback-ID:From:To:Cc:Date: Subject:Reply-To:Feedback-ID:Message-ID:BIMI-Selector; b=ZimmrM2lkwMyWFzYyjjVGbfOh55gUTTTlBEfjvZMHIloTA0+hQuod+upz79bRNF0A 2l62N4VuBTrOAj2Zj+ELRbpwkZfnFZMGG+f8mg8cPwS/9iZGcJ6G72HbcLtmMvHH7t wQJfzmF9mmmoKtV/OpX4fbjnz66si50BvpWJMtbCxpoKD3oj3aFTEK1PlCU9HzrhzG kk/KLuXlBlO1E241NsezeSXueJKFORV1LotG2yPQec6LH8KysoRukxMvvOyAtiOt2O ygDIB0r0fauQ76GXCruXZSVhNLtPXfNQTgPw88jxx4ZYdu8V407bpiJGWSWiMKRare dhYHzkxfa85GQ== Date: Sun, 22 Jun 2025 12:35:02 +0000 To: "Michael S . Tsirkin" , Paolo Bonzini , qemu-devel@nongnu.org From: Damien Zammit Subject: [PATCH] hw/i386/pc_piix.c: Add IRQs 14,15 as MADT overrides Message-ID: <20250622123401.211412-1-damien@zamaudio.com> Feedback-ID: 43209410:user:proton X-Pm-Message-ID: b7effeb76110a7e125a0014000b4ad66d6e2ea75 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=51.77.79.158; envelope-from=damien@zamaudio.com; helo=mail-0201.mail-europe.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Sun, 22 Jun 2025 08:59:50 -0400 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @zamaudio.com) X-ZM-MESSAGEID: 1750597225417116600 Content-Type: text/plain; charset="utf-8" When PIIX3 IDE is used, these two interrupts are active-low level-triggered but are not set as MADT overrides. Since the default for legacy interrupts is on rising edge, these two extra MADT isa irq overrides are needed. Signed-off-by: Damien Zammit --- hw/i386/pc_piix.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index ea7572e783..7320563890 100644 --- a/hw/i386/pc_piix.c +++ b/hw/i386/pc_piix.c @@ -181,6 +181,11 @@ static void pc_init1(MachineState *machine, const char= *pci_type) } } =20 + /* Add IRQ 14,15 to MADT overrides for PIIX3 IDE */ + if (pcmc->pci_enabled) { + x86ms->pci_irq_mask |=3D (1<<14) | (1<<15); + } + pc_machine_init_sgx_epc(pcms); x86_cpus_init(x86ms, pcmc->default_cpu_version); =20 --=20 2.30.2