From nobody Sat Nov 15 16:36:43 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1750550069; cv=none; d=zohomail.com; s=zohoarc; b=WbyGrzc5oPPTPAwyuQbV/iMKuSnpdfp4Yl7BFvdA/tb1pLExBmstvSFkUvvMFsxsh4tz93A4tjVF+iVrt0oV2oDlprIebRFMGhJ0uNffc6YpmQtVWiHXtAd9xDpM1AUM5wwRBJKk5MpWW68Mi+ZhOZj0DDp0YEMVsHo6ne1QWiY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1750550069; h=Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=ep/ctJ4lC0vJApF/uSjfzJ7QIfqX7YOFiWVYoLn9Hg0=; b=PQYYiGBWEK2JqDr0yr32SPD/omp9MM20qna1u632rSHrg62x3l9BCTmyYUaiISGvZYPL0UlZBh53p0QwImWxKtAzB/ik8soBc1/BSmPvpgf//BQ5V5HOFb+V+aJbHgfE181NxCkKhXrFyurH2CRzjg4AdsxBaIOTAT2VkzFjRR8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1750550069112630.4560843987658; Sat, 21 Jun 2025 16:54:29 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uT7zI-0005F1-OM; Sat, 21 Jun 2025 19:51:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uT7zF-0005CZ-8j for qemu-devel@nongnu.org; Sat, 21 Jun 2025 19:51:05 -0400 Received: from mail-pf1-x435.google.com ([2607:f8b0:4864:20::435]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uT7zD-0004X1-AR for qemu-devel@nongnu.org; Sat, 21 Jun 2025 19:51:05 -0400 Received: by mail-pf1-x435.google.com with SMTP id d2e1a72fcca58-742c3d06de3so3591819b3a.0 for ; Sat, 21 Jun 2025 16:51:02 -0700 (PDT) Received: from stoup.. (174-21-67-243.tukw.qwest.net. [174.21.67.243]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7490a49ebd0sm5073744b3a.55.2025.06.21.16.51.01 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 21 Jun 2025 16:51:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1750549861; x=1751154661; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=ep/ctJ4lC0vJApF/uSjfzJ7QIfqX7YOFiWVYoLn9Hg0=; b=E9JQMo1HdsNgirTXzg4VOYjUdmfUjujefk3wN+yffi1pBhsAR+UHNJlHwdgYx0hiGq UMPLgmUJzY3Tut50m/PqJoUvQNfy5+FBjq1pEsez+cvAkho5lB9zL5pP0wQcsJigNiRo VBw0D2Wmiluv7Q7cvTiirqOmzxbgOndJN2qU7MEuSO0GlF2NGVhPAfVVdAx8jjSClE6f VOfiSAcOkxNTAvGmzefaGi89g5pd6kWuJnUvUdDbs3NSviLCwLPQtxrSozikgZ1dX/Ru L+WLFlB65MYLcbej7IpvdhdCsxUXbx79sucqGeGN9liqKIXv+x90OPQs8LdVMDk2j8oB M8Cg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750549861; x=1751154661; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ep/ctJ4lC0vJApF/uSjfzJ7QIfqX7YOFiWVYoLn9Hg0=; b=ENuQq04woqlCGiHFGG7dwv940gSnKtKy5o8tr41YwZRVIUHA2gfg1ZirDvh9TMeTHx 9BaU8xqSsVIT42Kewlv0i8oJJRsH1JutHu7PLUADU3BDPOzwtg1Gfz3eC4qFcnBQvirl urRs4AGCDBEZoUi4530npp28QRwNnjhAJpTjAuG+qXAJBwg3tJSIjCS0De6GJ/S8a1mK 0QYOm2o0NgYWXlTECK17lt3JH57JJRovCY7uslB8aIm3sFpUf8vuEQOgISA7W0O+kdHT XvSXj322mU7udk/pHJqEZCiTF6CAiCjhTBh06+R5vuGWol0R0QAb2CE+4EVSkZVNqRSp 9lag== X-Gm-Message-State: AOJu0YyR7qUtEBR2bPDlE20YxwIIE8H6pJw/78k2N1c2WzvLQWwx6349 5SD9s6B0Bd2S/PsNuKkKSotmn4LsXrvA0bXpWlESmB2wAbDAfnNIbrJNEymodatK6NMQu3DEUFM lynx9 X-Gm-Gg: ASbGncvOhm5xF0vqhAvJObzirRQlVQYyxUzwIRc/5kMgdO8WCQVz4dL8fHilRS3y7Qh OSQHHKqp/FCEz82Kqql+tAspJ9SmwTcq6uq+fzz0RZYX/l125SkCwTZUa8P+upFEnA8B94mjNFl vuy02qTprPsQO4P09+ryTjRUxxG4TH4mQWy93imc/KAYsbfU2dtQkJyvF3ghXyYn/u1+vjWGCrD oRINkzm0+NFK5Mwu9umJ03ehXWzQy/elA0iMEQ4kh7SBD3QpG6X0k1+v44LxlvD6N7Ei8kBukOu vW5wOSkSP0P51aPh6Q5/U4UBP8IHuQ6S6JcL9DBRPX5lGJmjeXGxG0vwozMAdQa7YOK7RkxetGH jtz4oQkklBax79Zkt5Rua X-Google-Smtp-Source: AGHT+IFlDX4G2TsN51q28ELC/1gJCxWbOKMqWRPTPgFIm3V0djXbDKJfbdRjWWY6ZZYG5oH16Aay4Q== X-Received: by 2002:a05:6a00:1804:b0:748:e38d:fed4 with SMTP id d2e1a72fcca58-7490d691e08mr12439647b3a.6.1750549861544; Sat, 21 Jun 2025 16:51:01 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH v2 035/101] target/arm: Implement SME2 FDOT Date: Sat, 21 Jun 2025 16:49:31 -0700 Message-ID: <20250621235037.74091-36-richard.henderson@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250621235037.74091-1-richard.henderson@linaro.org> References: <20250621235037.74091-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::435; envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x435.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1750550070645116600 Content-Type: text/plain; charset="utf-8" Signed-off-by: Richard Henderson Reviewed-by: Peter Maydell --- target/arm/tcg/helper-sme.h | 5 ++++ target/arm/tcg/sme_helper.c | 44 ++++++++++++++++++++++++++++++++++ target/arm/tcg/translate-sme.c | 18 ++++++++++++++ target/arm/tcg/translate-sve.c | 5 ++++ target/arm/tcg/sme.decode | 14 +++++++++++ target/arm/tcg/sve.decode | 8 +++++-- 6 files changed, 92 insertions(+), 2 deletions(-) diff --git a/target/arm/tcg/helper-sme.h b/target/arm/tcg/helper-sme.h index cdd7058aed..ec93ff57ff 100644 --- a/target/arm/tcg/helper-sme.h +++ b/target/arm/tcg/helper-sme.h @@ -173,3 +173,8 @@ DEF_HELPER_FLAGS_5(gvec_fmaxnum_b16, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, fpst, i32) DEF_HELPER_FLAGS_5(gvec_fminnum_b16, TCG_CALL_NO_RWG, void, ptr, ptr, ptr, fpst, i32) + +DEF_HELPER_FLAGS_6(sme2_fdot_h, TCG_CALL_NO_RWG, + void, ptr, ptr, ptr, ptr, env, i32) +DEF_HELPER_FLAGS_6(sme2_fdot_idx_h, TCG_CALL_NO_RWG, + void, ptr, ptr, ptr, ptr, env, i32) diff --git a/target/arm/tcg/sme_helper.c b/target/arm/tcg/sme_helper.c index 194560eafa..bd9b81d5aa 100644 --- a/target/arm/tcg/sme_helper.c +++ b/target/arm/tcg/sme_helper.c @@ -1122,6 +1122,50 @@ void HELPER(sme_fmopa_h)(void *vza, void *vzn, void = *vzm, void *vpn, } } =20 +void HELPER(sme2_fdot_h)(void *vd, void *vn, void *vm, void *va, + CPUARMState *env, uint32_t desc) +{ + intptr_t i, oprsz =3D simd_maxsz(desc); + bool za =3D extract32(desc, SIMD_DATA_SHIFT, 1); + float_status *fpst_std =3D &env->vfp.fp_status[za ? FPST_ZA : FPST_A64= ]; + float_status *fpst_f16 =3D &env->vfp.fp_status[za ? FPST_ZA_F16 : FPST= _A64_F16]; + float_status fpst_odd =3D *fpst_std; + float32 *d =3D vd, *a =3D va; + uint32_t *n =3D vn, *m =3D vm; + + set_float_rounding_mode(float_round_to_odd, &fpst_odd); + + for (i =3D 0; i < oprsz / sizeof(float32); ++i) { + d[H4(i)] =3D f16_dotadd(a[H4(i)], n[H4(i)], m[H4(i)], + fpst_f16, fpst_std, &fpst_odd); + } +} + +void HELPER(sme2_fdot_idx_h)(void *vd, void *vn, void *vm, void *va, + CPUARMState *env, uint32_t desc) +{ + intptr_t i, j, oprsz =3D simd_maxsz(desc); + intptr_t elements =3D oprsz / sizeof(float32); + intptr_t eltspersegment =3D MIN(4, elements); + int idx =3D extract32(desc, SIMD_DATA_SHIFT, 2); + bool za =3D extract32(desc, SIMD_DATA_SHIFT + 2, 1); + float_status *fpst_std =3D &env->vfp.fp_status[za ? FPST_ZA : FPST_A64= ]; + float_status *fpst_f16 =3D &env->vfp.fp_status[za ? FPST_ZA_F16 : FPST= _A64_F16]; + float_status fpst_odd =3D *fpst_std; + float32 *d =3D vd, *a =3D va; + uint32_t *n =3D vn, *m =3D (uint32_t *)vm + H4(idx); + + set_float_rounding_mode(float_round_to_odd, &fpst_odd); + + for (i =3D 0; i < elements; i +=3D eltspersegment) { + uint32_t mm =3D m[i]; + for (j =3D 0; j < eltspersegment; ++j) { + d[H4(i + j)] =3D f16_dotadd(a[H4(i + j)], n[H4(i + j)], mm, + fpst_f16, fpst_std, &fpst_odd); + } + } +} + void HELPER(sme_bfmopa)(void *vza, void *vzn, void *vzm, void *vpn, void *vpm, CPUARMState *env, uint32_t d= esc) { diff --git a/target/arm/tcg/translate-sme.c b/target/arm/tcg/translate-sme.c index ec12bfd089..607dd2a928 100644 --- a/target/arm/tcg/translate-sme.c +++ b/target/arm/tcg/translate-sme.c @@ -844,3 +844,21 @@ static bool do_bfmlal_nx(DisasContext *s, arg_azx_n *a= , bool sub) =20 TRANS_FEAT(BFMLAL_nx, aa64_sme2, do_bfmlal_nx, a, false) TRANS_FEAT(BFMLSL_nx, aa64_sme2, do_bfmlal_nx, a, true) + +static bool do_fdot(DisasContext *s, arg_azz_n *a, bool multi) +{ + return do_azz_acc_fp(s, a->n, 1, a->rv, a->off, a->zn, a->zm, 1, 0, + multi, FPST_ENV, gen_helper_sme2_fdot_h); +} + +TRANS_FEAT(FDOT_n1, aa64_sme2, do_fdot, a, false) +TRANS_FEAT(FDOT_nn, aa64_sme2, do_fdot, a, true) + +static bool do_fdot_nx(DisasContext *s, arg_azx_n *a) +{ + return do_azz_acc_fp(s, a->n, 1, a->rv, a->off, a->zn, a->zm, + a->idx | 2, 0, false, FPST_ENV, + gen_helper_sme2_fdot_idx_h); +} + +TRANS_FEAT(FDOT_nx, aa64_sme2, do_fdot_nx, a) diff --git a/target/arm/tcg/translate-sve.c b/target/arm/tcg/translate-sve.c index 7f8ca78a91..2a1efa4394 100644 --- a/target/arm/tcg/translate-sve.c +++ b/target/arm/tcg/translate-sve.c @@ -7183,6 +7183,11 @@ TRANS_FEAT_NONSTREAMING(USMMLA, aa64_sve_i8mm, gen_g= vec_ool_arg_zzzz, TRANS_FEAT_NONSTREAMING(UMMLA, aa64_sve_i8mm, gen_gvec_ool_arg_zzzz, gen_helper_gvec_ummla_b, a, 0) =20 +TRANS_FEAT(FDOT_zzzz, aa64_sme2_or_sve2p1, gen_gvec_env_arg_zzzz, + gen_helper_sme2_fdot_h, a, 0) +TRANS_FEAT(FDOT_zzxz, aa64_sme2_or_sve2p1, gen_gvec_env_arg_zzxz, + gen_helper_sme2_fdot_idx_h, a) + TRANS_FEAT(BFDOT_zzzz, aa64_sve_bf16, gen_gvec_env_arg_zzzz, gen_helper_gvec_bfdot, a, 0) TRANS_FEAT(BFDOT_zzxz, aa64_sve_bf16, gen_gvec_env_arg_zzxz, diff --git a/target/arm/tcg/sme.decode b/target/arm/tcg/sme.decode index 9850c19d90..a2b93519c4 100644 --- a/target/arm/tcg/sme.decode +++ b/target/arm/tcg/sme.decode @@ -285,6 +285,9 @@ BFMLSL_n1 11000001 001 0 .... 0 .. 011 ..... 11 .= .. @azz_nx1_o3x2 n=3D1 BFMLSL_n1 11000001 001 0 .... 0 .. 010 ..... 110 .. @azz_nx1_o2x2 = n=3D2 BFMLSL_n1 11000001 001 1 .... 0 .. 010 ..... 110 .. @azz_nx1_o2x2 = n=3D4 =20 +FDOT_n1 11000001 001 0 .... 0 .. 100 ..... 00 ... @azz_nx1_o3 n= =3D2 +FDOT_n1 11000001 001 1 .... 0 .. 100 ..... 00 ... @azz_nx1_o3 n= =3D4 + ### SME2 Multi-vector Multiple Array Vectors =20 %zn_ax2 6:4 !function=3Dtimes_2 @@ -322,6 +325,9 @@ BFMLAL_nn 11000001 101 ...01 0 .. 010 ...00 100 .= . @azz_4x4_o2x2 BFMLSL_nn 11000001 101 ....0 0 .. 010 ....0 110 .. @azz_2x2_o2x2 BFMLSL_nn 11000001 101 ...01 0 .. 010 ...00 110 .. @azz_4x4_o2x2 =20 +FDOT_nn 11000001 101 ....0 0 .. 100 ....0 00 ... @azz_2x2_o3 +FDOT_nn 11000001 101 ...01 0 .. 100 ...00 00 ... @azz_4x4_o3 + ### SME2 Multi-vector Indexed =20 &azx_n n off rv zn zm idx @@ -351,3 +357,11 @@ BFMLAL_nx 11000001 1001 .... 1 .. 1 .. ...00 10 = ... @azx_4x1_o2x2 BFMLSL_nx 11000001 1000 .... . .. 1 .. ..... 11 ... @azx_1x1_o3x2 BFMLSL_nx 11000001 1001 .... 0 .. 1 .. ....0 11 ... @azx_2x1_o2x2 BFMLSL_nx 11000001 1001 .... 1 .. 1 .. ...00 11 ... @azx_4x1_o2x2 + +@azx_2x1_i2_o3 ........ .... zm:4 . .. . idx:2 .... ... off:3 \ + &azx_n n=3D2 rv=3D%mova_rv zn=3D%zn_ax2 +@azx_4x1_i2_o3 ........ .... zm:4 . .. . idx:2 .... ... off:3 \ + &azx_n n=3D2 rv=3D%mova_rv zn=3D%zn_ax4 + +FDOT_nx 11000001 0101 .... 0 .. 1 .. ....0 01 ... @azx_2x1_i2_o3 +FDOT_nx 11000001 0101 .... 1 .. 1 .. ...00 01 ... @azx_4x1_i2_o3 diff --git a/target/arm/tcg/sve.decode b/target/arm/tcg/sve.decode index 04b6fcc0cf..3a0ee429a8 100644 --- a/target/arm/tcg/sve.decode +++ b/target/arm/tcg/sve.decode @@ -1662,7 +1662,9 @@ FMLSLT_zzzw 01100100 10 1 ..... 10 1 00 1 ..... .= .... @rda_rn_rm_e0 BFMLALB_zzzw 01100100 11 1 ..... 10 0 00 0 ..... ..... @rda_rn_rm_e0 BFMLALT_zzzw 01100100 11 1 ..... 10 0 00 1 ..... ..... @rda_rn_rm_e0 =20 -### SVE2 floating-point bfloat16 dot-product +### SVE2 floating-point dot-product + +FDOT_zzzz 01100100 00 1 ..... 10 0 00 0 ..... ..... @rda_rn_rm_e0 BFDOT_zzzz 01100100 01 1 ..... 10 0 00 0 ..... ..... @rda_rn_rm_e0 =20 ### SVE2 floating-point multiply-add long (indexed) @@ -1673,7 +1675,9 @@ FMLSLT_zzxw 01100100 10 1 ..... 0110.1 ..... ....= . @rrxr_3a esz=3D2 BFMLALB_zzxw 01100100 11 1 ..... 0100.0 ..... ..... @rrxr_3a esz=3D2 BFMLALT_zzxw 01100100 11 1 ..... 0100.1 ..... ..... @rrxr_3a esz=3D2 =20 -### SVE2 floating-point bfloat16 dot-product (indexed) +### SVE2 floating-point dot-product (indexed) + +FDOT_zzxz 01100100 00 1 ..... 010000 ..... ..... @rrxr_2 esz=3D2 BFDOT_zzxz 01100100 01 1 ..... 010000 ..... ..... @rrxr_2 esz=3D2 =20 ### SVE broadcast predicate element --=20 2.43.0