From nobody Sat Nov 15 16:45:33 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1750437750; cv=none; d=zohomail.com; s=zohoarc; b=V/KFXoJEw+FrXkmVB6JUZUqfvHfK6R/tTO+xkGr/z1rn7zFVnYAe8MbytfdaDPd+yewm63g8vXTHUndPwg8OhEbUPXmMcmlBv0os0yvxthj/GTYu9/BcU3eVF6jjPKpSFKuXdH/A31/6Uk9vAzQc7K0LgtVUwlOVsG9RllBX7FQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1750437750; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=XMGhYnZFHX5IefyrfK9nBnHDbZhTF5W9KaGEmJ1RYIY=; b=QtqCuaZXjjBiMqOFJs5zv0UKyEuz1Ya2NZkAIschuftOyIHLQPyoNEW/dtyfgDuD61RX9JH25AF3bzHlxGtxFx5RuUs+eD+Eyp27/irs/7f1TiV+WPPV2Ii3tobgNsYMm6zzvM9YyhyOvMKnfOEpP7xI/XmQfonphxA4YYHYhfo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 175043775019411.913076070202806; Fri, 20 Jun 2025 09:42:30 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uSeoC-0006cD-6b; Fri, 20 Jun 2025 12:41:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uSeo7-0006ar-QX for qemu-devel@nongnu.org; Fri, 20 Jun 2025 12:41:40 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uSeo6-0000Hp-7u for qemu-devel@nongnu.org; Fri, 20 Jun 2025 12:41:39 -0400 Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-518-uQgv9LSVMKmIfdX1XISmbA-1; Fri, 20 Jun 2025 12:41:36 -0400 Received: by mail-ej1-f69.google.com with SMTP id a640c23a62f3a-acb8f9f58ebso164354766b.2 for ; Fri, 20 Jun 2025 09:41:35 -0700 (PDT) Received: from [192.168.122.1] ([151.62.200.93]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ae053e801ccsm185328666b.7.2025.06.20.09.41.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Jun 2025 09:41:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1750437697; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XMGhYnZFHX5IefyrfK9nBnHDbZhTF5W9KaGEmJ1RYIY=; b=Pb2iN/kGRtq/jtBEO2B8WzHD34aB6Qj55Kp4YNlTKNcQWcqm5sKHCaLn7dKgRt0U8Fgo9T lFSmcbvSL9n+6ishB35y6D3WAhewYAmPW8Ew+a1IDJoLTm2WLBjJ5bA5032Ow/Q3wbpb7X CzC8iKPOkirxj7Yty3TzHG9FM2OOYnw= X-MC-Unique: uQgv9LSVMKmIfdX1XISmbA-1 X-Mimecast-MFC-AGG-ID: uQgv9LSVMKmIfdX1XISmbA_1750437695 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750437694; x=1751042494; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XMGhYnZFHX5IefyrfK9nBnHDbZhTF5W9KaGEmJ1RYIY=; b=nMn5Plr5EyMtCnoNW4qEgsDyD6YyFInejsfkD4pLYYxFU6JfKJzg68llilhOF/ei7d +7aw22222w++/Fuhha0VDwFzK/OfpbN0nPaPOFiitTcmlumuqT9/mdA0T/0FLcIurRSW Wgxf82uFEa1h+vkEFJbYlI/jTRNNBoMVvIjn2HAnRkL+jWxJ48HfeWqS2Q2PKkjn6mXA iVd1Tskg/4pBHCf4iZGx3w4J2atbtghnK+EArG0XqZDy90T/OCDYHQjGqkeLOSBhtcbi YIfYRv2Kg5d0Lu+c4U6emA+wapUdjcx/zfg0wgwNzMcuRHKpcrOyUGIoQAPE2vQET2Dg SsNA== X-Gm-Message-State: AOJu0YwWZ3tK5CPbKAbTN1CLF4bry0SGJTSdeqrDPqw3gSIZSZPfXA0b o+4MCgsFw+4dGI123XabFQYnSitiEzGqSn3iWSfuJ4h7GY50t8exQaXwQ9Uf01ycXfny2Y2ewyZ tDIB0ozy129jxvQwvziqv0Bi0gWuQoz+CoNXAzk4BodUNunOEATT1vRnMdzGrMUJV0ubydgpH79 1b1e3wxYCJXqKRQjWsXMNOv8K3vTlxO8TSbxOb6tcJ X-Gm-Gg: ASbGnctDhC9a2x+ayK0Zic0Zoek9CkyJ9xxNlUPB/9ieCDHhjbKfaIyDoG/X26kcE3h HKMORQzHsoFpabdezg5V0aRBtFXm+D58kSmd7BETalZyQ4HmKgnWkpoD0uqBRup+5l26jpxELOS nXlU+qBZ2CFcpSpMTGkE1dLWWA2rvRh2FAi41hif+jjmVXoYqp4vvNQf6QsgEdtYLWQLedXa2js h8UKIahaIKYC0q5++dfINqtwXIrfNgWUprQsZHKjJUaupKR44Hab30mKXH1kpeq1MmpoQ0IQBOT jfzegZljGEHUVwkfpneRUAqsGQ== X-Received: by 2002:a17:907:db15:b0:ade:8d5a:cf37 with SMTP id a640c23a62f3a-ae057f2166emr335957566b.44.1750437693806; Fri, 20 Jun 2025 09:41:33 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGPQJ5Dtib/VLX65pHAXxYw1y9ZXtr1SOopos6qQ00HYRWazdyrZ5sEuoeOrcGhyDruN2uNsg== X-Received: by 2002:a17:907:db15:b0:ade:8d5a:cf37 with SMTP id a640c23a62f3a-ae057f2166emr335955366b.44.1750437693353; Fri, 20 Jun 2025 09:41:33 -0700 (PDT) From: Paolo Bonzini To: qemu-devel@nongnu.org Cc: Bernhard Beschow Subject: [PULL 14/24] rust: pl011: Add missing logging to match C version Date: Fri, 20 Jun 2025 18:40:42 +0200 Message-ID: <20250620164053.579416-15-pbonzini@redhat.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250620164053.579416-1-pbonzini@redhat.com> References: <20250620164053.579416-1-pbonzini@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=pbonzini@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -39 X-Spam_score: -4.0 X-Spam_bar: ---- X-Spam_report: (-4.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.897, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1750437751364116600 Content-Type: text/plain; charset="utf-8" From: Bernhard Beschow Co-developed-by: Paolo Bonzini Signed-off-by: Bernhard Beschow Link: https://lore.kernel.org/r/20250615112037.11992-4-shentey@gmail.com Signed-off-by: Paolo Bonzini --- rust/hw/char/pl011/src/device.rs | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/rust/hw/char/pl011/src/device.rs b/rust/hw/char/pl011/src/devi= ce.rs index 92dc295540e..5b53f2649f1 100644 --- a/rust/hw/char/pl011/src/device.rs +++ b/rust/hw/char/pl011/src/device.rs @@ -305,6 +305,12 @@ fn read_data_register(&mut self, update: &mut bool) ->= u32 { } =20 fn write_data_register(&mut self, value: u32) -> bool { + if !self.control.enable_uart() { + log_mask_ln!(Log::GuestError, "PL011 data written to disabled = UART"); + } + if !self.control.enable_transmit() { + log_mask_ln!(Log::GuestError, "PL011 data written to disabled = TX UART"); + } // interrupts always checked let _ =3D self.loopback_tx(value.into()); self.int_level |=3D Interrupt::TX; --=20 2.49.0