From nobody Sat Nov 15 14:11:25 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1750424896; cv=none; d=zohomail.com; s=zohoarc; b=Q9MHwP5QNPQpclG0jxl8oAMpccUjD0XEbdiurvQJGS9FfUJqCw/OWT33Myjkh76u58SenZ1JwyqYh93dRMo9m8QqJUQQPBChbfzboS/Jsvd+CQLugxcRySGDsjHI3nBom7ukMO6x9nErBhRVp4Gf2bjab9b036sm5pKxFhPjvX0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1750424896; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=tBZvBlUJJ4ZZzRhwp1RRYC3txHSba+iTcUIOSqbdq4E=; b=GpxMtRWg4U9u9dcJE8X2ZURjyzXOaGsAOIQYDTaEC0H6n9GoUTfdQNTuntyeP6ieJK8IVRLgGUE5tQ0RR7+Vs854/MIdZl40tXZcwdH3EcwsKwILaxZjddMvVVhTYwipGtfTS3JEYtB0dc3EFtl47n8N8mNKuVHWkHshV7giTMo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1750424896498571.1363023756528; Fri, 20 Jun 2025 06:08:16 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uSbSz-0002LJ-U6; Fri, 20 Jun 2025 09:07:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uSbSl-0002KK-H6 for qemu-devel@nongnu.org; Fri, 20 Jun 2025 09:07:23 -0400 Received: from mail-wm1-x32a.google.com ([2a00:1450:4864:20::32a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uSbSj-0004Uf-EW for qemu-devel@nongnu.org; Fri, 20 Jun 2025 09:07:22 -0400 Received: by mail-wm1-x32a.google.com with SMTP id 5b1f17b1804b1-4531e146a24so11615095e9.0 for ; Fri, 20 Jun 2025 06:07:19 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-453646cb692sm25426765e9.2.2025.06.20.06.07.16 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 20 Jun 2025 06:07:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1750424838; x=1751029638; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=tBZvBlUJJ4ZZzRhwp1RRYC3txHSba+iTcUIOSqbdq4E=; b=MBopYqoTNqoPrTtBiwCSqOW9yAdkqHrl/Q/wDgnn6xq+OPWcioOWHlXeGl94fjTIxF ROzgjT+co5iUhycIZN5eeDqenmEvnr0YGHrGwYmMTMnuzNqRKi9J/UqzudFDfGpBXlgy aUsNUSsa4DXXIfOwbvmW0I6I6i0WaNAbrxYBzgS0YixcHONlwD1aVV8RZxmM3bP2R9BU +W9pKTbi143ZOOz3XTsDLGVJoAnxYRb2pQPJcDdNxTxsq2i1TyWINvpS1XUPp9Rq0RtL zh3y6lDLweGgYF83p9DCyXaIsj+qNDtyUPwN6G2DiNehZBqdzOO93q7fRNMRRcQ6gxcC TXcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750424838; x=1751029638; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tBZvBlUJJ4ZZzRhwp1RRYC3txHSba+iTcUIOSqbdq4E=; b=NRMMQERtE9NVieAlLoA+LF4KDolRjFzTIaY1QTUtnUiJe/g/4XmOFYnYSrz106maj9 Tg1rNlfifaqA1P2+yFaG/gaoFSbYVaqaeg4ZruS9vkmYIoBs5zscFLyWhD7hc+EaN198 bliWDYjO5P4XIFGI80PWZrGFcEk5F+oOxGlzH733gxfPGiIgdxdCUt+hiVwRs+FzYeXK 2gn8l8eUTBlqh3PFVNNBNepTbf9NWv4bvVZqsXVTy1rlKqxGZraA3Ld4Tl4/9+bl4WSm T7lTFLS2tEMC67j0PEo05Gd+eJycIpRHttjiHsALMOoLQG0gKyFzfZOI6hwZ/J0V4jGR RwwQ== X-Gm-Message-State: AOJu0YwX7+WmNwr0i+vbGUwTx4fN0SX49Fm2B1tNOIz4ElZvfzlaUGDA Tsdd3o+1vlYuk08P54SFsjISqzLxCELQAU/suzgfOcK4GOWCBUPrMlUT8WGrXJvkIktWl3myXSk GY0vGa2Q= X-Gm-Gg: ASbGncvxkN3rhKD3R3AHGMCkPb2ukSiJN0v9D95WGDg77xmkOwuUfG6udum8sBwU0+Y nQzZimKuh1hklynr2l1mLdR25IKKMAnylz5Y+n6+czUmRPKkKAwNdkvGfj+4IYpg8Z2MXhHOkRB 4CUPoMe2UINbtrAoQze+afQJ3t71oVCxIVlvAYr9n9SlOUD8bOi2F5l242MK4shJIaf0tGsOmcK aItu+Rrprac0GI/FQD/+CSlaUHgQwNY6ygr+EqbHCo9HweIGZUqsxXvPRxvYHXziUbXdiy8NXYB U5SOo2zo+IAPsgl2hpdOYjOrAFzjvFXULfeX9OlN+mXSEydhuWJDA/4m2Bty7OI/HJt4ttvlLjB LIArk8GoED+Kx7iWjFzVC23yeYIWNAEx16+D4 X-Google-Smtp-Source: AGHT+IHkCPt6KL3uT84KaXQEf8w6Zl9aLccw1KatAjKZiNkbl+svh0rrY7kI5cIzTp13dZSGCGViFw== X-Received: by 2002:a5d:5e09:0:b0:3a5:39a8:6615 with SMTP id ffacd0b85a97d-3a6d12fb239mr2292246f8f.11.1750424838047; Fri, 20 Jun 2025 06:07:18 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Leif Lindholm , Richard Henderson , Radoslaw Biernacki , Alexander Graf , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Paolo Bonzini , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Phil Dennis-Jordan , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Bernhard Beschow , Cleber Rosa , Peter Maydell , Cameron Esfahani , kvm@vger.kernel.org, qemu-arm@nongnu.org, Eric Auger , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Thomas Huth , Roman Bolshakov , John Snow Subject: [PATCH v2 01/26] target/arm: Remove arm_handle_psci_call() stub Date: Fri, 20 Jun 2025 15:06:44 +0200 Message-ID: <20250620130709.31073-2-philmd@linaro.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250620130709.31073-1-philmd@linaro.org> References: <20250620130709.31073-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32a; envelope-from=philmd@linaro.org; helo=mail-wm1-x32a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1750424897629116600 Since commit 0c1aaa66c24 ("target/arm: wrap psci call with tcg_enabled") the arm_handle_psci_call() call is elided when TCG is disabled. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- target/arm/internals.h | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/target/arm/internals.h b/target/arm/internals.h index 3360de9150f..5ed25d33208 100644 --- a/target/arm/internals.h +++ b/target/arm/internals.h @@ -650,16 +650,12 @@ static inline bool arm_is_psci_call(ARMCPU *cpu, int = excp_type) { return false; } -static inline void arm_handle_psci_call(ARMCPU *cpu) -{ - g_assert_not_reached(); -} #else /* Return true if the r0/x0 value indicates that this SMC/HVC is a PSCI ca= ll. */ bool arm_is_psci_call(ARMCPU *cpu, int excp_type); +#endif /* Actually handle a PSCI call */ void arm_handle_psci_call(ARMCPU *cpu); -#endif =20 /** * arm_clear_exclusive: clear the exclusive monitor --=20 2.49.0 From nobody Sat Nov 15 14:11:25 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1750424919; cv=none; d=zohomail.com; s=zohoarc; b=bgev2EL4kX8XoQ+RHdtRkcb5Ai0jRMJ4IIYMUsXjlC66kTCzKhUP8ei3/mX9lt2QMVmONUVnbbQqzAjn3iU7txQ9l+24hbK4Y3Tfc75ME3/iXDtVTYMBgxmQORrt9sUTcOphYwFoNkCnizcgF1jXOTSHSdib41pZNxxaqA9ZNhc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1750424919; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=33tTruwtHJUDsLE1NQEO6k6TPJwHdavbHWnexaTt8VY=; b=bLMLhpiMIGjwvveGCkBLiD6DJMst3PbhBj+VKli1ekfflDaapDY62EV5NedOzFGCzC2KRkEm1RatQlzRkUcitckKs+oV7NNHNdwRCPT8y/HzulaS+vxnToyp036NGaY9TknwSIeNoCfcvp18u2e9QKKz71mtRG/hdM8lojiPfy4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1750424919039527.2962822912713; Fri, 20 Jun 2025 06:08:39 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uSbT2-0002Nr-3a; Fri, 20 Jun 2025 09:07:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uSbSq-0002L2-V1 for qemu-devel@nongnu.org; Fri, 20 Jun 2025 09:07:30 -0400 Received: from mail-wm1-x32f.google.com ([2a00:1450:4864:20::32f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uSbSn-0004VB-Fe for qemu-devel@nongnu.org; Fri, 20 Jun 2025 09:07:28 -0400 Received: by mail-wm1-x32f.google.com with SMTP id 5b1f17b1804b1-450ce671a08so11768155e9.3 for ; Fri, 20 Jun 2025 06:07:24 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4535e983c97sm60000735e9.9.2025.06.20.06.07.21 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 20 Jun 2025 06:07:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1750424843; x=1751029643; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=33tTruwtHJUDsLE1NQEO6k6TPJwHdavbHWnexaTt8VY=; b=Qq25uDyIvkdPZJUmKwOzZ4cVYHJ9sqFuTfjEWthgqShIORKjuINriqj1xTU+sxWCv8 ytjzNHjMaedvcSv8/kDoVTMLoycYpxPFtah3TD6OHcjUX4qBlVbdJeGNCYqEAqbjhDtr O2guymq1ZPQFCLsA8iPnOZfAEpzbotTO4dvJztzJ5NjwewhXrKlyx4uhiEgo19dKaOIW iBR74/TDfOfJA94KCAsYYGizMa91roObMq+rY6SobaHZ9z/s/jQuvLya30xcM4WDEE+Z 3JdJb+KeCDSgLY8XnceJv11J8n3zyJdKfjqjSOG6DWgr4SCri395U4HAV/M+VTQGXGDC 2nEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750424843; x=1751029643; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=33tTruwtHJUDsLE1NQEO6k6TPJwHdavbHWnexaTt8VY=; b=XDi3wW5Mq2WBszZfU7nv9nN6f67Uyg5gF5CzimjjehdXzbmN+zAlmRAsDgX/twtC68 A2Y1CToc/Xo9NPfPwxYzUbPB0r09ahEDFKY/ThDxTFJVPWzhXSEP77rYxVfpq0XgK4xX CPpFHAN2oZNXcoRMXEg+RfuYyxzhrjiDp5el9zUFe8rjCyBOQieqg+pj5S27tPSRVxMD xyuq+OeWqu4tThZ6jFFARuOvUOPIRSiC5UoMjUdDh7YnHsEOrKeqaxBMG8+tR2k6nRLS pszQv4Ljh9HwcOAzyFu9mfv0WfMxPCob/VuEwDIuJGmIXFW46exOS+PNz9NLu+i9VnGf jkLw== X-Gm-Message-State: AOJu0YxoTudbL4k9uHJp99UCMbYCj8tjAv0Jp0QoOlbdkHCdjQEVNqFg mXnlTtFE5GkAlqgJriaxYE2Bhkxs/kh6l3lZjiR+CIuY7zEDixNBmGOi4DXGyQCbQUC2GPk8xfw cyHouZ+w= X-Gm-Gg: ASbGncvcGts3KRTeeD9wVOhzmnQDjlNwDNHKxYCGqcnyg8JuUgkF6cDBBaxOCWkVxTn mSFrVYe4HtugtwweXXjyyPFFvqwkI3jIbuEkrPT0bW27d4H9QhKuwVZ454gTptKHkJwR9Khxh0e 2ICkxg4wIkSOyp26etCkEFcUUxajS7NqkPkf7G30DdZQrKeE5iQhBocBL86hMlXK5Xj6Vz5X8+O fCnyr3e/WI2s3TzQAP+oieyVRUGKn5o7YzSaHbKdBl6akEnPkpv8bCCrxomu+SVQdYHCmTDSUUx 5Y6SycK3q0A3jTiYKkGIekAJ315mCQuUHRUHP7FuFQeRdVmeS/YfCuyfXAU4mEIGTONyDLcu6+v uuiG2Xj76tnV5c+1EHxXBuV1W4+bho+sFeXS/ X-Google-Smtp-Source: AGHT+IEPb6wrdygh9iEg1xDu0Enz1glDmMWW79h8+hZ9AnnXvHvnm2dPPn2ChqyV+PmW9BY7cS4i1g== X-Received: by 2002:a05:600c:35c3:b0:450:d568:909b with SMTP id 5b1f17b1804b1-453653ba6a3mr28180435e9.14.1750424843244; Fri, 20 Jun 2025 06:07:23 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Leif Lindholm , Richard Henderson , Radoslaw Biernacki , Alexander Graf , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Paolo Bonzini , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Phil Dennis-Jordan , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Bernhard Beschow , Cleber Rosa , Peter Maydell , Cameron Esfahani , kvm@vger.kernel.org, qemu-arm@nongnu.org, Eric Auger , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Thomas Huth , Roman Bolshakov , John Snow Subject: [PATCH v2 02/26] target/arm: Reduce arm_cpu_post_init() declaration scope Date: Fri, 20 Jun 2025 15:06:45 +0200 Message-ID: <20250620130709.31073-3-philmd@linaro.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250620130709.31073-1-philmd@linaro.org> References: <20250620130709.31073-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32f; envelope-from=philmd@linaro.org; helo=mail-wm1-x32f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1750424919787116600 arm_cpu_post_init() is only used within the same file unit. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- target/arm/cpu.h | 2 -- target/arm/cpu.c | 2 +- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/target/arm/cpu.h b/target/arm/cpu.h index 302c24e2324..c31f69912b8 100644 --- a/target/arm/cpu.h +++ b/target/arm/cpu.h @@ -1150,8 +1150,6 @@ void arm_gt_sel2vtimer_cb(void *opaque); unsigned int gt_cntfrq_period_ns(ARMCPU *cpu); void gt_rme_post_el_change(ARMCPU *cpu, void *opaque); =20 -void arm_cpu_post_init(Object *obj); - #define ARM_AFF0_SHIFT 0 #define ARM_AFF0_MASK (0xFFULL << ARM_AFF0_SHIFT) #define ARM_AFF1_SHIFT 8 diff --git a/target/arm/cpu.c b/target/arm/cpu.c index e025e241eda..eb0639de719 100644 --- a/target/arm/cpu.c +++ b/target/arm/cpu.c @@ -1713,7 +1713,7 @@ static void arm_cpu_propagate_feature_implications(AR= MCPU *cpu) } } =20 -void arm_cpu_post_init(Object *obj) +static void arm_cpu_post_init(Object *obj) { ARMCPU *cpu =3D ARM_CPU(obj); =20 --=20 2.49.0 From nobody Sat Nov 15 14:11:25 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1750425061; cv=none; d=zohomail.com; s=zohoarc; b=A/yOGnfmvR5FRARo5bRTvkvn4Up6tjn/U/vrb3+CYKc0DW3OTPE+bMYeC5fmvSvqBTfUDWCQTc8L3Y5Nu1FZladWRlyW/ecnI6/kYp3sKLrErPFLDsfSYwIXc8leKfpABYog6WYuO1lrliwADRqLoMKgbiHFP4EmCfIuDJ/+H2o= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1750425061; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=g4jpPoIjWAnN20gltB2a/vOsrmaIk3+mmplMj5/YsrY=; b=BM6raobIqxIp/LaqJnYX198Vk5pnW7CG+J9DBdLuMu1HFsy921hLVLyHKFZBEPhv5j3U4OlTDPEt7h8NZIgCxz65s//KLBrCEwARADA4uQddDn0U20AXNh4RkzPTI+6YtGLQHdTZiisMpUrdvTnP44Egai1abpCDSmh030FQz2I= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1750425061863429.15151588096853; Fri, 20 Jun 2025 06:11:01 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uSbT4-0002Of-H4; Fri, 20 Jun 2025 09:07:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uSbSt-0002LP-Vw for qemu-devel@nongnu.org; Fri, 20 Jun 2025 09:07:35 -0400 Received: from mail-wm1-x32b.google.com ([2a00:1450:4864:20::32b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uSbSs-0004Vv-FK for qemu-devel@nongnu.org; Fri, 20 Jun 2025 09:07:31 -0400 Received: by mail-wm1-x32b.google.com with SMTP id 5b1f17b1804b1-43ea40a6e98so21254345e9.1 for ; Fri, 20 Jun 2025 06:07:30 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4535e983a4bsm59724925e9.13.2025.06.20.06.07.27 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 20 Jun 2025 06:07:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1750424849; x=1751029649; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=g4jpPoIjWAnN20gltB2a/vOsrmaIk3+mmplMj5/YsrY=; b=p6uRPjm8nNi3xleXh/tSBi9IPU12pLIq6HmOywtq84fAbVT7UW9DniAD0vBdgYkMKR 4/g1x67D8S0zX7+XZetZKzMm1iRy73X+KBq/R8kbAoP6K2PuGQ5fhU9ejrqAx0dmCwmF UsSEZL5tiCteq24ruL6i7WestJXyLYMZoa9sYJDChV03pjSRaPp4lZqyxu7dr7GEIqP6 gu6gQWkEfNcouFhUlWy4xIcQeh9sCGuR0gKTPLvQ7VwHCUXJip1byHtNOxcLasW7fwbg v7yg4Jg91T/aGGH3F0zj2bu8rltGn0Gvfa2kFlElI8ePOujPdafUb4hXoWBQ8zSP/aF2 xUkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750424849; x=1751029649; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=g4jpPoIjWAnN20gltB2a/vOsrmaIk3+mmplMj5/YsrY=; b=YCIm9V/efuYehzkonhQ7d0rEVnOIlR1POx/79osE6oUzQwBsYwm3wzbRZSiSADB0hB b/gHP5HKW7imcrVOMRcCktt+1n7BsO2TPo30Tv/HSjMqxCOXDDtxIGMCTFmmnuiow1Ea GNSMy8K/9zAKcUE98OHOmD4SGZZA1sRLgez/xjA/h/tBs08zTsKuec4yIf0AtPFqYZbr AnMvr00MSzH/9B1ITaClROJDmys/1FJxkXiNLtookAVsF6MugZ9/qFbYwofncQhYFQiT YnehHW0E6uE6lH8t5qu4kpv8/REzh+SGnuovruLn7Xu2pXnYxcfJApoUtYFJ81GgjDMV t7Lw== X-Gm-Message-State: AOJu0YxxCSM6bE+M6tfUE1cfgibZap1sQlidnpIj5KzSkD6FdggWbAL8 zYCg7/NSjTInXENUR4jqxv9sTHSgZs3ksAx60Dj9uXuEWdkMKhwj/gSRROuiau4K+xDpQYQzIU1 BRG69/KM= X-Gm-Gg: ASbGncvGFT8+ejmWfEN2/jyMU6szHPOUTZO1Aex1RL9fMeQMJWTVYys7pme3XJKO00u 6wQ/bsqQUxZ0/Al9vAz6Q5b77FTUG8qHV9xeAFSSARgcxXRZ1W7+RD/dz81bmiD+1VUJKRmU5jP LvCh6cmmglqhgsOFMhsSbnrjrdsZSGchZh+YcjCp14R8dv+xfV+MzrR7BDYpKAi+ZhBU9sefUaG 3znTmRflh+sgLaos/+uLOUzEnDnMGfRZpkKmhxrEyxF6a7VNdIGOp98FMdooDsHMbk8B97arnc/ 3delmT8gsO2ZhZiJYESIWCKwCPawPFBh2i40UDnFekfiGaM1nyoeMQHZkQftgyxInrvjc4lyp3X SUpMlvAKYMl/OyoZJTCkcL0DJrLRmVp58m9c4 X-Google-Smtp-Source: AGHT+IHvqyAxctyWiDO7wt3FaACda4gkUZk2ECgfjgeswwsSXX3ba2fXpQZsZ/3OnTwR/gx0VWlMzw== X-Received: by 2002:a05:600c:154b:b0:43d:40b0:5b with SMTP id 5b1f17b1804b1-453659b885emr24539615e9.25.1750424848387; Fri, 20 Jun 2025 06:07:28 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Leif Lindholm , Richard Henderson , Radoslaw Biernacki , Alexander Graf , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Paolo Bonzini , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Phil Dennis-Jordan , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Bernhard Beschow , Cleber Rosa , Peter Maydell , Cameron Esfahani , kvm@vger.kernel.org, qemu-arm@nongnu.org, Eric Auger , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Thomas Huth , Roman Bolshakov , John Snow Subject: [PATCH v2 03/26] target/arm: Unify gen_exception_internal() Date: Fri, 20 Jun 2025 15:06:46 +0200 Message-ID: <20250620130709.31073-4-philmd@linaro.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250620130709.31073-1-philmd@linaro.org> References: <20250620130709.31073-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32b; envelope-from=philmd@linaro.org; helo=mail-wm1-x32b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1750425063853116600 Same code, use the generic variant. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- target/arm/tcg/translate.h | 1 + target/arm/tcg/translate-a64.c | 6 ------ target/arm/tcg/translate.c | 2 +- 3 files changed, 2 insertions(+), 7 deletions(-) diff --git a/target/arm/tcg/translate.h b/target/arm/tcg/translate.h index 1bfdb0fb9bb..0004a97219b 100644 --- a/target/arm/tcg/translate.h +++ b/target/arm/tcg/translate.h @@ -347,6 +347,7 @@ void arm_jump_cc(DisasCompare *cmp, TCGLabel *label); void arm_gen_test_cc(int cc, TCGLabel *label); MemOp pow2_align(unsigned i); void unallocated_encoding(DisasContext *s); +void gen_exception_internal(int excp); void gen_exception_insn_el(DisasContext *s, target_long pc_diff, int excp, uint32_t syn, uint32_t target_el); void gen_exception_insn(DisasContext *s, target_long pc_diff, diff --git a/target/arm/tcg/translate-a64.c b/target/arm/tcg/translate-a64.c index ac80f572a2d..7c79b8c4401 100644 --- a/target/arm/tcg/translate-a64.c +++ b/target/arm/tcg/translate-a64.c @@ -433,12 +433,6 @@ static void gen_rebuild_hflags(DisasContext *s) gen_helper_rebuild_hflags_a64(tcg_env, tcg_constant_i32(s->current_el)= ); } =20 -static void gen_exception_internal(int excp) -{ - assert(excp_is_internal(excp)); - gen_helper_exception_internal(tcg_env, tcg_constant_i32(excp)); -} - static void gen_exception_internal_insn(DisasContext *s, int excp) { gen_a64_update_pc(s, 0); diff --git a/target/arm/tcg/translate.c b/target/arm/tcg/translate.c index 9962f43b1d0..f7d6d8ce196 100644 --- a/target/arm/tcg/translate.c +++ b/target/arm/tcg/translate.c @@ -372,7 +372,7 @@ static void gen_rebuild_hflags(DisasContext *s, bool ne= w_el) } } =20 -static void gen_exception_internal(int excp) +void gen_exception_internal(int excp) { assert(excp_is_internal(excp)); gen_helper_exception_internal(tcg_env, tcg_constant_i32(excp)); --=20 2.49.0 From nobody Sat Nov 15 14:11:25 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1750424885; cv=none; d=zohomail.com; s=zohoarc; b=UpmmJt+AKP9xcwrUjIw4T0/9uCn/GTbY6HXy1fWj7NnqgBFVygTz2zX6YUBbLGz342uiUqbZIODMe9Kd9LBY7UrdnSY0oYRxLUlecsGlgG0YCCOIhx6q+geEMiH8dxrfYiNlCLVWWK96mf5eWV2V6CPrgFOB3tFEpYXL+zwA7Ks= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1750424885; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=i7X9qE0A0zkH5gg9YDfRhHn13dFLj9D3tYtyAnJR94U=; b=W2tB596yTmPRzagIp0oOFvWut9qXQ1i2S8xRJZtFKpXTd724/9n99knC4wYTu5gXxjVJ1U3KZHBa86zXItV2ypYI8o/hzVj17FpSdFUhM1tYOHvhRXdKDWSaPg+ppDxFKmkj/2amPR/rjA3M5pmQqCSlYkd8q7NvbFcFtTo46zA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1750424885331452.9997057712834; Fri, 20 Jun 2025 06:08:05 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uSbT2-0002O3-O1; Fri, 20 Jun 2025 09:07:40 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uSbT0-0002Mw-Cp for qemu-devel@nongnu.org; Fri, 20 Jun 2025 09:07:38 -0400 Received: from mail-wr1-x431.google.com ([2a00:1450:4864:20::431]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uSbSy-0004WZ-QT for qemu-devel@nongnu.org; Fri, 20 Jun 2025 09:07:38 -0400 Received: by mail-wr1-x431.google.com with SMTP id ffacd0b85a97d-3a375e72473so862902f8f.0 for ; Fri, 20 Jun 2025 06:07:36 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45364703f1esm25142395e9.32.2025.06.20.06.07.32 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 20 Jun 2025 06:07:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1750424854; x=1751029654; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=i7X9qE0A0zkH5gg9YDfRhHn13dFLj9D3tYtyAnJR94U=; b=RriqMD/7m9gtm3lFIfhojDFxFLhIvvtHSX8TKcO/jpQmHX7brYioAzj7WxlHNYNzUT GG9VUtZbLYYXzWsl3v0eyylhe+s7KZgqrDeVWmYodc26h4LIv8QJ3qr6owflIfJye8OO prK6aFGSYE6mwjyENP/adObTInGfxW6zOizt3S28CAgCk1VGcpeA/jNeTCEbYzhVUCNl CtF35ywrtn73UGMD9Dyv5JeIaEE9cywQqLhoJXFnoo8Bn3Y9IW0jwr5IqrQE4AZzjrgl BH5sxeRGm7UWEWidv39NI97arNy0EY3gv96zvINpU2pLBGPXhMCnM0hPwi8Hn676Jmwq Z+MQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750424854; x=1751029654; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=i7X9qE0A0zkH5gg9YDfRhHn13dFLj9D3tYtyAnJR94U=; b=WHyMqjHgV/TOvFCSiHAvmBfCmdEvHjZbJ6g53N6ZkbopRp+wrYzH0WQUdx93W5Pkbv RfTX7uK+L6VQr5vzYmlFY/4XfKPCOMBk4bTkRTKiiE+ARvUSZ55tDL5i3jnQol6k4l/r EaqoEiTCiqmPNSKwsyhDnZZEBvqyfwb4QuRQ5Yu6LYC2u4pKG/4jcXDuOSg/fxiaBBs/ z/q7oakXrWDXWG6Eeo3E4Z0P0EGm9R0D+qVfspk3VLwnkPzWGk8U+eYt7aBJRJuU+SQy NcI4o3bjyxi+IUy4e+Un7eK0KkdTFqe80pILxXHtiu44T/Ocx/NXMTc4SsvYQmFJhT87 idiA== X-Gm-Message-State: AOJu0YyVAnJFXvYOEEZg9mu4mlkBsQK5Mj2HMJ3hU/ek+9upa9OLiUnx t+ooJzjnyBdPUi7F1V0HX8wMUuDg6JtGYPN2HKPGvQg+q4EFZVbUPbkLliueqVHB8p6/SXy8nww Q3lh3wTc= X-Gm-Gg: ASbGncsFLxdnoQH3hugXhwuY9sSn2gb02whP7EtXr+JdZp1yqIbA1jVTo4iSiEIYYEJ xgInC7x8n8FIHS70p9nTsA7x0owyIUM1+3kp5scwxS9S2jgfJf2Kygk6w1m8hYNVrFPsxS1z03i LQ2oWgklkgq3wL3wZQw5fF6oCKvt26xJzLKiupzh5a+VFC0q6EvdvXihXCP8+WTMWg4f3YRq4Vk +7L+89D13+qp8P08TgwKzLAkIhgtxBftAZkAtiThMHD1MNS2MELd9uIX0gRSISfHl3eDNQ1csRg xp/yEZdax7rCv26ciBxdVy7rO4stZ/Dnv0t6cqBbfivHQiKcO3ZUci0bPP3dVY7CdO4KzOqWkcQ 2zDnOHnjzXecxIPW3ywRDMk6ED4ecEzn6NATqFwj0dGfwOQA= X-Google-Smtp-Source: AGHT+IG8MOa1mgx5GRJT2pi7G8sTIbJ7uQF1KFg+Pl8xxcjdSw3j34E0kQi1ej0Od+hgqLrB/UqKrg== X-Received: by 2002:a05:6000:4715:b0:3a5:2923:7ffa with SMTP id ffacd0b85a97d-3a6d1193fd2mr2532616f8f.7.1750424854370; Fri, 20 Jun 2025 06:07:34 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Leif Lindholm , Richard Henderson , Radoslaw Biernacki , Alexander Graf , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Paolo Bonzini , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Phil Dennis-Jordan , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Bernhard Beschow , Cleber Rosa , Peter Maydell , Cameron Esfahani , kvm@vger.kernel.org, qemu-arm@nongnu.org, Eric Auger , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Thomas Huth , Roman Bolshakov , John Snow Subject: [PATCH v2 04/26] target/arm/hvf: Simplify GIC hvf_arch_init_vcpu() Date: Fri, 20 Jun 2025 15:06:47 +0200 Message-ID: <20250620130709.31073-5-philmd@linaro.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250620130709.31073-1-philmd@linaro.org> References: <20250620130709.31073-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::431; envelope-from=philmd@linaro.org; helo=mail-wr1-x431.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1750424887803116600 Only update the ID_AA64PFR0_EL1 register when a GIC is provided. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- target/arm/hvf/hvf.c | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/target/arm/hvf/hvf.c b/target/arm/hvf/hvf.c index 42258cc2d88..c1ed8b510db 100644 --- a/target/arm/hvf/hvf.c +++ b/target/arm/hvf/hvf.c @@ -1057,11 +1057,15 @@ int hvf_arch_init_vcpu(CPUState *cpu) arm_cpu->mp_affinity); assert_hvf_ok(ret); =20 - ret =3D hv_vcpu_get_sys_reg(cpu->accel->fd, HV_SYS_REG_ID_AA64PFR0_EL1= , &pfr); - assert_hvf_ok(ret); - pfr |=3D env->gicv3state ? (1 << 24) : 0; - ret =3D hv_vcpu_set_sys_reg(cpu->accel->fd, HV_SYS_REG_ID_AA64PFR0_EL1= , pfr); - assert_hvf_ok(ret); + if (env->gicv3state) { + ret =3D hv_vcpu_get_sys_reg(cpu->accel->fd, + HV_SYS_REG_ID_AA64PFR0_EL1, &pfr); + assert_hvf_ok(ret); + pfr =3D FIELD_DP64(pfr, ID_AA64PFR0, GIC, 1); + ret =3D hv_vcpu_set_sys_reg(cpu->accel->fd, + HV_SYS_REG_ID_AA64PFR0_EL1, pfr); + assert_hvf_ok(ret); + } =20 /* We're limited to underlying hardware caps, override internal versio= ns */ ret =3D hv_vcpu_get_sys_reg(cpu->accel->fd, HV_SYS_REG_ID_AA64MMFR0_EL= 1, --=20 2.49.0 From nobody Sat Nov 15 14:11:25 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1750425081; cv=none; d=zohomail.com; s=zohoarc; b=BvmuWL0vAwfchyuvkAxIFIeUj17WWv+wnv12naPvBXWPsInjj3huXlkndhP1oe3BZUgFxM6CnghsO5leId1JMEe7JWTSBQkG+DbHYzxu1r4HcIbJfTe1sEdmJk8cH7Rgcf2NJYQlcd12AErBUQTpK9vKGe/zzNRcPyORF1n1jBo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1750425081; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=XksfEnABhqse0vfJxYZJ+Lf0uyahV9aipIl1Sny7z0o=; b=GCv/XobnydL00vSlJZw716GJQgqaZm81AMgTS+YQpCGsM0eHfwT3wm/aTWHSvie0czBVzX5esTjbFKJiB0c862Loygkti09JiS4p03i9HUWKsf5yRKqyiXV+zCPoKratiiabI5m3KyhkfXrr2ruZGEyCrSwh1EXCvlcAEiltANk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1750425081529256.32738315522624; Fri, 20 Jun 2025 06:11:21 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uSbTA-0002Pu-2Z; Fri, 20 Jun 2025 09:07:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uSbT5-0002PV-0u for qemu-devel@nongnu.org; Fri, 20 Jun 2025 09:07:43 -0400 Received: from mail-wm1-x32a.google.com ([2a00:1450:4864:20::32a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uSbT3-0004XH-Gw for qemu-devel@nongnu.org; Fri, 20 Jun 2025 09:07:42 -0400 Received: by mail-wm1-x32a.google.com with SMTP id 5b1f17b1804b1-451ebd3d149so11651025e9.2 for ; Fri, 20 Jun 2025 06:07:41 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4535eac8edbsm58978705e9.24.2025.06.20.06.07.38 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 20 Jun 2025 06:07:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1750424860; x=1751029660; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=XksfEnABhqse0vfJxYZJ+Lf0uyahV9aipIl1Sny7z0o=; b=UBwtG0MudX4paiA7gOqGytVjb/JBmLANjQuB1aKXFyqhMJFF7GYAvtkxI4VsYosuIU eW1219lN4RME1JE/9lbiOnFmJ5lPIBcKtvJ3ISTEYLuqz776gdbGzjC2Mhu93UT3TBxi 3sEmdeBXbNDT/4xrOZ4isfWIusul6IGI74XnkWgv0Z354xutGYP1+40gE7i3nqqjbcKH zsz8JEzYUG91A6zdR1qV9dXjRwo2QKgRCh93lYUsiIxWD05TF84em0ezhGdUkIiBMVNY m2X2mX0qSpchbTEnyeL4emsEAJYAybzOYnScDoyUs01AyHm+eYPyPyjKC0JP5AJORDVf SK3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750424860; x=1751029660; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XksfEnABhqse0vfJxYZJ+Lf0uyahV9aipIl1Sny7z0o=; b=pYCS4+Yd1o8Rc3Jcn4fzLwxHsCwFYAa8LTGFI5lfeecuqFEqJpgYs8BhRQQpVj8XUz oXuBedszppZvQnFJq/uWdNyAxm87JynqpklSN4yn3mPkPfdQmmhgATjlWx2k4m0EyUjM wzyM31cSjnuJEi55rmECL8u/H9MyTI++P8lon3yHE1/n6wj55V2JBpz7vEAiRhvAFEhi fX2pOmxhsME6Q/ZkL/Y//SWT1OwTZDfLXLMq16JBTbeMkHoC+6e0PXEsIiejO9Xw7eVE mtBzb9GOW7QphtBcJzUkGwd+EMhReQnalrCsLSSD4doIq8MJsUhwa5ndzvLnxp3jgnU+ ZPfQ== X-Gm-Message-State: AOJu0Yzk4yQfduAFsvmpnuHQGZX2qgRmCIMtSva/GETHOO60CBoQH7Fo L67VHNT0zi8KljKTGAm1quxHUCOQGB1Y7Cp9mBmi3a22Xj3H2qxWMxRuc+i7/gzWDZYDuSx3Ykn AMistKhA= X-Gm-Gg: ASbGncusJbl/KemDfGvd87HZlM+T3IPklt1lh2iA7ECbe6pltjszu9MPKqVkPbedyuO D+WVUKXIYNQySXxFqmiAch+2/BSuGk2osJggJ7Zxuj1DltxhXNyQzDlO7ujpfxU9dL55R9oIl/m rW4cJfRtrjTe7fDvbvlL7C/ne+NHVI1QOnxSzWlAiCKrC65fzKTVYq2maRwO7mfwdjViNzo7Wpj Y4IN5XpPLQ+3rSlWpolMXdfQypnCcX6WP2N2DhDebUL0pZBRgyAoKF7tnfLpXZnAzluLAagt9df wuhvnaoa+euuNs2UOYKX/KbBZM1MBKxPtK5G8yVztQGY+o41JcStBQ8VmIq9i5NPOWJBZD+6Dx5 9slvsG/hk5Npr6EQF0qBFSzLpOi0FW0krRZan X-Google-Smtp-Source: AGHT+IE/7BsLb9TONAHrydupa8DFXSIV1OrSggLSDyPpvWjke04D0dS/jXyuRBj9Ay/VLjM8ny9caw== X-Received: by 2002:a05:600c:c103:b0:43c:fffc:786c with SMTP id 5b1f17b1804b1-45368787924mr6185275e9.19.1750424859628; Fri, 20 Jun 2025 06:07:39 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Leif Lindholm , Richard Henderson , Radoslaw Biernacki , Alexander Graf , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Paolo Bonzini , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Phil Dennis-Jordan , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Bernhard Beschow , Cleber Rosa , Peter Maydell , Cameron Esfahani , kvm@vger.kernel.org, qemu-arm@nongnu.org, Eric Auger , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Thomas Huth , Roman Bolshakov , John Snow Subject: [PATCH v2 05/26] target/arm/hvf: Directly re-lock BQL after hv_vcpu_run() Date: Fri, 20 Jun 2025 15:06:48 +0200 Message-ID: <20250620130709.31073-6-philmd@linaro.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250620130709.31073-1-philmd@linaro.org> References: <20250620130709.31073-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32a; envelope-from=philmd@linaro.org; helo=mail-wm1-x32a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1750425081981116600 Keep bql_unlock() / bql_lock() close. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Acked-by: Richard Henderson --- target/arm/hvf/hvf.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/target/arm/hvf/hvf.c b/target/arm/hvf/hvf.c index c1ed8b510db..ef76dcd28de 100644 --- a/target/arm/hvf/hvf.c +++ b/target/arm/hvf/hvf.c @@ -1914,7 +1914,9 @@ int hvf_vcpu_exec(CPUState *cpu) flush_cpu_state(cpu); =20 bql_unlock(); - assert_hvf_ok(hv_vcpu_run(cpu->accel->fd)); + r =3D hv_vcpu_run(cpu->accel->fd); + bql_lock(); + assert_hvf_ok(r); =20 /* handle VMEXIT */ uint64_t exit_reason =3D hvf_exit->reason; @@ -1922,7 +1924,6 @@ int hvf_vcpu_exec(CPUState *cpu) uint32_t ec =3D syn_get_ec(syndrome); =20 ret =3D 0; - bql_lock(); switch (exit_reason) { case HV_EXIT_REASON_EXCEPTION: /* This is the main one, handle below. */ --=20 2.49.0 From nobody Sat Nov 15 14:11:25 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1750425258; cv=none; d=zohomail.com; s=zohoarc; b=blcE0hDCk5LJ+pdA+WRYTy/aoYIYwZtTNknor6yIaaY30tWp5Zu7+OQKBDo9uQPUaEOq2NwhY20dZQZUb5Ittorp14eKtZScyW79/lvqaXUcvXKdqj9Kn2TD2Fb7xpBteZjUzWeX8ILBQ1jmGfI/kylKfvfrC81ubOn6ftVe5rM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1750425258; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=FtS7m+vqlh7Qr+Y7luF/PvAhAhpP9RBj3It7GX3FL/4=; b=mEHulB3RQBHnYCWzcYtlTTNqz2Xm3Qq7HAMsAoSOFu5GhKBDoUphJNKVgRAu1YetNPiyyESqRKxsoqQUPed2EQl9SP4I1CJL0Bl6fwn+cZQAE7Ff6w0c+XP4/6LPVveIDibAItYtzDu8IR0p1+sgolVcCBid36b1P6FQXATMwy0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1750425258755900.2051452860736; Fri, 20 Jun 2025 06:14:18 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uSbTI-0002VD-C8; Fri, 20 Jun 2025 09:07:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uSbTC-0002ST-Rf for qemu-devel@nongnu.org; Fri, 20 Jun 2025 09:07:52 -0400 Received: from mail-wr1-x431.google.com ([2a00:1450:4864:20::431]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uSbT8-0004Y6-Si for qemu-devel@nongnu.org; Fri, 20 Jun 2025 09:07:49 -0400 Received: by mail-wr1-x431.google.com with SMTP id ffacd0b85a97d-3a6cd1a6fecso1475149f8f.3 for ; Fri, 20 Jun 2025 06:07:46 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-453646fd6efsm24774235e9.19.2025.06.20.06.07.43 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 20 Jun 2025 06:07:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1750424865; x=1751029665; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=FtS7m+vqlh7Qr+Y7luF/PvAhAhpP9RBj3It7GX3FL/4=; b=zH91U74iSn5GtKsckcmd0iBoAZcTzYYPUUmewBX+jAwbdVfmmN1EuXv+brh4j0I12o gR4YEtvCY5ITBDpicYLQWEXI0qypQo3B7kZJS87cbhefYFe6DFiB+xPZB+cYnc2lVJwj dXEJ6jT4TetBaCvmKfuMAAr51vAFCX4f+k9J8Xw9lLXU0Rj7UH8t5gyy5lCNNPxpEQpI FphVgY9gp1STY5RtfadBWPqcQmtyXBJbLBYrMEguJ6pBMjwS7aGW6uIaMZVW6zslfhtn 0zrerrI3o5abNi/7F5/i/n3Usp9UqdF8TZ4txoemzEvN9XF93sHrn2PyjmTIpZ5nsviq M7yA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750424865; x=1751029665; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FtS7m+vqlh7Qr+Y7luF/PvAhAhpP9RBj3It7GX3FL/4=; b=Vh1B+GZnl0T+lA7/Vw5U0LdAexh7jed30uoKdh8bqd7cq/+4/o3ytk/t2pSAEl9n/c i+UnWcj1F2quwqDKglr2WoccN3OyGGIIWeOXyatFFMS9PU+MTqYhD4l5QgD4hIYTdhvc 6RUffT5K2OfD3d+IxCvLnnxHL2YI29K9VxL7Oz/euJP5SetgQRN1l1dWtjkHdsK7AhiA 4GfhVNAHJifYw3suUTkK6rTPqp1LhgCy9klZbceSvUDJ88aWFtWW4M+mPMm2HIFB+1Rc mlaYJVie/2t1gNxbOn/OSqlR5TXokQqLY7ruTOvg9cA2Bz1xKskKVTbUEs4BjD0zZUA4 ngZw== X-Gm-Message-State: AOJu0YzqaouZGUsIK/wC7zl8jOkNcg0iCThYRQ9+yzAgCRwVWSdmsyWV PHmJcRGkgaQQSR9puG2AHTUqGALqxSIxrg73S5FwlakdvY21Wfxd5d0bOrm/a59VcS97vJZie74 XXBMSAJY= X-Gm-Gg: ASbGnctU6h2/ckRjnicKxmGmAQZU3QCVg1UVMOnRsaHS8eunUONlPDWJn7lfo8ObAGP P7W7Ja6UZfU3SWWGGRtIYFACLoo0x1hCpdh/9UzGktai60jmhYVwGl+2cfzryWxx8XDkKYBRItv qed2eKOSssBGEwODphnDdsQCf7mWGV0aSetlH0mND+1TL70l3oOCfoGYU+fysgPhaKhXFtfubvM lDZxMUftPPrAVtVneysUqiNaaUAH0E2VoK/ZJL7dm9LsRF/0CKdYRI/4n4DiLhnVA3AkLP0LOHR Bf/Y3nAE3aGXujdS0pzUNn4NnMmX2dmVs412ms3eQdIaIKEpoBkqkVx4TsqCqHOapkJ2qS8CADh GMUw+OogolBJIsxHVq6mxrCc2eivJv63jUIvF X-Google-Smtp-Source: AGHT+IEu8ioD15jbsMdE6dCvAm9djKzVzv/o3I1P7WHIydoF4yyDTcP15aw9RWPaSxBAHXijuGZgUA== X-Received: by 2002:a05:6000:310a:b0:3a5:8cc2:10aa with SMTP id ffacd0b85a97d-3a6d12fbab7mr2059859f8f.32.1750424864938; Fri, 20 Jun 2025 06:07:44 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Leif Lindholm , Richard Henderson , Radoslaw Biernacki , Alexander Graf , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Paolo Bonzini , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Phil Dennis-Jordan , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Bernhard Beschow , Cleber Rosa , Peter Maydell , Cameron Esfahani , kvm@vger.kernel.org, qemu-arm@nongnu.org, Eric Auger , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Thomas Huth , Roman Bolshakov , John Snow Subject: [PATCH v2 06/26] target/arm/hvf: Trace hv_vcpu_run() failures Date: Fri, 20 Jun 2025 15:06:49 +0200 Message-ID: <20250620130709.31073-7-philmd@linaro.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250620130709.31073-1-philmd@linaro.org> References: <20250620130709.31073-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::431; envelope-from=philmd@linaro.org; helo=mail-wr1-x431.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1750425260430116600 Allow distinguishing HV_ILLEGAL_GUEST_STATE in trace events. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- target/arm/hvf/hvf.c | 10 +++++++++- target/arm/hvf/trace-events | 1 + 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/target/arm/hvf/hvf.c b/target/arm/hvf/hvf.c index ef76dcd28de..cc5bbc155d2 100644 --- a/target/arm/hvf/hvf.c +++ b/target/arm/hvf/hvf.c @@ -1916,7 +1916,15 @@ int hvf_vcpu_exec(CPUState *cpu) bql_unlock(); r =3D hv_vcpu_run(cpu->accel->fd); bql_lock(); - assert_hvf_ok(r); + switch (r) { + case HV_SUCCESS: + break; + case HV_ILLEGAL_GUEST_STATE: + trace_hvf_illegal_guest_state(); + /* fall through */ + default: + g_assert_not_reached(); + } =20 /* handle VMEXIT */ uint64_t exit_reason =3D hvf_exit->reason; diff --git a/target/arm/hvf/trace-events b/target/arm/hvf/trace-events index 4fbbe4b45ec..a4870e0a5c4 100644 --- a/target/arm/hvf/trace-events +++ b/target/arm/hvf/trace-events @@ -11,3 +11,4 @@ hvf_exit(uint64_t syndrome, uint32_t ec, uint64_t pc) "ex= it: 0x%"PRIx64" [ec=3D0x% hvf_psci_call(uint64_t x0, uint64_t x1, uint64_t x2, uint64_t x3, uint32_t= cpuid) "PSCI Call x0=3D0x%016"PRIx64" x1=3D0x%016"PRIx64" x2=3D0x%016"PRIx= 64" x3=3D0x%016"PRIx64" cpu=3D0x%x" hvf_vgic_write(const char *name, uint64_t val) "vgic write to %s [val=3D0x= %016"PRIx64"]" hvf_vgic_read(const char *name, uint64_t val) "vgic read from %s [val=3D0x= %016"PRIx64"]" +hvf_illegal_guest_state(void) "HV_ILLEGAL_GUEST_STATE" --=20 2.49.0 From nobody Sat Nov 15 14:11:25 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1750424898; cv=none; d=zohomail.com; s=zohoarc; b=ejQcEIMlCIcCeQ44ublny4UnT8xu2LwFLgiktjdMKdKcqicLdgh9WmPhzX7hchdrCB64Gn4SvJ/4zcMEqBVBuI+ANDMO5P58cyHSDzyDj0rx172UmA4kcTTnqn8Y4eFjLv5feQYWSOMnrN9hZPvrE5s1rmXv6vUsrFXzDoekN48= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1750424898; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=Q43gncpn959Q6vZG2TfwFzrP1CTDyk3SKCOoBpm/1fs=; b=AbtJLsPMdfCIMnon+cuglzktQvyYGBg8qb8VsqvK3WXnW3DknwlrA71cc5LCd2qpBzcUqTr4xCv1XlHVozw7xkKIfSR+2gNfj3qUu6OXbwHEuQowknGw0SKRieuep5c/TfY55mRf2Je6nV920de7Si0wPBZcYQ/zIJbfdPTRZwM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1750424898471446.84328161382166; Fri, 20 Jun 2025 06:08:18 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uSbTN-0002ZE-Sx; Fri, 20 Jun 2025 09:08:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uSbTI-0002VS-Hz for qemu-devel@nongnu.org; Fri, 20 Jun 2025 09:07:58 -0400 Received: from mail-wm1-x32d.google.com ([2a00:1450:4864:20::32d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uSbTE-0004Yh-P2 for qemu-devel@nongnu.org; Fri, 20 Jun 2025 09:07:54 -0400 Received: by mail-wm1-x32d.google.com with SMTP id 5b1f17b1804b1-450dd065828so13296095e9.2 for ; Fri, 20 Jun 2025 06:07:52 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a6d117e520sm2053595f8f.56.2025.06.20.06.07.49 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 20 Jun 2025 06:07:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1750424871; x=1751029671; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Q43gncpn959Q6vZG2TfwFzrP1CTDyk3SKCOoBpm/1fs=; b=TSmQQYdJ0O2tKdPY417QHnevALRHTi/C0D/UPXZuhRNn9fmdvhVNMARf8Yau6I+HVD SQWhTZF9kuwHivYGzdVYZPS+dlqJXP0leHbA+TeaJhIi/UyAPZF0DMEUtc7H37L3PjCf WWZTM22GzFZdZmCiFxOfe3AWvy3x/dY/ahvYYfDbpGpTLpJJsYIoqQJSHOS2MlmsFOZ0 fmAkJEmhOScFRXDOS0hKdXk6YJ0nQ/DfgmNA4m4ASFjBhBWXwkhZPD2A6azWVUJrwvwg qH09hyNdrAMM2BPizSANjft6oxWQ16VO1rcvH+KFDswCokrVlboIeWw4AtPzRAUhUFuy tqjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750424871; x=1751029671; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Q43gncpn959Q6vZG2TfwFzrP1CTDyk3SKCOoBpm/1fs=; b=BJBQ4BMKGc7pBUOBUJLTwu19RHT+wP5+mVldGDtyI809oRK449By1vc7fNtYIALmOt /TURTK86hPQXgcvQG790kgLqAmYYGy1bmjOqqNTEqp9wYMzNmY168tLz9azm53lIFYIg d7IfBHZIjszfpqKpK0TxODuiKWiCkmzdUgSPXAKpTxerqy1/9nJSoteElqTMHUtPO8HG GF9Y6fokZ4HCrhhPpMJGY2ghOKbO/3xluYCWIgJk+wgBaYmb/PX1uyZoHUeg5p/bF9Bj bNfwQyef714+VDc3wAmatUg3l8BqXg1UaT358yubDjAcmJqzUS8cFYyXbJA7Q/rKdcaO ZuIQ== X-Gm-Message-State: AOJu0YzwMG/P9mp0ZzWR3y/5Xg0ml0EPxO3M08Umx8bS5ZPAJaPTjO1u 0hwpT0rS067pJbF+RJqAGrABZTT67j5uM1jw9R8MAe+UrdN+W08qrS/toTaqWPBGR0j0DxfARwQ MnIwRxSM= X-Gm-Gg: ASbGncs8wn+Ch9f0v4Vie49qa3AzvmuFEZ7e3m7XmNAda1InI2o3Mhmji/dmbY+epgR Ts2d4CVX/Re7e1Wpqlb8sRiRlP4gzWcXo97UpVKBYUacdgIHFJE3sUsX5Aueli0Dj5txiqGcgBr Bi0cm4JEDQmXlw6DMGULwdwjxPWbrShmTWZpS7gNTA9zpun4M+qbCrTZzcUaQhdrD5Mmqlb0ZKR p5sAdNc3p4ZHLZfwvQTxorvPDJVJTNvlDhCG3wjhNflCPtZi0bACulggOGbGz+4C9G0MmMjWMmD G/1nPeahc63YHhWtfNTL2e4iZJ+2c9eBS9alY+HPGXuLhyGPBMSdsZiLpxt6/m1zhsYZWD95SbU WViFYdwjGunE1XlGrbvlnrkEeZdTWxDXPBmFv X-Google-Smtp-Source: AGHT+IEV1rnW6Q6vc9usSp2h/xg/oNVsZIj/bM4fFPHRe8OtleGcivh/UCl8l6pejkhU6VSf44Ctdg== X-Received: by 2002:a05:600c:3545:b0:43c:fffc:7886 with SMTP id 5b1f17b1804b1-453654cc009mr23346725e9.8.1750424870729; Fri, 20 Jun 2025 06:07:50 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Leif Lindholm , Richard Henderson , Radoslaw Biernacki , Alexander Graf , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Paolo Bonzini , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Phil Dennis-Jordan , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Bernhard Beschow , Cleber Rosa , Peter Maydell , Cameron Esfahani , kvm@vger.kernel.org, qemu-arm@nongnu.org, Eric Auger , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Thomas Huth , Roman Bolshakov , John Snow Subject: [PATCH v2 07/26] accel/hvf: Trace VM memory mapping Date: Fri, 20 Jun 2025 15:06:50 +0200 Message-ID: <20250620130709.31073-8-philmd@linaro.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250620130709.31073-1-philmd@linaro.org> References: <20250620130709.31073-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32d; envelope-from=philmd@linaro.org; helo=mail-wm1-x32d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1750424900046116600 Trace memory mapped / unmapped in the guest. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- meson.build | 1 + accel/hvf/trace.h | 2 ++ accel/hvf/hvf-accel-ops.c | 6 ++++++ accel/hvf/trace-events | 7 +++++++ 4 files changed, 16 insertions(+) create mode 100644 accel/hvf/trace.h create mode 100644 accel/hvf/trace-events diff --git a/meson.build b/meson.build index 34729c2a3dd..5004678a26b 100644 --- a/meson.build +++ b/meson.build @@ -3633,6 +3633,7 @@ if have_block endif if have_system trace_events_subdirs +=3D [ + 'accel/hvf', 'accel/kvm', 'audio', 'backends', diff --git a/accel/hvf/trace.h b/accel/hvf/trace.h new file mode 100644 index 00000000000..83a1883343a --- /dev/null +++ b/accel/hvf/trace.h @@ -0,0 +1,2 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ +#include "trace/trace-accel_hvf.h" diff --git a/accel/hvf/hvf-accel-ops.c b/accel/hvf/hvf-accel-ops.c index d60446b85b8..b38977207d2 100644 --- a/accel/hvf/hvf-accel-ops.c +++ b/accel/hvf/hvf-accel-ops.c @@ -59,6 +59,7 @@ #include "system/hvf_int.h" #include "system/runstate.h" #include "qemu/guest-random.h" +#include "trace.h" =20 HVFState *hvf_state; =20 @@ -97,6 +98,7 @@ static int do_hvf_set_memory(hvf_slot *slot, hv_memory_fl= ags_t flags) if (macslot->present) { if (macslot->size !=3D slot->size) { macslot->present =3D 0; + trace_hvf_vm_unmap(macslot->gpa_start, macslot->size); ret =3D hv_vm_unmap(macslot->gpa_start, macslot->size); assert_hvf_ok(ret); } @@ -109,6 +111,10 @@ static int do_hvf_set_memory(hvf_slot *slot, hv_memory= _flags_t flags) macslot->present =3D 1; macslot->gpa_start =3D slot->start; macslot->size =3D slot->size; + trace_hvf_vm_map(slot->start, slot->size, slot->mem, flags, + flags & HV_MEMORY_READ ? 'R' : '-', + flags & HV_MEMORY_WRITE ? 'W' : '-', + flags & HV_MEMORY_EXEC ? 'E' : '-'); ret =3D hv_vm_map(slot->mem, slot->start, slot->size, flags); assert_hvf_ok(ret); return 0; diff --git a/accel/hvf/trace-events b/accel/hvf/trace-events new file mode 100644 index 00000000000..2fd3e127c74 --- /dev/null +++ b/accel/hvf/trace-events @@ -0,0 +1,7 @@ +# SPDX-License-Identifier: GPL-2.0-or-later +# +# See docs/devel/tracing.rst for syntax documentation. + +# hvf-accel-ops.c +hvf_vm_map(uint64_t paddr, uint64_t size, void *vaddr, uint8_t flags, cons= t char r, const char w, const char e) "paddr:0x%016"PRIx64" size:0x%08"PRIx= 64" vaddr:%p flags:0x%02x/%c%c%c" +hvf_vm_unmap(uint64_t paddr, uint64_t size) "paddr:0x%016"PRIx64" size:0x%= 08"PRIx64 --=20 2.49.0 From nobody Sat Nov 15 14:11:25 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1750425308; cv=none; d=zohomail.com; s=zohoarc; b=Lyr5gVpyO4NxLDBnSub3GATvxF3MIc3mQpiezSr/7rthsXa0vILQZweg8zUSDMvZuZn5Qll+I0wlCnG0gSppdk0bEKAkeMVb4/BcCW8U3+7/BJBTT34Gi3JCMBB9lCqsglNZpzdJVJec165EOUZsT9kqI/vSjvJn6wTcxnQyZZU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1750425308; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=qyHQEfn6inWyZRMUVI/8b1HegzN318xDx/IKxFDD3c0=; b=Yu/pslp6r+9DSbg0rZWIRsDgCmCyRSjP8jJa0WoPt/XLwGu7p/R5ulJy9rQs2dygkb97s8aPsqCF01fn/dC+r3mH45qczdRwc/Vj1tfClpVPAhx5eEE7oqy0mDVl+js/T5rcuY82XsXrf5TXBAfJEY/dKKgHxlLgXADk2H4nOg8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1750425308446711.263167729817; Fri, 20 Jun 2025 06:15:08 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uSbTO-0002Za-Dj; Fri, 20 Jun 2025 09:08:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uSbTM-0002YG-NE for qemu-devel@nongnu.org; Fri, 20 Jun 2025 09:08:00 -0400 Received: from mail-wm1-x329.google.com ([2a00:1450:4864:20::329]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uSbTK-0004a6-VG for qemu-devel@nongnu.org; Fri, 20 Jun 2025 09:08:00 -0400 Received: by mail-wm1-x329.google.com with SMTP id 5b1f17b1804b1-4530921461aso15623115e9.0 for ; Fri, 20 Jun 2025 06:07:58 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4535eac8c16sm58396345e9.19.2025.06.20.06.07.55 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 20 Jun 2025 06:07:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1750424877; x=1751029677; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=qyHQEfn6inWyZRMUVI/8b1HegzN318xDx/IKxFDD3c0=; b=reQtFOxdZrO2AIStYH0aWZCh1TJOcskhZPBWMnOLhfty/lUoEGlSwigAXToc8ngw3m Om+nC8u4eYjH3EdQgeobe9f9c4GgbVciBKI5F1N03KTiAjBHF6Pj+LK+ZVctmA6/uUkH wl6A7jeKqxCHWZ2E0+8n8dC/ERX9oaMemhOCjg2ZMIe/UlVA/v7QbKzakPqVuq1xC6QH u1C+0/W9LB2ABHtrR2gxSu/CC0M7xsPLkt2mrQ6OsojSJprjXOIBCgoH66egUFiyBuWN zMUGlxFXWsnB3opCewYOqF09jFWT+mfId1QbSQY5kME5miwhSHfiztXpMpeLmwMjyZu3 ysDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750424877; x=1751029677; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qyHQEfn6inWyZRMUVI/8b1HegzN318xDx/IKxFDD3c0=; b=RiJlgFHbTrDllqkADWwcxzQObj/Jhu+bQICJ/GXtQyZYN/S/edqKtEmc0nUiucwm2C OffNHonNBH9fLp7tJ8I6qYKnPOxgjJ+Z9ynmLMYNDrKsMlPeGZ6r4MZqLCTm+hziSveW M1WV0MkcWLDlm2WxB4TaDb08oiklMXYA+mVaEPPZiT+KZSDC+KVq+spUM64xMOQQ9nYu sGNvBtLsVCoDk9CzY2IK2HHCjx0+JsOFYdt2/KRCFPg6FVaZ0kz0ZKOfI8aXvGbUwjTh 9/utX61JbK5Ncl/2vO//N6bqrdbU8YNbTRKX3lbleqnXbVbq0WccgS9soJ+8wprVCwHw nAXQ== X-Gm-Message-State: AOJu0YyK0q44wgzTqzH9ph5uyagGwca8yJBxIBcuO2q/417fefz3Sqr4 t4NimUHLDPsOhCJaOTnG5MDMvPkCaKXUWOJYocF0SS6YWqEcpzuU7xwaGsqKQVKAdaPapUBJbWR AgLpRCZI= X-Gm-Gg: ASbGncuHP3BCbOeG6/Sa2UN/4OMJPlAnJpqeR9G6+y+mAnoiIFk5zKJyqc5F0gyMgS7 UUyf44RTGJou3PqqVdipXTvmkG/f31KbJmPDFqcE9T1te7N6FpOtah+pn9uxrMJQ1pymUCO9qvN 6RlQIa4vD0BhFdY1hM/fTrL/6LE9LLSpNJeRXjFRMoi6vr0GXLcQV+enjZ8Wwr9AS7H9bvSHJG5 dcljXaM+lHc2SyKV0tSwTLmtF0VPTGYW3VvY6/LFENFqIrecbQ66vRsP9mu7aELpzNpvg7b12Oz 42XGDzoCqH/XdHD26Y+6PsGXKKSRtbQgR4nshbT/6xgJy0TMq078t5PSqP17YErzG+Op6Z3eZIR TMoVjM2701PV7+WG+xgjRa93Gzu6FpNqQ1pJ9 X-Google-Smtp-Source: AGHT+IGkXs40WMIJKGNMuEiJnfxX7/z7m/pHzk9ne+NytzMGvZpK0RzUyqBP8SLCEpCnawa9dPBjrg== X-Received: by 2002:a05:600c:3b14:b0:43d:2313:7b49 with SMTP id 5b1f17b1804b1-4536539c469mr27259205e9.12.1750424876897; Fri, 20 Jun 2025 06:07:56 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Leif Lindholm , Richard Henderson , Radoslaw Biernacki , Alexander Graf , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Paolo Bonzini , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Phil Dennis-Jordan , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Bernhard Beschow , Cleber Rosa , Peter Maydell , Cameron Esfahani , kvm@vger.kernel.org, qemu-arm@nongnu.org, Eric Auger , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Thomas Huth , Roman Bolshakov , John Snow Subject: [PATCH v2 08/26] target/arm/hvf: Log $pc in hvf_unknown_hvc() trace event Date: Fri, 20 Jun 2025 15:06:51 +0200 Message-ID: <20250620130709.31073-9-philmd@linaro.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250620130709.31073-1-philmd@linaro.org> References: <20250620130709.31073-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::329; envelope-from=philmd@linaro.org; helo=mail-wm1-x329.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1750425310777116600 Tracing $PC for unknown HVC instructions to not have to look at the disassembled flow of instructions. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- target/arm/hvf/hvf.c | 4 ++-- target/arm/hvf/trace-events | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/target/arm/hvf/hvf.c b/target/arm/hvf/hvf.c index cc5bbc155d2..d4c58516e8b 100644 --- a/target/arm/hvf/hvf.c +++ b/target/arm/hvf/hvf.c @@ -2071,12 +2071,12 @@ int hvf_vcpu_exec(CPUState *cpu) cpu_synchronize_state(cpu); if (arm_cpu->psci_conduit =3D=3D QEMU_PSCI_CONDUIT_HVC) { if (!hvf_handle_psci_call(cpu)) { - trace_hvf_unknown_hvc(env->xregs[0]); + trace_hvf_unknown_hvc(env->pc, env->xregs[0]); /* SMCCC 1.3 section 5.2 says every unknown SMCCC call ret= urns -1 */ env->xregs[0] =3D -1; } } else { - trace_hvf_unknown_hvc(env->xregs[0]); + trace_hvf_unknown_hvc(env->pc, env->xregs[0]); hvf_raise_exception(cpu, EXCP_UDEF, syn_uncategorized()); } break; diff --git a/target/arm/hvf/trace-events b/target/arm/hvf/trace-events index a4870e0a5c4..b49746f28d1 100644 --- a/target/arm/hvf/trace-events +++ b/target/arm/hvf/trace-events @@ -5,10 +5,10 @@ hvf_inject_irq(void) "injecting IRQ" hvf_data_abort(uint64_t pc, uint64_t va, uint64_t pa, bool isv, bool iswri= te, bool s1ptw, uint32_t len, uint32_t srt) "data abort: [pc=3D0x%"PRIx64" = va=3D0x%016"PRIx64" pa=3D0x%016"PRIx64" isv=3D%d iswrite=3D%d s1ptw=3D%d le= n=3D%d srt=3D%d]" hvf_sysreg_read(uint32_t reg, uint32_t op0, uint32_t op1, uint32_t crn, ui= nt32_t crm, uint32_t op2, uint64_t val) "sysreg read 0x%08x (op0=3D%d op1= =3D%d crn=3D%d crm=3D%d op2=3D%d) =3D 0x%016"PRIx64 hvf_sysreg_write(uint32_t reg, uint32_t op0, uint32_t op1, uint32_t crn, u= int32_t crm, uint32_t op2, uint64_t val) "sysreg write 0x%08x (op0=3D%d op1= =3D%d crn=3D%d crm=3D%d op2=3D%d, val=3D0x%016"PRIx64")" -hvf_unknown_hvc(uint64_t x0) "unknown HVC! 0x%016"PRIx64 +hvf_unknown_hvc(uint64_t pc, uint64_t x0) "pc=3D0x%"PRIx64" unknown HVC! 0= x%016"PRIx64 hvf_unknown_smc(uint64_t x0) "unknown SMC! 0x%016"PRIx64 hvf_exit(uint64_t syndrome, uint32_t ec, uint64_t pc) "exit: 0x%"PRIx64" [= ec=3D0x%x pc=3D0x%"PRIx64"]" -hvf_psci_call(uint64_t x0, uint64_t x1, uint64_t x2, uint64_t x3, uint32_t= cpuid) "PSCI Call x0=3D0x%016"PRIx64" x1=3D0x%016"PRIx64" x2=3D0x%016"PRIx= 64" x3=3D0x%016"PRIx64" cpu=3D0x%x" +hvf_psci_call(uint64_t x0, uint64_t x1, uint64_t x2, uint64_t x3, uint32_t= cpuid) "PSCI Call x0=3D0x%016"PRIx64" x1=3D0x%016"PRIx64" x2=3D0x%016"PRIx= 64" x3=3D0x%016"PRIx64" cpuid=3D0x%x" hvf_vgic_write(const char *name, uint64_t val) "vgic write to %s [val=3D0x= %016"PRIx64"]" hvf_vgic_read(const char *name, uint64_t val) "vgic read from %s [val=3D0x= %016"PRIx64"]" hvf_illegal_guest_state(void) "HV_ILLEGAL_GUEST_STATE" --=20 2.49.0 From nobody Sat Nov 15 14:11:25 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1750425230; cv=none; d=zohomail.com; s=zohoarc; b=TOD446Z+vOi4mp+2SdyvchWerXVuizoPSjMiad/Q6ZMD+lltYoAf5UXodWgGG4Mw+v6eIrMCgZtI5yShKanMJToGdmn/qqSNOpPvHZ/uRfNHMOzBt3aGZ4qv5rCP6gO1h3+ojo2uZXZBu/dkfUol2iY2gBYv26QJa3tir+gqvUE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1750425230; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=DHkUxhiwznLnPGQ7CmoJiivDkUiQkmNfBetsY13UZBg=; b=VrUiQwIRhgRqLiZ2UaXsPfuJj2UCXrzgD5OretXnw31hl0Mp9B/YhfpvuV4OSZX68S1OzLgU15Nouq+0keD9e41FbEa07x1a3OHyR7RUwOjQGRScFsCvEO1t5VukEpOWU8bccHfRMjNKJi6il9OrEzvVyVm7KsVfDrzR0X48+wQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1750425230295875.6065635534585; Fri, 20 Jun 2025 06:13:50 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uSbTU-0002nK-Ge; Fri, 20 Jun 2025 09:08:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uSbTS-0002id-C9 for qemu-devel@nongnu.org; Fri, 20 Jun 2025 09:08:06 -0400 Received: from mail-wm1-x32d.google.com ([2a00:1450:4864:20::32d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uSbTQ-0004bK-6G for qemu-devel@nongnu.org; Fri, 20 Jun 2025 09:08:06 -0400 Received: by mail-wm1-x32d.google.com with SMTP id 5b1f17b1804b1-442e9c00bf4so15034255e9.3 for ; Fri, 20 Jun 2025 06:08:03 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4535e98b66asm57984935e9.17.2025.06.20.06.08.00 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 20 Jun 2025 06:08:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1750424882; x=1751029682; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=DHkUxhiwznLnPGQ7CmoJiivDkUiQkmNfBetsY13UZBg=; b=mzU5OT7wO27hiwOCswg96hP1vq46euSOASpTsIMB5hASXGmQJExy9ebNWCYAHU3rUg IwagJOjAE2HukMuWgBfh0TIf/KT0QjQBVNJY5ZDicQFC/kBL60TJQR13Kj1roE5AjKcY heuWOBFLz6L8L0dkJHF+8GAMqAgvJcpRSCpSFpYaeHPZJmwa947fq+I+oH0NdTQCWNC+ ZDrYAQvmnD2bE2AqXnqGqbu3viwzpQw+KfHY3dz1wiaIte5KWKoYwVu9rY6NWVe7uBud p41Rb/cuKvo7A/cYbPdRLsGUWZdUkMnppclajLHwEFqM0y7uSH2iJSzCw/5shN/85Ml7 dFMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750424882; x=1751029682; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DHkUxhiwznLnPGQ7CmoJiivDkUiQkmNfBetsY13UZBg=; b=l1Mchcu1U+IoQeDRLR9EYlwfrNU9GE+OKgu/3TrIgpr3CyX+clVZ+bSHySceql2YUA C95BiNmfiMAqHdazcdh5kazChiL0l35PTWqahM00NozBGWfLsV/5XZzB+5YTuCSIcmg8 CXNi6MGTO9Cdjh6RuOcwk/bnIPClaMV470033ev6LefocIcJ1DH6BwIYwXT5M9Nlcl3d B9LOPBqHh4ZKaqGCdb6HLOlNUwfcBAZAeNtwr2rs3jAqfg0FuPY5isz0tUU+xMANGMJk PNy0Ru+XHUo91Q8Ma/BXV+04xMAkAzSbL0Lfy44DMQLig61keHSKxkqT6eDNLYQz5pcU HzfQ== X-Gm-Message-State: AOJu0YzwvsNIj5OzKKcRUigv/uARlETdJ36d0MCvrfdyMBCkvSQWgsAp dBslSGQvg2RYEN8QCzL8eeRaJmv2JaZZhWY86CdrVBqNXDGyTSBXf3StDNFa3CZdCZEwb9yY8mK kcjlMad4= X-Gm-Gg: ASbGncuP6d8nCkLJetZt7sc10gXOOLb1cbLtRRe1ZNfpvDLvoCcClMCkv3QTFaH5nl6 FzDutaCpLcMrQ5xVCDrjpZnBKRvw/Kh0gsqDbZ10/5mac9DPUDLF8zjHNXiZOovKY/eUuotRz7T e6bbhJz4KaBbhSHLqOE+7KF6nZ4MHeV6GsyzacP2RqJ7PwjYjpHHPSayrIR/nu7FBn0bvru+vAx YhJLelwZQsjGJCGEchq0CuVrtm7/2SnVfx0MDH4E/R85lFNzxWgVWBb3To/8VIAR5hk5jAjJ1uN cvclif4qPVR1/A1H60O6piSGRl3sy2b5XMN5o0GEOhVVgkF5FIt3q+C2q4FF8706J5zcWjNirJ5 tOGkRxhpRRAyXIK52FPK19XayZImuTDGWNkFw X-Google-Smtp-Source: AGHT+IFIRA+QgEzXaz5Kv5aRlxYuLkZKTx/pYgPZDxWBgIRvFsRGsi3xvxXp90rTSlKsbLeeXas7Hg== X-Received: by 2002:a05:600c:3acf:b0:440:6a37:be0d with SMTP id 5b1f17b1804b1-453655c3d4fmr28644125e9.15.1750424882015; Fri, 20 Jun 2025 06:08:02 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Leif Lindholm , Richard Henderson , Radoslaw Biernacki , Alexander Graf , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Paolo Bonzini , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Phil Dennis-Jordan , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Bernhard Beschow , Cleber Rosa , Peter Maydell , Cameron Esfahani , kvm@vger.kernel.org, qemu-arm@nongnu.org, Eric Auger , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Thomas Huth , Roman Bolshakov , John Snow Subject: [PATCH v2 09/26] target/arm: Correct KVM & HVF dtb_compatible value Date: Fri, 20 Jun 2025 15:06:52 +0200 Message-ID: <20250620130709.31073-10-philmd@linaro.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250620130709.31073-1-philmd@linaro.org> References: <20250620130709.31073-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32d; envelope-from=philmd@linaro.org; helo=mail-wm1-x32d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1750425232072116600 Linux kernel knows how to parse "arm,armv8", not "arm,arm-v8". See arch/arm64/boot/dts/foundation-v8.dts: https://github.com/torvalds/linux/commit/90556ca1ebdd Fixes: 26861c7ce06 ("target-arm: Add minimal KVM AArch64 support") Fixes: 585df85efea ("hvf: arm: Implement -cpu host") Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- target/arm/hvf/hvf.c | 2 +- target/arm/kvm.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/target/arm/hvf/hvf.c b/target/arm/hvf/hvf.c index d4c58516e8b..bf59b17dcb9 100644 --- a/target/arm/hvf/hvf.c +++ b/target/arm/hvf/hvf.c @@ -879,7 +879,7 @@ static bool hvf_arm_get_host_cpu_features(ARMHostCPUFea= tures *ahcf) hv_vcpu_exit_t *exit; int i; =20 - ahcf->dtb_compatible =3D "arm,arm-v8"; + ahcf->dtb_compatible =3D "arm,armv8"; ahcf->features =3D (1ULL << ARM_FEATURE_V8) | (1ULL << ARM_FEATURE_NEON) | (1ULL << ARM_FEATURE_AARCH64) | diff --git a/target/arm/kvm.c b/target/arm/kvm.c index 74fda8b8090..9a1b031556a 100644 --- a/target/arm/kvm.c +++ b/target/arm/kvm.c @@ -266,7 +266,7 @@ static bool kvm_arm_get_host_cpu_features(ARMHostCPUFea= tures *ahcf) } =20 ahcf->target =3D init.target; - ahcf->dtb_compatible =3D "arm,arm-v8"; + ahcf->dtb_compatible =3D "arm,armv8"; =20 err =3D read_sys_reg64(fdarray[2], &ahcf->isar.id_aa64pfr0, ARM64_SYS_REG(3, 0, 0, 4, 0)); --=20 2.49.0 From nobody Sat Nov 15 14:11:25 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1750425055; cv=none; d=zohomail.com; s=zohoarc; b=dV4rgrTPRZ+ws8s4dt3v8hSxcmIJ6q8VCkYf8cTTo2NYpXESXvFJHIkDX1uJmpvy8yWr77XR3HP8UhfnriDIJBc0ZleHPmWi2SmIZeda9ea4LDphsJUQcML7p0IeLjwtnQ/TOfUY6kFClCegdJ1FcSvtJ+PoG9J/KaA1ZYYEK88= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1750425055; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=gcjg3QhSmhnYtUxzgWM8ifLgGs9HqCTQt/fl8y8J7b4=; b=IkvFF5xkSU6A2yh+PGQLAq3D4szqQUaH5Dmqb86XuL7UUma7/YLFd7zzEhshud1gXcYgW0tLpuO1b4yD+KeeDVLjrlr7JfH2pfaGDBWBxZ//D+b+oUi3A4KGU6tgPAafjMxMJeKzun1kBbAi8/YOF4IcIxjeGAcgNQvaK9yEQCM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1750425055102639.1447658047107; Fri, 20 Jun 2025 06:10:55 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uSbTa-0002yZ-QF; Fri, 20 Jun 2025 09:08:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uSbTZ-0002xR-7D for qemu-devel@nongnu.org; Fri, 20 Jun 2025 09:08:13 -0400 Received: from mail-wr1-x436.google.com ([2a00:1450:4864:20::436]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uSbTW-0004cd-SS for qemu-devel@nongnu.org; Fri, 20 Jun 2025 09:08:12 -0400 Received: by mail-wr1-x436.google.com with SMTP id ffacd0b85a97d-3a53359dea5so1049733f8f.0 for ; Fri, 20 Jun 2025 06:08:10 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a6d1190d13sm2038186f8f.90.2025.06.20.06.08.06 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 20 Jun 2025 06:08:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1750424889; x=1751029689; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=gcjg3QhSmhnYtUxzgWM8ifLgGs9HqCTQt/fl8y8J7b4=; b=vWtHo9KFZk/tIqs0kCMqBjUliF2RrXyVUpFYG4ue5VBob3BPMMuvBjrcmAdfiZPVdx Q4P7UjKdD+lPju0mCfNyjIw6MPi31x0kLhcgIfYAY2maj+MtB5Q8RwfjRrDYnCJoMtxy MN+gZQ8QlSSMS38dSb7D8BpdPBNkhS8mR+9C9bxR5O/w/hu/YkEqaOV491RuB5r3qAr/ AZdsro4yGKcxoxPXB+Lj8OUiDHg0XI9X9mvCzQojO/+Pu2JlGCG//t9K534y5pPUnsJ0 7FSPwdyMDsWHEgsBnkovMyZ6A1mZq5UPt8KMKeeEn29Bb7csmtguFakgxV8mfBGB/opw WLvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750424889; x=1751029689; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gcjg3QhSmhnYtUxzgWM8ifLgGs9HqCTQt/fl8y8J7b4=; b=YvvdGpNPULQoU7NUSXvhZmPzo7L4DXYUBpJUob3z6DtR5Xg/GaWSxDVTJ79zkOfTSm EjF2n22TvntG4Mpj/fBIJS1ddL16WzHaZwx9MuCt4taGZofGHgReWrLUaEMZhHjkQIBO NUJ/IU1vYC0C1K4jesS9711GQXt5qInY+cIrJr1o2k4+CsRHSuWDyy9nTq9jKoHMf2K9 DKpZ0juuXgoVo+FfG7t1XhK6EaQaJiCFTGecYjO7v54G7qbZDKEkapaWgheaxGItcLvU 12jBMuqdnv5vzEpRCaVr8C0KxhuUBLz8vSk0A1/aQk/AtSjo9h8ri52Uwwd0IvRKT+57 jANw== X-Gm-Message-State: AOJu0YzTVmVDfmdf8iJbKrvA4wXEA7867t3jKgUtaRwoX6Ucp7mdpVBt BecNq1IryvHI/XiDH9ESikdDElZXu6iFTrYlq6tV4uoFHjGpWpQ2WSFrmirBV30dF/9jPF7dqjg 6+ldcMGU= X-Gm-Gg: ASbGncsppd1Rii7vK7Zt7dP6X8hwUC8VOo0H+npZVKnDDNxRWvXqbxCZQHIYwhe5dLE ZzHTYurdFfYMRhnVgcaQt5XVDGwDtiM5xkwFb0COG8zD+1Ljm2BL1lkCm+O0G1gOCHQ44V+3yLC kNWg0tTBhKUqFyo8gDB0+50IlUWqcZRbkeeO+nzeTxmJYjIGNlzPrLAMyws6dQaWZvd/Yp/WFVl ApI8+9CXeJJI5ZzlcN9jRLRwFuEunTaCM1trkGKkYwJmS1MSi4BAgcwO/DOKmaCqASelGKtPUpD blhSXNuDmKIUMy4mBNN+Z7Aq152nAFK6gAiz0YeNmbUSybWq9khRxZnHZRBgCNr+6rlo/2EokPQ tz35nbTVQVn8L7J/A1zodszRjb2UXVM3JUO5J X-Google-Smtp-Source: AGHT+IGlMawwPYBTI6F+HQ5fZwO6wtFZQ3ofGqTbh9NR6Oep2MJV2fe7y9qs/PunxZNaedQy8sLILg== X-Received: by 2002:a05:6000:1a8e:b0:3a4:f6ba:51da with SMTP id ffacd0b85a97d-3a6d12db6d0mr2328685f8f.15.1750424888138; Fri, 20 Jun 2025 06:08:08 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Leif Lindholm , Richard Henderson , Radoslaw Biernacki , Alexander Graf , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Paolo Bonzini , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Phil Dennis-Jordan , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Bernhard Beschow , Cleber Rosa , Peter Maydell , Cameron Esfahani , kvm@vger.kernel.org, qemu-arm@nongnu.org, Eric Auger , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Thomas Huth , Roman Bolshakov , John Snow Subject: [PATCH v2 10/26] accel/hvf: Model PhysTimer register Date: Fri, 20 Jun 2025 15:06:53 +0200 Message-ID: <20250620130709.31073-11-philmd@linaro.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250620130709.31073-1-philmd@linaro.org> References: <20250620130709.31073-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::436; envelope-from=philmd@linaro.org; helo=mail-wr1-x436.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1750425055608116600 Emulate PhysTimer dispatching to TCG, like we do with GIC registers. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- target/arm/hvf/hvf.c | 19 ++++++++----------- 1 file changed, 8 insertions(+), 11 deletions(-) diff --git a/target/arm/hvf/hvf.c b/target/arm/hvf/hvf.c index bf59b17dcb9..5169bf6e23c 100644 --- a/target/arm/hvf/hvf.c +++ b/target/arm/hvf/hvf.c @@ -187,6 +187,7 @@ void hvf_arm_init_debug(void) #define SYSREG_OSDLR_EL1 SYSREG(2, 0, 1, 3, 4) #define SYSREG_CNTPCT_EL0 SYSREG(3, 3, 14, 0, 1) #define SYSREG_CNTP_CTL_EL0 SYSREG(3, 3, 14, 2, 1) +#define SYSREG_CNTP_CVAL_EL0 SYSREG(3, 3, 14, 2, 2) #define SYSREG_PMCR_EL0 SYSREG(3, 3, 9, 12, 0) #define SYSREG_PMUSERENR_EL0 SYSREG(3, 3, 9, 14, 0) #define SYSREG_PMCNTENSET_EL0 SYSREG(3, 3, 9, 12, 1) @@ -198,6 +199,7 @@ void hvf_arm_init_debug(void) #define SYSREG_PMCEID0_EL0 SYSREG(3, 3, 9, 12, 6) #define SYSREG_PMCEID1_EL0 SYSREG(3, 3, 9, 12, 7) #define SYSREG_PMCCNTR_EL0 SYSREG(3, 3, 9, 13, 0) +#define SYSREG_CNTP_TVAL_EL0 SYSREG(3, 3, 14, 2, 0) #define SYSREG_PMCCFILTR_EL0 SYSREG(3, 3, 14, 15, 7) =20 #define SYSREG_ICC_AP0R0_EL1 SYSREG(3, 0, 12, 8, 4) @@ -1326,16 +1328,15 @@ static int hvf_sysreg_read(CPUState *cpu, uint32_t = reg, uint64_t *val) } =20 switch (reg) { - case SYSREG_CNTPCT_EL0: - *val =3D qemu_clock_get_ns(QEMU_CLOCK_VIRTUAL) / - gt_cntfrq_period_ns(arm_cpu); - return 0; case SYSREG_OSLSR_EL1: *val =3D env->cp15.oslsr_el1; return 0; case SYSREG_OSDLR_EL1: /* Dummy register */ return 0; + case SYSREG_CNTP_CTL_EL0: + case SYSREG_CNTP_TVAL_EL0: + case SYSREG_CNTPCT_EL0: case SYSREG_ICC_AP0R0_EL1: case SYSREG_ICC_AP0R1_EL1: case SYSREG_ICC_AP0R2_EL1: @@ -1639,16 +1640,12 @@ static int hvf_sysreg_write(CPUState *cpu, uint32_t= reg, uint64_t val) case SYSREG_OSLAR_EL1: env->cp15.oslsr_el1 =3D val & 1; return 0; - case SYSREG_CNTP_CTL_EL0: - /* - * Guests should not rely on the physical counter, but macOS emits - * disable writes to it. Let it do so, but ignore the requests. - */ - qemu_log_mask(LOG_UNIMP, "Unsupported write to CNTP_CTL_EL0\n"); - return 0; case SYSREG_OSDLR_EL1: /* Dummy register */ return 0; + case SYSREG_CNTP_CTL_EL0: + case SYSREG_CNTP_CVAL_EL0: + case SYSREG_CNTP_TVAL_EL0: case SYSREG_ICC_AP0R0_EL1: case SYSREG_ICC_AP0R1_EL1: case SYSREG_ICC_AP0R2_EL1: --=20 2.49.0 From nobody Sat Nov 15 14:11:25 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1750425078; cv=none; d=zohomail.com; s=zohoarc; b=Rtxa5Ubc2KkI4KxwU+pzGCWvLLu6ud4EbOIFxP2RDIlNHOhmsf46/iPMckc+8blz3+BiCQ+IIQwLpJ4kb37JlmWhGofF1XIfbN/L0TCyQll6jgUcLcivSw9xbUGcb9wyasmLWpeyICz7PLSkURkISlAlbzj5aJiz/oSFsc2OQPE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1750425078; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=fZYVTt5RemOQGhErk/wxiT1GRcR8x45vVeqGw/eKctk=; b=D3ksiiqFM2pmQMEgupQ3UBi7P1kbO/YjAETgzPRrStg9WuVNhFRmTo8jj1oJmaSJm/eFqe6y+r37FNTBzaISkibVb1O/2EGwOZVpoWoTVkHKGfW6inpY1bz4zbdR3OUrAj8ILFp1k3YuVDmBuZV54PjcFPrqf5kXU6jXVZRgRsc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1750425078553951.7327722856697; Fri, 20 Jun 2025 06:11:18 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uSbTk-00038Y-3E; Fri, 20 Jun 2025 09:08:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uSbTi-00037m-2X for qemu-devel@nongnu.org; Fri, 20 Jun 2025 09:08:22 -0400 Received: from mail-wm1-x331.google.com ([2a00:1450:4864:20::331]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uSbTc-0004dY-PW for qemu-devel@nongnu.org; Fri, 20 Jun 2025 09:08:21 -0400 Received: by mail-wm1-x331.google.com with SMTP id 5b1f17b1804b1-450cf214200so17544345e9.1 for ; Fri, 20 Jun 2025 06:08:16 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a6d117c663sm2084326f8f.64.2025.06.20.06.08.13 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 20 Jun 2025 06:08:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1750424895; x=1751029695; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=fZYVTt5RemOQGhErk/wxiT1GRcR8x45vVeqGw/eKctk=; b=NwF6LY1gkY0jTrfmu8pocegTrmHtCD0rHvvz7dh65JpW0BOgmBQE44lv5wvOZn5NMO pPb1cN1/x/G7j4GgCyVgvpuY7xZn1A3aG2+oRoAGU96rbJTa9VAm+Fr7YwYl//cdrmjR 2Cx1eMzjaWP7nx+laOt1teHHXqCIwdKG1F6d4DYLwnc2UdPwBSof9k9Q+lYqgKQIhx0z TuD5ayVUvjfRgGRR6T0UVDYpK36pqNTZmpbdsGE4hT+R/p+V28H2URxRzz0VDUwaoYdB aJ0rfbr+AnLtGoVwL+z8+B0xrFpp3lV1FpVrMW/zeqqmht2ewodUukDpYWfq4oHkFLHT 7tFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750424895; x=1751029695; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fZYVTt5RemOQGhErk/wxiT1GRcR8x45vVeqGw/eKctk=; b=lc5PzNdlbLUexF0iuSnC0ycHUQk10Vp5lIdf9WGZiLRck0Dbv46DxnK9DBxtAgPAC1 YRZf9fB+7T3W0smpULLrbdZ1Hk6BxEh49Lwi6FwBUnV8yYVxZyuuZhp5ybVSh6o8kRTt ZjPjXHC4SfH2XvLwMW1uB5//JJq7kRRU3H+0BU2fTHQBFfek8Mll8ugEgO7rE5pERxGc dsQRsbA/9uIr7pfmzpFhLczuffUSOFfd/csuw+aSiEzjFgXlCIURFuQ0Z7c4XH4X0Pa7 0MfflqhzI+0kaBXVHJKQ5Z3JsYtEaKiJnmt6IihtCI4nNt0lBE8Hd2676+GD0s+c/DYT X/UQ== X-Gm-Message-State: AOJu0YwjxZeli3BeVQiYWtPiR/8djR0HEkA010TE7xyRY6JQ7w/XLUiE z9aAEMgFKlzvgreaA4NkQGBQJHlLh5pRTguvui/uPLq2c1xu232BVTVbF9DoW1nyQa4Df1BfGJ4 pRnvOR14= X-Gm-Gg: ASbGncsvPzyoOSVCm0MyMPAQq0K7BvsgJ7ceanr5OizPBZjgtHyma47gNsvdk2m708H bdnYqW8bQdj0FWTX/WIw0ibvu3Co1UysEFOAPdNy328PcvsDfFjE1qMicjgR66SMcxQRBvtEvHo fot1YrGYKH6DSRMqGPao6kV3H0RHpoQkUhUtM9xN+eutE+4cIKHxE3x+F69F+dVCtkByq6Edld1 ww3EArRo9mjrUvgm/ZRpQ+7Gi0dshioHOHjVM5KF+3EXwrkG5zgwFCGuylbP9v2nSvVIhY4zDVc gsDGE/H21phR/gVuFzERHEvPscuTPaEqBhKNX4bpSFQPnmipQ4EsoeuhO8MYSCBNfsl3bq9eWgA HWF+6+Sdn0oJlvbEQgxUQ49ZMMWDDJxzelsYt4Bt2i6SjBgc= X-Google-Smtp-Source: AGHT+IFVLdhGyOe5Gwiz0JlxZs0z4PUuLavXcnnSLq49twNgh52Q6RjdjYzWXSk1EhN5FYPARRZVKg== X-Received: by 2002:a05:600c:1f94:b0:439:9424:1b70 with SMTP id 5b1f17b1804b1-45365a05192mr27153005e9.30.1750424894423; Fri, 20 Jun 2025 06:08:14 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Leif Lindholm , Richard Henderson , Radoslaw Biernacki , Alexander Graf , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Paolo Bonzini , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Phil Dennis-Jordan , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Bernhard Beschow , Cleber Rosa , Peter Maydell , Cameron Esfahani , kvm@vger.kernel.org, qemu-arm@nongnu.org, Eric Auger , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Thomas Huth , Roman Bolshakov , John Snow Subject: [PATCH v2 11/26] target/arm/hvf: Pass @target_el argument to hvf_raise_exception() Date: Fri, 20 Jun 2025 15:06:54 +0200 Message-ID: <20250620130709.31073-12-philmd@linaro.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250620130709.31073-1-philmd@linaro.org> References: <20250620130709.31073-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::331; envelope-from=philmd@linaro.org; helo=mail-wm1-x331.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1750425080154116600 In preparation of raising exceptions at EL2, add the 'target_el' argument to hvf_raise_exception(). Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- target/arm/hvf/hvf.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/target/arm/hvf/hvf.c b/target/arm/hvf/hvf.c index 5169bf6e23c..b932134a833 100644 --- a/target/arm/hvf/hvf.c +++ b/target/arm/hvf/hvf.c @@ -1089,13 +1089,13 @@ void hvf_kick_vcpu_thread(CPUState *cpu) } =20 static void hvf_raise_exception(CPUState *cpu, uint32_t excp, - uint32_t syndrome) + uint32_t syndrome, int target_el) { ARMCPU *arm_cpu =3D ARM_CPU(cpu); CPUARMState *env =3D &arm_cpu->env; =20 cpu->exception_index =3D excp; - env->exception.target_el =3D 1; + env->exception.target_el =3D target_el; env->exception.syndrome =3D syndrome; =20 arm_cpu_do_interrupt(cpu); @@ -1454,7 +1454,7 @@ static int hvf_sysreg_read(CPUState *cpu, uint32_t re= g, uint64_t *val) SYSREG_CRN(reg), SYSREG_CRM(reg), SYSREG_OP2(reg)); - hvf_raise_exception(cpu, EXCP_UDEF, syn_uncategorized()); + hvf_raise_exception(cpu, EXCP_UDEF, syn_uncategorized(), 1); return 1; } =20 @@ -1760,7 +1760,7 @@ static int hvf_sysreg_write(CPUState *cpu, uint32_t r= eg, uint64_t val) SYSREG_CRN(reg), SYSREG_CRM(reg), SYSREG_OP2(reg)); - hvf_raise_exception(cpu, EXCP_UDEF, syn_uncategorized()); + hvf_raise_exception(cpu, EXCP_UDEF, syn_uncategorized(), 1); return 1; } =20 @@ -1963,7 +1963,7 @@ int hvf_vcpu_exec(CPUState *cpu) if (!hvf_find_sw_breakpoint(cpu, env->pc)) { /* Re-inject into the guest */ ret =3D 0; - hvf_raise_exception(cpu, EXCP_BKPT, syn_aa64_bkpt(0)); + hvf_raise_exception(cpu, EXCP_BKPT, syn_aa64_bkpt(0), 1); } break; } @@ -2074,7 +2074,7 @@ int hvf_vcpu_exec(CPUState *cpu) } } else { trace_hvf_unknown_hvc(env->pc, env->xregs[0]); - hvf_raise_exception(cpu, EXCP_UDEF, syn_uncategorized()); + hvf_raise_exception(cpu, EXCP_UDEF, syn_uncategorized(), 1); } break; case EC_AA64_SMC: @@ -2089,7 +2089,7 @@ int hvf_vcpu_exec(CPUState *cpu) } } else { trace_hvf_unknown_smc(env->xregs[0]); - hvf_raise_exception(cpu, EXCP_UDEF, syn_uncategorized()); + hvf_raise_exception(cpu, EXCP_UDEF, syn_uncategorized(), 1); } break; default: --=20 2.49.0 From nobody Sat Nov 15 14:11:25 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1750425100; cv=none; d=zohomail.com; s=zohoarc; b=dh7sKdTA1TT2Lv03O34oVufN3rl55UIeF+dr2kVqxRREMZlEC7KO73OIkMdwXQfT1ZQ2GRaNXkMXiTPzqc3zUI1n2rLbPNorryYQ6CYFGPVEDVjVWBWLeE1knOJ8eh3wHplo2W9vzIO9kBeE0js4zKbjspXro91GNmecG0FuZpY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1750425100; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=oAt1PQLrHnO21M2Y87z2Ba1KRbOWR+1s+ZX+rYgrLRA=; b=O8QG4GBDGKKu7zURqrMLp/0h/XOr2dAr6roAmJTewGE3o/TxEwPmJgyC7t4NxblAqPHkiNvrUmsASHBOPODEkEEd0e64e6DqGWmRfnAUlSOuAK+wRwYGVjn8qXVjSZokMEMMVtSvFFLZLkFklZpNH3ko13rpYUmG1nXovJR+7DU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1750425100869589.3896795355945; Fri, 20 Jun 2025 06:11:40 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uSbTn-00039R-M6; Fri, 20 Jun 2025 09:08:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uSbTl-000390-SA for qemu-devel@nongnu.org; Fri, 20 Jun 2025 09:08:25 -0400 Received: from mail-wm1-x32c.google.com ([2a00:1450:4864:20::32c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uSbTj-0004fH-Mf for qemu-devel@nongnu.org; Fri, 20 Jun 2025 09:08:25 -0400 Received: by mail-wm1-x32c.google.com with SMTP id 5b1f17b1804b1-45310223677so15215415e9.0 for ; Fri, 20 Jun 2025 06:08:23 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-453646cb57fsm25578125e9.1.2025.06.20.06.08.18 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 20 Jun 2025 06:08:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1750424902; x=1751029702; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=oAt1PQLrHnO21M2Y87z2Ba1KRbOWR+1s+ZX+rYgrLRA=; b=T+wTcnvzlfqB1H/TlIvqDpxFOwy7x+JdNO8nqiDxTJarKLSYsOIqFLRcbIahgsjUNL 8ffItHZWkF/q6v912+ttjweTr9DPfPeRvniolpAqUPFkwhhZNIy5GwCC95CgTamEMK0c oMCumrLM6W9Ywu+hKVFKZ6qLr+bhq7O5jjH1O805RPfpBWZYh2ru1UbhZifnvKgUcjUm X8yTmHok2CA4uWzemUZx7OaE7KfGy+L6RKmO50ClrbfYPwNE7rG4jXZEcecjBTbyX80l qrOt7p7H4VeqFxy9Hv38MHNZdWkcpeXPd5VyDtBQxr5AmqtIrS17XopDGNE8Yt6bpb06 tgwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750424902; x=1751029702; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=oAt1PQLrHnO21M2Y87z2Ba1KRbOWR+1s+ZX+rYgrLRA=; b=RoMMpMRHWTeR8K3bWxflByvjckLEbs7CLsjm7fvvc2WcxcRG8/ehz9ag5RpxRbb2Bk 5Ue/nBxY9cpG2u/VhYldTWbXY4b6JB27ooHge6h8QQAbCzInO5YftaKPfOfRWx47upcF joHZLUqti+xDiwz5CANlgEfLsfwqRmNpDCZh6aCeiH9NtHKwPBnYfW9ZZ6UU/j/VGsZ7 /FhBmOBh8Fgpt4CF8TLZlZ3pdV8cwflU7VyyTo4CdUJsOjWpvHMA8pLWkjOP1bKYRmkO cwXouF/Kf20tZCIQ4hE7QT+tIGCdR622ll9bWNL4yt1UTKdehzFCsCGawRw8s6idhcNh aCZg== X-Gm-Message-State: AOJu0Yx2Ody9auNlrKH76A5dS8iY4p+CXVXuh4V56kHlSidCis6h7Rqz 1BF3INcflG0xx+okK4h0j5dTykRP32m+IPTih0k0RHTM/wr0I+cMJswELfpav9Te9eLLBKCujD7 BseozSpk= X-Gm-Gg: ASbGncv7PmMOEm2EXsJqX7yENl8YvUwOlm53Xb3ZB0OsSsenEg5dkbUCmF8Dyeae6ur b4vkmVQnq8aiMb/3MywhtmZUg3r0ja/JGpBWqZ65AwQ7+d1mMcYsB2aD480urxJZ2iwcRIl6d7g 4ZIQGtDkt/MYlcZNEcJFwpPeqIsqBza96dtYzz444zkmjwKqYy/RqCgBobesCmbwMM2/yiqJyO+ QdHp/SGKEqr/b9ZBdZ2Ttg1DxtXY8be9vctbqo79Lgyf6IEm8LRFYnnyGcwi9CKS18Fup+E6t2O QSuVNCXjifzLJRHZEbQgLS8AvwJxt4YyhQ0/236ME5VPZrsAdN3gLH0HnnRkuwp49QvhiuNeJsK NzdVV5YgDXp0FDEcqEAFGNEwjEZUoo2ZWVtKQ X-Google-Smtp-Source: AGHT+IEGmchw+a0k0hX0S9KobjryclE57uq2sgKFzkmMvuxn/d4B/I66wfS6mkzaJen5FMifqGqbXw== X-Received: by 2002:a05:600c:37c5:b0:453:5c30:a1d0 with SMTP id 5b1f17b1804b1-453659dcd62mr23896155e9.21.1750424899969; Fri, 20 Jun 2025 06:08:19 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Leif Lindholm , Richard Henderson , Radoslaw Biernacki , Alexander Graf , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Paolo Bonzini , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Phil Dennis-Jordan , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Bernhard Beschow , Cleber Rosa , Peter Maydell , Cameron Esfahani , kvm@vger.kernel.org, qemu-arm@nongnu.org, Eric Auger , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Thomas Huth , Roman Bolshakov , John Snow Subject: [PATCH v2 12/26] target/arm: Restrict system register properties to system binary Date: Fri, 20 Jun 2025 15:06:55 +0200 Message-ID: <20250620130709.31073-13-philmd@linaro.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250620130709.31073-1-philmd@linaro.org> References: <20250620130709.31073-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32c; envelope-from=philmd@linaro.org; helo=mail-wm1-x32c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1750425102467116600 Do not expose the following system-specific properties on user-mode binaries: - psci-conduit - cntfrq (ARM_FEATURE_GENERIC_TIMER) - rvbar (ARM_FEATURE_V8) - has-mpu (ARM_FEATURE_PMSA) - pmsav7-dregion (ARM_FEATURE_PMSA) - reset-cbar (ARM_FEATURE_CBAR) - reset-hivecs (ARM_FEATURE_M) - init-nsvtor (ARM_FEATURE_M) - init-svtor (ARM_FEATURE_M_SECURITY) - idau (ARM_FEATURE_M_SECURITY) Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- target/arm/cpu.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/target/arm/cpu.c b/target/arm/cpu.c index eb0639de719..e5b70f5de81 100644 --- a/target/arm/cpu.c +++ b/target/arm/cpu.c @@ -1500,6 +1500,7 @@ static void arm_cpu_initfn(Object *obj) * 0 means "unset, use the default value". That default might vary dependi= ng * on the CPU type, and is set in the realize fn. */ +#ifndef CONFIG_USER_ONLY static const Property arm_cpu_gt_cntfrq_property =3D DEFINE_PROP_UINT64("cntfrq", ARMCPU, gt_cntfrq_hz, 0); =20 @@ -1509,7 +1510,6 @@ static const Property arm_cpu_reset_cbar_property =3D static const Property arm_cpu_reset_hivecs_property =3D DEFINE_PROP_BOOL("reset-hivecs", ARMCPU, reset_hivecs, false); =20 -#ifndef CONFIG_USER_ONLY static const Property arm_cpu_has_el2_property =3D DEFINE_PROP_BOOL("has_el2", ARMCPU, has_el2, true); =20 @@ -1532,6 +1532,7 @@ static const Property arm_cpu_has_neon_property =3D static const Property arm_cpu_has_dsp_property =3D DEFINE_PROP_BOOL("dsp", ARMCPU, has_dsp, true); =20 +#ifndef CONFIG_USER_ONLY static const Property arm_cpu_has_mpu_property =3D DEFINE_PROP_BOOL("has-mpu", ARMCPU, has_mpu, true); =20 @@ -1544,6 +1545,7 @@ static const Property arm_cpu_pmsav7_dregion_property= =3D DEFINE_PROP_UNSIGNED_NODEFAULT("pmsav7-dregion", ARMCPU, pmsav7_dregion, qdev_prop_uint32, uint32_t); +#endif =20 static bool arm_get_pmu(Object *obj, Error **errp) { @@ -1731,6 +1733,7 @@ static void arm_cpu_post_init(Object *obj) "Set on/off to enable/disable aarc= h64 " "execution state "); } +#ifndef CONFIG_USER_ONLY if (arm_feature(&cpu->env, ARM_FEATURE_CBAR) || arm_feature(&cpu->env, ARM_FEATURE_CBAR_RO)) { qdev_property_add_static(DEVICE(obj), &arm_cpu_reset_cbar_property= ); @@ -1746,7 +1749,6 @@ static void arm_cpu_post_init(Object *obj) OBJ_PROP_FLAG_READWRITE); } =20 -#ifndef CONFIG_USER_ONLY if (arm_feature(&cpu->env, ARM_FEATURE_EL3)) { /* Add the has_el3 state CPU property only if EL3 is allowed. Thi= s will * prevent "has_el3" from existing on CPUs which cannot support EL= 3. @@ -1818,6 +1820,7 @@ static void arm_cpu_post_init(Object *obj) qdev_property_add_static(DEVICE(obj), &arm_cpu_has_dsp_property); } =20 +#ifndef CONFIG_USER_ONLY if (arm_feature(&cpu->env, ARM_FEATURE_PMSA)) { qdev_property_add_static(DEVICE(obj), &arm_cpu_has_mpu_property); if (arm_feature(&cpu->env, ARM_FEATURE_V7)) { @@ -1854,8 +1857,6 @@ static void arm_cpu_post_init(Object *obj) &cpu->psci_conduit, OBJ_PROP_FLAG_READWRITE); =20 - qdev_property_add_static(DEVICE(obj), &arm_cpu_cfgend_property); - if (arm_feature(&cpu->env, ARM_FEATURE_GENERIC_TIMER)) { qdev_property_add_static(DEVICE(cpu), &arm_cpu_gt_cntfrq_property); } @@ -1864,7 +1865,6 @@ static void arm_cpu_post_init(Object *obj) kvm_arm_add_vcpu_properties(cpu); } =20 -#ifndef CONFIG_USER_ONLY if (arm_feature(&cpu->env, ARM_FEATURE_AARCH64) && cpu_isar_feature(aa64_mte, cpu)) { object_property_add_link(obj, "tag-memory", @@ -1882,6 +1882,7 @@ static void arm_cpu_post_init(Object *obj) } } #endif + qdev_property_add_static(DEVICE(obj), &arm_cpu_cfgend_property); } =20 static void arm_cpu_finalizefn(Object *obj) --=20 2.49.0 From nobody Sat Nov 15 14:11:25 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1750424918; cv=none; d=zohomail.com; s=zohoarc; b=SaE9jwREZrjPCIo6NsVybUmsZFZFa57Inc/Hd6owXhSy1sQ6xhd1gZK6GbZKxv92uxPKWNM6NW9wQ6MFQiwFpJHYkLhA+QmMxUMJECFJQIapxe5V8j0BbICwWGqQyoH506BBkaDkD2jHAWpKI1me6I+iXU/wzDEcgISWn10SZTc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1750424918; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=qbJkhz3jwM/7an+ncj+kPtqJZzlzC4z2AtmZHXah0xc=; b=R1OKptf5FKAmSo5tXhAoWvQjCmDijPfXtu7vxgnhe1WF44ai1yFNLTZUFIOkXtOZhc7sWmeILPNYD2wW6X3bX8LaijSZ8V8zgALstc7vGP+6Fga06Zrm5OzOAH/zqjL4Al2Tl8n0L7TeomlAEN2iVfuSMe4uq1/KDHuPa3LMu/0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1750424918905769.8567789177317; Fri, 20 Jun 2025 06:08:38 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uSbTt-0003MK-AN; Fri, 20 Jun 2025 09:08:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uSbTq-0003C6-ES for qemu-devel@nongnu.org; Fri, 20 Jun 2025 09:08:30 -0400 Received: from mail-wm1-x335.google.com ([2a00:1450:4864:20::335]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uSbTo-0004gb-5k for qemu-devel@nongnu.org; Fri, 20 Jun 2025 09:08:29 -0400 Received: by mail-wm1-x335.google.com with SMTP id 5b1f17b1804b1-441ab63a415so19981815e9.3 for ; Fri, 20 Jun 2025 06:08:27 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4535eac8c41sm59776775e9.26.2025.06.20.06.08.24 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 20 Jun 2025 06:08:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1750424906; x=1751029706; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=qbJkhz3jwM/7an+ncj+kPtqJZzlzC4z2AtmZHXah0xc=; b=kz6nDLQxL7cOQ/4L1Q0iJKSGTsA+wCKVxr9WcTmC79JB9xUddiDuD27mNahfyyHsO1 dl7Nkxnfpw7/hr5srkE2S+S6EPAI6QbNw7c48FzUDCGq2T4bNwZxbsEbqr4IZNZKF/PL h5GsOLExufkJkLu8c9iqIFQYgwy2xMeb21FvvQOvWV96I8OjrPmyvrzfXqYGY59e7TBo 670lYv9ehCxuF9GQS72K+zvfSLtxEzHd+K86Ao7/xBriw+0yz+vSbZ5q4w8Wisd6Rp8V PzcK55dAF3T6luDlfrdzmuCtoRY+EPOOT/csBMHLX1TpFfWeIgn/YatTgvkkEsKBhygy zqdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750424906; x=1751029706; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qbJkhz3jwM/7an+ncj+kPtqJZzlzC4z2AtmZHXah0xc=; b=q8X9krGj/qtcXcKaYd57L5+sA5bOc55z4ZJeCUkJN/5Iito7+52N9uYeBm7znoJLEr 4UQxd2NX45Gbm/hGFjZR+2LcLud6EJrvIbvQAigE8hR+8Kh+rEevnp3iAwnAhjo01i8j RcVqtaEZzCdgDo01yZDknuiaWSlCE3q5Hu1sfqXhrYWxGIOIsL4lvCwbUaDW6zYoftOh 8ZX+SCrFpAg2g6ZY32W4cm2lL2c/u4Q1pFLEKlz7XNLeVSFDGpqR7cx/dTvWM9gvqcT9 iJS7lsuTq1SN7VGbZh4Vs9+cLAmn+dmzFyam/lMdjf2S2f4EdwPZAChra3uppGdABJMk YNVw== X-Gm-Message-State: AOJu0YwVra6KFdw6G0pi3M+FAA7E5Ajn/HpQcv62AXfsvXQuOeNSKA8R TeY6nuQGwj7Y3Pr07zqNsZknDOhorK/VH3vZP+mQBc+eyR7s7duzAjkcsqePfyp+4wyCsxhoqow giG4Aa2Y= X-Gm-Gg: ASbGncu5s+OxVXLGBGyo2e1TkDChPVuLRrRr00r5drHthoNe3/FHUREE6jf6CZvYHJW U7lwXyxeJSurTclAHb7zhZeVJ2IfQeWE4PVqBR1WmekNGE1FE6u5gxFDKvGnp1jStfkUU3ff77A tIe6GcKO1r0dXT26SKqN9ZoUFGWww+fPllT0KHf2SEL62hkC8CnWuUvpSghXoIWYL+iq0mFJosR 8IA9eB2oMRPZXaUOHg8dGATE13UcIW231pk2gi1Vg9bd6D1cRClIXZckt4J9NOaEUTyIJ9D0Wk5 nxqVJwh0V2l9t4ivTy1FdX9Je0Z/Au8LRpCpwb6svyQcZLNYuFF/CklUJfLH9YDMcEmjRx8ArEE 8LJOaSDmr2dVOTfO0gIE46g7irOu3dhJ40EGT X-Google-Smtp-Source: AGHT+IEovICPCvjwxdsOFxQYVKyO0QusibpDDvB3y28q9auAAPau9mFOJbflgaPhOt3KoclCZXn79Q== X-Received: by 2002:a05:600c:1d0b:b0:43c:fa24:873e with SMTP id 5b1f17b1804b1-453654cb826mr25614575e9.13.1750424906120; Fri, 20 Jun 2025 06:08:26 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Leif Lindholm , Richard Henderson , Radoslaw Biernacki , Alexander Graf , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Paolo Bonzini , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Phil Dennis-Jordan , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Bernhard Beschow , Cleber Rosa , Peter Maydell , Cameron Esfahani , kvm@vger.kernel.org, qemu-arm@nongnu.org, Eric Auger , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Thomas Huth , Roman Bolshakov , John Snow Subject: [PATCH v2 13/26] target/arm: Create GTimers *after* features finalized / accel realized Date: Fri, 20 Jun 2025 15:06:56 +0200 Message-ID: <20250620130709.31073-14-philmd@linaro.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250620130709.31073-1-philmd@linaro.org> References: <20250620130709.31073-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::335; envelope-from=philmd@linaro.org; helo=mail-wm1-x335.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1750424919896116600 Call generic (including accelerator) cpu_realize() handlers *before* setting @gt_cntfrq_hz default Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- target/arm/cpu.c | 65 ++++++++++++++++++++++++------------------------ 1 file changed, 33 insertions(+), 32 deletions(-) diff --git a/target/arm/cpu.c b/target/arm/cpu.c index e5b70f5de81..ab5fbd9b40b 100644 --- a/target/arm/cpu.c +++ b/target/arm/cpu.c @@ -1985,26 +1985,6 @@ static void arm_cpu_realizefn(DeviceState *dev, Erro= r **errp) return; } =20 - if (!cpu->gt_cntfrq_hz) { - /* - * 0 means "the board didn't set a value, use the default". (We al= so - * get here for the CONFIG_USER_ONLY case.) - * ARMv8.6 and later CPUs architecturally must use a 1GHz timer; b= efore - * that it was an IMPDEF choice, and QEMU initially picked 62.5MHz, - * which gives a 16ns tick period. - * - * We will use the back-compat value: - * - for QEMU CPU types added before we standardized on 1GHz - * - for versioned machine types with a version of 9.0 or earlier - */ - if (arm_feature(env, ARM_FEATURE_BACKCOMPAT_CNTFRQ) || - cpu->backcompat_cntfrq) { - cpu->gt_cntfrq_hz =3D GTIMER_BACKCOMPAT_HZ; - } else { - cpu->gt_cntfrq_hz =3D GTIMER_DEFAULT_HZ; - } - } - #ifndef CONFIG_USER_ONLY /* The NVIC and M-profile CPU are two halves of a single piece of * hardware; trying to use one without the other is a command line @@ -2051,7 +2031,40 @@ static void arm_cpu_realizefn(DeviceState *dev, Erro= r **errp) return; } } +#endif =20 + cpu_exec_realizefn(cs, &local_err); + if (local_err !=3D NULL) { + error_propagate(errp, local_err); + return; + } + + arm_cpu_finalize_features(cpu, &local_err); + if (local_err !=3D NULL) { + error_propagate(errp, local_err); + return; + } + +#ifndef CONFIG_USER_ONLY + if (!cpu->gt_cntfrq_hz) { + /* + * 0 means "the board didn't set a value, use the default". (We al= so + * get here for the CONFIG_USER_ONLY case.) + * ARMv8.6 and later CPUs architecturally must use a 1GHz timer; b= efore + * that it was an IMPDEF choice, and QEMU initially picked 62.5MHz, + * which gives a 16ns tick period. + * + * We will use the back-compat value: + * - for QEMU CPU types added before we standardized on 1GHz + * - for versioned machine types with a version of 9.0 or earlier + */ + if (arm_feature(env, ARM_FEATURE_BACKCOMPAT_CNTFRQ) || + cpu->backcompat_cntfrq) { + cpu->gt_cntfrq_hz =3D GTIMER_BACKCOMPAT_HZ; + } else { + cpu->gt_cntfrq_hz =3D GTIMER_DEFAULT_HZ; + } + } { uint64_t scale =3D gt_cntfrq_period_ns(cpu); =20 @@ -2072,18 +2085,6 @@ static void arm_cpu_realizefn(DeviceState *dev, Erro= r **errp) } #endif =20 - cpu_exec_realizefn(cs, &local_err); - if (local_err !=3D NULL) { - error_propagate(errp, local_err); - return; - } - - arm_cpu_finalize_features(cpu, &local_err); - if (local_err !=3D NULL) { - error_propagate(errp, local_err); - return; - } - #ifdef CONFIG_USER_ONLY /* * User mode relies on IC IVAU instructions to catch modification of --=20 2.49.0 From nobody Sat Nov 15 14:11:25 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1750424960; cv=none; d=zohomail.com; s=zohoarc; b=KHuf9c9vTynQ6lUzNomo8OPBz99wgCy6fw/X2e2Eg67TJr8/EDNGbQeww+rKOzEpPT/yu9OSylNac7j83EkaTJJN1wqAB94NyiWTP/jNF31PFY2lykDC55vlYuc/LPQVbTmMtNIs/qtzopDZT7y4f1rLN72OUOhlv7QzAmFuDyI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1750424960; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=FOQFF5IHVggEpZxvhH4Dg2y5NDppFE2+idPk4kXeUTw=; b=IZlLTpZEbuTpbcLShGXXT/6BHO1xlucLCBkZ6qt8Unitjef4xX9IfyBZKtYT1LtdZPKYytYpmHWJ0YJ5MVI81glUDEcoNe6yxT8bT0HsgDBKSKEsVwiZEh+pdssRosr73t6/KmQ1yVyvvDYW1m/mxHzDAbLsatLXdG0mtsbDOt8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1750424960181131.31352956265505; Fri, 20 Jun 2025 06:09:20 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uSbUB-0003r9-CP; Fri, 20 Jun 2025 09:08:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uSbTu-0003PY-Tr for qemu-devel@nongnu.org; Fri, 20 Jun 2025 09:08:35 -0400 Received: from mail-wm1-x32d.google.com ([2a00:1450:4864:20::32d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uSbTt-0004i6-2D for qemu-devel@nongnu.org; Fri, 20 Jun 2025 09:08:34 -0400 Received: by mail-wm1-x32d.google.com with SMTP id 5b1f17b1804b1-43edecbfb94so19353935e9.1 for ; Fri, 20 Jun 2025 06:08:32 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a6d117c0f1sm2083859f8f.53.2025.06.20.06.08.29 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 20 Jun 2025 06:08:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1750424911; x=1751029711; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=FOQFF5IHVggEpZxvhH4Dg2y5NDppFE2+idPk4kXeUTw=; b=HD547D2cRSJR1yXZHA5T5BCfRD26PLgmRY5qpw36Wxl38LYMgTTAXPCv0HAC1FLP/b 8s8Ws+LUcsPfQP9Eg/Uy62YvMmPnUEUAz1pvxtqXK2bRBleMwjh/mD874YBTMdtUrhRn zXPy/qRzM1ZC1F0odVHi4nwktiw+k6M+0XKLu7xv0thP9WLRXwdTfjIr/jGHS6THnxzp AbajDcGAfLkHfdcxZJ8GAiy+sONvRoYv6IspDikP4U5oN1vE4yudwVHgvamYPgCggGqH vthjkqR9zPN1x81UoIzQmLrrgLBJDLl0nCqz898weZlQKVNscm7EiXsuIT4OKzWrztdZ 2EUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750424911; x=1751029711; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FOQFF5IHVggEpZxvhH4Dg2y5NDppFE2+idPk4kXeUTw=; b=l9GmcyrCKsx8aRhOi2a7SFiIWhakLy9CRzibWPLVOM2QPGycfk8bnq17f83opwvEiK vzJVhPdAbTlIHV2/T4RktvJx8vGLkeNlcTGVS8Rk5Odc34TVTD14lyEYpNfZvnAXV9Rv TrU23o1AxokgbbN4+EG+UDECbBsWWLYg9fxUAZw/9SWrEI6cwHZb4bGbvjvXzImhXLa5 jJOhT/FckQBDz2vQoZjBnYhsx2D5IErUQFwvR3FCK8ECNdS1AltTcIzj8YNglMsHDNqd qKFLd5vU4d9Tw9TCA7FnAjuMvuV9sJ8N0HsP4KlcY6nVARPG3OnpBhSuWq1igOIDHcAm 1TRg== X-Gm-Message-State: AOJu0Yxf4x/MnlB8xBKMdxXDH4J7c6c+5Nnf1G71UQSSWScsE2AM1W0F OoUvzZwFkFHReM/Dn27589nbFjH2aLyMd9F4DckQ5SVQre0AmuMvp0JFzKyMSXHaBNLnsi79yXz FFwJI1ao= X-Gm-Gg: ASbGncv2bTSY6+Ghmn8oF+DeNwb2BKYsxJqDiVQPxRPpZL61pcIxzkI0Tep6ISarzX0 Ub+gtBBAKP+9MiJtsYm7F8DLNM0/bdF1M7q8jBPf/KDuncciAZYlbC16ZRa5Qm28Vg7oKZIN2JM y9P80UtBVXJuvKA6f90fUmfipa4smhUFB2YFNbmaka9sCe3RCaBG9ruS5f5uFsS6tX6xmDrgiAW aW9NhFR5ZCeBm8D9Bft4llYGYmbu0wo6yQXXArSd/1hGZvCD6nwRiL87XeaRlwYfQKkPn/q8VpB E0nci1jlLC1qwwj5jFNczfJqdNk+RD/HkiZARB+hkUYeGHFHA2DdQGcsJL97ZWTrIIuEcik/e4p zqn+R6GwPq3m8lYI77HhYv0KJo3gxUCMvlcF8 X-Google-Smtp-Source: AGHT+IG5VJ2wmm6aaoN33zTA0rvHD7SHc9CVgH1xuOcv58TCSdw7oIYTR3igTV8EZ3sVBVJ+FyYcCw== X-Received: by 2002:a05:6000:98f:b0:3a5:24a9:a5d3 with SMTP id ffacd0b85a97d-3a6d12a41ebmr2293268f8f.17.1750424911290; Fri, 20 Jun 2025 06:08:31 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Leif Lindholm , Richard Henderson , Radoslaw Biernacki , Alexander Graf , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Paolo Bonzini , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Phil Dennis-Jordan , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Bernhard Beschow , Cleber Rosa , Peter Maydell , Cameron Esfahani , kvm@vger.kernel.org, qemu-arm@nongnu.org, Eric Auger , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Thomas Huth , Roman Bolshakov , John Snow Subject: [PATCH v2 14/26] accel: Keep reference to AccelOpsClass in AccelClass Date: Fri, 20 Jun 2025 15:06:57 +0200 Message-ID: <20250620130709.31073-15-philmd@linaro.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250620130709.31073-1-philmd@linaro.org> References: <20250620130709.31073-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32d; envelope-from=philmd@linaro.org; helo=mail-wm1-x32d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1750424962449116600 Allow dereferencing AccelOpsClass outside of accel/accel-system.c. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson Reviewed-by: Alex Benn=C3=A9e --- include/qemu/accel.h | 3 +++ include/system/accel-ops.h | 3 ++- accel/accel-common.c | 1 + accel/accel-system.c | 3 ++- accel/tcg/tcg-accel-ops.c | 4 +++- 5 files changed, 11 insertions(+), 3 deletions(-) diff --git a/include/qemu/accel.h b/include/qemu/accel.h index fbd3d897fef..9dea3145429 100644 --- a/include/qemu/accel.h +++ b/include/qemu/accel.h @@ -37,6 +37,9 @@ typedef struct AccelClass { /*< public >*/ =20 const char *name; + /* Cached by accel_init_ops_interfaces() when created */ + AccelOpsClass *ops; + int (*init_machine)(MachineState *ms); bool (*cpu_common_realize)(CPUState *cpu, Error **errp); void (*cpu_common_unrealize)(CPUState *cpu); diff --git a/include/system/accel-ops.h b/include/system/accel-ops.h index 4c99d25aeff..44b37592d02 100644 --- a/include/system/accel-ops.h +++ b/include/system/accel-ops.h @@ -10,6 +10,7 @@ #ifndef ACCEL_OPS_H #define ACCEL_OPS_H =20 +#include "qemu/accel.h" #include "exec/vaddr.h" #include "qom/object.h" =20 @@ -31,7 +32,7 @@ struct AccelOpsClass { /*< public >*/ =20 /* initialization function called when accel is chosen */ - void (*ops_init)(AccelOpsClass *ops); + void (*ops_init)(AccelClass *ac); =20 bool (*cpus_are_resettable)(void); void (*cpu_reset_hold)(CPUState *cpu); diff --git a/accel/accel-common.c b/accel/accel-common.c index 4894b98d64a..56d88940f92 100644 --- a/accel/accel-common.c +++ b/accel/accel-common.c @@ -10,6 +10,7 @@ #include "qemu/osdep.h" #include "qemu/accel.h" #include "qemu/target-info.h" +#include "system/accel-ops.h" #include "accel/accel-cpu.h" #include "accel-internal.h" =20 diff --git a/accel/accel-system.c b/accel/accel-system.c index a0f562ae9ff..64bc991b1ce 100644 --- a/accel/accel-system.c +++ b/accel/accel-system.c @@ -85,8 +85,9 @@ void accel_init_ops_interfaces(AccelClass *ac) * non-NULL create_vcpu_thread operation. */ ops =3D ACCEL_OPS_CLASS(oc); + ac->ops =3D ops; if (ops->ops_init) { - ops->ops_init(ops); + ops->ops_init(ac); } cpus_register_accel(ops); } diff --git a/accel/tcg/tcg-accel-ops.c b/accel/tcg/tcg-accel-ops.c index b24d6a75625..da2e22a7dff 100644 --- a/accel/tcg/tcg-accel-ops.c +++ b/accel/tcg/tcg-accel-ops.c @@ -198,8 +198,10 @@ static inline void tcg_remove_all_breakpoints(CPUState= *cpu) cpu_watchpoint_remove_all(cpu, BP_GDB); } =20 -static void tcg_accel_ops_init(AccelOpsClass *ops) +static void tcg_accel_ops_init(AccelClass *ac) { + AccelOpsClass *ops =3D ac->ops; + if (qemu_tcg_mttcg_enabled()) { ops->create_vcpu_thread =3D mttcg_start_vcpu_thread; ops->kick_vcpu_thread =3D mttcg_kick_vcpu_thread; --=20 2.49.0 From nobody Sat Nov 15 14:11:25 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1750425252; cv=none; d=zohomail.com; s=zohoarc; b=ZhENN6fjRikVudZ2w6aYTac9ajZXUu5q9xMBaYN012QOhJPFWz/FHm0rB3fIabehl8+GIcn8FB2llrXJGgMnVvtGf8l8KjF1VblqcIex5a5oKv7b43mhCyaEbQ2R7niG8WSboRZthakLWaYCpri0Gplju9QgdtOvrjPt939PumY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1750425252; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=Fteu42QoSrS1hfDvjcW70gOANYEhePCaBpCVcvmvL2M=; b=GTjxLrrkhxOxW/OMhjW563PpnYPR2juxRn/0rPH9MDlME6/JxV1r6o4G02CZ8g4liN8fZ4IsiVIf8/QHRGYX+BEetxIVbAMUxk6ofALCINFjVIlJ9bI+xiz/SgOGejMj9v/gPBPj1J1kXshZmycPXtgs3iavfETY5vCu5FOv79o= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1750425252001377.2139257056011; Fri, 20 Jun 2025 06:14:12 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uSbUD-00045J-Dz; Fri, 20 Jun 2025 09:08:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uSbU0-0003UU-12 for qemu-devel@nongnu.org; Fri, 20 Jun 2025 09:08:43 -0400 Received: from mail-wm1-x329.google.com ([2a00:1450:4864:20::329]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uSbTy-0004jz-5Z for qemu-devel@nongnu.org; Fri, 20 Jun 2025 09:08:39 -0400 Received: by mail-wm1-x329.google.com with SMTP id 5b1f17b1804b1-451ebd3d149so11660895e9.2 for ; Fri, 20 Jun 2025 06:08:37 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a6d11909f4sm2016944f8f.88.2025.06.20.06.08.35 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 20 Jun 2025 06:08:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1750424916; x=1751029716; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Fteu42QoSrS1hfDvjcW70gOANYEhePCaBpCVcvmvL2M=; b=xGM6RSzxkE4aAyTloGQUSOucPNeP9CB5qTNqzcAnoobRa7XqERGLvOyv37fbFdiifm GxzqlemSBI5tVIepRdFz9xUzYKi94nXWis7ZueMYe+OPkBaSsPhMNre2uxaoAcAwsE5F 8sbfIv3967Z0JdnHxSrab2jTBo92xQYvbvzd2nmp/CCwDwCttg8FSWdn9R2t0Kr18Rmx OiP9gFT1qgKiCcXWpP4lh+nVCt3W1VjroJIR0T2coY/52+TDUn2lJM1C9CVrpdLu4CKv 6eGZ/4YkA1B7wNt/aGHM5omIq3P/3nENv5/RmPSfwX4NPBtif1cpiH3rJh6l9A7xq8nC wETA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750424916; x=1751029716; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Fteu42QoSrS1hfDvjcW70gOANYEhePCaBpCVcvmvL2M=; b=J8GD4T6KFyTDxxvKJ+vZStxaw6mfZBkutBr80Acx0jl29noz9PIy78+zfKqAk06Enf qYqNxQ198rUNaeHy6jOmCFKdSrLK+4Zrk4K+1qMjp1hknnpIdvbuZjXmHbCZjVJRwEBL 9ABWrv84kxsVzoze96+V0zTmV0mDlvGXE7xKmpt6wlWpKel4Ho1+EZPyLhG/Qj8RF/sz 8lSRqeWo7nnLi46dU7iJv60p9mNYcoEcqsqOf19+WHBPgqhauhb0oielDwV85siXjFxM JZc64hGfPf58+xdKd+biglpOMvpwUuvO7E+2XYupczRckCrMU3QLerwy6LW7LycJn716 s1QA== X-Gm-Message-State: AOJu0YxdGGLB1ZU19/HBxaNsULzFRZh6n87ie0MYivIomiYYvciKRDl0 s/KhE6ZuQ70jk7ENMUd5AaxuizRjIkKnEaoxMEl1XxH8wjzDgmC3YNKNCDh+GLV3QAtloThmv6N kNLuR7bw= X-Gm-Gg: ASbGncsvdrn8Y4aHxZ0oWwz4dN5TiD3tmb6+V3KX4/8f2/kMHvJFIP+e1+G8HyZ+Dpj pC/UTmCBHcNjA1txaAxSVzzoOdeSKbTRM37jFY5EJsUpgXfRQEo2dLOqpOrP/psigiomnLwwZRA /to0iv8E5WEeHDZ16Z21o/FJXQdnFrwQCFhVk/Wn3kCtvOg/0K3cS3lpP4me1mVlVn6RFJCVH3N 9HPiU1yOlaR+721lCOFZavT/415Na5dvKO2QYuRoxTu1A+QCf0ZhRzwEM/3sp/6sqZvEn9d0sxh xYI03cuBaXr4u14oHhE8qVc7U9g4WUn7GT4ZM1Lq97jhJGklSlYNT3Kxntnb6lQfKbzI3mkiqB1 dZWbJoQRkDsSphfCiSAAK+X+8xX4OD73eDDKW X-Google-Smtp-Source: AGHT+IF+npPw/Fpnff5lnMY4tzVA5zu1lieKqW+klOIEesBk3BkWi62GERyChD7PyAo9RXNQgBmPoQ== X-Received: by 2002:a05:600c:8b70:b0:445:1984:247d with SMTP id 5b1f17b1804b1-453653aa3afmr23498795e9.7.1750424916439; Fri, 20 Jun 2025 06:08:36 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Leif Lindholm , Richard Henderson , Radoslaw Biernacki , Alexander Graf , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Paolo Bonzini , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Phil Dennis-Jordan , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Bernhard Beschow , Cleber Rosa , Peter Maydell , Cameron Esfahani , kvm@vger.kernel.org, qemu-arm@nongnu.org, Eric Auger , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Thomas Huth , Roman Bolshakov , John Snow Subject: [PATCH v2 15/26] accel: Introduce AccelOpsClass::cpu_target_realize() hook Date: Fri, 20 Jun 2025 15:06:58 +0200 Message-ID: <20250620130709.31073-16-philmd@linaro.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250620130709.31073-1-philmd@linaro.org> References: <20250620130709.31073-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::329; envelope-from=philmd@linaro.org; helo=mail-wm1-x329.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1750425256391116600 Allow accelerators to set vCPU properties before its realization. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- include/system/accel-ops.h | 1 + accel/accel-common.c | 3 +++ 2 files changed, 4 insertions(+) diff --git a/include/system/accel-ops.h b/include/system/accel-ops.h index 44b37592d02..a863fe59388 100644 --- a/include/system/accel-ops.h +++ b/include/system/accel-ops.h @@ -35,6 +35,7 @@ struct AccelOpsClass { void (*ops_init)(AccelClass *ac); =20 bool (*cpus_are_resettable)(void); + bool (*cpu_target_realize)(CPUState *cpu, Error **errp); void (*cpu_reset_hold)(CPUState *cpu); =20 void (*create_vcpu_thread)(CPUState *cpu); /* MANDATORY NON-NULL */ diff --git a/accel/accel-common.c b/accel/accel-common.c index 56d88940f92..55d21b63a48 100644 --- a/accel/accel-common.c +++ b/accel/accel-common.c @@ -105,6 +105,9 @@ bool accel_cpu_common_realize(CPUState *cpu, Error **er= rp) if (acc->cpu_common_realize && !acc->cpu_common_realize(cpu, errp)) { return false; } + if (acc->ops->cpu_target_realize && !acc->ops->cpu_target_realize(cpu,= errp)) { + return false; + } =20 return true; } --=20 2.49.0 From nobody Sat Nov 15 14:11:25 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1750425126; cv=none; d=zohomail.com; s=zohoarc; b=a1/3Paex8BUTu9TOGav+A9AXXrV/tXvVUmI88rTA3Ay2Ept6uVH4/z/MmY42GCDOqlvJow8ij6KPFIQUiMSD5zgjHvqZFt9lJW4H+s8IoRgR7TrIRwbOCOHx4aGmLeGql+2i4ky6hysdbbjfN+BYzR2EnAPwcJq6es4bdrbY5bI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1750425126; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=2kLq7ybqs3cS0L36YzYXj0nQxUzd1xncr8lPWgttp7A=; b=nFTNdIbM5NA4kqBaq9GuBP9RQ+cbc7jpprXG41LXxGYPr0JO0Tb+WH3iQhrCnh+C9Aq9WVRSKFhibjzceeQpmKZc3NV97FxyzL089bXsvd/OxfQfe/ZlT5oO+k0K9LRgmfacQsLgxyFIHvHCDlihzuC/kFtbNZU6ARX39pLG5Ds= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1750425126161792.3975330527068; Fri, 20 Jun 2025 06:12:06 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uSbUC-0003xE-Fj; Fri, 20 Jun 2025 09:08:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uSbU7-0003ge-1N for qemu-devel@nongnu.org; Fri, 20 Jun 2025 09:08:49 -0400 Received: from mail-wm1-x333.google.com ([2a00:1450:4864:20::333]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uSbU5-0004lj-5B for qemu-devel@nongnu.org; Fri, 20 Jun 2025 09:08:46 -0400 Received: by mail-wm1-x333.google.com with SMTP id 5b1f17b1804b1-4531e146a24so11631125e9.0 for ; Fri, 20 Jun 2025 06:08:44 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-453646fd74asm24979395e9.22.2025.06.20.06.08.40 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 20 Jun 2025 06:08:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1750424923; x=1751029723; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=2kLq7ybqs3cS0L36YzYXj0nQxUzd1xncr8lPWgttp7A=; b=sioQ8Wo+hXQ8uqQkSVlIg+A/PtxXvSR/AiQvwM8rDdr1tIUTfOFQCLUFbxxbiD9Jd7 QTm4nXkeMZGaWlh5ehzUofAP6lyvHbAJiEP6frN8DcQ5if6fL7gKDvPBH3sa9euTooKT ZH1ygoOntt94sWq3NA75Bv/UZaelaJkXN1GYJg1DYS7q95Gz0/HxpLMdNoBUQfRuJ6iB +shSMyOpJIe9f8dOG2YF6fmxDFuGdwFyGQ6kJz9eY+ugUKcC9HlGNpCDTelUZT0yl7n6 bMv3xZQltF0QVmbYSwj+qcUfOcw+BproBxjUFFcWYTEwXtvJDKEQEbluyuOPCOo9VWF5 QmkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750424923; x=1751029723; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2kLq7ybqs3cS0L36YzYXj0nQxUzd1xncr8lPWgttp7A=; b=rSuZ8PxZG8++TgILIVnbn34FB9d5pqI0lH6Zl9PUipo5+Qhw08BuASkr8LLUsyeBKy RmOGZempo0MyQV6+lSkhsw6gvncX6Wzrlsgc/0SVVRZHWeCaHxIB5gq8KJ+oI57OdOgn bc3oOqxv+ezZIBHT0/mpKtDAMQGx7tO9Go1D6eyYtKaCXu0aqw/HGNJy07le900PuczK eKeu5Zywk9RSEtWMIILQ1ww1P27RiaDgJvLM7Fc/stQr4kaAOfWfmPtjW3Kd4/R9nnte KpTPN6nU8v0KYKRmxh0MMCdSAtdm7pJzwzRAtqYPU29Quj5Jdd6SGMHiA6/VltIB7K0S UZzA== X-Gm-Message-State: AOJu0Yz6KY6hCIkLYhz7INJvfj3A+vNPTJcODmDg2M3aiJuDcmSgpD8l +Slk2N+QIlPL1hYqUtjCTrN07Zzg89H4NSyJXTpwEJFhSFFGMTNDHk9AbJSK8dgOB8wFaBVmMeD 4vp24RdI= X-Gm-Gg: ASbGncsDP6DtU9vw5MmMy5ZpJKV2mpb0zlXe75jbIPES4+/ZWHfFiy87CrYgIR9eJDX +FU2DHTfFagdkT6nzrA+OsAMKawltmJ29+EUWUZy6N6epqLWJG0QraKFA+pT7hUTk9S/uIG9xKu aQGt3nw9PBWVaww8DAT1sETOnOyVCAFEVcLXyd9FXFduC8tcqBn2o0xyzmt+d+HWLqO9FhrwQxW PMXMt02SR0qCZtmwP3/aY86AwgGIdSLpLc8Fz+nuEdvscuM5jrHh1K3DpRu/vWJMZrA+OrF3EAh Oy7gO/ENNM2JPhSLX8joAJQmrSQMwWKVjVHBvN2W940+tSoUkc59kBnmxPWnjpKk62H7u+TuSh2 bYHguLVO3i6uAt9vw8f808ZDcp1ZvXNMm2tzw X-Google-Smtp-Source: AGHT+IHx17Q3o0n4ExJMDEX9nhiRFuD9m/DDwUW/YxBilyeTC3sNUKgmjYDttzl1RvFGqYhxbO7bhQ== X-Received: by 2002:a05:600c:c4ac:b0:442:dc75:5625 with SMTP id 5b1f17b1804b1-453659be428mr24945485e9.5.1750424922099; Fri, 20 Jun 2025 06:08:42 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Leif Lindholm , Richard Henderson , Radoslaw Biernacki , Alexander Graf , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Paolo Bonzini , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Phil Dennis-Jordan , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Bernhard Beschow , Cleber Rosa , Peter Maydell , Cameron Esfahani , kvm@vger.kernel.org, qemu-arm@nongnu.org, Eric Auger , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Thomas Huth , Roman Bolshakov , John Snow Subject: [PATCH v2 16/26] accel/hvf: Add hvf_arch_cpu_realize() stubs Date: Fri, 20 Jun 2025 15:06:59 +0200 Message-ID: <20250620130709.31073-17-philmd@linaro.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250620130709.31073-1-philmd@linaro.org> References: <20250620130709.31073-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::333; envelope-from=philmd@linaro.org; helo=mail-wm1-x333.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1750425126559116600 Implement HVF AccelOpsClass::cpu_target_realize() hook as empty stubs. Target implementations will come separately. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- include/system/hvf.h | 3 +++ accel/hvf/hvf-accel-ops.c | 2 ++ target/arm/hvf/hvf.c | 5 +++++ target/i386/hvf/hvf.c | 5 +++++ 4 files changed, 15 insertions(+) diff --git a/include/system/hvf.h b/include/system/hvf.h index a9a502f0c8f..8c4409a13f1 100644 --- a/include/system/hvf.h +++ b/include/system/hvf.h @@ -72,6 +72,9 @@ void hvf_arch_update_guest_debug(CPUState *cpu); * Return whether the guest supports debugging. */ bool hvf_arch_supports_guest_debug(void); + +bool hvf_arch_cpu_realize(CPUState *cpu, Error **errp); + #endif /* COMPILING_PER_TARGET */ =20 #endif diff --git a/accel/hvf/hvf-accel-ops.c b/accel/hvf/hvf-accel-ops.c index b38977207d2..b9511103a75 100644 --- a/accel/hvf/hvf-accel-ops.c +++ b/accel/hvf/hvf-accel-ops.c @@ -588,6 +588,8 @@ static void hvf_accel_ops_class_init(ObjectClass *oc, c= onst void *data) { AccelOpsClass *ops =3D ACCEL_OPS_CLASS(oc); =20 + ops->cpu_target_realize =3D hvf_arch_cpu_realize; + ops->create_vcpu_thread =3D hvf_start_vcpu_thread; ops->kick_vcpu_thread =3D hvf_kick_vcpu_thread; =20 diff --git a/target/arm/hvf/hvf.c b/target/arm/hvf/hvf.c index b932134a833..fd493f45af1 100644 --- a/target/arm/hvf/hvf.c +++ b/target/arm/hvf/hvf.c @@ -1082,6 +1082,11 @@ int hvf_arch_init_vcpu(CPUState *cpu) return 0; } =20 +bool hvf_arch_cpu_realize(CPUState *cs, Error **errp) +{ + return true; +} + void hvf_kick_vcpu_thread(CPUState *cpu) { cpus_kick_thread(cpu); diff --git a/target/i386/hvf/hvf.c b/target/i386/hvf/hvf.c index 99e37a33e50..28484496710 100644 --- a/target/i386/hvf/hvf.c +++ b/target/i386/hvf/hvf.c @@ -367,6 +367,11 @@ int hvf_arch_init_vcpu(CPUState *cpu) return 0; } =20 +bool hvf_arch_cpu_realize(CPUState *cs, Error **errp) +{ + return true; +} + static void hvf_store_events(CPUState *cpu, uint32_t ins_len, uint64_t idt= vec_info) { X86CPU *x86_cpu =3D X86_CPU(cpu); --=20 2.49.0 From nobody Sat Nov 15 14:11:25 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1750425133; cv=none; d=zohomail.com; s=zohoarc; b=fXRONZx5ti92Rzk6XE7JbEafCYDv3quYRVpuH6C97YhKXUi0+PQjfQEHp3Ev1abdCNZbrrXUpzev6oFyUvVVsWB+7QVG/mPWcuqA+fx5BBJ4Xud86HL/y/Ray33CU1L3iFzNZKJeBozzzqkNlnsdWg8yEpovYmhtUXaZ6igUxfw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1750425133; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=NW0Hu04oFurHIvjEpsNrwT15qBihdHLv3c5t8qKFRhE=; b=O7B4q7VSGvzAWaQ6Ur3qqbVxfNJyqRHPhVcyCPveHXP5m6uX5mqtkCf24LOUhv2XFS2W/6cJv1v25q1PUh7RipcBJ7MA/I8MO1r65P9CyUYzBJOf4mmM/xKr0f3tPBl8baZQP1yIXM3PfC060nLfFirPPkFpGvN62wEtFYfDN/g= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1750425133376418.72657841142905; Fri, 20 Jun 2025 06:12:13 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uSbUG-0004Li-1i; Fri, 20 Jun 2025 09:08:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uSbUB-0003uq-MJ for qemu-devel@nongnu.org; Fri, 20 Jun 2025 09:08:52 -0400 Received: from mail-wm1-x333.google.com ([2a00:1450:4864:20::333]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uSbUA-0004n5-4n for qemu-devel@nongnu.org; Fri, 20 Jun 2025 09:08:51 -0400 Received: by mail-wm1-x333.google.com with SMTP id 5b1f17b1804b1-453398e90e9so13153315e9.1 for ; Fri, 20 Jun 2025 06:08:49 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a6d0f18152sm2006529f8f.27.2025.06.20.06.08.46 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 20 Jun 2025 06:08:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1750424928; x=1751029728; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=NW0Hu04oFurHIvjEpsNrwT15qBihdHLv3c5t8qKFRhE=; b=o89ByaXz+Pps94E89f9dHuZPL5KCt6vEYrxACT9y/kTAahnwfAN4dItaqCrXGYtOzt 1ngW8ahYCs35i0r1XFmybGtgHAwegX5dAeLrLNRLdx7L2B9b+opwWfVoEiWaGIKmvGj+ fe4datHUbRount2Ksf097RX17t/RJycuwGNrMZW9rdcItXTypCGqP+FI0wNZYPE8kIKp lqPNj/d+j3fA2xMEVgyYfm/kc/BM9rNJbpeiBmPtszerieETYhmANW7XDbU9oNPj2681 j0v776IlU7uAfgYBXpbCSqQNYMt+DS67LM6xUiH1f+LvppNxwqByTMWE6q7feUehkAod WyQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750424928; x=1751029728; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NW0Hu04oFurHIvjEpsNrwT15qBihdHLv3c5t8qKFRhE=; b=ItSU1qlUoLDe9jtM66rEeBV8NxQqg3aDEofkfXnFH8iXIng7/m/LCj9PYfaovf5u5X 01myQot6O2dVpWb//O6+9F4yqIH8AVqQSb0T9nMux9BbkhgKLJiWiJREW0/qdzB4S66X /yAKrFZ34x2ErfeVXqFXzTGXuDKTNvQm9Jjhc8xgSpNhXlavgktv5mfvjFqQsxpoWLiA dhj/Tvker+rR7Frt6qDApUzipgyYC3cV1+J7LDP/QWR4QkdhGwwKD8hfkGtRBeBOYRtr OyskeLBFugYy0YXTEXckOZiYBq25W44z4qJiBeq7imxBgCf2NMjSeIrAlJecE9VotLRu nPFg== X-Gm-Message-State: AOJu0Yzu/WZ5R6yXg7f+1PGWMPLt1W+WlYKFgedIBdgEET5uyl/zjrLD p19cUoDqPmAyxTQuRXnoQw3OsG8gT5LeAbRFZIFcN2zNsbBeLqN+ueCSpu7fC1XfYkFLQCGKCuk 0OWbEdFw= X-Gm-Gg: ASbGncuVKjvT6tuMmZ/LrbkApGKezt/qLovZ5K0cER40YEGnj/wsifQmKzR1DBoWfC+ /r0U2u5ewujZMdoJX2TOW/rpXSXwHPRwVOXQRINSX/BEjOVOcp1gIKg7oD3ahTnx3/kxvTDSFaB dzyIap7MNoUr5yMw7ERPURpWSX5gO2C2XcdRzVJEOaaW1Zijp0rAB9mhPW6g0uTYUyCNUx5a2WE mbnCx/x2vlQhCPVCkHZIf4CBVGYwCjd39GBZfrMt1S45TscCyIwF6nSW7aaKxwNteQeoD9jS5e7 Y631Ufaqwbc4lKVUG8PsJY5GzMb9oA4k8aiXwnCb9GE4KUSR529vqfarXJnHAtBxRStq60n1Cs5 NeWG1o9GWFY0vnSM2oCfG1KXTFQAm6QZqaJe9 X-Google-Smtp-Source: AGHT+IGUxGQ9nSF7X2qks3F5L0LQ6lJ+WfpvhuThp4HFmarf7Jsr/FvLwKNQzlPqKQDhSjDBkrHhqg== X-Received: by 2002:a05:600c:1991:b0:444:c28f:e81a with SMTP id 5b1f17b1804b1-453659f5888mr23208755e9.27.1750424928234; Fri, 20 Jun 2025 06:08:48 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Leif Lindholm , Richard Henderson , Radoslaw Biernacki , Alexander Graf , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Paolo Bonzini , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Phil Dennis-Jordan , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Bernhard Beschow , Cleber Rosa , Peter Maydell , Cameron Esfahani , kvm@vger.kernel.org, qemu-arm@nongnu.org, Eric Auger , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Thomas Huth , Roman Bolshakov , John Snow Subject: [PATCH v2 17/26] target/arm/hvf: Really set Generic Timer counter frequency Date: Fri, 20 Jun 2025 15:07:00 +0200 Message-ID: <20250620130709.31073-18-philmd@linaro.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250620130709.31073-1-philmd@linaro.org> References: <20250620130709.31073-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::333; envelope-from=philmd@linaro.org; helo=mail-wm1-x333.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1750425134585116600 Setting ARMCPU::gt_cntfrq_hz in hvf_arch_init_vcpu() is not correct because the timers have already be initialized with the default frequency. Set it earlier in the AccelOpsClass::cpu_target_realize() handler instead, and assert the value is correct when reaching hvf_arch_init_vcpu(). Fixes: a1477da3dde ("hvf: Add Apple Silicon support") Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- target/arm/hvf/hvf.c | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/target/arm/hvf/hvf.c b/target/arm/hvf/hvf.c index fd493f45af1..52199c4ff9d 100644 --- a/target/arm/hvf/hvf.c +++ b/target/arm/hvf/hvf.c @@ -1004,6 +1004,13 @@ cleanup: return ret; } =20 +static uint64_t get_cntfrq_el0(void) +{ + uint64_t freq_hz =3D 0; + asm volatile("mrs %0, cntfrq_el0" : "=3Dr"(freq_hz)); + return freq_hz; +} + int hvf_arch_init_vcpu(CPUState *cpu) { ARMCPU *arm_cpu =3D ARM_CPU(cpu); @@ -1015,7 +1022,9 @@ int hvf_arch_init_vcpu(CPUState *cpu) int i; =20 env->aarch64 =3D true; - asm volatile("mrs %0, cntfrq_el0" : "=3Dr"(arm_cpu->gt_cntfrq_hz)); + + /* system count frequency sanity check */ + assert(arm_cpu->gt_cntfrq_hz =3D=3D get_cntfrq_el0()); =20 /* Allocate enough space for our sysreg sync */ arm_cpu->cpreg_indexes =3D g_renew(uint64_t, arm_cpu->cpreg_indexes, @@ -1084,6 +1093,10 @@ int hvf_arch_init_vcpu(CPUState *cpu) =20 bool hvf_arch_cpu_realize(CPUState *cs, Error **errp) { + ARMCPU *cpu =3D ARM_CPU(cs); + + cpu->gt_cntfrq_hz =3D get_cntfrq_el0(); + return true; } =20 --=20 2.49.0 From nobody Sat Nov 15 14:11:25 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1750425158; cv=none; d=zohomail.com; s=zohoarc; b=IT3JGwZABFj3sXdbtwM9hdKG/FPi+JWdsg7rQT4mYsDtv9cN6iO7UTcV4oit1Pfvmxbt6FJfeEc8Uc+7GBnB6RBAdIb01BmLjdUGA52obmFGm67fSYiSGi2qB8I/0mJQBsUfk+50yLAyaj0OFYR2NkUTolOtz6tR0noDM9AaNns= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1750425158; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=WoXZ8Al0R/es9sXpuEKkELf4IYQr/L/uwmOyRIHiR2c=; b=QolorRDQUZxgNVcoGV/VZPmZvILvjYEPOuR3LZx5Co64hu4kiOd+qXs0dPkTrNnNmOK2SixHdsGqUHTuXloBtZH8Sh5I/6tpXIKiFmeqJpXfGhpT24UH4a8lr4SdoPLns3gnXxKlbMZSsvBj1t4+KRCXT2US3AIC/PzFbVG3euc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 17504251579881004.7586965378855; Fri, 20 Jun 2025 06:12:37 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uSbUK-0004hQ-3W; Fri, 20 Jun 2025 09:09:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uSbUH-0004TP-1L for qemu-devel@nongnu.org; Fri, 20 Jun 2025 09:08:57 -0400 Received: from mail-wm1-x32c.google.com ([2a00:1450:4864:20::32c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uSbUF-0004pi-9g for qemu-devel@nongnu.org; Fri, 20 Jun 2025 09:08:56 -0400 Received: by mail-wm1-x32c.google.com with SMTP id 5b1f17b1804b1-45348bff79fso21167535e9.2 for ; Fri, 20 Jun 2025 06:08:54 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4536470826fsm24688205e9.36.2025.06.20.06.08.52 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 20 Jun 2025 06:08:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1750424933; x=1751029733; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=WoXZ8Al0R/es9sXpuEKkELf4IYQr/L/uwmOyRIHiR2c=; b=VJPAWiUU8ZrAI7HUR7Fh+SH22S5+wfd7ob+3W4tCfr9AIxxOm6vyCudaDtnAd88KaQ s8nuVtaTGV7P58LicYxqpX0cM1BrX4MLuU0p1qkSj3cIPecwS0LE8WUvQSbjwFFSC+uU K0gN+RuEQsAVLOPT0cnyVSFu8wetqnr+Srqge6+oVr9I8PVQCOUXwtgD+5GQkWGgpNEK tLAGLD53njoL0jwGg6gspT0rIsg4j6WjhBQIxoosPdUfb07ptfsgs5TGeu2UCjLBT04H IWh19k+LkiB5bAT1fO4nnSMLcsNgFKMf1FsGnDeCEYiPNsSeOIViXq9sVxf5EbTVPj4l 1q4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750424933; x=1751029733; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WoXZ8Al0R/es9sXpuEKkELf4IYQr/L/uwmOyRIHiR2c=; b=Py/w4cOQ3ZO1zbKxOk7ELqP023okKqhlQFEb3DA0aVwdDyBYNfMJ4kTQnoNboQjrcP aMEOi3PsWF0Grc3wTrKiKJ3C7yvDLEwlIPsgDf6Ot+fOoapt4tFfcxUp2hcGZzZzxikG hzVTlA6pzR+DMc6convCBurnL5XMn1xCflaDjrVAXyJFZ2CJ8GPqP8v6gu1+Dz//LF1s S+tc7pWFuL8R7dlMw0Kq8OjDeOEbfD8CePo/2CVSjDdGgviu8d3uLGQjrBT5+gHADCVj guKTU/DDI+NZlKhjpHrWCAy6rpdj2LbCUHwapkuTDFWO5F4f4PbQsLmNoIE8PzqmrPRk NoEg== X-Gm-Message-State: AOJu0YwA6+4VqOL+R+gT0vx2J/7NLqdNzNRW4rvQEOfM9WcSgzskN/XB cFXiygvpVMonLdH5nU5JDN6lnbceIvaxRx9Glv++nLQNIJv5eo3nFPLBWdzDYA1pP+E8Uz1+0YY u2nW6+Ys= X-Gm-Gg: ASbGnctv9jXZQBqa/Vixu6DiiUIAGPc2wYiWrS/nrEvt9V9Dybqyqw2NDeetwm7We6y /a5oGF875rhW8Ywdt2Ep1+3213/TbWA9HnMMDiql2L0Ugc93x+Cn/1ZDUxfrafLQGnGJsYeC9U+ INsijHlhUoWiG7VhCw/qtvOu4SINmkx+5fsqcXoob1e2gjulRZfRrHAmvrUEypsdWp48TNx9mDM EpuL/LmsLIo35Laofjt4c4+FRLqFPVH6RDL0zp/8JW1aYzdFqxwsR8P6hZPKOcgTQSs/ZK0Do1u YMuQufvQmiuvYkia6dBKfb9wCqa1FDA4UyDijHdANlrWnAoDcTHo2VuBie7HID0omddMxwGjq25 PEL6LvHaVP4suz3z8858WJ+Gj1zeAa3m2va9D X-Google-Smtp-Source: AGHT+IGEOZJZmS9VN7oJFrBpyPnyA04MJAIvpYC6GlxrITVRrfApyBG3DfPjsMvyvrXG11kPH2vwoA== X-Received: by 2002:a05:600c:8b52:b0:441:b19c:96fe with SMTP id 5b1f17b1804b1-453659c05e5mr32757335e9.10.1750424933502; Fri, 20 Jun 2025 06:08:53 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Leif Lindholm , Richard Henderson , Radoslaw Biernacki , Alexander Graf , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Paolo Bonzini , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Phil Dennis-Jordan , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Bernhard Beschow , Cleber Rosa , Peter Maydell , Cameron Esfahani , kvm@vger.kernel.org, qemu-arm@nongnu.org, Eric Auger , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Thomas Huth , Roman Bolshakov , John Snow Subject: [PATCH v2 18/26] target/arm/hvf: Trace host processor features Date: Fri, 20 Jun 2025 15:07:01 +0200 Message-ID: <20250620130709.31073-19-philmd@linaro.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250620130709.31073-1-philmd@linaro.org> References: <20250620130709.31073-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32c; envelope-from=philmd@linaro.org; helo=mail-wm1-x32c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1750425159103116600 Tracing an Apple M1 (Icestorm core, ARMv8.4-A): hvf_processor_feature_register EL0: 1 hvf_processor_feature_register EL1: 1 hvf_processor_feature_register EL2: 0 hvf_processor_feature_register FP: 1 hvf_processor_feature_register AdvSIMD: 1 hvf_processor_feature_register GIC: 0 hvf_processor_feature_register SVE: 0 hvf_processor_feature_register MTE: 0 hvf_processor_feature_register SME: 0 Suggested-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- target/arm/hvf/hvf.c | 43 +++++++++++++++++++++++++++++++++++++ target/arm/hvf/trace-events | 1 + 2 files changed, 44 insertions(+) diff --git a/target/arm/hvf/hvf.c b/target/arm/hvf/hvf.c index 52199c4ff9d..87cd323c14d 100644 --- a/target/arm/hvf/hvf.c +++ b/target/arm/hvf/hvf.c @@ -2160,8 +2160,51 @@ static void hvf_vm_state_change(void *opaque, bool r= unning, RunState state) } } =20 +static void trace_processor_feature_register(void) +{ + hv_return_t ret =3D HV_SUCCESS; + hv_vcpu_exit_t *exit; + hv_vcpu_t fd; + uint64_t pfr; + + if (!trace_event_get_state_backends(TRACE_HVF_PROCESSOR_FEATURE_REGIST= ER)) { + return; + } + + /* We set up a small vcpu to extract host registers */ + ret =3D hv_vcpu_create(&fd, &exit, NULL); + assert_hvf_ok(ret); + + ret =3D hv_vcpu_get_sys_reg(fd, HV_SYS_REG_ID_AA64PFR0_EL1, &pfr); + assert_hvf_ok(ret); + trace_hvf_processor_feature_register("EL0", + FIELD_EX64(pfr, ID_AA64PFR0, EL0)= ); + trace_hvf_processor_feature_register("EL1", + FIELD_EX64(pfr, ID_AA64PFR0, EL1)= ); + trace_hvf_processor_feature_register("EL2", + FIELD_EX64(pfr, ID_AA64PFR0, EL2)= ); + trace_hvf_processor_feature_register("FP", + FIELD_EX64(pfr, ID_AA64PFR0, FP)); + trace_hvf_processor_feature_register("AdvSIMD", FIELD_EX64(pfr, + ID_AA64PFR0, ADVSIMD)); + trace_hvf_processor_feature_register("GIC", FIELD_EX64(pfr, + ID_AA64PFR0, GIC)); + trace_hvf_processor_feature_register("SVE", FIELD_EX64(pfr, + ID_AA64PFR0, SVE)); + + ret =3D hv_vcpu_get_sys_reg(fd, HV_SYS_REG_ID_AA64PFR1_EL1, &pfr); + assert_hvf_ok(ret); + trace_hvf_processor_feature_register("MTE", + FIELD_EX64(pfr, ID_AA64PFR1, MTE)= ); + trace_hvf_processor_feature_register("SME", + FIELD_EX64(pfr, ID_AA64PFR1, SME)= ); + ret =3D hv_vcpu_destroy(fd); + assert_hvf_ok(ret); +} + int hvf_arch_init(void) { + trace_processor_feature_register(); hvf_state->vtimer_offset =3D mach_absolute_time(); vmstate_register(NULL, 0, &vmstate_hvf_vtimer, &vtimer); qemu_add_vm_change_state_handler(hvf_vm_state_change, &vtimer); diff --git a/target/arm/hvf/trace-events b/target/arm/hvf/trace-events index b49746f28d1..7ef75184901 100644 --- a/target/arm/hvf/trace-events +++ b/target/arm/hvf/trace-events @@ -12,3 +12,4 @@ hvf_psci_call(uint64_t x0, uint64_t x1, uint64_t x2, uint= 64_t x3, uint32_t cpuid hvf_vgic_write(const char *name, uint64_t val) "vgic write to %s [val=3D0x= %016"PRIx64"]" hvf_vgic_read(const char *name, uint64_t val) "vgic read from %s [val=3D0x= %016"PRIx64"]" hvf_illegal_guest_state(void) "HV_ILLEGAL_GUEST_STATE" +hvf_processor_feature_register(const char *regname, unsigned value) "%s: %= u" --=20 2.49.0 From nobody Sat Nov 15 14:11:25 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1750425270; cv=none; d=zohomail.com; s=zohoarc; b=kFRUhVKB2E8rQkqTfNpC7Q9M+7YVMFZwzVZoC/SBHXnBC/lAV/ozzsUoD6GzuHCN3I9HrRofmQ9iU9NavPrGkYQ5Ic+o6Q7Swh+/Izn+BB0515lZ49XLNWziQOAqtmJffXbnDOHAAV3MdisA0zw189Sd1kPuNLr1JYqnfO2RxwU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1750425270; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=CoTleeCUcvYndolgWSxVbjuEBw5fGt+mb1nmRFlbWPU=; b=c4o5/wnplFgxrwTpcWDjqXTPPwfG1lQEnMIJBzE0ocbwW5jbpnVsWu+IYydnrvAWwrQ4FhOT3sTPPc++/8Zuv4/f88KolBQKQ2Lw+y6Y+44Dc2fwsk/8fcwSHnYGCbadSziGRbxde/qjs3I0k/x3UTyLcT0sjRAPc/uMEBbTEts= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1750425269923324.6145827306002; Fri, 20 Jun 2025 06:14:29 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uSbUO-0004zK-2b; Fri, 20 Jun 2025 09:09:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uSbUM-0004qz-4r for qemu-devel@nongnu.org; Fri, 20 Jun 2025 09:09:02 -0400 Received: from mail-wm1-x32d.google.com ([2a00:1450:4864:20::32d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uSbUK-0004rM-HF for qemu-devel@nongnu.org; Fri, 20 Jun 2025 09:09:01 -0400 Received: by mail-wm1-x32d.google.com with SMTP id 5b1f17b1804b1-453643020bdso7372055e9.1 for ; Fri, 20 Jun 2025 06:09:00 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a6d1192680sm2076203f8f.95.2025.06.20.06.08.57 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 20 Jun 2025 06:08:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1750424939; x=1751029739; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=CoTleeCUcvYndolgWSxVbjuEBw5fGt+mb1nmRFlbWPU=; b=mBg6BDuSLoM/9bBw8W1CXSnhPh94g99ThxjB5mnc+Uue+cN52rZKqTcHP232JtvVHL Vp6OqGteV4WRshLbylhOoEbGMc4Fb6gTevp1ADD7goLBIRcQMB3zHIoZki5vAtbcXIGn mK+hKGkl/OxTZJHR1Uniw70Khpm7t+a/ORtEPe8gAsU3zLfWRMrdFELsAzggiuXlcc9E zJkegCUbnBH+ZMeak7AxASlTjSlhlTnYzuusJhYby8Gcb+pv6lg8S51isL5j3mD+X9j2 1hjRkTebsV9h80TnPxSr/bYcwmzRevluSwvWB+QPnGquWp9cQ5aKTy1C5I3pn71aBd+Y El6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750424939; x=1751029739; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=CoTleeCUcvYndolgWSxVbjuEBw5fGt+mb1nmRFlbWPU=; b=ovrLOYR1EVDs+jiTtv8uvaL2sICWrSimezjuuYcsbIzd1rCRGp6FwuCyP5ukWWsuA6 x9AQ1z81Up//VF72GlWxV6qwTfXtPBdeRHsZWq23wOEACl82w3Wk4efcf0Tnc3Z0ovzF WYf1wOjY80ySwRBq9rDmBAWwZRS1Jcmqe/ifFzRv82aaMCDEdh21ImF08CtW4E0mtDLC 6OYixA2VPPhUMpvXPcRoA/091fiBSYpFkSJ3RojiXHJFrVBZkWRQzDQusP6zABKjWvzZ SRwVBZAHcARwvL6+HIjk1OlDKKaFtc0FKfnh/lpbnVta6cgKtMO1NDAeFKuNI8b/Vqr3 BIQA== X-Gm-Message-State: AOJu0YzGwH/cvA8Y5AByfFn4F3Eo4HrC7Yx9M6jXMensOeZgaTWweWHN HMOHRXbhpdOSUDKM9AiK9w48bQMppnD+DDgDxr+IQdDkyHk7oRlj6ZYnn0+6fByfEU5i0l184Xj CJBe80n4= X-Gm-Gg: ASbGnctwIXI2QNipMl0XSyNeRhoJ2RXty1Uax68nEc+NjpguUrVbsdxpn9ba5QGfI4j +COqrvh9BtuYseX1HSo8Dd6Sa4wJ5IxHl++1IKgUbEFXzhC0CFqgsOQy7O3HbkExag7Im3qnteG YoMRQgmMg9W3HJcnr6jEfgJTw7UwIKsGnql3nS8GeVg5tJnt9Ls03JWTJh4EneOnpySPLjNXo3O UMKqRTmJkTJSfa8K91GmwPcnvUtT3GHMjAF0sBCxB0qYcQFqDOOrnSvIx7BFjX5O2qkiTqOhmKb yv+Ch9wCcByEtt6lXh9/6WjRfFFPz3uhnZqnrtV7DMdGWAp1lvGGT0n2tn3kRMcjWoqwheEwK7a 8Saem1h+A0nuAgOgXqIgFZcKQXHrckXdJFxl//mDmZphm7Ko= X-Google-Smtp-Source: AGHT+IGuIbYoqiAUyyTvRzRx4XiSdr/lFqQmEELQqzVAO0UNUSoo47/0fUF0+MkjrXr0XzUJRZQK0w== X-Received: by 2002:a05:6000:3103:b0:3a5:58a5:6a83 with SMTP id ffacd0b85a97d-3a6d13013eemr2649039f8f.13.1750424938708; Fri, 20 Jun 2025 06:08:58 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Leif Lindholm , Richard Henderson , Radoslaw Biernacki , Alexander Graf , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Paolo Bonzini , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Phil Dennis-Jordan , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Bernhard Beschow , Cleber Rosa , Peter Maydell , Cameron Esfahani , kvm@vger.kernel.org, qemu-arm@nongnu.org, Eric Auger , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Thomas Huth , Roman Bolshakov , John Snow Subject: [PATCH v2 19/26] hw/arm/virt: Only require TCG || QTest to use TrustZone Date: Fri, 20 Jun 2025 15:07:02 +0200 Message-ID: <20250620130709.31073-20-philmd@linaro.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250620130709.31073-1-philmd@linaro.org> References: <20250620130709.31073-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32d; envelope-from=philmd@linaro.org; helo=mail-wm1-x32d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1750425274409116600 We only need TCG (or QTest) to use TrustZone, whether KVM or HVF are used is not relevant. Reported-by: Alex Benn=C3=A9e Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- hw/arm/virt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/arm/virt.c b/hw/arm/virt.c index 99fde5836c9..b49d8579161 100644 --- a/hw/arm/virt.c +++ b/hw/arm/virt.c @@ -2203,7 +2203,7 @@ static void machvirt_init(MachineState *machine) exit(1); } =20 - if (vms->secure && (kvm_enabled() || hvf_enabled())) { + if (vms->secure && !tcg_enabled() && !qtest_enabled()) { error_report("mach-virt: %s does not support providing " "Security extensions (TrustZone) to the guest CPU", current_accel_name()); --=20 2.49.0 From nobody Sat Nov 15 14:11:25 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1750425254; cv=none; d=zohomail.com; s=zohoarc; b=nL4lBOtroB9BIPZBZez5yZVb6KOIp+de65pA4oUnghn3E7gUrddxM7Q/CwYv7R04I/UhBTZvO8xGdGC+04nm2Ub6iYEtCl6JUTnjuGcU7qWJaVGuBX82NnzBeaPZqIUektSfMGEBq+X2I0dXUVz7OSvB4KIqn7CPrvwlipQ/5QQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1750425254; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=jKb7+45W8wr+DNWypSxWBKVEj0bAIAzVgg/1Er2vy8s=; b=Yhb7l+NHUk2CMubchch1sSDD13w0PdxqvcjId/e6Bfha59vvGMxrxCCNjg8hohi3GWB2SnbicJbm8J++Qm0xGuF0ap3aRLuQ6YKZvdp/KNFdMtYvjypnC96Akl2Y2FAnghjhdTTQuXwSOpUwNe57k0AXWWZaJkmLk3ATOavcpdQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1750425254912940.6563248452901; Fri, 20 Jun 2025 06:14:14 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uSbUU-0005Ee-6P; Fri, 20 Jun 2025 09:09:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uSbUR-0005Bq-JW for qemu-devel@nongnu.org; Fri, 20 Jun 2025 09:09:07 -0400 Received: from mail-wr1-x434.google.com ([2a00:1450:4864:20::434]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uSbUQ-0004sg-0Z for qemu-devel@nongnu.org; Fri, 20 Jun 2025 09:09:07 -0400 Received: by mail-wr1-x434.google.com with SMTP id ffacd0b85a97d-3a507e88b0aso1550102f8f.1 for ; Fri, 20 Jun 2025 06:09:05 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a6d0f1ac5asm2117585f8f.33.2025.06.20.06.09.02 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 20 Jun 2025 06:09:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1750424944; x=1751029744; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=jKb7+45W8wr+DNWypSxWBKVEj0bAIAzVgg/1Er2vy8s=; b=CiA5T6w/zk81PZR+KrkaOzyj3uc6dHoz7mTdlTsdMa6P0yW0IbevzOsFkcTeDye9LY E7IL2URf5/M4w80UeGuiIBz9OYgu6USE8AUDSPDcUANDY7AOoF/1wSDdBv27rd41zaoQ PFx/aqhwKPU/NVEftqPUJ70kknpX307bCUsAG7neewFvMkY2VoJs6E+maxUqZc94xSPx W1QACjwvfjuxy1QE6gOEjjeAAUMJQ50H0brRy0k6kYTSbohfwGRUjonbi8mdBOvI+4la 75tbWmCsKTuxBfsYHddO8BkDMtr/c1ouw/bqaZ2om6lvN8FSExHErSepArPQa4oA+eDe iEuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750424944; x=1751029744; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jKb7+45W8wr+DNWypSxWBKVEj0bAIAzVgg/1Er2vy8s=; b=avhbD4xbT13XQlsN6lOXMmoTHj3XrkkwPtWZB9w5tE6rkSjP2idQO65StADMfjunpI cWfHncH0Qqh46gjWsXKyhWgEnHgRDlLn706EGkItMtwkNj7txN2SVXhrkEviJqtcQ1vJ JSB9EX8Do0yoru6T/Anspys7Tpv00ANl0VXB5FNaDGavQBKEr+MGM9H7IJ0NWZbtQMkd GMhSa+TYp6DwgirhWnYEG1D41/YuOR3hl0NKZy3nEdbPBTifDylx2OW5Kitt3aT/pfY2 g4L+9HaoC4ORLJbceTRhvd/ggbkpDG3TTfZSful3lreNbPFxZKKGKcGArpJow5Yr9u3C kxdw== X-Gm-Message-State: AOJu0Yy0IUEPov3lKT1i3XSQulq6QuqxNzI16RBjLCTgjxYV3rypc5T2 WORApC0WrUz3mqSoSHCBprwxE+9AXJa2yzH2iU5CeMPikHr18oMrV9RB7rtWlTSOIcNStVIObsy Kd2f8zsQ= X-Gm-Gg: ASbGnctOSebsCjTI4+EcQGCo/FymJn/5UVmJu0C/r/vxWa6XUadBHCSmlj326v/YLfs /oHjvVATq6huwYLg5x4AHlaL1p8duq8tqwnVm23y/NofBMnEbLZAgRDA2bNNTaAqbmZP04TGhTj tsk2PUjqLunOOu6sT9wQCnDKE4/VXYmLrPiCfK9QRhAdp/x3uQkGhGkJ9bmu21+Lm2pRmC8YdWu s2dTCm/ysWjscGanyZw8jUiBlOdOatIcrLatxed/uM3QCBvXjrAVn7aat/mCjeoIaClZV+/n0f4 c7A3BR87srISbpmfeBSBBV8Yim07v6qpl/vCREHU7zXpS7DCW2d2gz6AVrYcd9z35hJCVBLKM0H 8/aEIZG+B4x1p0+/qIW4ozb9tcoFSBo45Chea X-Google-Smtp-Source: AGHT+IGU/PISgWAUAam3cXO827+5Gf2StC7Q8MM7jO79fbKmCjBYcioqe0LeMR+lxX2cddMN2HDweA== X-Received: by 2002:a05:6000:4109:b0:3a4:eb7a:2cda with SMTP id ffacd0b85a97d-3a6d13071ddmr2045022f8f.30.1750424944090; Fri, 20 Jun 2025 06:09:04 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Leif Lindholm , Richard Henderson , Radoslaw Biernacki , Alexander Graf , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Paolo Bonzini , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Phil Dennis-Jordan , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Bernhard Beschow , Cleber Rosa , Peter Maydell , Cameron Esfahani , kvm@vger.kernel.org, qemu-arm@nongnu.org, Eric Auger , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Thomas Huth , Roman Bolshakov , John Snow Subject: [PATCH v2 20/26] hw/arm/virt: Only require TCG || QTest to use virtualization extension Date: Fri, 20 Jun 2025 15:07:03 +0200 Message-ID: <20250620130709.31073-21-philmd@linaro.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250620130709.31073-1-philmd@linaro.org> References: <20250620130709.31073-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::434; envelope-from=philmd@linaro.org; helo=mail-wr1-x434.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1750425256332116600 We can not start in EL2 / EL3 with anything but TCG (or QTest); whether KVM or HVF are used is not relevant. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson Reviewed-by: Alex Benn=C3=A9e --- hw/arm/virt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/arm/virt.c b/hw/arm/virt.c index b49d8579161..a9099570faa 100644 --- a/hw/arm/virt.c +++ b/hw/arm/virt.c @@ -2210,7 +2210,7 @@ static void machvirt_init(MachineState *machine) exit(1); } =20 - if (vms->virt && (kvm_enabled() || hvf_enabled())) { + if (vms->virt && !tcg_enabled() && !qtest_enabled()) { error_report("mach-virt: %s does not support providing " "Virtualization extensions to the guest CPU", current_accel_name()); --=20 2.49.0 From nobody Sat Nov 15 14:11:25 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1750425220; cv=none; d=zohomail.com; s=zohoarc; b=mdxTmLtBZc8lStFTC9yfCGQE8CYmsQlvXgMX4yAhFcn1QCHwMCbcpfRMiEsdTfJMr0jT0IIFQ8/EQjAGFZOIGldFgp9oNvDLcYI9Bd3T+L/t4eJ9sZAn3Wp/auB0wQFXCZxCWTW66RhEw19wxrnZsTB1ND2oJLG2OuvjOmxpZ+o= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1750425220; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=y5LZcCqNpH4GazYoT4HEePjvcf7hcAUKrr97H91/oS0=; b=US7u9dnmGHUZ03/atYw9881kLNN4c3hDtVquqIz6NvBrmZ+PuRzzv05hIPi//LFwCg2NqIOxWloOxRXZZPnyo9Nj/MFJpbtUxPlol+Z393u+K9mg2I1fYw9nfEbWjQ8GPDlL4UMnzfZpmZBWZHpP6s6FudvnPIR+fV53v2f0H+E= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 175042522036250.1608154549383; Fri, 20 Jun 2025 06:13:40 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uSbUa-0005iO-1T; Fri, 20 Jun 2025 09:09:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uSbUY-0005Yq-74 for qemu-devel@nongnu.org; Fri, 20 Jun 2025 09:09:14 -0400 Received: from mail-wr1-x434.google.com ([2a00:1450:4864:20::434]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uSbUW-0004uR-Lk for qemu-devel@nongnu.org; Fri, 20 Jun 2025 09:09:13 -0400 Received: by mail-wr1-x434.google.com with SMTP id ffacd0b85a97d-3a528243636so1159206f8f.3 for ; Fri, 20 Jun 2025 06:09:12 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a6d117bfd9sm2076809f8f.57.2025.06.20.06.09.09 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 20 Jun 2025 06:09:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1750424951; x=1751029751; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=y5LZcCqNpH4GazYoT4HEePjvcf7hcAUKrr97H91/oS0=; b=OwuGRA/4rWsALA1SholNrd6ABxL+j8EhWV8nJOyLyRjDDXSQamSBiNufgEJl9kR/Vq /k7fNjRuHZ51du0IM+Qa5Id06pqAnfSsd/hlh3W09r2OIIRBrwPLffzt57sKQUE52+FW 1vGFZky5SURlASTdj4xjQ61oJhX6weLmxhy8FERSOKh0SbWfQ2C7OPlYP3hoDAbIutcA 4UfHYZeGVuCFB7UtwxJG1yLqjQAIhvVDhKREdqXXrU4gHeMBHZYjLyRbfxtf/2PFJYaB mf4hYKmYB0yffOoF4Wh0gMq6e+m+dqUZd04ObV9C2GOzPheLa4WAgKBbErBExXzvgPNg isHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750424951; x=1751029751; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=y5LZcCqNpH4GazYoT4HEePjvcf7hcAUKrr97H91/oS0=; b=o1ksA//G9oJvZJAgsQQ1hZQyufVu37CmTmRzHUvwOz8/cEc0hOpK6CRYrc3QAHlFuZ Y8TU9oJOVn/sH45A70FdZdTe+o6jC0KSXjrz8IqPtMn2RVy0A+IZ4nWDNg/xwSc1Pnlq crfRCQrsfZGVCWCsGiyhqihGAPJkximiXwfegD6222YrrlBrTr+IwDsNPdy0w69k74jz J4HUyn89m6ezuFjM+0464FE760+gPxfKBzHgzEPsFzKmW/JUrUwHVqDdpbbqgVTPKKk9 ZaLOb2na6kzspa4X2G0P66hSECs9gKYhp69Av1UKfwA8xLECpGTTDnZVzXxuf4tUhgnG ctoA== X-Gm-Message-State: AOJu0YxL5KFhkiUy1iI9DKro2XBmTq/x+SRhJ7ZDF4r80MwadzTmkMAP MTqbZg7Y+JOT+zYr05gpiTAA7YAXlD0LS4Nnosn7Xrdfi78mQ+zGPDOo/YQCe0eM2gEueWih0W+ ZL0asV+s= X-Gm-Gg: ASbGncv7nYLOQPtojF2m7hvXFc1iFCwSsoI1gFiwW+jdkGaJgpiwGT3NNgmzoAV6qu6 p+pr55evGogz10bizWBc/i5CyA1uUuhnus2uoc6hhA8f7RZpDKFL+lzMWRMdeAz6jBQoOdy8y1D OEa5TBFMHfXbmrfXls9gU5oUL80wsjehpmKzwQfq+dsjfl2XlYyBu/Qdm1CjZYKKky0CPjg4I2m 9cuVcI7El8lwdb2wt7PfNSVyIySs518+TaOJPAZW2Jl80yXYZI39XJYr8bn7AoEqZp3RGo5kzOZ g8QCXthFeVEHRuVAZlpkVu3YS0uNNrIQpemKbNMhb1JJ93jIadHhSZGChlM8KLkqj7y8AVr++g8 EHCbdb6crYxTCJ+eHvwbt3aGBx33PGJwTwHpV X-Google-Smtp-Source: AGHT+IFC6yofAEZU9uIg4ElHVXtdVlW8O/y3B6pNs8rlLb+5bVvaCqliz0NCeVD+ukrt5UnUQmDjdA== X-Received: by 2002:a5d:584e:0:b0:3a4:e841:b236 with SMTP id ffacd0b85a97d-3a6d12d8c86mr2406728f8f.33.1750424950626; Fri, 20 Jun 2025 06:09:10 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Leif Lindholm , Richard Henderson , Radoslaw Biernacki , Alexander Graf , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Paolo Bonzini , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Phil Dennis-Jordan , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Bernhard Beschow , Cleber Rosa , Peter Maydell , Cameron Esfahani , kvm@vger.kernel.org, qemu-arm@nongnu.org, Eric Auger , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Thomas Huth , Roman Bolshakov , John Snow Subject: [PATCH v2 21/26] hw/arm/virt: Rename cpu_post_init() -> post_cpus_gic_realized() Date: Fri, 20 Jun 2025 15:07:04 +0200 Message-ID: <20250620130709.31073-22-philmd@linaro.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250620130709.31073-1-philmd@linaro.org> References: <20250620130709.31073-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::434; envelope-from=philmd@linaro.org; helo=mail-wr1-x434.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1750425221784116600 QDev uses _post_init() during instance creation, before being realized. Since here both vCPUs and GIC are REALIZED, rename as virt_post_cpus_gic_realized() for clarity. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- hw/arm/virt.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/arm/virt.c b/hw/arm/virt.c index a9099570faa..da453768cce 100644 --- a/hw/arm/virt.c +++ b/hw/arm/virt.c @@ -2032,7 +2032,8 @@ static void finalize_gic_version(VirtMachineState *vm= s) * virt_cpu_post_init() must be called after the CPUs have * been realized and the GIC has been created. */ -static void virt_cpu_post_init(VirtMachineState *vms, MemoryRegion *sysmem) +static void virt_post_cpus_gic_realized(VirtMachineState *vms, + MemoryRegion *sysmem) { int max_cpus =3D MACHINE(vms)->smp.max_cpus; bool aarch64, pmu, steal_time; @@ -2349,7 +2350,7 @@ static void machvirt_init(MachineState *machine) =20 create_gic(vms, sysmem); =20 - virt_cpu_post_init(vms, sysmem); + virt_post_cpus_gic_realized(vms, sysmem); =20 fdt_add_pmu_nodes(vms); =20 --=20 2.49.0 From nobody Sat Nov 15 14:11:25 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1750425010; cv=none; d=zohomail.com; s=zohoarc; b=ajWAWxSXWafMA526yVxBo++3h0mrOuyXK+0UxglzDxmRK4eqAMCmB6KpWsnWrkiTj2cbOUTXRNXgx/9vbEeqH+itO+SEcXFrK4b271W/J/dkuKeEaUvjhH8f2SGxmcfG+5u7uJRnGzeioNdvnQEseu8DYQtCj/OfAE0lB3UAes0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1750425010; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=tlzGRKm85UWY2+8yyhfs+sQBrY+hIXBP3ETvuuIJ2dg=; b=XX+Pm3se7koLa3WliistStrbIurZlrJ+EvdBLf3oVotY3BNp+F1s0KKGrKosW7mpZjz/SD54c3I6uDM4Cq4JEMgAkd/OsuWCle0g4zNVkk+uBn3x30w6jGZwmueRPlUAiGW1tOlWIn3odJmNGnfW/KLhn+T0FWBB7QLOeH6zyiI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1750425010190734.7289278366335; Fri, 20 Jun 2025 06:10:10 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uSbUj-00063g-5K; Fri, 20 Jun 2025 09:09:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uSbUe-00060Y-FC for qemu-devel@nongnu.org; Fri, 20 Jun 2025 09:09:20 -0400 Received: from mail-wr1-x431.google.com ([2a00:1450:4864:20::431]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uSbUc-0004wU-HY for qemu-devel@nongnu.org; Fri, 20 Jun 2025 09:09:20 -0400 Received: by mail-wr1-x431.google.com with SMTP id ffacd0b85a97d-3a50fc819f2so1494930f8f.2 for ; Fri, 20 Jun 2025 06:09:17 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a6d2236452sm1791926f8f.59.2025.06.20.06.09.15 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 20 Jun 2025 06:09:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1750424956; x=1751029756; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=tlzGRKm85UWY2+8yyhfs+sQBrY+hIXBP3ETvuuIJ2dg=; b=Pht7qKYbs4PNh3+1sfSzreFNcmsSlficbWNgEYaQqnMWJ53RYjmk4ycvkeJn8SnAKp U4IKxlgwjv4ppwiiLvNSkjkoWRO0fHrqLjfM+MmYkIgo9q76syP1NOFY36uh2DMksbzQ cGyROTZianVReO27rd3vXGy5jnNx2p+aM7LBXJR91LkPPvV0Pfjb4jXcuAmKu5mfPVwJ eQUEpQI2sn6gLVMyPjq5G1YNYHwZMAjumEGddl/Rkk9q02NOSjdrZ1a446k/tz0n8kFS X81pjBD44jE07f2w7P9DEUzNXOTik9VQsMGaWnB2LHrqV4Gr9P2IdlvegGcyUnoEldhE ODVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750424956; x=1751029756; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tlzGRKm85UWY2+8yyhfs+sQBrY+hIXBP3ETvuuIJ2dg=; b=oS/udG7MJ4W+88Z5MLtxG5t/uIqC+Sxt1wc0t3JOa9dnD3z+dFJ8RMNnnJZbFVaOYD /24bIaDG3R63DWbTJheuGIGuzBS2dI7fApmt6z340tZtUnOPfawbyWZ96o/AYrcST+Hu 73wHUCy9T7e4nY9+Z4cAg8pgDF4WGDrYg537s8PiEqoyGfQ5DAZMdMN9dfv8o1aQEB95 it/W9TiRqbT6L4ugmxTtN5qKaSzlJrNrhNAwwIu4RLdfvDeSYPfW7M/iNna+jshwUmP2 zQCvUqUipfKz4Ef+XT+fS4cnCBA7COI5DZvxhg+mVOp6jGfCel3TeKS+xVRd7cr/VBvE bpdg== X-Gm-Message-State: AOJu0YzM4z5DuwwhLkdIncXEiRW7nHpCTHPumXhwsVY+7tkxxCC9e/Xt A0LNAIcZqxRg39ypb7MQsYdQMFtcKb9lD71nKLmtf9xNhJcAJWwbDOppAbUc1kcVabWp3Y99Rpv 8I+69cys= X-Gm-Gg: ASbGncsIA83Ym5x+DAYcSMeh4DCF5ozD27RWNsPXZo9zM2/QQ48+FsN0SgfpSMW0H/D +lmuC/yct9uWK215F8KoQ0fuYArKFVRuU0LQ3nAsClUymw/e9HSAQ54Jue5bO3ucJ0xColVEE7p C6GfLoFKDi1UF6Ss4zYupkTVR/fZMx/eZj6VvuSK72VCsQN1wqhB4nOqp1L/Kw+H6FafrVFhIRx s8VvNMgvDrzmBnZJnJLSStCZFyxNuqx91g5ge/vBfWPDZ5Knw1IqjgjyQuu/jEfuLfpIkpyvDJ4 VxSXdlWUi6JOgChO4VpQ+uhTSeySOh0vfT6rsaDz660YRN4+dQphsROUVOHSQq6BD34FjVUgy+l UFGo21PywnP4aAEJ5ygniprKHnis7RgB/8rFB X-Google-Smtp-Source: AGHT+IF5uD/3snOQ4X+aLRPk1Xt/Xd4ZmVTTd6N1+20oIyEGbROy1hmGwi9rA/PwtOTLyfKem3s2JA== X-Received: by 2002:a05:6000:248a:b0:3a5:2fae:1348 with SMTP id ffacd0b85a97d-3a6d13129c6mr2233188f8f.51.1750424956479; Fri, 20 Jun 2025 06:09:16 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Leif Lindholm , Richard Henderson , Radoslaw Biernacki , Alexander Graf , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Paolo Bonzini , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Phil Dennis-Jordan , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Bernhard Beschow , Cleber Rosa , Peter Maydell , Cameron Esfahani , kvm@vger.kernel.org, qemu-arm@nongnu.org, Eric Auger , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Thomas Huth , Roman Bolshakov , John Snow Subject: [PATCH v2 22/26] hw/arm/sbsa-ref: Tidy up use of RAMLIMIT_GB definition Date: Fri, 20 Jun 2025 15:07:05 +0200 Message-ID: <20250620130709.31073-23-philmd@linaro.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250620130709.31073-1-philmd@linaro.org> References: <20250620130709.31073-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::431; envelope-from=philmd@linaro.org; helo=mail-wr1-x431.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1750425011059116600 Define RAMLIMIT_BYTES using the TiB definition and display the error parsed with size_to_str(): $ qemu-system-aarch64-unsigned -M sbsa-ref -m 9T qemu-system-aarch64-unsigned: sbsa-ref: cannot model more than 8 TiB of R= AM Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- hw/arm/sbsa-ref.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/hw/arm/sbsa-ref.c b/hw/arm/sbsa-ref.c index deae5cf9861..15c1ff4b140 100644 --- a/hw/arm/sbsa-ref.c +++ b/hw/arm/sbsa-ref.c @@ -19,6 +19,7 @@ */ =20 #include "qemu/osdep.h" +#include "qemu/cutils.h" #include "qemu/datadir.h" #include "qapi/error.h" #include "qemu/error-report.h" @@ -53,8 +54,7 @@ #include "target/arm/cpu-qom.h" #include "target/arm/gtimer.h" =20 -#define RAMLIMIT_GB 8192 -#define RAMLIMIT_BYTES (RAMLIMIT_GB * GiB) +#define RAMLIMIT_BYTES (8 * TiB) =20 #define NUM_IRQS 256 #define NUM_SMMU_IRQS 4 @@ -756,7 +756,9 @@ static void sbsa_ref_init(MachineState *machine) sms->smp_cpus =3D smp_cpus; =20 if (machine->ram_size > sbsa_ref_memmap[SBSA_MEM].size) { - error_report("sbsa-ref: cannot model more than %dGB RAM", RAMLIMIT= _GB); + char *size_str =3D size_to_str(RAMLIMIT_BYTES); + + error_report("sbsa-ref: cannot model more than %s of RAM", size_st= r); exit(1); } =20 --=20 2.49.0 From nobody Sat Nov 15 14:11:25 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1750425265; cv=none; d=zohomail.com; s=zohoarc; b=bNKn2fUhNtucGAq2LAeUv60Y9S7u2UMADLReP8IJQOXdwPAqedmKo9Uteaiha5EaprZtZ5ztHIhr1vkgB0JbztZl6urhpMC4H36xkxGhEj14syB5z63TiBB3aEdLwLfZgUvurtT+A0vaSXs/sj9+46XbQHWWiv0KZrSJmreep+k= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1750425265; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=V640ljTD2H/6yk77CGg8pqgiDQ7Rk/byXNy/qGehgeE=; b=UJ2fUe0CmziyWOExOIz5PjhFB2XkjCu9n7LyIF7MXwPQLad/zUTJiqZT28INE4v+wG3qAro34a9ZKHNad68zpD79cxk/FHoygWmcxPxVxLjTeg5fnfZ1C4asGhJFYAHz/IA/so7RTi6QKlV/Yqli2irDptPz9KBN0Dj48Ec3Yso= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1750425265639327.19007125692656; Fri, 20 Jun 2025 06:14:25 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uSbUr-0006Cz-6c; Fri, 20 Jun 2025 09:09:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uSbUj-00066K-AT for qemu-devel@nongnu.org; Fri, 20 Jun 2025 09:09:26 -0400 Received: from mail-wm1-x32d.google.com ([2a00:1450:4864:20::32d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uSbUh-0004yD-Sa for qemu-devel@nongnu.org; Fri, 20 Jun 2025 09:09:25 -0400 Received: by mail-wm1-x32d.google.com with SMTP id 5b1f17b1804b1-450cfb79177so9814495e9.0 for ; Fri, 20 Jun 2025 06:09:23 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-453646dc66fsm24808055e9.18.2025.06.20.06.09.20 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 20 Jun 2025 06:09:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1750424962; x=1751029762; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=V640ljTD2H/6yk77CGg8pqgiDQ7Rk/byXNy/qGehgeE=; b=kXEbevRhvpba/YdO1ed65S3u9QgjQRfftfnA4cF0WhM5bAhjDO2+zoD993uK0RHDsM CzenPvDr/+kIKhC+mlOIsvdC1c6gFO/vyaMZrawroZnStV52cXDSTD2ZiEVBMC5+3kw5 BXUS0vFV1Jv+AZVsPZOxntkpJRnDuTtK054pPXLnaSGLSC3l6Pw36e8RPveA4kGgAijH Cdn6AM3jH8VmBQAai/UFko+wqajrVWAP/7VJgt3GYdu+IHejg7s7+rpdsnV5I3Zr2fZ/ qK4hAx/zMCPGmB0Ftoj5E3UB0bAp63HjnAkdGiUf+C5n2WN1ScApdPuaQDKoNuZNIDqT /VdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750424962; x=1751029762; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=V640ljTD2H/6yk77CGg8pqgiDQ7Rk/byXNy/qGehgeE=; b=d3UamdwPAR9YNUgRvALkXqUwjcY0UWdVvT+0AYRvroz2JRSqwpcJmlByBNpL2IULBw vJ61U/W+QMObYwsOqe8KBHi0XubiPc5ctn0ONQhF3r83glJyuBeAsUdAYeFvdBFfIwnR sDSEaMtFGnHYRJ620Pw5xo62zsLycy5QTnyytKWc+xGIM0tXdSdqqAepFbC8hdMcnzJe LkBA8rNCmiLFpwIxc9xWug3xGYJNxlQn5hwuajSZtzaLMWikJ4c7+CoVZ6EFaJ6xT/eU qiZGtbv9lUyR2jmM5zZp4yD+JP5To5staxmtBhHOeqFGaK8B9IR8CbBhU/h++A7P/Hhd EJ0w== X-Gm-Message-State: AOJu0Ywhwaxd8ef1lI77HaXxSw68euVZhfZWwlOiBMYWrH3xTkSW5JeQ Ra9R12+V18Moio9LsaouteUK3UrUL7EaGeWO3ioojr2eB4DY6W8UtYsAjDCw8V4CVyo2vULUx3+ R+H4ARFE= X-Gm-Gg: ASbGncsHQWGBwDUWiD63aX/a6YUPqZ9EuPzFos2Ru8WIrzSWY712Pej4VD2cSvUKHO9 GrvlH+r7t/Ltj9L+shF+nNR6aVHisW59cB2sWdHUYC5PRIYfFPPkOogG4DmhEsZkWjNUy/+pURU cljKiRgXI5LVcv7LAkUzTbkVcxcM+gyKkR43ays1qMjGJFljd5U8QU5Ueq5KF1ZMBX/T6c4HM3k wN9sVts+RaBX9+qReO4IEDuH5nngcNSZfB5Y/HkN4Px5JQl5E7O7mLf3y0+t5QeonL0VJ9JSnP5 BJpc+hzLCQ4n0uI7JDCi3+KWgFl3f1x18GppLfgoN5WXWbxN5EBuukOXnbxSn9NKM3CWLDgAJDe kAcI6duTkVSPi+YEanXShnoEr3gQHgwtM1rv7 X-Google-Smtp-Source: AGHT+IGgGpF8T6F/eU2syTxh0rLMvaVCXrLMi432W+jy74ylNB4a4nTNwHJAEpagSMq8fk2NTIgxGQ== X-Received: by 2002:a05:6000:65a:b0:3a6:d579:b78e with SMTP id ffacd0b85a97d-3a6d579b7f8mr393678f8f.46.1750424962155; Fri, 20 Jun 2025 06:09:22 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Leif Lindholm , Richard Henderson , Radoslaw Biernacki , Alexander Graf , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Paolo Bonzini , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Phil Dennis-Jordan , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Bernhard Beschow , Cleber Rosa , Peter Maydell , Cameron Esfahani , kvm@vger.kernel.org, qemu-arm@nongnu.org, Eric Auger , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Thomas Huth , Roman Bolshakov , John Snow Subject: [PATCH v2 23/26] tests/functional: Restrict nexted Aarch64 Xen test to TCG Date: Fri, 20 Jun 2025 15:07:06 +0200 Message-ID: <20250620130709.31073-24-philmd@linaro.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250620130709.31073-1-philmd@linaro.org> References: <20250620130709.31073-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32d; envelope-from=philmd@linaro.org; helo=mail-wm1-x32d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1750425266292116600 On macOS this test fails: qemu-system-aarch64: mach-virt: HVF does not support providing Virtualiza= tion extensions to the guest CPU Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- tests/functional/test_aarch64_xen.py | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/functional/test_aarch64_xen.py b/tests/functional/test_a= arch64_xen.py index 339904221b0..261d796540d 100755 --- a/tests/functional/test_aarch64_xen.py +++ b/tests/functional/test_aarch64_xen.py @@ -33,6 +33,7 @@ def launch_xen(self, xen_path): """ Launch Xen with a dom0 guest kernel """ + self.require_accelerator("tcg") # virtualization=3Don self.set_machine('virt') self.cpu =3D "cortex-a57" self.kernel_path =3D self.ASSET_KERNEL.fetch() --=20 2.49.0 From nobody Sat Nov 15 14:11:25 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1750425157; cv=none; d=zohomail.com; s=zohoarc; b=iw7es5vL0vCv6sTxJ5xjV/N5hmxUUrmshu9rntSNLamxDKwbM/7QYyXKTDSk9y9vuWqLmSIHJiN4Bz8FqoEeu0OSD+V5QI+XIrOJ1UXJ5MNiSvQZfi6UbOs8a3z9NY19o5OKF0cGaOpV+ix4ChJZQIqZHauj4Br5hhSVvyxZ3+M= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1750425157; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=2ho90gmr9LBnf0X5r6n+/qD5b6A/rnGinNhmNB6fBLQ=; b=dimWTs9JXpXPfbZuSsRFUEQ0u/MR5PtNROeLqzzHfzg+p8ATbtGJvRWc1MeiIEid84vsQqJHJxRQlZMjZwik00tO5ANnqkXNtqRGYznlTVb0NEG5OmIZDDxyX6AujKabgvLjK87suGp9U6RstaXcTfQDjewJwect7sargzAhRkM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 175042515780418.648417368363766; Fri, 20 Jun 2025 06:12:37 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uSbVH-0006QI-5s; Fri, 20 Jun 2025 09:10:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uSbUq-0006Ad-1D for qemu-devel@nongnu.org; Fri, 20 Jun 2025 09:09:32 -0400 Received: from mail-wm1-x333.google.com ([2a00:1450:4864:20::333]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uSbUo-0004zj-H4 for qemu-devel@nongnu.org; Fri, 20 Jun 2025 09:09:31 -0400 Received: by mail-wm1-x333.google.com with SMTP id 5b1f17b1804b1-45348bff79fso21175135e9.2 for ; Fri, 20 Jun 2025 06:09:29 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a6d1190c9asm2073452f8f.93.2025.06.20.06.09.27 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 20 Jun 2025 06:09:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1750424968; x=1751029768; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=2ho90gmr9LBnf0X5r6n+/qD5b6A/rnGinNhmNB6fBLQ=; b=h5W6ZV+jJfjqLfkZoqArgbiag5+e5R0LmITY2mykPJJlfJVlhFuNlJjGm1lBrl+x6M StKuwhG+0oOvrvcoMq+qroCshLhH6u58I1UgscJeh4oInrrqCpZvFBAW9WaLBbMt459N 04Kh8Nao+O4zo82EqGb3DyW6H7JCvb1kkY9ndi1GNR5pXc4VYEKbwDF35HALDOlM0vxn jKvm5F8hfQuRU89RYmPVlV3qow0+cbieyLLQ4bV9dg1tV2g87WfVPGpycqR69mUNtuu6 DBd7p2iefuBvw31hLaXHnWn+5bn+6mib57eAVWlBV4wn4CQIpql5w4Zg0AewcAmOvPku uEqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750424968; x=1751029768; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2ho90gmr9LBnf0X5r6n+/qD5b6A/rnGinNhmNB6fBLQ=; b=q9cDXQrNPlDL+3qX4dIM1lXDSM8vckQPWJFybQ3K/DhFPlU1UBYP0jx+Q4dbCux4/c +TzAtHW6fiT4lT8Xy4J7aM+ndgT90UxHeS/QYwoLe1WVug0gHa3cjRJbFaMYnN/1lU7J /voTU7ZLcbj0rElg9pbbRFpNllS0VrNTGIGWAwx3kAuv9H8yF7/dYPxfR3TX9LikFV/4 1ZLaTRLUbLdZAvWNE98LiGBkutSRwT9ZL7hhb4+2MuICjBdvJh0xAQ8nNErBXEZIMrUr SM8Ozda+6bAfX8FaUsXzJbLfDS8F4WB/G62Qt3fwnDDnV/9I4t3KVHseqYp5oH/c6wyG hQag== X-Gm-Message-State: AOJu0YyP9krknuXuFZzLNsid5hor1Ssf2wT69Dox0eN49V2aUqjmhgSA CqpbxHBTUsBod4sTf88DAQYtLvw0y74pM7ivf7kTcnEz0q5dMUU7w0Fac1mW6pX8Vg//tiepI+d y0JmPH7I= X-Gm-Gg: ASbGncshav3ygEclwQujY6aXatAVcFN5dN/GI8fPhqKh7M15P7LNwSV/A4nVTzSEktL 3hkhO9JUnnOyXFMrSvFU64gqKF/+Lff5SgUQsjfB6+bb64SOp4IgROFAUD39XX3eAZZEl+6M8ZY lnSpdd0PC8jqQLoXC19YRaawK6tx/+3LkKld5HPMkmH1uswXhmAjep8HbEhtgQMbNZK0GUDaJGQ GYK4adYXb2JAqydbiNNupNPAu0E5hJNYWKQejLr7Kr0laFskNqTXp9RUyorsTuK3iauCf/lsHhb JN0/3ap5NL/5u0K+/k0x/dlb9/ip+VkrR8AUTcP5v+WqrRZQtyBR0jQiiLjJM+HdCTWJzxaByRn wFuJ7gjtVPXXqJ1YyfKbfH9ohUqgSRU1FdqZy X-Google-Smtp-Source: AGHT+IGF8bB+qSx4ZvZXQLjUAOyAVozgjbRUMGz4uRoQ08Z1w2S6A2LTzrO9vB7Kb0AUvy301GjaBg== X-Received: by 2002:a05:600c:4747:b0:450:d37c:9fc8 with SMTP id 5b1f17b1804b1-453659c0a51mr22550685e9.13.1750424968380; Fri, 20 Jun 2025 06:09:28 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Leif Lindholm , Richard Henderson , Radoslaw Biernacki , Alexander Graf , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Paolo Bonzini , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Phil Dennis-Jordan , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Bernhard Beschow , Cleber Rosa , Peter Maydell , Cameron Esfahani , kvm@vger.kernel.org, qemu-arm@nongnu.org, Eric Auger , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Thomas Huth , Roman Bolshakov , John Snow Subject: [PATCH v2 24/26] tests/functional: Require TCG to run Aarch64 imx8mp-evk test Date: Fri, 20 Jun 2025 15:07:07 +0200 Message-ID: <20250620130709.31073-25-philmd@linaro.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250620130709.31073-1-philmd@linaro.org> References: <20250620130709.31073-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::333; envelope-from=philmd@linaro.org; helo=mail-wm1-x333.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1750425158906116600 The imx8mp-evk machine is only built when TCG is available. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson Reviewed-by: Thomas Huth --- tests/functional/test_aarch64_imx8mp_evk.py | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/functional/test_aarch64_imx8mp_evk.py b/tests/functional= /test_aarch64_imx8mp_evk.py index 638bf9e1310..99ddcdef835 100755 --- a/tests/functional/test_aarch64_imx8mp_evk.py +++ b/tests/functional/test_aarch64_imx8mp_evk.py @@ -49,6 +49,7 @@ def setUp(self): self.DTB_OFFSET, self.DTB_SIZE) =20 def test_aarch64_imx8mp_evk_usdhc(self): + self.require_accelerator("tcg") self.set_machine('imx8mp-evk') self.vm.set_console(console_index=3D1) self.vm.add_args('-m', '2G', --=20 2.49.0 From nobody Sat Nov 15 14:11:25 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1750425259; cv=none; d=zohomail.com; s=zohoarc; b=M9OZuuEfkRMghWiOvs50Rjv64I7oX0+bnqq5A+ssmMlwP5kFdTgSFrMDJWnpiiBKpTCQQe835n1gqJESuUIf3AvdPN9gxeg1glhMxub2ordFXj3F57Rs4V5WoOKD6yn3zdx/jqrIrjTPl9gmFIYNxU30vE1N0qhy/CpDR1atuFY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1750425259; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=ML487RZEtX6RDPbX3JUchrWHyom2/STG3MUfjQAASi4=; b=oIGYGb7VGuGZZRgSs1dxO8rztOPF1lca1KbCe+oNcpHv0u08zF6dRRoWq/VFocSBt66cm0BRdJXTD3g/C8FMF6+toFZnTax9UG8njFxKRLNm3tSRzcOGGsGO0kEleXP/45gHDmYRgDxvcS0BzUnqzXK84rJToJWYacuKYfnV8Ts= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1750425259339973.0802435348952; Fri, 20 Jun 2025 06:14:19 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uSbVU-0006pJ-3g; Fri, 20 Jun 2025 09:10:12 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uSbV0-0006Md-Q0 for qemu-devel@nongnu.org; Fri, 20 Jun 2025 09:09:44 -0400 Received: from mail-wm1-x333.google.com ([2a00:1450:4864:20::333]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uSbUz-00050y-6s for qemu-devel@nongnu.org; Fri, 20 Jun 2025 09:09:42 -0400 Received: by mail-wm1-x333.google.com with SMTP id 5b1f17b1804b1-450cb2ddd46so10893665e9.2 for ; Fri, 20 Jun 2025 06:09:35 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45359a09ee6sm38434125e9.1.2025.06.20.06.09.33 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 20 Jun 2025 06:09:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1750424974; x=1751029774; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ML487RZEtX6RDPbX3JUchrWHyom2/STG3MUfjQAASi4=; b=IT057k3uHPK2jXPABWZBFBSIB+izc1o8hMUcx8/yTkbKDneHtD5b2YVkxeSqDpEmyY Raf5RDBNTiq2k92x/DOt6dRPrVhnAzx0XkuFUR8BtL3ZdXwoYX86RuGgDfXyQ+hIKca3 AX+o5u4M0qJwx0AhXg4Zp0badcrniEavpS7kzUNyqUwhNZmJpZTQ9dMr/4XSZxYD3s/2 Z8ctbfNNFIg6mcPvjc6mQsVbCJhe+pJVjqXFTO3yrO6R9xxVMHudrziF0WjnGEuJ+aAh J8TA+mWtXCVf4jxYcolqHtwR7mPp03Fa9kdb1w7Ob8BLGhb9QUprvfnPDCx1fReQE3op t0iA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750424974; x=1751029774; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ML487RZEtX6RDPbX3JUchrWHyom2/STG3MUfjQAASi4=; b=iHDUro0XxYtYi4MK1iUuG9+98k8V64qBJPUcjGcGnRBSVkeHdFc/BrS+d5zLtQySN0 XEaI4F3Mmo8153wl/5xPCcl3vu182XQ9Du2+zxHUUhDTV9fHwX+mtWQ3lR5gShFlhPQd 4f3nF9BzS7yyuiWB3f8PEWleGCHMaovWv8K9ScQmyUsdXRS3008zWq9cdJ+K9MQnG9uH DHNUFnWrmbKQYHX3dan4AKb25TkFYB3026P1gwn/2OLHZATiWxt6F4QpZoczimhMU0B/ IikzAcmQ9TC3uvsTYtqmSAIsxbmyzVL7CZl8pivY8ZOWSEiNmXFWpnCTCoHgG53EvQsx 6lvw== X-Gm-Message-State: AOJu0YyUHL3LFrLzlVnjadTE28k0EpXx6p+hjyXAWR5EDLrCbzhZpuYB Nrf3tsxSMmAGICocWh7fOLJwrbSsQtKLVVunjyLhLZvttowCvnCBxrJN6hcO38RTLflFpI0KsUi LP7HxFmE= X-Gm-Gg: ASbGncscjo2UhYBz3XKlca0dk0BFepDe2ACtwadmTkvt/bpv17eC+jhUxK2fMYqXtzw ZozJyaDM7lCw8m8vMpzca4dqXxjmKjUDS5ESAF4cmtBAVQqX2llKrt2S4fy0LHeSJ//E7DcaF7V Thbg6gxFO8FuVv8wpG2p1sVmjRt3UMs9hdlTuq1Hb3/OQgk2/sf47RQFopiIx3EfMoMBpmsOAP6 hzro6TcXjsJBnpjM6rakafFUXyHQMX30rpAmp1GbOkiJ3++dtA1kE+6hJaLOegBdgqlsLo9Jz+7 kSCKteMsq6aZepy/IE1htM2grO/SI93eY0MJLjesfi14fad6UlrpVKkTy+pUoo4dCaL7HectxId afhBx/v6O7/5uz/oqcrA9XsbGoLVb/ioLF9/P X-Google-Smtp-Source: AGHT+IFoaiSq8p/vZ15JMywutihLdhiyx/4+KTYgXl1gSeqr94tnRyEi672b3w+H0TV5kZSUiEuYRg== X-Received: by 2002:a05:600c:3542:b0:451:e394:8920 with SMTP id 5b1f17b1804b1-453659edd18mr24577215e9.27.1750424974566; Fri, 20 Jun 2025 06:09:34 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Leif Lindholm , Richard Henderson , Radoslaw Biernacki , Alexander Graf , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Paolo Bonzini , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Phil Dennis-Jordan , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Bernhard Beschow , Cleber Rosa , Peter Maydell , Cameron Esfahani , kvm@vger.kernel.org, qemu-arm@nongnu.org, Eric Auger , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Thomas Huth , Roman Bolshakov , John Snow Subject: [PATCH v2 25/26] tests/functional: Add hvf_available() helper Date: Fri, 20 Jun 2025 15:07:08 +0200 Message-ID: <20250620130709.31073-26-philmd@linaro.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250620130709.31073-1-philmd@linaro.org> References: <20250620130709.31073-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::333; envelope-from=philmd@linaro.org; helo=mail-wm1-x333.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1750425260342116600 Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson Reviewed-by: Thomas Huth --- python/qemu/utils/__init__.py | 2 +- python/qemu/utils/accel.py | 8 ++++++++ tests/functional/qemu_test/testcase.py | 6 ++++-- 3 files changed, 13 insertions(+), 3 deletions(-) diff --git a/python/qemu/utils/__init__.py b/python/qemu/utils/__init__.py index 017cfdcda75..d2fe5db223c 100644 --- a/python/qemu/utils/__init__.py +++ b/python/qemu/utils/__init__.py @@ -23,7 +23,7 @@ from typing import Optional =20 # pylint: disable=3Dimport-error -from .accel import kvm_available, list_accel, tcg_available +from .accel import hvf_available, kvm_available, list_accel, tcg_available =20 =20 __all__ =3D ( diff --git a/python/qemu/utils/accel.py b/python/qemu/utils/accel.py index 386ff640ca8..376d1e30005 100644 --- a/python/qemu/utils/accel.py +++ b/python/qemu/utils/accel.py @@ -82,3 +82,11 @@ def tcg_available(qemu_bin: str) -> bool: @param qemu_bin (str): path to the QEMU binary """ return 'tcg' in list_accel(qemu_bin) + +def hvf_available(qemu_bin: str) -> bool: + """ + Check if HVF is available. + + @param qemu_bin (str): path to the QEMU binary + """ + return 'hvf' in list_accel(qemu_bin) diff --git a/tests/functional/qemu_test/testcase.py b/tests/functional/qemu= _test/testcase.py index 50c401b8c3c..2082c6fce43 100644 --- a/tests/functional/qemu_test/testcase.py +++ b/tests/functional/qemu_test/testcase.py @@ -23,7 +23,7 @@ import uuid =20 from qemu.machine import QEMUMachine -from qemu.utils import kvm_available, tcg_available +from qemu.utils import hvf_available, kvm_available, tcg_available =20 from .archive import archive_extract from .asset import Asset @@ -317,7 +317,9 @@ def require_accelerator(self, accelerator): :type accelerator: str """ checker =3D {'tcg': tcg_available, - 'kvm': kvm_available}.get(accelerator) + 'kvm': kvm_available, + 'hvf': hvf_available, + }.get(accelerator) if checker is None: self.skipTest("Don't know how to check for the presence " "of accelerator %s" % accelerator) --=20 2.49.0 From nobody Sat Nov 15 14:11:25 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1750425126; cv=none; d=zohomail.com; s=zohoarc; b=G/diuhJ49rvcvgwXtzKfYDiCXc5OxXpFxM0oCUHOqrWsAMEKtCtk6+ug7Y0ndKcBzYeqA2Winms3WpC39uhO0It/UoKKX4PMMdnHHyPR5uPjjSbsg5esnxsgQDCQpzcIFJLTkx1wGkYPliY0TNloVyvbe8Iws5hW5y5eBLEJupQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1750425126; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=w6n2BSSxRh+KStXe1TUl7/blQoxrrxglxVgcpHIzilA=; b=PhXyfylZo0fdD6B0BM110nNS3ELXPA1PtUTE1xUNr8b+T+J4Rw4DpER0vijGGn1vTs25ls36aN7g1clQS9eilLJW7x4MWmxqvNqpdFyTyp8B73w9ubTdU8xvbBzF2StlFVcanH2Tb4QOhX80Vc6xPZSMXdrKk+dX0hIpUZEEPg8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1750425126699821.0446617410245; Fri, 20 Jun 2025 06:12:06 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uSbVP-0006Vx-8d; Fri, 20 Jun 2025 09:10:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uSbV4-0006NN-UT for qemu-devel@nongnu.org; Fri, 20 Jun 2025 09:09:51 -0400 Received: from mail-wr1-x42e.google.com ([2a00:1450:4864:20::42e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uSbUz-00051V-Kh for qemu-devel@nongnu.org; Fri, 20 Jun 2025 09:09:43 -0400 Received: by mail-wr1-x42e.google.com with SMTP id ffacd0b85a97d-3a4e742dc97so1830208f8f.0 for ; Fri, 20 Jun 2025 06:09:41 -0700 (PDT) Received: from localhost.localdomain (88-187-86-199.subs.proxad.net. [88.187.86.199]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a6d1188804sm2015800f8f.79.2025.06.20.06.09.38 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 20 Jun 2025 06:09:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1750424980; x=1751029780; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=w6n2BSSxRh+KStXe1TUl7/blQoxrrxglxVgcpHIzilA=; b=j1AbF+saJLwNRwmEmgfXjh/ZCQoVy6jpWeXzoqh2NOxw3ljJA6cWkAoOspcfs3jJOd 3N5LlMD504rtBBpaHnFfb1DRqejU2sPtHTG4+nfr5W+6Q//v4oMKcSCFDYzYblkJnFZI RuqGPyzrDHDQudkdevcJrzCROxnkY7lHGfyhw/Rf4PvA4r4G4at8LIGjX+ASlgJUxvdD FXkAFjIAR9Iz8rm4fb+RupopT8VzabE4iQOdpHtY5HNuB7GswXBq0AGzC2hF/n3IcLuT Hm+USKnU7lRJhEGWOma8FKl5CWu/bIVu+71vP14ygvV3VVxqZ2PjfUcKA37Ie148eAyL nJgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750424980; x=1751029780; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=w6n2BSSxRh+KStXe1TUl7/blQoxrrxglxVgcpHIzilA=; b=FQkdi7hSDi0tuT4XtqebJU5+vW4HQNKz+B77s4WZtI90RuvFNqGi0o7E/odg0ccRP5 +e5jEJp0qykp7FNwID4WF5HD4chttRbebc4CMU3L1YSikx3v7lCnmB4ywI6DP8/upfEW tPhCmHa80bZqb8OzrL5lzYZgOAPMecwJOm/Zk6KLcME/mR6OsDU5JhYs42lQ6lS9YwRj yoV8nb252SeGOdWNtYqEc1kZeMZun8MfoClBBDFMpU02OM+VvIwIv4NqelkWdnLnRfdI R3cwU7gwX9MZBBGuCgxXcz8MB3wJGKSD3aGD7+ksQV1SbIbTpZRqBqnlR81HdgTItQjR UotA== X-Gm-Message-State: AOJu0YxRoFsa7zV+ECqTuI3BycT6aiinzFtIBwjRzd81ePsJnHvaRfT1 stwYFXCiGg3ddtJ49oM6yhPjEjPybKhK0rkmEXRDTzuQhhqs9ekRyyiYXfAlyWoiRlK6a+O+Vcz Eev+RFVU= X-Gm-Gg: ASbGnctOFvmX+5jIAkjUPcmXzGqIXKl11BgonrwrbC0+LhbxnlscyQJnFOZhQU2pRnI RhPiQAp3n7ug4zDcqD//qXc+J2BpDrHoj68/cCPeJRDdnLkmiQvjL3pAyjHnetBZFUVDCkNXg2M fJwaclTdAxtcwEA7HaSzy2VxTV+eZ8YqymLCBNIKpf2R/SKEvAJSNdNSHXjpjqUrY35umf5TFNl FgACHbvyZCxDpaAdihH7L3jvA8QLH1WYH3+8V2lGyi7wN2TBQYyf4HfO1fUKuPK8ORg4Pl49NUD 9nLgS05F+hRmzqlhf8XHPiZuOROgx/yX08MhdVCizo7kurHWz9WC+X2n2xoW0VRQyg7qlcB1lwl 4wDHA1kETOwsrJ0Bx4vlYWLRSxkOsuVJEXeEi X-Google-Smtp-Source: AGHT+IGXwFQFfwW7rAMovUtfDAuB9Dz2J3aZxTUZqf2DF7gPQ8T5LAmGCEyFfgo/pTiyQMieyUC1PQ== X-Received: by 2002:a05:6000:26c8:b0:3a5:8977:e0f8 with SMTP id ffacd0b85a97d-3a6d27e16f5mr2027646f8f.19.1750424979716; Fri, 20 Jun 2025 06:09:39 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: Leif Lindholm , Richard Henderson , Radoslaw Biernacki , Alexander Graf , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Paolo Bonzini , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Phil Dennis-Jordan , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Bernhard Beschow , Cleber Rosa , Peter Maydell , Cameron Esfahani , kvm@vger.kernel.org, qemu-arm@nongnu.org, Eric Auger , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Thomas Huth , Roman Bolshakov , John Snow Subject: [PATCH v2 26/26] tests/functional: Expand Aarch64 SMMU tests to run on HVF accelerator Date: Fri, 20 Jun 2025 15:07:09 +0200 Message-ID: <20250620130709.31073-27-philmd@linaro.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250620130709.31073-1-philmd@linaro.org> References: <20250620130709.31073-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::42e; envelope-from=philmd@linaro.org; helo=mail-wr1-x42e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1750425128690116600 Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- tests/functional/test_aarch64_smmu.py | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/tests/functional/test_aarch64_smmu.py b/tests/functional/test_= aarch64_smmu.py index c65d0f28178..59b62a55a9e 100755 --- a/tests/functional/test_aarch64_smmu.py +++ b/tests/functional/test_aarch64_smmu.py @@ -22,6 +22,7 @@ =20 class SMMU(LinuxKernelTest): =20 + accel =3D 'kvm' default_kernel_params =3D ('earlyprintk=3Dpl011,0x9000000 no_timer_che= ck ' 'printk.time=3D1 rd_NO_PLYMOUTH net.ifnames= =3D0 ' 'console=3DttyAMA0 rd.rescue') @@ -45,11 +46,11 @@ def set_up_boot(self, path): self.vm.add_args('-device', 'virtio-net,netdev=3Dn1' + self.IOMMU_= ADDON) =20 def common_vm_setup(self, kernel, initrd, disk): - self.require_accelerator("kvm") + self.require_accelerator(self.accel) self.require_netdev('user') self.set_machine("virt") self.vm.add_args('-m', '1G') - self.vm.add_args("-accel", "kvm") + self.vm.add_args("-accel", self.accel) self.vm.add_args("-cpu", "host") self.vm.add_args("-machine", "iommu=3Dsmmuv3") self.vm.add_args("-d", "guest_errors") @@ -201,5 +202,9 @@ def test_smmu_ril_nostrict(self): self.run_and_check(self.F33_FILENAME, self.F33_HSUM) =20 =20 +class SMMU_HVF(SMMU): + accel =3D 'hvf' + + if __name__ =3D=3D '__main__': LinuxKernelTest.main() --=20 2.49.0