From nobody Sat Nov 15 16:38:22 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1750315331; cv=none; d=zohomail.com; s=zohoarc; b=bPjm6iSAfMiTAMvXfoWAHz1YoKUUr7riiAzHV6GBvQAA4E3947wh13hoDY5G9evpGT0aX46Ta0Fu0Q/Rb3PlJP5JolSg2nLCSJIgi8GrsU5HP5RK622jkG5AiL4Nbv3vXR0MaNHcUcX4MO9+nsREzQDtF+njeAp3qtg5/qDlfug= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1750315331; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Reply-To:Reply-To:References:Sender:Subject:Subject:To:To:Message-Id; bh=MjaxmAHWJDTmRKgCswuyzroUUoM27wR6I2Moz/iJyVk=; b=chyAwTlQVNipRjXHvTq7RUS4j5cqBb1/+EPMOpbm2wyfkRzSUwjZqWFzb16Vb1YkiCU+gYEhd6gJ89zHn5wiI0ehZ1D+KwEuae5AdLQqkTFg2Gq0zkgC9/NNuMvGiEXFW1k79yLLau25+jBxEjUhjy+cVilPS50uWQmOwEMdEAc= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1750315331394387.42837192305467; Wed, 18 Jun 2025 23:42:11 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uS8y2-0002Xb-R1; Thu, 19 Jun 2025 02:41:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uS8xv-0002WQ-AX; Thu, 19 Jun 2025 02:41:40 -0400 Received: from mail.aspeedtech.com ([211.20.114.72] helo=TWMBX01.aspeed.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uS8xs-0001s1-TQ; Thu, 19 Jun 2025 02:41:38 -0400 Received: from TWMBX01.aspeed.com (192.168.0.62) by TWMBX01.aspeed.com (192.168.0.62) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1748.10; Thu, 19 Jun 2025 14:41:16 +0800 Received: from mail.aspeedtech.com (192.168.10.10) by TWMBX01.aspeed.com (192.168.0.62) with Microsoft SMTP Server id 15.2.1748.10 via Frontend Transport; Thu, 19 Jun 2025 14:41:16 +0800 To: =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Peter Maydell , Steven Lee , Troy Lee , Jamin Lin , Andrew Jeffery , Joel Stanley , "open list:ASPEED BMCs" , "open list:All patches CC here" CC: , Kane-Chen-AS Subject: [RFC v5 3/4] hw/arm: Integrate ASPEED OTP memory support into AST10x0 and AST2600 SoCs Date: Thu, 19 Jun 2025 14:41:12 +0800 Message-ID: <20250619064115.4182202-4-kane_chen@aspeedtech.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250619064115.4182202-1-kane_chen@aspeedtech.com> References: <20250619064115.4182202-1-kane_chen@aspeedtech.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=211.20.114.72; envelope-from=kane_chen@aspeedtech.com; helo=TWMBX01.aspeed.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_FAIL=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Kane Chen From: Kane Chen via Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZM-MESSAGEID: 1750315332501116600 Content-Type: text/plain; charset="utf-8" From: Kane-Chen-AS This patch exposes a new "otpmem" machine parameter to allow users to attach an OTP memory device to AST1030 and AST2600-based platforms. The value of this parameter is passed as a QOM alias to the Secure Boot Controller (SBC), enabling binding to an aspeed.otpmem device created via -device. This allows emulation of secure boot flows that rely on fuse-based configuration stored in OTP memory. The has_otpmem attribute is enabled in the SBC subclasses for AST10x0 and AST2600 to control the presence of OTP support per SoC type. Users can preload a custom OTP memory image for boot-time behavior. For example: ```bash for i in $(seq 1 2048); do printf '\x00\x00\x00\x00\xff\xff\xff\xff' done > otpmem.img ``` Users can test OTP memory integration using the following command, which loads a file-backed OTP image into the emulated SoC: ```bash qemu-system-arm -machine ast2600-evb,otpmem=3Dotpmem-drive \ -blockdev driver=3Dfile,filename=3Dotpmem.img,node-name=3Dotpmem \ -device aspeed.otpmem,drive=3Dotpmem,id=3Dotpmem-drive \ ... ``` Signed-off-by: Kane-Chen-AS --- hw/arm/aspeed.c | 20 ++++++++++++++++++++ hw/arm/aspeed_ast10x0.c | 2 +- hw/arm/aspeed_ast2600.c | 2 +- hw/misc/aspeed_sbc.c | 18 ++++++++++++++++++ include/hw/misc/aspeed_sbc.h | 1 + 5 files changed, 41 insertions(+), 2 deletions(-) diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c index d0b333646e..734416c217 100644 --- a/hw/arm/aspeed.c +++ b/hw/arm/aspeed.c @@ -47,6 +47,7 @@ struct AspeedMachineState { uint32_t uart_chosen; char *fmc_model; char *spi_model; + char *otpmem; uint32_t hw_strap1; }; =20 @@ -1199,6 +1200,21 @@ static void aspeed_set_bmc_console(Object *obj, cons= t char *value, Error **errp) bmc->uart_chosen =3D val + ASPEED_DEV_UART0; } =20 +static char *aspeed_get_otpmem(Object *obj, Error **errp) +{ + AspeedMachineState *bmc =3D ASPEED_MACHINE(obj); + + return g_strdup(bmc->otpmem); +} + +static void aspeed_set_otpmem(Object *obj, const char *value, Error **errp) +{ + AspeedMachineState *bmc =3D ASPEED_MACHINE(obj); + + g_free(bmc->otpmem); + bmc->otpmem =3D g_strdup(value); +} + static void aspeed_machine_class_props_init(ObjectClass *oc) { object_class_property_add_bool(oc, "execute-in-place", @@ -1220,6 +1236,10 @@ static void aspeed_machine_class_props_init(ObjectCl= ass *oc) aspeed_set_spi_model); object_class_property_set_description(oc, "spi-model", "Change the SPI Flash model"); + object_class_property_add_str(oc, "otpmem", aspeed_get_otpmem, + aspeed_set_otpmem); + object_class_property_set_description(oc, "otpmem", + "Set OTP Memory Drive"); } =20 static void aspeed_machine_class_init_cpus_defaults(MachineClass *mc) diff --git a/hw/arm/aspeed_ast10x0.c b/hw/arm/aspeed_ast10x0.c index e6e1ee63c1..c446e70b24 100644 --- a/hw/arm/aspeed_ast10x0.c +++ b/hw/arm/aspeed_ast10x0.c @@ -154,7 +154,7 @@ static void aspeed_soc_ast1030_init(Object *obj) =20 object_initialize_child(obj, "peci", &s->peci, TYPE_ASPEED_PECI); =20 - object_initialize_child(obj, "sbc", &s->sbc, TYPE_ASPEED_SBC); + object_initialize_child(obj, "sbc", &s->sbc, TYPE_ASPEED_AST10X0_SBC); =20 for (i =3D 0; i < sc->wdts_num; i++) { snprintf(typename, sizeof(typename), "aspeed.wdt-%s", socname); diff --git a/hw/arm/aspeed_ast2600.c b/hw/arm/aspeed_ast2600.c index d12707f0ab..59ffd41a4a 100644 --- a/hw/arm/aspeed_ast2600.c +++ b/hw/arm/aspeed_ast2600.c @@ -261,7 +261,7 @@ static void aspeed_soc_ast2600_init(Object *obj) =20 object_initialize_child(obj, "i3c", &s->i3c, TYPE_ASPEED_I3C); =20 - object_initialize_child(obj, "sbc", &s->sbc, TYPE_ASPEED_SBC); + object_initialize_child(obj, "sbc", &s->sbc, TYPE_ASPEED_AST2600_SBC); =20 object_initialize_child(obj, "iomem", &s->iomem, TYPE_UNIMPLEMENTED_DE= VICE); object_initialize_child(obj, "video", &s->video, TYPE_UNIMPLEMENTED_DE= VICE); diff --git a/hw/misc/aspeed_sbc.c b/hw/misc/aspeed_sbc.c index 8e192e9496..38f6d2745e 100644 --- a/hw/misc/aspeed_sbc.c +++ b/hw/misc/aspeed_sbc.c @@ -323,8 +323,10 @@ static const TypeInfo aspeed_sbc_info =3D { static void aspeed_ast2600_sbc_class_init(ObjectClass *klass, const void *= data) { DeviceClass *dc =3D DEVICE_CLASS(klass); + AspeedSBCClass *sc =3D ASPEED_SBC_CLASS(klass); =20 dc->desc =3D "AST2600 Secure Boot Controller"; + sc->has_otpmem =3D true; } =20 static const TypeInfo aspeed_ast2600_sbc_info =3D { @@ -333,9 +335,25 @@ static const TypeInfo aspeed_ast2600_sbc_info =3D { .class_init =3D aspeed_ast2600_sbc_class_init, }; =20 +static void aspeed_ast10x0_sbc_class_init(ObjectClass *klass, const void *= data) +{ + DeviceClass *dc =3D DEVICE_CLASS(klass); + AspeedSBCClass *sc =3D ASPEED_SBC_CLASS(klass); + + dc->desc =3D "AST10X0 Secure Boot Controller"; + sc->has_otpmem =3D true; +} + +static const TypeInfo aspeed_ast10x0_sbc_info =3D { + .name =3D TYPE_ASPEED_AST10X0_SBC, + .parent =3D TYPE_ASPEED_SBC, + .class_init =3D aspeed_ast10x0_sbc_class_init, +}; + static void aspeed_sbc_register_types(void) { type_register_static(&aspeed_ast2600_sbc_info); + type_register_static(&aspeed_ast10x0_sbc_info); type_register_static(&aspeed_sbc_info); } =20 diff --git a/include/hw/misc/aspeed_sbc.h b/include/hw/misc/aspeed_sbc.h index 858e82861b..34ee949fad 100644 --- a/include/hw/misc/aspeed_sbc.h +++ b/include/hw/misc/aspeed_sbc.h @@ -14,6 +14,7 @@ =20 #define TYPE_ASPEED_SBC "aspeed.sbc" #define TYPE_ASPEED_AST2600_SBC TYPE_ASPEED_SBC "-ast2600" +#define TYPE_ASPEED_AST10X0_SBC TYPE_ASPEED_SBC "-ast10X0" OBJECT_DECLARE_TYPE(AspeedSBCState, AspeedSBCClass, ASPEED_SBC) =20 #define ASPEED_SBC_NR_REGS (0x93c >> 2) --=20 2.43.0