From nobody Mon Feb 9 09:47:52 2026 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=suse.com ARC-Seal: i=1; a=rsa-sha256; t=1750282611; cv=none; d=zohomail.com; s=zohoarc; b=nr/2dYdC3n28g1iS6QHcqXw+9pzBN1wiDSOiEd0V5ismCOsrzdvj/60pKv0mTau6EuM6M/YfIM+lMowLAgpktxu6gdc3IRNgX4bjvQzNSu2Ja9+ekEeYvDyw8d9G+BvqgvUIMx9PKltvytQZJbWMF8dRlJz4d7fkZUFXvgy2S54= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1750282611; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=/dtP/wPX6YaIMdCs/d+V0dG8onDo592JRn8CaOwFdRE=; b=ZzY7aN7ayQ0n4hYNaxeEK+AgGR+aC9ybUTB1C/kBkAQM+O8r2EZ00LfzuAzPixRv+WCubkm+NOGS/KiPbC9QKg0RlxQNEkdbDzeXSzKgFpzJZlOeL92NmMziZ1kKzvcHq+01USNwHsjEz+CtHfbPwem+eiMJefi02cI+HyMO+cc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1750282611766565.5987798278308; Wed, 18 Jun 2025 14:36:51 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uS0Rl-00078o-0Q; Wed, 18 Jun 2025 17:35:53 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uS0Rj-00078S-RF for qemu-devel@nongnu.org; Wed, 18 Jun 2025 17:35:51 -0400 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uS0Rh-0002Kh-CQ for qemu-devel@nongnu.org; Wed, 18 Jun 2025 17:35:51 -0400 Received: by mail-wm1-x342.google.com with SMTP id 5b1f17b1804b1-450cf0120cdso807445e9.2 for ; Wed, 18 Jun 2025 14:35:48 -0700 (PDT) Received: from localhost ([2a02:587:4b09:8700:f50f:b7ef:31a4:1163]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-4535e982dd5sm8296275e9.12.2025.06.18.14.35.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 Jun 2025 14:35:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1750282547; x=1750887347; darn=nongnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=/dtP/wPX6YaIMdCs/d+V0dG8onDo592JRn8CaOwFdRE=; b=LjMf07mnQkC0mpTQaYo5e5GHSrQsNi3jg9CaahrMpSlzvtB4gCXGPj8NqKOhwEWIsb eucmj729rmJQ0Awf0N/rdffIe7NpWpPm0rMO87Sw2ZMjOlxGWdfuL2Owty8Rwhe7Ycts 4WXFIpVA186O5MXdEiuYxpY2SQomMo6no6nsCm7q7ZWslBIwpomxqbXEvrbaYuADqkzj 60EjHjm8ildyUIbwJbLocvWppN85vXaIyw9TK4vgEr6vp0OnL8KqfrV+MJJmLXZfJiZ6 brLcZaJ0Ak/GsnUkxqfFoHuBoavHrZ5ET2Ol8nCgM1eo6liFF26crmzgyeY4XLdZAlNP EVew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750282547; x=1750887347; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=/dtP/wPX6YaIMdCs/d+V0dG8onDo592JRn8CaOwFdRE=; b=QmcUbNT2vI+idKq6FsJn8oTIThRTQmkN95+rueiN/Lnz4zdyley8ZqDv06KhpCj+H7 OAX5H7+ZI0fHgkxvw/2Z8iqKniMDfQnDNWHPrIzCTo/jYrxv541blNTQHY+mWlomasZN ElEyZtxqCQDdu36KJK/Am53/SoORHUZ2LmHSYcQQsLdlr0v/ldFkOVS8Gxd1nmCTPlbj 0MVYStfc/lPIclZ8TcYyOIPvfggmde8T207vQCvOfKBJOn3L0Iew410ms9bXrTzFeaMK IZte04vBphhalt4rgvI0QCOHS42gAYkMi3sG78WA2Jft5qorFTiBicue0RzEUY94irDw Hs0A== X-Gm-Message-State: AOJu0YyYjGagmF6o6UC8TTXKTTtfdTWihHv96KGFqg5YvAwz2ShU156t bqjLGZIjgc1AUa32XjkMK06cM/gb5BysVc+100gv/HLkx+i6rwPyhQqW+/h289IGzR9/QDBWow8 mVNUVew6xKw== X-Gm-Gg: ASbGncvoMzixCjwkG9TexuPH5DFEszvrBfXjW7SoReYkP0QVqNCYpV2H+YtqU7OIlwR 5VhTTtCyiIP9D2kKCw04979KJCe/4uL140907vCu2iZtH0MDs7FWN+susHchztp2/vQ4Xq+kMtH XPugyA+9D5Cl2orTsqi1Bv0tVfCi727m2ZBl86e/FSpVPRFOXkUdV7/DQ+KAV4XecmbK9Cscf/n ZdJ4wFNGmyDWgRE5JevEXdt6USQlJsyj8/wAw4/rNBAKHOCDHnF865tspreW0iMcGzI74+W6ud8 69G6Kvb6s41gR8s9k7F5r06C+lQREOFwSdGITitShk3UvgVn70WQ5OAGt4CM0IU= X-Google-Smtp-Source: AGHT+IHfH0POiYdvqSbXnwEmTQeAnbr0JF1o2eOxl1YFcuUpQBicPPFXHBAyv3Lk1ylYejIBYr7GYA== X-Received: by 2002:a05:600c:1d06:b0:450:c20d:64c3 with SMTP id 5b1f17b1804b1-4533caad17fmr184569945e9.18.1750282547173; Wed, 18 Jun 2025 14:35:47 -0700 (PDT) From: Vasilis Liaskovitis To: qemu-devel@nongnu.org, qemu-riscv@nongnu.org Cc: dbarboza@ventanamicro.com, ajones@ventanamicro.com, alistair.francis@wdc.com, philmd@linaro.org, Vasilis Liaskovitis Subject: [PATCH v2] target/riscv: Add a property to set vill bit on reserved usage of vsetvli instruction Date: Wed, 18 Jun 2025 23:35:42 +0200 Message-ID: <20250618213542.22873-1-vliaskovitis@suse.com> X-Mailer: git-send-email 2.46.0 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::342; envelope-from=vliaskovitis@suse.com; helo=mail-wm1-x342.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @suse.com) X-ZM-MESSAGEID: 1750282614271116600 Content-Type: text/plain; charset="utf-8" Usage of vsetvli instruction is reserved if VLMAX is changed when vsetvli r= s1 and rd arguments are x0. In this case, if the new property is true, only the vill bit will be set. See https://github.com/riscv/riscv-isa-manual/blob/main/src/v-st-ext.adoc#a= vl-encoding According to the spec, the above use cases are reserved, and "Implementations may set vill in either case." Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2422 Signed-off-by: Vasilis Liaskovitis Reviewed-by: Daniel Henrique Barboza --- target/riscv/cpu.c | 1 + target/riscv/cpu_cfg_fields.h.inc | 1 + target/riscv/helper.h | 2 +- target/riscv/insn_trans/trans_rvv.c.inc | 4 ++-- target/riscv/vector_helper.c | 12 +++++++++++- 5 files changed, 16 insertions(+), 4 deletions(-) diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c index 629ac37501..1c29ed3b2b 100644 --- a/target/riscv/cpu.c +++ b/target/riscv/cpu.c @@ -2595,6 +2595,7 @@ static const Property riscv_cpu_properties[] =3D { DEFINE_PROP_BOOL("rvv_ta_all_1s", RISCVCPU, cfg.rvv_ta_all_1s, false), DEFINE_PROP_BOOL("rvv_ma_all_1s", RISCVCPU, cfg.rvv_ma_all_1s, false), DEFINE_PROP_BOOL("rvv_vl_half_avl", RISCVCPU, cfg.rvv_vl_half_avl, fal= se), + DEFINE_PROP_BOOL("rvv_vsetvl_x0_vill", RISCVCPU, cfg.rvv_vsetvl_x0_vil= l, false), =20 /* * write_misa() is marked as experimental for now so mark diff --git a/target/riscv/cpu_cfg_fields.h.inc b/target/riscv/cpu_cfg_field= s.h.inc index 59f134a419..9c78a797cf 100644 --- a/target/riscv/cpu_cfg_fields.h.inc +++ b/target/riscv/cpu_cfg_fields.h.inc @@ -114,6 +114,7 @@ BOOL_FIELD(ext_supm) BOOL_FIELD(rvv_ta_all_1s) BOOL_FIELD(rvv_ma_all_1s) BOOL_FIELD(rvv_vl_half_avl) +BOOL_FIELD(rvv_vsetvl_x0_vill) /* Named features */ BOOL_FIELD(ext_svade) BOOL_FIELD(ext_zic64b) diff --git a/target/riscv/helper.h b/target/riscv/helper.h index 85d73e492d..f712b1c368 100644 --- a/target/riscv/helper.h +++ b/target/riscv/helper.h @@ -159,7 +159,7 @@ DEF_HELPER_FLAGS_3(hyp_hsv_d, TCG_CALL_NO_WG, void, env= , tl, tl) #endif =20 /* Vector functions */ -DEF_HELPER_3(vsetvl, tl, env, tl, tl) +DEF_HELPER_4(vsetvl, tl, env, tl, tl, tl) DEF_HELPER_5(vle8_v, void, ptr, ptr, tl, env, i32) DEF_HELPER_5(vle16_v, void, ptr, ptr, tl, env, i32) DEF_HELPER_5(vle32_v, void, ptr, ptr, tl, env, i32) diff --git a/target/riscv/insn_trans/trans_rvv.c.inc b/target/riscv/insn_tr= ans/trans_rvv.c.inc index 2b6077ac06..87071c5d62 100644 --- a/target/riscv/insn_trans/trans_rvv.c.inc +++ b/target/riscv/insn_trans/trans_rvv.c.inc @@ -202,7 +202,7 @@ static bool do_vsetvl(DisasContext *s, int rd, int rs1,= TCGv s2) s1 =3D get_gpr(s, rs1, EXT_ZERO); } =20 - gen_helper_vsetvl(dst, tcg_env, s1, s2); + gen_helper_vsetvl(dst, tcg_env, s1, s2, tcg_constant_tl((int) (rd =3D= =3D 0 && rs1 =3D=3D 0))); gen_set_gpr(s, rd, dst); finalize_rvv_inst(s); =20 @@ -222,7 +222,7 @@ static bool do_vsetivli(DisasContext *s, int rd, TCGv s= 1, TCGv s2) =20 dst =3D dest_gpr(s, rd); =20 - gen_helper_vsetvl(dst, tcg_env, s1, s2); + gen_helper_vsetvl(dst, tcg_env, s1, s2, tcg_constant_tl(0)); gen_set_gpr(s, rd, dst); finalize_rvv_inst(s); gen_update_pc(s, s->cur_insn_len); diff --git a/target/riscv/vector_helper.c b/target/riscv/vector_helper.c index 5dc1c10012..b41c29da0b 100644 --- a/target/riscv/vector_helper.c +++ b/target/riscv/vector_helper.c @@ -35,7 +35,7 @@ #include =20 target_ulong HELPER(vsetvl)(CPURISCVState *env, target_ulong s1, - target_ulong s2) + target_ulong s2, target_ulong x0) { int vlmax, vl; RISCVCPU *cpu =3D env_archcpu(env); @@ -83,6 +83,16 @@ target_ulong HELPER(vsetvl)(CPURISCVState *env, target_u= long s1, } else { vl =3D vlmax; } + + if (cpu->cfg.rvv_vsetvl_x0_vill && x0 && (env->vl !=3D vl)) { + /* only set vill bit. */ + env->vill =3D 1; + env->vtype =3D 0; + env->vl =3D 0; + env->vstart =3D 0; + return 0; + } + env->vl =3D vl; env->vtype =3D s2; env->vstart =3D 0; --=20 2.46.0