From nobody Sat Nov 15 09:29:11 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1750185457; cv=none; d=zohomail.com; s=zohoarc; b=erkrd+RRFcRmfA1edZFbhZh2tMHbdjGPXmw0ihF0eUmFtgq4WRXbmzwoJr+UJYNAAgmNGQpwgPiEcMgZWAjv935HwBMXAt4bvfAlqbi1ZxpfyjiaDr9c0FOL8MDevxC61Pu+l+5AcDN6ijvIL1EmTZZ3Pbu4GuAFMXb0+Gyop4Y= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1750185457; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=oSeq3zKyvNEH98Ef19TGp9ugIdv9/k6rVRDQBz3u+ao=; b=dKcyaooFPe8aS8rIBB52F06ZVj34L1MFCCOoEu+je8iqQeREDxAydS7BHcLNuUrJKieuKChtjloZsa9/Yft8IKm/bgfJnlrfVrLfXkOZi6shdGIVXtUxkJgamw/6Hjxu1lz8X1g8i0wAzgOwlntx7B3XNDe0Eg31oW8b7J3e43k= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1750185457137195.6367279584889; Tue, 17 Jun 2025 11:37:37 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uRbB0-00081I-GD; Tue, 17 Jun 2025 14:36:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uRbAy-00080r-9o for qemu-devel@nongnu.org; Tue, 17 Jun 2025 14:36:52 -0400 Received: from mail-pl1-x629.google.com ([2607:f8b0:4864:20::629]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uRbAw-0006Qj-MM for qemu-devel@nongnu.org; Tue, 17 Jun 2025 14:36:52 -0400 Received: by mail-pl1-x629.google.com with SMTP id d9443c01a7336-23633a6ac50so88203615ad.2 for ; Tue, 17 Jun 2025 11:36:49 -0700 (PDT) Received: from ubuntu.. ([49.207.59.144]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2365de78565sm83584295ad.124.2025.06.17.11.36.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Jun 2025 11:36:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1750185408; x=1750790208; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=oSeq3zKyvNEH98Ef19TGp9ugIdv9/k6rVRDQBz3u+ao=; b=RPIy4a7Bgac1RbNH2MXWwGDbYQJ+5VP7uJ13EoZkIOIFVRKpgOyqKHG3oLhYJZx+Dy j5F02ZgMHhu3jpcyfEviRATl6/M6R6XKv1IfyH37sbzBAFBVIm0JCvv8Bq0A3XScu/PO nEEf1XJCmQ0oIQ8SQup3azdVwg9QwfvuaCPbhdqYphBucn5riCXeKix4UEyLK5SpyiDd Rbw3QYjgtOUbmikhiIbTSOriHkNNO+ZkVgWbqxuwlgQoUfMpvjrVVoEmRr1ZupgiupUN LKBeGMLfZqJQRXLwarvKgm7LEiRQ61xGuuSmmiq8v5+ECVVC3etgpb1DlGTaqOkwyRqt CnqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750185408; x=1750790208; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=oSeq3zKyvNEH98Ef19TGp9ugIdv9/k6rVRDQBz3u+ao=; b=US9H96NiabQfODys5uq/PmlzR5RBpE7OAiF+mSaMZb8358uZniyoaWRPyZCJuCI+/N vVyXEnF73d3wMeyXrLWZk0HO3P9vzfQQrwFF6G/FZ+N2Djb7nD294vj5AGPJ7GTj1kLz QVgUKEmAFtxvY+/ejIU7FuffVoP1yMqJ+K7CPu5bi5x1BlxeSxn76AGcX8RpQO9imNEn l5DM0J33tHlVkYtIsNEuD1RhMbCt0EOjzI72rFVjWxHlFMxj4ZXndwoEIKcL7MXLHl0l SRfDT3B9rv5Jy7e8B9M4I8AOqoT7ywPY6K9flb9MUZvGG3cTSMRXA28BxwpW0LzpuuTT t3wQ== X-Gm-Message-State: AOJu0YzGRvXXOG2aA9jOkmaFla45dDn2wImlFNInRVYuQGdh0kmZ+lBt uVd4Pd/KTEpx3DomsXSvrL/675f9Hr+tXHHcm7lcpARy2fDmxwzkMakIkr8WHJ+O3s8ovA== X-Gm-Gg: ASbGncsZ7wnIfMKkKAf8Gv5Ad8ydj3HGUSssiH8Q0s0cXocBcXgZdthQeQSuaqZqz+R jc1Mk3D1x/XZuq3jOiUuYEHbhcS5wjoq2Av4rd16BXqe1zCawIf9n14+HEbGnFn4zDgCi/sYnze 4ogy27tofmbOk3LXvuDSuMP7CGKgdH9rxzbWuu7EQfdI7FNYHw7cAEEXdlPPdoj/Dh6v0gkpyw1 tGaXLaVllMu6bdtJnPyqFezlXIM9hhoSxVSoo3HKIWgfRE4hHK+2OIHQ/fSZnJHaYVis+7WNNn9 GHlFWPbOYpnCXT6YdGs7ZWZh5sTU78PDoCUvHhkkHZHHoHGEyJYaExDcAP9maW+CVPRymThU X-Google-Smtp-Source: AGHT+IH5naVHOtCGNaWkBPJNIa7tBveQWc4NTRX5A1oXQk8YygQe+HIM1Mg/oCRFL8kZzRg2PFnYAA== X-Received: by 2002:a17:902:dacf:b0:235:f1e4:3383 with SMTP id d9443c01a7336-2366b337fddmr180100125ad.7.1750185407932; Tue, 17 Jun 2025 11:36:47 -0700 (PDT) From: Tanish Desai To: qemu-devel@nongnu.org Cc: pbonzini@redhat.com, mads@ynddal.dk, stefanha@redhat.com, Tanish Desai Subject: [PATCH v2] tracetool: removed the unused vcpu property Date: Tue, 17 Jun 2025 18:36:19 +0000 Message-Id: <20250617183619.13581-1-tanishdesai37@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250617140725.GA117267@fedora> References: <20250617140725.GA117267@fedora> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::629; envelope-from=tanishdesai37@gmail.com; helo=mail-pl1-x629.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1750185458988116600 Content-Type: text/plain; charset="utf-8" The vcpu property is no longer used in these backends. Removing it avoids unnecessary checks and simplifies the code generation for these trace backe= nds. Signed-off-by: Tanish Desai --- scripts/tracetool/__init__.py | 6 +++--- scripts/tracetool/backend/log.py | 6 +----- scripts/tracetool/backend/simple.py | 6 +----- scripts/tracetool/backend/syslog.py | 6 +----- 4 files changed, 6 insertions(+), 18 deletions(-) diff --git a/scripts/tracetool/__init__.py b/scripts/tracetool/__init__.py index bc03238c0f..e86c898a1e 100644 --- a/scripts/tracetool/__init__.py +++ b/scripts/tracetool/__init__.py @@ -216,9 +216,9 @@ class Event(object): r"\s*" r"(?:(?:(?P\".+),)?\s*(?P\".+))?" r"\s*") - - _VALID_PROPS =3D set(["disable", "vcpu"]) - + =20 + _VALID_PROPS =3D set(["disable"]) + =20 def __init__(self, name, props, fmt, args, lineno, filename, orig=3DNo= ne, event_trans=3DNone, event_exec=3DNone): """ diff --git a/scripts/tracetool/backend/log.py b/scripts/tracetool/backend/l= og.py index de27b7e62e..f24acad74c 100644 --- a/scripts/tracetool/backend/log.py +++ b/scripts/tracetool/backend/log.py @@ -31,11 +31,7 @@ def generate_h(event, group): if len(event.args) > 0: argnames =3D ", " + argnames =20 - if "vcpu" in event.properties: - # already checked on the generic format code - cond =3D "true" - else: - cond =3D "trace_event_get_state(%s)" % ("TRACE_" + event.name.uppe= r()) + cond =3D "trace_event_get_state(%s)" % ("TRACE_" + event.name.upper()) =20 out(' if (%(cond)s && qemu_loglevel_mask(LOG_TRACE)) {', ' if (message_with_timestamp) {', diff --git a/scripts/tracetool/backend/simple.py b/scripts/tracetool/backen= d/simple.py index 2688d4b64b..7c84c06b20 100644 --- a/scripts/tracetool/backend/simple.py +++ b/scripts/tracetool/backend/simple.py @@ -37,11 +37,7 @@ def generate_h_begin(events, group): =20 def generate_h(event, group): event_id =3D 'TRACE_' + event.name.upper() - if "vcpu" in event.properties: - # already checked on the generic format code - cond =3D "true" - else: - cond =3D "trace_event_get_state(%s)" % event_id + cond =3D "trace_event_get_state(%s)" % event_id out(' if (%(cond)s) {', ' _simple_%(api)s(%(args)s);', ' }', diff --git a/scripts/tracetool/backend/syslog.py b/scripts/tracetool/backen= d/syslog.py index 012970f6cc..6fdc1142fb 100644 --- a/scripts/tracetool/backend/syslog.py +++ b/scripts/tracetool/backend/syslog.py @@ -30,11 +30,7 @@ def generate_h(event, group): if len(event.args) > 0: argnames =3D ", " + argnames =20 - if "vcpu" in event.properties: - # already checked on the generic format code - cond =3D "true" - else: - cond =3D "trace_event_get_state(%s)" % ("TRACE_" + event.name.uppe= r()) + cond =3D "trace_event_get_state(%s)" % ("TRACE_" + event.name.upper()) =20 out(' if (%(cond)s) {', '#line %(event_lineno)d "%(event_filename)s"', --=20 2.34.1