From nobody Sat Nov 15 16:43:22 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1750178082; cv=none; d=zohomail.com; s=zohoarc; b=mRSoZ1Q3Iyrdvy6mrZhZy+BGqkfiBL5Z2m1Ur8bCrpLHc/Ddo9iLmC9g0Kcc87p2+N/rdRCRnFTJ17a2BC5ByCTz9wbtxUVd6jUTMKK4iITGJZiJG1cksbcbcZZsVQ4lB1PHZtTUuqUO5oISK/mLkoDhWdLIfXgLd/3sN139HNM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1750178082; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=/pVLW980tQUeFMbPOSrmbCV35FWVqLGwZwmiSRkT/nc=; b=XYmcV1rtEFhI0Am7oxB92Sktz0raMP2i3OMmVzmbbOQhoUGgHjq76d/qd/0Nmemj6X4El5il2/Yl/hYs8TXlmMzMBgoZXerm/+YOKvoyAdzENVyWPFt7Lsj947QKtjcSJ693CW9vYy1irBhAmZjj5aSp8H3mK4xQouWhf1DbZP4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1750178082473390.9787158831343; Tue, 17 Jun 2025 09:34:42 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uRZGQ-0000mc-LR; Tue, 17 Jun 2025 12:34:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uRZG2-0000kn-S4 for qemu-devel@nongnu.org; Tue, 17 Jun 2025 12:33:58 -0400 Received: from mail-wm1-x329.google.com ([2a00:1450:4864:20::329]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uRZFz-0000cf-Lk for qemu-devel@nongnu.org; Tue, 17 Jun 2025 12:33:58 -0400 Received: by mail-wm1-x329.google.com with SMTP id 5b1f17b1804b1-45348bff79fso32505855e9.2 for ; Tue, 17 Jun 2025 09:33:55 -0700 (PDT) Received: from draig.lan ([185.126.160.19]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4532e268de2sm181468295e9.40.2025.06.17.09.33.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Jun 2025 09:33:52 -0700 (PDT) Received: from draig.lan (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id 15EEF5F873; Tue, 17 Jun 2025 17:33:52 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1750178034; x=1750782834; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/pVLW980tQUeFMbPOSrmbCV35FWVqLGwZwmiSRkT/nc=; b=AARro+sgTKnFkmA/pCZGdxHsKke7t5ORNlCD7/asYUSrNRTBhhUfHvudVVNoqG8kkQ taO7FDKy+1F3xYzgT5HioSBnmujf5apUsup6Dd4x5aGgLxQdUmmZXcnTmkuiDHSvVfP/ 8VBeIaoNoiETopcMaXNKb/lTKNwzJ11egYrA7P5kyZy1ZYxM5f/r7xw/KWCA86XCchtm BtUJxx9nhQ6TQN+/VW3fYby0SoVzHZElzqbn9YPXrzFWidViKSmjswqgJEtKEKRILdrY shYahkoVtiLYlF0rE7B6bFD0YE8EgqqSzrE2WNVIDYY08UiGIBFAzXT3gc7Cr/k2buYL 3s+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750178034; x=1750782834; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/pVLW980tQUeFMbPOSrmbCV35FWVqLGwZwmiSRkT/nc=; b=ajkONnWGGWWScgyalrRD+lETQtPPKEG9GWg1CeM/qeva5PFeQ1xqmb/Lpzu/ImaasO 6gF6Pgd+qJDcB8+wHERLigH2Mev9DR5IYLbdEkkvUVEaJ3kE0cbrgbIve59eJjxPlP64 zBrSJRvoMtx3eMPehkETnxGIB8SN3evhxvxA/HCvgMMx+Zq0/Uk1xMXlMzMQXr/7Nl9u dD953cKg6BouhD6W+zQYLnDl8JZRxTv64KAFIAagO8MrDMqEK3gtQcGVsVQ60/niGZ8T 8Y53M+GkThe5BM5xps7Y46aUnj3913vgFYDsEiDbjhnWzsA2tWSUNozhDmLGnEY1OWlk Mulg== X-Gm-Message-State: AOJu0Yz1F2NKSiktWSNbGrhwLz7nmb5UzUmmLJneUcTHZvbkYUCcVN3I Ebs1v34D8pS/ouy92JAR4CSUh4bhXvtDEA1HnHsNMNQkWqYwJODsGr7aDN/f25okK4Y= X-Gm-Gg: ASbGncvLmj8zzCKb16xIPFq54Df34FJXx9Jjul3gRHwYy64m6bHmLZ4P/lk47ucvClu YCB16NflaLXh2QKux3wzegPIkVm1uRLR/30Ir+48Oi4JbHVW+0KD777fJ2uwUYzJ2MsdI3BkeDk MUgTump5GmFSsBi3eNBv0eYqJf2N19ma2cg/AmPLU3upLRfUXE8EV/ya1/AP4AXfa8k5K/8E8J6 avEb10AmaNrliUL6Te60lpaLb3axD9RUGQ61xmbqgYOhBHeIDOvlL6w4idlddU8ZzvDcZxs8MNL JVCQHIzWEqs3WELwwn9XpSs5Nld9iabUCcSGH0R0uXHnIEFuaEzgUiUtMsu8lWs= X-Google-Smtp-Source: AGHT+IE8v8HeR2piaWlFX6bbvfHCxqXZXhONIJkvHNHlEOHHSq+0M0P/3+bbuJRt/SWwiA7WH7QLGg== X-Received: by 2002:a05:600c:8286:b0:450:cfe1:a827 with SMTP id 5b1f17b1804b1-4533cb1a7c4mr155107765e9.31.1750178033665; Tue, 17 Jun 2025 09:33:53 -0700 (PDT) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Cc: Cornelia Huck , qemu-arm@nongnu.org, Mark Burton , "Michael S. Tsirkin" , Alexander Graf , kvm@vger.kernel.org, Peter Maydell , Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , =?UTF-8?q?Alex=20Benn=C3=A9e?= Subject: [RFC PATCH 02/11] target/arm: re-arrange debug_cp_reginfo Date: Tue, 17 Jun 2025 17:33:42 +0100 Message-ID: <20250617163351.2640572-3-alex.bennee@linaro.org> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250617163351.2640572-1-alex.bennee@linaro.org> References: <20250617163351.2640572-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::329; envelope-from=alex.bennee@linaro.org; helo=mail-wm1-x329.google.com X-Spam_score_int: 12 X-Spam_score: 1.2 X-Spam_bar: + X-Spam_report: (1.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1750178084192116600 Although we are using structure initialisation the order of the op[012]/cr[nm] fields don't match the rest of the code base. Re-organise to be consistent and help the poor engineer who is grepping for system registers. Signed-off-by: Alex Benn=C3=A9e --- target/arm/debug_helper.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/target/arm/debug_helper.c b/target/arm/debug_helper.c index 69fb1d0d9f..8130ff78de 100644 --- a/target/arm/debug_helper.c +++ b/target/arm/debug_helper.c @@ -948,19 +948,21 @@ static const ARMCPRegInfo debug_cp_reginfo[] =3D { * DBGDSAR is deprecated and must RAZ from v8 anyway, so it has no AAr= ch64 * accessor. */ - { .name =3D "DBGDRAR", .cp =3D 14, .crn =3D 1, .crm =3D 0, .opc1 =3D 0= , .opc2 =3D 0, + { .name =3D "DBGDRAR", .cp =3D 14, + .opc0 =3D 0, .crn =3D 1, .crm =3D 0, .opc1 =3D 0, .opc2 =3D 0, .access =3D PL0_R, .accessfn =3D access_tdra, .type =3D ARM_CP_CONST | ARM_CP_NO_GDB, .resetvalue =3D 0 }, { .name =3D "MDRAR_EL1", .state =3D ARM_CP_STATE_AA64, - .opc0 =3D 2, .opc1 =3D 0, .crn =3D 1, .crm =3D 0, .opc2 =3D 0, + .opc0 =3D 2, .crn =3D 1, .crm =3D 0, .opc1 =3D 0, .opc2 =3D 0, .access =3D PL1_R, .accessfn =3D access_tdra, .type =3D ARM_CP_CONST, .resetvalue =3D 0 }, - { .name =3D "DBGDSAR", .cp =3D 14, .crn =3D 2, .crm =3D 0, .opc1 =3D 0= , .opc2 =3D 0, + { .name =3D "DBGDSAR", .cp =3D 14, + .opc0 =3D 0, .opc1 =3D 0, .crn =3D 2, .crm =3D 0,.opc2 =3D 0, .access =3D PL0_R, .accessfn =3D access_tdra, .type =3D ARM_CP_CONST | ARM_CP_NO_GDB, .resetvalue =3D 0 }, /* Monitor debug system control register; the 32-bit alias is DBGDSCRe= xt. */ - { .name =3D "MDSCR_EL1", .state =3D ARM_CP_STATE_BOTH, - .cp =3D 14, .opc0 =3D 2, .opc1 =3D 0, .crn =3D 0, .crm =3D 2, .opc2 = =3D 2, + { .name =3D "MDSCR_EL1", .state =3D ARM_CP_STATE_BOTH, .cp =3D 14, + .opc0 =3D 2, .opc1 =3D 0, .crn =3D 0, .crm =3D 2, .opc2 =3D 2, .access =3D PL1_RW, .accessfn =3D access_tda, .fgt =3D FGT_MDSCR_EL1, .nv2_redirect_offset =3D 0x158, --=20 2.47.2