From nobody Sat Nov 15 16:37:09 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass header.i=@intel.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1750135189; cv=none; d=zohomail.com; s=zohoarc; b=eMOe6lm1pjkcZkAt58izLlCeLYRgNnM2dagfMI7dI/tvq8VrrLWpUiTulxtvPd+YRVKMAv5nNlQTKdBKK/aZ/0gaF0XrZASgSvnWBUJH0dzvjtU9UNOj8GYXcPPF5LSdc4v7Erq0FhooofN+HK6J7VQLG4ufzcDymgoB1CpvwKM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1750135189; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=QV2wuC6BM9xdGyx+krxFNPcwmsvejwXSkBEQ/bgj89A=; b=iPBJnvAI712kPvwEQ8cKN07opJ9gTYHhDa1eE9f3CA1UoqkixrCxQdy3hAwyzj+5ACSvDu8/cpwdD1moDedBj2+G//dqiX3JReJovPJ1zYsS+BBZA4UVOyCvO4Y1h+MTz9NGwNFE+vjUEv62tcGSmva7QU3WUhxKpkOWwDsnbgg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=@intel.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1750135189184756.7456608855831; Mon, 16 Jun 2025 21:39:49 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uRO5i-0002rP-J6; Tue, 17 Jun 2025 00:38:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uRO5f-0002pk-D8 for qemu-devel@nongnu.org; Tue, 17 Jun 2025 00:38:31 -0400 Received: from mgamail.intel.com ([198.175.65.18]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uRO5d-0007ja-OY for qemu-devel@nongnu.org; Tue, 17 Jun 2025 00:38:31 -0400 Received: from orviesa008.jf.intel.com ([10.64.159.148]) by orvoesa110.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Jun 2025 21:38:24 -0700 Received: from vkasired-desk2.fm.intel.com ([10.105.128.132]) by orviesa008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Jun 2025 21:38:23 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1750135110; x=1781671110; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=N/hxLA1NKl77VClmHWfKHM7UOdeBh5dCwhVlxw8bnz8=; b=TP7l1LVvu4P60yV4il8zRaPRJhHSGoKue/qQSQ7u6P34+XM/q6CFnIEx Aav+IWtN/XTFUAXAMdpQB9u0ojenbi7/fBrUM0rkIGGwf2d9SI9DyJCgW 0HUHchNzg2fMPPiu6OwkQHfy9P8Tr9cG68+Hwa2xtdZPZgR6r/aEaQRLk vQhnVjnrlw/LUicroCPKT5jiWomq6TGzWSsLaW8m+Lzpa/Yoz6L7DtI2/ Mczw5MkGtVnLdIYTGEufXZmeOY7fCz1ahUTyfqp3MGaUkvjmXBzOSRLo/ VIgvZrbvy0cPg0+BbeVBdfypVrSkVoyZsNr016LKF4j0DM8INhkrWjSH1 g==; X-CSE-ConnectionGUID: ZzrJEi4KSpCoXeGhvYdMdw== X-CSE-MsgGUID: 8//Wg5JSSv6iec2je+oruw== X-IronPort-AV: E=McAfee;i="6800,10657,11465"; a="52432300" X-IronPort-AV: E=Sophos;i="6.16,242,1744095600"; d="scan'208";a="52432300" X-CSE-ConnectionGUID: YiGgnWO2SkW8bkYovLf+eQ== X-CSE-MsgGUID: fn5azfjfSl6lWpBzyABr7A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,242,1744095600"; d="scan'208";a="149551044" From: Vivek Kasireddy To: qemu-devel@nongnu.org Cc: Vivek Kasireddy , Gerd Hoffmann , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Dmitry Osipenko , Frediano Ziglio , Dongwon Kim , Michael Scherle , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= Subject: [PATCH v6 3/7] ui/spice: Add an option for users to provide a preferred video codec Date: Mon, 16 Jun 2025 21:32:27 -0700 Message-ID: <20250617043546.1022779-4-vivek.kasireddy@intel.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250617043546.1022779-1-vivek.kasireddy@intel.com> References: <20250617043546.1022779-1-vivek.kasireddy@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=198.175.65.18; envelope-from=vivek.kasireddy@intel.com; helo=mgamail.intel.com X-Spam_score_int: -62 X-Spam_score: -6.3 X-Spam_bar: ------ X-Spam_report: (-6.3 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.892, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @intel.com) X-ZM-MESSAGEID: 1750135189499116600 Giving users an option to choose a particular codec will enable them to make an appropriate decision based on their hardware and use-case. Note that, the Spice server would use this codec with Gstreamer encoder and only when gl=3Don is specified. If no codec is provided, then the codec gstreamer:h264 would be used as default. And, for the case where gl=3Doff, the default codec to be used is determined by the Spice server. Cc: Gerd Hoffmann Cc: Marc-Andr=C3=A9 Lureau Cc: Dmitry Osipenko Cc: Frediano Ziglio Cc: Dongwon Kim Cc: Michael Scherle Cc: Daniel P. Berrang=C3=A9 Reviewed-by: Marc-Andr=C3=A9 Lureau Signed-off-by: Vivek Kasireddy --- qemu-options.hx | 8 ++++++++ ui/spice-core.c | 15 +++++++++++++++ 2 files changed, 23 insertions(+) diff --git a/qemu-options.hx b/qemu-options.hx index 7eb8e02b4b..124c87311c 100644 --- a/qemu-options.hx +++ b/qemu-options.hx @@ -2281,6 +2281,7 @@ DEF("spice", HAS_ARG, QEMU_OPTION_spice, " [,streaming-video=3D[off|all|filter]][,disable-copy-paste=3Don= |off]\n" " [,disable-agent-file-xfer=3Don|off][,agent-mouse=3D[on|off]]\n" " [,playback-compression=3D[on|off]][,seamless-migration=3D[on|o= ff]]\n" + " [,video-codec=3D\n" " [,gl=3D[on|off]][,rendernode=3D]\n" " enable spice\n" " at least one of {port, tls-port} is mandatory\n", @@ -2369,6 +2370,13 @@ SRST ``seamless-migration=3D[on|off]`` Enable/disable spice seamless migration. Default is off. =20 + ``video-codec=3D`` + Provide the preferred codec the Spice server should use with the + Gstreamer encoder. This option is only relevant when gl=3Don is + specified. If no codec is provided, then the codec gstreamer:h264 + would be used as default. And, for the case where gl=3Doff, the + default codec to be used is determined by the Spice server. + ``gl=3D[on|off]`` Enable/disable OpenGL context. Default is off. =20 diff --git a/ui/spice-core.c b/ui/spice-core.c index 5acbdd3955..5e585ed958 100644 --- a/ui/spice-core.c +++ b/ui/spice-core.c @@ -488,6 +488,9 @@ static QemuOptsList qemu_spice_opts =3D { },{ .name =3D "streaming-video", .type =3D QEMU_OPT_STRING, + },{ + .name =3D "video-codec", + .type =3D QEMU_OPT_STRING, },{ .name =3D "agent-mouse", .type =3D QEMU_OPT_BOOL, @@ -662,6 +665,8 @@ static void qemu_spice_init(void) char *x509_key_file =3D NULL, *x509_cert_file =3D NULL, *x509_cacert_file =3D NULL; + const char *video_codec =3D NULL; + g_autofree char *enc_codec =3D NULL; int port, tls_port, addr_flags; spice_image_compression_t compression; spice_wan_compression_t wan_compr; @@ -838,6 +843,16 @@ static void qemu_spice_init(void) if ((port !=3D 0) || (tls_port !=3D 0)) { #if SPICE_SERVER_VERSION >=3D 0x000f03 /* release 0.15.3 */ spice_remote_client =3D 1; + + video_codec =3D qemu_opt_get(opts, "video-codec"); + if (video_codec) { + enc_codec =3D g_strconcat("gstreamer:", video_codec, NULL); + } + if (spice_server_set_video_codecs(spice_server, + enc_codec ?: "gstreamer:h264= ")) { + error_report("invalid video codec"); + exit(1); + } #else error_report("SPICE GL support is local-only for now and " "incompatible with -spice port/tls-port"); --=20 2.49.0