From nobody Sat Nov 15 17:08:37 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1749750657; cv=none; d=zohomail.com; s=zohoarc; b=Oz5SPsILiF9yNLzlh+665Ir9TejVgQ+o6b5UYIYMifskmj2d57RB6eGA25w3ypdt9ctW7y6dzcmqgMssOtzwmBjIabVU4LLFgtvzSqrBjSZez0f9nnn3x7nnp4OTRfnJRI7VGtwgknxvLwkYYPXbVSSKdhzhK+S9uT8nZg5o2YM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1749750657; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=6bQecbjwc79DIm5WiLI4eZ/uPMXFoQbP4oqqiq3Lujc=; b=SawSVofB27vt7nJQIE7cDRo9ziLr/YYsPwhVwuPiU9RLZCawq2nDLfPf4MoeCB+RAELkyrU3xBZGe5ZCffYgiz33+ZAvM0A6FBCj2L92x1uYeqJVRKUP9wVwcZ4nK6KVv3AsNft7xTOTeDMeF9jBmsIjuCh9JGVSwstFohqVrFk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1749750657201513.419662297928; Thu, 12 Jun 2025 10:50:57 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uPm3K-0008Q6-Bh; Thu, 12 Jun 2025 13:49:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uPm3H-0008Om-VY for qemu-devel@nongnu.org; Thu, 12 Jun 2025 13:49:24 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uPm3F-0001Lt-Am for qemu-devel@nongnu.org; Thu, 12 Jun 2025 13:49:23 -0400 Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-549-TrKyAINWPXWPRIaMqBuveQ-1; Thu, 12 Jun 2025 13:49:16 -0400 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 4EB1B1809C84; Thu, 12 Jun 2025 17:49:11 +0000 (UTC) Received: from localhost (unknown [10.2.16.98]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id E055D19560AF; Thu, 12 Jun 2025 17:49:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1749750560; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6bQecbjwc79DIm5WiLI4eZ/uPMXFoQbP4oqqiq3Lujc=; b=OO6GzQA6Lf9CepJO7Rycd+bHdDFXgGwEEeT7B3fIN7v/lgNmljzOOe6O+LKEfQEv/pgoEL CKuolpYJLBjt9K5UZsn2HiI7OaUWn2HChcZZ2WAMTS46bCVCrij6GJDsRo33vTun+xaUaj HxJbMiH/h+OPo+bUkcQ6G1OO7UsxV8w= X-MC-Unique: TrKyAINWPXWPRIaMqBuveQ-1 X-Mimecast-MFC-AGG-ID: TrKyAINWPXWPRIaMqBuveQ_1749750552 From: Stefan Hajnoczi To: qemu-devel@nongnu.org Cc: "Michael S. Tsirkin" , qemu-ppc@nongnu.org, Paolo Bonzini , Fam Zheng , Laurent Vivier , Hanna Reitz , Keith Busch , Steven Lee , qemu-arm@nongnu.org, Michael Tokarev , qemu-block@nongnu.org, Peter Maydell , Harsh Prateek Bora , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20Barrat?= , Rob Herring , Dmitry Fleytman , Jamin Lin , qemu-s390x@nongnu.org, Gerd Hoffmann , Halil Pasic , Kevin Wolf , Jason Wang , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Klaus Jensen , Jeuk Kim , "Edgar E. Iglesias" , Daniel Henrique Barboza , Stefan Hajnoczi , Nicholas Piggin , Christian Borntraeger , Andrew Jeffery , Jesper Devantier , qemu-trivial@nongnu.org, Sven Schnelle , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Troy Lee , Joel Stanley , Thomas Huth , Hannes Reinecke , Alistair Francis , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= Subject: [PULL v2 11/31] hw/audio/marvell_88w8618: skip automatic zero-init of large array Date: Thu, 12 Jun 2025 13:48:55 -0400 Message-ID: <20250612174855.238493-2-stefanha@redhat.com> In-Reply-To: <20250612174855.238493-1-stefanha@redhat.com> References: <20250612174855.238493-1-stefanha@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=stefanha@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1749750657997116600 From: Daniel P. Berrang=C3=A9 The 'mv88w8618_audio_callback' method has a 4k byte array used for copying data between the audio backend and device. Skip the automatic zero-init of this array to eliminate the performance overhead in the I/O hot path. The 'buf' array will be fully initialized when reading data from device memory. Signed-off-by: Daniel P. Berrang=C3=A9 Reviewed-by: Stefan Hajnoczi Message-id: 20250610123709.835102-12-berrange@redhat.com [Fixed hw/audio/gus in commit message --Stefan] Signed-off-by: Stefan Hajnoczi --- hw/audio/marvell_88w8618.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/audio/marvell_88w8618.c b/hw/audio/marvell_88w8618.c index 6d3ebbb0c8..c5c79d083a 100644 --- a/hw/audio/marvell_88w8618.c +++ b/hw/audio/marvell_88w8618.c @@ -66,7 +66,7 @@ static void mv88w8618_audio_callback(void *opaque, int fr= ee_out, int free_in) { mv88w8618_audio_state *s =3D opaque; int16_t *codec_buffer; - int8_t buf[4096]; + QEMU_UNINITIALIZED int8_t buf[4096]; int8_t *mem_buffer; int pos, block_size; =20 --=20 2.49.0