From nobody Sat Nov 15 17:05:50 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1749667122; cv=none; d=zohomail.com; s=zohoarc; b=TYB9XfN3BzFoKSZ36ymqFn5buVx5RbmQR+MFw46diqc3aPHnFNJyfrbaUjPeCLMw2DRJvovCu6y37yjYOcyriCyJwnX6sv6Q21oxzS1+bI8tTO9bBi0+KI7gdC3RUSN+VMoT3z6KY06HlfFIh085r6x10RbrDPn/9tG0wwuM8Qo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1749667122; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=O+7OFQBZxd+Nmat7sdVrdGixlbTcW+usn+WRWhkWZmc=; b=m0sI6heM9nWeZhCLmtNFx7kkJF+QlnoplC9LJ6RzoKi/Q/jVxdxHbk6X1VQcR0GD9cg8+EyUJmM0JD/o4Ylcle0RGEct7Ryu67m4fZyRwwwm0oeO+YNzQqoXsYN+lLcnxh26cifu300LFqvuXnMkn2XKo3TKSPwQwE9a3n+zW0g= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1749667122194444.26569704950896; Wed, 11 Jun 2025 11:38:42 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uPQB4-0003MI-KT; Wed, 11 Jun 2025 14:27:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uPQ9u-0001d3-Lt for qemu-devel@nongnu.org; Wed, 11 Jun 2025 14:26:47 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uPQ9k-0001KZ-TZ for qemu-devel@nongnu.org; Wed, 11 Jun 2025 14:26:46 -0400 Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-468-oT-YHPVcO2Os6-8OnAC1NA-1; Wed, 11 Jun 2025 14:26:25 -0400 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 220F6195608E; Wed, 11 Jun 2025 18:26:21 +0000 (UTC) Received: from localhost (unknown [10.2.16.122]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 1FA1519560AF; Wed, 11 Jun 2025 18:26:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1749666389; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=O+7OFQBZxd+Nmat7sdVrdGixlbTcW+usn+WRWhkWZmc=; b=CalUVg1mv7NBUPuv0uj+UoupDkaLTlE3Qg8vrJiO2chr/yqr01JKzlSmgYxlo8Cvvg5wf3 7ms2X5ZoCsIaAza2cJ06TXb9SvTppY5/j99BBNkbm3DQvWNmRhXjLSNdt64bSrT+XO0VC1 RFRw3ltjDVPdR11fUoq0t4Xb42xAPmE= X-MC-Unique: oT-YHPVcO2Os6-8OnAC1NA-1 X-Mimecast-MFC-AGG-ID: oT-YHPVcO2Os6-8OnAC1NA_1749666381 From: Stefan Hajnoczi To: qemu-devel@nongnu.org Cc: qemu-ppc@nongnu.org, Daniel Henrique Barboza , qemu-block@nongnu.org, Jesper Devantier , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Peter Maydell , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Harsh Prateek Bora , Troy Lee , Paolo Bonzini , Hanna Reitz , qemu-s390x@nongnu.org, Halil Pasic , Kevin Wolf , "Michael S. Tsirkin" , qemu-trivial@nongnu.org, Dmitry Fleytman , Jason Wang , Keith Busch , Nicholas Piggin , =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20Barrat?= , Fam Zheng , Sven Schnelle , Stefan Hajnoczi , Joel Stanley , Gerd Hoffmann , "Edgar E. Iglesias" , qemu-arm@nongnu.org, Hannes Reinecke , Klaus Jensen , Jeuk Kim , Andrew Jeffery , Alistair Francis , Thomas Huth , Michael Tokarev , Laurent Vivier , Rob Herring , Steven Lee , Jamin Lin , Christian Borntraeger , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= Subject: [PULL 08/31] hw/audio/cs4231a: skip automatic zero-init of large arrays Date: Wed, 11 Jun 2025 14:25:10 -0400 Message-ID: <20250611182533.200590-9-stefanha@redhat.com> In-Reply-To: <20250611182533.200590-1-stefanha@redhat.com> References: <20250611182533.200590-1-stefanha@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=stefanha@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1749667122800116600 From: Daniel P. Berrang=C3=A9 The 'cs_write_audio' method has a pair of byte arrays, one 4k in size and one 8k, which are used in converting audio samples. Skip the automatic zero-init of these arrays to eliminate the performance overhead in the I/O hot path. The 'tmpbuf' array will be fully initialized when reading a block of data from the guest. The 'linbuf' array will be fully initialized when converting the audio samples. Signed-off-by: Daniel P. Berrang=C3=A9 Reviewed-by: Stefan Hajnoczi Message-id: 20250610123709.835102-9-berrange@redhat.com Signed-off-by: Stefan Hajnoczi --- hw/audio/cs4231a.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/audio/cs4231a.c b/hw/audio/cs4231a.c index eb9a45805b..6dfff202ff 100644 --- a/hw/audio/cs4231a.c +++ b/hw/audio/cs4231a.c @@ -528,7 +528,7 @@ static int cs_write_audio (CSState *s, int nchan, int d= ma_pos, int dma_len, int len) { int temp, net; - uint8_t tmpbuf[4096]; + QEMU_UNINITIALIZED uint8_t tmpbuf[4096]; IsaDmaClass *k =3D ISADMA_GET_CLASS(s->isa_dma); =20 temp =3D len; @@ -547,7 +547,7 @@ static int cs_write_audio (CSState *s, int nchan, int d= ma_pos, copied =3D k->read_memory(s->isa_dma, nchan, tmpbuf, dma_pos, to_c= opy); if (s->tab) { int i; - int16_t linbuf[4096]; + QEMU_UNINITIALIZED int16_t linbuf[4096]; =20 for (i =3D 0; i < copied; ++i) linbuf[i] =3D s->tab[tmpbuf[i]]; --=20 2.49.0