From nobody Sat Nov 15 17:06:28 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1749666572; cv=none; d=zohomail.com; s=zohoarc; b=L22+1H52CJcX3yIp3ZGtz5G+eMBOZieIzFvuztZjkO2Ko0Tawwy06avy2APqZp7GPKa0TAttz+RkaH4ea/xrAPIMN3Ww3QtVs7/1Wd8d/OBtWQN+dA9tpC80nlyJw3SxGUqWXjrDklCOT61R2CWmwbE3QvAMAK9/fmXidH/c+Wk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1749666572; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=EY31iwe6lMrC3heUYVrnbfnuVcc4xslPfJSpEvuNg6o=; b=PSd0569XV8wGbwWQaATz28K3X/Ch8bgR7KDCzmZuL4u1Opqk/qlzZamxiaIYgWYnQE6A3AR3gAnW2kguYU6Cjne7CGIWP71fVnlMrAg0uhAtyzpIOH7YsytRnnVvBHezOLWKJvNHukFBmqtllzVye21r57U39ofjyoKhQ5P18dI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1749666572757170.60729932256697; Wed, 11 Jun 2025 11:29:32 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uPQBY-0004h9-Dx; Wed, 11 Jun 2025 14:28:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uPQAJ-0001xi-RY for qemu-devel@nongnu.org; Wed, 11 Jun 2025 14:27:13 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uPQA7-0001YG-E8 for qemu-devel@nongnu.org; Wed, 11 Jun 2025 14:27:04 -0400 Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-130-xO02etT5ORmRJ79kOiamwA-1; Wed, 11 Jun 2025 14:26:54 -0400 Received: from mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.40]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id A72D11809C80; Wed, 11 Jun 2025 18:26:48 +0000 (UTC) Received: from localhost (unknown [10.2.16.122]) by mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id D1F1519560A3; Wed, 11 Jun 2025 18:26:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1749666418; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EY31iwe6lMrC3heUYVrnbfnuVcc4xslPfJSpEvuNg6o=; b=jEz/gnry+R3Sv0GgBelmlVEaZnKP72gGEsrt1SjTZ/mLJO9uCgGogaD1h4q0N0fUX7S8zQ XqsgH+LEv6+LUSug7TyXS2/oE3YZR52UDHaR9obNC1GnYHcxRaYAJ+KD06wRMmbid702iR hIPQbmCZFsG3zu7/2hx0jLxRDmN37HU= X-MC-Unique: xO02etT5ORmRJ79kOiamwA-1 X-Mimecast-MFC-AGG-ID: xO02etT5ORmRJ79kOiamwA_1749666408 From: Stefan Hajnoczi To: qemu-devel@nongnu.org Cc: qemu-ppc@nongnu.org, Daniel Henrique Barboza , qemu-block@nongnu.org, Jesper Devantier , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Peter Maydell , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Harsh Prateek Bora , Troy Lee , Paolo Bonzini , Hanna Reitz , qemu-s390x@nongnu.org, Halil Pasic , Kevin Wolf , "Michael S. Tsirkin" , qemu-trivial@nongnu.org, Dmitry Fleytman , Jason Wang , Keith Busch , Nicholas Piggin , =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20Barrat?= , Fam Zheng , Sven Schnelle , Stefan Hajnoczi , Joel Stanley , Gerd Hoffmann , "Edgar E. Iglesias" , qemu-arm@nongnu.org, Hannes Reinecke , Klaus Jensen , Jeuk Kim , Andrew Jeffery , Alistair Francis , Thomas Huth , Michael Tokarev , Laurent Vivier , Rob Herring , Steven Lee , Jamin Lin , Christian Borntraeger , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= Subject: [PULL 16/31] hw/display/vmware_vga: skip automatic zero-init of large struct Date: Wed, 11 Jun 2025 14:25:18 -0400 Message-ID: <20250611182533.200590-17-stefanha@redhat.com> In-Reply-To: <20250611182533.200590-1-stefanha@redhat.com> References: <20250611182533.200590-1-stefanha@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.0 on 10.30.177.40 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.133.124; envelope-from=stefanha@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1749666573695116600 From: Daniel P. Berrang=C3=A9 The 'vmsvga_fifo_run' method has a struct which is a little over 20k in size, used for holding image data for cursor changes. Skip the automatic zero-init of this struct to eliminate the performance overhead in the I/O hot path. The cursor variable will be fully initialized only when processing a cursor definition message from the guest. Signed-off-by: Daniel P. Berrang=C3=A9 Reviewed-by: Stefan Hajnoczi Message-id: 20250610123709.835102-17-berrange@redhat.com Signed-off-by: Stefan Hajnoczi --- hw/display/vmware_vga.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/display/vmware_vga.c b/hw/display/vmware_vga.c index 544bb65320..bc1a8ed466 100644 --- a/hw/display/vmware_vga.c +++ b/hw/display/vmware_vga.c @@ -618,7 +618,7 @@ static void vmsvga_fifo_run(struct vmsvga_state_s *s) uint32_t cmd, colour; int args, len, maxloop =3D 1024; int x, y, dx, dy, width, height; - struct vmsvga_cursor_definition_s cursor; + QEMU_UNINITIALIZED struct vmsvga_cursor_definition_s cursor; uint32_t cmd_start; =20 len =3D vmsvga_fifo_length(s); --=20 2.49.0