From nobody Sat Nov 15 17:43:58 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=quarantine dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1749654538; cv=none; d=zohomail.com; s=zohoarc; b=VzMPDfkaMVKhBFwKfN00sLl6jRFodst/G6wl/GzZtpbpO4chMUF7EzX8rtcCw+948f1+Mpf4KkPK2UitSgjrJSNWGlv1Wg+cyYjkY76JaQvdvEJ6ZKO8ckogZVVHqDKWp+RIgykyF8uJ8g3eam3dp1VmYEOXxpk+reiqbxQt/0I= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1749654538; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=IGUijn8OwNTfwcOPRbjli+qIh22n9IlcqzOHh08EtHM=; b=oBV9e87J3wQpMHtNFAVWER1ggi0Dave8+xFfeuPK6xHrlaH/n0WBLRl4yjc0+ekJhDE5CRgqBIZRke/qLeRG2E6/w6QndEnJsj9bVkgFQeNBpmZXBoC/ZmR8IBb8VlEMHArAAlRzP2wbjbTElbK0Y1jtM2FyUnbbEeBJpOwijEU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=quarantine dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1749654538894800.8283958674712; Wed, 11 Jun 2025 08:08:58 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uPN2I-0004Mm-J8; Wed, 11 Jun 2025 11:06:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uPN2D-0004MB-8G for qemu-devel@nongnu.org; Wed, 11 Jun 2025 11:06:37 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uPN2B-00072t-Dk for qemu-devel@nongnu.org; Wed, 11 Jun 2025 11:06:36 -0400 Received: from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-607-Z3gH8SuvMpaECHxrW8CRUw-1; Wed, 11 Jun 2025 11:06:31 -0400 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 1072C19560B2; Wed, 11 Jun 2025 15:06:30 +0000 (UTC) Received: from corto.redhat.com (unknown [10.45.225.191]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 8C7CC180045B; Wed, 11 Jun 2025 15:06:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1749654394; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IGUijn8OwNTfwcOPRbjli+qIh22n9IlcqzOHh08EtHM=; b=iXHGSx6P+JbhoYYH/PU5adQxOZSrUN1JJeM1lDz7wgwEd004Z7f8uawfJFPqkX8+EzBiGC AG5YvoxcL/py+NHUHo0Km+/2JsBq5ehEY2r+yUxPfAbQgTmT7iP6Nf3SD53rRSp7viFZxa WjQ5zv4UqKS/qvmQ5QuTk2S5Aku3mN0= X-MC-Unique: Z3gH8SuvMpaECHxrW8CRUw-1 X-Mimecast-MFC-AGG-ID: Z3gH8SuvMpaECHxrW8CRUw_1749654390 From: =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= To: qemu-devel@nongnu.org Cc: Alex Williamson , Zhenzhong Duan , John Levon , =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= , Yi Liu Subject: [PULL 02/27] vfio/pci: Fix instance_size of VFIO_PCI_BASE Date: Wed, 11 Jun 2025 17:05:54 +0200 Message-ID: <20250611150620.701903-3-clg@redhat.com> In-Reply-To: <20250611150620.701903-1-clg@redhat.com> References: <20250611150620.701903-1-clg@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=170.10.129.124; envelope-from=clg@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @redhat.com) X-ZM-MESSAGEID: 1749655134440116600 From: Zhenzhong Duan Currently the final instance_size of VFIO_PCI_BASE is sizeof(PCIDevice). It should be sizeof(VFIOPCIDevice), VFIO_PCI uses same structure as base class VFIO_PCI_BASE, so no need to set its instance_size explicitly. This isn't catastrophic only because VFIO_PCI_BASE is an abstract class. Fixes: d4e392d0a99b ("vfio: add vfio-pci-base class") Signed-off-by: Zhenzhong Duan Reviewed-by: John Levon Reviewed-by: C=C3=A9dric Le Goater Reviewed-by: Yi Liu Link: https://lore.kernel.org/qemu-devel/20250611024228.423666-1-zhenzhong.= duan@intel.com Signed-off-by: C=C3=A9dric Le Goater --- hw/vfio/pci.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c index b1250d85bf0124a22e3ba3859a47d2b176ade648..6748f4e876942f89138f9d8fedf= b99dab95b865e 100644 --- a/hw/vfio/pci.c +++ b/hw/vfio/pci.c @@ -3425,7 +3425,7 @@ static void vfio_pci_base_dev_class_init(ObjectClass = *klass, const void *data) static const TypeInfo vfio_pci_base_dev_info =3D { .name =3D TYPE_VFIO_PCI_BASE, .parent =3D TYPE_PCI_DEVICE, - .instance_size =3D 0, + .instance_size =3D sizeof(VFIOPCIDevice), .abstract =3D true, .class_init =3D vfio_pci_base_dev_class_init, .interfaces =3D (const InterfaceInfo[]) { @@ -3647,7 +3647,6 @@ static void vfio_pci_dev_class_init(ObjectClass *klas= s, const void *data) static const TypeInfo vfio_pci_dev_info =3D { .name =3D TYPE_VFIO_PCI, .parent =3D TYPE_VFIO_PCI_BASE, - .instance_size =3D sizeof(VFIOPCIDevice), .class_init =3D vfio_pci_dev_class_init, .instance_init =3D vfio_instance_init, .instance_finalize =3D vfio_instance_finalize, --=20 2.49.0