From nobody Sat Nov 15 17:17:25 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1749228452; cv=none; d=zohomail.com; s=zohoarc; b=C+vVO5NNz/JGXNWehHs8NJyYSYRanHZ7AzUrX3w1mciw6VgrCXbTRkHpSQiw2FkMFwrIvJO5NvpPax0Flm9xrzlQtZvc0BLtb7PICWYKH0g8zBs7RfgNxtRXydwR/S6v8XXD8AVB+mL2oqM+aXm4N1Iwju/WkHEgZr5W0Vmy0Js= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1749228452; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=xncKsFHoKiGF9zIgTrjiHDIYawtS38KWgNsBt6WFVxY=; b=UKLUmyTlHZ4fwe9v3asy58QLN0eEE6dGenep51IyRNxEZuNtPVprMODmgsUWkYwYii/0ysYNt3wbm0aJG9TNoEm3sf19PZzLpG5Tg8MqGrDlozM0pbp0wdImby4DuWiXaX9ycKvRaHoXmPIBshacB9QDKpBkWgMMDtsnw2FzbVw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1749228452114516.7233410456951; Fri, 6 Jun 2025 09:47:32 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uNaBH-0004bv-FZ; Fri, 06 Jun 2025 12:44:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uNaBF-0004bO-PW for qemu-devel@nongnu.org; Fri, 06 Jun 2025 12:44:33 -0400 Received: from mail-wm1-x332.google.com ([2a00:1450:4864:20::332]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uNaBE-00037y-9y for qemu-devel@nongnu.org; Fri, 06 Jun 2025 12:44:33 -0400 Received: by mail-wm1-x332.google.com with SMTP id 5b1f17b1804b1-451ebd3d149so15384975e9.2 for ; Fri, 06 Jun 2025 09:44:31 -0700 (PDT) Received: from localhost.localdomain (59.red-95-127-62.dynamicip.rima-tde.net. [95.127.62.59]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4521370961csm29805915e9.22.2025.06.06.09.44.28 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 06 Jun 2025 09:44:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1749228270; x=1749833070; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=xncKsFHoKiGF9zIgTrjiHDIYawtS38KWgNsBt6WFVxY=; b=HXf6s17RHu9+jhRY3KIGpTjtqQZPorQmREls4ISU2+kacWeBvToKBh8ZCc9TlGlO77 p7zaENBYyxWVegHRzzsw1/e+8ohG6ZUp1m/flTXmS5e9EF6CO1szL44Zfhn0RFJl6Z3A qxVm4zkghxa3d+O9/FH/wK5bTxLHsKLRpDKdHGm3g6tasuTHgHat24v3nuG0JW8aLm54 YIfGUR8nAF3f0+cGGfCgyZj+oUgxcF8nr23jUiBDEYWT5MRv2v4t+nvlrTS9Q6XVO7B8 rKmHHMH0eH/gChimFlbzTceDRdCRyo8L/6LbViPF2LMz5rXAFyVyvNuXHNLQb4ua4UWA ze/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749228270; x=1749833070; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xncKsFHoKiGF9zIgTrjiHDIYawtS38KWgNsBt6WFVxY=; b=mkuRctxhiDIYqOmNV+SVF8q+ZsIYLfhNzMxPSuzU1zx4pTCpBDFNmYakvTTwhEqyzG WVnLJwMq4an7g0j/76mIHCvh01MhW9awJdf+UmXpugp9jO7k+Gxmj0nQIduYqvXPt0Hq ButKyrOEL6GZugVkCJuz/03+FftKdOZLxqXEGiSFyfQ3MFX1CW6OffABstmVyO8Onm7q 5oZh+UucZxZPD6tVUfgBn93FiIa0RGGXiDoDpKIE55GOce2iQ00mvlHPT3ycLP89yLrk x5KWlSZ3i5ajgYirDLhpKc07sfVlTjroq62EDiaH1P+M/2zhnzw0etIEnCC+BRjs0jnh gmvg== X-Gm-Message-State: AOJu0YwBbOOxcAQnaVR0h0yMNid03yRcysb7PJXQ8qF76U7gMNjbxCCQ hvh6bnjikAPbcuuVfz3gt6viEGPeOhRo2CVdMKL8Jg+j3EEHRvColSem+IdPbes7GFJo8qOCkMl vTHWbT8Nkww== X-Gm-Gg: ASbGncsU5UQ8cksZymGD3ImcY69ZITsAUXEb3DsEVY+ruVgSvjoctUdj0SaUgRUvclm BPcyrzT0MpWKMMKL8vMCBIwAy5SuR+eetiXnDTqa8CWLi7U+cxk+j4vTjjWYL2zcBNfuWEMvZX9 Y/2y0osZtmDZAy2kaYk1HRsfjTKDNBgxw/FkrRdlp9S9WcoD+khAWOVvC1dY15CtqKqBWwB/Dme GBPIXQ3VxjDfmWc7STRpgCMq36YlTivO9H9GgKS+nP5lFEcDa2jWykPPMV/iezyusmywATK0LKW lew4BhLz6yXrjDXn27c8olqwz7QF7eCEFSLor3nar7Swb60zkpWud6+oWXUypUsviD8Ait9A8Sp dQ3Hke5BlWgQEQZvmWwUc1K3JXnMbIOc9YwuJ8tj1Tz7kaDfN X-Google-Smtp-Source: AGHT+IGyymJQ4AlQL4XA1khDXxyS75SWyWGAowwEWF3FEQ+c35QOAwfqzYg9VdbiUSs22lWuJuqtjA== X-Received: by 2002:a05:600c:1c1b:b0:44b:1f5b:8c85 with SMTP id 5b1f17b1804b1-4520139c741mr45039555e9.13.1749228270392; Fri, 06 Jun 2025 09:44:30 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Alex=20Benn=C3=A9e?= , Richard Henderson , Pierrick Bouvier Subject: [RFC PATCH 01/19] hw/arm/virt: Only require TCG || QTest to use virtualization extension Date: Fri, 6 Jun 2025 18:44:00 +0200 Message-ID: <20250606164418.98655-2-philmd@linaro.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250606164418.98655-1-philmd@linaro.org> References: <20250606164418.98655-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::332; envelope-from=philmd@linaro.org; helo=mail-wm1-x332.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1749228453403116600 Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Alex Benn=C3=A9e Reviewed-by: Richard Henderson --- hw/arm/virt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/arm/virt.c b/hw/arm/virt.c index 9a6cd085a37..d55ce2c0f4e 100644 --- a/hw/arm/virt.c +++ b/hw/arm/virt.c @@ -2205,7 +2205,7 @@ static void machvirt_init(MachineState *machine) exit(1); } =20 - if (vms->virt && (kvm_enabled() || hvf_enabled())) { + if (vms->virt && !tcg_enabled() && !qtest_enabled()) { error_report("mach-virt: %s does not support providing " "Virtualization extensions to the guest CPU", current_accel_name()); --=20 2.49.0 From nobody Sat Nov 15 17:17:25 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1749228316; cv=none; d=zohomail.com; s=zohoarc; b=I4sl8VARDeEp5uSecJsTp8d/x1HLlqeWHfjhJC/qaGUAPdllRjmOR7Ason9xD/uLCIh/rdZh2ECIaD7pqAn3i/oFWVbPf+TD1fIYYyMBkZGzJqFC0YDzJibvAWEoR4naXA3X78PKWNYhpgKwEC1ODIxOByIceBUfXDb0ytjomAA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1749228316; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=u7VQXQKp4F78pUbtbCAb+X5WWO3G+XUjvRGKunsuffg=; b=M6Ub2nlryyHN5sSXmQEAWq2HeBx7PJbPjF5ROn+Dpt+mXxxF7+gKZ/1HV94QK6LfeYNFqQxm0zDp9s2GZQuYh6kg1HcrFGeex+sHxQoK7l5IERUQv36YUPIuwU6MJlgWjWENcOejSxnr/KYdTOi5G/VEXtIbHHGQ3F+FvV3SO3A= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1749228315982100.39887232418027; Fri, 6 Jun 2025 09:45:15 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uNaBO-0004cT-Tj; Fri, 06 Jun 2025 12:44:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uNaBO-0004cJ-3n for qemu-devel@nongnu.org; Fri, 06 Jun 2025 12:44:42 -0400 Received: from mail-wm1-x32b.google.com ([2a00:1450:4864:20::32b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uNaBL-000391-P2 for qemu-devel@nongnu.org; Fri, 06 Jun 2025 12:44:41 -0400 Received: by mail-wm1-x32b.google.com with SMTP id 5b1f17b1804b1-450cd6b511cso16138525e9.2 for ; Fri, 06 Jun 2025 09:44:39 -0700 (PDT) Received: from localhost.localdomain (59.red-95-127-62.dynamicip.rima-tde.net. [95.127.62.59]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a53229ddf6sm2352584f8f.2.2025.06.06.09.44.35 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 06 Jun 2025 09:44:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1749228278; x=1749833078; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=u7VQXQKp4F78pUbtbCAb+X5WWO3G+XUjvRGKunsuffg=; b=hC6/cauASZE1iB0zRzypvoNtfFWAkmm0QkKmKNsO0/T3uoIiz0l4bRT+TRlx6WywKv G4LpFY+0GMtVkJtciY+iZ+tXWvHS+sxIhH44ghF4vugCS7DKCMVaNORluWvO+Mf99sr8 QIKXxjL5KgWZAEavuc8b5dn1SBXaIMZUSUqWHqZVzEcvdGOk8yUifCXW3jQDz9GHucCU OK40UkxcvSlqNQ7kj8gNSym/KLflg++Gd/nLjhi3/GGevEkXcp/8w3pLJ1amBqgDDzFN X3w7NM0zuGcHXyZ9I5BfcJWJRulvNWEzK0k80Pp0FlBFloxHbnONr3WeuwbGdGqQslbw B4OA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749228278; x=1749833078; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=u7VQXQKp4F78pUbtbCAb+X5WWO3G+XUjvRGKunsuffg=; b=g/X7ci88PfZ2R4s6x0JOggctN3xLuD26ZAEk2covRZtjZSijYk2RV+fEs8yH2/dC9L xvwvj/M0fAzKPo5sgwE8XUe0y9Ubk54YHjUrr71eoA29PMHqijqqudghQ2JHCTxlRNY5 SUH6o83JszGk+hfN0EDmtgjm2hGE31YtlV9yKBb/CJWR5Rl3E+33jUkVznPtW57WpNyj Kfz3OJgi3ffJbHz/7CJIjzn1f+nbCX8NJj481DXcpBoxQALJNRPnoK4R86AUuce6yUDV BWgH4fcIWA74y/rblPzAy/iLA4MBNRULBS+j0Jb1yzKEy1/aNs6iBttEbLRtIuEnf2Ms acNA== X-Gm-Message-State: AOJu0YzQ7knnzYCfTCzKvVnHA6N5DzpGNDagU45dwEyTanT97F9It2Az 2rD2zEzyon+87+WBHpJJzqOh5e9VbF64opYUmy3/sNhY9ABeNea6jtfQI2qNkfPyHmLbd2siq+q yaZ76AGWszQ== X-Gm-Gg: ASbGnctui19xVV1Fm4nYwYS+8wZoBq03VslROimJHzLcvXH1c0N6/5wZ4iiCs1Pm7dN OyJbq2jsdXgjByB3wh/oUgiWNk1xrAOVC+23AVHviWpoMmhchdfu4IXLAIOJ2Q8j4dPBFo2wQjv WZQsq2j9dwTQxe4LlCQDb2mxKFYvEKRRwo0za53rXZt8gGGC0ZxHEls+aCpewDqTSmrq4KyMzG1 0NiVJhMIUty3qtMlNK1RAcSh75Kq0X1ajkk3A7gwOAQq0aQBe1xgqWrVezX2Vckw4ZTxrwYstwY kCdA5xNTYx7gYxZ2OreylXOJB5hwbt8QjzV90kwy6EBMUbqr8XK3CF7JB/CBunF2snm68MjOOph w1uLK01FWE1bazTlyHAicbWXdwvBVNLiYQTpch2L0IupBCqEI X-Google-Smtp-Source: AGHT+IHUQV8A62vXFrim/3fZWlx3zxw6UsOwkpoAasWmFFQbJEqzGebFv67y2r8KSoUz2mdKc74E4w== X-Received: by 2002:a05:600c:4712:b0:44b:eb56:1d48 with SMTP id 5b1f17b1804b1-45201417ff5mr48369655e9.4.1749228277642; Fri, 06 Jun 2025 09:44:37 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Alex=20Benn=C3=A9e?= , Richard Henderson , Pierrick Bouvier Subject: [RFC PATCH 02/19] system/cpus: Only kick running vCPUs Date: Fri, 6 Jun 2025 18:44:01 +0200 Message-ID: <20250606164418.98655-3-philmd@linaro.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250606164418.98655-1-philmd@linaro.org> References: <20250606164418.98655-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32b; envelope-from=philmd@linaro.org; helo=mail-wm1-x32b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1749228317624116600 As an optimization, avoid kicking stopped vCPUs. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- system/cpus.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/system/cpus.c b/system/cpus.c index d16b0dff989..4835e5ced48 100644 --- a/system/cpus.c +++ b/system/cpus.c @@ -494,6 +494,11 @@ void cpus_kick_thread(CPUState *cpu) void qemu_cpu_kick(CPUState *cpu) { qemu_cond_broadcast(cpu->halt_cond); + + if (!cpu_can_run(cpu)) { + return; + } + if (cpus_accel->kick_vcpu_thread) { cpus_accel->kick_vcpu_thread(cpu); } else { /* default */ --=20 2.49.0 From nobody Sat Nov 15 17:17:25 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1749228506; cv=none; d=zohomail.com; s=zohoarc; b=ngPCsNFDbyPp8mbpvPf9l8d5s2qy34BYp0wqi9RDparziKaDICz0GvlwRxBwSQ16pOHZUYif3q9B4+ZBivuZXahVN20VAJrJNFxcgIiT/Vqsn5yX4SZAmhqz1fAp11elFZ7VoCbxHpn/G163AZtURFXMyT+Jzz7vEdwj9z0bF6s= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1749228506; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=aUp6HMosko5+RmwM4ev7KubdCI/J9zGOgFIy4jTzBlM=; b=W0JyPAsP+0jhsDVrlqy4v0+tO2PmSz4jCKDPh7IXxZGlqIGbX5B7f1nQ2EUQDGIFaK2Aw5RdwkSAIucJop/RwNihm2OaG1LSFNfzRt7LWEdOE/O4X8/CuP5HFXECzTuEfji/fwsKbShzCko+F+y5NcenN7BoQtOuIadLg0qXGT0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 174922850599574.79219797250278; Fri, 6 Jun 2025 09:48:25 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uNaBW-0004dZ-8X; Fri, 06 Jun 2025 12:44:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uNaBU-0004d6-N2 for qemu-devel@nongnu.org; Fri, 06 Jun 2025 12:44:48 -0400 Received: from mail-wr1-x434.google.com ([2a00:1450:4864:20::434]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uNaBT-00039w-2a for qemu-devel@nongnu.org; Fri, 06 Jun 2025 12:44:48 -0400 Received: by mail-wr1-x434.google.com with SMTP id ffacd0b85a97d-3a0ac853894so2065663f8f.3 for ; Fri, 06 Jun 2025 09:44:46 -0700 (PDT) Received: from localhost.localdomain (59.red-95-127-62.dynamicip.rima-tde.net. [95.127.62.59]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a53229de70sm2304909f8f.5.2025.06.06.09.44.43 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 06 Jun 2025 09:44:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1749228285; x=1749833085; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=aUp6HMosko5+RmwM4ev7KubdCI/J9zGOgFIy4jTzBlM=; b=qD9yirwmj4TVcKhAn0p60hkJ/dX9w3BSjwR75fQ5aOiibX8QfTR9/9YkHvp8iFZ8O+ MN6z0+jrVUzSA0OZ5eJRoSsDxr3IJj6RSozezFq+1n/64Pl8rALHfGNlD6b9SAfyS3/l BBAuMFpE4YNp7ty7ULcY7L5+0EM8OjEQ9oJamSMLjy1MYERgDp6BfH0L6kBIJH+JffeQ /JOIHtAfzdVKrr7DCAXM3oiTL2RBZiQ7FCErl20jR/eZvXcV/kzpmpDjUPyzgKQanHuU u6f8SDmY2PpdPmFT2EDZlRTqymZOHlaqpmmLAr3400NBC1VNJ/Lzj5We2KLgUd64z/RW 3vtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749228285; x=1749833085; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=aUp6HMosko5+RmwM4ev7KubdCI/J9zGOgFIy4jTzBlM=; b=gu5xYOBhA/EwSaC2lY0SwkXvWP8XqixUv3/JwMXaOBC6Gg97EQf/lAdMwBuPVwIuHW 6IyrQJfMknQWONVxzk8NldLs/YnUU5A2KyYt9FNh7Y+fYpk30QLk77xtv8g4nvqQxizf fXOApb+RDBGClVaWmcwud5AJfDFpYicQGngDa4qHAcT06YYSMKYo0M3zkRep9EhNPAc1 41HVRT7T8PhjaNHkEISdXWBEn1p90DEghFjcGsk733XH7ayMuKLqN5c7POdX/o2D6j8M K4lNLe2DAR29DKHj+v6DX/LBPPVXcHbV6oVCgXxk6fpchoBprUBnSfVoDo6CY8p0vMlB wE6w== X-Gm-Message-State: AOJu0YzXIJpbuH9OY20qiJ1X4H1YZP53l7STfKecUy8W0QMRBfWgOkGL EfCKzA8CWxmXRm+AES6+i7cYw0oFDpWh948NUN1K+AHR5PzXfmZhkw9J34rw2uZCRF37A0ivOPi eAwIDU8E7iQ== X-Gm-Gg: ASbGnctZHEHI6rR5ZXtom6l9RPJUU9BwncOeNB9rcaVdvj0B+Z+uBsz94H2qr2D0OkS OEmeakFmoSTq0EhCoycrDPOheny5IHtiqaRCCqFTbPy656vJpsSMFpX79hL+ADyiG//4bobQt6z /JzJg64LCFf908IcGQGI/M8M+xiuNWzqyl173AGRhhQYDiGkb3vXzghY9taLap67vSr+ZLLA+0l fMJxqtcfv3YjOxGxzowqGG6EvMhCigPohEpGjDEXXZ6UU43Ebt+MHA/whqjVERpD26IpCa9EzuQ kyE/463rneKA6hn88Rj1hWhTpLX4c6XrF2aqmxM75MoXHRulRMcd7yqR7a43FTAn8CMORXv6pEh SFQgZHWtuRJDjBCLn5zaSMCLDH9qwyqLtnA9UohELJS3Sb2Dm X-Google-Smtp-Source: AGHT+IEFoy0iUsm50S8C5X9dDeALmMI23Uup+Xi95anscjkLGUgqXs/1YmskcA2kRwB/hddPmbmz0w== X-Received: by 2002:a05:6000:2c10:b0:3a4:e6e7:3acd with SMTP id ffacd0b85a97d-3a531ca7d4dmr3344706f8f.18.1749228285001; Fri, 06 Jun 2025 09:44:45 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Alex=20Benn=C3=A9e?= , Richard Henderson , Pierrick Bouvier Subject: [RFC PATCH 03/19] accel: Keep reference to AccelOpsClass in AccelClass Date: Fri, 6 Jun 2025 18:44:02 +0200 Message-ID: <20250606164418.98655-4-philmd@linaro.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250606164418.98655-1-philmd@linaro.org> References: <20250606164418.98655-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::434; envelope-from=philmd@linaro.org; helo=mail-wr1-x434.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1749228508061116600 Allow dereferencing AccelOpsClass outside of accel/accel-system.c. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Alex Benn=C3=A9e Reviewed-by: Richard Henderson --- include/qemu/accel.h | 2 ++ include/system/accel-ops.h | 3 ++- accel/accel-system.c | 3 ++- accel/tcg/tcg-accel-ops.c | 4 +++- 4 files changed, 9 insertions(+), 3 deletions(-) diff --git a/include/qemu/accel.h b/include/qemu/accel.h index fbd3d897fef..23c62cbeb07 100644 --- a/include/qemu/accel.h +++ b/include/qemu/accel.h @@ -37,6 +37,8 @@ typedef struct AccelClass { /*< public >*/ =20 const char *name; + AccelOpsClass *ops; + int (*init_machine)(MachineState *ms); bool (*cpu_common_realize)(CPUState *cpu, Error **errp); void (*cpu_common_unrealize)(CPUState *cpu); diff --git a/include/system/accel-ops.h b/include/system/accel-ops.h index 4c99d25aeff..44b37592d02 100644 --- a/include/system/accel-ops.h +++ b/include/system/accel-ops.h @@ -10,6 +10,7 @@ #ifndef ACCEL_OPS_H #define ACCEL_OPS_H =20 +#include "qemu/accel.h" #include "exec/vaddr.h" #include "qom/object.h" =20 @@ -31,7 +32,7 @@ struct AccelOpsClass { /*< public >*/ =20 /* initialization function called when accel is chosen */ - void (*ops_init)(AccelOpsClass *ops); + void (*ops_init)(AccelClass *ac); =20 bool (*cpus_are_resettable)(void); void (*cpu_reset_hold)(CPUState *cpu); diff --git a/accel/accel-system.c b/accel/accel-system.c index a0f562ae9ff..64bc991b1ce 100644 --- a/accel/accel-system.c +++ b/accel/accel-system.c @@ -85,8 +85,9 @@ void accel_init_ops_interfaces(AccelClass *ac) * non-NULL create_vcpu_thread operation. */ ops =3D ACCEL_OPS_CLASS(oc); + ac->ops =3D ops; if (ops->ops_init) { - ops->ops_init(ops); + ops->ops_init(ac); } cpus_register_accel(ops); } diff --git a/accel/tcg/tcg-accel-ops.c b/accel/tcg/tcg-accel-ops.c index b24d6a75625..da2e22a7dff 100644 --- a/accel/tcg/tcg-accel-ops.c +++ b/accel/tcg/tcg-accel-ops.c @@ -198,8 +198,10 @@ static inline void tcg_remove_all_breakpoints(CPUState= *cpu) cpu_watchpoint_remove_all(cpu, BP_GDB); } =20 -static void tcg_accel_ops_init(AccelOpsClass *ops) +static void tcg_accel_ops_init(AccelClass *ac) { + AccelOpsClass *ops =3D ac->ops; + if (qemu_tcg_mttcg_enabled()) { ops->create_vcpu_thread =3D mttcg_start_vcpu_thread; ops->kick_vcpu_thread =3D mttcg_kick_vcpu_thread; --=20 2.49.0 From nobody Sat Nov 15 17:17:25 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1749228313; cv=none; d=zohomail.com; s=zohoarc; b=Nt/S7+S0/8ogJ8wjisZawk7+XdlyhKnbAENIMloyfmTF1j+jsrUHIoBNK/wwTnHABWgzKj9wCP15UvG2eixobQGj09xi5DzVqyR6gaYv8bydVQe5nV3yjM0tlsbqzfBBvx86XRgir+aQ4SXeuNDeAt3YbOgGCPVio0KrW8tzDbs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1749228313; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=YiFuAm3OZkIEGknbm0ayReT0Cz2T98Om3bMRx4Pxr2U=; b=mBqNrrLFafjfov2T0v+QcZMnCXBt7S5WeWbMW1bN6C6FNusi26F0PhVwwXCDE24g/lBUdw7R3U6x2GguzA2Bv/syUohVmAVcjQkorYg2AcV6KTtJkEjrn/lwhOvAc4/MqmeIacATzi2ZTvz3NXpA53uJIagiGBgD++1NP0XYJM0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1749228313456845.7484012915036; Fri, 6 Jun 2025 09:45:13 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uNaBd-0004eG-Qe; Fri, 06 Jun 2025 12:44:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uNaBc-0004e4-Dv for qemu-devel@nongnu.org; Fri, 06 Jun 2025 12:44:56 -0400 Received: from mail-wr1-x42b.google.com ([2a00:1450:4864:20::42b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uNaBa-0003AQ-BE for qemu-devel@nongnu.org; Fri, 06 Jun 2025 12:44:56 -0400 Received: by mail-wr1-x42b.google.com with SMTP id ffacd0b85a97d-3a375888297so1491059f8f.1 for ; Fri, 06 Jun 2025 09:44:53 -0700 (PDT) Received: from localhost.localdomain (59.red-95-127-62.dynamicip.rima-tde.net. [95.127.62.59]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a53229d9ddsm2360075f8f.4.2025.06.06.09.44.50 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 06 Jun 2025 09:44:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1749228292; x=1749833092; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=YiFuAm3OZkIEGknbm0ayReT0Cz2T98Om3bMRx4Pxr2U=; b=HTYrAL3fb4fBBqaMj4MLPp6DdkvLllCaX8Fj1+ocz0IeEVAK2CqAiT99O0CRuM/Yug vrK4BQaAOhdQ1AjmuE70H0eKWwIKBJldwW8VN7muY7T5PeQQgcN1M7+iOs96AHU6osoL UKmRvMLrYdnAOW570YMmu9IAzveX0L8zTonEIEhBTqUhmjlBQ6RAw+RCMhVdDkQj4Y+e 6rJdw0KmzQf9Y/gCD8HdmSee01u5Qls36+YFaArvDT5N8lf2qlJhDRXTVvYJK9WpCu0I yuOnJzItkUrrZkw7tekfMTaM+UQ3yfT2aHO113iJi393E6jccWNwOYdZX5rZLkp3omHW zRXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749228292; x=1749833092; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YiFuAm3OZkIEGknbm0ayReT0Cz2T98Om3bMRx4Pxr2U=; b=umRlTaoSF7CyK0qoRly17PK9UYtl7AdRe0vJGGRbWMSd86Mvqbtdxr5RYnfqe8i+Mm ms1p83WwsXpYjUTgi4wuPVstJsG7OpVQKpFDrfmhhlRqp/n+uFDBzKrWoL4YSMRjKfX0 KI1LOOoIB2HYw7edrHtQi4MZ2D4m31+5pelJmYn0QzzS+XU73OnuOcO7hSHIfABQAwo3 GAonHDGIrXQZsXRLB8r0JUxnJjJVp+p6aMZ8ckzTYp/QXPRPmbiC4jqiY48rxr8VhIo8 O/4/2oJ4b3w0ROxR3FWarFGW9XZSVAH+BjPSvnN/sKxosjaySZwKF7Au2tMXxrYxon/S CTfA== X-Gm-Message-State: AOJu0Yx33V0GyMFTYFlczH7o2jdFcqGij9ixOI8rGD5Rh3DV/7Vjjv6S tmufeDeGGfo1OaS0H+va1aP2QJE74KOTS2QocdOcU3BY51yoW45nTelUrTlKJxQHHMc3YxLxvAh s9Wk5cBGSqA== X-Gm-Gg: ASbGncsjA532a/5QmDDinsFUHnEqjgjdZ065eYi5McsXTprm6x/jeF0Wx3dAfBXGIp6 0wf/tawKfV3u0IFXKoqgldf/ya5rZQSmaWWoNqHduKSpi7hIrwHyVnV9sDA2gMzI0iVi6i+Vr/A wtIOvS1KAOaDE05Ozs6CYBqb5q9KvTqVAxeaGis5dDQADq6Od/zes3LsTGwlTvYG2aFpYWdpBQe oLPmg4X57j7PKWczHtyEwb9us44ZtmMr6fNOuQtxwwcPRmAhGKDChWLGrmDVOJDKYwBY/rLWTlC 1NTItOc6QIyan02zW2o2QLx5ggmgUxGBN4ylEqT+e7MF7ACnk1ovlAgWeOsG8EEVkvQ3jZQllK7 bkP3x8wUfllJ2TbISQLFAKZyJIw+jEXMZtmrUQDs6bDish4ZY X-Google-Smtp-Source: AGHT+IG3UTcytprGVaVVRAVZi8092Sr63+QD+q+aenXzhIw1jkvBopJEbU5zpmNx/wqbL0yIinwDqQ== X-Received: by 2002:a5d:5f88:0:b0:3a4:d79a:3599 with SMTP id ffacd0b85a97d-3a53131de7amr4116329f8f.11.1749228292257; Fri, 06 Jun 2025 09:44:52 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Alex=20Benn=C3=A9e?= , Richard Henderson , Pierrick Bouvier Subject: [RFC PATCH 04/19] accel: Propagate AccelState to AccelClass::init_machine() Date: Fri, 6 Jun 2025 18:44:03 +0200 Message-ID: <20250606164418.98655-5-philmd@linaro.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250606164418.98655-1-philmd@linaro.org> References: <20250606164418.98655-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::42b; envelope-from=philmd@linaro.org; helo=mail-wr1-x42b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1749228315583116600 In order to avoid init_machine() to call current_accel(), pass AccelState along. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Alex Benn=C3=A9e Reviewed-by: Richard Henderson --- include/qemu/accel.h | 2 +- accel/accel-system.c | 2 +- accel/hvf/hvf-accel-ops.c | 2 +- accel/kvm/kvm-all.c | 2 +- accel/qtest/qtest.c | 2 +- accel/tcg/tcg-all.c | 2 +- bsd-user/main.c | 2 +- linux-user/main.c | 2 +- target/i386/nvmm/nvmm-all.c | 2 +- target/i386/whpx/whpx-all.c | 2 +- 10 files changed, 10 insertions(+), 10 deletions(-) diff --git a/include/qemu/accel.h b/include/qemu/accel.h index 23c62cbeb07..c660c5f4b11 100644 --- a/include/qemu/accel.h +++ b/include/qemu/accel.h @@ -39,7 +39,7 @@ typedef struct AccelClass { const char *name; AccelOpsClass *ops; =20 - int (*init_machine)(MachineState *ms); + int (*init_machine)(MachineState *ms, AccelState *as); bool (*cpu_common_realize)(CPUState *cpu, Error **errp); void (*cpu_common_unrealize)(CPUState *cpu); =20 diff --git a/accel/accel-system.c b/accel/accel-system.c index 64bc991b1ce..68d2f28388b 100644 --- a/accel/accel-system.c +++ b/accel/accel-system.c @@ -37,7 +37,7 @@ int accel_init_machine(AccelState *accel, MachineState *m= s) int ret; ms->accelerator =3D accel; *(acc->allowed) =3D true; - ret =3D acc->init_machine(ms); + ret =3D acc->init_machine(ms, accel); if (ret < 0) { ms->accelerator =3D NULL; *(acc->allowed) =3D false; diff --git a/accel/hvf/hvf-accel-ops.c b/accel/hvf/hvf-accel-ops.c index b8b6116bc84..3dd9de26dbb 100644 --- a/accel/hvf/hvf-accel-ops.c +++ b/accel/hvf/hvf-accel-ops.c @@ -315,7 +315,7 @@ static void dummy_signal(int sig) =20 bool hvf_allowed; =20 -static int hvf_accel_init(MachineState *ms) +static int hvf_accel_init(MachineState *ms, AccelState *as) { int x; hv_return_t ret; diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c index a31778341c2..5b28b15ccec 100644 --- a/accel/kvm/kvm-all.c +++ b/accel/kvm/kvm-all.c @@ -2567,7 +2567,7 @@ static int kvm_setup_dirty_ring(KVMState *s) return 0; } =20 -static int kvm_init(MachineState *ms) +static int kvm_init(MachineState *ms, AccelState *as) { MachineClass *mc =3D MACHINE_GET_CLASS(ms); static const char upgrade_note[] =3D diff --git a/accel/qtest/qtest.c b/accel/qtest/qtest.c index 92bed9264ce..c5a53ecb6dd 100644 --- a/accel/qtest/qtest.c +++ b/accel/qtest/qtest.c @@ -37,7 +37,7 @@ static void qtest_set_virtual_clock(int64_t count) qatomic_set_i64(&qtest_clock_counter, count); } =20 -static int qtest_init_accel(MachineState *ms) +static int qtest_init_accel(MachineState *ms, AccelState *as) { return 0; } diff --git a/accel/tcg/tcg-all.c b/accel/tcg/tcg-all.c index 6e5dc333d59..6c5979861cf 100644 --- a/accel/tcg/tcg-all.c +++ b/accel/tcg/tcg-all.c @@ -80,7 +80,7 @@ static void tcg_accel_instance_init(Object *obj) =20 bool one_insn_per_tb; =20 -static int tcg_init_machine(MachineState *ms) +static int tcg_init_machine(MachineState *ms, AccelState *as) { TCGState *s =3D TCG_STATE(current_accel()); unsigned max_threads =3D 1; diff --git a/bsd-user/main.c b/bsd-user/main.c index 7c0a059c3ba..ad2032a8b01 100644 --- a/bsd-user/main.c +++ b/bsd-user/main.c @@ -474,7 +474,7 @@ int main(int argc, char **argv) opt_one_insn_per_tb, &error_abort); object_property_set_int(OBJECT(accel), "tb-size", opt_tb_size, &error_abort); - ac->init_machine(NULL); + ac->init_machine(NULL, accel); } =20 /* diff --git a/linux-user/main.c b/linux-user/main.c index 5ac5b55dc65..2441e6edc71 100644 --- a/linux-user/main.c +++ b/linux-user/main.c @@ -820,7 +820,7 @@ int main(int argc, char **argv, char **envp) opt_one_insn_per_tb, &error_abort); object_property_set_int(OBJECT(accel), "tb-size", opt_tb_size, &error_abort); - ac->init_machine(NULL); + ac->init_machine(NULL, accel); } =20 /* diff --git a/target/i386/nvmm/nvmm-all.c b/target/i386/nvmm/nvmm-all.c index f1c6120ccf1..887534d4ca6 100644 --- a/target/i386/nvmm/nvmm-all.c +++ b/target/i386/nvmm/nvmm-all.c @@ -1153,7 +1153,7 @@ static struct RAMBlockNotifier nvmm_ram_notifier =3D { /* -----------------------------------------------------------------------= --- */ =20 static int -nvmm_accel_init(MachineState *ms) +nvmm_accel_init(MachineState *ms, AccelState *as) { int ret, err; =20 diff --git a/target/i386/whpx/whpx-all.c b/target/i386/whpx/whpx-all.c index cf6d3e4cdd4..238c3b95c6f 100644 --- a/target/i386/whpx/whpx-all.c +++ b/target/i386/whpx/whpx-all.c @@ -2505,7 +2505,7 @@ static void whpx_set_kernel_irqchip(Object *obj, Visi= tor *v, * Partition support */ =20 -static int whpx_accel_init(MachineState *ms) +static int whpx_accel_init(MachineState *ms, AccelState *as) { struct whpx_state *whpx; int ret; --=20 2.49.0 From nobody Sat Nov 15 17:17:25 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1749228333; cv=none; d=zohomail.com; s=zohoarc; b=FGzmfESvj7wgMOYqISWimiqwCmRIAWK/WuTwKPujW+wr/WXLJq23WJ1JfViE+D5RiilF+3mBIN+2SrGq12b/3/OG2kdZX5DicnTWpStIYClI9dAkxWWfu7bx+gSAu0mOkY9FL6vRxaYrLuP3MC552iAYkuH2F819zMPR/JmeLCg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1749228333; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=/gEDjW5HxfekGeOmD2/G2kge4npJYt8IQAdDV18MsLw=; b=fyoWXciH7S1VS/i08sSPt7qTS4MpL/XoPPMyNvsSqKU/rdlNkiEr2weWbYXfUXDr4oJAaYwxOa4Zbh2T+sMHggxhLO1X05QvOC3j8zcmua1Brh38IF/ZlA5uaN2pgC6Q8nh2Elb2HwMvSEPZrR2DKcoCNZRt6OpEkdkGlWT7kLw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1749228333119394.32487761135974; Fri, 6 Jun 2025 09:45:33 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uNaBk-0004hM-BP; Fri, 06 Jun 2025 12:45:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uNaBj-0004fw-67 for qemu-devel@nongnu.org; Fri, 06 Jun 2025 12:45:03 -0400 Received: from mail-wm1-x331.google.com ([2a00:1450:4864:20::331]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uNaBh-0003BC-LX for qemu-devel@nongnu.org; Fri, 06 Jun 2025 12:45:02 -0400 Received: by mail-wm1-x331.google.com with SMTP id 5b1f17b1804b1-451d6ade159so20489345e9.1 for ; Fri, 06 Jun 2025 09:45:01 -0700 (PDT) Received: from localhost.localdomain (59.red-95-127-62.dynamicip.rima-tde.net. [95.127.62.59]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-452730d1636sm26638875e9.38.2025.06.06.09.44.57 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 06 Jun 2025 09:44:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1749228300; x=1749833100; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/gEDjW5HxfekGeOmD2/G2kge4npJYt8IQAdDV18MsLw=; b=hJ7wu2iaEP2t9rCQq/e2VbEO8mD4lxcLaHD21ubtZsTGSGYGOb2iTkFNFMXtmDIdpq RxzEpDSSOL7WDGjOQC4fIX/s/AxOjmDv2wPYlebXBNcFT+DmKjxCA7+aRs3ZMKeLIs5t /RJyC6qDxOlhBRdTb/xAyDo/UDqq+GG/XPBbd/yidDlwJk57UUGsjXM5TaRExwHdfCYA O8RaWVM9Cr6De1XY9TZDjdyBnh2A3W7zwcGUHefXFSlCpRymcuaa7v+I0xB6rL0xcmcn ObDWraPDrV/7nHu6sh9XW66fsMdxBckIxdYyfiYwUtI7V75uBhJ08GpvX6R8vZh5LqQH mOAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749228300; x=1749833100; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/gEDjW5HxfekGeOmD2/G2kge4npJYt8IQAdDV18MsLw=; b=QvxhroxHWf+uImmIv06WoKPPXT0dHALg/3Qlp4jDR520zam6Bgn6v+ivfYZu1eXcuj l3Y99jex6/RcHnW2Hf+pFBJSnZ07D49br+DjSZ5DH5NqMKmtZ6waLvdyaEADeFVvKOCr FDizRN3B9wCAuROfuoy9F5qTCMrHT1XC1kt9YowIXYuWmD1U0wnCmp+jqrCG2iDKAp/Y WYFeNFvw4Y6B9mr8wPN0O2ZmGmuTNh9ZNdj4K7Pzzol4aJRQew64NC4Tu+/I8w2t+bGm +GVDUPrPPwqC6DT3kZmJWCjJwBSaCSznYvi+1QaxRGc1UxdjCkK4WPQxuM9dOojVbJay /CtA== X-Gm-Message-State: AOJu0Yyx1X5PgaGnR3TDHb9LZBYL7d1BJ0hEjpccaewrqGaHYpfud+Kd dZOZxsF3BxZupwrJY1MRAfNvKHt4m/VzcDI+ar0b2s1uGwDuuAtuR6aF+vuigwMJWC4sq7Y8ymY f5mq1wuOTAg== X-Gm-Gg: ASbGncvXF0HQynX4YWU4QOK5CbS8TQxr6FxboTP8mkxto7seJ1AtoNfZs9DNmCvcHe2 2El8mV6KdOgiXgkK0SjVcggJ0Uyq9EmEwOc+sZ91vr+MD2MwwyLGp0+uNgahM9aDUAGXLB1CRe7 7zulMcJ4MK7El9leCS3yLQnw183J3mqgr295nyTb2t4cWp/ZU0m9SNja5zvUodcSCDgg8JxSFK8 zxi35RkT8vU+EgdRMwuzfM0gzgGeFfO4p7iei4uIe7tsuRnT9dH50okTQlsgE2zZxJJ/e/so8cs kqNkCOQThuSfj6dAnwv90USIf2c1vYAuZpqyaJ8lVtl6xwmlQooYvKwWZNoTL75EfS/II9NoRxg 16ZI6rD7z0Icd5dp5VMRceNQSyynaX1ljHfwjGfD41Ic0TY9t X-Google-Smtp-Source: AGHT+IEG2BGePAm+aW1Be2h1yBIQOTmjPdYGteXBwIu00B6TE/NSqlLQKYFeSkiy7G8Puq2xHfQ4JQ== X-Received: by 2002:a5d:4acc:0:b0:3a5:3a3b:6a3a with SMTP id ffacd0b85a97d-3a53a3b6a81mr238000f8f.54.1749228299690; Fri, 06 Jun 2025 09:44:59 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Alex=20Benn=C3=A9e?= , Richard Henderson , Pierrick Bouvier Subject: [RFC PATCH 05/19] accel/kvm: Prefer local AccelState over global MachineState::accel Date: Fri, 6 Jun 2025 18:44:04 +0200 Message-ID: <20250606164418.98655-6-philmd@linaro.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250606164418.98655-1-philmd@linaro.org> References: <20250606164418.98655-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::331; envelope-from=philmd@linaro.org; helo=mail-wm1-x331.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1749228333745116600 Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- accel/kvm/kvm-all.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c index 5b28b15ccec..551a462926d 100644 --- a/accel/kvm/kvm-all.c +++ b/accel/kvm/kvm-all.c @@ -2582,15 +2582,13 @@ static int kvm_init(MachineState *ms, AccelState *a= s) { /* end of list */ } }, *nc =3D num_cpus; int soft_vcpus_limit, hard_vcpus_limit; - KVMState *s; + KVMState *s =3D KVM_STATE(as); const KVMCapabilityInfo *missing_cap; int ret; int type; =20 qemu_mutex_init(&kml_slots_lock); =20 - s =3D KVM_STATE(ms->accelerator); - /* * On systems where the kernel can support different base page * sizes, host page size may be different from TARGET_PAGE_SIZE, --=20 2.49.0 From nobody Sat Nov 15 17:17:25 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1749228326; cv=none; d=zohomail.com; s=zohoarc; b=nexDAM17U5CW5N6ri6//cA3Q7c7XsWvHYXCw1EO1JeXfGPL/Z3uZlEol1+qkML87/ZqL9mBTtDm00olF6Z3BJn+GjKAOIoo/I/dRpdM580pzYdXEBCls30++9ZJP+lsp1q/r3aM2bHi4EDai9RIk8YpQngsvvLNfTH/nfYTks8Y= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1749228326; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=o7y7S/WReThht8x9oOE0nYIkVcJDi5oe728aOgkzFNA=; b=PKDugYvS8DfuQOxmiVp3E6Ykz2IEDnsOjBrmCN7JdYgGkuoeLTGkC3bCyLdMoyINxoxfudCCfvf7nHyjmWo0cJ3VHrY2BC0YxoaA9zRmNBPsNK9XveVtsH8Yxn9xrtjR+8JCCcUdcw1BUuzbpIdj5BNrCDBXq5015GmPr/syqxE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1749228326007335.06968244493885; Fri, 6 Jun 2025 09:45:26 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uNaBs-0004pV-1S; Fri, 06 Jun 2025 12:45:19 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uNaBq-0004p5-2n for qemu-devel@nongnu.org; Fri, 06 Jun 2025 12:45:10 -0400 Received: from mail-wm1-x336.google.com ([2a00:1450:4864:20::336]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uNaBo-0003NA-Ib for qemu-devel@nongnu.org; Fri, 06 Jun 2025 12:45:09 -0400 Received: by mail-wm1-x336.google.com with SMTP id 5b1f17b1804b1-43ea40a6e98so29892305e9.1 for ; Fri, 06 Jun 2025 09:45:08 -0700 (PDT) Received: from localhost.localdomain (59.red-95-127-62.dynamicip.rima-tde.net. [95.127.62.59]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4526e05636dsm28158215e9.4.2025.06.06.09.45.05 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 06 Jun 2025 09:45:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1749228306; x=1749833106; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=o7y7S/WReThht8x9oOE0nYIkVcJDi5oe728aOgkzFNA=; b=YB1kiLwhwUQBz5ezGN/UKSyzbf/qY1MIOSvyngk0hSsLqQO75ReXWFk7XRmvZKNLQK nd22KMlKtvbLIjo6Vok8Xpdc020j/ahfZcHAb/iB5AjDXvFe9LemS66AhzE1a7f7mlVj jc08mwisiAc4mLG7dv3dpqVp+RdYeu0v8EDtgyK6/c6oG3Kp1l7v2aPXPHBBrjU8DewL SwHr3VACR2ouO2yKvIyL9sDrxxj9mWgKKXWAPyGdPc6rJ4Q6Fqn4ia7xUCO/kD1vhtax TpKT64ieHlJtNVoCjWrBg+86NQ4WDjpi70hkK6+RJ9hijPrZnP00ZU4UAQfVO44GbT5y QroQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749228306; x=1749833106; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=o7y7S/WReThht8x9oOE0nYIkVcJDi5oe728aOgkzFNA=; b=KKAeTUKSRUbiiJoHetTreSb/n046wlmLjOrtPDrIN7yyey7mEhLkufAMc272bOmOvI 4PTgG36CmI4DjQPdXZ40Y+V7OFclOH8nC++T/zQ0mZmXfSazE9v8671F5Jtkeu8YyfdG vgjIvq/ClyghNX98IosOAbxMQSXnySVasdhbOEdiJBDwp6J8fWHNYS393Gt1JoIFAK9n Kcl3D7nl+G4f8eghZ9Pc0MA5dw8jipvgU4ru0LQSEYhZ4KMP0weMK3wTNVbM9wbuSNw7 WVZoOaUOzgH6O4aYGL2BcaKPW2cNNSdXoN6qKbJI8ZGedyuTgU+IN/c4P4gKyEQEw1/w +S+Q== X-Gm-Message-State: AOJu0YwBUI98KETgV5yZKirnbd62+AUZngbn0vC+rU4H0041X+F5iqna fHaNT0kB9wRu46HvvFmbU676grV1mdome7H8M+fgWC032jIS5VtNreuIJEBDBSOfsGIuoCKW6Du h9tbxbZKgRA== X-Gm-Gg: ASbGnctMwXcNiV/2D2PY0boadqR2cMH4PMzRikA1YiN0qHYUWuc49Tip+nmtpB4QZaV 49gDRa+W1m6OMXzJvjQ8ZOi66VzdFbr8/VBvyKTA7bnIArlCbNewBH48w2IBleVcdsXrXDwFyqL XlFJBfcM5BTIaQJtHn9apt3pNvbHCxX/ZeR6PZNV4xHQXTfTVNhIKOtdL9x8nodbQQ+1KixXMNy DnaXb549fgkI/O9tGsPP9GtaVS5C1AuxM4vI4InRSVMb5ujpAUlcZiLMLKFh3ZbVYq/AkM91EDu tDJslB18U9SHBRc52+L0RHmkxYMjgRnEnQiGjsdb/Bj8TBELU+71tfKhK95B5of4cLj2KI/Qj0D lInkKXFF/XUOAUuEnaZi+9oyEBN1u+F0qPsy+cg== X-Google-Smtp-Source: AGHT+IFD/vFGIhtbLTFZGOwNSjbgw2uHXMwoYPW2JP5oR2ndiyg/Xqnj8sXjw6qI/td9t3/+vfw2Uw== X-Received: by 2002:adf:b304:0:b0:3a5:39a8:199c with SMTP id ffacd0b85a97d-3a539a819d3mr628116f8f.53.1749228306563; Fri, 06 Jun 2025 09:45:06 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Alex=20Benn=C3=A9e?= , Richard Henderson , Pierrick Bouvier Subject: [RFC PATCH 06/19] accel/hvf: Fix TYPE_HVF_ACCEL instance size Date: Fri, 6 Jun 2025 18:44:05 +0200 Message-ID: <20250606164418.98655-7-philmd@linaro.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250606164418.98655-1-philmd@linaro.org> References: <20250606164418.98655-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::336; envelope-from=philmd@linaro.org; helo=mail-wm1-x336.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1749228327819116600 Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- include/system/hvf_int.h | 1 + accel/hvf/hvf-accel-ops.c | 1 + 2 files changed, 2 insertions(+) diff --git a/include/system/hvf_int.h b/include/system/hvf_int.h index 8c8b84012d9..d774e58df91 100644 --- a/include/system/hvf_int.h +++ b/include/system/hvf_int.h @@ -44,6 +44,7 @@ typedef struct hvf_vcpu_caps { =20 struct HVFState { AccelState parent; + hvf_slot slots[32]; int num_slots; =20 diff --git a/accel/hvf/hvf-accel-ops.c b/accel/hvf/hvf-accel-ops.c index 3dd9de26dbb..808ecea3816 100644 --- a/accel/hvf/hvf-accel-ops.c +++ b/accel/hvf/hvf-accel-ops.c @@ -366,6 +366,7 @@ static void hvf_accel_class_init(ObjectClass *oc, const= void *data) static const TypeInfo hvf_accel_type =3D { .name =3D TYPE_HVF_ACCEL, .parent =3D TYPE_ACCEL, + .instance_size =3D sizeof(HVFState), .class_init =3D hvf_accel_class_init, }; =20 --=20 2.49.0 From nobody Sat Nov 15 17:17:25 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1749228506; cv=none; d=zohomail.com; s=zohoarc; b=Jj40Tp3xlakhgOjupmXRl/NBiFu4WvYd5NpZga1bCguhGf1KkYwQrc8aKzvIPKdEEybUlwhKqq2NSZ3v3o8c4o4bflz/8ig992q9NfPSh03P8Dn+ZxEg/xPQKO1aog8FXRenzFizSjNFDoQ9uZwN5AcEPRrzb2iVEv+RT4UFCGQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1749228506; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=za4OfKA+ZM6zV60/HKnwP61V+8x3zdpeOiThEah6L0g=; b=gO+pqDsFdSn9VEj+terv9P2NM+AJdKIv2JXj/qX+GkCLjayEusUAgTe6+IHLTexcsxK21AtG331tcfZyuQdjhCxEsdNcv+bi37eQS9fn2gd3i9Oa2jw2MwesXeUU/If1FIYsimBZvuIAby/EI8nGHmhOQKfBr8pIiojsal5tG7k= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1749228506151176.82604260256403; Fri, 6 Jun 2025 09:48:26 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uNaC2-0004xB-AT; Fri, 06 Jun 2025 12:45:22 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uNaBz-0004tQ-LU for qemu-devel@nongnu.org; Fri, 06 Jun 2025 12:45:21 -0400 Received: from mail-wm1-x32c.google.com ([2a00:1450:4864:20::32c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uNaBx-0003Nu-7g for qemu-devel@nongnu.org; Fri, 06 Jun 2025 12:45:18 -0400 Received: by mail-wm1-x32c.google.com with SMTP id 5b1f17b1804b1-451d7b50815so20351675e9.2 for ; Fri, 06 Jun 2025 09:45:15 -0700 (PDT) Received: from localhost.localdomain (59.red-95-127-62.dynamicip.rima-tde.net. [95.127.62.59]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a53229dea7sm2431121f8f.12.2025.06.06.09.45.12 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 06 Jun 2025 09:45:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1749228314; x=1749833114; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=za4OfKA+ZM6zV60/HKnwP61V+8x3zdpeOiThEah6L0g=; b=GCoQGPp+QGNlneZQg8feSdT0IO5VTZqr0KjMrK1CWQ2f1Y8aaO9BqBy0lgGMUIONXb G2o3hyevlV2UCUHBZteNKEfYi4lVNjBHPXSwjUW7sVZwG1s+lWtYvrOYell6EshLDiSn Hpw+7N3BHorE7Zw5FUqqThKpLQYlwOEW3bIpJzNTSq5UJVq/Kx6eHI6o9Lj1fPCSIQuP m7uCYP1FeSHh9hync7vfnFyuJUqpR94owtIS6UplegRatqc9PQ6gy6ygNGfCgRDehAAT jvNySmcHoC7tqtyemt8Q6xXScdTPtmV6rKdNBJSYTZlsoaFrXtoD0Id+zLEDn8QhUk8y ouwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749228314; x=1749833114; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=za4OfKA+ZM6zV60/HKnwP61V+8x3zdpeOiThEah6L0g=; b=EMVDKXoK09EysVHVa4WDr0yO0WPj5I5C/ahdcPrtuAAYcBcpIrwC/Rsb9uqAI4sp+X 3J3/irpMViUy/Q9WoKC71Po/YjRZ3y1UoFcC8NJpaHD0bQHh9fV0HC2PHLA5BiomOQ4w UDh1D3O8OqN6HOkzPYTihdHXxnC4oG1gvgiXZkSToymmWdN5nUHnc1jyINRhcOWHCp9l qPo2HaZ7/Jm0Rbd/V3YNQdZbg6A6zdSj8dHX8PLVvDoEvgseUGAngmbMPA+jYEMKg/CA k3H2Xe04vIzp3Jrwg2CmuremxhLcOwCy6MmdL7bUUcwWIRSDdwCib5l9D43IUzCVintO 8fVg== X-Gm-Message-State: AOJu0YzEw5r0WC2Cbmd5lxIGIpHcXOwCSLizaeySeuj98CiIZCX3QpWm W64SYn/NSJfZUHA2HMWkJVzkIx9XJ9r43ZNri0k8l4LeQwyYAu4JN89nKvyPvrn0jgYXUipy0Qh KgAYw0UZoBw== X-Gm-Gg: ASbGncu3J1t9JkNQfWErNiey83JcGNsbKQKdBSc2PaWTbQ7OGXDJZy9o+iBHEDNce0S Gn17fuVxsRcsjaKtePePLD0Gxy1I/Ls0GHmEctVQE+JPeDc4uABHiBs0iF0oppzleJ/QNVKgvs9 75Flvd+nM9JCfmaa4CNmTZ86TfLBM3/ux1+veUEM3kTrvGNzmS0olRl3mVf3udnKQqy2x8xlmvt 0M6/K0OvI6yyqYMckBKCtgpRTwjZXJ6+KsT94tbENqwusxrMu4HTIlsydbbA6fLMfwDnLN9LmIl E/TvR8l7JQ+3jjw6h27wj5m2PEwWH1AACAXBZ9iJ5FTMQvOqxHdotc6sZuLIHfzkIe0VHcup5Vf Ah8dqf1hrIsjFBV2B5HXy+M0vyqAIXOLRPwvWPg== X-Google-Smtp-Source: AGHT+IEjSinlxGgF0FigYMIbyMdqDg7XFFwUvXebA+wAtPU7UTy04H353qxRggmeMlVzRt0NOrPPTg== X-Received: by 2002:a05:600c:1c90:b0:450:d01e:78ee with SMTP id 5b1f17b1804b1-4520140b8b5mr42932815e9.24.1749228313673; Fri, 06 Jun 2025 09:45:13 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Alex=20Benn=C3=A9e?= , Richard Henderson , Pierrick Bouvier Subject: [RFC PATCH 07/19] accel/hvf: Re-use QOM allocated state Date: Fri, 6 Jun 2025 18:44:06 +0200 Message-ID: <20250606164418.98655-8-philmd@linaro.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250606164418.98655-1-philmd@linaro.org> References: <20250606164418.98655-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32c; envelope-from=philmd@linaro.org; helo=mail-wm1-x32c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1749228508028116600 Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- accel/hvf/hvf-accel-ops.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/accel/hvf/hvf-accel-ops.c b/accel/hvf/hvf-accel-ops.c index 808ecea3816..f4a983d1328 100644 --- a/accel/hvf/hvf-accel-ops.c +++ b/accel/hvf/hvf-accel-ops.c @@ -319,7 +319,7 @@ static int hvf_accel_init(MachineState *ms, AccelState = *as) { int x; hv_return_t ret; - HVFState *s; + HVFState *s =3D HVF_STATE(as); int pa_range =3D 36; MachineClass *mc =3D MACHINE_GET_CLASS(ms); =20 @@ -333,8 +333,6 @@ static int hvf_accel_init(MachineState *ms, AccelState = *as) ret =3D hvf_arch_vm_create(ms, (uint32_t)pa_range); assert_hvf_ok(ret); =20 - s =3D g_new0(HVFState, 1); - s->num_slots =3D ARRAY_SIZE(s->slots); for (x =3D 0; x < s->num_slots; ++x) { s->slots[x].size =3D 0; --=20 2.49.0 From nobody Sat Nov 15 17:17:25 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1749228449; cv=none; d=zohomail.com; s=zohoarc; b=nKpm9AdUkmKNUZGHMhCMeX1SAlijTVDNjfFKrYz6+HhYYc0bUZej1H5MXnE4Zh06Qe5Rl2iek8EBfKVKyyS+b4LSGKEftnJ7WGi0fG8h1NYQsZyx++Zh5htCiT9smlTovHHSQgKNjfaayhBqxfHnbQwAydM77HDtMbEoWpam5bc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1749228449; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=3rGEJzRlC4Fsxdbk2GIFasmygNDXfJQlCwnu7QAb7e0=; b=Q8qMeZ0qjXNINwKkfwbiq67AlXZFyLl0X9OIggYFubd8Q/zjodaInYzCwGwdoaakfZuLNKtFPXdqP2SI/U+Lo1wz9Op1g+h3ZqzUiuKmfXGUK31xc8XIiPgWLesaT4KhgGRSP20Ao+Pn3kf+qhh4jhhiwtZ2cjUweh7XSE5cv94= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 174922844924519.218072986347124; Fri, 6 Jun 2025 09:47:29 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uNaC7-0004zq-Ac; Fri, 06 Jun 2025 12:45:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uNaC4-0004xz-RO for qemu-devel@nongnu.org; Fri, 06 Jun 2025 12:45:24 -0400 Received: from mail-wr1-x431.google.com ([2a00:1450:4864:20::431]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uNaC3-0003P0-Bp for qemu-devel@nongnu.org; Fri, 06 Jun 2025 12:45:24 -0400 Received: by mail-wr1-x431.google.com with SMTP id ffacd0b85a97d-3a507e88b0aso2118269f8f.1 for ; Fri, 06 Jun 2025 09:45:22 -0700 (PDT) Received: from localhost.localdomain (59.red-95-127-62.dynamicip.rima-tde.net. [95.127.62.59]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-451f82878acsm35550495e9.0.2025.06.06.09.45.19 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 06 Jun 2025 09:45:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1749228321; x=1749833121; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=3rGEJzRlC4Fsxdbk2GIFasmygNDXfJQlCwnu7QAb7e0=; b=AiaO9F+yxOuBXKFwiw0grjQPPOWRiGZ1N+nMrlQLtoUgjzhZqBNxog4FgYGYXO+gcc EidGG1+kOaUDbwQ3Q00LTqWVFAM1SpRKMZrRzdi4Xi6tQRjGRAe+tQ7fJcSYLpKBRk2G Un3ZDqQChxmKuNaYagpXMIIcWLO7/WG5pTzCEsoQiJ3jrPk3PdIntKLpUlEc6ll5jF2u AZNBR/StrP+9ee1qq3cstWlq1T+YxHCpC2Dr81k1XVC6TzjrlfGvasOyMIv+rH1ojlRi uLJdcVYkn+ywjxBqbZdMwY7tgpMojEKKe3HKW5v/BQB0RJh3QQl57LxVc9ZBt54YaqFZ MKtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749228321; x=1749833121; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3rGEJzRlC4Fsxdbk2GIFasmygNDXfJQlCwnu7QAb7e0=; b=ZkhXnwRfGBlZL5TYqtXfgwDYX2IHuS75aIxZMfITTNK5J2hd5CLGMt3omi0QWaHygI 9n02e9We19va357dhTfnVMTfbzHUQmyBv9yj5xu8mCPDdjy3hvvm3d6tnXCNf/ssv1LD ULHJeqfa9nx48xGwZI2Viv89bOzQgUc3OQSYBbsKPc01N/DMhepcCQ1LHQMye03SYxOt jA8F+/m11LNkhz19Pepjiodr9/I+KVrsIvf5yQk5jVNUhJa9EDzydQi6+K4cNJPvwt4q 3S+PQ5pgDgs3GPb4qXtZNTavFgr5flu5ElaxnHG5Cw/eoa3EaQCiPI47M2TPlog5qkT2 lzpQ== X-Gm-Message-State: AOJu0YwwpqJUat/9Qiz0Gm/12WMKkOV5TV8eCW+vp/Ga5MvLVrDajlFT 7fFAnAaqlJEMrdOVlp+K9YcXDaZA9KYbWa+ojGhDjlOXoilsEQMNPx1RkzeOpsXnk2/BZWkQjNc paj49BcDtHg== X-Gm-Gg: ASbGncsoJSc+cY6UcmiQZnzoRakmPVNud2KRIjxczqgdLFRfiAiZ8uEzNoHjjMxNUN2 zNNWjLv4JIdzspD8pwmAG2Lla4foEy24Qfn76o6m9WBZrOCP+iPNR0+FXdtzJXrcYSdG4sobyPb N2YTPUumrE2U2Hg8cflMblFlGcFCj7+7ih1xY8uIpYs7NvxqT6xjZlicXBb3+lXo5RqJ1upSEWp kBnBqi5lurqvie91/639LXYcytJxRBtLhmbF7dssLvyBaZzExE7cJAA/nBa2FYw42PTt9MXUuKG hoBF/rf2TFkaZ5lMQavJdQXx0datA+jpi4GSm4JdPVU5guLRw0qfmJjj6QkOJ/8FEfGZ6HbYiDV wNYi48FOepn/tFSjdwnSSfyfZ0hcxVPu3Vr0+dA== X-Google-Smtp-Source: AGHT+IHipB4Jravzy/orNFjTY1wqg05TgvuL3WtTJuqQ2mU9camsarUlzg2Im3xUE8SfSw7SV6N81A== X-Received: by 2002:a05:6000:4305:b0:3a4:e1e1:7779 with SMTP id ffacd0b85a97d-3a5318a070emr3112474f8f.32.1749228321601; Fri, 06 Jun 2025 09:45:21 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Alex=20Benn=C3=A9e?= , Richard Henderson , Pierrick Bouvier Subject: [RFC PATCH 08/19] accel/tcg: Prefer local AccelState over global current_accel() Date: Fri, 6 Jun 2025 18:44:07 +0200 Message-ID: <20250606164418.98655-9-philmd@linaro.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250606164418.98655-1-philmd@linaro.org> References: <20250606164418.98655-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::431; envelope-from=philmd@linaro.org; helo=mail-wr1-x431.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1749228451386116600 Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- accel/tcg/tcg-all.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/accel/tcg/tcg-all.c b/accel/tcg/tcg-all.c index 6c5979861cf..4b1238ed345 100644 --- a/accel/tcg/tcg-all.c +++ b/accel/tcg/tcg-all.c @@ -82,7 +82,7 @@ bool one_insn_per_tb; =20 static int tcg_init_machine(MachineState *ms, AccelState *as) { - TCGState *s =3D TCG_STATE(current_accel()); + TCGState *s =3D TCG_STATE(as); unsigned max_threads =3D 1; =20 #ifndef CONFIG_USER_ONLY --=20 2.49.0 From nobody Sat Nov 15 17:17:25 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1749228379; cv=none; d=zohomail.com; s=zohoarc; b=NWetdR2JfgsSoOZmoHiEkVdSBdgE7veBN0q/lfcOoNL/2jGuRmdrkTAdmKek+6VeystUlNKt0mBWr7XcW0UTDczxqIC7+JAfXFQ7Xz30lQf3Fv8K5uwWPQNJaZvUn9Zt3TV7thi8t4VY+/rMWfDcYQkUMf+PFmt/Y06tMSTekFw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1749228379; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=mEZ1hQ5Ve/n40v+7Xdzb9ewpikW8Poa4vyefkyKHER0=; b=QCxxWW1sU009DZc32YecdxonYoglHrentCGWF17DLnflomDAYX7ROt2HqUng9g7Za3JtworVCQbQ35KU+wF7fZZ3GokXUfK8qphXIhLHntLf4iKaAg1LctFnMnOBibjmJfnWg/AY0Rm0KS33D8NR09VZZXovKvqtjisQlusSNzw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1749228379842695.7937633958825; Fri, 6 Jun 2025 09:46:19 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uNaCG-0005AK-GK; Fri, 06 Jun 2025 12:45:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uNaCC-00055C-8A for qemu-devel@nongnu.org; Fri, 06 Jun 2025 12:45:33 -0400 Received: from mail-wm1-x336.google.com ([2a00:1450:4864:20::336]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uNaCA-0003Pf-Ls for qemu-devel@nongnu.org; Fri, 06 Jun 2025 12:45:31 -0400 Received: by mail-wm1-x336.google.com with SMTP id 5b1f17b1804b1-450cfb79177so12673355e9.0 for ; Fri, 06 Jun 2025 09:45:30 -0700 (PDT) Received: from localhost.localdomain (59.red-95-127-62.dynamicip.rima-tde.net. [95.127.62.59]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a53229df09sm2376630f8f.6.2025.06.06.09.45.27 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 06 Jun 2025 09:45:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1749228329; x=1749833129; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=mEZ1hQ5Ve/n40v+7Xdzb9ewpikW8Poa4vyefkyKHER0=; b=vT2oaioRsFG1IBc2zoOjg1xHYbQ5+q9dKHkysw/FEp2C6za58VTtIL+vezMZlDBkl6 L9rIkNcBB8ZpIUcAsZ1uirZpwfwnwy6RJs80jS22DBKVGJyhMoQF8IxXLf2jt7VFcjpP za/I8yPz/rnY/6HrnkUmHmdlNfLtp0BkdVajmfYier5LwytWGrJLSLaBRExRimyISFxh /R2KpSW5/j0tFQw/MprnnH8dPsYSEF4h3bQ/ud2sGeeqz+SIQtk8PXW5c1NSFW1wa9Q7 gOVOWjtjbEdPh/GjJ35/SP36iuZMemurHhh7wCKwMFr/LjQr2SdWzPk3QYYndbW2aOQ4 InqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749228329; x=1749833129; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mEZ1hQ5Ve/n40v+7Xdzb9ewpikW8Poa4vyefkyKHER0=; b=vwQbOimsve0KqcuDZ2ZEiq09prXmY5zBf4vvsaganCb0hsXHo2nOZKbmnlxAwB/2qH CYAgpCKP21fgZZiUSnTjb1bcGKb+QT8zRxGQjaZ/aJWZ2w3pfUZr2Hq6S+WMSme8MbSQ Gy+S6JY/PKAkrc5l4NxsITrectoX3/I+R366BqHLOmiGRxEHKvO7DRePeyIwhMlBLZWq iNCZAV7CuHgRZweK3TBDNCTj2bsr3AQAxrrNjQiuEaf4ld/N1w4hypO4NQ89LO18xWs8 d32fIy8hWP1SKxNI9z8q3mg9xc3kAzPkQgyq9AOfhB7+ix1jpgnuMry+mL/Z+2Lr22XZ qJfw== X-Gm-Message-State: AOJu0YyyxoWaM3XEFf7VCaj6wn5TuHKlfH4TK7c0A9cIQcs/BFYN1UW1 VoG065IW/ykOq9oERW96qlwEXbOpmpFlhww852qng5CgIUIGYyRkljGVEhWh3QHGiAgOT82x5Ca x6WSUVh+u/g== X-Gm-Gg: ASbGncvgN9dTV7nKK2gIg2AR9Qdb1KXj+8dmpelDXt8CNUfLCmmDPGq727OSecftzDH 5+HvUQhL5MGuhGTJ1OzFZOc89ermFO0lY1/mIyfvKrVqAjDfTqfXvrDJPXSU6LLuks0sQCWKFsV M7fVo6aQSlsfOICw74nPnNbyl24qLBQU0Fr0dgUgo3eiCG4Y+4uUzW4vh7cZzHrjif6Urk03Qww RYFlhtH/fZk5z8eLsfHva1SViYpbXv7hmvTTDZl7fW0uiy8yUKbvWCvzp5O2+xEmeweaErYhHK2 bbCKQ7Dx0uHiW0y3jYLSz+ScVzKGV3IOyXOjuPeYJAavRIbULCBazgHcxOMlV8lcWIj+Nl7h6Mp pESQ4h0B0oEWr6ypxnK1gURSjpt2dp2pbiKmLBQ== X-Google-Smtp-Source: AGHT+IFICxov0pvMKxGo28Kaw+rf+i8HFY+WVoVL2vnBfNYO9OTf4i+cavlMQW0m9L0SUT+jBjjPvw== X-Received: by 2002:a05:600c:8b48:b0:43d:9d5:474d with SMTP id 5b1f17b1804b1-452013141b3mr50523815e9.0.1749228328771; Fri, 06 Jun 2025 09:45:28 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Alex=20Benn=C3=A9e?= , Richard Henderson , Pierrick Bouvier Subject: [RFC PATCH 09/19] accel: Factor accel_cpu_realize() out Date: Fri, 6 Jun 2025 18:44:08 +0200 Message-ID: <20250606164418.98655-10-philmd@linaro.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250606164418.98655-1-philmd@linaro.org> References: <20250606164418.98655-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::336; envelope-from=philmd@linaro.org; helo=mail-wm1-x336.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1749228380453116600 Factor accel_cpu_realize() out of accel_cpu_common_realize() for re-use. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- accel/accel-internal.h | 2 ++ include/qemu/accel.h | 2 ++ accel/accel-common.c | 15 ++++++++++++--- 3 files changed, 16 insertions(+), 3 deletions(-) diff --git a/accel/accel-internal.h b/accel/accel-internal.h index d3a4422cbf7..b541377c349 100644 --- a/accel/accel-internal.h +++ b/accel/accel-internal.h @@ -14,4 +14,6 @@ =20 void accel_init_ops_interfaces(AccelClass *ac); =20 +bool accel_cpu_realize(AccelState *accel, CPUState *cpu, Error **errp); + #endif /* ACCEL_SYSTEM_H */ diff --git a/include/qemu/accel.h b/include/qemu/accel.h index c660c5f4b11..3c9aaf9523c 100644 --- a/include/qemu/accel.h +++ b/include/qemu/accel.h @@ -91,6 +91,8 @@ void accel_setup_post(MachineState *ms); */ void accel_cpu_instance_init(CPUState *cpu); =20 +bool accel_cpu_realize(AccelState *accel, CPUState *cpu, Error **errp); + /** * accel_cpu_common_realize: * @cpu: The CPU that needs to call accel-specific cpu realization. diff --git a/accel/accel-common.c b/accel/accel-common.c index 4894b98d64a..4f3b42e7112 100644 --- a/accel/accel-common.c +++ b/accel/accel-common.c @@ -88,10 +88,14 @@ void accel_cpu_instance_init(CPUState *cpu) } } =20 -bool accel_cpu_common_realize(CPUState *cpu, Error **errp) +bool accel_cpu_realize(AccelState *accel, CPUState *cpu, Error **errp) { - AccelState *accel =3D current_accel(); - AccelClass *acc =3D ACCEL_GET_CLASS(accel); + AccelClass *acc; + + if (!accel) { + accel =3D current_accel(); + } + acc =3D ACCEL_GET_CLASS(accel); =20 /* target specific realization */ if (cpu->cc->accel_cpu @@ -108,6 +112,11 @@ bool accel_cpu_common_realize(CPUState *cpu, Error **e= rrp) return true; } =20 +bool accel_cpu_common_realize(CPUState *cpu, Error **errp) +{ + return accel_cpu_realize(NULL, cpu, errp); +} + void accel_cpu_common_unrealize(CPUState *cpu) { AccelState *accel =3D current_accel(); --=20 2.49.0 From nobody Sat Nov 15 17:17:25 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1749228423; cv=none; d=zohomail.com; s=zohoarc; b=goaAYG5IXNk1a4CZSYSPgpqqtXNrZkTZTVRVmKVBWHvRIHRkgsM+Hwr8Qgf4xCnW80c1iyCjWAL3ezS7q2pc3LznOx/220hkiRiuThDMEbyzfX3H/bzbU73w5VvJJLmJmFuJWlPcbVO7UGM+znzzS3tOwugyZMnIqCQ3bjcfB/U= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1749228423; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=d/XNfWiSbWGdYBzuDNRVlb7gdtXynRKks1ss0p+cqNk=; b=SZNABXkzhiQSK4SZkWPLdLMsuhsnLM5mikm5Q70JO6NDnGB+WS99HlV8p7xS5DhP7HrmBvPzyfktCx5JLJTILjmIOBJq5iaDaMjwevRBYS4dvrSmeW063oDf6985UyJw6IAwzko+CC36aMB19fzevvvt5gktlxE81h8NqoodbSs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1749228423188200.8792607525828; Fri, 6 Jun 2025 09:47:03 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uNaCe-0005lu-L9; Fri, 06 Jun 2025 12:46:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uNaCL-0005TM-3G for qemu-devel@nongnu.org; Fri, 06 Jun 2025 12:45:47 -0400 Received: from mail-wm1-x335.google.com ([2a00:1450:4864:20::335]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uNaCJ-0003QF-AF for qemu-devel@nongnu.org; Fri, 06 Jun 2025 12:45:40 -0400 Received: by mail-wm1-x335.google.com with SMTP id 5b1f17b1804b1-450cf0120cdso21939685e9.2 for ; Fri, 06 Jun 2025 09:45:38 -0700 (PDT) Received: from localhost.localdomain (59.red-95-127-62.dynamicip.rima-tde.net. [95.127.62.59]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-452fba4621csm17499185e9.13.2025.06.06.09.45.34 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 06 Jun 2025 09:45:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1749228337; x=1749833137; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=d/XNfWiSbWGdYBzuDNRVlb7gdtXynRKks1ss0p+cqNk=; b=Zq13RdC1hr+mbjJh0YMy8dt/RcaAIX/A//QgJhzb/OqYzfw+miOk/yEZAUG9fKpR+E 2CB1ITzXf8hM/w/LVCW8nLmcBlNOVQgSYoSyyZ8PaJ+5wFeLguTkuUS+nYNe9eT5aaZm uEMeTsE+OO89u/htXaBz9Qbrz7qnXLfPBgiO6VNc6H+58Z2oeiLrK3P1f8/SGtEw0MRt uTYqv4AB3c8XkGtLfP57xA54LHzlfFkyKahI/3yqB4zywA9j/lHJg1xzMXCSna1bFz5U dWMMbJ85xzQIL6CFuluqU/IljkrLMoz2ANkGdiMflYf/sJ0yA7uspSG1o4L+On6x+tYN wMzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749228337; x=1749833137; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=d/XNfWiSbWGdYBzuDNRVlb7gdtXynRKks1ss0p+cqNk=; b=UJVU1FG9AnZaZLswz2p92njpdZP0d4uLmmBBklSvAoW3UHs0NsdOQGNyiQUOhDw2np LfrDeDgmL8o752SiSwq2OFJOrxtV1048k80oKEB0RptsmpPKIDnyiHHP+rhS40SRUO/y 2iNSHyRdre5QjvMCveZPLyvDves+kEdo2J+yD29AjXjIpMMJqjM8J7d2DIMdX2xyKfuu h48azFCPlxdOx0TAJrYyiImH7hC+HdD7ctfOmqc4gec4pWXsMoc1Ano/aU9f+79T9scO qRVuy8pD9ktyhYvrL5V5d9crEFhbcr2+slyOhI0tFFyDXSQGl7wsg8y1oeDidWPWwAmY 0/GA== X-Gm-Message-State: AOJu0YzNpGr4kaADEyE8glH5LR6R9IhiU4uR/HkbAbx6ZJbh7dytBeYG 20Yt400xpxXMRMt35EfVjzlQcOhavu3tfONHKyaD+GsGlam/spIOqM/g2xxxGJeRixDzOgWeWqN N8ECntp9BwQ== X-Gm-Gg: ASbGncsnu3ec75CWQFk3A8o06zHWgYHx+2hF5rIUcNtyxD7rrhMlqdu6DO4RRalBxck qj0JZjX9eY0o3NDDv6BR5OEAHYos+kAdnAq8IbcZdvsRyy+r8n7dLtOz9Aqa2XEWSl8Iy87MeGo 3ycMooT4xhaLGLjYIwv0tD/We0xhZaLMLZeSNjJKz6IHria+vvONrntfYBt9/PMycYBspRmt8nH IsAZbO5nA/63MyxlKzsMZ/jfBK8YuxE1R4+Xuhu41q5F0kSe0+jopdJOcaQfRP7CdsBJRSz/WbZ z4ihGYIj+lMynFebRBFim71fpe9TGr/f4eKQlEH78+f5EHCuYb8qjbVWULKSM1MsOrZwFPMyoRa DQGJwEF4IyjWJW0L+nbMRG1bFC0YsRML2yRsJZxgC3XBDEt/c X-Google-Smtp-Source: AGHT+IGU+hGMKOTFmlNWWRga/zciSsEUVEbDz0Ap5vWKhtRMxHgJDnXVglly2xgVH+sdT58W1jk81w== X-Received: by 2002:a05:600c:1e09:b0:442:ccf0:41e6 with SMTP id 5b1f17b1804b1-45201340872mr50661325e9.3.1749228336787; Fri, 06 Jun 2025 09:45:36 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Alex=20Benn=C3=A9e?= , Richard Henderson , Pierrick Bouvier Subject: [RFC PATCH 10/19] accel/dummy: Factor dummy_thread_precreate() out Date: Fri, 6 Jun 2025 18:44:09 +0200 Message-ID: <20250606164418.98655-11-philmd@linaro.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250606164418.98655-1-philmd@linaro.org> References: <20250606164418.98655-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::335; envelope-from=philmd@linaro.org; helo=mail-wm1-x335.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1749228425111116600 Initialize the semaphore before creating the thread, factor out as dummy_thread_precreate(). Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- include/system/cpus.h | 1 + accel/dummy-cpus.c | 12 +++++++++--- 2 files changed, 10 insertions(+), 3 deletions(-) diff --git a/include/system/cpus.h b/include/system/cpus.h index 3226c765d01..bfaa339dd73 100644 --- a/include/system/cpus.h +++ b/include/system/cpus.h @@ -8,6 +8,7 @@ void cpus_register_accel(const AccelOpsClass *i); const AccelOpsClass *cpus_get_accel(void); =20 /* accel/dummy-cpus.c */ +void dummy_thread_precreate(CPUState *cpu); =20 /* Create a dummy vcpu for AccelOpsClass->create_vcpu_thread */ void dummy_start_vcpu_thread(CPUState *); diff --git a/accel/dummy-cpus.c b/accel/dummy-cpus.c index 867276144fa..7c34e6c0fc5 100644 --- a/accel/dummy-cpus.c +++ b/accel/dummy-cpus.c @@ -64,15 +64,21 @@ static void *dummy_cpu_thread_fn(void *arg) return NULL; } =20 +void dummy_thread_precreate(CPUState *cpu) +{ +#ifdef _WIN32 + qemu_sem_init(&cpu->sem, 0); +#endif +} + void dummy_start_vcpu_thread(CPUState *cpu) { char thread_name[VCPU_THREAD_NAME_SIZE]; =20 + dummy_thread_precreate(cpu); + snprintf(thread_name, VCPU_THREAD_NAME_SIZE, "CPU %d/DUMMY", cpu->cpu_index); qemu_thread_create(cpu->thread, thread_name, dummy_cpu_thread_fn, cpu, QEMU_THREAD_JOINABLE); -#ifdef _WIN32 - qemu_sem_init(&cpu->sem, 0); -#endif } --=20 2.49.0 From nobody Sat Nov 15 17:17:25 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1749228453; cv=none; d=zohomail.com; s=zohoarc; b=bUlORnkw44zmmQQ29Ljate9Vnqhg1JynLjft3NA9BMa8xmgxIABhVMgfnPOHgnsz/CSITpHysdGKep5y6mxjSRSw9NkQrPGpHAPKC0o11CUawr1YGrPH74BbAssT3uMTnimDBmxGsF6sK4VSiLppeXJy+I2DgMvyXPepUP0+z+M= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1749228453; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=JIuklLgT7yxDr5xUfy1gGIRFVc8VIMyOClNRwci8w2E=; b=csaHqart8KBEWBa4MXak8g1P2HFgwuavpOjrbhWv98ZM7I3zKTJMZIAm14wPJ9dYk++TJhgDNHy5Gxq0UhMNxejRSlMXutjTX/DK5mHgMG9/uLzqIWYiPbTBgvQiw3MKXqTOBeSSG1/ywd2BLtDzcYjuHEsAOoIR+KyMJ/gyFOM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1749228453444856.0142319701681; Fri, 6 Jun 2025 09:47:33 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uNaCi-0005xv-0t; Fri, 06 Jun 2025 12:46:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uNaCR-0005XD-VZ for qemu-devel@nongnu.org; Fri, 06 Jun 2025 12:45:49 -0400 Received: from mail-wm1-x333.google.com ([2a00:1450:4864:20::333]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uNaCP-0003Qd-NJ for qemu-devel@nongnu.org; Fri, 06 Jun 2025 12:45:47 -0400 Received: by mail-wm1-x333.google.com with SMTP id 5b1f17b1804b1-442fda876a6so19365765e9.0 for ; Fri, 06 Jun 2025 09:45:45 -0700 (PDT) Received: from localhost.localdomain (59.red-95-127-62.dynamicip.rima-tde.net. [95.127.62.59]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4526e163113sm27660095e9.18.2025.06.06.09.45.42 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 06 Jun 2025 09:45:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1749228344; x=1749833144; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=JIuklLgT7yxDr5xUfy1gGIRFVc8VIMyOClNRwci8w2E=; b=c/Xcs4xjeEG/V/CEggSm4wtZHaosVaCBDWRKYS/d5cN/BchFpR54Cfqo32eLcdtcH8 Ocb7I35iciCwoz4X96aoYFLpXScMThPaXD8HSU9bFZkvU6/6NMFpImRxcSawNshGcl/k ORg8REzC6RFGWpn16hnTYNk0d6g26+DOgQFkIEdCPkK0RXp/U6mJqh6OJvBqFtiANWkg SeswCruf+1Lhi4jhUxCm0yke5lP21gxXsG/c0vRivQfeEGF1Rpb97Pzd9b+T64UOkg0N GrdrddTDU/YeyT9phq44g6sXCKjlkI8jWXw9jhGAI8BvIvK36l7Q9CrAS6V7eIbpOwS9 TsGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749228344; x=1749833144; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JIuklLgT7yxDr5xUfy1gGIRFVc8VIMyOClNRwci8w2E=; b=Kl59q0+LM/yJjKJ5zg95z0L2GpaIK3oXFcWRXx3BqTq2+KZWLDValFkw60XwiPLcmO riEZ0MSPjm8ZhBrbEV1FAExn3JAT+sbTem3Kg4QStVNYZAxde60zpc4Gzt8Q/aAWFTi0 gQF/BqRoQ7qnkx1Ksf+E5yKSz1Bbn4GJUHIghfGmj0f4GEvRKSOO1Kq/hSfAVsGctxla J9vJddwkQeeouNs/AfPP3tdL7erAB6/qawhBlR5RLk1OXWIE5mcmN1DVAt3wyKS9GQrQ hqJZ5qwDP37du0Pcy8wTMNC+DeVbEhtaVJEDk1mmCPwqKNG04gA8a/OWsBWGO4yr1HN+ CP8g== X-Gm-Message-State: AOJu0YzFlGsUDJFV0sznHXzCb0gJWCbgaXnQmZVwQPoAmGMP/gMJ5XH1 2IFwj16RTYx5gFT5kcC5bJd+G9TAt902AqWPK4yMSz0Iku6QeJYeWnnFZ8NzZrif+UDDYK/3hcT bjUEhrvUalg== X-Gm-Gg: ASbGncv0/hbvRk/KETXmBwtQzMhBX0IqBtf30/hr3+6n8Dum33rYaN5lQdR2rIbUMze yAeg9fFKq2u/Z6TzjPqPnLdAjI/DuOzU1SSWE/c9n5whPWgoqme+2npqBlXrNlVNJ5L4lLgQOBV doFeMwuikzpgCmp1EjNZ7SRy1gqwRQOPvqzzPgqK3vYLrdLK2NVr3WEgNv0VmJ/rWkamJYkH28F K0vwxNUImuDDkwH8UpLx56UtLTf1xz/a0gQJdTU5oUBizKXM/naFIKJWKTlCJcD6z2Z7TLFXm5x MRrjKbM+kgcW+aztD/C75MnubE2pyylMBkONyguXkrGa7CZvzIRzQLoziQ5r9gT460Vo3kt6VeV 9xRNMAsAO70Ew9Yb/FI2Sb9fIr0pxu9eDvlMx5Q== X-Google-Smtp-Source: AGHT+IGLJmLcQIfes6jY98XoA3SWPqVf0SmUqEsPF/BIH4sJgjnuAdD68huSFTHM9R6cOKbIJ3mLPw== X-Received: by 2002:a05:600c:5492:b0:442:ccfa:1461 with SMTP id 5b1f17b1804b1-45201357413mr44755445e9.13.1749228343874; Fri, 06 Jun 2025 09:45:43 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Alex=20Benn=C3=A9e?= , Richard Henderson , Pierrick Bouvier Subject: [RFC PATCH 11/19] accel/dummy: Factor tcg_vcpu_thread_precreate() out Date: Fri, 6 Jun 2025 18:44:10 +0200 Message-ID: <20250606164418.98655-12-philmd@linaro.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250606164418.98655-1-philmd@linaro.org> References: <20250606164418.98655-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::333; envelope-from=philmd@linaro.org; helo=mail-wm1-x333.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1749228455589116600 Factor tcg_vcpu_thread_precreate() out for re-use. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- accel/tcg/tcg-accel-ops.h | 1 + accel/tcg/tcg-accel-ops-mttcg.c | 3 +-- accel/tcg/tcg-accel-ops-rr.c | 3 +-- accel/tcg/tcg-accel-ops.c | 7 +++++++ 4 files changed, 10 insertions(+), 4 deletions(-) diff --git a/accel/tcg/tcg-accel-ops.h b/accel/tcg/tcg-accel-ops.h index 6feeb3f3e9b..129af89c3e7 100644 --- a/accel/tcg/tcg-accel-ops.h +++ b/accel/tcg/tcg-accel-ops.h @@ -14,6 +14,7 @@ =20 #include "system/cpus.h" =20 +void tcg_vcpu_thread_precreate(CPUState *cpu); void tcg_cpu_destroy(CPUState *cpu); int tcg_cpu_exec(CPUState *cpu); void tcg_handle_interrupt(CPUState *cpu, int mask); diff --git a/accel/tcg/tcg-accel-ops-mttcg.c b/accel/tcg/tcg-accel-ops-mttc= g.c index dfcee30947e..462be7596b9 100644 --- a/accel/tcg/tcg-accel-ops-mttcg.c +++ b/accel/tcg/tcg-accel-ops-mttcg.c @@ -133,8 +133,7 @@ void mttcg_start_vcpu_thread(CPUState *cpu) { char thread_name[VCPU_THREAD_NAME_SIZE]; =20 - g_assert(tcg_enabled()); - tcg_cpu_init_cflags(cpu, current_machine->smp.max_cpus > 1); + tcg_vcpu_thread_precreate(cpu); =20 /* create a thread per vCPU with TCG (MTTCG) */ snprintf(thread_name, VCPU_THREAD_NAME_SIZE, "CPU %d/TCG", diff --git a/accel/tcg/tcg-accel-ops-rr.c b/accel/tcg/tcg-accel-ops-rr.c index 6eec5c9eee9..fc33a13e4e8 100644 --- a/accel/tcg/tcg-accel-ops-rr.c +++ b/accel/tcg/tcg-accel-ops-rr.c @@ -311,8 +311,7 @@ void rr_start_vcpu_thread(CPUState *cpu) static QemuCond *single_tcg_halt_cond; static QemuThread *single_tcg_cpu_thread; =20 - g_assert(tcg_enabled()); - tcg_cpu_init_cflags(cpu, false); + tcg_vcpu_thread_precreate(cpu); =20 if (!single_tcg_cpu_thread) { single_tcg_halt_cond =3D cpu->halt_cond; diff --git a/accel/tcg/tcg-accel-ops.c b/accel/tcg/tcg-accel-ops.c index da2e22a7dff..e58e1c3738f 100644 --- a/accel/tcg/tcg-accel-ops.c +++ b/accel/tcg/tcg-accel-ops.c @@ -41,6 +41,7 @@ #include "gdbstub/enums.h" =20 #include "hw/core/cpu.h" +#include "hw/boards.h" =20 #include "tcg-accel-ops.h" #include "tcg-accel-ops-mttcg.h" @@ -68,6 +69,12 @@ void tcg_cpu_init_cflags(CPUState *cpu, bool parallel) tcg_cflags_set(cpu, cflags); } =20 +void tcg_vcpu_thread_precreate(CPUState *cpu) +{ + g_assert(tcg_enabled()); + tcg_cpu_init_cflags(cpu, current_machine->smp.max_cpus > 1); +} + void tcg_cpu_destroy(CPUState *cpu) { cpu_thread_signal_destroyed(cpu); --=20 2.49.0 From nobody Sat Nov 15 17:17:25 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1749228423; cv=none; d=zohomail.com; s=zohoarc; b=cJ2QMe138eGSVTU56vxvvMIh8eU5fPXznvTtxmO1Z5pCWw3NIvFhJRHNo5s8PhGL0sdreJNR0pucPPwKJ4CTbPY8qP3RLbTxf54cdpR5N075QAPzmBlk5iwDJkecYFzNF3CQk57vHUX6+BhZoPs8qhAl7YsjN4CTBwRii9hPw/w= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1749228423; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=UaqgBc+8IPd+F+DKqw2/dlO2PgT1d6b4+qh/jcNGS0o=; b=NnjOnchCNB1qMqoJWvoiQBONk8haFbbwYwFDFKVjaBosK85+hKBFvTXp+Y0l2HrbjmnX1fuTFN1u6zfTFJd1iRqWeixL3RMxnYIypEbbFbUhjbOSfmkyIiFzBFuXj4MmStpVG0KbawdWVyakpJIkSWJEfUUKlo4yLft5jgKnTUY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1749228423044216.20824391067322; Fri, 6 Jun 2025 09:47:03 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uNaCh-0005xA-V2; Fri, 06 Jun 2025 12:46:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uNaCZ-0005YT-My for qemu-devel@nongnu.org; Fri, 06 Jun 2025 12:45:57 -0400 Received: from mail-wr1-x429.google.com ([2a00:1450:4864:20::429]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uNaCX-0003RC-Ll for qemu-devel@nongnu.org; Fri, 06 Jun 2025 12:45:55 -0400 Received: by mail-wr1-x429.google.com with SMTP id ffacd0b85a97d-3a522224582so1435798f8f.3 for ; Fri, 06 Jun 2025 09:45:53 -0700 (PDT) Received: from localhost.localdomain (59.red-95-127-62.dynamicip.rima-tde.net. [95.127.62.59]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a53244fd02sm2330320f8f.75.2025.06.06.09.45.49 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 06 Jun 2025 09:45:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1749228351; x=1749833151; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=UaqgBc+8IPd+F+DKqw2/dlO2PgT1d6b4+qh/jcNGS0o=; b=ztDm1INrsjBP4xUKGJhwETQGgiILgQ5uD+cVjqufE1UqGW7May8UivU2CgGFMxT6CK iW/qCOafAJlNu7QBB9jWISRgCrAyDJOn2Vej5CZxPp1XhpUsf1xLTJNkhQWnbgdsKBFH YfpvQjfm1cmA5PIwnAfAmKyp9dOceOLUmwhXYoGsCuseHhqwTxkUjAtGdKuHkEvVTPiF brjNskbZ2DLOL/hig57eUTG6SBUAwT32HjDpK17XIdaFUbAp2sMBeM2tRszsXrnqEYVI zU/ZGeNWqOtPbe2za+To/z6lx7ZAk0e432BnnOKFK6nDKC1WZZPDxR5TAwEk8aSaPJ9w nYMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749228351; x=1749833151; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UaqgBc+8IPd+F+DKqw2/dlO2PgT1d6b4+qh/jcNGS0o=; b=JrCiuB2eWP6GqCechsbaAcYZkuHkvpCep3ZY1cZXlzZOPMgL0zrecPbmta5U2H0oko ftFdPHf1UZRFAloWmTJsQu0I5ORXZZjHaoneqrJ6i1ft2lz1xkSxXfJaDxWAiHclSTZX xtb+DpIch0MZ44MbQhqcdU2kls4TU8Uauds+kyxR5lOAaT/D+kAQUOGjtVNU4Elb2rNW kJ2wlX2IY9HID/3gRYbJIK3kT/CabmMyWoEhkJXFPnCCRv0frxXypbAOSjmbsn14uP68 IXokIBaC5MkR2xIBXPc8joMOoJU2vlTPFq+OOHGCZueod2Ffz0HrDgA7bKPZcumifETw mV1A== X-Gm-Message-State: AOJu0YyIFiVltjumqosUO2pNVQjt5hGMX37Z0A3JDeYtIPFd3m+GWxLM vszPXuy4HlVbGm4qQlA6wmJ/zRMfvmR56EkOt0wLpGSgmLKex9tU0NdbZ/dqCZ2zto3O5eOX3QJ RGDHAxcXydg== X-Gm-Gg: ASbGncv4dCT/yMIpa+eufhWWcDDGDOeL+2odoD56sY6GIdC0a9DDUSDMF7juRIQtUwq Ni1sw64WM9/IJ+R3PZ9h+Q/jCcMPYFZWCf39NgxlQ9H72LnO5gCuowJvxvmBNFx25TLpQvCUUvR IiLNlhrcyjGR2tLlUXx+wBulwbXa3FnmCPRx7hxW5k8L8A+l+2l4HJPVFpQ5vaRckm+rI7jrHqt 9tMBhDX3kF8gLXxnfR8xMgww4Jq3Ie1EJd42z8xonim3bczffbRWa0HcwzojUl4ElDaR50ruRHm Gdb9UycrmTzKrEfHju6U/APiier6yEGL+Rf98HENw5aPBSW+hYsORzwK1ObjItvGOCtq/L1H5Uu chW0JxhPJryh6X2ip7o8TR/+BQzGWMx1xkj6efg== X-Google-Smtp-Source: AGHT+IHy3I3xniHdl9pP2pmVXsFrTxR4qRcns7OlZAb6H/2bqDPkN/Nsdjdsfxf0oTgi5COmBZKwgA== X-Received: by 2002:a05:6000:2c11:b0:3a4:e393:11e2 with SMTP id ffacd0b85a97d-3a5318a9b08mr3551108f8f.34.1749228351303; Fri, 06 Jun 2025 09:45:51 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Alex=20Benn=C3=A9e?= , Richard Henderson , Pierrick Bouvier Subject: [RFC PATCH 12/19] accel: Factor accel_create_vcpu_thread() out Date: Fri, 6 Jun 2025 18:44:11 +0200 Message-ID: <20250606164418.98655-13-philmd@linaro.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250606164418.98655-1-philmd@linaro.org> References: <20250606164418.98655-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::429; envelope-from=philmd@linaro.org; helo=mail-wr1-x429.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1749228425079116600 Factor accel_create_vcpu_thread() out of system/cpus.c to be able to access accel/ internal definitions. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- include/qemu/accel.h | 2 ++ accel/accel-common.c | 20 ++++++++++++++++++++ system/cpus.c | 4 +--- 3 files changed, 23 insertions(+), 3 deletions(-) diff --git a/include/qemu/accel.h b/include/qemu/accel.h index 3c9aaf9523c..a351eebe567 100644 --- a/include/qemu/accel.h +++ b/include/qemu/accel.h @@ -93,6 +93,8 @@ void accel_cpu_instance_init(CPUState *cpu); =20 bool accel_cpu_realize(AccelState *accel, CPUState *cpu, Error **errp); =20 +void accel_create_vcpu_thread(AccelState *accel, CPUState *cpu); + /** * accel_cpu_common_realize: * @cpu: The CPU that needs to call accel-specific cpu realization. diff --git a/accel/accel-common.c b/accel/accel-common.c index 4f3b42e7112..6bd4ef47c2c 100644 --- a/accel/accel-common.c +++ b/accel/accel-common.c @@ -10,6 +10,7 @@ #include "qemu/osdep.h" #include "qemu/accel.h" #include "qemu/target-info.h" +#include "system/accel-ops.h" #include "accel/accel-cpu.h" #include "accel-internal.h" =20 @@ -88,6 +89,25 @@ void accel_cpu_instance_init(CPUState *cpu) } } =20 +void accel_create_vcpu_thread(AccelState *accel, CPUState *cpu) +{ + AccelClass *ac; + + if (!accel) { + accel =3D current_accel(); + } + ac =3D ACCEL_GET_CLASS(accel); + + /* accelerators all implement the AccelOpsClass */ + g_assert(ac->ops); + + if (ac->ops->create_vcpu_thread !=3D NULL) { + ac->ops->create_vcpu_thread(cpu); + } else { + g_assert_not_reached(); + } +} + bool accel_cpu_realize(AccelState *accel, CPUState *cpu, Error **errp) { AccelClass *acc; diff --git a/system/cpus.c b/system/cpus.c index 4835e5ced48..b6dff01c7ea 100644 --- a/system/cpus.c +++ b/system/cpus.c @@ -709,9 +709,7 @@ void qemu_init_vcpu(CPUState *cpu) cpu_address_space_init(cpu, 0, "cpu-memory", cpu->memory); } =20 - /* accelerators all implement the AccelOpsClass */ - g_assert(cpus_accel !=3D NULL && cpus_accel->create_vcpu_thread !=3D N= ULL); - cpus_accel->create_vcpu_thread(cpu); + accel_create_vcpu_thread(NULL, cpu); =20 while (!cpu->created) { qemu_cond_wait(&qemu_cpu_cond, &bql); --=20 2.49.0 From nobody Sat Nov 15 17:17:25 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1749228425; cv=none; d=zohomail.com; s=zohoarc; b=MK6zW51Bi/ehFSJx1b5c//grtyfwzloJSGoVQOXe7EAJUqVwMI9dkxG5k9QXv3AOERsj25/ZvOY0CsxQVWU/qGwJuokI+9EEDwT0AE+SHHqCtn4gdePzc9jlR48Gi5mLCtM3UkUacv2JWThremtj+JxUCjRP9FwY7qvqkVdo2LA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1749228425; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=pwxS6tGZTBGZ4r+Yv78QnnlZaFN0K0U25unYT1xV8tg=; b=joy0gcb/zVQ3yyfIePXfkK6bsVLQ8xACflxksNcIl82/Pz7m9t8ZcE5i4FYqwvEAbxZbADiTmAVnU9KTVKnNiBjv4dn1I5lIUwB6IEiyhnDg4ZdR9AtlHGoy2ENoM+T0nmAx9X6Gkp6Y0JUs9Bb5NzL8XNS/kB8e+FH7vPPNDPc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1749228425061530.7760761991531; Fri, 6 Jun 2025 09:47:05 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uNaD8-0006RF-8m; Fri, 06 Jun 2025 12:46:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uNaCh-0005xE-0L for qemu-devel@nongnu.org; Fri, 06 Jun 2025 12:46:03 -0400 Received: from mail-wr1-x435.google.com ([2a00:1450:4864:20::435]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uNaCf-0003Rd-1m for qemu-devel@nongnu.org; Fri, 06 Jun 2025 12:46:02 -0400 Received: by mail-wr1-x435.google.com with SMTP id ffacd0b85a97d-3a366843fa6so1230461f8f.1 for ; Fri, 06 Jun 2025 09:46:00 -0700 (PDT) Received: from localhost.localdomain (59.red-95-127-62.dynamicip.rima-tde.net. [95.127.62.59]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a53244d66dsm2362103f8f.70.2025.06.06.09.45.57 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 06 Jun 2025 09:45:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1749228359; x=1749833159; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=pwxS6tGZTBGZ4r+Yv78QnnlZaFN0K0U25unYT1xV8tg=; b=X+l92fH4QjokPYM3ltqPbj9NGQWusb3ojs+8gziS5UKk6g8YA7xaNeLR63vyh9EDDs 5DOHWl7bBh0HS85XFla+h23kHI/0ckvU0YSKk4QP2cMhsla9ILFFXxsnA6fxaTSuld+Y kX7MIu82ArKfZzFmi3mzMcYpWFSQyhKPvm+2maYRTaWMemaeplp1zBW97vwA3jXV4lPg sWtAO1FR8GozqBZRn2WMEsKhpXkgzacMuyID6D+3s2lE4CjrAUdiIaI4KtVZqQ5cV9r6 UJ9N7hxjAEuFV6z+cNaSoAwHVWmUid1cJfnPjZmpcqTfa+8BNSif3jklDNqz2Js+Z43K uIxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749228359; x=1749833159; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=pwxS6tGZTBGZ4r+Yv78QnnlZaFN0K0U25unYT1xV8tg=; b=g6qGdKNePVXCG5/tc09JWHrAj6SHYL1cxVBGqBUbg1XchRAWcmoc7NqJ57YDHAKDO/ Ti6aOWeG+Ij8OyfK4gaYKas+J57+SBIWhP5nXyJvkX/JbpBIFQiHFxK3mPZHHWHocgJ3 tEH/dmrd5pebeHJGnKRGUANkcEU/X8lo/tyyi59zhRLx0mDpKgtkwZTVNDn9bhmIHs2v IOsWHbSo27BWuKAhPiJxWa1bi4OPLT4ZlK8NxJDEiHtEvMC4XLKjzdw0PZHUn9RVGi7Y Zg3KM3KBP/KOzlluo3FL+ThWqcrFrFeN78VdklmgUEP3/EtV7mpw0xeHrrEzaG15osaf U29w== X-Gm-Message-State: AOJu0Yw2131KFVjYxuisIfr1NTKPyhU5zqT45dxLVZmpfcxeoDiFQX4b b7NjWdFCuddaD6yXf/FaJUnzmheQFEFjUSqBMy65cUV1QR6laVIRFwf/I0lS8Ibyp/gHKJb8QFb 4nZYCOYQm6w== X-Gm-Gg: ASbGncvmrTZ+15Y5V4+u2gf1y1pXo2FflAEXx/juqZLcmva6pFKP5uJPCuZdW6LYt12 geMHBwC1CE4KhYEiSeNczAPTON7bqIAShQblc9PTrF5wRmuPMNBejr0vpjJMFdkOqoHiZftXfPq Ivv1TUiEXwPScWIBXi/VPj+CMIRToovQTx5btUxnADOvjs+9R8G9DBhaJEJeUgjjMTInWt7U8qR rPx5zVN+jrP50jgPT2UPHLQ5NL5SRVBYhjNRidtNkzxTAlcPGr1ZGIox12Go7k3DAgU+DLpXH5b KN5X04gSyrWtoH6kZUE+agN/xEji1RW9pApODNfDFO1D+d4w8DtVzoFNXeF2AcnqW+Ui0GQTjwA xPCIvuzfFxpVm6dHgRy+2pk8J0hzX7vGxUy08+g== X-Google-Smtp-Source: AGHT+IG4SC6b/prO8grC06Fyujv0dozi6SX5wubmWB35gjpsLmmWO0Fruyy7K1QksvT8hUk2MrB+AA== X-Received: by 2002:a05:6000:1a86:b0:3a4:f723:3e73 with SMTP id ffacd0b85a97d-3a531caa50cmr3448182f8f.16.1749228358894; Fri, 06 Jun 2025 09:45:58 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Alex=20Benn=C3=A9e?= , Richard Henderson , Pierrick Bouvier Subject: [RFC PATCH 13/19] accel: Introduce AccelOpsClass::cpu_thread_routine handler Date: Fri, 6 Jun 2025 18:44:12 +0200 Message-ID: <20250606164418.98655-14-philmd@linaro.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250606164418.98655-1-philmd@linaro.org> References: <20250606164418.98655-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::435; envelope-from=philmd@linaro.org; helo=mail-wr1-x435.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1749228427183116600 In order to have a generic function creating threads, introduce the thread_precreate() and cpu_thread_routine() handlers. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- include/system/accel-ops.h | 2 ++ accel/accel-common.c | 16 +++++++++++++++- 2 files changed, 17 insertions(+), 1 deletion(-) diff --git a/include/system/accel-ops.h b/include/system/accel-ops.h index 44b37592d02..a6535a07343 100644 --- a/include/system/accel-ops.h +++ b/include/system/accel-ops.h @@ -37,6 +37,8 @@ struct AccelOpsClass { bool (*cpus_are_resettable)(void); void (*cpu_reset_hold)(CPUState *cpu); =20 + void *(*cpu_thread_routine)(void *); + void (*thread_precreate)(CPUState *cpu); void (*create_vcpu_thread)(CPUState *cpu); /* MANDATORY NON-NULL */ void (*kick_vcpu_thread)(CPUState *cpu); bool (*cpu_thread_is_idle)(CPUState *cpu); diff --git a/accel/accel-common.c b/accel/accel-common.c index 6bd4ef47c2c..39eb2b2c1be 100644 --- a/accel/accel-common.c +++ b/accel/accel-common.c @@ -11,6 +11,7 @@ #include "qemu/accel.h" #include "qemu/target-info.h" #include "system/accel-ops.h" +#include "system/cpus.h" #include "accel/accel-cpu.h" #include "accel-internal.h" =20 @@ -104,7 +105,20 @@ void accel_create_vcpu_thread(AccelState *accel, CPUSt= ate *cpu) if (ac->ops->create_vcpu_thread !=3D NULL) { ac->ops->create_vcpu_thread(cpu); } else { - g_assert_not_reached(); + char thread_name[VCPU_THREAD_NAME_SIZE]; + + assert(ac->name); + assert(ac->ops->cpu_thread_routine); + + if (ac->ops->thread_precreate) { + ac->ops->thread_precreate(cpu); + } + + snprintf(thread_name, VCPU_THREAD_NAME_SIZE, "CPU %d/%s", + cpu->cpu_index, ac->name); + qemu_thread_create(cpu->thread, thread_name, + ac->ops->cpu_thread_routine, + cpu, QEMU_THREAD_JOINABLE); } } =20 --=20 2.49.0 From nobody Sat Nov 15 17:17:25 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1749228396; cv=none; d=zohomail.com; s=zohoarc; b=BjLxZ9R66q/oTVQ+k9D1B3Z9bpBAkaO/h/7D5QNdhNrghtQvsd2LalAFFNA9DsMYbmhbdY7BOlCE8FS5U2+x/lqqnT1+PgoxAcTyKMyXQNGiawxTSBK73+i1ri91EkOv/owEKmpxHHvuGrlQM5P6cRAoR+WYUDLXOC6laapILuk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1749228396; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=hNDNfI0qG9TUFAdzgUh03+hHn2rhRAOW0ter/WGtavA=; b=YigjFQwcQfSDtkeuALrfkpHbDRo2wB1+oCUeYP9FnkGi6clM1fXOageRNWufx/ZXDEW+Itr5bb7xAqx+oBaAdmCBkgYA4lg0wrrr3fezoP5mSZy3dQbre/8G19I7Vwk7gi/wGdbjimKTYWvzS63GLwktHMtLC7RFPvIZfTvSCP8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 174922839658483.58745696107053; Fri, 6 Jun 2025 09:46:36 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uNaD9-0006aP-TO; Fri, 06 Jun 2025 12:46:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uNaCo-0006Bh-3O for qemu-devel@nongnu.org; Fri, 06 Jun 2025 12:46:12 -0400 Received: from mail-wr1-x42d.google.com ([2a00:1450:4864:20::42d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uNaCm-0003SC-EY for qemu-devel@nongnu.org; Fri, 06 Jun 2025 12:46:09 -0400 Received: by mail-wr1-x42d.google.com with SMTP id ffacd0b85a97d-3a35c894313so1946011f8f.2 for ; Fri, 06 Jun 2025 09:46:08 -0700 (PDT) Received: from localhost.localdomain (59.red-95-127-62.dynamicip.rima-tde.net. [95.127.62.59]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4521370936esm30071185e9.20.2025.06.06.09.46.04 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 06 Jun 2025 09:46:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1749228366; x=1749833166; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=hNDNfI0qG9TUFAdzgUh03+hHn2rhRAOW0ter/WGtavA=; b=h48OmWATQoOfb1lCMtfKQhArpGp0k7bJw3bRZGaJzo9Fx3L/G5v3AAjIvUze+60kcH UMGdDP3nwg5PD9MOaQ5mU+mBmb0LCDFj6TATlyXNQwkxh7bsg+rWj9b2DlcK9Ovt3HiA T4AeF+kjEh5o0Blvv52zde+KIPlfbzr0LnoaGxIFxBNn4EubRb7bz5tIQwtzAAlKDvQF YyFhyUtk5fwPj88lcoQhMu/SSYCSNrgQovpUojFnxfbdyizBQv/+8jM2RwdadlGUc8nJ 6FwlFHYXjc9JnnZM1nQCTPSc7lax+3vptw7QIqV8PFO8xO8dBsN1soMFO2Vt2SnNjFM6 nHsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749228366; x=1749833166; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hNDNfI0qG9TUFAdzgUh03+hHn2rhRAOW0ter/WGtavA=; b=VpjEHvIfkhKgWKgYJf2BgMwK7EM5HrA284KZ1eu3Y55JxK1sXyDKu2Bvw38Bzjqh31 mJbw/4Aii9T8wgaSEnzL072PVgNRKORsU/iiQfGBGsfR+QeSbOJ/fGr6hFg+JiVkDQis UxrjLLx1SV0cmGRKidfltF8CH6rNE0k7TxB0+aqEJwOV0Qzcf99+PADmD6/nDhKX3U8F s50egIpE8wAX8cK5IsMT6ZqC5ETnnC88vCrJHcSSNHBKvdqRlmYufdVV4WSrx5Ikajhn lXVqTnvWN2YmSPcFKu213cxwYNZheemXdTWxhOD2BJW6iAkmDOisC6y8BGy22Vxfr036 NGwQ== X-Gm-Message-State: AOJu0Yx7OY2YPh3buKdxE+0wuB2dX/p7cY3mzKm2fmerwMfpXtlnUPBr Ypjha93Y9SumkC61JT8B0Kr3L0V5fG/hnjb+6MJg2lkLw8KBJqGXuHyokjMECu9wT9Kie0N7UIM 1XcYVRkyFbw== X-Gm-Gg: ASbGncsMwmcpPb0oSXvyTwT1rletFN5VYf7M5JdDWdA5VDvQxws//OhQibHOClW1mff A01lQAT0bKl9z8qSKK/h1Pg4vqubD5DTrGzIgZu0OfCFJHQwRX+gOurJmiMXAhFD2zQm6YR7XNm +M74ZNwTu7J+LFHqCjHFmymbDnG8rMQDC2esFOV8dUxPQvvnIxqBrWItKTob7Y3dKDN6IhgJOHA 4CcgobSOx/Ss4Ohb11bY3DGpYusWh05GbQb9g0QK7qYjlkCitfzddBA7Q06kt4LkNkWFpdNDp57 hqGsBIy83Cx9jmd1EX7BSLe79KR6ELZN4wwaOfxZgIGjPl4O1WRWfCCrGu3R9x7NFwQfbviey0F xfTDPvdUVUFT8b1w9Mxpp0KwIttIkMxV+rs+MXiEXFCL4u1HX X-Google-Smtp-Source: AGHT+IGb9O9jUeVc8U28MjhJudT9XBh0KuYkIeyLBIkTLVk2gTPSrlfcqytDyUJBTDv8R2vcT2Ja3Q== X-Received: by 2002:a05:6000:24c7:b0:3a4:f71e:d2e with SMTP id ffacd0b85a97d-3a531ce8887mr3630177f8f.56.1749228366439; Fri, 06 Jun 2025 09:46:06 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Alex=20Benn=C3=A9e?= , Richard Henderson , Pierrick Bouvier Subject: [RFC PATCH 14/19] accel/dummy: Convert to AccelOpsClass::cpu_thread_routine Date: Fri, 6 Jun 2025 18:44:13 +0200 Message-ID: <20250606164418.98655-15-philmd@linaro.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250606164418.98655-1-philmd@linaro.org> References: <20250606164418.98655-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::42d; envelope-from=philmd@linaro.org; helo=mail-wr1-x42d.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1749228398920116600 By converting to AccelOpsClass::cpu_thread_routine we can let the common accel_create_vcpu_thread() create the thread. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- include/system/cpus.h | 4 +--- accel/dummy-cpus.c | 14 +------------- accel/qtest/qtest.c | 3 ++- accel/xen/xen-all.c | 3 ++- 4 files changed, 6 insertions(+), 18 deletions(-) diff --git a/include/system/cpus.h b/include/system/cpus.h index bfaa339dd73..e7ca9f4d684 100644 --- a/include/system/cpus.h +++ b/include/system/cpus.h @@ -9,9 +9,7 @@ const AccelOpsClass *cpus_get_accel(void); =20 /* accel/dummy-cpus.c */ void dummy_thread_precreate(CPUState *cpu); - -/* Create a dummy vcpu for AccelOpsClass->create_vcpu_thread */ -void dummy_start_vcpu_thread(CPUState *); +void *dummy_cpu_thread_routine(void *arg); =20 /* interface available for cpus accelerator threads */ =20 diff --git a/accel/dummy-cpus.c b/accel/dummy-cpus.c index 7c34e6c0fc5..c6756252550 100644 --- a/accel/dummy-cpus.c +++ b/accel/dummy-cpus.c @@ -18,7 +18,7 @@ #include "qemu/main-loop.h" #include "hw/core/cpu.h" =20 -static void *dummy_cpu_thread_fn(void *arg) +void *dummy_cpu_thread_routine(void *arg) { CPUState *cpu =3D arg; =20 @@ -70,15 +70,3 @@ void dummy_thread_precreate(CPUState *cpu) qemu_sem_init(&cpu->sem, 0); #endif } - -void dummy_start_vcpu_thread(CPUState *cpu) -{ - char thread_name[VCPU_THREAD_NAME_SIZE]; - - dummy_thread_precreate(cpu); - - snprintf(thread_name, VCPU_THREAD_NAME_SIZE, "CPU %d/DUMMY", - cpu->cpu_index); - qemu_thread_create(cpu->thread, thread_name, dummy_cpu_thread_fn, cpu, - QEMU_THREAD_JOINABLE); -} diff --git a/accel/qtest/qtest.c b/accel/qtest/qtest.c index c5a53ecb6dd..6930cc4cf3e 100644 --- a/accel/qtest/qtest.c +++ b/accel/qtest/qtest.c @@ -63,7 +63,8 @@ static void qtest_accel_ops_class_init(ObjectClass *oc, c= onst void *data) { AccelOpsClass *ops =3D ACCEL_OPS_CLASS(oc); =20 - ops->create_vcpu_thread =3D dummy_start_vcpu_thread; + ops->thread_precreate =3D dummy_thread_precreate; + ops->cpu_thread_routine =3D dummy_cpu_thread_routine; ops->get_virtual_clock =3D qtest_get_virtual_clock; ops->set_virtual_clock =3D qtest_set_virtual_clock; }; diff --git a/accel/xen/xen-all.c b/accel/xen/xen-all.c index de52a8f882a..3bd91889925 100644 --- a/accel/xen/xen-all.c +++ b/accel/xen/xen-all.c @@ -151,7 +151,8 @@ static void xen_accel_ops_class_init(ObjectClass *oc, c= onst void *data) { AccelOpsClass *ops =3D ACCEL_OPS_CLASS(oc); =20 - ops->create_vcpu_thread =3D dummy_start_vcpu_thread; + ops->thread_precreate =3D dummy_thread_precreate; + ops->cpu_thread_routine =3D dummy_cpu_thread_routine; } =20 static const TypeInfo xen_accel_ops_type =3D { --=20 2.49.0 From nobody Sat Nov 15 17:17:25 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1749228401; cv=none; d=zohomail.com; s=zohoarc; b=HafZyUVulSSa4ubNJEcXgm0TQfUdI8MBWV93D4EZQ46zhdNCSn0viugz6cV719E1PcAc44j3wwFqNRy9ms5Gpzh59z9C9TRgwSmZcovqCZ2hsuaP2MJUTutxLumY90pySeXzT32UvhEhtS3w9f2znxzOfq86jQgUn50Yb1LaQY0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1749228401; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=u4qlPyVP19TOs/IkzQVFEBQPCs8QxMwe6aQWLV0wFtw=; b=kV7/YGcs2UBUFdfhknwSne3CS+ULQzsh2E3YSseoNxchDuv9SVMM56+8mtexitAC7oCiI9ArmohkKwtg14fQe8/1jRHrtLrHhkZyYT0wmOxkb/tz/8+5Zq7BYFLYSrA+1DM5/HyCrvcMrcWJqKi/Y5ogu0YIuCqjFuWZfsS5bbQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1749228401184226.55297988939776; Fri, 6 Jun 2025 09:46:41 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uNaDB-0006fG-Gl; Fri, 06 Jun 2025 12:46:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uNaCw-0006Hx-5B for qemu-devel@nongnu.org; Fri, 06 Jun 2025 12:46:20 -0400 Received: from mail-wm1-x32f.google.com ([2a00:1450:4864:20::32f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uNaCt-0003Sa-M2 for qemu-devel@nongnu.org; Fri, 06 Jun 2025 12:46:17 -0400 Received: by mail-wm1-x32f.google.com with SMTP id 5b1f17b1804b1-451d3f72391so29934005e9.3 for ; Fri, 06 Jun 2025 09:46:15 -0700 (PDT) Received: from localhost.localdomain (59.red-95-127-62.dynamicip.rima-tde.net. [95.127.62.59]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-452137281b0sm30312505e9.29.2025.06.06.09.46.11 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 06 Jun 2025 09:46:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1749228374; x=1749833174; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=u4qlPyVP19TOs/IkzQVFEBQPCs8QxMwe6aQWLV0wFtw=; b=N4Ye0nXQeR035nDvUHQWs+lGh5qx7PKXKvu03yT3NMCoFc5y54QlUH7btIQ1T10leF NV7uUO4c1D8dqvZwYmnjfSGw/waL4fLNMySw0qsr6Szlmd/y749khoDWFIUYaCMKPHu5 LqnOhszswPC52dVRt/fp32f2TEi44lzgj1oMuSiRbwD8uxnzuJanYsbnilNv25l55gsa tfkw6hNayefNPUvU+hVqzkCkKqN2H1Kago8qruZoY2+KIObh7w83IeQtfpZ1urBddcI4 SeL5Mf4yah2JA314GnJFlqcKGlcpzVs9iDofrX3zKfZsMCODr8G+NYVZzbo+DFt59SzL NYgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749228374; x=1749833174; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=u4qlPyVP19TOs/IkzQVFEBQPCs8QxMwe6aQWLV0wFtw=; b=YjfHHvaYDLRR9QcXEBZgkp3tY5qiCQ+/FyiU7+tVjGJjWdmdnkVdk9vJyPtOExlukj CgbcmXfTTuzxBqzGln9jCsCwefeCBqnj5RFu01+++AZ0o9zXK2yKCAD1mgugWPvTP/hy 0VgBI5/rQEpsIepKWJEhyy5z8IeQHcAhbXI3mwDyQb5VZr90U+Euflz/iu2T1GopJdmV 7OUQZF7ZRZLaw00fV/9IZ0DIRM0g06SgF/EHz9l+JOFlVAlyw1/Ugk1WcKRgjiW6vDLO VXalsaYpnNQN0urvmikNzcCur1+ImhtBQX6cKstg5gV0Q/3eZwYScCWpsHlILobGO/Db 96/g== X-Gm-Message-State: AOJu0YwTWTWEXoYAdCZp+KZxpCgRaAyjaHsg/uE4AftEbv07E7wJhOGb Q031RztmNAhlLXGeR12RRJWts4CSY6C+3wphKXyGEPxA5BimhwSNCI8g7s2nYWhd5Fv1syQSx9X aTA9St/h/tA== X-Gm-Gg: ASbGncv06l+m6QrMsDKj1RwQqPG6oPIlyZ084cRCfLpwaYP4+g50emuWQx7uW5A1kE6 5+GP2lIO5dUx5k+T5/tGM1E9llONH0+8QTGHk4R5zUMlCooOzhwrUtY0zrSpPSJPq/voG4qYbGQ Dux7aZQkPGLnRLz95qJIhAXRiirKY4AoBx3iqOFvVePSkflCNolLWV0iqQ4XnFrkIR1niUuHHDx w2MfAeP2TiYqwBFpByNaBZrYAfHJwz7JHYsaoaekxIxRUmn/S9cj4JpBwzTnDm9HRj6BtrNrrI4 0/fgrPKo1AnLa/LOFo2Q0uaYZMdqhldcXvA/YscGQ90OLSqE7jLz6m5CYtNTWxA5TehICtTSlu2 TLXKhxL69sbSNcLElhV5IGhdyVBAmnxKfLs7LG9JBg3CaVSb+ X-Google-Smtp-Source: AGHT+IEKYod3eqsOm/9hKAMbNssa5gpIELDdRp5eDU9k2t0nVsWJoNd2vfuGtxNF4UDUHzBfVx7v5g== X-Received: by 2002:a05:600c:3ba1:b0:44a:b478:1387 with SMTP id 5b1f17b1804b1-4520147ea0amr46702795e9.17.1749228373574; Fri, 06 Jun 2025 09:46:13 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Alex=20Benn=C3=A9e?= , Richard Henderson , Pierrick Bouvier Subject: [RFC PATCH 15/19] accel/tcg: Convert to AccelOpsClass::cpu_thread_routine Date: Fri, 6 Jun 2025 18:44:14 +0200 Message-ID: <20250606164418.98655-16-philmd@linaro.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250606164418.98655-1-philmd@linaro.org> References: <20250606164418.98655-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32f; envelope-from=philmd@linaro.org; helo=mail-wm1-x32f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1749228402893116600 By converting to AccelOpsClass::cpu_thread_routine we can let the common accel_create_vcpu_thread() create the thread. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- accel/tcg/tcg-accel-ops-mttcg.h | 3 +-- accel/tcg/tcg-accel-ops-mttcg.c | 16 +--------------- accel/tcg/tcg-accel-ops.c | 3 ++- 3 files changed, 4 insertions(+), 18 deletions(-) diff --git a/accel/tcg/tcg-accel-ops-mttcg.h b/accel/tcg/tcg-accel-ops-mttc= g.h index 8ffa7a9a9fe..8bf2452c886 100644 --- a/accel/tcg/tcg-accel-ops-mttcg.h +++ b/accel/tcg/tcg-accel-ops-mttcg.h @@ -13,7 +13,6 @@ /* kick MTTCG vCPU thread */ void mttcg_kick_vcpu_thread(CPUState *cpu); =20 -/* start an mttcg vCPU thread */ -void mttcg_start_vcpu_thread(CPUState *cpu); +void *mttcg_cpu_thread_routine(void *arg); =20 #endif /* TCG_ACCEL_OPS_MTTCG_H */ diff --git a/accel/tcg/tcg-accel-ops-mttcg.c b/accel/tcg/tcg-accel-ops-mttc= g.c index 462be7596b9..96ce065eb59 100644 --- a/accel/tcg/tcg-accel-ops-mttcg.c +++ b/accel/tcg/tcg-accel-ops-mttcg.c @@ -61,7 +61,7 @@ static void mttcg_force_rcu(Notifier *notify, void *data) * current CPUState for a given thread. */ =20 -static void *mttcg_cpu_thread_fn(void *arg) +void *mttcg_cpu_thread_routine(void *arg) { MttcgForceRcuNotifier force_rcu; CPUState *cpu =3D arg; @@ -128,17 +128,3 @@ void mttcg_kick_vcpu_thread(CPUState *cpu) { cpu_exit(cpu); } - -void mttcg_start_vcpu_thread(CPUState *cpu) -{ - char thread_name[VCPU_THREAD_NAME_SIZE]; - - tcg_vcpu_thread_precreate(cpu); - - /* create a thread per vCPU with TCG (MTTCG) */ - snprintf(thread_name, VCPU_THREAD_NAME_SIZE, "CPU %d/TCG", - cpu->cpu_index); - - qemu_thread_create(cpu->thread, thread_name, mttcg_cpu_thread_fn, - cpu, QEMU_THREAD_JOINABLE); -} diff --git a/accel/tcg/tcg-accel-ops.c b/accel/tcg/tcg-accel-ops.c index e58e1c3738f..954e85dc13c 100644 --- a/accel/tcg/tcg-accel-ops.c +++ b/accel/tcg/tcg-accel-ops.c @@ -210,7 +210,7 @@ static void tcg_accel_ops_init(AccelClass *ac) AccelOpsClass *ops =3D ac->ops; =20 if (qemu_tcg_mttcg_enabled()) { - ops->create_vcpu_thread =3D mttcg_start_vcpu_thread; + ops->cpu_thread_routine =3D mttcg_cpu_thread_routine; ops->kick_vcpu_thread =3D mttcg_kick_vcpu_thread; ops->handle_interrupt =3D tcg_handle_interrupt; } else { @@ -226,6 +226,7 @@ static void tcg_accel_ops_init(AccelClass *ac) } } =20 + ops->thread_precreate =3D tcg_vcpu_thread_precreate; ops->cpu_reset_hold =3D tcg_cpu_reset_hold; ops->supports_guest_debug =3D tcg_supports_guest_debug; ops->insert_breakpoint =3D tcg_insert_breakpoint; --=20 2.49.0 From nobody Sat Nov 15 17:17:25 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1749228429; cv=none; d=zohomail.com; s=zohoarc; b=i00bqzb9IQDc0RHrL8GGHxt6An17hjWq7Od0aBuIVhPldZAG/zlHhKc5520cKLJosvpIGlQgbINkLTi8ADuSCeHzaInp0hrGO/idpXPMizGFshJK0xbd2/tQLimyPtWSv28qc/CBamT0HV6BFD4jnsAMStTyJH63gzikMxyNfxE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1749228429; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=GbtuoNgudglhJLlyI30gSCpvbQM9+V/yqMDBe9lx7qs=; b=UEvtL72cl5UpIwGnMlWbZ/JHz+e8cD8cT3rfVaj6FKDKuBKHUlcHX0A2WjSbJ9kyOX1us3UDUsWLkL6zSbMJCqRLQLV0S8dqH6dEgPnNsBFH4B61hLATsQCfeM+Wm/UeNY6csqVUagEBArMIIgnrAi4+eWFzZGRunx2KBt8X0k8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1749228429481730.5556880703843; Fri, 6 Jun 2025 09:47:09 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uNaDd-00078t-RI; Fri, 06 Jun 2025 12:47:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uNaD2-0006PG-Hh for qemu-devel@nongnu.org; Fri, 06 Jun 2025 12:46:29 -0400 Received: from mail-wm1-x330.google.com ([2a00:1450:4864:20::330]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uNaD0-0003T8-V6 for qemu-devel@nongnu.org; Fri, 06 Jun 2025 12:46:24 -0400 Received: by mail-wm1-x330.google.com with SMTP id 5b1f17b1804b1-450cfb6a794so16131195e9.1 for ; Fri, 06 Jun 2025 09:46:22 -0700 (PDT) Received: from localhost.localdomain (59.red-95-127-62.dynamicip.rima-tde.net. [95.127.62.59]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a532464e7fsm2341760f8f.96.2025.06.06.09.46.19 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 06 Jun 2025 09:46:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1749228381; x=1749833181; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=GbtuoNgudglhJLlyI30gSCpvbQM9+V/yqMDBe9lx7qs=; b=hVuujyKdyyIAP6ytRfpgU3VDmYoxca4MIxiAMEqr1ka+iOnzItZhU+jA1hNWN8wIU4 B+FCqdIYWKddSsHYTEqQL8HfEwxZwXdutfwMgOq7fZS4HFshYBXx/GcP5ZdzzOEBODkp KtZAhZL1iIHGmSn9abOsmcY5I58vW8Vci3suvjyeeTBn48BLy8jy3VfwjIN3yD6QbOIJ t5npfDard+QjYSbJ76Uqn8INmr0IF7i2dgZIF8lbC7CuakgpDSq6J0jVkulz/ddih0hy 3KaJ95gaKZZhYm6POBK/+RKCAgwJQIWS4m9YbfolhHjlux8GWXJ8Q+C5T1yQGuPbYfBL ebtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749228381; x=1749833181; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GbtuoNgudglhJLlyI30gSCpvbQM9+V/yqMDBe9lx7qs=; b=VGKWk/Vo4qYWKu63o5MqBLKvM2Ym6AI2Fevv4Xb0Ixr9lVhE+CkgTlnGdJvsQlhMn/ +VJS/VBjSw1yOJgvFTIAJbqzUL6kCoLc9szaSLNuSeY0HlKPx2jLj7Gc7OOpDS2s2k2V CD2x3QMsUV5yYwgzzIBO56WF2YMBVELJd09r3KcF742J+KnJlV6+QZUebQMVPVEmx6a9 e2DdjwLkZcnjtnOymXQbG23n4CjbzZl1CBM1OkEdHiPjscnvlo00ZtTji4Tnz+k1iqDH dnjChvMHPJysLB7uxP1VHf0V2ar6cYw352gZQRCu6UCyxeLy1p8brB8TNGrZKPTIbsHk wRsg== X-Gm-Message-State: AOJu0YyIoaTX7BerTat95gsrk3L0teTyULM0Z9ysr2bUt4J8NyzqEg8M 80XrqllCekJzlnzkjRXlW3BsXFvgyEwXsCm1oNIP/y7d7rGHMDAUhwPF7h5hvTOJAQ4Z4FtMuG1 GUm1vvbiZYw== X-Gm-Gg: ASbGncsMNv4Ylz8zfdPyXcOuKU4kZORh5VvVlayjHizgcxHRCSYdejj3X2UeXshefsb AljeTemZu9A4m7RVRnUadfbCcGD9JThpjfHB0AxJQXKjqKj+JjqhrlVMuMvWamJk0lB49jZauph KOVYHIaTMqZzcvRked/PdaLdABdZJfnd8R85DwwFZlzIfHOUc9V9MwxnxmM/B+rtPfiNgREgE0Y NYbe7bnYUlbhLrNnufft52QFdG5Gl1tMo1xC3b+L9QgNmSAk9MjBep3bLxI070rkOjjwlfcnQG0 0pQdo0Z/DUjK7U7bSslPhQ66hasKITDVpKY/ziNjmRQZBCiIuCxV6CxWbcDmZjByWwqim5Ph7w7 3Y0o9s9ziH5zgW+LWEuP8HTAm5PY1WN8EhBCJdw6y2hpG1GMh X-Google-Smtp-Source: AGHT+IEX0vp0R6AZjVX0jvBAykDp95VYAjSi/tS+ematIm1d+CVc6TcqdSLJHPOWKplR01lEw3YgYw== X-Received: by 2002:a05:600c:8b11:b0:450:c210:a01b with SMTP id 5b1f17b1804b1-4520136993amr46814795e9.17.1749228381060; Fri, 06 Jun 2025 09:46:21 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Alex=20Benn=C3=A9e?= , Richard Henderson , Pierrick Bouvier Subject: [RFC PATCH 16/19] accel/hvf: Convert to AccelOpsClass::cpu_thread_routine Date: Fri, 6 Jun 2025 18:44:15 +0200 Message-ID: <20250606164418.98655-17-philmd@linaro.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250606164418.98655-1-philmd@linaro.org> References: <20250606164418.98655-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::330; envelope-from=philmd@linaro.org; helo=mail-wm1-x330.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1749228431170116600 By converting to AccelOpsClass::cpu_thread_routine we can let the common accel_create_vcpu_thread() create the thread. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- accel/hvf/hvf-accel-ops.c | 18 +----------------- 1 file changed, 1 insertion(+), 17 deletions(-) diff --git a/accel/hvf/hvf-accel-ops.c b/accel/hvf/hvf-accel-ops.c index f4a983d1328..d9b533820c5 100644 --- a/accel/hvf/hvf-accel-ops.c +++ b/accel/hvf/hvf-accel-ops.c @@ -458,22 +458,6 @@ static void *hvf_cpu_thread_fn(void *arg) return NULL; } =20 -static void hvf_start_vcpu_thread(CPUState *cpu) -{ - char thread_name[VCPU_THREAD_NAME_SIZE]; - - /* - * HVF currently does not support TCG, and only runs in - * unrestricted-guest mode. - */ - assert(hvf_enabled()); - - snprintf(thread_name, VCPU_THREAD_NAME_SIZE, "CPU %d/HVF", - cpu->cpu_index); - qemu_thread_create(cpu->thread, thread_name, hvf_cpu_thread_fn, - cpu, QEMU_THREAD_JOINABLE); -} - static int hvf_insert_breakpoint(CPUState *cpu, int type, vaddr addr, vadd= r len) { struct hvf_sw_breakpoint *bp; @@ -580,7 +564,7 @@ static void hvf_accel_ops_class_init(ObjectClass *oc, c= onst void *data) { AccelOpsClass *ops =3D ACCEL_OPS_CLASS(oc); =20 - ops->create_vcpu_thread =3D hvf_start_vcpu_thread; + ops->cpu_thread_routine =3D hvf_cpu_thread_fn, ops->kick_vcpu_thread =3D hvf_kick_vcpu_thread; =20 ops->synchronize_post_reset =3D hvf_cpu_synchronize_post_reset; --=20 2.49.0 From nobody Sat Nov 15 17:17:25 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1749228502; cv=none; d=zohomail.com; s=zohoarc; b=mIgC+kCwNfOVrBILdeDbvVlbXOsRGiZhCnmebKZudhdYi8WI/nh2AURgYMgo0aC1P9WroSS/laoh82gbRltfO+29/R/MN9iniWkKlQ00MFYTn3m+45IDNo5JJxRnrPXQGfTcXDP3APoiRjkhBRO0HNUuol7c+eYnTO11+sKhX4Q= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1749228502; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=eW26fCg8e+Q3GYcnecMlFtDKq9fMUnTMjzlwEj1wdjA=; b=XRnzrpHDRi934KzfuQjQ23p6BOCNcJB8/rUOg8jWRy+uPzMp0+Ki4rz1ccHPFgjykO8jN6BaTzmjeXPEHWZ0+Ca0AEs5f/2Mmgz/B7K8tHCDwFJAskRPhVTlZXKgsClpwREnDsTB89/AUfQJ1Ho7CqjZjYAA3fQ/rXXsGn8ENjs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1749228502949786.5421396304658; Fri, 6 Jun 2025 09:48:22 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uNaDh-0007cR-IJ; Fri, 06 Jun 2025 12:47:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uNaDA-0006h2-RH for qemu-devel@nongnu.org; Fri, 06 Jun 2025 12:46:33 -0400 Received: from mail-wm1-x32e.google.com ([2a00:1450:4864:20::32e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uNaD9-0003TS-5L for qemu-devel@nongnu.org; Fri, 06 Jun 2025 12:46:32 -0400 Received: by mail-wm1-x32e.google.com with SMTP id 5b1f17b1804b1-451dbe494d6so28320925e9.1 for ; Fri, 06 Jun 2025 09:46:30 -0700 (PDT) Received: from localhost.localdomain (59.red-95-127-62.dynamicip.rima-tde.net. [95.127.62.59]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-452730c66a1sm26841725e9.27.2025.06.06.09.46.26 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 06 Jun 2025 09:46:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1749228389; x=1749833189; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=eW26fCg8e+Q3GYcnecMlFtDKq9fMUnTMjzlwEj1wdjA=; b=sTaNhiP1t1wyZwI4e6Yz+dcEyAkc+6pDsug32zFhoFKCnoWOmBwv2AqFVGZBYPsQKc VZUrXu/Nmk4Zhyk0ee9lzTlH70QoUozEOhafY25mD7MO44bga2Hgw/qSp4hnMVSGgBcz je99eEv5eQG8UlYFrSau2o8Ht7VefXRVypF3Qt03BO8kUyrICv6soud57Tuj/BADWYH/ VikAAjDv4ksSeJ3S8yh0AjHvJ6QQRelM/ZyHWpGKZqJOSDJ3n/kUHdujdzgq+wkUfOln Gb7cD1/oSMuIwIZnGiw6cKMS6rBtuyKguBipHRYBql17a8HMM15SA4JoFwW7kJl/ZZYa fW7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749228389; x=1749833189; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=eW26fCg8e+Q3GYcnecMlFtDKq9fMUnTMjzlwEj1wdjA=; b=t7VnXefRIRsL/Ixhy13FTdi8Y8b8vgBXqjO9mLrAI/sRaMs7CRcfuIvqmoZ58m64/Z MTpSxTxqjRO4J6Q7R2+p1QXgrXJ/Cp435j1UIypxktyeq7E8aKfNez9sxvg8R+pDPQKX ePNHKKPhlAlBxshnBI1uVDJ+5npjRLUi63ddN6qwVatJJkkbiPrW1n92xEM62ZBKJC1w BiXAuNJtAbdD4v7OIp3AFsqw3jbEr+OkXolOZjKCICDP1iBN/0nVXWZVRL7dB5seqFcZ z5gsJES1HQqf2u/6ldtTKcQNrDBAm9LxzA0wdCnosJCWCKc9wujtdv6qEmncCMsQT04b 2Rwg== X-Gm-Message-State: AOJu0YzMCTSUk/zrDQIh2bKN1tFkQ0UT4l0v1m9Qc9z65Cogkm15LyRa Ykb8TbAoegeAaILIsDqxx/F4CLinzSUHS6TwRUL9eW26WitJgTzKNAfP3hBVkCj87yd+7yvF/Jb p+8a+CuzlnQ== X-Gm-Gg: ASbGncsptRgS4wKq8bIIjzuMNfMaqnci0/BST0+MeNWgcZFENV3zn56nrCS6Llw+6H7 aq1YACPCRWTw0rQ7TOSq1YCSAmVFTOxsyzpID8Z7yq+emPJjt+oLNkHKHicnLGEtfKUK/yte9Cd vSiYvDQL/LsOCP474Yhw+clXiWQrvb6La2FOvimuR1BHUKxWf2DVj2iPV4o+gsbOj2qwof/mRA9 1vPFfp9LFr062Xabb+Scm9073sSe1fcmcylp/706pNOgA9gxdiBvNQRlMig7OqVU0X9rQCsSSW6 VrsiwoJbTTr+RzTIKEUjlsbhgOtUXycVDkHlflN7KGpihsAsYh6SmlOiLrrFNeg4fIwkuIgdRf1 D1D3o2XeB4nCUNM+BUpwLGTGwSX1bllDlVZpvzQ== X-Google-Smtp-Source: AGHT+IF1Xyh5ySTeGryGVO8X6wrK5tj6OGPjTAzvu3QggZoLJOffrJgC6E+IBq3/p1Y7rNQVqnfLdw== X-Received: by 2002:a05:600c:6209:b0:441:b698:3431 with SMTP id 5b1f17b1804b1-4520141a7f4mr37452095e9.28.1749228389139; Fri, 06 Jun 2025 09:46:29 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Alex=20Benn=C3=A9e?= , Richard Henderson , Pierrick Bouvier Subject: [RFC PATCH 17/19] accel/kvm: Convert to AccelOpsClass::cpu_thread_routine Date: Fri, 6 Jun 2025 18:44:16 +0200 Message-ID: <20250606164418.98655-18-philmd@linaro.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250606164418.98655-1-philmd@linaro.org> References: <20250606164418.98655-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32e; envelope-from=philmd@linaro.org; helo=mail-wm1-x32e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1749228504101116600 By converting to AccelOpsClass::cpu_thread_routine we can let the common accel_create_vcpu_thread() create the thread. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- accel/kvm/kvm-accel-ops.c | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/accel/kvm/kvm-accel-ops.c b/accel/kvm/kvm-accel-ops.c index e5c15449aa6..39334997fb1 100644 --- a/accel/kvm/kvm-accel-ops.c +++ b/accel/kvm/kvm-accel-ops.c @@ -63,16 +63,6 @@ static void *kvm_vcpu_thread_fn(void *arg) return NULL; } =20 -static void kvm_start_vcpu_thread(CPUState *cpu) -{ - char thread_name[VCPU_THREAD_NAME_SIZE]; - - snprintf(thread_name, VCPU_THREAD_NAME_SIZE, "CPU %d/KVM", - cpu->cpu_index); - qemu_thread_create(cpu->thread, thread_name, kvm_vcpu_thread_fn, - cpu, QEMU_THREAD_JOINABLE); -} - static bool kvm_vcpu_thread_is_idle(CPUState *cpu) { return !kvm_halt_in_kernel(); @@ -94,7 +84,7 @@ static void kvm_accel_ops_class_init(ObjectClass *oc, con= st void *data) { AccelOpsClass *ops =3D ACCEL_OPS_CLASS(oc); =20 - ops->create_vcpu_thread =3D kvm_start_vcpu_thread; + ops->cpu_thread_routine =3D kvm_vcpu_thread_fn; ops->cpu_thread_is_idle =3D kvm_vcpu_thread_is_idle; ops->cpus_are_resettable =3D kvm_cpus_are_resettable; ops->synchronize_post_reset =3D kvm_cpu_synchronize_post_reset; --=20 2.49.0 From nobody Sat Nov 15 17:17:25 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1749228506; cv=none; d=zohomail.com; s=zohoarc; b=m7Dvt/83zPkB6Y+f0fEHCJyasZ7zsots9p+rkCO64IjUHnjzOEwqqsSazGTsIRKerpUdyragZLHJHmdFvbxf7OrcxIlzwOPgqW2Zi6sF7xgq2SroezvirzkSbOD+P/kCxYq8/4DnI6d9qK1QEccVCayod0GX6ZmSU/dH3ihtclQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1749228506; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=bscCZhJPor6p9xOGYxKsyHkSJQbAuOk7LsWMwFm7sCY=; b=P6JkL/LlAhRV+Qz+nAlrNY6AqSAmlwo70lk0Ty4yr8ord8CU/xw5eu4MqrQXLChIEo1b1UgUTkQS8Yd5cZ8purK96Gu7SVUyAOKD9vdKJIT2VBCp38t9KU2awcFlW/3A/oIZdYYlMSq+jPiZDVlLO5Em6JP9cR/Iva6uLrGc29M= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1749228506106633.9760361850911; Fri, 6 Jun 2025 09:48:26 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uNaDg-0007SU-0A; Fri, 06 Jun 2025 12:47:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uNaDJ-00072S-DK for qemu-devel@nongnu.org; Fri, 06 Jun 2025 12:46:48 -0400 Received: from mail-wm1-x335.google.com ([2a00:1450:4864:20::335]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uNaDH-0003Tv-2M for qemu-devel@nongnu.org; Fri, 06 Jun 2025 12:46:40 -0400 Received: by mail-wm1-x335.google.com with SMTP id 5b1f17b1804b1-451d6ade159so20498785e9.1 for ; Fri, 06 Jun 2025 09:46:38 -0700 (PDT) Received: from localhost.localdomain (59.red-95-127-62.dynamicip.rima-tde.net. [95.127.62.59]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-452137277afsm30506935e9.30.2025.06.06.09.46.34 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 06 Jun 2025 09:46:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1749228397; x=1749833197; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=bscCZhJPor6p9xOGYxKsyHkSJQbAuOk7LsWMwFm7sCY=; b=II/Sxjs2GBolN5lwLhYzFLIJkxWKUqwdXU03MlPZ7Ekhc1HXrtN+Uh2R5oSOCgm3bP db7kbnmvAqFcPFaM1l+WZ0s6UcCSwg/vARbvWi4KYmq4HAs/ixoS3fvnugNCmGmA4wbd yK+j0ZFeGhrfnrwvmmt5unXBUlzOlYYuQq6yN1rJkXgN+ehePUvrsdsKtXpNReOAhrQH oKwlkUP33h0+5QRLLlCzlp6uRaQ1o6SVOOW1iT7Lv6pFv+5Me3neuTarp2hnwizSbGUA IMfUvEJAQyrsGsUhShNGlk8cOUvO6YFrNgq5oluQIGnQYk239npc8vpV8Q1sG+Azpn0F Lxiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749228397; x=1749833197; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bscCZhJPor6p9xOGYxKsyHkSJQbAuOk7LsWMwFm7sCY=; b=rM9x5jSsqGZFNjlT4nG6pYwZe5B9kHTCyzX38zY+FTZKOFuKVVhY61kkw0ztIszJ/b pkH1O4YlWCcM+x9BT2SaFCT2ZpUBEsy0Zk2vj/vXNC6zES+d7/AZ+3CwNDG82VvI4s18 P5YI3OpQZTquzc7GuhESUDuGFkvmzs4h0XjHkHiY5dMwJ4T5QnAYvsdof7Ykp42bMgQ8 ijNKz1dVndXKWVo6EZNjWTFBXC3t587NQwKGv4DuG2dYYKPv5tep7c9l+KGjnKia6oLK UAjLavuE/ZrGFT9N2JoW/ai/Fc9+Tydzo5MmNhgLV8K+geTsXP8eCjFFBT/FzZtMDrDk A6iw== X-Gm-Message-State: AOJu0Yx0ymsSIzomi2UPoeY3ljGqcB0TUd2Z6E9ld3FyZPt+UUJOwIkJ 38Qqi4m5apwQ/YuNLIstpqjcgYG3fhdwGYlZffJb0vjkOydWBIOVFIfv5IPQFnlH8DGOQbzA3YF HXR/915V+0A== X-Gm-Gg: ASbGncvwydSGSaNKN23rmCfH0/I+kvFbN4nVawUu1KxOilZtviLUdIY8WcXE2M/zAm/ EbugkRGgkx1BOGN5Oq7MCiHCORB3VSHraVLelSq/dGk4HaKTpU5tOy0yMSgZcFDe010SOQAu/RP QaM97RLcmKOGGTmcVKHDadKU3IFLO3IXeu/29oSVn85fTIrjJ1b4vhHty5bSG+PSZP9vtI3tBp6 O8CFPNhalz/OI5itkN0aSQip42a2CsC4FfCdsWapfpYkbVXQA7sy4F5EVLAmj5jENkdcDbUDa7z xanW7yMWSbucnBflh8HVMEkXjIZ6Xjcr7EQXqYSf+UmBkcNwfDHF2eFvy9duVVTz7+qCX/DKmHL qzSUdMyZ+P0q0kd7KjJnKdBYrR5PUC/p4jh9vXg== X-Google-Smtp-Source: AGHT+IEfieFC9wvJ1rs1Wl1sCKCoM/i8eGhzo/CMfNmSSkbUp9KqidKwZLdkvGDV0kTw1gduv9DENA== X-Received: by 2002:a05:600c:1c1b:b0:44b:1f5b:8c85 with SMTP id 5b1f17b1804b1-4520139c741mr45100795e9.13.1749228396991; Fri, 06 Jun 2025 09:46:36 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Alex=20Benn=C3=A9e?= , Richard Henderson , Pierrick Bouvier Subject: [RFC PATCH 18/19] accel/nvmm: Convert to AccelOpsClass::cpu_thread_routine Date: Fri, 6 Jun 2025 18:44:17 +0200 Message-ID: <20250606164418.98655-19-philmd@linaro.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250606164418.98655-1-philmd@linaro.org> References: <20250606164418.98655-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::335; envelope-from=philmd@linaro.org; helo=mail-wm1-x335.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1749228508019116600 By converting to AccelOpsClass::cpu_thread_routine we can let the common accel_create_vcpu_thread() create the thread. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- target/i386/nvmm/nvmm-accel-ops.c | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/target/i386/nvmm/nvmm-accel-ops.c b/target/i386/nvmm/nvmm-acce= l-ops.c index 21443078b72..bef6f61b776 100644 --- a/target/i386/nvmm/nvmm-accel-ops.c +++ b/target/i386/nvmm/nvmm-accel-ops.c @@ -61,16 +61,6 @@ static void *qemu_nvmm_cpu_thread_fn(void *arg) return NULL; } =20 -static void nvmm_start_vcpu_thread(CPUState *cpu) -{ - char thread_name[VCPU_THREAD_NAME_SIZE]; - - snprintf(thread_name, VCPU_THREAD_NAME_SIZE, "CPU %d/NVMM", - cpu->cpu_index); - qemu_thread_create(cpu->thread, thread_name, qemu_nvmm_cpu_thread_fn, - cpu, QEMU_THREAD_JOINABLE); -} - /* * Abort the call to run the virtual processor by another thread, and to * return the control to that thread. @@ -85,7 +75,7 @@ static void nvmm_accel_ops_class_init(ObjectClass *oc, co= nst void *data) { AccelOpsClass *ops =3D ACCEL_OPS_CLASS(oc); =20 - ops->create_vcpu_thread =3D nvmm_start_vcpu_thread; + ops->cpu_thread_routine =3D qemu_nvmm_cpu_thread_fn; ops->kick_vcpu_thread =3D nvmm_kick_vcpu_thread; =20 ops->synchronize_post_reset =3D nvmm_cpu_synchronize_post_reset; --=20 2.49.0 From nobody Sat Nov 15 17:17:25 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1749228451; cv=none; d=zohomail.com; s=zohoarc; b=EALkSAWWGeW0R28HAb6bpbdqwezeQinyK4iF6iN4G2gK+y8w5DjvtKUYltoHuOifB5bwc1qYiCtYYWJJvwxQbhyn4NV4U/W4o7BdVFlSocq8NFMIzWhBpgfVvAdeNsbAxBc9gXYP9PvLbcCF2G9NwXhzI+XJC8OwZI/joEVcaoM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1749228451; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=Y7Q0I9KRKGwfpnxMkCGWptv5CW/tc1a4iSXRbv+1UdA=; b=by9RXcnJTmvsxf04aGqPVpQyIaVcWDK0OtchsgtqrHfhukrvySa7P8iuLH3oMawTcZn4+jW6sS9e/Ybsg/f1ec2BkY3cdYHosFv4qIjs7yrY9TKGDLObdkzdvNCpjwDi9Ac0hbfySWiqgw1sdPxllSRQkAc8xrClW3rN6MEpwK8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1749228451519682.9807664717301; Fri, 6 Jun 2025 09:47:31 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uNaDk-0007y9-Dx; Fri, 06 Jun 2025 12:47:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uNaDQ-00073K-Q3 for qemu-devel@nongnu.org; Fri, 06 Jun 2025 12:46:54 -0400 Received: from mail-wm1-x32b.google.com ([2a00:1450:4864:20::32b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uNaDO-0003UX-Lv for qemu-devel@nongnu.org; Fri, 06 Jun 2025 12:46:47 -0400 Received: by mail-wm1-x32b.google.com with SMTP id 5b1f17b1804b1-442e9c00bf4so18926015e9.3 for ; Fri, 06 Jun 2025 09:46:45 -0700 (PDT) Received: from localhost.localdomain (59.red-95-127-62.dynamicip.rima-tde.net. [95.127.62.59]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45209ce5045sm29896375e9.16.2025.06.06.09.46.42 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 06 Jun 2025 09:46:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1749228404; x=1749833204; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Y7Q0I9KRKGwfpnxMkCGWptv5CW/tc1a4iSXRbv+1UdA=; b=L7lUVX3ZhJksjJsHmMc2UrRbMibCQBP3lWjrOAHTqvZnj/xTf5j82GfgW4NEbwEMUO QxkTbGaQ6sXOhtZ9tR7+NHSZyWuzx2R7e5shxWX+j9w7317IDi6uP6LE3+dV/Nz6hZRr SlfRDYpU0FdoY8dmQFizH1gmxFHZqX7pKffQIi0OAHKt1C5QdftsjPcaxiJ9eFx6pMxT NxGWK06wp2ueQwBz/34AEFu7Q6HRv7l4y7BkbzMOOUD5Bj/qykYCP3jmiVIxBchcaw7E kJk1J1NDYROJdoN1ta8DXAPvhSm6s6beexhaILXgTcYcyBCPpqEnuKY3xQR8BqghBfRF qvgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749228404; x=1749833204; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Y7Q0I9KRKGwfpnxMkCGWptv5CW/tc1a4iSXRbv+1UdA=; b=LeKNqWTNWWp8D9Kmtc6K8TS4fbfq2GZ4XYvbP3pytkZbkwWpl2X/4SgGxgJKy8oyMp UmcJ1vJbxRY7vAd0UfxSgtoPgWxdiCHrpCidny7svZGCv4uC8hyE6XTEWTuPIUM7DRpa NvSEgss/nxwp7HV/2mTtQMmH6kyu7HsjbuYa6VW3XGZn9092Hm7dfnTj+iTTP8GOsCJq +JGlpDc/Gd8LYaH6aforR9JE/hjMepIzopDyT9VJ3iJJEY0Cru0yUS075IyNBevia/ky ObL3LmUl4DaqsUYEPtQFJgh1bD0MzNiDf/BBfJ0pWc9wGnZFNmWekB+PDYu/ahxsm9Bw 3Z7Q== X-Gm-Message-State: AOJu0YzuASd8e/VOCT62ANYUa8ADbDaW2E7TcZjPO7KaheM4bdoLzwdK RGz9pF17pGlrxU6YAr/wghUcBFA7o6V04UxuMsGczZRUKTidLPRG/ktZtLAk7CHgIhrn7+7evMF r+QZMtB/NjQ== X-Gm-Gg: ASbGnculagMwedq3g6yAT3dgWnlgTBSbtnCMnaY/EqsMKKeo5XnvHN90OFMjJ6mLIYZ DO7Au4PjLRIz0RDbb05kwAmRWHJ8Ir7Bx4QqY7J9sibU1nlWm+vLYIHfrut7ZuMa915T9MoRzsv v0zSvfKoRzJFIWjhMAjjSWA8SoULMd9sANxFohR+EkbbB5ScQyO8tV0zhf1oQpFgweNnZUgpgJ6 Gl6SHkD61I3hN0A1Uq3zVMtizeSATw5limLNwgr2LbpOL1Cc1QF2PeY2+EvWiMjLuPGWYd7+eUq iVxKYP6lgJqt8lQom+Rh3E5iRpdik9MYVH2Xqda+c2eJahuRzn1tT3Ifl7EjUWp3SB3Z3eHCdDY 22XTgY476i+8XMIKHmCI3WmxaQHNSidsQo9IMd+ZrWInfcjpQ X-Google-Smtp-Source: AGHT+IHcvLEM83tjXj8Ojh1eRgB4Rg2QAaXcIfoZDI2EebYgYFjcwFxCEgX0D0ygKk42dcS5KqmaWA== X-Received: by 2002:a05:600c:4507:b0:43d:fa5d:9315 with SMTP id 5b1f17b1804b1-452014b56dbmr41284545e9.33.1749228403960; Fri, 06 Jun 2025 09:46:43 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Cc: =?UTF-8?q?Alex=20Benn=C3=A9e?= , Richard Henderson , Pierrick Bouvier Subject: [RFC PATCH 19/19] accel/whpx: Convert to AccelOpsClass::cpu_thread_routine Date: Fri, 6 Jun 2025 18:44:18 +0200 Message-ID: <20250606164418.98655-20-philmd@linaro.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250606164418.98655-1-philmd@linaro.org> References: <20250606164418.98655-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::32b; envelope-from=philmd@linaro.org; helo=mail-wm1-x32b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1749228453426116600 By converting to AccelOpsClass::cpu_thread_routine we can let the common accel_create_vcpu_thread() create the thread. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- target/i386/whpx/whpx-accel-ops.c | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/target/i386/whpx/whpx-accel-ops.c b/target/i386/whpx/whpx-acce= l-ops.c index b8bebe403c9..c1b27d1b89d 100644 --- a/target/i386/whpx/whpx-accel-ops.c +++ b/target/i386/whpx/whpx-accel-ops.c @@ -61,16 +61,6 @@ static void *whpx_cpu_thread_fn(void *arg) return NULL; } =20 -static void whpx_start_vcpu_thread(CPUState *cpu) -{ - char thread_name[VCPU_THREAD_NAME_SIZE]; - - snprintf(thread_name, VCPU_THREAD_NAME_SIZE, "CPU %d/WHPX", - cpu->cpu_index); - qemu_thread_create(cpu->thread, thread_name, whpx_cpu_thread_fn, - cpu, QEMU_THREAD_JOINABLE); -} - static void whpx_kick_vcpu_thread(CPUState *cpu) { if (!qemu_cpu_is_self(cpu)) { @@ -87,7 +77,7 @@ static void whpx_accel_ops_class_init(ObjectClass *oc, co= nst void *data) { AccelOpsClass *ops =3D ACCEL_OPS_CLASS(oc); =20 - ops->create_vcpu_thread =3D whpx_start_vcpu_thread; + ops->cpu_thread_routine =3D whpx_cpu_thread_fn; ops->kick_vcpu_thread =3D whpx_kick_vcpu_thread; ops->cpu_thread_is_idle =3D whpx_vcpu_thread_is_idle; =20 --=20 2.49.0