From nobody Sat Nov 15 16:07:53 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1749005842878533.5828647174588; Tue, 3 Jun 2025 19:57:22 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uMeIO-00023s-Iq; Tue, 03 Jun 2025 22:56:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uMeIK-00022K-KF; Tue, 03 Jun 2025 22:56:00 -0400 Received: from mail-pg1-x534.google.com ([2607:f8b0:4864:20::534]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uMeII-0000NP-GR; Tue, 03 Jun 2025 22:55:59 -0400 Received: by mail-pg1-x534.google.com with SMTP id 41be03b00d2f7-b1396171fb1so3433956a12.2; Tue, 03 Jun 2025 19:55:57 -0700 (PDT) Received: from donnager-debian.. ([45.124.203.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-23506d21818sm94457555ad.254.2025.06.03.19.55.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Jun 2025 19:55:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1749005756; x=1749610556; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:from:to:cc:subject:date :message-id:reply-to; bh=SjYjBnl7oiMU6MAiENEsoNhEbfMSMae5CUiyc7OESQ0=; b=IE7CnmQ4Q4Ni0N0DIk6nPqyWuOnx7GXvcl8X80NjQqW+jhmpxdx+iwLZVvv4X4Y2cJ ppT2w1/vSWvjkvAp9JLZ2WdlqewW6r7gSusOUIcECCQTQ9rrzTjsI9nJ2lPnqQmV03uq gpSNaYItydxEUP3rPb7ZXU2zDm1gD4WvmAfhc1aHoDhvwYxmirzwDMV0wUF9kNvrYhTC xIKCQK6GNPIxHh7InA4zL40D0sI2N657pzsVRcVkkGZ7X4KL2KSgvkmrLedwZV6stLxs Hfdr7TbiKbwSAC50M7zF5BVKBKySxEovcVZhKDU+tisoO77hbhuwj3RT9k+7Zb4oN7wM daCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749005756; x=1749610556; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=SjYjBnl7oiMU6MAiENEsoNhEbfMSMae5CUiyc7OESQ0=; b=BBcTb7yoXIob53Vq0p+CrDMUTLl4xOEb1j8NSVjlVP+iXCp2ecmr4oXrt33wf/ebTz BGFK6rudfzWKbWFl9Sagop1mTWZns5YUESjEEhXvicosiE/bMaUcn5iGeTUlH+dFMUXG jtOi8LYIh9Nx2f5kI3B49Dqtr6xPAIu8xQ/2f3RoZKI+kYWByqs3J+VH0StOsK92nKYG x/4fGOCqW/UT6hiC8KmDkPK+IKp3WQ8DiSCOjDwSdQ/ROZAIEz10xBAVOayWbj8fsz0U 5jYm6hnI8sSuzQd6OhGYT1JoW6WF0Za1a4A5aZ3ggemsOwjztUiEBKJ8DvEIvCzKuzda uvwg== X-Forwarded-Encrypted: i=1; AJvYcCWyqcWYI8xMQ2CrWCd/DGe6amrUaeWVp2KHu7CXCJrxJgt0ndOlJe35Tlo4tLLIrFLYswKQlRffv/Cu@nongnu.org X-Gm-Message-State: AOJu0YyZYWxD4Z+8tsRLVYegbA8bHTvkYHRVYI8HzRH5lWROZK2j8jjz jXiAI7mTuaCZVe3mf/2yWWNICW9tuM3lGHElmRGa4GC2AHY/tOSvURzh X-Gm-Gg: ASbGncs99S4woTg+o/YLhu0MOTiUnuJllQS8r7838bWHDKkfe4WuNIu5Es32AdbAvMd mPuGK8zkL9h9BmX0GuWhw1yDjHDJw+KBSiuU6XirGTmZK/a1z92RvujQif/eujP7FQEhLiZnFlK jAgPG5UnSg5e9fxj1FYV7b24i98KEBABGDJ+Z/o7L28YbnWoVPJ2qrfZm7AcdzLf8By51krEXhv Y1JaoDSUz1KxaBNcVx2b9C4C1pkw1VxMKJkPtqVxi5+QQxkzTIwCmJeb474LOJRGQZib7P2lxYd rDbv2ov5n/9Gpum1jmbciI8LGvcT8iJEoanZIIvPQ2Ls/RVn/EdfrCtcyQzBbQfUgHvDSq5s X-Google-Smtp-Source: AGHT+IHoOnyBGFkmT24X4VBKpFjytF3X2SNvD9JPwNb3xRK/hmk8C/cf5yXB7kBBoI7IyiRS6EZkvw== X-Received: by 2002:a17:903:1110:b0:234:9375:e081 with SMTP id d9443c01a7336-235e11eca33mr15549195ad.42.1749005755994; Tue, 03 Jun 2025 19:55:55 -0700 (PDT) From: Joel Stanley To: Alistair Francis , Daniel Henrique Barboza Cc: qemu-riscv@nongnu.org, qemu-devel@nongnu.org Subject: [PATCH v2 01/12] hw/riscv/virt: Fix clint base address type Date: Wed, 4 Jun 2025 12:24:37 +0930 Message-ID: <20250604025450.85327-2-joel@jms.id.au> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250604025450.85327-1-joel@jms.id.au> References: <20250604025450.85327-1-joel@jms.id.au> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::534; envelope-from=joel.stan@gmail.com; helo=mail-pg1-x534.google.com X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.001, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1749005843735116600 Content-Type: text/plain; charset="utf-8" The address is a hardware address, so use hwaddr for consistency with the rest of the machine. Reviewed-by: Daniel Henrique Barboza Reviewed-by: Alistair Francis Signed-off-by: Joel Stanley --- hw/riscv/virt.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/riscv/virt.c b/hw/riscv/virt.c index cf280a92e5ac..875eb7155a30 100644 --- a/hw/riscv/virt.c +++ b/hw/riscv/virt.c @@ -324,7 +324,7 @@ static void create_fdt_socket_clint(RISCVVirtState *s, int cpu; g_autofree char *clint_name =3D NULL; g_autofree uint32_t *clint_cells =3D NULL; - unsigned long clint_addr; + hwaddr clint_addr; MachineState *ms =3D MACHINE(s); static const char * const clint_compat[2] =3D { "sifive,clint0", "riscv,clint0" @@ -340,8 +340,8 @@ static void create_fdt_socket_clint(RISCVVirtState *s, } =20 clint_addr =3D s->memmap[VIRT_CLINT].base + - (s->memmap[VIRT_CLINT].size * socket); - clint_name =3D g_strdup_printf("/soc/clint@%lx", clint_addr); + s->memmap[VIRT_CLINT].size * socket; + clint_name =3D g_strdup_printf("/soc/clint@%"HWADDR_PRIx, clint_addr); qemu_fdt_add_subnode(ms->fdt, clint_name); qemu_fdt_setprop_string_array(ms->fdt, clint_name, "compatible", (char **)&clint_compat, --=20 2.47.2 From nobody Sat Nov 15 16:07:53 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1749005853450307.1887589349443; Tue, 3 Jun 2025 19:57:33 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uMeIP-000240-Li; Tue, 03 Jun 2025 22:56:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uMeIN-00023V-IV; Tue, 03 Jun 2025 22:56:03 -0400 Received: from mail-pl1-x62e.google.com ([2607:f8b0:4864:20::62e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uMeIL-0000Ne-09; Tue, 03 Jun 2025 22:56:03 -0400 Received: by mail-pl1-x62e.google.com with SMTP id d9443c01a7336-234f17910d8so60377195ad.3; Tue, 03 Jun 2025 19:56:00 -0700 (PDT) Received: from donnager-debian.. ([45.124.203.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-23506d21818sm94457555ad.254.2025.06.03.19.55.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Jun 2025 19:55:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1749005759; x=1749610559; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:from:to:cc:subject:date :message-id:reply-to; bh=MeGvg6cXzrjav0ZzmPvxc+8/oL/HaY6cVk0CyPTtjB0=; b=R3cIwhlJRiFUKsEnpoEUfeUxdBcc4bd167Z7iT0Prew/bceTV3b3ysvfRrXZtpwen2 s4DjpzeMFcSfJtymjemcQ84gjBjwfAyoV2WXu1mSx3MRMP9tUZawsCKwjUuIhunfxKZU 749Eg/VtIKEqZjC/0nNjomaGyHAMX4jQK7hlE39+rxnMQzs4F37W7mE/GFfz2GTgrt5f hCpH7l7aaQnCLIHP+MBjrF64o8Yb4QZIFfNqDtIu7dsVGldxb67NnoShZr6MTVA//rdj lTyE18gskbOQDfq83e/Z80L+uhD6cAzXFHCuY+akAMa4ilhX+2Z5GwpYI/BTCAF/UTaS 1U6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749005759; x=1749610559; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=MeGvg6cXzrjav0ZzmPvxc+8/oL/HaY6cVk0CyPTtjB0=; b=Cj7CHGDqyYW4+UU+huX2HCwn5CEIpFqZEsNt/ufgI01O+91Rl/VFQJnRKB0t4NbhGL AlRqNP0gExncUWgct3BTCVhWZ3TJWN3MV5bMXAqiwuSaZO9ExG+feO+mavGt0llDoaNe tP5eddShs1dEq2ZJzk6mjyc9mtwOWEB8RGfmv20z7j1EBU73kPAyJiPIUMKlpgGF7/V5 oouRZ8QHBW/pa4xm5mHVsQyYT09lGOViVk5WyrgxaQHW5SbiZUn8IHqV+JOXHOzHwTpK QAOzfEOquYomyjN41nZcRFvbw7A2nMx7PQKixXFnKO5IPO3w43XnDzjhtBa4P4dQPZo9 P9cw== X-Forwarded-Encrypted: i=1; AJvYcCUoGMEtOnKRVy1dPQi8OCWeW7PxxMQKbUuvjo4LT44nM50Yk1zndEqiTqEKy0OxRvYSKEKUELfnsv/+@nongnu.org X-Gm-Message-State: AOJu0YyvPyaK2H/fUPNbDuYaWXyVfb1FbHBuCTSPThJ4QUJm/hBm/iWG 8ByI69R7UioS1Qc3CgKFcrd7OV7BGh0MqgswwU2hVpGDepgtsHGlJoizGNtk5gkM X-Gm-Gg: ASbGncujPt/puvOj+XbaDaZBO9Y37/EejUQDouaPWP0s5+PtFsvrwSD9l0eGRPsZDr7 6jm9uc7hejY0zR/x5B1vK0m4TD+im+Z2Brd2VXsMeQWGz6Xupf+PVNfseDrzmX5B63YDxGPBHxu EabutmszXJqWvgwRvbkIX0/JL5DwecTY7/AV2mLq3cGR+a6zAMEYCrhewVrcX1c9+1wNm49fEna SvzAYmcBuRNcmRswKQ1nO9RC0x5EaJr2xvMhMHxuBjnENw+reodTeV94fpbX8uxcj8/aAslW1b2 HdVNtjm6Sc3VIrJwZAv0P5dF+lusligVAEJsX8Eu0jXpmT/jCGwdl80eGpdW1xGP6APPUPu/ X-Google-Smtp-Source: AGHT+IGztwzy+wmA/FPmfesj5ESIRD6lYa5Ve7BhTJqGGT/8mSsYDFphkpRee7b6SRCXokRcGsRioA== X-Received: by 2002:a17:902:e74b:b0:234:a3d2:78fd with SMTP id d9443c01a7336-235e11fe5d9mr17537235ad.36.1749005758822; Tue, 03 Jun 2025 19:55:58 -0700 (PDT) From: Joel Stanley To: Alistair Francis , Daniel Henrique Barboza Cc: qemu-riscv@nongnu.org, qemu-devel@nongnu.org Subject: [PATCH v2 02/12] hw/riscv/virt: Use setprop_sized_cells for clint Date: Wed, 4 Jun 2025 12:24:38 +0930 Message-ID: <20250604025450.85327-3-joel@jms.id.au> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250604025450.85327-1-joel@jms.id.au> References: <20250604025450.85327-1-joel@jms.id.au> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::62e; envelope-from=joel.stan@gmail.com; helo=mail-pl1-x62e.google.com X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.001, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1749005853888116600 Content-Type: text/plain; charset="utf-8" The current device tree property uses two cells for the address (and for the size), but assumes the they are less than 32 bits by hard coding the high cell to zero. Use qemu_fdt_setprop_sized_cells to do the job of splitting the upper and lower 32 bits across cells. Reviewed-by: Daniel Henrique Barboza Reviewed-by: Alistair Francis Signed-off-by: Joel Stanley --- hw/riscv/virt.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/riscv/virt.c b/hw/riscv/virt.c index 875eb7155a30..5143a465555a 100644 --- a/hw/riscv/virt.c +++ b/hw/riscv/virt.c @@ -346,8 +346,8 @@ static void create_fdt_socket_clint(RISCVVirtState *s, qemu_fdt_setprop_string_array(ms->fdt, clint_name, "compatible", (char **)&clint_compat, ARRAY_SIZE(clint_compat)); - qemu_fdt_setprop_cells(ms->fdt, clint_name, "reg", - 0x0, clint_addr, 0x0, s->memmap[VIRT_CLINT].size); + qemu_fdt_setprop_sized_cells(ms->fdt, clint_name, "reg", + 2, clint_addr, 2, s->memmap[VIRT_CLINT].size); qemu_fdt_setprop(ms->fdt, clint_name, "interrupts-extended", clint_cells, s->soc[socket].num_harts * sizeof(uint32_t) * 4); riscv_socket_fdt_write_id(ms, clint_name, socket); --=20 2.47.2 From nobody Sat Nov 15 16:07:53 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1749005887737426.71732131110275; Tue, 3 Jun 2025 19:58:07 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uMeIQ-00024t-NB; Tue, 03 Jun 2025 22:56:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uMeIO-00023t-Rp; Tue, 03 Jun 2025 22:56:04 -0400 Received: from mail-pl1-x62d.google.com ([2607:f8b0:4864:20::62d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uMeIN-0000Nu-BB; Tue, 03 Jun 2025 22:56:04 -0400 Received: by mail-pl1-x62d.google.com with SMTP id d9443c01a7336-235d6de331fso11862145ad.3; Tue, 03 Jun 2025 19:56:02 -0700 (PDT) Received: from donnager-debian.. ([45.124.203.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-23506d21818sm94457555ad.254.2025.06.03.19.55.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Jun 2025 19:56:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1749005762; x=1749610562; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:from:to:cc:subject:date :message-id:reply-to; bh=S/RDXCfB4a2xfexhBzBRYa2uyDwDEGd0jWyYIoveQVk=; b=ELJ5YPTU/CKixuJUjWYY+28bZsjtx83+hOUa3O41fFih8mvk2G/F91plBZaufMUcqj NtWpw0aghBtyLdteds74WMeXImEYrQZjy1B70nshRpxE4zlJAcShKnUh2TcXYHeHVvzV j3PlNXshqCV8rHS+heNr7+FogLfISFxDI14n8xRwSBRfXxgjaFx5raabbJuJcVWYeK4+ jfyhikn7uNf5SO6+Ggi1cFvhFvW5pDfZltzSbh0vtcNDalALoPWZbvYobJybAZ15X281 3PSJlcwJx+jbOAd6Sjq6xcEB5ws6JSaaxBghEF/eYCLEGuWdDYy3U0KvDNGtQ2AxCFGD FdJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749005762; x=1749610562; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=S/RDXCfB4a2xfexhBzBRYa2uyDwDEGd0jWyYIoveQVk=; b=kAarHrhjHaWaPddoqc1WBDgggL1QjLMfN8JAShIVLqd9/BBpijQ2aceQUVT06ln0e2 YXUqQ1rAqWaRFXGhg6Inh63lZFuGok4GS8m3vPJGTH0CaTSqhlis44JCDXlk4vdnoyAD tACqkeNK6iivoQ6sj93tiG75o5r+bQE3EEHA5Sb3HNIqY19FmwQ9i5svQCOrwIqh+g7z 35C7k+KuGJ4vpW8YUJ00Tw/DnCFxQumPhXw+Ji3lRYwXR4/zNhZEZtfIj4c48vJVC04g eQOByqfRg9Lns0kE8dFmvCANfDD2gBz9tOM/q6zy5nfeD42W1Ov0y2+0boKghsltc32K ffgw== X-Forwarded-Encrypted: i=1; AJvYcCUFq++TQKLRpetRJczEXLl7ifCOIo3R7PxBUHNna9gNTccT+kJsLu11zgV1IH5QYIXM1CW8jDATCHyv@nongnu.org X-Gm-Message-State: AOJu0YyLoig8EZ11RmmtLiWR9anDhwnnqGUXieVzjiHkqyOS/Ofszuk9 94ZESMM5+pzYfv2TevsP4kWmkIfh7quvrJjKrZVoBQy5PFBpStiGygkO X-Gm-Gg: ASbGnctpAijm7k8I393P9isw20GO8AScSR5XJ01CLCHiXer5XMu8rrHysCAW3IApp/6 y5WdyCCOsW3Nt6KEXp09C6NcCSs1XZdmpzz38N8N2jStq5Q/ZOEDffW3Y+Y4Hy9pNf8jW/Ds8WN zATD6uKWud6UFON4bigtCCQUrt4+anERje3hOkYC+Jom42Xvldyw/5+S9gW4tKy1zb4Mmiw0c4F pPRgQI7GexbJWwcTA5wmzTwn45i7btdwhNjrtlhQUGlmOOIbSXTashlheSqZnM0raFRAqUyttzk 6bFRE2VhRRsuItW+MaOD7+gs9hpniJfloo2DRY0szsaIpSxsWTs3pnj0H3ypGg== X-Google-Smtp-Source: AGHT+IGAdxBQZMz5grysvELBTC2zbk6QXJeyOtKHe9wS8ho/h5zL+YdHimnRThABew+ItGAvG1PKkQ== X-Received: by 2002:a17:902:ea0b:b0:234:986c:66c6 with SMTP id d9443c01a7336-235e1129230mr14361835ad.2.1749005761598; Tue, 03 Jun 2025 19:56:01 -0700 (PDT) From: Joel Stanley To: Alistair Francis , Daniel Henrique Barboza Cc: qemu-riscv@nongnu.org, qemu-devel@nongnu.org Subject: [PATCH v2 03/12] hw/riscv/virt: Use setprop_sized_cells for memory Date: Wed, 4 Jun 2025 12:24:39 +0930 Message-ID: <20250604025450.85327-4-joel@jms.id.au> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250604025450.85327-1-joel@jms.id.au> References: <20250604025450.85327-1-joel@jms.id.au> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::62d; envelope-from=joel.stan@gmail.com; helo=mail-pl1-x62d.google.com X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.001, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1749005888206116600 Content-Type: text/plain; charset="utf-8" Use qemu_fdt_setprop_sized_cells to do the job of splitting the upper and lower 32 bits across cells. Reviewed-by: Daniel Henrique Barboza Reviewed-by: Alistair Francis Signed-off-by: Joel Stanley --- hw/riscv/virt.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/hw/riscv/virt.c b/hw/riscv/virt.c index 5143a465555a..e074a296751a 100644 --- a/hw/riscv/virt.c +++ b/hw/riscv/virt.c @@ -311,8 +311,7 @@ static void create_fdt_socket_memory(RISCVVirtState *s,= int socket) size =3D riscv_socket_mem_size(ms, socket); mem_name =3D g_strdup_printf("/memory@%"HWADDR_PRIx, addr); qemu_fdt_add_subnode(ms->fdt, mem_name); - qemu_fdt_setprop_cells(ms->fdt, mem_name, "reg", - addr >> 32, addr, size >> 32, size); + qemu_fdt_setprop_sized_cells(ms->fdt, mem_name, "reg", 2, addr, 2, siz= e); qemu_fdt_setprop_string(ms->fdt, mem_name, "device_type", "memory"); riscv_socket_fdt_write_id(ms, mem_name, socket); } --=20 2.47.2 From nobody Sat Nov 15 16:07:53 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1749005814080709.569676952697; Tue, 3 Jun 2025 19:56:54 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uMeIU-00026t-SA; Tue, 03 Jun 2025 22:56:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uMeIS-00025r-ME; Tue, 03 Jun 2025 22:56:08 -0400 Received: from mail-pl1-x630.google.com ([2607:f8b0:4864:20::630]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uMeIR-0000OV-06; Tue, 03 Jun 2025 22:56:08 -0400 Received: by mail-pl1-x630.google.com with SMTP id d9443c01a7336-23035b3edf1so57516975ad.3; Tue, 03 Jun 2025 19:56:06 -0700 (PDT) Received: from donnager-debian.. ([45.124.203.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-23506d21818sm94457555ad.254.2025.06.03.19.56.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Jun 2025 19:56:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1749005765; x=1749610565; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:from:to:cc:subject:date :message-id:reply-to; bh=YXzQjQHha3k8G+tIoP6yHELVJ1uynYIijybQ2TGYkZE=; b=miXOEAK27hp/QOSSLH6MFV65V1EPQDX0P0tACjG0hM3EmGGaJ8hmOh88GnvxcRKU/H Zlxcz9/HpZusnvI70eMHa1rktT24F7WzrPYHKmJIrnoLyM2cZSWcVMDwyy6WcKoMRl1o run9LrmnZ4Yz5qVrz9cg9L1y0BjoPWh4UWtqp7WimBNksu20pxCfOKlFY+nGRTUln7SD uQANJ8/cvNA4R5ggPowEOUQR+MWr9ZhylzgUcgbT0RjFZ13m/Fuo81Hbm3NVSFD6PC+0 z7DOf0NHjJ4556GkGi0Gh8rFeviQiZbfJJIYLmks3O2U0FsEdXnFwEr7dVfBjEAUaZN3 vraw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749005765; x=1749610565; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=YXzQjQHha3k8G+tIoP6yHELVJ1uynYIijybQ2TGYkZE=; b=YUH34MWY6goXJifTHRBscRsnTUrw1CZpuV0bZHTJfJaE8Q0KhUuWD4NCQGhPFQb3VX QpSv/cB8FeoBWgeV9PiWxc7kMUb9PFXeGBSoLOgT+vJ6t7PGyPv9Mmw7LgKsftVGbkBp KHhbHEjJyses3HEiuU3X8MpIPXKhTcAquHqF5ax/To7rVmyNeRktNbr2sddMQGsu8jNh 5HtdBirAYxvhN8BTlC0N5RAUOF3fNABXZvmVORl5FDyYV3Qd39xjgTVRxR6a4iO1eDL9 nXLH2edzRfULphnrCFUoeFLLlXeoc35ArcJAdL+sL/YhGj39LOh6v7vdchewVpqSTcl8 m6Ug== X-Forwarded-Encrypted: i=1; AJvYcCVKYWhd3MIfrksL6002EM1wqvXzOoiV1+kTPs2AT8QGyA0Z4CC1HGdmyNuJds4uZ9fFEDz5d657O6/F@nongnu.org X-Gm-Message-State: AOJu0YwAZkugjQfUegBOK+BlKcLm6Ntg8/sAoUuR7UuBu0ZMayt+MyVR dBs9OsGi6LmGea+79UGQgRe3XQEIO/WDCydzRzLd3kTw/6lKrKcxDT2E X-Gm-Gg: ASbGncvicxQWv7f5UvRHRWq4UVuAgLP1TjKVrOei63/Pz0/t470uCVCuMMnslaLsKjL 7koCBHipGTUZU3trsQQ8Ia541Sm7leqSUYjtlzcioK6yoUs425tz+blsJEZphqECZdDnh2M7qmZ V5VRltQjgAFEFG3moDPMUtVwEtMfy7DFxv0zarKYYF8WxMrjkN8yU/q0urE/CBMCiagCmSoxEEF xjX0yJxr6lRSxcoyHrpvF1htLAKziwojfeHqng30ysVCAZdbzoUKFR2s06fRSjCNaDSdTFNKhaP 5ICnTUQ/Co2fuEvjTjxLDjD+9KocJiE0SZxmfep3dK6AftsE1ZtboSwnJ08nwA== X-Google-Smtp-Source: AGHT+IGdXUuCkBK5O2SiIkB46e1SDPEkceyhhNez1Fgnq5pidi75Z8zcIxBwI/37GGM0ObT+w75PmA== X-Received: by 2002:a17:902:e74e:b0:223:65dc:4580 with SMTP id d9443c01a7336-235e151c771mr12561885ad.52.1749005765304; Tue, 03 Jun 2025 19:56:05 -0700 (PDT) From: Joel Stanley To: Alistair Francis , Daniel Henrique Barboza Cc: qemu-riscv@nongnu.org, qemu-devel@nongnu.org Subject: [PATCH v2 04/12] hw/riscv/virt: Use setprop_sized_cells for aplic Date: Wed, 4 Jun 2025 12:24:40 +0930 Message-ID: <20250604025450.85327-5-joel@jms.id.au> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250604025450.85327-1-joel@jms.id.au> References: <20250604025450.85327-1-joel@jms.id.au> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::630; envelope-from=joel.stan@gmail.com; helo=mail-pl1-x630.google.com X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.001, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1749005821820116600 Content-Type: text/plain; charset="utf-8" The current device tree property uses two cells for the address (and for the size), but assumes the they are less than 32 bits by hard coding the high cell to zero. Use qemu_fdt_setprop_sized_cells to do the job of splitting the upper and lower 32 bits across cells. Reviewed-by: Daniel Henrique Barboza Reviewed-by: Alistair Francis Signed-off-by: Joel Stanley --- hw/riscv/virt.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/riscv/virt.c b/hw/riscv/virt.c index e074a296751a..205fa6e44f29 100644 --- a/hw/riscv/virt.c +++ b/hw/riscv/virt.c @@ -655,8 +655,8 @@ static void create_fdt_one_aplic(RISCVVirtState *s, int= socket, qemu_fdt_setprop_cell(ms->fdt, aplic_name, "msi-parent", msi_phand= le); } =20 - qemu_fdt_setprop_cells(ms->fdt, aplic_name, "reg", - 0x0, aplic_addr, 0x0, aplic_size); + qemu_fdt_setprop_sized_cells(ms->fdt, aplic_name, "reg", + 2, aplic_addr, 2, aplic_size); qemu_fdt_setprop_cell(ms->fdt, aplic_name, "riscv,num-sources", VIRT_IRQCHIP_NUM_SOURCES); =20 --=20 2.47.2 From nobody Sat Nov 15 16:07:53 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1749005874364672.0003771791828; Tue, 3 Jun 2025 19:57:54 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uMeIW-00027T-Ud; Tue, 03 Jun 2025 22:56:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uMeIV-00026y-5w; Tue, 03 Jun 2025 22:56:11 -0400 Received: from mail-pl1-x62b.google.com ([2607:f8b0:4864:20::62b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uMeIT-0000P3-Ms; Tue, 03 Jun 2025 22:56:10 -0400 Received: by mail-pl1-x62b.google.com with SMTP id d9443c01a7336-2352e3db62cso45450195ad.2; Tue, 03 Jun 2025 19:56:09 -0700 (PDT) Received: from donnager-debian.. ([45.124.203.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-23506d21818sm94457555ad.254.2025.06.03.19.56.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Jun 2025 19:56:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1749005768; x=1749610568; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:from:to:cc:subject:date :message-id:reply-to; bh=trWsim9P8VoeUTyxM6i3oLW4qplPzfRCJw14dYpxdW8=; b=Uf2U72wuDZRXq4i7VlyoXpUOLWLzu4vbGQ+29xlZnB2Ie22cNqmu7axtIb7kG/hDKf 5kgj8D2yekZEnGLRGXfLiRlIoVKS/tDsU7U/rgKhA7viLp0su37R4mfhQnANriFRu2h+ DpeRNDkYJACq1GeWEjqdC3VM9jZvIeGLIo7vpPeoNgCgB/enL546/PvN+Fgg2LsNoJQX lKGad8nnUHXng1mNB8pcRaA/n4ncpdiQfRY1OtP160yYTG3pVi+kFFebxEaClyWAnPDe gk3NTClKxD2ed99T287bsnRhAmYQ0rxNHknCUB0qOqedGINGugllnUOIxK5uFBPWioMl E37g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749005768; x=1749610568; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=trWsim9P8VoeUTyxM6i3oLW4qplPzfRCJw14dYpxdW8=; b=EwBxOZa6aV9Al/sp/OJtHs5AfCWNfUs5ePbQmq0EDJyiOAR90CmUUeBP4fTVhG5ny8 y4Vp1Rdn/gYmK0ziXTLLKSEI+0FIKl8Hf6ABqb4lINIQ6ERh0OiZyUQ8Uy2bGo04lLsu FB2oDBr4vAtSRMOY9oQ8DpFi9IgDcjwu8spZxks5z1/hSXj4hGSKyxl9Tj94s5dqlHKE WqJsW2vHGl/DSSllJxH3Pt8ocdaRDXLiGZieHK2uI5QxgqvtAUA9t+odqIkzlywosD1V LKfaILikopN6oUEvql7rKEFd9cycvcqtLFrGyP2iAo/egFbS0KoRj868vbj54ehuahUT +cGA== X-Forwarded-Encrypted: i=1; AJvYcCWvdxC4yWmllog6Fdnl3KFy/iu+NHhPnK5zzDpvsio9PgJx7ibey2+JYHVuaCUD3xm5+qfVG6boL+Q0@nongnu.org X-Gm-Message-State: AOJu0YwyCP3waotV0DEF4hH0Y5wXYC5sVzxXwoJikLoDfqwo3ZVzDdCr oSYfdph/MPemZ1uX+QOL0qx1URCCbpFInH5C008jLbhR8m0PZWSupBb0 X-Gm-Gg: ASbGncvjdGtuSJaZ0m1AtwP42mApDrkjQMk0Oh57VX/luW4h1O3NM1UOC8g+5LKXEaq 3giLXIHkYRhakeb8jIaWWk3oYyDgnTITahQ48kp0uUUhDoDbxoUpVZHqZQLp3LpHQXDvYXSbN8J OskbbC2OxpjYIPWDmcPbUbzHYcURvoENYcKdu13U+j41d5fkIvC5Dh2mQ25KiGiVgrSO62PE7n5 gm/rlsrYOIHN9OQgc8EQZySrrt4odQkupCGZVBtEkwnGLu0nfgcAGzL+xQEXgsfzGqralBk6WDR my0HQiZ1kPB/siJI7Mk0u42lKZGFf1qJbmwI1j0A1K83eKAiHwpgLufVot8JnVvu7tY8Q3Mh X-Google-Smtp-Source: AGHT+IEgWP5CfQZOKawlyNQMyeptgcxlhdwqOxDdDDV1ajwVTv/Wj7QfZP9bpwAMlmOnyOhJUuExGg== X-Received: by 2002:a17:903:2349:b0:220:c4e8:3b9f with SMTP id d9443c01a7336-235e0f2c875mr17881135ad.0.1749005768053; Tue, 03 Jun 2025 19:56:08 -0700 (PDT) From: Joel Stanley To: Alistair Francis , Daniel Henrique Barboza Cc: qemu-riscv@nongnu.org, qemu-devel@nongnu.org Subject: [PATCH v2 05/12] hw/riscv/virt: Use setprop_sized_cells for aclint Date: Wed, 4 Jun 2025 12:24:41 +0930 Message-ID: <20250604025450.85327-6-joel@jms.id.au> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250604025450.85327-1-joel@jms.id.au> References: <20250604025450.85327-1-joel@jms.id.au> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::62b; envelope-from=joel.stan@gmail.com; helo=mail-pl1-x62b.google.com X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.001, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1749005876246116600 Content-Type: text/plain; charset="utf-8" The current device tree property uses two cells for the address (and for the size), but assumes the they are less than 32 bits by hard coding the high cell to zero. Use qemu_fdt_setprop_sized_cells to do the job of splitting the upper and lower 32 bits across cells. Reviewed-by: Daniel Henrique Barboza Reviewed-by: Alistair Francis Signed-off-by: Joel Stanley --- hw/riscv/virt.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/hw/riscv/virt.c b/hw/riscv/virt.c index 205fa6e44f29..4fd966a34277 100644 --- a/hw/riscv/virt.c +++ b/hw/riscv/virt.c @@ -387,8 +387,8 @@ static void create_fdt_socket_aclint(RISCVVirtState *s, qemu_fdt_add_subnode(ms->fdt, name); qemu_fdt_setprop_string(ms->fdt, name, "compatible", "riscv,aclint-mswi"); - qemu_fdt_setprop_cells(ms->fdt, name, "reg", - 0x0, addr, 0x0, RISCV_ACLINT_SWI_SIZE); + qemu_fdt_setprop_sized_cells(ms->fdt, name, "reg", + 2, addr, 2, RISCV_ACLINT_SWI_SIZE); qemu_fdt_setprop(ms->fdt, name, "interrupts-extended", aclint_mswi_cells, aclint_cells_size); qemu_fdt_setprop(ms->fdt, name, "interrupt-controller", NULL, 0); @@ -410,11 +410,11 @@ static void create_fdt_socket_aclint(RISCVVirtState *= s, qemu_fdt_add_subnode(ms->fdt, name); qemu_fdt_setprop_string(ms->fdt, name, "compatible", "riscv,aclint-mtimer"); - qemu_fdt_setprop_cells(ms->fdt, name, "reg", - 0x0, addr + RISCV_ACLINT_DEFAULT_MTIME, - 0x0, size - RISCV_ACLINT_DEFAULT_MTIME, - 0x0, addr + RISCV_ACLINT_DEFAULT_MTIMECMP, - 0x0, RISCV_ACLINT_DEFAULT_MTIME); + qemu_fdt_setprop_sized_cells(ms->fdt, name, "reg", + 2, addr + RISCV_ACLINT_DEFAULT_MTIME, + 2, size - RISCV_ACLINT_DEFAULT_MTIME, + 2, addr + RISCV_ACLINT_DEFAULT_MTIMECMP, + 2, RISCV_ACLINT_DEFAULT_MTIME); qemu_fdt_setprop(ms->fdt, name, "interrupts-extended", aclint_mtimer_cells, aclint_cells_size); riscv_socket_fdt_write_id(ms, name, socket); @@ -428,8 +428,8 @@ static void create_fdt_socket_aclint(RISCVVirtState *s, qemu_fdt_add_subnode(ms->fdt, name); qemu_fdt_setprop_string(ms->fdt, name, "compatible", "riscv,aclint-sswi"); - qemu_fdt_setprop_cells(ms->fdt, name, "reg", - 0x0, addr, 0x0, s->memmap[VIRT_ACLINT_SSWI].size); + qemu_fdt_setprop_sized_cells(ms->fdt, name, "reg", + 2, addr, 2, s->memmap[VIRT_ACLINT_SSWI].size); qemu_fdt_setprop(ms->fdt, name, "interrupts-extended", aclint_sswi_cells, aclint_cells_size); qemu_fdt_setprop(ms->fdt, name, "interrupt-controller", NULL, 0); --=20 2.47.2 From nobody Sat Nov 15 16:07:53 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1749005873777125.50383770865187; Tue, 3 Jun 2025 19:57:53 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uMeIb-000294-Mi; Tue, 03 Jun 2025 22:56:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uMeIZ-000281-5c; Tue, 03 Jun 2025 22:56:15 -0400 Received: from mail-pj1-x102d.google.com ([2607:f8b0:4864:20::102d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uMeIX-0000PR-IH; Tue, 03 Jun 2025 22:56:14 -0400 Received: by mail-pj1-x102d.google.com with SMTP id 98e67ed59e1d1-311da0bef4aso6849183a91.3; Tue, 03 Jun 2025 19:56:12 -0700 (PDT) Received: from donnager-debian.. ([45.124.203.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-23506d21818sm94457555ad.254.2025.06.03.19.56.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Jun 2025 19:56:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1749005772; x=1749610572; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:from:to:cc:subject:date :message-id:reply-to; bh=PRXSFCctYU6eIeoEwNRJJ2XIPCgo6TSpCf+Bf38w7iU=; b=eQHtXUux0hhGc1smPi8gFtGoQ3cj3P5AKTOTXgQMgw5b10hiJ6gapsboDDqAwt96vf r5ogprOw9D2UvRr8TCtQd3VMeveod/EVZ+DxmS9Dt5QIfnvGbKvUCHBw6ndpevWv7mnJ yJEMXGoTFKsK995L4VXnJZjsHem7hMNSyTIcFDixZaKfSrm+iTpHalWU1/BkDapB429G As+fnC4lKeiigfJQJtNYMLcZiyfRjcl1IU6WyBVT61jNzEeqlR0sBzZBZdcS2fAUlozu KFaLKRZIZgl72+qw31MPBi8Au0froNGMGMtIiW4Uk5z6kNM2oJN7X9/gGwGfQFbMn50T 36Xw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749005772; x=1749610572; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=PRXSFCctYU6eIeoEwNRJJ2XIPCgo6TSpCf+Bf38w7iU=; b=DO15sRcpK4+tES9IRdMh8pk5+AYlyD8laokeugXegthyCcqM4Cfe+K5vq1xetDUB/0 5HXTSP5ptaAdndT8OzRSxLrmhgyWUOf+O2V/aX3NGyJ5kvPahYQ9yW+r53jOQna3syht mACLTGaqKtuB/PQBqv+WbyQmQ0hqQAiiThCFYoDLv6fj6EC6+JGkrNXWTJm9sPAUqJ6+ X4+H5HvsyZ8Hm3wdFUc+m5fNGch+2yLKIm7cZnCVVDk8ktLauR5QZohCSEOVLtnk4pYW b8A3nKCf2nYn0byiNG4Urre15o0siXhLjvtyUNaeyPe7fUFQM3ofp7gAW70AbxjeeijI 39rg== X-Forwarded-Encrypted: i=1; AJvYcCVvPet9nPs1U9W7mguy2b1IDxMo8l2uaQoiHmyV7KuUqKhlFpzgCzAlFHIftJip6IeTWZs1Cldwc8y1@nongnu.org X-Gm-Message-State: AOJu0YxcITBeWxIN7Od5ziFYLW0LJyrDuZzLzVVEeOxP99F1g4fO6srt KM4x27QSxqCZtvlSzQUi+XRJL9eBsnYMfjle9zJbnElXj1rleiyI8Rcm X-Gm-Gg: ASbGnct7LzI3HTNtzAmH1eiZno6kdJP4T4QMxATsqzqz/4a1xj/+P7PNgVSFWQLeh0h +g++0tQlZ2RcgrIT2NpkmFC3+CI6cH3fBw8DyD9Y+9ea64ITEgDASBLcgd8ZJYyip3UntAPwDgA S6vuepMi+i5TRY/Elsm2SIrdkY0pi6vKgwyrimhZuTFIwktCCLhHhu1FhD0khrjkYrOCxos13/6 izL/CML6lLQS0dAQvgztKP8r49pj9dnJ08p967TrzH4yvhvHqDkEix2MJFlR/nk4lroNkfZ8SG3 mxWSzKXAZgIaQXRYbO55zgtDABCP6pCwkj5bDI3Mvyz+b2ayMwrBndsa6kmcNQ== X-Google-Smtp-Source: AGHT+IFYvUz6DetSkmWankGNz0UvGs6Y9YpwXsDBOwiGBh9r/IWtfRsh9a0sGLISAUe6ynoSWTbSaw== X-Received: by 2002:a17:90b:4a:b0:311:cc4e:516b with SMTP id 98e67ed59e1d1-3130cdfa97dmr1786860a91.32.1749005771793; Tue, 03 Jun 2025 19:56:11 -0700 (PDT) From: Joel Stanley To: Alistair Francis , Daniel Henrique Barboza Cc: qemu-riscv@nongnu.org, qemu-devel@nongnu.org Subject: [PATCH v2 06/12] hw/riscv/virt: Use setprop_sized_cells for plic Date: Wed, 4 Jun 2025 12:24:42 +0930 Message-ID: <20250604025450.85327-7-joel@jms.id.au> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250604025450.85327-1-joel@jms.id.au> References: <20250604025450.85327-1-joel@jms.id.au> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::102d; envelope-from=joel.stan@gmail.com; helo=mail-pj1-x102d.google.com X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.001, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1749005876222116600 Content-Type: text/plain; charset="utf-8" The current device tree property uses two cells for the address (and for the size), but assumes the they are less than 32 bits by hard coding the high cell to zero. Use qemu_fdt_setprop_sized_cells to do the job of splitting the upper and lower 32 bits across cells. Reviewed-by: Daniel Henrique Barboza Reviewed-by: Alistair Francis Signed-off-by: Joel Stanley --- hw/riscv/virt.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/riscv/virt.c b/hw/riscv/virt.c index 4fd966a34277..67e60eec1f00 100644 --- a/hw/riscv/virt.c +++ b/hw/riscv/virt.c @@ -493,8 +493,8 @@ static void create_fdt_socket_plic(RISCVVirtState *s, s->soc[socket].num_harts * sizeof(uint32_t) * 4); } =20 - qemu_fdt_setprop_cells(ms->fdt, plic_name, "reg", - 0x0, plic_addr, 0x0, s->memmap[VIRT_PLIC].size); + qemu_fdt_setprop_sized_cells(ms->fdt, plic_name, "reg", + 2, plic_addr, 2, s->memmap[VIRT_PLIC].siz= e); qemu_fdt_setprop_cell(ms->fdt, plic_name, "riscv,ndev", VIRT_IRQCHIP_NUM_SOURCES - 1); riscv_socket_fdt_write_id(ms, plic_name, socket); --=20 2.47.2 From nobody Sat Nov 15 16:07:53 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1749005861589339.3051907404838; Tue, 3 Jun 2025 19:57:41 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uMeId-00029v-W2; Tue, 03 Jun 2025 22:56:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uMeIb-00029B-UU; Tue, 03 Jun 2025 22:56:17 -0400 Received: from mail-pl1-x633.google.com ([2607:f8b0:4864:20::633]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uMeIa-0000Pg-Cg; Tue, 03 Jun 2025 22:56:17 -0400 Received: by mail-pl1-x633.google.com with SMTP id d9443c01a7336-23035b3edf1so57517665ad.3; Tue, 03 Jun 2025 19:56:15 -0700 (PDT) Received: from donnager-debian.. ([45.124.203.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-23506d21818sm94457555ad.254.2025.06.03.19.56.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Jun 2025 19:56:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1749005774; x=1749610574; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:from:to:cc:subject:date :message-id:reply-to; bh=2TW2qvDv71buLaLj/Jgf+ppXxchJib0Z3gTkRO9ucyE=; b=APW3pJaHjDRlJGT6M/RA/HcTT1PP2VV+5lKFbrr+GAk0Ajvtm5jxlx/elp5gFMwlUi 3MtZOyspHTi65hwv2pymRZ/ty2axfVLQC3cwqMcJ4FBwRU7UPutPuq1A2g/17BkLXNOs eKT3EoUNf0+B4IqzXi1Cm0uER0/ypCQ3Cum3nsNlydgrOnfE7vJaDKO7GXmXLNeMMYPK 1GeP4ixo3QaTiVobHXHfa5FTultV3sHicRK8LOVKJkWP8K0X87BYXfqDbN82Q2DQKKwZ 0K4z9mvAqeBEiwtLleLeYqqydcxaOcm3SM1hbI0o/e1xLIZocWdRCdRjwjgfD0/yHRu5 UkJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749005774; x=1749610574; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=2TW2qvDv71buLaLj/Jgf+ppXxchJib0Z3gTkRO9ucyE=; b=K/OrHcjIn6Gm624PsUvkuM1eRmbiB5E9IGKAapqxnKFTHuHtM92KxXbWR+8MCn//qm fvk/3ZX13GuO7VD0oyXydnBcqmQDJg6NnfMLPJwULZlCJOlK7y7qLzn/GXjuOO8BocSv BzyRJqepPZ1XGgUkIURxMq8KO4bn29X0sElLbih1QJD59aTwulG+7KqRxVQkExmcakks Hr18RDLqIFJXPjogTGOFgFVOMHjSA2O8T8w7nJtF/b7lMVEEhS9j2G+U854JSEUV6Tt6 dxbA/hy2Nejbvgcu00Lo8DM92LA2eeeSvOIZrrCA+O7Pywctuea48jTyS4o5ojWB3Pg2 QoDg== X-Forwarded-Encrypted: i=1; AJvYcCVGscPa4RAUh4QEF7Giit/MD1PnS9rAI8Pgfs/MDkrzGWIb8BWDhCOpB1dn/zefOBI1GGK66b+3qmnO@nongnu.org X-Gm-Message-State: AOJu0YxtzKIivynrSpImJREDsBIvr9FPCpx3eORlHC5vVYOHucT44aIi 3LapH6xlLFCJUFHvzqrA3hxo3ZM9fvEaDKc4+dc7cwUeMyjZcYtRhbDk X-Gm-Gg: ASbGncuO3mMG2KvTdLbgUdh3awzfATcmAoJSaPv4PQKPjUNuEy0yQx0NgP3UL/DU1s0 DDcvh+N2n8vy3QC4ey60hMNgac00EWMJoVaWHeH/nMfhLmk4cNGYlmYDzWKiRA3HDN/MaXa92YF aGZefqmmy2i85hCgnVX6ZhJFfz/TiwMXlpLMV172Bono5yMrpQSQcJa8p103VFXlZ+iE6hZni1m jDHuXE1DJHOtc3Esd/4B5gcFh/PtzkN13oQaEwybfJE57gLOgCctuM1gScTgZ1Q59m55DGQuWYa YXDlTJFuHsr4K4rv6ysvmjAeXMuYR0cbL9KUDmyX8r/3+7h8/TJnGQgES7f6zg== X-Google-Smtp-Source: AGHT+IE5nQMp5rPZ9tpEiPdq6ffxx6p/6RGswvmuZeosf0Pi5lVRHSNDlous3NxYm0iYD4WAS2ap3w== X-Received: by 2002:a17:903:2291:b0:234:c8f6:1afb with SMTP id d9443c01a7336-235e12c4defmr16200855ad.0.1749005774607; Tue, 03 Jun 2025 19:56:14 -0700 (PDT) From: Joel Stanley To: Alistair Francis , Daniel Henrique Barboza Cc: qemu-riscv@nongnu.org, qemu-devel@nongnu.org Subject: [PATCH v2 07/12] hw/riscv/virt: Use setprop_sized_cells for virtio Date: Wed, 4 Jun 2025 12:24:43 +0930 Message-ID: <20250604025450.85327-8-joel@jms.id.au> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250604025450.85327-1-joel@jms.id.au> References: <20250604025450.85327-1-joel@jms.id.au> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::633; envelope-from=joel.stan@gmail.com; helo=mail-pl1-x633.google.com X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.001, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1749005864029116600 Content-Type: text/plain; charset="utf-8" The current device tree property uses two cells for the address (and for the size), but assumes the they are less than 32 bits by hard coding the high cell to zero. Use qemu_fdt_setprop_sized_cells to do the job of splitting the upper and lower 32 bits across cells. Reviewed-by: Daniel Henrique Barboza Reviewed-by: Alistair Francis Signed-off-by: Joel Stanley --- hw/riscv/virt.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/hw/riscv/virt.c b/hw/riscv/virt.c index 67e60eec1f00..851c7cc82ad5 100644 --- a/hw/riscv/virt.c +++ b/hw/riscv/virt.c @@ -856,9 +856,7 @@ static void create_fdt_virtio(RISCVVirtState *s, uint32= _t irq_virtio_phandle) =20 qemu_fdt_add_subnode(ms->fdt, name); qemu_fdt_setprop_string(ms->fdt, name, "compatible", "virtio,mmio"= ); - qemu_fdt_setprop_cells(ms->fdt, name, "reg", - 0x0, addr, - 0x0, size); + qemu_fdt_setprop_sized_cells(ms->fdt, name, "reg", 2, addr, 2, siz= e); qemu_fdt_setprop_cell(ms->fdt, name, "interrupt-parent", irq_virtio_phandle); if (s->aia_type =3D=3D VIRT_AIA_TYPE_NONE) { --=20 2.47.2 From nobody Sat Nov 15 16:07:53 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1749005880886934.614524568381; Tue, 3 Jun 2025 19:58:00 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uMeIg-0002Ap-Ta; Tue, 03 Jun 2025 22:56:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uMeIe-00029x-Ip; Tue, 03 Jun 2025 22:56:20 -0400 Received: from mail-pl1-x62d.google.com ([2607:f8b0:4864:20::62d]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uMeId-0000Px-6D; Tue, 03 Jun 2025 22:56:20 -0400 Received: by mail-pl1-x62d.google.com with SMTP id d9443c01a7336-23228b9d684so67468255ad.1; Tue, 03 Jun 2025 19:56:18 -0700 (PDT) Received: from donnager-debian.. ([45.124.203.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-23506d21818sm94457555ad.254.2025.06.03.19.56.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Jun 2025 19:56:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1749005777; x=1749610577; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:from:to:cc:subject:date :message-id:reply-to; bh=X0AiQvQjk6NtB61sWMHYFKwjwNvToRms+mkQ+N4dhTg=; b=jxL9eZgU0EjKrHNHijYOlAqgmKW0zBtwYruMQTMTjxocLlQ7pyzFpG0roQt5mTRLrw izCYvsCjzudZBlbiUiXih1bgQi3dNX3k3/fiNpoClY45q7jSDBaRgy75Cd4UJnhQMO9z HF3VmBnR09KDSQ7udw3FYxsTBkJPmci6xpnJq+pHwZqQ6gubBXwqqy0/+wfee4PNvdD1 R9/oHruCz0vs6jJoOJwbhiIUrrAT3y+lpSHOd5+DrjauJjsiv3zLue8wTFV1IONvY5ga TGaMPqBb9NqxTm/8OPkrV5NSSmNEyqFWVCCI/xZL9WNgWoegyIFxaDCBrGEkNCp8NObD Sw/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749005777; x=1749610577; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=X0AiQvQjk6NtB61sWMHYFKwjwNvToRms+mkQ+N4dhTg=; b=hLGuSAfcCatqF9P6CQvp9ZaZlcFIEKRXHOow78K+ggSfdgZeleY225jQeOR2y1+/qu c+pmSts2Tbjy9UDgIsjYxCTJoEyeyFq+YBrjXzeFdWXtpfV3hXU1tsuc0EA2VhkN/mPm feQLLxSMDd7wjwZ3wtBHj+bQ+lEIZWkPEtamnH3DG0uzV9RZgSleQ5+O+4DQK6KQroiC vFVqNjTJbc/xdKTcdsg+3QcjxBeoRmuswoGtlnapGRR+UP41tWrln+tcJLhDlNWYfkyN x8Y+LQOw2BehLwYUycmk9l9BCoKR/U/mgDERmmMkzaeOUA7oZ1ThKe9B+JCCG5V4Zy9n gAxA== X-Forwarded-Encrypted: i=1; AJvYcCVnzCggkaHefQsF6cEtEAv9/BL5CK3CmyOhzELvuEfYW7K8F/U5SpiQNm3DrQkCCXlI6kqJWyjExmRx@nongnu.org X-Gm-Message-State: AOJu0Ywk7Q9r4KJHCPCZVrCd4LZ0L3IX2NUKvtvFlS/PRongpfZT8EyG zYVBKzue7sAw9CAQEkTfSdqZPl/G6VfMXWh+rIDkWUyAQYt5E9J22HmG X-Gm-Gg: ASbGnct7wdmcB+lK2DX7BGs/EGo3Ks8rJWpznxwmQtiEKsfkySNnM+Eam8qxwMiJNGp aMEv7JFNKfBnSsIdEZ8KdkPdFli35apA33TpTKQQtOjeW2bIaorkMsy037uaIKsauh7sfsD5Iyr +1Gsxc/xoMKqj+YdRe3O3fRTogOqCgTiDrErhuksgFD1rv2ePCs6S0hYLcq/eMN0Y/zWdnjyNme 9VqYxkkoVZM5klYUNKy/BUhBq9Fd5qvEcCZok1jMqXTOv1f8pI88QuXzmjPn1p/cad7QQ2H7DIQ h/1ml/hvKBmfhjq94j2dp+ORX4714hbZEg8oTEsxS6qDCe3Op6BirMYvafN7QQ== X-Google-Smtp-Source: AGHT+IFNYdzFhsGKQPt/a3jc4vaH2cKMfikVRHrO3Drs04si8+HkPuRQ5VkakR0VtYnYx3OBWHmv6Q== X-Received: by 2002:a17:903:1245:b0:234:8ec1:4aec with SMTP id d9443c01a7336-235e1126f3dmr12473215ad.6.1749005777310; Tue, 03 Jun 2025 19:56:17 -0700 (PDT) From: Joel Stanley To: Alistair Francis , Daniel Henrique Barboza Cc: qemu-riscv@nongnu.org, qemu-devel@nongnu.org Subject: [PATCH v2 08/12] hw/riscv/virt: Use setprop_sized_cells for reset Date: Wed, 4 Jun 2025 12:24:44 +0930 Message-ID: <20250604025450.85327-9-joel@jms.id.au> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250604025450.85327-1-joel@jms.id.au> References: <20250604025450.85327-1-joel@jms.id.au> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::62d; envelope-from=joel.stan@gmail.com; helo=mail-pl1-x62d.google.com X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.001, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1749005882505116600 Content-Type: text/plain; charset="utf-8" The current device tree property uses two cells for the address (and for the size), but assumes the they are less than 32 bits by hard coding the high cell to zero. Use qemu_fdt_setprop_sized_cells to do the job of splitting the upper and lower 32 bits across cells. Reviewed-by: Daniel Henrique Barboza Reviewed-by: Alistair Francis Signed-off-by: Joel Stanley --- hw/riscv/virt.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/riscv/virt.c b/hw/riscv/virt.c index 851c7cc82ad5..b59f10dabe19 100644 --- a/hw/riscv/virt.c +++ b/hw/riscv/virt.c @@ -932,8 +932,9 @@ static void create_fdt_reset(RISCVVirtState *s, uint32_= t *phandle) qemu_fdt_setprop_string_array(ms->fdt, name, "compatible", (char **)&compat, ARRAY_SIZE(compat)= ); } - qemu_fdt_setprop_cells(ms->fdt, name, "reg", - 0x0, s->memmap[VIRT_TEST].base, 0x0, s->memmap[VIRT_TEST].size); + qemu_fdt_setprop_sized_cells(ms->fdt, name, "reg", + 2, s->memmap[VIRT_TEST].base, + 2, s->memmap[VIRT_TEST].size); qemu_fdt_setprop_cell(ms->fdt, name, "phandle", test_phandle); test_phandle =3D qemu_fdt_get_phandle(ms->fdt, name); g_free(name); --=20 2.47.2 From nobody Sat Nov 15 16:07:53 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1749005815567417.2123467739418; Tue, 3 Jun 2025 19:56:55 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uMeIj-0002Bl-Gz; Tue, 03 Jun 2025 22:56:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uMeIh-0002Az-9r; Tue, 03 Jun 2025 22:56:23 -0400 Received: from mail-pg1-x529.google.com ([2607:f8b0:4864:20::529]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uMeIf-0000QE-QV; Tue, 03 Jun 2025 22:56:23 -0400 Received: by mail-pg1-x529.google.com with SMTP id 41be03b00d2f7-b1396171fb1so3434086a12.2; Tue, 03 Jun 2025 19:56:21 -0700 (PDT) Received: from donnager-debian.. ([45.124.203.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-23506d21818sm94457555ad.254.2025.06.03.19.56.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Jun 2025 19:56:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1749005780; x=1749610580; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:from:to:cc:subject:date :message-id:reply-to; bh=haOAiWr51e6r2Yb+LqRCwcRTvswrSE/JCNkLUe12L38=; b=gspWr2GpsTNmZU83O1UyBEbsfuOkaKbdJFHO8c9eazvJmB0Y8j82rOiEsEVIdyqEz7 tlgDcm1q6k+3dtGW3UI+JrM6iSW616t8AktjM0SLrzsKjqIGk5BQAAIYTjR8CRKIApJr MooO/KEaAuM4W8LyFWpdrcE3t6wG6P7A8ELHnKgDYHr6sLMwX3pmgwx1RupU6bwV/XzT cK+2TQqxyMgOrIZneMycvt9zvH4HIzDesU7IN1XltOVwiaZqDEmf0wWPtZ4iue1VOjPW 2cLRXXIZ44sfZCKgzVT8VxOkir+wW9JOUDy6MrZzgtBQnsJTRfY/NBHeBO7fGZcbaSRK +Vlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749005780; x=1749610580; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=haOAiWr51e6r2Yb+LqRCwcRTvswrSE/JCNkLUe12L38=; b=FcehChEzDjbG8bG6Zk4pCTbE/Hecjc+DYquHC0Jjdb0qBcDt1WJwrhEzrG+GlhwFdr Zy3mxYgkdPh1/t+07NY5/oPLzriH1ZB3ggCYDdsS+F9SvpLo8QeD6XDsopbTn0HHWnEo 4JUdKspBN9O4dUF+HjI62dr70E8+AVu9Y8tT+A3qPQk27qyJoXEvkcd9RnDq8xZqKHPF vPMdFcnRUWCOYhRnCCpFJFqjyvgwfNNweTcUrZaAABUzFYM/LGlnpDz3K4qIf+xWgH3u bMK2Qbcw6CfwvxcB8vEr38gV7woqklLZHpzJg2WBzEpJ2Zd47YeXlqKUYgyWOUMDoR2f ocDQ== X-Forwarded-Encrypted: i=1; AJvYcCX63T65bU7grf5dti6GwdBiXwAbXiDxZqaVQ8WkUUiWI0rAkX5zs+N267/Zt7IMQhT2VZ6suh3/AxjB@nongnu.org X-Gm-Message-State: AOJu0YxBCXUESTpqzxIDu1ST37Ft4Eln/Hli+9ke211jpaG3apV3NZVC +I2cEX5BD/q8W6behp2+wa2cbhCRyDDs6n5/mgBNrhKy+m1FD1vDuFrw X-Gm-Gg: ASbGnctcNYwerZflT6nfJaIU32TmUjA6B90DLaYHSGWBS5uqdAl8/OgmQl7V8ODymon 3N5jBaUcWUzHX5r+yXPqkXL+eCzaFJpOcTCb0+lQLIkaiWoUfYWMIjbo9ti5ubNc7Zlaq3YOMgB gsAGHPNVtmVQsBNYGHrCBU8AWLZ9bLf0HevmgI/Y+fY+C7umfqfzQk2fzSGCICaJcj1bcPJIq/d IAJw9LsJ6oM7KjRmdUZkyQOXnxojFPZkQ29yza8TU98y3IxsFqXGfwdfvMAt2wznFGcfLZ8KECC 20jrS0Oe75hvCM31zu3UQWlZ11LTfsrCl/ddGqlHS3h+VVWSQm2UYPOxINrRow== X-Google-Smtp-Source: AGHT+IGNqF7KYywxERt/8FSIQkRQIKseB6Ofo9DigC3InAnKqXEo53jvvDL/A7VKxfi3DCCvza+teQ== X-Received: by 2002:a17:903:2452:b0:232:202e:ab18 with SMTP id d9443c01a7336-235e11c7f69mr14880645ad.26.1749005780086; Tue, 03 Jun 2025 19:56:20 -0700 (PDT) From: Joel Stanley To: Alistair Francis , Daniel Henrique Barboza Cc: qemu-riscv@nongnu.org, qemu-devel@nongnu.org Subject: [PATCH v2 09/12] hw/riscv/virt: Use setprop_sized_cells for uart Date: Wed, 4 Jun 2025 12:24:45 +0930 Message-ID: <20250604025450.85327-10-joel@jms.id.au> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250604025450.85327-1-joel@jms.id.au> References: <20250604025450.85327-1-joel@jms.id.au> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::529; envelope-from=joel.stan@gmail.com; helo=mail-pg1-x529.google.com X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.001, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1749005817451116600 Content-Type: text/plain; charset="utf-8" The current device tree property uses two cells for the address (and for the size), but assumes the they are less than 32 bits by hard coding the high cell to zero. Use qemu_fdt_setprop_sized_cells to do the job of splitting the upper and lower 32 bits across cells. Reviewed-by: Daniel Henrique Barboza Reviewed-by: Alistair Francis Signed-off-by: Joel Stanley --- hw/riscv/virt.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/riscv/virt.c b/hw/riscv/virt.c index b59f10dabe19..7c38a9048044 100644 --- a/hw/riscv/virt.c +++ b/hw/riscv/virt.c @@ -966,9 +966,9 @@ static void create_fdt_uart(RISCVVirtState *s, s->memmap[VIRT_UART0].base); qemu_fdt_add_subnode(ms->fdt, name); qemu_fdt_setprop_string(ms->fdt, name, "compatible", "ns16550a"); - qemu_fdt_setprop_cells(ms->fdt, name, "reg", - 0x0, s->memmap[VIRT_UART0].base, - 0x0, s->memmap[VIRT_UART0].size); + qemu_fdt_setprop_sized_cells(ms->fdt, name, "reg", + 2, s->memmap[VIRT_UART0].base, + 2, s->memmap[VIRT_UART0].size); qemu_fdt_setprop_cell(ms->fdt, name, "clock-frequency", 3686400); qemu_fdt_setprop_cell(ms->fdt, name, "interrupt-parent", irq_mmio_phan= dle); if (s->aia_type =3D=3D VIRT_AIA_TYPE_NONE) { --=20 2.47.2 From nobody Sat Nov 15 16:07:53 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1749005834085667.3382161945888; Tue, 3 Jun 2025 19:57:14 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uMeIl-0002CW-U5; Tue, 03 Jun 2025 22:56:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uMeIj-0002Bm-Tk; Tue, 03 Jun 2025 22:56:25 -0400 Received: from mail-pl1-x62e.google.com ([2607:f8b0:4864:20::62e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uMeIi-0000Qg-Er; Tue, 03 Jun 2025 22:56:25 -0400 Received: by mail-pl1-x62e.google.com with SMTP id d9443c01a7336-234ade5a819so56348575ad.1; Tue, 03 Jun 2025 19:56:23 -0700 (PDT) Received: from donnager-debian.. ([45.124.203.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-23506d21818sm94457555ad.254.2025.06.03.19.56.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Jun 2025 19:56:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1749005783; x=1749610583; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:from:to:cc:subject:date :message-id:reply-to; bh=lkqK6XnqHK1/oK/4bd2jOxngmEcZko8Z16pkYXUDEX4=; b=NRahlBGC5n6K028/2Ni1XtasaPolx0KBkxnemScCRdr/3/dFScHesDxW4UWUvkWT/o 3aZJmOvs/D94EHTf/flBSQjuWwxoscpdwWi6JAdlsdOIYMDlepMuaU+uT1qsYJdhNZIP J/GAyAIXlHqqck9QAxuTrl2kMM5I5dWLEL2Yel8CrSaWRB+saJF0uXE6DjNTImj20CYx gcDxIKwbsWOKpGctiQ219R8Yu6prGsu6dGmdqgjuZKeGTWvJdQPBD0/ItyIOosfFn5Pc RYIVjhnv07KbMrck0hft4vDNRc4NJtMAHcIOJxxXSagOoVV069YQ1g1ggopvLUSHILT6 xCHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749005783; x=1749610583; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=lkqK6XnqHK1/oK/4bd2jOxngmEcZko8Z16pkYXUDEX4=; b=pl1Bcf/WbnFw9aPSFtDM9FYf6HzL7Od3xjxc/Y0hvLFZRknwbM6ecY0WaCI0oX7ePA V6b3h+5pWDGBfbRjkbhsN8FTvjVqYZwNvAVLMwgCSKOgHGktxiXbwzTZfBYIkFVlYbqL 8L5gADtB+ZF/y+hPKVTXj/DyFPoxmFd6oZGyyYclCtZBg5j67nK2Kcigp5oW3ahGf4Oc pnURQPwEEGuY+KL+brNPf7NPi3u/N93ziXRLddiXU4YfvKvC2fdONNB9HFdMDBTHmCqj Lv+DHmVll4/YGhRGIyoHLBTu58gzhi+0SVqUGn1kKiIrmT6WOWm1+wtBfWY25kgUoQky gAFA== X-Forwarded-Encrypted: i=1; AJvYcCUNkbyxw/q+xUyq0qbp0GygRjmxT+JVj/bXK820IXyO1EpPULVtHrgO/0JuvlaDwwni7bFkhKCXj9e2@nongnu.org X-Gm-Message-State: AOJu0YwBK585q4aiQnlnt4lUQVZO/xuEfxQRszV7OInewnFUzJHk4F/X dc8xu1TiitK01aMg2DxeCUKX4VlPocUj7RO+iEQfYB9/DknkPQTcWOTfT0/pmTOn X-Gm-Gg: ASbGncvT0wO4HDCQ5EpjjWRz7CYxvCh+cc7XbFEx9MGbb62J8E4+qEbqoRXnf5GAhHM d7oJXo0MxYna1S+8FZhL22tG9Bf7eZSkxgOgMjVKQyuc+jhYGwXSIeQmTJNnL+eqEM9jYoQjJJh pdJi/VjGB/hAtRtJHAxZhJxxJfxkZJW94zsHv1taDrhhxXsa51rQvjejuCEi6tIndGDFuN2meIA 4w2FGp8yMElU1IanwNqldV24OBnG2IOkjUx89B2+ErEELnY6GLn7ol1TF4GcSrptnj5JPQCr+K9 nVIh3g1eURzGNfs+LzgBIezyXjmHLOwd+cZoVV/gRD/BGgqNntuQDGoJWeTqQgnhXHv4hHJU X-Google-Smtp-Source: AGHT+IEyjBG5cmJRW3tH8JMmScQa1bFr8eJr2Ta1PS24F5uounN7kkPn92IVimIjwVCqCwucj9uYPA== X-Received: by 2002:a17:903:46c8:b0:234:d7b2:2ac4 with SMTP id d9443c01a7336-235e1126ed5mr16451125ad.17.1749005782879; Tue, 03 Jun 2025 19:56:22 -0700 (PDT) From: Joel Stanley To: Alistair Francis , Daniel Henrique Barboza Cc: qemu-riscv@nongnu.org, qemu-devel@nongnu.org Subject: [PATCH v2 10/12] hw/riscv/virt: Use setprop_sized_cells for rtc Date: Wed, 4 Jun 2025 12:24:46 +0930 Message-ID: <20250604025450.85327-11-joel@jms.id.au> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250604025450.85327-1-joel@jms.id.au> References: <20250604025450.85327-1-joel@jms.id.au> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::62e; envelope-from=joel.stan@gmail.com; helo=mail-pl1-x62e.google.com X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.001, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1749005835638116600 Content-Type: text/plain; charset="utf-8" The current device tree property uses two cells for the address (and for the size), but assumes the they are less than 32 bits by hard coding the high cell to zero. Use qemu_fdt_setprop_sized_cells to do the job of splitting the upper and lower 32 bits across cells. Reviewed-by: Daniel Henrique Barboza Reviewed-by: Alistair Francis Signed-off-by: Joel Stanley --- hw/riscv/virt.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/riscv/virt.c b/hw/riscv/virt.c index 7c38a9048044..4fa2bad24804 100644 --- a/hw/riscv/virt.c +++ b/hw/riscv/virt.c @@ -992,8 +992,9 @@ static void create_fdt_rtc(RISCVVirtState *s, qemu_fdt_add_subnode(ms->fdt, name); qemu_fdt_setprop_string(ms->fdt, name, "compatible", "google,goldfish-rtc"); - qemu_fdt_setprop_cells(ms->fdt, name, "reg", - 0x0, s->memmap[VIRT_RTC].base, 0x0, s->memmap[VIRT_RTC].size); + qemu_fdt_setprop_sized_cells(ms->fdt, name, "reg", + 2, s->memmap[VIRT_RTC].base, + 2, s->memmap[VIRT_RTC].size); qemu_fdt_setprop_cell(ms->fdt, name, "interrupt-parent", irq_mmio_phandle); if (s->aia_type =3D=3D VIRT_AIA_TYPE_NONE) { --=20 2.47.2 From nobody Sat Nov 15 16:07:53 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1749005814177454.4157330921904; Tue, 3 Jun 2025 19:56:54 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uMeIp-0002DZ-Hh; Tue, 03 Jun 2025 22:56:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uMeIm-0002Cp-Sk; Tue, 03 Jun 2025 22:56:28 -0400 Received: from mail-pl1-x636.google.com ([2607:f8b0:4864:20::636]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uMeIl-0000Qv-Ei; Tue, 03 Jun 2025 22:56:28 -0400 Received: by mail-pl1-x636.google.com with SMTP id d9443c01a7336-2351227b098so44027535ad.2; Tue, 03 Jun 2025 19:56:26 -0700 (PDT) Received: from donnager-debian.. ([45.124.203.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-23506d21818sm94457555ad.254.2025.06.03.19.56.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Jun 2025 19:56:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1749005785; x=1749610585; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:from:to:cc:subject:date :message-id:reply-to; bh=mZb1PN7GT5tBM4E+RD0BlKVebwzNtkntVesD3GuzMrw=; b=U4+2PdQEXfSGF251F/ngzwTr7tXpYxV9CkczzN3hTOIzSZ2eM5tGx3SeBix6zFj3zj /uFzvc1v2WYfOOkCNQVhezxHJRpsvzbcMdEF7MCcbczNuoSpcLm4kNLE67Zf5ITSsep2 eiJM5GWIYckP8rKIKWyxvM7cU5y1Xx0jKhoxVNExwW66SgLwtgP80KF9xP9+KK4j8JEU BTzpXzLzK7GH1Xv5r+DT+6JJZrhZQfwapvWHs+PAKseKE5OSxmBQ9t0p6WsxS4lljK69 KjpPVF8RLpv3DElh3/EQY68y0R72aV7AhGeWUfK9ZyyjWTGMiLWbLMENRCfCP0vuI3uP uVVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749005785; x=1749610585; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=mZb1PN7GT5tBM4E+RD0BlKVebwzNtkntVesD3GuzMrw=; b=np8ZTgv/nmjd0pebpRaXSHTGIUP/MFkZ2fU6GOw0i+8v4ueNFSO1tWNcvmWHyn/qci yOpvJ4kx/3oqmQXegqfTFsgYKBdk59PYh8UNTJl7uX8u90RZNO18r2JlrCsf1dh60i3H rA7f/+0AzyZeLNeoO+6N5Zw4eWI+EFUE5ZLF/F1ET5gHSHTyHamSFR8Qb6Vv4uKmyfpF F4Jv8WH4yDguU37fCK30lnfBIeBZzq3y/K4hV6bf1wyJQpx5Obb5GTVvDQYqSXSCXCMa E0W2VstTTzXQereZackYy9IU9c5pc2bin4lpu2oRHPH1aEvBVwcCSfImLDSuDtkS7Zms EQog== X-Forwarded-Encrypted: i=1; AJvYcCUZlxJJBu9rrpM/GDliWPrxKukgGWpy7l1nAnvaWv6V6jKG5u9Q0yaxhMd+QUMbj6ACUgNKt0+CHMCS@nongnu.org X-Gm-Message-State: AOJu0Yy984YRyy6W12nHEuZLg6LB3PrFLJ696J0LM4Z8bD3uTh77V9I/ RTLD2gmTxQxeMfFYsA4bL9gGfwfmC7wZ+FGLPDgb9xZUXhRcM3V58DnpWbjSGB65 X-Gm-Gg: ASbGncszsRNxphIFDvjq66YdhxLCLcPoxX7UGDKK8pWN65izCyRiKgDOyJp+nxScxeg VHmsbA+tmR7pftBdug+jfFNtETxvH1yD4Kc7LuvUYKIFxxHlFBGKxfkA2MyR5swbsD9TaVGxGNd d05gjIKfE8/o3FHutcx+rzCH13KkIZ9OKuvylvG/eDBVwewJCnvwpjcZZd1XUtCCdZmOVqzsJBE 5xdZhVBZh4rzG8h8rP1DAXyMaabshPH6I8u5I2j2J97lc31q6RFpv7NnbKyAfqJDIU9zvW16cow kv9tei/9xlIkOK876LZk0GG686c5tBQqRK631F1/QhDUaZ+5vILg4lOyvG7x4w== X-Google-Smtp-Source: AGHT+IFcTlOVQJh7u63++qJTY0fw1RSrBjukHzN+g9JLGVr5lwCWAcoXBe6/sLLtYo52bBJlJxsRZA== X-Received: by 2002:a17:903:228a:b0:220:df73:b639 with SMTP id d9443c01a7336-235e11e74d0mr16848525ad.36.1749005785662; Tue, 03 Jun 2025 19:56:25 -0700 (PDT) From: Joel Stanley To: Alistair Francis , Daniel Henrique Barboza Cc: qemu-riscv@nongnu.org, qemu-devel@nongnu.org Subject: [PATCH v2 11/12] hw/riscv/virt: Use setprop_sized_cells for iommu Date: Wed, 4 Jun 2025 12:24:47 +0930 Message-ID: <20250604025450.85327-12-joel@jms.id.au> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250604025450.85327-1-joel@jms.id.au> References: <20250604025450.85327-1-joel@jms.id.au> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::636; envelope-from=joel.stan@gmail.com; helo=mail-pl1-x636.google.com X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.001, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1749005816264116600 Content-Type: text/plain; charset="utf-8" The current device tree property uses two cells for the address (and for the size), but assumes the they are less than 32 bits by hard coding the high cell to zero. Use qemu_fdt_setprop_sized_cells to do the job of splitting the upper and lower 32 bits across cells. Reviewed-by: Daniel Henrique Barboza Reviewed-by: Alistair Francis Signed-off-by: Joel Stanley --- hw/riscv/virt.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/hw/riscv/virt.c b/hw/riscv/virt.c index 4fa2bad24804..67490c5c693a 100644 --- a/hw/riscv/virt.c +++ b/hw/riscv/virt.c @@ -1088,8 +1088,7 @@ static void create_fdt_iommu_sys(RISCVVirtState *s, u= int32_t irq_chip, qemu_fdt_setprop_cell(fdt, iommu_node, "#iommu-cells", 1); qemu_fdt_setprop_cell(fdt, iommu_node, "phandle", iommu_phandle); =20 - qemu_fdt_setprop_cells(fdt, iommu_node, "reg", - addr >> 32, addr, size >> 32, size); + qemu_fdt_setprop_sized_cells(fdt, iommu_node, "reg", 2, addr, 2, size); qemu_fdt_setprop_cell(fdt, iommu_node, "interrupt-parent", irq_chip); =20 qemu_fdt_setprop_cells(fdt, iommu_node, "interrupts", --=20 2.47.2 From nobody Sat Nov 15 16:07:53 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1749005898512514.1677386870334; Tue, 3 Jun 2025 19:58:18 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uMeIt-0002Ee-Au; Tue, 03 Jun 2025 22:56:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uMeIp-0002Da-Kp; Tue, 03 Jun 2025 22:56:31 -0400 Received: from mail-pl1-x62b.google.com ([2607:f8b0:4864:20::62b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uMeIo-0000RH-7K; Tue, 03 Jun 2025 22:56:31 -0400 Received: by mail-pl1-x62b.google.com with SMTP id d9443c01a7336-2320d06b728so54526615ad.1; Tue, 03 Jun 2025 19:56:29 -0700 (PDT) Received: from donnager-debian.. ([45.124.203.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-23506d21818sm94457555ad.254.2025.06.03.19.56.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Jun 2025 19:56:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1749005788; x=1749610588; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:from:to:cc:subject:date :message-id:reply-to; bh=0cPu0mtekVksYgzSb8SFLIZhjgTCV3V/MOS6qVJu54E=; b=lsNyAYN/zH0nEdXLqJnBq4LGQfEcUj84Ks7nSps9uLlTw0JywAOzSlx2Q5PbPR3HPM i1x2zarfBHylaDdpOwgDhL55p/1RpmqW6wfscpLpcHpXQWfFVTME4WhHs1x6Cgc0m1mH vDK7iseiuQcwdUwS8bEQhKYdDzBrBDvm8/WsEpy30nk9RhV2lgxJKQtlOSG9wKnIy4Oy 8BT8HfdpQT5Nl4Igs+eSm3gPvl0o+pNa6ueFft+kzMtnVary/yqXtEw4BCy0qF+YVAYN IdT2Ln9dTV22+l5mw9ppYv3N3wRUmskHBaBg8YvzxeKODYn0fiIb0jcrkdx1gNbMG3j8 bqDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749005788; x=1749610588; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=0cPu0mtekVksYgzSb8SFLIZhjgTCV3V/MOS6qVJu54E=; b=BSveQVg8lYg7s1P2f+VdifwDsVCRfC/igjXDj8kcu7NFYjEkWeLYTAJ7dDx4f54/CC 0n5RKWL6hHaIWSp5CpzjTrCdeLRzA4FRtYLuoPsJcL3GwOnnrKpLq3lCB53R/AKa8gmC cNU+9SMfX6NJOc6wHGlhNmnU5nybEZk7TGMDeopARpwFDYrBETFrAHNVwZECA700junx S6SlTIZXB7mxt6+zBRLvfFez+yDfFYGuxpjrBeIMEngJSQoFGBSYmlrW18iQ++YDek0u tf3XYbSqlEdTi9hRPRNS4u65Gzi0n7lamTleZSTXQi+oyxoaINhQ/LsDqHZ4Ron9T/eU CIYg== X-Forwarded-Encrypted: i=1; AJvYcCWCbeZ+CB5GqjOAJ0N7QQz43TvBEoqcr6RyFDZVHhZ1i5xj0r7reELfWvnBWJ6h4eWSi4iOZxoHJdQ+@nongnu.org X-Gm-Message-State: AOJu0Yz7ijRJEuNWsYohrRv6fIYp4xYpnfsJvDvem/0LYC5yz0VxsW7G XEdOaFyaBfPyjNATvDifgNa0+42CjRRn1rEqUfNAHRBofhfPJVlkaQiO X-Gm-Gg: ASbGnctM67WiHzNtV6kjt9RGyT6pkcR9Id9qdyJotiqMxwKXjRErPVmxBiZajQ5ftqh SdWyIygvTGIh4TIjMuUoNnMTsD9A2SYePtDpjzzfPCQq8m06B/3xu01mfWd5MMry0kI9k1BbSGf 40pDPfUzlDJHyZx8iT9XPeUeNw3Iq9XowvxqOJTjPaqja+Qql6jJybzKABfTRTrBb+slwcuZMh+ LPfh9RWSSHzt1iWZ2YrOIFJdBNQ0pQI3dIq4xnPnNDlR3pvgcVdtRr997gVt+FYFndcoEo1afmM WtF6Byw1/I92TJfGh7Jf4We0/fKEZ/ktP57ae0pFYWQQDzY4FhIf/lyqQZvvjA== X-Google-Smtp-Source: AGHT+IFeRKR9b4x6GfqerkCJAcpkL1KCHjA7eI4OKRbTA6JHoEDzsyqprKBKr2pQIR6LQXejZnVN5A== X-Received: by 2002:a17:902:ccd2:b0:22e:4db0:6b2 with SMTP id d9443c01a7336-235e1485adfmr15698805ad.9.1749005788386; Tue, 03 Jun 2025 19:56:28 -0700 (PDT) From: Joel Stanley To: Alistair Francis , Daniel Henrique Barboza Cc: qemu-riscv@nongnu.org, qemu-devel@nongnu.org Subject: [PATCH v2 12/12] hw/riscv/virt: Use setprop_sized_cells for pcie Date: Wed, 4 Jun 2025 12:24:48 +0930 Message-ID: <20250604025450.85327-13-joel@jms.id.au> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250604025450.85327-1-joel@jms.id.au> References: <20250604025450.85327-1-joel@jms.id.au> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::62b; envelope-from=joel.stan@gmail.com; helo=mail-pl1-x62b.google.com X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.001, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: fail (Header signature does not verify) X-ZM-MESSAGEID: 1749005900415116600 Content-Type: text/plain; charset="utf-8" The current device tree property uses two cells for the address (and for the size), but assumes the they are less than 32 bits by hard coding the high cell to zero. Use qemu_fdt_setprop_sized_cells to do the job of splitting the upper and lower 32 bits across cells. Reviewed-by: Daniel Henrique Barboza Reviewed-by: Alistair Francis Signed-off-by: Joel Stanley --- hw/riscv/virt.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/riscv/virt.c b/hw/riscv/virt.c index 67490c5c693a..47e573f85ab1 100644 --- a/hw/riscv/virt.c +++ b/hw/riscv/virt.c @@ -894,8 +894,8 @@ static void create_fdt_pcie(RISCVVirtState *s, if (s->aia_type =3D=3D VIRT_AIA_TYPE_APLIC_IMSIC) { qemu_fdt_setprop_cell(ms->fdt, name, "msi-parent", msi_pcie_phandl= e); } - qemu_fdt_setprop_cells(ms->fdt, name, "reg", 0, - s->memmap[VIRT_PCIE_ECAM].base, 0, s->memmap[VIRT_PCIE_ECAM].size); + qemu_fdt_setprop_sized_cells(ms->fdt, name, "reg", 2, + s->memmap[VIRT_PCIE_ECAM].base, 2, s->memmap[VIRT_PCIE_ECAM].size); qemu_fdt_setprop_sized_cells(ms->fdt, name, "ranges", 1, FDT_PCI_RANGE_IOPORT, 2, 0, 2, s->memmap[VIRT_PCIE_PIO].base, 2, s->memmap[VIRT_PCIE_PIO].size, --=20 2.47.2