From nobody Sat Nov 15 17:18:51 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1748938219; cv=none; d=zohomail.com; s=zohoarc; b=KaxYMRf0iikOvk5CIh5wvh8L4qM0cKwhFMhfOciZZ07wz8Rb8ONVyJwOYh/xkAdflUX66LJX5nigRhTMPVCcVBYRux1F156kK92HhJIw9u31FyoWCQyE/PLVcyNyoohgoMsiVC+qBVQut5/4SlRSqBQl35WjOiAo+G2+IvjYLvk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1748938219; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=ERsN3wV+fcXb2xmdBpByK0N2LC/9kgwvDEhvl3/V1A0=; b=mvHf345QXpANhPzHbbUQ4nTIvLdRWPw6IolN0/GfXR2/7gDAGsLkm3j1lL8wUSr7yiIJekxKUjvVS85UqWaK+ulvjsg6OTrOtU3YWvniXyxJuBPZJhmpP71RtT7f0kKJLw0M/XbmzvZXX3ylJmbaGlGTR/xJf+cJxkHD+ruN2aA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1748938219247935.6742887703994; Tue, 3 Jun 2025 01:10:19 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uMMiZ-0000r7-EA; Tue, 03 Jun 2025 04:09:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uMMiX-0000qf-Lg for qemu-devel@nongnu.org; Tue, 03 Jun 2025 04:09:53 -0400 Received: from mail-wr1-x434.google.com ([2a00:1450:4864:20::434]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uMMiW-0005Tw-3p for qemu-devel@nongnu.org; Tue, 03 Jun 2025 04:09:53 -0400 Received: by mail-wr1-x434.google.com with SMTP id ffacd0b85a97d-3a36e090102so3022160f8f.2 for ; Tue, 03 Jun 2025 01:09:51 -0700 (PDT) Received: from stoup.lan (host-80-41-64-133.as13285.net. [80.41.64.133]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3a4f009ff7asm17668852f8f.90.2025.06.03.01.09.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Jun 2025 01:09:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1748938190; x=1749542990; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ERsN3wV+fcXb2xmdBpByK0N2LC/9kgwvDEhvl3/V1A0=; b=GXn1HlOO8y5GQOwY9wRq5g5bPy6dMZbagP3YoL3WT6iueJ0Ph4v34LUPX6FXl/6y7e pnJBcJxYtTTUxIk8Mrl/1AimfPAXD9JADfeByR3VLGTel2/Q39oKkLEfaMa9Wk0lJQ/8 FGY0StIYngdq1xZC3Rs1xoo5gqkf0BGpgwlHObmsoR/+vzJeOnhU7jbVIhMoT2CP+Z52 ZlFsqGwLYe/hpOgcyIIJ3+l7JqRlVcTLr/m6FP/C59sKL2+dmGyl9Phlgwj8RNzJZFaX VIh3szbzqZEDljsg/Xaka6OQtswV03JllJWEdR+zO9oMEXtgYV+vObO65W1GVaq9jcAm gKew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748938190; x=1749542990; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ERsN3wV+fcXb2xmdBpByK0N2LC/9kgwvDEhvl3/V1A0=; b=E5O1wjVsl8BRISvBZi8GbcmQSfezZZQClLDokAXAnYLpYvWdyDiEAibr2vHx2KO9t3 kvIRfaW7jaeABZBxLQYE5RZDYz2GbrWc6FlTSuYZwuG34xoYOnjxNJtjOlFv9cwCSKkI JqC38lvFfDmU9ujZJ0gt8puZGIaakl4D0GD42bpcGB1XFdehSftL6yWdGIQy7pgRZ0XZ fvDdXLkw0Y6dePJH5IWfNCO4Fe8mHBDjAz9yzz7oKAfTA1dl9hAwZIr56KeInQm9pVjI lmO7NVOssiGYum1zOm/8/Wz0ZpUFAOPYozwEqW6QCygOC5iNN4UwEZQwRflTckXjFAZ6 Cthw== X-Gm-Message-State: AOJu0YxNTM1E3d+CsijzXL4lU5kqxkRIeN3ZOHpEGhSDeZwZJRyVblZi ygQ5iI6NP8tZ0EhZh5rohxFmOafZNpgAef0oJ8Jgma6OBMbNqzxQ6amFQbcrQbqv/ZcQ+/EVjZB yLEqgi0k= X-Gm-Gg: ASbGnctJfvyR+UCmdepNA2djA2QuJi4BEWxSx54C+Xcp5CyUAbJ5YBCS0dilqWn7R3r fu6T0wjuEAKeus/p03s2aKWiznO+VSBnX4TfrPJBSMxu+JA6arUuD/TB1lzkCAhZa4tWNqLKvta u1j3z1diuSrKZvo6HLx1r2CDnAKDSUxUz/p6/iqOJ/FXL2yGbbSUw61+hhpqRSu6D2JRTsvcgm5 ZnmUGcWh/kLk2H9SS5FdFvqX1/sKwtPgDv+2n+PjisPhJ+q9yZHRBK559FNhK0Y7pSf2fyUBmmd cO10bVofXyqAZ2D4zHYtaxfmKRZZpMJXG983Hfsh9eKR/DAcY8B7KfzLa3whYuVNqEibrGzduE/ bh/JV1YgPJ6NB X-Google-Smtp-Source: AGHT+IFpIF9yxFdE6ckBItrApMy8/2hbNV3svvDMW8i7EEL+vk237VHLDPB+08JeW/HJKjmIv09s9Q== X-Received: by 2002:a5d:5889:0:b0:3a4:d53d:be22 with SMTP id ffacd0b85a97d-3a4f7a7dd8cmr12562304f8f.58.1748938190455; Tue, 03 Jun 2025 01:09:50 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Cc: pbonzini@redhat.com Subject: [PATCH v2 04/27] tcg/optimize: Build and use o_bits in fold_and Date: Tue, 3 Jun 2025 09:08:45 +0100 Message-ID: <20250603080908.559594-5-richard.henderson@linaro.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250603080908.559594-1-richard.henderson@linaro.org> References: <20250603080908.559594-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2a00:1450:4864:20::434; envelope-from=richard.henderson@linaro.org; helo=mail-wr1-x434.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @linaro.org) X-ZM-MESSAGEID: 1748938220704116600 Content-Type: text/plain; charset="utf-8" Signed-off-by: Richard Henderson Reviewed-by: Pierrick Bouvier --- tcg/optimize.c | 20 +++++++------------- 1 file changed, 7 insertions(+), 13 deletions(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index 49ef039932..d9ccbb36e2 100644 --- a/tcg/optimize.c +++ b/tcg/optimize.c @@ -1422,7 +1422,7 @@ static bool fold_addco(OptContext *ctx, TCGOp *op) =20 static bool fold_and(OptContext *ctx, TCGOp *op) { - uint64_t z1, z2, z_mask, s_mask; + uint64_t z_mask, o_mask, s_mask, a_mask; TempOptInfo *t1, *t2; =20 if (fold_const2_commutative(ctx, op) || @@ -1434,18 +1434,9 @@ static bool fold_and(OptContext *ctx, TCGOp *op) =20 t1 =3D arg_info(op->args[1]); t2 =3D arg_info(op->args[2]); - z1 =3D t1->z_mask; - z2 =3D t2->z_mask; =20 - /* - * Known-zeros does not imply known-ones. Therefore unless - * arg2 is constant, we can't infer affected bits from it. - */ - if (ti_is_const(t2) && fold_affected_mask(ctx, op, z1 & ~z2)) { - return true; - } - - z_mask =3D z1 & z2; + z_mask =3D t1->z_mask & t2->z_mask; + o_mask =3D t1->o_mask & t2->o_mask; =20 /* * Sign repetitions are perforce all identical, whether they are 1 or = 0. @@ -1453,7 +1444,10 @@ static bool fold_and(OptContext *ctx, TCGOp *op) */ s_mask =3D t1->s_mask & t2->s_mask; =20 - return fold_masks_zs(ctx, op, z_mask, s_mask); + /* Affected bits are those not known zero, masked by those known one. = */ + a_mask =3D t1->z_mask & ~t2->o_mask; + + return fold_masks_zosa(ctx, op, z_mask, o_mask, s_mask, a_mask); } =20 static bool fold_andc(OptContext *ctx, TCGOp *op) --=20 2.43.0