From nobody Sat Nov 15 18:46:29 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass header.i=@intel.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=intel.com ARC-Seal: i=1; a=rsa-sha256; t=1748927621; cv=none; d=zohomail.com; s=zohoarc; b=S4iFaTGW0LAENKVyHZ2ilDsHB7vhEpckj1on1ZWu6sIAT8bo2zT4Jzn/ftNxVO/MWps+8JGz9Sk3HJGpf9HFPqT3yZhf7fS0DH7uUA+frMC2iKXnWTpomWIYxDd87wg01dnU3ziWN4XmX0ap9WqB5kG5F9OXXek4n4DFQu0ejKQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1748927621; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=So78gltEXRHsL4V6HPHyWjNUQzw3Qslq5qrKkaqcrAo=; b=Dp6TdtyLnyYPewlvWpLjH/7JdtHl1YokohbOjJwZrm8QHuPUmM9JZcg4GSZ4iy+NSaUOn0Ls4k0f2tGHFIvsx93BKAMslq51gnCN6E/mI4ZyTAzh+wN2lBoiyi9zXrstzJU05bqFMQONWxNC++X9AT/+M8db2Ym9Zz5FCpbbtM0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=@intel.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1748927621707583.3334572112411; Mon, 2 Jun 2025 22:13:41 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uMJxB-0006ui-5P; Tue, 03 Jun 2025 01:12:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uMJx5-0006tT-KQ for qemu-devel@nongnu.org; Tue, 03 Jun 2025 01:12:43 -0400 Received: from mgamail.intel.com ([198.175.65.13]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uMJx3-0003ON-SD for qemu-devel@nongnu.org; Tue, 03 Jun 2025 01:12:43 -0400 Received: from orviesa002.jf.intel.com ([10.64.159.142]) by orvoesa105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jun 2025 22:09:14 -0700 Received: from lxy-clx-4s.sh.intel.com ([10.239.48.52]) by orviesa002.jf.intel.com with ESMTP; 02 Jun 2025 22:09:13 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1748927562; x=1780463562; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=aEBokaXE3lrXtpc+g4ptK8Bwk8vWkUXL1JJQu78WCfw=; b=gJtpt4IN9neEqkap1cGG2ZoPM3ksqrzD3XESH0ASTp/tWxVlli3kK2Og 2VckD3dpcfGs2rjVIN5f24EOHwX5s3kYNKzXpcFSpqnMmX6BBvT7ud9dt +o/mOcIHnzeW9BTr88ZfbQdxDsIXqkoQahGWNz5x1EaWn7543pdWyhxZY 7AWIormkAxvwObvKSj07f+DKsfD/n7VKBQAUnwcpOx5kvQhFLP5FUCG8P LWb3OA83pfIQihkHFWnP5hEFRNe5vRVKnymoHSJBKV6NwCz9DeF9MYzuY tkv90GHUZ2ejIsif5EjOZJfFMIcYKGEno++BsZk5DqxvrmGSrwIszotDC A==; X-CSE-ConnectionGUID: X4ByoYRzQV+G65EFRrUjJQ== X-CSE-MsgGUID: 7xGo6CViSyGxHkB3WwlKnQ== X-IronPort-AV: E=McAfee;i="6700,10204,11451"; a="62007533" X-IronPort-AV: E=Sophos;i="6.16,205,1744095600"; d="scan'208";a="62007533" X-CSE-ConnectionGUID: bcXopVodTeuuUmvu/P/hdA== X-CSE-MsgGUID: G1Zc+D52SH25le8L4UpbTw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,205,1744095600"; d="scan'208";a="175700651" From: Xiaoyao Li To: Paolo Bonzini Cc: Igor Mammedov , =?UTF-8?q?Daniel=20P=20=2E=20Berrang=C3=A9?= , Xiaoyao Li , qemu-devel@nongnu.org Subject: [PATCH 3/3] i386/tdx: Clarify the error message of mrconfigid/mrowner/mrownerconfig Date: Tue, 3 Jun 2025 01:03:05 -0400 Message-ID: <20250603050305.1704586-4-xiaoyao.li@intel.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250603050305.1704586-1-xiaoyao.li@intel.com> References: <20250603050305.1704586-1-xiaoyao.li@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=198.175.65.13; envelope-from=xiaoyao.li@intel.com; helo=mgamail.intel.com X-Spam_score_int: -33 X-Spam_score: -3.4 X-Spam_bar: --- X-Spam_report: (-3.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.015, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HK_RANDOM_ENVFROM=0.001, HK_RANDOM_FROM=0.999, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @intel.com) X-ZM-MESSAGEID: 1748927623823116600 The error message is misleading - we successfully decoded the data, the decoded data was simply with the wrong length. Change the error message to show it is an length check failure with both the received and expected values. Suggested-by: Daniel P. Berrang=C3=A9 Signed-off-by: Xiaoyao Li Reviewed-by: Daniel P. Berrang=C3=A9 Reviewed-by: Igor Mammedov --- Suggested by Daniel at https://lore.kernel.org/qemu-devel/aBzT3TrdldaN-uqx@= redhat.com/ --- target/i386/kvm/tdx.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/target/i386/kvm/tdx.c b/target/i386/kvm/tdx.c index 17e671f1710f..4172bbd23340 100644 --- a/target/i386/kvm/tdx.c +++ b/target/i386/kvm/tdx.c @@ -1026,7 +1026,9 @@ int tdx_pre_create_vcpu(CPUState *cpu, Error **errp) return -1; } if (data_len !=3D QCRYPTO_HASH_DIGEST_LEN_SHA384) { - error_setg(errp, "TDX: failed to decode mrconfigid"); + error_setg(errp, "TDX 'mrconfigid' sha384 digest was %ld bytes= , " + "expected %d bytes", data_len, + QCRYPTO_HASH_DIGEST_LEN_SHA384); return -1; } memcpy(init_vm->mrconfigid, data, data_len); @@ -1039,7 +1041,9 @@ int tdx_pre_create_vcpu(CPUState *cpu, Error **errp) return -1; } if (data_len !=3D QCRYPTO_HASH_DIGEST_LEN_SHA384) { - error_setg(errp, "TDX: failed to decode mrowner"); + error_setg(errp, "TDX 'mrowner' sha384 digest was %ld bytes, " + "expected %d bytes", data_len, + QCRYPTO_HASH_DIGEST_LEN_SHA384); return -1; } memcpy(init_vm->mrowner, data, data_len); @@ -1052,7 +1056,9 @@ int tdx_pre_create_vcpu(CPUState *cpu, Error **errp) return -1; } if (data_len !=3D QCRYPTO_HASH_DIGEST_LEN_SHA384) { - error_setg(errp, "TDX: failed to decode mrownerconfig"); + error_setg(errp, "TDX 'mrownerconfig' sha384 digest was %ld by= tes, " + "expected %d bytes", data_len, + QCRYPTO_HASH_DIGEST_LEN_SHA384); return -1; } memcpy(init_vm->mrownerconfig, data, data_len); --=20 2.43.0