From nobody Sat Nov 15 19:32:08 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1748801632; cv=none; d=zohomail.com; s=zohoarc; b=G7GpjLzsrCen8vIaLYpgOpWNN6go2FPfWFEfgyblW9r1bFWZ1pmWQYDmFFIywSu3aaPS0BhXB1nYpkmMpm3RFijAfKN8qpdI5j2svrgmt3E2oI5Sl6WYYF9ziV9G8YOkEMURQoZTW4Hi8jdlOTNNXNv1f0e1pttduOueu+ZOfYs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1748801632; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=3WBLhmVUNFmmWr7iWGyD+QREshlRfuZn9YAw+EwxcsE=; b=mSuMRvFqhv7Rhy3zmSt9lx2bBdqqkxEJwpS5yTZXNH3q5Oz9K4kkc3tJCki45EOO1EMje2d/avfVWPGdF8scT7bA5jbK01xczZocFfJHgbZYVfyVBtKhfpDFv6999MweKUtWFNpf5ORsTbWg4HuVYfy+oT+K/O/GZIGsZtGR6NY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1748801632150328.65215017905587; Sun, 1 Jun 2025 11:13:52 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uLnAu-00021Y-QN; Sun, 01 Jun 2025 14:12:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uLnAt-00021I-CU for qemu-devel@nongnu.org; Sun, 01 Jun 2025 14:12:47 -0400 Received: from mail-pf1-x42f.google.com ([2607:f8b0:4864:20::42f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uLnAr-0002ow-RA for qemu-devel@nongnu.org; Sun, 01 Jun 2025 14:12:47 -0400 Received: by mail-pf1-x42f.google.com with SMTP id d2e1a72fcca58-742c9563fd9so2935045b3a.3 for ; Sun, 01 Jun 2025 11:12:45 -0700 (PDT) Received: from ubuntu.. ([49.207.58.139]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-747afed4bafsm6189191b3a.79.2025.06.01.11.12.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 01 Jun 2025 11:12:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1748801564; x=1749406364; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=3WBLhmVUNFmmWr7iWGyD+QREshlRfuZn9YAw+EwxcsE=; b=lpMXUTP+2r/dBFp6QuWzwZK895DPgXVBXaT7Eb+nKjdcqZI3WCYWbrZoFrH/50KJ2U G++tfRcBZEIWPLwPKbPttThbf+63AQ5128LHql1yVCQeEWORs9wLkutW1Prs+WcP5ka7 2/VjmGRRumdJPf+7HPTeDn1Ftedtd6JJvaVYIUxdlpeX8aC4c04uJjvSbn+Qin64T1oa 1A2afBg04AOt3yVL9ydrDDiNy8gtvlzHMnR3Srsr/RjfdDljHz4j8p4kXEE8HRNfC6jc kvON1cqhE9NqFEX+k4DbVzqXac+U7P3JDfRooiPEZTIy+f7KyDl/Ofh1yJIclap+Ld+U eCFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748801564; x=1749406364; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3WBLhmVUNFmmWr7iWGyD+QREshlRfuZn9YAw+EwxcsE=; b=bq62lItsJyFBR4fDlX/eL1hjDeJLDwVrGyzOq/VzKk4+2FQYIUmyUVnnc9QN34JG+y aUDBaeGCiVoF8IMv3+89E3K3LeUO3WaEAEq4LGBwCd0I+GfJyfcIpnJI7eid5u3xtqYF 2kQ/r+tAV7Ws5P9NaqRozBDIDw5WEan9guzxmCgvunTHA153kbq43Zip2ACn5sjDiPbK 8hYWqRkZ8AJOcVbS982pnKLaNW2x84Kcz8uKmzRhvJ7RX+ZuwCgdRarDAegjy/m9nDq1 32cS/LuBPsQYC3gx/FzUyjcTubBigXCYIpcuazlFBqgv9Nb+pHicg8DsysrJh7OjRuJ1 VdrQ== X-Gm-Message-State: AOJu0YxhnF70Pb3ID2owbNu1fxE2VDXT3DMZW2fvVpLZzCahkIkuWgGv I4tkNUr//NDpu38Ii/Q/jPdUsPCtD2p1p4XvcYJdobXMmmRlI5WMVFg5IH/zmVEp6pZM4w== X-Gm-Gg: ASbGncvphJViFHAZv0GbI48HLCNcai+BQYHIQNDeksru6zzlthGEblg/lDpt9uU6Bno y8eSHmXi2xJBigXsSB4SnIf1UJzDjhZQn9tsGaFVHUM6B6NFz+hUuzGIkx9athj+QsBlGEBPjtB Ma6kHPDoQnrolnFSnRrCEn9ozRO0bTYCN6epsv/qFxOtXx2ctlr97DGjd/28mJFZP3qi8Fd+l1d pt/xSoOZSb9wr3Zsj63o5pKcmy4JhuHGRi8HssxoXO0NkDMQBQE3NWV0GxGhrXTyFAeInf4PxwT x1NEsiitFoU+gImVe5+7G4eA9zc9+iDaDXYTXyAa5EXvTRYks2mO5Qa38G/7Zw== X-Google-Smtp-Source: AGHT+IGJ8LcEKExYmpW+rhMh2S/WK9qeFiecSO5i3z+vg1zitqHFCfw5LMF1q134xtjoCedPAGbqDQ== X-Received: by 2002:a05:6a00:a27:b0:736:5438:ccc with SMTP id d2e1a72fcca58-747c1a83bd3mr13717140b3a.9.1748801563981; Sun, 01 Jun 2025 11:12:43 -0700 (PDT) From: Tanish Desai To: qemu-devel@nongnu.org Cc: Stefan Hajnoczi , pbonzini@redhat.com, Mads Ynddal , Tanish Desai Subject: [PATCH 3/3] trace/log: seperate cold path of tracing functions Date: Sun, 1 Jun 2025 18:12:31 +0000 Message-Id: <20250601181231.3461-4-tanishdesai37@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250601181231.3461-1-tanishdesai37@gmail.com> References: <20250601181231.3461-1-tanishdesai37@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::42f; envelope-from=tanishdesai37@gmail.com; helo=mail-pf1-x42f.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1748801633348116600 Content-Type: text/plain; charset="utf-8" Moved frequently used hot paths from the .c file to the .h file to enable i= nlining and improve performance. This approach is inspired by past QEMU optimizatio= ns, where performance-critical code was inlined based on profiling results. Signed-off-by: Tanish Desai --- scripts/tracetool/backend/log.py | 26 ++++++++++++++++++++++++-- 1 file changed, 24 insertions(+), 2 deletions(-) diff --git a/scripts/tracetool/backend/log.py b/scripts/tracetool/backend/l= og.py index de27b7e62e..ca53747950 100644 --- a/scripts/tracetool/backend/log.py +++ b/scripts/tracetool/backend/log.py @@ -24,6 +24,10 @@ def generate_h_begin(events, group): out('#include "qemu/log-for-trace.h"', '#include "qemu/error-report.h"', '') + for event in events: + out('void _log_%(api)s(%(args)s);', + api=3Devent.api(), + args=3Devent.args) =20 =20 def generate_h(event, group): @@ -38,6 +42,22 @@ def generate_h(event, group): cond =3D "trace_event_get_state(%s)" % ("TRACE_" + event.name.uppe= r()) =20 out(' if (%(cond)s && qemu_loglevel_mask(LOG_TRACE)) {', + ' _log_%(api)s(%(args)s);', + ' }', + cond=3Dcond, + event_lineno=3Devent.lineno, + event_filename=3Dos.path.relpath(event.filename), + name=3Devent.name, + fmt=3Devent.fmt.rstrip("\n"), + argnames=3Dargnames, + args =3D ", ".join(event.args.names()), + api=3Devent.api()) + +def generate_c(event, group): + argnames =3D ", ".join(event.args.names()) + if len(event.args) > 0: + argnames =3D ", " + argnames + out('void _log_%(api)s(%(args)s){', ' if (message_with_timestamp) {', ' struct timeval _now;', ' gettimeofday(&_now, NULL);', @@ -53,12 +73,14 @@ def generate_h(event, group): '#line %(out_next_lineno)d "%(out_filename)s"', ' }', ' }', - cond=3Dcond, event_lineno=3Devent.lineno, event_filename=3Dos.path.relpath(event.filename), name=3Devent.name, fmt=3Devent.fmt.rstrip("\n"), - argnames=3Dargnames) + argnames=3Dargnames, + args=3Devent.args, + api=3Devent.api() + ) =20 =20 def generate_h_backend_dstate(event, group): --=20 2.34.1