From nobody Sat Nov 15 19:32:08 2025 Delivered-To: importer@patchew.org Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=gmail.com ARC-Seal: i=1; a=rsa-sha256; t=1748801617; cv=none; d=zohomail.com; s=zohoarc; b=Qs36MExXSPOz596a0bdc72hs8yCDrnUkZWz7jfcduTBb0QiB1gJ4cr49Mp5JZVOI3q4Atrw4QdQZ8z9Ms/qNo2PzndLmofAaRManpc2Mri9/YX5nCHZrwm4SFk80k/G71fqtLeuiWyiT+zvYzEMTnCSnGojLekB8LNr442P9NYw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1748801617; h=Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:Subject:To:To:Message-Id:Reply-To; bh=F26xt53SD7/0sbTj2mZq8Jxx7blMqx6sb10y95AoeDI=; b=OcR8Fg7MtidjDLTnS+EKC0Ur9wSNQ2Ut72TibKC30KTZc5J9CgwjquHZ+pXcD/bDoUpQ2FThxQN71fX8RpIi9821L25La+TR+P+keFZr35U5zMjttemuqfxgmN84dHWWK1OdY07AXAMwAA4ZB6BaoogFLMTJ9n2mXny3yXMH9Zk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1748801617541918.2111052017858; Sun, 1 Jun 2025 11:13:37 -0700 (PDT) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1uLnAq-00020o-OZ; Sun, 01 Jun 2025 14:12:44 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1uLnAo-00020G-Qq for qemu-devel@nongnu.org; Sun, 01 Jun 2025 14:12:42 -0400 Received: from mail-pf1-x42a.google.com ([2607:f8b0:4864:20::42a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1uLnAm-0002oT-Vg for qemu-devel@nongnu.org; Sun, 01 Jun 2025 14:12:42 -0400 Received: by mail-pf1-x42a.google.com with SMTP id d2e1a72fcca58-742af848148so2321613b3a.1 for ; Sun, 01 Jun 2025 11:12:40 -0700 (PDT) Received: from ubuntu.. ([49.207.58.139]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-747afed4bafsm6189191b3a.79.2025.06.01.11.12.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 01 Jun 2025 11:12:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1748801559; x=1749406359; darn=nongnu.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=F26xt53SD7/0sbTj2mZq8Jxx7blMqx6sb10y95AoeDI=; b=TnZ8EFU5INqjOsgEsnX8pej+pxw0hQoxMzv4RD6dEXxHt+a1pA1HPhxtJuUm3Vbhjj gI15W2OHy7E/A/FPf+wIzPKa3t/Wc7JYA5JTV7B2ig0oy7nS+m9xK1vSB8A4lylhBmGX kQZKiTcbBE+QbA71t0CiAfqq/o/GEdPH68T2a+jYzB/iBIBG8HKAyFLFpflgE7I9Bdb2 /T7HbhpUtm2wkjIjwZSomG4hk9ukav1nY+9DlR92u1huWJiS1ajRfYsKN0qFgSzzORiR C8vA4TBpPSmC2jH0fXDPs3RVF92yZnfz5nD1KGfU3Epxhxq+wJKNeH1manhMSj5coJWz BCrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748801559; x=1749406359; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=F26xt53SD7/0sbTj2mZq8Jxx7blMqx6sb10y95AoeDI=; b=G325E7YQcFwgTR+H+dwgpF3vmJeQ6AgP+P3A4KHG4QXWw4nIHq1US1OMo7H4MbPRvQ 9fN7W28OT1b4LgcsMIrr2ozrD7Q9bnDCV7t1QsozLkK81zyTlX1zQp8LHhCOkhGxwpeO IGVyA2wAPoxj4lsHCpV5Dt/VX7zRsrD7ZT3W+ci2a9USN0slwuAgAXYGYKO7CQMhLaa1 lPSCmULSJyeFGqcH+00Dj/umsPZPA2qvnKrKfK/L6JxEn1JIktOM/+0JYhbSAShdL2tP j4BB+CuIY3X8wY1jqdNxHiOfgHg//Vg4/rAUm2JEXWJzifsK+b9QLFUy5cx72pj5y8M+ tPLQ== X-Gm-Message-State: AOJu0YyJrE/eyzjpVW9ZMYyA+e1jQUk3HbSdzc1+gcG/L825Eb5gVxVd ishpztNGk9w9J89AGhYOIAzkVeSc5+4y86eMLBop1/G04yYQwJuk1wvTEtPtxwJw38AmjA== X-Gm-Gg: ASbGncs3DjIU9O1G8giAF0AL4jqZnplsM18aMI7AZ7tCGFJLD683Klpn5MvKeAuKS4q TljbrZ386gT5KN9xttgMSEWI0lAgHrvOq4+nLLenRu7TqjZfKRnxppIsbzuG6lSv1ipa1VMwGZ3 Gq5YGMkctaDFL5gu7qqtlDGM4MW8xCBG3HlOOnxirqnfUezalSVxii70AFmrmTpFNrpQzf1jgm6 1mdBIffe0OwUpxj/EApPuzDte/wx2t4TBa9jlTUR7CkK/DovK70whEOLeBB2YKEQdAn6kNg+D2x Y+DVVFAjuqteaKZqjk1tCJqdBCj/rk0euQJumh/P6R80sJt7aipfIoNpk2ooreCxHxgofjvy X-Google-Smtp-Source: AGHT+IEARA6o8RXWdPby4uob9Hz1e7h4596ZzlNaG4nb3dimZZjdSEFafMqNoSoUTOjfIdqSl/W5tg== X-Received: by 2002:a05:6a00:4b13:b0:73f:ff25:90b3 with SMTP id d2e1a72fcca58-747d1ae2c64mr8818577b3a.24.1748801559076; Sun, 01 Jun 2025 11:12:39 -0700 (PDT) From: Tanish Desai To: qemu-devel@nongnu.org Cc: Stefan Hajnoczi , pbonzini@redhat.com, Mads Ynddal , Tanish Desai Subject: [PATCH 1/3] trace/syslog: seperate cold paths of tracing functions Date: Sun, 1 Jun 2025 18:12:29 +0000 Message-Id: <20250601181231.3461-2-tanishdesai37@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20250601181231.3461-1-tanishdesai37@gmail.com> References: <20250601181231.3461-1-tanishdesai37@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Received-SPF: pass client-ip=2607:f8b0:4864:20::42a; envelope-from=tanishdesai37@gmail.com; helo=mail-pf1-x42a.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: qemu-devel-bounces+importer=patchew.org@nongnu.org X-ZohoMail-DKIM: pass (identity @gmail.com) X-ZM-MESSAGEID: 1748801618800116600 Content-Type: text/plain; charset="utf-8" inline: move hot paths from .c to .h for better performance Moved frequently used hot paths from the .c file to the .h file to enable i= nlining and improve performance. This approach is inspired by past QEMU optimizatio= ns, where performance-critical code was inlined based on profiling results. Signed-off-by: Tanish Desai --- scripts/tracetool/backend/syslog.py | 36 +++++++++++++++++++++++------ 1 file changed, 29 insertions(+), 7 deletions(-) diff --git a/scripts/tracetool/backend/syslog.py b/scripts/tracetool/backen= d/syslog.py index 012970f6cc..52b8ff65ea 100644 --- a/scripts/tracetool/backend/syslog.py +++ b/scripts/tracetool/backend/syslog.py @@ -21,8 +21,12 @@ =20 =20 def generate_h_begin(events, group): - out('#include ', - '') + out('#include ') + for event in events: + out('void _syslog_%(api)s(%(args)s);', + api=3Devent.api(), + args=3Devent.args) + out('') =20 =20 def generate_h(event, group): @@ -37,17 +41,35 @@ def generate_h(event, group): cond =3D "trace_event_get_state(%s)" % ("TRACE_" + event.name.uppe= r()) =20 out(' if (%(cond)s) {', - '#line %(event_lineno)d "%(event_filename)s"', - ' syslog(LOG_INFO, "%(name)s " %(fmt)s %(argnames)s);', - '#line %(out_next_lineno)d "%(out_filename)s"', + ' _syslog_%(api)s(%(args)s);', ' }', cond=3Dcond, event_lineno=3Devent.lineno, event_filename=3Dos.path.relpath(event.filename), name=3Devent.name, fmt=3Devent.fmt.rstrip("\n"), - argnames=3Dargnames) - + argnames=3Dargnames, + api=3Devent.api(), + args=3D", ".join(event.args.names())) + + +def generate_c(event, group): + argnames =3D ", ".join(event.args.names()) + if len(event.args) > 0: + argnames =3D ", " + argnames + out('void _syslog_%(api)s(%(args)s){', + ' #line %(event_lineno)d "%(event_filename)s"', + ' syslog(LOG_INFO, "%(name)s " %(fmt)s %(argnames)s);', + ' #line %(out_next_lineno)d "%(out_filename)s"', + '}', + '', + event_lineno=3Devent.lineno, + event_filename=3Dos.path.relpath(event.filename), + name=3Devent.name, + fmt=3Devent.fmt.rstrip("\n"), + argnames=3Dargnames, + api=3Devent.api(), + args=3Devent.args) =20 =20 def generate_h_backend_dstate(event, group): out(' trace_event_get_state_dynamic_by_id(%(event_id)s) || \\', --=20 2.34.1